migration_test.rb 30.9 KB
Newer Older
1
require "cases/helper"
2
require "cases/migration/helper"
3 4
require 'bigdecimal/util'

J
Jeremy Kemper 已提交
5 6
require 'models/person'
require 'models/topic'
7
require 'models/developer'
8 9

require MIGRATIONS_ROOT + "/valid/2_we_need_reminders"
10 11
require MIGRATIONS_ROOT + "/rename/1_we_need_things"
require MIGRATIONS_ROOT + "/rename/2_rename_things"
12
require MIGRATIONS_ROOT + "/decimal/1_give_me_big_numbers"
13

14
class BigNumber < ActiveRecord::Base
15
  unless current_adapter?(:PostgreSQLAdapter, :SQLite3Adapter)
S
Sean Griffin 已提交
16
    attribute :value_of_e, Type::Integer.new
17
  end
S
Sean Griffin 已提交
18 19
  attribute :world_population, Type::Integer.new
  attribute :my_house_population, Type::Integer.new
20
end
21

22
class Reminder < ActiveRecord::Base; end
23

24
class Thing < ActiveRecord::Base; end
25

26 27
class MigrationTest < ActiveRecord::TestCase
  self.use_transactional_fixtures = false
28

29
  fixtures :people
30

31 32
  def setup
    super
A
Akira Matsuda 已提交
33
    %w(reminders people_reminders prefix_reminders_suffix p_things_s).each do |table|
A
Aaron Patterson 已提交
34 35 36
      Reminder.connection.drop_table(table) rescue nil
    end
    Reminder.reset_column_information
37 38
    ActiveRecord::Migration.verbose = true
    ActiveRecord::Migration.message_count = 0
A
Akira Matsuda 已提交
39
    ActiveRecord::Base.connection.schema_cache.clear!
40
  end
41

G
Guo Xiang Tan 已提交
42
  teardown do
43 44 45
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""

46 47
    ActiveRecord::Base.connection.initialize_schema_migrations_table
    ActiveRecord::Base.connection.execute "DELETE FROM #{ActiveRecord::Migrator.schema_migrations_table_name}"
48

49
    %w(things awesome_things prefix_things_suffix p_awesome_things_s ).each do |table|
50
      Thing.connection.drop_table(table) rescue nil
51
    end
52
    Thing.reset_column_information
53

54 55 56
    %w(reminders people_reminders prefix_reminders_suffix).each do |table|
      Reminder.connection.drop_table(table) rescue nil
    end
57
    Reminder.reset_table_name
58
    Reminder.reset_column_information
59

60 61 62 63 64 65 66 67 68
    %w(last_name key bio age height wealth birthday favorite_day
       moment_of_truth male administrator funny).each do |column|
      Person.connection.remove_column('people', column) rescue nil
    end
    Person.connection.remove_column("people", "first_name") rescue nil
    Person.connection.remove_column("people", "middle_name") rescue nil
    Person.connection.add_column("people", "first_name", :string, :limit => 40)
    Person.reset_column_information
  end
69

70 71
  def test_migrator_versions
    migrations_path = MIGRATIONS_ROOT + "/valid"
72
    old_path = ActiveRecord::Migrator.migrations_paths
73 74 75 76 77
    ActiveRecord::Migrator.migrations_paths = migrations_path

    ActiveRecord::Migrator.up(migrations_path)
    assert_equal 3, ActiveRecord::Migrator.current_version
    assert_equal 3, ActiveRecord::Migrator.last_version
78
    assert_equal false, ActiveRecord::Migrator.needs_migration?
79 80 81 82

    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid")
    assert_equal 0, ActiveRecord::Migrator.current_version
    assert_equal 3, ActiveRecord::Migrator.last_version
83
    assert_equal true, ActiveRecord::Migrator.needs_migration?
84 85
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
86 87
  end

88 89 90 91
  def test_migration_version
    ActiveRecord::Migrator.run(:up, MIGRATIONS_ROOT + "/version_check", 20131219224947)
  end

92 93 94
  def test_create_table_with_force_true_does_not_drop_nonexisting_table
    if Person.connection.table_exists?(:testings2)
      Person.connection.drop_table :testings2
95 96
    end

97 98 99
    # using a copy as we need the drop_table method to
    # continue to work for the ensure block of the test
    temp_conn = Person.connection.dup
100 101 102

    assert_not_equal temp_conn, Person.connection

103 104
    temp_conn.create_table :testings2, :force => true do |t|
      t.column :foo, :string
105
    end
106 107 108
  ensure
    Person.connection.drop_table :testings2 rescue nil
  end
109

110 111 112
  def connection
    ActiveRecord::Base.connection
  end
113

114 115 116 117
  def test_migration_instance_has_connection
    migration = Class.new(ActiveRecord::Migration).new
    assert_equal connection, migration.connection
  end
118

119 120 121 122 123 124 125 126
  def test_method_missing_delegates_to_connection
    migration = Class.new(ActiveRecord::Migration) {
      def connection
        Class.new {
          def create_table; "hi mom!"; end
        }.new
      end
    }.new
127

128
    assert_equal "hi mom!", migration.method_missing(:create_table)
129
  end
130

131 132 133 134 135 136 137 138 139 140 141 142 143 144
  def test_add_table_with_decimals
    Person.connection.drop_table :big_numbers rescue nil

    assert !BigNumber.table_exists?
    GiveMeBigNumbers.up

    assert BigNumber.create(
      :bank_balance => 1586.43,
      :big_bank_balance => BigDecimal("1000234000567.95"),
      :world_population => 6000000000,
      :my_house_population => 3,
      :value_of_e => BigDecimal("2.7182818284590452353602875")
    )

145
    b = BigNumber.first
146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188
    assert_not_nil b

    assert_not_nil b.bank_balance
    assert_not_nil b.big_bank_balance
    assert_not_nil b.world_population
    assert_not_nil b.my_house_population
    assert_not_nil b.value_of_e

    # TODO: set world_population >= 2**62 to cover 64-bit platforms and test
    # is_a?(Bignum)
    assert_kind_of Integer, b.world_population
    assert_equal 6000000000, b.world_population
    assert_kind_of Fixnum, b.my_house_population
    assert_equal 3, b.my_house_population
    assert_kind_of BigDecimal, b.bank_balance
    assert_equal BigDecimal("1586.43"), b.bank_balance
    assert_kind_of BigDecimal, b.big_bank_balance
    assert_equal BigDecimal("1000234000567.95"), b.big_bank_balance

    # This one is fun. The 'value_of_e' field is defined as 'DECIMAL' with
    # precision/scale explicitly left out.  By the SQL standard, numbers
    # assigned to this field should be truncated but that's seldom respected.
    if current_adapter?(:PostgreSQLAdapter)
      # - PostgreSQL changes the SQL spec on columns declared simply as
      # "decimal" to something more useful: instead of being given a scale
      # of 0, they take on the compile-time limit for precision and scale,
      # so the following should succeed unless you have used really wacky
      # compilation options
      # - SQLite2 has the default behavior of preserving all data sent in,
      # so this happens there too
      assert_kind_of BigDecimal, b.value_of_e
      assert_equal BigDecimal("2.7182818284590452353602875"), b.value_of_e
    elsif current_adapter?(:SQLite3Adapter)
      # - SQLite3 stores a float, in violation of SQL
      assert_kind_of BigDecimal, b.value_of_e
      assert_in_delta BigDecimal("2.71828182845905"), b.value_of_e, 0.00000000000001
    else
      # - SQL standard is an integer
      assert_kind_of Fixnum, b.value_of_e
      assert_equal 2, b.value_of_e
    end

    GiveMeBigNumbers.down
189
    assert_raise(ActiveRecord::StatementInvalid) { BigNumber.first }
190
  end
191

192
  def test_filtering_migrations
193
    assert_no_column Person, :last_name
194
    assert !Reminder.table_exists?
195

196 197
    name_filter = lambda { |migration| migration.name == "ValidPeopleHaveLastNames" }
    ActiveRecord::Migrator.up(MIGRATIONS_ROOT + "/valid", &name_filter)
198

199
    assert_column Person, :last_name
200
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
201

202 203
    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid", &name_filter)

204
    assert_no_column Person, :last_name
205
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
206 207 208 209 210 211 212
  end

  class MockMigration < ActiveRecord::Migration
    attr_reader :went_up, :went_down
    def initialize
      @went_up   = false
      @went_down = false
213 214
    end

215 216 217 218
    def up
      @went_up = true
      super
    end
219

220 221 222
    def down
      @went_down = true
      super
223
    end
224
  end
225

226 227 228 229
  def test_instance_based_migration_up
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
230

231 232 233 234
    migration.migrate :up
    assert migration.went_up, 'have gone up'
    assert !migration.went_down, 'have not gone down'
  end
235

236 237 238 239
  def test_instance_based_migration_down
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
240

241 242 243 244
    migration.migrate :down
    assert !migration.went_up, 'have gone up'
    assert migration.went_down, 'have not gone down'
  end
245

246 247 248 249 250 251 252 253 254 255 256
  if ActiveRecord::Base.connection.supports_ddl_transactions?
    def test_migrator_one_up_with_exception_and_rollback
      assert_no_column Person, :last_name

      migration = Class.new(ActiveRecord::Migration) {
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
257

258
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
259

260
      e = assert_raise(StandardError) { migrator.migrate }
261

262
      assert_equal "An error has occurred, this and all later migrations canceled:\n\nSomething broke", e.message
263

264 265
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
B
bondarev 已提交
266 267
    end

268 269
    def test_migrator_one_up_with_exception_and_rollback_using_run
      assert_no_column Person, :last_name
B
bondarev 已提交
270

271 272 273 274 275 276 277
      migration = Class.new(ActiveRecord::Migration) {
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
B
bondarev 已提交
278

279
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
B
bondarev 已提交
280

281
      e = assert_raise(StandardError) { migrator.run }
B
bondarev 已提交
282

283
      assert_equal "An error has occurred, this migration was canceled:\n\nSomething broke", e.message
B
bondarev 已提交
284

285 286
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
287 288
    end

289 290
    def test_migration_without_transaction
      assert_no_column Person, :last_name
291

292 293
      migration = Class.new(ActiveRecord::Migration) {
        self.disable_ddl_transaction!
294

295 296 297 298 299 300
        def version; 101 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
301

302 303 304
      migrator = ActiveRecord::Migrator.new(:up, [migration], 101)
      e = assert_raise(StandardError) { migrator.migrate }
      assert_equal "An error has occurred, all later migrations canceled:\n\nSomething broke", e.message
305

306 307 308 309 310 311 312
      assert_column Person, :last_name,
        "without ddl transactions, the Migrator should not rollback on error but it did."
    ensure
      Person.reset_column_information
      if Person.column_names.include?('last_name')
        Person.connection.remove_column('people', 'last_name')
      end
313
    end
314
  end
315

316
  def test_schema_migrations_table_name
317 318 319
    original_schema_migrations_table_name = ActiveRecord::Migrator.schema_migrations_table_name

    assert_equal "schema_migrations", ActiveRecord::Migrator.schema_migrations_table_name
320 321 322 323
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
    Reminder.reset_table_name
    assert_equal "prefix_schema_migrations_suffix", ActiveRecord::Migrator.schema_migrations_table_name
324 325 326
    ActiveRecord::Base.schema_migrations_table_name = "changed"
    Reminder.reset_table_name
    assert_equal "prefix_changed_suffix", ActiveRecord::Migrator.schema_migrations_table_name
327 328 329
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""
    Reminder.reset_table_name
330 331 332 333
    assert_equal "changed", ActiveRecord::Migrator.schema_migrations_table_name
  ensure
    ActiveRecord::Base.schema_migrations_table_name = original_schema_migrations_table_name
    Reminder.reset_table_name
334 335
  end

336
  def test_proper_table_name_on_migration
337
    reminder_class = new_isolated_reminder_class
338 339 340
    migration = ActiveRecord::Migration.new
    assert_equal "table", migration.proper_table_name('table')
    assert_equal "table", migration.proper_table_name(:table)
341 342 343
    assert_equal "reminders", migration.proper_table_name(reminder_class)
    reminder_class.reset_table_name
    assert_equal reminder_class.table_name, migration.proper_table_name(reminder_class)
344 345 346 347

    # Use the model's own prefix/suffix if a model is given
    ActiveRecord::Base.table_name_prefix = "ARprefix_"
    ActiveRecord::Base.table_name_suffix = "_ARsuffix"
348 349 350 351 352 353 354
    reminder_class.table_name_prefix = 'prefix_'
    reminder_class.table_name_suffix = '_suffix'
    reminder_class.reset_table_name
    assert_equal "prefix_reminders_suffix", migration.proper_table_name(reminder_class)
    reminder_class.table_name_prefix = ''
    reminder_class.table_name_suffix = ''
    reminder_class.reset_table_name
355 356 357 358

    # Use AR::Base's prefix/suffix if string or symbol is given
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
359
    reminder_class.reset_table_name
360 361 362 363
    assert_equal "prefix_table_suffix", migration.proper_table_name('table', migration.table_name_options)
    assert_equal "prefix_table_suffix", migration.proper_table_name(:table, migration.table_name_options)
  end

364 365
  def test_rename_table_with_prefix_and_suffix
    assert !Thing.table_exists?
366 367
    ActiveRecord::Base.table_name_prefix = 'p_'
    ActiveRecord::Base.table_name_suffix = '_s'
368 369 370 371 372
    Thing.reset_table_name
    Thing.reset_sequence_name
    WeNeedThings.up

    assert Thing.create("content" => "hello world")
373
    assert_equal "hello world", Thing.first.content
374 375

    RenameThings.up
376
    Thing.table_name = "p_awesome_things_s"
377

378
    assert_equal "hello world", Thing.first.content
379 380 381 382 383 384 385 386 387 388 389 390 391
  ensure
    Thing.reset_table_name
    Thing.reset_sequence_name
  end

  def test_add_drop_table_with_prefix_and_suffix
    assert !Reminder.table_exists?
    ActiveRecord::Base.table_name_prefix = 'prefix_'
    ActiveRecord::Base.table_name_suffix = '_suffix'
    Reminder.reset_table_name
    Reminder.reset_sequence_name
    WeNeedReminders.up
    assert Reminder.create("content" => "hello world", "remind_at" => Time.now)
392
    assert_equal "hello world", Reminder.first.content
393 394

    WeNeedReminders.down
395
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
396 397 398
  ensure
    Reminder.reset_sequence_name
  end
399

400 401
  def test_create_table_with_binary_column
    Person.connection.drop_table :binary_testings rescue nil
402

403 404
    assert_nothing_raised {
      Person.connection.create_table :binary_testings do |t|
405
        t.column "data", :binary, :null => false
406
      end
407 408 409 410
    }

    columns = Person.connection.columns(:binary_testings)
    data_column = columns.detect { |c| c.name == "data" }
411

J
Jon Leighton 已提交
412
    assert_nil data_column.default
413

414 415 416
    Person.connection.drop_table :binary_testings rescue nil
  end

417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442
  def test_create_table_with_query
    Person.connection.drop_table :table_from_query_testings rescue nil
    Person.connection.create_table(:person, force: true)

    Person.connection.create_table :table_from_query_testings, as: "SELECT id FROM person"

    columns = Person.connection.columns(:table_from_query_testings)
    assert_equal 1, columns.length
    assert_equal "id", columns.first.name

    Person.connection.drop_table :table_from_query_testings rescue nil
  end

  def test_create_table_with_query_from_relation
    Person.connection.drop_table :table_from_query_testings rescue nil
    Person.connection.create_table(:person, force: true)

    Person.connection.create_table :table_from_query_testings, as: Person.select(:id)

    columns = Person.connection.columns(:table_from_query_testings)
    assert_equal 1, columns.length
    assert_equal "id", columns.first.name

    Person.connection.drop_table :table_from_query_testings rescue nil
  end

443 444 445 446 447 448 449 450 451 452 453
  if current_adapter? :OracleAdapter
    def test_create_table_with_custom_sequence_name
      # table name is 29 chars, the standard sequence name will
      # be 33 chars and should be shortened
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok do |t|
            t.column :foo, :string, :null => false
          end
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok rescue nil
454 455 456
        end
      end

457 458 459 460 461 462 463
      # should be all good w/ a custom sequence name
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' do |t|
            t.column :foo, :string, :null => false
          end
464

465
          Person.connection.execute("select suitably_short_seq.nextval from dual")
466

467 468 469 470
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' rescue nil
        end
471 472
      end

473 474 475 476
      # confirm the custom sequence got dropped
      assert_raise(ActiveRecord::StatementInvalid) do
        Person.connection.execute("select suitably_short_seq.nextval from dual")
      end
477
    end
478
  end
479

480 481 482 483 484 485 486
  if current_adapter?(:MysqlAdapter, :Mysql2Adapter, :PostgreSQLAdapter)
    def test_out_of_range_limit_should_raise
      Person.connection.drop_table :test_limits rescue nil
      assert_raise(ActiveRecord::ActiveRecordError, "integer limit didn't raise") do
        Person.connection.create_table :test_integer_limits, :force => true do |t|
          t.column :bigone, :integer, :limit => 10
        end
487 488
      end

489 490 491 492 493
      unless current_adapter?(:PostgreSQLAdapter)
        assert_raise(ActiveRecord::ActiveRecordError, "text limit didn't raise") do
          Person.connection.create_table :test_text_limits, :force => true do |t|
            t.column :bigtext, :text, :limit => 0xfffffffff
          end
494 495 496
        end
      end

497 498
      Person.connection.drop_table :test_limits rescue nil
    end
499 500
  end

501
  protected
502 503 504 505 506 507 508 509
    # This is needed to isolate class_attribute assignments like `table_name_prefix`
    # for each test case.
    def new_isolated_reminder_class
      Class.new(Reminder) {
        def self.name; "Reminder"; end
        def self.base_class; self; end
      }
    end
510
end
511

512 513 514 515 516
class ReservedWordsMigrationTest < ActiveRecord::TestCase
  def test_drop_index_from_table_named_values
    connection = Person.connection
    connection.create_table :values, :force => true do |t|
      t.integer :value
517
    end
518

519 520 521
    assert_nothing_raised do
      connection.add_index :values, :value
      connection.remove_index :values, :column => :value
522
    end
523

524 525 526 527
    connection.drop_table :values rescue nil
  end
end

528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543
class ExplicitlyNamedIndexMigrationTest < ActiveRecord::TestCase
  def test_drop_index_by_name
    connection = Person.connection
    connection.create_table :values, force: true do |t|
      t.integer :value
    end

    assert_nothing_raised ArgumentError do
      connection.add_index :values, :value, name: 'a_different_name'
      connection.remove_index :values, column: :value, name: 'a_different_name'
    end

    connection.drop_table :values rescue nil
  end
end

544 545 546 547 548
if ActiveRecord::Base.connection.supports_bulk_alter?
  class BulkAlterTableMigrationsTest < ActiveRecord::TestCase
    def setup
      @connection = Person.connection
      @connection.create_table(:delete_me, :force => true) {|t| }
A
Akira Matsuda 已提交
549 550
      Person.reset_column_information
      Person.reset_sequence_name
551
    end
552

G
Guo Xiang Tan 已提交
553
    teardown do
554 555
      Person.connection.drop_table(:delete_me) rescue nil
    end
556

557 558
    def test_adding_multiple_columns
      assert_queries(1) do
559
        with_bulk_change_table do |t|
560
          t.column :name, :string
561
          t.string :qualification, :experience
562 563 564
          t.integer :age, :default => 0
          t.date :birthdate
          t.timestamps
565
        end
566
      end
567

568 569
      assert_equal 8, columns.size
      [:name, :qualification, :experience].each {|s| assert_equal :string, column(s).type }
570
      assert_equal '0', column(:age).default
571
    end
572

573 574 575
    def test_removing_columns
      with_bulk_change_table do |t|
        t.string :qualification, :experience
576 577
      end

578
      [:qualification, :experience].each {|c| assert column(c) }
579

580 581 582 583
      assert_queries(1) do
        with_bulk_change_table do |t|
          t.remove :qualification, :experience
          t.string :qualification_experience
584
        end
585
      end
586

587 588 589
      [:qualification, :experience].each {|c| assert ! column(c) }
      assert column(:qualification_experience)
    end
590

591 592 593 594 595
    def test_adding_indexes
      with_bulk_change_table do |t|
        t.string :username
        t.string :name
        t.integer :age
596 597
      end

598 599
      # Adding an index fires a query every time to check if an index already exists or not
      assert_queries(3) do
600
        with_bulk_change_table do |t|
601 602
          t.index :username, :unique => true, :name => :awesome_username_index
          t.index [:name, :age]
603
        end
604
      end
605

606
      assert_equal 2, indexes.size
607

608 609 610
      name_age_index = index(:index_delete_me_on_name_and_age)
      assert_equal ['name', 'age'].sort, name_age_index.columns.sort
      assert ! name_age_index.unique
611

612 613
      assert index(:awesome_username_index).unique
    end
614

615 616 617 618
    def test_removing_index
      with_bulk_change_table do |t|
        t.string :name
        t.index :name
619
      end
620

621 622 623
      assert index(:index_delete_me_on_name)

      assert_queries(3) do
624
        with_bulk_change_table do |t|
625 626
          t.remove_index :name
          t.index :name, :name => :new_name_index, :unique => true
627
        end
628
      end
629

630
      assert ! index(:index_delete_me_on_name)
631

632 633 634
      new_name_index = index(:new_name_index)
      assert new_name_index.unique
    end
635

636 637 638 639
    def test_changing_columns
      with_bulk_change_table do |t|
        t.string :name
        t.date :birthdate
640
      end
641

642 643
      assert ! column(:name).default
      assert_equal :date, column(:birthdate).type
644

645 646 647
      # One query for columns (delete_me table)
      # One query for primary key (delete_me table)
      # One query to do the bulk change
648
      assert_queries(3, :ignore_none => true) do
649 650 651
        with_bulk_change_table do |t|
          t.change :name, :string, :default => 'NONAME'
          t.change :birthdate, :datetime
652
        end
653 654
      end

655 656 657
      assert_equal 'NONAME', column(:name).default
      assert_equal :datetime, column(:birthdate).type
    end
658

659
    protected
660

661 662 663
    def with_bulk_change_table
      # Reset columns/indexes cache as we're changing the table
      @columns = @indexes = nil
664

665 666
      Person.connection.change_table(:delete_me, :bulk => true) do |t|
        yield t
667
      end
668
    end
669

670 671 672
    def column(name)
      columns.detect {|c| c.name == name.to_s }
    end
673

674 675
    def columns
      @columns ||= Person.connection.columns('delete_me')
676 677
    end

678 679
    def index(name)
      indexes.detect {|i| i.name == name.to_s }
680 681
    end

682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704
    def indexes
      @indexes ||= Person.connection.indexes('delete_me')
    end
  end # AlterTableMigrationsTest

end

class CopyMigrationsTest < ActiveRecord::TestCase
  def setup
  end

  def clear
    ActiveRecord::Base.timestamped_migrations = true
    to_delete = Dir[@migrations_path + "/*.rb"] - @existing_migrations
    File.delete(*to_delete)
  end

  def test_copying_migrations_without_timestamps
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
A
Arun Agrawal 已提交
705 706
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724
    assert_equal [@migrations_path + "/4_people_have_hobbies.bukkits.rb", @migrations_path + "/5_people_have_descriptions.bukkits.rb"], copied.map(&:filename)

    expected = "# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_people_have_hobbies.bukkits.rb")[0].chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

  def test_copying_migrations_without_timestamps_from_2_sources
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

725
    sources = {}
726 727 728
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy"
    sources[:omg] = MIGRATIONS_ROOT + "/to_copy2"
    ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
729 730 731 732
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
    assert File.exist?(@migrations_path + "/6_create_articles.omg.rb")
    assert File.exist?(@migrations_path + "/7_create_comments.omg.rb")
733 734 735 736 737 738 739

    files_count = Dir[@migrations_path + "/*.rb"].length
    ActiveRecord::Migration.copy(@migrations_path, sources)
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
  ensure
    clear
  end
740

741 742 743
  def test_copying_migrations_with_timestamps
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
744

745
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
746
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
747 748
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
749 750 751
      expected = [@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb",
                  @migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb"]
      assert_equal expected, copied.map(&:filename)
752

753
      files_count = Dir[@migrations_path + "/*.rb"].length
754
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
755 756 757
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
    end
758 759 760
  ensure
    clear
  end
761

762 763 764
  def test_copying_migrations_with_timestamps_from_2_sources
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
765

766
    sources = {}
767 768 769
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_timestamps2"

770
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
771
      copied = ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
772 773 774 775
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101012_create_articles.omg.rb")
      assert File.exist?(@migrations_path + "/20100726101013_create_comments.omg.rb")
776
      assert_equal 4, copied.length
777 778 779 780 781

      files_count = Dir[@migrations_path + "/*.rb"].length
      ActiveRecord::Migration.copy(@migrations_path, sources)
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    end
782 783 784
  ensure
    clear
  end
785

786 787 788
  def test_copying_migrations_with_timestamps_to_destination_with_timestamps_in_future
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
789

790
    travel_to(Time.utc(2010, 2, 20, 10, 10, 10)) do
791
      ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
792 793
      assert File.exist?(@migrations_path + "/20100301010102_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100301010103_people_have_descriptions.bukkits.rb")
794

795 796 797 798
      files_count = Dir[@migrations_path + "/*.rb"].length
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
799
    end
800 801 802
  ensure
    clear
  end
803

804 805 806 807 808 809
  def test_copying_migrations_preserving_magic_comments
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
A
Arun Agrawal 已提交
810
    assert File.exist?(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")
811 812 813 814 815 816 817 818 819 820 821 822 823
    assert_equal [@migrations_path + "/4_currencies_have_symbols.bukkits.rb"], copied.map(&:filename)

    expected = "# coding: ISO-8859-15\n# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")[0..1].join.chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

824 825 826
  def test_skipping_migrations
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
827 828

    sources = {}
829 830
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_name_collision"
831

832 833 834 835
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    assert_equal 2, copied.length
836

837 838 839 840 841
    assert_equal 1, skipped.length
    assert_equal ["omg PeopleHaveHobbies"], skipped
  ensure
    clear
  end
842

843 844 845
  def test_skip_is_not_called_if_migrations_are_from_the_same_plugin
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
846

847
    sources = {}
848
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
849

850 851 852 853
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
854

855 856 857 858 859
    assert_equal 2, copied.length
    assert_equal 0, skipped.length
  ensure
    clear
  end
860

861 862 863
  def test_copying_migrations_to_non_existing_directory
    @migrations_path = MIGRATIONS_ROOT + "/non_existing"
    @existing_migrations = []
864

865
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
866
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
867 868
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
869 870
      assert_equal 2, copied.length
    end
871 872 873 874
  ensure
    clear
    Dir.delete(@migrations_path)
  end
875

876 877 878
  def test_copying_migrations_to_empty_directory
    @migrations_path = MIGRATIONS_ROOT + "/empty"
    @existing_migrations = []
879

880
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
881
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
882 883
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
884
      assert_equal 2, copied.length
885
    end
886 887
  ensure
    clear
888
  end
889 890 891 892 893 894 895 896 897

  def test_check_pending_with_stdlib_logger
    old, ActiveRecord::Base.logger = ActiveRecord::Base.logger, ::Logger.new($stdout)
    quietly do
      assert_nothing_raised { ActiveRecord::Migration::CheckPending.new(Proc.new {}).call({}) }
    end
  ensure
    ActiveRecord::Base.logger = old
  end
898
end