migration_test.rb 31.7 KB
Newer Older
1
require "cases/helper"
2
require "cases/migration/helper"
3 4
require 'bigdecimal/util'

J
Jeremy Kemper 已提交
5 6
require 'models/person'
require 'models/topic'
7
require 'models/developer'
8 9

require MIGRATIONS_ROOT + "/valid/2_we_need_reminders"
10 11
require MIGRATIONS_ROOT + "/rename/1_we_need_things"
require MIGRATIONS_ROOT + "/rename/2_rename_things"
12
require MIGRATIONS_ROOT + "/decimal/1_give_me_big_numbers"
13

14
class BigNumber < ActiveRecord::Base
15
  unless current_adapter?(:PostgreSQLAdapter, :SQLite3Adapter)
S
Sean Griffin 已提交
16
    attribute :value_of_e, Type::Integer.new
17
  end
S
Sean Griffin 已提交
18
  attribute :my_house_population, Type::Integer.new
19
end
20

21
class Reminder < ActiveRecord::Base; end
22

23
class Thing < ActiveRecord::Base; end
24

25 26
class MigrationTest < ActiveRecord::TestCase
  self.use_transactional_fixtures = false
27

28
  fixtures :people
29

30 31
  def setup
    super
A
Akira Matsuda 已提交
32
    %w(reminders people_reminders prefix_reminders_suffix p_things_s).each do |table|
A
Aaron Patterson 已提交
33 34 35
      Reminder.connection.drop_table(table) rescue nil
    end
    Reminder.reset_column_information
36
    @verbose_was, ActiveRecord::Migration.verbose = ActiveRecord::Migration.verbose, false
A
Akira Matsuda 已提交
37
    ActiveRecord::Base.connection.schema_cache.clear!
38
  end
39

G
Guo Xiang Tan 已提交
40
  teardown do
41 42 43
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""

44 45
    ActiveRecord::Base.connection.initialize_schema_migrations_table
    ActiveRecord::Base.connection.execute "DELETE FROM #{ActiveRecord::Migrator.schema_migrations_table_name}"
46

47
    %w(things awesome_things prefix_things_suffix p_awesome_things_s ).each do |table|
48
      Thing.connection.drop_table(table) rescue nil
49
    end
50
    Thing.reset_column_information
51

52 53 54
    %w(reminders people_reminders prefix_reminders_suffix).each do |table|
      Reminder.connection.drop_table(table) rescue nil
    end
55
    Reminder.reset_table_name
56
    Reminder.reset_column_information
57

58 59 60 61 62 63
    %w(last_name key bio age height wealth birthday favorite_day
       moment_of_truth male administrator funny).each do |column|
      Person.connection.remove_column('people', column) rescue nil
    end
    Person.connection.remove_column("people", "first_name") rescue nil
    Person.connection.remove_column("people", "middle_name") rescue nil
64
    Person.connection.add_column("people", "first_name", :string)
65
    Person.reset_column_information
66 67

    ActiveRecord::Migration.verbose = @verbose_was
68
  end
69

70 71
  def test_migrator_versions
    migrations_path = MIGRATIONS_ROOT + "/valid"
72
    old_path = ActiveRecord::Migrator.migrations_paths
73 74 75 76 77
    ActiveRecord::Migrator.migrations_paths = migrations_path

    ActiveRecord::Migrator.up(migrations_path)
    assert_equal 3, ActiveRecord::Migrator.current_version
    assert_equal 3, ActiveRecord::Migrator.last_version
78
    assert_equal false, ActiveRecord::Migrator.needs_migration?
79 80 81 82

    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid")
    assert_equal 0, ActiveRecord::Migrator.current_version
    assert_equal 3, ActiveRecord::Migrator.last_version
83
    assert_equal true, ActiveRecord::Migrator.needs_migration?
84 85 86 87 88 89 90 91

    ActiveRecord::SchemaMigration.create!(:version => ActiveRecord::Migrator.last_version)
    assert_equal true, ActiveRecord::Migrator.needs_migration?
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
  end

  def test_migration_detection_without_schema_migration_table
92
    ActiveRecord::Base.connection.drop_table('schema_migrations') if ActiveRecord::Base.connection.table_exists?('schema_migrations')
93 94 95 96 97 98

    migrations_path = MIGRATIONS_ROOT + "/valid"
    old_path = ActiveRecord::Migrator.migrations_paths
    ActiveRecord::Migrator.migrations_paths = migrations_path

    assert_equal true, ActiveRecord::Migrator.needs_migration?
99 100
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
101 102
  end

103 104 105 106
  def test_migration_version
    ActiveRecord::Migrator.run(:up, MIGRATIONS_ROOT + "/version_check", 20131219224947)
  end

107 108 109
  def test_create_table_with_force_true_does_not_drop_nonexisting_table
    if Person.connection.table_exists?(:testings2)
      Person.connection.drop_table :testings2
110 111
    end

112 113 114
    # using a copy as we need the drop_table method to
    # continue to work for the ensure block of the test
    temp_conn = Person.connection.dup
115 116 117

    assert_not_equal temp_conn, Person.connection

118 119
    temp_conn.create_table :testings2, :force => true do |t|
      t.column :foo, :string
120
    end
121 122 123
  ensure
    Person.connection.drop_table :testings2 rescue nil
  end
124

125 126 127
  def connection
    ActiveRecord::Base.connection
  end
128

129 130 131 132
  def test_migration_instance_has_connection
    migration = Class.new(ActiveRecord::Migration).new
    assert_equal connection, migration.connection
  end
133

134 135 136 137 138 139 140 141
  def test_method_missing_delegates_to_connection
    migration = Class.new(ActiveRecord::Migration) {
      def connection
        Class.new {
          def create_table; "hi mom!"; end
        }.new
      end
    }.new
142

143
    assert_equal "hi mom!", migration.method_missing(:create_table)
144
  end
145

146 147 148 149 150 151 152 153 154 155 156 157 158 159
  def test_add_table_with_decimals
    Person.connection.drop_table :big_numbers rescue nil

    assert !BigNumber.table_exists?
    GiveMeBigNumbers.up

    assert BigNumber.create(
      :bank_balance => 1586.43,
      :big_bank_balance => BigDecimal("1000234000567.95"),
      :world_population => 6000000000,
      :my_house_population => 3,
      :value_of_e => BigDecimal("2.7182818284590452353602875")
    )

160
    b = BigNumber.first
161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203
    assert_not_nil b

    assert_not_nil b.bank_balance
    assert_not_nil b.big_bank_balance
    assert_not_nil b.world_population
    assert_not_nil b.my_house_population
    assert_not_nil b.value_of_e

    # TODO: set world_population >= 2**62 to cover 64-bit platforms and test
    # is_a?(Bignum)
    assert_kind_of Integer, b.world_population
    assert_equal 6000000000, b.world_population
    assert_kind_of Fixnum, b.my_house_population
    assert_equal 3, b.my_house_population
    assert_kind_of BigDecimal, b.bank_balance
    assert_equal BigDecimal("1586.43"), b.bank_balance
    assert_kind_of BigDecimal, b.big_bank_balance
    assert_equal BigDecimal("1000234000567.95"), b.big_bank_balance

    # This one is fun. The 'value_of_e' field is defined as 'DECIMAL' with
    # precision/scale explicitly left out.  By the SQL standard, numbers
    # assigned to this field should be truncated but that's seldom respected.
    if current_adapter?(:PostgreSQLAdapter)
      # - PostgreSQL changes the SQL spec on columns declared simply as
      # "decimal" to something more useful: instead of being given a scale
      # of 0, they take on the compile-time limit for precision and scale,
      # so the following should succeed unless you have used really wacky
      # compilation options
      # - SQLite2 has the default behavior of preserving all data sent in,
      # so this happens there too
      assert_kind_of BigDecimal, b.value_of_e
      assert_equal BigDecimal("2.7182818284590452353602875"), b.value_of_e
    elsif current_adapter?(:SQLite3Adapter)
      # - SQLite3 stores a float, in violation of SQL
      assert_kind_of BigDecimal, b.value_of_e
      assert_in_delta BigDecimal("2.71828182845905"), b.value_of_e, 0.00000000000001
    else
      # - SQL standard is an integer
      assert_kind_of Fixnum, b.value_of_e
      assert_equal 2, b.value_of_e
    end

    GiveMeBigNumbers.down
204
    assert_raise(ActiveRecord::StatementInvalid) { BigNumber.first }
205
  end
206

207
  def test_filtering_migrations
208
    assert_no_column Person, :last_name
209
    assert !Reminder.table_exists?
210

211 212
    name_filter = lambda { |migration| migration.name == "ValidPeopleHaveLastNames" }
    ActiveRecord::Migrator.up(MIGRATIONS_ROOT + "/valid", &name_filter)
213

214
    assert_column Person, :last_name
215
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
216

217 218
    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid", &name_filter)

219
    assert_no_column Person, :last_name
220
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
221 222 223 224 225 226 227
  end

  class MockMigration < ActiveRecord::Migration
    attr_reader :went_up, :went_down
    def initialize
      @went_up   = false
      @went_down = false
228 229
    end

230 231 232 233
    def up
      @went_up = true
      super
    end
234

235 236 237
    def down
      @went_down = true
      super
238
    end
239
  end
240

241 242 243 244
  def test_instance_based_migration_up
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
245

246 247 248 249
    migration.migrate :up
    assert migration.went_up, 'have gone up'
    assert !migration.went_down, 'have not gone down'
  end
250

251 252 253 254
  def test_instance_based_migration_down
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
255

256 257 258 259
    migration.migrate :down
    assert !migration.went_up, 'have gone up'
    assert migration.went_down, 'have not gone down'
  end
260

261 262 263 264 265 266 267 268 269 270 271
  if ActiveRecord::Base.connection.supports_ddl_transactions?
    def test_migrator_one_up_with_exception_and_rollback
      assert_no_column Person, :last_name

      migration = Class.new(ActiveRecord::Migration) {
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
272

273
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
274

275
      e = assert_raise(StandardError) { migrator.migrate }
276

277
      assert_equal "An error has occurred, this and all later migrations canceled:\n\nSomething broke", e.message
278

279 280
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
B
bondarev 已提交
281 282
    end

283 284
    def test_migrator_one_up_with_exception_and_rollback_using_run
      assert_no_column Person, :last_name
B
bondarev 已提交
285

286 287 288 289 290 291 292
      migration = Class.new(ActiveRecord::Migration) {
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
B
bondarev 已提交
293

294
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
B
bondarev 已提交
295

296
      e = assert_raise(StandardError) { migrator.run }
B
bondarev 已提交
297

298
      assert_equal "An error has occurred, this migration was canceled:\n\nSomething broke", e.message
B
bondarev 已提交
299

300 301
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
302 303
    end

304 305
    def test_migration_without_transaction
      assert_no_column Person, :last_name
306

307 308
      migration = Class.new(ActiveRecord::Migration) {
        self.disable_ddl_transaction!
309

310 311 312 313 314 315
        def version; 101 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
316

317 318 319
      migrator = ActiveRecord::Migrator.new(:up, [migration], 101)
      e = assert_raise(StandardError) { migrator.migrate }
      assert_equal "An error has occurred, all later migrations canceled:\n\nSomething broke", e.message
320

321 322 323 324 325 326 327
      assert_column Person, :last_name,
        "without ddl transactions, the Migrator should not rollback on error but it did."
    ensure
      Person.reset_column_information
      if Person.column_names.include?('last_name')
        Person.connection.remove_column('people', 'last_name')
      end
328
    end
329
  end
330

331
  def test_schema_migrations_table_name
332 333 334
    original_schema_migrations_table_name = ActiveRecord::Migrator.schema_migrations_table_name

    assert_equal "schema_migrations", ActiveRecord::Migrator.schema_migrations_table_name
335 336 337 338
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
    Reminder.reset_table_name
    assert_equal "prefix_schema_migrations_suffix", ActiveRecord::Migrator.schema_migrations_table_name
339 340 341
    ActiveRecord::Base.schema_migrations_table_name = "changed"
    Reminder.reset_table_name
    assert_equal "prefix_changed_suffix", ActiveRecord::Migrator.schema_migrations_table_name
342 343 344
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""
    Reminder.reset_table_name
345 346 347 348
    assert_equal "changed", ActiveRecord::Migrator.schema_migrations_table_name
  ensure
    ActiveRecord::Base.schema_migrations_table_name = original_schema_migrations_table_name
    Reminder.reset_table_name
349 350
  end

351
  def test_proper_table_name_on_migration
352
    reminder_class = new_isolated_reminder_class
353 354 355
    migration = ActiveRecord::Migration.new
    assert_equal "table", migration.proper_table_name('table')
    assert_equal "table", migration.proper_table_name(:table)
356 357 358
    assert_equal "reminders", migration.proper_table_name(reminder_class)
    reminder_class.reset_table_name
    assert_equal reminder_class.table_name, migration.proper_table_name(reminder_class)
359 360 361 362

    # Use the model's own prefix/suffix if a model is given
    ActiveRecord::Base.table_name_prefix = "ARprefix_"
    ActiveRecord::Base.table_name_suffix = "_ARsuffix"
363 364 365 366 367 368 369
    reminder_class.table_name_prefix = 'prefix_'
    reminder_class.table_name_suffix = '_suffix'
    reminder_class.reset_table_name
    assert_equal "prefix_reminders_suffix", migration.proper_table_name(reminder_class)
    reminder_class.table_name_prefix = ''
    reminder_class.table_name_suffix = ''
    reminder_class.reset_table_name
370 371 372 373

    # Use AR::Base's prefix/suffix if string or symbol is given
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
374
    reminder_class.reset_table_name
375 376 377 378
    assert_equal "prefix_table_suffix", migration.proper_table_name('table', migration.table_name_options)
    assert_equal "prefix_table_suffix", migration.proper_table_name(:table, migration.table_name_options)
  end

379 380
  def test_rename_table_with_prefix_and_suffix
    assert !Thing.table_exists?
381 382
    ActiveRecord::Base.table_name_prefix = 'p_'
    ActiveRecord::Base.table_name_suffix = '_s'
383 384 385 386 387
    Thing.reset_table_name
    Thing.reset_sequence_name
    WeNeedThings.up

    assert Thing.create("content" => "hello world")
388
    assert_equal "hello world", Thing.first.content
389 390

    RenameThings.up
391
    Thing.table_name = "p_awesome_things_s"
392

393
    assert_equal "hello world", Thing.first.content
394 395 396 397 398 399 400 401 402 403 404 405 406
  ensure
    Thing.reset_table_name
    Thing.reset_sequence_name
  end

  def test_add_drop_table_with_prefix_and_suffix
    assert !Reminder.table_exists?
    ActiveRecord::Base.table_name_prefix = 'prefix_'
    ActiveRecord::Base.table_name_suffix = '_suffix'
    Reminder.reset_table_name
    Reminder.reset_sequence_name
    WeNeedReminders.up
    assert Reminder.create("content" => "hello world", "remind_at" => Time.now)
407
    assert_equal "hello world", Reminder.first.content
408 409

    WeNeedReminders.down
410
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
411 412 413
  ensure
    Reminder.reset_sequence_name
  end
414

415 416
  def test_create_table_with_binary_column
    Person.connection.drop_table :binary_testings rescue nil
417

418 419
    assert_nothing_raised {
      Person.connection.create_table :binary_testings do |t|
420
        t.column "data", :binary, :null => false
421
      end
422 423 424 425
    }

    columns = Person.connection.columns(:binary_testings)
    data_column = columns.detect { |c| c.name == "data" }
426

J
Jon Leighton 已提交
427
    assert_nil data_column.default
428

429 430 431
    Person.connection.drop_table :binary_testings rescue nil
  end

432 433 434 435
  unless mysql_enforcing_gtid_consistency?
    def test_create_table_with_query
      Person.connection.drop_table :table_from_query_testings rescue nil
      Person.connection.create_table(:person, force: true)
436

437
      Person.connection.create_table :table_from_query_testings, as: "SELECT id FROM person"
438

439 440 441
      columns = Person.connection.columns(:table_from_query_testings)
      assert_equal 1, columns.length
      assert_equal "id", columns.first.name
442

443 444
      Person.connection.drop_table :table_from_query_testings rescue nil
    end
445

446 447 448
    def test_create_table_with_query_from_relation
      Person.connection.drop_table :table_from_query_testings rescue nil
      Person.connection.create_table(:person, force: true)
449

450
      Person.connection.create_table :table_from_query_testings, as: Person.select(:id)
451

452 453 454
      columns = Person.connection.columns(:table_from_query_testings)
      assert_equal 1, columns.length
      assert_equal "id", columns.first.name
455

456 457
      Person.connection.drop_table :table_from_query_testings rescue nil
    end
458 459
  end

460 461 462 463 464 465 466 467 468 469 470
  if current_adapter? :OracleAdapter
    def test_create_table_with_custom_sequence_name
      # table name is 29 chars, the standard sequence name will
      # be 33 chars and should be shortened
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok do |t|
            t.column :foo, :string, :null => false
          end
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok rescue nil
471 472 473
        end
      end

474 475 476 477 478 479 480
      # should be all good w/ a custom sequence name
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' do |t|
            t.column :foo, :string, :null => false
          end
481

482
          Person.connection.execute("select suitably_short_seq.nextval from dual")
483

484 485 486 487
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' rescue nil
        end
488 489
      end

490 491 492 493
      # confirm the custom sequence got dropped
      assert_raise(ActiveRecord::StatementInvalid) do
        Person.connection.execute("select suitably_short_seq.nextval from dual")
      end
494
    end
495
  end
496

497 498 499 500 501 502 503
  if current_adapter?(:MysqlAdapter, :Mysql2Adapter, :PostgreSQLAdapter)
    def test_out_of_range_limit_should_raise
      Person.connection.drop_table :test_limits rescue nil
      assert_raise(ActiveRecord::ActiveRecordError, "integer limit didn't raise") do
        Person.connection.create_table :test_integer_limits, :force => true do |t|
          t.column :bigone, :integer, :limit => 10
        end
504 505
      end

506 507 508 509 510
      unless current_adapter?(:PostgreSQLAdapter)
        assert_raise(ActiveRecord::ActiveRecordError, "text limit didn't raise") do
          Person.connection.create_table :test_text_limits, :force => true do |t|
            t.column :bigtext, :text, :limit => 0xfffffffff
          end
511 512 513
        end
      end

514 515
      Person.connection.drop_table :test_limits rescue nil
    end
516 517
  end

518
  protected
519 520 521 522 523 524 525 526
    # This is needed to isolate class_attribute assignments like `table_name_prefix`
    # for each test case.
    def new_isolated_reminder_class
      Class.new(Reminder) {
        def self.name; "Reminder"; end
        def self.base_class; self; end
      }
    end
527
end
528

529 530 531 532 533
class ReservedWordsMigrationTest < ActiveRecord::TestCase
  def test_drop_index_from_table_named_values
    connection = Person.connection
    connection.create_table :values, :force => true do |t|
      t.integer :value
534
    end
535

536 537 538
    assert_nothing_raised do
      connection.add_index :values, :value
      connection.remove_index :values, :column => :value
539
    end
540

541 542 543 544
    connection.drop_table :values rescue nil
  end
end

545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560
class ExplicitlyNamedIndexMigrationTest < ActiveRecord::TestCase
  def test_drop_index_by_name
    connection = Person.connection
    connection.create_table :values, force: true do |t|
      t.integer :value
    end

    assert_nothing_raised ArgumentError do
      connection.add_index :values, :value, name: 'a_different_name'
      connection.remove_index :values, column: :value, name: 'a_different_name'
    end

    connection.drop_table :values rescue nil
  end
end

561 562 563 564 565
if ActiveRecord::Base.connection.supports_bulk_alter?
  class BulkAlterTableMigrationsTest < ActiveRecord::TestCase
    def setup
      @connection = Person.connection
      @connection.create_table(:delete_me, :force => true) {|t| }
A
Akira Matsuda 已提交
566 567
      Person.reset_column_information
      Person.reset_sequence_name
568
    end
569

G
Guo Xiang Tan 已提交
570
    teardown do
571 572
      Person.connection.drop_table(:delete_me) rescue nil
    end
573

574 575
    def test_adding_multiple_columns
      assert_queries(1) do
576
        with_bulk_change_table do |t|
577
          t.column :name, :string
578
          t.string :qualification, :experience
579 580
          t.integer :age, :default => 0
          t.date :birthdate
581
          t.timestamps null: true
582
        end
583
      end
584

585 586
      assert_equal 8, columns.size
      [:name, :qualification, :experience].each {|s| assert_equal :string, column(s).type }
587
      assert_equal '0', column(:age).default
588
    end
589

590 591 592
    def test_removing_columns
      with_bulk_change_table do |t|
        t.string :qualification, :experience
593 594
      end

595
      [:qualification, :experience].each {|c| assert column(c) }
596

597 598 599 600
      assert_queries(1) do
        with_bulk_change_table do |t|
          t.remove :qualification, :experience
          t.string :qualification_experience
601
        end
602
      end
603

604 605 606
      [:qualification, :experience].each {|c| assert ! column(c) }
      assert column(:qualification_experience)
    end
607

608 609 610 611 612
    def test_adding_indexes
      with_bulk_change_table do |t|
        t.string :username
        t.string :name
        t.integer :age
613 614
      end

615 616
      # Adding an index fires a query every time to check if an index already exists or not
      assert_queries(3) do
617
        with_bulk_change_table do |t|
618 619
          t.index :username, :unique => true, :name => :awesome_username_index
          t.index [:name, :age]
620
        end
621
      end
622

623
      assert_equal 2, indexes.size
624

625 626 627
      name_age_index = index(:index_delete_me_on_name_and_age)
      assert_equal ['name', 'age'].sort, name_age_index.columns.sort
      assert ! name_age_index.unique
628

629 630
      assert index(:awesome_username_index).unique
    end
631

632 633 634 635
    def test_removing_index
      with_bulk_change_table do |t|
        t.string :name
        t.index :name
636
      end
637

638 639 640
      assert index(:index_delete_me_on_name)

      assert_queries(3) do
641
        with_bulk_change_table do |t|
642 643
          t.remove_index :name
          t.index :name, :name => :new_name_index, :unique => true
644
        end
645
      end
646

647
      assert ! index(:index_delete_me_on_name)
648

649 650 651
      new_name_index = index(:new_name_index)
      assert new_name_index.unique
    end
652

653 654 655 656
    def test_changing_columns
      with_bulk_change_table do |t|
        t.string :name
        t.date :birthdate
657
      end
658

659 660
      assert ! column(:name).default
      assert_equal :date, column(:birthdate).type
661

662 663 664
      # One query for columns (delete_me table)
      # One query for primary key (delete_me table)
      # One query to do the bulk change
665
      assert_queries(3, :ignore_none => true) do
666 667 668
        with_bulk_change_table do |t|
          t.change :name, :string, :default => 'NONAME'
          t.change :birthdate, :datetime
669
        end
670 671
      end

672 673 674
      assert_equal 'NONAME', column(:name).default
      assert_equal :datetime, column(:birthdate).type
    end
675

676
    protected
677

678 679 680
    def with_bulk_change_table
      # Reset columns/indexes cache as we're changing the table
      @columns = @indexes = nil
681

682 683
      Person.connection.change_table(:delete_me, :bulk => true) do |t|
        yield t
684
      end
685
    end
686

687 688 689
    def column(name)
      columns.detect {|c| c.name == name.to_s }
    end
690

691 692
    def columns
      @columns ||= Person.connection.columns('delete_me')
693 694
    end

695 696
    def index(name)
      indexes.detect {|i| i.name == name.to_s }
697 698
    end

699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721
    def indexes
      @indexes ||= Person.connection.indexes('delete_me')
    end
  end # AlterTableMigrationsTest

end

class CopyMigrationsTest < ActiveRecord::TestCase
  def setup
  end

  def clear
    ActiveRecord::Base.timestamped_migrations = true
    to_delete = Dir[@migrations_path + "/*.rb"] - @existing_migrations
    File.delete(*to_delete)
  end

  def test_copying_migrations_without_timestamps
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
A
Arun Agrawal 已提交
722 723
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741
    assert_equal [@migrations_path + "/4_people_have_hobbies.bukkits.rb", @migrations_path + "/5_people_have_descriptions.bukkits.rb"], copied.map(&:filename)

    expected = "# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_people_have_hobbies.bukkits.rb")[0].chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

  def test_copying_migrations_without_timestamps_from_2_sources
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

742
    sources = {}
743 744 745
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy"
    sources[:omg] = MIGRATIONS_ROOT + "/to_copy2"
    ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
746 747 748 749
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
    assert File.exist?(@migrations_path + "/6_create_articles.omg.rb")
    assert File.exist?(@migrations_path + "/7_create_comments.omg.rb")
750 751 752 753 754 755 756

    files_count = Dir[@migrations_path + "/*.rb"].length
    ActiveRecord::Migration.copy(@migrations_path, sources)
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
  ensure
    clear
  end
757

758 759 760
  def test_copying_migrations_with_timestamps
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
761

762
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
763
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
764 765
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
766 767 768
      expected = [@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb",
                  @migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb"]
      assert_equal expected, copied.map(&:filename)
769

770
      files_count = Dir[@migrations_path + "/*.rb"].length
771
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
772 773 774
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
    end
775 776 777
  ensure
    clear
  end
778

779 780 781
  def test_copying_migrations_with_timestamps_from_2_sources
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
782

783
    sources = {}
784 785 786
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_timestamps2"

787
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
788
      copied = ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
789 790 791 792
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101012_create_articles.omg.rb")
      assert File.exist?(@migrations_path + "/20100726101013_create_comments.omg.rb")
793
      assert_equal 4, copied.length
794 795 796 797 798

      files_count = Dir[@migrations_path + "/*.rb"].length
      ActiveRecord::Migration.copy(@migrations_path, sources)
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    end
799 800 801
  ensure
    clear
  end
802

803 804 805
  def test_copying_migrations_with_timestamps_to_destination_with_timestamps_in_future
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
806

807
    travel_to(Time.utc(2010, 2, 20, 10, 10, 10)) do
808
      ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
809 810
      assert File.exist?(@migrations_path + "/20100301010102_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100301010103_people_have_descriptions.bukkits.rb")
811

812 813 814 815
      files_count = Dir[@migrations_path + "/*.rb"].length
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
816
    end
817 818 819
  ensure
    clear
  end
820

821 822 823 824 825 826
  def test_copying_migrations_preserving_magic_comments
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
A
Arun Agrawal 已提交
827
    assert File.exist?(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")
828 829 830 831 832 833 834 835 836 837 838 839 840
    assert_equal [@migrations_path + "/4_currencies_have_symbols.bukkits.rb"], copied.map(&:filename)

    expected = "# coding: ISO-8859-15\n# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")[0..1].join.chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

841 842 843
  def test_skipping_migrations
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
844 845

    sources = {}
846 847
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_name_collision"
848

849 850 851 852
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    assert_equal 2, copied.length
853

854 855 856 857 858
    assert_equal 1, skipped.length
    assert_equal ["omg PeopleHaveHobbies"], skipped
  ensure
    clear
  end
859

860 861 862
  def test_skip_is_not_called_if_migrations_are_from_the_same_plugin
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
863

864
    sources = {}
865
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
866

867 868 869 870
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
871

872 873 874 875 876
    assert_equal 2, copied.length
    assert_equal 0, skipped.length
  ensure
    clear
  end
877

878 879 880
  def test_copying_migrations_to_non_existing_directory
    @migrations_path = MIGRATIONS_ROOT + "/non_existing"
    @existing_migrations = []
881

882
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
883
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
884 885
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
886 887
      assert_equal 2, copied.length
    end
888 889 890 891
  ensure
    clear
    Dir.delete(@migrations_path)
  end
892

893 894 895
  def test_copying_migrations_to_empty_directory
    @migrations_path = MIGRATIONS_ROOT + "/empty"
    @existing_migrations = []
896

897
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
898
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
899 900
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
901
      assert_equal 2, copied.length
902
    end
903 904
  ensure
    clear
905
  end
906 907 908 909 910 911 912 913 914

  def test_check_pending_with_stdlib_logger
    old, ActiveRecord::Base.logger = ActiveRecord::Base.logger, ::Logger.new($stdout)
    quietly do
      assert_nothing_raised { ActiveRecord::Migration::CheckPending.new(Proc.new {}).call({}) }
    end
  ensure
    ActiveRecord::Base.logger = old
  end
915 916 917 918 919 920 921 922 923 924

  private

  def quietly
    silence_stream(STDOUT) do
      silence_stream(STDERR) do
        yield
      end
    end
  end
925
end