migration_test.rb 30.8 KB
Newer Older
1
require "cases/helper"
2
require "cases/migration/helper"
3 4
require 'bigdecimal/util'

J
Jeremy Kemper 已提交
5 6
require 'models/person'
require 'models/topic'
7
require 'models/developer'
8 9

require MIGRATIONS_ROOT + "/valid/2_we_need_reminders"
10 11
require MIGRATIONS_ROOT + "/rename/1_we_need_things"
require MIGRATIONS_ROOT + "/rename/2_rename_things"
12
require MIGRATIONS_ROOT + "/decimal/1_give_me_big_numbers"
13

14
class BigNumber < ActiveRecord::Base; end
15

16
class Reminder < ActiveRecord::Base; end
17

18
class Thing < ActiveRecord::Base; end
19

20 21
class MigrationTest < ActiveRecord::TestCase
  self.use_transactional_fixtures = false
22

23
  fixtures :people
24

25 26
  def setup
    super
A
Akira Matsuda 已提交
27
    %w(reminders people_reminders prefix_reminders_suffix p_things_s).each do |table|
A
Aaron Patterson 已提交
28 29 30
      Reminder.connection.drop_table(table) rescue nil
    end
    Reminder.reset_column_information
31 32
    ActiveRecord::Migration.verbose = true
    ActiveRecord::Migration.message_count = 0
A
Akira Matsuda 已提交
33
    ActiveRecord::Base.connection.schema_cache.clear!
34
  end
35

36
  def teardown
37 38 39
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""

40 41
    ActiveRecord::Base.connection.initialize_schema_migrations_table
    ActiveRecord::Base.connection.execute "DELETE FROM #{ActiveRecord::Migrator.schema_migrations_table_name}"
42

43
    %w(things awesome_things prefix_things_suffix p_awesome_things_s ).each do |table|
44
      Thing.connection.drop_table(table) rescue nil
45
    end
46
    Thing.reset_column_information
47

48 49 50
    %w(reminders people_reminders prefix_reminders_suffix).each do |table|
      Reminder.connection.drop_table(table) rescue nil
    end
51
    Reminder.reset_table_name
52
    Reminder.reset_column_information
53

54 55 56 57 58 59 60 61 62
    %w(last_name key bio age height wealth birthday favorite_day
       moment_of_truth male administrator funny).each do |column|
      Person.connection.remove_column('people', column) rescue nil
    end
    Person.connection.remove_column("people", "first_name") rescue nil
    Person.connection.remove_column("people", "middle_name") rescue nil
    Person.connection.add_column("people", "first_name", :string, :limit => 40)
    Person.reset_column_information
  end
63

64 65 66 67 68 69 70
  def test_migrator_versions
    migrations_path = MIGRATIONS_ROOT + "/valid"
    ActiveRecord::Migrator.migrations_paths = migrations_path

    ActiveRecord::Migrator.up(migrations_path)
    assert_equal 3, ActiveRecord::Migrator.current_version
    assert_equal 3, ActiveRecord::Migrator.last_version
71
    assert_equal false, ActiveRecord::Migrator.needs_migration?
72 73 74 75

    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid")
    assert_equal 0, ActiveRecord::Migrator.current_version
    assert_equal 3, ActiveRecord::Migrator.last_version
76
    assert_equal true, ActiveRecord::Migrator.needs_migration?
77 78
  end

79 80 81
  def test_create_table_with_force_true_does_not_drop_nonexisting_table
    if Person.connection.table_exists?(:testings2)
      Person.connection.drop_table :testings2
82 83
    end

84 85 86
    # using a copy as we need the drop_table method to
    # continue to work for the ensure block of the test
    temp_conn = Person.connection.dup
87 88 89

    assert_not_equal temp_conn, Person.connection

90 91
    temp_conn.create_table :testings2, :force => true do |t|
      t.column :foo, :string
92
    end
93 94 95
  ensure
    Person.connection.drop_table :testings2 rescue nil
  end
96

97 98 99
  def connection
    ActiveRecord::Base.connection
  end
100

101 102 103 104
  def test_migration_instance_has_connection
    migration = Class.new(ActiveRecord::Migration).new
    assert_equal connection, migration.connection
  end
105

106 107 108 109 110 111 112 113
  def test_method_missing_delegates_to_connection
    migration = Class.new(ActiveRecord::Migration) {
      def connection
        Class.new {
          def create_table; "hi mom!"; end
        }.new
      end
    }.new
114

115
    assert_equal "hi mom!", migration.method_missing(:create_table)
116
  end
117

118 119 120 121 122 123 124 125 126 127 128 129 130 131
  def test_add_table_with_decimals
    Person.connection.drop_table :big_numbers rescue nil

    assert !BigNumber.table_exists?
    GiveMeBigNumbers.up

    assert BigNumber.create(
      :bank_balance => 1586.43,
      :big_bank_balance => BigDecimal("1000234000567.95"),
      :world_population => 6000000000,
      :my_house_population => 3,
      :value_of_e => BigDecimal("2.7182818284590452353602875")
    )

132
    b = BigNumber.first
133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175
    assert_not_nil b

    assert_not_nil b.bank_balance
    assert_not_nil b.big_bank_balance
    assert_not_nil b.world_population
    assert_not_nil b.my_house_population
    assert_not_nil b.value_of_e

    # TODO: set world_population >= 2**62 to cover 64-bit platforms and test
    # is_a?(Bignum)
    assert_kind_of Integer, b.world_population
    assert_equal 6000000000, b.world_population
    assert_kind_of Fixnum, b.my_house_population
    assert_equal 3, b.my_house_population
    assert_kind_of BigDecimal, b.bank_balance
    assert_equal BigDecimal("1586.43"), b.bank_balance
    assert_kind_of BigDecimal, b.big_bank_balance
    assert_equal BigDecimal("1000234000567.95"), b.big_bank_balance

    # This one is fun. The 'value_of_e' field is defined as 'DECIMAL' with
    # precision/scale explicitly left out.  By the SQL standard, numbers
    # assigned to this field should be truncated but that's seldom respected.
    if current_adapter?(:PostgreSQLAdapter)
      # - PostgreSQL changes the SQL spec on columns declared simply as
      # "decimal" to something more useful: instead of being given a scale
      # of 0, they take on the compile-time limit for precision and scale,
      # so the following should succeed unless you have used really wacky
      # compilation options
      # - SQLite2 has the default behavior of preserving all data sent in,
      # so this happens there too
      assert_kind_of BigDecimal, b.value_of_e
      assert_equal BigDecimal("2.7182818284590452353602875"), b.value_of_e
    elsif current_adapter?(:SQLite3Adapter)
      # - SQLite3 stores a float, in violation of SQL
      assert_kind_of BigDecimal, b.value_of_e
      assert_in_delta BigDecimal("2.71828182845905"), b.value_of_e, 0.00000000000001
    else
      # - SQL standard is an integer
      assert_kind_of Fixnum, b.value_of_e
      assert_equal 2, b.value_of_e
    end

    GiveMeBigNumbers.down
176
    assert_raise(ActiveRecord::StatementInvalid) { BigNumber.first }
177
  end
178

179
  def test_filtering_migrations
180
    assert_no_column Person, :last_name
181
    assert !Reminder.table_exists?
182

183 184
    name_filter = lambda { |migration| migration.name == "ValidPeopleHaveLastNames" }
    ActiveRecord::Migrator.up(MIGRATIONS_ROOT + "/valid", &name_filter)
185

186
    assert_column Person, :last_name
187
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
188

189 190
    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid", &name_filter)

191
    assert_no_column Person, :last_name
192
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
193 194 195 196 197 198 199
  end

  class MockMigration < ActiveRecord::Migration
    attr_reader :went_up, :went_down
    def initialize
      @went_up   = false
      @went_down = false
200 201
    end

202 203 204 205
    def up
      @went_up = true
      super
    end
206

207 208 209
    def down
      @went_down = true
      super
210
    end
211
  end
212

213 214 215 216
  def test_instance_based_migration_up
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
217

218 219 220 221
    migration.migrate :up
    assert migration.went_up, 'have gone up'
    assert !migration.went_down, 'have not gone down'
  end
222

223 224 225 226
  def test_instance_based_migration_down
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
227

228 229 230 231
    migration.migrate :down
    assert !migration.went_up, 'have gone up'
    assert migration.went_down, 'have not gone down'
  end
232

233 234 235 236 237 238 239 240 241 242 243
  if ActiveRecord::Base.connection.supports_ddl_transactions?
    def test_migrator_one_up_with_exception_and_rollback
      assert_no_column Person, :last_name

      migration = Class.new(ActiveRecord::Migration) {
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
244

245
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
246

247
      e = assert_raise(StandardError) { migrator.migrate }
248

249
      assert_equal "An error has occurred, this and all later migrations canceled:\n\nSomething broke", e.message
250

251 252
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
B
bondarev 已提交
253 254
    end

255 256
    def test_migrator_one_up_with_exception_and_rollback_using_run
      assert_no_column Person, :last_name
B
bondarev 已提交
257

258 259 260 261 262 263 264
      migration = Class.new(ActiveRecord::Migration) {
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
B
bondarev 已提交
265

266
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
B
bondarev 已提交
267

268
      e = assert_raise(StandardError) { migrator.run }
B
bondarev 已提交
269

270
      assert_equal "An error has occurred, this migration was canceled:\n\nSomething broke", e.message
B
bondarev 已提交
271

272 273
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
274 275
    end

276 277
    def test_migration_without_transaction
      assert_no_column Person, :last_name
278

279 280
      migration = Class.new(ActiveRecord::Migration) {
        self.disable_ddl_transaction!
281

282 283 284 285 286 287
        def version; 101 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
288

289 290 291
      migrator = ActiveRecord::Migrator.new(:up, [migration], 101)
      e = assert_raise(StandardError) { migrator.migrate }
      assert_equal "An error has occurred, all later migrations canceled:\n\nSomething broke", e.message
292

293 294 295 296 297 298 299
      assert_column Person, :last_name,
        "without ddl transactions, the Migrator should not rollback on error but it did."
    ensure
      Person.reset_column_information
      if Person.column_names.include?('last_name')
        Person.connection.remove_column('people', 'last_name')
      end
300
    end
301
  end
302

303
  def test_schema_migrations_table_name
304 305 306
    original_schema_migrations_table_name = ActiveRecord::Migrator.schema_migrations_table_name

    assert_equal "schema_migrations", ActiveRecord::Migrator.schema_migrations_table_name
307 308 309 310
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
    Reminder.reset_table_name
    assert_equal "prefix_schema_migrations_suffix", ActiveRecord::Migrator.schema_migrations_table_name
311 312 313
    ActiveRecord::Base.schema_migrations_table_name = "changed"
    Reminder.reset_table_name
    assert_equal "prefix_changed_suffix", ActiveRecord::Migrator.schema_migrations_table_name
314 315 316
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""
    Reminder.reset_table_name
317 318 319 320
    assert_equal "changed", ActiveRecord::Migrator.schema_migrations_table_name
  ensure
    ActiveRecord::Base.schema_migrations_table_name = original_schema_migrations_table_name
    Reminder.reset_table_name
321 322
  end

323
  def test_proper_table_name_on_migrator
324 325 326 327 328 329 330 331 332
    assert_deprecated do
      assert_equal "table", ActiveRecord::Migrator.proper_table_name('table')
    end
    assert_deprecated do
      assert_equal "table", ActiveRecord::Migrator.proper_table_name(:table)
    end
    assert_deprecated do
      assert_equal "reminders", ActiveRecord::Migrator.proper_table_name(Reminder)
    end
333
    Reminder.reset_table_name
334 335 336
    assert_deprecated do
      assert_equal Reminder.table_name, ActiveRecord::Migrator.proper_table_name(Reminder)
    end
337 338 339 340 341 342 343

    # Use the model's own prefix/suffix if a model is given
    ActiveRecord::Base.table_name_prefix = "ARprefix_"
    ActiveRecord::Base.table_name_suffix = "_ARsuffix"
    Reminder.table_name_prefix = 'prefix_'
    Reminder.table_name_suffix = '_suffix'
    Reminder.reset_table_name
344 345 346
    assert_deprecated do
      assert_equal "prefix_reminders_suffix", ActiveRecord::Migrator.proper_table_name(Reminder)
    end
347 348 349 350 351 352 353 354
    Reminder.table_name_prefix = ''
    Reminder.table_name_suffix = ''
    Reminder.reset_table_name

    # Use AR::Base's prefix/suffix if string or symbol is given
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
    Reminder.reset_table_name
355 356 357 358 359 360
    assert_deprecated do
      assert_equal "prefix_table_suffix", ActiveRecord::Migrator.proper_table_name('table')
    end
    assert_deprecated do
      assert_equal "prefix_table_suffix", ActiveRecord::Migrator.proper_table_name(:table)
    end
361 362
  end

363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389
  def test_proper_table_name_on_migration
    migration = ActiveRecord::Migration.new
    assert_equal "table", migration.proper_table_name('table')
    assert_equal "table", migration.proper_table_name(:table)
    assert_equal "reminders", migration.proper_table_name(Reminder)
    Reminder.reset_table_name
    assert_equal Reminder.table_name, migration.proper_table_name(Reminder)

    # Use the model's own prefix/suffix if a model is given
    ActiveRecord::Base.table_name_prefix = "ARprefix_"
    ActiveRecord::Base.table_name_suffix = "_ARsuffix"
    Reminder.table_name_prefix = 'prefix_'
    Reminder.table_name_suffix = '_suffix'
    Reminder.reset_table_name
    assert_equal "prefix_reminders_suffix", migration.proper_table_name(Reminder)
    Reminder.table_name_prefix = ''
    Reminder.table_name_suffix = ''
    Reminder.reset_table_name

    # Use AR::Base's prefix/suffix if string or symbol is given
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
    Reminder.reset_table_name
    assert_equal "prefix_table_suffix", migration.proper_table_name('table', migration.table_name_options)
    assert_equal "prefix_table_suffix", migration.proper_table_name(:table, migration.table_name_options)
  end

390 391
  def test_rename_table_with_prefix_and_suffix
    assert !Thing.table_exists?
392 393
    ActiveRecord::Base.table_name_prefix = 'p_'
    ActiveRecord::Base.table_name_suffix = '_s'
394 395 396 397 398
    Thing.reset_table_name
    Thing.reset_sequence_name
    WeNeedThings.up

    assert Thing.create("content" => "hello world")
399
    assert_equal "hello world", Thing.first.content
400 401

    RenameThings.up
402
    Thing.table_name = "p_awesome_things_s"
403

404
    assert_equal "hello world", Thing.first.content
405 406 407 408 409 410 411 412 413 414 415 416 417
  ensure
    Thing.reset_table_name
    Thing.reset_sequence_name
  end

  def test_add_drop_table_with_prefix_and_suffix
    assert !Reminder.table_exists?
    ActiveRecord::Base.table_name_prefix = 'prefix_'
    ActiveRecord::Base.table_name_suffix = '_suffix'
    Reminder.reset_table_name
    Reminder.reset_sequence_name
    WeNeedReminders.up
    assert Reminder.create("content" => "hello world", "remind_at" => Time.now)
418
    assert_equal "hello world", Reminder.first.content
419 420

    WeNeedReminders.down
421
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
422 423 424
  ensure
    Reminder.reset_sequence_name
  end
425

426 427
  def test_create_table_with_binary_column
    Person.connection.drop_table :binary_testings rescue nil
428

429 430
    assert_nothing_raised {
      Person.connection.create_table :binary_testings do |t|
431
        t.column "data", :binary, :null => false
432
      end
433 434 435 436
    }

    columns = Person.connection.columns(:binary_testings)
    data_column = columns.detect { |c| c.name == "data" }
437

J
Jon Leighton 已提交
438
    assert_nil data_column.default
439

440 441 442
    Person.connection.drop_table :binary_testings rescue nil
  end

443 444 445 446 447 448 449 450 451 452 453
  if current_adapter? :OracleAdapter
    def test_create_table_with_custom_sequence_name
      # table name is 29 chars, the standard sequence name will
      # be 33 chars and should be shortened
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok do |t|
            t.column :foo, :string, :null => false
          end
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok rescue nil
454 455 456
        end
      end

457 458 459 460 461 462 463
      # should be all good w/ a custom sequence name
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' do |t|
            t.column :foo, :string, :null => false
          end
464

465
          Person.connection.execute("select suitably_short_seq.nextval from dual")
466

467 468 469 470
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' rescue nil
        end
471 472
      end

473 474 475 476
      # confirm the custom sequence got dropped
      assert_raise(ActiveRecord::StatementInvalid) do
        Person.connection.execute("select suitably_short_seq.nextval from dual")
      end
477
    end
478
  end
479

480 481 482 483 484 485 486
  if current_adapter?(:MysqlAdapter, :Mysql2Adapter, :PostgreSQLAdapter)
    def test_out_of_range_limit_should_raise
      Person.connection.drop_table :test_limits rescue nil
      assert_raise(ActiveRecord::ActiveRecordError, "integer limit didn't raise") do
        Person.connection.create_table :test_integer_limits, :force => true do |t|
          t.column :bigone, :integer, :limit => 10
        end
487 488
      end

489 490 491 492 493
      unless current_adapter?(:PostgreSQLAdapter)
        assert_raise(ActiveRecord::ActiveRecordError, "text limit didn't raise") do
          Person.connection.create_table :test_text_limits, :force => true do |t|
            t.column :bigtext, :text, :limit => 0xfffffffff
          end
494 495 496
        end
      end

497 498
      Person.connection.drop_table :test_limits rescue nil
    end
499 500
  end

501 502 503 504
  protected
    def with_env_tz(new_tz = 'US/Eastern')
      old_tz, ENV['TZ'] = ENV['TZ'], new_tz
      yield
505
    ensure
506
      old_tz ? ENV['TZ'] = old_tz : ENV.delete('TZ')
507
    end
508
end
509

510 511 512 513 514
class ReservedWordsMigrationTest < ActiveRecord::TestCase
  def test_drop_index_from_table_named_values
    connection = Person.connection
    connection.create_table :values, :force => true do |t|
      t.integer :value
515
    end
516

517 518 519
    assert_nothing_raised do
      connection.add_index :values, :value
      connection.remove_index :values, :column => :value
520
    end
521

522 523 524 525
    connection.drop_table :values rescue nil
  end
end

526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541
class ExplicitlyNamedIndexMigrationTest < ActiveRecord::TestCase
  def test_drop_index_by_name
    connection = Person.connection
    connection.create_table :values, force: true do |t|
      t.integer :value
    end

    assert_nothing_raised ArgumentError do
      connection.add_index :values, :value, name: 'a_different_name'
      connection.remove_index :values, column: :value, name: 'a_different_name'
    end

    connection.drop_table :values rescue nil
  end
end

542 543 544 545 546
if ActiveRecord::Base.connection.supports_bulk_alter?
  class BulkAlterTableMigrationsTest < ActiveRecord::TestCase
    def setup
      @connection = Person.connection
      @connection.create_table(:delete_me, :force => true) {|t| }
A
Akira Matsuda 已提交
547 548
      Person.reset_column_information
      Person.reset_sequence_name
549
    end
550

551 552 553
    def teardown
      Person.connection.drop_table(:delete_me) rescue nil
    end
554

555 556
    def test_adding_multiple_columns
      assert_queries(1) do
557
        with_bulk_change_table do |t|
558
          t.column :name, :string
559
          t.string :qualification, :experience
560 561 562
          t.integer :age, :default => 0
          t.date :birthdate
          t.timestamps
563
        end
564
      end
565

566 567 568 569
      assert_equal 8, columns.size
      [:name, :qualification, :experience].each {|s| assert_equal :string, column(s).type }
      assert_equal 0, column(:age).default
    end
570

571 572 573
    def test_removing_columns
      with_bulk_change_table do |t|
        t.string :qualification, :experience
574 575
      end

576
      [:qualification, :experience].each {|c| assert column(c) }
577

578 579 580 581
      assert_queries(1) do
        with_bulk_change_table do |t|
          t.remove :qualification, :experience
          t.string :qualification_experience
582
        end
583
      end
584

585 586 587
      [:qualification, :experience].each {|c| assert ! column(c) }
      assert column(:qualification_experience)
    end
588

589 590 591 592 593
    def test_adding_indexes
      with_bulk_change_table do |t|
        t.string :username
        t.string :name
        t.integer :age
594 595
      end

596 597
      # Adding an index fires a query every time to check if an index already exists or not
      assert_queries(3) do
598
        with_bulk_change_table do |t|
599 600
          t.index :username, :unique => true, :name => :awesome_username_index
          t.index [:name, :age]
601
        end
602
      end
603

604
      assert_equal 2, indexes.size
605

606 607 608
      name_age_index = index(:index_delete_me_on_name_and_age)
      assert_equal ['name', 'age'].sort, name_age_index.columns.sort
      assert ! name_age_index.unique
609

610 611
      assert index(:awesome_username_index).unique
    end
612

613 614 615 616
    def test_removing_index
      with_bulk_change_table do |t|
        t.string :name
        t.index :name
617
      end
618

619 620 621
      assert index(:index_delete_me_on_name)

      assert_queries(3) do
622
        with_bulk_change_table do |t|
623 624
          t.remove_index :name
          t.index :name, :name => :new_name_index, :unique => true
625
        end
626
      end
627

628
      assert ! index(:index_delete_me_on_name)
629

630 631 632
      new_name_index = index(:new_name_index)
      assert new_name_index.unique
    end
633

634 635 636 637
    def test_changing_columns
      with_bulk_change_table do |t|
        t.string :name
        t.date :birthdate
638
      end
639

640 641
      assert ! column(:name).default
      assert_equal :date, column(:birthdate).type
642

643 644 645
      # One query for columns (delete_me table)
      # One query for primary key (delete_me table)
      # One query to do the bulk change
646
      assert_queries(3, :ignore_none => true) do
647 648 649
        with_bulk_change_table do |t|
          t.change :name, :string, :default => 'NONAME'
          t.change :birthdate, :datetime
650
        end
651 652
      end

653 654 655
      assert_equal 'NONAME', column(:name).default
      assert_equal :datetime, column(:birthdate).type
    end
656

657
    protected
658

659 660 661
    def with_bulk_change_table
      # Reset columns/indexes cache as we're changing the table
      @columns = @indexes = nil
662

663 664
      Person.connection.change_table(:delete_me, :bulk => true) do |t|
        yield t
665
      end
666
    end
667

668 669 670
    def column(name)
      columns.detect {|c| c.name == name.to_s }
    end
671

672 673
    def columns
      @columns ||= Person.connection.columns('delete_me')
674 675
    end

676 677
    def index(name)
      indexes.detect {|i| i.name == name.to_s }
678 679
    end

680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702
    def indexes
      @indexes ||= Person.connection.indexes('delete_me')
    end
  end # AlterTableMigrationsTest

end

class CopyMigrationsTest < ActiveRecord::TestCase
  def setup
  end

  def clear
    ActiveRecord::Base.timestamped_migrations = true
    to_delete = Dir[@migrations_path + "/*.rb"] - @existing_migrations
    File.delete(*to_delete)
  end

  def test_copying_migrations_without_timestamps
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
A
Arun Agrawal 已提交
703 704
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722
    assert_equal [@migrations_path + "/4_people_have_hobbies.bukkits.rb", @migrations_path + "/5_people_have_descriptions.bukkits.rb"], copied.map(&:filename)

    expected = "# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_people_have_hobbies.bukkits.rb")[0].chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

  def test_copying_migrations_without_timestamps_from_2_sources
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

723
    sources = {}
724 725 726
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy"
    sources[:omg] = MIGRATIONS_ROOT + "/to_copy2"
    ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
727 728 729 730
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
    assert File.exist?(@migrations_path + "/6_create_articles.omg.rb")
    assert File.exist?(@migrations_path + "/7_create_comments.omg.rb")
731 732 733 734 735 736 737

    files_count = Dir[@migrations_path + "/*.rb"].length
    ActiveRecord::Migration.copy(@migrations_path, sources)
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
  ensure
    clear
  end
738

739 740 741
  def test_copying_migrations_with_timestamps
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
742

743 744
    Time.travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
745 746
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
747 748 749
      expected = [@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb",
                  @migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb"]
      assert_equal expected, copied.map(&:filename)
750

751
      files_count = Dir[@migrations_path + "/*.rb"].length
752
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
753 754 755
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
    end
756 757 758
  ensure
    clear
  end
759

760 761 762
  def test_copying_migrations_with_timestamps_from_2_sources
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
763

764
    sources = {}
765 766 767 768 769
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_timestamps2"

    Time.travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
      copied = ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
770 771 772 773
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101012_create_articles.omg.rb")
      assert File.exist?(@migrations_path + "/20100726101013_create_comments.omg.rb")
774
      assert_equal 4, copied.length
775 776 777 778 779

      files_count = Dir[@migrations_path + "/*.rb"].length
      ActiveRecord::Migration.copy(@migrations_path, sources)
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    end
780 781 782
  ensure
    clear
  end
783

784 785 786
  def test_copying_migrations_with_timestamps_to_destination_with_timestamps_in_future
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
787

788 789
    Time.travel_to(Time.utc(2010, 2, 20, 10, 10, 10)) do
      ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
790 791
      assert File.exist?(@migrations_path + "/20100301010102_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100301010103_people_have_descriptions.bukkits.rb")
792

793 794 795 796
      files_count = Dir[@migrations_path + "/*.rb"].length
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
797
    end
798 799 800
  ensure
    clear
  end
801

802 803 804 805 806 807
  def test_copying_migrations_preserving_magic_comments
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
A
Arun Agrawal 已提交
808
    assert File.exist?(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")
809 810 811 812 813 814 815 816 817 818 819 820 821
    assert_equal [@migrations_path + "/4_currencies_have_symbols.bukkits.rb"], copied.map(&:filename)

    expected = "# coding: ISO-8859-15\n# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")[0..1].join.chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

822 823 824
  def test_skipping_migrations
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
825 826

    sources = {}
827 828
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_name_collision"
829

830 831 832 833
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    assert_equal 2, copied.length
834

835 836 837 838 839
    assert_equal 1, skipped.length
    assert_equal ["omg PeopleHaveHobbies"], skipped
  ensure
    clear
  end
840

841 842 843
  def test_skip_is_not_called_if_migrations_are_from_the_same_plugin
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
844

845
    sources = {}
846
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
847

848 849 850 851
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
852

853 854 855 856 857
    assert_equal 2, copied.length
    assert_equal 0, skipped.length
  ensure
    clear
  end
858

859 860 861
  def test_copying_migrations_to_non_existing_directory
    @migrations_path = MIGRATIONS_ROOT + "/non_existing"
    @existing_migrations = []
862

863 864
    Time.travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
865 866
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
867 868
      assert_equal 2, copied.length
    end
869 870 871 872
  ensure
    clear
    Dir.delete(@migrations_path)
  end
873

874 875 876
  def test_copying_migrations_to_empty_directory
    @migrations_path = MIGRATIONS_ROOT + "/empty"
    @existing_migrations = []
877

878 879
    Time.travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
880 881
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
882
      assert_equal 2, copied.length
883
    end
884 885
  ensure
    clear
886
  end
887 888 889 890 891 892 893 894 895

  def test_check_pending_with_stdlib_logger
    old, ActiveRecord::Base.logger = ActiveRecord::Base.logger, ::Logger.new($stdout)
    quietly do
      assert_nothing_raised { ActiveRecord::Migration::CheckPending.new(Proc.new {}).call({}) }
    end
  ensure
    ActiveRecord::Base.logger = old
  end
896
end