migration_test.rb 37.4 KB
Newer Older
1 2
require 'cases/helper'
require 'cases/migration/helper'
3
require 'bigdecimal/util'
4
require 'concurrent/atomic/count_down_latch'
5

J
Jeremy Kemper 已提交
6 7
require 'models/person'
require 'models/topic'
8
require 'models/developer'
A
Arun Agrawal 已提交
9
require 'models/computer'
10 11

require MIGRATIONS_ROOT + "/valid/2_we_need_reminders"
12 13
require MIGRATIONS_ROOT + "/rename/1_we_need_things"
require MIGRATIONS_ROOT + "/rename/2_rename_things"
14
require MIGRATIONS_ROOT + "/decimal/1_give_me_big_numbers"
15

16
class BigNumber < ActiveRecord::Base
17
  unless current_adapter?(:PostgreSQLAdapter, :SQLite3Adapter)
18
    attribute :value_of_e, :integer
19
  end
20
  attribute :my_house_population, :integer
21
end
22

23
class Reminder < ActiveRecord::Base; end
24

25
class Thing < ActiveRecord::Base; end
26

27
class MigrationTest < ActiveRecord::TestCase
28
  self.use_transactional_tests = false
29

30
  fixtures :people
31

32 33
  def setup
    super
A
Akira Matsuda 已提交
34
    %w(reminders people_reminders prefix_reminders_suffix p_things_s).each do |table|
A
Aaron Patterson 已提交
35 36 37
      Reminder.connection.drop_table(table) rescue nil
    end
    Reminder.reset_column_information
38
    @verbose_was, ActiveRecord::Migration.verbose = ActiveRecord::Migration.verbose, false
A
Akira Matsuda 已提交
39
    ActiveRecord::Base.connection.schema_cache.clear!
40
  end
41

G
Guo Xiang Tan 已提交
42
  teardown do
43 44 45
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""

46 47
    ActiveRecord::Base.connection.initialize_schema_migrations_table
    ActiveRecord::Base.connection.execute "DELETE FROM #{ActiveRecord::Migrator.schema_migrations_table_name}"
48

49
    %w(things awesome_things prefix_things_suffix p_awesome_things_s ).each do |table|
50
      Thing.connection.drop_table(table) rescue nil
51
    end
52
    Thing.reset_column_information
53

54 55 56
    %w(reminders people_reminders prefix_reminders_suffix).each do |table|
      Reminder.connection.drop_table(table) rescue nil
    end
57
    Reminder.reset_table_name
58
    Reminder.reset_column_information
59

60 61 62 63 64 65
    %w(last_name key bio age height wealth birthday favorite_day
       moment_of_truth male administrator funny).each do |column|
      Person.connection.remove_column('people', column) rescue nil
    end
    Person.connection.remove_column("people", "first_name") rescue nil
    Person.connection.remove_column("people", "middle_name") rescue nil
66
    Person.connection.add_column("people", "first_name", :string)
67
    Person.reset_column_information
68 69

    ActiveRecord::Migration.verbose = @verbose_was
70
  end
71

72 73
  def test_migrator_versions
    migrations_path = MIGRATIONS_ROOT + "/valid"
74
    old_path = ActiveRecord::Migrator.migrations_paths
75 76 77 78
    ActiveRecord::Migrator.migrations_paths = migrations_path

    ActiveRecord::Migrator.up(migrations_path)
    assert_equal 3, ActiveRecord::Migrator.current_version
79
    assert_equal false, ActiveRecord::Migrator.needs_migration?
80 81 82

    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid")
    assert_equal 0, ActiveRecord::Migrator.current_version
83
    assert_equal true, ActiveRecord::Migrator.needs_migration?
84

Y
Yves Senn 已提交
85
    ActiveRecord::SchemaMigration.create!(version: 3)
86 87 88 89 90 91
    assert_equal true, ActiveRecord::Migrator.needs_migration?
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
  end

  def test_migration_detection_without_schema_migration_table
92
    ActiveRecord::Base.connection.drop_table 'schema_migrations', if_exists: true
93 94 95 96 97 98

    migrations_path = MIGRATIONS_ROOT + "/valid"
    old_path = ActiveRecord::Migrator.migrations_paths
    ActiveRecord::Migrator.migrations_paths = migrations_path

    assert_equal true, ActiveRecord::Migrator.needs_migration?
99 100
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
101 102
  end

103 104 105 106 107 108 109 110 111 112 113 114 115
  def test_any_migrations
    old_path = ActiveRecord::Migrator.migrations_paths
    ActiveRecord::Migrator.migrations_paths = MIGRATIONS_ROOT + "/valid"

    assert ActiveRecord::Migrator.any_migrations?

    ActiveRecord::Migrator.migrations_paths = MIGRATIONS_ROOT + "/empty"

    assert_not ActiveRecord::Migrator.any_migrations?
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
  end

116
  def test_migration_version
117
    assert_nothing_raised { ActiveRecord::Migrator.run(:up, MIGRATIONS_ROOT + "/version_check", 20131219224947) }
118 119
  end

120 121 122 123
  def test_create_table_with_force_true_does_not_drop_nonexisting_table
    # using a copy as we need the drop_table method to
    # continue to work for the ensure block of the test
    temp_conn = Person.connection.dup
124 125 126

    assert_not_equal temp_conn, Person.connection

127 128
    temp_conn.create_table :testings2, :force => true do |t|
      t.column :foo, :string
129
    end
130
  ensure
131
    Person.connection.drop_table :testings2, if_exists: true
132
  end
133

134
  def test_migration_instance_has_connection
135
    migration = Class.new(ActiveRecord::Migration::Current).new
136
    assert_equal ActiveRecord::Base.connection, migration.connection
137
  end
138

139
  def test_method_missing_delegates_to_connection
140
    migration = Class.new(ActiveRecord::Migration::Current) {
141 142 143 144 145 146
      def connection
        Class.new {
          def create_table; "hi mom!"; end
        }.new
      end
    }.new
147

148
    assert_equal "hi mom!", migration.method_missing(:create_table)
149
  end
150

151 152 153 154 155
  def test_add_table_with_decimals
    Person.connection.drop_table :big_numbers rescue nil

    assert !BigNumber.table_exists?
    GiveMeBigNumbers.up
156
    BigNumber.reset_column_information
157 158 159 160 161 162 163 164 165

    assert BigNumber.create(
      :bank_balance => 1586.43,
      :big_bank_balance => BigDecimal("1000234000567.95"),
      :world_population => 6000000000,
      :my_house_population => 3,
      :value_of_e => BigDecimal("2.7182818284590452353602875")
    )

166
    b = BigNumber.first
167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209
    assert_not_nil b

    assert_not_nil b.bank_balance
    assert_not_nil b.big_bank_balance
    assert_not_nil b.world_population
    assert_not_nil b.my_house_population
    assert_not_nil b.value_of_e

    # TODO: set world_population >= 2**62 to cover 64-bit platforms and test
    # is_a?(Bignum)
    assert_kind_of Integer, b.world_population
    assert_equal 6000000000, b.world_population
    assert_kind_of Fixnum, b.my_house_population
    assert_equal 3, b.my_house_population
    assert_kind_of BigDecimal, b.bank_balance
    assert_equal BigDecimal("1586.43"), b.bank_balance
    assert_kind_of BigDecimal, b.big_bank_balance
    assert_equal BigDecimal("1000234000567.95"), b.big_bank_balance

    # This one is fun. The 'value_of_e' field is defined as 'DECIMAL' with
    # precision/scale explicitly left out.  By the SQL standard, numbers
    # assigned to this field should be truncated but that's seldom respected.
    if current_adapter?(:PostgreSQLAdapter)
      # - PostgreSQL changes the SQL spec on columns declared simply as
      # "decimal" to something more useful: instead of being given a scale
      # of 0, they take on the compile-time limit for precision and scale,
      # so the following should succeed unless you have used really wacky
      # compilation options
      # - SQLite2 has the default behavior of preserving all data sent in,
      # so this happens there too
      assert_kind_of BigDecimal, b.value_of_e
      assert_equal BigDecimal("2.7182818284590452353602875"), b.value_of_e
    elsif current_adapter?(:SQLite3Adapter)
      # - SQLite3 stores a float, in violation of SQL
      assert_kind_of BigDecimal, b.value_of_e
      assert_in_delta BigDecimal("2.71828182845905"), b.value_of_e, 0.00000000000001
    else
      # - SQL standard is an integer
      assert_kind_of Fixnum, b.value_of_e
      assert_equal 2, b.value_of_e
    end

    GiveMeBigNumbers.down
210
    assert_raise(ActiveRecord::StatementInvalid) { BigNumber.first }
211
  end
212

213
  def test_filtering_migrations
214
    assert_no_column Person, :last_name
215
    assert !Reminder.table_exists?
216

217 218
    name_filter = lambda { |migration| migration.name == "ValidPeopleHaveLastNames" }
    ActiveRecord::Migrator.up(MIGRATIONS_ROOT + "/valid", &name_filter)
219

220
    assert_column Person, :last_name
221
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
222

223 224
    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid", &name_filter)

225
    assert_no_column Person, :last_name
226
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
227 228
  end

229
  class MockMigration < ActiveRecord::Migration::Current
230 231 232 233
    attr_reader :went_up, :went_down
    def initialize
      @went_up   = false
      @went_down = false
234 235
    end

236 237 238 239
    def up
      @went_up = true
      super
    end
240

241 242 243
    def down
      @went_down = true
      super
244
    end
245
  end
246

247 248 249 250
  def test_instance_based_migration_up
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
251

252 253 254 255
    migration.migrate :up
    assert migration.went_up, 'have gone up'
    assert !migration.went_down, 'have not gone down'
  end
256

257 258 259 260
  def test_instance_based_migration_down
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
261

262 263 264 265
    migration.migrate :down
    assert !migration.went_up, 'have gone up'
    assert migration.went_down, 'have not gone down'
  end
266

267 268 269 270
  if ActiveRecord::Base.connection.supports_ddl_transactions?
    def test_migrator_one_up_with_exception_and_rollback
      assert_no_column Person, :last_name

271
      migration = Class.new(ActiveRecord::Migration::Current) {
272 273 274 275 276 277
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
278

279
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
280

281
      e = assert_raise(StandardError) { migrator.migrate }
282

283
      assert_equal "An error has occurred, this and all later migrations canceled:\n\nSomething broke", e.message
284

285 286
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
B
bondarev 已提交
287 288
    end

289 290
    def test_migrator_one_up_with_exception_and_rollback_using_run
      assert_no_column Person, :last_name
B
bondarev 已提交
291

292
      migration = Class.new(ActiveRecord::Migration::Current) {
293 294 295 296 297 298
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
B
bondarev 已提交
299

300
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
B
bondarev 已提交
301

302
      e = assert_raise(StandardError) { migrator.run }
B
bondarev 已提交
303

304
      assert_equal "An error has occurred, this migration was canceled:\n\nSomething broke", e.message
B
bondarev 已提交
305

306 307
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
308 309
    end

310 311
    def test_migration_without_transaction
      assert_no_column Person, :last_name
312

313
      migration = Class.new(ActiveRecord::Migration::Current) {
314
        self.disable_ddl_transaction!
315

316 317 318 319 320 321
        def version; 101 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
322

323 324 325
      migrator = ActiveRecord::Migrator.new(:up, [migration], 101)
      e = assert_raise(StandardError) { migrator.migrate }
      assert_equal "An error has occurred, all later migrations canceled:\n\nSomething broke", e.message
326

327 328 329 330 331 332 333
      assert_column Person, :last_name,
        "without ddl transactions, the Migrator should not rollback on error but it did."
    ensure
      Person.reset_column_information
      if Person.column_names.include?('last_name')
        Person.connection.remove_column('people', 'last_name')
      end
334
    end
335
  end
336

337
  def test_schema_migrations_table_name
338 339 340
    original_schema_migrations_table_name = ActiveRecord::Migrator.schema_migrations_table_name

    assert_equal "schema_migrations", ActiveRecord::Migrator.schema_migrations_table_name
341 342 343 344
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
    Reminder.reset_table_name
    assert_equal "prefix_schema_migrations_suffix", ActiveRecord::Migrator.schema_migrations_table_name
345 346 347
    ActiveRecord::Base.schema_migrations_table_name = "changed"
    Reminder.reset_table_name
    assert_equal "prefix_changed_suffix", ActiveRecord::Migrator.schema_migrations_table_name
348 349 350
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""
    Reminder.reset_table_name
351 352 353 354
    assert_equal "changed", ActiveRecord::Migrator.schema_migrations_table_name
  ensure
    ActiveRecord::Base.schema_migrations_table_name = original_schema_migrations_table_name
    Reminder.reset_table_name
355 356
  end

357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382
  def test_internal_metadata_table_name
    original_internal_metadata_table_name = ActiveRecord::Base.internal_metadata_table_name

    assert_equal "active_record_internal_metadatas", ActiveRecord::InternalMetadata.table_name
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
    Reminder.reset_table_name
    assert_equal "prefix_active_record_internal_metadatas_suffix", ActiveRecord::InternalMetadata.table_name
    ActiveRecord::Base.internal_metadata_table_name = "changed"
    Reminder.reset_table_name
    assert_equal "prefix_changed_suffix", ActiveRecord::InternalMetadata.table_name
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""
    Reminder.reset_table_name
    assert_equal "changed", ActiveRecord::InternalMetadata.table_name
  ensure
    ActiveRecord::Base.internal_metadata_table_name = original_internal_metadata_table_name
    Reminder.reset_table_name
  end

  def test_internal_metadata_stores_environment
    current_env     = ActiveRecord::ConnectionHandling::DEFAULT_ENV.call
    migrations_path = MIGRATIONS_ROOT + "/valid"
    old_path        = ActiveRecord::Migrator.migrations_paths
    ActiveRecord::Migrator.migrations_paths = migrations_path

383
    assert_equal current_env, ActiveRecord::InternalMetadata[:environment]
384 385 386 387 388 389 390 391 392 393

    original_rails_env  = ENV["RAILS_ENV"]
    original_rack_env   = ENV["RACK_ENV"]
    ENV["RAILS_ENV"]    = ENV["RACK_ENV"] = "foofoo"
    new_env     = ActiveRecord::ConnectionHandling::DEFAULT_ENV.call

    refute_equal current_env, new_env

    sleep 1 # mysql by default does not store fractional seconds in the database
    ActiveRecord::Migrator.up(migrations_path)
394
    assert_equal new_env, ActiveRecord::InternalMetadata[:environment]
395 396 397 398 399 400
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
    ENV["RAILS_ENV"] = original_rails_env
    ENV["RACK_ENV"]  = original_rack_env
  end

401
  def test_proper_table_name_on_migration
402
    reminder_class = new_isolated_reminder_class
403 404 405
    migration = ActiveRecord::Migration.new
    assert_equal "table", migration.proper_table_name('table')
    assert_equal "table", migration.proper_table_name(:table)
406 407 408
    assert_equal "reminders", migration.proper_table_name(reminder_class)
    reminder_class.reset_table_name
    assert_equal reminder_class.table_name, migration.proper_table_name(reminder_class)
409 410 411 412

    # Use the model's own prefix/suffix if a model is given
    ActiveRecord::Base.table_name_prefix = "ARprefix_"
    ActiveRecord::Base.table_name_suffix = "_ARsuffix"
413 414 415 416 417 418 419
    reminder_class.table_name_prefix = 'prefix_'
    reminder_class.table_name_suffix = '_suffix'
    reminder_class.reset_table_name
    assert_equal "prefix_reminders_suffix", migration.proper_table_name(reminder_class)
    reminder_class.table_name_prefix = ''
    reminder_class.table_name_suffix = ''
    reminder_class.reset_table_name
420 421 422 423

    # Use AR::Base's prefix/suffix if string or symbol is given
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
424
    reminder_class.reset_table_name
425 426 427 428
    assert_equal "prefix_table_suffix", migration.proper_table_name('table', migration.table_name_options)
    assert_equal "prefix_table_suffix", migration.proper_table_name(:table, migration.table_name_options)
  end

429 430
  def test_rename_table_with_prefix_and_suffix
    assert !Thing.table_exists?
431 432
    ActiveRecord::Base.table_name_prefix = 'p_'
    ActiveRecord::Base.table_name_suffix = '_s'
433 434 435
    Thing.reset_table_name
    Thing.reset_sequence_name
    WeNeedThings.up
436
    Thing.reset_column_information
437 438

    assert Thing.create("content" => "hello world")
439
    assert_equal "hello world", Thing.first.content
440 441

    RenameThings.up
442
    Thing.table_name = "p_awesome_things_s"
443

444
    assert_equal "hello world", Thing.first.content
445 446 447 448 449 450 451 452 453 454 455
  ensure
    Thing.reset_table_name
    Thing.reset_sequence_name
  end

  def test_add_drop_table_with_prefix_and_suffix
    assert !Reminder.table_exists?
    ActiveRecord::Base.table_name_prefix = 'prefix_'
    ActiveRecord::Base.table_name_suffix = '_suffix'
    Reminder.reset_table_name
    Reminder.reset_sequence_name
456
    Reminder.reset_column_information
457 458
    WeNeedReminders.up
    assert Reminder.create("content" => "hello world", "remind_at" => Time.now)
459
    assert_equal "hello world", Reminder.first.content
460 461

    WeNeedReminders.down
462
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
463 464 465
  ensure
    Reminder.reset_sequence_name
  end
466

467 468 469
  def test_create_table_with_binary_column
    assert_nothing_raised {
      Person.connection.create_table :binary_testings do |t|
470
        t.column "data", :binary, :null => false
471
      end
472 473 474 475
    }

    columns = Person.connection.columns(:binary_testings)
    data_column = columns.detect { |c| c.name == "data" }
476

J
Jon Leighton 已提交
477
    assert_nil data_column.default
478

479
    Person.connection.drop_table :binary_testings, if_exists: true
480 481
  end

482 483 484 485
  unless mysql_enforcing_gtid_consistency?
    def test_create_table_with_query
      Person.connection.drop_table :table_from_query_testings rescue nil
      Person.connection.create_table(:person, force: true)
486

487
      Person.connection.create_table :table_from_query_testings, as: "SELECT id FROM person"
488

489 490 491
      columns = Person.connection.columns(:table_from_query_testings)
      assert_equal 1, columns.length
      assert_equal "id", columns.first.name
492

493 494
      Person.connection.drop_table :table_from_query_testings rescue nil
    end
495

496 497 498
    def test_create_table_with_query_from_relation
      Person.connection.drop_table :table_from_query_testings rescue nil
      Person.connection.create_table(:person, force: true)
499

500
      Person.connection.create_table :table_from_query_testings, as: Person.select(:id)
501

502 503 504
      columns = Person.connection.columns(:table_from_query_testings)
      assert_equal 1, columns.length
      assert_equal "id", columns.first.name
505

506 507
      Person.connection.drop_table :table_from_query_testings rescue nil
    end
508 509
  end

510 511 512 513 514 515 516 517 518 519 520
  if current_adapter? :OracleAdapter
    def test_create_table_with_custom_sequence_name
      # table name is 29 chars, the standard sequence name will
      # be 33 chars and should be shortened
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok do |t|
            t.column :foo, :string, :null => false
          end
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok rescue nil
521 522 523
        end
      end

524 525 526 527 528 529 530
      # should be all good w/ a custom sequence name
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' do |t|
            t.column :foo, :string, :null => false
          end
531

532
          Person.connection.execute("select suitably_short_seq.nextval from dual")
533

534 535 536 537
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' rescue nil
        end
538 539
      end

540 541 542 543
      # confirm the custom sequence got dropped
      assert_raise(ActiveRecord::StatementInvalid) do
        Person.connection.execute("select suitably_short_seq.nextval from dual")
      end
544
    end
545
  end
546

A
Abdelkader Boudih 已提交
547
  if current_adapter?(:Mysql2Adapter, :PostgreSQLAdapter)
548 549
    def test_out_of_range_limit_should_raise
      Person.connection.drop_table :test_limits rescue nil
F
Franky W 已提交
550
      e = assert_raise(ActiveRecord::ActiveRecordError, "integer limit didn't raise") do
551 552 553
        Person.connection.create_table :test_integer_limits, :force => true do |t|
          t.column :bigone, :integer, :limit => 10
        end
554 555
      end

F
Franky W 已提交
556 557
      assert_match(/No integer type has byte size 10/, e.message)

558 559 560 561 562
      unless current_adapter?(:PostgreSQLAdapter)
        assert_raise(ActiveRecord::ActiveRecordError, "text limit didn't raise") do
          Person.connection.create_table :test_text_limits, :force => true do |t|
            t.column :bigtext, :text, :limit => 0xfffffffff
          end
563 564 565
        end
      end

566 567
      Person.connection.drop_table :test_limits rescue nil
    end
568 569
  end

570
  if ActiveRecord::Base.connection.supports_advisory_locks?
571
    def test_migrator_generates_valid_lock_id
572
      migration = Class.new(ActiveRecord::Migration::Current).new
573 574
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)

575
      lock_id = migrator.send(:generate_migrator_advisory_lock_id)
576

577 578 579 580
      assert ActiveRecord::Base.connection.get_advisory_lock(lock_id),
        "the Migrator should have generated a valid lock id, but it didn't"
      assert ActiveRecord::Base.connection.release_advisory_lock(lock_id),
        "the Migrator should have generated a valid lock id, but it didn't"
581 582
    end

583
    def test_generate_migrator_advisory_lock_id
584 585
      # It is important we are consistent with how we generate this so that
      # exclusive locking works across migrator versions
586
      migration = Class.new(ActiveRecord::Migration::Current).new
587 588
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)

589
      lock_id = migrator.send(:generate_migrator_advisory_lock_id)
590 591 592

      current_database = ActiveRecord::Base.connection.current_database
      salt = ActiveRecord::Migrator::MIGRATOR_SALT
593
      expected_id = Zlib.crc32(current_database) * salt
594

595 596
      assert lock_id == expected_id, "expected lock id generated by the migrator to be #{expected_id}, but it was #{lock_id} instead"
      assert lock_id.bit_length <= 63, "lock id must be a signed integer of max 63 bits magnitude"
597 598 599 600 601
    end

    def test_migrator_one_up_with_unavailable_lock
      assert_no_column Person, :last_name

602
      migration = Class.new(ActiveRecord::Migration::Current) {
603 604 605 606 607 608 609
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
        end
      }.new

      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
610
      lock_id = migrator.send(:generate_migrator_advisory_lock_id)
611

612
      with_another_process_holding_lock(lock_id) do
613 614 615 616 617 618 619 620 621 622
        assert_raise(ActiveRecord::ConcurrentMigrationError) { migrator.migrate }
      end

      assert_no_column Person, :last_name,
        "without an advisory lock, the Migrator should not make any changes, but it did."
    end

    def test_migrator_one_up_with_unavailable_lock_using_run
      assert_no_column Person, :last_name

623
      migration = Class.new(ActiveRecord::Migration::Current) {
624 625 626 627 628 629 630
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
        end
      }.new

      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
631
      lock_id = migrator.send(:generate_migrator_advisory_lock_id)
632

633
      with_another_process_holding_lock(lock_id) do
634 635 636 637 638 639 640 641
        assert_raise(ActiveRecord::ConcurrentMigrationError) { migrator.run }
      end

      assert_no_column Person, :last_name,
        "without an advisory lock, the Migrator should not make any changes, but it did."
    end
  end

642
  protected
643 644 645 646 647 648 649 650
    # This is needed to isolate class_attribute assignments like `table_name_prefix`
    # for each test case.
    def new_isolated_reminder_class
      Class.new(Reminder) {
        def self.name; "Reminder"; end
        def self.base_class; self; end
      }
    end
651

652
    def with_another_process_holding_lock(lock_id)
A
Aaron Patterson 已提交
653 654
      thread_lock = Concurrent::CountDownLatch.new
      test_terminated = Concurrent::CountDownLatch.new
655 656 657 658

      other_process = Thread.new do
        begin
          conn = ActiveRecord::Base.connection_pool.checkout
659
          conn.get_advisory_lock(lock_id)
A
Aaron Patterson 已提交
660 661
          thread_lock.count_down
          test_terminated.wait # hold the lock open until we tested everything
662
        ensure
663
          conn.release_advisory_lock(lock_id)
664 665 666 667
          ActiveRecord::Base.connection_pool.checkin(conn)
        end
      end

A
Aaron Patterson 已提交
668
      thread_lock.wait # wait until the 'other process' has the lock
669 670 671

      yield

A
Aaron Patterson 已提交
672
      test_terminated.count_down
673 674
      other_process.join
    end
675
end
676

677 678 679 680 681
class ReservedWordsMigrationTest < ActiveRecord::TestCase
  def test_drop_index_from_table_named_values
    connection = Person.connection
    connection.create_table :values, :force => true do |t|
      t.integer :value
682
    end
683

684 685 686
    assert_nothing_raised do
      connection.add_index :values, :value
      connection.remove_index :values, :column => :value
687
    end
688

689 690 691 692
    connection.drop_table :values rescue nil
  end
end

693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708
class ExplicitlyNamedIndexMigrationTest < ActiveRecord::TestCase
  def test_drop_index_by_name
    connection = Person.connection
    connection.create_table :values, force: true do |t|
      t.integer :value
    end

    assert_nothing_raised ArgumentError do
      connection.add_index :values, :value, name: 'a_different_name'
      connection.remove_index :values, column: :value, name: 'a_different_name'
    end

    connection.drop_table :values rescue nil
  end
end

709 710 711 712 713
if ActiveRecord::Base.connection.supports_bulk_alter?
  class BulkAlterTableMigrationsTest < ActiveRecord::TestCase
    def setup
      @connection = Person.connection
      @connection.create_table(:delete_me, :force => true) {|t| }
A
Akira Matsuda 已提交
714 715
      Person.reset_column_information
      Person.reset_sequence_name
716
    end
717

G
Guo Xiang Tan 已提交
718
    teardown do
719 720
      Person.connection.drop_table(:delete_me) rescue nil
    end
721

722 723
    def test_adding_multiple_columns
      assert_queries(1) do
724
        with_bulk_change_table do |t|
725
          t.column :name, :string
726
          t.string :qualification, :experience
727 728
          t.integer :age, :default => 0
          t.date :birthdate
729
          t.timestamps null: true
730
        end
731
      end
732

733 734
      assert_equal 8, columns.size
      [:name, :qualification, :experience].each {|s| assert_equal :string, column(s).type }
735
      assert_equal '0', column(:age).default
736
    end
737

738 739 740
    def test_removing_columns
      with_bulk_change_table do |t|
        t.string :qualification, :experience
741 742
      end

743
      [:qualification, :experience].each {|c| assert column(c) }
744

745 746 747 748
      assert_queries(1) do
        with_bulk_change_table do |t|
          t.remove :qualification, :experience
          t.string :qualification_experience
749
        end
750
      end
751

752 753 754
      [:qualification, :experience].each {|c| assert ! column(c) }
      assert column(:qualification_experience)
    end
755

756 757 758 759 760
    def test_adding_indexes
      with_bulk_change_table do |t|
        t.string :username
        t.string :name
        t.integer :age
761 762
      end

763 764
      # Adding an index fires a query every time to check if an index already exists or not
      assert_queries(3) do
765
        with_bulk_change_table do |t|
766 767
          t.index :username, :unique => true, :name => :awesome_username_index
          t.index [:name, :age]
768
        end
769
      end
770

771
      assert_equal 2, indexes.size
772

773 774 775
      name_age_index = index(:index_delete_me_on_name_and_age)
      assert_equal ['name', 'age'].sort, name_age_index.columns.sort
      assert ! name_age_index.unique
776

777 778
      assert index(:awesome_username_index).unique
    end
779

780 781 782 783
    def test_removing_index
      with_bulk_change_table do |t|
        t.string :name
        t.index :name
784
      end
785

786 787 788
      assert index(:index_delete_me_on_name)

      assert_queries(3) do
789
        with_bulk_change_table do |t|
790 791
          t.remove_index :name
          t.index :name, :name => :new_name_index, :unique => true
792
        end
793
      end
794

795
      assert ! index(:index_delete_me_on_name)
796

797 798 799
      new_name_index = index(:new_name_index)
      assert new_name_index.unique
    end
800

801 802 803 804
    def test_changing_columns
      with_bulk_change_table do |t|
        t.string :name
        t.date :birthdate
805
      end
806

807 808
      assert ! column(:name).default
      assert_equal :date, column(:birthdate).type
809

810 811 812
      # One query for columns (delete_me table)
      # One query for primary key (delete_me table)
      # One query to do the bulk change
813
      assert_queries(3, :ignore_none => true) do
814 815 816
        with_bulk_change_table do |t|
          t.change :name, :string, :default => 'NONAME'
          t.change :birthdate, :datetime
817
        end
818 819
      end

820 821 822
      assert_equal 'NONAME', column(:name).default
      assert_equal :datetime, column(:birthdate).type
    end
823

824
    protected
825

826 827 828
    def with_bulk_change_table
      # Reset columns/indexes cache as we're changing the table
      @columns = @indexes = nil
829

830 831
      Person.connection.change_table(:delete_me, :bulk => true) do |t|
        yield t
832
      end
833
    end
834

835 836 837
    def column(name)
      columns.detect {|c| c.name == name.to_s }
    end
838

839 840
    def columns
      @columns ||= Person.connection.columns('delete_me')
841 842
    end

843 844
    def index(name)
      indexes.detect {|i| i.name == name.to_s }
845 846
    end

847 848 849 850 851 852 853 854
    def indexes
      @indexes ||= Person.connection.indexes('delete_me')
    end
  end # AlterTableMigrationsTest

end

class CopyMigrationsTest < ActiveRecord::TestCase
855 856
  include ActiveSupport::Testing::Stream

857 858 859 860 861 862 863 864 865 866 867 868 869 870 871
  def setup
  end

  def clear
    ActiveRecord::Base.timestamped_migrations = true
    to_delete = Dir[@migrations_path + "/*.rb"] - @existing_migrations
    File.delete(*to_delete)
  end

  def test_copying_migrations_without_timestamps
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
A
Arun Agrawal 已提交
872 873
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891
    assert_equal [@migrations_path + "/4_people_have_hobbies.bukkits.rb", @migrations_path + "/5_people_have_descriptions.bukkits.rb"], copied.map(&:filename)

    expected = "# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_people_have_hobbies.bukkits.rb")[0].chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

  def test_copying_migrations_without_timestamps_from_2_sources
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

892
    sources = {}
893 894 895
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy"
    sources[:omg] = MIGRATIONS_ROOT + "/to_copy2"
    ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
896 897 898 899
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
    assert File.exist?(@migrations_path + "/6_create_articles.omg.rb")
    assert File.exist?(@migrations_path + "/7_create_comments.omg.rb")
900 901 902 903 904 905 906

    files_count = Dir[@migrations_path + "/*.rb"].length
    ActiveRecord::Migration.copy(@migrations_path, sources)
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
  ensure
    clear
  end
907

908 909 910
  def test_copying_migrations_with_timestamps
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
911

912
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
913
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
914 915
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
916 917 918
      expected = [@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb",
                  @migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb"]
      assert_equal expected, copied.map(&:filename)
919

920
      files_count = Dir[@migrations_path + "/*.rb"].length
921
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
922 923 924
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
    end
925 926 927
  ensure
    clear
  end
928

929 930 931
  def test_copying_migrations_with_timestamps_from_2_sources
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
932

933
    sources = {}
934 935 936
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_timestamps2"

937
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
938
      copied = ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
939 940 941 942
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101012_create_articles.omg.rb")
      assert File.exist?(@migrations_path + "/20100726101013_create_comments.omg.rb")
943
      assert_equal 4, copied.length
944 945 946 947 948

      files_count = Dir[@migrations_path + "/*.rb"].length
      ActiveRecord::Migration.copy(@migrations_path, sources)
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    end
949 950 951
  ensure
    clear
  end
952

953 954 955
  def test_copying_migrations_with_timestamps_to_destination_with_timestamps_in_future
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
956

957
    travel_to(Time.utc(2010, 2, 20, 10, 10, 10)) do
958
      ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
959 960
      assert File.exist?(@migrations_path + "/20100301010102_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100301010103_people_have_descriptions.bukkits.rb")
961

962 963 964 965
      files_count = Dir[@migrations_path + "/*.rb"].length
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
966
    end
967 968 969
  ensure
    clear
  end
970

971 972 973 974 975 976
  def test_copying_migrations_preserving_magic_comments
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
A
Arun Agrawal 已提交
977
    assert File.exist?(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")
978 979 980 981 982 983 984 985 986 987 988 989 990
    assert_equal [@migrations_path + "/4_currencies_have_symbols.bukkits.rb"], copied.map(&:filename)

    expected = "# coding: ISO-8859-15\n# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")[0..1].join.chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

991 992 993
  def test_skipping_migrations
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
994 995

    sources = {}
996 997
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_name_collision"
998

999 1000 1001 1002
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    assert_equal 2, copied.length
1003

1004 1005 1006 1007 1008
    assert_equal 1, skipped.length
    assert_equal ["omg PeopleHaveHobbies"], skipped
  ensure
    clear
  end
1009

1010 1011 1012
  def test_skip_is_not_called_if_migrations_are_from_the_same_plugin
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
1013

1014
    sources = {}
1015
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
1016

1017 1018 1019 1020
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
1021

1022 1023 1024 1025 1026
    assert_equal 2, copied.length
    assert_equal 0, skipped.length
  ensure
    clear
  end
1027

1028 1029 1030
  def test_copying_migrations_to_non_existing_directory
    @migrations_path = MIGRATIONS_ROOT + "/non_existing"
    @existing_migrations = []
1031

1032
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
1033
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
1034 1035
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
1036 1037
      assert_equal 2, copied.length
    end
1038 1039 1040 1041
  ensure
    clear
    Dir.delete(@migrations_path)
  end
1042

1043 1044 1045
  def test_copying_migrations_to_empty_directory
    @migrations_path = MIGRATIONS_ROOT + "/empty"
    @existing_migrations = []
1046

1047
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
1048
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
1049 1050
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
1051
      assert_equal 2, copied.length
1052
    end
1053 1054
  ensure
    clear
1055
  end
1056 1057 1058 1059 1060 1061 1062 1063 1064

  def test_check_pending_with_stdlib_logger
    old, ActiveRecord::Base.logger = ActiveRecord::Base.logger, ::Logger.new($stdout)
    quietly do
      assert_nothing_raised { ActiveRecord::Migration::CheckPending.new(Proc.new {}).call({}) }
    end
  ensure
    ActiveRecord::Base.logger = old
  end
1065

1066
end