The problem was that the arguments for the string interpolation
were not passed as a tuple, as they should. When hitting
an unknown migration protocol error, the return would raise
a TypeError. Let's fix it.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: Nyangdongsheng <yangds.fnst@cn.fujitsu.com>

Lots of times to call vmxml.undefine() and vmxml.define(), to
make our config in vmxml take effect in vm.
Signed-off-by: Nyangdongsheng <yangds.fnst@cn.fujitsu.com>

Signed-off-by: Nyangdongsheng <yangds.fnst@cn.fujitsu.com>

Turns out RHEL5 qemu does not support the 'info qtree'
command, therefore an attempt to parse the output of
this command will fail. So skip that particular check
when running on this particular qemu version.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

On RHEL5, we were not passing boot=on properly to the
qemu-kvm binary. Fix the heuristics to detect whether
the binary uses this ancient syntax to define virtio
disks as bootable.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Use the unified configs (scsiid=>unit, lun=>port) and store the images
in the usual location. The location '/tmp/%s' was used before because
python was unable to execute that long command and this prefix shorten
it significantly. Now autotest supports the way to deal with long
commands so we can finally store the images in the right location.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Some cases create many disks, which takes a long time, where most
time consumes the handling around cmd execution. This patch parallelize
the image processing in case we deal with over 20 disks. It spawns
$no_cpus * 2 threads (or less in case it would be inefficient).

The performance improvement was significant (30=>12s on 4CPU system).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Current kernels support unlimited argument length, the only limit is
stack size. The default stack size is usually 8KB which is sufficient
for ~2MB commands. Use ulimit to increase these limits. The multi_disk
in some configurations attacks the 2MB barier and in the future we
might see this comming (unless we switch to -readconfig).

NOTE: Only superuser can increase the hard limit, anyway if the command
      fails the test continues and tries to execute the cmd anyway.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

virttest.qemu_devices: Fix floppy issues

Old qemu without -global support must use -drive index=n
to set the floppy slot.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

image_format is usually set for images. Floppies usually use raw so
we'd have to either set image format for floppies or we can simply
ignore it (this solution).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

media accepts only disk or cdrom. Use media='' to ignore it even in
strict_mode. (strict_mode sets media=disk when media is None)
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

qemu.test: add reboot step for pci_hotplug testing

Before upstream qemu commit

  commit 56c4bfb3f07f3107894c00281276aea4f5e8834d
  Author: Laszlo Ersek <lersek@redhat.com>
  Date:   Tue Aug 6 12:37:11 2013 +0200

      dump: rebase from host-private RAMBlock offsets to guest-physical
      addresses

the dump-guest-memory QMP command used to write incorrect vmcores for
x86_64 guests with more than 3.5GB RAM. Add a testcase that creates a 4GB
guest, dumps its core, copies it into the guest, and analyzes it there
with the "crash" utility.

Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=981582
Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=990118Suggested-by: NAdemar de Souza Reis Jr. <areis@redhat.com>
Signed-off-by: NLaszlo Ersek <lersek@redhat.com>

Signed-off-by: NYanbing Du <ydu@redhat.com>

Signed-off-by: NYanbing Du <ydu@redhat.com>

We need step reboot guest after hotplug/unplug pci device to verify guest
not crash or hang when reboot;
Signed-off-by: NXu Tian <xutian@redhat.com>

Enhance pci_test_cmd for block_hotplug testing 

Add rescan and list disk steps; Do rescan to ensure diskpart read latest disk
configuration and it will avoid diskpart report
'The disk you specified is not valid.' error, list disk step will record disk
info before check disk drive;
New steps will helpful for debugging when test failed at pci device test step;
Signed-off-by: NXu Tian <xutian@redhat.com>

Small fix for unattended_install.floppy_ks test

Reading ks from floppy driectly isn't works for some distr but boot option
'ks=hd:/dev/fd0' can reading ks from mounted floppy; so skip replace
this options;
Signed-off-by: NXu Tian <xutian@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

* Simple/minimal implementation with passwd property, more can be added
  later.
* Thanks to Kyla - Wei Zhang <weizhan@redhat.com> for requesting and
  helping test.
* Added unittest for graphics device to verify changes are commited to
  vm_xml instance.
Signed-off-by: NChris Evich <cevich@redhat.com>

Readonly mode is an important part for virsh command,so add
a boolean parameter 'readonly' when execute virsh commnd.
Signed-off-by: NYanbing Du <ydu@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

sr-iov:  Update PciAssignable class to support more feature.

For pci-assign we need not get all the same group device.
Signed-off-by: NFeng Yang <fyang@redhat.com>

virttest.test_setup: Fix issue that 'pci-assign' is treated as not support in some host which really support it.

In some host pci-assign is aliased as kvm-pci-assign in qemu-kvm -device ?
So pci-assign is treated as not support. Add code to fix this.
Signed-off-by: NFeng Yang <fyang@redhat.com>

It used to set which device we want to use in device assignment test
Signed-off-by: NFeng Yang <fyang@redhat.com>

Also add new function get_same_group_devs() to get devices in same
group.

Get device's driver from /sys/bus/pci/devices/[device id]/driver
Signed-off-by: NFeng Yang <fyang@redhat.com>

Signed-off-by: NFeng Yang <fyang@redhat.com>

In this patch have following update:
1. Delete self.type_list and introduce self.devices.
2. Update add_device() to support mac setting for VF.
3. Update get_devs() to use new get_vf_devs() and get_pf_devs().
4. Update kvm parameter by echo to /sys folder.
5. Support set mac for VF.
6. Update the way used to update kvm module parameter.
Signed-off-by: NFeng Yang <fyang@redhat.com>

get requested vf or pf from self.pf_vf_info list.
Signed-off-by: NFeng Yang <fyang@redhat.com>

Get the PF PCI ID from self.pf_vf_info.
Return the first available PF if name is not set.
Signed-off-by: NFeng Yang <fyang@redhat.com>

This function will return corresponding pf eth name and vf num according to vf id.
We need use pf eth name and vf num when setting mac for vf.
Signed-off-by: NFeng Yang <fyang@redhat.com>