merge_request_spec.rb 62.0 KB
Newer Older
D
Dmitriy Zaporozhets 已提交
1 2
require 'spec_helper'

3
describe MergeRequest do
4
  include RepoHelpers
B
Bob Van Landuyt 已提交
5
  include ProjectForksHelper
6

7 8
  subject { create(:merge_request) }

R
Robert Speicher 已提交
9
  describe 'associations' do
10 11
    it { is_expected.to belong_to(:target_project).class_name('Project') }
    it { is_expected.to belong_to(:source_project).class_name('Project') }
12
    it { is_expected.to belong_to(:merge_user).class_name("User") }
13
    it { is_expected.to belong_to(:assignee) }
14
    it { is_expected.to have_many(:merge_request_diffs) }
R
Robert Speicher 已提交
15 16
  end

17 18 19 20 21 22 23 24 25 26 27
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(InternalId) }
    it { is_expected.to include_module(Issuable) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(Taskable) }
  end

  describe 'validation' do
28 29
    it { is_expected.to validate_presence_of(:target_branch) }
    it { is_expected.to validate_presence_of(:source_branch) }
Z
Zeger-Jan van de Weg 已提交
30

31
    context "Validation of merge user with Merge When Pipeline Succeeds" do
Z
Zeger-Jan van de Weg 已提交
32 33 34 35 36
      it "allows user to be nil when the feature is disabled" do
        expect(subject).to be_valid
      end

      it "is invalid without merge user" do
J
James Lopez 已提交
37
        subject.merge_when_pipeline_succeeds = true
Z
Zeger-Jan van de Weg 已提交
38 39 40 41
        expect(subject).not_to be_valid
      end

      it "is valid with merge user" do
J
James Lopez 已提交
42
        subject.merge_when_pipeline_succeeds = true
Z
Zeger-Jan van de Weg 已提交
43 44 45 46 47
        subject.merge_user = build(:user)

        expect(subject).to be_valid
      end
    end
48 49 50

    context 'for forks' do
      let(:project) { create(:project) }
B
Bob Van Landuyt 已提交
51 52
      let(:fork1) { fork_project(project) }
      let(:fork2) { fork_project(project) }
53 54 55 56 57 58 59 60

      it 'allows merge requests for sibling-forks' do
        subject.source_project = fork1
        subject.target_project = fork2

        expect(subject).to be_valid
      end
    end
D
Dmitriy Zaporozhets 已提交
61 62
  end

63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81
  describe 'callbacks' do
    describe '#ensure_merge_request_metrics' do
      it 'creates metrics after saving' do
        merge_request = create(:merge_request)

        expect(merge_request.metrics).to be_persisted
        expect(MergeRequest::Metrics.count).to eq(1)
      end

      it 'does not duplicate metrics for a merge request' do
        merge_request = create(:merge_request)

        merge_request.mark_as_merged!

        expect(MergeRequest::Metrics.count).to eq(1)
      end
    end
  end

R
Robert Speicher 已提交
82
  describe 'respond to' do
83 84 85
    it { is_expected.to respond_to(:unchecked?) }
    it { is_expected.to respond_to(:can_be_merged?) }
    it { is_expected.to respond_to(:cannot_be_merged?) }
86
    it { is_expected.to respond_to(:merge_params) }
J
James Lopez 已提交
87
    it { is_expected.to respond_to(:merge_when_pipeline_succeeds) }
88
  end
A
Andrey Kumanyaev 已提交
89

90 91 92 93 94 95
  describe '.in_projects' do
    it 'returns the merge requests for a set of projects' do
      expect(described_class.in_projects(Project.all)).to eq([subject])
    end
  end

96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132
  describe '.set_latest_merge_request_diff_ids!' do
    def create_merge_request_with_diffs(source_branch, diffs: 2)
      params = {
        target_project: project,
        target_branch: 'master',
        source_project: project,
        source_branch: source_branch
      }

      create(:merge_request, params).tap do |mr|
        diffs.times { mr.merge_request_diffs.create }
      end
    end

    let(:project) { create(:project) }

    it 'sets IDs for merge requests, whether they are already set or not' do
      merge_requests = [
        create_merge_request_with_diffs('feature'),
        create_merge_request_with_diffs('feature-conflict'),
        create_merge_request_with_diffs('wip', diffs: 0),
        create_merge_request_with_diffs('csv')
      ]

      merge_requests.take(2).each do |merge_request|
        merge_request.update_column(:latest_merge_request_diff_id, nil)
      end

      expected = merge_requests.map do |merge_request|
        merge_request.merge_request_diffs.maximum(:id)
      end

      expect { project.merge_requests.set_latest_merge_request_diff_ids! }
        .to change { merge_requests.map { |mr| mr.reload.latest_merge_request_diff_id } }.to(expected)
    end
  end

133
  describe '#target_branch_sha' do
134
    let(:project) { create(:project, :repository) }
135

136
    subject { create(:merge_request, source_project: project, target_project: project) }
137

138
    context 'when the target branch does not exist' do
139
      before do
140
        project.repository.rm_branch(subject.author, subject.target_branch)
141
        subject.clear_memoized_shas
142
      end
143 144

      it 'returns nil' do
145
        expect(subject.target_branch_sha).to be_nil
146 147
      end
    end
148 149 150 151 152 153

    it 'returns memoized value' do
      subject.target_branch_sha = '8ffb3c15a5475e59ae909384297fede4badcb4c7'

      expect(subject.target_branch_sha).to eq '8ffb3c15a5475e59ae909384297fede4badcb4c7'
    end
154 155
  end

156 157 158 159 160
  describe '#card_attributes' do
    it 'includes the author name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignee).and_return(nil)

161 162
      expect(subject.card_attributes)
        .to eq({ 'Author' => 'Robert', 'Assignee' => nil })
163 164 165 166 167 168
    end

    it 'includes the assignee name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignee).and_return(double(name: 'Douwe'))

169 170
      expect(subject.card_attributes)
        .to eq({ 'Author' => 'Robert', 'Assignee' => 'Douwe' })
171 172 173
    end
  end

174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189
  describe '#assignee_ids' do
    it 'returns an array of the assigned user id' do
      subject.assignee_id = 123

      expect(subject.assignee_ids).to eq([123])
    end
  end

  describe '#assignee_ids=' do
    it 'sets assignee_id to the last id in the array' do
      subject.assignee_ids = [123, 456]

      expect(subject.assignee_id).to eq(456)
    end
  end

190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209
  describe '#assignee_or_author?' do
    let(:user) { create(:user) }

    it 'returns true for a user that is assigned to a merge request' do
      subject.assignee = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns true for a user that is the author of a merge request' do
      subject.author = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns false for a user that is not the assignee or author' do
      expect(subject.assignee_or_author?(user)).to eq(false)
    end
  end

210 211
  describe '#cache_merge_request_closes_issues!' do
    before do
212
      subject.project.add_developer(subject.author)
213 214 215 216 217 218 219 220
      subject.target_branch = subject.project.default_branch
    end

    it 'caches closed issues' do
      issue  = create :issue, project: subject.project
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])

221
      expect { subject.cache_merge_request_closes_issues!(subject.author) }.to change(subject.merge_requests_closing_issues, :count).by(1)
222 223
    end

224 225 226 227
    context 'when both internal and external issue trackers are enabled' do
      before do
        subject.project.has_external_issue_tracker = true
        subject.project.save!
228
        create(:jira_service, project: subject.project)
229 230 231 232 233 234
      end

      it 'does not cache issues from external trackers' do
        issue  = ExternalIssue.new('JIRA-123', subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])
235

236
        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to raise_error
237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272
        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
      end

      it 'caches an internal issue' do
        issue  = create(:issue, project: subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }
          .to change(subject.merge_requests_closing_issues, :count).by(1)
      end
    end

    context 'when only external issue tracker enabled' do
      before do
        subject.project.has_external_issue_tracker = true
        subject.project.issues_enabled = false
        subject.project.save!
      end

      it 'does not cache issues from external trackers' do
        issue  = ExternalIssue.new('JIRA-123', subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
      end

      it 'does not cache an internal issue' do
        issue  = create(:issue, project: subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }
          .not_to change(subject.merge_requests_closing_issues, :count)
      end
273 274 275
    end
  end

276
  describe '#source_branch_sha' do
277
    let(:last_branch_commit) { subject.source_project.repository.commit(Gitlab::Git::BRANCH_REF_PREFIX + subject.source_branch) }
278 279 280 281

    context 'with diffs' do
      subject { create(:merge_request, :with_diffs) }
      it 'returns the sha of the source branch last commit' do
282
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
283 284 285
      end
    end

286 287 288
    context 'without diffs' do
      subject { create(:merge_request, :without_diffs) }
      it 'returns the sha of the source branch last commit' do
289
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
290
      end
291 292 293 294 295 296 297 298 299 300 301 302 303 304 305

      context 'when there is a tag name matching the branch name' do
        let(:tag_name) { subject.source_branch }

        it 'returns the sha of the source branch last commit' do
          subject.source_project.repository.add_tag(subject.author,
                                                    tag_name,
                                                    subject.target_branch_sha,
                                                    'Add a tag')

          expect(subject.source_branch_sha).to eq(last_branch_commit.sha)

          subject.source_project.repository.rm_tag(subject.author, tag_name)
        end
      end
306 307
    end

308 309 310
    context 'when the merge request is being created' do
      subject { build(:merge_request, source_branch: nil, compare_commits: []) }
      it 'returns nil' do
311
        expect(subject.source_branch_sha).to be_nil
312 313
      end
    end
314 315 316 317 318 319

    it 'returns memoized value' do
      subject.source_branch_sha = '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'

      expect(subject.source_branch_sha).to eq '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
    end
320 321
  end

322
  describe '#to_reference' do
323
    let(:project) { build(:project, name: 'sample-project') }
324 325
    let(:merge_request) { build(:merge_request, target_project: project, iid: 1) }

326
    it 'returns a String reference to the object' do
327
      expect(merge_request.to_reference).to eq "!1"
328 329 330
    end

    it 'supports a cross-project reference' do
331
      another_project = build(:project, name: 'another-project', namespace: project.namespace)
332
      expect(merge_request.to_reference(another_project)).to eq "sample-project!1"
333
    end
334 335

    it 'returns a String reference with the full path' do
336
      expect(merge_request.to_reference(full: true)).to eq(project.full_path + '!1')
337
    end
338
  end
339

340
  describe '#raw_diffs' do
S
Sean McGivern 已提交
341 342 343 344 345 346 347
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
        merge_request.merge_request_diff = MergeRequestDiff.new

348
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(options)
S
Sean McGivern 已提交
349

350 351 352 353 354 355 356 357 358 359 360 361 362 363 364
        merge_request.raw_diffs(options)
      end
    end

    context 'when there are no MR diffs' do
      it 'delegates to the compare object' do
        merge_request.compare = double(:compare)

        expect(merge_request.compare).to receive(:raw_diffs).with(options)

        merge_request.raw_diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
365 366 367 368 369 370
  describe '#diffs' do
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
371
        merge_request.save
S
Sean McGivern 已提交
372

373
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(hash_including(options))
S
Sean McGivern 已提交
374 375 376 377 378 379

        merge_request.diffs(options)
      end
    end

    context 'when there are no MR diffs' do
380
      it 'delegates to the compare object, setting expanded: true' do
S
Sean McGivern 已提交
381 382
        merge_request.compare = double(:compare)

383
        expect(merge_request.compare).to receive(:diffs).with(options.merge(expanded: true))
S
Sean McGivern 已提交
384 385 386 387 388 389

        merge_request.diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
390 391 392 393 394 395
  describe '#diff_size' do
    let(:merge_request) do
      build(:merge_request, source_branch: 'expand-collapse-files', target_branch: 'master')
    end

    context 'when there are MR diffs' do
396
      it 'returns the correct count' do
S
Sean McGivern 已提交
397
        merge_request.save
398 399

        expect(merge_request.diff_size).to eq('105')
S
Sean McGivern 已提交
400 401
      end

402 403 404 405 406
      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        merge_request.save

        expect(merge_request.diff_size).to eq('2+')
S
Sean McGivern 已提交
407 408 409
      end

      it 'does not perform highlighting' do
410 411
        merge_request.save

S
Sean McGivern 已提交
412 413 414 415 416 417 418
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end

    context 'when there are no MR diffs' do
419
      def set_compare(merge_request)
S
Sean McGivern 已提交
420 421 422 423 424 425 426 427 428 429
        merge_request.compare = CompareService.new(
          merge_request.source_project,
          merge_request.source_branch
        ).execute(
          merge_request.target_project,
          merge_request.target_branch
        )
      end

      it 'returns the correct count' do
430 431 432 433 434 435 436 437 438 439
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('105')
      end

      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('2+')
S
Sean McGivern 已提交
440 441 442
      end

      it 'does not perform highlighting' do
443 444
        set_compare(merge_request)

S
Sean McGivern 已提交
445 446 447 448 449 450 451
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end
  end

452
  describe "#related_notes" do
453
    let!(:merge_request) { create(:merge_request) }
454 455

    before do
456
      allow(merge_request).to receive(:commits) { [merge_request.source_project.repository.commit] }
457 458
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.project)
D
Dmitriy Zaporozhets 已提交
459
      create(:note, noteable: merge_request, project: merge_request.project)
460 461
    end

462
    it "includes notes for commits" do
463
      expect(merge_request.commits).not_to be_empty
464
      expect(merge_request.related_notes.count).to eq(2)
465
    end
466

467
    it "includes notes for commits from target project as well" do
468 469 470
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.target_project)

471
      expect(merge_request.commits).not_to be_empty
472
      expect(merge_request.related_notes.count).to eq(3)
473
    end
474
  end
475

I
Izaak Alpert 已提交
476 477
  describe '#for_fork?' do
    it 'returns true if the merge request is for a fork' do
478 479
      subject.source_project = build_stubbed(:project, namespace: create(:group))
      subject.target_project = build_stubbed(:project, namespace: create(:group))
I
Izaak Alpert 已提交
480

481
      expect(subject.for_fork?).to be_truthy
I
Izaak Alpert 已提交
482
    end
D
Dmitriy Zaporozhets 已提交
483

I
Izaak Alpert 已提交
484
    it 'returns false if is not for a fork' do
485
      expect(subject.for_fork?).to be_falsey
I
Izaak Alpert 已提交
486 487 488
    end
  end

489
  describe '#closes_issues' do
490 491
    let(:issue0) { create :issue, project: subject.project }
    let(:issue1) { create :issue, project: subject.project }
492 493 494 495

    let(:commit0) { double('commit0', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit1) { double('commit1', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit2) { double('commit2', safe_message: "Fixes #{issue1.to_reference}") }
496 497

    before do
498
      subject.project.add_developer(subject.author)
499
      allow(subject).to receive(:commits).and_return([commit0, commit1, commit2])
500 501
    end

502
    it 'accesses the set of issues that will be closed on acceptance' do
503 504
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
505

506
      closed = subject.closes_issues
507

508 509
      expect(closed).to include(issue0, issue1)
    end
510

511 512 513
    it 'only lists issues as to be closed if it targets the default branch' do
      allow(subject.project).to receive(:default_branch).and_return('master')
      subject.target_branch = 'something-else'
514

515
      expect(subject.closes_issues).to be_empty
516
    end
517
  end
518

519
  describe '#issues_mentioned_but_not_closing' do
520 521 522 523
    let(:closing_issue) { create :issue, project: subject.project }
    let(:mentioned_issue) { create :issue, project: subject.project }

    let(:commit) { double('commit', safe_message: "Fixes #{closing_issue.to_reference}") }
524

525
    it 'detects issues mentioned in description but not closed' do
526
      subject.project.add_developer(subject.author)
527
      subject.description = "Is related to #{mentioned_issue.to_reference} and #{closing_issue.to_reference}"
528

529
      allow(subject).to receive(:commits).and_return([commit])
530 531
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
532

533
      expect(subject.issues_mentioned_but_not_closing(subject.author)).to match_array([mentioned_issue])
534
    end
535 536 537

    context 'when the project has an external issue tracker' do
      before do
538
        subject.project.add_developer(subject.author)
539 540 541 542 543 544 545 546 547 548 549 550 551
        commit = double(:commit, safe_message: 'Fixes TEST-3')

        create(:jira_service, project: subject.project)

        allow(subject).to receive(:commits).and_return([commit])
        allow(subject).to receive(:description).and_return('Is related to TEST-2 and TEST-3')
        allow(subject.project).to receive(:default_branch).and_return(subject.target_branch)
      end

      it 'detects issues mentioned in description but not closed' do
        expect(subject.issues_mentioned_but_not_closing(subject.author).map(&:to_s)).to match_array(['TEST-2'])
      end
    end
552 553
  end

554
  describe "#work_in_progress?" do
555 556 557
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "detects the '#{wip_prefix}' prefix" do
        subject.title = "#{wip_prefix}#{subject.title}"
558
        expect(subject.work_in_progress?).to eq true
559
      end
T
Ted Hogan 已提交
560 561
    end

562 563
    it "doesn't detect WIP for words starting with WIP" do
      subject.title = "Wipwap #{subject.title}"
564
      expect(subject.work_in_progress?).to eq false
565 566
    end

567 568
    it "doesn't detect WIP for words containing with WIP" do
      subject.title = "WupWipwap #{subject.title}"
569
      expect(subject.work_in_progress?).to eq false
570 571
    end

572
    it "doesn't detect WIP by default" do
573
      expect(subject.work_in_progress?).to eq false
574 575 576
    end
  end

T
Thomas Balthazar 已提交
577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599
  describe "#wipless_title" do
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "removes the '#{wip_prefix}' prefix" do
        wipless_title = subject.title
        subject.title = "#{wip_prefix}#{subject.title}"

        expect(subject.wipless_title).to eq wipless_title
      end

      it "is satisfies the #work_in_progress? method" do
        subject.title = "#{wip_prefix}#{subject.title}"
        subject.title = subject.wipless_title

        expect(subject.work_in_progress?).to eq false
      end
    end
  end

  describe "#wip_title" do
    it "adds the WIP: prefix to the title" do
      wip_title = "WIP: #{subject.title}"

      expect(subject.wip_title).to eq wip_title
600
    end
T
Thomas Balthazar 已提交
601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616

    it "does not add the WIP: prefix multiple times" do
      wip_title = "WIP: #{subject.title}"
      subject.title = subject.wip_title
      subject.title = subject.wip_title

      expect(subject.wip_title).to eq wip_title
    end

    it "is satisfies the #work_in_progress? method" do
      subject.title = subject.wip_title

      expect(subject.work_in_progress?).to eq true
    end
  end

Z
Zeger-Jan van de Weg 已提交
617
  describe '#can_remove_source_branch?' do
618 619
    set(:user) { create(:user) }
    set(:merge_request) { create(:merge_request, :simple) }
620

621
    subject { merge_request }
622

623 624
    before do
      subject.source_project.add_master(user)
Z
Zeger-Jan van de Weg 已提交
625
    end
626

Z
Zeger-Jan van de Weg 已提交
627
    it "can't be removed when its a protected branch" do
628
      allow(ProtectedBranch).to receive(:protected?).and_return(true)
629

630 631 632
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

633
    it "can't remove a root ref" do
634
      subject.update(source_branch: 'master', target_branch: 'feature')
635 636 637 638

      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

Z
Zeger-Jan van de Weg 已提交
639
    it "is unable to remove the source branch for a project the user cannot push to" do
640 641
      user2 = create(:user)

Z
Zeger-Jan van de Weg 已提交
642 643 644
      expect(subject.can_remove_source_branch?(user2)).to be_falsey
    end

645
    it "can be removed if the last commit is the head of the source branch" do
646
      allow(subject).to receive(:source_branch_head).and_return(subject.diff_head_commit)
647

Z
Zeger-Jan van de Weg 已提交
648
      expect(subject.can_remove_source_branch?(user)).to be_truthy
649
    end
650 651

    it "cannot be removed if the last commit is not also the head of the source branch" do
652
      subject.clear_memoized_shas
653 654
      subject.source_branch = "lfs"

655 656
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end
657 658
  end

659 660 661 662 663 664 665 666 667 668 669 670 671 672 673
  describe '#merge_commit_message' do
    it 'includes merge information as the title' do
      request = build(:merge_request, source_branch: 'source', target_branch: 'target')

      expect(request.merge_commit_message)
        .to match("Merge branch 'source' into 'target'\n\n")
    end

    it 'includes its title in the body' do
      request = build(:merge_request, title: 'Remove all technical debt')

      expect(request.merge_commit_message)
        .to match("Remove all technical debt\n\n")
    end

674
    it 'includes its closed issues in the body' do
675
      issue = create(:issue, project: subject.project)
676

677
      subject.project.add_developer(subject.author)
678
      subject.description = "This issue Closes #{issue.to_reference}"
679

680 681
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
682 683

      expect(subject.merge_commit_message)
684
        .to match("Closes #{issue.to_reference}")
685 686 687 688 689 690
    end

    it 'includes its reference in the body' do
      request = build_stubbed(:merge_request)

      expect(request.merge_commit_message)
691
        .to match("See merge request #{request.to_reference(full: true)}")
692 693 694 695 696 697 698
    end

    it 'excludes multiple linebreak runs when description is blank' do
      request = build(:merge_request, title: 'Title', description: nil)

      expect(request.merge_commit_message).not_to match("Title\n\n\n\n")
    end
699 700 701 702 703 704 705 706 707 708 709 710 711 712

    it 'includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message(include_description: true))
        .to match("By removing all code\n\n")
    end

    it 'does not includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message)
        .not_to match("By removing all code\n\n")
    end
713 714
  end

J
James Lopez 已提交
715
  describe "#reset_merge_when_pipeline_succeeds" do
716
    let(:merge_if_green) do
J
James Lopez 已提交
717
      create :merge_request, merge_when_pipeline_succeeds: true, merge_user: create(:user),
718 719
                             merge_params: { "should_remove_source_branch" => "1", "commit_message" => "msg" }
    end
Z
Zeger-Jan van de Weg 已提交
720

721
    it "sets the item to false" do
J
James Lopez 已提交
722
      merge_if_green.reset_merge_when_pipeline_succeeds
723 724
      merge_if_green.reload

J
James Lopez 已提交
725
      expect(merge_if_green.merge_when_pipeline_succeeds).to be_falsey
726 727
      expect(merge_if_green.merge_params["should_remove_source_branch"]).to be_nil
      expect(merge_if_green.merge_params["commit_message"]).to be_nil
728 729 730
    end
  end

731
  describe '#hook_attrs' do
732 733 734 735 736 737 738 739
    it 'delegates to Gitlab::HookData::MergeRequestBuilder#build' do
      builder = double

      expect(Gitlab::HookData::MergeRequestBuilder)
        .to receive(:new).with(subject).and_return(builder)
      expect(builder).to receive(:build)

      subject.hook_attrs
740
    end
741 742 743
  end

  describe '#diverged_commits_count' do
744
    let(:project)      { create(:project, :repository) }
B
Bob Van Landuyt 已提交
745
    let(:forked_project) { fork_project(project, nil, repository: true) }
746

747
    context 'when the target branch does not exist anymore' do
748 749 750 751
      subject { create(:merge_request, source_project: project, target_project: project) }

      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
752
        subject.clear_memoized_shas
753
      end
754 755

      it 'does not crash' do
756
        expect { subject.diverged_commits_count }.not_to raise_error
757 758 759 760 761 762 763
      end

      it 'returns 0' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

764 765 766 767
    context 'diverged on same repository' do
      subject(:merge_request_with_divergence) { create(:merge_request, :diverged, source_project: project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
768
        expect(subject.diverged_commits_count).to eq(29)
769 770 771 772
      end
    end

    context 'diverged on fork' do
B
Bob Van Landuyt 已提交
773
      subject(:merge_request_fork_with_divergence) { create(:merge_request, :diverged, source_project: forked_project, target_project: project) }
774 775

      it 'counts commits that are on target branch but not on source branch' do
776
        expect(subject.diverged_commits_count).to eq(29)
777 778 779 780
      end
    end

    context 'rebased on fork' do
B
Bob Van Landuyt 已提交
781
      subject(:merge_request_rebased) { create(:merge_request, :rebased, source_project: forked_project, target_project: project) }
782 783 784 785 786 787 788

      it 'counts commits that are on target branch but not on source branch' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

    describe 'caching' do
789
      before do
790 791 792 793
        allow(Rails).to receive(:cache).and_return(ActiveSupport::Cache::MemoryStore.new)
      end

      it 'caches the output' do
794 795 796
        expect(subject).to receive(:compute_diverged_commits_count)
          .once
          .and_return(2)
797 798 799 800 801 802

        subject.diverged_commits_count
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the source sha changes' do
803 804 805
        expect(subject).to receive(:compute_diverged_commits_count)
          .twice
          .and_return(2)
806 807

        subject.diverged_commits_count
808
        allow(subject).to receive(:source_branch_sha).and_return('123abc')
809 810 811 812
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the target sha changes' do
813 814 815
        expect(subject).to receive(:compute_diverged_commits_count)
          .twice
          .and_return(2)
816 817

        subject.diverged_commits_count
818
        allow(subject).to receive(:target_branch_sha).and_return('123abc')
819 820 821
        subject.diverged_commits_count
      end
    end
822 823
  end

824
  it_behaves_like 'an editable mentionable' do
825
    subject { create(:merge_request, :simple) }
826

827
    let(:backref_text) { "merge request #{subject.to_reference}" }
828
    let(:set_mentionable_text) { ->(txt) { subject.description = txt } }
829
  end
V
Vinnie Okada 已提交
830 831

  it_behaves_like 'a Taskable' do
832
    subject { create :merge_request, :simple }
V
Vinnie Okada 已提交
833
  end
834

835
  describe '#commit_shas' do
836
    before do
837
      allow(subject.merge_request_diff).to receive(:commit_shas)
838
        .and_return(['sha1'])
839 840
    end

841
    it 'delegates to merge request diff' do
842
      expect(subject.commit_shas).to eq ['sha1']
843 844 845
    end
  end

846
  context 'head pipeline' do
847 848 849
    before do
      allow(subject).to receive(:diff_head_sha).and_return('lastsha')
    end
850

851 852 853
    describe '#head_pipeline' do
      it 'returns nil for MR without head_pipeline_id' do
        subject.update_attribute(:head_pipeline_id, nil)
854

855 856
        expect(subject.head_pipeline).to be_nil
      end
857 858 859 860 861 862 863 864

      context 'when the source project does not exist' do
        it 'returns nil' do
          allow(subject).to receive(:source_project).and_return(nil)

          expect(subject.head_pipeline).to be_nil
        end
      end
865 866
    end

867
    describe '#actual_head_pipeline' do
868 869 870
      it 'returns nil for MR with old pipeline' do
        pipeline = create(:ci_empty_pipeline, sha: 'notlatestsha')
        subject.update_attribute(:head_pipeline_id, pipeline.id)
871

872
        expect(subject.actual_head_pipeline).to be_nil
873
      end
874

875 876 877
      it 'returns the pipeline for MR with recent pipeline' do
        pipeline = create(:ci_empty_pipeline, sha: 'lastsha')
        subject.update_attribute(:head_pipeline_id, pipeline.id)
878

879 880
        expect(subject.actual_head_pipeline).to eq(subject.head_pipeline)
        expect(subject.actual_head_pipeline).to eq(pipeline)
881
      end
882 883 884 885 886 887

      it 'returns nil when source project does not exist' do
        allow(subject).to receive(:source_project).and_return(nil)

        expect(subject.actual_head_pipeline).to be_nil
      end
888 889
    end
  end
Y
Yorick Peterse 已提交
890

891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933
  describe '#has_ci?' do
    let(:merge_request) { build_stubbed(:merge_request) }

    context 'has ci' do
      it 'returns true if MR has head_pipeline_id and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { double }
        allow(merge_request).to receive(:has_no_commits?) { false }

        expect(merge_request.has_ci?).to be(true)
      end

      it 'returns true if MR has any pipeline and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:has_no_commits?) { false }
        allow(merge_request).to receive(:all_pipelines) { [double] }

        expect(merge_request.has_ci?).to be(true)
      end

      it 'returns true if MR has CI service and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { double }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:has_no_commits?) { false }
        allow(merge_request).to receive(:all_pipelines) { [] }

        expect(merge_request.has_ci?).to be(true)
      end
    end

    context 'has no ci' do
      it 'returns false if MR has no CI service nor pipeline, and no commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:all_pipelines) { [] }
        allow(merge_request).to receive(:has_no_commits?) { true }

        expect(merge_request.has_ci?).to be(false)
      end
    end
  end

934
  describe '#all_pipelines' do
935
    shared_examples 'returning pipelines with proper ordering' do
936
      let!(:all_pipelines) do
937
        subject.all_commit_shas.map do |sha|
938 939 940 941
          create(:ci_empty_pipeline,
                 project: subject.source_project,
                 sha: sha,
                 ref: subject.source_branch)
942 943 944 945 946
        end
      end

      it 'returns all pipelines' do
        expect(subject.all_pipelines).not_to be_empty
947
        expect(subject.all_pipelines).to eq(all_pipelines.reverse)
948
      end
949 950
    end

951 952 953 954 955 956
    context 'with single merge_request_diffs' do
      it_behaves_like 'returning pipelines with proper ordering'
    end

    context 'with multiple irrelevant merge_request_diffs' do
      before do
957
        subject.update(target_branch: 'v1.0.0')
958 959 960
      end

      it_behaves_like 'returning pipelines with proper ordering'
961
    end
962 963

    context 'with unsaved merge request' do
964
      subject { build(:merge_request) }
965 966 967

      let!(:pipeline) do
        create(:ci_empty_pipeline,
968
               project: subject.project,
969 970
               sha: subject.diff_head_sha,
               ref: subject.source_branch)
971
      end
972 973 974 975 976

      it 'returns pipelines from diff_head_sha' do
        expect(subject.all_pipelines).to contain_exactly(pipeline)
      end
    end
977 978
  end

979
  describe '#all_commit_shas' do
980
    context 'when merge request is persisted' do
981
      let(:all_commit_shas) do
982 983
        subject.merge_request_diffs.flat_map(&:commits).map(&:sha).uniq
      end
984

985
      shared_examples 'returning all SHA' do
986
        it 'returns all SHAs from all merge_request_diffs' do
987
          expect(subject.merge_request_diffs.size).to eq(2)
988
          expect(subject.all_commit_shas).to match_array(all_commit_shas)
989
        end
990 991
      end

992 993
      context 'with a completely different branch' do
        before do
994
          subject.update(target_branch: 'csv')
995 996 997
        end

        it_behaves_like 'returning all SHA'
998 999
      end

1000 1001
      context 'with a branch having no difference' do
        before do
1002
          subject.update(target_branch: 'branch-merged')
1003 1004 1005 1006 1007
          subject.reload # make sure commits were not cached
        end

        it_behaves_like 'returning all SHA'
      end
1008 1009
    end

1010 1011 1012 1013 1014 1015 1016 1017 1018
    context 'when merge request is not persisted' do
      context 'when compare commits are set in the service' do
        let(:commit) { spy('commit') }

        subject do
          build(:merge_request, compare_commits: [commit, commit])
        end

        it 'returns commits from compare commits temporary data' do
1019
          expect(subject.all_commit_shas).to eq [commit, commit]
1020
        end
1021 1022
      end

1023 1024 1025 1026
      context 'when compare commits are not set in the service' do
        subject { build(:merge_request) }

        it 'returns array with diff head sha element only' do
1027
          expect(subject.all_commit_shas).to eq [subject.diff_head_sha]
1028 1029
        end
      end
1030 1031 1032
    end
  end

Y
Yorick Peterse 已提交
1033
  describe '#participants' do
1034
    let(:project) { create(:project, :public) }
Y
Yorick Peterse 已提交
1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055

    let(:mr) do
      create(:merge_request, source_project: project, target_project: project)
    end

    let!(:note1) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'a')
    end

    let!(:note2) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'b')
    end

    it 'includes the merge request author' do
      expect(mr.participants).to include(mr.author)
    end

    it 'includes the authors of the notes' do
      expect(mr.participants).to include(note1.author, note2.author)
    end
  end
J
Josh Frye 已提交
1056 1057 1058 1059 1060 1061

  describe 'cached counts' do
    it 'updates when assignees change' do
      user1 = create(:user)
      user2 = create(:user)
      mr = create(:merge_request, assignee: user1)
1062 1063
      mr.project.add_developer(user1)
      mr.project.add_developer(user2)
J
Josh Frye 已提交
1064

1065 1066
      expect(user1.assigned_open_merge_requests_count).to eq(1)
      expect(user2.assigned_open_merge_requests_count).to eq(0)
J
Josh Frye 已提交
1067 1068 1069 1070

      mr.assignee = user2
      mr.save

1071 1072
      expect(user1.assigned_open_merge_requests_count).to eq(0)
      expect(user2.assigned_open_merge_requests_count).to eq(1)
J
Josh Frye 已提交
1073 1074
    end
  end
1075

1076
  describe '#merge_async' do
1077 1078 1079 1080 1081 1082 1083 1084 1085 1086
    it 'enqueues MergeWorker job and updates merge_jid' do
      merge_request = create(:merge_request)
      user_id = double(:user_id)
      params = double(:params)
      merge_jid = 'hash-123'

      expect(MergeWorker).to receive(:perform_async).with(merge_request.id, user_id, params) do
        merge_jid
      end

1087
      merge_request.merge_async(user_id, params)
1088 1089 1090 1091 1092

      expect(merge_request.reload.merge_jid).to eq(merge_jid)
    end
  end

1093
  describe '#check_if_can_be_merged' do
1094
    let(:project) { create(:project, only_allow_merge_if_pipeline_succeeds: true) }
1095 1096 1097 1098

    subject { create(:merge_request, source_project: project, merge_status: :unchecked) }

    context 'when it is not broken and has no conflicts' do
1099
      before do
1100
        allow(subject).to receive(:broken?) { false }
1101
        allow(project.repository).to receive(:can_be_merged?).and_return(true)
1102
      end
1103

1104
      it 'is marked as mergeable' do
1105 1106 1107 1108 1109
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('can_be_merged')
      end
    end

    context 'when broken' do
1110 1111 1112
      before do
        allow(subject).to receive(:broken?) { true }
      end
1113 1114 1115 1116 1117 1118 1119 1120 1121

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end

    context 'when it has conflicts' do
      before do
        allow(subject).to receive(:broken?) { false }
1122
        allow(project.repository).to receive(:can_be_merged?).and_return(false)
1123 1124 1125 1126 1127 1128 1129 1130 1131
      end

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end
  end

  describe '#mergeable?' do
1132
    let(:project) { create(:project) }
1133 1134 1135

    subject { create(:merge_request, source_project: project) }

1136 1137
    it 'returns false if #mergeable_state? is false' do
      expect(subject).to receive(:mergeable_state?) { false }
1138

1139
      expect(subject.mergeable?).to be_falsey
1140 1141
    end

1142
    it 'return true if #mergeable_state? is true and the MR #can_be_merged? is true' do
1143 1144
      allow(subject).to receive(:mergeable_state?) { true }
      expect(subject).to receive(:check_if_can_be_merged)
1145
      expect(subject).to receive(:can_be_merged?) { true }
1146 1147 1148 1149 1150 1151

      expect(subject.mergeable?).to be_truthy
    end
  end

  describe '#mergeable_state?' do
1152
    let(:project) { create(:project, :repository) }
1153 1154 1155

    subject { create(:merge_request, source_project: project) }

1156
    it 'checks if merge request can be merged' do
1157
      allow(subject).to receive(:mergeable_ci_state?) { true }
1158 1159 1160 1161 1162 1163
      expect(subject).to receive(:check_if_can_be_merged)

      subject.mergeable?
    end

    context 'when not open' do
1164 1165 1166
      before do
        subject.close
      end
1167 1168

      it 'returns false' do
1169
        expect(subject.mergeable_state?).to be_falsey
1170 1171 1172 1173
      end
    end

    context 'when working in progress' do
1174 1175 1176
      before do
        subject.title = 'WIP MR'
      end
1177 1178

      it 'returns false' do
1179
        expect(subject.mergeable_state?).to be_falsey
1180 1181 1182 1183
      end
    end

    context 'when broken' do
1184 1185 1186
      before do
        allow(subject).to receive(:broken?) { true }
      end
1187 1188

      it 'returns false' do
1189
        expect(subject.mergeable_state?).to be_falsey
1190 1191 1192 1193
      end
    end

    context 'when failed' do
R
Rémy Coutable 已提交
1194
      context 'when #mergeable_ci_state? is false' do
1195
        before do
1196
          allow(subject).to receive(:mergeable_ci_state?) { false }
1197 1198 1199 1200
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
1201 1202
        end
      end
1203

R
Rémy Coutable 已提交
1204
      context 'when #mergeable_discussions_state? is false' do
1205 1206 1207 1208 1209 1210 1211 1212
        before do
          allow(subject).to receive(:mergeable_discussions_state?) { false }
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
        end
      end
1213 1214 1215
    end
  end

1216
  describe '#mergeable_ci_state?' do
1217
    let(:project) { create(:project, only_allow_merge_if_pipeline_succeeds: true) }
R
Rémy Coutable 已提交
1218
    let(:pipeline) { create(:ci_empty_pipeline) }
1219 1220 1221

    subject { build(:merge_request, target_project: project) }

1222
    context 'when it is only allowed to merge when build is green' do
R
Rémy Coutable 已提交
1223
      context 'and a failed pipeline is associated' do
1224
        before do
1225
          pipeline.update(status: 'failed', sha: subject.diff_head_sha)
1226
          allow(subject).to receive(:head_pipeline) { pipeline }
1227
        end
1228

1229
        it { expect(subject.mergeable_ci_state?).to be_falsey }
1230 1231
      end

1232 1233
      context 'and a successful pipeline is associated' do
        before do
1234
          pipeline.update(status: 'success', sha: subject.diff_head_sha)
1235
          allow(subject).to receive(:head_pipeline) { pipeline }
1236 1237 1238 1239 1240 1241 1242
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

      context 'and a skipped pipeline is associated' do
        before do
1243
          pipeline.update(status: 'skipped', sha: subject.diff_head_sha)
1244
          allow(subject).to receive(:head_pipeline) { pipeline }
1245 1246 1247 1248 1249
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
1250
      context 'when no pipeline is associated' do
1251
        before do
1252
          allow(subject).to receive(:head_pipeline) { nil }
1253 1254 1255
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1256 1257 1258
      end
    end

1259
    context 'when merges are not restricted to green builds' do
1260
      subject { build(:merge_request, target_project: build(:project, only_allow_merge_if_pipeline_succeeds: false)) }
1261

R
Rémy Coutable 已提交
1262
      context 'and a failed pipeline is associated' do
1263
        before do
R
Rémy Coutable 已提交
1264
          pipeline.statuses << create(:commit_status, status: 'failed', project: project)
1265
          allow(subject).to receive(:head_pipeline) { pipeline }
1266 1267 1268 1269 1270
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
1271
      context 'when no pipeline is associated' do
1272
        before do
1273
          allow(subject).to receive(:head_pipeline) { nil }
1274 1275 1276
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1277 1278 1279
      end
    end
  end
1280

1281
  describe '#mergeable_discussions_state?' do
R
Rémy Coutable 已提交
1282
    let(:merge_request) { create(:merge_request_with_diff_notes, source_project: project) }
1283

R
Rémy Coutable 已提交
1284
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == true' do
1285
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: true) }
1286

R
Rémy Coutable 已提交
1287
      context 'with all discussions resolved' do
1288
        before do
R
Rémy Coutable 已提交
1289
          merge_request.discussions.each { |d| d.resolve!(merge_request.author) }
1290 1291 1292
        end

        it 'returns true' do
R
Rémy Coutable 已提交
1293
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1294 1295 1296
        end
      end

R
Rémy Coutable 已提交
1297
      context 'with unresolved discussions' do
1298
        before do
R
Rémy Coutable 已提交
1299
          merge_request.discussions.each(&:unresolve!)
1300 1301 1302
        end

        it 'returns false' do
R
Rémy Coutable 已提交
1303
          expect(merge_request.mergeable_discussions_state?).to be_falsey
1304 1305
        end
      end
1306 1307 1308 1309 1310 1311 1312 1313 1314 1315

      context 'with no discussions' do
        before do
          merge_request.notes.destroy_all
        end

        it 'returns true' do
          expect(merge_request.mergeable_discussions_state?).to be_truthy
        end
      end
1316 1317
    end

R
Rémy Coutable 已提交
1318
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == false' do
1319
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: false) }
1320

R
Rémy Coutable 已提交
1321
      context 'with unresolved discussions' do
1322
        before do
R
Rémy Coutable 已提交
1323
          merge_request.discussions.each(&:unresolve!)
1324 1325 1326
        end

        it 'returns true' do
R
Rémy Coutable 已提交
1327
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1328 1329 1330 1331 1332
        end
      end
    end
  end

D
Douwe Maan 已提交
1333
  describe "#environments_for" do
1334
    let(:project)       { create(:project, :repository) }
D
Douwe Maan 已提交
1335
    let(:user)          { project.creator }
Z
Z.J. van de Weg 已提交
1336 1337
    let(:merge_request) { create(:merge_request, source_project: project) }

D
Douwe Maan 已提交
1338 1339 1340 1341 1342
    before do
      merge_request.source_project.add_master(user)
      merge_request.target_project.add_master(user)
    end

1343 1344
    context 'with multiple environments' do
      let(:environments) { create_list(:environment, 3, project: project) }
1345

1346 1347 1348 1349 1350 1351
      before do
        create(:deployment, environment: environments.first, ref: 'master', sha: project.commit('master').id)
        create(:deployment, environment: environments.second, ref: 'feature', sha: project.commit('feature').id)
      end

      it 'selects deployed environments' do
D
Douwe Maan 已提交
1352
        expect(merge_request.environments_for(user)).to contain_exactly(environments.first)
1353 1354 1355 1356
      end
    end

    context 'with environments on source project' do
B
Bob Van Landuyt 已提交
1357
      let(:source_project) { fork_project(project, nil, repository: true) }
K
Kamil Trzcinski 已提交
1358

1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371
      let(:merge_request) do
        create(:merge_request,
               source_project: source_project, source_branch: 'feature',
               target_project: project)
      end

      let(:source_environment) { create(:environment, project: source_project) }

      before do
        create(:deployment, environment: source_environment, ref: 'feature', sha: merge_request.diff_head_sha)
      end

      it 'selects deployed environments' do
D
Douwe Maan 已提交
1372
        expect(merge_request.environments_for(user)).to contain_exactly(source_environment)
1373 1374 1375 1376 1377 1378 1379 1380 1381 1382
      end

      context 'with environments on target project' do
        let(:target_environment) { create(:environment, project: project) }

        before do
          create(:deployment, environment: target_environment, tag: true, sha: merge_request.diff_head_sha)
        end

        it 'selects deployed environments' do
D
Douwe Maan 已提交
1383
          expect(merge_request.environments_for(user)).to contain_exactly(source_environment, target_environment)
1384 1385
        end
      end
1386 1387 1388 1389 1390 1391 1392 1393
    end

    context 'without a diff_head_commit' do
      before do
        expect(merge_request).to receive(:diff_head_commit).and_return(nil)
      end

      it 'returns an empty array' do
D
Douwe Maan 已提交
1394
        expect(merge_request.environments_for(user)).to be_empty
1395
      end
Z
Z.J. van de Weg 已提交
1396 1397 1398
    end
  end

1399
  describe "#reload_diff" do
1400
    let(:discussion) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject).to_discussion }
1401 1402
    let(:commit) { subject.project.commit(sample_commit.id) }

1403
    it "does not change existing merge request diff" do
1404
      expect(subject.merge_request_diff).not_to receive(:save_git_content)
1405 1406 1407
      subject.reload_diff
    end

1408 1409 1410 1411
    it "creates new merge request diff" do
      expect { subject.reload_diff }.to change { subject.merge_request_diffs.count }.by(1)
    end

1412 1413 1414 1415 1416 1417
    it "executs diff cache service" do
      expect_any_instance_of(MergeRequests::MergeRequestDiffCacheService).to receive(:execute).with(subject)

      subject.reload_diff
    end

1418 1419 1420 1421 1422
    it "calls update_diff_discussion_positions" do
      expect(subject).to receive(:update_diff_discussion_positions)

      subject.reload_diff
    end
1423 1424 1425 1426 1427 1428 1429 1430 1431 1432

    context 'when using the after_update hook to update' do
      context 'when the branches are updated' do
        it 'uses the new heads to generate the diff' do
          expect { subject.update!(source_branch: subject.target_branch, target_branch: subject.source_branch) }
            .to change { subject.merge_request_diff.start_commit_sha }
            .and change { subject.merge_request_diff.head_commit_sha }
        end
      end
    end
1433
  end
1434

1435 1436 1437 1438 1439 1440
  describe '#update_diff_discussion_positions' do
    let(:discussion) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject).to_discussion }
    let(:commit) { subject.project.commit(sample_commit.id) }
    let(:old_diff_refs) { subject.diff_refs }

    before do
1441
      # Update merge_request_diff so that #diff_refs will return commit.diff_refs
1442 1443 1444 1445 1446 1447
      allow(subject).to receive(:create_merge_request_diff) do
        subject.merge_request_diffs.create(
          base_commit_sha: commit.parent_id,
          start_commit_sha: commit.parent_id,
          head_commit_sha: commit.sha
        )
1448 1449

        subject.merge_request_diff(true)
1450
      end
1451
    end
1452

1453
    it "updates diff discussion positions" do
1454
      expect(Discussions::UpdateDiffPositionService).to receive(:new).with(
1455
        subject.project,
1456
        subject.author,
1457 1458
        old_diff_refs: old_diff_refs,
        new_diff_refs: commit.diff_refs,
1459
        paths: discussion.position.paths
1460 1461
      ).and_call_original

1462
      expect_any_instance_of(Discussions::UpdateDiffPositionService).to receive(:execute).with(discussion).and_call_original
1463 1464
      expect_any_instance_of(DiffNote).to receive(:save).once

1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484
      subject.update_diff_discussion_positions(old_diff_refs: old_diff_refs,
                                               new_diff_refs: commit.diff_refs,
                                               current_user: subject.author)
    end

    context 'when resolve_outdated_diff_discussions is set' do
      before do
        discussion

        subject.project.update!(resolve_outdated_diff_discussions: true)
      end

      it 'calls MergeRequests::ResolvedDiscussionNotificationService' do
        expect_any_instance_of(MergeRequests::ResolvedDiscussionNotificationService)
          .to receive(:execute).with(subject)

        subject.update_diff_discussion_positions(old_diff_refs: old_diff_refs,
                                                 new_diff_refs: commit.diff_refs,
                                                 current_user: subject.author)
      end
1485 1486
    end
  end
1487 1488 1489 1490 1491 1492 1493 1494 1495

  describe '#branch_merge_base_commit' do
    context 'source and target branch exist' do
      it { expect(subject.branch_merge_base_commit.sha).to eq('ae73cb07c9eeaf35924a10f713b364d32b2dd34f') }
      it { expect(subject.branch_merge_base_commit).to be_a(Commit) }
    end

    context 'when the target branch does not exist' do
      before do
1496
        subject.project.repository.rm_branch(subject.author, subject.target_branch)
1497
        subject.clear_memoized_shas
1498 1499 1500 1501
      end

      it 'returns nil' do
        expect(subject.branch_merge_base_commit).to be_nil
1502 1503 1504 1505
      end
    end
  end

1506
  describe "#diff_refs" do
1507 1508 1509 1510 1511 1512 1513 1514
    context "with diffs" do
      subject { create(:merge_request, :with_diffs) }

      it "does not touch the repository" do
        subject # Instantiate the object

        expect_any_instance_of(Repository).not_to receive(:commit)

1515
        subject.diff_refs
1516 1517 1518 1519 1520 1521 1522 1523 1524
      end

      it "returns expected diff_refs" do
        expected_diff_refs = Gitlab::Diff::DiffRefs.new(
          base_sha:  subject.merge_request_diff.base_commit_sha,
          start_sha: subject.merge_request_diff.start_commit_sha,
          head_sha:  subject.merge_request_diff.head_commit_sha
        )

1525
        expect(subject.diff_refs).to eq(expected_diff_refs)
1526 1527 1528
      end
    end
  end
1529

1530
  describe "#source_project_missing?" do
1531
    let(:project)      { create(:project) }
B
Bob Van Landuyt 已提交
1532
    let(:forked_project) { fork_project(project) }
1533
    let(:user)         { create(:user) }
B
Bob Van Landuyt 已提交
1534
    let(:unlink_project) { Projects::UnlinkForkService.new(forked_project, user) }
1535

K
Katarzyna Kobierska 已提交
1536
    context "when the fork exists" do
1537 1538
      let(:merge_request) do
        create(:merge_request,
B
Bob Van Landuyt 已提交
1539
          source_project: forked_project,
1540 1541 1542
          target_project: project)
      end

1543
      it { expect(merge_request.source_project_missing?).to be_falsey }
1544 1545
    end

K
Katarzyna Kobierska 已提交
1546
    context "when the source project is the same as the target project" do
1547 1548
      let(:merge_request) { create(:merge_request, source_project: project) }

1549
      it { expect(merge_request.source_project_missing?).to be_falsey }
1550 1551
    end

K
Katarzyna Kobierska 已提交
1552
    context "when the fork does not exist" do
1553
      let!(:merge_request) do
1554
        create(:merge_request,
B
Bob Van Landuyt 已提交
1555
          source_project: forked_project,
1556 1557 1558
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1559
      it "returns true" do
1560 1561 1562
        unlink_project.execute
        merge_request.reload

1563
        expect(merge_request.source_project_missing?).to be_truthy
1564 1565 1566 1567
      end
    end
  end

1568
  describe '#merge_ongoing?' do
1569 1570 1571 1572 1573 1574
    it 'returns true when the merge request is locked' do
      merge_request = build_stubbed(:merge_request, state: :locked)

      expect(merge_request.merge_ongoing?).to be(true)
    end

1575
    it 'returns true when merge_id, MR is not merged and it has no running job' do
1576
      merge_request = build_stubbed(:merge_request, state: :open, merge_jid: 'foo')
1577
      allow(Gitlab::SidekiqStatus).to receive(:running?).with('foo') { true }
1578 1579 1580

      expect(merge_request.merge_ongoing?).to be(true)
    end
1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595

    it 'returns false when merge_jid is nil' do
      merge_request = build_stubbed(:merge_request, state: :open, merge_jid: nil)

      expect(merge_request.merge_ongoing?).to be(false)
    end

    it 'returns false if MR is merged' do
      merge_request = build_stubbed(:merge_request, state: :merged, merge_jid: 'foo')

      expect(merge_request.merge_ongoing?).to be(false)
    end

    it 'returns false if there is no merge job running' do
      merge_request = build_stubbed(:merge_request, state: :open, merge_jid: 'foo')
1596
      allow(Gitlab::SidekiqStatus).to receive(:running?).with('foo') { false }
1597 1598 1599

      expect(merge_request.merge_ongoing?).to be(false)
    end
1600 1601
  end

1602
  describe "#closed_without_fork?" do
1603
    let(:project)      { create(:project) }
B
Bob Van Landuyt 已提交
1604
    let(:forked_project) { fork_project(project) }
1605
    let(:user)         { create(:user) }
B
Bob Van Landuyt 已提交
1606
    let(:unlink_project) { Projects::UnlinkForkService.new(forked_project, user) }
1607

K
Katarzyna Kobierska 已提交
1608
    context "when the merge request is closed" do
1609 1610
      let(:closed_merge_request) do
        create(:closed_merge_request,
B
Bob Van Landuyt 已提交
1611
          source_project: forked_project,
1612 1613 1614
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1615
      it "returns false if the fork exist" do
1616 1617 1618
        expect(closed_merge_request.closed_without_fork?).to be_falsey
      end

K
Katarzyna Kobierska 已提交
1619
      it "returns true if the fork does not exist" do
1620 1621 1622 1623 1624 1625
        unlink_project.execute
        closed_merge_request.reload

        expect(closed_merge_request.closed_without_fork?).to be_truthy
      end
    end
K
Katarzyna Kobierska 已提交
1626

K
Katarzyna Kobierska 已提交
1627
    context "when the merge request is open" do
K
Katarzyna Kobierska 已提交
1628 1629
      let(:open_merge_request) do
        create(:merge_request,
B
Bob Van Landuyt 已提交
1630
          source_project: forked_project,
K
Katarzyna Kobierska 已提交
1631 1632 1633 1634 1635 1636 1637
          target_project: project)
      end

      it "returns false" do
        expect(open_merge_request.closed_without_fork?).to be_falsey
      end
    end
1638
  end
1639

1640
  describe '#reopenable?' do
K
Katarzyna Kobierska 已提交
1641 1642 1643
    context 'when the merge request is closed' do
      it 'returns true' do
        subject.close
K
Katarzyna Kobierska 已提交
1644

1645
        expect(subject.reopenable?).to be_truthy
K
Katarzyna Kobierska 已提交
1646 1647 1648
      end

      context 'forked project' do
B
Bob Van Landuyt 已提交
1649
        let(:project)      { create(:project, :public) }
K
Katarzyna Kobierska 已提交
1650
        let(:user)         { create(:user) }
B
Bob Van Landuyt 已提交
1651
        let(:forked_project) { fork_project(project, user) }
1652 1653

        let!(:merge_request) do
K
Katarzyna Kobierska 已提交
1654
          create(:closed_merge_request,
B
Bob Van Landuyt 已提交
1655
            source_project: forked_project,
K
Katarzyna Kobierska 已提交
1656 1657 1658 1659
            target_project: project)
        end

        it 'returns false if unforked' do
B
Bob Van Landuyt 已提交
1660
          Projects::UnlinkForkService.new(forked_project, user).execute
K
Katarzyna Kobierska 已提交
1661

1662
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1663 1664 1665
        end

        it 'returns false if the source project is deleted' do
B
Bob Van Landuyt 已提交
1666
          Projects::DestroyService.new(forked_project, user).execute
K
Katarzyna Kobierska 已提交
1667

1668
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1669 1670
        end

K
Katarzyna Kobierska 已提交
1671
        it 'returns false if the merge request is merged' do
K
Katarzyna Kobierska 已提交
1672 1673
          merge_request.update_attributes(state: 'merged')

1674
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1675 1676
        end
      end
K
Katarzyna Kobierska 已提交
1677 1678
    end

K
Katarzyna Kobierska 已提交
1679
    context 'when the merge request is opened' do
K
Katarzyna Kobierska 已提交
1680
      it 'returns false' do
1681
        expect(subject.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1682
      end
K
Katarzyna Kobierska 已提交
1683 1684
    end
  end
1685

1686
  describe '#mergeable_with_quick_action?' do
1687
    def create_pipeline(status)
F
Felipe Artur 已提交
1688
      pipeline = create(:ci_pipeline_with_one_job,
1689 1690 1691
        project: project,
        ref:     merge_request.source_branch,
        sha:     merge_request.diff_head_sha,
1692 1693
        status:  status,
        head_pipeline_of: merge_request)
F
Felipe Artur 已提交
1694 1695

      pipeline
1696 1697
    end

J
James Lopez 已提交
1698
    let(:project)       { create(:project, :public, :repository, only_allow_merge_if_pipeline_succeeds: true) }
1699 1700 1701 1702 1703 1704
    let(:developer)     { create(:user) }
    let(:user)          { create(:user) }
    let(:merge_request) { create(:merge_request, source_project: project) }
    let(:mr_sha)        { merge_request.diff_head_sha }

    before do
1705
      project.add_developer(developer)
1706 1707 1708 1709
    end

    context 'when autocomplete_precheck is set to true' do
      it 'is mergeable by developer' do
1710
        expect(merge_request.mergeable_with_quick_action?(developer, autocomplete_precheck: true)).to be_truthy
1711 1712 1713
      end

      it 'is not mergeable by normal user' do
1714
        expect(merge_request.mergeable_with_quick_action?(user, autocomplete_precheck: true)).to be_falsey
1715 1716 1717 1718 1719
      end
    end

    context 'when autocomplete_precheck is set to false' do
      it 'is mergeable by developer' do
1720
        expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1721 1722 1723
      end

      it 'is not mergeable by normal user' do
1724
        expect(merge_request.mergeable_with_quick_action?(user, last_diff_sha: mr_sha)).to be_falsey
1725 1726 1727 1728 1729 1730 1731 1732
      end

      context 'closed MR'  do
        before do
          merge_request.update_attribute(:state, :closed)
        end

        it 'is not mergeable' do
1733
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1734 1735 1736 1737 1738 1739 1740 1741 1742
        end
      end

      context 'MR with WIP'  do
        before do
          merge_request.update_attribute(:title, 'WIP: some MR')
        end

        it 'is not mergeable' do
1743
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1744 1745 1746 1747 1748
        end
      end

      context 'sha differs from the MR diff_head_sha'  do
        it 'is not mergeable' do
1749
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: 'some other sha')).to be_falsey
1750 1751 1752
        end
      end

J
Jarka Kadlecova 已提交
1753 1754
      context 'sha is not provided'  do
        it 'is not mergeable' do
1755
          expect(merge_request.mergeable_with_quick_action?(developer)).to be_falsey
J
Jarka Kadlecova 已提交
1756 1757 1758
        end
      end

1759 1760 1761 1762 1763 1764
      context 'with pipeline ok'  do
        before do
          create_pipeline(:success)
        end

        it 'is mergeable' do
1765
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1766 1767 1768 1769 1770 1771 1772 1773 1774
        end
      end

      context 'with failing pipeline'  do
        before do
          create_pipeline(:failed)
        end

        it 'is not mergeable' do
1775
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1776 1777 1778 1779 1780
        end
      end

      context 'with running pipeline'  do
        before do
F
Felipe Artur 已提交
1781
          create_pipeline(:running)
1782 1783 1784
        end

        it 'is mergeable' do
1785
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1786 1787 1788 1789 1790
        end
      end
    end
  end

1791 1792
  describe '#has_commits?' do
    before do
1793 1794
      allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(2)
1795 1796 1797 1798 1799 1800 1801 1802 1803
    end

    it 'returns true when merge request diff has commits' do
      expect(subject.has_commits?).to be_truthy
    end
  end

  describe '#has_no_commits?' do
    before do
1804 1805
      allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(0)
1806 1807 1808 1809 1810 1811
    end

    it 'returns true when merge request diff has 0 commits' do
      expect(subject.has_no_commits?).to be_truthy
    end
  end
1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830

  describe '#merge_request_diff_for' do
    subject { create(:merge_request, importing: true) }
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'with diff refs' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff1.diff_refs)).to eq(merge_request_diff1)
      end
    end

    context 'with a commit SHA' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff3.head_commit_sha)).to eq(merge_request_diff3)
      end
    end
  end
1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862

  describe '#version_params_for' do
    subject { create(:merge_request, importing: true) }
    let(:project) { subject.project }
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'when the diff refs are for an older merge request version' do
      let(:diff_refs) { merge_request_diff1.diff_refs }

      it 'returns the diff ID for the version to show' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff1.id)
      end
    end

    context 'when the diff refs are for a comparison between merge request versions' do
      let(:diff_refs) { merge_request_diff3.compare_with(merge_request_diff1.head_commit_sha).diff_refs }

      it 'returns the diff ID and start sha of the versions to compare' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff3.id, start_sha: merge_request_diff1.head_commit_sha)
      end
    end

    context 'when the diff refs are not for a merge request version' do
      let(:diff_refs) { project.commit(sample_commit.id).diff_refs }

      it 'returns nil' do
        expect(subject.version_params_for(diff_refs)).to be_nil
      end
    end
  end
1863

1864
  describe '#fetch_ref!' do
M
micael.bergeron 已提交
1865
    it 'fetches the ref correctly' do
1866
      expect { subject.target_project.repository.delete_refs(subject.ref_path) }.not_to raise_error
1867

1868 1869
      subject.fetch_ref!
      expect(subject.target_project.repository.ref_exists?(subject.ref_path)).to be_truthy
1870 1871
    end
  end
1872 1873 1874 1875 1876 1877 1878 1879 1880

  describe 'removing a merge request' do
    it 'refreshes the number of open merge requests of the target project' do
      project = subject.target_project

      expect { subject.destroy }
        .to change { project.open_merge_requests_count }.from(1).to(0)
    end
  end
1881 1882 1883 1884

  it_behaves_like 'throttled touch' do
    subject { create(:merge_request, updated_at: 1.hour.ago) }
  end
1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900

  context 'state machine transitions' do
    describe '#unlock_mr' do
      subject { create(:merge_request, state: 'locked', merge_jid: 123) }

      it 'updates merge request head pipeline and sets merge_jid to nil' do
        pipeline = create(:ci_empty_pipeline, project: subject.project, ref: subject.source_branch, sha: subject.source_branch_sha)

        subject.unlock_mr

        subject.reload
        expect(subject.head_pipeline).to eq(pipeline)
        expect(subject.merge_jid).to be_nil
      end
    end
  end
1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946

  describe '#should_be_rebased?' do
    let(:project) { create(:project, :repository) }

    it 'returns false for the same source and target branches' do
      merge_request = create(:merge_request, source_project: project, target_project: project)

      expect(merge_request.should_be_rebased?).to be_falsey
    end
  end

  describe '#rebase_in_progress?' do
    # Create merge request and project before we stub file calls
    before do
      subject
    end

    it 'returns true when there is a current rebase directory' do
      allow(File).to receive(:exist?).and_return(true)
      allow(File).to receive(:mtime).and_return(Time.now)

      expect(subject.rebase_in_progress?).to be_truthy
    end

    it 'returns false when there is no rebase directory' do
      allow(File).to receive(:exist?).and_return(false)

      expect(subject.rebase_in_progress?).to be_falsey
    end

    it 'returns false when the rebase directory has expired' do
      allow(File).to receive(:exist?).and_return(true)
      allow(File).to receive(:mtime).and_return(20.minutes.ago)

      expect(subject.rebase_in_progress?).to be_falsey
    end

    it 'returns false when the source project has been removed' do
      allow(subject).to receive(:source_project).and_return(nil)
      allow(File).to receive(:exist?).and_return(true)
      allow(File).to receive(:mtime).and_return(Time.now)

      expect(File).not_to have_received(:exist?)
      expect(subject.rebase_in_progress?).to be_falsey
    end
  end
D
Dmitriy Zaporozhets 已提交
1947
end