merge_request_spec.rb 48.3 KB
Newer Older
D
Dmitriy Zaporozhets 已提交
1 2
require 'spec_helper'

D
Douwe Maan 已提交
3
describe MergeRequest, models: true do
4 5
  include RepoHelpers

6 7
  subject { create(:merge_request) }

R
Robert Speicher 已提交
8
  describe 'associations' do
9 10
    it { is_expected.to belong_to(:target_project).class_name('Project') }
    it { is_expected.to belong_to(:source_project).class_name('Project') }
11
    it { is_expected.to belong_to(:merge_user).class_name("User") }
12
    it { is_expected.to have_many(:merge_request_diffs).dependent(:destroy) }
R
Robert Speicher 已提交
13 14
  end

15 16 17 18 19 20 21 22 23 24
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(InternalId) }
    it { is_expected.to include_module(Issuable) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(Taskable) }
  end

Z
Zeger-Jan van de Weg 已提交
25 26 27 28 29
  describe "act_as_paranoid" do
    it { is_expected.to have_db_column(:deleted_at) }
    it { is_expected.to have_db_index(:deleted_at) }
  end

30
  describe 'validation' do
31 32
    it { is_expected.to validate_presence_of(:target_branch) }
    it { is_expected.to validate_presence_of(:source_branch) }
Z
Zeger-Jan van de Weg 已提交
33

34
    context "Validation of merge user with Merge When Pipeline Succeeds" do
Z
Zeger-Jan van de Weg 已提交
35 36 37 38 39
      it "allows user to be nil when the feature is disabled" do
        expect(subject).to be_valid
      end

      it "is invalid without merge user" do
J
James Lopez 已提交
40
        subject.merge_when_pipeline_succeeds = true
Z
Zeger-Jan van de Weg 已提交
41 42 43 44
        expect(subject).not_to be_valid
      end

      it "is valid with merge user" do
J
James Lopez 已提交
45
        subject.merge_when_pipeline_succeeds = true
Z
Zeger-Jan van de Weg 已提交
46 47 48 49 50
        subject.merge_user = build(:user)

        expect(subject).to be_valid
      end
    end
D
Dmitriy Zaporozhets 已提交
51 52
  end

R
Robert Speicher 已提交
53
  describe 'respond to' do
54 55 56
    it { is_expected.to respond_to(:unchecked?) }
    it { is_expected.to respond_to(:can_be_merged?) }
    it { is_expected.to respond_to(:cannot_be_merged?) }
57
    it { is_expected.to respond_to(:merge_params) }
J
James Lopez 已提交
58
    it { is_expected.to respond_to(:merge_when_pipeline_succeeds) }
59
  end
A
Andrey Kumanyaev 已提交
60

61 62 63 64 65 66
  describe '.in_projects' do
    it 'returns the merge requests for a set of projects' do
      expect(described_class.in_projects(Project.all)).to eq([subject])
    end
  end

67
  describe '#target_branch_sha' do
68
    let(:project) { create(:project, :repository) }
69

70
    subject { create(:merge_request, source_project: project, target_project: project) }
71

72
    context 'when the target branch does not exist' do
73 74 75
      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
      end
76 77

      it 'returns nil' do
78
        expect(subject.target_branch_sha).to be_nil
79 80
      end
    end
81 82 83 84 85 86

    it 'returns memoized value' do
      subject.target_branch_sha = '8ffb3c15a5475e59ae909384297fede4badcb4c7'

      expect(subject.target_branch_sha).to eq '8ffb3c15a5475e59ae909384297fede4badcb4c7'
    end
87 88
  end

89 90 91 92 93 94 95 96 97 98 99
  describe '#cache_merge_request_closes_issues!' do
    before do
      subject.project.team << [subject.author, :developer]
      subject.target_branch = subject.project.default_branch
    end

    it 'caches closed issues' do
      issue  = create :issue, project: subject.project
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])

100
      expect { subject.cache_merge_request_closes_issues!(subject.author) }.to change(subject.merge_requests_closing_issues, :count).by(1)
101 102 103 104 105 106 107 108
    end

    it 'does not cache issues from external trackers' do
      subject.project.update_attribute(:has_external_issue_tracker, true)
      issue  = ExternalIssue.new('JIRA-123', subject.project)
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])

109
      expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
110 111 112
    end
  end

113
  describe '#source_branch_sha' do
114 115 116 117 118
    let(:last_branch_commit) { subject.source_project.repository.commit(subject.source_branch) }

    context 'with diffs' do
      subject { create(:merge_request, :with_diffs) }
      it 'returns the sha of the source branch last commit' do
119
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
120 121 122
      end
    end

123 124 125
    context 'without diffs' do
      subject { create(:merge_request, :without_diffs) }
      it 'returns the sha of the source branch last commit' do
126
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
127 128 129
      end
    end

130 131 132
    context 'when the merge request is being created' do
      subject { build(:merge_request, source_branch: nil, compare_commits: []) }
      it 'returns nil' do
133
        expect(subject.source_branch_sha).to be_nil
134 135
      end
    end
136 137 138 139 140 141

    it 'returns memoized value' do
      subject.source_branch_sha = '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'

      expect(subject.source_branch_sha).to eq '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
    end
142 143
  end

144
  describe '#to_reference' do
145 146 147
    let(:project) { build(:empty_project, name: 'sample-project') }
    let(:merge_request) { build(:merge_request, target_project: project, iid: 1) }

148
    it 'returns a String reference to the object' do
149
      expect(merge_request.to_reference).to eq "!1"
150 151 152
    end

    it 'supports a cross-project reference' do
153
      another_project = build(:empty_project, name: 'another-project', namespace: project.namespace)
154
      expect(merge_request.to_reference(another_project)).to eq "sample-project!1"
155
    end
156 157 158 159

    it 'returns a String reference with the full path' do
      expect(merge_request.to_reference(full: true)).to eq(project.path_with_namespace + '!1')
    end
160
  end
161

162
  describe '#raw_diffs' do
S
Sean McGivern 已提交
163 164 165 166 167 168 169
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
        merge_request.merge_request_diff = MergeRequestDiff.new

170
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(options)
S
Sean McGivern 已提交
171

172 173 174 175 176 177 178 179 180 181 182 183 184 185 186
        merge_request.raw_diffs(options)
      end
    end

    context 'when there are no MR diffs' do
      it 'delegates to the compare object' do
        merge_request.compare = double(:compare)

        expect(merge_request.compare).to receive(:raw_diffs).with(options)

        merge_request.raw_diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
187 188 189 190 191 192
  describe '#diffs' do
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
193
        merge_request.save
S
Sean McGivern 已提交
194

195
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(hash_including(options))
S
Sean McGivern 已提交
196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211

        merge_request.diffs(options)
      end
    end

    context 'when there are no MR diffs' do
      it 'delegates to the compare object' do
        merge_request.compare = double(:compare)

        expect(merge_request.compare).to receive(:diffs).with(options)

        merge_request.diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255
  describe '#diff_size' do
    let(:merge_request) do
      build(:merge_request, source_branch: 'expand-collapse-files', target_branch: 'master')
    end

    context 'when there are MR diffs' do
      before do
        merge_request.save
      end

      it 'returns the correct count' do
        expect(merge_request.diff_size).to eq(105)
      end

      it 'does not perform highlighting' do
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end

    context 'when there are no MR diffs' do
      before do
        merge_request.compare = CompareService.new(
          merge_request.source_project,
          merge_request.source_branch
        ).execute(
          merge_request.target_project,
          merge_request.target_branch
        )
      end

      it 'returns the correct count' do
        expect(merge_request.diff_size).to eq(105)
      end

      it 'does not perform highlighting' do
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end
  end

256
  describe "#related_notes" do
257
    let!(:merge_request) { create(:merge_request) }
258 259

    before do
260
      allow(merge_request).to receive(:commits) { [merge_request.source_project.repository.commit] }
261 262
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.project)
D
Dmitriy Zaporozhets 已提交
263
      create(:note, noteable: merge_request, project: merge_request.project)
264 265
    end

266
    it "includes notes for commits" do
267
      expect(merge_request.commits).not_to be_empty
268
      expect(merge_request.related_notes.count).to eq(2)
269
    end
270

271
    it "includes notes for commits from target project as well" do
272 273 274
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.target_project)

275
      expect(merge_request.commits).not_to be_empty
276
      expect(merge_request.related_notes.count).to eq(3)
277
    end
278
  end
279 280 281

  describe '#is_being_reassigned?' do
    it 'returns true if the merge_request assignee has changed' do
282
      subject.assignee = create(:user)
283
      expect(subject.is_being_reassigned?).to be_truthy
284 285
    end
    it 'returns false if the merge request assignee has not changed' do
286
      expect(subject.is_being_reassigned?).to be_falsey
287 288
    end
  end
I
Izaak Alpert 已提交
289 290 291

  describe '#for_fork?' do
    it 'returns true if the merge request is for a fork' do
292 293
      subject.source_project = build_stubbed(:empty_project, namespace: create(:group))
      subject.target_project = build_stubbed(:empty_project, namespace: create(:group))
I
Izaak Alpert 已提交
294

295
      expect(subject.for_fork?).to be_truthy
I
Izaak Alpert 已提交
296
    end
D
Dmitriy Zaporozhets 已提交
297

I
Izaak Alpert 已提交
298
    it 'returns false if is not for a fork' do
299
      expect(subject.for_fork?).to be_falsey
I
Izaak Alpert 已提交
300 301 302
    end
  end

303
  describe '#closes_issues' do
304 305
    let(:issue0) { create :issue, project: subject.project }
    let(:issue1) { create :issue, project: subject.project }
306 307 308 309

    let(:commit0) { double('commit0', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit1) { double('commit1', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit2) { double('commit2', safe_message: "Fixes #{issue1.to_reference}") }
310 311

    before do
312
      subject.project.team << [subject.author, :developer]
313
      allow(subject).to receive(:commits).and_return([commit0, commit1, commit2])
314 315
    end

316 317 318
    it 'accesses the set of issues that will be closed on acceptance' do
      allow(subject.project).to receive(:default_branch).
        and_return(subject.target_branch)
319

320
      closed = subject.closes_issues
321

322 323
      expect(closed).to include(issue0, issue1)
    end
324

325 326 327
    it 'only lists issues as to be closed if it targets the default branch' do
      allow(subject.project).to receive(:default_branch).and_return('master')
      subject.target_branch = 'something-else'
328

329
      expect(subject.closes_issues).to be_empty
330
    end
331
  end
332

333
  describe '#issues_mentioned_but_not_closing' do
334 335 336 337
    let(:closing_issue) { create :issue, project: subject.project }
    let(:mentioned_issue) { create :issue, project: subject.project }

    let(:commit) { double('commit', safe_message: "Fixes #{closing_issue.to_reference}") }
338

339
    it 'detects issues mentioned in description but not closed' do
340
      subject.project.team << [subject.author, :developer]
341
      subject.description = "Is related to #{mentioned_issue.to_reference} and #{closing_issue.to_reference}"
342

343
      allow(subject).to receive(:commits).and_return([commit])
344 345
      allow(subject.project).to receive(:default_branch).
        and_return(subject.target_branch)
346

347
      expect(subject.issues_mentioned_but_not_closing(subject.author)).to match_array([mentioned_issue])
348
    end
349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365

    context 'when the project has an external issue tracker' do
      before do
        subject.project.team << [subject.author, :developer]
        commit = double(:commit, safe_message: 'Fixes TEST-3')

        create(:jira_service, project: subject.project)

        allow(subject).to receive(:commits).and_return([commit])
        allow(subject).to receive(:description).and_return('Is related to TEST-2 and TEST-3')
        allow(subject.project).to receive(:default_branch).and_return(subject.target_branch)
      end

      it 'detects issues mentioned in description but not closed' do
        expect(subject.issues_mentioned_but_not_closing(subject.author).map(&:to_s)).to match_array(['TEST-2'])
      end
    end
366 367
  end

368
  describe "#work_in_progress?" do
369 370 371
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "detects the '#{wip_prefix}' prefix" do
        subject.title = "#{wip_prefix}#{subject.title}"
372
        expect(subject.work_in_progress?).to eq true
373
      end
T
Ted Hogan 已提交
374 375
    end

376 377
    it "doesn't detect WIP for words starting with WIP" do
      subject.title = "Wipwap #{subject.title}"
378
      expect(subject.work_in_progress?).to eq false
379 380
    end

381 382
    it "doesn't detect WIP for words containing with WIP" do
      subject.title = "WupWipwap #{subject.title}"
383
      expect(subject.work_in_progress?).to eq false
384 385
    end

386
    it "doesn't detect WIP by default" do
387
      expect(subject.work_in_progress?).to eq false
388 389 390
    end
  end

T
Thomas Balthazar 已提交
391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413
  describe "#wipless_title" do
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "removes the '#{wip_prefix}' prefix" do
        wipless_title = subject.title
        subject.title = "#{wip_prefix}#{subject.title}"

        expect(subject.wipless_title).to eq wipless_title
      end

      it "is satisfies the #work_in_progress? method" do
        subject.title = "#{wip_prefix}#{subject.title}"
        subject.title = subject.wipless_title

        expect(subject.work_in_progress?).to eq false
      end
    end
  end

  describe "#wip_title" do
    it "adds the WIP: prefix to the title" do
      wip_title = "WIP: #{subject.title}"

      expect(subject.wip_title).to eq wip_title
414
    end
T
Thomas Balthazar 已提交
415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430

    it "does not add the WIP: prefix multiple times" do
      wip_title = "WIP: #{subject.title}"
      subject.title = subject.wip_title
      subject.title = subject.wip_title

      expect(subject.wip_title).to eq wip_title
    end

    it "is satisfies the #work_in_progress? method" do
      subject.title = subject.wip_title

      expect(subject.work_in_progress?).to eq true
    end
  end

Z
Zeger-Jan van de Weg 已提交
431
  describe '#can_remove_source_branch?' do
Z
Zeger-Jan van de Weg 已提交
432 433
    let(:user) { create(:user) }
    let(:user2) { create(:user) }
434 435 436 437

    before do
      subject.source_project.team << [user, :master]

Z
Zeger-Jan van de Weg 已提交
438 439 440 441
      subject.source_branch = "feature"
      subject.target_branch = "master"
      subject.save!
    end
442

Z
Zeger-Jan van de Weg 已提交
443
    it "can't be removed when its a protected branch" do
444
      allow(ProtectedBranch).to receive(:protected?).and_return(true)
445 446 447
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

448
    it "can't remove a root ref" do
Z
Zeger-Jan van de Weg 已提交
449 450
      subject.source_branch = "master"
      subject.target_branch = "feature"
451 452 453 454

      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

Z
Zeger-Jan van de Weg 已提交
455 456 457 458
    it "is unable to remove the source branch for a project the user cannot push to" do
      expect(subject.can_remove_source_branch?(user2)).to be_falsey
    end

459
    it "can be removed if the last commit is the head of the source branch" do
460
      allow(subject).to receive(:source_branch_head).and_return(subject.diff_head_commit)
461

Z
Zeger-Jan van de Weg 已提交
462
      expect(subject.can_remove_source_branch?(user)).to be_truthy
463
    end
464 465

    it "cannot be removed if the last commit is not also the head of the source branch" do
466 467
      subject.source_branch = "lfs"

468 469
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end
470 471
  end

472 473 474 475 476 477 478 479 480 481 482 483 484 485 486
  describe '#merge_commit_message' do
    it 'includes merge information as the title' do
      request = build(:merge_request, source_branch: 'source', target_branch: 'target')

      expect(request.merge_commit_message)
        .to match("Merge branch 'source' into 'target'\n\n")
    end

    it 'includes its title in the body' do
      request = build(:merge_request, title: 'Remove all technical debt')

      expect(request.merge_commit_message)
        .to match("Remove all technical debt\n\n")
    end

487
    it 'includes its closed issues in the body' do
488
      issue = create(:issue, project: subject.project)
489

490
      subject.project.team << [subject.author, :developer]
491
      subject.description = "This issue Closes #{issue.to_reference}"
492 493 494 495 496

      allow(subject.project).to receive(:default_branch).
        and_return(subject.target_branch)

      expect(subject.merge_commit_message)
497
        .to match("Closes #{issue.to_reference}")
498 499 500 501 502 503 504 505 506 507 508 509 510 511
    end

    it 'includes its reference in the body' do
      request = build_stubbed(:merge_request)

      expect(request.merge_commit_message)
        .to match("See merge request #{request.to_reference}")
    end

    it 'excludes multiple linebreak runs when description is blank' do
      request = build(:merge_request, title: 'Title', description: nil)

      expect(request.merge_commit_message).not_to match("Title\n\n\n\n")
    end
512 513 514 515 516 517 518 519 520 521 522 523 524 525

    it 'includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message(include_description: true))
        .to match("By removing all code\n\n")
    end

    it 'does not includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message)
        .not_to match("By removing all code\n\n")
    end
526 527
  end

J
James Lopez 已提交
528
  describe "#reset_merge_when_pipeline_succeeds" do
529
    let(:merge_if_green) do
J
James Lopez 已提交
530
      create :merge_request, merge_when_pipeline_succeeds: true, merge_user: create(:user),
531 532
                             merge_params: { "should_remove_source_branch" => "1", "commit_message" => "msg" }
    end
Z
Zeger-Jan van de Weg 已提交
533

534
    it "sets the item to false" do
J
James Lopez 已提交
535
      merge_if_green.reset_merge_when_pipeline_succeeds
536 537
      merge_if_green.reload

J
James Lopez 已提交
538
      expect(merge_if_green.merge_when_pipeline_succeeds).to be_falsey
539 540
      expect(merge_if_green.merge_params["should_remove_source_branch"]).to be_nil
      expect(merge_if_green.merge_params["commit_message"]).to be_nil
541 542 543
    end
  end

544
  describe "#hook_attrs" do
545
    let(:attrs_hash) { subject.hook_attrs }
546 547 548 549 550 551 552 553 554 555

    [:source, :target].each do |key|
      describe "#{key} key" do
        include_examples 'project hook data', project_key: key do
          let(:data)    { attrs_hash }
          let(:project) { subject.send("#{key}_project") }
        end
      end
    end

556
    it "has all the required keys" do
557 558 559 560
      expect(attrs_hash).to include(:source)
      expect(attrs_hash).to include(:target)
      expect(attrs_hash).to include(:last_commit)
      expect(attrs_hash).to include(:work_in_progress)
561 562 563 564
      expect(attrs_hash).to include(:total_time_spent)
      expect(attrs_hash).to include(:human_time_estimate)
      expect(attrs_hash).to include(:human_total_time_spent)
      expect(attrs_hash).to include('time_estimate')
565
    end
566 567 568
  end

  describe '#diverged_commits_count' do
569 570
    let(:project)      { create(:project, :repository) }
    let(:fork_project) { create(:project, :repository, forked_from_project: project) }
571

572
    context 'when the target branch does not exist anymore' do
573 574 575 576 577 578
      subject { create(:merge_request, source_project: project, target_project: project) }

      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
        subject.reload
      end
579 580 581 582 583 584 585 586 587 588

      it 'does not crash' do
        expect{ subject.diverged_commits_count }.not_to raise_error
      end

      it 'returns 0' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

589 590 591 592
    context 'diverged on same repository' do
      subject(:merge_request_with_divergence) { create(:merge_request, :diverged, source_project: project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
593
        expect(subject.diverged_commits_count).to eq(29)
594 595 596 597 598 599 600
      end
    end

    context 'diverged on fork' do
      subject(:merge_request_fork_with_divergence) { create(:merge_request, :diverged, source_project: fork_project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
601
        expect(subject.diverged_commits_count).to eq(29)
602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632
      end
    end

    context 'rebased on fork' do
      subject(:merge_request_rebased) { create(:merge_request, :rebased, source_project: fork_project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

    describe 'caching' do
      before(:example) do
        allow(Rails).to receive(:cache).and_return(ActiveSupport::Cache::MemoryStore.new)
      end

      it 'caches the output' do
        expect(subject).to receive(:compute_diverged_commits_count).
          once.
          and_return(2)

        subject.diverged_commits_count
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the source sha changes' do
        expect(subject).to receive(:compute_diverged_commits_count).
          twice.
          and_return(2)

        subject.diverged_commits_count
633
        allow(subject).to receive(:source_branch_sha).and_return('123abc')
634 635 636 637 638 639 640 641 642
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the target sha changes' do
        expect(subject).to receive(:compute_diverged_commits_count).
          twice.
          and_return(2)

        subject.diverged_commits_count
643
        allow(subject).to receive(:target_branch_sha).and_return('123abc')
644 645 646
        subject.diverged_commits_count
      end
    end
647 648
  end

649
  it_behaves_like 'an editable mentionable' do
650
    subject { create(:merge_request, :simple) }
651

652 653
    let(:backref_text) { "merge request #{subject.to_reference}" }
    let(:set_mentionable_text) { ->(txt){ subject.description = txt } }
654
  end
V
Vinnie Okada 已提交
655 656

  it_behaves_like 'a Taskable' do
657
    subject { create :merge_request, :simple }
V
Vinnie Okada 已提交
658
  end
659

660 661
  describe '#commits_sha' do
    before do
662 663
      allow(subject.merge_request_diff).to receive(:commits_sha).
        and_return(['sha1'])
664 665
    end

666 667
    it 'delegates to merge request diff' do
      expect(subject.commits_sha).to eq ['sha1']
668 669 670
    end
  end

671
  describe '#head_pipeline' do
672
    describe 'when the source project exists' do
673
      it 'returns the latest pipeline' do
674
        pipeline = double(:ci_pipeline, ref: 'master')
675

676
        allow(subject).to receive(:diff_head_sha).and_return('123abc')
677

L
Lin Jen-Shin 已提交
678 679
        expect(subject.source_project).to receive(:pipeline_for).
          with('master', '123abc').
680
          and_return(pipeline)
681

682
        expect(subject.head_pipeline).to eq(pipeline)
683 684 685 686 687 688 689
      end
    end

    describe 'when the source project does not exist' do
      it 'returns nil' do
        allow(subject).to receive(:source_project).and_return(nil)

690
        expect(subject.head_pipeline).to be_nil
691 692 693
      end
    end
  end
Y
Yorick Peterse 已提交
694

695
  describe '#all_pipelines' do
696
    shared_examples 'returning pipelines with proper ordering' do
697 698 699 700 701 702
      let!(:all_pipelines) do
        subject.all_commits_sha.map do |sha|
          create(:ci_empty_pipeline,
                 project: subject.source_project,
                 sha: sha,
                 ref: subject.source_branch)
703 704 705 706 707
        end
      end

      it 'returns all pipelines' do
        expect(subject.all_pipelines).not_to be_empty
708
        expect(subject.all_pipelines).to eq(all_pipelines.reverse)
709
      end
710 711
    end

712 713 714 715 716 717
    context 'with single merge_request_diffs' do
      it_behaves_like 'returning pipelines with proper ordering'
    end

    context 'with multiple irrelevant merge_request_diffs' do
      before do
718
        subject.update(target_branch: 'v1.0.0')
719 720 721
      end

      it_behaves_like 'returning pipelines with proper ordering'
722
    end
723 724

    context 'with unsaved merge request' do
725
      subject { build(:merge_request) }
726 727 728

      let!(:pipeline) do
        create(:ci_empty_pipeline,
729
               project: subject.project,
730 731
               sha: subject.diff_head_sha,
               ref: subject.source_branch)
732
      end
733 734 735 736 737

      it 'returns pipelines from diff_head_sha' do
        expect(subject.all_pipelines).to contain_exactly(pipeline)
      end
    end
738 739
  end

740
  describe '#all_commits_sha' do
741 742 743 744
    context 'when merge request is persisted' do
      let(:all_commits_sha) do
        subject.merge_request_diffs.flat_map(&:commits).map(&:sha).uniq
      end
745

746 747 748 749 750
      shared_examples 'returning all SHA' do
        it 'returns all SHA from all merge_request_diffs' do
          expect(subject.merge_request_diffs.size).to eq(2)
          expect(subject.all_commits_sha).to eq(all_commits_sha)
        end
751 752
      end

753 754 755 756 757 758
      context 'with a completely different branch' do
        before do
          subject.update(target_branch: 'v1.0.0')
        end

        it_behaves_like 'returning all SHA'
759 760
      end

761 762 763 764 765 766 767 768
      context 'with a branch having no difference' do
        before do
          subject.update(target_branch: 'v1.1.0')
          subject.reload # make sure commits were not cached
        end

        it_behaves_like 'returning all SHA'
      end
769 770
    end

771 772 773 774 775 776 777 778 779 780 781
    context 'when merge request is not persisted' do
      context 'when compare commits are set in the service' do
        let(:commit) { spy('commit') }

        subject do
          build(:merge_request, compare_commits: [commit, commit])
        end

        it 'returns commits from compare commits temporary data' do
          expect(subject.all_commits_sha).to eq [commit, commit]
        end
782 783
      end

784 785 786 787 788 789 790
      context 'when compare commits are not set in the service' do
        subject { build(:merge_request) }

        it 'returns array with diff head sha element only' do
          expect(subject.all_commits_sha).to eq [subject.diff_head_sha]
        end
      end
791 792 793
    end
  end

Y
Yorick Peterse 已提交
794
  describe '#participants' do
795
    let(:project) { create(:empty_project, :public) }
Y
Yorick Peterse 已提交
796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816

    let(:mr) do
      create(:merge_request, source_project: project, target_project: project)
    end

    let!(:note1) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'a')
    end

    let!(:note2) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'b')
    end

    it 'includes the merge request author' do
      expect(mr.participants).to include(mr.author)
    end

    it 'includes the authors of the notes' do
      expect(mr.participants).to include(note1.author, note2.author)
    end
  end
J
Josh Frye 已提交
817 818 819 820 821 822

  describe 'cached counts' do
    it 'updates when assignees change' do
      user1 = create(:user)
      user2 = create(:user)
      mr = create(:merge_request, assignee: user1)
823 824
      mr.project.add_developer(user1)
      mr.project.add_developer(user2)
J
Josh Frye 已提交
825

826 827
      expect(user1.assigned_open_merge_requests_count).to eq(1)
      expect(user2.assigned_open_merge_requests_count).to eq(0)
J
Josh Frye 已提交
828 829 830 831

      mr.assignee = user2
      mr.save

832 833
      expect(user1.assigned_open_merge_requests_count).to eq(0)
      expect(user2.assigned_open_merge_requests_count).to eq(1)
J
Josh Frye 已提交
834 835
    end
  end
836 837

  describe '#check_if_can_be_merged' do
J
James Lopez 已提交
838
    let(:project) { create(:empty_project, only_allow_merge_if_pipeline_succeeds: true) }
839 840 841 842

    subject { create(:merge_request, source_project: project, merge_status: :unchecked) }

    context 'when it is not broken and has no conflicts' do
843
      before do
844
        allow(subject).to receive(:broken?) { false }
845
        allow(project.repository).to receive(:can_be_merged?).and_return(true)
846
      end
847

848
      it 'is marked as mergeable' do
849 850 851 852 853 854 855 856 857 858 859 860 861 862 863
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('can_be_merged')
      end
    end

    context 'when broken' do
      before { allow(subject).to receive(:broken?) { true } }

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end

    context 'when it has conflicts' do
      before do
        allow(subject).to receive(:broken?) { false }
864
        allow(project.repository).to receive(:can_be_merged?).and_return(false)
865 866 867 868 869 870 871 872 873
      end

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end
  end

  describe '#mergeable?' do
874
    let(:project) { create(:empty_project) }
875 876 877

    subject { create(:merge_request, source_project: project) }

878 879
    it 'returns false if #mergeable_state? is false' do
      expect(subject).to receive(:mergeable_state?) { false }
880

881
      expect(subject.mergeable?).to be_falsey
882 883
    end

884
    it 'return true if #mergeable_state? is true and the MR #can_be_merged? is true' do
885 886
      allow(subject).to receive(:mergeable_state?) { true }
      expect(subject).to receive(:check_if_can_be_merged)
887
      expect(subject).to receive(:can_be_merged?) { true }
888 889 890 891 892 893

      expect(subject.mergeable?).to be_truthy
    end
  end

  describe '#mergeable_state?' do
894
    let(:project) { create(:project, :repository) }
895 896 897

    subject { create(:merge_request, source_project: project) }

898
    it 'checks if merge request can be merged' do
899
      allow(subject).to receive(:mergeable_ci_state?) { true }
900 901 902 903 904 905 906 907 908
      expect(subject).to receive(:check_if_can_be_merged)

      subject.mergeable?
    end

    context 'when not open' do
      before { subject.close }

      it 'returns false' do
909
        expect(subject.mergeable_state?).to be_falsey
910 911 912 913 914 915 916
      end
    end

    context 'when working in progress' do
      before { subject.title = 'WIP MR' }

      it 'returns false' do
917
        expect(subject.mergeable_state?).to be_falsey
918 919 920 921 922 923 924
      end
    end

    context 'when broken' do
      before { allow(subject).to receive(:broken?) { true } }

      it 'returns false' do
925
        expect(subject.mergeable_state?).to be_falsey
926 927 928 929
      end
    end

    context 'when failed' do
R
Rémy Coutable 已提交
930
      context 'when #mergeable_ci_state? is false' do
931
        before do
932
          allow(subject).to receive(:mergeable_ci_state?) { false }
933 934 935 936
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
937 938
        end
      end
939

R
Rémy Coutable 已提交
940
      context 'when #mergeable_discussions_state? is false' do
941 942 943 944 945 946 947 948
        before do
          allow(subject).to receive(:mergeable_discussions_state?) { false }
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
        end
      end
949 950 951
    end
  end

952
  describe '#mergeable_ci_state?' do
J
James Lopez 已提交
953
    let(:project) { create(:empty_project, only_allow_merge_if_pipeline_succeeds: true) }
R
Rémy Coutable 已提交
954
    let(:pipeline) { create(:ci_empty_pipeline) }
955 956 957

    subject { build(:merge_request, target_project: project) }

958
    context 'when it is only allowed to merge when build is green' do
R
Rémy Coutable 已提交
959
      context 'and a failed pipeline is associated' do
960
        before do
961
          pipeline.update(status: 'failed')
962
          allow(subject).to receive(:head_pipeline) { pipeline }
963
        end
964

965
        it { expect(subject.mergeable_ci_state?).to be_falsey }
966 967
      end

968 969 970
      context 'and a successful pipeline is associated' do
        before do
          pipeline.update(status: 'success')
971
          allow(subject).to receive(:head_pipeline) { pipeline }
972 973 974 975 976 977 978 979
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

      context 'and a skipped pipeline is associated' do
        before do
          pipeline.update(status: 'skipped')
980
          allow(subject).to receive(:head_pipeline) { pipeline }
981 982 983 984 985
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
986
      context 'when no pipeline is associated' do
987
        before do
988
          allow(subject).to receive(:head_pipeline) { nil }
989 990 991
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
992 993 994
      end
    end

995
    context 'when merges are not restricted to green builds' do
J
James Lopez 已提交
996
      subject { build(:merge_request, target_project: build(:empty_project, only_allow_merge_if_pipeline_succeeds: false)) }
997

R
Rémy Coutable 已提交
998
      context 'and a failed pipeline is associated' do
999
        before do
R
Rémy Coutable 已提交
1000
          pipeline.statuses << create(:commit_status, status: 'failed', project: project)
1001
          allow(subject).to receive(:head_pipeline) { pipeline }
1002 1003 1004 1005 1006
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
1007
      context 'when no pipeline is associated' do
1008
        before do
1009
          allow(subject).to receive(:head_pipeline) { nil }
1010 1011 1012
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1013 1014 1015
      end
    end
  end
1016

1017
  describe '#mergeable_discussions_state?' do
R
Rémy Coutable 已提交
1018
    let(:merge_request) { create(:merge_request_with_diff_notes, source_project: project) }
1019

R
Rémy Coutable 已提交
1020
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == true' do
1021
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: true) }
1022

R
Rémy Coutable 已提交
1023
      context 'with all discussions resolved' do
1024
        before do
R
Rémy Coutable 已提交
1025
          merge_request.discussions.each { |d| d.resolve!(merge_request.author) }
1026 1027 1028
        end

        it 'returns true' do
R
Rémy Coutable 已提交
1029
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1030 1031 1032
        end
      end

R
Rémy Coutable 已提交
1033
      context 'with unresolved discussions' do
1034
        before do
R
Rémy Coutable 已提交
1035
          merge_request.discussions.each(&:unresolve!)
1036 1037 1038
        end

        it 'returns false' do
R
Rémy Coutable 已提交
1039
          expect(merge_request.mergeable_discussions_state?).to be_falsey
1040 1041
        end
      end
1042 1043 1044 1045 1046 1047 1048 1049 1050 1051

      context 'with no discussions' do
        before do
          merge_request.notes.destroy_all
        end

        it 'returns true' do
          expect(merge_request.mergeable_discussions_state?).to be_truthy
        end
      end
1052 1053
    end

R
Rémy Coutable 已提交
1054
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == false' do
1055
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: false) }
1056

R
Rémy Coutable 已提交
1057
      context 'with unresolved discussions' do
1058
        before do
R
Rémy Coutable 已提交
1059
          merge_request.discussions.each(&:unresolve!)
1060 1061 1062
        end

        it 'returns true' do
R
Rémy Coutable 已提交
1063
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1064 1065 1066 1067 1068
        end
      end
    end
  end

D
Douwe Maan 已提交
1069
  describe "#environments_for" do
1070
    let(:project)       { create(:project, :repository) }
D
Douwe Maan 已提交
1071
    let(:user)          { project.creator }
Z
Z.J. van de Weg 已提交
1072 1073
    let(:merge_request) { create(:merge_request, source_project: project) }

D
Douwe Maan 已提交
1074 1075 1076 1077 1078
    before do
      merge_request.source_project.add_master(user)
      merge_request.target_project.add_master(user)
    end

1079 1080
    context 'with multiple environments' do
      let(:environments) { create_list(:environment, 3, project: project) }
1081

1082 1083 1084 1085 1086 1087
      before do
        create(:deployment, environment: environments.first, ref: 'master', sha: project.commit('master').id)
        create(:deployment, environment: environments.second, ref: 'feature', sha: project.commit('feature').id)
      end

      it 'selects deployed environments' do
D
Douwe Maan 已提交
1088
        expect(merge_request.environments_for(user)).to contain_exactly(environments.first)
1089 1090 1091 1092 1093
      end
    end

    context 'with environments on source project' do
      let(:source_project) do
1094
        create(:project, :repository) do |fork_project|
1095 1096 1097
          fork_project.create_forked_project_link(forked_to_project_id: fork_project.id, forked_from_project_id: project.id)
        end
      end
K
Kamil Trzcinski 已提交
1098

1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111
      let(:merge_request) do
        create(:merge_request,
               source_project: source_project, source_branch: 'feature',
               target_project: project)
      end

      let(:source_environment) { create(:environment, project: source_project) }

      before do
        create(:deployment, environment: source_environment, ref: 'feature', sha: merge_request.diff_head_sha)
      end

      it 'selects deployed environments' do
D
Douwe Maan 已提交
1112
        expect(merge_request.environments_for(user)).to contain_exactly(source_environment)
1113 1114 1115 1116 1117 1118 1119 1120 1121 1122
      end

      context 'with environments on target project' do
        let(:target_environment) { create(:environment, project: project) }

        before do
          create(:deployment, environment: target_environment, tag: true, sha: merge_request.diff_head_sha)
        end

        it 'selects deployed environments' do
D
Douwe Maan 已提交
1123
          expect(merge_request.environments_for(user)).to contain_exactly(source_environment, target_environment)
1124 1125
        end
      end
1126 1127 1128 1129 1130 1131 1132 1133
    end

    context 'without a diff_head_commit' do
      before do
        expect(merge_request).to receive(:diff_head_commit).and_return(nil)
      end

      it 'returns an empty array' do
D
Douwe Maan 已提交
1134
        expect(merge_request.environments_for(user)).to be_empty
1135
      end
Z
Z.J. van de Weg 已提交
1136 1137 1138
    end
  end

1139 1140 1141 1142 1143
  describe "#reload_diff" do
    let(:note) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject) }

    let(:commit) { subject.project.commit(sample_commit.id) }

1144
    it "does not change existing merge request diff" do
1145
      expect(subject.merge_request_diff).not_to receive(:save_git_content)
1146 1147 1148
      subject.reload_diff
    end

1149 1150 1151 1152
    it "creates new merge request diff" do
      expect { subject.reload_diff }.to change { subject.merge_request_diffs.count }.by(1)
    end

1153 1154 1155 1156 1157 1158
    it "executs diff cache service" do
      expect_any_instance_of(MergeRequests::MergeRequestDiffCacheService).to receive(:execute).with(subject)

      subject.reload_diff
    end

1159 1160 1161 1162
    it "updates diff note positions" do
      old_diff_refs = subject.diff_refs

      # Update merge_request_diff so that #diff_refs will return commit.diff_refs
1163 1164 1165 1166 1167 1168
      allow(subject).to receive(:create_merge_request_diff) do
        subject.merge_request_diffs.create(
          base_commit_sha: commit.parent_id,
          start_commit_sha: commit.parent_id,
          head_commit_sha: commit.sha
        )
1169 1170

        subject.merge_request_diff(true)
1171 1172 1173 1174 1175 1176 1177 1178 1179 1180
      end

      expect(Notes::DiffPositionUpdateService).to receive(:new).with(
        subject.project,
        nil,
        old_diff_refs: old_diff_refs,
        new_diff_refs: commit.diff_refs,
        paths: note.position.paths
      ).and_call_original

1181
      expect_any_instance_of(Notes::DiffPositionUpdateService).to receive(:execute).with(note)
1182 1183 1184 1185 1186
      expect_any_instance_of(DiffNote).to receive(:save).once

      subject.reload_diff
    end
  end
1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200

  describe '#branch_merge_base_commit' do
    context 'source and target branch exist' do
      it { expect(subject.branch_merge_base_commit.sha).to eq('ae73cb07c9eeaf35924a10f713b364d32b2dd34f') }
      it { expect(subject.branch_merge_base_commit).to be_a(Commit) }
    end

    context 'when the target branch does not exist' do
      before do
        subject.project.repository.raw_repository.delete_branch(subject.target_branch)
      end

      it 'returns nil' do
        expect(subject.branch_merge_base_commit).to be_nil
1201 1202 1203 1204
      end
    end
  end

1205
  describe "#diff_sha_refs" do
1206 1207 1208 1209 1210 1211 1212 1213
    context "with diffs" do
      subject { create(:merge_request, :with_diffs) }

      it "does not touch the repository" do
        subject # Instantiate the object

        expect_any_instance_of(Repository).not_to receive(:commit)

1214
        subject.diff_sha_refs
1215 1216 1217 1218 1219 1220 1221 1222 1223
      end

      it "returns expected diff_refs" do
        expected_diff_refs = Gitlab::Diff::DiffRefs.new(
          base_sha:  subject.merge_request_diff.base_commit_sha,
          start_sha: subject.merge_request_diff.start_commit_sha,
          head_sha:  subject.merge_request_diff.head_commit_sha
        )

1224
        expect(subject.diff_sha_refs).to eq(expected_diff_refs)
1225 1226 1227
      end
    end
  end
1228

1229
  describe '#conflicts_can_be_resolved_in_ui?' do
S
Sean McGivern 已提交
1230 1231 1232 1233 1234 1235 1236 1237 1238 1239
    def create_merge_request(source_branch)
      create(:merge_request, source_branch: source_branch, target_branch: 'conflict-start') do |mr|
        mr.mark_as_unmergeable
      end
    end

    it 'returns a falsey value when the MR can be merged without conflicts' do
      merge_request = create_merge_request('master')
      merge_request.mark_as_mergeable

1240
      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
S
Sean McGivern 已提交
1241 1242
    end

1243 1244 1245 1246 1247 1248
    it 'returns a falsey value when the MR is marked as having conflicts, but has none' do
      merge_request = create_merge_request('master')

      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
    end

1249 1250 1251 1252 1253 1254 1255
    it 'returns a falsey value when the MR has a missing ref after a force push' do
      merge_request = create_merge_request('conflict-resolvable')
      allow(merge_request.conflicts).to receive(:merge_index).and_raise(Rugged::OdbError)

      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
    end

S
Sean McGivern 已提交
1256 1257 1258 1259
    it 'returns a falsey value when the MR does not support new diff notes' do
      merge_request = create_merge_request('conflict-resolvable')
      merge_request.merge_request_diff.update_attributes(start_commit_sha: nil)

1260
      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
S
Sean McGivern 已提交
1261 1262 1263 1264 1265
    end

    it 'returns a falsey value when the conflicts contain a large file' do
      merge_request = create_merge_request('conflict-too-large')

1266
      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
S
Sean McGivern 已提交
1267 1268 1269 1270 1271
    end

    it 'returns a falsey value when the conflicts contain a binary file' do
      merge_request = create_merge_request('conflict-binary-file')

1272
      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
S
Sean McGivern 已提交
1273 1274 1275 1276 1277
    end

    it 'returns a falsey value when the conflicts contain a file edited in one branch and deleted in another' do
      merge_request = create_merge_request('conflict-missing-side')

1278
      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
S
Sean McGivern 已提交
1279 1280 1281 1282 1283
    end

    it 'returns a truthy value when the conflicts are resolvable in the UI' do
      merge_request = create_merge_request('conflict-resolvable')

1284
      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_truthy
S
Sean McGivern 已提交
1285
    end
S
Sean McGivern 已提交
1286 1287 1288 1289 1290 1291

    it 'returns a truthy value when the conflicts have to be resolved in an editor' do
      merge_request = create_merge_request('conflict-contains-conflict-markers')

      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_truthy
    end
S
Sean McGivern 已提交
1292
  end
1293

1294
  describe "#source_project_missing?" do
1295 1296
    let(:project)      { create(:empty_project) }
    let(:fork_project) { create(:empty_project, forked_from_project: project) }
1297 1298 1299
    let(:user)         { create(:user) }
    let(:unlink_project) { Projects::UnlinkForkService.new(fork_project, user) }

K
Katarzyna Kobierska 已提交
1300
    context "when the fork exists" do
1301 1302 1303 1304 1305 1306
      let(:merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

1307
      it { expect(merge_request.source_project_missing?).to be_falsey }
1308 1309
    end

K
Katarzyna Kobierska 已提交
1310
    context "when the source project is the same as the target project" do
1311 1312
      let(:merge_request) { create(:merge_request, source_project: project) }

1313
      it { expect(merge_request.source_project_missing?).to be_falsey }
1314 1315
    end

K
Katarzyna Kobierska 已提交
1316
    context "when the fork does not exist" do
1317 1318 1319 1320 1321 1322
      let(:merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1323
      it "returns true" do
1324 1325 1326
        unlink_project.execute
        merge_request.reload

1327
        expect(merge_request.source_project_missing?).to be_truthy
1328 1329 1330 1331 1332
      end
    end
  end

  describe "#closed_without_fork?" do
1333 1334
    let(:project)      { create(:empty_project) }
    let(:fork_project) { create(:empty_project, forked_from_project: project) }
1335 1336 1337
    let(:user)         { create(:user) }
    let(:unlink_project) { Projects::UnlinkForkService.new(fork_project, user) }

K
Katarzyna Kobierska 已提交
1338
    context "when the merge request is closed" do
1339 1340 1341 1342 1343 1344
      let(:closed_merge_request) do
        create(:closed_merge_request,
          source_project: fork_project,
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1345
      it "returns false if the fork exist" do
1346 1347 1348
        expect(closed_merge_request.closed_without_fork?).to be_falsey
      end

K
Katarzyna Kobierska 已提交
1349
      it "returns true if the fork does not exist" do
1350 1351 1352 1353 1354 1355
        unlink_project.execute
        closed_merge_request.reload

        expect(closed_merge_request.closed_without_fork?).to be_truthy
      end
    end
K
Katarzyna Kobierska 已提交
1356

K
Katarzyna Kobierska 已提交
1357
    context "when the merge request is open" do
K
Katarzyna Kobierska 已提交
1358 1359 1360 1361 1362 1363 1364 1365 1366 1367
      let(:open_merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

      it "returns false" do
        expect(open_merge_request.closed_without_fork?).to be_falsey
      end
    end
1368
  end
1369

1370
  describe '#reopenable?' do
K
Katarzyna Kobierska 已提交
1371 1372 1373
    context 'when the merge request is closed' do
      it 'returns true' do
        subject.close
K
Katarzyna Kobierska 已提交
1374

1375
        expect(subject.reopenable?).to be_truthy
K
Katarzyna Kobierska 已提交
1376 1377 1378
      end

      context 'forked project' do
1379
        let(:project)      { create(:empty_project) }
K
Katarzyna Kobierska 已提交
1380
        let(:user)         { create(:user) }
1381
        let(:fork_project) { create(:empty_project, forked_from_project: project, namespace: user.namespace) }
1382 1383

        let!(:merge_request) do
K
Katarzyna Kobierska 已提交
1384 1385 1386 1387 1388 1389 1390 1391
          create(:closed_merge_request,
            source_project: fork_project,
            target_project: project)
        end

        it 'returns false if unforked' do
          Projects::UnlinkForkService.new(fork_project, user).execute

1392
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1393 1394 1395
        end

        it 'returns false if the source project is deleted' do
1396
          Projects::DestroyService.new(fork_project, user).execute
K
Katarzyna Kobierska 已提交
1397

1398
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1399 1400
        end

K
Katarzyna Kobierska 已提交
1401
        it 'returns false if the merge request is merged' do
K
Katarzyna Kobierska 已提交
1402 1403
          merge_request.update_attributes(state: 'merged')

1404
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1405 1406
        end
      end
K
Katarzyna Kobierska 已提交
1407 1408
    end

K
Katarzyna Kobierska 已提交
1409
    context 'when the merge request is opened' do
K
Katarzyna Kobierska 已提交
1410
      it 'returns false' do
1411
        expect(subject.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1412
      end
K
Katarzyna Kobierska 已提交
1413 1414
    end
  end
1415

1416 1417 1418 1419 1420 1421 1422 1423 1424
  describe '#mergeable_with_slash_command?' do
    def create_pipeline(status)
      create(:ci_pipeline_with_one_job,
        project: project,
        ref:     merge_request.source_branch,
        sha:     merge_request.diff_head_sha,
        status:  status)
    end

J
James Lopez 已提交
1425
    let(:project)       { create(:project, :public, :repository, only_allow_merge_if_pipeline_succeeds: true) }
1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479
    let(:developer)     { create(:user) }
    let(:user)          { create(:user) }
    let(:merge_request) { create(:merge_request, source_project: project) }
    let(:mr_sha)        { merge_request.diff_head_sha }

    before do
      project.team << [developer, :developer]
    end

    context 'when autocomplete_precheck is set to true' do
      it 'is mergeable by developer' do
        expect(merge_request.mergeable_with_slash_command?(developer, autocomplete_precheck: true)).to be_truthy
      end

      it 'is not mergeable by normal user' do
        expect(merge_request.mergeable_with_slash_command?(user, autocomplete_precheck: true)).to be_falsey
      end
    end

    context 'when autocomplete_precheck is set to false' do
      it 'is mergeable by developer' do
        expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: mr_sha)).to be_truthy
      end

      it 'is not mergeable by normal user' do
        expect(merge_request.mergeable_with_slash_command?(user, last_diff_sha: mr_sha)).to be_falsey
      end

      context 'closed MR'  do
        before do
          merge_request.update_attribute(:state, :closed)
        end

        it 'is not mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: mr_sha)).to be_falsey
        end
      end

      context 'MR with WIP'  do
        before do
          merge_request.update_attribute(:title, 'WIP: some MR')
        end

        it 'is not mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: mr_sha)).to be_falsey
        end
      end

      context 'sha differs from the MR diff_head_sha'  do
        it 'is not mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: 'some other sha')).to be_falsey
        end
      end

J
Jarka Kadlecova 已提交
1480 1481 1482 1483 1484 1485
      context 'sha is not provided'  do
        it 'is not mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer)).to be_falsey
        end
      end

1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517
      context 'with pipeline ok'  do
        before do
          create_pipeline(:success)
        end

        it 'is mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: mr_sha)).to be_truthy
        end
      end

      context 'with failing pipeline'  do
        before do
          create_pipeline(:failed)
        end

        it 'is not mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: mr_sha)).to be_falsey
        end
      end

      context 'with running pipeline'  do
        before do
          create_pipeline(:running)
        end

        it 'is mergeable' do
          expect(merge_request.mergeable_with_slash_command?(developer, last_diff_sha: mr_sha)).to be_truthy
        end
      end
    end
  end

1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538
  describe '#has_commits?' do
    before do
      allow(subject.merge_request_diff).to receive(:commits_count).
        and_return(2)
    end

    it 'returns true when merge request diff has commits' do
      expect(subject.has_commits?).to be_truthy
    end
  end

  describe '#has_no_commits?' do
    before do
      allow(subject.merge_request_diff).to receive(:commits_count).
        and_return(0)
    end

    it 'returns true when merge request diff has 0 commits' do
      expect(subject.has_no_commits?).to be_truthy
    end
  end
D
Dmitriy Zaporozhets 已提交
1539
end