merge_request_spec.rb 56.8 KB
Newer Older
D
Dmitriy Zaporozhets 已提交
1 2
require 'spec_helper'

3
describe MergeRequest do
4 5
  include RepoHelpers

6 7
  subject { create(:merge_request) }

R
Robert Speicher 已提交
8
  describe 'associations' do
9 10
    it { is_expected.to belong_to(:target_project).class_name('Project') }
    it { is_expected.to belong_to(:source_project).class_name('Project') }
11
    it { is_expected.to belong_to(:merge_user).class_name("User") }
12
    it { is_expected.to belong_to(:assignee) }
13
    it { is_expected.to have_many(:merge_request_diffs) }
R
Robert Speicher 已提交
14 15
  end

16 17 18 19 20 21 22 23 24 25
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(InternalId) }
    it { is_expected.to include_module(Issuable) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(Taskable) }
  end

Z
Zeger-Jan van de Weg 已提交
26 27 28 29 30
  describe "act_as_paranoid" do
    it { is_expected.to have_db_column(:deleted_at) }
    it { is_expected.to have_db_index(:deleted_at) }
  end

31
  describe 'validation' do
32 33
    it { is_expected.to validate_presence_of(:target_branch) }
    it { is_expected.to validate_presence_of(:source_branch) }
Z
Zeger-Jan van de Weg 已提交
34

35
    context "Validation of merge user with Merge When Pipeline Succeeds" do
Z
Zeger-Jan van de Weg 已提交
36 37 38 39 40
      it "allows user to be nil when the feature is disabled" do
        expect(subject).to be_valid
      end

      it "is invalid without merge user" do
J
James Lopez 已提交
41
        subject.merge_when_pipeline_succeeds = true
Z
Zeger-Jan van de Weg 已提交
42 43 44 45
        expect(subject).not_to be_valid
      end

      it "is valid with merge user" do
J
James Lopez 已提交
46
        subject.merge_when_pipeline_succeeds = true
Z
Zeger-Jan van de Weg 已提交
47 48 49 50 51
        subject.merge_user = build(:user)

        expect(subject).to be_valid
      end
    end
D
Dmitriy Zaporozhets 已提交
52 53
  end

R
Robert Speicher 已提交
54
  describe 'respond to' do
55 56 57
    it { is_expected.to respond_to(:unchecked?) }
    it { is_expected.to respond_to(:can_be_merged?) }
    it { is_expected.to respond_to(:cannot_be_merged?) }
58
    it { is_expected.to respond_to(:merge_params) }
J
James Lopez 已提交
59
    it { is_expected.to respond_to(:merge_when_pipeline_succeeds) }
60
  end
A
Andrey Kumanyaev 已提交
61

62 63 64 65 66 67
  describe '.in_projects' do
    it 'returns the merge requests for a set of projects' do
      expect(described_class.in_projects(Project.all)).to eq([subject])
    end
  end

68
  describe '#target_branch_sha' do
69
    let(:project) { create(:project, :repository) }
70

71
    subject { create(:merge_request, source_project: project, target_project: project) }
72

73
    context 'when the target branch does not exist' do
74 75 76
      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
      end
77 78

      it 'returns nil' do
79
        expect(subject.target_branch_sha).to be_nil
80 81
      end
    end
82 83 84 85 86 87

    it 'returns memoized value' do
      subject.target_branch_sha = '8ffb3c15a5475e59ae909384297fede4badcb4c7'

      expect(subject.target_branch_sha).to eq '8ffb3c15a5475e59ae909384297fede4badcb4c7'
    end
88 89
  end

90 91 92 93 94
  describe '#card_attributes' do
    it 'includes the author name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignee).and_return(nil)

95 96
      expect(subject.card_attributes)
        .to eq({ 'Author' => 'Robert', 'Assignee' => nil })
97 98 99 100 101 102
    end

    it 'includes the assignee name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignee).and_return(double(name: 'Douwe'))

103 104
      expect(subject.card_attributes)
        .to eq({ 'Author' => 'Robert', 'Assignee' => 'Douwe' })
105 106 107
    end
  end

108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123
  describe '#assignee_ids' do
    it 'returns an array of the assigned user id' do
      subject.assignee_id = 123

      expect(subject.assignee_ids).to eq([123])
    end
  end

  describe '#assignee_ids=' do
    it 'sets assignee_id to the last id in the array' do
      subject.assignee_ids = [123, 456]

      expect(subject.assignee_id).to eq(456)
    end
  end

124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143
  describe '#assignee_or_author?' do
    let(:user) { create(:user) }

    it 'returns true for a user that is assigned to a merge request' do
      subject.assignee = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns true for a user that is the author of a merge request' do
      subject.author = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns false for a user that is not the assignee or author' do
      expect(subject.assignee_or_author?(user)).to eq(false)
    end
  end

144 145 146 147 148 149 150 151 152 153 154
  describe '#cache_merge_request_closes_issues!' do
    before do
      subject.project.team << [subject.author, :developer]
      subject.target_branch = subject.project.default_branch
    end

    it 'caches closed issues' do
      issue  = create :issue, project: subject.project
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])

155
      expect { subject.cache_merge_request_closes_issues!(subject.author) }.to change(subject.merge_requests_closing_issues, :count).by(1)
156 157
    end

158 159 160 161
    context 'when both internal and external issue trackers are enabled' do
      before do
        subject.project.has_external_issue_tracker = true
        subject.project.save!
162
        create(:jira_service, project: subject.project)
163 164 165 166 167 168
      end

      it 'does not cache issues from external trackers' do
        issue  = ExternalIssue.new('JIRA-123', subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])
169

170
        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to raise_error
171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206
        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
      end

      it 'caches an internal issue' do
        issue  = create(:issue, project: subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }
          .to change(subject.merge_requests_closing_issues, :count).by(1)
      end
    end

    context 'when only external issue tracker enabled' do
      before do
        subject.project.has_external_issue_tracker = true
        subject.project.issues_enabled = false
        subject.project.save!
      end

      it 'does not cache issues from external trackers' do
        issue  = ExternalIssue.new('JIRA-123', subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
      end

      it 'does not cache an internal issue' do
        issue  = create(:issue, project: subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }
          .not_to change(subject.merge_requests_closing_issues, :count)
      end
207 208 209
    end
  end

210
  describe '#source_branch_sha' do
211 212 213 214 215
    let(:last_branch_commit) { subject.source_project.repository.commit(subject.source_branch) }

    context 'with diffs' do
      subject { create(:merge_request, :with_diffs) }
      it 'returns the sha of the source branch last commit' do
216
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
217 218 219
      end
    end

220 221 222
    context 'without diffs' do
      subject { create(:merge_request, :without_diffs) }
      it 'returns the sha of the source branch last commit' do
223
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
224 225 226
      end
    end

227 228 229
    context 'when the merge request is being created' do
      subject { build(:merge_request, source_branch: nil, compare_commits: []) }
      it 'returns nil' do
230
        expect(subject.source_branch_sha).to be_nil
231 232
      end
    end
233 234 235 236 237 238

    it 'returns memoized value' do
      subject.source_branch_sha = '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'

      expect(subject.source_branch_sha).to eq '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
    end
239 240
  end

241
  describe '#to_reference' do
242
    let(:project) { build(:project, name: 'sample-project') }
243 244
    let(:merge_request) { build(:merge_request, target_project: project, iid: 1) }

245
    it 'returns a String reference to the object' do
246
      expect(merge_request.to_reference).to eq "!1"
247 248 249
    end

    it 'supports a cross-project reference' do
250
      another_project = build(:project, name: 'another-project', namespace: project.namespace)
251
      expect(merge_request.to_reference(another_project)).to eq "sample-project!1"
252
    end
253 254

    it 'returns a String reference with the full path' do
255
      expect(merge_request.to_reference(full: true)).to eq(project.full_path + '!1')
256
    end
257
  end
258

259
  describe '#raw_diffs' do
S
Sean McGivern 已提交
260 261 262 263 264 265 266
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
        merge_request.merge_request_diff = MergeRequestDiff.new

267
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(options)
S
Sean McGivern 已提交
268

269 270 271 272 273 274 275 276 277 278 279 280 281 282 283
        merge_request.raw_diffs(options)
      end
    end

    context 'when there are no MR diffs' do
      it 'delegates to the compare object' do
        merge_request.compare = double(:compare)

        expect(merge_request.compare).to receive(:raw_diffs).with(options)

        merge_request.raw_diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
284 285 286 287 288 289
  describe '#diffs' do
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
290
        merge_request.save
S
Sean McGivern 已提交
291

292
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(hash_including(options))
S
Sean McGivern 已提交
293 294 295 296 297 298

        merge_request.diffs(options)
      end
    end

    context 'when there are no MR diffs' do
299
      it 'delegates to the compare object, setting expanded: true' do
S
Sean McGivern 已提交
300 301
        merge_request.compare = double(:compare)

302
        expect(merge_request.compare).to receive(:diffs).with(options.merge(expanded: true))
S
Sean McGivern 已提交
303 304 305 306 307 308

        merge_request.diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
309 310 311 312 313 314
  describe '#diff_size' do
    let(:merge_request) do
      build(:merge_request, source_branch: 'expand-collapse-files', target_branch: 'master')
    end

    context 'when there are MR diffs' do
315
      it 'returns the correct count' do
S
Sean McGivern 已提交
316
        merge_request.save
317 318

        expect(merge_request.diff_size).to eq('105')
S
Sean McGivern 已提交
319 320
      end

321 322 323 324 325
      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        merge_request.save

        expect(merge_request.diff_size).to eq('2+')
S
Sean McGivern 已提交
326 327 328
      end

      it 'does not perform highlighting' do
329 330
        merge_request.save

S
Sean McGivern 已提交
331 332 333 334 335 336 337
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end

    context 'when there are no MR diffs' do
338
      def set_compare(merge_request)
S
Sean McGivern 已提交
339 340 341 342 343 344 345 346 347 348
        merge_request.compare = CompareService.new(
          merge_request.source_project,
          merge_request.source_branch
        ).execute(
          merge_request.target_project,
          merge_request.target_branch
        )
      end

      it 'returns the correct count' do
349 350 351 352 353 354 355 356 357 358
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('105')
      end

      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('2+')
S
Sean McGivern 已提交
359 360 361
      end

      it 'does not perform highlighting' do
362 363
        set_compare(merge_request)

S
Sean McGivern 已提交
364 365 366 367 368 369 370
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end
  end

371
  describe "#related_notes" do
372
    let!(:merge_request) { create(:merge_request) }
373 374

    before do
375
      allow(merge_request).to receive(:commits) { [merge_request.source_project.repository.commit] }
376 377
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.project)
D
Dmitriy Zaporozhets 已提交
378
      create(:note, noteable: merge_request, project: merge_request.project)
379 380
    end

381
    it "includes notes for commits" do
382
      expect(merge_request.commits).not_to be_empty
383
      expect(merge_request.related_notes.count).to eq(2)
384
    end
385

386
    it "includes notes for commits from target project as well" do
387 388 389
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.target_project)

390
      expect(merge_request.commits).not_to be_empty
391
      expect(merge_request.related_notes.count).to eq(3)
392
    end
393
  end
394

I
Izaak Alpert 已提交
395 396
  describe '#for_fork?' do
    it 'returns true if the merge request is for a fork' do
397 398
      subject.source_project = build_stubbed(:project, namespace: create(:group))
      subject.target_project = build_stubbed(:project, namespace: create(:group))
I
Izaak Alpert 已提交
399

400
      expect(subject.for_fork?).to be_truthy
I
Izaak Alpert 已提交
401
    end
D
Dmitriy Zaporozhets 已提交
402

I
Izaak Alpert 已提交
403
    it 'returns false if is not for a fork' do
404
      expect(subject.for_fork?).to be_falsey
I
Izaak Alpert 已提交
405 406 407
    end
  end

408
  describe '#closes_issues' do
409 410
    let(:issue0) { create :issue, project: subject.project }
    let(:issue1) { create :issue, project: subject.project }
411 412 413 414

    let(:commit0) { double('commit0', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit1) { double('commit1', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit2) { double('commit2', safe_message: "Fixes #{issue1.to_reference}") }
415 416

    before do
417
      subject.project.team << [subject.author, :developer]
418
      allow(subject).to receive(:commits).and_return([commit0, commit1, commit2])
419 420
    end

421
    it 'accesses the set of issues that will be closed on acceptance' do
422 423
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
424

425
      closed = subject.closes_issues
426

427 428
      expect(closed).to include(issue0, issue1)
    end
429

430 431 432
    it 'only lists issues as to be closed if it targets the default branch' do
      allow(subject.project).to receive(:default_branch).and_return('master')
      subject.target_branch = 'something-else'
433

434
      expect(subject.closes_issues).to be_empty
435
    end
436
  end
437

438
  describe '#issues_mentioned_but_not_closing' do
439 440 441 442
    let(:closing_issue) { create :issue, project: subject.project }
    let(:mentioned_issue) { create :issue, project: subject.project }

    let(:commit) { double('commit', safe_message: "Fixes #{closing_issue.to_reference}") }
443

444
    it 'detects issues mentioned in description but not closed' do
445
      subject.project.team << [subject.author, :developer]
446
      subject.description = "Is related to #{mentioned_issue.to_reference} and #{closing_issue.to_reference}"
447

448
      allow(subject).to receive(:commits).and_return([commit])
449 450
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
451

452
      expect(subject.issues_mentioned_but_not_closing(subject.author)).to match_array([mentioned_issue])
453
    end
454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470

    context 'when the project has an external issue tracker' do
      before do
        subject.project.team << [subject.author, :developer]
        commit = double(:commit, safe_message: 'Fixes TEST-3')

        create(:jira_service, project: subject.project)

        allow(subject).to receive(:commits).and_return([commit])
        allow(subject).to receive(:description).and_return('Is related to TEST-2 and TEST-3')
        allow(subject.project).to receive(:default_branch).and_return(subject.target_branch)
      end

      it 'detects issues mentioned in description but not closed' do
        expect(subject.issues_mentioned_but_not_closing(subject.author).map(&:to_s)).to match_array(['TEST-2'])
      end
    end
471 472
  end

473
  describe "#work_in_progress?" do
474 475 476
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "detects the '#{wip_prefix}' prefix" do
        subject.title = "#{wip_prefix}#{subject.title}"
477
        expect(subject.work_in_progress?).to eq true
478
      end
T
Ted Hogan 已提交
479 480
    end

481 482
    it "doesn't detect WIP for words starting with WIP" do
      subject.title = "Wipwap #{subject.title}"
483
      expect(subject.work_in_progress?).to eq false
484 485
    end

486 487
    it "doesn't detect WIP for words containing with WIP" do
      subject.title = "WupWipwap #{subject.title}"
488
      expect(subject.work_in_progress?).to eq false
489 490
    end

491
    it "doesn't detect WIP by default" do
492
      expect(subject.work_in_progress?).to eq false
493 494 495
    end
  end

T
Thomas Balthazar 已提交
496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518
  describe "#wipless_title" do
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "removes the '#{wip_prefix}' prefix" do
        wipless_title = subject.title
        subject.title = "#{wip_prefix}#{subject.title}"

        expect(subject.wipless_title).to eq wipless_title
      end

      it "is satisfies the #work_in_progress? method" do
        subject.title = "#{wip_prefix}#{subject.title}"
        subject.title = subject.wipless_title

        expect(subject.work_in_progress?).to eq false
      end
    end
  end

  describe "#wip_title" do
    it "adds the WIP: prefix to the title" do
      wip_title = "WIP: #{subject.title}"

      expect(subject.wip_title).to eq wip_title
519
    end
T
Thomas Balthazar 已提交
520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535

    it "does not add the WIP: prefix multiple times" do
      wip_title = "WIP: #{subject.title}"
      subject.title = subject.wip_title
      subject.title = subject.wip_title

      expect(subject.wip_title).to eq wip_title
    end

    it "is satisfies the #work_in_progress? method" do
      subject.title = subject.wip_title

      expect(subject.work_in_progress?).to eq true
    end
  end

Z
Zeger-Jan van de Weg 已提交
536
  describe '#can_remove_source_branch?' do
Z
Zeger-Jan van de Weg 已提交
537 538
    let(:user) { create(:user) }
    let(:user2) { create(:user) }
539 540 541 542

    before do
      subject.source_project.team << [user, :master]

Z
Zeger-Jan van de Weg 已提交
543 544 545 546
      subject.source_branch = "feature"
      subject.target_branch = "master"
      subject.save!
    end
547

Z
Zeger-Jan van de Weg 已提交
548
    it "can't be removed when its a protected branch" do
549
      allow(ProtectedBranch).to receive(:protected?).and_return(true)
550 551 552
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

553
    it "can't remove a root ref" do
Z
Zeger-Jan van de Weg 已提交
554 555
      subject.source_branch = "master"
      subject.target_branch = "feature"
556 557 558 559

      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

Z
Zeger-Jan van de Weg 已提交
560 561 562 563
    it "is unable to remove the source branch for a project the user cannot push to" do
      expect(subject.can_remove_source_branch?(user2)).to be_falsey
    end

564
    it "can be removed if the last commit is the head of the source branch" do
565
      allow(subject).to receive(:source_branch_head).and_return(subject.diff_head_commit)
566

Z
Zeger-Jan van de Weg 已提交
567
      expect(subject.can_remove_source_branch?(user)).to be_truthy
568
    end
569 570

    it "cannot be removed if the last commit is not also the head of the source branch" do
571 572
      subject.source_branch = "lfs"

573 574
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end
575 576
  end

577 578 579 580 581 582 583 584 585 586 587 588 589 590 591
  describe '#merge_commit_message' do
    it 'includes merge information as the title' do
      request = build(:merge_request, source_branch: 'source', target_branch: 'target')

      expect(request.merge_commit_message)
        .to match("Merge branch 'source' into 'target'\n\n")
    end

    it 'includes its title in the body' do
      request = build(:merge_request, title: 'Remove all technical debt')

      expect(request.merge_commit_message)
        .to match("Remove all technical debt\n\n")
    end

592
    it 'includes its closed issues in the body' do
593
      issue = create(:issue, project: subject.project)
594

595
      subject.project.team << [subject.author, :developer]
596
      subject.description = "This issue Closes #{issue.to_reference}"
597

598 599
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
600 601

      expect(subject.merge_commit_message)
602
        .to match("Closes #{issue.to_reference}")
603 604 605 606 607 608
    end

    it 'includes its reference in the body' do
      request = build_stubbed(:merge_request)

      expect(request.merge_commit_message)
609
        .to match("See merge request #{request.to_reference(full: true)}")
610 611 612 613 614 615 616
    end

    it 'excludes multiple linebreak runs when description is blank' do
      request = build(:merge_request, title: 'Title', description: nil)

      expect(request.merge_commit_message).not_to match("Title\n\n\n\n")
    end
617 618 619 620 621 622 623 624 625 626 627 628 629 630

    it 'includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message(include_description: true))
        .to match("By removing all code\n\n")
    end

    it 'does not includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message)
        .not_to match("By removing all code\n\n")
    end
631 632
  end

J
James Lopez 已提交
633
  describe "#reset_merge_when_pipeline_succeeds" do
634
    let(:merge_if_green) do
J
James Lopez 已提交
635
      create :merge_request, merge_when_pipeline_succeeds: true, merge_user: create(:user),
636 637
                             merge_params: { "should_remove_source_branch" => "1", "commit_message" => "msg" }
    end
Z
Zeger-Jan van de Weg 已提交
638

639
    it "sets the item to false" do
J
James Lopez 已提交
640
      merge_if_green.reset_merge_when_pipeline_succeeds
641 642
      merge_if_green.reload

J
James Lopez 已提交
643
      expect(merge_if_green.merge_when_pipeline_succeeds).to be_falsey
644 645
      expect(merge_if_green.merge_params["should_remove_source_branch"]).to be_nil
      expect(merge_if_green.merge_params["commit_message"]).to be_nil
646 647 648
    end
  end

649
  describe "#hook_attrs" do
650
    let(:attrs_hash) { subject.hook_attrs }
651 652 653 654 655 656 657 658 659 660

    [:source, :target].each do |key|
      describe "#{key} key" do
        include_examples 'project hook data', project_key: key do
          let(:data)    { attrs_hash }
          let(:project) { subject.send("#{key}_project") }
        end
      end
    end

661
    it "has all the required keys" do
662 663 664 665
      expect(attrs_hash).to include(:source)
      expect(attrs_hash).to include(:target)
      expect(attrs_hash).to include(:last_commit)
      expect(attrs_hash).to include(:work_in_progress)
666 667 668 669
      expect(attrs_hash).to include(:total_time_spent)
      expect(attrs_hash).to include(:human_time_estimate)
      expect(attrs_hash).to include(:human_total_time_spent)
      expect(attrs_hash).to include('time_estimate')
670
    end
671 672 673
  end

  describe '#diverged_commits_count' do
674 675
    let(:project)      { create(:project, :repository) }
    let(:fork_project) { create(:project, :repository, forked_from_project: project) }
676

677
    context 'when the target branch does not exist anymore' do
678 679 680 681 682 683
      subject { create(:merge_request, source_project: project, target_project: project) }

      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
        subject.reload
      end
684 685

      it 'does not crash' do
686
        expect { subject.diverged_commits_count }.not_to raise_error
687 688 689 690 691 692 693
      end

      it 'returns 0' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

694 695 696 697
    context 'diverged on same repository' do
      subject(:merge_request_with_divergence) { create(:merge_request, :diverged, source_project: project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
698
        expect(subject.diverged_commits_count).to eq(29)
699 700 701 702 703 704 705
      end
    end

    context 'diverged on fork' do
      subject(:merge_request_fork_with_divergence) { create(:merge_request, :diverged, source_project: fork_project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
706
        expect(subject.diverged_commits_count).to eq(29)
707 708 709 710 711 712 713 714 715 716 717 718
      end
    end

    context 'rebased on fork' do
      subject(:merge_request_rebased) { create(:merge_request, :rebased, source_project: fork_project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

    describe 'caching' do
719
      before do
720 721 722 723
        allow(Rails).to receive(:cache).and_return(ActiveSupport::Cache::MemoryStore.new)
      end

      it 'caches the output' do
724 725 726
        expect(subject).to receive(:compute_diverged_commits_count)
          .once
          .and_return(2)
727 728 729 730 731 732

        subject.diverged_commits_count
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the source sha changes' do
733 734 735
        expect(subject).to receive(:compute_diverged_commits_count)
          .twice
          .and_return(2)
736 737

        subject.diverged_commits_count
738
        allow(subject).to receive(:source_branch_sha).and_return('123abc')
739 740 741 742
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the target sha changes' do
743 744 745
        expect(subject).to receive(:compute_diverged_commits_count)
          .twice
          .and_return(2)
746 747

        subject.diverged_commits_count
748
        allow(subject).to receive(:target_branch_sha).and_return('123abc')
749 750 751
        subject.diverged_commits_count
      end
    end
752 753
  end

754
  it_behaves_like 'an editable mentionable' do
755
    subject { create(:merge_request, :simple) }
756

757
    let(:backref_text) { "merge request #{subject.to_reference}" }
758
    let(:set_mentionable_text) { ->(txt) { subject.description = txt } }
759
  end
V
Vinnie Okada 已提交
760 761

  it_behaves_like 'a Taskable' do
762
    subject { create :merge_request, :simple }
V
Vinnie Okada 已提交
763
  end
764

765
  describe '#commit_shas' do
766
    before do
767
      allow(subject.merge_request_diff).to receive(:commit_shas)
768
        .and_return(['sha1'])
769 770
    end

771
    it 'delegates to merge request diff' do
772
      expect(subject.commit_shas).to eq ['sha1']
773 774 775
    end
  end

776
  describe '#head_pipeline' do
777
    describe 'when the source project exists' do
778
      it 'returns the latest pipeline' do
779
        pipeline = create(:ci_empty_pipeline, project: subject.source_project, ref: 'master', status: 'running', sha: "123abc", head_pipeline_of: subject)
780

781
        expect(subject.head_pipeline).to eq(pipeline)
782 783 784 785 786 787 788
      end
    end

    describe 'when the source project does not exist' do
      it 'returns nil' do
        allow(subject).to receive(:source_project).and_return(nil)

789
        expect(subject.head_pipeline).to be_nil
790 791 792
      end
    end
  end
Y
Yorick Peterse 已提交
793

794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836
  describe '#has_ci?' do
    let(:merge_request) { build_stubbed(:merge_request) }

    context 'has ci' do
      it 'returns true if MR has head_pipeline_id and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { double }
        allow(merge_request).to receive(:has_no_commits?) { false }

        expect(merge_request.has_ci?).to be(true)
      end

      it 'returns true if MR has any pipeline and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:has_no_commits?) { false }
        allow(merge_request).to receive(:all_pipelines) { [double] }

        expect(merge_request.has_ci?).to be(true)
      end

      it 'returns true if MR has CI service and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { double }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:has_no_commits?) { false }
        allow(merge_request).to receive(:all_pipelines) { [] }

        expect(merge_request.has_ci?).to be(true)
      end
    end

    context 'has no ci' do
      it 'returns false if MR has no CI service nor pipeline, and no commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:all_pipelines) { [] }
        allow(merge_request).to receive(:has_no_commits?) { true }

        expect(merge_request.has_ci?).to be(false)
      end
    end
  end

837
  describe '#all_pipelines' do
838
    shared_examples 'returning pipelines with proper ordering' do
839
      let!(:all_pipelines) do
840
        subject.all_commit_shas.map do |sha|
841 842 843 844
          create(:ci_empty_pipeline,
                 project: subject.source_project,
                 sha: sha,
                 ref: subject.source_branch)
845 846 847 848 849
        end
      end

      it 'returns all pipelines' do
        expect(subject.all_pipelines).not_to be_empty
850
        expect(subject.all_pipelines).to eq(all_pipelines.reverse)
851
      end
852 853
    end

854 855 856 857 858 859
    context 'with single merge_request_diffs' do
      it_behaves_like 'returning pipelines with proper ordering'
    end

    context 'with multiple irrelevant merge_request_diffs' do
      before do
860
        subject.update(target_branch: 'v1.0.0')
861 862 863
      end

      it_behaves_like 'returning pipelines with proper ordering'
864
    end
865 866

    context 'with unsaved merge request' do
867
      subject { build(:merge_request) }
868 869 870

      let!(:pipeline) do
        create(:ci_empty_pipeline,
871
               project: subject.project,
872 873
               sha: subject.diff_head_sha,
               ref: subject.source_branch)
874
      end
875 876 877 878 879

      it 'returns pipelines from diff_head_sha' do
        expect(subject.all_pipelines).to contain_exactly(pipeline)
      end
    end
880 881
  end

882
  describe '#all_commit_shas' do
883
    context 'when merge request is persisted' do
884
      let(:all_commit_shas) do
885 886
        subject.merge_request_diffs.flat_map(&:commits).map(&:sha).uniq
      end
887

888 889 890
      shared_examples 'returning all SHA' do
        it 'returns all SHA from all merge_request_diffs' do
          expect(subject.merge_request_diffs.size).to eq(2)
891
          expect(subject.all_commit_shas).to match_array(all_commit_shas)
892
        end
893 894
      end

895 896 897 898 899 900
      context 'with a completely different branch' do
        before do
          subject.update(target_branch: 'v1.0.0')
        end

        it_behaves_like 'returning all SHA'
901 902
      end

903 904 905 906 907 908 909 910
      context 'with a branch having no difference' do
        before do
          subject.update(target_branch: 'v1.1.0')
          subject.reload # make sure commits were not cached
        end

        it_behaves_like 'returning all SHA'
      end
911 912
    end

913 914 915 916 917 918 919 920 921
    context 'when merge request is not persisted' do
      context 'when compare commits are set in the service' do
        let(:commit) { spy('commit') }

        subject do
          build(:merge_request, compare_commits: [commit, commit])
        end

        it 'returns commits from compare commits temporary data' do
922
          expect(subject.all_commit_shas).to eq [commit, commit]
923
        end
924 925
      end

926 927 928 929
      context 'when compare commits are not set in the service' do
        subject { build(:merge_request) }

        it 'returns array with diff head sha element only' do
930
          expect(subject.all_commit_shas).to eq [subject.diff_head_sha]
931 932
        end
      end
933 934 935
    end
  end

Y
Yorick Peterse 已提交
936
  describe '#participants' do
937
    let(:project) { create(:project, :public) }
Y
Yorick Peterse 已提交
938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958

    let(:mr) do
      create(:merge_request, source_project: project, target_project: project)
    end

    let!(:note1) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'a')
    end

    let!(:note2) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'b')
    end

    it 'includes the merge request author' do
      expect(mr.participants).to include(mr.author)
    end

    it 'includes the authors of the notes' do
      expect(mr.participants).to include(note1.author, note2.author)
    end
  end
J
Josh Frye 已提交
959 960 961 962 963 964

  describe 'cached counts' do
    it 'updates when assignees change' do
      user1 = create(:user)
      user2 = create(:user)
      mr = create(:merge_request, assignee: user1)
965 966
      mr.project.add_developer(user1)
      mr.project.add_developer(user2)
J
Josh Frye 已提交
967

968 969
      expect(user1.assigned_open_merge_requests_count).to eq(1)
      expect(user2.assigned_open_merge_requests_count).to eq(0)
J
Josh Frye 已提交
970 971 972 973

      mr.assignee = user2
      mr.save

974 975
      expect(user1.assigned_open_merge_requests_count).to eq(0)
      expect(user2.assigned_open_merge_requests_count).to eq(1)
J
Josh Frye 已提交
976 977
    end
  end
978

979
  describe '#merge_async' do
980 981 982 983 984 985 986 987 988 989
    it 'enqueues MergeWorker job and updates merge_jid' do
      merge_request = create(:merge_request)
      user_id = double(:user_id)
      params = double(:params)
      merge_jid = 'hash-123'

      expect(MergeWorker).to receive(:perform_async).with(merge_request.id, user_id, params) do
        merge_jid
      end

990
      merge_request.merge_async(user_id, params)
991 992 993 994 995

      expect(merge_request.reload.merge_jid).to eq(merge_jid)
    end
  end

996
  describe '#check_if_can_be_merged' do
997
    let(:project) { create(:project, only_allow_merge_if_pipeline_succeeds: true) }
998 999 1000 1001

    subject { create(:merge_request, source_project: project, merge_status: :unchecked) }

    context 'when it is not broken and has no conflicts' do
1002
      before do
1003
        allow(subject).to receive(:broken?) { false }
1004
        allow(project.repository).to receive(:can_be_merged?).and_return(true)
1005
      end
1006

1007
      it 'is marked as mergeable' do
1008 1009 1010 1011 1012
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('can_be_merged')
      end
    end

    context 'when broken' do
1013 1014 1015
      before do
        allow(subject).to receive(:broken?) { true }
      end
1016 1017 1018 1019 1020 1021 1022 1023 1024

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end

    context 'when it has conflicts' do
      before do
        allow(subject).to receive(:broken?) { false }
1025
        allow(project.repository).to receive(:can_be_merged?).and_return(false)
1026 1027 1028 1029 1030 1031 1032 1033 1034
      end

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end
  end

  describe '#mergeable?' do
1035
    let(:project) { create(:project) }
1036 1037 1038

    subject { create(:merge_request, source_project: project) }

1039 1040
    it 'returns false if #mergeable_state? is false' do
      expect(subject).to receive(:mergeable_state?) { false }
1041

1042
      expect(subject.mergeable?).to be_falsey
1043 1044
    end

1045
    it 'return true if #mergeable_state? is true and the MR #can_be_merged? is true' do
1046 1047
      allow(subject).to receive(:mergeable_state?) { true }
      expect(subject).to receive(:check_if_can_be_merged)
1048
      expect(subject).to receive(:can_be_merged?) { true }
1049 1050 1051 1052 1053 1054

      expect(subject.mergeable?).to be_truthy
    end
  end

  describe '#mergeable_state?' do
1055
    let(:project) { create(:project, :repository) }
1056 1057 1058

    subject { create(:merge_request, source_project: project) }

1059
    it 'checks if merge request can be merged' do
1060
      allow(subject).to receive(:mergeable_ci_state?) { true }
1061 1062 1063 1064 1065 1066
      expect(subject).to receive(:check_if_can_be_merged)

      subject.mergeable?
    end

    context 'when not open' do
1067 1068 1069
      before do
        subject.close
      end
1070 1071

      it 'returns false' do
1072
        expect(subject.mergeable_state?).to be_falsey
1073 1074 1075 1076
      end
    end

    context 'when working in progress' do
1077 1078 1079
      before do
        subject.title = 'WIP MR'
      end
1080 1081

      it 'returns false' do
1082
        expect(subject.mergeable_state?).to be_falsey
1083 1084 1085 1086
      end
    end

    context 'when broken' do
1087 1088 1089
      before do
        allow(subject).to receive(:broken?) { true }
      end
1090 1091

      it 'returns false' do
1092
        expect(subject.mergeable_state?).to be_falsey
1093 1094 1095 1096
      end
    end

    context 'when failed' do
R
Rémy Coutable 已提交
1097
      context 'when #mergeable_ci_state? is false' do
1098
        before do
1099
          allow(subject).to receive(:mergeable_ci_state?) { false }
1100 1101 1102 1103
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
1104 1105
        end
      end
1106

R
Rémy Coutable 已提交
1107
      context 'when #mergeable_discussions_state? is false' do
1108 1109 1110 1111 1112 1113 1114 1115
        before do
          allow(subject).to receive(:mergeable_discussions_state?) { false }
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
        end
      end
1116 1117 1118
    end
  end

1119
  describe '#mergeable_ci_state?' do
1120
    let(:project) { create(:project, only_allow_merge_if_pipeline_succeeds: true) }
R
Rémy Coutable 已提交
1121
    let(:pipeline) { create(:ci_empty_pipeline) }
1122 1123 1124

    subject { build(:merge_request, target_project: project) }

1125
    context 'when it is only allowed to merge when build is green' do
R
Rémy Coutable 已提交
1126
      context 'and a failed pipeline is associated' do
1127
        before do
1128
          pipeline.update(status: 'failed')
1129
          allow(subject).to receive(:head_pipeline) { pipeline }
1130
        end
1131

1132
        it { expect(subject.mergeable_ci_state?).to be_falsey }
1133 1134
      end

1135 1136 1137
      context 'and a successful pipeline is associated' do
        before do
          pipeline.update(status: 'success')
1138
          allow(subject).to receive(:head_pipeline) { pipeline }
1139 1140 1141 1142 1143 1144 1145 1146
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

      context 'and a skipped pipeline is associated' do
        before do
          pipeline.update(status: 'skipped')
1147
          allow(subject).to receive(:head_pipeline) { pipeline }
1148 1149 1150 1151 1152
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
1153
      context 'when no pipeline is associated' do
1154
        before do
1155
          allow(subject).to receive(:head_pipeline) { nil }
1156 1157 1158
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1159 1160 1161
      end
    end

1162
    context 'when merges are not restricted to green builds' do
1163
      subject { build(:merge_request, target_project: build(:project, only_allow_merge_if_pipeline_succeeds: false)) }
1164

R
Rémy Coutable 已提交
1165
      context 'and a failed pipeline is associated' do
1166
        before do
R
Rémy Coutable 已提交
1167
          pipeline.statuses << create(:commit_status, status: 'failed', project: project)
1168
          allow(subject).to receive(:head_pipeline) { pipeline }
1169 1170 1171 1172 1173
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
1174
      context 'when no pipeline is associated' do
1175
        before do
1176
          allow(subject).to receive(:head_pipeline) { nil }
1177 1178 1179
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1180 1181 1182
      end
    end
  end
1183

1184
  describe '#mergeable_discussions_state?' do
R
Rémy Coutable 已提交
1185
    let(:merge_request) { create(:merge_request_with_diff_notes, source_project: project) }
1186

R
Rémy Coutable 已提交
1187
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == true' do
1188
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: true) }
1189

R
Rémy Coutable 已提交
1190
      context 'with all discussions resolved' do
1191
        before do
R
Rémy Coutable 已提交
1192
          merge_request.discussions.each { |d| d.resolve!(merge_request.author) }
1193 1194 1195
        end

        it 'returns true' do
R
Rémy Coutable 已提交
1196
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1197 1198 1199
        end
      end

R
Rémy Coutable 已提交
1200
      context 'with unresolved discussions' do
1201
        before do
R
Rémy Coutable 已提交
1202
          merge_request.discussions.each(&:unresolve!)
1203 1204 1205
        end

        it 'returns false' do
R
Rémy Coutable 已提交
1206
          expect(merge_request.mergeable_discussions_state?).to be_falsey
1207 1208
        end
      end
1209 1210 1211 1212 1213 1214 1215 1216 1217 1218

      context 'with no discussions' do
        before do
          merge_request.notes.destroy_all
        end

        it 'returns true' do
          expect(merge_request.mergeable_discussions_state?).to be_truthy
        end
      end
1219 1220
    end

R
Rémy Coutable 已提交
1221
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == false' do
1222
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: false) }
1223

R
Rémy Coutable 已提交
1224
      context 'with unresolved discussions' do
1225
        before do
R
Rémy Coutable 已提交
1226
          merge_request.discussions.each(&:unresolve!)
1227 1228 1229
        end

        it 'returns true' do
R
Rémy Coutable 已提交
1230
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1231 1232 1233 1234 1235
        end
      end
    end
  end

D
Douwe Maan 已提交
1236
  describe "#environments_for" do
1237
    let(:project)       { create(:project, :repository) }
D
Douwe Maan 已提交
1238
    let(:user)          { project.creator }
Z
Z.J. van de Weg 已提交
1239 1240
    let(:merge_request) { create(:merge_request, source_project: project) }

D
Douwe Maan 已提交
1241 1242 1243 1244 1245
    before do
      merge_request.source_project.add_master(user)
      merge_request.target_project.add_master(user)
    end

1246 1247
    context 'with multiple environments' do
      let(:environments) { create_list(:environment, 3, project: project) }
1248

1249 1250 1251 1252 1253 1254
      before do
        create(:deployment, environment: environments.first, ref: 'master', sha: project.commit('master').id)
        create(:deployment, environment: environments.second, ref: 'feature', sha: project.commit('feature').id)
      end

      it 'selects deployed environments' do
D
Douwe Maan 已提交
1255
        expect(merge_request.environments_for(user)).to contain_exactly(environments.first)
1256 1257 1258 1259 1260
      end
    end

    context 'with environments on source project' do
      let(:source_project) do
1261
        create(:project, :repository) do |fork_project|
1262 1263 1264
          fork_project.create_forked_project_link(forked_to_project_id: fork_project.id, forked_from_project_id: project.id)
        end
      end
K
Kamil Trzcinski 已提交
1265

1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278
      let(:merge_request) do
        create(:merge_request,
               source_project: source_project, source_branch: 'feature',
               target_project: project)
      end

      let(:source_environment) { create(:environment, project: source_project) }

      before do
        create(:deployment, environment: source_environment, ref: 'feature', sha: merge_request.diff_head_sha)
      end

      it 'selects deployed environments' do
D
Douwe Maan 已提交
1279
        expect(merge_request.environments_for(user)).to contain_exactly(source_environment)
1280 1281 1282 1283 1284 1285 1286 1287 1288 1289
      end

      context 'with environments on target project' do
        let(:target_environment) { create(:environment, project: project) }

        before do
          create(:deployment, environment: target_environment, tag: true, sha: merge_request.diff_head_sha)
        end

        it 'selects deployed environments' do
D
Douwe Maan 已提交
1290
          expect(merge_request.environments_for(user)).to contain_exactly(source_environment, target_environment)
1291 1292
        end
      end
1293 1294 1295 1296 1297 1298 1299 1300
    end

    context 'without a diff_head_commit' do
      before do
        expect(merge_request).to receive(:diff_head_commit).and_return(nil)
      end

      it 'returns an empty array' do
D
Douwe Maan 已提交
1301
        expect(merge_request.environments_for(user)).to be_empty
1302
      end
Z
Z.J. van de Weg 已提交
1303 1304 1305
    end
  end

1306
  describe "#reload_diff" do
1307
    let(:discussion) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject).to_discussion }
1308 1309
    let(:commit) { subject.project.commit(sample_commit.id) }

1310
    it "does not change existing merge request diff" do
1311
      expect(subject.merge_request_diff).not_to receive(:save_git_content)
1312 1313 1314
      subject.reload_diff
    end

1315 1316 1317 1318
    it "creates new merge request diff" do
      expect { subject.reload_diff }.to change { subject.merge_request_diffs.count }.by(1)
    end

1319 1320 1321 1322 1323 1324
    it "executs diff cache service" do
      expect_any_instance_of(MergeRequests::MergeRequestDiffCacheService).to receive(:execute).with(subject)

      subject.reload_diff
    end

1325 1326 1327 1328 1329 1330
    it "calls update_diff_discussion_positions" do
      expect(subject).to receive(:update_diff_discussion_positions)

      subject.reload_diff
    end
  end
1331

1332 1333 1334 1335 1336 1337
  describe '#update_diff_discussion_positions' do
    let(:discussion) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject).to_discussion }
    let(:commit) { subject.project.commit(sample_commit.id) }
    let(:old_diff_refs) { subject.diff_refs }

    before do
1338
      # Update merge_request_diff so that #diff_refs will return commit.diff_refs
1339 1340 1341 1342 1343 1344
      allow(subject).to receive(:create_merge_request_diff) do
        subject.merge_request_diffs.create(
          base_commit_sha: commit.parent_id,
          start_commit_sha: commit.parent_id,
          head_commit_sha: commit.sha
        )
1345 1346

        subject.merge_request_diff(true)
1347
      end
1348
    end
1349

1350
    it "updates diff discussion positions" do
1351
      expect(Discussions::UpdateDiffPositionService).to receive(:new).with(
1352
        subject.project,
1353
        subject.author,
1354 1355
        old_diff_refs: old_diff_refs,
        new_diff_refs: commit.diff_refs,
1356
        paths: discussion.position.paths
1357 1358
      ).and_call_original

1359
      expect_any_instance_of(Discussions::UpdateDiffPositionService).to receive(:execute).with(discussion).and_call_original
1360 1361
      expect_any_instance_of(DiffNote).to receive(:save).once

1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381
      subject.update_diff_discussion_positions(old_diff_refs: old_diff_refs,
                                               new_diff_refs: commit.diff_refs,
                                               current_user: subject.author)
    end

    context 'when resolve_outdated_diff_discussions is set' do
      before do
        discussion

        subject.project.update!(resolve_outdated_diff_discussions: true)
      end

      it 'calls MergeRequests::ResolvedDiscussionNotificationService' do
        expect_any_instance_of(MergeRequests::ResolvedDiscussionNotificationService)
          .to receive(:execute).with(subject)

        subject.update_diff_discussion_positions(old_diff_refs: old_diff_refs,
                                                 new_diff_refs: commit.diff_refs,
                                                 current_user: subject.author)
      end
1382 1383
    end
  end
1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397

  describe '#branch_merge_base_commit' do
    context 'source and target branch exist' do
      it { expect(subject.branch_merge_base_commit.sha).to eq('ae73cb07c9eeaf35924a10f713b364d32b2dd34f') }
      it { expect(subject.branch_merge_base_commit).to be_a(Commit) }
    end

    context 'when the target branch does not exist' do
      before do
        subject.project.repository.raw_repository.delete_branch(subject.target_branch)
      end

      it 'returns nil' do
        expect(subject.branch_merge_base_commit).to be_nil
1398 1399 1400 1401
      end
    end
  end

1402
  describe "#diff_refs" do
1403 1404 1405 1406 1407 1408 1409 1410
    context "with diffs" do
      subject { create(:merge_request, :with_diffs) }

      it "does not touch the repository" do
        subject # Instantiate the object

        expect_any_instance_of(Repository).not_to receive(:commit)

1411
        subject.diff_refs
1412 1413 1414 1415 1416 1417 1418 1419 1420
      end

      it "returns expected diff_refs" do
        expected_diff_refs = Gitlab::Diff::DiffRefs.new(
          base_sha:  subject.merge_request_diff.base_commit_sha,
          start_sha: subject.merge_request_diff.start_commit_sha,
          head_sha:  subject.merge_request_diff.head_commit_sha
        )

1421
        expect(subject.diff_refs).to eq(expected_diff_refs)
1422 1423 1424
      end
    end
  end
1425

1426
  describe "#source_project_missing?" do
1427 1428
    let(:project)      { create(:project) }
    let(:fork_project) { create(:project, forked_from_project: project) }
1429 1430 1431
    let(:user)         { create(:user) }
    let(:unlink_project) { Projects::UnlinkForkService.new(fork_project, user) }

K
Katarzyna Kobierska 已提交
1432
    context "when the fork exists" do
1433 1434 1435 1436 1437 1438
      let(:merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

1439
      it { expect(merge_request.source_project_missing?).to be_falsey }
1440 1441
    end

K
Katarzyna Kobierska 已提交
1442
    context "when the source project is the same as the target project" do
1443 1444
      let(:merge_request) { create(:merge_request, source_project: project) }

1445
      it { expect(merge_request.source_project_missing?).to be_falsey }
1446 1447
    end

K
Katarzyna Kobierska 已提交
1448
    context "when the fork does not exist" do
1449 1450 1451 1452 1453 1454
      let(:merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1455
      it "returns true" do
1456 1457 1458
        unlink_project.execute
        merge_request.reload

1459
        expect(merge_request.source_project_missing?).to be_truthy
1460 1461 1462 1463
      end
    end
  end

1464
  describe '#merge_ongoing?' do
1465 1466
    it 'returns true when merge_id is present and MR is not merged' do
      merge_request = build_stubbed(:merge_request, state: :open, merge_jid: 'foo')
1467 1468 1469 1470 1471

      expect(merge_request.merge_ongoing?).to be(true)
    end
  end

1472
  describe "#closed_without_fork?" do
1473 1474
    let(:project)      { create(:project) }
    let(:fork_project) { create(:project, forked_from_project: project) }
1475 1476 1477
    let(:user)         { create(:user) }
    let(:unlink_project) { Projects::UnlinkForkService.new(fork_project, user) }

K
Katarzyna Kobierska 已提交
1478
    context "when the merge request is closed" do
1479 1480 1481 1482 1483 1484
      let(:closed_merge_request) do
        create(:closed_merge_request,
          source_project: fork_project,
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1485
      it "returns false if the fork exist" do
1486 1487 1488
        expect(closed_merge_request.closed_without_fork?).to be_falsey
      end

K
Katarzyna Kobierska 已提交
1489
      it "returns true if the fork does not exist" do
1490 1491 1492 1493 1494 1495
        unlink_project.execute
        closed_merge_request.reload

        expect(closed_merge_request.closed_without_fork?).to be_truthy
      end
    end
K
Katarzyna Kobierska 已提交
1496

K
Katarzyna Kobierska 已提交
1497
    context "when the merge request is open" do
K
Katarzyna Kobierska 已提交
1498 1499 1500 1501 1502 1503 1504 1505 1506 1507
      let(:open_merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

      it "returns false" do
        expect(open_merge_request.closed_without_fork?).to be_falsey
      end
    end
1508
  end
1509

1510
  describe '#reopenable?' do
K
Katarzyna Kobierska 已提交
1511 1512 1513
    context 'when the merge request is closed' do
      it 'returns true' do
        subject.close
K
Katarzyna Kobierska 已提交
1514

1515
        expect(subject.reopenable?).to be_truthy
K
Katarzyna Kobierska 已提交
1516 1517 1518
      end

      context 'forked project' do
1519
        let(:project)      { create(:project) }
K
Katarzyna Kobierska 已提交
1520
        let(:user)         { create(:user) }
1521
        let(:fork_project) { create(:project, forked_from_project: project, namespace: user.namespace) }
1522 1523

        let!(:merge_request) do
K
Katarzyna Kobierska 已提交
1524 1525 1526 1527 1528 1529 1530 1531
          create(:closed_merge_request,
            source_project: fork_project,
            target_project: project)
        end

        it 'returns false if unforked' do
          Projects::UnlinkForkService.new(fork_project, user).execute

1532
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1533 1534 1535
        end

        it 'returns false if the source project is deleted' do
1536
          Projects::DestroyService.new(fork_project, user).execute
K
Katarzyna Kobierska 已提交
1537

1538
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1539 1540
        end

K
Katarzyna Kobierska 已提交
1541
        it 'returns false if the merge request is merged' do
K
Katarzyna Kobierska 已提交
1542 1543
          merge_request.update_attributes(state: 'merged')

1544
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1545 1546
        end
      end
K
Katarzyna Kobierska 已提交
1547 1548
    end

K
Katarzyna Kobierska 已提交
1549
    context 'when the merge request is opened' do
K
Katarzyna Kobierska 已提交
1550
      it 'returns false' do
1551
        expect(subject.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1552
      end
K
Katarzyna Kobierska 已提交
1553 1554
    end
  end
1555

1556
  describe '#mergeable_with_quick_action?' do
1557
    def create_pipeline(status)
F
Felipe Artur 已提交
1558
      pipeline = create(:ci_pipeline_with_one_job,
1559 1560 1561
        project: project,
        ref:     merge_request.source_branch,
        sha:     merge_request.diff_head_sha,
1562 1563
        status:  status,
        head_pipeline_of: merge_request)
F
Felipe Artur 已提交
1564 1565

      pipeline
1566 1567
    end

J
James Lopez 已提交
1568
    let(:project)       { create(:project, :public, :repository, only_allow_merge_if_pipeline_succeeds: true) }
1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579
    let(:developer)     { create(:user) }
    let(:user)          { create(:user) }
    let(:merge_request) { create(:merge_request, source_project: project) }
    let(:mr_sha)        { merge_request.diff_head_sha }

    before do
      project.team << [developer, :developer]
    end

    context 'when autocomplete_precheck is set to true' do
      it 'is mergeable by developer' do
1580
        expect(merge_request.mergeable_with_quick_action?(developer, autocomplete_precheck: true)).to be_truthy
1581 1582 1583
      end

      it 'is not mergeable by normal user' do
1584
        expect(merge_request.mergeable_with_quick_action?(user, autocomplete_precheck: true)).to be_falsey
1585 1586 1587 1588 1589
      end
    end

    context 'when autocomplete_precheck is set to false' do
      it 'is mergeable by developer' do
1590
        expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1591 1592 1593
      end

      it 'is not mergeable by normal user' do
1594
        expect(merge_request.mergeable_with_quick_action?(user, last_diff_sha: mr_sha)).to be_falsey
1595 1596 1597 1598 1599 1600 1601 1602
      end

      context 'closed MR'  do
        before do
          merge_request.update_attribute(:state, :closed)
        end

        it 'is not mergeable' do
1603
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1604 1605 1606 1607 1608 1609 1610 1611 1612
        end
      end

      context 'MR with WIP'  do
        before do
          merge_request.update_attribute(:title, 'WIP: some MR')
        end

        it 'is not mergeable' do
1613
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1614 1615 1616 1617 1618
        end
      end

      context 'sha differs from the MR diff_head_sha'  do
        it 'is not mergeable' do
1619
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: 'some other sha')).to be_falsey
1620 1621 1622
        end
      end

J
Jarka Kadlecova 已提交
1623 1624
      context 'sha is not provided'  do
        it 'is not mergeable' do
1625
          expect(merge_request.mergeable_with_quick_action?(developer)).to be_falsey
J
Jarka Kadlecova 已提交
1626 1627 1628
        end
      end

1629 1630 1631 1632 1633 1634
      context 'with pipeline ok'  do
        before do
          create_pipeline(:success)
        end

        it 'is mergeable' do
1635
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1636 1637 1638 1639 1640 1641 1642 1643 1644
        end
      end

      context 'with failing pipeline'  do
        before do
          create_pipeline(:failed)
        end

        it 'is not mergeable' do
1645
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1646 1647 1648 1649 1650
        end
      end

      context 'with running pipeline'  do
        before do
F
Felipe Artur 已提交
1651
          create_pipeline(:running)
1652 1653 1654
        end

        it 'is mergeable' do
1655
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1656 1657 1658 1659 1660
        end
      end
    end
  end

1661 1662
  describe '#has_commits?' do
    before do
1663 1664
      allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(2)
1665 1666 1667 1668 1669 1670 1671 1672 1673
    end

    it 'returns true when merge request diff has commits' do
      expect(subject.has_commits?).to be_truthy
    end
  end

  describe '#has_no_commits?' do
    before do
1674 1675
      allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(0)
1676 1677 1678 1679 1680 1681
    end

    it 'returns true when merge request diff has 0 commits' do
      expect(subject.has_no_commits?).to be_truthy
    end
  end
1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700

  describe '#merge_request_diff_for' do
    subject { create(:merge_request, importing: true) }
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'with diff refs' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff1.diff_refs)).to eq(merge_request_diff1)
      end
    end

    context 'with a commit SHA' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff3.head_commit_sha)).to eq(merge_request_diff3)
      end
    end
  end
1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732

  describe '#version_params_for' do
    subject { create(:merge_request, importing: true) }
    let(:project) { subject.project }
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'when the diff refs are for an older merge request version' do
      let(:diff_refs) { merge_request_diff1.diff_refs }

      it 'returns the diff ID for the version to show' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff1.id)
      end
    end

    context 'when the diff refs are for a comparison between merge request versions' do
      let(:diff_refs) { merge_request_diff3.compare_with(merge_request_diff1.head_commit_sha).diff_refs }

      it 'returns the diff ID and start sha of the versions to compare' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff3.id, start_sha: merge_request_diff1.head_commit_sha)
      end
    end

    context 'when the diff refs are not for a merge request version' do
      let(:diff_refs) { project.commit(sample_commit.id).diff_refs }

      it 'returns nil' do
        expect(subject.version_params_for(diff_refs)).to be_nil
      end
    end
  end
1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768

  describe '#fetch_ref' do
    it 'sets "ref_fetched" flag to true' do
      subject.update!(ref_fetched: nil)

      subject.fetch_ref

      expect(subject.reload.ref_fetched).to be_truthy
    end
  end

  describe '#ref_fetched?' do
    it 'does not perform git operation when value is cached' do
      subject.ref_fetched = true

      expect_any_instance_of(Repository).not_to receive(:ref_exists?)
      expect(subject.ref_fetched?).to be_truthy
    end

    it 'caches the value when ref exists but value is not cached' do
      subject.update!(ref_fetched: nil)
      allow_any_instance_of(Repository).to receive(:ref_exists?)
        .and_return(true)

      expect(subject.ref_fetched?).to be_truthy
      expect(subject.reload.ref_fetched).to be_truthy
    end

    it 'returns false when ref does not exist' do
      subject.update!(ref_fetched: nil)
      allow_any_instance_of(Repository).to receive(:ref_exists?)
        .and_return(false)

      expect(subject.ref_fetched?).to be_falsey
    end
  end
1769 1770 1771 1772 1773 1774 1775 1776 1777

  describe 'removing a merge request' do
    it 'refreshes the number of open merge requests of the target project' do
      project = subject.target_project

      expect { subject.destroy }
        .to change { project.open_merge_requests_count }.from(1).to(0)
    end
  end
1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789

  describe '#update_project_counter_caches?' do
    it 'returns true when the state changes' do
      subject.state = 'closed'

      expect(subject.update_project_counter_caches?).to eq(true)
    end

    it 'returns false when the state did not change' do
      expect(subject.update_project_counter_caches?).to eq(false)
    end
  end
D
Dmitriy Zaporozhets 已提交
1790
end