merge_request_spec.rb 59.2 KB
Newer Older
D
Dmitriy Zaporozhets 已提交
1 2
require 'spec_helper'

3
describe MergeRequest do
4
  include RepoHelpers
B
Bob Van Landuyt 已提交
5
  include ProjectForksHelper
6

7 8
  subject { create(:merge_request) }

R
Robert Speicher 已提交
9
  describe 'associations' do
10 11
    it { is_expected.to belong_to(:target_project).class_name('Project') }
    it { is_expected.to belong_to(:source_project).class_name('Project') }
12
    it { is_expected.to belong_to(:merge_user).class_name("User") }
13
    it { is_expected.to belong_to(:assignee) }
14
    it { is_expected.to have_many(:merge_request_diffs) }
R
Robert Speicher 已提交
15 16
  end

17 18 19 20 21 22 23 24 25 26
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(InternalId) }
    it { is_expected.to include_module(Issuable) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(Taskable) }
  end

Z
Zeger-Jan van de Weg 已提交
27 28 29 30 31
  describe "act_as_paranoid" do
    it { is_expected.to have_db_column(:deleted_at) }
    it { is_expected.to have_db_index(:deleted_at) }
  end

32
  describe 'validation' do
33 34
    it { is_expected.to validate_presence_of(:target_branch) }
    it { is_expected.to validate_presence_of(:source_branch) }
Z
Zeger-Jan van de Weg 已提交
35

36
    context "Validation of merge user with Merge When Pipeline Succeeds" do
Z
Zeger-Jan van de Weg 已提交
37 38 39 40 41
      it "allows user to be nil when the feature is disabled" do
        expect(subject).to be_valid
      end

      it "is invalid without merge user" do
J
James Lopez 已提交
42
        subject.merge_when_pipeline_succeeds = true
Z
Zeger-Jan van de Weg 已提交
43 44 45 46
        expect(subject).not_to be_valid
      end

      it "is valid with merge user" do
J
James Lopez 已提交
47
        subject.merge_when_pipeline_succeeds = true
Z
Zeger-Jan van de Weg 已提交
48 49 50 51 52
        subject.merge_user = build(:user)

        expect(subject).to be_valid
      end
    end
53 54 55

    context 'for forks' do
      let(:project) { create(:project) }
B
Bob Van Landuyt 已提交
56 57
      let(:fork1) { fork_project(project) }
      let(:fork2) { fork_project(project) }
58 59 60 61 62 63 64 65

      it 'allows merge requests for sibling-forks' do
        subject.source_project = fork1
        subject.target_project = fork2

        expect(subject).to be_valid
      end
    end
D
Dmitriy Zaporozhets 已提交
66 67
  end

R
Robert Speicher 已提交
68
  describe 'respond to' do
69 70 71
    it { is_expected.to respond_to(:unchecked?) }
    it { is_expected.to respond_to(:can_be_merged?) }
    it { is_expected.to respond_to(:cannot_be_merged?) }
72
    it { is_expected.to respond_to(:merge_params) }
J
James Lopez 已提交
73
    it { is_expected.to respond_to(:merge_when_pipeline_succeeds) }
74
  end
A
Andrey Kumanyaev 已提交
75

76 77 78 79 80 81
  describe '.in_projects' do
    it 'returns the merge requests for a set of projects' do
      expect(described_class.in_projects(Project.all)).to eq([subject])
    end
  end

82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118
  describe '.set_latest_merge_request_diff_ids!' do
    def create_merge_request_with_diffs(source_branch, diffs: 2)
      params = {
        target_project: project,
        target_branch: 'master',
        source_project: project,
        source_branch: source_branch
      }

      create(:merge_request, params).tap do |mr|
        diffs.times { mr.merge_request_diffs.create }
      end
    end

    let(:project) { create(:project) }

    it 'sets IDs for merge requests, whether they are already set or not' do
      merge_requests = [
        create_merge_request_with_diffs('feature'),
        create_merge_request_with_diffs('feature-conflict'),
        create_merge_request_with_diffs('wip', diffs: 0),
        create_merge_request_with_diffs('csv')
      ]

      merge_requests.take(2).each do |merge_request|
        merge_request.update_column(:latest_merge_request_diff_id, nil)
      end

      expected = merge_requests.map do |merge_request|
        merge_request.merge_request_diffs.maximum(:id)
      end

      expect { project.merge_requests.set_latest_merge_request_diff_ids! }
        .to change { merge_requests.map { |mr| mr.reload.latest_merge_request_diff_id } }.to(expected)
    end
  end

119
  describe '#target_branch_sha' do
120
    let(:project) { create(:project, :repository) }
121

122
    subject { create(:merge_request, source_project: project, target_project: project) }
123

124
    context 'when the target branch does not exist' do
125
      before do
126
        project.repository.rm_branch(subject.author, subject.target_branch)
127
      end
128 129

      it 'returns nil' do
130
        expect(subject.target_branch_sha).to be_nil
131 132
      end
    end
133 134 135 136 137 138

    it 'returns memoized value' do
      subject.target_branch_sha = '8ffb3c15a5475e59ae909384297fede4badcb4c7'

      expect(subject.target_branch_sha).to eq '8ffb3c15a5475e59ae909384297fede4badcb4c7'
    end
139 140
  end

141 142 143 144 145
  describe '#card_attributes' do
    it 'includes the author name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignee).and_return(nil)

146 147
      expect(subject.card_attributes)
        .to eq({ 'Author' => 'Robert', 'Assignee' => nil })
148 149 150 151 152 153
    end

    it 'includes the assignee name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignee).and_return(double(name: 'Douwe'))

154 155
      expect(subject.card_attributes)
        .to eq({ 'Author' => 'Robert', 'Assignee' => 'Douwe' })
156 157 158
    end
  end

159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174
  describe '#assignee_ids' do
    it 'returns an array of the assigned user id' do
      subject.assignee_id = 123

      expect(subject.assignee_ids).to eq([123])
    end
  end

  describe '#assignee_ids=' do
    it 'sets assignee_id to the last id in the array' do
      subject.assignee_ids = [123, 456]

      expect(subject.assignee_id).to eq(456)
    end
  end

175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194
  describe '#assignee_or_author?' do
    let(:user) { create(:user) }

    it 'returns true for a user that is assigned to a merge request' do
      subject.assignee = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns true for a user that is the author of a merge request' do
      subject.author = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns false for a user that is not the assignee or author' do
      expect(subject.assignee_or_author?(user)).to eq(false)
    end
  end

195 196 197 198 199 200 201 202 203 204 205
  describe '#cache_merge_request_closes_issues!' do
    before do
      subject.project.team << [subject.author, :developer]
      subject.target_branch = subject.project.default_branch
    end

    it 'caches closed issues' do
      issue  = create :issue, project: subject.project
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])

206
      expect { subject.cache_merge_request_closes_issues!(subject.author) }.to change(subject.merge_requests_closing_issues, :count).by(1)
207 208
    end

209 210 211 212
    context 'when both internal and external issue trackers are enabled' do
      before do
        subject.project.has_external_issue_tracker = true
        subject.project.save!
213
        create(:jira_service, project: subject.project)
214 215 216 217 218 219
      end

      it 'does not cache issues from external trackers' do
        issue  = ExternalIssue.new('JIRA-123', subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])
220

221
        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to raise_error
222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257
        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
      end

      it 'caches an internal issue' do
        issue  = create(:issue, project: subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }
          .to change(subject.merge_requests_closing_issues, :count).by(1)
      end
    end

    context 'when only external issue tracker enabled' do
      before do
        subject.project.has_external_issue_tracker = true
        subject.project.issues_enabled = false
        subject.project.save!
      end

      it 'does not cache issues from external trackers' do
        issue  = ExternalIssue.new('JIRA-123', subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
      end

      it 'does not cache an internal issue' do
        issue  = create(:issue, project: subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }
          .not_to change(subject.merge_requests_closing_issues, :count)
      end
258 259 260
    end
  end

261
  describe '#source_branch_sha' do
262
    let(:last_branch_commit) { subject.source_project.repository.commit(Gitlab::Git::BRANCH_REF_PREFIX + subject.source_branch) }
263 264 265 266

    context 'with diffs' do
      subject { create(:merge_request, :with_diffs) }
      it 'returns the sha of the source branch last commit' do
267
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
268 269 270
      end
    end

271 272 273
    context 'without diffs' do
      subject { create(:merge_request, :without_diffs) }
      it 'returns the sha of the source branch last commit' do
274
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
275
      end
276 277 278 279 280 281 282 283 284 285 286 287 288 289 290

      context 'when there is a tag name matching the branch name' do
        let(:tag_name) { subject.source_branch }

        it 'returns the sha of the source branch last commit' do
          subject.source_project.repository.add_tag(subject.author,
                                                    tag_name,
                                                    subject.target_branch_sha,
                                                    'Add a tag')

          expect(subject.source_branch_sha).to eq(last_branch_commit.sha)

          subject.source_project.repository.rm_tag(subject.author, tag_name)
        end
      end
291 292
    end

293 294 295
    context 'when the merge request is being created' do
      subject { build(:merge_request, source_branch: nil, compare_commits: []) }
      it 'returns nil' do
296
        expect(subject.source_branch_sha).to be_nil
297 298
      end
    end
299 300 301 302 303 304

    it 'returns memoized value' do
      subject.source_branch_sha = '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'

      expect(subject.source_branch_sha).to eq '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
    end
305 306
  end

307
  describe '#to_reference' do
308
    let(:project) { build(:project, name: 'sample-project') }
309 310
    let(:merge_request) { build(:merge_request, target_project: project, iid: 1) }

311
    it 'returns a String reference to the object' do
312
      expect(merge_request.to_reference).to eq "!1"
313 314 315
    end

    it 'supports a cross-project reference' do
316
      another_project = build(:project, name: 'another-project', namespace: project.namespace)
317
      expect(merge_request.to_reference(another_project)).to eq "sample-project!1"
318
    end
319 320

    it 'returns a String reference with the full path' do
321
      expect(merge_request.to_reference(full: true)).to eq(project.full_path + '!1')
322
    end
323
  end
324

325
  describe '#raw_diffs' do
S
Sean McGivern 已提交
326 327 328 329 330 331 332
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
        merge_request.merge_request_diff = MergeRequestDiff.new

333
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(options)
S
Sean McGivern 已提交
334

335 336 337 338 339 340 341 342 343 344 345 346 347 348 349
        merge_request.raw_diffs(options)
      end
    end

    context 'when there are no MR diffs' do
      it 'delegates to the compare object' do
        merge_request.compare = double(:compare)

        expect(merge_request.compare).to receive(:raw_diffs).with(options)

        merge_request.raw_diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
350 351 352 353 354 355
  describe '#diffs' do
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
356
        merge_request.save
S
Sean McGivern 已提交
357

358
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(hash_including(options))
S
Sean McGivern 已提交
359 360 361 362 363 364

        merge_request.diffs(options)
      end
    end

    context 'when there are no MR diffs' do
365
      it 'delegates to the compare object, setting expanded: true' do
S
Sean McGivern 已提交
366 367
        merge_request.compare = double(:compare)

368
        expect(merge_request.compare).to receive(:diffs).with(options.merge(expanded: true))
S
Sean McGivern 已提交
369 370 371 372 373 374

        merge_request.diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
375 376 377 378 379 380
  describe '#diff_size' do
    let(:merge_request) do
      build(:merge_request, source_branch: 'expand-collapse-files', target_branch: 'master')
    end

    context 'when there are MR diffs' do
381
      it 'returns the correct count' do
S
Sean McGivern 已提交
382
        merge_request.save
383 384

        expect(merge_request.diff_size).to eq('105')
S
Sean McGivern 已提交
385 386
      end

387 388 389 390 391
      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        merge_request.save

        expect(merge_request.diff_size).to eq('2+')
S
Sean McGivern 已提交
392 393 394
      end

      it 'does not perform highlighting' do
395 396
        merge_request.save

S
Sean McGivern 已提交
397 398 399 400 401 402 403
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end

    context 'when there are no MR diffs' do
404
      def set_compare(merge_request)
S
Sean McGivern 已提交
405 406 407 408 409 410 411 412 413 414
        merge_request.compare = CompareService.new(
          merge_request.source_project,
          merge_request.source_branch
        ).execute(
          merge_request.target_project,
          merge_request.target_branch
        )
      end

      it 'returns the correct count' do
415 416 417 418 419 420 421 422 423 424
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('105')
      end

      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('2+')
S
Sean McGivern 已提交
425 426 427
      end

      it 'does not perform highlighting' do
428 429
        set_compare(merge_request)

S
Sean McGivern 已提交
430 431 432 433 434 435 436
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end
  end

437
  describe "#related_notes" do
438
    let!(:merge_request) { create(:merge_request) }
439 440

    before do
441
      allow(merge_request).to receive(:commits) { [merge_request.source_project.repository.commit] }
442 443
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.project)
D
Dmitriy Zaporozhets 已提交
444
      create(:note, noteable: merge_request, project: merge_request.project)
445 446
    end

447
    it "includes notes for commits" do
448
      expect(merge_request.commits).not_to be_empty
449
      expect(merge_request.related_notes.count).to eq(2)
450
    end
451

452
    it "includes notes for commits from target project as well" do
453 454 455
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.target_project)

456
      expect(merge_request.commits).not_to be_empty
457
      expect(merge_request.related_notes.count).to eq(3)
458
    end
459
  end
460

I
Izaak Alpert 已提交
461 462
  describe '#for_fork?' do
    it 'returns true if the merge request is for a fork' do
463 464
      subject.source_project = build_stubbed(:project, namespace: create(:group))
      subject.target_project = build_stubbed(:project, namespace: create(:group))
I
Izaak Alpert 已提交
465

466
      expect(subject.for_fork?).to be_truthy
I
Izaak Alpert 已提交
467
    end
D
Dmitriy Zaporozhets 已提交
468

I
Izaak Alpert 已提交
469
    it 'returns false if is not for a fork' do
470
      expect(subject.for_fork?).to be_falsey
I
Izaak Alpert 已提交
471 472 473
    end
  end

474
  describe '#closes_issues' do
475 476
    let(:issue0) { create :issue, project: subject.project }
    let(:issue1) { create :issue, project: subject.project }
477 478 479 480

    let(:commit0) { double('commit0', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit1) { double('commit1', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit2) { double('commit2', safe_message: "Fixes #{issue1.to_reference}") }
481 482

    before do
483
      subject.project.team << [subject.author, :developer]
484
      allow(subject).to receive(:commits).and_return([commit0, commit1, commit2])
485 486
    end

487
    it 'accesses the set of issues that will be closed on acceptance' do
488 489
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
490

491
      closed = subject.closes_issues
492

493 494
      expect(closed).to include(issue0, issue1)
    end
495

496 497 498
    it 'only lists issues as to be closed if it targets the default branch' do
      allow(subject.project).to receive(:default_branch).and_return('master')
      subject.target_branch = 'something-else'
499

500
      expect(subject.closes_issues).to be_empty
501
    end
502
  end
503

504
  describe '#issues_mentioned_but_not_closing' do
505 506 507 508
    let(:closing_issue) { create :issue, project: subject.project }
    let(:mentioned_issue) { create :issue, project: subject.project }

    let(:commit) { double('commit', safe_message: "Fixes #{closing_issue.to_reference}") }
509

510
    it 'detects issues mentioned in description but not closed' do
511
      subject.project.team << [subject.author, :developer]
512
      subject.description = "Is related to #{mentioned_issue.to_reference} and #{closing_issue.to_reference}"
513

514
      allow(subject).to receive(:commits).and_return([commit])
515 516
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
517

518
      expect(subject.issues_mentioned_but_not_closing(subject.author)).to match_array([mentioned_issue])
519
    end
520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536

    context 'when the project has an external issue tracker' do
      before do
        subject.project.team << [subject.author, :developer]
        commit = double(:commit, safe_message: 'Fixes TEST-3')

        create(:jira_service, project: subject.project)

        allow(subject).to receive(:commits).and_return([commit])
        allow(subject).to receive(:description).and_return('Is related to TEST-2 and TEST-3')
        allow(subject.project).to receive(:default_branch).and_return(subject.target_branch)
      end

      it 'detects issues mentioned in description but not closed' do
        expect(subject.issues_mentioned_but_not_closing(subject.author).map(&:to_s)).to match_array(['TEST-2'])
      end
    end
537 538
  end

539
  describe "#work_in_progress?" do
540 541 542
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "detects the '#{wip_prefix}' prefix" do
        subject.title = "#{wip_prefix}#{subject.title}"
543
        expect(subject.work_in_progress?).to eq true
544
      end
T
Ted Hogan 已提交
545 546
    end

547 548
    it "doesn't detect WIP for words starting with WIP" do
      subject.title = "Wipwap #{subject.title}"
549
      expect(subject.work_in_progress?).to eq false
550 551
    end

552 553
    it "doesn't detect WIP for words containing with WIP" do
      subject.title = "WupWipwap #{subject.title}"
554
      expect(subject.work_in_progress?).to eq false
555 556
    end

557
    it "doesn't detect WIP by default" do
558
      expect(subject.work_in_progress?).to eq false
559 560 561
    end
  end

T
Thomas Balthazar 已提交
562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584
  describe "#wipless_title" do
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "removes the '#{wip_prefix}' prefix" do
        wipless_title = subject.title
        subject.title = "#{wip_prefix}#{subject.title}"

        expect(subject.wipless_title).to eq wipless_title
      end

      it "is satisfies the #work_in_progress? method" do
        subject.title = "#{wip_prefix}#{subject.title}"
        subject.title = subject.wipless_title

        expect(subject.work_in_progress?).to eq false
      end
    end
  end

  describe "#wip_title" do
    it "adds the WIP: prefix to the title" do
      wip_title = "WIP: #{subject.title}"

      expect(subject.wip_title).to eq wip_title
585
    end
T
Thomas Balthazar 已提交
586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601

    it "does not add the WIP: prefix multiple times" do
      wip_title = "WIP: #{subject.title}"
      subject.title = subject.wip_title
      subject.title = subject.wip_title

      expect(subject.wip_title).to eq wip_title
    end

    it "is satisfies the #work_in_progress? method" do
      subject.title = subject.wip_title

      expect(subject.work_in_progress?).to eq true
    end
  end

Z
Zeger-Jan van de Weg 已提交
602
  describe '#can_remove_source_branch?' do
Z
Zeger-Jan van de Weg 已提交
603 604
    let(:user) { create(:user) }
    let(:user2) { create(:user) }
605 606 607 608

    before do
      subject.source_project.team << [user, :master]

Z
Zeger-Jan van de Weg 已提交
609 610 611 612
      subject.source_branch = "feature"
      subject.target_branch = "master"
      subject.save!
    end
613

Z
Zeger-Jan van de Weg 已提交
614
    it "can't be removed when its a protected branch" do
615
      allow(ProtectedBranch).to receive(:protected?).and_return(true)
616 617 618
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

619
    it "can't remove a root ref" do
Z
Zeger-Jan van de Weg 已提交
620 621
      subject.source_branch = "master"
      subject.target_branch = "feature"
622 623 624 625

      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

Z
Zeger-Jan van de Weg 已提交
626 627 628 629
    it "is unable to remove the source branch for a project the user cannot push to" do
      expect(subject.can_remove_source_branch?(user2)).to be_falsey
    end

630
    it "can be removed if the last commit is the head of the source branch" do
631
      allow(subject).to receive(:source_branch_head).and_return(subject.diff_head_commit)
632

Z
Zeger-Jan van de Weg 已提交
633
      expect(subject.can_remove_source_branch?(user)).to be_truthy
634
    end
635 636

    it "cannot be removed if the last commit is not also the head of the source branch" do
637 638
      subject.source_branch = "lfs"

639 640
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end
641 642
  end

643 644 645 646 647 648 649 650 651 652 653 654 655 656 657
  describe '#merge_commit_message' do
    it 'includes merge information as the title' do
      request = build(:merge_request, source_branch: 'source', target_branch: 'target')

      expect(request.merge_commit_message)
        .to match("Merge branch 'source' into 'target'\n\n")
    end

    it 'includes its title in the body' do
      request = build(:merge_request, title: 'Remove all technical debt')

      expect(request.merge_commit_message)
        .to match("Remove all technical debt\n\n")
    end

658
    it 'includes its closed issues in the body' do
659
      issue = create(:issue, project: subject.project)
660

661
      subject.project.team << [subject.author, :developer]
662
      subject.description = "This issue Closes #{issue.to_reference}"
663

664 665
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
666 667

      expect(subject.merge_commit_message)
668
        .to match("Closes #{issue.to_reference}")
669 670 671 672 673 674
    end

    it 'includes its reference in the body' do
      request = build_stubbed(:merge_request)

      expect(request.merge_commit_message)
675
        .to match("See merge request #{request.to_reference(full: true)}")
676 677 678 679 680 681 682
    end

    it 'excludes multiple linebreak runs when description is blank' do
      request = build(:merge_request, title: 'Title', description: nil)

      expect(request.merge_commit_message).not_to match("Title\n\n\n\n")
    end
683 684 685 686 687 688 689 690 691 692 693 694 695 696

    it 'includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message(include_description: true))
        .to match("By removing all code\n\n")
    end

    it 'does not includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message)
        .not_to match("By removing all code\n\n")
    end
697 698
  end

J
James Lopez 已提交
699
  describe "#reset_merge_when_pipeline_succeeds" do
700
    let(:merge_if_green) do
J
James Lopez 已提交
701
      create :merge_request, merge_when_pipeline_succeeds: true, merge_user: create(:user),
702 703
                             merge_params: { "should_remove_source_branch" => "1", "commit_message" => "msg" }
    end
Z
Zeger-Jan van de Weg 已提交
704

705
    it "sets the item to false" do
J
James Lopez 已提交
706
      merge_if_green.reset_merge_when_pipeline_succeeds
707 708
      merge_if_green.reload

J
James Lopez 已提交
709
      expect(merge_if_green.merge_when_pipeline_succeeds).to be_falsey
710 711
      expect(merge_if_green.merge_params["should_remove_source_branch"]).to be_nil
      expect(merge_if_green.merge_params["commit_message"]).to be_nil
712 713 714
    end
  end

715
  describe '#hook_attrs' do
716 717 718 719 720 721 722 723
    it 'delegates to Gitlab::HookData::MergeRequestBuilder#build' do
      builder = double

      expect(Gitlab::HookData::MergeRequestBuilder)
        .to receive(:new).with(subject).and_return(builder)
      expect(builder).to receive(:build)

      subject.hook_attrs
724
    end
725 726 727
  end

  describe '#diverged_commits_count' do
728
    let(:project)      { create(:project, :repository) }
B
Bob Van Landuyt 已提交
729
    let(:forked_project) { fork_project(project, nil, repository: true) }
730

731
    context 'when the target branch does not exist anymore' do
732 733 734 735 736 737
      subject { create(:merge_request, source_project: project, target_project: project) }

      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
        subject.reload
      end
738 739

      it 'does not crash' do
740
        expect { subject.diverged_commits_count }.not_to raise_error
741 742 743 744 745 746 747
      end

      it 'returns 0' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

748 749 750 751
    context 'diverged on same repository' do
      subject(:merge_request_with_divergence) { create(:merge_request, :diverged, source_project: project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
752
        expect(subject.diverged_commits_count).to eq(29)
753 754 755 756
      end
    end

    context 'diverged on fork' do
B
Bob Van Landuyt 已提交
757
      subject(:merge_request_fork_with_divergence) { create(:merge_request, :diverged, source_project: forked_project, target_project: project) }
758 759

      it 'counts commits that are on target branch but not on source branch' do
760
        expect(subject.diverged_commits_count).to eq(29)
761 762 763 764
      end
    end

    context 'rebased on fork' do
B
Bob Van Landuyt 已提交
765
      subject(:merge_request_rebased) { create(:merge_request, :rebased, source_project: forked_project, target_project: project) }
766 767 768 769 770 771 772

      it 'counts commits that are on target branch but not on source branch' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

    describe 'caching' do
773
      before do
774 775 776 777
        allow(Rails).to receive(:cache).and_return(ActiveSupport::Cache::MemoryStore.new)
      end

      it 'caches the output' do
778 779 780
        expect(subject).to receive(:compute_diverged_commits_count)
          .once
          .and_return(2)
781 782 783 784 785 786

        subject.diverged_commits_count
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the source sha changes' do
787 788 789
        expect(subject).to receive(:compute_diverged_commits_count)
          .twice
          .and_return(2)
790 791

        subject.diverged_commits_count
792
        allow(subject).to receive(:source_branch_sha).and_return('123abc')
793 794 795 796
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the target sha changes' do
797 798 799
        expect(subject).to receive(:compute_diverged_commits_count)
          .twice
          .and_return(2)
800 801

        subject.diverged_commits_count
802
        allow(subject).to receive(:target_branch_sha).and_return('123abc')
803 804 805
        subject.diverged_commits_count
      end
    end
806 807
  end

808
  it_behaves_like 'an editable mentionable' do
809
    subject { create(:merge_request, :simple) }
810

811
    let(:backref_text) { "merge request #{subject.to_reference}" }
812
    let(:set_mentionable_text) { ->(txt) { subject.description = txt } }
813
  end
V
Vinnie Okada 已提交
814 815

  it_behaves_like 'a Taskable' do
816
    subject { create :merge_request, :simple }
V
Vinnie Okada 已提交
817
  end
818

819
  describe '#commit_shas' do
820
    before do
821
      allow(subject.merge_request_diff).to receive(:commit_shas)
822
        .and_return(['sha1'])
823 824
    end

825
    it 'delegates to merge request diff' do
826
      expect(subject.commit_shas).to eq ['sha1']
827 828 829
    end
  end

830
  context 'head pipeline' do
831 832 833
    before do
      allow(subject).to receive(:diff_head_sha).and_return('lastsha')
    end
834

835 836 837
    describe '#head_pipeline' do
      it 'returns nil for MR without head_pipeline_id' do
        subject.update_attribute(:head_pipeline_id, nil)
838

839 840
        expect(subject.head_pipeline).to be_nil
      end
841 842 843 844 845 846 847 848

      context 'when the source project does not exist' do
        it 'returns nil' do
          allow(subject).to receive(:source_project).and_return(nil)

          expect(subject.head_pipeline).to be_nil
        end
      end
849 850
    end

851
    describe '#actual_head_pipeline' do
852 853 854
      it 'returns nil for MR with old pipeline' do
        pipeline = create(:ci_empty_pipeline, sha: 'notlatestsha')
        subject.update_attribute(:head_pipeline_id, pipeline.id)
855

856
        expect(subject.actual_head_pipeline).to be_nil
857
      end
858

859 860 861
      it 'returns the pipeline for MR with recent pipeline' do
        pipeline = create(:ci_empty_pipeline, sha: 'lastsha')
        subject.update_attribute(:head_pipeline_id, pipeline.id)
862

863 864
        expect(subject.actual_head_pipeline).to eq(subject.head_pipeline)
        expect(subject.actual_head_pipeline).to eq(pipeline)
865
      end
866 867 868 869 870 871

      it 'returns nil when source project does not exist' do
        allow(subject).to receive(:source_project).and_return(nil)

        expect(subject.actual_head_pipeline).to be_nil
      end
872 873
    end
  end
Y
Yorick Peterse 已提交
874

875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917
  describe '#has_ci?' do
    let(:merge_request) { build_stubbed(:merge_request) }

    context 'has ci' do
      it 'returns true if MR has head_pipeline_id and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { double }
        allow(merge_request).to receive(:has_no_commits?) { false }

        expect(merge_request.has_ci?).to be(true)
      end

      it 'returns true if MR has any pipeline and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:has_no_commits?) { false }
        allow(merge_request).to receive(:all_pipelines) { [double] }

        expect(merge_request.has_ci?).to be(true)
      end

      it 'returns true if MR has CI service and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { double }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:has_no_commits?) { false }
        allow(merge_request).to receive(:all_pipelines) { [] }

        expect(merge_request.has_ci?).to be(true)
      end
    end

    context 'has no ci' do
      it 'returns false if MR has no CI service nor pipeline, and no commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:all_pipelines) { [] }
        allow(merge_request).to receive(:has_no_commits?) { true }

        expect(merge_request.has_ci?).to be(false)
      end
    end
  end

918
  describe '#all_pipelines' do
919
    shared_examples 'returning pipelines with proper ordering' do
920
      let!(:all_pipelines) do
921
        subject.all_commit_shas.map do |sha|
922 923 924 925
          create(:ci_empty_pipeline,
                 project: subject.source_project,
                 sha: sha,
                 ref: subject.source_branch)
926 927 928 929 930
        end
      end

      it 'returns all pipelines' do
        expect(subject.all_pipelines).not_to be_empty
931
        expect(subject.all_pipelines).to eq(all_pipelines.reverse)
932
      end
933 934
    end

935 936 937 938 939 940
    context 'with single merge_request_diffs' do
      it_behaves_like 'returning pipelines with proper ordering'
    end

    context 'with multiple irrelevant merge_request_diffs' do
      before do
941
        subject.update(target_branch: 'v1.0.0')
942 943 944
      end

      it_behaves_like 'returning pipelines with proper ordering'
945
    end
946 947

    context 'with unsaved merge request' do
948
      subject { build(:merge_request) }
949 950 951

      let!(:pipeline) do
        create(:ci_empty_pipeline,
952
               project: subject.project,
953 954
               sha: subject.diff_head_sha,
               ref: subject.source_branch)
955
      end
956 957 958 959 960

      it 'returns pipelines from diff_head_sha' do
        expect(subject.all_pipelines).to contain_exactly(pipeline)
      end
    end
961 962
  end

963
  describe '#all_commit_shas' do
964
    context 'when merge request is persisted' do
965
      let(:all_commit_shas) do
966 967
        subject.merge_request_diffs.flat_map(&:commits).map(&:sha).uniq
      end
968

969
      shared_examples 'returning all SHA' do
970
        it 'returns all SHAs from all merge_request_diffs' do
971
          expect(subject.merge_request_diffs.size).to eq(2)
972
          expect(subject.all_commit_shas).to match_array(all_commit_shas)
973
        end
974 975
      end

976 977
      context 'with a completely different branch' do
        before do
978
          subject.update(target_branch: 'csv')
979 980 981
        end

        it_behaves_like 'returning all SHA'
982 983
      end

984 985
      context 'with a branch having no difference' do
        before do
986
          subject.update(target_branch: 'branch-merged')
987 988 989 990 991
          subject.reload # make sure commits were not cached
        end

        it_behaves_like 'returning all SHA'
      end
992 993
    end

994 995 996 997 998 999 1000 1001 1002
    context 'when merge request is not persisted' do
      context 'when compare commits are set in the service' do
        let(:commit) { spy('commit') }

        subject do
          build(:merge_request, compare_commits: [commit, commit])
        end

        it 'returns commits from compare commits temporary data' do
1003
          expect(subject.all_commit_shas).to eq [commit, commit]
1004
        end
1005 1006
      end

1007 1008 1009 1010
      context 'when compare commits are not set in the service' do
        subject { build(:merge_request) }

        it 'returns array with diff head sha element only' do
1011
          expect(subject.all_commit_shas).to eq [subject.diff_head_sha]
1012 1013
        end
      end
1014 1015 1016
    end
  end

Y
Yorick Peterse 已提交
1017
  describe '#participants' do
1018
    let(:project) { create(:project, :public) }
Y
Yorick Peterse 已提交
1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039

    let(:mr) do
      create(:merge_request, source_project: project, target_project: project)
    end

    let!(:note1) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'a')
    end

    let!(:note2) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'b')
    end

    it 'includes the merge request author' do
      expect(mr.participants).to include(mr.author)
    end

    it 'includes the authors of the notes' do
      expect(mr.participants).to include(note1.author, note2.author)
    end
  end
J
Josh Frye 已提交
1040 1041 1042 1043 1044 1045

  describe 'cached counts' do
    it 'updates when assignees change' do
      user1 = create(:user)
      user2 = create(:user)
      mr = create(:merge_request, assignee: user1)
1046 1047
      mr.project.add_developer(user1)
      mr.project.add_developer(user2)
J
Josh Frye 已提交
1048

1049 1050
      expect(user1.assigned_open_merge_requests_count).to eq(1)
      expect(user2.assigned_open_merge_requests_count).to eq(0)
J
Josh Frye 已提交
1051 1052 1053 1054

      mr.assignee = user2
      mr.save

1055 1056
      expect(user1.assigned_open_merge_requests_count).to eq(0)
      expect(user2.assigned_open_merge_requests_count).to eq(1)
J
Josh Frye 已提交
1057 1058
    end
  end
1059

1060
  describe '#merge_async' do
1061 1062 1063 1064 1065 1066 1067 1068 1069 1070
    it 'enqueues MergeWorker job and updates merge_jid' do
      merge_request = create(:merge_request)
      user_id = double(:user_id)
      params = double(:params)
      merge_jid = 'hash-123'

      expect(MergeWorker).to receive(:perform_async).with(merge_request.id, user_id, params) do
        merge_jid
      end

1071
      merge_request.merge_async(user_id, params)
1072 1073 1074 1075 1076

      expect(merge_request.reload.merge_jid).to eq(merge_jid)
    end
  end

1077
  describe '#check_if_can_be_merged' do
1078
    let(:project) { create(:project, only_allow_merge_if_pipeline_succeeds: true) }
1079 1080 1081 1082

    subject { create(:merge_request, source_project: project, merge_status: :unchecked) }

    context 'when it is not broken and has no conflicts' do
1083
      before do
1084
        allow(subject).to receive(:broken?) { false }
1085
        allow(project.repository).to receive(:can_be_merged?).and_return(true)
1086
      end
1087

1088
      it 'is marked as mergeable' do
1089 1090 1091 1092 1093
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('can_be_merged')
      end
    end

    context 'when broken' do
1094 1095 1096
      before do
        allow(subject).to receive(:broken?) { true }
      end
1097 1098 1099 1100 1101 1102 1103 1104 1105

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end

    context 'when it has conflicts' do
      before do
        allow(subject).to receive(:broken?) { false }
1106
        allow(project.repository).to receive(:can_be_merged?).and_return(false)
1107 1108 1109 1110 1111 1112 1113 1114 1115
      end

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end
  end

  describe '#mergeable?' do
1116
    let(:project) { create(:project) }
1117 1118 1119

    subject { create(:merge_request, source_project: project) }

1120 1121
    it 'returns false if #mergeable_state? is false' do
      expect(subject).to receive(:mergeable_state?) { false }
1122

1123
      expect(subject.mergeable?).to be_falsey
1124 1125
    end

1126
    it 'return true if #mergeable_state? is true and the MR #can_be_merged? is true' do
1127 1128
      allow(subject).to receive(:mergeable_state?) { true }
      expect(subject).to receive(:check_if_can_be_merged)
1129
      expect(subject).to receive(:can_be_merged?) { true }
1130 1131 1132 1133 1134 1135

      expect(subject.mergeable?).to be_truthy
    end
  end

  describe '#mergeable_state?' do
1136
    let(:project) { create(:project, :repository) }
1137 1138 1139

    subject { create(:merge_request, source_project: project) }

1140
    it 'checks if merge request can be merged' do
1141
      allow(subject).to receive(:mergeable_ci_state?) { true }
1142 1143 1144 1145 1146 1147
      expect(subject).to receive(:check_if_can_be_merged)

      subject.mergeable?
    end

    context 'when not open' do
1148 1149 1150
      before do
        subject.close
      end
1151 1152

      it 'returns false' do
1153
        expect(subject.mergeable_state?).to be_falsey
1154 1155 1156 1157
      end
    end

    context 'when working in progress' do
1158 1159 1160
      before do
        subject.title = 'WIP MR'
      end
1161 1162

      it 'returns false' do
1163
        expect(subject.mergeable_state?).to be_falsey
1164 1165 1166 1167
      end
    end

    context 'when broken' do
1168 1169 1170
      before do
        allow(subject).to receive(:broken?) { true }
      end
1171 1172

      it 'returns false' do
1173
        expect(subject.mergeable_state?).to be_falsey
1174 1175 1176 1177
      end
    end

    context 'when failed' do
R
Rémy Coutable 已提交
1178
      context 'when #mergeable_ci_state? is false' do
1179
        before do
1180
          allow(subject).to receive(:mergeable_ci_state?) { false }
1181 1182 1183 1184
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
1185 1186
        end
      end
1187

R
Rémy Coutable 已提交
1188
      context 'when #mergeable_discussions_state? is false' do
1189 1190 1191 1192 1193 1194 1195 1196
        before do
          allow(subject).to receive(:mergeable_discussions_state?) { false }
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
        end
      end
1197 1198 1199
    end
  end

1200
  describe '#mergeable_ci_state?' do
1201
    let(:project) { create(:project, only_allow_merge_if_pipeline_succeeds: true) }
R
Rémy Coutable 已提交
1202
    let(:pipeline) { create(:ci_empty_pipeline) }
1203 1204 1205

    subject { build(:merge_request, target_project: project) }

1206
    context 'when it is only allowed to merge when build is green' do
R
Rémy Coutable 已提交
1207
      context 'and a failed pipeline is associated' do
1208
        before do
1209
          pipeline.update(status: 'failed', sha: subject.diff_head_sha)
1210
          allow(subject).to receive(:head_pipeline) { pipeline }
1211
        end
1212

1213
        it { expect(subject.mergeable_ci_state?).to be_falsey }
1214 1215
      end

1216 1217
      context 'and a successful pipeline is associated' do
        before do
1218
          pipeline.update(status: 'success', sha: subject.diff_head_sha)
1219
          allow(subject).to receive(:head_pipeline) { pipeline }
1220 1221 1222 1223 1224 1225 1226
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

      context 'and a skipped pipeline is associated' do
        before do
1227
          pipeline.update(status: 'skipped', sha: subject.diff_head_sha)
1228
          allow(subject).to receive(:head_pipeline) { pipeline }
1229 1230 1231 1232 1233
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
1234
      context 'when no pipeline is associated' do
1235
        before do
1236
          allow(subject).to receive(:head_pipeline) { nil }
1237 1238 1239
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1240 1241 1242
      end
    end

1243
    context 'when merges are not restricted to green builds' do
1244
      subject { build(:merge_request, target_project: build(:project, only_allow_merge_if_pipeline_succeeds: false)) }
1245

R
Rémy Coutable 已提交
1246
      context 'and a failed pipeline is associated' do
1247
        before do
R
Rémy Coutable 已提交
1248
          pipeline.statuses << create(:commit_status, status: 'failed', project: project)
1249
          allow(subject).to receive(:head_pipeline) { pipeline }
1250 1251 1252 1253 1254
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
1255
      context 'when no pipeline is associated' do
1256
        before do
1257
          allow(subject).to receive(:head_pipeline) { nil }
1258 1259 1260
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1261 1262 1263
      end
    end
  end
1264

1265
  describe '#mergeable_discussions_state?' do
R
Rémy Coutable 已提交
1266
    let(:merge_request) { create(:merge_request_with_diff_notes, source_project: project) }
1267

R
Rémy Coutable 已提交
1268
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == true' do
1269
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: true) }
1270

R
Rémy Coutable 已提交
1271
      context 'with all discussions resolved' do
1272
        before do
R
Rémy Coutable 已提交
1273
          merge_request.discussions.each { |d| d.resolve!(merge_request.author) }
1274 1275 1276
        end

        it 'returns true' do
R
Rémy Coutable 已提交
1277
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1278 1279 1280
        end
      end

R
Rémy Coutable 已提交
1281
      context 'with unresolved discussions' do
1282
        before do
R
Rémy Coutable 已提交
1283
          merge_request.discussions.each(&:unresolve!)
1284 1285 1286
        end

        it 'returns false' do
R
Rémy Coutable 已提交
1287
          expect(merge_request.mergeable_discussions_state?).to be_falsey
1288 1289
        end
      end
1290 1291 1292 1293 1294 1295 1296 1297 1298 1299

      context 'with no discussions' do
        before do
          merge_request.notes.destroy_all
        end

        it 'returns true' do
          expect(merge_request.mergeable_discussions_state?).to be_truthy
        end
      end
1300 1301
    end

R
Rémy Coutable 已提交
1302
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == false' do
1303
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: false) }
1304

R
Rémy Coutable 已提交
1305
      context 'with unresolved discussions' do
1306
        before do
R
Rémy Coutable 已提交
1307
          merge_request.discussions.each(&:unresolve!)
1308 1309 1310
        end

        it 'returns true' do
R
Rémy Coutable 已提交
1311
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1312 1313 1314 1315 1316
        end
      end
    end
  end

D
Douwe Maan 已提交
1317
  describe "#environments_for" do
1318
    let(:project)       { create(:project, :repository) }
D
Douwe Maan 已提交
1319
    let(:user)          { project.creator }
Z
Z.J. van de Weg 已提交
1320 1321
    let(:merge_request) { create(:merge_request, source_project: project) }

D
Douwe Maan 已提交
1322 1323 1324 1325 1326
    before do
      merge_request.source_project.add_master(user)
      merge_request.target_project.add_master(user)
    end

1327 1328
    context 'with multiple environments' do
      let(:environments) { create_list(:environment, 3, project: project) }
1329

1330 1331 1332 1333 1334 1335
      before do
        create(:deployment, environment: environments.first, ref: 'master', sha: project.commit('master').id)
        create(:deployment, environment: environments.second, ref: 'feature', sha: project.commit('feature').id)
      end

      it 'selects deployed environments' do
D
Douwe Maan 已提交
1336
        expect(merge_request.environments_for(user)).to contain_exactly(environments.first)
1337 1338 1339 1340
      end
    end

    context 'with environments on source project' do
B
Bob Van Landuyt 已提交
1341
      let(:source_project) { fork_project(project, nil, repository: true) }
K
Kamil Trzcinski 已提交
1342

1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355
      let(:merge_request) do
        create(:merge_request,
               source_project: source_project, source_branch: 'feature',
               target_project: project)
      end

      let(:source_environment) { create(:environment, project: source_project) }

      before do
        create(:deployment, environment: source_environment, ref: 'feature', sha: merge_request.diff_head_sha)
      end

      it 'selects deployed environments' do
D
Douwe Maan 已提交
1356
        expect(merge_request.environments_for(user)).to contain_exactly(source_environment)
1357 1358 1359 1360 1361 1362 1363 1364 1365 1366
      end

      context 'with environments on target project' do
        let(:target_environment) { create(:environment, project: project) }

        before do
          create(:deployment, environment: target_environment, tag: true, sha: merge_request.diff_head_sha)
        end

        it 'selects deployed environments' do
D
Douwe Maan 已提交
1367
          expect(merge_request.environments_for(user)).to contain_exactly(source_environment, target_environment)
1368 1369
        end
      end
1370 1371 1372 1373 1374 1375 1376 1377
    end

    context 'without a diff_head_commit' do
      before do
        expect(merge_request).to receive(:diff_head_commit).and_return(nil)
      end

      it 'returns an empty array' do
D
Douwe Maan 已提交
1378
        expect(merge_request.environments_for(user)).to be_empty
1379
      end
Z
Z.J. van de Weg 已提交
1380 1381 1382
    end
  end

1383
  describe "#reload_diff" do
1384
    let(:discussion) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject).to_discussion }
1385 1386
    let(:commit) { subject.project.commit(sample_commit.id) }

1387
    it "does not change existing merge request diff" do
1388
      expect(subject.merge_request_diff).not_to receive(:save_git_content)
1389 1390 1391
      subject.reload_diff
    end

1392 1393 1394 1395
    it "creates new merge request diff" do
      expect { subject.reload_diff }.to change { subject.merge_request_diffs.count }.by(1)
    end

1396 1397 1398 1399 1400 1401
    it "executs diff cache service" do
      expect_any_instance_of(MergeRequests::MergeRequestDiffCacheService).to receive(:execute).with(subject)

      subject.reload_diff
    end

1402 1403 1404 1405 1406 1407
    it "calls update_diff_discussion_positions" do
      expect(subject).to receive(:update_diff_discussion_positions)

      subject.reload_diff
    end
  end
1408

1409 1410 1411 1412 1413 1414
  describe '#update_diff_discussion_positions' do
    let(:discussion) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject).to_discussion }
    let(:commit) { subject.project.commit(sample_commit.id) }
    let(:old_diff_refs) { subject.diff_refs }

    before do
1415
      # Update merge_request_diff so that #diff_refs will return commit.diff_refs
1416 1417 1418 1419 1420 1421
      allow(subject).to receive(:create_merge_request_diff) do
        subject.merge_request_diffs.create(
          base_commit_sha: commit.parent_id,
          start_commit_sha: commit.parent_id,
          head_commit_sha: commit.sha
        )
1422 1423

        subject.merge_request_diff(true)
1424
      end
1425
    end
1426

1427
    it "updates diff discussion positions" do
1428
      expect(Discussions::UpdateDiffPositionService).to receive(:new).with(
1429
        subject.project,
1430
        subject.author,
1431 1432
        old_diff_refs: old_diff_refs,
        new_diff_refs: commit.diff_refs,
1433
        paths: discussion.position.paths
1434 1435
      ).and_call_original

1436
      expect_any_instance_of(Discussions::UpdateDiffPositionService).to receive(:execute).with(discussion).and_call_original
1437 1438
      expect_any_instance_of(DiffNote).to receive(:save).once

1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458
      subject.update_diff_discussion_positions(old_diff_refs: old_diff_refs,
                                               new_diff_refs: commit.diff_refs,
                                               current_user: subject.author)
    end

    context 'when resolve_outdated_diff_discussions is set' do
      before do
        discussion

        subject.project.update!(resolve_outdated_diff_discussions: true)
      end

      it 'calls MergeRequests::ResolvedDiscussionNotificationService' do
        expect_any_instance_of(MergeRequests::ResolvedDiscussionNotificationService)
          .to receive(:execute).with(subject)

        subject.update_diff_discussion_positions(old_diff_refs: old_diff_refs,
                                                 new_diff_refs: commit.diff_refs,
                                                 current_user: subject.author)
      end
1459 1460
    end
  end
1461 1462 1463 1464 1465 1466 1467 1468 1469

  describe '#branch_merge_base_commit' do
    context 'source and target branch exist' do
      it { expect(subject.branch_merge_base_commit.sha).to eq('ae73cb07c9eeaf35924a10f713b364d32b2dd34f') }
      it { expect(subject.branch_merge_base_commit).to be_a(Commit) }
    end

    context 'when the target branch does not exist' do
      before do
1470
        subject.project.repository.rm_branch(subject.author, subject.target_branch)
1471 1472 1473 1474
      end

      it 'returns nil' do
        expect(subject.branch_merge_base_commit).to be_nil
1475 1476 1477 1478
      end
    end
  end

1479
  describe "#diff_refs" do
1480 1481 1482 1483 1484 1485 1486 1487
    context "with diffs" do
      subject { create(:merge_request, :with_diffs) }

      it "does not touch the repository" do
        subject # Instantiate the object

        expect_any_instance_of(Repository).not_to receive(:commit)

1488
        subject.diff_refs
1489 1490 1491 1492 1493 1494 1495 1496 1497
      end

      it "returns expected diff_refs" do
        expected_diff_refs = Gitlab::Diff::DiffRefs.new(
          base_sha:  subject.merge_request_diff.base_commit_sha,
          start_sha: subject.merge_request_diff.start_commit_sha,
          head_sha:  subject.merge_request_diff.head_commit_sha
        )

1498
        expect(subject.diff_refs).to eq(expected_diff_refs)
1499 1500 1501
      end
    end
  end
1502

1503
  describe "#source_project_missing?" do
1504
    let(:project)      { create(:project) }
B
Bob Van Landuyt 已提交
1505
    let(:forked_project) { fork_project(project) }
1506
    let(:user)         { create(:user) }
B
Bob Van Landuyt 已提交
1507
    let(:unlink_project) { Projects::UnlinkForkService.new(forked_project, user) }
1508

K
Katarzyna Kobierska 已提交
1509
    context "when the fork exists" do
1510 1511
      let(:merge_request) do
        create(:merge_request,
B
Bob Van Landuyt 已提交
1512
          source_project: forked_project,
1513 1514 1515
          target_project: project)
      end

1516
      it { expect(merge_request.source_project_missing?).to be_falsey }
1517 1518
    end

K
Katarzyna Kobierska 已提交
1519
    context "when the source project is the same as the target project" do
1520 1521
      let(:merge_request) { create(:merge_request, source_project: project) }

1522
      it { expect(merge_request.source_project_missing?).to be_falsey }
1523 1524
    end

K
Katarzyna Kobierska 已提交
1525
    context "when the fork does not exist" do
1526
      let!(:merge_request) do
1527
        create(:merge_request,
B
Bob Van Landuyt 已提交
1528
          source_project: forked_project,
1529 1530 1531
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1532
      it "returns true" do
1533 1534 1535
        unlink_project.execute
        merge_request.reload

1536
        expect(merge_request.source_project_missing?).to be_truthy
1537 1538 1539 1540
      end
    end
  end

1541
  describe '#merge_ongoing?' do
1542 1543 1544 1545 1546 1547
    it 'returns true when the merge request is locked' do
      merge_request = build_stubbed(:merge_request, state: :locked)

      expect(merge_request.merge_ongoing?).to be(true)
    end

1548
    it 'returns true when merge_id, MR is not merged and it has no running job' do
1549
      merge_request = build_stubbed(:merge_request, state: :open, merge_jid: 'foo')
1550
      allow(Gitlab::SidekiqStatus).to receive(:running?).with('foo') { true }
1551 1552 1553

      expect(merge_request.merge_ongoing?).to be(true)
    end
1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568

    it 'returns false when merge_jid is nil' do
      merge_request = build_stubbed(:merge_request, state: :open, merge_jid: nil)

      expect(merge_request.merge_ongoing?).to be(false)
    end

    it 'returns false if MR is merged' do
      merge_request = build_stubbed(:merge_request, state: :merged, merge_jid: 'foo')

      expect(merge_request.merge_ongoing?).to be(false)
    end

    it 'returns false if there is no merge job running' do
      merge_request = build_stubbed(:merge_request, state: :open, merge_jid: 'foo')
1569
      allow(Gitlab::SidekiqStatus).to receive(:running?).with('foo') { false }
1570 1571 1572

      expect(merge_request.merge_ongoing?).to be(false)
    end
1573 1574
  end

1575
  describe "#closed_without_fork?" do
1576
    let(:project)      { create(:project) }
B
Bob Van Landuyt 已提交
1577
    let(:forked_project) { fork_project(project) }
1578
    let(:user)         { create(:user) }
B
Bob Van Landuyt 已提交
1579
    let(:unlink_project) { Projects::UnlinkForkService.new(forked_project, user) }
1580

K
Katarzyna Kobierska 已提交
1581
    context "when the merge request is closed" do
1582 1583
      let(:closed_merge_request) do
        create(:closed_merge_request,
B
Bob Van Landuyt 已提交
1584
          source_project: forked_project,
1585 1586 1587
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1588
      it "returns false if the fork exist" do
1589 1590 1591
        expect(closed_merge_request.closed_without_fork?).to be_falsey
      end

K
Katarzyna Kobierska 已提交
1592
      it "returns true if the fork does not exist" do
1593 1594 1595 1596 1597 1598
        unlink_project.execute
        closed_merge_request.reload

        expect(closed_merge_request.closed_without_fork?).to be_truthy
      end
    end
K
Katarzyna Kobierska 已提交
1599

K
Katarzyna Kobierska 已提交
1600
    context "when the merge request is open" do
K
Katarzyna Kobierska 已提交
1601 1602
      let(:open_merge_request) do
        create(:merge_request,
B
Bob Van Landuyt 已提交
1603
          source_project: forked_project,
K
Katarzyna Kobierska 已提交
1604 1605 1606 1607 1608 1609 1610
          target_project: project)
      end

      it "returns false" do
        expect(open_merge_request.closed_without_fork?).to be_falsey
      end
    end
1611
  end
1612

1613
  describe '#reopenable?' do
K
Katarzyna Kobierska 已提交
1614 1615 1616
    context 'when the merge request is closed' do
      it 'returns true' do
        subject.close
K
Katarzyna Kobierska 已提交
1617

1618
        expect(subject.reopenable?).to be_truthy
K
Katarzyna Kobierska 已提交
1619 1620 1621
      end

      context 'forked project' do
B
Bob Van Landuyt 已提交
1622
        let(:project)      { create(:project, :public) }
K
Katarzyna Kobierska 已提交
1623
        let(:user)         { create(:user) }
B
Bob Van Landuyt 已提交
1624
        let(:forked_project) { fork_project(project, user) }
1625 1626

        let!(:merge_request) do
K
Katarzyna Kobierska 已提交
1627
          create(:closed_merge_request,
B
Bob Van Landuyt 已提交
1628
            source_project: forked_project,
K
Katarzyna Kobierska 已提交
1629 1630 1631 1632
            target_project: project)
        end

        it 'returns false if unforked' do
B
Bob Van Landuyt 已提交
1633
          Projects::UnlinkForkService.new(forked_project, user).execute
K
Katarzyna Kobierska 已提交
1634

1635
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1636 1637 1638
        end

        it 'returns false if the source project is deleted' do
B
Bob Van Landuyt 已提交
1639
          Projects::DestroyService.new(forked_project, user).execute
K
Katarzyna Kobierska 已提交
1640

1641
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1642 1643
        end

K
Katarzyna Kobierska 已提交
1644
        it 'returns false if the merge request is merged' do
K
Katarzyna Kobierska 已提交
1645 1646
          merge_request.update_attributes(state: 'merged')

1647
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1648 1649
        end
      end
K
Katarzyna Kobierska 已提交
1650 1651
    end

K
Katarzyna Kobierska 已提交
1652
    context 'when the merge request is opened' do
K
Katarzyna Kobierska 已提交
1653
      it 'returns false' do
1654
        expect(subject.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1655
      end
K
Katarzyna Kobierska 已提交
1656 1657
    end
  end
1658

1659
  describe '#mergeable_with_quick_action?' do
1660
    def create_pipeline(status)
F
Felipe Artur 已提交
1661
      pipeline = create(:ci_pipeline_with_one_job,
1662 1663 1664
        project: project,
        ref:     merge_request.source_branch,
        sha:     merge_request.diff_head_sha,
1665 1666
        status:  status,
        head_pipeline_of: merge_request)
F
Felipe Artur 已提交
1667 1668

      pipeline
1669 1670
    end

J
James Lopez 已提交
1671
    let(:project)       { create(:project, :public, :repository, only_allow_merge_if_pipeline_succeeds: true) }
1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682
    let(:developer)     { create(:user) }
    let(:user)          { create(:user) }
    let(:merge_request) { create(:merge_request, source_project: project) }
    let(:mr_sha)        { merge_request.diff_head_sha }

    before do
      project.team << [developer, :developer]
    end

    context 'when autocomplete_precheck is set to true' do
      it 'is mergeable by developer' do
1683
        expect(merge_request.mergeable_with_quick_action?(developer, autocomplete_precheck: true)).to be_truthy
1684 1685 1686
      end

      it 'is not mergeable by normal user' do
1687
        expect(merge_request.mergeable_with_quick_action?(user, autocomplete_precheck: true)).to be_falsey
1688 1689 1690 1691 1692
      end
    end

    context 'when autocomplete_precheck is set to false' do
      it 'is mergeable by developer' do
1693
        expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1694 1695 1696
      end

      it 'is not mergeable by normal user' do
1697
        expect(merge_request.mergeable_with_quick_action?(user, last_diff_sha: mr_sha)).to be_falsey
1698 1699 1700 1701 1702 1703 1704 1705
      end

      context 'closed MR'  do
        before do
          merge_request.update_attribute(:state, :closed)
        end

        it 'is not mergeable' do
1706
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1707 1708 1709 1710 1711 1712 1713 1714 1715
        end
      end

      context 'MR with WIP'  do
        before do
          merge_request.update_attribute(:title, 'WIP: some MR')
        end

        it 'is not mergeable' do
1716
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1717 1718 1719 1720 1721
        end
      end

      context 'sha differs from the MR diff_head_sha'  do
        it 'is not mergeable' do
1722
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: 'some other sha')).to be_falsey
1723 1724 1725
        end
      end

J
Jarka Kadlecova 已提交
1726 1727
      context 'sha is not provided'  do
        it 'is not mergeable' do
1728
          expect(merge_request.mergeable_with_quick_action?(developer)).to be_falsey
J
Jarka Kadlecova 已提交
1729 1730 1731
        end
      end

1732 1733 1734 1735 1736 1737
      context 'with pipeline ok'  do
        before do
          create_pipeline(:success)
        end

        it 'is mergeable' do
1738
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1739 1740 1741 1742 1743 1744 1745 1746 1747
        end
      end

      context 'with failing pipeline'  do
        before do
          create_pipeline(:failed)
        end

        it 'is not mergeable' do
1748
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1749 1750 1751 1752 1753
        end
      end

      context 'with running pipeline'  do
        before do
F
Felipe Artur 已提交
1754
          create_pipeline(:running)
1755 1756 1757
        end

        it 'is mergeable' do
1758
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1759 1760 1761 1762 1763
        end
      end
    end
  end

1764 1765
  describe '#has_commits?' do
    before do
1766 1767
      allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(2)
1768 1769 1770 1771 1772 1773 1774 1775 1776
    end

    it 'returns true when merge request diff has commits' do
      expect(subject.has_commits?).to be_truthy
    end
  end

  describe '#has_no_commits?' do
    before do
1777 1778
      allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(0)
1779 1780 1781 1782 1783 1784
    end

    it 'returns true when merge request diff has 0 commits' do
      expect(subject.has_no_commits?).to be_truthy
    end
  end
1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803

  describe '#merge_request_diff_for' do
    subject { create(:merge_request, importing: true) }
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'with diff refs' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff1.diff_refs)).to eq(merge_request_diff1)
      end
    end

    context 'with a commit SHA' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff3.head_commit_sha)).to eq(merge_request_diff3)
      end
    end
  end
1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835

  describe '#version_params_for' do
    subject { create(:merge_request, importing: true) }
    let(:project) { subject.project }
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'when the diff refs are for an older merge request version' do
      let(:diff_refs) { merge_request_diff1.diff_refs }

      it 'returns the diff ID for the version to show' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff1.id)
      end
    end

    context 'when the diff refs are for a comparison between merge request versions' do
      let(:diff_refs) { merge_request_diff3.compare_with(merge_request_diff1.head_commit_sha).diff_refs }

      it 'returns the diff ID and start sha of the versions to compare' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff3.id, start_sha: merge_request_diff1.head_commit_sha)
      end
    end

    context 'when the diff refs are not for a merge request version' do
      let(:diff_refs) { project.commit(sample_commit.id).diff_refs }

      it 'returns nil' do
        expect(subject.version_params_for(diff_refs)).to be_nil
      end
    end
  end
1836

1837
  describe '#fetch_ref!' do
M
micael.bergeron 已提交
1838
    it 'fetches the ref correctly' do
1839
      expect { subject.target_project.repository.delete_refs(subject.ref_path) }.not_to raise_error
1840

1841 1842
      subject.fetch_ref!
      expect(subject.target_project.repository.ref_exists?(subject.ref_path)).to be_truthy
1843 1844
    end
  end
1845 1846 1847 1848 1849 1850 1851 1852 1853

  describe 'removing a merge request' do
    it 'refreshes the number of open merge requests of the target project' do
      project = subject.target_project

      expect { subject.destroy }
        .to change { project.open_merge_requests_count }.from(1).to(0)
    end
  end
1854 1855 1856 1857

  it_behaves_like 'throttled touch' do
    subject { create(:merge_request, updated_at: 1.hour.ago) }
  end
D
Dmitriy Zaporozhets 已提交
1858
end