merge_request_spec.rb 53.3 KB
Newer Older
D
Dmitriy Zaporozhets 已提交
1 2
require 'spec_helper'

3
describe MergeRequest do
4 5
  include RepoHelpers

6 7
  subject { create(:merge_request) }

R
Robert Speicher 已提交
8
  describe 'associations' do
9 10
    it { is_expected.to belong_to(:target_project).class_name('Project') }
    it { is_expected.to belong_to(:source_project).class_name('Project') }
11
    it { is_expected.to belong_to(:merge_user).class_name("User") }
12
    it { is_expected.to belong_to(:assignee) }
13
    it { is_expected.to have_many(:merge_request_diffs) }
R
Robert Speicher 已提交
14 15
  end

16 17 18 19 20 21 22 23 24 25
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(InternalId) }
    it { is_expected.to include_module(Issuable) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(Taskable) }
  end

Z
Zeger-Jan van de Weg 已提交
26 27 28 29 30
  describe "act_as_paranoid" do
    it { is_expected.to have_db_column(:deleted_at) }
    it { is_expected.to have_db_index(:deleted_at) }
  end

31
  describe 'validation' do
32 33
    it { is_expected.to validate_presence_of(:target_branch) }
    it { is_expected.to validate_presence_of(:source_branch) }
Z
Zeger-Jan van de Weg 已提交
34

35
    context "Validation of merge user with Merge When Pipeline Succeeds" do
Z
Zeger-Jan van de Weg 已提交
36 37 38 39 40
      it "allows user to be nil when the feature is disabled" do
        expect(subject).to be_valid
      end

      it "is invalid without merge user" do
J
James Lopez 已提交
41
        subject.merge_when_pipeline_succeeds = true
Z
Zeger-Jan van de Weg 已提交
42 43 44 45
        expect(subject).not_to be_valid
      end

      it "is valid with merge user" do
J
James Lopez 已提交
46
        subject.merge_when_pipeline_succeeds = true
Z
Zeger-Jan van de Weg 已提交
47 48 49 50 51
        subject.merge_user = build(:user)

        expect(subject).to be_valid
      end
    end
D
Dmitriy Zaporozhets 已提交
52 53
  end

R
Robert Speicher 已提交
54
  describe 'respond to' do
55 56 57
    it { is_expected.to respond_to(:unchecked?) }
    it { is_expected.to respond_to(:can_be_merged?) }
    it { is_expected.to respond_to(:cannot_be_merged?) }
58
    it { is_expected.to respond_to(:merge_params) }
J
James Lopez 已提交
59
    it { is_expected.to respond_to(:merge_when_pipeline_succeeds) }
60
  end
A
Andrey Kumanyaev 已提交
61

62 63 64 65 66 67
  describe '.in_projects' do
    it 'returns the merge requests for a set of projects' do
      expect(described_class.in_projects(Project.all)).to eq([subject])
    end
  end

68
  describe '#target_branch_sha' do
69
    let(:project) { create(:project, :repository) }
70

71
    subject { create(:merge_request, source_project: project, target_project: project) }
72

73
    context 'when the target branch does not exist' do
74 75 76
      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
      end
77 78

      it 'returns nil' do
79
        expect(subject.target_branch_sha).to be_nil
80 81
      end
    end
82 83 84 85 86 87

    it 'returns memoized value' do
      subject.target_branch_sha = '8ffb3c15a5475e59ae909384297fede4badcb4c7'

      expect(subject.target_branch_sha).to eq '8ffb3c15a5475e59ae909384297fede4badcb4c7'
    end
88 89
  end

90 91 92 93 94
  describe '#card_attributes' do
    it 'includes the author name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignee).and_return(nil)

95 96
      expect(subject.card_attributes)
        .to eq({ 'Author' => 'Robert', 'Assignee' => nil })
97 98 99 100 101 102
    end

    it 'includes the assignee name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignee).and_return(double(name: 'Douwe'))

103 104
      expect(subject.card_attributes)
        .to eq({ 'Author' => 'Robert', 'Assignee' => 'Douwe' })
105 106 107
    end
  end

108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123
  describe '#assignee_ids' do
    it 'returns an array of the assigned user id' do
      subject.assignee_id = 123

      expect(subject.assignee_ids).to eq([123])
    end
  end

  describe '#assignee_ids=' do
    it 'sets assignee_id to the last id in the array' do
      subject.assignee_ids = [123, 456]

      expect(subject.assignee_id).to eq(456)
    end
  end

124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143
  describe '#assignee_or_author?' do
    let(:user) { create(:user) }

    it 'returns true for a user that is assigned to a merge request' do
      subject.assignee = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns true for a user that is the author of a merge request' do
      subject.author = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns false for a user that is not the assignee or author' do
      expect(subject.assignee_or_author?(user)).to eq(false)
    end
  end

144 145 146 147 148 149 150 151 152 153 154
  describe '#cache_merge_request_closes_issues!' do
    before do
      subject.project.team << [subject.author, :developer]
      subject.target_branch = subject.project.default_branch
    end

    it 'caches closed issues' do
      issue  = create :issue, project: subject.project
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])

155
      expect { subject.cache_merge_request_closes_issues!(subject.author) }.to change(subject.merge_requests_closing_issues, :count).by(1)
156 157
    end

158 159 160 161 162 163 164 165 166 167
    context 'when both internal and external issue trackers are enabled' do
      before do
        subject.project.has_external_issue_tracker = true
        subject.project.save!
      end

      it 'does not cache issues from external trackers' do
        issue  = ExternalIssue.new('JIRA-123', subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])
168

169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204
        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
      end

      it 'caches an internal issue' do
        issue  = create(:issue, project: subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }
          .to change(subject.merge_requests_closing_issues, :count).by(1)
      end
    end

    context 'when only external issue tracker enabled' do
      before do
        subject.project.has_external_issue_tracker = true
        subject.project.issues_enabled = false
        subject.project.save!
      end

      it 'does not cache issues from external trackers' do
        issue  = ExternalIssue.new('JIRA-123', subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
      end

      it 'does not cache an internal issue' do
        issue  = create(:issue, project: subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }
          .not_to change(subject.merge_requests_closing_issues, :count)
      end
205 206 207
    end
  end

208
  describe '#source_branch_sha' do
209 210 211 212 213
    let(:last_branch_commit) { subject.source_project.repository.commit(subject.source_branch) }

    context 'with diffs' do
      subject { create(:merge_request, :with_diffs) }
      it 'returns the sha of the source branch last commit' do
214
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
215 216 217
      end
    end

218 219 220
    context 'without diffs' do
      subject { create(:merge_request, :without_diffs) }
      it 'returns the sha of the source branch last commit' do
221
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
222 223 224
      end
    end

225 226 227
    context 'when the merge request is being created' do
      subject { build(:merge_request, source_branch: nil, compare_commits: []) }
      it 'returns nil' do
228
        expect(subject.source_branch_sha).to be_nil
229 230
      end
    end
231 232 233 234 235 236

    it 'returns memoized value' do
      subject.source_branch_sha = '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'

      expect(subject.source_branch_sha).to eq '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
    end
237 238
  end

239
  describe '#to_reference' do
240
    let(:project) { build(:project, name: 'sample-project') }
241 242
    let(:merge_request) { build(:merge_request, target_project: project, iid: 1) }

243
    it 'returns a String reference to the object' do
244
      expect(merge_request.to_reference).to eq "!1"
245 246 247
    end

    it 'supports a cross-project reference' do
248
      another_project = build(:project, name: 'another-project', namespace: project.namespace)
249
      expect(merge_request.to_reference(another_project)).to eq "sample-project!1"
250
    end
251 252

    it 'returns a String reference with the full path' do
253
      expect(merge_request.to_reference(full: true)).to eq(project.full_path + '!1')
254
    end
255
  end
256

257
  describe '#raw_diffs' do
S
Sean McGivern 已提交
258 259 260 261 262 263 264
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
        merge_request.merge_request_diff = MergeRequestDiff.new

265
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(options)
S
Sean McGivern 已提交
266

267 268 269 270 271 272 273 274 275 276 277 278 279 280 281
        merge_request.raw_diffs(options)
      end
    end

    context 'when there are no MR diffs' do
      it 'delegates to the compare object' do
        merge_request.compare = double(:compare)

        expect(merge_request.compare).to receive(:raw_diffs).with(options)

        merge_request.raw_diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
282 283 284 285 286 287
  describe '#diffs' do
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
288
        merge_request.save
S
Sean McGivern 已提交
289

290
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(hash_including(options))
S
Sean McGivern 已提交
291 292 293 294 295 296

        merge_request.diffs(options)
      end
    end

    context 'when there are no MR diffs' do
297
      it 'delegates to the compare object, setting expanded: true' do
S
Sean McGivern 已提交
298 299
        merge_request.compare = double(:compare)

300
        expect(merge_request.compare).to receive(:diffs).with(options.merge(expanded: true))
S
Sean McGivern 已提交
301 302 303 304 305 306

        merge_request.diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
307 308 309 310 311 312
  describe '#diff_size' do
    let(:merge_request) do
      build(:merge_request, source_branch: 'expand-collapse-files', target_branch: 'master')
    end

    context 'when there are MR diffs' do
313
      it 'returns the correct count' do
S
Sean McGivern 已提交
314
        merge_request.save
315 316

        expect(merge_request.diff_size).to eq('105')
S
Sean McGivern 已提交
317 318
      end

319 320 321 322 323
      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        merge_request.save

        expect(merge_request.diff_size).to eq('2+')
S
Sean McGivern 已提交
324 325 326
      end

      it 'does not perform highlighting' do
327 328
        merge_request.save

S
Sean McGivern 已提交
329 330 331 332 333 334 335
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end

    context 'when there are no MR diffs' do
336
      def set_compare(merge_request)
S
Sean McGivern 已提交
337 338 339 340 341 342 343 344 345 346
        merge_request.compare = CompareService.new(
          merge_request.source_project,
          merge_request.source_branch
        ).execute(
          merge_request.target_project,
          merge_request.target_branch
        )
      end

      it 'returns the correct count' do
347 348 349 350 351 352 353 354 355 356
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('105')
      end

      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('2+')
S
Sean McGivern 已提交
357 358 359
      end

      it 'does not perform highlighting' do
360 361
        set_compare(merge_request)

S
Sean McGivern 已提交
362 363 364 365 366 367 368
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end
  end

369
  describe "#related_notes" do
370
    let!(:merge_request) { create(:merge_request) }
371 372

    before do
373
      allow(merge_request).to receive(:commits) { [merge_request.source_project.repository.commit] }
374 375
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.project)
D
Dmitriy Zaporozhets 已提交
376
      create(:note, noteable: merge_request, project: merge_request.project)
377 378
    end

379
    it "includes notes for commits" do
380
      expect(merge_request.commits).not_to be_empty
381
      expect(merge_request.related_notes.count).to eq(2)
382
    end
383

384
    it "includes notes for commits from target project as well" do
385 386 387
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.target_project)

388
      expect(merge_request.commits).not_to be_empty
389
      expect(merge_request.related_notes.count).to eq(3)
390
    end
391
  end
392

I
Izaak Alpert 已提交
393 394
  describe '#for_fork?' do
    it 'returns true if the merge request is for a fork' do
395 396
      subject.source_project = build_stubbed(:project, namespace: create(:group))
      subject.target_project = build_stubbed(:project, namespace: create(:group))
I
Izaak Alpert 已提交
397

398
      expect(subject.for_fork?).to be_truthy
I
Izaak Alpert 已提交
399
    end
D
Dmitriy Zaporozhets 已提交
400

I
Izaak Alpert 已提交
401
    it 'returns false if is not for a fork' do
402
      expect(subject.for_fork?).to be_falsey
I
Izaak Alpert 已提交
403 404 405
    end
  end

406
  describe '#closes_issues' do
407 408
    let(:issue0) { create :issue, project: subject.project }
    let(:issue1) { create :issue, project: subject.project }
409 410 411 412

    let(:commit0) { double('commit0', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit1) { double('commit1', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit2) { double('commit2', safe_message: "Fixes #{issue1.to_reference}") }
413 414

    before do
415
      subject.project.team << [subject.author, :developer]
416
      allow(subject).to receive(:commits).and_return([commit0, commit1, commit2])
417 418
    end

419
    it 'accesses the set of issues that will be closed on acceptance' do
420 421
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
422

423
      closed = subject.closes_issues
424

425 426
      expect(closed).to include(issue0, issue1)
    end
427

428 429 430
    it 'only lists issues as to be closed if it targets the default branch' do
      allow(subject.project).to receive(:default_branch).and_return('master')
      subject.target_branch = 'something-else'
431

432
      expect(subject.closes_issues).to be_empty
433
    end
434
  end
435

436
  describe '#issues_mentioned_but_not_closing' do
437 438 439 440
    let(:closing_issue) { create :issue, project: subject.project }
    let(:mentioned_issue) { create :issue, project: subject.project }

    let(:commit) { double('commit', safe_message: "Fixes #{closing_issue.to_reference}") }
441

442
    it 'detects issues mentioned in description but not closed' do
443
      subject.project.team << [subject.author, :developer]
444
      subject.description = "Is related to #{mentioned_issue.to_reference} and #{closing_issue.to_reference}"
445

446
      allow(subject).to receive(:commits).and_return([commit])
447 448
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
449

450
      expect(subject.issues_mentioned_but_not_closing(subject.author)).to match_array([mentioned_issue])
451
    end
452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468

    context 'when the project has an external issue tracker' do
      before do
        subject.project.team << [subject.author, :developer]
        commit = double(:commit, safe_message: 'Fixes TEST-3')

        create(:jira_service, project: subject.project)

        allow(subject).to receive(:commits).and_return([commit])
        allow(subject).to receive(:description).and_return('Is related to TEST-2 and TEST-3')
        allow(subject.project).to receive(:default_branch).and_return(subject.target_branch)
      end

      it 'detects issues mentioned in description but not closed' do
        expect(subject.issues_mentioned_but_not_closing(subject.author).map(&:to_s)).to match_array(['TEST-2'])
      end
    end
469 470
  end

471
  describe "#work_in_progress?" do
472 473 474
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "detects the '#{wip_prefix}' prefix" do
        subject.title = "#{wip_prefix}#{subject.title}"
475
        expect(subject.work_in_progress?).to eq true
476
      end
T
Ted Hogan 已提交
477 478
    end

479 480
    it "doesn't detect WIP for words starting with WIP" do
      subject.title = "Wipwap #{subject.title}"
481
      expect(subject.work_in_progress?).to eq false
482 483
    end

484 485
    it "doesn't detect WIP for words containing with WIP" do
      subject.title = "WupWipwap #{subject.title}"
486
      expect(subject.work_in_progress?).to eq false
487 488
    end

489
    it "doesn't detect WIP by default" do
490
      expect(subject.work_in_progress?).to eq false
491 492 493
    end
  end

T
Thomas Balthazar 已提交
494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516
  describe "#wipless_title" do
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "removes the '#{wip_prefix}' prefix" do
        wipless_title = subject.title
        subject.title = "#{wip_prefix}#{subject.title}"

        expect(subject.wipless_title).to eq wipless_title
      end

      it "is satisfies the #work_in_progress? method" do
        subject.title = "#{wip_prefix}#{subject.title}"
        subject.title = subject.wipless_title

        expect(subject.work_in_progress?).to eq false
      end
    end
  end

  describe "#wip_title" do
    it "adds the WIP: prefix to the title" do
      wip_title = "WIP: #{subject.title}"

      expect(subject.wip_title).to eq wip_title
517
    end
T
Thomas Balthazar 已提交
518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533

    it "does not add the WIP: prefix multiple times" do
      wip_title = "WIP: #{subject.title}"
      subject.title = subject.wip_title
      subject.title = subject.wip_title

      expect(subject.wip_title).to eq wip_title
    end

    it "is satisfies the #work_in_progress? method" do
      subject.title = subject.wip_title

      expect(subject.work_in_progress?).to eq true
    end
  end

Z
Zeger-Jan van de Weg 已提交
534
  describe '#can_remove_source_branch?' do
Z
Zeger-Jan van de Weg 已提交
535 536
    let(:user) { create(:user) }
    let(:user2) { create(:user) }
537 538 539 540

    before do
      subject.source_project.team << [user, :master]

Z
Zeger-Jan van de Weg 已提交
541 542 543 544
      subject.source_branch = "feature"
      subject.target_branch = "master"
      subject.save!
    end
545

Z
Zeger-Jan van de Weg 已提交
546
    it "can't be removed when its a protected branch" do
547
      allow(ProtectedBranch).to receive(:protected?).and_return(true)
548 549 550
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

551
    it "can't remove a root ref" do
Z
Zeger-Jan van de Weg 已提交
552 553
      subject.source_branch = "master"
      subject.target_branch = "feature"
554 555 556 557

      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

Z
Zeger-Jan van de Weg 已提交
558 559 560 561
    it "is unable to remove the source branch for a project the user cannot push to" do
      expect(subject.can_remove_source_branch?(user2)).to be_falsey
    end

562
    it "can be removed if the last commit is the head of the source branch" do
563
      allow(subject).to receive(:source_branch_head).and_return(subject.diff_head_commit)
564

Z
Zeger-Jan van de Weg 已提交
565
      expect(subject.can_remove_source_branch?(user)).to be_truthy
566
    end
567 568

    it "cannot be removed if the last commit is not also the head of the source branch" do
569 570
      subject.source_branch = "lfs"

571 572
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end
573 574
  end

575 576 577 578 579 580 581 582 583 584 585 586 587 588 589
  describe '#merge_commit_message' do
    it 'includes merge information as the title' do
      request = build(:merge_request, source_branch: 'source', target_branch: 'target')

      expect(request.merge_commit_message)
        .to match("Merge branch 'source' into 'target'\n\n")
    end

    it 'includes its title in the body' do
      request = build(:merge_request, title: 'Remove all technical debt')

      expect(request.merge_commit_message)
        .to match("Remove all technical debt\n\n")
    end

590
    it 'includes its closed issues in the body' do
591
      issue = create(:issue, project: subject.project)
592

593
      subject.project.team << [subject.author, :developer]
594
      subject.description = "This issue Closes #{issue.to_reference}"
595

596 597
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
598 599

      expect(subject.merge_commit_message)
600
        .to match("Closes #{issue.to_reference}")
601 602 603 604 605 606
    end

    it 'includes its reference in the body' do
      request = build_stubbed(:merge_request)

      expect(request.merge_commit_message)
607
        .to match("See merge request #{request.to_reference(full: true)}")
608 609 610 611 612 613 614
    end

    it 'excludes multiple linebreak runs when description is blank' do
      request = build(:merge_request, title: 'Title', description: nil)

      expect(request.merge_commit_message).not_to match("Title\n\n\n\n")
    end
615 616 617 618 619 620 621 622 623 624 625 626 627 628

    it 'includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message(include_description: true))
        .to match("By removing all code\n\n")
    end

    it 'does not includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message)
        .not_to match("By removing all code\n\n")
    end
629 630
  end

J
James Lopez 已提交
631
  describe "#reset_merge_when_pipeline_succeeds" do
632
    let(:merge_if_green) do
J
James Lopez 已提交
633
      create :merge_request, merge_when_pipeline_succeeds: true, merge_user: create(:user),
634 635
                             merge_params: { "should_remove_source_branch" => "1", "commit_message" => "msg" }
    end
Z
Zeger-Jan van de Weg 已提交
636

637
    it "sets the item to false" do
J
James Lopez 已提交
638
      merge_if_green.reset_merge_when_pipeline_succeeds
639 640
      merge_if_green.reload

J
James Lopez 已提交
641
      expect(merge_if_green.merge_when_pipeline_succeeds).to be_falsey
642 643
      expect(merge_if_green.merge_params["should_remove_source_branch"]).to be_nil
      expect(merge_if_green.merge_params["commit_message"]).to be_nil
644 645 646
    end
  end

647
  describe "#hook_attrs" do
648
    let(:attrs_hash) { subject.hook_attrs }
649 650 651 652 653 654 655 656 657 658

    [:source, :target].each do |key|
      describe "#{key} key" do
        include_examples 'project hook data', project_key: key do
          let(:data)    { attrs_hash }
          let(:project) { subject.send("#{key}_project") }
        end
      end
    end

659
    it "has all the required keys" do
660 661 662 663
      expect(attrs_hash).to include(:source)
      expect(attrs_hash).to include(:target)
      expect(attrs_hash).to include(:last_commit)
      expect(attrs_hash).to include(:work_in_progress)
664 665 666 667
      expect(attrs_hash).to include(:total_time_spent)
      expect(attrs_hash).to include(:human_time_estimate)
      expect(attrs_hash).to include(:human_total_time_spent)
      expect(attrs_hash).to include('time_estimate')
668
    end
669 670 671
  end

  describe '#diverged_commits_count' do
672 673
    let(:project)      { create(:project, :repository) }
    let(:fork_project) { create(:project, :repository, forked_from_project: project) }
674

675
    context 'when the target branch does not exist anymore' do
676 677 678 679 680 681
      subject { create(:merge_request, source_project: project, target_project: project) }

      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
        subject.reload
      end
682 683

      it 'does not crash' do
684
        expect { subject.diverged_commits_count }.not_to raise_error
685 686 687 688 689 690 691
      end

      it 'returns 0' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

692 693 694 695
    context 'diverged on same repository' do
      subject(:merge_request_with_divergence) { create(:merge_request, :diverged, source_project: project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
696
        expect(subject.diverged_commits_count).to eq(29)
697 698 699 700 701 702 703
      end
    end

    context 'diverged on fork' do
      subject(:merge_request_fork_with_divergence) { create(:merge_request, :diverged, source_project: fork_project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
704
        expect(subject.diverged_commits_count).to eq(29)
705 706 707 708 709 710 711 712 713 714 715 716
      end
    end

    context 'rebased on fork' do
      subject(:merge_request_rebased) { create(:merge_request, :rebased, source_project: fork_project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

    describe 'caching' do
717
      before do
718 719 720 721
        allow(Rails).to receive(:cache).and_return(ActiveSupport::Cache::MemoryStore.new)
      end

      it 'caches the output' do
722 723 724
        expect(subject).to receive(:compute_diverged_commits_count)
          .once
          .and_return(2)
725 726 727 728 729 730

        subject.diverged_commits_count
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the source sha changes' do
731 732 733
        expect(subject).to receive(:compute_diverged_commits_count)
          .twice
          .and_return(2)
734 735

        subject.diverged_commits_count
736
        allow(subject).to receive(:source_branch_sha).and_return('123abc')
737 738 739 740
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the target sha changes' do
741 742 743
        expect(subject).to receive(:compute_diverged_commits_count)
          .twice
          .and_return(2)
744 745

        subject.diverged_commits_count
746
        allow(subject).to receive(:target_branch_sha).and_return('123abc')
747 748 749
        subject.diverged_commits_count
      end
    end
750 751
  end

752
  it_behaves_like 'an editable mentionable' do
753
    subject { create(:merge_request, :simple) }
754

755
    let(:backref_text) { "merge request #{subject.to_reference}" }
756
    let(:set_mentionable_text) { ->(txt) { subject.description = txt } }
757
  end
V
Vinnie Okada 已提交
758 759

  it_behaves_like 'a Taskable' do
760
    subject { create :merge_request, :simple }
V
Vinnie Okada 已提交
761
  end
762

763
  describe '#commit_shas' do
764
    before do
765
      allow(subject.merge_request_diff).to receive(:commit_shas)
766
        .and_return(['sha1'])
767 768
    end

769
    it 'delegates to merge request diff' do
770
      expect(subject.commit_shas).to eq ['sha1']
771 772 773
    end
  end

774
  describe '#head_pipeline' do
775
    describe 'when the source project exists' do
776
      it 'returns the latest pipeline' do
777
        pipeline = create(:ci_empty_pipeline, project: subject.source_project, ref: 'master', status: 'running', sha: "123abc", head_pipeline_of: subject)
778

779
        expect(subject.head_pipeline).to eq(pipeline)
780 781 782 783 784 785 786
      end
    end

    describe 'when the source project does not exist' do
      it 'returns nil' do
        allow(subject).to receive(:source_project).and_return(nil)

787
        expect(subject.head_pipeline).to be_nil
788 789 790
      end
    end
  end
Y
Yorick Peterse 已提交
791

792
  describe '#all_pipelines' do
793
    shared_examples 'returning pipelines with proper ordering' do
794
      let!(:all_pipelines) do
795
        subject.all_commit_shas.map do |sha|
796 797 798 799
          create(:ci_empty_pipeline,
                 project: subject.source_project,
                 sha: sha,
                 ref: subject.source_branch)
800 801 802 803 804
        end
      end

      it 'returns all pipelines' do
        expect(subject.all_pipelines).not_to be_empty
805
        expect(subject.all_pipelines).to eq(all_pipelines.reverse)
806
      end
807 808
    end

809 810 811 812 813 814
    context 'with single merge_request_diffs' do
      it_behaves_like 'returning pipelines with proper ordering'
    end

    context 'with multiple irrelevant merge_request_diffs' do
      before do
815
        subject.update(target_branch: 'v1.0.0')
816 817 818
      end

      it_behaves_like 'returning pipelines with proper ordering'
819
    end
820 821

    context 'with unsaved merge request' do
822
      subject { build(:merge_request) }
823 824 825

      let!(:pipeline) do
        create(:ci_empty_pipeline,
826
               project: subject.project,
827 828
               sha: subject.diff_head_sha,
               ref: subject.source_branch)
829
      end
830 831 832 833 834

      it 'returns pipelines from diff_head_sha' do
        expect(subject.all_pipelines).to contain_exactly(pipeline)
      end
    end
835 836
  end

837
  describe '#all_commit_shas' do
838
    context 'when merge request is persisted' do
839
      let(:all_commit_shas) do
840 841
        subject.merge_request_diffs.flat_map(&:commits).map(&:sha).uniq
      end
842

843 844 845
      shared_examples 'returning all SHA' do
        it 'returns all SHA from all merge_request_diffs' do
          expect(subject.merge_request_diffs.size).to eq(2)
846
          expect(subject.all_commit_shas).to match_array(all_commit_shas)
847
        end
848 849
      end

850 851 852 853 854 855
      context 'with a completely different branch' do
        before do
          subject.update(target_branch: 'v1.0.0')
        end

        it_behaves_like 'returning all SHA'
856 857
      end

858 859 860 861 862 863 864 865
      context 'with a branch having no difference' do
        before do
          subject.update(target_branch: 'v1.1.0')
          subject.reload # make sure commits were not cached
        end

        it_behaves_like 'returning all SHA'
      end
866 867
    end

868 869 870 871 872 873 874 875 876
    context 'when merge request is not persisted' do
      context 'when compare commits are set in the service' do
        let(:commit) { spy('commit') }

        subject do
          build(:merge_request, compare_commits: [commit, commit])
        end

        it 'returns commits from compare commits temporary data' do
877
          expect(subject.all_commit_shas).to eq [commit, commit]
878
        end
879 880
      end

881 882 883 884
      context 'when compare commits are not set in the service' do
        subject { build(:merge_request) }

        it 'returns array with diff head sha element only' do
885
          expect(subject.all_commit_shas).to eq [subject.diff_head_sha]
886 887
        end
      end
888 889 890
    end
  end

Y
Yorick Peterse 已提交
891
  describe '#participants' do
892
    let(:project) { create(:project, :public) }
Y
Yorick Peterse 已提交
893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913

    let(:mr) do
      create(:merge_request, source_project: project, target_project: project)
    end

    let!(:note1) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'a')
    end

    let!(:note2) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'b')
    end

    it 'includes the merge request author' do
      expect(mr.participants).to include(mr.author)
    end

    it 'includes the authors of the notes' do
      expect(mr.participants).to include(note1.author, note2.author)
    end
  end
J
Josh Frye 已提交
914 915 916 917 918 919

  describe 'cached counts' do
    it 'updates when assignees change' do
      user1 = create(:user)
      user2 = create(:user)
      mr = create(:merge_request, assignee: user1)
920 921
      mr.project.add_developer(user1)
      mr.project.add_developer(user2)
J
Josh Frye 已提交
922

923 924
      expect(user1.assigned_open_merge_requests_count).to eq(1)
      expect(user2.assigned_open_merge_requests_count).to eq(0)
J
Josh Frye 已提交
925 926 927 928

      mr.assignee = user2
      mr.save

929 930
      expect(user1.assigned_open_merge_requests_count).to eq(0)
      expect(user2.assigned_open_merge_requests_count).to eq(1)
J
Josh Frye 已提交
931 932
    end
  end
933

934
  describe '#merge_async' do
935 936 937 938 939 940 941 942 943 944
    it 'enqueues MergeWorker job and updates merge_jid' do
      merge_request = create(:merge_request)
      user_id = double(:user_id)
      params = double(:params)
      merge_jid = 'hash-123'

      expect(MergeWorker).to receive(:perform_async).with(merge_request.id, user_id, params) do
        merge_jid
      end

945
      merge_request.merge_async(user_id, params)
946 947 948 949 950

      expect(merge_request.reload.merge_jid).to eq(merge_jid)
    end
  end

951
  describe '#check_if_can_be_merged' do
952
    let(:project) { create(:project, only_allow_merge_if_pipeline_succeeds: true) }
953 954 955 956

    subject { create(:merge_request, source_project: project, merge_status: :unchecked) }

    context 'when it is not broken and has no conflicts' do
957
      before do
958
        allow(subject).to receive(:broken?) { false }
959
        allow(project.repository).to receive(:can_be_merged?).and_return(true)
960
      end
961

962
      it 'is marked as mergeable' do
963 964 965 966 967
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('can_be_merged')
      end
    end

    context 'when broken' do
968 969 970
      before do
        allow(subject).to receive(:broken?) { true }
      end
971 972 973 974 975 976 977 978 979

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end

    context 'when it has conflicts' do
      before do
        allow(subject).to receive(:broken?) { false }
980
        allow(project.repository).to receive(:can_be_merged?).and_return(false)
981 982 983 984 985 986 987 988 989
      end

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end
  end

  describe '#mergeable?' do
990
    let(:project) { create(:project) }
991 992 993

    subject { create(:merge_request, source_project: project) }

994 995
    it 'returns false if #mergeable_state? is false' do
      expect(subject).to receive(:mergeable_state?) { false }
996

997
      expect(subject.mergeable?).to be_falsey
998 999
    end

1000
    it 'return true if #mergeable_state? is true and the MR #can_be_merged? is true' do
1001 1002
      allow(subject).to receive(:mergeable_state?) { true }
      expect(subject).to receive(:check_if_can_be_merged)
1003
      expect(subject).to receive(:can_be_merged?) { true }
1004 1005 1006 1007 1008 1009

      expect(subject.mergeable?).to be_truthy
    end
  end

  describe '#mergeable_state?' do
1010
    let(:project) { create(:project, :repository) }
1011 1012 1013

    subject { create(:merge_request, source_project: project) }

1014
    it 'checks if merge request can be merged' do
1015
      allow(subject).to receive(:mergeable_ci_state?) { true }
1016 1017 1018 1019 1020 1021
      expect(subject).to receive(:check_if_can_be_merged)

      subject.mergeable?
    end

    context 'when not open' do
1022 1023 1024
      before do
        subject.close
      end
1025 1026

      it 'returns false' do
1027
        expect(subject.mergeable_state?).to be_falsey
1028 1029 1030 1031
      end
    end

    context 'when working in progress' do
1032 1033 1034
      before do
        subject.title = 'WIP MR'
      end
1035 1036

      it 'returns false' do
1037
        expect(subject.mergeable_state?).to be_falsey
1038 1039 1040 1041
      end
    end

    context 'when broken' do
1042 1043 1044
      before do
        allow(subject).to receive(:broken?) { true }
      end
1045 1046

      it 'returns false' do
1047
        expect(subject.mergeable_state?).to be_falsey
1048 1049 1050 1051
      end
    end

    context 'when failed' do
R
Rémy Coutable 已提交
1052
      context 'when #mergeable_ci_state? is false' do
1053
        before do
1054
          allow(subject).to receive(:mergeable_ci_state?) { false }
1055 1056 1057 1058
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
1059 1060
        end
      end
1061

R
Rémy Coutable 已提交
1062
      context 'when #mergeable_discussions_state? is false' do
1063 1064 1065 1066 1067 1068 1069 1070
        before do
          allow(subject).to receive(:mergeable_discussions_state?) { false }
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
        end
      end
1071 1072 1073
    end
  end

1074
  describe '#mergeable_ci_state?' do
1075
    let(:project) { create(:project, only_allow_merge_if_pipeline_succeeds: true) }
R
Rémy Coutable 已提交
1076
    let(:pipeline) { create(:ci_empty_pipeline) }
1077 1078 1079

    subject { build(:merge_request, target_project: project) }

1080
    context 'when it is only allowed to merge when build is green' do
R
Rémy Coutable 已提交
1081
      context 'and a failed pipeline is associated' do
1082
        before do
1083
          pipeline.update(status: 'failed')
1084
          allow(subject).to receive(:head_pipeline) { pipeline }
1085
        end
1086

1087
        it { expect(subject.mergeable_ci_state?).to be_falsey }
1088 1089
      end

1090 1091 1092
      context 'and a successful pipeline is associated' do
        before do
          pipeline.update(status: 'success')
1093
          allow(subject).to receive(:head_pipeline) { pipeline }
1094 1095 1096 1097 1098 1099 1100 1101
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

      context 'and a skipped pipeline is associated' do
        before do
          pipeline.update(status: 'skipped')
1102
          allow(subject).to receive(:head_pipeline) { pipeline }
1103 1104 1105 1106 1107
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
1108
      context 'when no pipeline is associated' do
1109
        before do
1110
          allow(subject).to receive(:head_pipeline) { nil }
1111 1112 1113
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1114 1115 1116
      end
    end

1117
    context 'when merges are not restricted to green builds' do
1118
      subject { build(:merge_request, target_project: build(:project, only_allow_merge_if_pipeline_succeeds: false)) }
1119

R
Rémy Coutable 已提交
1120
      context 'and a failed pipeline is associated' do
1121
        before do
R
Rémy Coutable 已提交
1122
          pipeline.statuses << create(:commit_status, status: 'failed', project: project)
1123
          allow(subject).to receive(:head_pipeline) { pipeline }
1124 1125 1126 1127 1128
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
1129
      context 'when no pipeline is associated' do
1130
        before do
1131
          allow(subject).to receive(:head_pipeline) { nil }
1132 1133 1134
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1135 1136 1137
      end
    end
  end
1138

1139
  describe '#mergeable_discussions_state?' do
R
Rémy Coutable 已提交
1140
    let(:merge_request) { create(:merge_request_with_diff_notes, source_project: project) }
1141

R
Rémy Coutable 已提交
1142
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == true' do
1143
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: true) }
1144

R
Rémy Coutable 已提交
1145
      context 'with all discussions resolved' do
1146
        before do
R
Rémy Coutable 已提交
1147
          merge_request.discussions.each { |d| d.resolve!(merge_request.author) }
1148 1149 1150
        end

        it 'returns true' do
R
Rémy Coutable 已提交
1151
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1152 1153 1154
        end
      end

R
Rémy Coutable 已提交
1155
      context 'with unresolved discussions' do
1156
        before do
R
Rémy Coutable 已提交
1157
          merge_request.discussions.each(&:unresolve!)
1158 1159 1160
        end

        it 'returns false' do
R
Rémy Coutable 已提交
1161
          expect(merge_request.mergeable_discussions_state?).to be_falsey
1162 1163
        end
      end
1164 1165 1166 1167 1168 1169 1170 1171 1172 1173

      context 'with no discussions' do
        before do
          merge_request.notes.destroy_all
        end

        it 'returns true' do
          expect(merge_request.mergeable_discussions_state?).to be_truthy
        end
      end
1174 1175
    end

R
Rémy Coutable 已提交
1176
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == false' do
1177
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: false) }
1178

R
Rémy Coutable 已提交
1179
      context 'with unresolved discussions' do
1180
        before do
R
Rémy Coutable 已提交
1181
          merge_request.discussions.each(&:unresolve!)
1182 1183 1184
        end

        it 'returns true' do
R
Rémy Coutable 已提交
1185
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1186 1187 1188 1189 1190
        end
      end
    end
  end

D
Douwe Maan 已提交
1191
  describe "#environments_for" do
1192
    let(:project)       { create(:project, :repository) }
D
Douwe Maan 已提交
1193
    let(:user)          { project.creator }
Z
Z.J. van de Weg 已提交
1194 1195
    let(:merge_request) { create(:merge_request, source_project: project) }

D
Douwe Maan 已提交
1196 1197 1198 1199 1200
    before do
      merge_request.source_project.add_master(user)
      merge_request.target_project.add_master(user)
    end

1201 1202
    context 'with multiple environments' do
      let(:environments) { create_list(:environment, 3, project: project) }
1203

1204 1205 1206 1207 1208 1209
      before do
        create(:deployment, environment: environments.first, ref: 'master', sha: project.commit('master').id)
        create(:deployment, environment: environments.second, ref: 'feature', sha: project.commit('feature').id)
      end

      it 'selects deployed environments' do
D
Douwe Maan 已提交
1210
        expect(merge_request.environments_for(user)).to contain_exactly(environments.first)
1211 1212 1213 1214 1215
      end
    end

    context 'with environments on source project' do
      let(:source_project) do
1216
        create(:project, :repository) do |fork_project|
1217 1218 1219
          fork_project.create_forked_project_link(forked_to_project_id: fork_project.id, forked_from_project_id: project.id)
        end
      end
K
Kamil Trzcinski 已提交
1220

1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233
      let(:merge_request) do
        create(:merge_request,
               source_project: source_project, source_branch: 'feature',
               target_project: project)
      end

      let(:source_environment) { create(:environment, project: source_project) }

      before do
        create(:deployment, environment: source_environment, ref: 'feature', sha: merge_request.diff_head_sha)
      end

      it 'selects deployed environments' do
D
Douwe Maan 已提交
1234
        expect(merge_request.environments_for(user)).to contain_exactly(source_environment)
1235 1236 1237 1238 1239 1240 1241 1242 1243 1244
      end

      context 'with environments on target project' do
        let(:target_environment) { create(:environment, project: project) }

        before do
          create(:deployment, environment: target_environment, tag: true, sha: merge_request.diff_head_sha)
        end

        it 'selects deployed environments' do
D
Douwe Maan 已提交
1245
          expect(merge_request.environments_for(user)).to contain_exactly(source_environment, target_environment)
1246 1247
        end
      end
1248 1249 1250 1251 1252 1253 1254 1255
    end

    context 'without a diff_head_commit' do
      before do
        expect(merge_request).to receive(:diff_head_commit).and_return(nil)
      end

      it 'returns an empty array' do
D
Douwe Maan 已提交
1256
        expect(merge_request.environments_for(user)).to be_empty
1257
      end
Z
Z.J. van de Weg 已提交
1258 1259 1260
    end
  end

1261
  describe "#reload_diff" do
1262
    let(:discussion) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject).to_discussion }
1263 1264 1265

    let(:commit) { subject.project.commit(sample_commit.id) }

1266
    it "does not change existing merge request diff" do
1267
      expect(subject.merge_request_diff).not_to receive(:save_git_content)
1268 1269 1270
      subject.reload_diff
    end

1271 1272 1273 1274
    it "creates new merge request diff" do
      expect { subject.reload_diff }.to change { subject.merge_request_diffs.count }.by(1)
    end

1275 1276 1277 1278 1279 1280
    it "executs diff cache service" do
      expect_any_instance_of(MergeRequests::MergeRequestDiffCacheService).to receive(:execute).with(subject)

      subject.reload_diff
    end

1281
    it "updates diff discussion positions" do
1282 1283 1284
      old_diff_refs = subject.diff_refs

      # Update merge_request_diff so that #diff_refs will return commit.diff_refs
1285 1286 1287 1288 1289 1290
      allow(subject).to receive(:create_merge_request_diff) do
        subject.merge_request_diffs.create(
          base_commit_sha: commit.parent_id,
          start_commit_sha: commit.parent_id,
          head_commit_sha: commit.sha
        )
1291 1292

        subject.merge_request_diff(true)
1293 1294
      end

1295
      expect(Discussions::UpdateDiffPositionService).to receive(:new).with(
1296
        subject.project,
1297
        subject.author,
1298 1299
        old_diff_refs: old_diff_refs,
        new_diff_refs: commit.diff_refs,
1300
        paths: discussion.position.paths
1301 1302
      ).and_call_original

1303
      expect_any_instance_of(Discussions::UpdateDiffPositionService).to receive(:execute).with(discussion).and_call_original
1304 1305
      expect_any_instance_of(DiffNote).to receive(:save).once

1306
      subject.reload_diff(subject.author)
1307 1308
    end
  end
1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322

  describe '#branch_merge_base_commit' do
    context 'source and target branch exist' do
      it { expect(subject.branch_merge_base_commit.sha).to eq('ae73cb07c9eeaf35924a10f713b364d32b2dd34f') }
      it { expect(subject.branch_merge_base_commit).to be_a(Commit) }
    end

    context 'when the target branch does not exist' do
      before do
        subject.project.repository.raw_repository.delete_branch(subject.target_branch)
      end

      it 'returns nil' do
        expect(subject.branch_merge_base_commit).to be_nil
1323 1324 1325 1326
      end
    end
  end

1327
  describe "#diff_refs" do
1328 1329 1330 1331 1332 1333 1334 1335
    context "with diffs" do
      subject { create(:merge_request, :with_diffs) }

      it "does not touch the repository" do
        subject # Instantiate the object

        expect_any_instance_of(Repository).not_to receive(:commit)

1336
        subject.diff_refs
1337 1338 1339 1340 1341 1342 1343 1344 1345
      end

      it "returns expected diff_refs" do
        expected_diff_refs = Gitlab::Diff::DiffRefs.new(
          base_sha:  subject.merge_request_diff.base_commit_sha,
          start_sha: subject.merge_request_diff.start_commit_sha,
          head_sha:  subject.merge_request_diff.head_commit_sha
        )

1346
        expect(subject.diff_refs).to eq(expected_diff_refs)
1347 1348 1349
      end
    end
  end
1350

1351
  describe "#source_project_missing?" do
1352 1353
    let(:project)      { create(:project) }
    let(:fork_project) { create(:project, forked_from_project: project) }
1354 1355 1356
    let(:user)         { create(:user) }
    let(:unlink_project) { Projects::UnlinkForkService.new(fork_project, user) }

K
Katarzyna Kobierska 已提交
1357
    context "when the fork exists" do
1358 1359 1360 1361 1362 1363
      let(:merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

1364
      it { expect(merge_request.source_project_missing?).to be_falsey }
1365 1366
    end

K
Katarzyna Kobierska 已提交
1367
    context "when the source project is the same as the target project" do
1368 1369
      let(:merge_request) { create(:merge_request, source_project: project) }

1370
      it { expect(merge_request.source_project_missing?).to be_falsey }
1371 1372
    end

K
Katarzyna Kobierska 已提交
1373
    context "when the fork does not exist" do
1374 1375 1376 1377 1378 1379
      let(:merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1380
      it "returns true" do
1381 1382 1383
        unlink_project.execute
        merge_request.reload

1384
        expect(merge_request.source_project_missing?).to be_truthy
1385 1386 1387 1388
      end
    end
  end

1389
  describe '#merge_ongoing?' do
1390 1391
    it 'returns true when merge_id is present and MR is not merged' do
      merge_request = build_stubbed(:merge_request, state: :open, merge_jid: 'foo')
1392 1393 1394 1395 1396

      expect(merge_request.merge_ongoing?).to be(true)
    end
  end

1397
  describe "#closed_without_fork?" do
1398 1399
    let(:project)      { create(:project) }
    let(:fork_project) { create(:project, forked_from_project: project) }
1400 1401 1402
    let(:user)         { create(:user) }
    let(:unlink_project) { Projects::UnlinkForkService.new(fork_project, user) }

K
Katarzyna Kobierska 已提交
1403
    context "when the merge request is closed" do
1404 1405 1406 1407 1408 1409
      let(:closed_merge_request) do
        create(:closed_merge_request,
          source_project: fork_project,
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1410
      it "returns false if the fork exist" do
1411 1412 1413
        expect(closed_merge_request.closed_without_fork?).to be_falsey
      end

K
Katarzyna Kobierska 已提交
1414
      it "returns true if the fork does not exist" do
1415 1416 1417 1418 1419 1420
        unlink_project.execute
        closed_merge_request.reload

        expect(closed_merge_request.closed_without_fork?).to be_truthy
      end
    end
K
Katarzyna Kobierska 已提交
1421

K
Katarzyna Kobierska 已提交
1422
    context "when the merge request is open" do
K
Katarzyna Kobierska 已提交
1423 1424 1425 1426 1427 1428 1429 1430 1431 1432
      let(:open_merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

      it "returns false" do
        expect(open_merge_request.closed_without_fork?).to be_falsey
      end
    end
1433
  end
1434

1435
  describe '#reopenable?' do
K
Katarzyna Kobierska 已提交
1436 1437 1438
    context 'when the merge request is closed' do
      it 'returns true' do
        subject.close
K
Katarzyna Kobierska 已提交
1439

1440
        expect(subject.reopenable?).to be_truthy
K
Katarzyna Kobierska 已提交
1441 1442 1443
      end

      context 'forked project' do
1444
        let(:project)      { create(:project) }
K
Katarzyna Kobierska 已提交
1445
        let(:user)         { create(:user) }
1446
        let(:fork_project) { create(:project, forked_from_project: project, namespace: user.namespace) }
1447 1448

        let!(:merge_request) do
K
Katarzyna Kobierska 已提交
1449 1450 1451 1452 1453 1454 1455 1456
          create(:closed_merge_request,
            source_project: fork_project,
            target_project: project)
        end

        it 'returns false if unforked' do
          Projects::UnlinkForkService.new(fork_project, user).execute

1457
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1458 1459 1460
        end

        it 'returns false if the source project is deleted' do
1461
          Projects::DestroyService.new(fork_project, user).execute
K
Katarzyna Kobierska 已提交
1462

1463
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1464 1465
        end

K
Katarzyna Kobierska 已提交
1466
        it 'returns false if the merge request is merged' do
K
Katarzyna Kobierska 已提交
1467 1468
          merge_request.update_attributes(state: 'merged')

1469
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1470 1471
        end
      end
K
Katarzyna Kobierska 已提交
1472 1473
    end

K
Katarzyna Kobierska 已提交
1474
    context 'when the merge request is opened' do
K
Katarzyna Kobierska 已提交
1475
      it 'returns false' do
1476
        expect(subject.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1477
      end
K
Katarzyna Kobierska 已提交
1478 1479
    end
  end
1480

1481
  describe '#mergeable_with_quick_action?' do
1482
    def create_pipeline(status)
F
Felipe Artur 已提交
1483
      pipeline = create(:ci_pipeline_with_one_job,
1484 1485 1486
        project: project,
        ref:     merge_request.source_branch,
        sha:     merge_request.diff_head_sha,
1487 1488
        status:  status,
        head_pipeline_of: merge_request)
F
Felipe Artur 已提交
1489 1490

      pipeline
1491 1492
    end

J
James Lopez 已提交
1493
    let(:project)       { create(:project, :public, :repository, only_allow_merge_if_pipeline_succeeds: true) }
1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504
    let(:developer)     { create(:user) }
    let(:user)          { create(:user) }
    let(:merge_request) { create(:merge_request, source_project: project) }
    let(:mr_sha)        { merge_request.diff_head_sha }

    before do
      project.team << [developer, :developer]
    end

    context 'when autocomplete_precheck is set to true' do
      it 'is mergeable by developer' do
1505
        expect(merge_request.mergeable_with_quick_action?(developer, autocomplete_precheck: true)).to be_truthy
1506 1507 1508
      end

      it 'is not mergeable by normal user' do
1509
        expect(merge_request.mergeable_with_quick_action?(user, autocomplete_precheck: true)).to be_falsey
1510 1511 1512 1513 1514
      end
    end

    context 'when autocomplete_precheck is set to false' do
      it 'is mergeable by developer' do
1515
        expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1516 1517 1518
      end

      it 'is not mergeable by normal user' do
1519
        expect(merge_request.mergeable_with_quick_action?(user, last_diff_sha: mr_sha)).to be_falsey
1520 1521 1522 1523 1524 1525 1526 1527
      end

      context 'closed MR'  do
        before do
          merge_request.update_attribute(:state, :closed)
        end

        it 'is not mergeable' do
1528
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1529 1530 1531 1532 1533 1534 1535 1536 1537
        end
      end

      context 'MR with WIP'  do
        before do
          merge_request.update_attribute(:title, 'WIP: some MR')
        end

        it 'is not mergeable' do
1538
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1539 1540 1541 1542 1543
        end
      end

      context 'sha differs from the MR diff_head_sha'  do
        it 'is not mergeable' do
1544
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: 'some other sha')).to be_falsey
1545 1546 1547
        end
      end

J
Jarka Kadlecova 已提交
1548 1549
      context 'sha is not provided'  do
        it 'is not mergeable' do
1550
          expect(merge_request.mergeable_with_quick_action?(developer)).to be_falsey
J
Jarka Kadlecova 已提交
1551 1552 1553
        end
      end

1554 1555 1556 1557 1558 1559
      context 'with pipeline ok'  do
        before do
          create_pipeline(:success)
        end

        it 'is mergeable' do
1560
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1561 1562 1563 1564 1565 1566 1567 1568 1569
        end
      end

      context 'with failing pipeline'  do
        before do
          create_pipeline(:failed)
        end

        it 'is not mergeable' do
1570
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1571 1572 1573 1574 1575
        end
      end

      context 'with running pipeline'  do
        before do
F
Felipe Artur 已提交
1576
          create_pipeline(:running)
1577 1578 1579
        end

        it 'is mergeable' do
1580
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1581 1582 1583 1584 1585
        end
      end
    end
  end

1586 1587
  describe '#has_commits?' do
    before do
1588 1589
      allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(2)
1590 1591 1592 1593 1594 1595 1596 1597 1598
    end

    it 'returns true when merge request diff has commits' do
      expect(subject.has_commits?).to be_truthy
    end
  end

  describe '#has_no_commits?' do
    before do
1599 1600
      allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(0)
1601 1602 1603 1604 1605 1606
    end

    it 'returns true when merge request diff has 0 commits' do
      expect(subject.has_no_commits?).to be_truthy
    end
  end
1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625

  describe '#merge_request_diff_for' do
    subject { create(:merge_request, importing: true) }
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'with diff refs' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff1.diff_refs)).to eq(merge_request_diff1)
      end
    end

    context 'with a commit SHA' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff3.head_commit_sha)).to eq(merge_request_diff3)
      end
    end
  end
1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657

  describe '#version_params_for' do
    subject { create(:merge_request, importing: true) }
    let(:project) { subject.project }
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'when the diff refs are for an older merge request version' do
      let(:diff_refs) { merge_request_diff1.diff_refs }

      it 'returns the diff ID for the version to show' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff1.id)
      end
    end

    context 'when the diff refs are for a comparison between merge request versions' do
      let(:diff_refs) { merge_request_diff3.compare_with(merge_request_diff1.head_commit_sha).diff_refs }

      it 'returns the diff ID and start sha of the versions to compare' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff3.id, start_sha: merge_request_diff1.head_commit_sha)
      end
    end

    context 'when the diff refs are not for a merge request version' do
      let(:diff_refs) { project.commit(sample_commit.id).diff_refs }

      it 'returns nil' do
        expect(subject.version_params_for(diff_refs)).to be_nil
      end
    end
  end
1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693

  describe '#fetch_ref' do
    it 'sets "ref_fetched" flag to true' do
      subject.update!(ref_fetched: nil)

      subject.fetch_ref

      expect(subject.reload.ref_fetched).to be_truthy
    end
  end

  describe '#ref_fetched?' do
    it 'does not perform git operation when value is cached' do
      subject.ref_fetched = true

      expect_any_instance_of(Repository).not_to receive(:ref_exists?)
      expect(subject.ref_fetched?).to be_truthy
    end

    it 'caches the value when ref exists but value is not cached' do
      subject.update!(ref_fetched: nil)
      allow_any_instance_of(Repository).to receive(:ref_exists?)
        .and_return(true)

      expect(subject.ref_fetched?).to be_truthy
      expect(subject.reload.ref_fetched).to be_truthy
    end

    it 'returns false when ref does not exist' do
      subject.update!(ref_fetched: nil)
      allow_any_instance_of(Repository).to receive(:ref_exists?)
        .and_return(false)

      expect(subject.ref_fetched?).to be_falsey
    end
  end
1694 1695 1696 1697 1698 1699 1700 1701 1702

  describe 'removing a merge request' do
    it 'refreshes the number of open merge requests of the target project' do
      project = subject.target_project

      expect { subject.destroy }
        .to change { project.open_merge_requests_count }.from(1).to(0)
    end
  end
D
Dmitriy Zaporozhets 已提交
1703
end