merge_request_spec.rb 47.9 KB
Newer Older
D
Dmitriy Zaporozhets 已提交
1 2
require 'spec_helper'

D
Douwe Maan 已提交
3
describe MergeRequest, models: true do
4 5
  include RepoHelpers

6 7
  subject { create(:merge_request) }

R
Robert Speicher 已提交
8
  describe 'associations' do
9 10
    it { is_expected.to belong_to(:target_project).class_name('Project') }
    it { is_expected.to belong_to(:source_project).class_name('Project') }
11
    it { is_expected.to belong_to(:merge_user).class_name("User") }
12
    it { is_expected.to have_many(:merge_request_diffs).dependent(:destroy) }
R
Robert Speicher 已提交
13 14
  end

15 16 17 18 19 20 21 22 23 24
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(InternalId) }
    it { is_expected.to include_module(Issuable) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(Taskable) }
  end

Z
Zeger-Jan van de Weg 已提交
25 26 27 28 29
  describe "act_as_paranoid" do
    it { is_expected.to have_db_column(:deleted_at) }
    it { is_expected.to have_db_index(:deleted_at) }
  end

30
  describe 'validation' do
31 32
    it { is_expected.to validate_presence_of(:target_branch) }
    it { is_expected.to validate_presence_of(:source_branch) }
Z
Zeger-Jan van de Weg 已提交
33

34
    context "Validation of merge user with Merge When Pipeline Succeeds" do
Z
Zeger-Jan van de Weg 已提交
35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50
      it "allows user to be nil when the feature is disabled" do
        expect(subject).to be_valid
      end

      it "is invalid without merge user" do
        subject.merge_when_build_succeeds = true
        expect(subject).not_to be_valid
      end

      it "is valid with merge user" do
        subject.merge_when_build_succeeds = true
        subject.merge_user = build(:user)

        expect(subject).to be_valid
      end
    end
D
Dmitriy Zaporozhets 已提交
51 52
  end

R
Robert Speicher 已提交
53
  describe 'respond to' do
54 55 56
    it { is_expected.to respond_to(:unchecked?) }
    it { is_expected.to respond_to(:can_be_merged?) }
    it { is_expected.to respond_to(:cannot_be_merged?) }
57 58
    it { is_expected.to respond_to(:merge_params) }
    it { is_expected.to respond_to(:merge_when_build_succeeds) }
59
  end
A
Andrey Kumanyaev 已提交
60

61 62 63 64 65 66
  describe '.in_projects' do
    it 'returns the merge requests for a set of projects' do
      expect(described_class.in_projects(Project.all)).to eq([subject])
    end
  end

67
  describe '#target_branch_sha' do
68
    let(:project) { create(:project) }
69

70
    subject { create(:merge_request, source_project: project, target_project: project) }
71

72
    context 'when the target branch does not exist' do
73 74 75
      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
      end
76 77

      it 'returns nil' do
78
        expect(subject.target_branch_sha).to be_nil
79 80
      end
    end
81 82 83 84 85 86

    it 'returns memoized value' do
      subject.target_branch_sha = '8ffb3c15a5475e59ae909384297fede4badcb4c7'

      expect(subject.target_branch_sha).to eq '8ffb3c15a5475e59ae909384297fede4badcb4c7'
    end
87 88
  end

89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112
  describe '#cache_merge_request_closes_issues!' do
    before do
      subject.project.team << [subject.author, :developer]
      subject.target_branch = subject.project.default_branch
    end

    it 'caches closed issues' do
      issue  = create :issue, project: subject.project
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])

      expect { subject.cache_merge_request_closes_issues! }.to change(subject.merge_requests_closing_issues, :count).by(1)
    end

    it 'does not cache issues from external trackers' do
      subject.project.update_attribute(:has_external_issue_tracker, true)
      issue  = ExternalIssue.new('JIRA-123', subject.project)
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])

      expect { subject.cache_merge_request_closes_issues! }.not_to change(subject.merge_requests_closing_issues, :count)
    end
  end

113
  describe '#source_branch_sha' do
114 115 116 117 118
    let(:last_branch_commit) { subject.source_project.repository.commit(subject.source_branch) }

    context 'with diffs' do
      subject { create(:merge_request, :with_diffs) }
      it 'returns the sha of the source branch last commit' do
119
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
120 121 122
      end
    end

123 124 125
    context 'without diffs' do
      subject { create(:merge_request, :without_diffs) }
      it 'returns the sha of the source branch last commit' do
126
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
127 128 129
      end
    end

130 131 132
    context 'when the merge request is being created' do
      subject { build(:merge_request, source_branch: nil, compare_commits: []) }
      it 'returns nil' do
133
        expect(subject.source_branch_sha).to be_nil
134 135
      end
    end
136 137 138 139 140 141

    it 'returns memoized value' do
      subject.source_branch_sha = '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'

      expect(subject.source_branch_sha).to eq '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
    end
142 143
  end

144
  describe '#to_reference' do
145 146 147
    let(:project) { build(:empty_project, name: 'sample-project') }
    let(:merge_request) { build(:merge_request, target_project: project, iid: 1) }

148
    it 'returns a String reference to the object' do
149
      expect(merge_request.to_reference).to eq "!1"
150 151 152
    end

    it 'supports a cross-project reference' do
153 154
      another_project = build(:project, name: 'another-project', namespace: project.namespace)
      expect(merge_request.to_reference(another_project)).to eq "sample-project!1"
155
    end
156
  end
157

158
  describe '#raw_diffs' do
S
Sean McGivern 已提交
159 160 161 162 163 164 165
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
        merge_request.merge_request_diff = MergeRequestDiff.new

166
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(options)
S
Sean McGivern 已提交
167

168 169 170 171 172 173 174 175 176 177 178 179 180 181 182
        merge_request.raw_diffs(options)
      end
    end

    context 'when there are no MR diffs' do
      it 'delegates to the compare object' do
        merge_request.compare = double(:compare)

        expect(merge_request.compare).to receive(:raw_diffs).with(options)

        merge_request.raw_diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
183 184 185 186 187 188
  describe '#diffs' do
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
189
        merge_request.save
S
Sean McGivern 已提交
190

191
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(hash_including(options))
S
Sean McGivern 已提交
192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207

        merge_request.diffs(options)
      end
    end

    context 'when there are no MR diffs' do
      it 'delegates to the compare object' do
        merge_request.compare = double(:compare)

        expect(merge_request.compare).to receive(:diffs).with(options)

        merge_request.diffs(options)
      end
    end
  end

208
  describe "#related_notes" do
209
    let!(:merge_request) { create(:merge_request) }
210 211

    before do
212
      allow(merge_request).to receive(:commits) { [merge_request.source_project.repository.commit] }
213 214
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.project)
D
Dmitriy Zaporozhets 已提交
215
      create(:note, noteable: merge_request, project: merge_request.project)
216 217
    end

218
    it "includes notes for commits" do
219
      expect(merge_request.commits).not_to be_empty
220
      expect(merge_request.related_notes.count).to eq(2)
221
    end
222

223
    it "includes notes for commits from target project as well" do
224 225 226
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.target_project)

227
      expect(merge_request.commits).not_to be_empty
228
      expect(merge_request.related_notes.count).to eq(3)
229
    end
230
  end
231 232 233

  describe '#is_being_reassigned?' do
    it 'returns true if the merge_request assignee has changed' do
234
      subject.assignee = create(:user)
235
      expect(subject.is_being_reassigned?).to be_truthy
236 237
    end
    it 'returns false if the merge request assignee has not changed' do
238
      expect(subject.is_being_reassigned?).to be_falsey
239 240
    end
  end
I
Izaak Alpert 已提交
241 242 243

  describe '#for_fork?' do
    it 'returns true if the merge request is for a fork' do
D
Dmitriy Zaporozhets 已提交
244 245
      subject.source_project = create(:project, namespace: create(:group))
      subject.target_project = create(:project, namespace: create(:group))
I
Izaak Alpert 已提交
246

247
      expect(subject.for_fork?).to be_truthy
I
Izaak Alpert 已提交
248
    end
D
Dmitriy Zaporozhets 已提交
249

I
Izaak Alpert 已提交
250
    it 'returns false if is not for a fork' do
251
      expect(subject.for_fork?).to be_falsey
I
Izaak Alpert 已提交
252 253 254
    end
  end

255
  describe '#closes_issues' do
256 257
    let(:issue0) { create :issue, project: subject.project }
    let(:issue1) { create :issue, project: subject.project }
258 259 260 261

    let(:commit0) { double('commit0', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit1) { double('commit1', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit2) { double('commit2', safe_message: "Fixes #{issue1.to_reference}") }
262 263

    before do
264
      subject.project.team << [subject.author, :developer]
265
      allow(subject).to receive(:commits).and_return([commit0, commit1, commit2])
266 267
    end

268 269 270
    it 'accesses the set of issues that will be closed on acceptance' do
      allow(subject.project).to receive(:default_branch).
        and_return(subject.target_branch)
271

272
      closed = subject.closes_issues
273

274 275
      expect(closed).to include(issue0, issue1)
    end
276

277 278 279
    it 'only lists issues as to be closed if it targets the default branch' do
      allow(subject.project).to receive(:default_branch).and_return('master')
      subject.target_branch = 'something-else'
280

281
      expect(subject.closes_issues).to be_empty
282
    end
283
  end
284

285
  describe '#issues_mentioned_but_not_closing' do
286
    it 'detects issues mentioned in description but not closed' do
287 288
      mentioned_issue = create(:issue, project: subject.project)

289
      subject.project.team << [subject.author, :developer]
290 291
      subject.description = "Is related to #{mentioned_issue.to_reference}"

292 293
      allow(subject.project).to receive(:default_branch).
        and_return(subject.target_branch)
294

295
      expect(subject.issues_mentioned_but_not_closing).to match_array([mentioned_issue])
296
    end
297 298
  end

299
  describe "#work_in_progress?" do
300 301 302
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "detects the '#{wip_prefix}' prefix" do
        subject.title = "#{wip_prefix}#{subject.title}"
303
        expect(subject.work_in_progress?).to eq true
304
      end
T
Ted Hogan 已提交
305 306
    end

307 308
    it "doesn't detect WIP for words starting with WIP" do
      subject.title = "Wipwap #{subject.title}"
309
      expect(subject.work_in_progress?).to eq false
310 311
    end

312 313
    it "doesn't detect WIP for words containing with WIP" do
      subject.title = "WupWipwap #{subject.title}"
314
      expect(subject.work_in_progress?).to eq false
315 316
    end

317
    it "doesn't detect WIP by default" do
318
      expect(subject.work_in_progress?).to eq false
319 320 321
    end
  end

T
Thomas Balthazar 已提交
322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344
  describe "#wipless_title" do
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "removes the '#{wip_prefix}' prefix" do
        wipless_title = subject.title
        subject.title = "#{wip_prefix}#{subject.title}"

        expect(subject.wipless_title).to eq wipless_title
      end

      it "is satisfies the #work_in_progress? method" do
        subject.title = "#{wip_prefix}#{subject.title}"
        subject.title = subject.wipless_title

        expect(subject.work_in_progress?).to eq false
      end
    end
  end

  describe "#wip_title" do
    it "adds the WIP: prefix to the title" do
      wip_title = "WIP: #{subject.title}"

      expect(subject.wip_title).to eq wip_title
345
    end
T
Thomas Balthazar 已提交
346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361

    it "does not add the WIP: prefix multiple times" do
      wip_title = "WIP: #{subject.title}"
      subject.title = subject.wip_title
      subject.title = subject.wip_title

      expect(subject.wip_title).to eq wip_title
    end

    it "is satisfies the #work_in_progress? method" do
      subject.title = subject.wip_title

      expect(subject.work_in_progress?).to eq true
    end
  end

Z
Zeger-Jan van de Weg 已提交
362
  describe '#can_remove_source_branch?' do
Z
Zeger-Jan van de Weg 已提交
363 364
    let(:user) { create(:user) }
    let(:user2) { create(:user) }
365 366 367 368

    before do
      subject.source_project.team << [user, :master]

Z
Zeger-Jan van de Weg 已提交
369 370 371 372
      subject.source_branch = "feature"
      subject.target_branch = "master"
      subject.save!
    end
373

Z
Zeger-Jan van de Weg 已提交
374 375
    it "can't be removed when its a protected branch" do
      allow(subject.source_project).to receive(:protected_branch?).and_return(true)
376 377 378
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

379
    it "can't remove a root ref" do
Z
Zeger-Jan van de Weg 已提交
380 381
      subject.source_branch = "master"
      subject.target_branch = "feature"
382 383 384 385

      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

Z
Zeger-Jan van de Weg 已提交
386 387 388 389
    it "is unable to remove the source branch for a project the user cannot push to" do
      expect(subject.can_remove_source_branch?(user2)).to be_falsey
    end

390
    it "can be removed if the last commit is the head of the source branch" do
391
      allow(subject).to receive(:source_branch_head).and_return(subject.diff_head_commit)
392

Z
Zeger-Jan van de Weg 已提交
393
      expect(subject.can_remove_source_branch?(user)).to be_truthy
394
    end
395 396

    it "cannot be removed if the last commit is not also the head of the source branch" do
397 398
      subject.source_branch = "lfs"

399 400
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end
401 402
  end

403 404 405 406 407 408 409 410 411 412 413 414 415 416 417
  describe '#merge_commit_message' do
    it 'includes merge information as the title' do
      request = build(:merge_request, source_branch: 'source', target_branch: 'target')

      expect(request.merge_commit_message)
        .to match("Merge branch 'source' into 'target'\n\n")
    end

    it 'includes its title in the body' do
      request = build(:merge_request, title: 'Remove all technical debt')

      expect(request.merge_commit_message)
        .to match("Remove all technical debt\n\n")
    end

418 419
    it 'includes its closed issues in the body' do
      issue = create(:issue, project: subject.project) 
420

421 422 423 424 425 426 427 428
      subject.project.team << [subject.author, :developer]
      subject.description = "Closes #{issue.to_reference}"

      allow(subject.project).to receive(:default_branch).
        and_return(subject.target_branch)

      expect(subject.merge_commit_message)
        .to match("Closed Issues: #{issue.to_reference}")
429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444
    end

    it 'includes its reference in the body' do
      request = build_stubbed(:merge_request)

      expect(request.merge_commit_message)
        .to match("See merge request #{request.to_reference}")
    end

    it 'excludes multiple linebreak runs when description is blank' do
      request = build(:merge_request, title: 'Title', description: nil)

      expect(request.merge_commit_message).not_to match("Title\n\n\n\n")
    end
  end

445
  describe "#reset_merge_when_build_succeeds" do
446 447 448 449
    let(:merge_if_green) do
      create :merge_request, merge_when_build_succeeds: true, merge_user: create(:user),
                             merge_params: { "should_remove_source_branch" => "1", "commit_message" => "msg" }
    end
Z
Zeger-Jan van de Weg 已提交
450

451 452 453 454 455
    it "sets the item to false" do
      merge_if_green.reset_merge_when_build_succeeds
      merge_if_green.reload

      expect(merge_if_green.merge_when_build_succeeds).to be_falsey
456 457
      expect(merge_if_green.merge_params["should_remove_source_branch"]).to be_nil
      expect(merge_if_green.merge_params["commit_message"]).to be_nil
458 459 460
    end
  end

461
  describe "#hook_attrs" do
462 463 464 465 466 467 468 469 470 471 472
    let(:attrs_hash) { subject.hook_attrs.to_h }

    [:source, :target].each do |key|
      describe "#{key} key" do
        include_examples 'project hook data', project_key: key do
          let(:data)    { attrs_hash }
          let(:project) { subject.send("#{key}_project") }
        end
      end
    end

473
    it "has all the required keys" do
474 475 476 477
      expect(attrs_hash).to include(:source)
      expect(attrs_hash).to include(:target)
      expect(attrs_hash).to include(:last_commit)
      expect(attrs_hash).to include(:work_in_progress)
478
    end
479 480 481 482 483 484
  end

  describe '#diverged_commits_count' do
    let(:project)      { create(:project) }
    let(:fork_project) { create(:project, forked_from_project: project) }

485
    context 'when the target branch does not exist anymore' do
486 487 488 489 490 491
      subject { create(:merge_request, source_project: project, target_project: project) }

      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
        subject.reload
      end
492 493 494 495 496 497 498 499 500 501

      it 'does not crash' do
        expect{ subject.diverged_commits_count }.not_to raise_error
      end

      it 'returns 0' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

502 503 504 505
    context 'diverged on same repository' do
      subject(:merge_request_with_divergence) { create(:merge_request, :diverged, source_project: project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
506
        expect(subject.diverged_commits_count).to eq(29)
507 508 509 510 511 512 513
      end
    end

    context 'diverged on fork' do
      subject(:merge_request_fork_with_divergence) { create(:merge_request, :diverged, source_project: fork_project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
514
        expect(subject.diverged_commits_count).to eq(29)
515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545
      end
    end

    context 'rebased on fork' do
      subject(:merge_request_rebased) { create(:merge_request, :rebased, source_project: fork_project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

    describe 'caching' do
      before(:example) do
        allow(Rails).to receive(:cache).and_return(ActiveSupport::Cache::MemoryStore.new)
      end

      it 'caches the output' do
        expect(subject).to receive(:compute_diverged_commits_count).
          once.
          and_return(2)

        subject.diverged_commits_count
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the source sha changes' do
        expect(subject).to receive(:compute_diverged_commits_count).
          twice.
          and_return(2)

        subject.diverged_commits_count
546
        allow(subject).to receive(:source_branch_sha).and_return('123abc')
547 548 549 550 551 552 553 554 555
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the target sha changes' do
        expect(subject).to receive(:compute_diverged_commits_count).
          twice.
          and_return(2)

        subject.diverged_commits_count
556
        allow(subject).to receive(:target_branch_sha).and_return('123abc')
557 558 559
        subject.diverged_commits_count
      end
    end
560 561
  end

562
  it_behaves_like 'an editable mentionable' do
563
    subject { create(:merge_request, :simple) }
564

565 566
    let(:backref_text) { "merge request #{subject.to_reference}" }
    let(:set_mentionable_text) { ->(txt){ subject.description = txt } }
567
  end
V
Vinnie Okada 已提交
568 569

  it_behaves_like 'a Taskable' do
570
    subject { create :merge_request, :simple }
V
Vinnie Okada 已提交
571
  end
572

573 574
  describe '#commits_sha' do
    before do
575 576
      allow(subject.merge_request_diff).to receive(:commits_sha).
        and_return(['sha1'])
577 578
    end

579 580
    it 'delegates to merge request diff' do
      expect(subject.commits_sha).to eq ['sha1']
581 582 583
    end
  end

584
  describe '#head_pipeline' do
585
    describe 'when the source project exists' do
586
      it 'returns the latest pipeline' do
587
        pipeline = double(:ci_pipeline, ref: 'master')
588

589
        allow(subject).to receive(:diff_head_sha).and_return('123abc')
590

L
Lin Jen-Shin 已提交
591 592
        expect(subject.source_project).to receive(:pipeline_for).
          with('master', '123abc').
593
          and_return(pipeline)
594

595
        expect(subject.head_pipeline).to eq(pipeline)
596 597 598 599 600 601 602
      end
    end

    describe 'when the source project does not exist' do
      it 'returns nil' do
        allow(subject).to receive(:source_project).and_return(nil)

603
        expect(subject.head_pipeline).to be_nil
604 605 606
      end
    end
  end
Y
Yorick Peterse 已提交
607

608
  describe '#all_pipelines' do
609
    shared_examples 'returning pipelines with proper ordering' do
610 611 612 613 614 615
      let!(:all_pipelines) do
        subject.all_commits_sha.map do |sha|
          create(:ci_empty_pipeline,
                 project: subject.source_project,
                 sha: sha,
                 ref: subject.source_branch)
616 617 618 619 620
        end
      end

      it 'returns all pipelines' do
        expect(subject.all_pipelines).not_to be_empty
621
        expect(subject.all_pipelines).to eq(all_pipelines.reverse)
622
      end
623 624
    end

625 626 627 628 629 630
    context 'with single merge_request_diffs' do
      it_behaves_like 'returning pipelines with proper ordering'
    end

    context 'with multiple irrelevant merge_request_diffs' do
      before do
631
        subject.update(target_branch: 'v1.0.0')
632 633 634
      end

      it_behaves_like 'returning pipelines with proper ordering'
635
    end
636 637

    context 'with unsaved merge request' do
638
      subject { build(:merge_request) }
639 640 641

      let!(:pipeline) do
        create(:ci_empty_pipeline,
642
               project: subject.project,
643 644
               sha: subject.diff_head_sha,
               ref: subject.source_branch)
645
      end
646 647 648 649 650

      it 'returns pipelines from diff_head_sha' do
        expect(subject.all_pipelines).to contain_exactly(pipeline)
      end
    end
651 652
  end

653
  describe '#all_commits_sha' do
654 655 656 657
    context 'when merge request is persisted' do
      let(:all_commits_sha) do
        subject.merge_request_diffs.flat_map(&:commits).map(&:sha).uniq
      end
658

659 660 661 662 663
      shared_examples 'returning all SHA' do
        it 'returns all SHA from all merge_request_diffs' do
          expect(subject.merge_request_diffs.size).to eq(2)
          expect(subject.all_commits_sha).to eq(all_commits_sha)
        end
664 665
      end

666 667 668 669 670 671
      context 'with a completely different branch' do
        before do
          subject.update(target_branch: 'v1.0.0')
        end

        it_behaves_like 'returning all SHA'
672 673
      end

674 675 676 677 678 679 680 681
      context 'with a branch having no difference' do
        before do
          subject.update(target_branch: 'v1.1.0')
          subject.reload # make sure commits were not cached
        end

        it_behaves_like 'returning all SHA'
      end
682 683
    end

684 685 686 687 688 689 690 691 692 693 694
    context 'when merge request is not persisted' do
      context 'when compare commits are set in the service' do
        let(:commit) { spy('commit') }

        subject do
          build(:merge_request, compare_commits: [commit, commit])
        end

        it 'returns commits from compare commits temporary data' do
          expect(subject.all_commits_sha).to eq [commit, commit]
        end
695 696
      end

697 698 699 700 701 702 703
      context 'when compare commits are not set in the service' do
        subject { build(:merge_request) }

        it 'returns array with diff head sha element only' do
          expect(subject.all_commits_sha).to eq [subject.diff_head_sha]
        end
      end
704 705 706
    end
  end

Y
Yorick Peterse 已提交
707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729
  describe '#participants' do
    let(:project) { create(:project, :public) }

    let(:mr) do
      create(:merge_request, source_project: project, target_project: project)
    end

    let!(:note1) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'a')
    end

    let!(:note2) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'b')
    end

    it 'includes the merge request author' do
      expect(mr.participants).to include(mr.author)
    end

    it 'includes the authors of the notes' do
      expect(mr.participants).to include(note1.author, note2.author)
    end
  end
J
Josh Frye 已提交
730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746

  describe 'cached counts' do
    it 'updates when assignees change' do
      user1 = create(:user)
      user2 = create(:user)
      mr = create(:merge_request, assignee: user1)

      expect(user1.assigned_open_merge_request_count).to eq(1)
      expect(user2.assigned_open_merge_request_count).to eq(0)

      mr.assignee = user2
      mr.save

      expect(user1.assigned_open_merge_request_count).to eq(0)
      expect(user2.assigned_open_merge_request_count).to eq(1)
    end
  end
747 748 749 750 751 752 753 754 755

  describe '#check_if_can_be_merged' do
    let(:project) { create(:project, only_allow_merge_if_build_succeeds: true) }

    subject { create(:merge_request, source_project: project, merge_status: :unchecked) }

    context 'when it is not broken and has no conflicts' do
      it 'is marked as mergeable' do
        allow(subject).to receive(:broken?) { false }
756
        allow(project.repository).to receive(:can_be_merged?).and_return(true)
757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772

        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('can_be_merged')
      end
    end

    context 'when broken' do
      before { allow(subject).to receive(:broken?) { true } }

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end

    context 'when it has conflicts' do
      before do
        allow(subject).to receive(:broken?) { false }
773
        allow(project.repository).to receive(:can_be_merged?).and_return(false)
774 775 776 777 778 779 780 781 782
      end

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end
  end

  describe '#mergeable?' do
783 784 785 786
    let(:project) { create(:project) }

    subject { create(:merge_request, source_project: project) }

787 788
    it 'returns false if #mergeable_state? is false' do
      expect(subject).to receive(:mergeable_state?) { false }
789

790
      expect(subject.mergeable?).to be_falsey
791 792
    end

793
    it 'return true if #mergeable_state? is true and the MR #can_be_merged? is true' do
794 795
      allow(subject).to receive(:mergeable_state?) { true }
      expect(subject).to receive(:check_if_can_be_merged)
796
      expect(subject).to receive(:can_be_merged?) { true }
797 798 799 800 801 802 803

      expect(subject.mergeable?).to be_truthy
    end
  end

  describe '#mergeable_state?' do
    let(:project) { create(:project) }
804 805 806

    subject { create(:merge_request, source_project: project) }

807
    it 'checks if merge request can be merged' do
808
      allow(subject).to receive(:mergeable_ci_state?) { true }
809 810 811 812 813 814 815 816 817
      expect(subject).to receive(:check_if_can_be_merged)

      subject.mergeable?
    end

    context 'when not open' do
      before { subject.close }

      it 'returns false' do
818
        expect(subject.mergeable_state?).to be_falsey
819 820 821 822 823 824 825
      end
    end

    context 'when working in progress' do
      before { subject.title = 'WIP MR' }

      it 'returns false' do
826
        expect(subject.mergeable_state?).to be_falsey
827 828 829 830 831 832 833
      end
    end

    context 'when broken' do
      before { allow(subject).to receive(:broken?) { true } }

      it 'returns false' do
834
        expect(subject.mergeable_state?).to be_falsey
835 836 837 838
      end
    end

    context 'when failed' do
R
Rémy Coutable 已提交
839
      context 'when #mergeable_ci_state? is false' do
840
        before do
841
          allow(subject).to receive(:mergeable_ci_state?) { false }
842 843 844 845
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
846 847
        end
      end
848

R
Rémy Coutable 已提交
849
      context 'when #mergeable_discussions_state? is false' do
850 851 852 853 854 855 856 857
        before do
          allow(subject).to receive(:mergeable_discussions_state?) { false }
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
        end
      end
858 859 860
    end
  end

861
  describe '#mergeable_ci_state?' do
862
    let(:project) { create(:empty_project, only_allow_merge_if_build_succeeds: true) }
R
Rémy Coutable 已提交
863
    let(:pipeline) { create(:ci_empty_pipeline) }
864 865 866

    subject { build(:merge_request, target_project: project) }

867
    context 'when it is only allowed to merge when build is green' do
R
Rémy Coutable 已提交
868
      context 'and a failed pipeline is associated' do
869
        before do
870
          pipeline.update(status: 'failed')
871
          allow(subject).to receive(:head_pipeline) { pipeline }
872
        end
873

874
        it { expect(subject.mergeable_ci_state?).to be_falsey }
875 876
      end

877 878 879
      context 'and a successful pipeline is associated' do
        before do
          pipeline.update(status: 'success')
880
          allow(subject).to receive(:head_pipeline) { pipeline }
881 882 883 884 885 886 887 888
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

      context 'and a skipped pipeline is associated' do
        before do
          pipeline.update(status: 'skipped')
889
          allow(subject).to receive(:head_pipeline) { pipeline }
890 891 892 893 894
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
895
      context 'when no pipeline is associated' do
896
        before do
897
          allow(subject).to receive(:head_pipeline) { nil }
898 899 900
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
901 902 903
      end
    end

904
    context 'when merges are not restricted to green builds' do
905 906
      subject { build(:merge_request, target_project: build(:empty_project, only_allow_merge_if_build_succeeds: false)) }

R
Rémy Coutable 已提交
907
      context 'and a failed pipeline is associated' do
908
        before do
R
Rémy Coutable 已提交
909
          pipeline.statuses << create(:commit_status, status: 'failed', project: project)
910
          allow(subject).to receive(:head_pipeline) { pipeline }
911 912 913 914 915
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
916
      context 'when no pipeline is associated' do
917
        before do
918
          allow(subject).to receive(:head_pipeline) { nil }
919 920 921
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
922 923 924
      end
    end
  end
925

926
  describe '#mergeable_discussions_state?' do
R
Rémy Coutable 已提交
927
    let(:merge_request) { create(:merge_request_with_diff_notes, source_project: project) }
928

R
Rémy Coutable 已提交
929 930
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == true' do
      let(:project) { create(:project, only_allow_merge_if_all_discussions_are_resolved: true) }
931

R
Rémy Coutable 已提交
932
      context 'with all discussions resolved' do
933
        before do
R
Rémy Coutable 已提交
934
          merge_request.discussions.each { |d| d.resolve!(merge_request.author) }
935 936 937
        end

        it 'returns true' do
R
Rémy Coutable 已提交
938
          expect(merge_request.mergeable_discussions_state?).to be_truthy
939 940 941
        end
      end

R
Rémy Coutable 已提交
942
      context 'with unresolved discussions' do
943
        before do
R
Rémy Coutable 已提交
944
          merge_request.discussions.each(&:unresolve!)
945 946 947
        end

        it 'returns false' do
R
Rémy Coutable 已提交
948
          expect(merge_request.mergeable_discussions_state?).to be_falsey
949 950
        end
      end
951 952 953 954 955 956 957 958 959 960

      context 'with no discussions' do
        before do
          merge_request.notes.destroy_all
        end

        it 'returns true' do
          expect(merge_request.mergeable_discussions_state?).to be_truthy
        end
      end
961 962
    end

R
Rémy Coutable 已提交
963 964
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == false' do
      let(:project) { create(:project, only_allow_merge_if_all_discussions_are_resolved: false) }
965

R
Rémy Coutable 已提交
966
      context 'with unresolved discussions' do
967
        before do
R
Rémy Coutable 已提交
968
          merge_request.discussions.each(&:unresolve!)
969 970 971
        end

        it 'returns true' do
R
Rémy Coutable 已提交
972
          expect(merge_request.mergeable_discussions_state?).to be_truthy
973 974 975 976 977 978
        end
      end
    end
  end

  describe "#environments" do
Z
Z.J. van de Weg 已提交
979 980 981
    let(:project)       { create(:project) }
    let(:merge_request) { create(:merge_request, source_project: project) }

982 983
    context 'with multiple environments' do
      let(:environments) { create_list(:environment, 3, project: project) }
984

985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000
      before do
        create(:deployment, environment: environments.first, ref: 'master', sha: project.commit('master').id)
        create(:deployment, environment: environments.second, ref: 'feature', sha: project.commit('feature').id)
      end

      it 'selects deployed environments' do
        expect(merge_request.environments).to contain_exactly(environments.first)
      end
    end

    context 'with environments on source project' do
      let(:source_project) do
        create(:project) do |fork_project|
          fork_project.create_forked_project_link(forked_to_project_id: fork_project.id, forked_from_project_id: project.id)
        end
      end
K
Kamil Trzcinski 已提交
1001

1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028
      let(:merge_request) do
        create(:merge_request,
               source_project: source_project, source_branch: 'feature',
               target_project: project)
      end

      let(:source_environment) { create(:environment, project: source_project) }

      before do
        create(:deployment, environment: source_environment, ref: 'feature', sha: merge_request.diff_head_sha)
      end

      it 'selects deployed environments' do
        expect(merge_request.environments).to contain_exactly(source_environment)
      end

      context 'with environments on target project' do
        let(:target_environment) { create(:environment, project: project) }

        before do
          create(:deployment, environment: target_environment, tag: true, sha: merge_request.diff_head_sha)
        end

        it 'selects deployed environments' do
          expect(merge_request.environments).to contain_exactly(source_environment, target_environment)
        end
      end
1029 1030 1031 1032 1033 1034 1035 1036 1037 1038
    end

    context 'without a diff_head_commit' do
      before do
        expect(merge_request).to receive(:diff_head_commit).and_return(nil)
      end

      it 'returns an empty array' do
        expect(merge_request.environments).to be_empty
      end
Z
Z.J. van de Weg 已提交
1039 1040 1041
    end
  end

1042 1043 1044 1045 1046
  describe "#reload_diff" do
    let(:note) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject) }

    let(:commit) { subject.project.commit(sample_commit.id) }

1047
    it "does not change existing merge request diff" do
1048
      expect(subject.merge_request_diff).not_to receive(:save_git_content)
1049 1050 1051
      subject.reload_diff
    end

1052 1053 1054 1055
    it "creates new merge request diff" do
      expect { subject.reload_diff }.to change { subject.merge_request_diffs.count }.by(1)
    end

1056 1057 1058 1059 1060 1061
    it "executs diff cache service" do
      expect_any_instance_of(MergeRequests::MergeRequestDiffCacheService).to receive(:execute).with(subject)

      subject.reload_diff
    end

1062 1063 1064 1065
    it "updates diff note positions" do
      old_diff_refs = subject.diff_refs

      # Update merge_request_diff so that #diff_refs will return commit.diff_refs
1066 1067 1068 1069 1070 1071
      allow(subject).to receive(:create_merge_request_diff) do
        subject.merge_request_diffs.create(
          base_commit_sha: commit.parent_id,
          start_commit_sha: commit.parent_id,
          head_commit_sha: commit.sha
        )
1072 1073

        subject.merge_request_diff(true)
1074 1075 1076 1077 1078 1079 1080 1081 1082 1083
      end

      expect(Notes::DiffPositionUpdateService).to receive(:new).with(
        subject.project,
        nil,
        old_diff_refs: old_diff_refs,
        new_diff_refs: commit.diff_refs,
        paths: note.position.paths
      ).and_call_original

1084
      expect_any_instance_of(Notes::DiffPositionUpdateService).to receive(:execute).with(note)
1085 1086 1087 1088 1089
      expect_any_instance_of(DiffNote).to receive(:save).once

      subject.reload_diff
    end
  end
1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103

  describe '#branch_merge_base_commit' do
    context 'source and target branch exist' do
      it { expect(subject.branch_merge_base_commit.sha).to eq('ae73cb07c9eeaf35924a10f713b364d32b2dd34f') }
      it { expect(subject.branch_merge_base_commit).to be_a(Commit) }
    end

    context 'when the target branch does not exist' do
      before do
        subject.project.repository.raw_repository.delete_branch(subject.target_branch)
      end

      it 'returns nil' do
        expect(subject.branch_merge_base_commit).to be_nil
1104 1105 1106 1107
      end
    end
  end

1108
  describe "#diff_sha_refs" do
1109 1110 1111 1112 1113 1114 1115 1116
    context "with diffs" do
      subject { create(:merge_request, :with_diffs) }

      it "does not touch the repository" do
        subject # Instantiate the object

        expect_any_instance_of(Repository).not_to receive(:commit)

1117
        subject.diff_sha_refs
1118 1119 1120 1121 1122 1123 1124 1125 1126
      end

      it "returns expected diff_refs" do
        expected_diff_refs = Gitlab::Diff::DiffRefs.new(
          base_sha:  subject.merge_request_diff.base_commit_sha,
          start_sha: subject.merge_request_diff.start_commit_sha,
          head_sha:  subject.merge_request_diff.head_commit_sha
        )

1127
        expect(subject.diff_sha_refs).to eq(expected_diff_refs)
1128 1129 1130
      end
    end
  end
1131 1132 1133 1134 1135 1136 1137

  context "discussion status" do
    let(:first_discussion) { Discussion.new([create(:diff_note_on_merge_request)]) }
    let(:second_discussion) { Discussion.new([create(:diff_note_on_merge_request)]) }
    let(:third_discussion) { Discussion.new([create(:diff_note_on_merge_request)]) }

    before do
1138
      allow(subject).to receive(:diff_discussions).and_return([first_discussion, second_discussion, third_discussion])
1139 1140
    end

1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180
    describe '#resolvable_discussions' do
      before do
        allow(first_discussion).to receive(:to_be_resolved?).and_return(true)
        allow(second_discussion).to receive(:to_be_resolved?).and_return(false)
        allow(third_discussion).to receive(:to_be_resolved?).and_return(false)
      end

      it 'includes only discussions that need to be resolved' do
        expect(subject.resolvable_discussions).to eq([first_discussion])
      end
    end

    describe '#discussions_can_be_resolved_by? user' do
      let(:user) { build(:user) }

      context 'all discussions can be resolved by the user' do
        before do
          allow(first_discussion).to receive(:can_resolve?).with(user).and_return(true)
          allow(second_discussion).to receive(:can_resolve?).with(user).and_return(true)
          allow(third_discussion).to receive(:can_resolve?).with(user).and_return(true)
        end

        it 'allows a user to resolve the discussions' do
          expect(subject.discussions_can_be_resolved_by?(user)).to be(true)
        end
      end

      context 'one discussion cannot be resolved by the user' do
        before do
          allow(first_discussion).to receive(:can_resolve?).with(user).and_return(true)
          allow(second_discussion).to receive(:can_resolve?).with(user).and_return(true)
          allow(third_discussion).to receive(:can_resolve?).with(user).and_return(false)
        end

        it 'allows a user to resolve the discussions' do
          expect(subject.discussions_can_be_resolved_by?(user)).to be(false)
        end
      end
    end

1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261
    describe "#discussions_resolvable?" do
      context "when all discussions are unresolvable" do
        before do
          allow(first_discussion).to receive(:resolvable?).and_return(false)
          allow(second_discussion).to receive(:resolvable?).and_return(false)
          allow(third_discussion).to receive(:resolvable?).and_return(false)
        end

        it "returns false" do
          expect(subject.discussions_resolvable?).to be false
        end
      end

      context "when some discussions are unresolvable and some discussions are resolvable" do
        before do
          allow(first_discussion).to receive(:resolvable?).and_return(true)
          allow(second_discussion).to receive(:resolvable?).and_return(false)
          allow(third_discussion).to receive(:resolvable?).and_return(true)
        end

        it "returns true" do
          expect(subject.discussions_resolvable?).to be true
        end
      end

      context "when all discussions are resolvable" do
        before do
          allow(first_discussion).to receive(:resolvable?).and_return(true)
          allow(second_discussion).to receive(:resolvable?).and_return(true)
          allow(third_discussion).to receive(:resolvable?).and_return(true)
        end

        it "returns true" do
          expect(subject.discussions_resolvable?).to be true
        end
      end
    end

    describe "#discussions_resolved?" do
      context "when discussions are not resolvable" do
        before do
          allow(subject).to receive(:discussions_resolvable?).and_return(false)
        end

        it "returns false" do
          expect(subject.discussions_resolved?).to be false
        end
      end

      context "when discussions are resolvable" do
        before do
          allow(subject).to receive(:discussions_resolvable?).and_return(true)

          allow(first_discussion).to receive(:resolvable?).and_return(true)
          allow(second_discussion).to receive(:resolvable?).and_return(false)
          allow(third_discussion).to receive(:resolvable?).and_return(true)
        end

        context "when all resolvable discussions are resolved" do
          before do
            allow(first_discussion).to receive(:resolved?).and_return(true)
            allow(third_discussion).to receive(:resolved?).and_return(true)
          end

          it "returns true" do
            expect(subject.discussions_resolved?).to be true
          end
        end

        context "when some resolvable discussions are not resolved" do
          before do
            allow(first_discussion).to receive(:resolved?).and_return(true)
            allow(third_discussion).to receive(:resolved?).and_return(false)
          end

          it "returns false" do
            expect(subject.discussions_resolved?).to be false
          end
        end
      end
    end
1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305

    describe "#discussions_to_be_resolved?" do
      context "when discussions are not resolvable" do
        before do
          allow(subject).to receive(:discussions_resolvable?).and_return(false)
        end

        it "returns false" do
          expect(subject.discussions_to_be_resolved?).to be false
        end
      end

      context "when discussions are resolvable" do
        before do
          allow(subject).to receive(:discussions_resolvable?).and_return(true)

          allow(first_discussion).to receive(:resolvable?).and_return(true)
          allow(second_discussion).to receive(:resolvable?).and_return(false)
          allow(third_discussion).to receive(:resolvable?).and_return(true)
        end

        context "when all resolvable discussions are resolved" do
          before do
            allow(first_discussion).to receive(:resolved?).and_return(true)
            allow(third_discussion).to receive(:resolved?).and_return(true)
          end

          it "returns false" do
            expect(subject.discussions_to_be_resolved?).to be false
          end
        end

        context "when some resolvable discussions are not resolved" do
          before do
            allow(first_discussion).to receive(:resolved?).and_return(true)
            allow(third_discussion).to receive(:resolved?).and_return(false)
          end

          it "returns true" do
            expect(subject.discussions_to_be_resolved?).to be true
          end
        end
      end
    end
1306
  end
S
Sean McGivern 已提交
1307

1308
  describe '#conflicts_can_be_resolved_in_ui?' do
S
Sean McGivern 已提交
1309 1310 1311 1312 1313 1314 1315 1316 1317 1318
    def create_merge_request(source_branch)
      create(:merge_request, source_branch: source_branch, target_branch: 'conflict-start') do |mr|
        mr.mark_as_unmergeable
      end
    end

    it 'returns a falsey value when the MR can be merged without conflicts' do
      merge_request = create_merge_request('master')
      merge_request.mark_as_mergeable

1319
      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
S
Sean McGivern 已提交
1320 1321
    end

1322 1323 1324 1325 1326 1327
    it 'returns a falsey value when the MR is marked as having conflicts, but has none' do
      merge_request = create_merge_request('master')

      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
    end

1328 1329 1330 1331 1332 1333 1334
    it 'returns a falsey value when the MR has a missing ref after a force push' do
      merge_request = create_merge_request('conflict-resolvable')
      allow(merge_request.conflicts).to receive(:merge_index).and_raise(Rugged::OdbError)

      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
    end

S
Sean McGivern 已提交
1335 1336 1337 1338
    it 'returns a falsey value when the MR does not support new diff notes' do
      merge_request = create_merge_request('conflict-resolvable')
      merge_request.merge_request_diff.update_attributes(start_commit_sha: nil)

1339
      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
S
Sean McGivern 已提交
1340 1341 1342 1343 1344
    end

    it 'returns a falsey value when the conflicts contain a large file' do
      merge_request = create_merge_request('conflict-too-large')

1345
      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
S
Sean McGivern 已提交
1346 1347 1348 1349 1350
    end

    it 'returns a falsey value when the conflicts contain a binary file' do
      merge_request = create_merge_request('conflict-binary-file')

1351
      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
S
Sean McGivern 已提交
1352 1353 1354 1355 1356
    end

    it 'returns a falsey value when the conflicts contain a file edited in one branch and deleted in another' do
      merge_request = create_merge_request('conflict-missing-side')

1357
      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_falsey
S
Sean McGivern 已提交
1358 1359 1360 1361 1362
    end

    it 'returns a truthy value when the conflicts are resolvable in the UI' do
      merge_request = create_merge_request('conflict-resolvable')

1363
      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_truthy
S
Sean McGivern 已提交
1364
    end
S
Sean McGivern 已提交
1365 1366 1367 1368 1369 1370

    it 'returns a truthy value when the conflicts have to be resolved in an editor' do
      merge_request = create_merge_request('conflict-contains-conflict-markers')

      expect(merge_request.conflicts_can_be_resolved_in_ui?).to be_truthy
    end
S
Sean McGivern 已提交
1371
  end
1372

1373
  describe "#source_project_missing?" do
1374 1375 1376 1377 1378
    let(:project)      { create(:project) }
    let(:fork_project) { create(:project, forked_from_project: project) }
    let(:user)         { create(:user) }
    let(:unlink_project) { Projects::UnlinkForkService.new(fork_project, user) }

K
Katarzyna Kobierska 已提交
1379
    context "when the fork exists" do
1380 1381 1382 1383 1384 1385
      let(:merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

1386
      it { expect(merge_request.source_project_missing?).to be_falsey }
1387 1388
    end

K
Katarzyna Kobierska 已提交
1389
    context "when the source project is the same as the target project" do
1390 1391
      let(:merge_request) { create(:merge_request, source_project: project) }

1392
      it { expect(merge_request.source_project_missing?).to be_falsey }
1393 1394
    end

K
Katarzyna Kobierska 已提交
1395
    context "when the fork does not exist" do
1396 1397 1398 1399 1400 1401
      let(:merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1402
      it "returns true" do
1403 1404 1405
        unlink_project.execute
        merge_request.reload

1406
        expect(merge_request.source_project_missing?).to be_truthy
1407 1408 1409 1410 1411 1412 1413 1414 1415 1416
      end
    end
  end

  describe "#closed_without_fork?" do
    let(:project)      { create(:project) }
    let(:fork_project) { create(:project, forked_from_project: project) }
    let(:user)         { create(:user) }
    let(:unlink_project) { Projects::UnlinkForkService.new(fork_project, user) }

K
Katarzyna Kobierska 已提交
1417
    context "when the merge request is closed" do
1418 1419 1420 1421 1422 1423
      let(:closed_merge_request) do
        create(:closed_merge_request,
          source_project: fork_project,
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1424
      it "returns false if the fork exist" do
1425 1426 1427
        expect(closed_merge_request.closed_without_fork?).to be_falsey
      end

K
Katarzyna Kobierska 已提交
1428
      it "returns true if the fork does not exist" do
1429 1430 1431 1432 1433 1434
        unlink_project.execute
        closed_merge_request.reload

        expect(closed_merge_request.closed_without_fork?).to be_truthy
      end
    end
K
Katarzyna Kobierska 已提交
1435

K
Katarzyna Kobierska 已提交
1436
    context "when the merge request is open" do
K
Katarzyna Kobierska 已提交
1437 1438 1439 1440 1441 1442 1443 1444 1445 1446
      let(:open_merge_request) do
        create(:merge_request,
          source_project: fork_project,
          target_project: project)
      end

      it "returns false" do
        expect(open_merge_request.closed_without_fork?).to be_falsey
      end
    end
1447
  end
1448

1449
  describe '#reopenable?' do
K
Katarzyna Kobierska 已提交
1450 1451 1452
    context 'when the merge request is closed' do
      it 'returns true' do
        subject.close
K
Katarzyna Kobierska 已提交
1453

1454
        expect(subject.reopenable?).to be_truthy
K
Katarzyna Kobierska 已提交
1455 1456 1457 1458 1459
      end

      context 'forked project' do
        let(:project)      { create(:project) }
        let(:user)         { create(:user) }
1460
        let(:fork_project) { create(:project, forked_from_project: project, namespace: user.namespace) }
1461 1462

        let!(:merge_request) do
K
Katarzyna Kobierska 已提交
1463 1464 1465 1466 1467 1468 1469 1470
          create(:closed_merge_request,
            source_project: fork_project,
            target_project: project)
        end

        it 'returns false if unforked' do
          Projects::UnlinkForkService.new(fork_project, user).execute

1471
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1472 1473 1474
        end

        it 'returns false if the source project is deleted' do
1475
          Projects::DestroyService.new(fork_project, user).execute
K
Katarzyna Kobierska 已提交
1476

1477
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1478 1479
        end

K
Katarzyna Kobierska 已提交
1480
        it 'returns false if the merge request is merged' do
K
Katarzyna Kobierska 已提交
1481 1482
          merge_request.update_attributes(state: 'merged')

1483
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1484 1485
        end
      end
K
Katarzyna Kobierska 已提交
1486 1487
    end

K
Katarzyna Kobierska 已提交
1488
    context 'when the merge request is opened' do
K
Katarzyna Kobierska 已提交
1489
      it 'returns false' do
1490
        expect(subject.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1491
      end
K
Katarzyna Kobierska 已提交
1492 1493
    end
  end
1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515

  describe '#has_commits?' do
    before do
      allow(subject.merge_request_diff).to receive(:commits_count).
        and_return(2)
    end

    it 'returns true when merge request diff has commits' do
      expect(subject.has_commits?).to be_truthy
    end
  end

  describe '#has_no_commits?' do
    before do
      allow(subject.merge_request_diff).to receive(:commits_count).
        and_return(0)
    end

    it 'returns true when merge request diff has 0 commits' do
      expect(subject.has_no_commits?).to be_truthy
    end
  end
D
Dmitriy Zaporozhets 已提交
1516
end