merge_request_spec.rb 68.9 KB
Newer Older
D
Dmitriy Zaporozhets 已提交
1 2
require 'spec_helper'

3
describe MergeRequest do
4
  include RepoHelpers
B
Bob Van Landuyt 已提交
5
  include ProjectForksHelper
6

7 8
  subject { create(:merge_request) }

R
Robert Speicher 已提交
9
  describe 'associations' do
10 11
    it { is_expected.to belong_to(:target_project).class_name('Project') }
    it { is_expected.to belong_to(:source_project).class_name('Project') }
12
    it { is_expected.to belong_to(:merge_user).class_name("User") }
13
    it { is_expected.to belong_to(:assignee) }
14
    it { is_expected.to have_many(:merge_request_diffs) }
R
Robert Speicher 已提交
15 16
  end

17 18 19 20 21 22 23 24 25 26 27
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(InternalId) }
    it { is_expected.to include_module(Issuable) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(Taskable) }
  end

  describe 'validation' do
28 29
    it { is_expected.to validate_presence_of(:target_branch) }
    it { is_expected.to validate_presence_of(:source_branch) }
Z
Zeger-Jan van de Weg 已提交
30

31
    context "Validation of merge user with Merge When Pipeline Succeeds" do
Z
Zeger-Jan van de Weg 已提交
32 33 34 35 36
      it "allows user to be nil when the feature is disabled" do
        expect(subject).to be_valid
      end

      it "is invalid without merge user" do
J
James Lopez 已提交
37
        subject.merge_when_pipeline_succeeds = true
Z
Zeger-Jan van de Weg 已提交
38 39 40 41
        expect(subject).not_to be_valid
      end

      it "is valid with merge user" do
J
James Lopez 已提交
42
        subject.merge_when_pipeline_succeeds = true
Z
Zeger-Jan van de Weg 已提交
43 44 45 46 47
        subject.merge_user = build(:user)

        expect(subject).to be_valid
      end
    end
48 49 50

    context 'for forks' do
      let(:project) { create(:project) }
B
Bob Van Landuyt 已提交
51 52
      let(:fork1) { fork_project(project) }
      let(:fork2) { fork_project(project) }
53 54 55 56 57 58 59 60

      it 'allows merge requests for sibling-forks' do
        subject.source_project = fork1
        subject.target_project = fork2

        expect(subject).to be_valid
      end
    end
D
Dmitriy Zaporozhets 已提交
61 62
  end

63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81
  describe 'callbacks' do
    describe '#ensure_merge_request_metrics' do
      it 'creates metrics after saving' do
        merge_request = create(:merge_request)

        expect(merge_request.metrics).to be_persisted
        expect(MergeRequest::Metrics.count).to eq(1)
      end

      it 'does not duplicate metrics for a merge request' do
        merge_request = create(:merge_request)

        merge_request.mark_as_merged!

        expect(MergeRequest::Metrics.count).to eq(1)
      end
    end
  end

R
Robert Speicher 已提交
82
  describe 'respond to' do
83 84 85
    it { is_expected.to respond_to(:unchecked?) }
    it { is_expected.to respond_to(:can_be_merged?) }
    it { is_expected.to respond_to(:cannot_be_merged?) }
86
    it { is_expected.to respond_to(:merge_params) }
J
James Lopez 已提交
87
    it { is_expected.to respond_to(:merge_when_pipeline_succeeds) }
88
  end
A
Andrey Kumanyaev 已提交
89

90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122
  describe '.by_commit_sha' do
    subject(:by_commit_sha) { described_class.by_commit_sha(sha) }

    let!(:merge_request) { create(:merge_request, :with_diffs) }

    context 'with sha contained in latest merge request diff' do
      let(:sha) { 'b83d6e391c22777fca1ed3012fce84f633d7fed0' }

      it 'returns merge requests' do
        expect(by_commit_sha).to eq([merge_request])
      end
    end

    context 'with sha contained not in latest merge request diff' do
      let(:sha) { 'b83d6e391c22777fca1ed3012fce84f633d7fed0' }

      it 'returns empty requests' do
        latest_merge_request_diff = merge_request.merge_request_diffs.create
        latest_merge_request_diff.merge_request_diff_commits.where(sha: 'b83d6e391c22777fca1ed3012fce84f633d7fed0').delete_all

        expect(by_commit_sha).to be_empty
      end
    end

    context 'with sha not contained in' do
      let(:sha) { 'b83d6e3' }

      it 'returns empty result' do
        expect(by_commit_sha).to be_empty
      end
    end
  end

123 124 125 126 127 128
  describe '.in_projects' do
    it 'returns the merge requests for a set of projects' do
      expect(described_class.in_projects(Project.all)).to eq([subject])
    end
  end

129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165
  describe '.set_latest_merge_request_diff_ids!' do
    def create_merge_request_with_diffs(source_branch, diffs: 2)
      params = {
        target_project: project,
        target_branch: 'master',
        source_project: project,
        source_branch: source_branch
      }

      create(:merge_request, params).tap do |mr|
        diffs.times { mr.merge_request_diffs.create }
      end
    end

    let(:project) { create(:project) }

    it 'sets IDs for merge requests, whether they are already set or not' do
      merge_requests = [
        create_merge_request_with_diffs('feature'),
        create_merge_request_with_diffs('feature-conflict'),
        create_merge_request_with_diffs('wip', diffs: 0),
        create_merge_request_with_diffs('csv')
      ]

      merge_requests.take(2).each do |merge_request|
        merge_request.update_column(:latest_merge_request_diff_id, nil)
      end

      expected = merge_requests.map do |merge_request|
        merge_request.merge_request_diffs.maximum(:id)
      end

      expect { project.merge_requests.set_latest_merge_request_diff_ids! }
        .to change { merge_requests.map { |mr| mr.reload.latest_merge_request_diff_id } }.to(expected)
    end
  end

166
  describe '#target_branch_sha' do
167
    let(:project) { create(:project, :repository) }
168

169
    subject { create(:merge_request, source_project: project, target_project: project) }
170

171
    context 'when the target branch does not exist' do
172
      before do
173
        project.repository.rm_branch(subject.author, subject.target_branch)
174
        subject.clear_memoized_shas
175
      end
176 177

      it 'returns nil' do
178
        expect(subject.target_branch_sha).to be_nil
179 180
      end
    end
181 182 183 184 185 186

    it 'returns memoized value' do
      subject.target_branch_sha = '8ffb3c15a5475e59ae909384297fede4badcb4c7'

      expect(subject.target_branch_sha).to eq '8ffb3c15a5475e59ae909384297fede4badcb4c7'
    end
187 188
  end

189 190 191 192 193
  describe '#card_attributes' do
    it 'includes the author name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignee).and_return(nil)

194 195
      expect(subject.card_attributes)
        .to eq({ 'Author' => 'Robert', 'Assignee' => nil })
196 197 198 199 200 201
    end

    it 'includes the assignee name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignee).and_return(double(name: 'Douwe'))

202 203
      expect(subject.card_attributes)
        .to eq({ 'Author' => 'Robert', 'Assignee' => 'Douwe' })
204 205 206
    end
  end

207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222
  describe '#assignee_ids' do
    it 'returns an array of the assigned user id' do
      subject.assignee_id = 123

      expect(subject.assignee_ids).to eq([123])
    end
  end

  describe '#assignee_ids=' do
    it 'sets assignee_id to the last id in the array' do
      subject.assignee_ids = [123, 456]

      expect(subject.assignee_id).to eq(456)
    end
  end

223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242
  describe '#assignee_or_author?' do
    let(:user) { create(:user) }

    it 'returns true for a user that is assigned to a merge request' do
      subject.assignee = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns true for a user that is the author of a merge request' do
      subject.author = user

      expect(subject.assignee_or_author?(user)).to eq(true)
    end

    it 'returns false for a user that is not the assignee or author' do
      expect(subject.assignee_or_author?(user)).to eq(false)
    end
  end

243 244
  describe '#cache_merge_request_closes_issues!' do
    before do
245
      subject.project.add_developer(subject.author)
246 247 248 249 250 251 252 253
      subject.target_branch = subject.project.default_branch
    end

    it 'caches closed issues' do
      issue  = create :issue, project: subject.project
      commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
      allow(subject).to receive(:commits).and_return([commit])

254
      expect { subject.cache_merge_request_closes_issues!(subject.author) }.to change(subject.merge_requests_closing_issues, :count).by(1)
255 256
    end

257 258 259 260
    context 'when both internal and external issue trackers are enabled' do
      before do
        subject.project.has_external_issue_tracker = true
        subject.project.save!
261
        create(:jira_service, project: subject.project)
262 263 264 265 266 267
      end

      it 'does not cache issues from external trackers' do
        issue  = ExternalIssue.new('JIRA-123', subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])
268

269
        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to raise_error
270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305
        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
      end

      it 'caches an internal issue' do
        issue  = create(:issue, project: subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }
          .to change(subject.merge_requests_closing_issues, :count).by(1)
      end
    end

    context 'when only external issue tracker enabled' do
      before do
        subject.project.has_external_issue_tracker = true
        subject.project.issues_enabled = false
        subject.project.save!
      end

      it 'does not cache issues from external trackers' do
        issue  = ExternalIssue.new('JIRA-123', subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to change(subject.merge_requests_closing_issues, :count)
      end

      it 'does not cache an internal issue' do
        issue  = create(:issue, project: subject.project)
        commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
        allow(subject).to receive(:commits).and_return([commit])

        expect { subject.cache_merge_request_closes_issues!(subject.author) }
          .not_to change(subject.merge_requests_closing_issues, :count)
      end
306 307 308
    end
  end

309
  describe '#source_branch_sha' do
310
    let(:last_branch_commit) { subject.source_project.repository.commit(Gitlab::Git::BRANCH_REF_PREFIX + subject.source_branch) }
311 312 313 314

    context 'with diffs' do
      subject { create(:merge_request, :with_diffs) }
      it 'returns the sha of the source branch last commit' do
315
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
316 317 318
      end
    end

319 320 321
    context 'without diffs' do
      subject { create(:merge_request, :without_diffs) }
      it 'returns the sha of the source branch last commit' do
322
        expect(subject.source_branch_sha).to eq(last_branch_commit.sha)
323
      end
324 325 326 327 328 329 330 331 332 333 334 335 336 337 338

      context 'when there is a tag name matching the branch name' do
        let(:tag_name) { subject.source_branch }

        it 'returns the sha of the source branch last commit' do
          subject.source_project.repository.add_tag(subject.author,
                                                    tag_name,
                                                    subject.target_branch_sha,
                                                    'Add a tag')

          expect(subject.source_branch_sha).to eq(last_branch_commit.sha)

          subject.source_project.repository.rm_tag(subject.author, tag_name)
        end
      end
339 340
    end

341 342 343
    context 'when the merge request is being created' do
      subject { build(:merge_request, source_branch: nil, compare_commits: []) }
      it 'returns nil' do
344
        expect(subject.source_branch_sha).to be_nil
345 346
      end
    end
347 348 349 350 351 352

    it 'returns memoized value' do
      subject.source_branch_sha = '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'

      expect(subject.source_branch_sha).to eq '2e5d3239642f9161dcbbc4b70a211a68e5e45e2b'
    end
353 354
  end

355
  describe '#to_reference' do
356
    let(:project) { build(:project, name: 'sample-project') }
357 358
    let(:merge_request) { build(:merge_request, target_project: project, iid: 1) }

359
    it 'returns a String reference to the object' do
360
      expect(merge_request.to_reference).to eq "!1"
361 362 363
    end

    it 'supports a cross-project reference' do
364
      another_project = build(:project, name: 'another-project', namespace: project.namespace)
365
      expect(merge_request.to_reference(another_project)).to eq "sample-project!1"
366
    end
367 368

    it 'returns a String reference with the full path' do
369
      expect(merge_request.to_reference(full: true)).to eq(project.full_path + '!1')
370
    end
371
  end
372

373
  describe '#raw_diffs' do
S
Sean McGivern 已提交
374 375 376 377 378 379 380
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
        merge_request.merge_request_diff = MergeRequestDiff.new

381
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(options)
S
Sean McGivern 已提交
382

383 384 385 386 387 388 389 390 391 392 393 394 395 396 397
        merge_request.raw_diffs(options)
      end
    end

    context 'when there are no MR diffs' do
      it 'delegates to the compare object' do
        merge_request.compare = double(:compare)

        expect(merge_request.compare).to receive(:raw_diffs).with(options)

        merge_request.raw_diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
398 399 400 401 402 403
  describe '#diffs' do
    let(:merge_request) { build(:merge_request) }
    let(:options) { { paths: ['a/b', 'b/a', 'c/*'] } }

    context 'when there are MR diffs' do
      it 'delegates to the MR diffs' do
404
        merge_request.save
S
Sean McGivern 已提交
405

406
        expect(merge_request.merge_request_diff).to receive(:raw_diffs).with(hash_including(options))
S
Sean McGivern 已提交
407 408 409 410 411 412

        merge_request.diffs(options)
      end
    end

    context 'when there are no MR diffs' do
413
      it 'delegates to the compare object, setting expanded: true' do
S
Sean McGivern 已提交
414 415
        merge_request.compare = double(:compare)

416
        expect(merge_request.compare).to receive(:diffs).with(options.merge(expanded: true))
S
Sean McGivern 已提交
417 418 419 420 421 422

        merge_request.diffs(options)
      end
    end
  end

S
Sean McGivern 已提交
423 424 425 426 427 428
  describe '#diff_size' do
    let(:merge_request) do
      build(:merge_request, source_branch: 'expand-collapse-files', target_branch: 'master')
    end

    context 'when there are MR diffs' do
429
      it 'returns the correct count' do
S
Sean McGivern 已提交
430
        merge_request.save
431 432

        expect(merge_request.diff_size).to eq('105')
S
Sean McGivern 已提交
433 434
      end

435 436 437 438 439
      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        merge_request.save

        expect(merge_request.diff_size).to eq('2+')
S
Sean McGivern 已提交
440 441 442
      end

      it 'does not perform highlighting' do
443 444
        merge_request.save

S
Sean McGivern 已提交
445 446 447 448 449 450 451
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end

    context 'when there are no MR diffs' do
452
      def set_compare(merge_request)
S
Sean McGivern 已提交
453 454 455 456 457 458 459 460 461 462
        merge_request.compare = CompareService.new(
          merge_request.source_project,
          merge_request.source_branch
        ).execute(
          merge_request.target_project,
          merge_request.target_branch
        )
      end

      it 'returns the correct count' do
463 464 465 466 467 468 469 470 471 472
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('105')
      end

      it 'returns the correct overflow count' do
        allow(Commit).to receive(:max_diff_options).and_return(max_files: 2)
        set_compare(merge_request)

        expect(merge_request.diff_size).to eq('2+')
S
Sean McGivern 已提交
473 474 475
      end

      it 'does not perform highlighting' do
476 477
        set_compare(merge_request)

S
Sean McGivern 已提交
478 479 480 481 482 483 484
        expect(Gitlab::Diff::Highlight).not_to receive(:new)

        merge_request.diff_size
      end
    end
  end

485
  describe "#related_notes" do
486
    let!(:merge_request) { create(:merge_request) }
487 488

    before do
489
      allow(merge_request).to receive(:commits) { [merge_request.source_project.repository.commit] }
490 491
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.project)
D
Dmitriy Zaporozhets 已提交
492
      create(:note, noteable: merge_request, project: merge_request.project)
493 494
    end

495
    it "includes notes for commits" do
496
      expect(merge_request.commits).not_to be_empty
497
      expect(merge_request.related_notes.count).to eq(2)
498
    end
499

500
    it "includes notes for commits from target project as well" do
501 502 503
      create(:note_on_commit, commit_id: merge_request.commits.first.id,
                              project: merge_request.target_project)

504
      expect(merge_request.commits).not_to be_empty
505
      expect(merge_request.related_notes.count).to eq(3)
506
    end
507
  end
508

I
Izaak Alpert 已提交
509 510
  describe '#for_fork?' do
    it 'returns true if the merge request is for a fork' do
511 512
      subject.source_project = build_stubbed(:project, namespace: create(:group))
      subject.target_project = build_stubbed(:project, namespace: create(:group))
I
Izaak Alpert 已提交
513

514
      expect(subject.for_fork?).to be_truthy
I
Izaak Alpert 已提交
515
    end
D
Dmitriy Zaporozhets 已提交
516

I
Izaak Alpert 已提交
517
    it 'returns false if is not for a fork' do
518
      expect(subject.for_fork?).to be_falsey
I
Izaak Alpert 已提交
519 520 521
    end
  end

522
  describe '#closes_issues' do
523 524
    let(:issue0) { create :issue, project: subject.project }
    let(:issue1) { create :issue, project: subject.project }
525 526 527 528

    let(:commit0) { double('commit0', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit1) { double('commit1', safe_message: "Fixes #{issue0.to_reference}") }
    let(:commit2) { double('commit2', safe_message: "Fixes #{issue1.to_reference}") }
529 530

    before do
531
      subject.project.add_developer(subject.author)
532
      allow(subject).to receive(:commits).and_return([commit0, commit1, commit2])
533 534
    end

535
    it 'accesses the set of issues that will be closed on acceptance' do
536 537
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
538

539
      closed = subject.closes_issues
540

541 542
      expect(closed).to include(issue0, issue1)
    end
543

544 545 546
    it 'only lists issues as to be closed if it targets the default branch' do
      allow(subject.project).to receive(:default_branch).and_return('master')
      subject.target_branch = 'something-else'
547

548
      expect(subject.closes_issues).to be_empty
549
    end
550
  end
551

552
  describe '#issues_mentioned_but_not_closing' do
553 554 555 556
    let(:closing_issue) { create :issue, project: subject.project }
    let(:mentioned_issue) { create :issue, project: subject.project }

    let(:commit) { double('commit', safe_message: "Fixes #{closing_issue.to_reference}") }
557

558
    it 'detects issues mentioned in description but not closed' do
559
      subject.project.add_developer(subject.author)
560
      subject.description = "Is related to #{mentioned_issue.to_reference} and #{closing_issue.to_reference}"
561

562
      allow(subject).to receive(:commits).and_return([commit])
563 564
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
565

566
      expect(subject.issues_mentioned_but_not_closing(subject.author)).to match_array([mentioned_issue])
567
    end
568 569 570

    context 'when the project has an external issue tracker' do
      before do
571
        subject.project.add_developer(subject.author)
572 573 574 575 576 577 578 579 580 581 582 583 584
        commit = double(:commit, safe_message: 'Fixes TEST-3')

        create(:jira_service, project: subject.project)

        allow(subject).to receive(:commits).and_return([commit])
        allow(subject).to receive(:description).and_return('Is related to TEST-2 and TEST-3')
        allow(subject.project).to receive(:default_branch).and_return(subject.target_branch)
      end

      it 'detects issues mentioned in description but not closed' do
        expect(subject.issues_mentioned_but_not_closing(subject.author).map(&:to_s)).to match_array(['TEST-2'])
      end
    end
585 586
  end

587
  describe "#work_in_progress?" do
588 589 590
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "detects the '#{wip_prefix}' prefix" do
        subject.title = "#{wip_prefix}#{subject.title}"
591
        expect(subject.work_in_progress?).to eq true
592
      end
T
Ted Hogan 已提交
593 594
    end

595 596
    it "doesn't detect WIP for words starting with WIP" do
      subject.title = "Wipwap #{subject.title}"
597
      expect(subject.work_in_progress?).to eq false
598 599
    end

600 601
    it "doesn't detect WIP for words containing with WIP" do
      subject.title = "WupWipwap #{subject.title}"
602
      expect(subject.work_in_progress?).to eq false
603 604
    end

605
    it "doesn't detect WIP by default" do
606
      expect(subject.work_in_progress?).to eq false
607 608 609
    end
  end

T
Thomas Balthazar 已提交
610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632
  describe "#wipless_title" do
    ['WIP ', 'WIP:', 'WIP: ', '[WIP]', '[WIP] ', ' [WIP] WIP [WIP] WIP: WIP '].each do |wip_prefix|
      it "removes the '#{wip_prefix}' prefix" do
        wipless_title = subject.title
        subject.title = "#{wip_prefix}#{subject.title}"

        expect(subject.wipless_title).to eq wipless_title
      end

      it "is satisfies the #work_in_progress? method" do
        subject.title = "#{wip_prefix}#{subject.title}"
        subject.title = subject.wipless_title

        expect(subject.work_in_progress?).to eq false
      end
    end
  end

  describe "#wip_title" do
    it "adds the WIP: prefix to the title" do
      wip_title = "WIP: #{subject.title}"

      expect(subject.wip_title).to eq wip_title
633
    end
T
Thomas Balthazar 已提交
634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649

    it "does not add the WIP: prefix multiple times" do
      wip_title = "WIP: #{subject.title}"
      subject.title = subject.wip_title
      subject.title = subject.wip_title

      expect(subject.wip_title).to eq wip_title
    end

    it "is satisfies the #work_in_progress? method" do
      subject.title = subject.wip_title

      expect(subject.work_in_progress?).to eq true
    end
  end

Z
Zeger-Jan van de Weg 已提交
650
  describe '#can_remove_source_branch?' do
651 652
    set(:user) { create(:user) }
    set(:merge_request) { create(:merge_request, :simple) }
653

654
    subject { merge_request }
655

656 657
    before do
      subject.source_project.add_master(user)
Z
Zeger-Jan van de Weg 已提交
658
    end
659

Z
Zeger-Jan van de Weg 已提交
660
    it "can't be removed when its a protected branch" do
661
      allow(ProtectedBranch).to receive(:protected?).and_return(true)
662

663 664 665
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

666
    it "can't remove a root ref" do
667
      subject.update(source_branch: 'master', target_branch: 'feature')
668 669 670 671

      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end

Z
Zeger-Jan van de Weg 已提交
672
    it "is unable to remove the source branch for a project the user cannot push to" do
673 674
      user2 = create(:user)

Z
Zeger-Jan van de Weg 已提交
675 676 677
      expect(subject.can_remove_source_branch?(user2)).to be_falsey
    end

678
    it "can be removed if the last commit is the head of the source branch" do
679
      allow(subject).to receive(:source_branch_head).and_return(subject.diff_head_commit)
680

Z
Zeger-Jan van de Weg 已提交
681
      expect(subject.can_remove_source_branch?(user)).to be_truthy
682
    end
683 684

    it "cannot be removed if the last commit is not also the head of the source branch" do
685
      subject.clear_memoized_shas
686 687
      subject.source_branch = "lfs"

688 689
      expect(subject.can_remove_source_branch?(user)).to be_falsey
    end
690 691
  end

692 693 694 695 696 697 698 699 700 701 702 703 704 705 706
  describe '#merge_commit_message' do
    it 'includes merge information as the title' do
      request = build(:merge_request, source_branch: 'source', target_branch: 'target')

      expect(request.merge_commit_message)
        .to match("Merge branch 'source' into 'target'\n\n")
    end

    it 'includes its title in the body' do
      request = build(:merge_request, title: 'Remove all technical debt')

      expect(request.merge_commit_message)
        .to match("Remove all technical debt\n\n")
    end

707
    it 'includes its closed issues in the body' do
708
      issue = create(:issue, project: subject.project)
709

710
      subject.project.add_developer(subject.author)
711
      subject.description = "This issue Closes #{issue.to_reference}"
712

713 714
      allow(subject.project).to receive(:default_branch)
        .and_return(subject.target_branch)
715 716

      expect(subject.merge_commit_message)
717
        .to match("Closes #{issue.to_reference}")
718 719 720 721 722 723
    end

    it 'includes its reference in the body' do
      request = build_stubbed(:merge_request)

      expect(request.merge_commit_message)
724
        .to match("See merge request #{request.to_reference(full: true)}")
725 726 727 728 729 730 731
    end

    it 'excludes multiple linebreak runs when description is blank' do
      request = build(:merge_request, title: 'Title', description: nil)

      expect(request.merge_commit_message).not_to match("Title\n\n\n\n")
    end
732 733 734 735 736 737 738 739 740 741 742 743 744 745

    it 'includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message(include_description: true))
        .to match("By removing all code\n\n")
    end

    it 'does not includes its description in the body' do
      request = build(:merge_request, description: 'By removing all code')

      expect(request.merge_commit_message)
        .not_to match("By removing all code\n\n")
    end
746 747
  end

J
James Lopez 已提交
748
  describe "#reset_merge_when_pipeline_succeeds" do
749
    let(:merge_if_green) do
J
James Lopez 已提交
750
      create :merge_request, merge_when_pipeline_succeeds: true, merge_user: create(:user),
751 752
                             merge_params: { "should_remove_source_branch" => "1", "commit_message" => "msg" }
    end
Z
Zeger-Jan van de Weg 已提交
753

754
    it "sets the item to false" do
J
James Lopez 已提交
755
      merge_if_green.reset_merge_when_pipeline_succeeds
756 757
      merge_if_green.reload

J
James Lopez 已提交
758
      expect(merge_if_green.merge_when_pipeline_succeeds).to be_falsey
759 760
      expect(merge_if_green.merge_params["should_remove_source_branch"]).to be_nil
      expect(merge_if_green.merge_params["commit_message"]).to be_nil
761 762 763
    end
  end

764
  describe '#hook_attrs' do
765 766 767 768 769 770 771 772
    it 'delegates to Gitlab::HookData::MergeRequestBuilder#build' do
      builder = double

      expect(Gitlab::HookData::MergeRequestBuilder)
        .to receive(:new).with(subject).and_return(builder)
      expect(builder).to receive(:build)

      subject.hook_attrs
773
    end
774 775 776
  end

  describe '#diverged_commits_count' do
777
    let(:project)      { create(:project, :repository) }
B
Bob Van Landuyt 已提交
778
    let(:forked_project) { fork_project(project, nil, repository: true) }
779

780
    context 'when the target branch does not exist anymore' do
781 782 783 784
      subject { create(:merge_request, source_project: project, target_project: project) }

      before do
        project.repository.raw_repository.delete_branch(subject.target_branch)
785
        subject.clear_memoized_shas
786
      end
787 788

      it 'does not crash' do
789
        expect { subject.diverged_commits_count }.not_to raise_error
790 791 792 793 794 795 796
      end

      it 'returns 0' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

797 798 799 800
    context 'diverged on same repository' do
      subject(:merge_request_with_divergence) { create(:merge_request, :diverged, source_project: project, target_project: project) }

      it 'counts commits that are on target branch but not on source branch' do
801
        expect(subject.diverged_commits_count).to eq(29)
802 803 804 805
      end
    end

    context 'diverged on fork' do
B
Bob Van Landuyt 已提交
806
      subject(:merge_request_fork_with_divergence) { create(:merge_request, :diverged, source_project: forked_project, target_project: project) }
807 808

      it 'counts commits that are on target branch but not on source branch' do
809
        expect(subject.diverged_commits_count).to eq(29)
810 811 812 813
      end
    end

    context 'rebased on fork' do
B
Bob Van Landuyt 已提交
814
      subject(:merge_request_rebased) { create(:merge_request, :rebased, source_project: forked_project, target_project: project) }
815 816 817 818 819 820 821

      it 'counts commits that are on target branch but not on source branch' do
        expect(subject.diverged_commits_count).to eq(0)
      end
    end

    describe 'caching' do
822
      before do
823 824 825 826
        allow(Rails).to receive(:cache).and_return(ActiveSupport::Cache::MemoryStore.new)
      end

      it 'caches the output' do
827 828 829
        expect(subject).to receive(:compute_diverged_commits_count)
          .once
          .and_return(2)
830 831 832 833 834 835

        subject.diverged_commits_count
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the source sha changes' do
836 837 838
        expect(subject).to receive(:compute_diverged_commits_count)
          .twice
          .and_return(2)
839 840

        subject.diverged_commits_count
841
        allow(subject).to receive(:source_branch_sha).and_return('123abc')
842 843 844 845
        subject.diverged_commits_count
      end

      it 'invalidates the cache when the target sha changes' do
846 847 848
        expect(subject).to receive(:compute_diverged_commits_count)
          .twice
          .and_return(2)
849 850

        subject.diverged_commits_count
851
        allow(subject).to receive(:target_branch_sha).and_return('123abc')
852 853 854
        subject.diverged_commits_count
      end
    end
855 856
  end

857
  it_behaves_like 'an editable mentionable' do
858
    subject { create(:merge_request, :simple) }
859

860
    let(:backref_text) { "merge request #{subject.to_reference}" }
861
    let(:set_mentionable_text) { ->(txt) { subject.description = txt } }
862
  end
V
Vinnie Okada 已提交
863 864

  it_behaves_like 'a Taskable' do
865
    subject { create :merge_request, :simple }
V
Vinnie Okada 已提交
866
  end
867

868
  describe '#commit_shas' do
869
    before do
870
      allow(subject.merge_request_diff).to receive(:commit_shas)
871
        .and_return(['sha1'])
872 873
    end

874
    it 'delegates to merge request diff' do
875
      expect(subject.commit_shas).to eq ['sha1']
876 877 878
    end
  end

879
  context 'head pipeline' do
880 881 882
    before do
      allow(subject).to receive(:diff_head_sha).and_return('lastsha')
    end
883

884 885 886
    describe '#head_pipeline' do
      it 'returns nil for MR without head_pipeline_id' do
        subject.update_attribute(:head_pipeline_id, nil)
887

888 889
        expect(subject.head_pipeline).to be_nil
      end
890 891 892 893 894 895 896 897

      context 'when the source project does not exist' do
        it 'returns nil' do
          allow(subject).to receive(:source_project).and_return(nil)

          expect(subject.head_pipeline).to be_nil
        end
      end
898 899
    end

900
    describe '#actual_head_pipeline' do
901 902 903
      it 'returns nil for MR with old pipeline' do
        pipeline = create(:ci_empty_pipeline, sha: 'notlatestsha')
        subject.update_attribute(:head_pipeline_id, pipeline.id)
904

905
        expect(subject.actual_head_pipeline).to be_nil
906
      end
907

908 909 910
      it 'returns the pipeline for MR with recent pipeline' do
        pipeline = create(:ci_empty_pipeline, sha: 'lastsha')
        subject.update_attribute(:head_pipeline_id, pipeline.id)
911

912 913
        expect(subject.actual_head_pipeline).to eq(subject.head_pipeline)
        expect(subject.actual_head_pipeline).to eq(pipeline)
914
      end
915 916 917 918 919 920

      it 'returns nil when source project does not exist' do
        allow(subject).to receive(:source_project).and_return(nil)

        expect(subject.actual_head_pipeline).to be_nil
      end
921 922
    end
  end
Y
Yorick Peterse 已提交
923

924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966
  describe '#has_ci?' do
    let(:merge_request) { build_stubbed(:merge_request) }

    context 'has ci' do
      it 'returns true if MR has head_pipeline_id and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { double }
        allow(merge_request).to receive(:has_no_commits?) { false }

        expect(merge_request.has_ci?).to be(true)
      end

      it 'returns true if MR has any pipeline and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:has_no_commits?) { false }
        allow(merge_request).to receive(:all_pipelines) { [double] }

        expect(merge_request.has_ci?).to be(true)
      end

      it 'returns true if MR has CI service and commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { double }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:has_no_commits?) { false }
        allow(merge_request).to receive(:all_pipelines) { [] }

        expect(merge_request.has_ci?).to be(true)
      end
    end

    context 'has no ci' do
      it 'returns false if MR has no CI service nor pipeline, and no commits' do
        allow(merge_request).to receive_message_chain(:source_project, :ci_service) { nil }
        allow(merge_request).to receive(:head_pipeline_id) { nil }
        allow(merge_request).to receive(:all_pipelines) { [] }
        allow(merge_request).to receive(:has_no_commits?) { true }

        expect(merge_request.has_ci?).to be(false)
      end
    end
  end

967
  describe '#all_pipelines' do
968
    shared_examples 'returning pipelines with proper ordering' do
969
      let!(:all_pipelines) do
970
        subject.all_commit_shas.map do |sha|
971 972 973 974
          create(:ci_empty_pipeline,
                 project: subject.source_project,
                 sha: sha,
                 ref: subject.source_branch)
975 976 977 978 979
        end
      end

      it 'returns all pipelines' do
        expect(subject.all_pipelines).not_to be_empty
980
        expect(subject.all_pipelines).to eq(all_pipelines.reverse)
981
      end
982 983
    end

984 985 986 987 988 989
    context 'with single merge_request_diffs' do
      it_behaves_like 'returning pipelines with proper ordering'
    end

    context 'with multiple irrelevant merge_request_diffs' do
      before do
990
        subject.update(target_branch: 'v1.0.0')
991 992 993
      end

      it_behaves_like 'returning pipelines with proper ordering'
994
    end
995 996

    context 'with unsaved merge request' do
997
      subject { build(:merge_request) }
998 999 1000

      let!(:pipeline) do
        create(:ci_empty_pipeline,
1001
               project: subject.project,
1002 1003
               sha: subject.diff_head_sha,
               ref: subject.source_branch)
1004
      end
1005 1006 1007 1008 1009

      it 'returns pipelines from diff_head_sha' do
        expect(subject.all_pipelines).to contain_exactly(pipeline)
      end
    end
1010 1011
  end

1012
  describe '#all_commit_shas' do
1013
    context 'when merge request is persisted' do
1014
      let(:all_commit_shas) do
1015 1016
        subject.merge_request_diffs.flat_map(&:commits).map(&:sha).uniq
      end
1017

1018
      shared_examples 'returning all SHA' do
1019
        it 'returns all SHAs from all merge_request_diffs' do
1020
          expect(subject.merge_request_diffs.size).to eq(2)
1021
          expect(subject.all_commit_shas).to match_array(all_commit_shas)
1022
        end
1023 1024
      end

1025 1026
      context 'with a completely different branch' do
        before do
1027
          subject.update(target_branch: 'csv')
1028 1029 1030
        end

        it_behaves_like 'returning all SHA'
1031 1032
      end

1033 1034
      context 'with a branch having no difference' do
        before do
1035
          subject.update(target_branch: 'branch-merged')
1036 1037 1038 1039 1040
          subject.reload # make sure commits were not cached
        end

        it_behaves_like 'returning all SHA'
      end
1041 1042
    end

1043 1044 1045 1046 1047 1048 1049 1050 1051
    context 'when merge request is not persisted' do
      context 'when compare commits are set in the service' do
        let(:commit) { spy('commit') }

        subject do
          build(:merge_request, compare_commits: [commit, commit])
        end

        it 'returns commits from compare commits temporary data' do
1052
          expect(subject.all_commit_shas).to eq [commit, commit]
1053
        end
1054 1055
      end

1056 1057 1058 1059
      context 'when compare commits are not set in the service' do
        subject { build(:merge_request) }

        it 'returns array with diff head sha element only' do
1060
          expect(subject.all_commit_shas).to eq [subject.diff_head_sha]
1061 1062
        end
      end
1063 1064 1065
    end
  end

1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089
  describe '#can_be_reverted?' do
    context 'when there is no merge_commit for the MR' do
      before do
        subject.metrics.update!(merged_at: Time.now.utc)
      end

      it 'returns false' do
        expect(subject.can_be_reverted?(nil)).to be_falsey
      end
    end

    context 'when the MR has been merged' do
      before do
        MergeRequests::MergeService
          .new(subject.target_project, subject.author)
          .execute(subject)
      end

      context 'when there is no revert commit' do
        it 'returns true' do
          expect(subject.can_be_reverted?(nil)).to be_truthy
        end
      end

1090 1091 1092 1093 1094 1095 1096 1097 1098 1099
      context 'when there is no merged_at for the MR' do
        before do
          subject.metrics.update!(merged_at: nil)
        end

        it 'returns true' do
          expect(subject.can_be_reverted?(nil)).to be_truthy
        end
      end

1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129
      context 'when there is a revert commit' do
        let(:current_user) { subject.author }
        let(:branch) { subject.target_branch }
        let(:project) { subject.target_project }

        let(:revert_commit_id) do
          params = {
            commit: subject.merge_commit,
            branch_name: branch,
            start_branch: branch
          }

          Commits::RevertService.new(project, current_user, params).execute[:result]
        end

        before do
          project.add_master(current_user)

          ProcessCommitWorker.new.perform(project.id,
                                          current_user.id,
                                          project.commit(revert_commit_id).to_hash,
                                          project.default_branch == branch)
        end

        context 'when the revert commit is mentioned in a note after the MR was merged' do
          it 'returns false' do
            expect(subject.can_be_reverted?(current_user)).to be_falsey
          end
        end

1130 1131 1132 1133 1134 1135 1136 1137 1138 1139
        context 'when there is no merged_at for the MR' do
          before do
            subject.metrics.update!(merged_at: nil)
          end

          it 'returns false' do
            expect(subject.can_be_reverted?(current_user)).to be_falsey
          end
        end

1140
        context 'when the revert commit is mentioned in a note just before the MR was merged' do
1141
          before do
1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152
            subject.notes.last.update!(created_at: subject.metrics.merged_at - 30.seconds)
          end

          it 'returns false' do
            expect(subject.can_be_reverted?(current_user)).to be_falsey
          end
        end

        context 'when the revert commit is mentioned in a note long before the MR was merged' do
          before do
            subject.notes.last.update!(created_at: subject.metrics.merged_at - 2.minutes)
1153 1154 1155 1156 1157 1158 1159 1160 1161 1162
          end

          it 'returns true' do
            expect(subject.can_be_reverted?(current_user)).to be_truthy
          end
        end
      end
    end
  end

Y
Yorick Peterse 已提交
1163
  describe '#participants' do
1164
    let(:project) { create(:project, :public) }
Y
Yorick Peterse 已提交
1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185

    let(:mr) do
      create(:merge_request, source_project: project, target_project: project)
    end

    let!(:note1) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'a')
    end

    let!(:note2) do
      create(:note_on_merge_request, noteable: mr, project: project, note: 'b')
    end

    it 'includes the merge request author' do
      expect(mr.participants).to include(mr.author)
    end

    it 'includes the authors of the notes' do
      expect(mr.participants).to include(note1.author, note2.author)
    end
  end
J
Josh Frye 已提交
1186 1187 1188 1189 1190 1191

  describe 'cached counts' do
    it 'updates when assignees change' do
      user1 = create(:user)
      user2 = create(:user)
      mr = create(:merge_request, assignee: user1)
1192 1193
      mr.project.add_developer(user1)
      mr.project.add_developer(user2)
J
Josh Frye 已提交
1194

1195 1196
      expect(user1.assigned_open_merge_requests_count).to eq(1)
      expect(user2.assigned_open_merge_requests_count).to eq(0)
J
Josh Frye 已提交
1197 1198 1199 1200

      mr.assignee = user2
      mr.save

1201 1202
      expect(user1.assigned_open_merge_requests_count).to eq(0)
      expect(user2.assigned_open_merge_requests_count).to eq(1)
J
Josh Frye 已提交
1203 1204
    end
  end
1205

1206
  describe '#merge_async' do
1207 1208 1209 1210 1211 1212 1213 1214 1215 1216
    it 'enqueues MergeWorker job and updates merge_jid' do
      merge_request = create(:merge_request)
      user_id = double(:user_id)
      params = double(:params)
      merge_jid = 'hash-123'

      expect(MergeWorker).to receive(:perform_async).with(merge_request.id, user_id, params) do
        merge_jid
      end

1217
      merge_request.merge_async(user_id, params)
1218 1219 1220 1221 1222

      expect(merge_request.reload.merge_jid).to eq(merge_jid)
    end
  end

1223
  describe '#check_if_can_be_merged' do
1224
    let(:project) { create(:project, only_allow_merge_if_pipeline_succeeds: true) }
1225 1226 1227 1228

    subject { create(:merge_request, source_project: project, merge_status: :unchecked) }

    context 'when it is not broken and has no conflicts' do
1229
      before do
1230
        allow(subject).to receive(:broken?) { false }
1231
        allow(project.repository).to receive(:can_be_merged?).and_return(true)
1232
      end
1233

1234
      it 'is marked as mergeable' do
1235 1236 1237 1238 1239
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('can_be_merged')
      end
    end

    context 'when broken' do
1240 1241 1242
      before do
        allow(subject).to receive(:broken?) { true }
      end
1243 1244 1245 1246 1247 1248 1249 1250 1251

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end

    context 'when it has conflicts' do
      before do
        allow(subject).to receive(:broken?) { false }
1252
        allow(project.repository).to receive(:can_be_merged?).and_return(false)
1253 1254 1255 1256 1257 1258 1259 1260 1261
      end

      it 'becomes unmergeable' do
        expect { subject.check_if_can_be_merged }.to change { subject.merge_status }.to('cannot_be_merged')
      end
    end
  end

  describe '#mergeable?' do
1262
    let(:project) { create(:project) }
1263 1264 1265

    subject { create(:merge_request, source_project: project) }

1266 1267
    it 'returns false if #mergeable_state? is false' do
      expect(subject).to receive(:mergeable_state?) { false }
1268

1269
      expect(subject.mergeable?).to be_falsey
1270 1271
    end

1272
    it 'return true if #mergeable_state? is true and the MR #can_be_merged? is true' do
1273 1274
      allow(subject).to receive(:mergeable_state?) { true }
      expect(subject).to receive(:check_if_can_be_merged)
1275
      expect(subject).to receive(:can_be_merged?) { true }
1276 1277 1278 1279 1280 1281

      expect(subject.mergeable?).to be_truthy
    end
  end

  describe '#mergeable_state?' do
1282
    let(:project) { create(:project, :repository) }
1283 1284 1285

    subject { create(:merge_request, source_project: project) }

1286
    it 'checks if merge request can be merged' do
1287
      allow(subject).to receive(:mergeable_ci_state?) { true }
1288 1289 1290 1291 1292 1293
      expect(subject).to receive(:check_if_can_be_merged)

      subject.mergeable?
    end

    context 'when not open' do
1294 1295 1296
      before do
        subject.close
      end
1297 1298

      it 'returns false' do
1299
        expect(subject.mergeable_state?).to be_falsey
1300 1301 1302 1303
      end
    end

    context 'when working in progress' do
1304 1305 1306
      before do
        subject.title = 'WIP MR'
      end
1307 1308

      it 'returns false' do
1309
        expect(subject.mergeable_state?).to be_falsey
1310 1311 1312 1313
      end
    end

    context 'when broken' do
1314 1315 1316
      before do
        allow(subject).to receive(:broken?) { true }
      end
1317 1318

      it 'returns false' do
1319
        expect(subject.mergeable_state?).to be_falsey
1320 1321 1322 1323
      end
    end

    context 'when failed' do
R
Rémy Coutable 已提交
1324
      context 'when #mergeable_ci_state? is false' do
1325
        before do
1326
          allow(subject).to receive(:mergeable_ci_state?) { false }
1327 1328 1329 1330
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
1331 1332
        end
      end
1333

R
Rémy Coutable 已提交
1334
      context 'when #mergeable_discussions_state? is false' do
1335 1336 1337 1338 1339 1340 1341
        before do
          allow(subject).to receive(:mergeable_discussions_state?) { false }
        end

        it 'returns false' do
          expect(subject.mergeable_state?).to be_falsey
        end
1342 1343 1344 1345

        it 'returns true when skipping discussions check' do
          expect(subject.mergeable_state?(skip_discussions_check: true)).to be(true)
        end
1346
      end
1347 1348 1349
    end
  end

1350
  describe '#mergeable_ci_state?' do
1351
    let(:project) { create(:project, only_allow_merge_if_pipeline_succeeds: true) }
R
Rémy Coutable 已提交
1352
    let(:pipeline) { create(:ci_empty_pipeline) }
1353 1354 1355

    subject { build(:merge_request, target_project: project) }

1356
    context 'when it is only allowed to merge when build is green' do
R
Rémy Coutable 已提交
1357
      context 'and a failed pipeline is associated' do
1358
        before do
1359
          pipeline.update(status: 'failed', sha: subject.diff_head_sha)
1360
          allow(subject).to receive(:head_pipeline) { pipeline }
1361
        end
1362

1363
        it { expect(subject.mergeable_ci_state?).to be_falsey }
1364 1365
      end

1366 1367
      context 'and a successful pipeline is associated' do
        before do
1368
          pipeline.update(status: 'success', sha: subject.diff_head_sha)
1369
          allow(subject).to receive(:head_pipeline) { pipeline }
1370 1371 1372 1373 1374 1375 1376
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

      context 'and a skipped pipeline is associated' do
        before do
1377
          pipeline.update(status: 'skipped', sha: subject.diff_head_sha)
1378
          allow(subject).to receive(:head_pipeline) { pipeline }
1379 1380 1381 1382 1383
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
1384
      context 'when no pipeline is associated' do
1385
        before do
1386
          allow(subject).to receive(:head_pipeline) { nil }
1387 1388 1389
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1390 1391 1392
      end
    end

1393
    context 'when merges are not restricted to green builds' do
1394
      subject { build(:merge_request, target_project: build(:project, only_allow_merge_if_pipeline_succeeds: false)) }
1395

R
Rémy Coutable 已提交
1396
      context 'and a failed pipeline is associated' do
1397
        before do
R
Rémy Coutable 已提交
1398
          pipeline.statuses << create(:commit_status, status: 'failed', project: project)
1399
          allow(subject).to receive(:head_pipeline) { pipeline }
1400 1401 1402 1403 1404
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
      end

R
Rémy Coutable 已提交
1405
      context 'when no pipeline is associated' do
1406
        before do
1407
          allow(subject).to receive(:head_pipeline) { nil }
1408 1409 1410
        end

        it { expect(subject.mergeable_ci_state?).to be_truthy }
1411 1412 1413
      end
    end
  end
1414

1415
  describe '#mergeable_discussions_state?' do
R
Rémy Coutable 已提交
1416
    let(:merge_request) { create(:merge_request_with_diff_notes, source_project: project) }
1417

R
Rémy Coutable 已提交
1418
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == true' do
1419
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: true) }
1420

R
Rémy Coutable 已提交
1421
      context 'with all discussions resolved' do
1422
        before do
R
Rémy Coutable 已提交
1423
          merge_request.discussions.each { |d| d.resolve!(merge_request.author) }
1424 1425 1426
        end

        it 'returns true' do
R
Rémy Coutable 已提交
1427
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1428 1429 1430
        end
      end

R
Rémy Coutable 已提交
1431
      context 'with unresolved discussions' do
1432
        before do
R
Rémy Coutable 已提交
1433
          merge_request.discussions.each(&:unresolve!)
1434 1435 1436
        end

        it 'returns false' do
R
Rémy Coutable 已提交
1437
          expect(merge_request.mergeable_discussions_state?).to be_falsey
1438 1439
        end
      end
1440 1441 1442 1443 1444 1445 1446 1447 1448 1449

      context 'with no discussions' do
        before do
          merge_request.notes.destroy_all
        end

        it 'returns true' do
          expect(merge_request.mergeable_discussions_state?).to be_truthy
        end
      end
1450 1451
    end

R
Rémy Coutable 已提交
1452
    context 'when project.only_allow_merge_if_all_discussions_are_resolved == false' do
1453
      let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: false) }
1454

R
Rémy Coutable 已提交
1455
      context 'with unresolved discussions' do
1456
        before do
R
Rémy Coutable 已提交
1457
          merge_request.discussions.each(&:unresolve!)
1458 1459 1460
        end

        it 'returns true' do
R
Rémy Coutable 已提交
1461
          expect(merge_request.mergeable_discussions_state?).to be_truthy
1462 1463 1464 1465 1466
        end
      end
    end
  end

D
Douwe Maan 已提交
1467
  describe "#environments_for" do
1468
    let(:project)       { create(:project, :repository) }
D
Douwe Maan 已提交
1469
    let(:user)          { project.creator }
Z
Z.J. van de Weg 已提交
1470 1471
    let(:merge_request) { create(:merge_request, source_project: project) }

D
Douwe Maan 已提交
1472 1473 1474 1475 1476
    before do
      merge_request.source_project.add_master(user)
      merge_request.target_project.add_master(user)
    end

1477 1478
    context 'with multiple environments' do
      let(:environments) { create_list(:environment, 3, project: project) }
1479

1480 1481 1482 1483 1484 1485
      before do
        create(:deployment, environment: environments.first, ref: 'master', sha: project.commit('master').id)
        create(:deployment, environment: environments.second, ref: 'feature', sha: project.commit('feature').id)
      end

      it 'selects deployed environments' do
D
Douwe Maan 已提交
1486
        expect(merge_request.environments_for(user)).to contain_exactly(environments.first)
1487 1488 1489 1490
      end
    end

    context 'with environments on source project' do
B
Bob Van Landuyt 已提交
1491
      let(:source_project) { fork_project(project, nil, repository: true) }
K
Kamil Trzcinski 已提交
1492

1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505
      let(:merge_request) do
        create(:merge_request,
               source_project: source_project, source_branch: 'feature',
               target_project: project)
      end

      let(:source_environment) { create(:environment, project: source_project) }

      before do
        create(:deployment, environment: source_environment, ref: 'feature', sha: merge_request.diff_head_sha)
      end

      it 'selects deployed environments' do
D
Douwe Maan 已提交
1506
        expect(merge_request.environments_for(user)).to contain_exactly(source_environment)
1507 1508 1509 1510 1511 1512 1513 1514 1515 1516
      end

      context 'with environments on target project' do
        let(:target_environment) { create(:environment, project: project) }

        before do
          create(:deployment, environment: target_environment, tag: true, sha: merge_request.diff_head_sha)
        end

        it 'selects deployed environments' do
D
Douwe Maan 已提交
1517
          expect(merge_request.environments_for(user)).to contain_exactly(source_environment, target_environment)
1518 1519
        end
      end
1520 1521 1522 1523 1524 1525 1526 1527
    end

    context 'without a diff_head_commit' do
      before do
        expect(merge_request).to receive(:diff_head_commit).and_return(nil)
      end

      it 'returns an empty array' do
D
Douwe Maan 已提交
1528
        expect(merge_request.environments_for(user)).to be_empty
1529
      end
Z
Z.J. van de Weg 已提交
1530 1531 1532
    end
  end

1533
  describe "#reload_diff" do
1534
    let(:discussion) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject).to_discussion }
1535 1536
    let(:commit) { subject.project.commit(sample_commit.id) }

1537
    it "does not change existing merge request diff" do
1538
      expect(subject.merge_request_diff).not_to receive(:save_git_content)
1539 1540 1541
      subject.reload_diff
    end

1542 1543 1544 1545
    it "creates new merge request diff" do
      expect { subject.reload_diff }.to change { subject.merge_request_diffs.count }.by(1)
    end

1546
    it "executes diff cache service" do
1547
      expect_any_instance_of(MergeRequests::MergeRequestDiffCacheService).to receive(:execute).with(subject, an_instance_of(MergeRequestDiff))
1548 1549 1550 1551

      subject.reload_diff
    end

1552 1553 1554 1555 1556
    it "calls update_diff_discussion_positions" do
      expect(subject).to receive(:update_diff_discussion_positions)

      subject.reload_diff
    end
1557 1558 1559 1560 1561 1562 1563 1564 1565 1566

    context 'when using the after_update hook to update' do
      context 'when the branches are updated' do
        it 'uses the new heads to generate the diff' do
          expect { subject.update!(source_branch: subject.target_branch, target_branch: subject.source_branch) }
            .to change { subject.merge_request_diff.start_commit_sha }
            .and change { subject.merge_request_diff.head_commit_sha }
        end
      end
    end
1567
  end
1568

1569 1570 1571 1572 1573 1574
  describe '#update_diff_discussion_positions' do
    let(:discussion) { create(:diff_note_on_merge_request, project: subject.project, noteable: subject).to_discussion }
    let(:commit) { subject.project.commit(sample_commit.id) }
    let(:old_diff_refs) { subject.diff_refs }

    before do
1575
      # Update merge_request_diff so that #diff_refs will return commit.diff_refs
1576 1577 1578 1579 1580 1581
      allow(subject).to receive(:create_merge_request_diff) do
        subject.merge_request_diffs.create(
          base_commit_sha: commit.parent_id,
          start_commit_sha: commit.parent_id,
          head_commit_sha: commit.sha
        )
1582 1583

        subject.merge_request_diff(true)
1584
      end
1585
    end
1586

1587
    it "updates diff discussion positions" do
1588
      expect(Discussions::UpdateDiffPositionService).to receive(:new).with(
1589
        subject.project,
1590
        subject.author,
1591 1592
        old_diff_refs: old_diff_refs,
        new_diff_refs: commit.diff_refs,
1593
        paths: discussion.position.paths
1594 1595
      ).and_call_original

1596
      expect_any_instance_of(Discussions::UpdateDiffPositionService).to receive(:execute).with(discussion).and_call_original
1597 1598
      expect_any_instance_of(DiffNote).to receive(:save).once

1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618
      subject.update_diff_discussion_positions(old_diff_refs: old_diff_refs,
                                               new_diff_refs: commit.diff_refs,
                                               current_user: subject.author)
    end

    context 'when resolve_outdated_diff_discussions is set' do
      before do
        discussion

        subject.project.update!(resolve_outdated_diff_discussions: true)
      end

      it 'calls MergeRequests::ResolvedDiscussionNotificationService' do
        expect_any_instance_of(MergeRequests::ResolvedDiscussionNotificationService)
          .to receive(:execute).with(subject)

        subject.update_diff_discussion_positions(old_diff_refs: old_diff_refs,
                                                 new_diff_refs: commit.diff_refs,
                                                 current_user: subject.author)
      end
1619 1620
    end
  end
1621 1622 1623 1624 1625 1626 1627 1628 1629

  describe '#branch_merge_base_commit' do
    context 'source and target branch exist' do
      it { expect(subject.branch_merge_base_commit.sha).to eq('ae73cb07c9eeaf35924a10f713b364d32b2dd34f') }
      it { expect(subject.branch_merge_base_commit).to be_a(Commit) }
    end

    context 'when the target branch does not exist' do
      before do
1630
        subject.project.repository.rm_branch(subject.author, subject.target_branch)
1631
        subject.clear_memoized_shas
1632 1633 1634 1635
      end

      it 'returns nil' do
        expect(subject.branch_merge_base_commit).to be_nil
1636 1637 1638 1639
      end
    end
  end

1640
  describe "#diff_refs" do
1641 1642 1643 1644 1645 1646 1647 1648
    context "with diffs" do
      subject { create(:merge_request, :with_diffs) }

      it "does not touch the repository" do
        subject # Instantiate the object

        expect_any_instance_of(Repository).not_to receive(:commit)

1649
        subject.diff_refs
1650 1651 1652 1653 1654 1655 1656 1657 1658
      end

      it "returns expected diff_refs" do
        expected_diff_refs = Gitlab::Diff::DiffRefs.new(
          base_sha:  subject.merge_request_diff.base_commit_sha,
          start_sha: subject.merge_request_diff.start_commit_sha,
          head_sha:  subject.merge_request_diff.head_commit_sha
        )

1659
        expect(subject.diff_refs).to eq(expected_diff_refs)
1660 1661 1662
      end
    end
  end
1663

1664
  describe "#source_project_missing?" do
1665
    let(:project)      { create(:project) }
B
Bob Van Landuyt 已提交
1666
    let(:forked_project) { fork_project(project) }
1667
    let(:user)         { create(:user) }
B
Bob Van Landuyt 已提交
1668
    let(:unlink_project) { Projects::UnlinkForkService.new(forked_project, user) }
1669

K
Katarzyna Kobierska 已提交
1670
    context "when the fork exists" do
1671 1672
      let(:merge_request) do
        create(:merge_request,
B
Bob Van Landuyt 已提交
1673
          source_project: forked_project,
1674 1675 1676
          target_project: project)
      end

1677
      it { expect(merge_request.source_project_missing?).to be_falsey }
1678 1679
    end

K
Katarzyna Kobierska 已提交
1680
    context "when the source project is the same as the target project" do
1681 1682
      let(:merge_request) { create(:merge_request, source_project: project) }

1683
      it { expect(merge_request.source_project_missing?).to be_falsey }
1684 1685
    end

K
Katarzyna Kobierska 已提交
1686
    context "when the fork does not exist" do
1687
      let!(:merge_request) do
1688
        create(:merge_request,
B
Bob Van Landuyt 已提交
1689
          source_project: forked_project,
1690 1691 1692
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1693
      it "returns true" do
1694 1695 1696
        unlink_project.execute
        merge_request.reload

1697
        expect(merge_request.source_project_missing?).to be_truthy
1698 1699 1700 1701
      end
    end
  end

1702
  describe '#merge_ongoing?' do
1703 1704 1705 1706 1707 1708
    it 'returns true when the merge request is locked' do
      merge_request = build_stubbed(:merge_request, state: :locked)

      expect(merge_request.merge_ongoing?).to be(true)
    end

1709
    it 'returns true when merge_id, MR is not merged and it has no running job' do
1710
      merge_request = build_stubbed(:merge_request, state: :open, merge_jid: 'foo')
1711
      allow(Gitlab::SidekiqStatus).to receive(:running?).with('foo') { true }
1712 1713 1714

      expect(merge_request.merge_ongoing?).to be(true)
    end
1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729

    it 'returns false when merge_jid is nil' do
      merge_request = build_stubbed(:merge_request, state: :open, merge_jid: nil)

      expect(merge_request.merge_ongoing?).to be(false)
    end

    it 'returns false if MR is merged' do
      merge_request = build_stubbed(:merge_request, state: :merged, merge_jid: 'foo')

      expect(merge_request.merge_ongoing?).to be(false)
    end

    it 'returns false if there is no merge job running' do
      merge_request = build_stubbed(:merge_request, state: :open, merge_jid: 'foo')
1730
      allow(Gitlab::SidekiqStatus).to receive(:running?).with('foo') { false }
1731 1732 1733

      expect(merge_request.merge_ongoing?).to be(false)
    end
1734 1735
  end

1736
  describe "#closed_without_fork?" do
1737
    let(:project)      { create(:project) }
B
Bob Van Landuyt 已提交
1738
    let(:forked_project) { fork_project(project) }
1739
    let(:user)         { create(:user) }
B
Bob Van Landuyt 已提交
1740
    let(:unlink_project) { Projects::UnlinkForkService.new(forked_project, user) }
1741

K
Katarzyna Kobierska 已提交
1742
    context "when the merge request is closed" do
1743 1744
      let(:closed_merge_request) do
        create(:closed_merge_request,
B
Bob Van Landuyt 已提交
1745
          source_project: forked_project,
1746 1747 1748
          target_project: project)
      end

K
Katarzyna Kobierska 已提交
1749
      it "returns false if the fork exist" do
1750 1751 1752
        expect(closed_merge_request.closed_without_fork?).to be_falsey
      end

K
Katarzyna Kobierska 已提交
1753
      it "returns true if the fork does not exist" do
1754 1755 1756 1757 1758 1759
        unlink_project.execute
        closed_merge_request.reload

        expect(closed_merge_request.closed_without_fork?).to be_truthy
      end
    end
K
Katarzyna Kobierska 已提交
1760

K
Katarzyna Kobierska 已提交
1761
    context "when the merge request is open" do
K
Katarzyna Kobierska 已提交
1762 1763
      let(:open_merge_request) do
        create(:merge_request,
B
Bob Van Landuyt 已提交
1764
          source_project: forked_project,
K
Katarzyna Kobierska 已提交
1765 1766 1767 1768 1769 1770 1771
          target_project: project)
      end

      it "returns false" do
        expect(open_merge_request.closed_without_fork?).to be_falsey
      end
    end
1772
  end
1773

1774
  describe '#reopenable?' do
K
Katarzyna Kobierska 已提交
1775 1776 1777
    context 'when the merge request is closed' do
      it 'returns true' do
        subject.close
K
Katarzyna Kobierska 已提交
1778

1779
        expect(subject.reopenable?).to be_truthy
K
Katarzyna Kobierska 已提交
1780 1781 1782
      end

      context 'forked project' do
B
Bob Van Landuyt 已提交
1783
        let(:project)      { create(:project, :public) }
K
Katarzyna Kobierska 已提交
1784
        let(:user)         { create(:user) }
B
Bob Van Landuyt 已提交
1785
        let(:forked_project) { fork_project(project, user) }
1786 1787

        let!(:merge_request) do
K
Katarzyna Kobierska 已提交
1788
          create(:closed_merge_request,
B
Bob Van Landuyt 已提交
1789
            source_project: forked_project,
K
Katarzyna Kobierska 已提交
1790 1791 1792 1793
            target_project: project)
        end

        it 'returns false if unforked' do
B
Bob Van Landuyt 已提交
1794
          Projects::UnlinkForkService.new(forked_project, user).execute
K
Katarzyna Kobierska 已提交
1795

1796
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1797 1798 1799
        end

        it 'returns false if the source project is deleted' do
B
Bob Van Landuyt 已提交
1800
          Projects::DestroyService.new(forked_project, user).execute
K
Katarzyna Kobierska 已提交
1801

1802
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1803 1804
        end

K
Katarzyna Kobierska 已提交
1805
        it 'returns false if the merge request is merged' do
K
Katarzyna Kobierska 已提交
1806 1807
          merge_request.update_attributes(state: 'merged')

1808
          expect(merge_request.reload.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1809 1810
        end
      end
K
Katarzyna Kobierska 已提交
1811 1812
    end

K
Katarzyna Kobierska 已提交
1813
    context 'when the merge request is opened' do
K
Katarzyna Kobierska 已提交
1814
      it 'returns false' do
1815
        expect(subject.reopenable?).to be_falsey
K
Katarzyna Kobierska 已提交
1816
      end
K
Katarzyna Kobierska 已提交
1817 1818
    end
  end
1819

1820
  describe '#mergeable_with_quick_action?' do
1821
    def create_pipeline(status)
F
Felipe Artur 已提交
1822
      pipeline = create(:ci_pipeline_with_one_job,
1823 1824 1825
        project: project,
        ref:     merge_request.source_branch,
        sha:     merge_request.diff_head_sha,
1826 1827
        status:  status,
        head_pipeline_of: merge_request)
F
Felipe Artur 已提交
1828 1829

      pipeline
1830 1831
    end

J
James Lopez 已提交
1832
    let(:project)       { create(:project, :public, :repository, only_allow_merge_if_pipeline_succeeds: true) }
1833 1834 1835 1836 1837 1838
    let(:developer)     { create(:user) }
    let(:user)          { create(:user) }
    let(:merge_request) { create(:merge_request, source_project: project) }
    let(:mr_sha)        { merge_request.diff_head_sha }

    before do
1839
      project.add_developer(developer)
1840 1841 1842 1843
    end

    context 'when autocomplete_precheck is set to true' do
      it 'is mergeable by developer' do
1844
        expect(merge_request.mergeable_with_quick_action?(developer, autocomplete_precheck: true)).to be_truthy
1845 1846 1847
      end

      it 'is not mergeable by normal user' do
1848
        expect(merge_request.mergeable_with_quick_action?(user, autocomplete_precheck: true)).to be_falsey
1849 1850 1851 1852 1853
      end
    end

    context 'when autocomplete_precheck is set to false' do
      it 'is mergeable by developer' do
1854
        expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1855 1856 1857
      end

      it 'is not mergeable by normal user' do
1858
        expect(merge_request.mergeable_with_quick_action?(user, last_diff_sha: mr_sha)).to be_falsey
1859 1860 1861 1862 1863 1864 1865 1866
      end

      context 'closed MR'  do
        before do
          merge_request.update_attribute(:state, :closed)
        end

        it 'is not mergeable' do
1867
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1868 1869 1870 1871 1872 1873 1874 1875 1876
        end
      end

      context 'MR with WIP'  do
        before do
          merge_request.update_attribute(:title, 'WIP: some MR')
        end

        it 'is not mergeable' do
1877
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1878 1879 1880 1881 1882
        end
      end

      context 'sha differs from the MR diff_head_sha'  do
        it 'is not mergeable' do
1883
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: 'some other sha')).to be_falsey
1884 1885 1886
        end
      end

J
Jarka Kadlecova 已提交
1887 1888
      context 'sha is not provided'  do
        it 'is not mergeable' do
1889
          expect(merge_request.mergeable_with_quick_action?(developer)).to be_falsey
J
Jarka Kadlecova 已提交
1890 1891 1892
        end
      end

1893 1894 1895 1896 1897 1898
      context 'with pipeline ok'  do
        before do
          create_pipeline(:success)
        end

        it 'is mergeable' do
1899
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1900 1901 1902 1903 1904 1905 1906 1907 1908
        end
      end

      context 'with failing pipeline'  do
        before do
          create_pipeline(:failed)
        end

        it 'is not mergeable' do
1909
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_falsey
1910 1911 1912 1913 1914
        end
      end

      context 'with running pipeline'  do
        before do
F
Felipe Artur 已提交
1915
          create_pipeline(:running)
1916 1917 1918
        end

        it 'is mergeable' do
1919
          expect(merge_request.mergeable_with_quick_action?(developer, last_diff_sha: mr_sha)).to be_truthy
1920 1921 1922 1923 1924
        end
      end
    end
  end

1925 1926
  describe '#has_commits?' do
    before do
1927 1928
      allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(2)
1929 1930 1931 1932 1933 1934 1935 1936 1937
    end

    it 'returns true when merge request diff has commits' do
      expect(subject.has_commits?).to be_truthy
    end
  end

  describe '#has_no_commits?' do
    before do
1938 1939
      allow(subject.merge_request_diff).to receive(:commits_count)
        .and_return(0)
1940 1941 1942 1943 1944 1945
    end

    it 'returns true when merge request diff has 0 commits' do
      expect(subject.has_no_commits?).to be_truthy
    end
  end
1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964

  describe '#merge_request_diff_for' do
    subject { create(:merge_request, importing: true) }
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'with diff refs' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff1.diff_refs)).to eq(merge_request_diff1)
      end
    end

    context 'with a commit SHA' do
      it 'returns the diffs' do
        expect(subject.merge_request_diff_for(merge_request_diff3.head_commit_sha)).to eq(merge_request_diff3)
      end
    end
  end
1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996

  describe '#version_params_for' do
    subject { create(:merge_request, importing: true) }
    let(:project) { subject.project }
    let!(:merge_request_diff1) { subject.merge_request_diffs.create(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
    let!(:merge_request_diff2) { subject.merge_request_diffs.create(head_commit_sha: nil) }
    let!(:merge_request_diff3) { subject.merge_request_diffs.create(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }

    context 'when the diff refs are for an older merge request version' do
      let(:diff_refs) { merge_request_diff1.diff_refs }

      it 'returns the diff ID for the version to show' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff1.id)
      end
    end

    context 'when the diff refs are for a comparison between merge request versions' do
      let(:diff_refs) { merge_request_diff3.compare_with(merge_request_diff1.head_commit_sha).diff_refs }

      it 'returns the diff ID and start sha of the versions to compare' do
        expect(subject.version_params_for(diff_refs)).to eq(diff_id: merge_request_diff3.id, start_sha: merge_request_diff1.head_commit_sha)
      end
    end

    context 'when the diff refs are not for a merge request version' do
      let(:diff_refs) { project.commit(sample_commit.id).diff_refs }

      it 'returns nil' do
        expect(subject.version_params_for(diff_refs)).to be_nil
      end
    end
  end
1997

1998
  describe '#fetch_ref!' do
M
micael.bergeron 已提交
1999
    it 'fetches the ref correctly' do
2000
      expect { subject.target_project.repository.delete_refs(subject.ref_path) }.not_to raise_error
2001

2002 2003
      subject.fetch_ref!
      expect(subject.target_project.repository.ref_exists?(subject.ref_path)).to be_truthy
2004 2005
    end
  end
2006 2007 2008 2009 2010 2011 2012 2013 2014

  describe 'removing a merge request' do
    it 'refreshes the number of open merge requests of the target project' do
      project = subject.target_project

      expect { subject.destroy }
        .to change { project.open_merge_requests_count }.from(1).to(0)
    end
  end
2015 2016 2017 2018

  it_behaves_like 'throttled touch' do
    subject { create(:merge_request, updated_at: 1.hour.ago) }
  end
2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034

  context 'state machine transitions' do
    describe '#unlock_mr' do
      subject { create(:merge_request, state: 'locked', merge_jid: 123) }

      it 'updates merge request head pipeline and sets merge_jid to nil' do
        pipeline = create(:ci_empty_pipeline, project: subject.project, ref: subject.source_branch, sha: subject.source_branch_sha)

        subject.unlock_mr

        subject.reload
        expect(subject.head_pipeline).to eq(pipeline)
        expect(subject.merge_jid).to be_nil
      end
    end
  end
2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046

  describe '#should_be_rebased?' do
    let(:project) { create(:project, :repository) }

    it 'returns false for the same source and target branches' do
      merge_request = create(:merge_request, source_project: project, target_project: project)

      expect(merge_request.should_be_rebased?).to be_falsey
    end
  end

  describe '#rebase_in_progress?' do
2047 2048 2049
    shared_examples 'checking whether a rebase is in progress' do
      let(:repo_path) { subject.source_project.repository.path }
      let(:rebase_path) { File.join(repo_path, "gitlab-worktree", "rebase-#{subject.id}") }
2050

2051 2052 2053
      before do
        system(*%W(#{Gitlab.config.git.bin_path} -C #{repo_path} worktree add --detach #{rebase_path} master))
      end
2054

2055 2056 2057
      it 'returns true when there is a current rebase directory' do
        expect(subject.rebase_in_progress?).to be_truthy
      end
2058

2059 2060
      it 'returns false when there is no rebase directory' do
        FileUtils.rm_rf(rebase_path)
2061

2062 2063 2064 2065 2066 2067
        expect(subject.rebase_in_progress?).to be_falsey
      end

      it 'returns false when the rebase directory has expired' do
        time = 20.minutes.ago.to_time
        File.utime(time, time, rebase_path)
2068

2069 2070
        expect(subject.rebase_in_progress?).to be_falsey
      end
2071

2072 2073 2074 2075 2076
      it 'returns false when the source project has been removed' do
        allow(subject).to receive(:source_project).and_return(nil)

        expect(subject.rebase_in_progress?).to be_falsey
      end
2077 2078
    end

2079 2080 2081
    context 'when Gitaly rebase_in_progress is enabled' do
      it_behaves_like 'checking whether a rebase is in progress'
    end
2082

2083 2084
    context 'when Gitaly rebase_in_progress is enabled', :disable_gitaly do
      it_behaves_like 'checking whether a rebase is in progress'
2085 2086
    end
  end
2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164

  describe '#allow_maintainer_to_push' do
    let(:merge_request) do
      build(:merge_request, source_branch: 'fixes', allow_maintainer_to_push: true)
    end

    it 'is false when pushing by a maintainer is not possible' do
      expect(merge_request).to receive(:maintainer_push_possible?) { false }

      expect(merge_request.allow_maintainer_to_push).to be_falsy
    end

    it 'is true when pushing by a maintainer is possible' do
      expect(merge_request).to receive(:maintainer_push_possible?) { true }

      expect(merge_request.allow_maintainer_to_push).to be_truthy
    end
  end

  describe '#maintainer_push_possible?' do
    let(:merge_request) do
      build(:merge_request, source_branch: 'fixes')
    end

    before do
      allow(ProtectedBranch).to receive(:protected?) { false }
    end

    it 'does not allow maintainer to push if the source project is the same as the target' do
      merge_request.target_project = merge_request.source_project = create(:project, :public)

      expect(merge_request.maintainer_push_possible?).to be_falsy
    end

    it 'allows maintainer to push when both source and target are public' do
      merge_request.target_project = build(:project, :public)
      merge_request.source_project = build(:project, :public)

      expect(merge_request.maintainer_push_possible?).to be_truthy
    end

    it 'is not available for protected branches' do
      merge_request.target_project = build(:project, :public)
      merge_request.source_project = build(:project, :public)

      expect(ProtectedBranch).to receive(:protected?)
                                   .with(merge_request.source_project, 'fixes')
                                   .and_return(true)

      expect(merge_request.maintainer_push_possible?).to be_falsy
    end
  end

  describe '#can_allow_maintainer_to_push?' do
    let(:target_project) { create(:project, :public) }
    let(:source_project) { fork_project(target_project) }
    let(:merge_request) do
      create(:merge_request,
             source_project: source_project,
             source_branch: 'fixes',
             target_project: target_project)
    end
    let(:user) { create(:user) }

    before do
      allow(merge_request).to receive(:maintainer_push_possible?) { true }
    end

    it 'is false if the user does not have push access to the source project' do
      expect(merge_request.can_allow_maintainer_to_push?(user)).to be_falsy
    end

    it 'is true when the user has push access to the source project' do
      source_project.add_developer(user)

      expect(merge_request.can_allow_maintainer_to_push?(user)).to be_truthy
    end
  end
D
Dmitriy Zaporozhets 已提交
2165
end