i915_gem_execbuffer.c 51.1 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
/*
 * Copyright © 2008,2010 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 *
 * Authors:
 *    Eric Anholt <eric@anholt.net>
 *    Chris Wilson <chris@chris-wilson.co.uk>
 *
 */

29 30 31 32
#include <linux/dma_remapping.h>
#include <linux/reservation.h>
#include <linux/uaccess.h>

33 34
#include <drm/drmP.h>
#include <drm/i915_drm.h>
35

36
#include "i915_drv.h"
37
#include "i915_gem_dmabuf.h"
38 39
#include "i915_trace.h"
#include "intel_drv.h"
40
#include "intel_frontbuffer.h"
41

42 43 44 45 46
#define  __EXEC_OBJECT_HAS_PIN		(1<<31)
#define  __EXEC_OBJECT_HAS_FENCE	(1<<30)
#define  __EXEC_OBJECT_NEEDS_MAP	(1<<29)
#define  __EXEC_OBJECT_NEEDS_BIAS	(1<<28)
#define  __EXEC_OBJECT_INTERNAL_FLAGS (0xf<<28) /* all of the above */
47 48

#define BATCH_OFFSET_BIAS (256*1024)
49

50 51 52
struct i915_execbuffer_params {
	struct drm_device               *dev;
	struct drm_file                 *file;
53 54 55
	struct i915_vma			*batch;
	u32				dispatch_flags;
	u32				args_batch_start_offset;
56 57 58 59 60
	struct intel_engine_cs          *engine;
	struct i915_gem_context         *ctx;
	struct drm_i915_gem_request     *request;
};

61 62
struct eb_vmas {
	struct list_head vmas;
63
	int and;
64
	union {
65
		struct i915_vma *lut[0];
66 67
		struct hlist_head buckets[0];
	};
68 69
};

70
static struct eb_vmas *
B
Ben Widawsky 已提交
71
eb_create(struct drm_i915_gem_execbuffer2 *args)
72
{
73
	struct eb_vmas *eb = NULL;
74 75

	if (args->flags & I915_EXEC_HANDLE_LUT) {
76
		unsigned size = args->buffer_count;
77 78
		size *= sizeof(struct i915_vma *);
		size += sizeof(struct eb_vmas);
79 80 81 82
		eb = kmalloc(size, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
	}

	if (eb == NULL) {
83 84
		unsigned size = args->buffer_count;
		unsigned count = PAGE_SIZE / sizeof(struct hlist_head) / 2;
L
Lauri Kasanen 已提交
85
		BUILD_BUG_ON_NOT_POWER_OF_2(PAGE_SIZE / sizeof(struct hlist_head));
86 87 88
		while (count > 2*size)
			count >>= 1;
		eb = kzalloc(count*sizeof(struct hlist_head) +
89
			     sizeof(struct eb_vmas),
90 91 92 93 94 95 96 97
			     GFP_TEMPORARY);
		if (eb == NULL)
			return eb;

		eb->and = count - 1;
	} else
		eb->and = -args->buffer_count;

98
	INIT_LIST_HEAD(&eb->vmas);
99 100 101 102
	return eb;
}

static void
103
eb_reset(struct eb_vmas *eb)
104
{
105 106
	if (eb->and >= 0)
		memset(eb->buckets, 0, (eb->and+1)*sizeof(struct hlist_head));
107 108
}

109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128
static struct i915_vma *
eb_get_batch(struct eb_vmas *eb)
{
	struct i915_vma *vma = list_entry(eb->vmas.prev, typeof(*vma), exec_list);

	/*
	 * SNA is doing fancy tricks with compressing batch buffers, which leads
	 * to negative relocation deltas. Usually that works out ok since the
	 * relocate address is still positive, except when the batch is placed
	 * very low in the GTT. Ensure this doesn't happen.
	 *
	 * Note that actual hangs have only been observed on gen7, but for
	 * paranoia do it everywhere.
	 */
	if ((vma->exec_entry->flags & EXEC_OBJECT_PINNED) == 0)
		vma->exec_entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

	return vma;
}

129
static int
130 131 132 133 134
eb_lookup_vmas(struct eb_vmas *eb,
	       struct drm_i915_gem_exec_object2 *exec,
	       const struct drm_i915_gem_execbuffer2 *args,
	       struct i915_address_space *vm,
	       struct drm_file *file)
135
{
136 137
	struct drm_i915_gem_object *obj;
	struct list_head objects;
138
	int i, ret;
139

140
	INIT_LIST_HEAD(&objects);
141
	spin_lock(&file->table_lock);
142 143
	/* Grab a reference to the object and release the lock so we can lookup
	 * or create the VMA without using GFP_ATOMIC */
144
	for (i = 0; i < args->buffer_count; i++) {
145 146 147 148 149
		obj = to_intel_bo(idr_find(&file->object_idr, exec[i].handle));
		if (obj == NULL) {
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Invalid object handle %d at index %d\n",
				   exec[i].handle, i);
150
			ret = -ENOENT;
151
			goto err;
152 153
		}

154
		if (!list_empty(&obj->obj_exec_link)) {
155 156 157
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Object %p [handle %d, index %d] appears more than once in object list\n",
				   obj, exec[i].handle, i);
158
			ret = -EINVAL;
159
			goto err;
160 161
		}

162
		i915_gem_object_get(obj);
163 164 165
		list_add_tail(&obj->obj_exec_link, &objects);
	}
	spin_unlock(&file->table_lock);
166

167
	i = 0;
168
	while (!list_empty(&objects)) {
169
		struct i915_vma *vma;
170

171 172 173 174
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);

175 176 177 178 179 180 181 182
		/*
		 * NOTE: We can leak any vmas created here when something fails
		 * later on. But that's no issue since vma_unbind can deal with
		 * vmas which are not actually bound. And since only
		 * lookup_or_create exists as an interface to get at the vma
		 * from the (obj, vm) we don't run the risk of creating
		 * duplicated vmas for the same vm.
		 */
183
		vma = i915_gem_obj_lookup_or_create_vma(obj, vm);
184 185 186
		if (IS_ERR(vma)) {
			DRM_DEBUG("Failed to lookup VMA\n");
			ret = PTR_ERR(vma);
187
			goto err;
188 189
		}

190
		/* Transfer ownership from the objects list to the vmas list. */
191
		list_add_tail(&vma->exec_list, &eb->vmas);
192
		list_del_init(&obj->obj_exec_link);
193 194

		vma->exec_entry = &exec[i];
195
		if (eb->and < 0) {
196
			eb->lut[i] = vma;
197 198
		} else {
			uint32_t handle = args->flags & I915_EXEC_HANDLE_LUT ? i : exec[i].handle;
199 200
			vma->exec_handle = handle;
			hlist_add_head(&vma->exec_node,
201 202
				       &eb->buckets[handle & eb->and]);
		}
203
		++i;
204 205
	}

206
	return 0;
207 208


209
err:
210 211 212 213 214
	while (!list_empty(&objects)) {
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);
		list_del_init(&obj->obj_exec_link);
215
		i915_gem_object_put(obj);
216
	}
217 218 219 220 221
	/*
	 * Objects already transfered to the vmas list will be unreferenced by
	 * eb_destroy.
	 */

222
	return ret;
223 224
}

225
static struct i915_vma *eb_get_vma(struct eb_vmas *eb, unsigned long handle)
226
{
227 228 229 230 231 232
	if (eb->and < 0) {
		if (handle >= -eb->and)
			return NULL;
		return eb->lut[handle];
	} else {
		struct hlist_head *head;
233
		struct i915_vma *vma;
234

235
		head = &eb->buckets[handle & eb->and];
236
		hlist_for_each_entry(vma, head, exec_node) {
237 238
			if (vma->exec_handle == handle)
				return vma;
239 240 241
		}
		return NULL;
	}
242 243
}

244 245 246 247 248 249 250 251 252 253 254 255 256 257 258
static void
i915_gem_execbuffer_unreserve_vma(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry;
	struct drm_i915_gem_object *obj = vma->obj;

	if (!drm_mm_node_allocated(&vma->node))
		return;

	entry = vma->exec_entry;

	if (entry->flags & __EXEC_OBJECT_HAS_FENCE)
		i915_gem_object_unpin_fence(obj);

	if (entry->flags & __EXEC_OBJECT_HAS_PIN)
259
		__i915_vma_unpin(vma);
260

C
Chris Wilson 已提交
261
	entry->flags &= ~(__EXEC_OBJECT_HAS_FENCE | __EXEC_OBJECT_HAS_PIN);
262 263 264 265
}

static void eb_destroy(struct eb_vmas *eb)
{
266 267
	while (!list_empty(&eb->vmas)) {
		struct i915_vma *vma;
268

269 270
		vma = list_first_entry(&eb->vmas,
				       struct i915_vma,
271
				       exec_list);
272
		list_del_init(&vma->exec_list);
273
		i915_gem_execbuffer_unreserve_vma(vma);
274
		i915_gem_object_put(vma->obj);
275
	}
276 277 278
	kfree(eb);
}

279 280
static inline int use_cpu_reloc(struct drm_i915_gem_object *obj)
{
281 282
	return (HAS_LLC(obj->base.dev) ||
		obj->base.write_domain == I915_GEM_DOMAIN_CPU ||
283 284 285
		obj->cache_level != I915_CACHE_NONE);
}

286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310
/* Used to convert any address to canonical form.
 * Starting from gen8, some commands (e.g. STATE_BASE_ADDRESS,
 * MI_LOAD_REGISTER_MEM and others, see Broadwell PRM Vol2a) require the
 * addresses to be in a canonical form:
 * "GraphicsAddress[63:48] are ignored by the HW and assumed to be in correct
 * canonical form [63:48] == [47]."
 */
#define GEN8_HIGH_ADDRESS_BIT 47
static inline uint64_t gen8_canonical_addr(uint64_t address)
{
	return sign_extend64(address, GEN8_HIGH_ADDRESS_BIT);
}

static inline uint64_t gen8_noncanonical_addr(uint64_t address)
{
	return address & ((1ULL << (GEN8_HIGH_ADDRESS_BIT + 1)) - 1);
}

static inline uint64_t
relocation_target(struct drm_i915_gem_relocation_entry *reloc,
		  uint64_t target_offset)
{
	return gen8_canonical_addr((int)reloc->delta + target_offset);
}

311 312
static int
relocate_entry_cpu(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
313 314
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
315
{
316
	struct drm_device *dev = obj->base.dev;
317
	uint32_t page_offset = offset_in_page(reloc->offset);
318
	uint64_t delta = relocation_target(reloc, target_offset);
319
	char *vaddr;
320
	int ret;
321

322
	ret = i915_gem_object_set_to_cpu_domain(obj, true);
323 324 325
	if (ret)
		return ret;

326
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
327
				reloc->offset >> PAGE_SHIFT));
B
Ben Widawsky 已提交
328
	*(uint32_t *)(vaddr + page_offset) = lower_32_bits(delta);
329 330 331 332 333 334

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
335
			vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
336 337 338
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

B
Ben Widawsky 已提交
339
		*(uint32_t *)(vaddr + page_offset) = upper_32_bits(delta);
340 341
	}

342 343 344 345 346 347 348
	kunmap_atomic(vaddr);

	return 0;
}

static int
relocate_entry_gtt(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
349 350
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
351 352
{
	struct drm_device *dev = obj->base.dev;
353 354
	struct drm_i915_private *dev_priv = to_i915(dev);
	struct i915_ggtt *ggtt = &dev_priv->ggtt;
355
	uint64_t delta = relocation_target(reloc, target_offset);
356
	uint64_t offset;
357
	void __iomem *reloc_page;
358
	int ret;
359 360 361 362 363 364 365 366 367 368

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

	ret = i915_gem_object_put_fence(obj);
	if (ret)
		return ret;

	/* Map the page containing the relocation we're going to perform.  */
369 370
	offset = i915_gem_obj_ggtt_offset(obj);
	offset += reloc->offset;
371
	reloc_page = io_mapping_map_atomic_wc(ggtt->mappable,
372 373
					      offset & PAGE_MASK);
	iowrite32(lower_32_bits(delta), reloc_page + offset_in_page(offset));
374 375

	if (INTEL_INFO(dev)->gen >= 8) {
376
		offset += sizeof(uint32_t);
377

378
		if (offset_in_page(offset) == 0) {
379
			io_mapping_unmap_atomic(reloc_page);
380
			reloc_page =
381
				io_mapping_map_atomic_wc(ggtt->mappable,
382
							 offset);
383 384
		}

385 386
		iowrite32(upper_32_bits(delta),
			  reloc_page + offset_in_page(offset));
387 388
	}

389 390 391 392 393
	io_mapping_unmap_atomic(reloc_page);

	return 0;
}

394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409
static void
clflush_write32(void *addr, uint32_t value)
{
	/* This is not a fast path, so KISS. */
	drm_clflush_virt_range(addr, sizeof(uint32_t));
	*(uint32_t *)addr = value;
	drm_clflush_virt_range(addr, sizeof(uint32_t));
}

static int
relocate_entry_clflush(struct drm_i915_gem_object *obj,
		       struct drm_i915_gem_relocation_entry *reloc,
		       uint64_t target_offset)
{
	struct drm_device *dev = obj->base.dev;
	uint32_t page_offset = offset_in_page(reloc->offset);
410
	uint64_t delta = relocation_target(reloc, target_offset);
411 412 413 414 415 416 417
	char *vaddr;
	int ret;

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

418
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
419 420 421 422 423 424 425 426
				reloc->offset >> PAGE_SHIFT));
	clflush_write32(vaddr + page_offset, lower_32_bits(delta));

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
427
			vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
428 429 430 431 432 433 434 435 436 437 438
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

		clflush_write32(vaddr + page_offset, upper_32_bits(delta));
	}

	kunmap_atomic(vaddr);

	return 0;
}

439 440
static bool object_is_idle(struct drm_i915_gem_object *obj)
{
441
	unsigned long active = i915_gem_object_get_active(obj);
442 443 444 445 446 447 448 449 450 451 452
	int idx;

	for_each_active(active, idx) {
		if (!i915_gem_active_is_idle(&obj->last_read[idx],
					     &obj->base.dev->struct_mutex))
			return false;
	}

	return true;
}

453 454
static int
i915_gem_execbuffer_relocate_entry(struct drm_i915_gem_object *obj,
455
				   struct eb_vmas *eb,
456
				   struct drm_i915_gem_relocation_entry *reloc)
457 458 459
{
	struct drm_device *dev = obj->base.dev;
	struct drm_gem_object *target_obj;
460
	struct drm_i915_gem_object *target_i915_obj;
461
	struct i915_vma *target_vma;
B
Ben Widawsky 已提交
462
	uint64_t target_offset;
463
	int ret;
464

465
	/* we've already hold a reference to all valid objects */
466 467
	target_vma = eb_get_vma(eb, reloc->target_handle);
	if (unlikely(target_vma == NULL))
468
		return -ENOENT;
469 470
	target_i915_obj = target_vma->obj;
	target_obj = &target_vma->obj->base;
471

472
	target_offset = gen8_canonical_addr(target_vma->node.start);
473

474 475 476 477
	/* Sandybridge PPGTT errata: We need a global gtt mapping for MI and
	 * pipe_control writes because the gpu doesn't properly redirect them
	 * through the ppgtt for non_secure batchbuffers. */
	if (unlikely(IS_GEN6(dev) &&
478
	    reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION)) {
479
		ret = i915_vma_bind(target_vma, target_i915_obj->cache_level,
480
				    PIN_GLOBAL);
481 482 483
		if (WARN_ONCE(ret, "Unexpected failure to bind target VMA!"))
			return ret;
	}
484

485
	/* Validate that the target is in a valid r/w GPU domain */
486
	if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) {
487
		DRM_DEBUG("reloc with multiple write domains: "
488 489 490 491 492 493
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
494
		return -EINVAL;
495
	}
496 497
	if (unlikely((reloc->write_domain | reloc->read_domains)
		     & ~I915_GEM_GPU_DOMAINS)) {
498
		DRM_DEBUG("reloc with read/write non-GPU domains: "
499 500 501 502 503 504
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
505
		return -EINVAL;
506 507 508 509 510 511 512 513 514
	}

	target_obj->pending_read_domains |= reloc->read_domains;
	target_obj->pending_write_domain |= reloc->write_domain;

	/* If the relocation already has the right value in it, no
	 * more work needs to be done.
	 */
	if (target_offset == reloc->presumed_offset)
515
		return 0;
516 517

	/* Check that the relocation address is valid... */
518 519
	if (unlikely(reloc->offset >
		obj->base.size - (INTEL_INFO(dev)->gen >= 8 ? 8 : 4))) {
520
		DRM_DEBUG("Relocation beyond object bounds: "
521 522 523 524
			  "obj %p target %d offset %d size %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  (int) obj->base.size);
525
		return -EINVAL;
526
	}
527
	if (unlikely(reloc->offset & 3)) {
528
		DRM_DEBUG("Relocation not 4-byte aligned: "
529 530 531
			  "obj %p target %d offset %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset);
532
		return -EINVAL;
533 534
	}

535
	/* We can't wait for rendering with pagefaults disabled */
536
	if (pagefault_disabled() && !object_is_idle(obj))
537 538
		return -EFAULT;

539
	if (use_cpu_reloc(obj))
B
Ben Widawsky 已提交
540
		ret = relocate_entry_cpu(obj, reloc, target_offset);
541
	else if (obj->map_and_fenceable)
B
Ben Widawsky 已提交
542
		ret = relocate_entry_gtt(obj, reloc, target_offset);
543
	else if (static_cpu_has(X86_FEATURE_CLFLUSH))
544 545 546 547 548
		ret = relocate_entry_clflush(obj, reloc, target_offset);
	else {
		WARN_ONCE(1, "Impossible case in relocation handling\n");
		ret = -ENODEV;
	}
549

550 551 552
	if (ret)
		return ret;

553 554 555
	/* and update the user's relocation entry */
	reloc->presumed_offset = target_offset;

556
	return 0;
557 558 559
}

static int
560 561
i915_gem_execbuffer_relocate_vma(struct i915_vma *vma,
				 struct eb_vmas *eb)
562
{
563 564
#define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry))
	struct drm_i915_gem_relocation_entry stack_reloc[N_RELOC(512)];
565
	struct drm_i915_gem_relocation_entry __user *user_relocs;
566
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
567
	int remain, ret;
568

569
	user_relocs = u64_to_user_ptr(entry->relocs_ptr);
570

571 572 573 574 575 576 577 578 579
	remain = entry->relocation_count;
	while (remain) {
		struct drm_i915_gem_relocation_entry *r = stack_reloc;
		int count = remain;
		if (count > ARRAY_SIZE(stack_reloc))
			count = ARRAY_SIZE(stack_reloc);
		remain -= count;

		if (__copy_from_user_inatomic(r, user_relocs, count*sizeof(r[0])))
580 581
			return -EFAULT;

582 583
		do {
			u64 offset = r->presumed_offset;
584

585
			ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, r);
586 587 588 589
			if (ret)
				return ret;

			if (r->presumed_offset != offset &&
590
			    __put_user(r->presumed_offset, &user_relocs->presumed_offset)) {
591 592 593 594 595 596
				return -EFAULT;
			}

			user_relocs++;
			r++;
		} while (--count);
597 598 599
	}

	return 0;
600
#undef N_RELOC
601 602 603
}

static int
604 605 606
i915_gem_execbuffer_relocate_vma_slow(struct i915_vma *vma,
				      struct eb_vmas *eb,
				      struct drm_i915_gem_relocation_entry *relocs)
607
{
608
	const struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
609 610 611
	int i, ret;

	for (i = 0; i < entry->relocation_count; i++) {
612
		ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, &relocs[i]);
613 614 615 616 617 618 619 620
		if (ret)
			return ret;
	}

	return 0;
}

static int
B
Ben Widawsky 已提交
621
i915_gem_execbuffer_relocate(struct eb_vmas *eb)
622
{
623
	struct i915_vma *vma;
624 625 626 627 628 629 630 631 632 633
	int ret = 0;

	/* This is the fast path and we cannot handle a pagefault whilst
	 * holding the struct mutex lest the user pass in the relocations
	 * contained within a mmaped bo. For in such a case we, the page
	 * fault handler would call i915_gem_fault() and we would try to
	 * acquire the struct mutex again. Obviously this is bad and so
	 * lockdep complains vehemently.
	 */
	pagefault_disable();
634 635
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		ret = i915_gem_execbuffer_relocate_vma(vma, eb);
636
		if (ret)
637
			break;
638
	}
639
	pagefault_enable();
640

641
	return ret;
642 643
}

644 645 646 647 648 649
static bool only_mappable_for_reloc(unsigned int flags)
{
	return (flags & (EXEC_OBJECT_NEEDS_FENCE | __EXEC_OBJECT_NEEDS_MAP)) ==
		__EXEC_OBJECT_NEEDS_MAP;
}

650
static int
651
i915_gem_execbuffer_reserve_vma(struct i915_vma *vma,
652
				struct intel_engine_cs *engine,
653
				bool *need_reloc)
654
{
655
	struct drm_i915_gem_object *obj = vma->obj;
656
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
657
	uint64_t flags;
658 659
	int ret;

660
	flags = PIN_USER;
661 662 663
	if (entry->flags & EXEC_OBJECT_NEEDS_GTT)
		flags |= PIN_GLOBAL;

664
	if (!drm_mm_node_allocated(&vma->node)) {
665 666 667 668 669
		/* Wa32bitGeneralStateOffset & Wa32bitInstructionBaseOffset,
		 * limit address to the first 4GBs for unflagged objects.
		 */
		if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0)
			flags |= PIN_ZONE_4G;
670 671 672 673
		if (entry->flags & __EXEC_OBJECT_NEEDS_MAP)
			flags |= PIN_GLOBAL | PIN_MAPPABLE;
		if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS)
			flags |= BATCH_OFFSET_BIAS | PIN_OFFSET_BIAS;
674 675
		if (entry->flags & EXEC_OBJECT_PINNED)
			flags |= entry->offset | PIN_OFFSET_FIXED;
676 677
		if ((flags & PIN_MAPPABLE) == 0)
			flags |= PIN_HIGH;
678
	}
679

680 681 682 683 684
	ret = i915_vma_pin(vma,
			   entry->pad_to_size,
			   entry->alignment,
			   flags);
	if ((ret == -ENOSPC || ret == -E2BIG) &&
685
	    only_mappable_for_reloc(entry->flags))
686 687 688 689
		ret = i915_vma_pin(vma,
				   entry->pad_to_size,
				   entry->alignment,
				   flags & ~PIN_MAPPABLE);
690 691 692
	if (ret)
		return ret;

693 694
	entry->flags |= __EXEC_OBJECT_HAS_PIN;

695 696 697 698
	if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
		ret = i915_gem_object_get_fence(obj);
		if (ret)
			return ret;
699

700 701
		if (i915_gem_object_pin_fence(obj))
			entry->flags |= __EXEC_OBJECT_HAS_FENCE;
702 703
	}

704 705
	if (entry->offset != vma->node.start) {
		entry->offset = vma->node.start;
706 707 708 709 710 711 712 713
		*need_reloc = true;
	}

	if (entry->flags & EXEC_OBJECT_WRITE) {
		obj->base.pending_read_domains = I915_GEM_DOMAIN_RENDER;
		obj->base.pending_write_domain = I915_GEM_DOMAIN_RENDER;
	}

714
	return 0;
715
}
716

717
static bool
718
need_reloc_mappable(struct i915_vma *vma)
719 720 721
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;

722 723 724
	if (entry->relocation_count == 0)
		return false;

725
	if (!i915_vma_is_ggtt(vma))
726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742
		return false;

	/* See also use_cpu_reloc() */
	if (HAS_LLC(vma->obj->base.dev))
		return false;

	if (vma->obj->base.write_domain == I915_GEM_DOMAIN_CPU)
		return false;

	return true;
}

static bool
eb_vma_misplaced(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
	struct drm_i915_gem_object *obj = vma->obj;
743

744 745
	WARN_ON(entry->flags & __EXEC_OBJECT_NEEDS_MAP &&
		!i915_vma_is_ggtt(vma));
746 747 748 749 750

	if (entry->alignment &&
	    vma->node.start & (entry->alignment - 1))
		return true;

751 752 753
	if (vma->node.size < entry->pad_to_size)
		return true;

754 755 756 757
	if (entry->flags & EXEC_OBJECT_PINNED &&
	    vma->node.start != entry->offset)
		return true;

758 759 760 761
	if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS &&
	    vma->node.start < BATCH_OFFSET_BIAS)
		return true;

762 763 764 765
	/* avoid costly ping-pong once a batch bo ended up non-mappable */
	if (entry->flags & __EXEC_OBJECT_NEEDS_MAP && !obj->map_and_fenceable)
		return !only_mappable_for_reloc(entry->flags);

766 767 768 769
	if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0 &&
	    (vma->node.start + vma->node.size - 1) >> 32)
		return true;

770 771 772
	return false;
}

773
static int
774
i915_gem_execbuffer_reserve(struct intel_engine_cs *engine,
775
			    struct list_head *vmas,
776
			    struct i915_gem_context *ctx,
777
			    bool *need_relocs)
778
{
779
	struct drm_i915_gem_object *obj;
780
	struct i915_vma *vma;
781
	struct i915_address_space *vm;
782
	struct list_head ordered_vmas;
783
	struct list_head pinned_vmas;
784
	bool has_fenced_gpu_access = INTEL_GEN(engine->i915) < 4;
785
	int retry;
786

787 788
	vm = list_first_entry(vmas, struct i915_vma, exec_list)->vm;

789
	INIT_LIST_HEAD(&ordered_vmas);
790
	INIT_LIST_HEAD(&pinned_vmas);
791
	while (!list_empty(vmas)) {
792 793 794
		struct drm_i915_gem_exec_object2 *entry;
		bool need_fence, need_mappable;

795 796 797
		vma = list_first_entry(vmas, struct i915_vma, exec_list);
		obj = vma->obj;
		entry = vma->exec_entry;
798

799 800 801
		if (ctx->flags & CONTEXT_NO_ZEROMAP)
			entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

802 803
		if (!has_fenced_gpu_access)
			entry->flags &= ~EXEC_OBJECT_NEEDS_FENCE;
804 805
		need_fence =
			entry->flags & EXEC_OBJECT_NEEDS_FENCE &&
806
			i915_gem_object_is_tiled(obj);
807
		need_mappable = need_fence || need_reloc_mappable(vma);
808

809 810 811
		if (entry->flags & EXEC_OBJECT_PINNED)
			list_move_tail(&vma->exec_list, &pinned_vmas);
		else if (need_mappable) {
812
			entry->flags |= __EXEC_OBJECT_NEEDS_MAP;
813
			list_move(&vma->exec_list, &ordered_vmas);
814
		} else
815
			list_move_tail(&vma->exec_list, &ordered_vmas);
816

817
		obj->base.pending_read_domains = I915_GEM_GPU_DOMAINS & ~I915_GEM_DOMAIN_COMMAND;
818
		obj->base.pending_write_domain = 0;
819
	}
820
	list_splice(&ordered_vmas, vmas);
821
	list_splice(&pinned_vmas, vmas);
822 823 824 825 826 827 828 829 830 831

	/* Attempt to pin all of the buffers into the GTT.
	 * This is done in 3 phases:
	 *
	 * 1a. Unbind all objects that do not match the GTT constraints for
	 *     the execbuffer (fenceable, mappable, alignment etc).
	 * 1b. Increment pin count for already bound objects.
	 * 2.  Bind new objects.
	 * 3.  Decrement pin count.
	 *
832
	 * This avoid unnecessary unbinding of later objects in order to make
833 834 835 836
	 * room for the earlier objects *unless* we need to defragment.
	 */
	retry = 0;
	do {
837
		int ret = 0;
838 839

		/* Unbind any ill-fitting objects or pin. */
840 841
		list_for_each_entry(vma, vmas, exec_list) {
			if (!drm_mm_node_allocated(&vma->node))
842 843
				continue;

844
			if (eb_vma_misplaced(vma))
845
				ret = i915_vma_unbind(vma);
846
			else
847 848 849
				ret = i915_gem_execbuffer_reserve_vma(vma,
								      engine,
								      need_relocs);
850
			if (ret)
851 852 853 854
				goto err;
		}

		/* Bind fresh objects */
855 856
		list_for_each_entry(vma, vmas, exec_list) {
			if (drm_mm_node_allocated(&vma->node))
857
				continue;
858

859 860
			ret = i915_gem_execbuffer_reserve_vma(vma, engine,
							      need_relocs);
861 862
			if (ret)
				goto err;
863 864
		}

865
err:
C
Chris Wilson 已提交
866
		if (ret != -ENOSPC || retry++)
867 868
			return ret;

869 870 871 872
		/* Decrement pin count for bound objects */
		list_for_each_entry(vma, vmas, exec_list)
			i915_gem_execbuffer_unreserve_vma(vma);

873
		ret = i915_gem_evict_vm(vm, true);
874 875 876 877 878 879 880
		if (ret)
			return ret;
	} while (1);
}

static int
i915_gem_execbuffer_relocate_slow(struct drm_device *dev,
881
				  struct drm_i915_gem_execbuffer2 *args,
882
				  struct drm_file *file,
883
				  struct intel_engine_cs *engine,
884
				  struct eb_vmas *eb,
885
				  struct drm_i915_gem_exec_object2 *exec,
886
				  struct i915_gem_context *ctx)
887 888
{
	struct drm_i915_gem_relocation_entry *reloc;
889 890
	struct i915_address_space *vm;
	struct i915_vma *vma;
891
	bool need_relocs;
892
	int *reloc_offset;
893
	int i, total, ret;
894
	unsigned count = args->buffer_count;
895

896 897
	vm = list_first_entry(&eb->vmas, struct i915_vma, exec_list)->vm;

898
	/* We may process another execbuffer during the unlock... */
899 900 901
	while (!list_empty(&eb->vmas)) {
		vma = list_first_entry(&eb->vmas, struct i915_vma, exec_list);
		list_del_init(&vma->exec_list);
902
		i915_gem_execbuffer_unreserve_vma(vma);
903
		i915_gem_object_put(vma->obj);
904 905
	}

906 907 908 909
	mutex_unlock(&dev->struct_mutex);

	total = 0;
	for (i = 0; i < count; i++)
910
		total += exec[i].relocation_count;
911

912
	reloc_offset = drm_malloc_ab(count, sizeof(*reloc_offset));
913
	reloc = drm_malloc_ab(total, sizeof(*reloc));
914 915 916
	if (reloc == NULL || reloc_offset == NULL) {
		drm_free_large(reloc);
		drm_free_large(reloc_offset);
917 918 919 920 921 922 923
		mutex_lock(&dev->struct_mutex);
		return -ENOMEM;
	}

	total = 0;
	for (i = 0; i < count; i++) {
		struct drm_i915_gem_relocation_entry __user *user_relocs;
924 925
		u64 invalid_offset = (u64)-1;
		int j;
926

927
		user_relocs = u64_to_user_ptr(exec[i].relocs_ptr);
928 929

		if (copy_from_user(reloc+total, user_relocs,
930
				   exec[i].relocation_count * sizeof(*reloc))) {
931 932 933 934 935
			ret = -EFAULT;
			mutex_lock(&dev->struct_mutex);
			goto err;
		}

936 937 938 939 940 941 942 943 944 945
		/* As we do not update the known relocation offsets after
		 * relocating (due to the complexities in lock handling),
		 * we need to mark them as invalid now so that we force the
		 * relocation processing next time. Just in case the target
		 * object is evicted and then rebound into its old
		 * presumed_offset before the next execbuffer - if that
		 * happened we would make the mistake of assuming that the
		 * relocations were valid.
		 */
		for (j = 0; j < exec[i].relocation_count; j++) {
946 947 948
			if (__copy_to_user(&user_relocs[j].presumed_offset,
					   &invalid_offset,
					   sizeof(invalid_offset))) {
949 950 951 952 953 954
				ret = -EFAULT;
				mutex_lock(&dev->struct_mutex);
				goto err;
			}
		}

955
		reloc_offset[i] = total;
956
		total += exec[i].relocation_count;
957 958 959 960 961 962 963 964
	}

	ret = i915_mutex_lock_interruptible(dev);
	if (ret) {
		mutex_lock(&dev->struct_mutex);
		goto err;
	}

965 966
	/* reacquire the objects */
	eb_reset(eb);
967
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
968 969
	if (ret)
		goto err;
970

971
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
972 973
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
974 975 976
	if (ret)
		goto err;

977 978 979 980
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		int offset = vma->exec_entry - exec;
		ret = i915_gem_execbuffer_relocate_vma_slow(vma, eb,
							    reloc + reloc_offset[offset]);
981 982 983 984 985 986 987 988 989 990 991 992
		if (ret)
			goto err;
	}

	/* Leave the user relocations as are, this is the painfully slow path,
	 * and we want to avoid the complication of dropping the lock whilst
	 * having buffers reserved in the aperture and so causing spurious
	 * ENOSPC for random operations.
	 */

err:
	drm_free_large(reloc);
993
	drm_free_large(reloc_offset);
994 995 996
	return ret;
}

997 998 999 1000 1001 1002 1003 1004 1005 1006
static unsigned int eb_other_engines(struct drm_i915_gem_request *req)
{
	unsigned int mask;

	mask = ~intel_engine_flag(req->engine) & I915_BO_ACTIVE_MASK;
	mask <<= I915_BO_ACTIVE_SHIFT;

	return mask;
}

1007
static int
1008
i915_gem_execbuffer_move_to_gpu(struct drm_i915_gem_request *req,
1009
				struct list_head *vmas)
1010
{
1011
	const unsigned int other_rings = eb_other_engines(req);
1012
	struct i915_vma *vma;
1013
	uint32_t flush_domains = 0;
1014
	bool flush_chipset = false;
1015
	int ret;
1016

1017 1018
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
1019

1020
		if (obj->flags & other_rings) {
1021
			ret = i915_gem_object_sync(obj, req);
1022 1023 1024
			if (ret)
				return ret;
		}
1025 1026

		if (obj->base.write_domain & I915_GEM_DOMAIN_CPU)
1027
			flush_chipset |= i915_gem_clflush_object(obj, false);
1028 1029

		flush_domains |= obj->base.write_domain;
1030 1031
	}

1032
	if (flush_chipset)
1033
		i915_gem_chipset_flush(req->engine->i915);
1034 1035 1036 1037

	if (flush_domains & I915_GEM_DOMAIN_GTT)
		wmb();

1038
	/* Unconditionally invalidate GPU caches and TLBs. */
1039
	return req->engine->emit_flush(req, EMIT_INVALIDATE);
1040 1041
}

1042 1043
static bool
i915_gem_check_execbuffer(struct drm_i915_gem_execbuffer2 *exec)
1044
{
1045 1046 1047
	if (exec->flags & __I915_EXEC_UNKNOWN_FLAGS)
		return false;

C
Chris Wilson 已提交
1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062
	/* Kernel clipping was a DRI1 misfeature */
	if (exec->num_cliprects || exec->cliprects_ptr)
		return false;

	if (exec->DR4 == 0xffffffff) {
		DRM_DEBUG("UXA submitting garbage DR4, fixing up\n");
		exec->DR4 = 0;
	}
	if (exec->DR1 || exec->DR4)
		return false;

	if ((exec->batch_start_offset | exec->batch_len) & 0x7)
		return false;

	return true;
1063 1064 1065
}

static int
1066 1067
validate_exec_list(struct drm_device *dev,
		   struct drm_i915_gem_exec_object2 *exec,
1068 1069
		   int count)
{
1070 1071
	unsigned relocs_total = 0;
	unsigned relocs_max = UINT_MAX / sizeof(struct drm_i915_gem_relocation_entry);
1072 1073 1074
	unsigned invalid_flags;
	int i;

1075 1076 1077
	/* INTERNAL flags must not overlap with external ones */
	BUILD_BUG_ON(__EXEC_OBJECT_INTERNAL_FLAGS & ~__EXEC_OBJECT_UNKNOWN_FLAGS);

1078 1079 1080
	invalid_flags = __EXEC_OBJECT_UNKNOWN_FLAGS;
	if (USES_FULL_PPGTT(dev))
		invalid_flags |= EXEC_OBJECT_NEEDS_GTT;
1081 1082

	for (i = 0; i < count; i++) {
1083
		char __user *ptr = u64_to_user_ptr(exec[i].relocs_ptr);
1084 1085
		int length; /* limited by fault_in_pages_readable() */

1086
		if (exec[i].flags & invalid_flags)
1087 1088
			return -EINVAL;

1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103
		/* Offset can be used as input (EXEC_OBJECT_PINNED), reject
		 * any non-page-aligned or non-canonical addresses.
		 */
		if (exec[i].flags & EXEC_OBJECT_PINNED) {
			if (exec[i].offset !=
			    gen8_canonical_addr(exec[i].offset & PAGE_MASK))
				return -EINVAL;

			/* From drm_mm perspective address space is continuous,
			 * so from this point we're always using non-canonical
			 * form internally.
			 */
			exec[i].offset = gen8_noncanonical_addr(exec[i].offset);
		}

1104 1105 1106
		if (exec[i].alignment && !is_power_of_2(exec[i].alignment))
			return -EINVAL;

1107 1108 1109 1110 1111 1112 1113 1114
		/* pad_to_size was once a reserved field, so sanitize it */
		if (exec[i].flags & EXEC_OBJECT_PAD_TO_SIZE) {
			if (offset_in_page(exec[i].pad_to_size))
				return -EINVAL;
		} else {
			exec[i].pad_to_size = 0;
		}

1115 1116 1117 1118 1119
		/* First check for malicious input causing overflow in
		 * the worst case where we need to allocate the entire
		 * relocation tree as a single array.
		 */
		if (exec[i].relocation_count > relocs_max - relocs_total)
1120
			return -EINVAL;
1121
		relocs_total += exec[i].relocation_count;
1122 1123 1124

		length = exec[i].relocation_count *
			sizeof(struct drm_i915_gem_relocation_entry);
1125 1126 1127 1128 1129
		/*
		 * We must check that the entire relocation array is safe
		 * to read, but since we may need to update the presumed
		 * offsets during execution, check for full write access.
		 */
1130 1131 1132
		if (!access_ok(VERIFY_WRITE, ptr, length))
			return -EFAULT;

1133
		if (likely(!i915.prefault_disable)) {
1134 1135 1136
			if (fault_in_multipages_readable(ptr, length))
				return -EFAULT;
		}
1137 1138 1139 1140 1141
	}

	return 0;
}

1142
static struct i915_gem_context *
1143
i915_gem_validate_context(struct drm_device *dev, struct drm_file *file,
1144
			  struct intel_engine_cs *engine, const u32 ctx_id)
1145
{
1146
	struct i915_gem_context *ctx = NULL;
1147 1148
	struct i915_ctx_hang_stats *hs;

1149
	if (engine->id != RCS && ctx_id != DEFAULT_CONTEXT_HANDLE)
1150 1151
		return ERR_PTR(-EINVAL);

1152
	ctx = i915_gem_context_lookup(file->driver_priv, ctx_id);
1153
	if (IS_ERR(ctx))
1154
		return ctx;
1155

1156
	hs = &ctx->hang_stats;
1157 1158
	if (hs->banned) {
		DRM_DEBUG("Context %u tried to submit while banned\n", ctx_id);
1159
		return ERR_PTR(-EIO);
1160 1161
	}

1162
	return ctx;
1163 1164
}

1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175
void i915_vma_move_to_active(struct i915_vma *vma,
			     struct drm_i915_gem_request *req,
			     unsigned int flags)
{
	struct drm_i915_gem_object *obj = vma->obj;
	const unsigned int idx = req->engine->id;

	GEM_BUG_ON(!drm_mm_node_allocated(&vma->node));

	obj->dirty = 1; /* be paranoid  */

1176 1177 1178 1179 1180 1181 1182
	/* Add a reference if we're newly entering the active list.
	 * The order in which we add operations to the retirement queue is
	 * vital here: mark_active adds to the start of the callback list,
	 * such that subsequent callbacks are called first. Therefore we
	 * add the active reference first and queue for it to be dropped
	 * *last*.
	 */
1183
	if (!i915_gem_object_is_active(obj))
1184
		i915_gem_object_get(obj);
1185
	i915_gem_object_set_active(obj, idx);
1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206
	i915_gem_active_set(&obj->last_read[idx], req);

	if (flags & EXEC_OBJECT_WRITE) {
		i915_gem_active_set(&obj->last_write, req);

		intel_fb_obj_invalidate(obj, ORIGIN_CS);

		/* update for the implicit flush after a batch */
		obj->base.write_domain &= ~I915_GEM_GPU_DOMAINS;
	}

	if (flags & EXEC_OBJECT_NEEDS_FENCE) {
		i915_gem_active_set(&obj->last_fence, req);
		if (flags & __EXEC_OBJECT_HAS_FENCE) {
			struct drm_i915_private *dev_priv = req->i915;

			list_move_tail(&dev_priv->fence_regs[obj->fence_reg].lru_list,
				       &dev_priv->mm.fence_list);
		}
	}

1207 1208
	i915_vma_set_active(vma, idx);
	i915_gem_active_set(&vma->last_read[idx], req);
1209 1210 1211
	list_move_tail(&vma->vm_link, &vma->vm->active_list);
}

1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233
static void eb_export_fence(struct drm_i915_gem_object *obj,
			    struct drm_i915_gem_request *req,
			    unsigned int flags)
{
	struct reservation_object *resv;

	resv = i915_gem_object_get_dmabuf_resv(obj);
	if (!resv)
		return;

	/* Ignore errors from failing to allocate the new fence, we can't
	 * handle an error right now. Worst case should be missed
	 * synchronisation leading to rendering corruption.
	 */
	ww_mutex_lock(&resv->lock, NULL);
	if (flags & EXEC_OBJECT_WRITE)
		reservation_object_add_excl_fence(resv, &req->fence);
	else if (reservation_object_reserve_shared(resv) == 0)
		reservation_object_add_shared_fence(resv, &req->fence);
	ww_mutex_unlock(&resv->lock);
}

1234
static void
1235
i915_gem_execbuffer_move_to_active(struct list_head *vmas,
1236
				   struct drm_i915_gem_request *req)
1237
{
1238
	struct i915_vma *vma;
1239

1240 1241
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
1242 1243
		u32 old_read = obj->base.read_domains;
		u32 old_write = obj->base.write_domain;
C
Chris Wilson 已提交
1244

1245
		obj->base.write_domain = obj->base.pending_write_domain;
1246 1247 1248
		if (obj->base.write_domain)
			vma->exec_entry->flags |= EXEC_OBJECT_WRITE;
		else
1249 1250
			obj->base.pending_read_domains |= obj->base.read_domains;
		obj->base.read_domains = obj->base.pending_read_domains;
1251

1252
		i915_vma_move_to_active(vma, req, vma->exec_entry->flags);
1253
		eb_export_fence(obj, req, vma->exec_entry->flags);
C
Chris Wilson 已提交
1254
		trace_i915_gem_object_change_domain(obj, old_read, old_write);
1255 1256 1257
	}
}

1258
static int
1259
i915_reset_gen7_sol_offsets(struct drm_i915_gem_request *req)
1260
{
1261
	struct intel_ring *ring = req->ring;
1262 1263
	int ret, i;

1264
	if (!IS_GEN7(req->i915) || req->engine->id != RCS) {
1265 1266 1267
		DRM_DEBUG("sol reset is gen7/rcs only\n");
		return -EINVAL;
	}
1268

1269
	ret = intel_ring_begin(req, 4 * 3);
1270 1271 1272 1273
	if (ret)
		return ret;

	for (i = 0; i < 4; i++) {
1274 1275 1276
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(ring, GEN7_SO_WRITE_OFFSET(i));
		intel_ring_emit(ring, 0);
1277 1278
	}

1279
	intel_ring_advance(ring);
1280 1281 1282 1283

	return 0;
}

1284
static struct i915_vma*
1285
i915_gem_execbuffer_parse(struct intel_engine_cs *engine,
1286 1287
			  struct drm_i915_gem_exec_object2 *shadow_exec_entry,
			  struct drm_i915_gem_object *batch_obj,
1288
			  struct eb_vmas *eb,
1289 1290
			  u32 batch_start_offset,
			  u32 batch_len,
1291
			  bool is_master)
1292 1293
{
	struct drm_i915_gem_object *shadow_batch_obj;
1294
	struct i915_vma *vma;
1295 1296
	int ret;

1297
	shadow_batch_obj = i915_gem_batch_pool_get(&engine->batch_pool,
1298
						   PAGE_ALIGN(batch_len));
1299
	if (IS_ERR(shadow_batch_obj))
1300
		return ERR_CAST(shadow_batch_obj);
1301

1302 1303 1304 1305 1306 1307
	ret = intel_engine_cmd_parser(engine,
				      batch_obj,
				      shadow_batch_obj,
				      batch_start_offset,
				      batch_len,
				      is_master);
1308 1309
	if (ret)
		goto err;
1310

1311
	ret = i915_gem_object_ggtt_pin(shadow_batch_obj, NULL, 0, 0, 0);
1312 1313
	if (ret)
		goto err;
1314

C
Chris Wilson 已提交
1315 1316
	i915_gem_object_unpin_pages(shadow_batch_obj);

1317
	memset(shadow_exec_entry, 0, sizeof(*shadow_exec_entry));
1318

1319 1320
	vma = i915_gem_obj_to_ggtt(shadow_batch_obj);
	vma->exec_entry = shadow_exec_entry;
C
Chris Wilson 已提交
1321
	vma->exec_entry->flags = __EXEC_OBJECT_HAS_PIN;
1322
	i915_gem_object_get(shadow_batch_obj);
1323
	list_add_tail(&vma->exec_list, &eb->vmas);
1324

1325
	return vma;
1326

1327
err:
C
Chris Wilson 已提交
1328
	i915_gem_object_unpin_pages(shadow_batch_obj);
1329
	if (ret == -EACCES) /* unhandled chained batch */
1330
		return NULL;
1331 1332
	else
		return ERR_PTR(ret);
1333
}
1334

1335 1336 1337 1338
static int
execbuf_submit(struct i915_execbuffer_params *params,
	       struct drm_i915_gem_execbuffer2 *args,
	       struct list_head *vmas)
1339
{
1340
	struct drm_i915_private *dev_priv = params->request->i915;
1341
	u64 exec_start, exec_len;
1342 1343
	int instp_mode;
	u32 instp_mask;
C
Chris Wilson 已提交
1344
	int ret;
1345

1346
	ret = i915_gem_execbuffer_move_to_gpu(params->request, vmas);
1347
	if (ret)
C
Chris Wilson 已提交
1348
		return ret;
1349

1350
	ret = i915_switch_context(params->request);
1351
	if (ret)
C
Chris Wilson 已提交
1352
		return ret;
1353 1354 1355 1356 1357 1358 1359

	instp_mode = args->flags & I915_EXEC_CONSTANTS_MASK;
	instp_mask = I915_EXEC_CONSTANTS_MASK;
	switch (instp_mode) {
	case I915_EXEC_CONSTANTS_REL_GENERAL:
	case I915_EXEC_CONSTANTS_ABSOLUTE:
	case I915_EXEC_CONSTANTS_REL_SURFACE:
1360
		if (instp_mode != 0 && params->engine->id != RCS) {
1361
			DRM_DEBUG("non-0 rel constants mode on non-RCS\n");
C
Chris Wilson 已提交
1362
			return -EINVAL;
1363 1364 1365
		}

		if (instp_mode != dev_priv->relative_constants_mode) {
1366
			if (INTEL_INFO(dev_priv)->gen < 4) {
1367
				DRM_DEBUG("no rel constants on pre-gen4\n");
C
Chris Wilson 已提交
1368
				return -EINVAL;
1369 1370
			}

1371
			if (INTEL_INFO(dev_priv)->gen > 5 &&
1372 1373
			    instp_mode == I915_EXEC_CONSTANTS_REL_SURFACE) {
				DRM_DEBUG("rel surface constants mode invalid on gen5+\n");
C
Chris Wilson 已提交
1374
				return -EINVAL;
1375 1376 1377
			}

			/* The HW changed the meaning on this bit on gen6 */
1378
			if (INTEL_INFO(dev_priv)->gen >= 6)
1379 1380 1381 1382 1383
				instp_mask &= ~I915_EXEC_CONSTANTS_REL_SURFACE;
		}
		break;
	default:
		DRM_DEBUG("execbuf with unknown constants: %d\n", instp_mode);
C
Chris Wilson 已提交
1384
		return -EINVAL;
1385 1386
	}

1387
	if (params->engine->id == RCS &&
C
Chris Wilson 已提交
1388
	    instp_mode != dev_priv->relative_constants_mode) {
1389
		struct intel_ring *ring = params->request->ring;
1390

1391
		ret = intel_ring_begin(params->request, 4);
1392
		if (ret)
C
Chris Wilson 已提交
1393
			return ret;
1394

1395 1396 1397 1398 1399
		intel_ring_emit(ring, MI_NOOP);
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(ring, INSTPM);
		intel_ring_emit(ring, instp_mask << 16 | instp_mode);
		intel_ring_advance(ring);
1400 1401 1402 1403 1404

		dev_priv->relative_constants_mode = instp_mode;
	}

	if (args->flags & I915_EXEC_GEN7_SOL_RESET) {
1405
		ret = i915_reset_gen7_sol_offsets(params->request);
1406
		if (ret)
C
Chris Wilson 已提交
1407
			return ret;
1408 1409
	}

1410
	exec_len   = args->batch_len;
1411
	exec_start = params->batch->node.start +
1412 1413
		     params->args_batch_start_offset;

1414
	if (exec_len == 0)
1415
		exec_len = params->batch->size;
1416

1417 1418 1419
	ret = params->engine->emit_bb_start(params->request,
					    exec_start, exec_len,
					    params->dispatch_flags);
C
Chris Wilson 已提交
1420 1421
	if (ret)
		return ret;
1422

1423
	trace_i915_gem_ring_dispatch(params->request, params->dispatch_flags);
1424

1425
	i915_gem_execbuffer_move_to_active(vmas, params->request);
1426

C
Chris Wilson 已提交
1427
	return 0;
1428 1429
}

1430 1431
/**
 * Find one BSD ring to dispatch the corresponding BSD command.
1432
 * The engine index is returned.
1433
 */
1434
static unsigned int
1435 1436
gen8_dispatch_bsd_engine(struct drm_i915_private *dev_priv,
			 struct drm_file *file)
1437 1438 1439
{
	struct drm_i915_file_private *file_priv = file->driver_priv;

1440
	/* Check whether the file_priv has already selected one ring. */
1441
	if ((int)file_priv->bsd_engine < 0) {
1442
		/* If not, use the ping-pong mechanism to select one. */
1443
		mutex_lock(&dev_priv->drm.struct_mutex);
1444 1445
		file_priv->bsd_engine = dev_priv->mm.bsd_engine_dispatch_index;
		dev_priv->mm.bsd_engine_dispatch_index ^= 1;
1446
		mutex_unlock(&dev_priv->drm.struct_mutex);
1447
	}
1448

1449
	return file_priv->bsd_engine;
1450 1451
}

1452 1453
#define I915_USER_RINGS (4)

1454
static const enum intel_engine_id user_ring_map[I915_USER_RINGS + 1] = {
1455 1456 1457 1458 1459 1460 1461
	[I915_EXEC_DEFAULT]	= RCS,
	[I915_EXEC_RENDER]	= RCS,
	[I915_EXEC_BLT]		= BCS,
	[I915_EXEC_BSD]		= VCS,
	[I915_EXEC_VEBOX]	= VECS
};

1462 1463 1464 1465
static struct intel_engine_cs *
eb_select_engine(struct drm_i915_private *dev_priv,
		 struct drm_file *file,
		 struct drm_i915_gem_execbuffer2 *args)
1466 1467
{
	unsigned int user_ring_id = args->flags & I915_EXEC_RING_MASK;
1468
	struct intel_engine_cs *engine;
1469 1470 1471

	if (user_ring_id > I915_USER_RINGS) {
		DRM_DEBUG("execbuf with unknown ring: %u\n", user_ring_id);
1472
		return NULL;
1473 1474 1475 1476 1477 1478
	}

	if ((user_ring_id != I915_EXEC_BSD) &&
	    ((args->flags & I915_EXEC_BSD_MASK) != 0)) {
		DRM_DEBUG("execbuf with non bsd ring but with invalid "
			  "bsd dispatch flags: %d\n", (int)(args->flags));
1479
		return NULL;
1480 1481 1482 1483 1484 1485
	}

	if (user_ring_id == I915_EXEC_BSD && HAS_BSD2(dev_priv)) {
		unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;

		if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
1486
			bsd_idx = gen8_dispatch_bsd_engine(dev_priv, file);
1487 1488
		} else if (bsd_idx >= I915_EXEC_BSD_RING1 &&
			   bsd_idx <= I915_EXEC_BSD_RING2) {
1489
			bsd_idx >>= I915_EXEC_BSD_SHIFT;
1490 1491 1492 1493
			bsd_idx--;
		} else {
			DRM_DEBUG("execbuf with unknown bsd ring: %u\n",
				  bsd_idx);
1494
			return NULL;
1495 1496
		}

1497
		engine = &dev_priv->engine[_VCS(bsd_idx)];
1498
	} else {
1499
		engine = &dev_priv->engine[user_ring_map[user_ring_id]];
1500 1501
	}

1502
	if (!intel_engine_initialized(engine)) {
1503
		DRM_DEBUG("execbuf with invalid ring: %u\n", user_ring_id);
1504
		return NULL;
1505 1506
	}

1507
	return engine;
1508 1509
}

1510 1511 1512 1513
static int
i915_gem_do_execbuffer(struct drm_device *dev, void *data,
		       struct drm_file *file,
		       struct drm_i915_gem_execbuffer2 *args,
1514
		       struct drm_i915_gem_exec_object2 *exec)
1515
{
1516 1517
	struct drm_i915_private *dev_priv = to_i915(dev);
	struct i915_ggtt *ggtt = &dev_priv->ggtt;
1518
	struct eb_vmas *eb;
1519
	struct drm_i915_gem_exec_object2 shadow_exec_entry;
1520
	struct intel_engine_cs *engine;
1521
	struct i915_gem_context *ctx;
1522
	struct i915_address_space *vm;
1523 1524
	struct i915_execbuffer_params params_master; /* XXX: will be removed later */
	struct i915_execbuffer_params *params = &params_master;
1525
	const u32 ctx_id = i915_execbuffer2_get_context_id(*args);
1526
	u32 dispatch_flags;
1527
	int ret;
1528
	bool need_relocs;
1529

1530
	if (!i915_gem_check_execbuffer(args))
1531 1532
		return -EINVAL;

1533
	ret = validate_exec_list(dev, exec, args->buffer_count);
1534 1535 1536
	if (ret)
		return ret;

1537
	dispatch_flags = 0;
1538
	if (args->flags & I915_EXEC_SECURE) {
1539
		if (!drm_is_current_master(file) || !capable(CAP_SYS_ADMIN))
1540 1541
		    return -EPERM;

1542
		dispatch_flags |= I915_DISPATCH_SECURE;
1543
	}
1544
	if (args->flags & I915_EXEC_IS_PINNED)
1545
		dispatch_flags |= I915_DISPATCH_PINNED;
1546

1547 1548 1549
	engine = eb_select_engine(dev_priv, file, args);
	if (!engine)
		return -EINVAL;
1550 1551

	if (args->buffer_count < 1) {
1552
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1553 1554 1555
		return -EINVAL;
	}

1556 1557 1558 1559 1560
	if (args->flags & I915_EXEC_RESOURCE_STREAMER) {
		if (!HAS_RESOURCE_STREAMER(dev)) {
			DRM_DEBUG("RS is only allowed for Haswell, Gen8 and above\n");
			return -EINVAL;
		}
1561
		if (engine->id != RCS) {
1562
			DRM_DEBUG("RS is not available on %s\n",
1563
				 engine->name);
1564 1565 1566 1567 1568 1569
			return -EINVAL;
		}

		dispatch_flags |= I915_DISPATCH_RS;
	}

1570 1571 1572 1573 1574 1575
	/* Take a local wakeref for preparing to dispatch the execbuf as
	 * we expect to access the hardware fairly frequently in the
	 * process. Upon first dispatch, we acquire another prolonged
	 * wakeref that we hold until the GPU has been idle for at least
	 * 100ms.
	 */
1576 1577
	intel_runtime_pm_get(dev_priv);

1578 1579 1580 1581
	ret = i915_mutex_lock_interruptible(dev);
	if (ret)
		goto pre_mutex_err;

1582
	ctx = i915_gem_validate_context(dev, file, engine, ctx_id);
1583
	if (IS_ERR(ctx)) {
1584
		mutex_unlock(&dev->struct_mutex);
1585
		ret = PTR_ERR(ctx);
1586
		goto pre_mutex_err;
1587
	}
1588

1589
	i915_gem_context_get(ctx);
1590

1591 1592 1593
	if (ctx->ppgtt)
		vm = &ctx->ppgtt->base;
	else
1594
		vm = &ggtt->base;
1595

1596 1597
	memset(&params_master, 0x00, sizeof(params_master));

B
Ben Widawsky 已提交
1598
	eb = eb_create(args);
1599
	if (eb == NULL) {
1600
		i915_gem_context_put(ctx);
1601 1602 1603 1604 1605
		mutex_unlock(&dev->struct_mutex);
		ret = -ENOMEM;
		goto pre_mutex_err;
	}

1606
	/* Look up object handles */
1607
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
1608 1609
	if (ret)
		goto err;
1610

1611
	/* take note of the batch buffer before we might reorder the lists */
1612
	params->batch = eb_get_batch(eb);
1613

1614
	/* Move the objects en-masse into the GTT, evicting if necessary. */
1615
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
1616 1617
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
1618 1619 1620 1621
	if (ret)
		goto err;

	/* The objects are in their final locations, apply the relocations. */
1622
	if (need_relocs)
B
Ben Widawsky 已提交
1623
		ret = i915_gem_execbuffer_relocate(eb);
1624 1625
	if (ret) {
		if (ret == -EFAULT) {
1626 1627
			ret = i915_gem_execbuffer_relocate_slow(dev, args, file,
								engine,
1628
								eb, exec, ctx);
1629 1630 1631 1632 1633 1634 1635
			BUG_ON(!mutex_is_locked(&dev->struct_mutex));
		}
		if (ret)
			goto err;
	}

	/* Set the pending read domains for the batch buffer to COMMAND */
1636
	if (params->batch->obj->base.pending_write_domain) {
1637
		DRM_DEBUG("Attempting to use self-modifying batch buffer\n");
1638 1639 1640 1641
		ret = -EINVAL;
		goto err;
	}

1642
	params->args_batch_start_offset = args->batch_start_offset;
1643
	if (intel_engine_needs_cmd_parser(engine) && args->batch_len) {
1644 1645 1646 1647 1648 1649 1650 1651 1652 1653
		struct i915_vma *vma;

		vma = i915_gem_execbuffer_parse(engine, &shadow_exec_entry,
						params->batch->obj,
						eb,
						args->batch_start_offset,
						args->batch_len,
						drm_is_current_master(file));
		if (IS_ERR(vma)) {
			ret = PTR_ERR(vma);
1654 1655
			goto err;
		}
1656

1657
		if (vma) {
1658 1659 1660 1661 1662 1663 1664 1665 1666 1667
			/*
			 * Batch parsed and accepted:
			 *
			 * Set the DISPATCH_SECURE bit to remove the NON_SECURE
			 * bit from MI_BATCH_BUFFER_START commands issued in
			 * the dispatch_execbuffer implementations. We
			 * specifically don't want that set on batches the
			 * command parser has accepted.
			 */
			dispatch_flags |= I915_DISPATCH_SECURE;
1668
			params->args_batch_start_offset = 0;
1669
			params->batch = vma;
1670
		}
1671 1672
	}

1673
	params->batch->obj->base.pending_read_domains |= I915_GEM_DOMAIN_COMMAND;
1674

1675 1676
	/* snb/ivb/vlv conflate the "batch in ppgtt" bit with the "non-secure
	 * batch" bit. Hence we need to pin secure batches into the global gtt.
B
Ben Widawsky 已提交
1677
	 * hsw should have this fixed, but bdw mucks it up again. */
1678
	if (dispatch_flags & I915_DISPATCH_SECURE) {
1679 1680
		struct drm_i915_gem_object *obj = params->batch->obj;

1681 1682 1683 1684 1685 1686
		/*
		 * So on first glance it looks freaky that we pin the batch here
		 * outside of the reservation loop. But:
		 * - The batch is already pinned into the relevant ppgtt, so we
		 *   already have the backing storage fully allocated.
		 * - No other BO uses the global gtt (well contexts, but meh),
1687
		 *   so we don't really have issues with multiple objects not
1688 1689 1690
		 *   fitting due to fragmentation.
		 * So this is actually safe.
		 */
1691
		ret = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
1692 1693
		if (ret)
			goto err;
1694

1695 1696
		params->batch = i915_gem_obj_to_ggtt(obj);
	}
1697

1698
	/* Allocate a request for this batch buffer nice and early. */
1699 1700 1701
	params->request = i915_gem_request_alloc(engine, ctx);
	if (IS_ERR(params->request)) {
		ret = PTR_ERR(params->request);
1702
		goto err_batch_unpin;
1703
	}
1704

1705 1706 1707 1708 1709 1710 1711 1712
	/* Whilst this request exists, batch_obj will be on the
	 * active_list, and so will hold the active reference. Only when this
	 * request is retired will the the batch_obj be moved onto the
	 * inactive_list and lose its active reference. Hence we do not need
	 * to explicitly hold another reference here.
	 */
	params->request->batch_obj = params->batch->obj;

1713
	ret = i915_gem_request_add_to_client(params->request, file);
1714
	if (ret)
1715
		goto err_request;
1716

1717 1718 1719 1720 1721 1722 1723 1724
	/*
	 * Save assorted stuff away to pass through to *_submission().
	 * NB: This data should be 'persistent' and not local as it will
	 * kept around beyond the duration of the IOCTL once the GPU
	 * scheduler arrives.
	 */
	params->dev                     = dev;
	params->file                    = file;
1725
	params->engine                    = engine;
1726 1727 1728
	params->dispatch_flags          = dispatch_flags;
	params->ctx                     = ctx;

1729
	ret = execbuf_submit(params, args, &eb->vmas);
1730
err_request:
1731
	__i915_add_request(params->request, ret == 0);
1732

1733
err_batch_unpin:
1734 1735 1736 1737 1738 1739
	/*
	 * FIXME: We crucially rely upon the active tracking for the (ppgtt)
	 * batch vma for correctness. For less ugly and less fragility this
	 * needs to be adjusted to also track the ggtt batch vma properly as
	 * active.
	 */
1740
	if (dispatch_flags & I915_DISPATCH_SECURE)
1741
		i915_vma_unpin(params->batch);
1742
err:
1743
	/* the request owns the ref now */
1744
	i915_gem_context_put(ctx);
1745
	eb_destroy(eb);
1746 1747 1748 1749

	mutex_unlock(&dev->struct_mutex);

pre_mutex_err:
1750 1751 1752
	/* intel_gpu_busy should also get a ref, so it will free when the device
	 * is really idle. */
	intel_runtime_pm_put(dev_priv);
1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770
	return ret;
}

/*
 * Legacy execbuffer just creates an exec2 list from the original exec object
 * list array and passes it to the real function.
 */
int
i915_gem_execbuffer(struct drm_device *dev, void *data,
		    struct drm_file *file)
{
	struct drm_i915_gem_execbuffer *args = data;
	struct drm_i915_gem_execbuffer2 exec2;
	struct drm_i915_gem_exec_object *exec_list = NULL;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret, i;

	if (args->buffer_count < 1) {
1771
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1772 1773 1774 1775 1776 1777 1778
		return -EINVAL;
	}

	/* Copy in the exec list from userland */
	exec_list = drm_malloc_ab(sizeof(*exec_list), args->buffer_count);
	exec2_list = drm_malloc_ab(sizeof(*exec2_list), args->buffer_count);
	if (exec_list == NULL || exec2_list == NULL) {
1779
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1780 1781 1782 1783 1784 1785
			  args->buffer_count);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -ENOMEM;
	}
	ret = copy_from_user(exec_list,
1786
			     u64_to_user_ptr(args->buffers_ptr),
1787 1788
			     sizeof(*exec_list) * args->buffer_count);
	if (ret != 0) {
1789
		DRM_DEBUG("copy %d exec entries failed %d\n",
1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816
			  args->buffer_count, ret);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

	for (i = 0; i < args->buffer_count; i++) {
		exec2_list[i].handle = exec_list[i].handle;
		exec2_list[i].relocation_count = exec_list[i].relocation_count;
		exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr;
		exec2_list[i].alignment = exec_list[i].alignment;
		exec2_list[i].offset = exec_list[i].offset;
		if (INTEL_INFO(dev)->gen < 4)
			exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE;
		else
			exec2_list[i].flags = 0;
	}

	exec2.buffers_ptr = args->buffers_ptr;
	exec2.buffer_count = args->buffer_count;
	exec2.batch_start_offset = args->batch_start_offset;
	exec2.batch_len = args->batch_len;
	exec2.DR1 = args->DR1;
	exec2.DR4 = args->DR4;
	exec2.num_cliprects = args->num_cliprects;
	exec2.cliprects_ptr = args->cliprects_ptr;
	exec2.flags = I915_EXEC_RENDER;
1817
	i915_execbuffer2_set_context_id(exec2, 0);
1818

1819
	ret = i915_gem_do_execbuffer(dev, data, file, &exec2, exec2_list);
1820
	if (!ret) {
1821
		struct drm_i915_gem_exec_object __user *user_exec_list =
1822
			u64_to_user_ptr(args->buffers_ptr);
1823

1824
		/* Copy the new buffer offsets back to the user's exec list. */
1825
		for (i = 0; i < args->buffer_count; i++) {
1826 1827
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1828 1829 1830 1831 1832 1833 1834 1835 1836 1837
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user (%d)\n",
					  args->buffer_count, ret);
				break;
			}
1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853
		}
	}

	drm_free_large(exec_list);
	drm_free_large(exec2_list);
	return ret;
}

int
i915_gem_execbuffer2(struct drm_device *dev, void *data,
		     struct drm_file *file)
{
	struct drm_i915_gem_execbuffer2 *args = data;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret;

1854 1855
	if (args->buffer_count < 1 ||
	    args->buffer_count > UINT_MAX / sizeof(*exec2_list)) {
1856
		DRM_DEBUG("execbuf2 with %d buffers\n", args->buffer_count);
1857 1858 1859
		return -EINVAL;
	}

1860 1861 1862 1863 1864
	if (args->rsvd2 != 0) {
		DRM_DEBUG("dirty rvsd2 field\n");
		return -EINVAL;
	}

1865 1866 1867
	exec2_list = drm_malloc_gfp(args->buffer_count,
				    sizeof(*exec2_list),
				    GFP_TEMPORARY);
1868
	if (exec2_list == NULL) {
1869
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1870 1871 1872 1873
			  args->buffer_count);
		return -ENOMEM;
	}
	ret = copy_from_user(exec2_list,
1874
			     u64_to_user_ptr(args->buffers_ptr),
1875 1876
			     sizeof(*exec2_list) * args->buffer_count);
	if (ret != 0) {
1877
		DRM_DEBUG("copy %d exec entries failed %d\n",
1878 1879 1880 1881 1882
			  args->buffer_count, ret);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

1883
	ret = i915_gem_do_execbuffer(dev, data, file, args, exec2_list);
1884 1885
	if (!ret) {
		/* Copy the new buffer offsets back to the user's exec list. */
1886
		struct drm_i915_gem_exec_object2 __user *user_exec_list =
1887
				   u64_to_user_ptr(args->buffers_ptr);
1888 1889 1890
		int i;

		for (i = 0; i < args->buffer_count; i++) {
1891 1892
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1893 1894 1895 1896 1897 1898 1899 1900 1901 1902
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user\n",
					  args->buffer_count);
				break;
			}
1903 1904 1905 1906 1907 1908
		}
	}

	drm_free_large(exec2_list);
	return ret;
}