i915_gem_execbuffer.c 49.7 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
/*
 * Copyright © 2008,2010 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 *
 * Authors:
 *    Eric Anholt <eric@anholt.net>
 *    Chris Wilson <chris@chris-wilson.co.uk>
 *
 */

29 30
#include <drm/drmP.h>
#include <drm/i915_drm.h>
31 32 33
#include "i915_drv.h"
#include "i915_trace.h"
#include "intel_drv.h"
34
#include <linux/dma_remapping.h>
35
#include <linux/uaccess.h>
36

37 38 39 40 41
#define  __EXEC_OBJECT_HAS_PIN		(1<<31)
#define  __EXEC_OBJECT_HAS_FENCE	(1<<30)
#define  __EXEC_OBJECT_NEEDS_MAP	(1<<29)
#define  __EXEC_OBJECT_NEEDS_BIAS	(1<<28)
#define  __EXEC_OBJECT_INTERNAL_FLAGS (0xf<<28) /* all of the above */
42 43

#define BATCH_OFFSET_BIAS (256*1024)
44

45 46 47
struct i915_execbuffer_params {
	struct drm_device               *dev;
	struct drm_file                 *file;
48 49 50
	struct i915_vma			*batch;
	u32				dispatch_flags;
	u32				args_batch_start_offset;
51 52 53 54 55
	struct intel_engine_cs          *engine;
	struct i915_gem_context         *ctx;
	struct drm_i915_gem_request     *request;
};

56 57
struct eb_vmas {
	struct list_head vmas;
58
	int and;
59
	union {
60
		struct i915_vma *lut[0];
61 62
		struct hlist_head buckets[0];
	};
63 64
};

65
static struct eb_vmas *
B
Ben Widawsky 已提交
66
eb_create(struct drm_i915_gem_execbuffer2 *args)
67
{
68
	struct eb_vmas *eb = NULL;
69 70

	if (args->flags & I915_EXEC_HANDLE_LUT) {
71
		unsigned size = args->buffer_count;
72 73
		size *= sizeof(struct i915_vma *);
		size += sizeof(struct eb_vmas);
74 75 76 77
		eb = kmalloc(size, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
	}

	if (eb == NULL) {
78 79
		unsigned size = args->buffer_count;
		unsigned count = PAGE_SIZE / sizeof(struct hlist_head) / 2;
L
Lauri Kasanen 已提交
80
		BUILD_BUG_ON_NOT_POWER_OF_2(PAGE_SIZE / sizeof(struct hlist_head));
81 82 83
		while (count > 2*size)
			count >>= 1;
		eb = kzalloc(count*sizeof(struct hlist_head) +
84
			     sizeof(struct eb_vmas),
85 86 87 88 89 90 91 92
			     GFP_TEMPORARY);
		if (eb == NULL)
			return eb;

		eb->and = count - 1;
	} else
		eb->and = -args->buffer_count;

93
	INIT_LIST_HEAD(&eb->vmas);
94 95 96 97
	return eb;
}

static void
98
eb_reset(struct eb_vmas *eb)
99
{
100 101
	if (eb->and >= 0)
		memset(eb->buckets, 0, (eb->and+1)*sizeof(struct hlist_head));
102 103
}

104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123
static struct i915_vma *
eb_get_batch(struct eb_vmas *eb)
{
	struct i915_vma *vma = list_entry(eb->vmas.prev, typeof(*vma), exec_list);

	/*
	 * SNA is doing fancy tricks with compressing batch buffers, which leads
	 * to negative relocation deltas. Usually that works out ok since the
	 * relocate address is still positive, except when the batch is placed
	 * very low in the GTT. Ensure this doesn't happen.
	 *
	 * Note that actual hangs have only been observed on gen7, but for
	 * paranoia do it everywhere.
	 */
	if ((vma->exec_entry->flags & EXEC_OBJECT_PINNED) == 0)
		vma->exec_entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

	return vma;
}

124
static int
125 126 127 128 129
eb_lookup_vmas(struct eb_vmas *eb,
	       struct drm_i915_gem_exec_object2 *exec,
	       const struct drm_i915_gem_execbuffer2 *args,
	       struct i915_address_space *vm,
	       struct drm_file *file)
130
{
131 132
	struct drm_i915_gem_object *obj;
	struct list_head objects;
133
	int i, ret;
134

135
	INIT_LIST_HEAD(&objects);
136
	spin_lock(&file->table_lock);
137 138
	/* Grab a reference to the object and release the lock so we can lookup
	 * or create the VMA without using GFP_ATOMIC */
139
	for (i = 0; i < args->buffer_count; i++) {
140 141 142 143 144
		obj = to_intel_bo(idr_find(&file->object_idr, exec[i].handle));
		if (obj == NULL) {
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Invalid object handle %d at index %d\n",
				   exec[i].handle, i);
145
			ret = -ENOENT;
146
			goto err;
147 148
		}

149
		if (!list_empty(&obj->obj_exec_link)) {
150 151 152
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Object %p [handle %d, index %d] appears more than once in object list\n",
				   obj, exec[i].handle, i);
153
			ret = -EINVAL;
154
			goto err;
155 156
		}

157
		i915_gem_object_get(obj);
158 159 160
		list_add_tail(&obj->obj_exec_link, &objects);
	}
	spin_unlock(&file->table_lock);
161

162
	i = 0;
163
	while (!list_empty(&objects)) {
164
		struct i915_vma *vma;
165

166 167 168 169
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);

170 171 172 173 174 175 176 177
		/*
		 * NOTE: We can leak any vmas created here when something fails
		 * later on. But that's no issue since vma_unbind can deal with
		 * vmas which are not actually bound. And since only
		 * lookup_or_create exists as an interface to get at the vma
		 * from the (obj, vm) we don't run the risk of creating
		 * duplicated vmas for the same vm.
		 */
178
		vma = i915_gem_obj_lookup_or_create_vma(obj, vm);
179 180 181
		if (IS_ERR(vma)) {
			DRM_DEBUG("Failed to lookup VMA\n");
			ret = PTR_ERR(vma);
182
			goto err;
183 184
		}

185
		/* Transfer ownership from the objects list to the vmas list. */
186
		list_add_tail(&vma->exec_list, &eb->vmas);
187
		list_del_init(&obj->obj_exec_link);
188 189

		vma->exec_entry = &exec[i];
190
		if (eb->and < 0) {
191
			eb->lut[i] = vma;
192 193
		} else {
			uint32_t handle = args->flags & I915_EXEC_HANDLE_LUT ? i : exec[i].handle;
194 195
			vma->exec_handle = handle;
			hlist_add_head(&vma->exec_node,
196 197
				       &eb->buckets[handle & eb->and]);
		}
198
		++i;
199 200
	}

201
	return 0;
202 203


204
err:
205 206 207 208 209
	while (!list_empty(&objects)) {
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);
		list_del_init(&obj->obj_exec_link);
210
		i915_gem_object_put(obj);
211
	}
212 213 214 215 216
	/*
	 * Objects already transfered to the vmas list will be unreferenced by
	 * eb_destroy.
	 */

217
	return ret;
218 219
}

220
static struct i915_vma *eb_get_vma(struct eb_vmas *eb, unsigned long handle)
221
{
222 223 224 225 226 227
	if (eb->and < 0) {
		if (handle >= -eb->and)
			return NULL;
		return eb->lut[handle];
	} else {
		struct hlist_head *head;
228
		struct i915_vma *vma;
229

230
		head = &eb->buckets[handle & eb->and];
231
		hlist_for_each_entry(vma, head, exec_node) {
232 233
			if (vma->exec_handle == handle)
				return vma;
234 235 236
		}
		return NULL;
	}
237 238
}

239 240 241 242 243 244 245 246 247 248 249 250 251 252 253
static void
i915_gem_execbuffer_unreserve_vma(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry;
	struct drm_i915_gem_object *obj = vma->obj;

	if (!drm_mm_node_allocated(&vma->node))
		return;

	entry = vma->exec_entry;

	if (entry->flags & __EXEC_OBJECT_HAS_FENCE)
		i915_gem_object_unpin_fence(obj);

	if (entry->flags & __EXEC_OBJECT_HAS_PIN)
254
		__i915_vma_unpin(vma);
255

C
Chris Wilson 已提交
256
	entry->flags &= ~(__EXEC_OBJECT_HAS_FENCE | __EXEC_OBJECT_HAS_PIN);
257 258 259 260
}

static void eb_destroy(struct eb_vmas *eb)
{
261 262
	while (!list_empty(&eb->vmas)) {
		struct i915_vma *vma;
263

264 265
		vma = list_first_entry(&eb->vmas,
				       struct i915_vma,
266
				       exec_list);
267
		list_del_init(&vma->exec_list);
268
		i915_gem_execbuffer_unreserve_vma(vma);
269
		i915_gem_object_put(vma->obj);
270
	}
271 272 273
	kfree(eb);
}

274 275
static inline int use_cpu_reloc(struct drm_i915_gem_object *obj)
{
276 277
	return (HAS_LLC(obj->base.dev) ||
		obj->base.write_domain == I915_GEM_DOMAIN_CPU ||
278 279 280
		obj->cache_level != I915_CACHE_NONE);
}

281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305
/* Used to convert any address to canonical form.
 * Starting from gen8, some commands (e.g. STATE_BASE_ADDRESS,
 * MI_LOAD_REGISTER_MEM and others, see Broadwell PRM Vol2a) require the
 * addresses to be in a canonical form:
 * "GraphicsAddress[63:48] are ignored by the HW and assumed to be in correct
 * canonical form [63:48] == [47]."
 */
#define GEN8_HIGH_ADDRESS_BIT 47
static inline uint64_t gen8_canonical_addr(uint64_t address)
{
	return sign_extend64(address, GEN8_HIGH_ADDRESS_BIT);
}

static inline uint64_t gen8_noncanonical_addr(uint64_t address)
{
	return address & ((1ULL << (GEN8_HIGH_ADDRESS_BIT + 1)) - 1);
}

static inline uint64_t
relocation_target(struct drm_i915_gem_relocation_entry *reloc,
		  uint64_t target_offset)
{
	return gen8_canonical_addr((int)reloc->delta + target_offset);
}

306 307
static int
relocate_entry_cpu(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
308 309
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
310
{
311
	struct drm_device *dev = obj->base.dev;
312
	uint32_t page_offset = offset_in_page(reloc->offset);
313
	uint64_t delta = relocation_target(reloc, target_offset);
314
	char *vaddr;
315
	int ret;
316

317
	ret = i915_gem_object_set_to_cpu_domain(obj, true);
318 319 320
	if (ret)
		return ret;

321
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
322
				reloc->offset >> PAGE_SHIFT));
B
Ben Widawsky 已提交
323
	*(uint32_t *)(vaddr + page_offset) = lower_32_bits(delta);
324 325 326 327 328 329

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
330
			vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
331 332 333
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

B
Ben Widawsky 已提交
334
		*(uint32_t *)(vaddr + page_offset) = upper_32_bits(delta);
335 336
	}

337 338 339 340 341 342 343
	kunmap_atomic(vaddr);

	return 0;
}

static int
relocate_entry_gtt(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
344 345
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
346 347
{
	struct drm_device *dev = obj->base.dev;
348 349
	struct drm_i915_private *dev_priv = to_i915(dev);
	struct i915_ggtt *ggtt = &dev_priv->ggtt;
350
	uint64_t delta = relocation_target(reloc, target_offset);
351
	uint64_t offset;
352
	void __iomem *reloc_page;
353
	int ret;
354 355 356 357 358 359 360 361 362 363

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

	ret = i915_gem_object_put_fence(obj);
	if (ret)
		return ret;

	/* Map the page containing the relocation we're going to perform.  */
364 365
	offset = i915_gem_obj_ggtt_offset(obj);
	offset += reloc->offset;
366
	reloc_page = io_mapping_map_atomic_wc(ggtt->mappable,
367 368
					      offset & PAGE_MASK);
	iowrite32(lower_32_bits(delta), reloc_page + offset_in_page(offset));
369 370

	if (INTEL_INFO(dev)->gen >= 8) {
371
		offset += sizeof(uint32_t);
372

373
		if (offset_in_page(offset) == 0) {
374
			io_mapping_unmap_atomic(reloc_page);
375
			reloc_page =
376
				io_mapping_map_atomic_wc(ggtt->mappable,
377
							 offset);
378 379
		}

380 381
		iowrite32(upper_32_bits(delta),
			  reloc_page + offset_in_page(offset));
382 383
	}

384 385 386 387 388
	io_mapping_unmap_atomic(reloc_page);

	return 0;
}

389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404
static void
clflush_write32(void *addr, uint32_t value)
{
	/* This is not a fast path, so KISS. */
	drm_clflush_virt_range(addr, sizeof(uint32_t));
	*(uint32_t *)addr = value;
	drm_clflush_virt_range(addr, sizeof(uint32_t));
}

static int
relocate_entry_clflush(struct drm_i915_gem_object *obj,
		       struct drm_i915_gem_relocation_entry *reloc,
		       uint64_t target_offset)
{
	struct drm_device *dev = obj->base.dev;
	uint32_t page_offset = offset_in_page(reloc->offset);
405
	uint64_t delta = relocation_target(reloc, target_offset);
406 407 408 409 410 411 412
	char *vaddr;
	int ret;

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

413
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
414 415 416 417 418 419 420 421
				reloc->offset >> PAGE_SHIFT));
	clflush_write32(vaddr + page_offset, lower_32_bits(delta));

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
422
			vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
423 424 425 426 427 428 429 430 431 432 433
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

		clflush_write32(vaddr + page_offset, upper_32_bits(delta));
	}

	kunmap_atomic(vaddr);

	return 0;
}

434 435 436 437 438 439 440 441 442 443 444 445 446 447
static bool object_is_idle(struct drm_i915_gem_object *obj)
{
	unsigned long active = obj->active;
	int idx;

	for_each_active(active, idx) {
		if (!i915_gem_active_is_idle(&obj->last_read[idx],
					     &obj->base.dev->struct_mutex))
			return false;
	}

	return true;
}

448 449
static int
i915_gem_execbuffer_relocate_entry(struct drm_i915_gem_object *obj,
450
				   struct eb_vmas *eb,
451
				   struct drm_i915_gem_relocation_entry *reloc)
452 453 454
{
	struct drm_device *dev = obj->base.dev;
	struct drm_gem_object *target_obj;
455
	struct drm_i915_gem_object *target_i915_obj;
456
	struct i915_vma *target_vma;
B
Ben Widawsky 已提交
457
	uint64_t target_offset;
458
	int ret;
459

460
	/* we've already hold a reference to all valid objects */
461 462
	target_vma = eb_get_vma(eb, reloc->target_handle);
	if (unlikely(target_vma == NULL))
463
		return -ENOENT;
464 465
	target_i915_obj = target_vma->obj;
	target_obj = &target_vma->obj->base;
466

467
	target_offset = gen8_canonical_addr(target_vma->node.start);
468

469 470 471 472
	/* Sandybridge PPGTT errata: We need a global gtt mapping for MI and
	 * pipe_control writes because the gpu doesn't properly redirect them
	 * through the ppgtt for non_secure batchbuffers. */
	if (unlikely(IS_GEN6(dev) &&
473
	    reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION)) {
474
		ret = i915_vma_bind(target_vma, target_i915_obj->cache_level,
475
				    PIN_GLOBAL);
476 477 478
		if (WARN_ONCE(ret, "Unexpected failure to bind target VMA!"))
			return ret;
	}
479

480
	/* Validate that the target is in a valid r/w GPU domain */
481
	if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) {
482
		DRM_DEBUG("reloc with multiple write domains: "
483 484 485 486 487 488
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
489
		return -EINVAL;
490
	}
491 492
	if (unlikely((reloc->write_domain | reloc->read_domains)
		     & ~I915_GEM_GPU_DOMAINS)) {
493
		DRM_DEBUG("reloc with read/write non-GPU domains: "
494 495 496 497 498 499
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
500
		return -EINVAL;
501 502 503 504 505 506 507 508 509
	}

	target_obj->pending_read_domains |= reloc->read_domains;
	target_obj->pending_write_domain |= reloc->write_domain;

	/* If the relocation already has the right value in it, no
	 * more work needs to be done.
	 */
	if (target_offset == reloc->presumed_offset)
510
		return 0;
511 512

	/* Check that the relocation address is valid... */
513 514
	if (unlikely(reloc->offset >
		obj->base.size - (INTEL_INFO(dev)->gen >= 8 ? 8 : 4))) {
515
		DRM_DEBUG("Relocation beyond object bounds: "
516 517 518 519
			  "obj %p target %d offset %d size %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  (int) obj->base.size);
520
		return -EINVAL;
521
	}
522
	if (unlikely(reloc->offset & 3)) {
523
		DRM_DEBUG("Relocation not 4-byte aligned: "
524 525 526
			  "obj %p target %d offset %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset);
527
		return -EINVAL;
528 529
	}

530
	/* We can't wait for rendering with pagefaults disabled */
531
	if (pagefault_disabled() && !object_is_idle(obj))
532 533
		return -EFAULT;

534
	if (use_cpu_reloc(obj))
B
Ben Widawsky 已提交
535
		ret = relocate_entry_cpu(obj, reloc, target_offset);
536
	else if (obj->map_and_fenceable)
B
Ben Widawsky 已提交
537
		ret = relocate_entry_gtt(obj, reloc, target_offset);
538
	else if (static_cpu_has(X86_FEATURE_CLFLUSH))
539 540 541 542 543
		ret = relocate_entry_clflush(obj, reloc, target_offset);
	else {
		WARN_ONCE(1, "Impossible case in relocation handling\n");
		ret = -ENODEV;
	}
544

545 546 547
	if (ret)
		return ret;

548 549 550
	/* and update the user's relocation entry */
	reloc->presumed_offset = target_offset;

551
	return 0;
552 553 554
}

static int
555 556
i915_gem_execbuffer_relocate_vma(struct i915_vma *vma,
				 struct eb_vmas *eb)
557
{
558 559
#define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry))
	struct drm_i915_gem_relocation_entry stack_reloc[N_RELOC(512)];
560
	struct drm_i915_gem_relocation_entry __user *user_relocs;
561
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
562
	int remain, ret;
563

564
	user_relocs = u64_to_user_ptr(entry->relocs_ptr);
565

566 567 568 569 570 571 572 573 574
	remain = entry->relocation_count;
	while (remain) {
		struct drm_i915_gem_relocation_entry *r = stack_reloc;
		int count = remain;
		if (count > ARRAY_SIZE(stack_reloc))
			count = ARRAY_SIZE(stack_reloc);
		remain -= count;

		if (__copy_from_user_inatomic(r, user_relocs, count*sizeof(r[0])))
575 576
			return -EFAULT;

577 578
		do {
			u64 offset = r->presumed_offset;
579

580
			ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, r);
581 582 583 584
			if (ret)
				return ret;

			if (r->presumed_offset != offset &&
585
			    __put_user(r->presumed_offset, &user_relocs->presumed_offset)) {
586 587 588 589 590 591
				return -EFAULT;
			}

			user_relocs++;
			r++;
		} while (--count);
592 593 594
	}

	return 0;
595
#undef N_RELOC
596 597 598
}

static int
599 600 601
i915_gem_execbuffer_relocate_vma_slow(struct i915_vma *vma,
				      struct eb_vmas *eb,
				      struct drm_i915_gem_relocation_entry *relocs)
602
{
603
	const struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
604 605 606
	int i, ret;

	for (i = 0; i < entry->relocation_count; i++) {
607
		ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, &relocs[i]);
608 609 610 611 612 613 614 615
		if (ret)
			return ret;
	}

	return 0;
}

static int
B
Ben Widawsky 已提交
616
i915_gem_execbuffer_relocate(struct eb_vmas *eb)
617
{
618
	struct i915_vma *vma;
619 620 621 622 623 624 625 626 627 628
	int ret = 0;

	/* This is the fast path and we cannot handle a pagefault whilst
	 * holding the struct mutex lest the user pass in the relocations
	 * contained within a mmaped bo. For in such a case we, the page
	 * fault handler would call i915_gem_fault() and we would try to
	 * acquire the struct mutex again. Obviously this is bad and so
	 * lockdep complains vehemently.
	 */
	pagefault_disable();
629 630
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		ret = i915_gem_execbuffer_relocate_vma(vma, eb);
631
		if (ret)
632
			break;
633
	}
634
	pagefault_enable();
635

636
	return ret;
637 638
}

639 640 641 642 643 644
static bool only_mappable_for_reloc(unsigned int flags)
{
	return (flags & (EXEC_OBJECT_NEEDS_FENCE | __EXEC_OBJECT_NEEDS_MAP)) ==
		__EXEC_OBJECT_NEEDS_MAP;
}

645
static int
646
i915_gem_execbuffer_reserve_vma(struct i915_vma *vma,
647
				struct intel_engine_cs *engine,
648
				bool *need_reloc)
649
{
650
	struct drm_i915_gem_object *obj = vma->obj;
651
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
652
	uint64_t flags;
653 654
	int ret;

655
	flags = PIN_USER;
656 657 658
	if (entry->flags & EXEC_OBJECT_NEEDS_GTT)
		flags |= PIN_GLOBAL;

659
	if (!drm_mm_node_allocated(&vma->node)) {
660 661 662 663 664
		/* Wa32bitGeneralStateOffset & Wa32bitInstructionBaseOffset,
		 * limit address to the first 4GBs for unflagged objects.
		 */
		if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0)
			flags |= PIN_ZONE_4G;
665 666 667 668
		if (entry->flags & __EXEC_OBJECT_NEEDS_MAP)
			flags |= PIN_GLOBAL | PIN_MAPPABLE;
		if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS)
			flags |= BATCH_OFFSET_BIAS | PIN_OFFSET_BIAS;
669 670
		if (entry->flags & EXEC_OBJECT_PINNED)
			flags |= entry->offset | PIN_OFFSET_FIXED;
671 672
		if ((flags & PIN_MAPPABLE) == 0)
			flags |= PIN_HIGH;
673
	}
674

675 676 677 678 679
	ret = i915_vma_pin(vma,
			   entry->pad_to_size,
			   entry->alignment,
			   flags);
	if ((ret == -ENOSPC || ret == -E2BIG) &&
680
	    only_mappable_for_reloc(entry->flags))
681 682 683 684
		ret = i915_vma_pin(vma,
				   entry->pad_to_size,
				   entry->alignment,
				   flags & ~PIN_MAPPABLE);
685 686 687
	if (ret)
		return ret;

688 689
	entry->flags |= __EXEC_OBJECT_HAS_PIN;

690 691 692 693
	if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
		ret = i915_gem_object_get_fence(obj);
		if (ret)
			return ret;
694

695 696
		if (i915_gem_object_pin_fence(obj))
			entry->flags |= __EXEC_OBJECT_HAS_FENCE;
697 698
	}

699 700
	if (entry->offset != vma->node.start) {
		entry->offset = vma->node.start;
701 702 703 704 705 706 707 708
		*need_reloc = true;
	}

	if (entry->flags & EXEC_OBJECT_WRITE) {
		obj->base.pending_read_domains = I915_GEM_DOMAIN_RENDER;
		obj->base.pending_write_domain = I915_GEM_DOMAIN_RENDER;
	}

709
	return 0;
710
}
711

712
static bool
713
need_reloc_mappable(struct i915_vma *vma)
714 715 716
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;

717 718 719
	if (entry->relocation_count == 0)
		return false;

720
	if (!vma->is_ggtt)
721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737
		return false;

	/* See also use_cpu_reloc() */
	if (HAS_LLC(vma->obj->base.dev))
		return false;

	if (vma->obj->base.write_domain == I915_GEM_DOMAIN_CPU)
		return false;

	return true;
}

static bool
eb_vma_misplaced(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
	struct drm_i915_gem_object *obj = vma->obj;
738

739
	WARN_ON(entry->flags & __EXEC_OBJECT_NEEDS_MAP && !vma->is_ggtt);
740 741 742 743 744

	if (entry->alignment &&
	    vma->node.start & (entry->alignment - 1))
		return true;

745 746 747
	if (vma->node.size < entry->pad_to_size)
		return true;

748 749 750 751
	if (entry->flags & EXEC_OBJECT_PINNED &&
	    vma->node.start != entry->offset)
		return true;

752 753 754 755
	if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS &&
	    vma->node.start < BATCH_OFFSET_BIAS)
		return true;

756 757 758 759
	/* avoid costly ping-pong once a batch bo ended up non-mappable */
	if (entry->flags & __EXEC_OBJECT_NEEDS_MAP && !obj->map_and_fenceable)
		return !only_mappable_for_reloc(entry->flags);

760 761 762 763
	if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0 &&
	    (vma->node.start + vma->node.size - 1) >> 32)
		return true;

764 765 766
	return false;
}

767
static int
768
i915_gem_execbuffer_reserve(struct intel_engine_cs *engine,
769
			    struct list_head *vmas,
770
			    struct i915_gem_context *ctx,
771
			    bool *need_relocs)
772
{
773
	struct drm_i915_gem_object *obj;
774
	struct i915_vma *vma;
775
	struct i915_address_space *vm;
776
	struct list_head ordered_vmas;
777
	struct list_head pinned_vmas;
778
	bool has_fenced_gpu_access = INTEL_GEN(engine->i915) < 4;
779
	int retry;
780

781 782
	vm = list_first_entry(vmas, struct i915_vma, exec_list)->vm;

783
	INIT_LIST_HEAD(&ordered_vmas);
784
	INIT_LIST_HEAD(&pinned_vmas);
785
	while (!list_empty(vmas)) {
786 787 788
		struct drm_i915_gem_exec_object2 *entry;
		bool need_fence, need_mappable;

789 790 791
		vma = list_first_entry(vmas, struct i915_vma, exec_list);
		obj = vma->obj;
		entry = vma->exec_entry;
792

793 794 795
		if (ctx->flags & CONTEXT_NO_ZEROMAP)
			entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

796 797
		if (!has_fenced_gpu_access)
			entry->flags &= ~EXEC_OBJECT_NEEDS_FENCE;
798 799 800
		need_fence =
			entry->flags & EXEC_OBJECT_NEEDS_FENCE &&
			obj->tiling_mode != I915_TILING_NONE;
801
		need_mappable = need_fence || need_reloc_mappable(vma);
802

803 804 805
		if (entry->flags & EXEC_OBJECT_PINNED)
			list_move_tail(&vma->exec_list, &pinned_vmas);
		else if (need_mappable) {
806
			entry->flags |= __EXEC_OBJECT_NEEDS_MAP;
807
			list_move(&vma->exec_list, &ordered_vmas);
808
		} else
809
			list_move_tail(&vma->exec_list, &ordered_vmas);
810

811
		obj->base.pending_read_domains = I915_GEM_GPU_DOMAINS & ~I915_GEM_DOMAIN_COMMAND;
812
		obj->base.pending_write_domain = 0;
813
	}
814
	list_splice(&ordered_vmas, vmas);
815
	list_splice(&pinned_vmas, vmas);
816 817 818 819 820 821 822 823 824 825

	/* Attempt to pin all of the buffers into the GTT.
	 * This is done in 3 phases:
	 *
	 * 1a. Unbind all objects that do not match the GTT constraints for
	 *     the execbuffer (fenceable, mappable, alignment etc).
	 * 1b. Increment pin count for already bound objects.
	 * 2.  Bind new objects.
	 * 3.  Decrement pin count.
	 *
826
	 * This avoid unnecessary unbinding of later objects in order to make
827 828 829 830
	 * room for the earlier objects *unless* we need to defragment.
	 */
	retry = 0;
	do {
831
		int ret = 0;
832 833

		/* Unbind any ill-fitting objects or pin. */
834 835
		list_for_each_entry(vma, vmas, exec_list) {
			if (!drm_mm_node_allocated(&vma->node))
836 837
				continue;

838
			if (eb_vma_misplaced(vma))
839
				ret = i915_vma_unbind(vma);
840
			else
841 842 843
				ret = i915_gem_execbuffer_reserve_vma(vma,
								      engine,
								      need_relocs);
844
			if (ret)
845 846 847 848
				goto err;
		}

		/* Bind fresh objects */
849 850
		list_for_each_entry(vma, vmas, exec_list) {
			if (drm_mm_node_allocated(&vma->node))
851
				continue;
852

853 854
			ret = i915_gem_execbuffer_reserve_vma(vma, engine,
							      need_relocs);
855 856
			if (ret)
				goto err;
857 858
		}

859
err:
C
Chris Wilson 已提交
860
		if (ret != -ENOSPC || retry++)
861 862
			return ret;

863 864 865 866
		/* Decrement pin count for bound objects */
		list_for_each_entry(vma, vmas, exec_list)
			i915_gem_execbuffer_unreserve_vma(vma);

867
		ret = i915_gem_evict_vm(vm, true);
868 869 870 871 872 873 874
		if (ret)
			return ret;
	} while (1);
}

static int
i915_gem_execbuffer_relocate_slow(struct drm_device *dev,
875
				  struct drm_i915_gem_execbuffer2 *args,
876
				  struct drm_file *file,
877
				  struct intel_engine_cs *engine,
878
				  struct eb_vmas *eb,
879
				  struct drm_i915_gem_exec_object2 *exec,
880
				  struct i915_gem_context *ctx)
881 882
{
	struct drm_i915_gem_relocation_entry *reloc;
883 884
	struct i915_address_space *vm;
	struct i915_vma *vma;
885
	bool need_relocs;
886
	int *reloc_offset;
887
	int i, total, ret;
888
	unsigned count = args->buffer_count;
889

890 891
	vm = list_first_entry(&eb->vmas, struct i915_vma, exec_list)->vm;

892
	/* We may process another execbuffer during the unlock... */
893 894 895
	while (!list_empty(&eb->vmas)) {
		vma = list_first_entry(&eb->vmas, struct i915_vma, exec_list);
		list_del_init(&vma->exec_list);
896
		i915_gem_execbuffer_unreserve_vma(vma);
897
		i915_gem_object_put(vma->obj);
898 899
	}

900 901 902 903
	mutex_unlock(&dev->struct_mutex);

	total = 0;
	for (i = 0; i < count; i++)
904
		total += exec[i].relocation_count;
905

906
	reloc_offset = drm_malloc_ab(count, sizeof(*reloc_offset));
907
	reloc = drm_malloc_ab(total, sizeof(*reloc));
908 909 910
	if (reloc == NULL || reloc_offset == NULL) {
		drm_free_large(reloc);
		drm_free_large(reloc_offset);
911 912 913 914 915 916 917
		mutex_lock(&dev->struct_mutex);
		return -ENOMEM;
	}

	total = 0;
	for (i = 0; i < count; i++) {
		struct drm_i915_gem_relocation_entry __user *user_relocs;
918 919
		u64 invalid_offset = (u64)-1;
		int j;
920

921
		user_relocs = u64_to_user_ptr(exec[i].relocs_ptr);
922 923

		if (copy_from_user(reloc+total, user_relocs,
924
				   exec[i].relocation_count * sizeof(*reloc))) {
925 926 927 928 929
			ret = -EFAULT;
			mutex_lock(&dev->struct_mutex);
			goto err;
		}

930 931 932 933 934 935 936 937 938 939
		/* As we do not update the known relocation offsets after
		 * relocating (due to the complexities in lock handling),
		 * we need to mark them as invalid now so that we force the
		 * relocation processing next time. Just in case the target
		 * object is evicted and then rebound into its old
		 * presumed_offset before the next execbuffer - if that
		 * happened we would make the mistake of assuming that the
		 * relocations were valid.
		 */
		for (j = 0; j < exec[i].relocation_count; j++) {
940 941 942
			if (__copy_to_user(&user_relocs[j].presumed_offset,
					   &invalid_offset,
					   sizeof(invalid_offset))) {
943 944 945 946 947 948
				ret = -EFAULT;
				mutex_lock(&dev->struct_mutex);
				goto err;
			}
		}

949
		reloc_offset[i] = total;
950
		total += exec[i].relocation_count;
951 952 953 954 955 956 957 958
	}

	ret = i915_mutex_lock_interruptible(dev);
	if (ret) {
		mutex_lock(&dev->struct_mutex);
		goto err;
	}

959 960
	/* reacquire the objects */
	eb_reset(eb);
961
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
962 963
	if (ret)
		goto err;
964

965
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
966 967
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
968 969 970
	if (ret)
		goto err;

971 972 973 974
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		int offset = vma->exec_entry - exec;
		ret = i915_gem_execbuffer_relocate_vma_slow(vma, eb,
							    reloc + reloc_offset[offset]);
975 976 977 978 979 980 981 982 983 984 985 986
		if (ret)
			goto err;
	}

	/* Leave the user relocations as are, this is the painfully slow path,
	 * and we want to avoid the complication of dropping the lock whilst
	 * having buffers reserved in the aperture and so causing spurious
	 * ENOSPC for random operations.
	 */

err:
	drm_free_large(reloc);
987
	drm_free_large(reloc_offset);
988 989 990 991
	return ret;
}

static int
992
i915_gem_execbuffer_move_to_gpu(struct drm_i915_gem_request *req,
993
				struct list_head *vmas)
994
{
995
	const unsigned other_rings = ~intel_engine_flag(req->engine);
996
	struct i915_vma *vma;
997
	uint32_t flush_domains = 0;
998
	bool flush_chipset = false;
999
	int ret;
1000

1001 1002
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
1003 1004

		if (obj->active & other_rings) {
1005
			ret = i915_gem_object_sync(obj, req);
1006 1007 1008
			if (ret)
				return ret;
		}
1009 1010

		if (obj->base.write_domain & I915_GEM_DOMAIN_CPU)
1011
			flush_chipset |= i915_gem_clflush_object(obj, false);
1012 1013

		flush_domains |= obj->base.write_domain;
1014 1015
	}

1016
	if (flush_chipset)
1017
		i915_gem_chipset_flush(req->engine->i915);
1018 1019 1020 1021

	if (flush_domains & I915_GEM_DOMAIN_GTT)
		wmb();

1022
	/* Unconditionally invalidate GPU caches and TLBs. */
1023
	return req->engine->emit_flush(req, EMIT_INVALIDATE);
1024 1025
}

1026 1027
static bool
i915_gem_check_execbuffer(struct drm_i915_gem_execbuffer2 *exec)
1028
{
1029 1030 1031
	if (exec->flags & __I915_EXEC_UNKNOWN_FLAGS)
		return false;

C
Chris Wilson 已提交
1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046
	/* Kernel clipping was a DRI1 misfeature */
	if (exec->num_cliprects || exec->cliprects_ptr)
		return false;

	if (exec->DR4 == 0xffffffff) {
		DRM_DEBUG("UXA submitting garbage DR4, fixing up\n");
		exec->DR4 = 0;
	}
	if (exec->DR1 || exec->DR4)
		return false;

	if ((exec->batch_start_offset | exec->batch_len) & 0x7)
		return false;

	return true;
1047 1048 1049
}

static int
1050 1051
validate_exec_list(struct drm_device *dev,
		   struct drm_i915_gem_exec_object2 *exec,
1052 1053
		   int count)
{
1054 1055
	unsigned relocs_total = 0;
	unsigned relocs_max = UINT_MAX / sizeof(struct drm_i915_gem_relocation_entry);
1056 1057 1058
	unsigned invalid_flags;
	int i;

1059 1060 1061
	/* INTERNAL flags must not overlap with external ones */
	BUILD_BUG_ON(__EXEC_OBJECT_INTERNAL_FLAGS & ~__EXEC_OBJECT_UNKNOWN_FLAGS);

1062 1063 1064
	invalid_flags = __EXEC_OBJECT_UNKNOWN_FLAGS;
	if (USES_FULL_PPGTT(dev))
		invalid_flags |= EXEC_OBJECT_NEEDS_GTT;
1065 1066

	for (i = 0; i < count; i++) {
1067
		char __user *ptr = u64_to_user_ptr(exec[i].relocs_ptr);
1068 1069
		int length; /* limited by fault_in_pages_readable() */

1070
		if (exec[i].flags & invalid_flags)
1071 1072
			return -EINVAL;

1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087
		/* Offset can be used as input (EXEC_OBJECT_PINNED), reject
		 * any non-page-aligned or non-canonical addresses.
		 */
		if (exec[i].flags & EXEC_OBJECT_PINNED) {
			if (exec[i].offset !=
			    gen8_canonical_addr(exec[i].offset & PAGE_MASK))
				return -EINVAL;

			/* From drm_mm perspective address space is continuous,
			 * so from this point we're always using non-canonical
			 * form internally.
			 */
			exec[i].offset = gen8_noncanonical_addr(exec[i].offset);
		}

1088 1089 1090
		if (exec[i].alignment && !is_power_of_2(exec[i].alignment))
			return -EINVAL;

1091 1092 1093 1094 1095 1096 1097 1098
		/* pad_to_size was once a reserved field, so sanitize it */
		if (exec[i].flags & EXEC_OBJECT_PAD_TO_SIZE) {
			if (offset_in_page(exec[i].pad_to_size))
				return -EINVAL;
		} else {
			exec[i].pad_to_size = 0;
		}

1099 1100 1101 1102 1103
		/* First check for malicious input causing overflow in
		 * the worst case where we need to allocate the entire
		 * relocation tree as a single array.
		 */
		if (exec[i].relocation_count > relocs_max - relocs_total)
1104
			return -EINVAL;
1105
		relocs_total += exec[i].relocation_count;
1106 1107 1108

		length = exec[i].relocation_count *
			sizeof(struct drm_i915_gem_relocation_entry);
1109 1110 1111 1112 1113
		/*
		 * We must check that the entire relocation array is safe
		 * to read, but since we may need to update the presumed
		 * offsets during execution, check for full write access.
		 */
1114 1115 1116
		if (!access_ok(VERIFY_WRITE, ptr, length))
			return -EFAULT;

1117
		if (likely(!i915.prefault_disable)) {
1118 1119 1120
			if (fault_in_multipages_readable(ptr, length))
				return -EFAULT;
		}
1121 1122 1123 1124 1125
	}

	return 0;
}

1126
static struct i915_gem_context *
1127
i915_gem_validate_context(struct drm_device *dev, struct drm_file *file,
1128
			  struct intel_engine_cs *engine, const u32 ctx_id)
1129
{
1130
	struct i915_gem_context *ctx = NULL;
1131 1132
	struct i915_ctx_hang_stats *hs;

1133
	if (engine->id != RCS && ctx_id != DEFAULT_CONTEXT_HANDLE)
1134 1135
		return ERR_PTR(-EINVAL);

1136
	ctx = i915_gem_context_lookup(file->driver_priv, ctx_id);
1137
	if (IS_ERR(ctx))
1138
		return ctx;
1139

1140
	hs = &ctx->hang_stats;
1141 1142
	if (hs->banned) {
		DRM_DEBUG("Context %u tried to submit while banned\n", ctx_id);
1143
		return ERR_PTR(-EIO);
1144 1145
	}

1146
	return ctx;
1147 1148
}

1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159
void i915_vma_move_to_active(struct i915_vma *vma,
			     struct drm_i915_gem_request *req,
			     unsigned int flags)
{
	struct drm_i915_gem_object *obj = vma->obj;
	const unsigned int idx = req->engine->id;

	GEM_BUG_ON(!drm_mm_node_allocated(&vma->node));

	obj->dirty = 1; /* be paranoid  */

1160 1161 1162 1163 1164 1165 1166
	/* Add a reference if we're newly entering the active list.
	 * The order in which we add operations to the retirement queue is
	 * vital here: mark_active adds to the start of the callback list,
	 * such that subsequent callbacks are called first. Therefore we
	 * add the active reference first and queue for it to be dropped
	 * *last*.
	 */
1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190
	if (obj->active == 0)
		i915_gem_object_get(obj);
	obj->active |= 1 << idx;
	i915_gem_active_set(&obj->last_read[idx], req);

	if (flags & EXEC_OBJECT_WRITE) {
		i915_gem_active_set(&obj->last_write, req);

		intel_fb_obj_invalidate(obj, ORIGIN_CS);

		/* update for the implicit flush after a batch */
		obj->base.write_domain &= ~I915_GEM_GPU_DOMAINS;
	}

	if (flags & EXEC_OBJECT_NEEDS_FENCE) {
		i915_gem_active_set(&obj->last_fence, req);
		if (flags & __EXEC_OBJECT_HAS_FENCE) {
			struct drm_i915_private *dev_priv = req->i915;

			list_move_tail(&dev_priv->fence_regs[obj->fence_reg].lru_list,
				       &dev_priv->mm.fence_list);
		}
	}

1191 1192
	i915_vma_set_active(vma, idx);
	i915_gem_active_set(&vma->last_read[idx], req);
1193 1194 1195
	list_move_tail(&vma->vm_link, &vma->vm->active_list);
}

1196
static void
1197
i915_gem_execbuffer_move_to_active(struct list_head *vmas,
1198
				   struct drm_i915_gem_request *req)
1199
{
1200
	struct i915_vma *vma;
1201

1202 1203
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
1204 1205
		u32 old_read = obj->base.read_domains;
		u32 old_write = obj->base.write_domain;
C
Chris Wilson 已提交
1206

1207
		obj->base.write_domain = obj->base.pending_write_domain;
1208 1209 1210
		if (obj->base.write_domain)
			vma->exec_entry->flags |= EXEC_OBJECT_WRITE;
		else
1211 1212
			obj->base.pending_read_domains |= obj->base.read_domains;
		obj->base.read_domains = obj->base.pending_read_domains;
1213

1214
		i915_vma_move_to_active(vma, req, vma->exec_entry->flags);
C
Chris Wilson 已提交
1215
		trace_i915_gem_object_change_domain(obj, old_read, old_write);
1216 1217 1218
	}
}

1219
static int
1220
i915_reset_gen7_sol_offsets(struct drm_i915_gem_request *req)
1221
{
1222
	struct intel_ring *ring = req->ring;
1223 1224
	int ret, i;

1225
	if (!IS_GEN7(req->i915) || req->engine->id != RCS) {
1226 1227 1228
		DRM_DEBUG("sol reset is gen7/rcs only\n");
		return -EINVAL;
	}
1229

1230
	ret = intel_ring_begin(req, 4 * 3);
1231 1232 1233 1234
	if (ret)
		return ret;

	for (i = 0; i < 4; i++) {
1235 1236 1237
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(ring, GEN7_SO_WRITE_OFFSET(i));
		intel_ring_emit(ring, 0);
1238 1239
	}

1240
	intel_ring_advance(ring);
1241 1242 1243 1244

	return 0;
}

1245
static struct i915_vma*
1246
i915_gem_execbuffer_parse(struct intel_engine_cs *engine,
1247 1248
			  struct drm_i915_gem_exec_object2 *shadow_exec_entry,
			  struct drm_i915_gem_object *batch_obj,
1249
			  struct eb_vmas *eb,
1250 1251
			  u32 batch_start_offset,
			  u32 batch_len,
1252
			  bool is_master)
1253 1254
{
	struct drm_i915_gem_object *shadow_batch_obj;
1255
	struct i915_vma *vma;
1256 1257
	int ret;

1258
	shadow_batch_obj = i915_gem_batch_pool_get(&engine->batch_pool,
1259
						   PAGE_ALIGN(batch_len));
1260
	if (IS_ERR(shadow_batch_obj))
1261
		return ERR_CAST(shadow_batch_obj);
1262

1263 1264 1265 1266 1267 1268
	ret = intel_engine_cmd_parser(engine,
				      batch_obj,
				      shadow_batch_obj,
				      batch_start_offset,
				      batch_len,
				      is_master);
1269 1270
	if (ret)
		goto err;
1271

1272 1273 1274
	ret = i915_gem_obj_ggtt_pin(shadow_batch_obj, 0, 0);
	if (ret)
		goto err;
1275

C
Chris Wilson 已提交
1276 1277
	i915_gem_object_unpin_pages(shadow_batch_obj);

1278
	memset(shadow_exec_entry, 0, sizeof(*shadow_exec_entry));
1279

1280 1281
	vma = i915_gem_obj_to_ggtt(shadow_batch_obj);
	vma->exec_entry = shadow_exec_entry;
C
Chris Wilson 已提交
1282
	vma->exec_entry->flags = __EXEC_OBJECT_HAS_PIN;
1283
	i915_gem_object_get(shadow_batch_obj);
1284
	list_add_tail(&vma->exec_list, &eb->vmas);
1285

1286
	return vma;
1287

1288
err:
C
Chris Wilson 已提交
1289
	i915_gem_object_unpin_pages(shadow_batch_obj);
1290
	if (ret == -EACCES) /* unhandled chained batch */
1291
		return NULL;
1292 1293
	else
		return ERR_PTR(ret);
1294
}
1295

1296 1297 1298 1299
static int
execbuf_submit(struct i915_execbuffer_params *params,
	       struct drm_i915_gem_execbuffer2 *args,
	       struct list_head *vmas)
1300
{
1301
	struct drm_i915_private *dev_priv = params->request->i915;
1302
	u64 exec_start, exec_len;
1303 1304
	int instp_mode;
	u32 instp_mask;
C
Chris Wilson 已提交
1305
	int ret;
1306

1307
	ret = i915_gem_execbuffer_move_to_gpu(params->request, vmas);
1308
	if (ret)
C
Chris Wilson 已提交
1309
		return ret;
1310

1311
	ret = i915_switch_context(params->request);
1312
	if (ret)
C
Chris Wilson 已提交
1313
		return ret;
1314 1315 1316 1317 1318 1319 1320

	instp_mode = args->flags & I915_EXEC_CONSTANTS_MASK;
	instp_mask = I915_EXEC_CONSTANTS_MASK;
	switch (instp_mode) {
	case I915_EXEC_CONSTANTS_REL_GENERAL:
	case I915_EXEC_CONSTANTS_ABSOLUTE:
	case I915_EXEC_CONSTANTS_REL_SURFACE:
1321
		if (instp_mode != 0 && params->engine->id != RCS) {
1322
			DRM_DEBUG("non-0 rel constants mode on non-RCS\n");
C
Chris Wilson 已提交
1323
			return -EINVAL;
1324 1325 1326
		}

		if (instp_mode != dev_priv->relative_constants_mode) {
1327
			if (INTEL_INFO(dev_priv)->gen < 4) {
1328
				DRM_DEBUG("no rel constants on pre-gen4\n");
C
Chris Wilson 已提交
1329
				return -EINVAL;
1330 1331
			}

1332
			if (INTEL_INFO(dev_priv)->gen > 5 &&
1333 1334
			    instp_mode == I915_EXEC_CONSTANTS_REL_SURFACE) {
				DRM_DEBUG("rel surface constants mode invalid on gen5+\n");
C
Chris Wilson 已提交
1335
				return -EINVAL;
1336 1337 1338
			}

			/* The HW changed the meaning on this bit on gen6 */
1339
			if (INTEL_INFO(dev_priv)->gen >= 6)
1340 1341 1342 1343 1344
				instp_mask &= ~I915_EXEC_CONSTANTS_REL_SURFACE;
		}
		break;
	default:
		DRM_DEBUG("execbuf with unknown constants: %d\n", instp_mode);
C
Chris Wilson 已提交
1345
		return -EINVAL;
1346 1347
	}

1348
	if (params->engine->id == RCS &&
C
Chris Wilson 已提交
1349
	    instp_mode != dev_priv->relative_constants_mode) {
1350
		struct intel_ring *ring = params->request->ring;
1351

1352
		ret = intel_ring_begin(params->request, 4);
1353
		if (ret)
C
Chris Wilson 已提交
1354
			return ret;
1355

1356 1357 1358 1359 1360
		intel_ring_emit(ring, MI_NOOP);
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(ring, INSTPM);
		intel_ring_emit(ring, instp_mask << 16 | instp_mode);
		intel_ring_advance(ring);
1361 1362 1363 1364 1365

		dev_priv->relative_constants_mode = instp_mode;
	}

	if (args->flags & I915_EXEC_GEN7_SOL_RESET) {
1366
		ret = i915_reset_gen7_sol_offsets(params->request);
1367
		if (ret)
C
Chris Wilson 已提交
1368
			return ret;
1369 1370
	}

1371
	exec_len   = args->batch_len;
1372
	exec_start = params->batch->node.start +
1373 1374
		     params->args_batch_start_offset;

1375
	if (exec_len == 0)
1376
		exec_len = params->batch->size;
1377

1378 1379 1380
	ret = params->engine->emit_bb_start(params->request,
					    exec_start, exec_len,
					    params->dispatch_flags);
C
Chris Wilson 已提交
1381 1382
	if (ret)
		return ret;
1383

1384
	trace_i915_gem_ring_dispatch(params->request, params->dispatch_flags);
1385

1386
	i915_gem_execbuffer_move_to_active(vmas, params->request);
1387

C
Chris Wilson 已提交
1388
	return 0;
1389 1390
}

1391 1392
/**
 * Find one BSD ring to dispatch the corresponding BSD command.
1393
 * The engine index is returned.
1394
 */
1395
static unsigned int
1396 1397
gen8_dispatch_bsd_engine(struct drm_i915_private *dev_priv,
			 struct drm_file *file)
1398 1399 1400
{
	struct drm_i915_file_private *file_priv = file->driver_priv;

1401
	/* Check whether the file_priv has already selected one ring. */
1402
	if ((int)file_priv->bsd_engine < 0) {
1403
		/* If not, use the ping-pong mechanism to select one. */
1404
		mutex_lock(&dev_priv->drm.struct_mutex);
1405 1406
		file_priv->bsd_engine = dev_priv->mm.bsd_engine_dispatch_index;
		dev_priv->mm.bsd_engine_dispatch_index ^= 1;
1407
		mutex_unlock(&dev_priv->drm.struct_mutex);
1408
	}
1409

1410
	return file_priv->bsd_engine;
1411 1412
}

1413 1414
#define I915_USER_RINGS (4)

1415
static const enum intel_engine_id user_ring_map[I915_USER_RINGS + 1] = {
1416 1417 1418 1419 1420 1421 1422
	[I915_EXEC_DEFAULT]	= RCS,
	[I915_EXEC_RENDER]	= RCS,
	[I915_EXEC_BLT]		= BCS,
	[I915_EXEC_BSD]		= VCS,
	[I915_EXEC_VEBOX]	= VECS
};

1423 1424 1425 1426
static struct intel_engine_cs *
eb_select_engine(struct drm_i915_private *dev_priv,
		 struct drm_file *file,
		 struct drm_i915_gem_execbuffer2 *args)
1427 1428
{
	unsigned int user_ring_id = args->flags & I915_EXEC_RING_MASK;
1429
	struct intel_engine_cs *engine;
1430 1431 1432

	if (user_ring_id > I915_USER_RINGS) {
		DRM_DEBUG("execbuf with unknown ring: %u\n", user_ring_id);
1433
		return NULL;
1434 1435 1436 1437 1438 1439
	}

	if ((user_ring_id != I915_EXEC_BSD) &&
	    ((args->flags & I915_EXEC_BSD_MASK) != 0)) {
		DRM_DEBUG("execbuf with non bsd ring but with invalid "
			  "bsd dispatch flags: %d\n", (int)(args->flags));
1440
		return NULL;
1441 1442 1443 1444 1445 1446
	}

	if (user_ring_id == I915_EXEC_BSD && HAS_BSD2(dev_priv)) {
		unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;

		if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
1447
			bsd_idx = gen8_dispatch_bsd_engine(dev_priv, file);
1448 1449
		} else if (bsd_idx >= I915_EXEC_BSD_RING1 &&
			   bsd_idx <= I915_EXEC_BSD_RING2) {
1450
			bsd_idx >>= I915_EXEC_BSD_SHIFT;
1451 1452 1453 1454
			bsd_idx--;
		} else {
			DRM_DEBUG("execbuf with unknown bsd ring: %u\n",
				  bsd_idx);
1455
			return NULL;
1456 1457
		}

1458
		engine = &dev_priv->engine[_VCS(bsd_idx)];
1459
	} else {
1460
		engine = &dev_priv->engine[user_ring_map[user_ring_id]];
1461 1462
	}

1463
	if (!intel_engine_initialized(engine)) {
1464
		DRM_DEBUG("execbuf with invalid ring: %u\n", user_ring_id);
1465
		return NULL;
1466 1467
	}

1468
	return engine;
1469 1470
}

1471 1472 1473 1474
static int
i915_gem_do_execbuffer(struct drm_device *dev, void *data,
		       struct drm_file *file,
		       struct drm_i915_gem_execbuffer2 *args,
1475
		       struct drm_i915_gem_exec_object2 *exec)
1476
{
1477 1478
	struct drm_i915_private *dev_priv = to_i915(dev);
	struct i915_ggtt *ggtt = &dev_priv->ggtt;
1479
	struct eb_vmas *eb;
1480
	struct drm_i915_gem_exec_object2 shadow_exec_entry;
1481
	struct intel_engine_cs *engine;
1482
	struct i915_gem_context *ctx;
1483
	struct i915_address_space *vm;
1484 1485
	struct i915_execbuffer_params params_master; /* XXX: will be removed later */
	struct i915_execbuffer_params *params = &params_master;
1486
	const u32 ctx_id = i915_execbuffer2_get_context_id(*args);
1487
	u32 dispatch_flags;
1488
	int ret;
1489
	bool need_relocs;
1490

1491
	if (!i915_gem_check_execbuffer(args))
1492 1493
		return -EINVAL;

1494
	ret = validate_exec_list(dev, exec, args->buffer_count);
1495 1496 1497
	if (ret)
		return ret;

1498
	dispatch_flags = 0;
1499
	if (args->flags & I915_EXEC_SECURE) {
1500
		if (!drm_is_current_master(file) || !capable(CAP_SYS_ADMIN))
1501 1502
		    return -EPERM;

1503
		dispatch_flags |= I915_DISPATCH_SECURE;
1504
	}
1505
	if (args->flags & I915_EXEC_IS_PINNED)
1506
		dispatch_flags |= I915_DISPATCH_PINNED;
1507

1508 1509 1510
	engine = eb_select_engine(dev_priv, file, args);
	if (!engine)
		return -EINVAL;
1511 1512

	if (args->buffer_count < 1) {
1513
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1514 1515 1516
		return -EINVAL;
	}

1517 1518 1519 1520 1521
	if (args->flags & I915_EXEC_RESOURCE_STREAMER) {
		if (!HAS_RESOURCE_STREAMER(dev)) {
			DRM_DEBUG("RS is only allowed for Haswell, Gen8 and above\n");
			return -EINVAL;
		}
1522
		if (engine->id != RCS) {
1523
			DRM_DEBUG("RS is not available on %s\n",
1524
				 engine->name);
1525 1526 1527 1528 1529 1530
			return -EINVAL;
		}

		dispatch_flags |= I915_DISPATCH_RS;
	}

1531 1532 1533 1534 1535 1536
	/* Take a local wakeref for preparing to dispatch the execbuf as
	 * we expect to access the hardware fairly frequently in the
	 * process. Upon first dispatch, we acquire another prolonged
	 * wakeref that we hold until the GPU has been idle for at least
	 * 100ms.
	 */
1537 1538
	intel_runtime_pm_get(dev_priv);

1539 1540 1541 1542
	ret = i915_mutex_lock_interruptible(dev);
	if (ret)
		goto pre_mutex_err;

1543
	ctx = i915_gem_validate_context(dev, file, engine, ctx_id);
1544
	if (IS_ERR(ctx)) {
1545
		mutex_unlock(&dev->struct_mutex);
1546
		ret = PTR_ERR(ctx);
1547
		goto pre_mutex_err;
1548
	}
1549

1550
	i915_gem_context_get(ctx);
1551

1552 1553 1554
	if (ctx->ppgtt)
		vm = &ctx->ppgtt->base;
	else
1555
		vm = &ggtt->base;
1556

1557 1558
	memset(&params_master, 0x00, sizeof(params_master));

B
Ben Widawsky 已提交
1559
	eb = eb_create(args);
1560
	if (eb == NULL) {
1561
		i915_gem_context_put(ctx);
1562 1563 1564 1565 1566
		mutex_unlock(&dev->struct_mutex);
		ret = -ENOMEM;
		goto pre_mutex_err;
	}

1567
	/* Look up object handles */
1568
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
1569 1570
	if (ret)
		goto err;
1571

1572
	/* take note of the batch buffer before we might reorder the lists */
1573
	params->batch = eb_get_batch(eb);
1574

1575
	/* Move the objects en-masse into the GTT, evicting if necessary. */
1576
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
1577 1578
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
1579 1580 1581 1582
	if (ret)
		goto err;

	/* The objects are in their final locations, apply the relocations. */
1583
	if (need_relocs)
B
Ben Widawsky 已提交
1584
		ret = i915_gem_execbuffer_relocate(eb);
1585 1586
	if (ret) {
		if (ret == -EFAULT) {
1587 1588
			ret = i915_gem_execbuffer_relocate_slow(dev, args, file,
								engine,
1589
								eb, exec, ctx);
1590 1591 1592 1593 1594 1595 1596
			BUG_ON(!mutex_is_locked(&dev->struct_mutex));
		}
		if (ret)
			goto err;
	}

	/* Set the pending read domains for the batch buffer to COMMAND */
1597
	if (params->batch->obj->base.pending_write_domain) {
1598
		DRM_DEBUG("Attempting to use self-modifying batch buffer\n");
1599 1600 1601 1602
		ret = -EINVAL;
		goto err;
	}

1603
	params->args_batch_start_offset = args->batch_start_offset;
1604
	if (intel_engine_needs_cmd_parser(engine) && args->batch_len) {
1605 1606 1607 1608 1609 1610 1611 1612 1613 1614
		struct i915_vma *vma;

		vma = i915_gem_execbuffer_parse(engine, &shadow_exec_entry,
						params->batch->obj,
						eb,
						args->batch_start_offset,
						args->batch_len,
						drm_is_current_master(file));
		if (IS_ERR(vma)) {
			ret = PTR_ERR(vma);
1615 1616
			goto err;
		}
1617

1618
		if (vma) {
1619 1620 1621 1622 1623 1624 1625 1626 1627 1628
			/*
			 * Batch parsed and accepted:
			 *
			 * Set the DISPATCH_SECURE bit to remove the NON_SECURE
			 * bit from MI_BATCH_BUFFER_START commands issued in
			 * the dispatch_execbuffer implementations. We
			 * specifically don't want that set on batches the
			 * command parser has accepted.
			 */
			dispatch_flags |= I915_DISPATCH_SECURE;
1629
			params->args_batch_start_offset = 0;
1630
			params->batch = vma;
1631
		}
1632 1633
	}

1634
	params->batch->obj->base.pending_read_domains |= I915_GEM_DOMAIN_COMMAND;
1635

1636 1637
	/* snb/ivb/vlv conflate the "batch in ppgtt" bit with the "non-secure
	 * batch" bit. Hence we need to pin secure batches into the global gtt.
B
Ben Widawsky 已提交
1638
	 * hsw should have this fixed, but bdw mucks it up again. */
1639
	if (dispatch_flags & I915_DISPATCH_SECURE) {
1640 1641
		struct drm_i915_gem_object *obj = params->batch->obj;

1642 1643 1644 1645 1646 1647
		/*
		 * So on first glance it looks freaky that we pin the batch here
		 * outside of the reservation loop. But:
		 * - The batch is already pinned into the relevant ppgtt, so we
		 *   already have the backing storage fully allocated.
		 * - No other BO uses the global gtt (well contexts, but meh),
1648
		 *   so we don't really have issues with multiple objects not
1649 1650 1651
		 *   fitting due to fragmentation.
		 * So this is actually safe.
		 */
1652
		ret = i915_gem_obj_ggtt_pin(obj, 0, 0);
1653 1654
		if (ret)
			goto err;
1655

1656 1657
		params->batch = i915_gem_obj_to_ggtt(obj);
	}
1658

1659
	/* Allocate a request for this batch buffer nice and early. */
1660 1661 1662
	params->request = i915_gem_request_alloc(engine, ctx);
	if (IS_ERR(params->request)) {
		ret = PTR_ERR(params->request);
1663
		goto err_batch_unpin;
1664
	}
1665

1666
	ret = i915_gem_request_add_to_client(params->request, file);
1667
	if (ret)
1668
		goto err_request;
1669

1670 1671 1672 1673 1674 1675 1676 1677
	/*
	 * Save assorted stuff away to pass through to *_submission().
	 * NB: This data should be 'persistent' and not local as it will
	 * kept around beyond the duration of the IOCTL once the GPU
	 * scheduler arrives.
	 */
	params->dev                     = dev;
	params->file                    = file;
1678
	params->engine                    = engine;
1679 1680 1681
	params->dispatch_flags          = dispatch_flags;
	params->ctx                     = ctx;

1682
	ret = execbuf_submit(params, args, &eb->vmas);
1683
err_request:
1684
	__i915_add_request(params->request, params->batch->obj, ret == 0);
1685

1686
err_batch_unpin:
1687 1688 1689 1690 1691 1692
	/*
	 * FIXME: We crucially rely upon the active tracking for the (ppgtt)
	 * batch vma for correctness. For less ugly and less fragility this
	 * needs to be adjusted to also track the ggtt batch vma properly as
	 * active.
	 */
1693
	if (dispatch_flags & I915_DISPATCH_SECURE)
1694
		i915_vma_unpin(params->batch);
1695
err:
1696
	/* the request owns the ref now */
1697
	i915_gem_context_put(ctx);
1698
	eb_destroy(eb);
1699 1700 1701 1702

	mutex_unlock(&dev->struct_mutex);

pre_mutex_err:
1703 1704 1705
	/* intel_gpu_busy should also get a ref, so it will free when the device
	 * is really idle. */
	intel_runtime_pm_put(dev_priv);
1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723
	return ret;
}

/*
 * Legacy execbuffer just creates an exec2 list from the original exec object
 * list array and passes it to the real function.
 */
int
i915_gem_execbuffer(struct drm_device *dev, void *data,
		    struct drm_file *file)
{
	struct drm_i915_gem_execbuffer *args = data;
	struct drm_i915_gem_execbuffer2 exec2;
	struct drm_i915_gem_exec_object *exec_list = NULL;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret, i;

	if (args->buffer_count < 1) {
1724
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1725 1726 1727 1728 1729 1730 1731
		return -EINVAL;
	}

	/* Copy in the exec list from userland */
	exec_list = drm_malloc_ab(sizeof(*exec_list), args->buffer_count);
	exec2_list = drm_malloc_ab(sizeof(*exec2_list), args->buffer_count);
	if (exec_list == NULL || exec2_list == NULL) {
1732
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1733 1734 1735 1736 1737 1738
			  args->buffer_count);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -ENOMEM;
	}
	ret = copy_from_user(exec_list,
1739
			     u64_to_user_ptr(args->buffers_ptr),
1740 1741
			     sizeof(*exec_list) * args->buffer_count);
	if (ret != 0) {
1742
		DRM_DEBUG("copy %d exec entries failed %d\n",
1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769
			  args->buffer_count, ret);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

	for (i = 0; i < args->buffer_count; i++) {
		exec2_list[i].handle = exec_list[i].handle;
		exec2_list[i].relocation_count = exec_list[i].relocation_count;
		exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr;
		exec2_list[i].alignment = exec_list[i].alignment;
		exec2_list[i].offset = exec_list[i].offset;
		if (INTEL_INFO(dev)->gen < 4)
			exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE;
		else
			exec2_list[i].flags = 0;
	}

	exec2.buffers_ptr = args->buffers_ptr;
	exec2.buffer_count = args->buffer_count;
	exec2.batch_start_offset = args->batch_start_offset;
	exec2.batch_len = args->batch_len;
	exec2.DR1 = args->DR1;
	exec2.DR4 = args->DR4;
	exec2.num_cliprects = args->num_cliprects;
	exec2.cliprects_ptr = args->cliprects_ptr;
	exec2.flags = I915_EXEC_RENDER;
1770
	i915_execbuffer2_set_context_id(exec2, 0);
1771

1772
	ret = i915_gem_do_execbuffer(dev, data, file, &exec2, exec2_list);
1773
	if (!ret) {
1774
		struct drm_i915_gem_exec_object __user *user_exec_list =
1775
			u64_to_user_ptr(args->buffers_ptr);
1776

1777
		/* Copy the new buffer offsets back to the user's exec list. */
1778
		for (i = 0; i < args->buffer_count; i++) {
1779 1780
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1781 1782 1783 1784 1785 1786 1787 1788 1789 1790
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user (%d)\n",
					  args->buffer_count, ret);
				break;
			}
1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806
		}
	}

	drm_free_large(exec_list);
	drm_free_large(exec2_list);
	return ret;
}

int
i915_gem_execbuffer2(struct drm_device *dev, void *data,
		     struct drm_file *file)
{
	struct drm_i915_gem_execbuffer2 *args = data;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret;

1807 1808
	if (args->buffer_count < 1 ||
	    args->buffer_count > UINT_MAX / sizeof(*exec2_list)) {
1809
		DRM_DEBUG("execbuf2 with %d buffers\n", args->buffer_count);
1810 1811 1812
		return -EINVAL;
	}

1813 1814 1815 1816 1817
	if (args->rsvd2 != 0) {
		DRM_DEBUG("dirty rvsd2 field\n");
		return -EINVAL;
	}

1818 1819 1820
	exec2_list = drm_malloc_gfp(args->buffer_count,
				    sizeof(*exec2_list),
				    GFP_TEMPORARY);
1821
	if (exec2_list == NULL) {
1822
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1823 1824 1825 1826
			  args->buffer_count);
		return -ENOMEM;
	}
	ret = copy_from_user(exec2_list,
1827
			     u64_to_user_ptr(args->buffers_ptr),
1828 1829
			     sizeof(*exec2_list) * args->buffer_count);
	if (ret != 0) {
1830
		DRM_DEBUG("copy %d exec entries failed %d\n",
1831 1832 1833 1834 1835
			  args->buffer_count, ret);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

1836
	ret = i915_gem_do_execbuffer(dev, data, file, args, exec2_list);
1837 1838
	if (!ret) {
		/* Copy the new buffer offsets back to the user's exec list. */
1839
		struct drm_i915_gem_exec_object2 __user *user_exec_list =
1840
				   u64_to_user_ptr(args->buffers_ptr);
1841 1842 1843
		int i;

		for (i = 0; i < args->buffer_count; i++) {
1844 1845
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1846 1847 1848 1849 1850 1851 1852 1853 1854 1855
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user\n",
					  args->buffer_count);
				break;
			}
1856 1857 1858 1859 1860 1861
		}
	}

	drm_free_large(exec2_list);
	return ret;
}