i915_gem_execbuffer.c 49.4 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
/*
 * Copyright © 2008,2010 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 *
 * Authors:
 *    Eric Anholt <eric@anholt.net>
 *    Chris Wilson <chris@chris-wilson.co.uk>
 *
 */

29 30
#include <drm/drmP.h>
#include <drm/i915_drm.h>
31 32 33
#include "i915_drv.h"
#include "i915_trace.h"
#include "intel_drv.h"
34
#include <linux/dma_remapping.h>
35
#include <linux/uaccess.h>
36

37 38
#define  __EXEC_OBJECT_HAS_PIN (1<<31)
#define  __EXEC_OBJECT_HAS_FENCE (1<<30)
39
#define  __EXEC_OBJECT_NEEDS_MAP (1<<29)
40 41 42
#define  __EXEC_OBJECT_NEEDS_BIAS (1<<28)

#define BATCH_OFFSET_BIAS (256*1024)
43

44 45
struct eb_vmas {
	struct list_head vmas;
46
	int and;
47
	union {
48
		struct i915_vma *lut[0];
49 50
		struct hlist_head buckets[0];
	};
51 52
};

53
static struct eb_vmas *
B
Ben Widawsky 已提交
54
eb_create(struct drm_i915_gem_execbuffer2 *args)
55
{
56
	struct eb_vmas *eb = NULL;
57 58

	if (args->flags & I915_EXEC_HANDLE_LUT) {
59
		unsigned size = args->buffer_count;
60 61
		size *= sizeof(struct i915_vma *);
		size += sizeof(struct eb_vmas);
62 63 64 65
		eb = kmalloc(size, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
	}

	if (eb == NULL) {
66 67
		unsigned size = args->buffer_count;
		unsigned count = PAGE_SIZE / sizeof(struct hlist_head) / 2;
L
Lauri Kasanen 已提交
68
		BUILD_BUG_ON_NOT_POWER_OF_2(PAGE_SIZE / sizeof(struct hlist_head));
69 70 71
		while (count > 2*size)
			count >>= 1;
		eb = kzalloc(count*sizeof(struct hlist_head) +
72
			     sizeof(struct eb_vmas),
73 74 75 76 77 78 79 80
			     GFP_TEMPORARY);
		if (eb == NULL)
			return eb;

		eb->and = count - 1;
	} else
		eb->and = -args->buffer_count;

81
	INIT_LIST_HEAD(&eb->vmas);
82 83 84 85
	return eb;
}

static void
86
eb_reset(struct eb_vmas *eb)
87
{
88 89
	if (eb->and >= 0)
		memset(eb->buckets, 0, (eb->and+1)*sizeof(struct hlist_head));
90 91
}

92
static int
93 94 95 96 97
eb_lookup_vmas(struct eb_vmas *eb,
	       struct drm_i915_gem_exec_object2 *exec,
	       const struct drm_i915_gem_execbuffer2 *args,
	       struct i915_address_space *vm,
	       struct drm_file *file)
98
{
99 100
	struct drm_i915_gem_object *obj;
	struct list_head objects;
101
	int i, ret;
102

103
	INIT_LIST_HEAD(&objects);
104
	spin_lock(&file->table_lock);
105 106
	/* Grab a reference to the object and release the lock so we can lookup
	 * or create the VMA without using GFP_ATOMIC */
107
	for (i = 0; i < args->buffer_count; i++) {
108 109 110 111 112
		obj = to_intel_bo(idr_find(&file->object_idr, exec[i].handle));
		if (obj == NULL) {
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Invalid object handle %d at index %d\n",
				   exec[i].handle, i);
113
			ret = -ENOENT;
114
			goto err;
115 116
		}

117
		if (!list_empty(&obj->obj_exec_link)) {
118 119 120
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Object %p [handle %d, index %d] appears more than once in object list\n",
				   obj, exec[i].handle, i);
121
			ret = -EINVAL;
122
			goto err;
123 124 125
		}

		drm_gem_object_reference(&obj->base);
126 127 128
		list_add_tail(&obj->obj_exec_link, &objects);
	}
	spin_unlock(&file->table_lock);
129

130
	i = 0;
131
	while (!list_empty(&objects)) {
132
		struct i915_vma *vma;
133

134 135 136 137
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);

138 139 140 141 142 143 144 145
		/*
		 * NOTE: We can leak any vmas created here when something fails
		 * later on. But that's no issue since vma_unbind can deal with
		 * vmas which are not actually bound. And since only
		 * lookup_or_create exists as an interface to get at the vma
		 * from the (obj, vm) we don't run the risk of creating
		 * duplicated vmas for the same vm.
		 */
146
		vma = i915_gem_obj_lookup_or_create_vma(obj, vm);
147 148 149
		if (IS_ERR(vma)) {
			DRM_DEBUG("Failed to lookup VMA\n");
			ret = PTR_ERR(vma);
150
			goto err;
151 152
		}

153
		/* Transfer ownership from the objects list to the vmas list. */
154
		list_add_tail(&vma->exec_list, &eb->vmas);
155
		list_del_init(&obj->obj_exec_link);
156 157

		vma->exec_entry = &exec[i];
158
		if (eb->and < 0) {
159
			eb->lut[i] = vma;
160 161
		} else {
			uint32_t handle = args->flags & I915_EXEC_HANDLE_LUT ? i : exec[i].handle;
162 163
			vma->exec_handle = handle;
			hlist_add_head(&vma->exec_node,
164 165
				       &eb->buckets[handle & eb->and]);
		}
166
		++i;
167 168
	}

169
	return 0;
170 171


172
err:
173 174 175 176 177
	while (!list_empty(&objects)) {
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);
		list_del_init(&obj->obj_exec_link);
178
		drm_gem_object_unreference(&obj->base);
179
	}
180 181 182 183 184
	/*
	 * Objects already transfered to the vmas list will be unreferenced by
	 * eb_destroy.
	 */

185
	return ret;
186 187
}

188
static struct i915_vma *eb_get_vma(struct eb_vmas *eb, unsigned long handle)
189
{
190 191 192 193 194 195 196
	if (eb->and < 0) {
		if (handle >= -eb->and)
			return NULL;
		return eb->lut[handle];
	} else {
		struct hlist_head *head;
		struct hlist_node *node;
197

198 199
		head = &eb->buckets[handle & eb->and];
		hlist_for_each(node, head) {
200
			struct i915_vma *vma;
201

202 203 204
			vma = hlist_entry(node, struct i915_vma, exec_node);
			if (vma->exec_handle == handle)
				return vma;
205 206 207
		}
		return NULL;
	}
208 209
}

210 211 212 213 214 215 216 217 218 219 220 221 222 223 224
static void
i915_gem_execbuffer_unreserve_vma(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry;
	struct drm_i915_gem_object *obj = vma->obj;

	if (!drm_mm_node_allocated(&vma->node))
		return;

	entry = vma->exec_entry;

	if (entry->flags & __EXEC_OBJECT_HAS_FENCE)
		i915_gem_object_unpin_fence(obj);

	if (entry->flags & __EXEC_OBJECT_HAS_PIN)
225
		vma->pin_count--;
226

C
Chris Wilson 已提交
227
	entry->flags &= ~(__EXEC_OBJECT_HAS_FENCE | __EXEC_OBJECT_HAS_PIN);
228 229 230 231
}

static void eb_destroy(struct eb_vmas *eb)
{
232 233
	while (!list_empty(&eb->vmas)) {
		struct i915_vma *vma;
234

235 236
		vma = list_first_entry(&eb->vmas,
				       struct i915_vma,
237
				       exec_list);
238
		list_del_init(&vma->exec_list);
239
		i915_gem_execbuffer_unreserve_vma(vma);
240
		drm_gem_object_unreference(&vma->obj->base);
241
	}
242 243 244
	kfree(eb);
}

245 246
static inline int use_cpu_reloc(struct drm_i915_gem_object *obj)
{
247 248
	return (HAS_LLC(obj->base.dev) ||
		obj->base.write_domain == I915_GEM_DOMAIN_CPU ||
249 250 251
		obj->cache_level != I915_CACHE_NONE);
}

252 253
static int
relocate_entry_cpu(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
254 255
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
256
{
257
	struct drm_device *dev = obj->base.dev;
258
	uint32_t page_offset = offset_in_page(reloc->offset);
B
Ben Widawsky 已提交
259
	uint64_t delta = reloc->delta + target_offset;
260
	char *vaddr;
261
	int ret;
262

263
	ret = i915_gem_object_set_to_cpu_domain(obj, true);
264 265 266 267 268
	if (ret)
		return ret;

	vaddr = kmap_atomic(i915_gem_object_get_page(obj,
				reloc->offset >> PAGE_SHIFT));
B
Ben Widawsky 已提交
269
	*(uint32_t *)(vaddr + page_offset) = lower_32_bits(delta);
270 271 272 273 274 275 276 277 278 279

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
			vaddr = kmap_atomic(i915_gem_object_get_page(obj,
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

B
Ben Widawsky 已提交
280
		*(uint32_t *)(vaddr + page_offset) = upper_32_bits(delta);
281 282
	}

283 284 285 286 287 288 289
	kunmap_atomic(vaddr);

	return 0;
}

static int
relocate_entry_gtt(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
290 291
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
292 293 294
{
	struct drm_device *dev = obj->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
B
Ben Widawsky 已提交
295
	uint64_t delta = reloc->delta + target_offset;
296
	uint64_t offset;
297
	void __iomem *reloc_page;
298
	int ret;
299 300 301 302 303 304 305 306 307 308

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

	ret = i915_gem_object_put_fence(obj);
	if (ret)
		return ret;

	/* Map the page containing the relocation we're going to perform.  */
309 310
	offset = i915_gem_obj_ggtt_offset(obj);
	offset += reloc->offset;
311
	reloc_page = io_mapping_map_atomic_wc(dev_priv->gtt.mappable,
312 313
					      offset & PAGE_MASK);
	iowrite32(lower_32_bits(delta), reloc_page + offset_in_page(offset));
314 315

	if (INTEL_INFO(dev)->gen >= 8) {
316
		offset += sizeof(uint32_t);
317

318
		if (offset_in_page(offset) == 0) {
319
			io_mapping_unmap_atomic(reloc_page);
320 321 322
			reloc_page =
				io_mapping_map_atomic_wc(dev_priv->gtt.mappable,
							 offset);
323 324
		}

325 326
		iowrite32(upper_32_bits(delta),
			  reloc_page + offset_in_page(offset));
327 328
	}

329 330 331 332 333
	io_mapping_unmap_atomic(reloc_page);

	return 0;
}

334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
static void
clflush_write32(void *addr, uint32_t value)
{
	/* This is not a fast path, so KISS. */
	drm_clflush_virt_range(addr, sizeof(uint32_t));
	*(uint32_t *)addr = value;
	drm_clflush_virt_range(addr, sizeof(uint32_t));
}

static int
relocate_entry_clflush(struct drm_i915_gem_object *obj,
		       struct drm_i915_gem_relocation_entry *reloc,
		       uint64_t target_offset)
{
	struct drm_device *dev = obj->base.dev;
	uint32_t page_offset = offset_in_page(reloc->offset);
	uint64_t delta = (int)reloc->delta + target_offset;
	char *vaddr;
	int ret;

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

	vaddr = kmap_atomic(i915_gem_object_get_page(obj,
				reloc->offset >> PAGE_SHIFT));
	clflush_write32(vaddr + page_offset, lower_32_bits(delta));

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
			vaddr = kmap_atomic(i915_gem_object_get_page(obj,
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

		clflush_write32(vaddr + page_offset, upper_32_bits(delta));
	}

	kunmap_atomic(vaddr);

	return 0;
}

379 380
static int
i915_gem_execbuffer_relocate_entry(struct drm_i915_gem_object *obj,
381
				   struct eb_vmas *eb,
382
				   struct drm_i915_gem_relocation_entry *reloc)
383 384 385
{
	struct drm_device *dev = obj->base.dev;
	struct drm_gem_object *target_obj;
386
	struct drm_i915_gem_object *target_i915_obj;
387
	struct i915_vma *target_vma;
B
Ben Widawsky 已提交
388
	uint64_t target_offset;
389
	int ret;
390

391
	/* we've already hold a reference to all valid objects */
392 393
	target_vma = eb_get_vma(eb, reloc->target_handle);
	if (unlikely(target_vma == NULL))
394
		return -ENOENT;
395 396
	target_i915_obj = target_vma->obj;
	target_obj = &target_vma->obj->base;
397

398
	target_offset = target_vma->node.start;
399

400 401 402 403
	/* Sandybridge PPGTT errata: We need a global gtt mapping for MI and
	 * pipe_control writes because the gpu doesn't properly redirect them
	 * through the ppgtt for non_secure batchbuffers. */
	if (unlikely(IS_GEN6(dev) &&
404
	    reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION)) {
405
		ret = i915_vma_bind(target_vma, target_i915_obj->cache_level,
406
				    PIN_GLOBAL);
407 408 409
		if (WARN_ONCE(ret, "Unexpected failure to bind target VMA!"))
			return ret;
	}
410

411
	/* Validate that the target is in a valid r/w GPU domain */
412
	if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) {
413
		DRM_DEBUG("reloc with multiple write domains: "
414 415 416 417 418 419
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
420
		return -EINVAL;
421
	}
422 423
	if (unlikely((reloc->write_domain | reloc->read_domains)
		     & ~I915_GEM_GPU_DOMAINS)) {
424
		DRM_DEBUG("reloc with read/write non-GPU domains: "
425 426 427 428 429 430
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
431
		return -EINVAL;
432 433 434 435 436 437 438 439 440
	}

	target_obj->pending_read_domains |= reloc->read_domains;
	target_obj->pending_write_domain |= reloc->write_domain;

	/* If the relocation already has the right value in it, no
	 * more work needs to be done.
	 */
	if (target_offset == reloc->presumed_offset)
441
		return 0;
442 443

	/* Check that the relocation address is valid... */
444 445
	if (unlikely(reloc->offset >
		obj->base.size - (INTEL_INFO(dev)->gen >= 8 ? 8 : 4))) {
446
		DRM_DEBUG("Relocation beyond object bounds: "
447 448 449 450
			  "obj %p target %d offset %d size %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  (int) obj->base.size);
451
		return -EINVAL;
452
	}
453
	if (unlikely(reloc->offset & 3)) {
454
		DRM_DEBUG("Relocation not 4-byte aligned: "
455 456 457
			  "obj %p target %d offset %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset);
458
		return -EINVAL;
459 460
	}

461
	/* We can't wait for rendering with pagefaults disabled */
462
	if (obj->active && pagefault_disabled())
463 464
		return -EFAULT;

465
	if (use_cpu_reloc(obj))
B
Ben Widawsky 已提交
466
		ret = relocate_entry_cpu(obj, reloc, target_offset);
467
	else if (obj->map_and_fenceable)
B
Ben Widawsky 已提交
468
		ret = relocate_entry_gtt(obj, reloc, target_offset);
469 470 471 472 473 474
	else if (cpu_has_clflush)
		ret = relocate_entry_clflush(obj, reloc, target_offset);
	else {
		WARN_ONCE(1, "Impossible case in relocation handling\n");
		ret = -ENODEV;
	}
475

476 477 478
	if (ret)
		return ret;

479 480 481
	/* and update the user's relocation entry */
	reloc->presumed_offset = target_offset;

482
	return 0;
483 484 485
}

static int
486 487
i915_gem_execbuffer_relocate_vma(struct i915_vma *vma,
				 struct eb_vmas *eb)
488
{
489 490
#define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry))
	struct drm_i915_gem_relocation_entry stack_reloc[N_RELOC(512)];
491
	struct drm_i915_gem_relocation_entry __user *user_relocs;
492
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
493
	int remain, ret;
494

V
Ville Syrjälä 已提交
495
	user_relocs = to_user_ptr(entry->relocs_ptr);
496

497 498 499 500 501 502 503 504 505
	remain = entry->relocation_count;
	while (remain) {
		struct drm_i915_gem_relocation_entry *r = stack_reloc;
		int count = remain;
		if (count > ARRAY_SIZE(stack_reloc))
			count = ARRAY_SIZE(stack_reloc);
		remain -= count;

		if (__copy_from_user_inatomic(r, user_relocs, count*sizeof(r[0])))
506 507
			return -EFAULT;

508 509
		do {
			u64 offset = r->presumed_offset;
510

511
			ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, r);
512 513 514 515 516 517 518 519 520 521 522 523 524
			if (ret)
				return ret;

			if (r->presumed_offset != offset &&
			    __copy_to_user_inatomic(&user_relocs->presumed_offset,
						    &r->presumed_offset,
						    sizeof(r->presumed_offset))) {
				return -EFAULT;
			}

			user_relocs++;
			r++;
		} while (--count);
525 526 527
	}

	return 0;
528
#undef N_RELOC
529 530 531
}

static int
532 533 534
i915_gem_execbuffer_relocate_vma_slow(struct i915_vma *vma,
				      struct eb_vmas *eb,
				      struct drm_i915_gem_relocation_entry *relocs)
535
{
536
	const struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
537 538 539
	int i, ret;

	for (i = 0; i < entry->relocation_count; i++) {
540
		ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, &relocs[i]);
541 542 543 544 545 546 547 548
		if (ret)
			return ret;
	}

	return 0;
}

static int
B
Ben Widawsky 已提交
549
i915_gem_execbuffer_relocate(struct eb_vmas *eb)
550
{
551
	struct i915_vma *vma;
552 553 554 555 556 557 558 559 560 561
	int ret = 0;

	/* This is the fast path and we cannot handle a pagefault whilst
	 * holding the struct mutex lest the user pass in the relocations
	 * contained within a mmaped bo. For in such a case we, the page
	 * fault handler would call i915_gem_fault() and we would try to
	 * acquire the struct mutex again. Obviously this is bad and so
	 * lockdep complains vehemently.
	 */
	pagefault_disable();
562 563
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		ret = i915_gem_execbuffer_relocate_vma(vma, eb);
564
		if (ret)
565
			break;
566
	}
567
	pagefault_enable();
568

569
	return ret;
570 571
}

572 573 574 575 576 577
static bool only_mappable_for_reloc(unsigned int flags)
{
	return (flags & (EXEC_OBJECT_NEEDS_FENCE | __EXEC_OBJECT_NEEDS_MAP)) ==
		__EXEC_OBJECT_NEEDS_MAP;
}

578
static int
579
i915_gem_execbuffer_reserve_vma(struct i915_vma *vma,
580
				struct intel_engine_cs *ring,
581
				bool *need_reloc)
582
{
583
	struct drm_i915_gem_object *obj = vma->obj;
584
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
585
	uint64_t flags;
586 587
	int ret;

588
	flags = PIN_USER;
589 590 591
	if (entry->flags & EXEC_OBJECT_NEEDS_GTT)
		flags |= PIN_GLOBAL;

592
	if (!drm_mm_node_allocated(&vma->node)) {
593 594 595 596 597
		/* Wa32bitGeneralStateOffset & Wa32bitInstructionBaseOffset,
		 * limit address to the first 4GBs for unflagged objects.
		 */
		if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0)
			flags |= PIN_ZONE_4G;
598 599 600 601
		if (entry->flags & __EXEC_OBJECT_NEEDS_MAP)
			flags |= PIN_GLOBAL | PIN_MAPPABLE;
		if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS)
			flags |= BATCH_OFFSET_BIAS | PIN_OFFSET_BIAS;
602 603
		if ((flags & PIN_MAPPABLE) == 0)
			flags |= PIN_HIGH;
604
	}
605 606

	ret = i915_gem_object_pin(obj, vma->vm, entry->alignment, flags);
607 608 609 610
	if ((ret == -ENOSPC  || ret == -E2BIG) &&
	    only_mappable_for_reloc(entry->flags))
		ret = i915_gem_object_pin(obj, vma->vm,
					  entry->alignment,
611
					  flags & ~PIN_MAPPABLE);
612 613 614
	if (ret)
		return ret;

615 616
	entry->flags |= __EXEC_OBJECT_HAS_PIN;

617 618 619 620
	if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
		ret = i915_gem_object_get_fence(obj);
		if (ret)
			return ret;
621

622 623
		if (i915_gem_object_pin_fence(obj))
			entry->flags |= __EXEC_OBJECT_HAS_FENCE;
624 625
	}

626 627
	if (entry->offset != vma->node.start) {
		entry->offset = vma->node.start;
628 629 630 631 632 633 634 635
		*need_reloc = true;
	}

	if (entry->flags & EXEC_OBJECT_WRITE) {
		obj->base.pending_read_domains = I915_GEM_DOMAIN_RENDER;
		obj->base.pending_write_domain = I915_GEM_DOMAIN_RENDER;
	}

636
	return 0;
637
}
638

639
static bool
640
need_reloc_mappable(struct i915_vma *vma)
641 642 643
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;

644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664
	if (entry->relocation_count == 0)
		return false;

	if (!i915_is_ggtt(vma->vm))
		return false;

	/* See also use_cpu_reloc() */
	if (HAS_LLC(vma->obj->base.dev))
		return false;

	if (vma->obj->base.write_domain == I915_GEM_DOMAIN_CPU)
		return false;

	return true;
}

static bool
eb_vma_misplaced(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
	struct drm_i915_gem_object *obj = vma->obj;
665

666
	WARN_ON(entry->flags & __EXEC_OBJECT_NEEDS_MAP &&
667 668 669 670 671 672 673 674 675 676
	       !i915_is_ggtt(vma->vm));

	if (entry->alignment &&
	    vma->node.start & (entry->alignment - 1))
		return true;

	if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS &&
	    vma->node.start < BATCH_OFFSET_BIAS)
		return true;

677 678 679 680
	/* avoid costly ping-pong once a batch bo ended up non-mappable */
	if (entry->flags & __EXEC_OBJECT_NEEDS_MAP && !obj->map_and_fenceable)
		return !only_mappable_for_reloc(entry->flags);

681 682 683 684
	if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0 &&
	    (vma->node.start + vma->node.size - 1) >> 32)
		return true;

685 686 687
	return false;
}

688
static int
689
i915_gem_execbuffer_reserve(struct intel_engine_cs *ring,
690
			    struct list_head *vmas,
691
			    struct intel_context *ctx,
692
			    bool *need_relocs)
693
{
694
	struct drm_i915_gem_object *obj;
695
	struct i915_vma *vma;
696
	struct i915_address_space *vm;
697
	struct list_head ordered_vmas;
698 699
	bool has_fenced_gpu_access = INTEL_INFO(ring->dev)->gen < 4;
	int retry;
700

701 702
	i915_gem_retire_requests_ring(ring);

703 704
	vm = list_first_entry(vmas, struct i915_vma, exec_list)->vm;

705 706
	INIT_LIST_HEAD(&ordered_vmas);
	while (!list_empty(vmas)) {
707 708 709
		struct drm_i915_gem_exec_object2 *entry;
		bool need_fence, need_mappable;

710 711 712
		vma = list_first_entry(vmas, struct i915_vma, exec_list);
		obj = vma->obj;
		entry = vma->exec_entry;
713

714 715 716
		if (ctx->flags & CONTEXT_NO_ZEROMAP)
			entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

717 718
		if (!has_fenced_gpu_access)
			entry->flags &= ~EXEC_OBJECT_NEEDS_FENCE;
719 720 721
		need_fence =
			entry->flags & EXEC_OBJECT_NEEDS_FENCE &&
			obj->tiling_mode != I915_TILING_NONE;
722
		need_mappable = need_fence || need_reloc_mappable(vma);
723

724 725
		if (need_mappable) {
			entry->flags |= __EXEC_OBJECT_NEEDS_MAP;
726
			list_move(&vma->exec_list, &ordered_vmas);
727
		} else
728
			list_move_tail(&vma->exec_list, &ordered_vmas);
729

730
		obj->base.pending_read_domains = I915_GEM_GPU_DOMAINS & ~I915_GEM_DOMAIN_COMMAND;
731
		obj->base.pending_write_domain = 0;
732
	}
733
	list_splice(&ordered_vmas, vmas);
734 735 736 737 738 739 740 741 742 743

	/* Attempt to pin all of the buffers into the GTT.
	 * This is done in 3 phases:
	 *
	 * 1a. Unbind all objects that do not match the GTT constraints for
	 *     the execbuffer (fenceable, mappable, alignment etc).
	 * 1b. Increment pin count for already bound objects.
	 * 2.  Bind new objects.
	 * 3.  Decrement pin count.
	 *
744
	 * This avoid unnecessary unbinding of later objects in order to make
745 746 747 748
	 * room for the earlier objects *unless* we need to defragment.
	 */
	retry = 0;
	do {
749
		int ret = 0;
750 751

		/* Unbind any ill-fitting objects or pin. */
752 753
		list_for_each_entry(vma, vmas, exec_list) {
			if (!drm_mm_node_allocated(&vma->node))
754 755
				continue;

756
			if (eb_vma_misplaced(vma))
757
				ret = i915_vma_unbind(vma);
758
			else
759
				ret = i915_gem_execbuffer_reserve_vma(vma, ring, need_relocs);
760
			if (ret)
761 762 763 764
				goto err;
		}

		/* Bind fresh objects */
765 766
		list_for_each_entry(vma, vmas, exec_list) {
			if (drm_mm_node_allocated(&vma->node))
767
				continue;
768

769
			ret = i915_gem_execbuffer_reserve_vma(vma, ring, need_relocs);
770 771
			if (ret)
				goto err;
772 773
		}

774
err:
C
Chris Wilson 已提交
775
		if (ret != -ENOSPC || retry++)
776 777
			return ret;

778 779 780 781
		/* Decrement pin count for bound objects */
		list_for_each_entry(vma, vmas, exec_list)
			i915_gem_execbuffer_unreserve_vma(vma);

782
		ret = i915_gem_evict_vm(vm, true);
783 784 785 786 787 788 789
		if (ret)
			return ret;
	} while (1);
}

static int
i915_gem_execbuffer_relocate_slow(struct drm_device *dev,
790
				  struct drm_i915_gem_execbuffer2 *args,
791
				  struct drm_file *file,
792
				  struct intel_engine_cs *ring,
793
				  struct eb_vmas *eb,
794 795
				  struct drm_i915_gem_exec_object2 *exec,
				  struct intel_context *ctx)
796 797
{
	struct drm_i915_gem_relocation_entry *reloc;
798 799
	struct i915_address_space *vm;
	struct i915_vma *vma;
800
	bool need_relocs;
801
	int *reloc_offset;
802
	int i, total, ret;
803
	unsigned count = args->buffer_count;
804

805 806
	vm = list_first_entry(&eb->vmas, struct i915_vma, exec_list)->vm;

807
	/* We may process another execbuffer during the unlock... */
808 809 810
	while (!list_empty(&eb->vmas)) {
		vma = list_first_entry(&eb->vmas, struct i915_vma, exec_list);
		list_del_init(&vma->exec_list);
811
		i915_gem_execbuffer_unreserve_vma(vma);
812
		drm_gem_object_unreference(&vma->obj->base);
813 814
	}

815 816 817 818
	mutex_unlock(&dev->struct_mutex);

	total = 0;
	for (i = 0; i < count; i++)
819
		total += exec[i].relocation_count;
820

821
	reloc_offset = drm_malloc_ab(count, sizeof(*reloc_offset));
822
	reloc = drm_malloc_ab(total, sizeof(*reloc));
823 824 825
	if (reloc == NULL || reloc_offset == NULL) {
		drm_free_large(reloc);
		drm_free_large(reloc_offset);
826 827 828 829 830 831 832
		mutex_lock(&dev->struct_mutex);
		return -ENOMEM;
	}

	total = 0;
	for (i = 0; i < count; i++) {
		struct drm_i915_gem_relocation_entry __user *user_relocs;
833 834
		u64 invalid_offset = (u64)-1;
		int j;
835

V
Ville Syrjälä 已提交
836
		user_relocs = to_user_ptr(exec[i].relocs_ptr);
837 838

		if (copy_from_user(reloc+total, user_relocs,
839
				   exec[i].relocation_count * sizeof(*reloc))) {
840 841 842 843 844
			ret = -EFAULT;
			mutex_lock(&dev->struct_mutex);
			goto err;
		}

845 846 847 848 849 850 851 852 853 854
		/* As we do not update the known relocation offsets after
		 * relocating (due to the complexities in lock handling),
		 * we need to mark them as invalid now so that we force the
		 * relocation processing next time. Just in case the target
		 * object is evicted and then rebound into its old
		 * presumed_offset before the next execbuffer - if that
		 * happened we would make the mistake of assuming that the
		 * relocations were valid.
		 */
		for (j = 0; j < exec[i].relocation_count; j++) {
855 856 857
			if (__copy_to_user(&user_relocs[j].presumed_offset,
					   &invalid_offset,
					   sizeof(invalid_offset))) {
858 859 860 861 862 863
				ret = -EFAULT;
				mutex_lock(&dev->struct_mutex);
				goto err;
			}
		}

864
		reloc_offset[i] = total;
865
		total += exec[i].relocation_count;
866 867 868 869 870 871 872 873
	}

	ret = i915_mutex_lock_interruptible(dev);
	if (ret) {
		mutex_lock(&dev->struct_mutex);
		goto err;
	}

874 875
	/* reacquire the objects */
	eb_reset(eb);
876
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
877 878
	if (ret)
		goto err;
879

880
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
881
	ret = i915_gem_execbuffer_reserve(ring, &eb->vmas, ctx, &need_relocs);
882 883 884
	if (ret)
		goto err;

885 886 887 888
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		int offset = vma->exec_entry - exec;
		ret = i915_gem_execbuffer_relocate_vma_slow(vma, eb,
							    reloc + reloc_offset[offset]);
889 890 891 892 893 894 895 896 897 898 899 900
		if (ret)
			goto err;
	}

	/* Leave the user relocations as are, this is the painfully slow path,
	 * and we want to avoid the complication of dropping the lock whilst
	 * having buffers reserved in the aperture and so causing spurious
	 * ENOSPC for random operations.
	 */

err:
	drm_free_large(reloc);
901
	drm_free_large(reloc_offset);
902 903 904 905
	return ret;
}

static int
906
i915_gem_execbuffer_move_to_gpu(struct drm_i915_gem_request *req,
907
				struct list_head *vmas)
908
{
909
	const unsigned other_rings = ~intel_ring_flag(req->ring);
910
	struct i915_vma *vma;
911
	uint32_t flush_domains = 0;
912
	bool flush_chipset = false;
913
	int ret;
914

915 916
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
917 918

		if (obj->active & other_rings) {
919
			ret = i915_gem_object_sync(obj, req->ring, &req);
920 921 922
			if (ret)
				return ret;
		}
923 924

		if (obj->base.write_domain & I915_GEM_DOMAIN_CPU)
925
			flush_chipset |= i915_gem_clflush_object(obj, false);
926 927

		flush_domains |= obj->base.write_domain;
928 929
	}

930
	if (flush_chipset)
931
		i915_gem_chipset_flush(req->ring->dev);
932 933 934 935

	if (flush_domains & I915_GEM_DOMAIN_GTT)
		wmb();

936 937 938
	/* Unconditionally invalidate gpu caches and ensure that we do flush
	 * any residual writes from the previous batch.
	 */
939
	return intel_ring_invalidate_all_caches(req);
940 941
}

942 943
static bool
i915_gem_check_execbuffer(struct drm_i915_gem_execbuffer2 *exec)
944
{
945 946 947
	if (exec->flags & __I915_EXEC_UNKNOWN_FLAGS)
		return false;

948
	return ((exec->batch_start_offset | exec->batch_len) & 0x7) == 0;
949 950 951
}

static int
952 953
validate_exec_list(struct drm_device *dev,
		   struct drm_i915_gem_exec_object2 *exec,
954 955
		   int count)
{
956 957
	unsigned relocs_total = 0;
	unsigned relocs_max = UINT_MAX / sizeof(struct drm_i915_gem_relocation_entry);
958 959 960 961 962 963
	unsigned invalid_flags;
	int i;

	invalid_flags = __EXEC_OBJECT_UNKNOWN_FLAGS;
	if (USES_FULL_PPGTT(dev))
		invalid_flags |= EXEC_OBJECT_NEEDS_GTT;
964 965

	for (i = 0; i < count; i++) {
V
Ville Syrjälä 已提交
966
		char __user *ptr = to_user_ptr(exec[i].relocs_ptr);
967 968
		int length; /* limited by fault_in_pages_readable() */

969
		if (exec[i].flags & invalid_flags)
970 971
			return -EINVAL;

972 973 974
		if (exec[i].alignment && !is_power_of_2(exec[i].alignment))
			return -EINVAL;

975 976 977 978 979
		/* First check for malicious input causing overflow in
		 * the worst case where we need to allocate the entire
		 * relocation tree as a single array.
		 */
		if (exec[i].relocation_count > relocs_max - relocs_total)
980
			return -EINVAL;
981
		relocs_total += exec[i].relocation_count;
982 983 984

		length = exec[i].relocation_count *
			sizeof(struct drm_i915_gem_relocation_entry);
985 986 987 988 989
		/*
		 * We must check that the entire relocation array is safe
		 * to read, but since we may need to update the presumed
		 * offsets during execution, check for full write access.
		 */
990 991 992
		if (!access_ok(VERIFY_WRITE, ptr, length))
			return -EFAULT;

993
		if (likely(!i915.prefault_disable)) {
994 995 996
			if (fault_in_multipages_readable(ptr, length))
				return -EFAULT;
		}
997 998 999 1000 1001
	}

	return 0;
}

1002
static struct intel_context *
1003
i915_gem_validate_context(struct drm_device *dev, struct drm_file *file,
1004
			  struct intel_engine_cs *ring, const u32 ctx_id)
1005
{
1006
	struct intel_context *ctx = NULL;
1007 1008
	struct i915_ctx_hang_stats *hs;

1009
	if (ring->id != RCS && ctx_id != DEFAULT_CONTEXT_HANDLE)
1010 1011
		return ERR_PTR(-EINVAL);

1012
	ctx = i915_gem_context_get(file->driver_priv, ctx_id);
1013
	if (IS_ERR(ctx))
1014
		return ctx;
1015

1016
	hs = &ctx->hang_stats;
1017 1018
	if (hs->banned) {
		DRM_DEBUG("Context %u tried to submit while banned\n", ctx_id);
1019
		return ERR_PTR(-EIO);
1020 1021
	}

1022
	if (i915.enable_execlists && !ctx->engine[ring->id].state) {
1023
		int ret = intel_lr_context_deferred_alloc(ctx, ring);
1024 1025 1026 1027 1028 1029
		if (ret) {
			DRM_DEBUG("Could not create LRC %u: %d\n", ctx_id, ret);
			return ERR_PTR(ret);
		}
	}

1030
	return ctx;
1031 1032
}

1033
void
1034
i915_gem_execbuffer_move_to_active(struct list_head *vmas,
1035
				   struct drm_i915_gem_request *req)
1036
{
1037
	struct intel_engine_cs *ring = i915_gem_request_get_ring(req);
1038
	struct i915_vma *vma;
1039

1040
	list_for_each_entry(vma, vmas, exec_list) {
1041
		struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
1042
		struct drm_i915_gem_object *obj = vma->obj;
1043 1044
		u32 old_read = obj->base.read_domains;
		u32 old_write = obj->base.write_domain;
C
Chris Wilson 已提交
1045

1046
		obj->dirty = 1; /* be paranoid  */
1047
		obj->base.write_domain = obj->base.pending_write_domain;
1048 1049 1050
		if (obj->base.write_domain == 0)
			obj->base.pending_read_domains |= obj->base.read_domains;
		obj->base.read_domains = obj->base.pending_read_domains;
1051

1052
		i915_vma_move_to_active(vma, req);
1053
		if (obj->base.write_domain) {
1054
			i915_gem_request_assign(&obj->last_write_req, req);
1055

1056
			intel_fb_obj_invalidate(obj, ORIGIN_CS);
1057 1058 1059

			/* update for the implicit flush after a batch */
			obj->base.write_domain &= ~I915_GEM_GPU_DOMAINS;
1060
		}
1061
		if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
1062
			i915_gem_request_assign(&obj->last_fenced_req, req);
1063 1064 1065 1066 1067 1068
			if (entry->flags & __EXEC_OBJECT_HAS_FENCE) {
				struct drm_i915_private *dev_priv = to_i915(ring->dev);
				list_move_tail(&dev_priv->fence_regs[obj->fence_reg].lru_list,
					       &dev_priv->mm.fence_list);
			}
		}
1069

C
Chris Wilson 已提交
1070
		trace_i915_gem_object_change_domain(obj, old_read, old_write);
1071 1072 1073
	}
}

1074
void
1075
i915_gem_execbuffer_retire_commands(struct i915_execbuffer_params *params)
1076
{
1077
	/* Unconditionally force add_request to emit a full flush. */
1078
	params->ring->gpu_caches_dirty = true;
1079

1080
	/* Add a breadcrumb for the completion of the batch buffer */
1081
	__i915_add_request(params->request, params->batch_obj, true);
1082
}
1083

1084 1085
static int
i915_reset_gen7_sol_offsets(struct drm_device *dev,
1086
			    struct drm_i915_gem_request *req)
1087
{
1088
	struct intel_engine_cs *ring = req->ring;
1089
	struct drm_i915_private *dev_priv = dev->dev_private;
1090 1091
	int ret, i;

1092 1093 1094 1095
	if (!IS_GEN7(dev) || ring != &dev_priv->ring[RCS]) {
		DRM_DEBUG("sol reset is gen7/rcs only\n");
		return -EINVAL;
	}
1096

1097
	ret = intel_ring_begin(req, 4 * 3);
1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111
	if (ret)
		return ret;

	for (i = 0; i < 4; i++) {
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit(ring, GEN7_SO_WRITE_OFFSET(i));
		intel_ring_emit(ring, 0);
	}

	intel_ring_advance(ring);

	return 0;
}

1112
static int
1113
i915_emit_box(struct drm_i915_gem_request *req,
1114 1115 1116
	      struct drm_clip_rect *box,
	      int DR1, int DR4)
{
1117
	struct intel_engine_cs *ring = req->ring;
1118 1119 1120 1121 1122 1123 1124 1125 1126 1127
	int ret;

	if (box->y2 <= box->y1 || box->x2 <= box->x1 ||
	    box->y2 <= 0 || box->x2 <= 0) {
		DRM_ERROR("Bad box %d,%d..%d,%d\n",
			  box->x1, box->y1, box->x2, box->y2);
		return -EINVAL;
	}

	if (INTEL_INFO(ring->dev)->gen >= 4) {
1128
		ret = intel_ring_begin(req, 4);
1129 1130 1131 1132 1133 1134 1135 1136
		if (ret)
			return ret;

		intel_ring_emit(ring, GFX_OP_DRAWRECT_INFO_I965);
		intel_ring_emit(ring, (box->x1 & 0xffff) | box->y1 << 16);
		intel_ring_emit(ring, ((box->x2 - 1) & 0xffff) | (box->y2 - 1) << 16);
		intel_ring_emit(ring, DR4);
	} else {
1137
		ret = intel_ring_begin(req, 6);
1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152
		if (ret)
			return ret;

		intel_ring_emit(ring, GFX_OP_DRAWRECT_INFO);
		intel_ring_emit(ring, DR1);
		intel_ring_emit(ring, (box->x1 & 0xffff) | box->y1 << 16);
		intel_ring_emit(ring, ((box->x2 - 1) & 0xffff) | (box->y2 - 1) << 16);
		intel_ring_emit(ring, DR4);
		intel_ring_emit(ring, 0);
	}
	intel_ring_advance(ring);

	return 0;
}

1153 1154 1155 1156 1157 1158 1159
static struct drm_i915_gem_object*
i915_gem_execbuffer_parse(struct intel_engine_cs *ring,
			  struct drm_i915_gem_exec_object2 *shadow_exec_entry,
			  struct eb_vmas *eb,
			  struct drm_i915_gem_object *batch_obj,
			  u32 batch_start_offset,
			  u32 batch_len,
1160
			  bool is_master)
1161 1162
{
	struct drm_i915_gem_object *shadow_batch_obj;
1163
	struct i915_vma *vma;
1164 1165
	int ret;

1166
	shadow_batch_obj = i915_gem_batch_pool_get(&ring->batch_pool,
1167
						   PAGE_ALIGN(batch_len));
1168 1169 1170 1171 1172 1173 1174 1175 1176
	if (IS_ERR(shadow_batch_obj))
		return shadow_batch_obj;

	ret = i915_parse_cmds(ring,
			      batch_obj,
			      shadow_batch_obj,
			      batch_start_offset,
			      batch_len,
			      is_master);
1177 1178
	if (ret)
		goto err;
1179

1180 1181 1182
	ret = i915_gem_obj_ggtt_pin(shadow_batch_obj, 0, 0);
	if (ret)
		goto err;
1183

C
Chris Wilson 已提交
1184 1185
	i915_gem_object_unpin_pages(shadow_batch_obj);

1186
	memset(shadow_exec_entry, 0, sizeof(*shadow_exec_entry));
1187

1188 1189
	vma = i915_gem_obj_to_ggtt(shadow_batch_obj);
	vma->exec_entry = shadow_exec_entry;
C
Chris Wilson 已提交
1190
	vma->exec_entry->flags = __EXEC_OBJECT_HAS_PIN;
1191 1192
	drm_gem_object_reference(&shadow_batch_obj->base);
	list_add_tail(&vma->exec_list, &eb->vmas);
1193

1194 1195 1196
	shadow_batch_obj->base.pending_read_domains = I915_GEM_DOMAIN_COMMAND;

	return shadow_batch_obj;
1197

1198
err:
C
Chris Wilson 已提交
1199
	i915_gem_object_unpin_pages(shadow_batch_obj);
1200 1201 1202 1203
	if (ret == -EACCES) /* unhandled chained batch */
		return batch_obj;
	else
		return ERR_PTR(ret);
1204
}
1205

1206
int
1207
i915_gem_ringbuffer_submission(struct i915_execbuffer_params *params,
1208
			       struct drm_i915_gem_execbuffer2 *args,
1209
			       struct list_head *vmas)
1210 1211
{
	struct drm_clip_rect *cliprects = NULL;
1212 1213
	struct drm_device *dev = params->dev;
	struct intel_engine_cs *ring = params->ring;
1214
	struct drm_i915_private *dev_priv = dev->dev_private;
1215
	u64 exec_start, exec_len;
1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262
	int instp_mode;
	u32 instp_mask;
	int i, ret = 0;

	if (args->num_cliprects != 0) {
		if (ring != &dev_priv->ring[RCS]) {
			DRM_DEBUG("clip rectangles are only valid with the render ring\n");
			return -EINVAL;
		}

		if (INTEL_INFO(dev)->gen >= 5) {
			DRM_DEBUG("clip rectangles are only valid on pre-gen5\n");
			return -EINVAL;
		}

		if (args->num_cliprects > UINT_MAX / sizeof(*cliprects)) {
			DRM_DEBUG("execbuf with %u cliprects\n",
				  args->num_cliprects);
			return -EINVAL;
		}

		cliprects = kcalloc(args->num_cliprects,
				    sizeof(*cliprects),
				    GFP_KERNEL);
		if (cliprects == NULL) {
			ret = -ENOMEM;
			goto error;
		}

		if (copy_from_user(cliprects,
				   to_user_ptr(args->cliprects_ptr),
				   sizeof(*cliprects)*args->num_cliprects)) {
			ret = -EFAULT;
			goto error;
		}
	} else {
		if (args->DR4 == 0xffffffff) {
			DRM_DEBUG("UXA submitting garbage DR4, fixing up\n");
			args->DR4 = 0;
		}

		if (args->DR1 || args->DR4 || args->cliprects_ptr) {
			DRM_DEBUG("0 cliprects but dirt in cliprects fields\n");
			return -EINVAL;
		}
	}

1263
	ret = i915_gem_execbuffer_move_to_gpu(params->request, vmas);
1264 1265 1266
	if (ret)
		goto error;

1267
	ret = i915_switch_context(params->request);
1268 1269 1270
	if (ret)
		goto error;

1271
	WARN(params->ctx->ppgtt && params->ctx->ppgtt->pd_dirty_rings & (1<<ring->id),
1272
	     "%s didn't clear reload\n", ring->name);
1273

1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312
	instp_mode = args->flags & I915_EXEC_CONSTANTS_MASK;
	instp_mask = I915_EXEC_CONSTANTS_MASK;
	switch (instp_mode) {
	case I915_EXEC_CONSTANTS_REL_GENERAL:
	case I915_EXEC_CONSTANTS_ABSOLUTE:
	case I915_EXEC_CONSTANTS_REL_SURFACE:
		if (instp_mode != 0 && ring != &dev_priv->ring[RCS]) {
			DRM_DEBUG("non-0 rel constants mode on non-RCS\n");
			ret = -EINVAL;
			goto error;
		}

		if (instp_mode != dev_priv->relative_constants_mode) {
			if (INTEL_INFO(dev)->gen < 4) {
				DRM_DEBUG("no rel constants on pre-gen4\n");
				ret = -EINVAL;
				goto error;
			}

			if (INTEL_INFO(dev)->gen > 5 &&
			    instp_mode == I915_EXEC_CONSTANTS_REL_SURFACE) {
				DRM_DEBUG("rel surface constants mode invalid on gen5+\n");
				ret = -EINVAL;
				goto error;
			}

			/* The HW changed the meaning on this bit on gen6 */
			if (INTEL_INFO(dev)->gen >= 6)
				instp_mask &= ~I915_EXEC_CONSTANTS_REL_SURFACE;
		}
		break;
	default:
		DRM_DEBUG("execbuf with unknown constants: %d\n", instp_mode);
		ret = -EINVAL;
		goto error;
	}

	if (ring == &dev_priv->ring[RCS] &&
			instp_mode != dev_priv->relative_constants_mode) {
1313
		ret = intel_ring_begin(params->request, 4);
1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326
		if (ret)
			goto error;

		intel_ring_emit(ring, MI_NOOP);
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit(ring, INSTPM);
		intel_ring_emit(ring, instp_mask << 16 | instp_mode);
		intel_ring_advance(ring);

		dev_priv->relative_constants_mode = instp_mode;
	}

	if (args->flags & I915_EXEC_GEN7_SOL_RESET) {
1327
		ret = i915_reset_gen7_sol_offsets(dev, params->request);
1328 1329 1330 1331
		if (ret)
			goto error;
	}

1332 1333 1334 1335
	exec_len   = args->batch_len;
	exec_start = params->batch_obj_vm_offset +
		     params->args_batch_start_offset;

1336 1337
	if (cliprects) {
		for (i = 0; i < args->num_cliprects; i++) {
1338
			ret = i915_emit_box(params->request, &cliprects[i],
1339 1340 1341 1342
					    args->DR1, args->DR4);
			if (ret)
				goto error;

1343
			ret = ring->dispatch_execbuffer(params->request,
1344
							exec_start, exec_len,
1345
							params->dispatch_flags);
1346 1347 1348 1349
			if (ret)
				goto error;
		}
	} else {
1350
		ret = ring->dispatch_execbuffer(params->request,
1351
						exec_start, exec_len,
1352
						params->dispatch_flags);
1353 1354 1355 1356
		if (ret)
			return ret;
	}

1357
	trace_i915_gem_ring_dispatch(params->request, params->dispatch_flags);
1358

1359
	i915_gem_execbuffer_move_to_active(vmas, params->request);
1360
	i915_gem_execbuffer_retire_commands(params);
1361 1362 1363 1364 1365 1366

error:
	kfree(cliprects);
	return ret;
}

1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384
/**
 * Find one BSD ring to dispatch the corresponding BSD command.
 * The Ring ID is returned.
 */
static int gen8_dispatch_bsd_ring(struct drm_device *dev,
				  struct drm_file *file)
{
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct drm_i915_file_private *file_priv = file->driver_priv;

	/* Check whether the file_priv is using one ring */
	if (file_priv->bsd_ring)
		return file_priv->bsd_ring->id;
	else {
		/* If no, use the ping-pong mechanism to select one ring */
		int ring_id;

		mutex_lock(&dev->struct_mutex);
1385
		if (dev_priv->mm.bsd_ring_dispatch_index == 0) {
1386
			ring_id = VCS;
1387
			dev_priv->mm.bsd_ring_dispatch_index = 1;
1388 1389
		} else {
			ring_id = VCS2;
1390
			dev_priv->mm.bsd_ring_dispatch_index = 0;
1391 1392 1393 1394 1395 1396 1397
		}
		file_priv->bsd_ring = &dev_priv->ring[ring_id];
		mutex_unlock(&dev->struct_mutex);
		return ring_id;
	}
}

1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416
static struct drm_i915_gem_object *
eb_get_batch(struct eb_vmas *eb)
{
	struct i915_vma *vma = list_entry(eb->vmas.prev, typeof(*vma), exec_list);

	/*
	 * SNA is doing fancy tricks with compressing batch buffers, which leads
	 * to negative relocation deltas. Usually that works out ok since the
	 * relocate address is still positive, except when the batch is placed
	 * very low in the GTT. Ensure this doesn't happen.
	 *
	 * Note that actual hangs have only been observed on gen7, but for
	 * paranoia do it everywhere.
	 */
	vma->exec_entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

	return vma->obj;
}

1417 1418 1419 1420
static int
i915_gem_do_execbuffer(struct drm_device *dev, void *data,
		       struct drm_file *file,
		       struct drm_i915_gem_execbuffer2 *args,
1421
		       struct drm_i915_gem_exec_object2 *exec)
1422
{
1423
	struct drm_i915_private *dev_priv = dev->dev_private;
1424
	struct eb_vmas *eb;
1425
	struct drm_i915_gem_object *batch_obj;
1426
	struct drm_i915_gem_exec_object2 shadow_exec_entry;
1427
	struct intel_engine_cs *ring;
1428
	struct intel_context *ctx;
1429
	struct i915_address_space *vm;
1430 1431
	struct i915_execbuffer_params params_master; /* XXX: will be removed later */
	struct i915_execbuffer_params *params = &params_master;
1432
	const u32 ctx_id = i915_execbuffer2_get_context_id(*args);
1433
	u32 dispatch_flags;
1434
	int ret;
1435
	bool need_relocs;
1436

1437
	if (!i915_gem_check_execbuffer(args))
1438 1439
		return -EINVAL;

1440
	ret = validate_exec_list(dev, exec, args->buffer_count);
1441 1442 1443
	if (ret)
		return ret;

1444
	dispatch_flags = 0;
1445 1446 1447 1448
	if (args->flags & I915_EXEC_SECURE) {
		if (!file->is_master || !capable(CAP_SYS_ADMIN))
		    return -EPERM;

1449
		dispatch_flags |= I915_DISPATCH_SECURE;
1450
	}
1451
	if (args->flags & I915_EXEC_IS_PINNED)
1452
		dispatch_flags |= I915_DISPATCH_PINNED;
1453

1454
	if ((args->flags & I915_EXEC_RING_MASK) > LAST_USER_RING) {
1455
		DRM_DEBUG("execbuf with unknown ring: %d\n",
1456 1457 1458
			  (int)(args->flags & I915_EXEC_RING_MASK));
		return -EINVAL;
	}
1459

1460 1461 1462 1463 1464 1465 1466
	if (((args->flags & I915_EXEC_RING_MASK) != I915_EXEC_BSD) &&
	    ((args->flags & I915_EXEC_BSD_MASK) != 0)) {
		DRM_DEBUG("execbuf with non bsd ring but with invalid "
			"bsd dispatch flags: %d\n", (int)(args->flags));
		return -EINVAL;
	} 

1467 1468
	if ((args->flags & I915_EXEC_RING_MASK) == I915_EXEC_DEFAULT)
		ring = &dev_priv->ring[RCS];
1469 1470 1471
	else if ((args->flags & I915_EXEC_RING_MASK) == I915_EXEC_BSD) {
		if (HAS_BSD2(dev)) {
			int ring_id;
1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488

			switch (args->flags & I915_EXEC_BSD_MASK) {
			case I915_EXEC_BSD_DEFAULT:
				ring_id = gen8_dispatch_bsd_ring(dev, file);
				ring = &dev_priv->ring[ring_id];
				break;
			case I915_EXEC_BSD_RING1:
				ring = &dev_priv->ring[VCS];
				break;
			case I915_EXEC_BSD_RING2:
				ring = &dev_priv->ring[VCS2];
				break;
			default:
				DRM_DEBUG("execbuf with unknown bsd ring: %d\n",
					  (int)(args->flags & I915_EXEC_BSD_MASK));
				return -EINVAL;
			}
1489 1490 1491
		} else
			ring = &dev_priv->ring[VCS];
	} else
1492 1493
		ring = &dev_priv->ring[(args->flags & I915_EXEC_RING_MASK) - 1];

1494 1495 1496 1497 1498
	if (!intel_ring_initialized(ring)) {
		DRM_DEBUG("execbuf with invalid ring: %d\n",
			  (int)(args->flags & I915_EXEC_RING_MASK));
		return -EINVAL;
	}
1499 1500

	if (args->buffer_count < 1) {
1501
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1502 1503 1504
		return -EINVAL;
	}

1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518
	if (args->flags & I915_EXEC_RESOURCE_STREAMER) {
		if (!HAS_RESOURCE_STREAMER(dev)) {
			DRM_DEBUG("RS is only allowed for Haswell, Gen8 and above\n");
			return -EINVAL;
		}
		if (ring->id != RCS) {
			DRM_DEBUG("RS is not available on %s\n",
				 ring->name);
			return -EINVAL;
		}

		dispatch_flags |= I915_DISPATCH_RS;
	}

1519 1520
	intel_runtime_pm_get(dev_priv);

1521 1522 1523 1524
	ret = i915_mutex_lock_interruptible(dev);
	if (ret)
		goto pre_mutex_err;

1525
	ctx = i915_gem_validate_context(dev, file, ring, ctx_id);
1526
	if (IS_ERR(ctx)) {
1527
		mutex_unlock(&dev->struct_mutex);
1528
		ret = PTR_ERR(ctx);
1529
		goto pre_mutex_err;
1530
	}
1531 1532 1533

	i915_gem_context_reference(ctx);

1534 1535 1536
	if (ctx->ppgtt)
		vm = &ctx->ppgtt->base;
	else
1537
		vm = &dev_priv->gtt.base;
1538

1539 1540
	memset(&params_master, 0x00, sizeof(params_master));

B
Ben Widawsky 已提交
1541
	eb = eb_create(args);
1542
	if (eb == NULL) {
1543
		i915_gem_context_unreference(ctx);
1544 1545 1546 1547 1548
		mutex_unlock(&dev->struct_mutex);
		ret = -ENOMEM;
		goto pre_mutex_err;
	}

1549
	/* Look up object handles */
1550
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
1551 1552
	if (ret)
		goto err;
1553

1554
	/* take note of the batch buffer before we might reorder the lists */
1555
	batch_obj = eb_get_batch(eb);
1556

1557
	/* Move the objects en-masse into the GTT, evicting if necessary. */
1558
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
1559
	ret = i915_gem_execbuffer_reserve(ring, &eb->vmas, ctx, &need_relocs);
1560 1561 1562 1563
	if (ret)
		goto err;

	/* The objects are in their final locations, apply the relocations. */
1564
	if (need_relocs)
B
Ben Widawsky 已提交
1565
		ret = i915_gem_execbuffer_relocate(eb);
1566 1567
	if (ret) {
		if (ret == -EFAULT) {
1568
			ret = i915_gem_execbuffer_relocate_slow(dev, args, file, ring,
1569
								eb, exec, ctx);
1570 1571 1572 1573 1574 1575 1576 1577
			BUG_ON(!mutex_is_locked(&dev->struct_mutex));
		}
		if (ret)
			goto err;
	}

	/* Set the pending read domains for the batch buffer to COMMAND */
	if (batch_obj->base.pending_write_domain) {
1578
		DRM_DEBUG("Attempting to use self-modifying batch buffer\n");
1579 1580 1581 1582
		ret = -EINVAL;
		goto err;
	}

1583
	params->args_batch_start_offset = args->batch_start_offset;
1584
	if (i915_needs_cmd_parser(ring) && args->batch_len) {
1585 1586 1587
		struct drm_i915_gem_object *parsed_batch_obj;

		parsed_batch_obj = i915_gem_execbuffer_parse(ring,
1588 1589 1590 1591 1592
						      &shadow_exec_entry,
						      eb,
						      batch_obj,
						      args->batch_start_offset,
						      args->batch_len,
1593
						      file->is_master);
1594 1595
		if (IS_ERR(parsed_batch_obj)) {
			ret = PTR_ERR(parsed_batch_obj);
1596 1597
			goto err;
		}
1598 1599

		/*
1600 1601
		 * parsed_batch_obj == batch_obj means batch not fully parsed:
		 * Accept, but don't promote to secure.
1602 1603
		 */

1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614
		if (parsed_batch_obj != batch_obj) {
			/*
			 * Batch parsed and accepted:
			 *
			 * Set the DISPATCH_SECURE bit to remove the NON_SECURE
			 * bit from MI_BATCH_BUFFER_START commands issued in
			 * the dispatch_execbuffer implementations. We
			 * specifically don't want that set on batches the
			 * command parser has accepted.
			 */
			dispatch_flags |= I915_DISPATCH_SECURE;
1615
			params->args_batch_start_offset = 0;
1616 1617
			batch_obj = parsed_batch_obj;
		}
1618 1619
	}

1620 1621
	batch_obj->base.pending_read_domains |= I915_GEM_DOMAIN_COMMAND;

1622 1623
	/* snb/ivb/vlv conflate the "batch in ppgtt" bit with the "non-secure
	 * batch" bit. Hence we need to pin secure batches into the global gtt.
B
Ben Widawsky 已提交
1624
	 * hsw should have this fixed, but bdw mucks it up again. */
1625
	if (dispatch_flags & I915_DISPATCH_SECURE) {
1626 1627 1628 1629 1630 1631
		/*
		 * So on first glance it looks freaky that we pin the batch here
		 * outside of the reservation loop. But:
		 * - The batch is already pinned into the relevant ppgtt, so we
		 *   already have the backing storage fully allocated.
		 * - No other BO uses the global gtt (well contexts, but meh),
1632
		 *   so we don't really have issues with multiple objects not
1633 1634 1635 1636 1637 1638
		 *   fitting due to fragmentation.
		 * So this is actually safe.
		 */
		ret = i915_gem_obj_ggtt_pin(batch_obj, 0, 0);
		if (ret)
			goto err;
1639

1640
		params->batch_obj_vm_offset = i915_gem_obj_ggtt_offset(batch_obj);
1641
	} else
1642
		params->batch_obj_vm_offset = i915_gem_obj_offset(batch_obj, vm);
1643

1644
	/* Allocate a request for this batch buffer nice and early. */
1645
	ret = i915_gem_request_alloc(ring, ctx, &params->request);
1646 1647 1648
	if (ret)
		goto err_batch_unpin;

1649 1650 1651 1652
	ret = i915_gem_request_add_to_client(params->request, file);
	if (ret)
		goto err_batch_unpin;

1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666
	/*
	 * Save assorted stuff away to pass through to *_submission().
	 * NB: This data should be 'persistent' and not local as it will
	 * kept around beyond the duration of the IOCTL once the GPU
	 * scheduler arrives.
	 */
	params->dev                     = dev;
	params->file                    = file;
	params->ring                    = ring;
	params->dispatch_flags          = dispatch_flags;
	params->batch_obj               = batch_obj;
	params->ctx                     = ctx;

	ret = dev_priv->gt.execbuf_submit(params, args, &eb->vmas);
1667

1668
err_batch_unpin:
1669 1670 1671 1672 1673 1674
	/*
	 * FIXME: We crucially rely upon the active tracking for the (ppgtt)
	 * batch vma for correctness. For less ugly and less fragility this
	 * needs to be adjusted to also track the ggtt batch vma properly as
	 * active.
	 */
1675
	if (dispatch_flags & I915_DISPATCH_SECURE)
1676
		i915_gem_object_ggtt_unpin(batch_obj);
1677

1678
err:
1679 1680
	/* the request owns the ref now */
	i915_gem_context_unreference(ctx);
1681
	eb_destroy(eb);
1682

1683 1684 1685 1686 1687
	/*
	 * If the request was created but not successfully submitted then it
	 * must be freed again. If it was submitted then it is being tracked
	 * on the active request list and no clean up is required here.
	 */
1688
	if (ret && params->request)
1689 1690
		i915_gem_request_cancel(params->request);

1691 1692 1693
	mutex_unlock(&dev->struct_mutex);

pre_mutex_err:
1694 1695 1696
	/* intel_gpu_busy should also get a ref, so it will free when the device
	 * is really idle. */
	intel_runtime_pm_put(dev_priv);
1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714
	return ret;
}

/*
 * Legacy execbuffer just creates an exec2 list from the original exec object
 * list array and passes it to the real function.
 */
int
i915_gem_execbuffer(struct drm_device *dev, void *data,
		    struct drm_file *file)
{
	struct drm_i915_gem_execbuffer *args = data;
	struct drm_i915_gem_execbuffer2 exec2;
	struct drm_i915_gem_exec_object *exec_list = NULL;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret, i;

	if (args->buffer_count < 1) {
1715
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1716 1717 1718 1719 1720 1721 1722
		return -EINVAL;
	}

	/* Copy in the exec list from userland */
	exec_list = drm_malloc_ab(sizeof(*exec_list), args->buffer_count);
	exec2_list = drm_malloc_ab(sizeof(*exec2_list), args->buffer_count);
	if (exec_list == NULL || exec2_list == NULL) {
1723
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1724 1725 1726 1727 1728 1729
			  args->buffer_count);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -ENOMEM;
	}
	ret = copy_from_user(exec_list,
V
Ville Syrjälä 已提交
1730
			     to_user_ptr(args->buffers_ptr),
1731 1732
			     sizeof(*exec_list) * args->buffer_count);
	if (ret != 0) {
1733
		DRM_DEBUG("copy %d exec entries failed %d\n",
1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760
			  args->buffer_count, ret);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

	for (i = 0; i < args->buffer_count; i++) {
		exec2_list[i].handle = exec_list[i].handle;
		exec2_list[i].relocation_count = exec_list[i].relocation_count;
		exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr;
		exec2_list[i].alignment = exec_list[i].alignment;
		exec2_list[i].offset = exec_list[i].offset;
		if (INTEL_INFO(dev)->gen < 4)
			exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE;
		else
			exec2_list[i].flags = 0;
	}

	exec2.buffers_ptr = args->buffers_ptr;
	exec2.buffer_count = args->buffer_count;
	exec2.batch_start_offset = args->batch_start_offset;
	exec2.batch_len = args->batch_len;
	exec2.DR1 = args->DR1;
	exec2.DR4 = args->DR4;
	exec2.num_cliprects = args->num_cliprects;
	exec2.cliprects_ptr = args->cliprects_ptr;
	exec2.flags = I915_EXEC_RENDER;
1761
	i915_execbuffer2_set_context_id(exec2, 0);
1762

1763
	ret = i915_gem_do_execbuffer(dev, data, file, &exec2, exec2_list);
1764
	if (!ret) {
1765 1766 1767
		struct drm_i915_gem_exec_object __user *user_exec_list =
			to_user_ptr(args->buffers_ptr);

1768
		/* Copy the new buffer offsets back to the user's exec list. */
1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779
		for (i = 0; i < args->buffer_count; i++) {
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user (%d)\n",
					  args->buffer_count, ret);
				break;
			}
1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795
		}
	}

	drm_free_large(exec_list);
	drm_free_large(exec2_list);
	return ret;
}

int
i915_gem_execbuffer2(struct drm_device *dev, void *data,
		     struct drm_file *file)
{
	struct drm_i915_gem_execbuffer2 *args = data;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret;

1796 1797
	if (args->buffer_count < 1 ||
	    args->buffer_count > UINT_MAX / sizeof(*exec2_list)) {
1798
		DRM_DEBUG("execbuf2 with %d buffers\n", args->buffer_count);
1799 1800 1801
		return -EINVAL;
	}

1802 1803 1804 1805 1806
	if (args->rsvd2 != 0) {
		DRM_DEBUG("dirty rvsd2 field\n");
		return -EINVAL;
	}

1807
	exec2_list = kmalloc(sizeof(*exec2_list)*args->buffer_count,
1808
			     GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
1809 1810 1811
	if (exec2_list == NULL)
		exec2_list = drm_malloc_ab(sizeof(*exec2_list),
					   args->buffer_count);
1812
	if (exec2_list == NULL) {
1813
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1814 1815 1816 1817
			  args->buffer_count);
		return -ENOMEM;
	}
	ret = copy_from_user(exec2_list,
V
Ville Syrjälä 已提交
1818
			     to_user_ptr(args->buffers_ptr),
1819 1820
			     sizeof(*exec2_list) * args->buffer_count);
	if (ret != 0) {
1821
		DRM_DEBUG("copy %d exec entries failed %d\n",
1822 1823 1824 1825 1826
			  args->buffer_count, ret);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

1827
	ret = i915_gem_do_execbuffer(dev, data, file, args, exec2_list);
1828 1829
	if (!ret) {
		/* Copy the new buffer offsets back to the user's exec list. */
1830
		struct drm_i915_gem_exec_object2 __user *user_exec_list =
1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844
				   to_user_ptr(args->buffers_ptr);
		int i;

		for (i = 0; i < args->buffer_count; i++) {
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user\n",
					  args->buffer_count);
				break;
			}
1845 1846 1847 1848 1849 1850
		}
	}

	drm_free_large(exec2_list);
	return ret;
}