amdgpu_vm.c 44.5 KB
Newer Older
A
Alex Deucher 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
/*
 * Copyright 2008 Advanced Micro Devices, Inc.
 * Copyright 2008 Red Hat Inc.
 * Copyright 2009 Jerome Glisse.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 * OTHER DEALINGS IN THE SOFTWARE.
 *
 * Authors: Dave Airlie
 *          Alex Deucher
 *          Jerome Glisse
 */
28
#include <linux/fence-array.h>
A
Alex Deucher 已提交
29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53
#include <drm/drmP.h>
#include <drm/amdgpu_drm.h>
#include "amdgpu.h"
#include "amdgpu_trace.h"

/*
 * GPUVM
 * GPUVM is similar to the legacy gart on older asics, however
 * rather than there being a single global gart table
 * for the entire GPU, there are multiple VM page tables active
 * at any given time.  The VM page tables can contain a mix
 * vram pages and system memory pages and system memory pages
 * can be mapped as snooped (cached system pages) or unsnooped
 * (uncached system pages).
 * Each VM has an ID associated with it and there is a page table
 * associated with each VMID.  When execting a command buffer,
 * the kernel tells the the ring what VMID to use for that command
 * buffer.  VMIDs are allocated dynamically as commands are submitted.
 * The userspace drivers maintain their own address space and the kernel
 * sets up their pages tables accordingly when they submit their
 * command buffers and a VMID is assigned.
 * Cayman/Trinity support up to 8 active VMs at any given time;
 * SI supports 16.
 */

54 55 56
/* Local structure. Encapsulate some VM table update parameters to reduce
 * the number of function parameters
 */
57
struct amdgpu_pte_update_params {
58 59
	/* amdgpu device we do this update for */
	struct amdgpu_device *adev;
60 61 62 63
	/* address where to copy page table entries from */
	uint64_t src;
	/* indirect buffer to fill with commands */
	struct amdgpu_ib *ib;
64 65 66 67
	/* Function which actually does the update */
	void (*func)(struct amdgpu_pte_update_params *params, uint64_t pe,
		     uint64_t addr, unsigned count, uint32_t incr,
		     uint32_t flags);
68 69
	/* indicate update pt or its shadow */
	bool shadow;
70 71
};

A
Alex Deucher 已提交
72 73 74 75 76
/**
 * amdgpu_vm_num_pde - return the number of page directory entries
 *
 * @adev: amdgpu_device pointer
 *
77
 * Calculate the number of page directory entries.
A
Alex Deucher 已提交
78 79 80 81 82 83 84 85 86 87 88
 */
static unsigned amdgpu_vm_num_pdes(struct amdgpu_device *adev)
{
	return adev->vm_manager.max_pfn >> amdgpu_vm_block_size;
}

/**
 * amdgpu_vm_directory_size - returns the size of the page directory in bytes
 *
 * @adev: amdgpu_device pointer
 *
89
 * Calculate the size of the page directory in bytes.
A
Alex Deucher 已提交
90 91 92 93 94 95 96
 */
static unsigned amdgpu_vm_directory_size(struct amdgpu_device *adev)
{
	return AMDGPU_GPU_PAGE_ALIGN(amdgpu_vm_num_pdes(adev) * 8);
}

/**
97
 * amdgpu_vm_get_pd_bo - add the VM PD to a validation list
A
Alex Deucher 已提交
98 99
 *
 * @vm: vm providing the BOs
100
 * @validated: head of validation list
101
 * @entry: entry to add
A
Alex Deucher 已提交
102 103
 *
 * Add the page directory to the list of BOs to
104
 * validate for command submission.
A
Alex Deucher 已提交
105
 */
106 107 108
void amdgpu_vm_get_pd_bo(struct amdgpu_vm *vm,
			 struct list_head *validated,
			 struct amdgpu_bo_list_entry *entry)
A
Alex Deucher 已提交
109
{
110 111 112 113
	entry->robj = vm->page_directory;
	entry->priority = 0;
	entry->tv.bo = &vm->page_directory->tbo;
	entry->tv.shared = true;
114
	entry->user_pages = NULL;
115 116
	list_add(&entry->tv.head, validated);
}
A
Alex Deucher 已提交
117

118
/**
119
 * amdgpu_vm_validate_pt_bos - validate the page table BOs
120
 *
121
 * @adev: amdgpu device pointer
122
 * @vm: vm providing the BOs
123 124
 * @validate: callback to do the validation
 * @param: parameter for the validation callback
A
Alex Deucher 已提交
125
 *
126
 * Validate the page table BOs on command submission if neccessary.
A
Alex Deucher 已提交
127
 */
128 129 130
int amdgpu_vm_validate_pt_bos(struct amdgpu_device *adev, struct amdgpu_vm *vm,
			      int (*validate)(void *p, struct amdgpu_bo *bo),
			      void *param)
A
Alex Deucher 已提交
131
{
132
	uint64_t num_evictions;
133
	unsigned i;
134
	int r;
A
Alex Deucher 已提交
135

136 137 138 139 140
	/* We only need to validate the page tables
	 * if they aren't already valid.
	 */
	num_evictions = atomic64_read(&adev->num_evictions);
	if (num_evictions == vm->last_eviction_counter)
141
		return 0;
142

A
Alex Deucher 已提交
143
	/* add the vm page table to the list */
144
	for (i = 0; i <= vm->max_pde_used; ++i) {
145
		struct amdgpu_bo *bo = vm->page_tables[i].bo;
146

147
		if (!bo)
A
Alex Deucher 已提交
148 149
			continue;

150
		r = validate(param, bo);
151 152
		if (r)
			return r;
A
Alex Deucher 已提交
153
	}
154

155
	return 0;
156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173
}

/**
 * amdgpu_vm_move_pt_bos_in_lru - move the PT BOs to the LRU tail
 *
 * @adev: amdgpu device instance
 * @vm: vm providing the BOs
 *
 * Move the PT BOs to the tail of the LRU.
 */
void amdgpu_vm_move_pt_bos_in_lru(struct amdgpu_device *adev,
				  struct amdgpu_vm *vm)
{
	struct ttm_bo_global *glob = adev->mman.bdev.glob;
	unsigned i;

	spin_lock(&glob->lru_lock);
	for (i = 0; i <= vm->max_pde_used; ++i) {
174
		struct amdgpu_bo *bo = vm->page_tables[i].bo;
175

176
		if (!bo)
177 178
			continue;

179
		ttm_bo_move_to_lru_tail(&bo->tbo);
180 181
	}
	spin_unlock(&glob->lru_lock);
A
Alex Deucher 已提交
182 183
}

184 185 186 187 188 189 190
static bool amdgpu_vm_is_gpu_reset(struct amdgpu_device *adev,
			      struct amdgpu_vm_id *id)
{
	return id->current_gpu_reset_count !=
		atomic_read(&adev->gpu_reset_counter) ? true : false;
}

A
Alex Deucher 已提交
191 192 193 194
/**
 * amdgpu_vm_grab_id - allocate the next free VMID
 *
 * @vm: vm to allocate id for
195 196
 * @ring: ring we want to submit job to
 * @sync: sync object where we add dependencies
197
 * @fence: fence protecting ID from reuse
A
Alex Deucher 已提交
198
 *
199
 * Allocate an id for the vm, adding fences to the sync obj as necessary.
A
Alex Deucher 已提交
200
 */
201
int amdgpu_vm_grab_id(struct amdgpu_vm *vm, struct amdgpu_ring *ring,
202
		      struct amdgpu_sync *sync, struct fence *fence,
203
		      struct amdgpu_job *job)
A
Alex Deucher 已提交
204 205
{
	struct amdgpu_device *adev = ring->adev;
206
	uint64_t fence_context = adev->fence_context + ring->idx;
207
	struct fence *updates = sync->last_vm_update;
208
	struct amdgpu_vm_id *id, *idle;
209 210 211 212 213 214 215 216
	struct fence **fences;
	unsigned i;
	int r = 0;

	fences = kmalloc_array(sizeof(void *), adev->vm_manager.num_ids,
			       GFP_KERNEL);
	if (!fences)
		return -ENOMEM;
A
Alex Deucher 已提交
217

218 219
	mutex_lock(&adev->vm_manager.lock);

220
	/* Check if we have an idle VMID */
221
	i = 0;
222
	list_for_each_entry(idle, &adev->vm_manager.ids_lru, list) {
223 224
		fences[i] = amdgpu_sync_peek_fence(&idle->active, ring);
		if (!fences[i])
225
			break;
226
		++i;
227 228
	}

229
	/* If we can't find a idle VMID to use, wait till one becomes available */
230
	if (&idle->list == &adev->vm_manager.ids_lru) {
231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260
		u64 fence_context = adev->vm_manager.fence_context + ring->idx;
		unsigned seqno = ++adev->vm_manager.seqno[ring->idx];
		struct fence_array *array;
		unsigned j;

		for (j = 0; j < i; ++j)
			fence_get(fences[j]);

		array = fence_array_create(i, fences, fence_context,
					   seqno, true);
		if (!array) {
			for (j = 0; j < i; ++j)
				fence_put(fences[j]);
			kfree(fences);
			r = -ENOMEM;
			goto error;
		}


		r = amdgpu_sync_fence(ring->adev, sync, &array->base);
		fence_put(&array->base);
		if (r)
			goto error;

		mutex_unlock(&adev->vm_manager.lock);
		return 0;

	}
	kfree(fences);

261
	job->vm_needs_flush = true;
262 263 264 265 266 267 268 269
	/* Check if we can use a VMID already assigned to this VM */
	i = ring->idx;
	do {
		struct fence *flushed;

		id = vm->ids[i++];
		if (i == AMDGPU_MAX_RINGS)
			i = 0;
270

271 272 273
		/* Check all the prerequisites to using this VMID */
		if (!id)
			continue;
274
		if (amdgpu_vm_is_gpu_reset(adev, id))
275
			continue;
276 277 278 279

		if (atomic64_read(&id->owner) != vm->client_id)
			continue;

280
		if (job->vm_pd_addr != id->pd_gpu_addr)
281 282
			continue;

283 284 285 286 287
		if (!id->last_flush)
			continue;

		if (id->last_flush->context != fence_context &&
		    !fence_is_signaled(id->last_flush))
288 289 290 291 292 293 294
			continue;

		flushed  = id->flushed_updates;
		if (updates &&
		    (!flushed || fence_is_later(updates, flushed)))
			continue;

295 296 297
		/* Good we can use this VMID. Remember this submission as
		 * user of the VMID.
		 */
298 299 300
		r = amdgpu_sync_fence(ring->adev, &id->active, fence);
		if (r)
			goto error;
301

302
		id->current_gpu_reset_count = atomic_read(&adev->gpu_reset_counter);
303 304
		list_move_tail(&id->list, &adev->vm_manager.ids_lru);
		vm->ids[ring->idx] = id;
305

306 307
		job->vm_id = id - adev->vm_manager.ids;
		job->vm_needs_flush = false;
308
		trace_amdgpu_vm_grab_id(vm, ring->idx, job);
309

310 311
		mutex_unlock(&adev->vm_manager.lock);
		return 0;
312

313
	} while (i != ring->idx);
314

315 316
	/* Still no ID to use? Then use the idle one found earlier */
	id = idle;
317

318 319
	/* Remember this submission as user of the VMID */
	r = amdgpu_sync_fence(ring->adev, &id->active, fence);
320 321
	if (r)
		goto error;
322

323 324
	fence_put(id->first);
	id->first = fence_get(fence);
325

326 327 328
	fence_put(id->last_flush);
	id->last_flush = NULL;

329 330
	fence_put(id->flushed_updates);
	id->flushed_updates = fence_get(updates);
331

332
	id->pd_gpu_addr = job->vm_pd_addr;
333
	id->current_gpu_reset_count = atomic_read(&adev->gpu_reset_counter);
334
	list_move_tail(&id->list, &adev->vm_manager.ids_lru);
335
	atomic64_set(&id->owner, vm->client_id);
336
	vm->ids[ring->idx] = id;
A
Alex Deucher 已提交
337

338
	job->vm_id = id - adev->vm_manager.ids;
339
	trace_amdgpu_vm_grab_id(vm, ring->idx, job);
340 341

error:
342
	mutex_unlock(&adev->vm_manager.lock);
343
	return r;
A
Alex Deucher 已提交
344 345
}

346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371
static bool amdgpu_vm_ring_has_compute_vm_bug(struct amdgpu_ring *ring)
{
	struct amdgpu_device *adev = ring->adev;
	const struct amdgpu_ip_block_version *ip_block;

	if (ring->type != AMDGPU_RING_TYPE_COMPUTE)
		/* only compute rings */
		return false;

	ip_block = amdgpu_get_ip_block(adev, AMD_IP_BLOCK_TYPE_GFX);
	if (!ip_block)
		return false;

	if (ip_block->major <= 7) {
		/* gfx7 has no workaround */
		return true;
	} else if (ip_block->major == 8) {
		if (adev->gfx.mec_fw_version >= 673)
			/* gfx8 is fixed in MEC firmware 673 */
			return false;
		else
			return true;
	}
	return false;
}

A
Alex Deucher 已提交
372 373 374 375
/**
 * amdgpu_vm_flush - hardware flush the vm
 *
 * @ring: ring to use for flush
376
 * @vm_id: vmid number to use
377
 * @pd_addr: address of the page directory
A
Alex Deucher 已提交
378
 *
379
 * Emit a VM flush when it is necessary.
A
Alex Deucher 已提交
380
 */
381
int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job)
A
Alex Deucher 已提交
382
{
383
	struct amdgpu_device *adev = ring->adev;
384
	struct amdgpu_vm_id *id = &adev->vm_manager.ids[job->vm_id];
385
	bool gds_switch_needed = ring->funcs->emit_gds_switch && (
386 387 388 389 390 391
		id->gds_base != job->gds_base ||
		id->gds_size != job->gds_size ||
		id->gws_base != job->gws_base ||
		id->gws_size != job->gws_size ||
		id->oa_base != job->oa_base ||
		id->oa_size != job->oa_size);
392
	int r;
393 394

	if (ring->funcs->emit_pipeline_sync && (
395
	    job->vm_needs_flush || gds_switch_needed ||
396
	    amdgpu_vm_ring_has_compute_vm_bug(ring)))
397
		amdgpu_ring_emit_pipeline_sync(ring);
398

399 400
	if (ring->funcs->emit_vm_flush && (job->vm_needs_flush ||
	    amdgpu_vm_is_gpu_reset(adev, id))) {
401 402
		struct fence *fence;

403 404
		trace_amdgpu_vm_flush(job->vm_pd_addr, ring->idx, job->vm_id);
		amdgpu_ring_emit_vm_flush(ring, job->vm_id, job->vm_pd_addr);
405

406 407 408 409
		r = amdgpu_fence_emit(ring, &fence);
		if (r)
			return r;

410
		mutex_lock(&adev->vm_manager.lock);
411 412
		fence_put(id->last_flush);
		id->last_flush = fence;
413
		mutex_unlock(&adev->vm_manager.lock);
A
Alex Deucher 已提交
414
	}
415

416
	if (gds_switch_needed) {
417 418 419 420 421 422 423 424 425 426
		id->gds_base = job->gds_base;
		id->gds_size = job->gds_size;
		id->gws_base = job->gws_base;
		id->gws_size = job->gws_size;
		id->oa_base = job->oa_base;
		id->oa_size = job->oa_size;
		amdgpu_ring_emit_gds_switch(ring, job->vm_id,
					    job->gds_base, job->gds_size,
					    job->gws_base, job->gws_size,
					    job->oa_base, job->oa_size);
427
	}
428 429

	return 0;
430 431 432 433 434 435 436 437 438 439 440 441
}

/**
 * amdgpu_vm_reset_id - reset VMID to zero
 *
 * @adev: amdgpu device structure
 * @vm_id: vmid number to use
 *
 * Reset saved GDW, GWS and OA to force switch on next flush.
 */
void amdgpu_vm_reset_id(struct amdgpu_device *adev, unsigned vm_id)
{
442 443 444 445 446 447 448 449
	struct amdgpu_vm_id *id = &adev->vm_manager.ids[vm_id];

	id->gds_base = 0;
	id->gds_size = 0;
	id->gws_base = 0;
	id->gws_size = 0;
	id->oa_base = 0;
	id->oa_size = 0;
A
Alex Deucher 已提交
450 451 452 453 454 455 456 457
}

/**
 * amdgpu_vm_bo_find - find the bo_va for a specific vm & bo
 *
 * @vm: requested vm
 * @bo: requested buffer object
 *
458
 * Find @bo inside the requested vm.
A
Alex Deucher 已提交
459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477
 * Search inside the @bos vm list for the requested vm
 * Returns the found bo_va or NULL if none is found
 *
 * Object has to be reserved!
 */
struct amdgpu_bo_va *amdgpu_vm_bo_find(struct amdgpu_vm *vm,
				       struct amdgpu_bo *bo)
{
	struct amdgpu_bo_va *bo_va;

	list_for_each_entry(bo_va, &bo->va, bo_list) {
		if (bo_va->vm == vm) {
			return bo_va;
		}
	}
	return NULL;
}

/**
478
 * amdgpu_vm_do_set_ptes - helper to call the right asic function
A
Alex Deucher 已提交
479
 *
480
 * @params: see amdgpu_pte_update_params definition
A
Alex Deucher 已提交
481 482 483 484 485 486 487 488 489
 * @pe: addr of the page entry
 * @addr: dst addr to write into pe
 * @count: number of page entries to update
 * @incr: increase next addr by incr bytes
 * @flags: hw access flags
 *
 * Traces the parameters and calls the right asic functions
 * to setup the page table using the DMA.
 */
490 491 492 493
static void amdgpu_vm_do_set_ptes(struct amdgpu_pte_update_params *params,
				  uint64_t pe, uint64_t addr,
				  unsigned count, uint32_t incr,
				  uint32_t flags)
A
Alex Deucher 已提交
494
{
495
	trace_amdgpu_vm_set_ptes(pe, addr, count, incr, flags);
A
Alex Deucher 已提交
496

497
	if (count < 3) {
498 499
		amdgpu_vm_write_pte(params->adev, params->ib, pe,
				    addr | flags, count, incr);
A
Alex Deucher 已提交
500 501

	} else {
502
		amdgpu_vm_set_pte_pde(params->adev, params->ib, pe, addr,
A
Alex Deucher 已提交
503 504 505 506
				      count, incr, flags);
	}
}

507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523
/**
 * amdgpu_vm_do_copy_ptes - copy the PTEs from the GART
 *
 * @params: see amdgpu_pte_update_params definition
 * @pe: addr of the page entry
 * @addr: dst addr to write into pe
 * @count: number of page entries to update
 * @incr: increase next addr by incr bytes
 * @flags: hw access flags
 *
 * Traces the parameters and calls the DMA function to copy the PTEs.
 */
static void amdgpu_vm_do_copy_ptes(struct amdgpu_pte_update_params *params,
				   uint64_t pe, uint64_t addr,
				   unsigned count, uint32_t incr,
				   uint32_t flags)
{
524
	uint64_t src = (params->src + (addr >> 12) * 8);
525

526 527 528 529

	trace_amdgpu_vm_copy_ptes(pe, src, count);

	amdgpu_vm_copy_pte(params->adev, params->ib, pe, src, count);
530 531
}

A
Alex Deucher 已提交
532 533 534 535 536
/**
 * amdgpu_vm_clear_bo - initially clear the page dir/table
 *
 * @adev: amdgpu_device pointer
 * @bo: bo to clear
537 538
 *
 * need to reserve bo first before calling it.
A
Alex Deucher 已提交
539 540
 */
static int amdgpu_vm_clear_bo(struct amdgpu_device *adev,
541
			      struct amdgpu_vm *vm,
A
Alex Deucher 已提交
542 543
			      struct amdgpu_bo *bo)
{
544
	struct amdgpu_ring *ring;
545
	struct fence *fence = NULL;
546
	struct amdgpu_job *job;
547
	struct amdgpu_pte_update_params params;
A
Alex Deucher 已提交
548 549 550 551
	unsigned entries;
	uint64_t addr;
	int r;

552 553
	ring = container_of(vm->entity.sched, struct amdgpu_ring, sched);

M
monk.liu 已提交
554 555 556 557
	r = reservation_object_reserve_shared(bo->tbo.resv);
	if (r)
		return r;

A
Alex Deucher 已提交
558 559
	r = ttm_bo_validate(&bo->tbo, &bo->placement, true, false);
	if (r)
560
		goto error;
A
Alex Deucher 已提交
561

562 563 564 565
	r = amdgpu_ttm_bind(&bo->tbo, &bo->tbo.mem);
	if (r)
		goto error;

A
Alex Deucher 已提交
566 567 568
	addr = amdgpu_bo_gpu_offset(bo);
	entries = amdgpu_bo_size(bo) / 8;

569 570
	r = amdgpu_job_alloc_with_ib(adev, 64, &job);
	if (r)
571
		goto error;
A
Alex Deucher 已提交
572

573 574
	memset(&params, 0, sizeof(params));
	params.adev = adev;
575
	params.ib = &job->ibs[0];
576
	amdgpu_vm_do_set_ptes(&params, addr, 0, entries, 0, 0);
577 578 579
	amdgpu_ring_pad_ib(ring, &job->ibs[0]);

	WARN_ON(job->ibs[0].length_dw > 64);
580 581
	r = amdgpu_job_submit(job, ring, &vm->entity,
			      AMDGPU_FENCE_OWNER_VM, &fence);
A
Alex Deucher 已提交
582 583 584
	if (r)
		goto error_free;

585
	amdgpu_bo_fence(bo, fence, true);
586
	fence_put(fence);
587
	return 0;
588

A
Alex Deucher 已提交
589
error_free:
590
	amdgpu_job_free(job);
A
Alex Deucher 已提交
591

592
error:
A
Alex Deucher 已提交
593 594 595 596
	return r;
}

/**
597
 * amdgpu_vm_map_gart - Resolve gart mapping of addr
A
Alex Deucher 已提交
598
 *
599
 * @pages_addr: optional DMA address to use for lookup
A
Alex Deucher 已提交
600 601 602
 * @addr: the unmapped addr
 *
 * Look up the physical address of the page that the pte resolves
603
 * to and return the pointer for the page table entry.
A
Alex Deucher 已提交
604
 */
605
static uint64_t amdgpu_vm_map_gart(const dma_addr_t *pages_addr, uint64_t addr)
A
Alex Deucher 已提交
606 607 608
{
	uint64_t result;

609 610
	/* page table offset */
	result = pages_addr[addr >> PAGE_SHIFT];
611

612 613
	/* in case cpu page size != gpu page size*/
	result |= addr & (~PAGE_MASK);
A
Alex Deucher 已提交
614

615
	result &= 0xFFFFFFFFFFFFF000ULL;
A
Alex Deucher 已提交
616 617 618 619

	return result;
}

620 621 622 623 624 625 626 627 628 629 630 631 632 633
/*
 * amdgpu_vm_update_pdes - make sure that page directory is valid
 *
 * @adev: amdgpu_device pointer
 * @vm: requested vm
 * @start: start of GPU address range
 * @end: end of GPU address range
 *
 * Allocates new page tables if necessary
 * and updates the page directory.
 * Returns 0 for success, error for failure.
 */
int amdgpu_vm_update_page_directory(struct amdgpu_device *adev,
				    struct amdgpu_vm *vm)
A
Alex Deucher 已提交
634
{
635
	struct amdgpu_bo *shadow;
636
	struct amdgpu_ring *ring;
637
	uint64_t pd_addr, shadow_addr;
A
Alex Deucher 已提交
638
	uint32_t incr = AMDGPU_VM_PTE_COUNT * 8;
639
	uint64_t last_pde = ~0, last_pt = ~0, last_shadow = ~0;
A
Alex Deucher 已提交
640
	unsigned count = 0, pt_idx, ndw;
641
	struct amdgpu_job *job;
642
	struct amdgpu_pte_update_params params;
643
	struct fence *fence = NULL;
C
Chunming Zhou 已提交
644

A
Alex Deucher 已提交
645 646
	int r;

647
	ring = container_of(vm->entity.sched, struct amdgpu_ring, sched);
648
	shadow = vm->page_directory->shadow;
649

A
Alex Deucher 已提交
650 651 652 653 654 655
	/* padding, etc. */
	ndw = 64;

	/* assume the worst case */
	ndw += vm->max_pde_used * 6;

656 657 658 659 660 661 662 663 664 665 666
	pd_addr = amdgpu_bo_gpu_offset(vm->page_directory);
	if (shadow) {
		r = amdgpu_ttm_bind(&shadow->tbo, &shadow->tbo.mem);
		if (r)
			return r;
		shadow_addr = amdgpu_bo_gpu_offset(shadow);
		ndw *= 2;
	} else {
		shadow_addr = 0;
	}

667 668
	r = amdgpu_job_alloc_with_ib(adev, ndw * 4, &job);
	if (r)
A
Alex Deucher 已提交
669
		return r;
670

671 672
	memset(&params, 0, sizeof(params));
	params.adev = adev;
673
	params.ib = &job->ibs[0];
A
Alex Deucher 已提交
674 675 676

	/* walk over the address space and update the page directory */
	for (pt_idx = 0; pt_idx <= vm->max_pde_used; ++pt_idx) {
677
		struct amdgpu_bo *bo = vm->page_tables[pt_idx].bo;
A
Alex Deucher 已提交
678 679 680 681 682
		uint64_t pde, pt;

		if (bo == NULL)
			continue;

683
		if (bo->shadow) {
684
			struct amdgpu_bo *pt_shadow = bo->shadow;
685

686 687
			r = amdgpu_ttm_bind(&pt_shadow->tbo,
					    &pt_shadow->tbo.mem);
688 689 690 691
			if (r)
				return r;
		}

A
Alex Deucher 已提交
692
		pt = amdgpu_bo_gpu_offset(bo);
693 694 695 696
		if (vm->page_tables[pt_idx].addr == pt)
			continue;

		vm->page_tables[pt_idx].addr = pt;
A
Alex Deucher 已提交
697 698 699

		pde = pd_addr + pt_idx * 8;
		if (((last_pde + 8 * count) != pde) ||
700 701
		    ((last_pt + incr * count) != pt) ||
		    (count == AMDGPU_VM_MAX_UPDATE_SIZE)) {
A
Alex Deucher 已提交
702 703

			if (count) {
704 705 706 707 708 709 710
				if (shadow)
					amdgpu_vm_do_set_ptes(&params,
							      last_shadow,
							      last_pt, count,
							      incr,
							      AMDGPU_PTE_VALID);

711 712 713
				amdgpu_vm_do_set_ptes(&params, last_pde,
						      last_pt, count, incr,
						      AMDGPU_PTE_VALID);
A
Alex Deucher 已提交
714 715 716 717
			}

			count = 1;
			last_pde = pde;
718
			last_shadow = shadow_addr + pt_idx * 8;
A
Alex Deucher 已提交
719 720 721 722 723 724
			last_pt = pt;
		} else {
			++count;
		}
	}

725 726 727 728 729
	if (count) {
		if (vm->page_directory->shadow)
			amdgpu_vm_do_set_ptes(&params, last_shadow, last_pt,
					      count, incr, AMDGPU_PTE_VALID);

730 731
		amdgpu_vm_do_set_ptes(&params, last_pde, last_pt,
				      count, incr, AMDGPU_PTE_VALID);
732
	}
A
Alex Deucher 已提交
733

734 735 736 737 738 739 740 741 742 743
	if (params.ib->length_dw == 0) {
		amdgpu_job_free(job);
		return 0;
	}

	amdgpu_ring_pad_ib(ring, params.ib);
	amdgpu_sync_resv(adev, &job->sync, vm->page_directory->tbo.resv,
			 AMDGPU_FENCE_OWNER_VM);
	if (shadow)
		amdgpu_sync_resv(adev, &job->sync, shadow->tbo.resv,
744
				 AMDGPU_FENCE_OWNER_VM);
745

746 747 748 749 750
	WARN_ON(params.ib->length_dw > ndw);
	r = amdgpu_job_submit(job, ring, &vm->entity,
			      AMDGPU_FENCE_OWNER_VM, &fence);
	if (r)
		goto error_free;
C
Chunming Zhou 已提交
751

752 753 754 755
	amdgpu_bo_fence(vm->page_directory, fence, true);
	fence_put(vm->page_directory_fence);
	vm->page_directory_fence = fence_get(fence);
	fence_put(fence);
A
Alex Deucher 已提交
756 757

	return 0;
C
Chunming Zhou 已提交
758 759

error_free:
760
	amdgpu_job_free(job);
761
	return r;
A
Alex Deucher 已提交
762 763 764 765 766
}

/**
 * amdgpu_vm_update_ptes - make sure that page tables are valid
 *
767
 * @params: see amdgpu_pte_update_params definition
A
Alex Deucher 已提交
768 769 770
 * @vm: requested vm
 * @start: start of GPU address range
 * @end: end of GPU address range
771
 * @dst: destination address to map to, the next dst inside the function
A
Alex Deucher 已提交
772 773
 * @flags: mapping flags
 *
774
 * Update the page tables in the range @start - @end.
A
Alex Deucher 已提交
775
 */
776
static void amdgpu_vm_update_ptes(struct amdgpu_pte_update_params *params,
777 778 779
				  struct amdgpu_vm *vm,
				  uint64_t start, uint64_t end,
				  uint64_t dst, uint32_t flags)
A
Alex Deucher 已提交
780
{
781 782
	const uint64_t mask = AMDGPU_VM_PTE_COUNT - 1;

783
	uint64_t cur_pe_start, cur_nptes, cur_dst;
784
	uint64_t addr; /* next GPU address to be updated */
785 786 787 788 789 790 791 792
	uint64_t pt_idx;
	struct amdgpu_bo *pt;
	unsigned nptes; /* next number of ptes to be updated */
	uint64_t next_pe_start;

	/* initialize the variables */
	addr = start;
	pt_idx = addr >> amdgpu_vm_block_size;
793
	pt = vm->page_tables[pt_idx].bo;
794 795 796
	if (params->shadow) {
		if (!pt->shadow)
			return;
797
		pt = pt->shadow;
798
	}
799 800 801 802 803 804 805
	if ((addr & ~mask) == (end & ~mask))
		nptes = end - addr;
	else
		nptes = AMDGPU_VM_PTE_COUNT - (addr & mask);

	cur_pe_start = amdgpu_bo_gpu_offset(pt);
	cur_pe_start += (addr & mask) * 8;
806
	cur_nptes = nptes;
807 808 809 810 811
	cur_dst = dst;

	/* for next ptb*/
	addr += nptes;
	dst += nptes * AMDGPU_GPU_PAGE_SIZE;
A
Alex Deucher 已提交
812 813

	/* walk over the address space and update the page tables */
814 815
	while (addr < end) {
		pt_idx = addr >> amdgpu_vm_block_size;
816
		pt = vm->page_tables[pt_idx].bo;
817 818 819
		if (params->shadow) {
			if (!pt->shadow)
				return;
820
			pt = pt->shadow;
821
		}
A
Alex Deucher 已提交
822 823 824 825 826 827

		if ((addr & ~mask) == (end & ~mask))
			nptes = end - addr;
		else
			nptes = AMDGPU_VM_PTE_COUNT - (addr & mask);

828 829
		next_pe_start = amdgpu_bo_gpu_offset(pt);
		next_pe_start += (addr & mask) * 8;
A
Alex Deucher 已提交
830

831 832
		if ((cur_pe_start + 8 * cur_nptes) == next_pe_start &&
		    ((cur_nptes + nptes) <= AMDGPU_VM_MAX_UPDATE_SIZE)) {
833
			/* The next ptb is consecutive to current ptb.
834
			 * Don't call the update function now.
835 836
			 * Will update two ptbs together in future.
			*/
837
			cur_nptes += nptes;
838
		} else {
839 840
			params->func(params, cur_pe_start, cur_dst, cur_nptes,
				     AMDGPU_GPU_PAGE_SIZE, flags);
A
Alex Deucher 已提交
841

842
			cur_pe_start = next_pe_start;
843
			cur_nptes = nptes;
844
			cur_dst = dst;
A
Alex Deucher 已提交
845 846
		}

847
		/* for next ptb*/
A
Alex Deucher 已提交
848 849 850 851
		addr += nptes;
		dst += nptes * AMDGPU_GPU_PAGE_SIZE;
	}

852 853
	params->func(params, cur_pe_start, cur_dst, cur_nptes,
		     AMDGPU_GPU_PAGE_SIZE, flags);
854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889
}

/*
 * amdgpu_vm_frag_ptes - add fragment information to PTEs
 *
 * @params: see amdgpu_pte_update_params definition
 * @vm: requested vm
 * @start: first PTE to handle
 * @end: last PTE to handle
 * @dst: addr those PTEs should point to
 * @flags: hw mapping flags
 */
static void amdgpu_vm_frag_ptes(struct amdgpu_pte_update_params	*params,
				struct amdgpu_vm *vm,
				uint64_t start, uint64_t end,
				uint64_t dst, uint32_t flags)
{
	/**
	 * The MC L1 TLB supports variable sized pages, based on a fragment
	 * field in the PTE. When this field is set to a non-zero value, page
	 * granularity is increased from 4KB to (1 << (12 + frag)). The PTE
	 * flags are considered valid for all PTEs within the fragment range
	 * and corresponding mappings are assumed to be physically contiguous.
	 *
	 * The L1 TLB can store a single PTE for the whole fragment,
	 * significantly increasing the space available for translation
	 * caching. This leads to large improvements in throughput when the
	 * TLB is under pressure.
	 *
	 * The L2 TLB distributes small and large fragments into two
	 * asymmetric partitions. The large fragment cache is significantly
	 * larger. Thus, we try to use large fragments wherever possible.
	 * Userspace can support this by aligning virtual base address and
	 * allocation size to the fragment size.
	 */

890 891 892
	/* SI and newer are optimized for 64KB */
	uint64_t frag_flags = AMDGPU_PTE_FRAG(AMDGPU_LOG2_PAGES_PER_FRAG);
	uint64_t frag_align = 1 << AMDGPU_LOG2_PAGES_PER_FRAG;
893 894 895 896 897

	uint64_t frag_start = ALIGN(start, frag_align);
	uint64_t frag_end = end & ~(frag_align - 1);

	/* system pages are non continuously */
898
	if (params->src || !(flags & AMDGPU_PTE_VALID) ||
899 900 901 902 903 904 905 906 907 908 909 910 911 912 913
	    (frag_start >= frag_end)) {

		amdgpu_vm_update_ptes(params, vm, start, end, dst, flags);
		return;
	}

	/* handle the 4K area at the beginning */
	if (start != frag_start) {
		amdgpu_vm_update_ptes(params, vm, start, frag_start,
				      dst, flags);
		dst += (frag_start - start) * AMDGPU_GPU_PAGE_SIZE;
	}

	/* handle the area in the middle */
	amdgpu_vm_update_ptes(params, vm, frag_start, frag_end, dst,
914
			      flags | frag_flags);
915 916 917 918 919 920

	/* handle the 4K area at the end */
	if (frag_end != end) {
		dst += (frag_end - frag_start) * AMDGPU_GPU_PAGE_SIZE;
		amdgpu_vm_update_ptes(params, vm, frag_end, end, dst, flags);
	}
A
Alex Deucher 已提交
921 922 923 924 925 926
}

/**
 * amdgpu_vm_bo_update_mapping - update a mapping in the vm page table
 *
 * @adev: amdgpu_device pointer
927
 * @exclusive: fence we need to sync to
928 929
 * @src: address where to copy page table entries from
 * @pages_addr: DMA addresses to use for mapping
A
Alex Deucher 已提交
930
 * @vm: requested vm
931 932 933
 * @start: start of mapped range
 * @last: last mapped entry
 * @flags: flags for the entries
A
Alex Deucher 已提交
934 935 936
 * @addr: addr to set the area to
 * @fence: optional resulting fence
 *
937
 * Fill in the page table entries between @start and @last.
A
Alex Deucher 已提交
938 939 940
 * Returns 0 for success, -EINVAL for failure.
 */
static int amdgpu_vm_bo_update_mapping(struct amdgpu_device *adev,
941
				       struct fence *exclusive,
942 943
				       uint64_t src,
				       dma_addr_t *pages_addr,
A
Alex Deucher 已提交
944
				       struct amdgpu_vm *vm,
945 946 947
				       uint64_t start, uint64_t last,
				       uint32_t flags, uint64_t addr,
				       struct fence **fence)
A
Alex Deucher 已提交
948
{
949
	struct amdgpu_ring *ring;
950
	void *owner = AMDGPU_FENCE_OWNER_VM;
A
Alex Deucher 已提交
951
	unsigned nptes, ncmds, ndw;
952
	struct amdgpu_job *job;
953
	struct amdgpu_pte_update_params params;
954
	struct fence *f = NULL;
A
Alex Deucher 已提交
955 956
	int r;

957 958 959 960
	memset(&params, 0, sizeof(params));
	params.adev = adev;
	params.src = src;

961
	ring = container_of(vm->entity.sched, struct amdgpu_ring, sched);
962

963
	memset(&params, 0, sizeof(params));
964
	params.adev = adev;
965
	params.src = src;
966

967 968 969 970
	/* sync to everything on unmapping */
	if (!(flags & AMDGPU_PTE_VALID))
		owner = AMDGPU_FENCE_OWNER_UNDEFINED;

971
	nptes = last - start + 1;
A
Alex Deucher 已提交
972 973 974 975 976 977 978 979 980 981

	/*
	 * reserve space for one command every (1 << BLOCK_SIZE)
	 *  entries or 2k dwords (whatever is smaller)
	 */
	ncmds = (nptes >> min(amdgpu_vm_block_size, 11)) + 1;

	/* padding, etc. */
	ndw = 64;

982
	if (src) {
A
Alex Deucher 已提交
983 984 985
		/* only copy commands needed */
		ndw += ncmds * 7;

986 987
		params.func = amdgpu_vm_do_copy_ptes;

988 989 990
	} else if (pages_addr) {
		/* copy commands needed */
		ndw += ncmds * 7;
A
Alex Deucher 已提交
991

992
		/* and also PTEs */
A
Alex Deucher 已提交
993 994
		ndw += nptes * 2;

995 996
		params.func = amdgpu_vm_do_copy_ptes;

A
Alex Deucher 已提交
997 998 999 1000 1001 1002
	} else {
		/* set page commands needed */
		ndw += ncmds * 10;

		/* two extra commands for begin/end of fragment */
		ndw += 2 * 10;
1003 1004

		params.func = amdgpu_vm_do_set_ptes;
A
Alex Deucher 已提交
1005 1006
	}

1007 1008
	r = amdgpu_job_alloc_with_ib(adev, ndw * 4, &job);
	if (r)
A
Alex Deucher 已提交
1009
		return r;
1010

1011
	params.ib = &job->ibs[0];
C
Chunming Zhou 已提交
1012

1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026
	if (!src && pages_addr) {
		uint64_t *pte;
		unsigned i;

		/* Put the PTEs at the end of the IB. */
		i = ndw - nptes * 2;
		pte= (uint64_t *)&(job->ibs->ptr[i]);
		params.src = job->ibs->gpu_addr + i * 4;

		for (i = 0; i < nptes; ++i) {
			pte[i] = amdgpu_vm_map_gart(pages_addr, addr + i *
						    AMDGPU_GPU_PAGE_SIZE);
			pte[i] |= flags;
		}
1027
		addr = 0;
1028 1029
	}

1030 1031 1032 1033
	r = amdgpu_sync_fence(adev, &job->sync, exclusive);
	if (r)
		goto error_free;

1034
	r = amdgpu_sync_resv(adev, &job->sync, vm->page_directory->tbo.resv,
1035 1036 1037
			     owner);
	if (r)
		goto error_free;
A
Alex Deucher 已提交
1038

1039 1040 1041 1042
	r = reservation_object_reserve_shared(vm->page_directory->tbo.resv);
	if (r)
		goto error_free;

1043 1044 1045
	params.shadow = true;
	amdgpu_vm_frag_ptes(&params, vm, start, last + 1, addr, flags);
	params.shadow = false;
1046
	amdgpu_vm_frag_ptes(&params, vm, start, last + 1, addr, flags);
A
Alex Deucher 已提交
1047

1048 1049
	amdgpu_ring_pad_ib(ring, params.ib);
	WARN_ON(params.ib->length_dw > ndw);
1050 1051
	r = amdgpu_job_submit(job, ring, &vm->entity,
			      AMDGPU_FENCE_OWNER_VM, &f);
1052 1053
	if (r)
		goto error_free;
A
Alex Deucher 已提交
1054

1055
	amdgpu_bo_fence(vm->page_directory, f, true);
1056 1057 1058 1059
	if (fence) {
		fence_put(*fence);
		*fence = fence_get(f);
	}
1060
	fence_put(f);
A
Alex Deucher 已提交
1061
	return 0;
C
Chunming Zhou 已提交
1062 1063

error_free:
1064
	amdgpu_job_free(job);
1065
	return r;
A
Alex Deucher 已提交
1066 1067
}

1068 1069 1070 1071
/**
 * amdgpu_vm_bo_split_mapping - split a mapping into smaller chunks
 *
 * @adev: amdgpu_device pointer
1072
 * @exclusive: fence we need to sync to
1073 1074
 * @gtt_flags: flags as they are used for GTT
 * @pages_addr: DMA addresses to use for mapping
1075 1076
 * @vm: requested vm
 * @mapping: mapped range and flags to use for the update
1077
 * @flags: HW flags for the mapping
1078
 * @nodes: array of drm_mm_nodes with the MC addresses
1079 1080 1081 1082 1083 1084 1085
 * @fence: optional resulting fence
 *
 * Split the mapping into smaller chunks so that each update fits
 * into a SDMA IB.
 * Returns 0 for success, -EINVAL for failure.
 */
static int amdgpu_vm_bo_split_mapping(struct amdgpu_device *adev,
1086
				      struct fence *exclusive,
1087
				      uint32_t gtt_flags,
1088
				      dma_addr_t *pages_addr,
1089 1090
				      struct amdgpu_vm *vm,
				      struct amdgpu_bo_va_mapping *mapping,
1091 1092
				      uint32_t flags,
				      struct drm_mm_node *nodes,
1093
				      struct fence **fence)
1094
{
1095
	uint64_t pfn, src = 0, start = mapping->it.start;
1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107
	int r;

	/* normally,bo_va->flags only contians READABLE and WIRTEABLE bit go here
	 * but in case of something, we filter the flags in first place
	 */
	if (!(mapping->flags & AMDGPU_PTE_READABLE))
		flags &= ~AMDGPU_PTE_READABLE;
	if (!(mapping->flags & AMDGPU_PTE_WRITEABLE))
		flags &= ~AMDGPU_PTE_WRITEABLE;

	trace_amdgpu_vm_bo_update(mapping);

1108 1109 1110 1111 1112 1113
	pfn = mapping->offset >> PAGE_SHIFT;
	if (nodes) {
		while (pfn >= nodes->size) {
			pfn -= nodes->size;
			++nodes;
		}
1114
	}
1115

1116 1117 1118
	do {
		uint64_t max_entries;
		uint64_t addr, last;
1119

1120 1121 1122 1123 1124 1125 1126 1127
		if (nodes) {
			addr = nodes->start << PAGE_SHIFT;
			max_entries = (nodes->size - pfn) *
				(PAGE_SIZE / AMDGPU_GPU_PAGE_SIZE);
		} else {
			addr = 0;
			max_entries = S64_MAX;
		}
1128

1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141
		if (pages_addr) {
			if (flags == gtt_flags)
				src = adev->gart.table_addr +
					(addr >> AMDGPU_GPU_PAGE_SHIFT) * 8;
			else
				max_entries = min(max_entries, 16ull * 1024ull);
			addr = 0;
		} else if (flags & AMDGPU_PTE_VALID) {
			addr += adev->vm_manager.vram_base_offset;
		}
		addr += pfn << PAGE_SHIFT;

		last = min((uint64_t)mapping->it.last, start + max_entries - 1);
1142 1143
		r = amdgpu_vm_bo_update_mapping(adev, exclusive,
						src, pages_addr, vm,
1144 1145 1146 1147 1148
						start, last, flags, addr,
						fence);
		if (r)
			return r;

1149 1150 1151 1152 1153
		pfn += last - start + 1;
		if (nodes && nodes->size == pfn) {
			pfn = 0;
			++nodes;
		}
1154
		start = last + 1;
1155 1156

	} while (unlikely(start != mapping->it.last + 1));
1157 1158 1159 1160

	return 0;
}

A
Alex Deucher 已提交
1161 1162 1163 1164 1165
/**
 * amdgpu_vm_bo_update - update all BO mappings in the vm page table
 *
 * @adev: amdgpu_device pointer
 * @bo_va: requested BO and VM object
1166
 * @clear: if true clear the entries
A
Alex Deucher 已提交
1167 1168 1169 1170 1171 1172
 *
 * Fill in the page table entries for @bo_va.
 * Returns 0 for success, -EINVAL for failure.
 */
int amdgpu_vm_bo_update(struct amdgpu_device *adev,
			struct amdgpu_bo_va *bo_va,
1173
			bool clear)
A
Alex Deucher 已提交
1174 1175 1176
{
	struct amdgpu_vm *vm = bo_va->vm;
	struct amdgpu_bo_va_mapping *mapping;
1177
	dma_addr_t *pages_addr = NULL;
1178
	uint32_t gtt_flags, flags;
1179
	struct ttm_mem_reg *mem;
1180
	struct drm_mm_node *nodes;
1181
	struct fence *exclusive;
A
Alex Deucher 已提交
1182 1183
	int r;

1184 1185
	if (clear) {
		mem = NULL;
1186
		nodes = NULL;
1187 1188
		exclusive = NULL;
	} else {
1189 1190
		struct ttm_dma_tt *ttm;

1191
		mem = &bo_va->bo->tbo.mem;
1192 1193
		nodes = mem->mm_node;
		if (mem->mem_type == TTM_PL_TT) {
1194 1195 1196
			ttm = container_of(bo_va->bo->tbo.ttm, struct
					   ttm_dma_tt, ttm);
			pages_addr = ttm->dma_address;
1197
		}
1198
		exclusive = reservation_object_get_excl(bo_va->bo->tbo.resv);
A
Alex Deucher 已提交
1199 1200 1201
	}

	flags = amdgpu_ttm_tt_pte_flags(adev, bo_va->bo->tbo.ttm, mem);
1202
	gtt_flags = (amdgpu_ttm_is_bound(bo_va->bo->tbo.ttm) &&
1203
		adev == amdgpu_ttm_adev(bo_va->bo->tbo.bdev)) ? flags : 0;
A
Alex Deucher 已提交
1204

1205 1206 1207 1208 1209 1210
	spin_lock(&vm->status_lock);
	if (!list_empty(&bo_va->vm_status))
		list_splice_init(&bo_va->valids, &bo_va->invalids);
	spin_unlock(&vm->status_lock);

	list_for_each_entry(mapping, &bo_va->invalids, list) {
1211 1212
		r = amdgpu_vm_bo_split_mapping(adev, exclusive,
					       gtt_flags, pages_addr, vm,
1213
					       mapping, flags, nodes,
1214
					       &bo_va->last_pt_update);
A
Alex Deucher 已提交
1215 1216 1217 1218
		if (r)
			return r;
	}

1219 1220 1221 1222 1223 1224 1225 1226
	if (trace_amdgpu_vm_bo_mapping_enabled()) {
		list_for_each_entry(mapping, &bo_va->valids, list)
			trace_amdgpu_vm_bo_mapping(mapping);

		list_for_each_entry(mapping, &bo_va->invalids, list)
			trace_amdgpu_vm_bo_mapping(mapping);
	}

A
Alex Deucher 已提交
1227
	spin_lock(&vm->status_lock);
1228
	list_splice_init(&bo_va->invalids, &bo_va->valids);
A
Alex Deucher 已提交
1229
	list_del_init(&bo_va->vm_status);
1230
	if (clear)
1231
		list_add(&bo_va->vm_status, &vm->cleared);
A
Alex Deucher 已提交
1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257
	spin_unlock(&vm->status_lock);

	return 0;
}

/**
 * amdgpu_vm_clear_freed - clear freed BOs in the PT
 *
 * @adev: amdgpu_device pointer
 * @vm: requested vm
 *
 * Make sure all freed BOs are cleared in the PT.
 * Returns 0 for success.
 *
 * PTs have to be reserved and mutex must be locked!
 */
int amdgpu_vm_clear_freed(struct amdgpu_device *adev,
			  struct amdgpu_vm *vm)
{
	struct amdgpu_bo_va_mapping *mapping;
	int r;

	while (!list_empty(&vm->freed)) {
		mapping = list_first_entry(&vm->freed,
			struct amdgpu_bo_va_mapping, list);
		list_del(&mapping->list);
1258

1259
		r = amdgpu_vm_bo_split_mapping(adev, NULL, 0, NULL, vm, mapping,
1260
					       0, 0, NULL);
A
Alex Deucher 已提交
1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281
		kfree(mapping);
		if (r)
			return r;

	}
	return 0;

}

/**
 * amdgpu_vm_clear_invalids - clear invalidated BOs in the PT
 *
 * @adev: amdgpu_device pointer
 * @vm: requested vm
 *
 * Make sure all invalidated BOs are cleared in the PT.
 * Returns 0 for success.
 *
 * PTs have to be reserved and mutex must be locked!
 */
int amdgpu_vm_clear_invalids(struct amdgpu_device *adev,
1282
			     struct amdgpu_vm *vm, struct amdgpu_sync *sync)
A
Alex Deucher 已提交
1283
{
1284
	struct amdgpu_bo_va *bo_va = NULL;
1285
	int r = 0;
A
Alex Deucher 已提交
1286 1287 1288 1289 1290 1291

	spin_lock(&vm->status_lock);
	while (!list_empty(&vm->invalidated)) {
		bo_va = list_first_entry(&vm->invalidated,
			struct amdgpu_bo_va, vm_status);
		spin_unlock(&vm->status_lock);
1292

1293
		r = amdgpu_vm_bo_update(adev, bo_va, true);
A
Alex Deucher 已提交
1294 1295 1296 1297 1298 1299 1300
		if (r)
			return r;

		spin_lock(&vm->status_lock);
	}
	spin_unlock(&vm->status_lock);

1301
	if (bo_va)
1302
		r = amdgpu_sync_fence(adev, sync, bo_va->last_pt_update);
1303 1304

	return r;
A
Alex Deucher 已提交
1305 1306 1307 1308 1309 1310 1311 1312 1313
}

/**
 * amdgpu_vm_bo_add - add a bo to a specific vm
 *
 * @adev: amdgpu_device pointer
 * @vm: requested vm
 * @bo: amdgpu buffer object
 *
1314
 * Add @bo into the requested vm.
A
Alex Deucher 已提交
1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333
 * Add @bo to the list of bos associated with the vm
 * Returns newly added bo_va or NULL for failure
 *
 * Object has to be reserved!
 */
struct amdgpu_bo_va *amdgpu_vm_bo_add(struct amdgpu_device *adev,
				      struct amdgpu_vm *vm,
				      struct amdgpu_bo *bo)
{
	struct amdgpu_bo_va *bo_va;

	bo_va = kzalloc(sizeof(struct amdgpu_bo_va), GFP_KERNEL);
	if (bo_va == NULL) {
		return NULL;
	}
	bo_va->vm = vm;
	bo_va->bo = bo;
	bo_va->ref_count = 1;
	INIT_LIST_HEAD(&bo_va->bo_list);
1334 1335
	INIT_LIST_HEAD(&bo_va->valids);
	INIT_LIST_HEAD(&bo_va->invalids);
A
Alex Deucher 已提交
1336
	INIT_LIST_HEAD(&bo_va->vm_status);
1337

A
Alex Deucher 已提交
1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354
	list_add_tail(&bo_va->bo_list, &bo->va);

	return bo_va;
}

/**
 * amdgpu_vm_bo_map - map bo inside a vm
 *
 * @adev: amdgpu_device pointer
 * @bo_va: bo_va to store the address
 * @saddr: where to map the BO
 * @offset: requested offset in the BO
 * @flags: attributes of pages (read/write/valid/etc.)
 *
 * Add a mapping of the BO at the specefied addr into the VM.
 * Returns 0 for success, error for failure.
 *
1355
 * Object has to be reserved and unreserved outside!
A
Alex Deucher 已提交
1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368
 */
int amdgpu_vm_bo_map(struct amdgpu_device *adev,
		     struct amdgpu_bo_va *bo_va,
		     uint64_t saddr, uint64_t offset,
		     uint64_t size, uint32_t flags)
{
	struct amdgpu_bo_va_mapping *mapping;
	struct amdgpu_vm *vm = bo_va->vm;
	struct interval_tree_node *it;
	unsigned last_pfn, pt_idx;
	uint64_t eaddr;
	int r;

1369 1370
	/* validate the parameters */
	if (saddr & AMDGPU_GPU_PAGE_MASK || offset & AMDGPU_GPU_PAGE_MASK ||
1371
	    size == 0 || size & AMDGPU_GPU_PAGE_MASK)
1372 1373
		return -EINVAL;

A
Alex Deucher 已提交
1374
	/* make sure object fit at this offset */
1375
	eaddr = saddr + size - 1;
1376
	if ((saddr >= eaddr) || (offset + size > amdgpu_bo_size(bo_va->bo)))
A
Alex Deucher 已提交
1377 1378 1379
		return -EINVAL;

	last_pfn = eaddr / AMDGPU_GPU_PAGE_SIZE;
1380 1381
	if (last_pfn >= adev->vm_manager.max_pfn) {
		dev_err(adev->dev, "va above limit (0x%08X >= 0x%08X)\n",
A
Alex Deucher 已提交
1382 1383 1384 1385 1386 1387 1388
			last_pfn, adev->vm_manager.max_pfn);
		return -EINVAL;
	}

	saddr /= AMDGPU_GPU_PAGE_SIZE;
	eaddr /= AMDGPU_GPU_PAGE_SIZE;

1389
	it = interval_tree_iter_first(&vm->va, saddr, eaddr);
A
Alex Deucher 已提交
1390 1391 1392 1393 1394 1395 1396 1397
	if (it) {
		struct amdgpu_bo_va_mapping *tmp;
		tmp = container_of(it, struct amdgpu_bo_va_mapping, it);
		/* bo and tmp overlap, invalid addr */
		dev_err(adev->dev, "bo %p va 0x%010Lx-0x%010Lx conflict with "
			"0x%010lx-0x%010lx\n", bo_va->bo, saddr, eaddr,
			tmp->it.start, tmp->it.last + 1);
		r = -EINVAL;
1398
		goto error;
A
Alex Deucher 已提交
1399 1400 1401 1402 1403
	}

	mapping = kmalloc(sizeof(*mapping), GFP_KERNEL);
	if (!mapping) {
		r = -ENOMEM;
1404
		goto error;
A
Alex Deucher 已提交
1405 1406 1407 1408
	}

	INIT_LIST_HEAD(&mapping->list);
	mapping->it.start = saddr;
1409
	mapping->it.last = eaddr;
A
Alex Deucher 已提交
1410 1411 1412
	mapping->offset = offset;
	mapping->flags = flags;

1413
	list_add(&mapping->list, &bo_va->invalids);
A
Alex Deucher 已提交
1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426
	interval_tree_insert(&mapping->it, &vm->va);

	/* Make sure the page tables are allocated */
	saddr >>= amdgpu_vm_block_size;
	eaddr >>= amdgpu_vm_block_size;

	BUG_ON(eaddr >= amdgpu_vm_num_pdes(adev));

	if (eaddr > vm->max_pde_used)
		vm->max_pde_used = eaddr;

	/* walk over the address space and allocate the page tables */
	for (pt_idx = saddr; pt_idx <= eaddr; ++pt_idx) {
1427
		struct reservation_object *resv = vm->page_directory->tbo.resv;
A
Alex Deucher 已提交
1428 1429
		struct amdgpu_bo *pt;

1430
		if (vm->page_tables[pt_idx].bo)
A
Alex Deucher 已提交
1431 1432 1433 1434
			continue;

		r = amdgpu_bo_create(adev, AMDGPU_VM_PTE_COUNT * 8,
				     AMDGPU_GPU_PAGE_SIZE, true,
1435
				     AMDGPU_GEM_DOMAIN_VRAM,
1436
				     AMDGPU_GEM_CREATE_NO_CPU_ACCESS |
1437 1438
				     AMDGPU_GEM_CREATE_SHADOW |
				     AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS,
1439
				     NULL, resv, &pt);
1440
		if (r)
A
Alex Deucher 已提交
1441
			goto error_free;
1442

1443 1444 1445 1446 1447
		/* Keep a reference to the page table to avoid freeing
		 * them up in the wrong order.
		 */
		pt->parent = amdgpu_bo_ref(vm->page_directory);

1448
		r = amdgpu_vm_clear_bo(adev, vm, pt);
A
Alex Deucher 已提交
1449
		if (r) {
1450
			amdgpu_bo_unref(&pt->shadow);
A
Alex Deucher 已提交
1451 1452 1453 1454
			amdgpu_bo_unref(&pt);
			goto error_free;
		}

1455 1456 1457 1458 1459 1460 1461 1462 1463
		if (pt->shadow) {
			r = amdgpu_vm_clear_bo(adev, vm, pt->shadow);
			if (r) {
				amdgpu_bo_unref(&pt->shadow);
				amdgpu_bo_unref(&pt);
				goto error_free;
			}
		}

1464
		vm->page_tables[pt_idx].bo = pt;
A
Alex Deucher 已提交
1465 1466 1467 1468 1469 1470 1471 1472
		vm->page_tables[pt_idx].addr = 0;
	}

	return 0;

error_free:
	list_del(&mapping->list);
	interval_tree_remove(&mapping->it, &vm->va);
1473
	trace_amdgpu_vm_bo_unmap(bo_va, mapping);
A
Alex Deucher 已提交
1474 1475
	kfree(mapping);

1476
error:
A
Alex Deucher 已提交
1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489
	return r;
}

/**
 * amdgpu_vm_bo_unmap - remove bo mapping from vm
 *
 * @adev: amdgpu_device pointer
 * @bo_va: bo_va to remove the address from
 * @saddr: where to the BO is mapped
 *
 * Remove a mapping of the BO at the specefied addr from the VM.
 * Returns 0 for success, error for failure.
 *
1490
 * Object has to be reserved and unreserved outside!
A
Alex Deucher 已提交
1491 1492 1493 1494 1495 1496 1497
 */
int amdgpu_vm_bo_unmap(struct amdgpu_device *adev,
		       struct amdgpu_bo_va *bo_va,
		       uint64_t saddr)
{
	struct amdgpu_bo_va_mapping *mapping;
	struct amdgpu_vm *vm = bo_va->vm;
1498
	bool valid = true;
A
Alex Deucher 已提交
1499

1500
	saddr /= AMDGPU_GPU_PAGE_SIZE;
1501

1502
	list_for_each_entry(mapping, &bo_va->valids, list) {
A
Alex Deucher 已提交
1503 1504 1505 1506
		if (mapping->it.start == saddr)
			break;
	}

1507 1508 1509 1510 1511 1512 1513 1514
	if (&mapping->list == &bo_va->valids) {
		valid = false;

		list_for_each_entry(mapping, &bo_va->invalids, list) {
			if (mapping->it.start == saddr)
				break;
		}

1515
		if (&mapping->list == &bo_va->invalids)
1516
			return -ENOENT;
A
Alex Deucher 已提交
1517
	}
1518

A
Alex Deucher 已提交
1519 1520
	list_del(&mapping->list);
	interval_tree_remove(&mapping->it, &vm->va);
1521
	trace_amdgpu_vm_bo_unmap(bo_va, mapping);
A
Alex Deucher 已提交
1522

1523
	if (valid)
A
Alex Deucher 已提交
1524
		list_add(&mapping->list, &vm->freed);
1525
	else
A
Alex Deucher 已提交
1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536
		kfree(mapping);

	return 0;
}

/**
 * amdgpu_vm_bo_rmv - remove a bo to a specific vm
 *
 * @adev: amdgpu_device pointer
 * @bo_va: requested bo_va
 *
1537
 * Remove @bo_va->bo from the requested vm.
A
Alex Deucher 已提交
1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552
 *
 * Object have to be reserved!
 */
void amdgpu_vm_bo_rmv(struct amdgpu_device *adev,
		      struct amdgpu_bo_va *bo_va)
{
	struct amdgpu_bo_va_mapping *mapping, *next;
	struct amdgpu_vm *vm = bo_va->vm;

	list_del(&bo_va->bo_list);

	spin_lock(&vm->status_lock);
	list_del(&bo_va->vm_status);
	spin_unlock(&vm->status_lock);

1553
	list_for_each_entry_safe(mapping, next, &bo_va->valids, list) {
A
Alex Deucher 已提交
1554 1555
		list_del(&mapping->list);
		interval_tree_remove(&mapping->it, &vm->va);
1556
		trace_amdgpu_vm_bo_unmap(bo_va, mapping);
1557 1558 1559 1560 1561 1562
		list_add(&mapping->list, &vm->freed);
	}
	list_for_each_entry_safe(mapping, next, &bo_va->invalids, list) {
		list_del(&mapping->list);
		interval_tree_remove(&mapping->it, &vm->va);
		kfree(mapping);
A
Alex Deucher 已提交
1563
	}
1564

1565
	fence_put(bo_va->last_pt_update);
A
Alex Deucher 已提交
1566 1567 1568 1569 1570 1571 1572 1573 1574 1575
	kfree(bo_va);
}

/**
 * amdgpu_vm_bo_invalidate - mark the bo as invalid
 *
 * @adev: amdgpu_device pointer
 * @vm: requested vm
 * @bo: amdgpu buffer object
 *
1576
 * Mark @bo as invalid.
A
Alex Deucher 已提交
1577 1578 1579 1580 1581 1582 1583
 */
void amdgpu_vm_bo_invalidate(struct amdgpu_device *adev,
			     struct amdgpu_bo *bo)
{
	struct amdgpu_bo_va *bo_va;

	list_for_each_entry(bo_va, &bo->va, bo_list) {
1584 1585
		spin_lock(&bo_va->vm->status_lock);
		if (list_empty(&bo_va->vm_status))
A
Alex Deucher 已提交
1586
			list_add(&bo_va->vm_status, &bo_va->vm->invalidated);
1587
		spin_unlock(&bo_va->vm->status_lock);
A
Alex Deucher 已提交
1588 1589 1590 1591 1592 1593 1594 1595 1596
	}
}

/**
 * amdgpu_vm_init - initialize a vm instance
 *
 * @adev: amdgpu_device pointer
 * @vm: requested vm
 *
1597
 * Init @vm fields.
A
Alex Deucher 已提交
1598 1599 1600 1601 1602
 */
int amdgpu_vm_init(struct amdgpu_device *adev, struct amdgpu_vm *vm)
{
	const unsigned align = min(AMDGPU_VM_PTB_ALIGN_SIZE,
		AMDGPU_VM_PTE_COUNT * 8);
1603
	unsigned pd_size, pd_entries;
1604 1605
	unsigned ring_instance;
	struct amdgpu_ring *ring;
1606
	struct amd_sched_rq *rq;
A
Alex Deucher 已提交
1607 1608
	int i, r;

1609 1610
	for (i = 0; i < AMDGPU_MAX_RINGS; ++i)
		vm->ids[i] = NULL;
A
Alex Deucher 已提交
1611
	vm->va = RB_ROOT;
1612
	vm->client_id = atomic64_inc_return(&adev->vm_manager.client_counter);
A
Alex Deucher 已提交
1613 1614
	spin_lock_init(&vm->status_lock);
	INIT_LIST_HEAD(&vm->invalidated);
1615
	INIT_LIST_HEAD(&vm->cleared);
A
Alex Deucher 已提交
1616
	INIT_LIST_HEAD(&vm->freed);
1617

A
Alex Deucher 已提交
1618 1619 1620 1621
	pd_size = amdgpu_vm_directory_size(adev);
	pd_entries = amdgpu_vm_num_pdes(adev);

	/* allocate page table array */
1622
	vm->page_tables = drm_calloc_large(pd_entries, sizeof(struct amdgpu_vm_pt));
A
Alex Deucher 已提交
1623 1624 1625 1626 1627
	if (vm->page_tables == NULL) {
		DRM_ERROR("Cannot allocate memory for page table array\n");
		return -ENOMEM;
	}

1628
	/* create scheduler entity for page table updates */
1629 1630 1631 1632

	ring_instance = atomic_inc_return(&adev->vm_manager.vm_pte_next_ring);
	ring_instance %= adev->vm_manager.vm_pte_num_rings;
	ring = adev->vm_manager.vm_pte_rings[ring_instance];
1633 1634 1635 1636
	rq = &ring->sched.sched_rq[AMD_SCHED_PRIORITY_KERNEL];
	r = amd_sched_entity_init(&ring->sched, &vm->entity,
				  rq, amdgpu_sched_jobs);
	if (r)
1637
		goto err;
1638

1639 1640
	vm->page_directory_fence = NULL;

A
Alex Deucher 已提交
1641
	r = amdgpu_bo_create(adev, pd_size, align, true,
1642
			     AMDGPU_GEM_DOMAIN_VRAM,
1643
			     AMDGPU_GEM_CREATE_NO_CPU_ACCESS |
1644 1645
			     AMDGPU_GEM_CREATE_SHADOW |
			     AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS,
1646
			     NULL, NULL, &vm->page_directory);
A
Alex Deucher 已提交
1647
	if (r)
1648 1649
		goto error_free_sched_entity;

1650
	r = amdgpu_bo_reserve(vm->page_directory, false);
1651 1652 1653 1654 1655
	if (r)
		goto error_free_page_directory;

	r = amdgpu_vm_clear_bo(adev, vm, vm->page_directory);
	if (r)
1656 1657
		goto error_unreserve;

1658 1659 1660 1661 1662 1663
	if (vm->page_directory->shadow) {
		r = amdgpu_vm_clear_bo(adev, vm, vm->page_directory->shadow);
		if (r)
			goto error_unreserve;
	}

1664
	vm->last_eviction_counter = atomic64_read(&adev->num_evictions);
1665
	amdgpu_bo_unreserve(vm->page_directory);
A
Alex Deucher 已提交
1666 1667

	return 0;
1668

1669 1670 1671
error_unreserve:
	amdgpu_bo_unreserve(vm->page_directory);

1672
error_free_page_directory:
1673
	amdgpu_bo_unref(&vm->page_directory->shadow);
1674 1675 1676 1677 1678 1679
	amdgpu_bo_unref(&vm->page_directory);
	vm->page_directory = NULL;

error_free_sched_entity:
	amd_sched_entity_fini(&ring->sched, &vm->entity);

1680 1681 1682
err:
	drm_free_large(vm->page_tables);

1683
	return r;
A
Alex Deucher 已提交
1684 1685 1686 1687 1688 1689 1690 1691
}

/**
 * amdgpu_vm_fini - tear down a vm instance
 *
 * @adev: amdgpu_device pointer
 * @vm: requested vm
 *
1692
 * Tear down @vm.
A
Alex Deucher 已提交
1693 1694 1695 1696 1697 1698 1699
 * Unbind the VM and remove all bos from the vm bo list
 */
void amdgpu_vm_fini(struct amdgpu_device *adev, struct amdgpu_vm *vm)
{
	struct amdgpu_bo_va_mapping *mapping, *tmp;
	int i;

1700
	amd_sched_entity_fini(vm->entity.sched, &vm->entity);
1701

A
Alex Deucher 已提交
1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714
	if (!RB_EMPTY_ROOT(&vm->va)) {
		dev_err(adev->dev, "still active bo inside vm\n");
	}
	rbtree_postorder_for_each_entry_safe(mapping, tmp, &vm->va, it.rb) {
		list_del(&mapping->list);
		interval_tree_remove(&mapping->it, &vm->va);
		kfree(mapping);
	}
	list_for_each_entry_safe(mapping, tmp, &vm->freed, list) {
		list_del(&mapping->list);
		kfree(mapping);
	}

1715
	for (i = 0; i < amdgpu_vm_num_pdes(adev); i++) {
1716
		struct amdgpu_bo *pt = vm->page_tables[i].bo;
1717 1718 1719 1720 1721 1722

		if (!pt)
			continue;

		amdgpu_bo_unref(&pt->shadow);
		amdgpu_bo_unref(&pt);
1723
	}
1724
	drm_free_large(vm->page_tables);
A
Alex Deucher 已提交
1725

1726
	amdgpu_bo_unref(&vm->page_directory->shadow);
A
Alex Deucher 已提交
1727
	amdgpu_bo_unref(&vm->page_directory);
1728
	fence_put(vm->page_directory_fence);
A
Alex Deucher 已提交
1729
}
1730

1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744
/**
 * amdgpu_vm_manager_init - init the VM manager
 *
 * @adev: amdgpu_device pointer
 *
 * Initialize the VM manager structures
 */
void amdgpu_vm_manager_init(struct amdgpu_device *adev)
{
	unsigned i;

	INIT_LIST_HEAD(&adev->vm_manager.ids_lru);

	/* skip over VMID 0, since it is the system VM */
1745 1746
	for (i = 1; i < adev->vm_manager.num_ids; ++i) {
		amdgpu_vm_reset_id(adev, i);
1747
		amdgpu_sync_create(&adev->vm_manager.ids[i].active);
1748 1749
		list_add_tail(&adev->vm_manager.ids[i].list,
			      &adev->vm_manager.ids_lru);
1750
	}
1751

1752 1753 1754 1755
	adev->vm_manager.fence_context = fence_context_alloc(AMDGPU_MAX_RINGS);
	for (i = 0; i < AMDGPU_MAX_RINGS; ++i)
		adev->vm_manager.seqno[i] = 0;

1756
	atomic_set(&adev->vm_manager.vm_pte_next_ring, 0);
1757
	atomic64_set(&adev->vm_manager.client_counter, 0);
1758 1759
}

1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770
/**
 * amdgpu_vm_manager_fini - cleanup VM manager
 *
 * @adev: amdgpu_device pointer
 *
 * Cleanup the VM manager and free resources.
 */
void amdgpu_vm_manager_fini(struct amdgpu_device *adev)
{
	unsigned i;

1771 1772 1773
	for (i = 0; i < AMDGPU_NUM_VM; ++i) {
		struct amdgpu_vm_id *id = &adev->vm_manager.ids[i];

1774 1775
		fence_put(adev->vm_manager.ids[i].first);
		amdgpu_sync_free(&adev->vm_manager.ids[i].active);
1776 1777
		fence_put(id->flushed_updates);
	}
1778
}