i915_gem_execbuffer.c 51.3 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
/*
 * Copyright © 2008,2010 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 *
 * Authors:
 *    Eric Anholt <eric@anholt.net>
 *    Chris Wilson <chris@chris-wilson.co.uk>
 *
 */

29 30 31 32
#include <linux/dma_remapping.h>
#include <linux/reservation.h>
#include <linux/uaccess.h>

33 34
#include <drm/drmP.h>
#include <drm/i915_drm.h>
35

36 37 38
#include "i915_drv.h"
#include "i915_trace.h"
#include "intel_drv.h"
39
#include "intel_frontbuffer.h"
40

41 42
#define DBG_USE_CPU_RELOC 0 /* -1 force GTT relocs; 1 force CPU relocs */

43 44 45 46 47
#define  __EXEC_OBJECT_HAS_PIN		(1<<31)
#define  __EXEC_OBJECT_HAS_FENCE	(1<<30)
#define  __EXEC_OBJECT_NEEDS_MAP	(1<<29)
#define  __EXEC_OBJECT_NEEDS_BIAS	(1<<28)
#define  __EXEC_OBJECT_INTERNAL_FLAGS (0xf<<28) /* all of the above */
48 49

#define BATCH_OFFSET_BIAS (256*1024)
50

51 52 53
struct i915_execbuffer_params {
	struct drm_device               *dev;
	struct drm_file                 *file;
54 55 56
	struct i915_vma			*batch;
	u32				dispatch_flags;
	u32				args_batch_start_offset;
57 58 59 60 61
	struct intel_engine_cs          *engine;
	struct i915_gem_context         *ctx;
	struct drm_i915_gem_request     *request;
};

62
struct eb_vmas {
63
	struct drm_i915_private *i915;
64
	struct list_head vmas;
65
	int and;
66
	union {
67
		struct i915_vma *lut[0];
68 69
		struct hlist_head buckets[0];
	};
70 71
};

72
static struct eb_vmas *
73 74
eb_create(struct drm_i915_private *i915,
	  struct drm_i915_gem_execbuffer2 *args)
75
{
76
	struct eb_vmas *eb = NULL;
77 78

	if (args->flags & I915_EXEC_HANDLE_LUT) {
79
		unsigned size = args->buffer_count;
80 81
		size *= sizeof(struct i915_vma *);
		size += sizeof(struct eb_vmas);
82 83 84 85
		eb = kmalloc(size, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
	}

	if (eb == NULL) {
86 87
		unsigned size = args->buffer_count;
		unsigned count = PAGE_SIZE / sizeof(struct hlist_head) / 2;
L
Lauri Kasanen 已提交
88
		BUILD_BUG_ON_NOT_POWER_OF_2(PAGE_SIZE / sizeof(struct hlist_head));
89 90 91
		while (count > 2*size)
			count >>= 1;
		eb = kzalloc(count*sizeof(struct hlist_head) +
92
			     sizeof(struct eb_vmas),
93 94 95 96 97 98 99 100
			     GFP_TEMPORARY);
		if (eb == NULL)
			return eb;

		eb->and = count - 1;
	} else
		eb->and = -args->buffer_count;

101
	eb->i915 = i915;
102
	INIT_LIST_HEAD(&eb->vmas);
103 104 105 106
	return eb;
}

static void
107
eb_reset(struct eb_vmas *eb)
108
{
109 110
	if (eb->and >= 0)
		memset(eb->buckets, 0, (eb->and+1)*sizeof(struct hlist_head));
111 112
}

113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132
static struct i915_vma *
eb_get_batch(struct eb_vmas *eb)
{
	struct i915_vma *vma = list_entry(eb->vmas.prev, typeof(*vma), exec_list);

	/*
	 * SNA is doing fancy tricks with compressing batch buffers, which leads
	 * to negative relocation deltas. Usually that works out ok since the
	 * relocate address is still positive, except when the batch is placed
	 * very low in the GTT. Ensure this doesn't happen.
	 *
	 * Note that actual hangs have only been observed on gen7, but for
	 * paranoia do it everywhere.
	 */
	if ((vma->exec_entry->flags & EXEC_OBJECT_PINNED) == 0)
		vma->exec_entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

	return vma;
}

133
static int
134 135 136 137 138
eb_lookup_vmas(struct eb_vmas *eb,
	       struct drm_i915_gem_exec_object2 *exec,
	       const struct drm_i915_gem_execbuffer2 *args,
	       struct i915_address_space *vm,
	       struct drm_file *file)
139
{
140 141
	struct drm_i915_gem_object *obj;
	struct list_head objects;
142
	int i, ret;
143

144
	INIT_LIST_HEAD(&objects);
145
	spin_lock(&file->table_lock);
146 147
	/* Grab a reference to the object and release the lock so we can lookup
	 * or create the VMA without using GFP_ATOMIC */
148
	for (i = 0; i < args->buffer_count; i++) {
149 150 151 152 153
		obj = to_intel_bo(idr_find(&file->object_idr, exec[i].handle));
		if (obj == NULL) {
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Invalid object handle %d at index %d\n",
				   exec[i].handle, i);
154
			ret = -ENOENT;
155
			goto err;
156 157
		}

158
		if (!list_empty(&obj->obj_exec_link)) {
159 160 161
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Object %p [handle %d, index %d] appears more than once in object list\n",
				   obj, exec[i].handle, i);
162
			ret = -EINVAL;
163
			goto err;
164 165
		}

166
		i915_gem_object_get(obj);
167 168 169
		list_add_tail(&obj->obj_exec_link, &objects);
	}
	spin_unlock(&file->table_lock);
170

171
	i = 0;
172
	while (!list_empty(&objects)) {
173
		struct i915_vma *vma;
174

175 176 177 178
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);

179 180 181 182 183 184 185 186
		/*
		 * NOTE: We can leak any vmas created here when something fails
		 * later on. But that's no issue since vma_unbind can deal with
		 * vmas which are not actually bound. And since only
		 * lookup_or_create exists as an interface to get at the vma
		 * from the (obj, vm) we don't run the risk of creating
		 * duplicated vmas for the same vm.
		 */
187
		vma = i915_vma_instance(obj, vm, NULL);
C
Chris Wilson 已提交
188
		if (unlikely(IS_ERR(vma))) {
189 190
			DRM_DEBUG("Failed to lookup VMA\n");
			ret = PTR_ERR(vma);
191
			goto err;
192 193
		}

194
		/* Transfer ownership from the objects list to the vmas list. */
195
		list_add_tail(&vma->exec_list, &eb->vmas);
196
		list_del_init(&obj->obj_exec_link);
197 198

		vma->exec_entry = &exec[i];
199
		if (eb->and < 0) {
200
			eb->lut[i] = vma;
201 202
		} else {
			uint32_t handle = args->flags & I915_EXEC_HANDLE_LUT ? i : exec[i].handle;
203 204
			vma->exec_handle = handle;
			hlist_add_head(&vma->exec_node,
205 206
				       &eb->buckets[handle & eb->and]);
		}
207
		++i;
208 209
	}

210
	return 0;
211 212


213
err:
214 215 216 217 218
	while (!list_empty(&objects)) {
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);
		list_del_init(&obj->obj_exec_link);
219
		i915_gem_object_put(obj);
220
	}
221 222 223 224 225
	/*
	 * Objects already transfered to the vmas list will be unreferenced by
	 * eb_destroy.
	 */

226
	return ret;
227 228
}

229
static struct i915_vma *eb_get_vma(struct eb_vmas *eb, unsigned long handle)
230
{
231 232 233 234 235 236
	if (eb->and < 0) {
		if (handle >= -eb->and)
			return NULL;
		return eb->lut[handle];
	} else {
		struct hlist_head *head;
237
		struct i915_vma *vma;
238

239
		head = &eb->buckets[handle & eb->and];
240
		hlist_for_each_entry(vma, head, exec_node) {
241 242
			if (vma->exec_handle == handle)
				return vma;
243 244 245
		}
		return NULL;
	}
246 247
}

248 249 250 251 252 253 254 255 256 257 258
static void
i915_gem_execbuffer_unreserve_vma(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry;

	if (!drm_mm_node_allocated(&vma->node))
		return;

	entry = vma->exec_entry;

	if (entry->flags & __EXEC_OBJECT_HAS_FENCE)
259
		i915_vma_unpin_fence(vma);
260 261

	if (entry->flags & __EXEC_OBJECT_HAS_PIN)
262
		__i915_vma_unpin(vma);
263

C
Chris Wilson 已提交
264
	entry->flags &= ~(__EXEC_OBJECT_HAS_FENCE | __EXEC_OBJECT_HAS_PIN);
265 266 267 268
}

static void eb_destroy(struct eb_vmas *eb)
{
269 270
	while (!list_empty(&eb->vmas)) {
		struct i915_vma *vma;
271

272 273
		vma = list_first_entry(&eb->vmas,
				       struct i915_vma,
274
				       exec_list);
275
		list_del_init(&vma->exec_list);
276
		i915_gem_execbuffer_unreserve_vma(vma);
277
		vma->exec_entry = NULL;
278
		i915_vma_put(vma);
279
	}
280 281 282
	kfree(eb);
}

283 284
static inline int use_cpu_reloc(struct drm_i915_gem_object *obj)
{
285 286 287
	if (!i915_gem_object_has_struct_page(obj))
		return false;

288 289 290
	if (DBG_USE_CPU_RELOC)
		return DBG_USE_CPU_RELOC > 0;

291
	return (HAS_LLC(to_i915(obj->base.dev)) ||
292
		obj->base.write_domain == I915_GEM_DOMAIN_CPU ||
293 294 295
		obj->cache_level != I915_CACHE_NONE);
}

296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314
/* Used to convert any address to canonical form.
 * Starting from gen8, some commands (e.g. STATE_BASE_ADDRESS,
 * MI_LOAD_REGISTER_MEM and others, see Broadwell PRM Vol2a) require the
 * addresses to be in a canonical form:
 * "GraphicsAddress[63:48] are ignored by the HW and assumed to be in correct
 * canonical form [63:48] == [47]."
 */
#define GEN8_HIGH_ADDRESS_BIT 47
static inline uint64_t gen8_canonical_addr(uint64_t address)
{
	return sign_extend64(address, GEN8_HIGH_ADDRESS_BIT);
}

static inline uint64_t gen8_noncanonical_addr(uint64_t address)
{
	return address & ((1ULL << (GEN8_HIGH_ADDRESS_BIT + 1)) - 1);
}

static inline uint64_t
315
relocation_target(const struct drm_i915_gem_relocation_entry *reloc,
316 317 318 319 320
		  uint64_t target_offset)
{
	return gen8_canonical_addr((int)reloc->delta + target_offset);
}

321
struct reloc_cache {
322 323 324
	struct drm_i915_private *i915;
	struct drm_mm_node node;
	unsigned long vaddr;
325
	unsigned int page;
326
	bool use_64bit_reloc;
327 328
};

329 330
static void reloc_cache_init(struct reloc_cache *cache,
			     struct drm_i915_private *i915)
331
{
332
	cache->page = -1;
333 334
	cache->vaddr = 0;
	cache->i915 = i915;
335 336
	/* Must be a variable in the struct to allow GCC to unroll. */
	cache->use_64bit_reloc = HAS_64BIT_RELOC(i915);
337
	cache->node.allocated = false;
338
}
339

340 341 342 343 344 345 346 347
static inline void *unmask_page(unsigned long p)
{
	return (void *)(uintptr_t)(p & PAGE_MASK);
}

static inline unsigned int unmask_flags(unsigned long p)
{
	return p & ~PAGE_MASK;
348 349
}

350 351
#define KMAP 0x4 /* after CLFLUSH_FLAGS */

352 353
static void reloc_cache_fini(struct reloc_cache *cache)
{
354
	void *vaddr;
355

356 357
	if (!cache->vaddr)
		return;
358

359 360 361 362
	vaddr = unmask_page(cache->vaddr);
	if (cache->vaddr & KMAP) {
		if (cache->vaddr & CLFLUSH_AFTER)
			mb();
363

364 365 366
		kunmap_atomic(vaddr);
		i915_gem_obj_finish_shmem_access((struct drm_i915_gem_object *)cache->node.mm);
	} else {
367
		wmb();
368
		io_mapping_unmap_atomic((void __iomem *)vaddr);
369 370 371 372 373
		if (cache->node.allocated) {
			struct i915_ggtt *ggtt = &cache->i915->ggtt;

			ggtt->base.clear_range(&ggtt->base,
					       cache->node.start,
374
					       cache->node.size);
375 376 377
			drm_mm_remove_node(&cache->node);
		} else {
			i915_vma_unpin((struct i915_vma *)cache->node.mm);
378
		}
379 380 381 382 383 384 385
	}
}

static void *reloc_kmap(struct drm_i915_gem_object *obj,
			struct reloc_cache *cache,
			int page)
{
386 387 388 389 390 391 392
	void *vaddr;

	if (cache->vaddr) {
		kunmap_atomic(unmask_page(cache->vaddr));
	} else {
		unsigned int flushes;
		int ret;
393

394 395 396 397 398 399
		ret = i915_gem_obj_prepare_shmem_write(obj, &flushes);
		if (ret)
			return ERR_PTR(ret);

		BUILD_BUG_ON(KMAP & CLFLUSH_FLAGS);
		BUILD_BUG_ON((KMAP | CLFLUSH_FLAGS) & PAGE_MASK);
400

401 402 403 404
		cache->vaddr = flushes | KMAP;
		cache->node.mm = (void *)obj;
		if (flushes)
			mb();
405 406
	}

407 408
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj, page));
	cache->vaddr = unmask_flags(cache->vaddr) | (unsigned long)vaddr;
409
	cache->page = page;
410

411
	return vaddr;
412 413
}

414 415 416
static void *reloc_iomap(struct drm_i915_gem_object *obj,
			 struct reloc_cache *cache,
			 int page)
417
{
418 419
	struct i915_ggtt *ggtt = &cache->i915->ggtt;
	unsigned long offset;
420
	void *vaddr;
421

422
	if (cache->vaddr) {
423
		io_mapping_unmap_atomic((void __force __iomem *) unmask_page(cache->vaddr));
424 425 426
	} else {
		struct i915_vma *vma;
		int ret;
427

428 429
		if (use_cpu_reloc(obj))
			return NULL;
430

431 432 433
		ret = i915_gem_object_set_to_gtt_domain(obj, true);
		if (ret)
			return ERR_PTR(ret);
434

435 436
		vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0,
					       PIN_MAPPABLE | PIN_NONBLOCK);
437 438
		if (IS_ERR(vma)) {
			memset(&cache->node, 0, sizeof(cache->node));
439
			ret = drm_mm_insert_node_in_range
440
				(&ggtt->base.mm, &cache->node,
441
				 PAGE_SIZE, 0, I915_COLOR_UNEVICTABLE,
442
				 0, ggtt->mappable_end,
443
				 DRM_MM_INSERT_LOW);
444 445
			if (ret) /* no inactive aperture space, use cpu reloc */
				return NULL;
446
		} else {
447
			ret = i915_vma_put_fence(vma);
448 449 450 451
			if (ret) {
				i915_vma_unpin(vma);
				return ERR_PTR(ret);
			}
452

453 454
			cache->node.start = vma->node.start;
			cache->node.mm = (void *)vma;
455
		}
456
	}
457

458 459
	offset = cache->node.start;
	if (cache->node.allocated) {
460
		wmb();
461 462 463 464 465
		ggtt->base.insert_page(&ggtt->base,
				       i915_gem_object_get_dma_address(obj, page),
				       offset, I915_CACHE_NONE, 0);
	} else {
		offset += page << PAGE_SHIFT;
466 467
	}

468
	vaddr = (void __force *) io_mapping_map_atomic_wc(&cache->i915->ggtt.mappable, offset);
469 470
	cache->page = page;
	cache->vaddr = (unsigned long)vaddr;
471

472
	return vaddr;
473 474
}

475 476 477
static void *reloc_vaddr(struct drm_i915_gem_object *obj,
			 struct reloc_cache *cache,
			 int page)
478
{
479
	void *vaddr;
480

481 482 483 484 485 486 487 488
	if (cache->page == page) {
		vaddr = unmask_page(cache->vaddr);
	} else {
		vaddr = NULL;
		if ((cache->vaddr & KMAP) == 0)
			vaddr = reloc_iomap(obj, cache, page);
		if (!vaddr)
			vaddr = reloc_kmap(obj, cache, page);
489 490
	}

491
	return vaddr;
492 493
}

494
static void clflush_write32(u32 *addr, u32 value, unsigned int flushes)
495
{
496 497 498 499 500
	if (unlikely(flushes & (CLFLUSH_BEFORE | CLFLUSH_AFTER))) {
		if (flushes & CLFLUSH_BEFORE) {
			clflushopt(addr);
			mb();
		}
501

502
		*addr = value;
503

504 505 506 507 508 509 510 511 512 513
		/* Writes to the same cacheline are serialised by the CPU
		 * (including clflush). On the write path, we only require
		 * that it hits memory in an orderly fashion and place
		 * mb barriers at the start and end of the relocation phase
		 * to ensure ordering of clflush wrt to the system.
		 */
		if (flushes & CLFLUSH_AFTER)
			clflushopt(addr);
	} else
		*addr = value;
514 515 516
}

static int
517 518 519 520
relocate_entry(struct drm_i915_gem_object *obj,
	       const struct drm_i915_gem_relocation_entry *reloc,
	       struct reloc_cache *cache,
	       u64 target_offset)
521
{
522 523 524
	u64 offset = reloc->offset;
	bool wide = cache->use_64bit_reloc;
	void *vaddr;
525

526 527 528 529 530 531 532 533 534 535 536 537 538 539 540
	target_offset = relocation_target(reloc, target_offset);
repeat:
	vaddr = reloc_vaddr(obj, cache, offset >> PAGE_SHIFT);
	if (IS_ERR(vaddr))
		return PTR_ERR(vaddr);

	clflush_write32(vaddr + offset_in_page(offset),
			lower_32_bits(target_offset),
			cache->vaddr);

	if (wide) {
		offset += sizeof(u32);
		target_offset >>= 32;
		wide = false;
		goto repeat;
541 542 543 544 545
	}

	return 0;
}

546 547
static int
i915_gem_execbuffer_relocate_entry(struct drm_i915_gem_object *obj,
548
				   struct eb_vmas *eb,
549 550
				   struct drm_i915_gem_relocation_entry *reloc,
				   struct reloc_cache *cache)
551
{
552
	struct drm_i915_private *dev_priv = to_i915(obj->base.dev);
553
	struct drm_gem_object *target_obj;
554
	struct drm_i915_gem_object *target_i915_obj;
555
	struct i915_vma *target_vma;
B
Ben Widawsky 已提交
556
	uint64_t target_offset;
557
	int ret;
558

559
	/* we've already hold a reference to all valid objects */
560 561
	target_vma = eb_get_vma(eb, reloc->target_handle);
	if (unlikely(target_vma == NULL))
562
		return -ENOENT;
563 564
	target_i915_obj = target_vma->obj;
	target_obj = &target_vma->obj->base;
565

566
	target_offset = gen8_canonical_addr(target_vma->node.start);
567

568 569 570
	/* Sandybridge PPGTT errata: We need a global gtt mapping for MI and
	 * pipe_control writes because the gpu doesn't properly redirect them
	 * through the ppgtt for non_secure batchbuffers. */
571
	if (unlikely(IS_GEN6(dev_priv) &&
572
	    reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION)) {
573
		ret = i915_vma_bind(target_vma, target_i915_obj->cache_level,
574
				    PIN_GLOBAL);
575 576 577
		if (WARN_ONCE(ret, "Unexpected failure to bind target VMA!"))
			return ret;
	}
578

579
	/* Validate that the target is in a valid r/w GPU domain */
580
	if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) {
581
		DRM_DEBUG("reloc with multiple write domains: "
582 583 584 585 586 587
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
588
		return -EINVAL;
589
	}
590 591
	if (unlikely((reloc->write_domain | reloc->read_domains)
		     & ~I915_GEM_GPU_DOMAINS)) {
592
		DRM_DEBUG("reloc with read/write non-GPU domains: "
593 594 595 596 597 598
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
599
		return -EINVAL;
600 601 602 603 604 605 606 607 608
	}

	target_obj->pending_read_domains |= reloc->read_domains;
	target_obj->pending_write_domain |= reloc->write_domain;

	/* If the relocation already has the right value in it, no
	 * more work needs to be done.
	 */
	if (target_offset == reloc->presumed_offset)
609
		return 0;
610 611

	/* Check that the relocation address is valid... */
612
	if (unlikely(reloc->offset >
613
		     obj->base.size - (cache->use_64bit_reloc ? 8 : 4))) {
614
		DRM_DEBUG("Relocation beyond object bounds: "
615 616 617 618
			  "obj %p target %d offset %d size %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  (int) obj->base.size);
619
		return -EINVAL;
620
	}
621
	if (unlikely(reloc->offset & 3)) {
622
		DRM_DEBUG("Relocation not 4-byte aligned: "
623 624 625
			  "obj %p target %d offset %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset);
626
		return -EINVAL;
627 628
	}

629
	ret = relocate_entry(obj, reloc, cache, target_offset);
630 631 632
	if (ret)
		return ret;

633 634
	/* and update the user's relocation entry */
	reloc->presumed_offset = target_offset;
635
	return 0;
636 637 638
}

static int
639 640
i915_gem_execbuffer_relocate_vma(struct i915_vma *vma,
				 struct eb_vmas *eb)
641
{
642 643
#define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry))
	struct drm_i915_gem_relocation_entry stack_reloc[N_RELOC(512)];
644
	struct drm_i915_gem_relocation_entry __user *user_relocs;
645
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
646 647
	struct reloc_cache cache;
	int remain, ret = 0;
648

649
	user_relocs = u64_to_user_ptr(entry->relocs_ptr);
650
	reloc_cache_init(&cache, eb->i915);
651

652 653 654
	remain = entry->relocation_count;
	while (remain) {
		struct drm_i915_gem_relocation_entry *r = stack_reloc;
655 656 657 658
		unsigned long unwritten;
		unsigned int count;

		count = min_t(unsigned int, remain, ARRAY_SIZE(stack_reloc));
659 660
		remain -= count;

661 662 663 664 665 666 667 668 669 670 671
		/* This is the fast path and we cannot handle a pagefault
		 * whilst holding the struct mutex lest the user pass in the
		 * relocations contained within a mmaped bo. For in such a case
		 * we, the page fault handler would call i915_gem_fault() and
		 * we would try to acquire the struct mutex again. Obviously
		 * this is bad and so lockdep complains vehemently.
		 */
		pagefault_disable();
		unwritten = __copy_from_user_inatomic(r, user_relocs, count*sizeof(r[0]));
		pagefault_enable();
		if (unlikely(unwritten)) {
672 673 674
			ret = -EFAULT;
			goto out;
		}
675

676 677
		do {
			u64 offset = r->presumed_offset;
678

679
			ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, r, &cache);
680
			if (ret)
681
				goto out;
682

683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702
			if (r->presumed_offset != offset) {
				pagefault_disable();
				unwritten = __put_user(r->presumed_offset,
						       &user_relocs->presumed_offset);
				pagefault_enable();
				if (unlikely(unwritten)) {
					/* Note that reporting an error now
					 * leaves everything in an inconsistent
					 * state as we have *already* changed
					 * the relocation value inside the
					 * object. As we have not changed the
					 * reloc.presumed_offset or will not
					 * change the execobject.offset, on the
					 * call we may not rewrite the value
					 * inside the object, leaving it
					 * dangling and causing a GPU hang.
					 */
					ret = -EFAULT;
					goto out;
				}
703 704 705 706 707
			}

			user_relocs++;
			r++;
		} while (--count);
708 709
	}

710 711 712
out:
	reloc_cache_fini(&cache);
	return ret;
713
#undef N_RELOC
714 715 716
}

static int
717 718 719
i915_gem_execbuffer_relocate_vma_slow(struct i915_vma *vma,
				      struct eb_vmas *eb,
				      struct drm_i915_gem_relocation_entry *relocs)
720
{
721
	const struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
722 723
	struct reloc_cache cache;
	int i, ret = 0;
724

725
	reloc_cache_init(&cache, eb->i915);
726
	for (i = 0; i < entry->relocation_count; i++) {
727
		ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, &relocs[i], &cache);
728
		if (ret)
729
			break;
730
	}
731
	reloc_cache_fini(&cache);
732

733
	return ret;
734 735 736
}

static int
B
Ben Widawsky 已提交
737
i915_gem_execbuffer_relocate(struct eb_vmas *eb)
738
{
739
	struct i915_vma *vma;
740 741
	int ret = 0;

742 743
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		ret = i915_gem_execbuffer_relocate_vma(vma, eb);
744
		if (ret)
745
			break;
746 747
	}

748
	return ret;
749 750
}

751 752 753 754 755 756
static bool only_mappable_for_reloc(unsigned int flags)
{
	return (flags & (EXEC_OBJECT_NEEDS_FENCE | __EXEC_OBJECT_NEEDS_MAP)) ==
		__EXEC_OBJECT_NEEDS_MAP;
}

757
static int
758
i915_gem_execbuffer_reserve_vma(struct i915_vma *vma,
759
				struct intel_engine_cs *engine,
760
				bool *need_reloc)
761
{
762
	struct drm_i915_gem_object *obj = vma->obj;
763
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
764
	uint64_t flags;
765 766
	int ret;

767
	flags = PIN_USER;
768 769 770
	if (entry->flags & EXEC_OBJECT_NEEDS_GTT)
		flags |= PIN_GLOBAL;

771
	if (!drm_mm_node_allocated(&vma->node)) {
772 773 774 775 776
		/* Wa32bitGeneralStateOffset & Wa32bitInstructionBaseOffset,
		 * limit address to the first 4GBs for unflagged objects.
		 */
		if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0)
			flags |= PIN_ZONE_4G;
777 778 779 780
		if (entry->flags & __EXEC_OBJECT_NEEDS_MAP)
			flags |= PIN_GLOBAL | PIN_MAPPABLE;
		if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS)
			flags |= BATCH_OFFSET_BIAS | PIN_OFFSET_BIAS;
781 782
		if (entry->flags & EXEC_OBJECT_PINNED)
			flags |= entry->offset | PIN_OFFSET_FIXED;
783 784
		if ((flags & PIN_MAPPABLE) == 0)
			flags |= PIN_HIGH;
785
	}
786

787 788 789 790 791
	ret = i915_vma_pin(vma,
			   entry->pad_to_size,
			   entry->alignment,
			   flags);
	if ((ret == -ENOSPC || ret == -E2BIG) &&
792
	    only_mappable_for_reloc(entry->flags))
793 794 795 796
		ret = i915_vma_pin(vma,
				   entry->pad_to_size,
				   entry->alignment,
				   flags & ~PIN_MAPPABLE);
797 798 799
	if (ret)
		return ret;

800 801
	entry->flags |= __EXEC_OBJECT_HAS_PIN;

802
	if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
803
		ret = i915_vma_get_fence(vma);
804 805
		if (ret)
			return ret;
806

807
		if (i915_vma_pin_fence(vma))
808
			entry->flags |= __EXEC_OBJECT_HAS_FENCE;
809 810
	}

811 812
	if (entry->offset != vma->node.start) {
		entry->offset = vma->node.start;
813 814 815 816 817 818 819 820
		*need_reloc = true;
	}

	if (entry->flags & EXEC_OBJECT_WRITE) {
		obj->base.pending_read_domains = I915_GEM_DOMAIN_RENDER;
		obj->base.pending_write_domain = I915_GEM_DOMAIN_RENDER;
	}

821
	return 0;
822
}
823

824
static bool
825
need_reloc_mappable(struct i915_vma *vma)
826 827 828
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;

829 830 831
	if (entry->relocation_count == 0)
		return false;

832
	if (!i915_vma_is_ggtt(vma))
833 834 835
		return false;

	/* See also use_cpu_reloc() */
836
	if (HAS_LLC(to_i915(vma->obj->base.dev)))
837 838 839 840 841 842 843 844 845 846 847 848
		return false;

	if (vma->obj->base.write_domain == I915_GEM_DOMAIN_CPU)
		return false;

	return true;
}

static bool
eb_vma_misplaced(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
849

850 851
	WARN_ON(entry->flags & __EXEC_OBJECT_NEEDS_MAP &&
		!i915_vma_is_ggtt(vma));
852

853
	if (entry->alignment && !IS_ALIGNED(vma->node.start, entry->alignment))
854 855
		return true;

856 857 858
	if (vma->node.size < entry->pad_to_size)
		return true;

859 860 861 862
	if (entry->flags & EXEC_OBJECT_PINNED &&
	    vma->node.start != entry->offset)
		return true;

863 864 865 866
	if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS &&
	    vma->node.start < BATCH_OFFSET_BIAS)
		return true;

867
	/* avoid costly ping-pong once a batch bo ended up non-mappable */
868 869
	if (entry->flags & __EXEC_OBJECT_NEEDS_MAP &&
	    !i915_vma_is_map_and_fenceable(vma))
870 871
		return !only_mappable_for_reloc(entry->flags);

872 873 874 875
	if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0 &&
	    (vma->node.start + vma->node.size - 1) >> 32)
		return true;

876 877 878
	return false;
}

879
static int
880
i915_gem_execbuffer_reserve(struct intel_engine_cs *engine,
881
			    struct list_head *vmas,
882
			    struct i915_gem_context *ctx,
883
			    bool *need_relocs)
884
{
885
	struct drm_i915_gem_object *obj;
886
	struct i915_vma *vma;
887
	struct i915_address_space *vm;
888
	struct list_head ordered_vmas;
889
	struct list_head pinned_vmas;
890
	bool has_fenced_gpu_access = INTEL_GEN(engine->i915) < 4;
891
	int retry;
892

893 894
	vm = list_first_entry(vmas, struct i915_vma, exec_list)->vm;

895
	INIT_LIST_HEAD(&ordered_vmas);
896
	INIT_LIST_HEAD(&pinned_vmas);
897
	while (!list_empty(vmas)) {
898 899 900
		struct drm_i915_gem_exec_object2 *entry;
		bool need_fence, need_mappable;

901 902 903
		vma = list_first_entry(vmas, struct i915_vma, exec_list);
		obj = vma->obj;
		entry = vma->exec_entry;
904

905 906 907
		if (ctx->flags & CONTEXT_NO_ZEROMAP)
			entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

908 909
		if (!has_fenced_gpu_access)
			entry->flags &= ~EXEC_OBJECT_NEEDS_FENCE;
910 911
		need_fence =
			entry->flags & EXEC_OBJECT_NEEDS_FENCE &&
912
			i915_gem_object_is_tiled(obj);
913
		need_mappable = need_fence || need_reloc_mappable(vma);
914

915 916 917
		if (entry->flags & EXEC_OBJECT_PINNED)
			list_move_tail(&vma->exec_list, &pinned_vmas);
		else if (need_mappable) {
918
			entry->flags |= __EXEC_OBJECT_NEEDS_MAP;
919
			list_move(&vma->exec_list, &ordered_vmas);
920
		} else
921
			list_move_tail(&vma->exec_list, &ordered_vmas);
922

923
		obj->base.pending_read_domains = I915_GEM_GPU_DOMAINS & ~I915_GEM_DOMAIN_COMMAND;
924
		obj->base.pending_write_domain = 0;
925
	}
926
	list_splice(&ordered_vmas, vmas);
927
	list_splice(&pinned_vmas, vmas);
928 929 930 931 932 933 934 935 936 937

	/* Attempt to pin all of the buffers into the GTT.
	 * This is done in 3 phases:
	 *
	 * 1a. Unbind all objects that do not match the GTT constraints for
	 *     the execbuffer (fenceable, mappable, alignment etc).
	 * 1b. Increment pin count for already bound objects.
	 * 2.  Bind new objects.
	 * 3.  Decrement pin count.
	 *
938
	 * This avoid unnecessary unbinding of later objects in order to make
939 940 941 942
	 * room for the earlier objects *unless* we need to defragment.
	 */
	retry = 0;
	do {
943
		int ret = 0;
944 945

		/* Unbind any ill-fitting objects or pin. */
946 947
		list_for_each_entry(vma, vmas, exec_list) {
			if (!drm_mm_node_allocated(&vma->node))
948 949
				continue;

950
			if (eb_vma_misplaced(vma))
951
				ret = i915_vma_unbind(vma);
952
			else
953 954 955
				ret = i915_gem_execbuffer_reserve_vma(vma,
								      engine,
								      need_relocs);
956
			if (ret)
957 958 959 960
				goto err;
		}

		/* Bind fresh objects */
961 962
		list_for_each_entry(vma, vmas, exec_list) {
			if (drm_mm_node_allocated(&vma->node))
963
				continue;
964

965 966
			ret = i915_gem_execbuffer_reserve_vma(vma, engine,
							      need_relocs);
967 968
			if (ret)
				goto err;
969 970
		}

971
err:
C
Chris Wilson 已提交
972
		if (ret != -ENOSPC || retry++)
973 974
			return ret;

975 976 977 978
		/* Decrement pin count for bound objects */
		list_for_each_entry(vma, vmas, exec_list)
			i915_gem_execbuffer_unreserve_vma(vma);

979
		ret = i915_gem_evict_vm(vm, true);
980 981 982 983 984 985 986
		if (ret)
			return ret;
	} while (1);
}

static int
i915_gem_execbuffer_relocate_slow(struct drm_device *dev,
987
				  struct drm_i915_gem_execbuffer2 *args,
988
				  struct drm_file *file,
989
				  struct intel_engine_cs *engine,
990
				  struct eb_vmas *eb,
991
				  struct drm_i915_gem_exec_object2 *exec,
992
				  struct i915_gem_context *ctx)
993 994
{
	struct drm_i915_gem_relocation_entry *reloc;
995 996
	struct i915_address_space *vm;
	struct i915_vma *vma;
997
	bool need_relocs;
998
	int *reloc_offset;
999
	int i, total, ret;
1000
	unsigned count = args->buffer_count;
1001

1002 1003
	vm = list_first_entry(&eb->vmas, struct i915_vma, exec_list)->vm;

1004
	/* We may process another execbuffer during the unlock... */
1005 1006 1007
	while (!list_empty(&eb->vmas)) {
		vma = list_first_entry(&eb->vmas, struct i915_vma, exec_list);
		list_del_init(&vma->exec_list);
1008
		i915_gem_execbuffer_unreserve_vma(vma);
1009
		i915_vma_put(vma);
1010 1011
	}

1012 1013 1014 1015
	mutex_unlock(&dev->struct_mutex);

	total = 0;
	for (i = 0; i < count; i++)
1016
		total += exec[i].relocation_count;
1017

1018
	reloc_offset = drm_malloc_ab(count, sizeof(*reloc_offset));
1019
	reloc = drm_malloc_ab(total, sizeof(*reloc));
1020 1021 1022
	if (reloc == NULL || reloc_offset == NULL) {
		drm_free_large(reloc);
		drm_free_large(reloc_offset);
1023 1024 1025 1026 1027 1028 1029
		mutex_lock(&dev->struct_mutex);
		return -ENOMEM;
	}

	total = 0;
	for (i = 0; i < count; i++) {
		struct drm_i915_gem_relocation_entry __user *user_relocs;
1030 1031
		u64 invalid_offset = (u64)-1;
		int j;
1032

1033
		user_relocs = u64_to_user_ptr(exec[i].relocs_ptr);
1034 1035

		if (copy_from_user(reloc+total, user_relocs,
1036
				   exec[i].relocation_count * sizeof(*reloc))) {
1037 1038 1039 1040 1041
			ret = -EFAULT;
			mutex_lock(&dev->struct_mutex);
			goto err;
		}

1042 1043 1044 1045 1046 1047 1048 1049 1050 1051
		/* As we do not update the known relocation offsets after
		 * relocating (due to the complexities in lock handling),
		 * we need to mark them as invalid now so that we force the
		 * relocation processing next time. Just in case the target
		 * object is evicted and then rebound into its old
		 * presumed_offset before the next execbuffer - if that
		 * happened we would make the mistake of assuming that the
		 * relocations were valid.
		 */
		for (j = 0; j < exec[i].relocation_count; j++) {
1052 1053 1054
			if (__copy_to_user(&user_relocs[j].presumed_offset,
					   &invalid_offset,
					   sizeof(invalid_offset))) {
1055 1056 1057 1058 1059 1060
				ret = -EFAULT;
				mutex_lock(&dev->struct_mutex);
				goto err;
			}
		}

1061
		reloc_offset[i] = total;
1062
		total += exec[i].relocation_count;
1063 1064 1065 1066 1067 1068 1069 1070
	}

	ret = i915_mutex_lock_interruptible(dev);
	if (ret) {
		mutex_lock(&dev->struct_mutex);
		goto err;
	}

1071 1072
	/* reacquire the objects */
	eb_reset(eb);
1073
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
1074 1075
	if (ret)
		goto err;
1076

1077
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
1078 1079
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
1080 1081 1082
	if (ret)
		goto err;

1083 1084 1085 1086
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		int offset = vma->exec_entry - exec;
		ret = i915_gem_execbuffer_relocate_vma_slow(vma, eb,
							    reloc + reloc_offset[offset]);
1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098
		if (ret)
			goto err;
	}

	/* Leave the user relocations as are, this is the painfully slow path,
	 * and we want to avoid the complication of dropping the lock whilst
	 * having buffers reserved in the aperture and so causing spurious
	 * ENOSPC for random operations.
	 */

err:
	drm_free_large(reloc);
1099
	drm_free_large(reloc_offset);
1100 1101 1102 1103
	return ret;
}

static int
1104
i915_gem_execbuffer_move_to_gpu(struct drm_i915_gem_request *req,
1105
				struct list_head *vmas)
1106
{
1107
	struct i915_vma *vma;
1108
	int ret;
1109

1110 1111
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
1112

1113 1114 1115 1116
		ret = i915_gem_request_await_object
			(req, obj, obj->base.pending_write_domain);
		if (ret)
			return ret;
1117

1118
		if (obj->base.write_domain & I915_GEM_DOMAIN_CPU)
1119
			i915_gem_clflush_object(obj, false);
1120 1121
	}

1122 1123
	/* Unconditionally flush any chipset caches (for streaming writes). */
	i915_gem_chipset_flush(req->engine->i915);
1124

1125
	/* Unconditionally invalidate GPU caches and TLBs. */
1126
	return req->engine->emit_flush(req, EMIT_INVALIDATE);
1127 1128
}

1129 1130
static bool
i915_gem_check_execbuffer(struct drm_i915_gem_execbuffer2 *exec)
1131
{
1132 1133 1134
	if (exec->flags & __I915_EXEC_UNKNOWN_FLAGS)
		return false;

C
Chris Wilson 已提交
1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149
	/* Kernel clipping was a DRI1 misfeature */
	if (exec->num_cliprects || exec->cliprects_ptr)
		return false;

	if (exec->DR4 == 0xffffffff) {
		DRM_DEBUG("UXA submitting garbage DR4, fixing up\n");
		exec->DR4 = 0;
	}
	if (exec->DR1 || exec->DR4)
		return false;

	if ((exec->batch_start_offset | exec->batch_len) & 0x7)
		return false;

	return true;
1150 1151 1152
}

static int
1153 1154
validate_exec_list(struct drm_device *dev,
		   struct drm_i915_gem_exec_object2 *exec,
1155 1156
		   int count)
{
1157 1158
	unsigned relocs_total = 0;
	unsigned relocs_max = UINT_MAX / sizeof(struct drm_i915_gem_relocation_entry);
1159 1160 1161
	unsigned invalid_flags;
	int i;

1162 1163 1164
	/* INTERNAL flags must not overlap with external ones */
	BUILD_BUG_ON(__EXEC_OBJECT_INTERNAL_FLAGS & ~__EXEC_OBJECT_UNKNOWN_FLAGS);

1165 1166 1167
	invalid_flags = __EXEC_OBJECT_UNKNOWN_FLAGS;
	if (USES_FULL_PPGTT(dev))
		invalid_flags |= EXEC_OBJECT_NEEDS_GTT;
1168 1169

	for (i = 0; i < count; i++) {
1170
		char __user *ptr = u64_to_user_ptr(exec[i].relocs_ptr);
1171 1172
		int length; /* limited by fault_in_pages_readable() */

1173
		if (exec[i].flags & invalid_flags)
1174 1175
			return -EINVAL;

1176 1177 1178 1179 1180 1181 1182 1183 1184
		/* Offset can be used as input (EXEC_OBJECT_PINNED), reject
		 * any non-page-aligned or non-canonical addresses.
		 */
		if (exec[i].flags & EXEC_OBJECT_PINNED) {
			if (exec[i].offset !=
			    gen8_canonical_addr(exec[i].offset & PAGE_MASK))
				return -EINVAL;
		}

1185 1186 1187 1188 1189 1190
		/* From drm_mm perspective address space is continuous,
		 * so from this point we're always using non-canonical
		 * form internally.
		 */
		exec[i].offset = gen8_noncanonical_addr(exec[i].offset);

1191 1192 1193
		if (exec[i].alignment && !is_power_of_2(exec[i].alignment))
			return -EINVAL;

1194 1195 1196 1197 1198 1199 1200 1201
		/* pad_to_size was once a reserved field, so sanitize it */
		if (exec[i].flags & EXEC_OBJECT_PAD_TO_SIZE) {
			if (offset_in_page(exec[i].pad_to_size))
				return -EINVAL;
		} else {
			exec[i].pad_to_size = 0;
		}

1202 1203 1204 1205 1206
		/* First check for malicious input causing overflow in
		 * the worst case where we need to allocate the entire
		 * relocation tree as a single array.
		 */
		if (exec[i].relocation_count > relocs_max - relocs_total)
1207
			return -EINVAL;
1208
		relocs_total += exec[i].relocation_count;
1209 1210 1211

		length = exec[i].relocation_count *
			sizeof(struct drm_i915_gem_relocation_entry);
1212 1213 1214 1215 1216
		/*
		 * We must check that the entire relocation array is safe
		 * to read, but since we may need to update the presumed
		 * offsets during execution, check for full write access.
		 */
1217 1218 1219
		if (!access_ok(VERIFY_WRITE, ptr, length))
			return -EFAULT;

1220
		if (likely(!i915.prefault_disable)) {
1221
			if (fault_in_pages_readable(ptr, length))
1222 1223
				return -EFAULT;
		}
1224 1225 1226 1227 1228
	}

	return 0;
}

1229
static struct i915_gem_context *
1230
i915_gem_validate_context(struct drm_device *dev, struct drm_file *file,
1231
			  struct intel_engine_cs *engine, const u32 ctx_id)
1232
{
1233
	struct i915_gem_context *ctx;
1234

1235
	ctx = i915_gem_context_lookup(file->driver_priv, ctx_id);
1236
	if (IS_ERR(ctx))
1237
		return ctx;
1238

1239
	if (i915_gem_context_is_banned(ctx)) {
1240
		DRM_DEBUG("Context %u tried to submit while banned\n", ctx_id);
1241
		return ERR_PTR(-EIO);
1242 1243
	}

1244
	return ctx;
1245 1246
}

1247 1248 1249 1250 1251 1252
static bool gpu_write_needs_clflush(struct drm_i915_gem_object *obj)
{
	return !(obj->cache_level == I915_CACHE_NONE ||
		 obj->cache_level == I915_CACHE_WT);
}

1253 1254 1255 1256 1257 1258 1259
void i915_vma_move_to_active(struct i915_vma *vma,
			     struct drm_i915_gem_request *req,
			     unsigned int flags)
{
	struct drm_i915_gem_object *obj = vma->obj;
	const unsigned int idx = req->engine->id;

1260
	lockdep_assert_held(&req->i915->drm.struct_mutex);
1261 1262
	GEM_BUG_ON(!drm_mm_node_allocated(&vma->node));

1263 1264 1265 1266 1267 1268 1269
	/* Add a reference if we're newly entering the active list.
	 * The order in which we add operations to the retirement queue is
	 * vital here: mark_active adds to the start of the callback list,
	 * such that subsequent callbacks are called first. Therefore we
	 * add the active reference first and queue for it to be dropped
	 * *last*.
	 */
1270 1271 1272 1273 1274
	if (!i915_vma_is_active(vma))
		obj->active_count++;
	i915_vma_set_active(vma, idx);
	i915_gem_active_set(&vma->last_read[idx], req);
	list_move_tail(&vma->vm_link, &vma->vm->active_list);
1275 1276

	if (flags & EXEC_OBJECT_WRITE) {
1277 1278
		if (intel_fb_obj_invalidate(obj, ORIGIN_CS))
			i915_gem_active_set(&obj->frontbuffer_write, req);
1279 1280 1281

		/* update for the implicit flush after a batch */
		obj->base.write_domain &= ~I915_GEM_GPU_DOMAINS;
1282 1283
		if (!obj->cache_dirty && gpu_write_needs_clflush(obj))
			obj->cache_dirty = true;
1284 1285
	}

1286 1287
	if (flags & EXEC_OBJECT_NEEDS_FENCE)
		i915_gem_active_set(&vma->last_fence, req);
1288 1289
}

1290 1291 1292 1293
static void eb_export_fence(struct drm_i915_gem_object *obj,
			    struct drm_i915_gem_request *req,
			    unsigned int flags)
{
1294
	struct reservation_object *resv = obj->resv;
1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307

	/* Ignore errors from failing to allocate the new fence, we can't
	 * handle an error right now. Worst case should be missed
	 * synchronisation leading to rendering corruption.
	 */
	ww_mutex_lock(&resv->lock, NULL);
	if (flags & EXEC_OBJECT_WRITE)
		reservation_object_add_excl_fence(resv, &req->fence);
	else if (reservation_object_reserve_shared(resv) == 0)
		reservation_object_add_shared_fence(resv, &req->fence);
	ww_mutex_unlock(&resv->lock);
}

1308
static void
1309
i915_gem_execbuffer_move_to_active(struct list_head *vmas,
1310
				   struct drm_i915_gem_request *req)
1311
{
1312
	struct i915_vma *vma;
1313

1314 1315
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
1316 1317
		u32 old_read = obj->base.read_domains;
		u32 old_write = obj->base.write_domain;
C
Chris Wilson 已提交
1318

1319
		obj->base.write_domain = obj->base.pending_write_domain;
1320 1321 1322
		if (obj->base.write_domain)
			vma->exec_entry->flags |= EXEC_OBJECT_WRITE;
		else
1323 1324
			obj->base.pending_read_domains |= obj->base.read_domains;
		obj->base.read_domains = obj->base.pending_read_domains;
1325

1326
		i915_vma_move_to_active(vma, req, vma->exec_entry->flags);
1327
		eb_export_fence(obj, req, vma->exec_entry->flags);
C
Chris Wilson 已提交
1328
		trace_i915_gem_object_change_domain(obj, old_read, old_write);
1329 1330 1331
	}
}

1332
static int
1333
i915_reset_gen7_sol_offsets(struct drm_i915_gem_request *req)
1334
{
1335
	struct intel_ring *ring = req->ring;
1336 1337
	int ret, i;

1338
	if (!IS_GEN7(req->i915) || req->engine->id != RCS) {
1339 1340 1341
		DRM_DEBUG("sol reset is gen7/rcs only\n");
		return -EINVAL;
	}
1342

1343
	ret = intel_ring_begin(req, 4 * 3);
1344 1345 1346 1347
	if (ret)
		return ret;

	for (i = 0; i < 4; i++) {
1348 1349 1350
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(ring, GEN7_SO_WRITE_OFFSET(i));
		intel_ring_emit(ring, 0);
1351 1352
	}

1353
	intel_ring_advance(ring);
1354 1355 1356 1357

	return 0;
}

C
Chris Wilson 已提交
1358
static struct i915_vma *
1359
i915_gem_execbuffer_parse(struct intel_engine_cs *engine,
1360 1361
			  struct drm_i915_gem_exec_object2 *shadow_exec_entry,
			  struct drm_i915_gem_object *batch_obj,
1362
			  struct eb_vmas *eb,
1363 1364
			  u32 batch_start_offset,
			  u32 batch_len,
1365
			  bool is_master)
1366 1367
{
	struct drm_i915_gem_object *shadow_batch_obj;
1368
	struct i915_vma *vma;
1369 1370
	int ret;

1371
	shadow_batch_obj = i915_gem_batch_pool_get(&engine->batch_pool,
1372
						   PAGE_ALIGN(batch_len));
1373
	if (IS_ERR(shadow_batch_obj))
1374
		return ERR_CAST(shadow_batch_obj);
1375

1376 1377 1378 1379 1380 1381
	ret = intel_engine_cmd_parser(engine,
				      batch_obj,
				      shadow_batch_obj,
				      batch_start_offset,
				      batch_len,
				      is_master);
C
Chris Wilson 已提交
1382 1383 1384 1385 1386 1387 1388
	if (ret) {
		if (ret == -EACCES) /* unhandled chained batch */
			vma = NULL;
		else
			vma = ERR_PTR(ret);
		goto out;
	}
1389

C
Chris Wilson 已提交
1390 1391 1392
	vma = i915_gem_object_ggtt_pin(shadow_batch_obj, NULL, 0, 0, 0);
	if (IS_ERR(vma))
		goto out;
C
Chris Wilson 已提交
1393

1394
	memset(shadow_exec_entry, 0, sizeof(*shadow_exec_entry));
1395

1396
	vma->exec_entry = shadow_exec_entry;
C
Chris Wilson 已提交
1397
	vma->exec_entry->flags = __EXEC_OBJECT_HAS_PIN;
1398
	i915_gem_object_get(shadow_batch_obj);
1399
	list_add_tail(&vma->exec_list, &eb->vmas);
1400

C
Chris Wilson 已提交
1401
out:
C
Chris Wilson 已提交
1402
	i915_gem_object_unpin_pages(shadow_batch_obj);
C
Chris Wilson 已提交
1403
	return vma;
1404
}
1405

1406 1407 1408 1409
static int
execbuf_submit(struct i915_execbuffer_params *params,
	       struct drm_i915_gem_execbuffer2 *args,
	       struct list_head *vmas)
1410
{
1411
	u64 exec_start, exec_len;
C
Chris Wilson 已提交
1412
	int ret;
1413

1414
	ret = i915_gem_execbuffer_move_to_gpu(params->request, vmas);
1415
	if (ret)
C
Chris Wilson 已提交
1416
		return ret;
1417

1418
	ret = i915_switch_context(params->request);
1419
	if (ret)
C
Chris Wilson 已提交
1420
		return ret;
1421

1422 1423
	if (args->flags & I915_EXEC_CONSTANTS_MASK) {
		DRM_DEBUG("I915_EXEC_CONSTANTS_* unsupported\n");
C
Chris Wilson 已提交
1424
		return -EINVAL;
1425 1426 1427
	}

	if (args->flags & I915_EXEC_GEN7_SOL_RESET) {
1428
		ret = i915_reset_gen7_sol_offsets(params->request);
1429
		if (ret)
C
Chris Wilson 已提交
1430
			return ret;
1431 1432
	}

1433
	exec_len   = args->batch_len;
1434
	exec_start = params->batch->node.start +
1435 1436
		     params->args_batch_start_offset;

1437
	if (exec_len == 0)
1438
		exec_len = params->batch->size - params->args_batch_start_offset;
1439

1440 1441 1442
	ret = params->engine->emit_bb_start(params->request,
					    exec_start, exec_len,
					    params->dispatch_flags);
C
Chris Wilson 已提交
1443 1444
	if (ret)
		return ret;
1445

1446
	trace_i915_gem_ring_dispatch(params->request, params->dispatch_flags);
1447

1448
	i915_gem_execbuffer_move_to_active(vmas, params->request);
1449

C
Chris Wilson 已提交
1450
	return 0;
1451 1452
}

1453 1454
/**
 * Find one BSD ring to dispatch the corresponding BSD command.
1455
 * The engine index is returned.
1456
 */
1457
static unsigned int
1458 1459
gen8_dispatch_bsd_engine(struct drm_i915_private *dev_priv,
			 struct drm_file *file)
1460 1461 1462
{
	struct drm_i915_file_private *file_priv = file->driver_priv;

1463
	/* Check whether the file_priv has already selected one ring. */
1464 1465 1466
	if ((int)file_priv->bsd_engine < 0)
		file_priv->bsd_engine = atomic_fetch_xor(1,
			 &dev_priv->mm.bsd_engine_dispatch_index);
1467

1468
	return file_priv->bsd_engine;
1469 1470
}

1471 1472
#define I915_USER_RINGS (4)

1473
static const enum intel_engine_id user_ring_map[I915_USER_RINGS + 1] = {
1474 1475 1476 1477 1478 1479 1480
	[I915_EXEC_DEFAULT]	= RCS,
	[I915_EXEC_RENDER]	= RCS,
	[I915_EXEC_BLT]		= BCS,
	[I915_EXEC_BSD]		= VCS,
	[I915_EXEC_VEBOX]	= VECS
};

1481 1482 1483 1484
static struct intel_engine_cs *
eb_select_engine(struct drm_i915_private *dev_priv,
		 struct drm_file *file,
		 struct drm_i915_gem_execbuffer2 *args)
1485 1486
{
	unsigned int user_ring_id = args->flags & I915_EXEC_RING_MASK;
1487
	struct intel_engine_cs *engine;
1488 1489 1490

	if (user_ring_id > I915_USER_RINGS) {
		DRM_DEBUG("execbuf with unknown ring: %u\n", user_ring_id);
1491
		return NULL;
1492 1493 1494 1495 1496 1497
	}

	if ((user_ring_id != I915_EXEC_BSD) &&
	    ((args->flags & I915_EXEC_BSD_MASK) != 0)) {
		DRM_DEBUG("execbuf with non bsd ring but with invalid "
			  "bsd dispatch flags: %d\n", (int)(args->flags));
1498
		return NULL;
1499 1500 1501 1502 1503 1504
	}

	if (user_ring_id == I915_EXEC_BSD && HAS_BSD2(dev_priv)) {
		unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;

		if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
1505
			bsd_idx = gen8_dispatch_bsd_engine(dev_priv, file);
1506 1507
		} else if (bsd_idx >= I915_EXEC_BSD_RING1 &&
			   bsd_idx <= I915_EXEC_BSD_RING2) {
1508
			bsd_idx >>= I915_EXEC_BSD_SHIFT;
1509 1510 1511 1512
			bsd_idx--;
		} else {
			DRM_DEBUG("execbuf with unknown bsd ring: %u\n",
				  bsd_idx);
1513
			return NULL;
1514 1515
		}

1516
		engine = dev_priv->engine[_VCS(bsd_idx)];
1517
	} else {
1518
		engine = dev_priv->engine[user_ring_map[user_ring_id]];
1519 1520
	}

1521
	if (!engine) {
1522
		DRM_DEBUG("execbuf with invalid ring: %u\n", user_ring_id);
1523
		return NULL;
1524 1525
	}

1526
	return engine;
1527 1528
}

1529 1530 1531 1532
static int
i915_gem_do_execbuffer(struct drm_device *dev, void *data,
		       struct drm_file *file,
		       struct drm_i915_gem_execbuffer2 *args,
1533
		       struct drm_i915_gem_exec_object2 *exec)
1534
{
1535 1536
	struct drm_i915_private *dev_priv = to_i915(dev);
	struct i915_ggtt *ggtt = &dev_priv->ggtt;
1537
	struct eb_vmas *eb;
1538
	struct drm_i915_gem_exec_object2 shadow_exec_entry;
1539
	struct intel_engine_cs *engine;
1540
	struct i915_gem_context *ctx;
1541
	struct i915_address_space *vm;
1542 1543
	struct i915_execbuffer_params params_master; /* XXX: will be removed later */
	struct i915_execbuffer_params *params = &params_master;
1544
	const u32 ctx_id = i915_execbuffer2_get_context_id(*args);
1545
	u32 dispatch_flags;
1546
	int ret;
1547
	bool need_relocs;
1548

1549
	if (!i915_gem_check_execbuffer(args))
1550 1551
		return -EINVAL;

1552
	ret = validate_exec_list(dev, exec, args->buffer_count);
1553 1554 1555
	if (ret)
		return ret;

1556
	dispatch_flags = 0;
1557
	if (args->flags & I915_EXEC_SECURE) {
1558
		if (!drm_is_current_master(file) || !capable(CAP_SYS_ADMIN))
1559 1560
		    return -EPERM;

1561
		dispatch_flags |= I915_DISPATCH_SECURE;
1562
	}
1563
	if (args->flags & I915_EXEC_IS_PINNED)
1564
		dispatch_flags |= I915_DISPATCH_PINNED;
1565

1566 1567 1568
	engine = eb_select_engine(dev_priv, file, args);
	if (!engine)
		return -EINVAL;
1569 1570

	if (args->buffer_count < 1) {
1571
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1572 1573 1574
		return -EINVAL;
	}

1575
	if (args->flags & I915_EXEC_RESOURCE_STREAMER) {
1576
		if (!HAS_RESOURCE_STREAMER(dev_priv)) {
1577 1578 1579
			DRM_DEBUG("RS is only allowed for Haswell, Gen8 and above\n");
			return -EINVAL;
		}
1580
		if (engine->id != RCS) {
1581
			DRM_DEBUG("RS is not available on %s\n",
1582
				 engine->name);
1583 1584 1585 1586 1587 1588
			return -EINVAL;
		}

		dispatch_flags |= I915_DISPATCH_RS;
	}

1589 1590 1591 1592 1593 1594
	/* Take a local wakeref for preparing to dispatch the execbuf as
	 * we expect to access the hardware fairly frequently in the
	 * process. Upon first dispatch, we acquire another prolonged
	 * wakeref that we hold until the GPU has been idle for at least
	 * 100ms.
	 */
1595 1596
	intel_runtime_pm_get(dev_priv);

1597 1598 1599 1600
	ret = i915_mutex_lock_interruptible(dev);
	if (ret)
		goto pre_mutex_err;

1601
	ctx = i915_gem_validate_context(dev, file, engine, ctx_id);
1602
	if (IS_ERR(ctx)) {
1603
		mutex_unlock(&dev->struct_mutex);
1604
		ret = PTR_ERR(ctx);
1605
		goto pre_mutex_err;
1606
	}
1607

1608
	i915_gem_context_get(ctx);
1609

1610 1611 1612
	if (ctx->ppgtt)
		vm = &ctx->ppgtt->base;
	else
1613
		vm = &ggtt->base;
1614

1615 1616
	memset(&params_master, 0x00, sizeof(params_master));

1617
	eb = eb_create(dev_priv, args);
1618
	if (eb == NULL) {
1619
		i915_gem_context_put(ctx);
1620 1621 1622 1623 1624
		mutex_unlock(&dev->struct_mutex);
		ret = -ENOMEM;
		goto pre_mutex_err;
	}

1625
	/* Look up object handles */
1626
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
1627 1628
	if (ret)
		goto err;
1629

1630
	/* take note of the batch buffer before we might reorder the lists */
1631
	params->batch = eb_get_batch(eb);
1632

1633
	/* Move the objects en-masse into the GTT, evicting if necessary. */
1634
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
1635 1636
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
1637 1638 1639 1640
	if (ret)
		goto err;

	/* The objects are in their final locations, apply the relocations. */
1641
	if (need_relocs)
B
Ben Widawsky 已提交
1642
		ret = i915_gem_execbuffer_relocate(eb);
1643 1644
	if (ret) {
		if (ret == -EFAULT) {
1645 1646
			ret = i915_gem_execbuffer_relocate_slow(dev, args, file,
								engine,
1647
								eb, exec, ctx);
1648 1649 1650 1651 1652 1653 1654
			BUG_ON(!mutex_is_locked(&dev->struct_mutex));
		}
		if (ret)
			goto err;
	}

	/* Set the pending read domains for the batch buffer to COMMAND */
1655
	if (params->batch->obj->base.pending_write_domain) {
1656
		DRM_DEBUG("Attempting to use self-modifying batch buffer\n");
1657 1658 1659
		ret = -EINVAL;
		goto err;
	}
1660 1661 1662 1663 1664 1665
	if (args->batch_start_offset > params->batch->size ||
	    args->batch_len > params->batch->size - args->batch_start_offset) {
		DRM_DEBUG("Attempting to use out-of-bounds batch\n");
		ret = -EINVAL;
		goto err;
	}
1666

1667
	params->args_batch_start_offset = args->batch_start_offset;
1668
	if (engine->needs_cmd_parser && args->batch_len) {
1669 1670 1671 1672 1673 1674 1675 1676 1677 1678
		struct i915_vma *vma;

		vma = i915_gem_execbuffer_parse(engine, &shadow_exec_entry,
						params->batch->obj,
						eb,
						args->batch_start_offset,
						args->batch_len,
						drm_is_current_master(file));
		if (IS_ERR(vma)) {
			ret = PTR_ERR(vma);
1679 1680
			goto err;
		}
1681

1682
		if (vma) {
1683 1684 1685 1686 1687 1688 1689 1690 1691 1692
			/*
			 * Batch parsed and accepted:
			 *
			 * Set the DISPATCH_SECURE bit to remove the NON_SECURE
			 * bit from MI_BATCH_BUFFER_START commands issued in
			 * the dispatch_execbuffer implementations. We
			 * specifically don't want that set on batches the
			 * command parser has accepted.
			 */
			dispatch_flags |= I915_DISPATCH_SECURE;
1693
			params->args_batch_start_offset = 0;
1694
			params->batch = vma;
1695
		}
1696 1697
	}

1698
	params->batch->obj->base.pending_read_domains |= I915_GEM_DOMAIN_COMMAND;
1699

1700 1701
	/* snb/ivb/vlv conflate the "batch in ppgtt" bit with the "non-secure
	 * batch" bit. Hence we need to pin secure batches into the global gtt.
B
Ben Widawsky 已提交
1702
	 * hsw should have this fixed, but bdw mucks it up again. */
1703
	if (dispatch_flags & I915_DISPATCH_SECURE) {
1704
		struct drm_i915_gem_object *obj = params->batch->obj;
C
Chris Wilson 已提交
1705
		struct i915_vma *vma;
1706

1707 1708 1709 1710 1711 1712
		/*
		 * So on first glance it looks freaky that we pin the batch here
		 * outside of the reservation loop. But:
		 * - The batch is already pinned into the relevant ppgtt, so we
		 *   already have the backing storage fully allocated.
		 * - No other BO uses the global gtt (well contexts, but meh),
1713
		 *   so we don't really have issues with multiple objects not
1714 1715 1716
		 *   fitting due to fragmentation.
		 * So this is actually safe.
		 */
C
Chris Wilson 已提交
1717 1718 1719
		vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
		if (IS_ERR(vma)) {
			ret = PTR_ERR(vma);
1720
			goto err;
C
Chris Wilson 已提交
1721
		}
1722

C
Chris Wilson 已提交
1723
		params->batch = vma;
1724
	}
1725

1726
	/* Allocate a request for this batch buffer nice and early. */
1727 1728 1729
	params->request = i915_gem_request_alloc(engine, ctx);
	if (IS_ERR(params->request)) {
		ret = PTR_ERR(params->request);
1730
		goto err_batch_unpin;
1731
	}
1732

1733 1734 1735 1736 1737 1738
	/* Whilst this request exists, batch_obj will be on the
	 * active_list, and so will hold the active reference. Only when this
	 * request is retired will the the batch_obj be moved onto the
	 * inactive_list and lose its active reference. Hence we do not need
	 * to explicitly hold another reference here.
	 */
C
Chris Wilson 已提交
1739
	params->request->batch = params->batch;
1740

1741
	ret = i915_gem_request_add_to_client(params->request, file);
1742
	if (ret)
1743
		goto err_request;
1744

1745 1746 1747 1748 1749 1750 1751 1752
	/*
	 * Save assorted stuff away to pass through to *_submission().
	 * NB: This data should be 'persistent' and not local as it will
	 * kept around beyond the duration of the IOCTL once the GPU
	 * scheduler arrives.
	 */
	params->dev                     = dev;
	params->file                    = file;
1753
	params->engine                    = engine;
1754 1755 1756
	params->dispatch_flags          = dispatch_flags;
	params->ctx                     = ctx;

1757
	ret = execbuf_submit(params, args, &eb->vmas);
1758
err_request:
1759
	__i915_add_request(params->request, ret == 0);
1760

1761
err_batch_unpin:
1762 1763 1764 1765 1766 1767
	/*
	 * FIXME: We crucially rely upon the active tracking for the (ppgtt)
	 * batch vma for correctness. For less ugly and less fragility this
	 * needs to be adjusted to also track the ggtt batch vma properly as
	 * active.
	 */
1768
	if (dispatch_flags & I915_DISPATCH_SECURE)
1769
		i915_vma_unpin(params->batch);
1770
err:
1771
	/* the request owns the ref now */
1772
	i915_gem_context_put(ctx);
1773
	eb_destroy(eb);
1774 1775 1776 1777

	mutex_unlock(&dev->struct_mutex);

pre_mutex_err:
1778 1779 1780
	/* intel_gpu_busy should also get a ref, so it will free when the device
	 * is really idle. */
	intel_runtime_pm_put(dev_priv);
1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798
	return ret;
}

/*
 * Legacy execbuffer just creates an exec2 list from the original exec object
 * list array and passes it to the real function.
 */
int
i915_gem_execbuffer(struct drm_device *dev, void *data,
		    struct drm_file *file)
{
	struct drm_i915_gem_execbuffer *args = data;
	struct drm_i915_gem_execbuffer2 exec2;
	struct drm_i915_gem_exec_object *exec_list = NULL;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret, i;

	if (args->buffer_count < 1) {
1799
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1800 1801 1802 1803 1804 1805 1806
		return -EINVAL;
	}

	/* Copy in the exec list from userland */
	exec_list = drm_malloc_ab(sizeof(*exec_list), args->buffer_count);
	exec2_list = drm_malloc_ab(sizeof(*exec2_list), args->buffer_count);
	if (exec_list == NULL || exec2_list == NULL) {
1807
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1808 1809 1810 1811 1812 1813
			  args->buffer_count);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -ENOMEM;
	}
	ret = copy_from_user(exec_list,
1814
			     u64_to_user_ptr(args->buffers_ptr),
1815 1816
			     sizeof(*exec_list) * args->buffer_count);
	if (ret != 0) {
1817
		DRM_DEBUG("copy %d exec entries failed %d\n",
1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829
			  args->buffer_count, ret);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

	for (i = 0; i < args->buffer_count; i++) {
		exec2_list[i].handle = exec_list[i].handle;
		exec2_list[i].relocation_count = exec_list[i].relocation_count;
		exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr;
		exec2_list[i].alignment = exec_list[i].alignment;
		exec2_list[i].offset = exec_list[i].offset;
1830
		if (INTEL_GEN(to_i915(dev)) < 4)
1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844
			exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE;
		else
			exec2_list[i].flags = 0;
	}

	exec2.buffers_ptr = args->buffers_ptr;
	exec2.buffer_count = args->buffer_count;
	exec2.batch_start_offset = args->batch_start_offset;
	exec2.batch_len = args->batch_len;
	exec2.DR1 = args->DR1;
	exec2.DR4 = args->DR4;
	exec2.num_cliprects = args->num_cliprects;
	exec2.cliprects_ptr = args->cliprects_ptr;
	exec2.flags = I915_EXEC_RENDER;
1845
	i915_execbuffer2_set_context_id(exec2, 0);
1846

1847
	ret = i915_gem_do_execbuffer(dev, data, file, &exec2, exec2_list);
1848
	if (!ret) {
1849
		struct drm_i915_gem_exec_object __user *user_exec_list =
1850
			u64_to_user_ptr(args->buffers_ptr);
1851

1852
		/* Copy the new buffer offsets back to the user's exec list. */
1853
		for (i = 0; i < args->buffer_count; i++) {
1854 1855
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1856 1857 1858 1859 1860 1861 1862 1863 1864 1865
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user (%d)\n",
					  args->buffer_count, ret);
				break;
			}
1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881
		}
	}

	drm_free_large(exec_list);
	drm_free_large(exec2_list);
	return ret;
}

int
i915_gem_execbuffer2(struct drm_device *dev, void *data,
		     struct drm_file *file)
{
	struct drm_i915_gem_execbuffer2 *args = data;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret;

1882 1883
	if (args->buffer_count < 1 ||
	    args->buffer_count > UINT_MAX / sizeof(*exec2_list)) {
1884
		DRM_DEBUG("execbuf2 with %d buffers\n", args->buffer_count);
1885 1886 1887
		return -EINVAL;
	}

1888 1889 1890 1891 1892
	if (args->rsvd2 != 0) {
		DRM_DEBUG("dirty rvsd2 field\n");
		return -EINVAL;
	}

1893 1894 1895
	exec2_list = drm_malloc_gfp(args->buffer_count,
				    sizeof(*exec2_list),
				    GFP_TEMPORARY);
1896
	if (exec2_list == NULL) {
1897
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1898 1899 1900 1901
			  args->buffer_count);
		return -ENOMEM;
	}
	ret = copy_from_user(exec2_list,
1902
			     u64_to_user_ptr(args->buffers_ptr),
1903 1904
			     sizeof(*exec2_list) * args->buffer_count);
	if (ret != 0) {
1905
		DRM_DEBUG("copy %d exec entries failed %d\n",
1906 1907 1908 1909 1910
			  args->buffer_count, ret);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

1911
	ret = i915_gem_do_execbuffer(dev, data, file, args, exec2_list);
1912 1913
	if (!ret) {
		/* Copy the new buffer offsets back to the user's exec list. */
1914
		struct drm_i915_gem_exec_object2 __user *user_exec_list =
1915
				   u64_to_user_ptr(args->buffers_ptr);
1916 1917 1918
		int i;

		for (i = 0; i < args->buffer_count; i++) {
1919 1920
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1921 1922 1923 1924 1925 1926 1927 1928 1929 1930
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user\n",
					  args->buffer_count);
				break;
			}
1931 1932 1933 1934 1935 1936
		}
	}

	drm_free_large(exec2_list);
	return ret;
}