CSharpChangeSignatureService.cs 38.8 KB
Newer Older
S
Sam Harwell 已提交
1
// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
2 3 4 5 6 7 8 9 10

using System;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Composition;
using System.Diagnostics;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
11
using Microsoft.CodeAnalysis;
12
using Microsoft.CodeAnalysis.ChangeSignature;
C
Cyrus Najmabadi 已提交
13
using Microsoft.CodeAnalysis.CSharp.Extensions;
14 15 16 17 18 19
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.FindSymbols;
using Microsoft.CodeAnalysis.Formatting;
using Microsoft.CodeAnalysis.Formatting.Rules;
using Microsoft.CodeAnalysis.Host.Mef;
using Microsoft.CodeAnalysis.Shared.Extensions;
I
Ivan Basov 已提交
20
using Microsoft.CodeAnalysis.Utilities;
21 22 23 24 25 26 27
using Roslyn.Utilities;

namespace Microsoft.CodeAnalysis.CSharp.ChangeSignature
{
    [ExportLanguageService(typeof(AbstractChangeSignatureService), LanguageNames.CSharp), Shared]
    internal sealed class CSharpChangeSignatureService : AbstractChangeSignatureService
    {
28 29 30 31 32 33
        private static readonly ImmutableArray<SyntaxKind> _declarationKinds = ImmutableArray.Create(
            SyntaxKind.MethodDeclaration,
            SyntaxKind.ConstructorDeclaration,
            SyntaxKind.IndexerDeclaration,
            SyntaxKind.DelegateDeclaration,
            SyntaxKind.SimpleLambdaExpression,
34 35
            SyntaxKind.ParenthesizedLambdaExpression,
            SyntaxKind.LocalFunctionStatement);
36 37 38

        private static readonly ImmutableArray<SyntaxKind> _declarationAndInvocableKinds =
            _declarationKinds.Concat(ImmutableArray.Create(
39 40 41 42 43 44
                SyntaxKind.InvocationExpression,
                SyntaxKind.ElementAccessExpression,
                SyntaxKind.ThisConstructorInitializer,
                SyntaxKind.BaseConstructorInitializer,
                SyntaxKind.ObjectCreationExpression,
                SyntaxKind.Attribute,
45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62
                SyntaxKind.NameMemberCref));

        private static readonly ImmutableArray<SyntaxKind> _updatableAncestorKinds = ImmutableArray.Create(
            SyntaxKind.ConstructorDeclaration,
            SyntaxKind.IndexerDeclaration,
            SyntaxKind.InvocationExpression,
            SyntaxKind.ElementAccessExpression,
            SyntaxKind.ThisConstructorInitializer,
            SyntaxKind.BaseConstructorInitializer,
            SyntaxKind.ObjectCreationExpression,
            SyntaxKind.Attribute,
            SyntaxKind.DelegateDeclaration,
            SyntaxKind.SimpleLambdaExpression,
            SyntaxKind.ParenthesizedLambdaExpression,
            SyntaxKind.NameMemberCref);

        private static readonly ImmutableArray<SyntaxKind> _updatableNodeKinds = ImmutableArray.Create(
            SyntaxKind.MethodDeclaration,
63
            SyntaxKind.LocalFunctionStatement,
64 65 66 67 68 69 70 71 72 73 74 75 76
            SyntaxKind.ConstructorDeclaration,
            SyntaxKind.IndexerDeclaration,
            SyntaxKind.InvocationExpression,
            SyntaxKind.ElementAccessExpression,
            SyntaxKind.ThisConstructorInitializer,
            SyntaxKind.BaseConstructorInitializer,
            SyntaxKind.ObjectCreationExpression,
            SyntaxKind.Attribute,
            SyntaxKind.DelegateDeclaration,
            SyntaxKind.NameMemberCref,
            SyntaxKind.AnonymousMethodExpression,
            SyntaxKind.ParenthesizedLambdaExpression,
            SyntaxKind.SimpleLambdaExpression);
77

78 79 80 81 82
        [ImportingConstructor]
        public CSharpChangeSignatureService()
        {
        }

I
Ivan Basov 已提交
83
        public override async Task<(ISymbol symbol, int selectedIndex)> GetInvocationSymbolAsync(
84
            Document document, int position, bool restrictToDeclarations, CancellationToken cancellationToken)
85
        {
86
            var tree = await document.GetSyntaxTreeAsync(cancellationToken).ConfigureAwait(false);
87 88 89 90
            var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);

            var token = root.FindToken(position != tree.Length ? position : Math.Max(0, position - 1));

91
            // Allow the user to invoke Change-Sig if they've written:   Goo(a, b, c);$$ 
92 93 94 95 96 97
            if (token.Kind() == SyntaxKind.SemicolonToken && token.Parent is StatementSyntax)
            {
                token = token.GetPreviousToken();
                position = token.Span.End;
            }

98 99
            var matchingNode = GetMatchingNode(token.Parent, restrictToDeclarations);
            if (matchingNode == null)
100
            {
101
                return default;
102
            }
103

104 105
            // Don't show change-signature in the random whitespace/trivia for code.
            if (!matchingNode.Span.IntersectsWith(position))
106
            {
107
                return default;
108 109
            }

110 111 112 113
            // If we're actually on the declaration of some symbol, ensure that we're
            // in a good location for that symbol (i.e. not in the attributes/constraints).
            if (!InSymbolHeader(matchingNode, position))
            {
114
                return default;
115 116
            }

117 118
            var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);
            var symbol = semanticModel.GetDeclaredSymbol(matchingNode, cancellationToken);
119 120
            if (symbol != null)
            {
121
                var selectedIndex = TryGetSelectedIndexFromDeclaration(position, matchingNode);
I
Ivan Basov 已提交
122
                return (symbol, selectedIndex);
123 124 125 126 127 128 129 130
            }

            if (matchingNode.IsKind(SyntaxKind.ObjectCreationExpression))
            {
                var objectCreation = matchingNode as ObjectCreationExpressionSyntax;

                if (token.Parent.AncestorsAndSelf().Any(a => a == objectCreation.Type))
                {
131
                    var typeSymbol = semanticModel.GetSymbolInfo(objectCreation.Type, cancellationToken).Symbol;
I
Ivan Basov 已提交
132

133 134
                    if (typeSymbol != null && typeSymbol.IsKind(SymbolKind.NamedType) && (typeSymbol as ITypeSymbol).TypeKind == TypeKind.Delegate)
                    {
I
Ivan Basov 已提交
135
                        return (typeSymbol, 0);
136 137 138 139 140
                    }
                }
            }

            var symbolInfo = semanticModel.GetSymbolInfo(matchingNode, cancellationToken);
I
Ivan Basov 已提交
141
            return (symbolInfo.Symbol ?? symbolInfo.CandidateSymbols.FirstOrDefault(), 0);
142 143 144 145 146 147
        }

        private static int TryGetSelectedIndexFromDeclaration(int position, SyntaxNode matchingNode)
        {
            var parameters = matchingNode.ChildNodes().OfType<BaseParameterListSyntax>().SingleOrDefault();
            return parameters != null ? GetParameterIndex(parameters.Parameters, position) : 0;
148 149
        }

150 151
        // Find the position to insert the new parameter.
        // We will insert a new comma and a parameter.
I
Ivan Basov 已提交
152
        protected override int? TryGetInsertPositionFromDeclaration(SyntaxNode matchingNode)
153
        {
I
Ivan Basov 已提交
154
            var parameters = matchingNode.ChildNodes().OfType<BaseParameterListSyntax>().SingleOrDefault();
155

156 157
            if (parameters == null)
            {
I
Ivan Basov 已提交
158
                return null;
159
            }
160

I
Ivan Basov 已提交
161 162 163 164 165 166 167 168 169
            switch (parameters)
            {
                case ParameterListSyntax parameterListSyntax:
                    return parameterListSyntax.CloseParenToken.SpanStart;
                case BracketedParameterListSyntax bracketedParameterListSyntax:
                    return bracketedParameterListSyntax.CloseBracketToken.SpanStart;
            }

            return null;
170 171
        }

172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194
        private SyntaxNode GetMatchingNode(SyntaxNode node, bool restrictToDeclarations)
        {
            var matchKinds = restrictToDeclarations
                ? _declarationKinds
                : _declarationAndInvocableKinds;

            for (var current = node; current != null; current = current.Parent)
            {
                if (restrictToDeclarations &&
                    current.Kind() == SyntaxKind.Block || current.Kind() == SyntaxKind.ArrowExpressionClause)
                {
                    return null;
                }

                if (matchKinds.Contains(current.Kind()))
                {
                    return current;
                }
            }

            return null;
        }

195 196 197 198 199 200 201 202
        private bool InSymbolHeader(SyntaxNode matchingNode, int position)
        {
            // Caret has to be after the attributes if the symbol has any.
            var lastAttributes = matchingNode.ChildNodes().LastOrDefault(n => n is AttributeListSyntax);
            var start = lastAttributes?.GetLastToken().GetNextToken().SpanStart ??
                        matchingNode.SpanStart;

            if (position < start)
203
            {
204 205 206 207 208 209 210 211 212 213 214 215 216
                return false;
            }

            // If the symbol has a parameter list, then the caret shouldn't be past the end of it.
            var parameterList = matchingNode.ChildNodes().LastOrDefault(n => n is ParameterListSyntax);
            if (parameterList != null)
            {
                return position <= parameterList.FullSpan.End;
            }

            // Case we haven't handled yet.  Just assume we're in the header.
            return true;
        }
217 218 219

        public override SyntaxNode FindNodeToUpdate(Document document, SyntaxNode node)
        {
220
            if (_updatableNodeKinds.Contains(node.Kind()))
221 222 223 224 225
            {
                return node;
            }

            // TODO: file bug about this: var invocation = csnode.Ancestors().FirstOrDefault(a => a.Kind == SyntaxKind.InvocationExpression);
226
            var matchingNode = node.AncestorsAndSelf().FirstOrDefault(n => _updatableAncestorKinds.Contains(n.Kind()));
227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267
            if (matchingNode == null)
            {
                return null;
            }

            var nodeContainingOriginal = GetNodeContainingTargetNode(matchingNode);
            if (nodeContainingOriginal == null)
            {
                return null;
            }

            return node.AncestorsAndSelf().Any(n => n == nodeContainingOriginal) ? matchingNode : null;
        }

        private SyntaxNode GetNodeContainingTargetNode(SyntaxNode matchingNode)
        {
            switch (matchingNode.Kind())
            {
                case SyntaxKind.InvocationExpression:
                    return (matchingNode as InvocationExpressionSyntax).Expression;

                case SyntaxKind.ElementAccessExpression:
                    return (matchingNode as ElementAccessExpressionSyntax).ArgumentList;

                case SyntaxKind.ObjectCreationExpression:
                    return (matchingNode as ObjectCreationExpressionSyntax).Type;

                case SyntaxKind.ConstructorDeclaration:
                case SyntaxKind.IndexerDeclaration:
                case SyntaxKind.ThisConstructorInitializer:
                case SyntaxKind.BaseConstructorInitializer:
                case SyntaxKind.Attribute:
                case SyntaxKind.DelegateDeclaration:
                case SyntaxKind.NameMemberCref:
                    return matchingNode;

                default:
                    return null;
            }
        }

I
Ivan Basov 已提交
268
        public override async Task<SyntaxNode> ChangeSignatureAsync(
269 270 271 272 273 274 275 276 277 278 279 280 281 282 283
            Document document,
            ISymbol declarationSymbol,
            SyntaxNode potentiallyUpdatedNode,
            SyntaxNode originalNode,
            SignatureChange signaturePermutation,
            CancellationToken cancellationToken)
        {
            var updatedNode = potentiallyUpdatedNode as CSharpSyntaxNode;

            // Update <param> tags.
            if (updatedNode.IsKind(SyntaxKind.MethodDeclaration) ||
                updatedNode.IsKind(SyntaxKind.ConstructorDeclaration) ||
                updatedNode.IsKind(SyntaxKind.IndexerDeclaration) ||
                updatedNode.IsKind(SyntaxKind.DelegateDeclaration))
            {
I
Ivan Basov 已提交
284
                var updatedLeadingTrivia = UpdateParamTagsInLeadingTrivia(document, updatedNode, declarationSymbol, signaturePermutation);
285 286 287 288 289 290 291
                if (updatedLeadingTrivia != null)
                {
                    updatedNode = updatedNode.WithLeadingTrivia(updatedLeadingTrivia);
                }
            }

            // Update declarations parameter lists
I
Ivan Basov 已提交
292
            if (updatedNode.IsKind(SyntaxKind.MethodDeclaration, out MethodDeclarationSyntax method))
293
            {
I
Ivan Basov 已提交
294
                var updatedParameters = PermuteDeclaration(method.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
295 296 297
                return method.WithParameterList(method.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
298
            if (updatedNode.IsKind(SyntaxKind.LocalFunctionStatement, out LocalFunctionStatementSyntax localFunction))
299
            {
I
Ivan Basov 已提交
300
                var updatedParameters = PermuteDeclaration(localFunction.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
301 302 303
                return localFunction.WithParameterList(localFunction.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
304
            if (updatedNode.IsKind(SyntaxKind.ConstructorDeclaration, out ConstructorDeclarationSyntax constructor))
305
            {
I
Ivan Basov 已提交
306
                var updatedParameters = PermuteDeclaration(constructor.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
307 308 309
                return constructor.WithParameterList(constructor.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
310
            if (updatedNode.IsKind(SyntaxKind.IndexerDeclaration, out IndexerDeclarationSyntax indexer))
311
            {
I
Ivan Basov 已提交
312
                var updatedParameters = PermuteDeclaration(indexer.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
313 314 315
                return indexer.WithParameterList(indexer.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
316
            if (updatedNode.IsKind(SyntaxKind.DelegateDeclaration, out DelegateDeclarationSyntax delegateDeclaration))
317
            {
I
Ivan Basov 已提交
318
                var updatedParameters = PermuteDeclaration(delegateDeclaration.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
319 320 321
                return delegateDeclaration.WithParameterList(delegateDeclaration.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
322
            if (updatedNode.IsKind(SyntaxKind.AnonymousMethodExpression, out AnonymousMethodExpressionSyntax anonymousMethod))
323 324 325 326 327 328 329
            {
                // Delegates may omit parameters in C#
                if (anonymousMethod.ParameterList == null)
                {
                    return anonymousMethod;
                }

I
Ivan Basov 已提交
330
                var updatedParameters = PermuteDeclaration(anonymousMethod.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
331 332 333
                return anonymousMethod.WithParameterList(anonymousMethod.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
334
            if (updatedNode.IsKind(SyntaxKind.SimpleLambdaExpression, out SimpleLambdaExpressionSyntax lambda))
335 336 337
            {
                if (signaturePermutation.UpdatedConfiguration.ToListOfParameters().Any())
                {
I
Ivan Basov 已提交
338 339 340 341 342 343
                    var updatedParameters = PermuteDeclaration(SyntaxFactory.SeparatedList<ParameterSyntax>(new[] { lambda.Parameter }), signaturePermutation, CreateNewParameterSyntax);
                    return SyntaxFactory.ParenthesizedLambdaExpression(
                        lambda.AsyncKeyword,
                        SyntaxFactory.ParameterList(updatedParameters),
                        lambda.ArrowToken,
                        lambda.Body);
344 345 346 347 348 349 350 351
                }
                else
                {
                    // No parameters. Change to a parenthesized lambda expression
                    var emptyParameterList = SyntaxFactory.ParameterList()
                        .WithLeadingTrivia(lambda.Parameter.GetLeadingTrivia())
                        .WithTrailingTrivia(lambda.Parameter.GetTrailingTrivia());

352
                    return SyntaxFactory.ParenthesizedLambdaExpression(lambda.AsyncKeyword, emptyParameterList, lambda.ArrowToken, lambda.Body);
353 354 355
                }
            }

C
Cyrus Najmabadi 已提交
356
            if (updatedNode.IsKind(SyntaxKind.ParenthesizedLambdaExpression, out ParenthesizedLambdaExpressionSyntax parenLambda))
357
            {
I
Ivan Basov 已提交
358
                bool doNotSkipParameterType = parenLambda.ParameterList.Parameters.Any() && parenLambda.ParameterList.Parameters.First().Type != null;
I
Ivan Basov 已提交
359
                Func<AddedParameter, ParameterSyntax> createNewParameterDelegate =
I
Ivan Basov 已提交
360
                    p => CreateNewParameterSyntax(p, !doNotSkipParameterType);
I
Ivan Basov 已提交
361 362

                var updatedParameters = PermuteDeclaration(
I
Ivan Basov 已提交
363
                    parenLambda.ParameterList.Parameters,
I
Ivan Basov 已提交
364 365
                    signaturePermutation,
                    createNewParameterDelegate);
I
Ivan Basov 已提交
366
                return parenLambda.WithParameterList(parenLambda.ParameterList.WithParameters(updatedParameters));
367 368 369
            }

            // Update reference site argument lists
A
Allison Chou 已提交
370
            if (updatedNode.IsKind(SyntaxKind.InvocationExpression, out InvocationExpressionSyntax invocation))
371
            {
I
Ivan Basov 已提交
372
                var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);
373

374
                var symbolInfo = semanticModel.GetSymbolInfo((InvocationExpressionSyntax)originalNode, cancellationToken);
375 376
                var isReducedExtensionMethod = false;

C
Cyrus Najmabadi 已提交
377
                if (symbolInfo.Symbol is IMethodSymbol methodSymbol && methodSymbol.MethodKind == MethodKind.ReducedExtension)
378 379 380 381
                {
                    isReducedExtensionMethod = true;
                }

A
Allison Chou 已提交
382
                var newArguments = PermuteArgumentList(declarationSymbol, invocation.ArgumentList.Arguments, signaturePermutation.WithoutAddedParameters(), isReducedExtensionMethod);
I
Ivan Basov 已提交
383
                newArguments = AddNewArgumentsToList(newArguments, signaturePermutation, isReducedExtensionMethod);
384 385 386
                return invocation.WithArgumentList(invocation.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
387
            if (updatedNode.IsKind(SyntaxKind.ObjectCreationExpression, out ObjectCreationExpressionSyntax objCreation))
388
            {
A
Allison Chou 已提交
389 390 391 392 393 394 395 396 397 398 399 400
                var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);

                var symbolInfo = semanticModel.GetSymbolInfo((ObjectCreationExpressionSyntax)originalNode, cancellationToken);
                var isReducedExtensionMethod = false;

                if (symbolInfo.Symbol is IMethodSymbol methodSymbol && methodSymbol.MethodKind == MethodKind.ReducedExtension)
                {
                    isReducedExtensionMethod = true;
                }

                var newArguments = PermuteArgumentList(declarationSymbol, objCreation.ArgumentList.Arguments, signaturePermutation.WithoutAddedParameters());
                newArguments = AddNewArgumentsToList(newArguments, signaturePermutation, isReducedExtensionMethod);
401 402 403 404 405 406
                return objCreation.WithArgumentList(objCreation.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.ThisConstructorInitializer) ||
                updatedNode.IsKind(SyntaxKind.BaseConstructorInitializer))
            {
I
Ivan Basov 已提交
407 408
                var constructorInit = (ConstructorInitializerSyntax)updatedNode;
                var newArguments = PermuteArgumentList(declarationSymbol, constructorInit.ArgumentList.Arguments, signaturePermutation);
I
Ivan Basov 已提交
409
                return constructorInit.WithArgumentList(constructorInit.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
410 411
            }

C
Cyrus Najmabadi 已提交
412
            if (updatedNode.IsKind(SyntaxKind.ElementAccessExpression, out ElementAccessExpressionSyntax elementAccess))
413
            {
I
Ivan Basov 已提交
414
                var newArguments = PermuteArgumentList(declarationSymbol, elementAccess.ArgumentList.Arguments, signaturePermutation);
415 416 417
                return elementAccess.WithArgumentList(elementAccess.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
418
            if (updatedNode.IsKind(SyntaxKind.Attribute, out AttributeSyntax attribute))
419
            {
I
Ivan Basov 已提交
420
                var newArguments = PermuteAttributeArgumentList(declarationSymbol, attribute.ArgumentList.Arguments, signaturePermutation);
421 422 423 424
                return attribute.WithArgumentList(attribute.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            // Handle references in crefs
I
Ivan Basov 已提交
425
            if (updatedNode.IsKind(SyntaxKind.NameMemberCref, out NameMemberCrefSyntax nameMemberCref))
426 427 428 429 430 431 432
            {
                if (nameMemberCref.Parameters == null ||
                    !nameMemberCref.Parameters.Parameters.Any())
                {
                    return nameMemberCref;
                }

I
Ivan Basov 已提交
433
                var newParameters = PermuteDeclaration(nameMemberCref.Parameters.Parameters, signaturePermutation, CreateNewCrefParameterSyntax);
434 435 436 437 438 439 440 441 442

                var newCrefParameterList = nameMemberCref.Parameters.WithParameters(newParameters);
                return nameMemberCref.WithParameters(newCrefParameterList);
            }

            Debug.Assert(false, "Unknown reference location");
            return null;
        }

443 444
        private SeparatedSyntaxList<ArgumentSyntax> AddNewArgumentsToList(
            SeparatedSyntaxList<ArgumentSyntax> newArguments,
I
Ivan Basov 已提交
445 446
            SignatureChange signaturePermutation,
            bool isReducedExtensionMethod)
447 448
        {
            List<ArgumentSyntax> fullList = new List<ArgumentSyntax>();
449
            List<SyntaxToken> separators = new List<SyntaxToken>();
450 451 452 453 454 455 456 457 458

            var updatedParameters = signaturePermutation.UpdatedConfiguration.ToListOfParameters();

            int indexInExistingList = 0;

            bool seenNameEquals = false;

            for (int i = 0; i < updatedParameters.Count; i++)
            {
I
Ivan Basov 已提交
459 460 461
                // Skip this parameter in list of arguments for extension method calls but not for reduced ones.
                if (updatedParameters[i] != signaturePermutation.UpdatedConfiguration.ThisParameter
                    || !isReducedExtensionMethod)
462
                {
I
Ivan Basov 已提交
463
                    if (updatedParameters[i] is AddedParameter addedParameter)
464
                    {
I
Ivan Basov 已提交
465 466 467 468 469
                        fullList.Add(SyntaxFactory.Argument(
                            seenNameEquals ? SyntaxFactory.NameColon(addedParameter.Name) : default,
                            refKindKeyword: default,
                            expression: SyntaxFactory.ParseExpression(addedParameter.CallSiteValue)));
                        separators.Add(SyntaxFactory.Token(SyntaxKind.CommaToken).WithTrailingTrivia(SyntaxFactory.ElasticSpace));
470
                    }
I
Ivan Basov 已提交
471
                    else
472
                    {
I
Ivan Basov 已提交
473
                        if (indexInExistingList < newArguments.Count)
I
Ivan Basov 已提交
474
                        {
I
Ivan Basov 已提交
475
                            if (newArguments[indexInExistingList].NameColon != null)
I
Ivan Basov 已提交
476 477 478
                            {
                                seenNameEquals = true;
                            }
479

I
Ivan Basov 已提交
480 481 482 483
                            if (indexInExistingList < newArguments.SeparatorCount)
                            {
                                separators.Add(newArguments.GetSeparator(indexInExistingList));
                            }
484

I
Ivan Basov 已提交
485 486
                            fullList.Add(newArguments[indexInExistingList++]);
                        }
I
Ivan Basov 已提交
487
                    }
488 489 490
                }
            }

491 492 493 494 495 496 497 498 499 500 501
            // Add the rest of existing parameters, e.g. from the params argument.
            while (indexInExistingList < newArguments.Count)
            {
                if (indexInExistingList < newArguments.SeparatorCount)
                {
                    separators.Add(newArguments.GetSeparator(indexInExistingList));
                }

                fullList.Add(newArguments[indexInExistingList++]);
            }

I
Ivan Basov 已提交
502 503 504 505 506
            if (fullList.Count == separators.Count && separators.Count != 0)
            {
                separators.Remove(separators.Last());
            }

507
            return SyntaxFactory.SeparatedList(fullList, separators);
508 509
        }

I
Ivan Basov 已提交
510
        private static ParameterSyntax CreateNewParameterSyntax(AddedParameter addedParameter)
I
Ivan Basov 已提交
511
            => CreateNewParameterSyntax(addedParameter, skipParameterType: false);
I
Ivan Basov 已提交
512

I
Ivan Basov 已提交
513 514 515
        // TODO consider using symbol for TypeName instead of parsing it
        // https://github.com/dotnet/roslyn/issues/41046
        // Consider cross-platform scenarios here.
I
Ivan Basov 已提交
516
        private static ParameterSyntax CreateNewParameterSyntax(AddedParameter addedParameter, bool skipParameterType)
I
Ivan Basov 已提交
517 518 519
            => SyntaxFactory.Parameter(
                attributeLists: SyntaxFactory.List<AttributeListSyntax>(),
                modifiers: SyntaxFactory.TokenList(),
I
Ivan Basov 已提交
520
                type: skipParameterType ? default : SyntaxFactory.ParseTypeName(addedParameter.TypeName).WithTrailingTrivia(SyntaxFactory.ElasticSpace),
I
Ivan Basov 已提交
521 522
                SyntaxFactory.Identifier(addedParameter.ParameterName),
                @default: default);
I
Ivan Basov 已提交
523

I
Ivan Basov 已提交
524 525
        private static CrefParameterSyntax CreateNewCrefParameterSyntax(AddedParameter addedParameter)
            => SyntaxFactory.CrefParameter(type: SyntaxFactory.ParseTypeName(addedParameter.TypeName)).WithLeadingTrivia(SyntaxFactory.ElasticSpace);
I
Ivan Basov 已提交
526 527

        private SeparatedSyntaxList<T> PermuteDeclaration<T>(
I
Ivan Basov 已提交
528
            SeparatedSyntaxList<T> list,
I
Ivan Basov 已提交
529 530
            SignatureChange updatedSignature,
            Func<AddedParameter, T> createNewParameterMethod) where T : SyntaxNode
531
        {
532
            var permuteDeclarationBase = base.PermuteDeclarationBase<T>(list, updatedSignature, createNewParameterMethod);
533
            return SyntaxFactory.SeparatedList(permuteDeclarationBase.parameters, permuteDeclarationBase.separators);
534 535
        }

536
        protected override T TransferLeadingWhitespaceTrivia<T>(T newArgument, SyntaxNode oldArgument)
537 538 539 540 541 542 543 544 545
        {
            var oldTrivia = oldArgument.GetLeadingTrivia();
            var oldOnlyHasWhitespaceTrivia = oldTrivia.All(t => t.IsKind(SyntaxKind.WhitespaceTrivia));

            var newTrivia = newArgument.GetLeadingTrivia();
            var newOnlyHasWhitespaceTrivia = newTrivia.All(t => t.IsKind(SyntaxKind.WhitespaceTrivia));

            if (oldOnlyHasWhitespaceTrivia && newOnlyHasWhitespaceTrivia)
            {
546
                newArgument = newArgument.WithLeadingTrivia(oldTrivia);
547 548 549 550 551
            }

            return newArgument;
        }

552
        private SeparatedSyntaxList<AttributeArgumentSyntax> PermuteAttributeArgumentList(
553 554 555 556
            ISymbol declarationSymbol,
            SeparatedSyntaxList<AttributeArgumentSyntax> arguments,
            SignatureChange updatedSignature)
        {
I
Ivan Basov 已提交
557 558
            var newArguments = PermuteArguments(declarationSymbol, arguments.Select(a => UnifiedArgumentSyntax.Create(a)).ToList(),
                updatedSignature,
A
Allison Chou 已提交
559
                callSiteValue => UnifiedArgumentSyntax.Create(SyntaxFactory.AttributeArgument(SyntaxFactory.ParseExpression(callSiteValue))));
560
            var numSeparatorsToSkip = arguments.Count - newArguments.Count;
561 562

            // copy whitespace trivia from original position
563 564
            var newArgumentsWithTrivia = TransferLeadingWhitespaceTrivia(
                newArguments.Select(a => (AttributeArgumentSyntax)(UnifiedArgumentSyntax)a), arguments);
565 566

            return SyntaxFactory.SeparatedList(newArgumentsWithTrivia, GetSeparators(arguments, numSeparatorsToSkip));
567 568
        }

569
        private SeparatedSyntaxList<ArgumentSyntax> PermuteArgumentList(
570 571 572 573 574
            ISymbol declarationSymbol,
            SeparatedSyntaxList<ArgumentSyntax> arguments,
            SignatureChange updatedSignature,
            bool isReducedExtensionMethod = false)
        {
I
Ivan Basov 已提交
575 576 577
            var newArguments = PermuteArguments(
                declarationSymbol,
                arguments.Select(a => UnifiedArgumentSyntax.Create(a)).ToList(),
I
Ivan Basov 已提交
578
                updatedSignature,
I
Ivan Basov 已提交
579 580
                callSiteValue => UnifiedArgumentSyntax.Create(SyntaxFactory.Argument(SyntaxFactory.ParseExpression(callSiteValue))),
                isReducedExtensionMethod);
581

582 583 584
            // copy whitespace trivia from original position
            var newArgumentsWithTrivia = TransferLeadingWhitespaceTrivia(
                newArguments.Select(a => (ArgumentSyntax)(UnifiedArgumentSyntax)a), arguments);
585

586
            var numSeparatorsToSkip = arguments.Count - newArguments.Count;
587 588 589
            return SyntaxFactory.SeparatedList(newArgumentsWithTrivia, GetSeparators(arguments, numSeparatorsToSkip));
        }

590
        private List<T> TransferLeadingWhitespaceTrivia<T, U>(IEnumerable<T> newArguments, SeparatedSyntaxList<U> oldArguments)
591 592 593 594
            where T : SyntaxNode
            where U : SyntaxNode
        {
            var result = new List<T>();
595
            var index = 0;
596 597
            foreach (var newArgument in newArguments)
            {
I
Ivan Basov 已提交
598 599 600 601 602 603 604 605 606
                if (index < oldArguments.Count)
                {
                    result.Add(TransferLeadingWhitespaceTrivia(newArgument, oldArguments[index]));
                }
                else
                {
                    result.Add(newArgument);
                }

607 608 609 610
                index++;
            }

            return result;
611 612
        }

I
Ivan Basov 已提交
613
        private List<SyntaxTrivia> UpdateParamTagsInLeadingTrivia(Document document, CSharpSyntaxNode node, ISymbol declarationSymbol, SignatureChange updatedSignature)
614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630
        {
            if (!node.HasLeadingTrivia)
            {
                return null;
            }

            var paramNodes = node
                .DescendantNodes(descendIntoTrivia: true)
                .OfType<XmlElementSyntax>()
                .Where(e => e.StartTag.Name.ToString() == DocumentationCommentXmlNames.ParameterElementName);

            var permutedParamNodes = VerifyAndPermuteParamNodes(paramNodes, declarationSymbol, updatedSignature);
            if (permutedParamNodes == null)
            {
                return null;
            }

I
Ivan Basov 已提交
631
            return GetPermutedTrivia(document, node, permutedParamNodes);
632 633 634 635 636 637 638 639 640
        }

        private List<XmlElementSyntax> VerifyAndPermuteParamNodes(IEnumerable<XmlElementSyntax> paramNodes, ISymbol declarationSymbol, SignatureChange updatedSignature)
        {
            // Only reorder if count and order match originally.
            var originalParameters = updatedSignature.OriginalConfiguration.ToListOfParameters();
            var reorderedParameters = updatedSignature.UpdatedConfiguration.ToListOfParameters();

            var declaredParameters = declarationSymbol.GetParameters();
641
            if (paramNodes.Count() != declaredParameters.Length)
642 643 644 645
            {
                return null;
            }

646 647 648 649 650
            if (declaredParameters.Length == 0)
            {
                return null;
            }

651
            var dictionary = new Dictionary<string, XmlElementSyntax>();
652
            var i = 0;
C
Charles Stoner 已提交
653
            foreach (var paramNode in paramNodes)
654 655 656 657 658 659 660 661 662 663 664 665 666
            {
                var nameAttribute = paramNode.StartTag.Attributes.FirstOrDefault(a => a.Name.ToString().Equals("name", StringComparison.OrdinalIgnoreCase));
                if (nameAttribute == null)
                {
                    return null;
                }

                var identifier = nameAttribute.DescendantNodes(descendIntoTrivia: true).OfType<IdentifierNameSyntax>().FirstOrDefault();
                if (identifier == null || identifier.ToString() != declaredParameters.ElementAt(i).Name)
                {
                    return null;
                }

C
Charles Stoner 已提交
667 668
                dictionary.Add(originalParameters[i].Name.ToString(), paramNode);
                i++;
669 670 671 672 673 674
            }

            // Everything lines up, so permute them.
            var permutedParams = new List<XmlElementSyntax>();
            foreach (var parameter in reorderedParameters)
            {
I
Ivan Basov 已提交
675 676 677 678 679 680 681 682 683 684 685 686
                if (dictionary.TryGetValue(parameter.Name, out var permutedParam))
                {
                    permutedParams.Add(permutedParam);
                }
                else
                {
                    permutedParams.Add(SyntaxFactory.XmlElement(
                        SyntaxFactory.XmlElementStartTag(
                            SyntaxFactory.XmlName("param"),
                            SyntaxFactory.List<XmlAttributeSyntax>(new[] { SyntaxFactory.XmlNameAttribute(parameter.Name) })),
                        SyntaxFactory.XmlElementEndTag(SyntaxFactory.XmlName("param"))));
                }
687 688 689 690 691
            }

            return permutedParams;
        }

I
Ivan Basov 已提交
692
        private List<SyntaxTrivia> GetPermutedTrivia(Document document, CSharpSyntaxNode node, List<XmlElementSyntax> permutedParamNodes)
693 694 695
        {
            var updatedLeadingTrivia = new List<SyntaxTrivia>();
            var index = 0;
I
Ivan Basov 已提交
696 697 698 699
            SyntaxTrivia lastWhiteSpaceTrivia = default;

            var lastDocumentationCommentTriviaSyntax = node.GetLeadingTrivia()
                .LastOrDefault(t => t.HasStructure && t.GetStructure() is DocumentationCommentTriviaSyntax);
700 701 702 703 704

            foreach (var trivia in node.GetLeadingTrivia())
            {
                if (!trivia.HasStructure)
                {
I
Ivan Basov 已提交
705 706 707 708 709
                    if (trivia.IsKind(SyntaxKind.WhitespaceTrivia))
                    {
                        lastWhiteSpaceTrivia = trivia;
                    }

710 711 712 713
                    updatedLeadingTrivia.Add(trivia);
                    continue;
                }

C
Cyrus Najmabadi 已提交
714
                if (!(trivia.GetStructure() is DocumentationCommentTriviaSyntax structuredTrivia))
715 716 717 718 719 720 721
                {
                    updatedLeadingTrivia.Add(trivia);
                    continue;
                }

                var updatedNodeList = new List<XmlNodeSyntax>();
                var structuredContent = structuredTrivia.Content.ToList();
C
Cyrus Najmabadi 已提交
722
                for (var i = 0; i < structuredContent.Count; i++)
723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749
                {
                    var content = structuredContent[i];
                    if (!content.IsKind(SyntaxKind.XmlElement))
                    {
                        updatedNodeList.Add(content);
                        continue;
                    }

                    var xmlElement = content as XmlElementSyntax;
                    if (xmlElement.StartTag.Name.ToString() != DocumentationCommentXmlNames.ParameterElementName)
                    {
                        updatedNodeList.Add(content);
                        continue;
                    }

                    // Found a param tag, so insert the next one from the reordered list
                    if (index < permutedParamNodes.Count)
                    {
                        updatedNodeList.Add(permutedParamNodes[index].WithLeadingTrivia(content.GetLeadingTrivia()).WithTrailingTrivia(content.GetTrailingTrivia()));
                        index++;
                    }
                    else
                    {
                        // Inspecting a param element that we are deleting but not replacing.
                    }
                }

I
Ivan Basov 已提交
750 751 752 753
                var newDocComments = SyntaxFactory.DocumentationCommentTrivia(
                    structuredTrivia.Kind(),
                    SyntaxFactory.List(updatedNodeList.AsEnumerable()),
                    structuredTrivia.EndOfComment);
754 755 756 757 758 759
                newDocComments = newDocComments.WithLeadingTrivia(structuredTrivia.GetLeadingTrivia()).WithTrailingTrivia(structuredTrivia.GetTrailingTrivia());
                var newTrivia = SyntaxFactory.Trivia(newDocComments);

                updatedLeadingTrivia.Add(newTrivia);
            }

I
Ivan Basov 已提交
760 761 762
            var extraNodeList = new List<XmlNodeSyntax>();
            while (index < permutedParamNodes.Count)
            {
I
Ivan Basov 已提交
763
                extraNodeList.Add(permutedParamNodes[index]);
I
Ivan Basov 已提交
764 765 766 767 768
                index++;
            }

            if (extraNodeList.Any())
            {
I
Ivan Basov 已提交
769 770 771 772 773 774 775 776 777 778 779
                var extraDocComments = SyntaxFactory.DocumentationCommentTrivia(
                    SyntaxKind.MultiLineDocumentationCommentTrivia,
                    SyntaxFactory.List(extraNodeList.AsEnumerable()),
                    SyntaxFactory.Token(SyntaxKind.EndOfDocumentationCommentToken));
                extraDocComments = extraDocComments
                    .WithLeadingTrivia(SyntaxFactory.DocumentationCommentExterior("/// "))
                    .WithTrailingTrivia(node.GetTrailingTrivia())
                    .WithTrailingTrivia(
                    SyntaxFactory.EndOfLine(document.Project.Solution.Workspace.Options.GetOption(FormattingOptions.NewLine, LanguageNames.CSharp)),
                    lastWhiteSpaceTrivia);

I
Ivan Basov 已提交
780 781 782 783 784
                var newTrivia = SyntaxFactory.Trivia(extraDocComments);

                updatedLeadingTrivia.Add(newTrivia);
            }

785 786 787
            return updatedLeadingTrivia;
        }

788
        public override async Task<ImmutableArray<SymbolAndProjectId>> DetermineCascadedSymbolsFromDelegateInvoke(
D
dotnet-bot 已提交
789 790
            SymbolAndProjectId<IMethodSymbol> symbolAndProjectId,
            Document document,
791
            CancellationToken cancellationToken)
792
        {
793
            var symbol = symbolAndProjectId.Symbol;
794 795 796
            var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
            var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);

797
            var nodes = root.DescendantNodes().ToImmutableArray();
798
            var convertedMethodGroups = nodes
799
                .WhereAsArray(
800
                    n =>
I
Ivan Basov 已提交
801 802 803
                    {
                        if (!n.IsKind(SyntaxKind.IdentifierName) ||
                            !semanticModel.GetMemberGroup(n, cancellationToken).Any())
804
                        {
I
Ivan Basov 已提交
805 806
                            return false;
                        }
807

I
Ivan Basov 已提交
808
                        ISymbol convertedType = semanticModel.GetTypeInfo(n, cancellationToken).ConvertedType;
809

I
Ivan Basov 已提交
810 811 812 813
                        if (convertedType != null)
                        {
                            convertedType = convertedType.OriginalDefinition;
                        }
814

I
Ivan Basov 已提交
815 816 817 818
                        if (convertedType != null)
                        {
                            convertedType = SymbolFinder.FindSourceDefinitionAsync(convertedType, document.Project.Solution, cancellationToken).WaitAndGetResult_CanCallOnBackground(cancellationToken) ?? convertedType;
                        }
819

I
Ivan Basov 已提交
820 821
                        return Equals(convertedType, symbol.ContainingType);
                    })
822
                .SelectAsArray(n => semanticModel.GetSymbolInfo(n, cancellationToken).Symbol);
823

824
            return convertedMethodGroups.SelectAsArray(symbolAndProjectId.WithSymbol);
825 826
        }

827
        protected override IEnumerable<AbstractFormattingRule> GetFormattingRules(Document document)
828
            => SpecializedCollections.SingletonEnumerable<AbstractFormattingRule>(new ChangeSignatureFormattingRule()).Concat(Formatter.GetDefaultFormattingRules(document));
829

I
Ivan Basov 已提交
830 831
        protected override SyntaxToken CreateSeparatorSyntaxToken()
            => SyntaxFactory.Token(SyntaxKind.CommaToken).WithTrailingTrivia(SyntaxFactory.ElasticSpace);
832
    }
S
Sam Harwell 已提交
833
}