Changed UI (made Add higher) and fixed bug with callsites

src/Features/CSharp/Portable/ChangeSignature/CSharpChangeSignatureService.cs

@@ -383,7 +383,7 @@ private SyntaxNode GetNodeContainingTargetNode(SyntaxNode matchingNode)
             if (updatedNode.IsKind(SyntaxKind.InvocationExpression))
             {
                 var invocation = (InvocationExpressionSyntax)updatedNode;
-                var semanticModel = document.GetSemanticModelAsync(cancellationToken).WaitAndGetResult(cancellationToken);
+                var semanticModel = document.GetSemanticModelAsync(cancellationToken).WaitAndGetResult_CanCallOnBackground(cancellationToken);
 
                 var symbolInfo = semanticModel.GetSymbolInfo((InvocationExpressionSyntax)originalNode, cancellationToken);
                 var isReducedExtensionMethod = false;
@@ -466,10 +466,13 @@ private SeparatedSyntaxList<ArgumentSyntax> AddNewArgumentsToList(Document docum
             {
                 if (updatedParameters[i] is AddedParameter addedParameter)
                 {
-                    fullList.Add(SyntaxFactory.Argument(
-                        seenNameEquals ? SyntaxFactory.NameColon(addedParameter.Name) : default,
-                        refKindKeyword: default,
-                        expression: SyntaxFactory.ParseExpression(addedParameter.CallsiteValue)));
+                    if (addedParameter.CallsiteValue != null)
+                    {
+                        fullList.Add(SyntaxFactory.Argument(
+                            seenNameEquals ? SyntaxFactory.NameColon(addedParameter.Name) : default,
+                            refKindKeyword: default,
+                            expression: SyntaxFactory.ParseExpression(addedParameter.CallsiteValue)));
+                    }
                 }
                 else
                 {

src/Features/Core/Portable/ChangeSignature/AbstractChangeSignatureService.cs

@@ -61,11 +61,11 @@ public async Task<ImmutableArray<ChangeSignatureCodeAction>> GetChangeSignatureC
 
         internal ChangeSignatureResult ChangeSignature(Document document, int position, Action<string, NotificationSeverity> errorHandler, CancellationToken cancellationToken)
         {
-            var context = GetContextAsync(document, position, restrictToDeclarations: false, cancellationToken: cancellationToken).WaitAndGetResult(cancellationToken);
+            var context = GetContextAsync(document, position, restrictToDeclarations: false, cancellationToken: cancellationToken).WaitAndGetResult_CanCallOnBackground(cancellationToken);
 
             if (context.CanChangeSignature)
             {
-                return ChangeSignatureWithContextAsync(context, cancellationToken).WaitAndGetResult(cancellationToken);
+                return ChangeSignatureWithContextAsync(context, cancellationToken).WaitAndGetResult_CanCallOnBackground(cancellationToken);
             }
             else
             {
@@ -209,7 +209,7 @@ internal ChangeSignatureOptionsResult GetChangeSignatureOptions(ChangeSignatureA
 
             var symbols = FindChangeSignatureReferencesAsync(
                 SymbolAndProjectId.Create(declaredSymbol, context.Project.Id),
-                context.Solution, cancellationToken).WaitAndGetResult(cancellationToken);
+                context.Solution, cancellationToken).WaitAndGetResult_CanCallOnBackground(cancellationToken);
 
             foreach (var symbol in symbols)
             {

src/VisualStudio/Core/Def/Implementation/ChangeSignature/AddParameterDialog.xaml.cs

@@ -57,10 +57,11 @@ private void AddParameterDialog_Loaded(object sender, RoutedEventArgs e)
 
         private void OK_Click(object sender, RoutedEventArgs e)
         {
+            ViewModel.TypeName = ((IntellisenseTextBox)TypeContentControl.Content).Text;
+            ViewModel.ParameterName = ((IntellisenseTextBox)NameContentControl.Content).Text;
+
             if (ViewModel.TrySubmit())
             {
-                ViewModel.TypeName = ((IntellisenseTextBox)TypeContentControl.Content).Text;
-                ViewModel.ParameterName = ((IntellisenseTextBox)NameContentControl.Content).Text;
                 DialogResult = true;
             }
         }

src/VisualStudio/Core/Def/Implementation/ChangeSignature/ChangeSignatureDialog.xaml

@@ -277,36 +277,33 @@
                                         Width="16" 
                                         Moniker="{x:Static imagecatalog:KnownMonikers.MoveDown}" 
                                         Grayscale="{Binding IsEnabled, ElementName=DownButton, Converter={StaticResource NegateBooleanConverter}}"/>
-
                 </vs:DialogButton>
                 <vs:DialogButton
-                        Name="RemoveButton"
+                        Name="AddButton"
                         Margin="9 29 0 0"
+                        AutomationProperties.Name="{Binding AddAutomationText}"
+                        Click="Add_Click"
+                        AutomationProperties.AutomationId="AddButton"
+                        Content="{Binding ElementName=dialog, Path=Add}"
+                        Height="Auto" Width="Auto"/>
+                <vs:DialogButton
+                        Name="RemoveButton"
+                        Margin="9 9 0 0"
                         IsEnabled="{Binding CanRemove, Mode=OneWay}" 
                         AutomationProperties.Name="{Binding RemoveAutomationText}"
                         Click="Remove_Click" 
                         AutomationProperties.AutomationId="RemoveButton" 
                         Content="{Binding ElementName=dialog, Path=Remove}" 
-                        Height="Auto" Width="Auto">
-                </vs:DialogButton>
-
+                        Height="Auto" Width="Auto"/>
                 <vs:DialogButton
                         Name="RestoreButton"
-                        Margin="9 9 0 0"
+                        Margin="9 29 0 0"
                         IsEnabled="{Binding CanRestore, Mode=OneWay}" 
                         Click="Restore_Click" 
                         AutomationProperties.AutomationId="RestoreButton" 
                         AutomationProperties.Name="{Binding RestoreAutomationText}"
                         Content="{Binding ElementName=dialog, Path=Restore}" 
                         Height="Auto" Width="Auto"/>
-
-                <vs:DialogButton
-                        Margin="9 29 0 0"
-                        AutomationProperties.Name="{Binding AddAutomationText}"
-                        Click="Add_Click"
-                        AutomationProperties.AutomationId="AddButton"
-                        Content="{Binding ElementName=dialog, Path=Add}"
-                        Height="Auto" Width="Auto"/>
             </StackPanel>
         </Grid>