CSharpChangeSignatureService.cs 38.7 KB
Newer Older
S
Sam Harwell 已提交
1
// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
2 3 4 5 6 7 8 9 10

using System;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Composition;
using System.Diagnostics;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
11
using Microsoft.CodeAnalysis;
12 13 14 15 16 17 18
using Microsoft.CodeAnalysis.ChangeSignature;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.FindSymbols;
using Microsoft.CodeAnalysis.Formatting;
using Microsoft.CodeAnalysis.Formatting.Rules;
using Microsoft.CodeAnalysis.Host.Mef;
using Microsoft.CodeAnalysis.Shared.Extensions;
I
Ivan Basov 已提交
19
using Microsoft.CodeAnalysis.Utilities;
20 21 22 23 24 25 26
using Roslyn.Utilities;

namespace Microsoft.CodeAnalysis.CSharp.ChangeSignature
{
    [ExportLanguageService(typeof(AbstractChangeSignatureService), LanguageNames.CSharp), Shared]
    internal sealed class CSharpChangeSignatureService : AbstractChangeSignatureService
    {
27 28 29 30 31 32
        private static readonly ImmutableArray<SyntaxKind> _declarationKinds = ImmutableArray.Create(
            SyntaxKind.MethodDeclaration,
            SyntaxKind.ConstructorDeclaration,
            SyntaxKind.IndexerDeclaration,
            SyntaxKind.DelegateDeclaration,
            SyntaxKind.SimpleLambdaExpression,
33 34
            SyntaxKind.ParenthesizedLambdaExpression,
            SyntaxKind.LocalFunctionStatement);
35 36 37

        private static readonly ImmutableArray<SyntaxKind> _declarationAndInvocableKinds =
            _declarationKinds.Concat(ImmutableArray.Create(
38 39 40 41 42 43
                SyntaxKind.InvocationExpression,
                SyntaxKind.ElementAccessExpression,
                SyntaxKind.ThisConstructorInitializer,
                SyntaxKind.BaseConstructorInitializer,
                SyntaxKind.ObjectCreationExpression,
                SyntaxKind.Attribute,
44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61
                SyntaxKind.NameMemberCref));

        private static readonly ImmutableArray<SyntaxKind> _updatableAncestorKinds = ImmutableArray.Create(
            SyntaxKind.ConstructorDeclaration,
            SyntaxKind.IndexerDeclaration,
            SyntaxKind.InvocationExpression,
            SyntaxKind.ElementAccessExpression,
            SyntaxKind.ThisConstructorInitializer,
            SyntaxKind.BaseConstructorInitializer,
            SyntaxKind.ObjectCreationExpression,
            SyntaxKind.Attribute,
            SyntaxKind.DelegateDeclaration,
            SyntaxKind.SimpleLambdaExpression,
            SyntaxKind.ParenthesizedLambdaExpression,
            SyntaxKind.NameMemberCref);

        private static readonly ImmutableArray<SyntaxKind> _updatableNodeKinds = ImmutableArray.Create(
            SyntaxKind.MethodDeclaration,
62
            SyntaxKind.LocalFunctionStatement,
63 64 65 66 67 68 69 70 71 72 73 74 75
            SyntaxKind.ConstructorDeclaration,
            SyntaxKind.IndexerDeclaration,
            SyntaxKind.InvocationExpression,
            SyntaxKind.ElementAccessExpression,
            SyntaxKind.ThisConstructorInitializer,
            SyntaxKind.BaseConstructorInitializer,
            SyntaxKind.ObjectCreationExpression,
            SyntaxKind.Attribute,
            SyntaxKind.DelegateDeclaration,
            SyntaxKind.NameMemberCref,
            SyntaxKind.AnonymousMethodExpression,
            SyntaxKind.ParenthesizedLambdaExpression,
            SyntaxKind.SimpleLambdaExpression);
76

77 78 79 80 81
        [ImportingConstructor]
        public CSharpChangeSignatureService()
        {
        }

I
Ivan Basov 已提交
82
        public override async Task<(ISymbol symbol, int selectedIndex)> GetInvocationSymbolAsync(
83
            Document document, int position, bool restrictToDeclarations, CancellationToken cancellationToken)
84
        {
85
            var tree = await document.GetSyntaxTreeAsync(cancellationToken).ConfigureAwait(false);
86 87 88 89
            var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);

            var token = root.FindToken(position != tree.Length ? position : Math.Max(0, position - 1));

90
            // Allow the user to invoke Change-Sig if they've written:   Goo(a, b, c);$$ 
91 92 93 94 95 96
            if (token.Kind() == SyntaxKind.SemicolonToken && token.Parent is StatementSyntax)
            {
                token = token.GetPreviousToken();
                position = token.Span.End;
            }

97 98
            var matchingNode = GetMatchingNode(token.Parent, restrictToDeclarations);
            if (matchingNode == null)
99
            {
100
                return default;
101
            }
102

103 104
            // Don't show change-signature in the random whitespace/trivia for code.
            if (!matchingNode.Span.IntersectsWith(position))
105
            {
106
                return default;
107 108
            }

109 110 111 112
            // If we're actually on the declaration of some symbol, ensure that we're
            // in a good location for that symbol (i.e. not in the attributes/constraints).
            if (!InSymbolHeader(matchingNode, position))
            {
113
                return default;
114 115
            }

116 117
            var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);
            var symbol = semanticModel.GetDeclaredSymbol(matchingNode, cancellationToken);
118 119
            if (symbol != null)
            {
120
                var selectedIndex = TryGetSelectedIndexFromDeclaration(position, matchingNode);
I
Ivan Basov 已提交
121
                return (symbol, selectedIndex);
122 123 124 125 126 127 128 129
            }

            if (matchingNode.IsKind(SyntaxKind.ObjectCreationExpression))
            {
                var objectCreation = matchingNode as ObjectCreationExpressionSyntax;

                if (token.Parent.AncestorsAndSelf().Any(a => a == objectCreation.Type))
                {
130
                    var typeSymbol = semanticModel.GetSymbolInfo(objectCreation.Type, cancellationToken).Symbol;
I
Ivan Basov 已提交
131

132 133
                    if (typeSymbol != null && typeSymbol.IsKind(SymbolKind.NamedType) && (typeSymbol as ITypeSymbol).TypeKind == TypeKind.Delegate)
                    {
I
Ivan Basov 已提交
134
                        return (typeSymbol, 0);
135 136 137 138 139
                    }
                }
            }

            var symbolInfo = semanticModel.GetSymbolInfo(matchingNode, cancellationToken);
I
Ivan Basov 已提交
140
            return (symbolInfo.Symbol ?? symbolInfo.CandidateSymbols.FirstOrDefault(), 0);
141 142 143 144 145 146
        }

        private static int TryGetSelectedIndexFromDeclaration(int position, SyntaxNode matchingNode)
        {
            var parameters = matchingNode.ChildNodes().OfType<BaseParameterListSyntax>().SingleOrDefault();
            return parameters != null ? GetParameterIndex(parameters.Parameters, position) : 0;
147 148
        }

149 150
        // Find the position to insert the new parameter.
        // We will insert a new comma and a parameter.
I
Ivan Basov 已提交
151
        protected override int? TryGetInsertPositionFromDeclaration(SyntaxNode matchingNode)
152
        {
I
Ivan Basov 已提交
153
            var parameters = matchingNode.ChildNodes().OfType<BaseParameterListSyntax>().SingleOrDefault();
154

155 156
            if (parameters == null)
            {
I
Ivan Basov 已提交
157
                return null;
158
            }
159

I
Ivan Basov 已提交
160 161 162 163 164 165 166 167 168
            switch (parameters)
            {
                case ParameterListSyntax parameterListSyntax:
                    return parameterListSyntax.CloseParenToken.SpanStart;
                case BracketedParameterListSyntax bracketedParameterListSyntax:
                    return bracketedParameterListSyntax.CloseBracketToken.SpanStart;
            }

            return null;
169 170
        }

171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193
        private SyntaxNode GetMatchingNode(SyntaxNode node, bool restrictToDeclarations)
        {
            var matchKinds = restrictToDeclarations
                ? _declarationKinds
                : _declarationAndInvocableKinds;

            for (var current = node; current != null; current = current.Parent)
            {
                if (restrictToDeclarations &&
                    current.Kind() == SyntaxKind.Block || current.Kind() == SyntaxKind.ArrowExpressionClause)
                {
                    return null;
                }

                if (matchKinds.Contains(current.Kind()))
                {
                    return current;
                }
            }

            return null;
        }

194 195 196 197 198 199 200 201
        private bool InSymbolHeader(SyntaxNode matchingNode, int position)
        {
            // Caret has to be after the attributes if the symbol has any.
            var lastAttributes = matchingNode.ChildNodes().LastOrDefault(n => n is AttributeListSyntax);
            var start = lastAttributes?.GetLastToken().GetNextToken().SpanStart ??
                        matchingNode.SpanStart;

            if (position < start)
202
            {
203 204 205 206 207 208 209 210 211 212 213 214 215
                return false;
            }

            // If the symbol has a parameter list, then the caret shouldn't be past the end of it.
            var parameterList = matchingNode.ChildNodes().LastOrDefault(n => n is ParameterListSyntax);
            if (parameterList != null)
            {
                return position <= parameterList.FullSpan.End;
            }

            // Case we haven't handled yet.  Just assume we're in the header.
            return true;
        }
216 217 218

        public override SyntaxNode FindNodeToUpdate(Document document, SyntaxNode node)
        {
219
            if (_updatableNodeKinds.Contains(node.Kind()))
220 221 222 223 224
            {
                return node;
            }

            // TODO: file bug about this: var invocation = csnode.Ancestors().FirstOrDefault(a => a.Kind == SyntaxKind.InvocationExpression);
225
            var matchingNode = node.AncestorsAndSelf().FirstOrDefault(n => _updatableAncestorKinds.Contains(n.Kind()));
226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266
            if (matchingNode == null)
            {
                return null;
            }

            var nodeContainingOriginal = GetNodeContainingTargetNode(matchingNode);
            if (nodeContainingOriginal == null)
            {
                return null;
            }

            return node.AncestorsAndSelf().Any(n => n == nodeContainingOriginal) ? matchingNode : null;
        }

        private SyntaxNode GetNodeContainingTargetNode(SyntaxNode matchingNode)
        {
            switch (matchingNode.Kind())
            {
                case SyntaxKind.InvocationExpression:
                    return (matchingNode as InvocationExpressionSyntax).Expression;

                case SyntaxKind.ElementAccessExpression:
                    return (matchingNode as ElementAccessExpressionSyntax).ArgumentList;

                case SyntaxKind.ObjectCreationExpression:
                    return (matchingNode as ObjectCreationExpressionSyntax).Type;

                case SyntaxKind.ConstructorDeclaration:
                case SyntaxKind.IndexerDeclaration:
                case SyntaxKind.ThisConstructorInitializer:
                case SyntaxKind.BaseConstructorInitializer:
                case SyntaxKind.Attribute:
                case SyntaxKind.DelegateDeclaration:
                case SyntaxKind.NameMemberCref:
                    return matchingNode;

                default:
                    return null;
            }
        }

I
Ivan Basov 已提交
267
        public override async Task<SyntaxNode> ChangeSignatureAsync(
268 269 270 271 272 273 274 275 276 277 278 279 280 281 282
            Document document,
            ISymbol declarationSymbol,
            SyntaxNode potentiallyUpdatedNode,
            SyntaxNode originalNode,
            SignatureChange signaturePermutation,
            CancellationToken cancellationToken)
        {
            var updatedNode = potentiallyUpdatedNode as CSharpSyntaxNode;

            // Update <param> tags.
            if (updatedNode.IsKind(SyntaxKind.MethodDeclaration) ||
                updatedNode.IsKind(SyntaxKind.ConstructorDeclaration) ||
                updatedNode.IsKind(SyntaxKind.IndexerDeclaration) ||
                updatedNode.IsKind(SyntaxKind.DelegateDeclaration))
            {
I
Ivan Basov 已提交
283
                var updatedLeadingTrivia = UpdateParamTagsInLeadingTrivia(document, updatedNode, declarationSymbol, signaturePermutation);
284 285 286 287 288 289 290 291 292
                if (updatedLeadingTrivia != null)
                {
                    updatedNode = updatedNode.WithLeadingTrivia(updatedLeadingTrivia);
                }
            }

            // Update declarations parameter lists
            if (updatedNode.IsKind(SyntaxKind.MethodDeclaration))
            {
293
                var method = (MethodDeclarationSyntax)updatedNode;
I
Ivan Basov 已提交
294
                var updatedParameters = PermuteDeclaration(method.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
295 296 297
                return method.WithParameterList(method.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

298 299 300
            if (updatedNode.IsKind(SyntaxKind.LocalFunctionStatement))
            {
                var localFunction = (LocalFunctionStatementSyntax)updatedNode;
I
Ivan Basov 已提交
301
                var updatedParameters = PermuteDeclaration(localFunction.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
302 303 304
                return localFunction.WithParameterList(localFunction.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

305 306
            if (updatedNode.IsKind(SyntaxKind.ConstructorDeclaration))
            {
307
                var constructor = (ConstructorDeclarationSyntax)updatedNode;
I
Ivan Basov 已提交
308
                var updatedParameters = PermuteDeclaration(constructor.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
309 310 311 312 313
                return constructor.WithParameterList(constructor.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.IndexerDeclaration))
            {
314
                var indexer = (IndexerDeclarationSyntax)updatedNode;
I
Ivan Basov 已提交
315
                var updatedParameters = PermuteDeclaration(indexer.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
316 317 318 319 320
                return indexer.WithParameterList(indexer.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.DelegateDeclaration))
            {
321
                var delegateDeclaration = (DelegateDeclarationSyntax)updatedNode;
I
Ivan Basov 已提交
322
                var updatedParameters = PermuteDeclaration(delegateDeclaration.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
323 324 325 326 327
                return delegateDeclaration.WithParameterList(delegateDeclaration.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.AnonymousMethodExpression))
            {
328
                var anonymousMethod = (AnonymousMethodExpressionSyntax)updatedNode;
329 330 331 332 333 334 335

                // Delegates may omit parameters in C#
                if (anonymousMethod.ParameterList == null)
                {
                    return anonymousMethod;
                }

I
Ivan Basov 已提交
336
                var updatedParameters = PermuteDeclaration(anonymousMethod.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
337 338 339 340 341
                return anonymousMethod.WithParameterList(anonymousMethod.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.SimpleLambdaExpression))
            {
342
                var lambda = (SimpleLambdaExpressionSyntax)updatedNode;
343 344 345

                if (signaturePermutation.UpdatedConfiguration.ToListOfParameters().Any())
                {
I
Ivan Basov 已提交
346 347 348 349 350 351
                    var updatedParameters = PermuteDeclaration(SyntaxFactory.SeparatedList<ParameterSyntax>(new[] { lambda.Parameter }), signaturePermutation, CreateNewParameterSyntax);
                    return SyntaxFactory.ParenthesizedLambdaExpression(
                        lambda.AsyncKeyword,
                        SyntaxFactory.ParameterList(updatedParameters),
                        lambda.ArrowToken,
                        lambda.Body);
352 353 354 355 356 357 358 359
                }
                else
                {
                    // No parameters. Change to a parenthesized lambda expression
                    var emptyParameterList = SyntaxFactory.ParameterList()
                        .WithLeadingTrivia(lambda.Parameter.GetLeadingTrivia())
                        .WithTrailingTrivia(lambda.Parameter.GetTrailingTrivia());

360
                    return SyntaxFactory.ParenthesizedLambdaExpression(lambda.AsyncKeyword, emptyParameterList, lambda.ArrowToken, lambda.Body);
361 362 363 364 365
                }
            }

            if (updatedNode.IsKind(SyntaxKind.ParenthesizedLambdaExpression))
            {
366
                var lambda = (ParenthesizedLambdaExpressionSyntax)updatedNode;
I
Ivan Basov 已提交
367 368 369 370 371 372 373 374
                bool doNotSkipType = lambda.ParameterList.Parameters.Any() && lambda.ParameterList.Parameters.First().Type != null;
                Func<AddedParameter, ParameterSyntax> createNewParameterDelegate =
                    p => CreateNewParameterSyntax(p, !doNotSkipType);

                var updatedParameters = PermuteDeclaration(
                    lambda.ParameterList.Parameters,
                    signaturePermutation,
                    createNewParameterDelegate);
375 376 377 378 379 380
                return lambda.WithParameterList(lambda.ParameterList.WithParameters(updatedParameters));
            }

            // Update reference site argument lists
            if (updatedNode.IsKind(SyntaxKind.InvocationExpression))
            {
381
                var invocation = (InvocationExpressionSyntax)updatedNode;
I
Ivan Basov 已提交
382
                var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);
383

384
                var symbolInfo = semanticModel.GetSymbolInfo((InvocationExpressionSyntax)originalNode, cancellationToken);
385 386
                var isReducedExtensionMethod = false;

C
Cyrus Najmabadi 已提交
387
                if (symbolInfo.Symbol is IMethodSymbol methodSymbol && methodSymbol.MethodKind == MethodKind.ReducedExtension)
388 389 390 391
                {
                    isReducedExtensionMethod = true;
                }

392 393
                SignatureChange signaturePermutationWithoutAddedParameters = signaturePermutation.WithoutAddedParameters();

I
Ivan Basov 已提交
394
                var newArguments = PermuteArgumentList(declarationSymbol, invocation.ArgumentList.Arguments, signaturePermutationWithoutAddedParameters, isReducedExtensionMethod);
I
Ivan Basov 已提交
395
                newArguments = AddNewArgumentsToList(newArguments, signaturePermutation, isReducedExtensionMethod);
396 397 398 399 400
                return invocation.WithArgumentList(invocation.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.ObjectCreationExpression))
            {
401
                var objCreation = (ObjectCreationExpressionSyntax)updatedNode;
I
Ivan Basov 已提交
402
                var newArguments = PermuteArgumentList(declarationSymbol, objCreation.ArgumentList.Arguments, signaturePermutation);
403 404 405 406 407 408
                return objCreation.WithArgumentList(objCreation.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.ThisConstructorInitializer) ||
                updatedNode.IsKind(SyntaxKind.BaseConstructorInitializer))
            {
409
                var objCreation = (ConstructorInitializerSyntax)updatedNode;
I
Ivan Basov 已提交
410
                var newArguments = PermuteArgumentList(declarationSymbol, objCreation.ArgumentList.Arguments, signaturePermutation);
411 412 413 414 415
                return objCreation.WithArgumentList(objCreation.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.ElementAccessExpression))
            {
416
                var elementAccess = (ElementAccessExpressionSyntax)updatedNode;
I
Ivan Basov 已提交
417
                var newArguments = PermuteArgumentList(declarationSymbol, elementAccess.ArgumentList.Arguments, signaturePermutation);
418 419 420 421 422
                return elementAccess.WithArgumentList(elementAccess.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.Attribute))
            {
423
                var attribute = (AttributeSyntax)updatedNode;
I
Ivan Basov 已提交
424
                var newArguments = PermuteAttributeArgumentList(declarationSymbol, attribute.ArgumentList.Arguments, signaturePermutation);
425 426 427 428 429 430
                return attribute.WithArgumentList(attribute.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            // Handle references in crefs
            if (updatedNode.IsKind(SyntaxKind.NameMemberCref))
            {
431
                var nameMemberCref = (NameMemberCrefSyntax)updatedNode;
432 433 434 435 436 437 438

                if (nameMemberCref.Parameters == null ||
                    !nameMemberCref.Parameters.Parameters.Any())
                {
                    return nameMemberCref;
                }

I
Ivan Basov 已提交
439
                var newParameters = PermuteDeclaration(nameMemberCref.Parameters.Parameters, signaturePermutation, CreateNewCrefParameterSyntax);
440 441 442 443 444 445 446 447 448

                var newCrefParameterList = nameMemberCref.Parameters.WithParameters(newParameters);
                return nameMemberCref.WithParameters(newCrefParameterList);
            }

            Debug.Assert(false, "Unknown reference location");
            return null;
        }

449 450
        private SeparatedSyntaxList<ArgumentSyntax> AddNewArgumentsToList(
            SeparatedSyntaxList<ArgumentSyntax> newArguments,
I
Ivan Basov 已提交
451 452
            SignatureChange signaturePermutation,
            bool isReducedExtensionMethod)
453 454
        {
            List<ArgumentSyntax> fullList = new List<ArgumentSyntax>();
455
            List<SyntaxToken> separators = new List<SyntaxToken>();
456 457 458 459 460 461 462 463 464

            var updatedParameters = signaturePermutation.UpdatedConfiguration.ToListOfParameters();

            int indexInExistingList = 0;

            bool seenNameEquals = false;

            for (int i = 0; i < updatedParameters.Count; i++)
            {
I
Ivan Basov 已提交
465 466 467
                // Skip this parameter in list of arguments for extension method calls but not for reduced ones.
                if (updatedParameters[i] != signaturePermutation.UpdatedConfiguration.ThisParameter
                    || !isReducedExtensionMethod)
468
                {
I
Ivan Basov 已提交
469
                    if (updatedParameters[i] is AddedParameter addedParameter)
470
                    {
I
Ivan Basov 已提交
471
                        if (addedParameter.CallSiteValue != null)
I
Ivan Basov 已提交
472 473 474 475
                        {
                            fullList.Add(SyntaxFactory.Argument(
                                seenNameEquals ? SyntaxFactory.NameColon(addedParameter.Name) : default,
                                refKindKeyword: default,
I
Ivan Basov 已提交
476
                                expression: SyntaxFactory.ParseExpression(addedParameter.CallSiteValue)));
I
Ivan Basov 已提交
477
                            separators.Add(SyntaxFactory.Token(SyntaxKind.CommaToken).WithTrailingTrivia(SyntaxFactory.ElasticSpace));
I
Ivan Basov 已提交
478
                        }
479
                    }
I
Ivan Basov 已提交
480
                    else
481
                    {
I
Ivan Basov 已提交
482
                        if (indexInExistingList < newArguments.Count)
I
Ivan Basov 已提交
483
                        {
I
Ivan Basov 已提交
484 485 486 487
                            if (newArguments[indexInExistingList].NameColon != default)
                            {
                                seenNameEquals = true;
                            }
488

I
Ivan Basov 已提交
489 490 491 492
                            if (indexInExistingList < newArguments.SeparatorCount)
                            {
                                separators.Add(newArguments.GetSeparator(indexInExistingList));
                            }
493

I
Ivan Basov 已提交
494 495
                            fullList.Add(newArguments[indexInExistingList++]);
                        }
I
Ivan Basov 已提交
496
                    }
497 498 499
                }
            }

500 501 502 503 504 505 506 507 508 509 510
            // Add the rest of existing parameters, e.g. from the params argument.
            while (indexInExistingList < newArguments.Count)
            {
                if (indexInExistingList < newArguments.SeparatorCount)
                {
                    separators.Add(newArguments.GetSeparator(indexInExistingList));
                }

                fullList.Add(newArguments[indexInExistingList++]);
            }

I
Ivan Basov 已提交
511 512 513 514 515
            if (fullList.Count == separators.Count && separators.Count != 0)
            {
                separators.Remove(separators.Last());
            }

516
            return SyntaxFactory.SeparatedList(fullList, separators);
517 518
        }

I
Ivan Basov 已提交
519 520
        private static ParameterSyntax CreateNewParameterSyntax(AddedParameter addedParameter)
            => CreateNewParameterSyntax(addedParameter, skipType: false);
I
Ivan Basov 已提交
521

I
Ivan Basov 已提交
522 523 524 525 526 527 528
        private static ParameterSyntax CreateNewParameterSyntax(AddedParameter addedParameter, bool skipType)
            => SyntaxFactory.Parameter(
                attributeLists: SyntaxFactory.List<AttributeListSyntax>(),
                modifiers: SyntaxFactory.TokenList(),
                type: skipType ? default : SyntaxFactory.ParseTypeName(addedParameter.TypeName).WithTrailingTrivia(SyntaxFactory.ElasticSpace),
                SyntaxFactory.Identifier(addedParameter.ParameterName),
                @default: default);
I
Ivan Basov 已提交
529

I
Ivan Basov 已提交
530 531
        private static CrefParameterSyntax CreateNewCrefParameterSyntax(AddedParameter addedParameter)
            => SyntaxFactory.CrefParameter(type: SyntaxFactory.ParseTypeName(addedParameter.TypeName)).WithLeadingTrivia(SyntaxFactory.ElasticSpace);
I
Ivan Basov 已提交
532 533

        private SeparatedSyntaxList<T> PermuteDeclaration<T>(
I
Ivan Basov 已提交
534
            SeparatedSyntaxList<T> list,
I
Ivan Basov 已提交
535 536
            SignatureChange updatedSignature,
            Func<AddedParameter, T> createNewParameterMethod) where T : SyntaxNode
537
        {
538
            var permuteDeclarationBase = base.PermuteDeclarationBase<T>(list, updatedSignature, createNewParameterMethod);
539
            return SyntaxFactory.SeparatedList(permuteDeclarationBase.parameters, permuteDeclarationBase.separators);
540 541
        }

542
        protected override T TransferLeadingWhitespaceTrivia<T>(T newArgument, SyntaxNode oldArgument)
543 544 545 546 547 548 549 550 551
        {
            var oldTrivia = oldArgument.GetLeadingTrivia();
            var oldOnlyHasWhitespaceTrivia = oldTrivia.All(t => t.IsKind(SyntaxKind.WhitespaceTrivia));

            var newTrivia = newArgument.GetLeadingTrivia();
            var newOnlyHasWhitespaceTrivia = newTrivia.All(t => t.IsKind(SyntaxKind.WhitespaceTrivia));

            if (oldOnlyHasWhitespaceTrivia && newOnlyHasWhitespaceTrivia)
            {
552
                newArgument = newArgument.WithLeadingTrivia(oldTrivia);
553 554 555 556 557
            }

            return newArgument;
        }

558
        private SeparatedSyntaxList<AttributeArgumentSyntax> PermuteAttributeArgumentList(
559 560 561 562
            ISymbol declarationSymbol,
            SeparatedSyntaxList<AttributeArgumentSyntax> arguments,
            SignatureChange updatedSignature)
        {
I
Ivan Basov 已提交
563 564
            var newArguments = PermuteArguments(declarationSymbol, arguments.Select(a => UnifiedArgumentSyntax.Create(a)).ToList(),
                updatedSignature,
A
Allison Chou 已提交
565
                callSiteValue => UnifiedArgumentSyntax.Create(SyntaxFactory.AttributeArgument(SyntaxFactory.ParseExpression(callSiteValue))));
566
            var numSeparatorsToSkip = arguments.Count - newArguments.Count;
567 568

            // copy whitespace trivia from original position
569 570
            var newArgumentsWithTrivia = TransferLeadingWhitespaceTrivia(
                newArguments.Select(a => (AttributeArgumentSyntax)(UnifiedArgumentSyntax)a), arguments);
571 572

            return SyntaxFactory.SeparatedList(newArgumentsWithTrivia, GetSeparators(arguments, numSeparatorsToSkip));
573 574
        }

575
        private SeparatedSyntaxList<ArgumentSyntax> PermuteArgumentList(
576 577 578 579 580
            ISymbol declarationSymbol,
            SeparatedSyntaxList<ArgumentSyntax> arguments,
            SignatureChange updatedSignature,
            bool isReducedExtensionMethod = false)
        {
I
Ivan Basov 已提交
581 582
            var newArguments = PermuteArguments(declarationSymbol, arguments.Select(a => UnifiedArgumentSyntax.Create(a)).ToList(),
                updatedSignature,
A
Allison Chou 已提交
583
                 callSiteValue => UnifiedArgumentSyntax.Create(SyntaxFactory.Argument(SyntaxFactory.ParseExpression(callSiteValue))),
I
Ivan Basov 已提交
584
                 isReducedExtensionMethod);
585

586 587 588
            // copy whitespace trivia from original position
            var newArgumentsWithTrivia = TransferLeadingWhitespaceTrivia(
                newArguments.Select(a => (ArgumentSyntax)(UnifiedArgumentSyntax)a), arguments);
589

590
            var numSeparatorsToSkip = arguments.Count - newArguments.Count;
591 592 593
            return SyntaxFactory.SeparatedList(newArgumentsWithTrivia, GetSeparators(arguments, numSeparatorsToSkip));
        }

594
        private List<T> TransferLeadingWhitespaceTrivia<T, U>(IEnumerable<T> newArguments, SeparatedSyntaxList<U> oldArguments)
595 596 597 598
            where T : SyntaxNode
            where U : SyntaxNode
        {
            var result = new List<T>();
599
            var index = 0;
600 601
            foreach (var newArgument in newArguments)
            {
I
Ivan Basov 已提交
602 603 604 605 606 607 608 609 610
                if (index < oldArguments.Count)
                {
                    result.Add(TransferLeadingWhitespaceTrivia(newArgument, oldArguments[index]));
                }
                else
                {
                    result.Add(newArgument);
                }

611 612 613 614
                index++;
            }

            return result;
615 616
        }

I
Ivan Basov 已提交
617
        private List<SyntaxTrivia> UpdateParamTagsInLeadingTrivia(Document document, CSharpSyntaxNode node, ISymbol declarationSymbol, SignatureChange updatedSignature)
618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634
        {
            if (!node.HasLeadingTrivia)
            {
                return null;
            }

            var paramNodes = node
                .DescendantNodes(descendIntoTrivia: true)
                .OfType<XmlElementSyntax>()
                .Where(e => e.StartTag.Name.ToString() == DocumentationCommentXmlNames.ParameterElementName);

            var permutedParamNodes = VerifyAndPermuteParamNodes(paramNodes, declarationSymbol, updatedSignature);
            if (permutedParamNodes == null)
            {
                return null;
            }

I
Ivan Basov 已提交
635
            return GetPermutedTrivia(document, node, permutedParamNodes);
636 637 638 639 640 641 642 643 644
        }

        private List<XmlElementSyntax> VerifyAndPermuteParamNodes(IEnumerable<XmlElementSyntax> paramNodes, ISymbol declarationSymbol, SignatureChange updatedSignature)
        {
            // Only reorder if count and order match originally.
            var originalParameters = updatedSignature.OriginalConfiguration.ToListOfParameters();
            var reorderedParameters = updatedSignature.UpdatedConfiguration.ToListOfParameters();

            var declaredParameters = declarationSymbol.GetParameters();
645
            if (paramNodes.Count() != declaredParameters.Length)
646 647 648 649
            {
                return null;
            }

650 651 652 653 654
            if (declaredParameters.Length == 0)
            {
                return null;
            }

655
            var dictionary = new Dictionary<string, XmlElementSyntax>();
656
            var i = 0;
C
Charles Stoner 已提交
657
            foreach (var paramNode in paramNodes)
658 659 660 661 662 663 664 665 666 667 668 669 670
            {
                var nameAttribute = paramNode.StartTag.Attributes.FirstOrDefault(a => a.Name.ToString().Equals("name", StringComparison.OrdinalIgnoreCase));
                if (nameAttribute == null)
                {
                    return null;
                }

                var identifier = nameAttribute.DescendantNodes(descendIntoTrivia: true).OfType<IdentifierNameSyntax>().FirstOrDefault();
                if (identifier == null || identifier.ToString() != declaredParameters.ElementAt(i).Name)
                {
                    return null;
                }

C
Charles Stoner 已提交
671 672
                dictionary.Add(originalParameters[i].Name.ToString(), paramNode);
                i++;
673 674 675 676 677 678
            }

            // Everything lines up, so permute them.
            var permutedParams = new List<XmlElementSyntax>();
            foreach (var parameter in reorderedParameters)
            {
I
Ivan Basov 已提交
679 680 681 682 683 684 685 686 687 688 689 690
                if (dictionary.TryGetValue(parameter.Name, out var permutedParam))
                {
                    permutedParams.Add(permutedParam);
                }
                else
                {
                    permutedParams.Add(SyntaxFactory.XmlElement(
                        SyntaxFactory.XmlElementStartTag(
                            SyntaxFactory.XmlName("param"),
                            SyntaxFactory.List<XmlAttributeSyntax>(new[] { SyntaxFactory.XmlNameAttribute(parameter.Name) })),
                        SyntaxFactory.XmlElementEndTag(SyntaxFactory.XmlName("param"))));
                }
691 692 693 694 695
            }

            return permutedParams;
        }

I
Ivan Basov 已提交
696
        private List<SyntaxTrivia> GetPermutedTrivia(Document document, CSharpSyntaxNode node, List<XmlElementSyntax> permutedParamNodes)
697 698 699
        {
            var updatedLeadingTrivia = new List<SyntaxTrivia>();
            var index = 0;
I
Ivan Basov 已提交
700 701 702 703 704
            SyntaxTrivia lastWhiteSpaceTrivia = default;

            var lastDocumentationCommentTriviaSyntax = node.GetLeadingTrivia()
                .LastOrDefault(t => t.HasStructure && t.GetStructure() is DocumentationCommentTriviaSyntax);
            DocumentationCommentTriviaSyntax documentationCommeStructuredTrivia = lastDocumentationCommentTriviaSyntax.GetStructure() as DocumentationCommentTriviaSyntax;
705 706 707 708 709

            foreach (var trivia in node.GetLeadingTrivia())
            {
                if (!trivia.HasStructure)
                {
I
Ivan Basov 已提交
710 711 712 713 714
                    if (trivia.IsKind(SyntaxKind.WhitespaceTrivia))
                    {
                        lastWhiteSpaceTrivia = trivia;
                    }

715 716 717 718
                    updatedLeadingTrivia.Add(trivia);
                    continue;
                }

C
Cyrus Najmabadi 已提交
719
                if (!(trivia.GetStructure() is DocumentationCommentTriviaSyntax structuredTrivia))
720 721 722 723 724 725 726
                {
                    updatedLeadingTrivia.Add(trivia);
                    continue;
                }

                var updatedNodeList = new List<XmlNodeSyntax>();
                var structuredContent = structuredTrivia.Content.ToList();
C
Cyrus Najmabadi 已提交
727
                for (var i = 0; i < structuredContent.Count; i++)
728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754
                {
                    var content = structuredContent[i];
                    if (!content.IsKind(SyntaxKind.XmlElement))
                    {
                        updatedNodeList.Add(content);
                        continue;
                    }

                    var xmlElement = content as XmlElementSyntax;
                    if (xmlElement.StartTag.Name.ToString() != DocumentationCommentXmlNames.ParameterElementName)
                    {
                        updatedNodeList.Add(content);
                        continue;
                    }

                    // Found a param tag, so insert the next one from the reordered list
                    if (index < permutedParamNodes.Count)
                    {
                        updatedNodeList.Add(permutedParamNodes[index].WithLeadingTrivia(content.GetLeadingTrivia()).WithTrailingTrivia(content.GetTrailingTrivia()));
                        index++;
                    }
                    else
                    {
                        // Inspecting a param element that we are deleting but not replacing.
                    }
                }

I
Ivan Basov 已提交
755 756 757 758
                var newDocComments = SyntaxFactory.DocumentationCommentTrivia(
                    structuredTrivia.Kind(),
                    SyntaxFactory.List(updatedNodeList.AsEnumerable()),
                    structuredTrivia.EndOfComment);
759 760 761 762 763 764
                newDocComments = newDocComments.WithLeadingTrivia(structuredTrivia.GetLeadingTrivia()).WithTrailingTrivia(structuredTrivia.GetTrailingTrivia());
                var newTrivia = SyntaxFactory.Trivia(newDocComments);

                updatedLeadingTrivia.Add(newTrivia);
            }

I
Ivan Basov 已提交
765 766 767
            var extraNodeList = new List<XmlNodeSyntax>();
            while (index < permutedParamNodes.Count)
            {
I
Ivan Basov 已提交
768
                extraNodeList.Add(permutedParamNodes[index]);
I
Ivan Basov 已提交
769 770 771 772 773
                index++;
            }

            if (extraNodeList.Any())
            {
I
Ivan Basov 已提交
774 775 776 777 778 779 780 781 782 783 784
                var extraDocComments = SyntaxFactory.DocumentationCommentTrivia(
                    SyntaxKind.MultiLineDocumentationCommentTrivia,
                    SyntaxFactory.List(extraNodeList.AsEnumerable()),
                    SyntaxFactory.Token(SyntaxKind.EndOfDocumentationCommentToken));
                extraDocComments = extraDocComments
                    .WithLeadingTrivia(SyntaxFactory.DocumentationCommentExterior("/// "))
                    .WithTrailingTrivia(node.GetTrailingTrivia())
                    .WithTrailingTrivia(
                    SyntaxFactory.EndOfLine(document.Project.Solution.Workspace.Options.GetOption(FormattingOptions.NewLine, LanguageNames.CSharp)),
                    lastWhiteSpaceTrivia);

I
Ivan Basov 已提交
785 786 787 788 789
                var newTrivia = SyntaxFactory.Trivia(extraDocComments);

                updatedLeadingTrivia.Add(newTrivia);
            }

790 791 792
            return updatedLeadingTrivia;
        }

793
        public override async Task<ImmutableArray<SymbolAndProjectId>> DetermineCascadedSymbolsFromDelegateInvoke(
D
dotnet-bot 已提交
794 795
            SymbolAndProjectId<IMethodSymbol> symbolAndProjectId,
            Document document,
796
            CancellationToken cancellationToken)
797
        {
798
            var symbol = symbolAndProjectId.Symbol;
799 800 801
            var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
            var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);

802
            var nodes = root.DescendantNodes().ToImmutableArray();
803
            var convertedMethodGroups = nodes
804
                .WhereAsArray(
805
                    n =>
I
Ivan Basov 已提交
806 807 808
                    {
                        if (!n.IsKind(SyntaxKind.IdentifierName) ||
                            !semanticModel.GetMemberGroup(n, cancellationToken).Any())
809
                        {
I
Ivan Basov 已提交
810 811
                            return false;
                        }
812

I
Ivan Basov 已提交
813
                        ISymbol convertedType = semanticModel.GetTypeInfo(n, cancellationToken).ConvertedType;
814

I
Ivan Basov 已提交
815 816 817 818
                        if (convertedType != null)
                        {
                            convertedType = convertedType.OriginalDefinition;
                        }
819

I
Ivan Basov 已提交
820 821 822 823
                        if (convertedType != null)
                        {
                            convertedType = SymbolFinder.FindSourceDefinitionAsync(convertedType, document.Project.Solution, cancellationToken).WaitAndGetResult_CanCallOnBackground(cancellationToken) ?? convertedType;
                        }
824

I
Ivan Basov 已提交
825 826
                        return Equals(convertedType, symbol.ContainingType);
                    })
827
                .SelectAsArray(n => semanticModel.GetSymbolInfo(n, cancellationToken).Symbol);
828

829
            return convertedMethodGroups.SelectAsArray(symbolAndProjectId.WithSymbol);
830 831
        }

832
        protected override IEnumerable<AbstractFormattingRule> GetFormattingRules(Document document)
833
            => SpecializedCollections.SingletonEnumerable<AbstractFormattingRule>(new ChangeSignatureFormattingRule()).Concat(Formatter.GetDefaultFormattingRules(document));
834

I
Ivan Basov 已提交
835 836
        protected override SyntaxToken CreateSeparatorSyntaxToken()
            => SyntaxFactory.Token(SyntaxKind.CommaToken).WithTrailingTrivia(SyntaxFactory.ElasticSpace);
837
    }
S
Sam Harwell 已提交
838
}