CSharpChangeSignatureService.cs 39.0 KB
Newer Older
S
Sam Harwell 已提交
1
// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
2 3 4 5 6 7 8 9 10

using System;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Composition;
using System.Diagnostics;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
11
using Microsoft.CodeAnalysis;
12
using Microsoft.CodeAnalysis.ChangeSignature;
C
Cyrus Najmabadi 已提交
13
using Microsoft.CodeAnalysis.CSharp.Extensions;
14 15 16 17 18 19
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.FindSymbols;
using Microsoft.CodeAnalysis.Formatting;
using Microsoft.CodeAnalysis.Formatting.Rules;
using Microsoft.CodeAnalysis.Host.Mef;
using Microsoft.CodeAnalysis.Shared.Extensions;
I
Ivan Basov 已提交
20
using Microsoft.CodeAnalysis.Utilities;
21 22 23 24 25 26 27
using Roslyn.Utilities;

namespace Microsoft.CodeAnalysis.CSharp.ChangeSignature
{
    [ExportLanguageService(typeof(AbstractChangeSignatureService), LanguageNames.CSharp), Shared]
    internal sealed class CSharpChangeSignatureService : AbstractChangeSignatureService
    {
28 29 30 31 32 33
        private static readonly ImmutableArray<SyntaxKind> _declarationKinds = ImmutableArray.Create(
            SyntaxKind.MethodDeclaration,
            SyntaxKind.ConstructorDeclaration,
            SyntaxKind.IndexerDeclaration,
            SyntaxKind.DelegateDeclaration,
            SyntaxKind.SimpleLambdaExpression,
34 35
            SyntaxKind.ParenthesizedLambdaExpression,
            SyntaxKind.LocalFunctionStatement);
36 37 38

        private static readonly ImmutableArray<SyntaxKind> _declarationAndInvocableKinds =
            _declarationKinds.Concat(ImmutableArray.Create(
39 40 41 42 43 44
                SyntaxKind.InvocationExpression,
                SyntaxKind.ElementAccessExpression,
                SyntaxKind.ThisConstructorInitializer,
                SyntaxKind.BaseConstructorInitializer,
                SyntaxKind.ObjectCreationExpression,
                SyntaxKind.Attribute,
45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62
                SyntaxKind.NameMemberCref));

        private static readonly ImmutableArray<SyntaxKind> _updatableAncestorKinds = ImmutableArray.Create(
            SyntaxKind.ConstructorDeclaration,
            SyntaxKind.IndexerDeclaration,
            SyntaxKind.InvocationExpression,
            SyntaxKind.ElementAccessExpression,
            SyntaxKind.ThisConstructorInitializer,
            SyntaxKind.BaseConstructorInitializer,
            SyntaxKind.ObjectCreationExpression,
            SyntaxKind.Attribute,
            SyntaxKind.DelegateDeclaration,
            SyntaxKind.SimpleLambdaExpression,
            SyntaxKind.ParenthesizedLambdaExpression,
            SyntaxKind.NameMemberCref);

        private static readonly ImmutableArray<SyntaxKind> _updatableNodeKinds = ImmutableArray.Create(
            SyntaxKind.MethodDeclaration,
63
            SyntaxKind.LocalFunctionStatement,
64 65 66 67 68 69 70 71 72 73 74 75 76
            SyntaxKind.ConstructorDeclaration,
            SyntaxKind.IndexerDeclaration,
            SyntaxKind.InvocationExpression,
            SyntaxKind.ElementAccessExpression,
            SyntaxKind.ThisConstructorInitializer,
            SyntaxKind.BaseConstructorInitializer,
            SyntaxKind.ObjectCreationExpression,
            SyntaxKind.Attribute,
            SyntaxKind.DelegateDeclaration,
            SyntaxKind.NameMemberCref,
            SyntaxKind.AnonymousMethodExpression,
            SyntaxKind.ParenthesizedLambdaExpression,
            SyntaxKind.SimpleLambdaExpression);
77

78 79 80 81 82
        [ImportingConstructor]
        public CSharpChangeSignatureService()
        {
        }

I
Ivan Basov 已提交
83
        public override async Task<(ISymbol symbol, int selectedIndex)> GetInvocationSymbolAsync(
84
            Document document, int position, bool restrictToDeclarations, CancellationToken cancellationToken)
85
        {
86
            var tree = await document.GetSyntaxTreeAsync(cancellationToken).ConfigureAwait(false);
87 88 89 90
            var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);

            var token = root.FindToken(position != tree.Length ? position : Math.Max(0, position - 1));

91
            // Allow the user to invoke Change-Sig if they've written:   Goo(a, b, c);$$ 
92 93 94 95 96 97
            if (token.Kind() == SyntaxKind.SemicolonToken && token.Parent is StatementSyntax)
            {
                token = token.GetPreviousToken();
                position = token.Span.End;
            }

98 99
            var matchingNode = GetMatchingNode(token.Parent, restrictToDeclarations);
            if (matchingNode == null)
100
            {
101
                return default;
102
            }
103

104 105
            // Don't show change-signature in the random whitespace/trivia for code.
            if (!matchingNode.Span.IntersectsWith(position))
106
            {
107
                return default;
108 109
            }

110 111 112 113
            // If we're actually on the declaration of some symbol, ensure that we're
            // in a good location for that symbol (i.e. not in the attributes/constraints).
            if (!InSymbolHeader(matchingNode, position))
            {
114
                return default;
115 116
            }

117 118
            var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);
            var symbol = semanticModel.GetDeclaredSymbol(matchingNode, cancellationToken);
119 120
            if (symbol != null)
            {
121
                var selectedIndex = TryGetSelectedIndexFromDeclaration(position, matchingNode);
I
Ivan Basov 已提交
122
                return (symbol, selectedIndex);
123 124 125 126 127 128 129 130
            }

            if (matchingNode.IsKind(SyntaxKind.ObjectCreationExpression))
            {
                var objectCreation = matchingNode as ObjectCreationExpressionSyntax;

                if (token.Parent.AncestorsAndSelf().Any(a => a == objectCreation.Type))
                {
131
                    var typeSymbol = semanticModel.GetSymbolInfo(objectCreation.Type, cancellationToken).Symbol;
I
Ivan Basov 已提交
132

133 134
                    if (typeSymbol != null && typeSymbol.IsKind(SymbolKind.NamedType) && (typeSymbol as ITypeSymbol).TypeKind == TypeKind.Delegate)
                    {
I
Ivan Basov 已提交
135
                        return (typeSymbol, 0);
136 137 138 139 140
                    }
                }
            }

            var symbolInfo = semanticModel.GetSymbolInfo(matchingNode, cancellationToken);
I
Ivan Basov 已提交
141
            return (symbolInfo.Symbol ?? symbolInfo.CandidateSymbols.FirstOrDefault(), 0);
142 143 144 145 146 147
        }

        private static int TryGetSelectedIndexFromDeclaration(int position, SyntaxNode matchingNode)
        {
            var parameters = matchingNode.ChildNodes().OfType<BaseParameterListSyntax>().SingleOrDefault();
            return parameters != null ? GetParameterIndex(parameters.Parameters, position) : 0;
148 149
        }

150 151
        // Find the position to insert the new parameter.
        // We will insert a new comma and a parameter.
I
Ivan Basov 已提交
152
        protected override int? TryGetInsertPositionFromDeclaration(SyntaxNode matchingNode)
153
        {
I
Ivan Basov 已提交
154
            var parameters = matchingNode.ChildNodes().OfType<BaseParameterListSyntax>().SingleOrDefault();
155

156 157
            if (parameters == null)
            {
I
Ivan Basov 已提交
158
                return null;
159
            }
160

I
Ivan Basov 已提交
161 162 163 164 165 166 167 168 169
            switch (parameters)
            {
                case ParameterListSyntax parameterListSyntax:
                    return parameterListSyntax.CloseParenToken.SpanStart;
                case BracketedParameterListSyntax bracketedParameterListSyntax:
                    return bracketedParameterListSyntax.CloseBracketToken.SpanStart;
            }

            return null;
170 171
        }

172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194
        private SyntaxNode GetMatchingNode(SyntaxNode node, bool restrictToDeclarations)
        {
            var matchKinds = restrictToDeclarations
                ? _declarationKinds
                : _declarationAndInvocableKinds;

            for (var current = node; current != null; current = current.Parent)
            {
                if (restrictToDeclarations &&
                    current.Kind() == SyntaxKind.Block || current.Kind() == SyntaxKind.ArrowExpressionClause)
                {
                    return null;
                }

                if (matchKinds.Contains(current.Kind()))
                {
                    return current;
                }
            }

            return null;
        }

195 196 197 198 199 200 201 202
        private bool InSymbolHeader(SyntaxNode matchingNode, int position)
        {
            // Caret has to be after the attributes if the symbol has any.
            var lastAttributes = matchingNode.ChildNodes().LastOrDefault(n => n is AttributeListSyntax);
            var start = lastAttributes?.GetLastToken().GetNextToken().SpanStart ??
                        matchingNode.SpanStart;

            if (position < start)
203
            {
204 205 206 207 208 209 210 211 212 213 214 215 216
                return false;
            }

            // If the symbol has a parameter list, then the caret shouldn't be past the end of it.
            var parameterList = matchingNode.ChildNodes().LastOrDefault(n => n is ParameterListSyntax);
            if (parameterList != null)
            {
                return position <= parameterList.FullSpan.End;
            }

            // Case we haven't handled yet.  Just assume we're in the header.
            return true;
        }
217 218 219

        public override SyntaxNode FindNodeToUpdate(Document document, SyntaxNode node)
        {
220
            if (_updatableNodeKinds.Contains(node.Kind()))
221 222 223 224 225
            {
                return node;
            }

            // TODO: file bug about this: var invocation = csnode.Ancestors().FirstOrDefault(a => a.Kind == SyntaxKind.InvocationExpression);
226
            var matchingNode = node.AncestorsAndSelf().FirstOrDefault(n => _updatableAncestorKinds.Contains(n.Kind()));
227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267
            if (matchingNode == null)
            {
                return null;
            }

            var nodeContainingOriginal = GetNodeContainingTargetNode(matchingNode);
            if (nodeContainingOriginal == null)
            {
                return null;
            }

            return node.AncestorsAndSelf().Any(n => n == nodeContainingOriginal) ? matchingNode : null;
        }

        private SyntaxNode GetNodeContainingTargetNode(SyntaxNode matchingNode)
        {
            switch (matchingNode.Kind())
            {
                case SyntaxKind.InvocationExpression:
                    return (matchingNode as InvocationExpressionSyntax).Expression;

                case SyntaxKind.ElementAccessExpression:
                    return (matchingNode as ElementAccessExpressionSyntax).ArgumentList;

                case SyntaxKind.ObjectCreationExpression:
                    return (matchingNode as ObjectCreationExpressionSyntax).Type;

                case SyntaxKind.ConstructorDeclaration:
                case SyntaxKind.IndexerDeclaration:
                case SyntaxKind.ThisConstructorInitializer:
                case SyntaxKind.BaseConstructorInitializer:
                case SyntaxKind.Attribute:
                case SyntaxKind.DelegateDeclaration:
                case SyntaxKind.NameMemberCref:
                    return matchingNode;

                default:
                    return null;
            }
        }

I
Ivan Basov 已提交
268
        public override async Task<SyntaxNode> ChangeSignatureAsync(
269 270 271 272 273 274 275 276 277 278 279 280 281 282 283
            Document document,
            ISymbol declarationSymbol,
            SyntaxNode potentiallyUpdatedNode,
            SyntaxNode originalNode,
            SignatureChange signaturePermutation,
            CancellationToken cancellationToken)
        {
            var updatedNode = potentiallyUpdatedNode as CSharpSyntaxNode;

            // Update <param> tags.
            if (updatedNode.IsKind(SyntaxKind.MethodDeclaration) ||
                updatedNode.IsKind(SyntaxKind.ConstructorDeclaration) ||
                updatedNode.IsKind(SyntaxKind.IndexerDeclaration) ||
                updatedNode.IsKind(SyntaxKind.DelegateDeclaration))
            {
I
Ivan Basov 已提交
284
                var updatedLeadingTrivia = UpdateParamTagsInLeadingTrivia(document, updatedNode, declarationSymbol, signaturePermutation);
285 286 287 288 289 290 291 292 293
                if (updatedLeadingTrivia != null)
                {
                    updatedNode = updatedNode.WithLeadingTrivia(updatedLeadingTrivia);
                }
            }

            // Update declarations parameter lists
            if (updatedNode.IsKind(SyntaxKind.MethodDeclaration))
            {
294
                var method = (MethodDeclarationSyntax)updatedNode;
I
Ivan Basov 已提交
295
                var updatedParameters = PermuteDeclaration(method.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
296 297 298
                return method.WithParameterList(method.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
299
            if (updatedNode.IsKind(SyntaxKind.LocalFunctionStatement, out LocalFunctionStatementSyntax localFunction))
300 301
            {
                var localFunction = (LocalFunctionStatementSyntax)updatedNode;
I
Ivan Basov 已提交
302
                var updatedParameters = PermuteDeclaration(localFunction.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
303 304 305
                return localFunction.WithParameterList(localFunction.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
306
            if (updatedNode.IsKind(SyntaxKind.ConstructorDeclaration, out ConstructorDeclarationSyntax constructor))
307
            {
308
                var constructor = (ConstructorDeclarationSyntax)updatedNode;
I
Ivan Basov 已提交
309
                var updatedParameters = PermuteDeclaration(constructor.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
310 311 312
                return constructor.WithParameterList(constructor.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
313
            if (updatedNode.IsKind(SyntaxKind.IndexerDeclaration, out IndexerDeclarationSyntax indexer))
314
            {
315
                var indexer = (IndexerDeclarationSyntax)updatedNode;
I
Ivan Basov 已提交
316
                var updatedParameters = PermuteDeclaration(indexer.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
317 318 319
                return indexer.WithParameterList(indexer.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
320
            if (updatedNode.IsKind(SyntaxKind.DelegateDeclaration, out DelegateDeclarationSyntax delegateDeclaration))
321
            {
322
                var delegateDeclaration = (DelegateDeclarationSyntax)updatedNode;
I
Ivan Basov 已提交
323
                var updatedParameters = PermuteDeclaration(delegateDeclaration.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
324 325 326
                return delegateDeclaration.WithParameterList(delegateDeclaration.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
327
            if (updatedNode.IsKind(SyntaxKind.AnonymousMethodExpression, out AnonymousMethodExpressionSyntax anonymousMethod))
328 329 330 331 332 333 334
            {
                // Delegates may omit parameters in C#
                if (anonymousMethod.ParameterList == null)
                {
                    return anonymousMethod;
                }

I
Ivan Basov 已提交
335
                var updatedParameters = PermuteDeclaration(anonymousMethod.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
336 337 338
                return anonymousMethod.WithParameterList(anonymousMethod.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
339
            if (updatedNode.IsKind(SyntaxKind.SimpleLambdaExpression, out SimpleLambdaExpressionSyntax lambda))
340 341 342
            {
                if (signaturePermutation.UpdatedConfiguration.ToListOfParameters().Any())
                {
I
Ivan Basov 已提交
343 344 345 346 347 348
                    var updatedParameters = PermuteDeclaration(SyntaxFactory.SeparatedList<ParameterSyntax>(new[] { lambda.Parameter }), signaturePermutation, CreateNewParameterSyntax);
                    return SyntaxFactory.ParenthesizedLambdaExpression(
                        lambda.AsyncKeyword,
                        SyntaxFactory.ParameterList(updatedParameters),
                        lambda.ArrowToken,
                        lambda.Body);
349 350 351 352 353 354 355 356
                }
                else
                {
                    // No parameters. Change to a parenthesized lambda expression
                    var emptyParameterList = SyntaxFactory.ParameterList()
                        .WithLeadingTrivia(lambda.Parameter.GetLeadingTrivia())
                        .WithTrailingTrivia(lambda.Parameter.GetTrailingTrivia());

357
                    return SyntaxFactory.ParenthesizedLambdaExpression(lambda.AsyncKeyword, emptyParameterList, lambda.ArrowToken, lambda.Body);
358 359 360
                }
            }

C
Cyrus Najmabadi 已提交
361
            if (updatedNode.IsKind(SyntaxKind.ParenthesizedLambdaExpression, out ParenthesizedLambdaExpressionSyntax parenLambda))
362
            {
363
                var lambda = (ParenthesizedLambdaExpressionSyntax)updatedNode;
I
Ivan Basov 已提交
364
                bool doNotSkipParameterType = lambda.ParameterList.Parameters.Any() && lambda.ParameterList.Parameters.First().Type != null;
I
Ivan Basov 已提交
365
                Func<AddedParameter, ParameterSyntax> createNewParameterDelegate =
I
Ivan Basov 已提交
366
                    p => CreateNewParameterSyntax(p, !doNotSkipParameterType);
I
Ivan Basov 已提交
367 368 369 370 371

                var updatedParameters = PermuteDeclaration(
                    lambda.ParameterList.Parameters,
                    signaturePermutation,
                    createNewParameterDelegate);
372 373 374 375 376 377
                return lambda.WithParameterList(lambda.ParameterList.WithParameters(updatedParameters));
            }

            // Update reference site argument lists
            if (updatedNode.IsKind(SyntaxKind.InvocationExpression))
            {
378
                var invocation = (InvocationExpressionSyntax)updatedNode;
I
Ivan Basov 已提交
379
                var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);
380

381
                var symbolInfo = semanticModel.GetSymbolInfo((InvocationExpressionSyntax)originalNode, cancellationToken);
382 383
                var isReducedExtensionMethod = false;

C
Cyrus Najmabadi 已提交
384
                if (symbolInfo.Symbol is IMethodSymbol methodSymbol && methodSymbol.MethodKind == MethodKind.ReducedExtension)
385 386 387 388
                {
                    isReducedExtensionMethod = true;
                }

389 390
                SignatureChange signaturePermutationWithoutAddedParameters = signaturePermutation.WithoutAddedParameters();

I
Ivan Basov 已提交
391
                var newArguments = PermuteArgumentList(declarationSymbol, invocation.ArgumentList.Arguments, signaturePermutationWithoutAddedParameters, isReducedExtensionMethod);
I
Ivan Basov 已提交
392
                newArguments = AddNewArgumentsToList(newArguments, signaturePermutation, isReducedExtensionMethod);
393 394 395
                return invocation.WithArgumentList(invocation.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
396
            if (updatedNode.IsKind(SyntaxKind.ObjectCreationExpression, out ObjectCreationExpressionSyntax objCreation))
397
            {
398
                var objCreation = (ObjectCreationExpressionSyntax)updatedNode;
I
Ivan Basov 已提交
399
                var newArguments = PermuteArgumentList(declarationSymbol, objCreation.ArgumentList.Arguments, signaturePermutation);
400 401 402 403 404 405
                return objCreation.WithArgumentList(objCreation.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.ThisConstructorInitializer) ||
                updatedNode.IsKind(SyntaxKind.BaseConstructorInitializer))
            {
406
                var objCreation = (ConstructorInitializerSyntax)updatedNode;
I
Ivan Basov 已提交
407
                var newArguments = PermuteArgumentList(declarationSymbol, objCreation.ArgumentList.Arguments, signaturePermutation);
408 409 410
                return objCreation.WithArgumentList(objCreation.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
411
            if (updatedNode.IsKind(SyntaxKind.ElementAccessExpression, out ElementAccessExpressionSyntax elementAccess))
412
            {
413
                var elementAccess = (ElementAccessExpressionSyntax)updatedNode;
I
Ivan Basov 已提交
414
                var newArguments = PermuteArgumentList(declarationSymbol, elementAccess.ArgumentList.Arguments, signaturePermutation);
415 416 417
                return elementAccess.WithArgumentList(elementAccess.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

C
Cyrus Najmabadi 已提交
418
            if (updatedNode.IsKind(SyntaxKind.Attribute, out AttributeSyntax attribute))
419
            {
420
                var attribute = (AttributeSyntax)updatedNode;
I
Ivan Basov 已提交
421
                var newArguments = PermuteAttributeArgumentList(declarationSymbol, attribute.ArgumentList.Arguments, signaturePermutation);
422 423 424 425 426 427 428 429 430 431 432 433
                return attribute.WithArgumentList(attribute.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            // Handle references in crefs
            if (updatedNode.IsKind(SyntaxKind.NameMemberCref))
            {
                if (nameMemberCref.Parameters == null ||
                    !nameMemberCref.Parameters.Parameters.Any())
                {
                    return nameMemberCref;
                }

I
Ivan Basov 已提交
434
                var newParameters = PermuteDeclaration(nameMemberCref.Parameters.Parameters, signaturePermutation, CreateNewCrefParameterSyntax);
435 436 437 438 439 440 441 442 443

                var newCrefParameterList = nameMemberCref.Parameters.WithParameters(newParameters);
                return nameMemberCref.WithParameters(newCrefParameterList);
            }

            Debug.Assert(false, "Unknown reference location");
            return null;
        }

444 445
        private SeparatedSyntaxList<ArgumentSyntax> AddNewArgumentsToList(
            SeparatedSyntaxList<ArgumentSyntax> newArguments,
I
Ivan Basov 已提交
446 447
            SignatureChange signaturePermutation,
            bool isReducedExtensionMethod)
448 449
        {
            List<ArgumentSyntax> fullList = new List<ArgumentSyntax>();
450
            List<SyntaxToken> separators = new List<SyntaxToken>();
451 452 453 454 455 456 457 458 459

            var updatedParameters = signaturePermutation.UpdatedConfiguration.ToListOfParameters();

            int indexInExistingList = 0;

            bool seenNameEquals = false;

            for (int i = 0; i < updatedParameters.Count; i++)
            {
I
Ivan Basov 已提交
460 461 462
                // Skip this parameter in list of arguments for extension method calls but not for reduced ones.
                if (updatedParameters[i] != signaturePermutation.UpdatedConfiguration.ThisParameter
                    || !isReducedExtensionMethod)
463
                {
I
Ivan Basov 已提交
464
                    if (updatedParameters[i] is AddedParameter addedParameter)
465
                    {
I
Ivan Basov 已提交
466
                        if (addedParameter.CallSiteValue != null)
I
Ivan Basov 已提交
467 468 469 470
                        {
                            fullList.Add(SyntaxFactory.Argument(
                                seenNameEquals ? SyntaxFactory.NameColon(addedParameter.Name) : default,
                                refKindKeyword: default,
I
Ivan Basov 已提交
471
                                expression: SyntaxFactory.ParseExpression(addedParameter.CallSiteValue)));
I
Ivan Basov 已提交
472
                            separators.Add(SyntaxFactory.Token(SyntaxKind.CommaToken).WithTrailingTrivia(SyntaxFactory.ElasticSpace));
I
Ivan Basov 已提交
473
                        }
474
                    }
I
Ivan Basov 已提交
475
                    else
476
                    {
I
Ivan Basov 已提交
477
                        if (indexInExistingList < newArguments.Count)
I
Ivan Basov 已提交
478
                        {
I
Ivan Basov 已提交
479 480 481 482
                            if (newArguments[indexInExistingList].NameColon != default)
                            {
                                seenNameEquals = true;
                            }
483

I
Ivan Basov 已提交
484 485 486 487
                            if (indexInExistingList < newArguments.SeparatorCount)
                            {
                                separators.Add(newArguments.GetSeparator(indexInExistingList));
                            }
488

I
Ivan Basov 已提交
489 490
                            fullList.Add(newArguments[indexInExistingList++]);
                        }
I
Ivan Basov 已提交
491
                    }
492 493 494
                }
            }

495 496 497 498 499 500 501 502 503 504 505
            // Add the rest of existing parameters, e.g. from the params argument.
            while (indexInExistingList < newArguments.Count)
            {
                if (indexInExistingList < newArguments.SeparatorCount)
                {
                    separators.Add(newArguments.GetSeparator(indexInExistingList));
                }

                fullList.Add(newArguments[indexInExistingList++]);
            }

I
Ivan Basov 已提交
506 507 508 509 510
            if (fullList.Count == separators.Count && separators.Count != 0)
            {
                separators.Remove(separators.Last());
            }

511
            return SyntaxFactory.SeparatedList(fullList, separators);
512 513
        }

I
Ivan Basov 已提交
514
        private static ParameterSyntax CreateNewParameterSyntax(AddedParameter addedParameter)
I
Ivan Basov 已提交
515
            => CreateNewParameterSyntax(addedParameter, skipParameterType: false);
I
Ivan Basov 已提交
516

I
Ivan Basov 已提交
517
        private static ParameterSyntax CreateNewParameterSyntax(AddedParameter addedParameter, bool skipParameterType)
I
Ivan Basov 已提交
518 519 520
            => SyntaxFactory.Parameter(
                attributeLists: SyntaxFactory.List<AttributeListSyntax>(),
                modifiers: SyntaxFactory.TokenList(),
I
Ivan Basov 已提交
521
                type: skipParameterType ? default : SyntaxFactory.ParseTypeName(addedParameter.TypeName).WithTrailingTrivia(SyntaxFactory.ElasticSpace),
I
Ivan Basov 已提交
522 523
                SyntaxFactory.Identifier(addedParameter.ParameterName),
                @default: default);
I
Ivan Basov 已提交
524

I
Ivan Basov 已提交
525 526
        private static CrefParameterSyntax CreateNewCrefParameterSyntax(AddedParameter addedParameter)
            => SyntaxFactory.CrefParameter(type: SyntaxFactory.ParseTypeName(addedParameter.TypeName)).WithLeadingTrivia(SyntaxFactory.ElasticSpace);
I
Ivan Basov 已提交
527 528

        private SeparatedSyntaxList<T> PermuteDeclaration<T>(
I
Ivan Basov 已提交
529
            SeparatedSyntaxList<T> list,
I
Ivan Basov 已提交
530 531
            SignatureChange updatedSignature,
            Func<AddedParameter, T> createNewParameterMethod) where T : SyntaxNode
532
        {
533
            var permuteDeclarationBase = base.PermuteDeclarationBase<T>(list, updatedSignature, createNewParameterMethod);
534
            return SyntaxFactory.SeparatedList(permuteDeclarationBase.parameters, permuteDeclarationBase.separators);
535 536
        }

537
        protected override T TransferLeadingWhitespaceTrivia<T>(T newArgument, SyntaxNode oldArgument)
538 539 540 541 542 543 544 545 546
        {
            var oldTrivia = oldArgument.GetLeadingTrivia();
            var oldOnlyHasWhitespaceTrivia = oldTrivia.All(t => t.IsKind(SyntaxKind.WhitespaceTrivia));

            var newTrivia = newArgument.GetLeadingTrivia();
            var newOnlyHasWhitespaceTrivia = newTrivia.All(t => t.IsKind(SyntaxKind.WhitespaceTrivia));

            if (oldOnlyHasWhitespaceTrivia && newOnlyHasWhitespaceTrivia)
            {
547
                newArgument = newArgument.WithLeadingTrivia(oldTrivia);
548 549 550 551 552
            }

            return newArgument;
        }

553
        private SeparatedSyntaxList<AttributeArgumentSyntax> PermuteAttributeArgumentList(
554 555 556 557
            ISymbol declarationSymbol,
            SeparatedSyntaxList<AttributeArgumentSyntax> arguments,
            SignatureChange updatedSignature)
        {
I
Ivan Basov 已提交
558 559
            var newArguments = PermuteArguments(declarationSymbol, arguments.Select(a => UnifiedArgumentSyntax.Create(a)).ToList(),
                updatedSignature,
A
Allison Chou 已提交
560
                callSiteValue => UnifiedArgumentSyntax.Create(SyntaxFactory.AttributeArgument(SyntaxFactory.ParseExpression(callSiteValue))));
561
            var numSeparatorsToSkip = arguments.Count - newArguments.Count;
562 563

            // copy whitespace trivia from original position
564 565
            var newArgumentsWithTrivia = TransferLeadingWhitespaceTrivia(
                newArguments.Select(a => (AttributeArgumentSyntax)(UnifiedArgumentSyntax)a), arguments);
566 567

            return SyntaxFactory.SeparatedList(newArgumentsWithTrivia, GetSeparators(arguments, numSeparatorsToSkip));
568 569
        }

570
        private SeparatedSyntaxList<ArgumentSyntax> PermuteArgumentList(
571 572 573 574 575
            ISymbol declarationSymbol,
            SeparatedSyntaxList<ArgumentSyntax> arguments,
            SignatureChange updatedSignature,
            bool isReducedExtensionMethod = false)
        {
I
Ivan Basov 已提交
576 577 578
            var newArguments = PermuteArguments(
                declarationSymbol,
                arguments.Select(a => UnifiedArgumentSyntax.Create(a)).ToList(),
I
Ivan Basov 已提交
579
                updatedSignature,
I
Ivan Basov 已提交
580 581
                callSiteValue => UnifiedArgumentSyntax.Create(SyntaxFactory.Argument(SyntaxFactory.ParseExpression(callSiteValue))),
                isReducedExtensionMethod);
582

583 584 585
            // copy whitespace trivia from original position
            var newArgumentsWithTrivia = TransferLeadingWhitespaceTrivia(
                newArguments.Select(a => (ArgumentSyntax)(UnifiedArgumentSyntax)a), arguments);
586

587
            var numSeparatorsToSkip = arguments.Count - newArguments.Count;
588 589 590
            return SyntaxFactory.SeparatedList(newArgumentsWithTrivia, GetSeparators(arguments, numSeparatorsToSkip));
        }

591
        private List<T> TransferLeadingWhitespaceTrivia<T, U>(IEnumerable<T> newArguments, SeparatedSyntaxList<U> oldArguments)
592 593 594 595
            where T : SyntaxNode
            where U : SyntaxNode
        {
            var result = new List<T>();
596
            var index = 0;
597 598
            foreach (var newArgument in newArguments)
            {
I
Ivan Basov 已提交
599 600 601 602 603 604 605 606 607
                if (index < oldArguments.Count)
                {
                    result.Add(TransferLeadingWhitespaceTrivia(newArgument, oldArguments[index]));
                }
                else
                {
                    result.Add(newArgument);
                }

608 609 610 611
                index++;
            }

            return result;
612 613
        }

I
Ivan Basov 已提交
614
        private List<SyntaxTrivia> UpdateParamTagsInLeadingTrivia(Document document, CSharpSyntaxNode node, ISymbol declarationSymbol, SignatureChange updatedSignature)
615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631
        {
            if (!node.HasLeadingTrivia)
            {
                return null;
            }

            var paramNodes = node
                .DescendantNodes(descendIntoTrivia: true)
                .OfType<XmlElementSyntax>()
                .Where(e => e.StartTag.Name.ToString() == DocumentationCommentXmlNames.ParameterElementName);

            var permutedParamNodes = VerifyAndPermuteParamNodes(paramNodes, declarationSymbol, updatedSignature);
            if (permutedParamNodes == null)
            {
                return null;
            }

I
Ivan Basov 已提交
632
            return GetPermutedTrivia(document, node, permutedParamNodes);
633 634 635 636 637 638 639 640 641
        }

        private List<XmlElementSyntax> VerifyAndPermuteParamNodes(IEnumerable<XmlElementSyntax> paramNodes, ISymbol declarationSymbol, SignatureChange updatedSignature)
        {
            // Only reorder if count and order match originally.
            var originalParameters = updatedSignature.OriginalConfiguration.ToListOfParameters();
            var reorderedParameters = updatedSignature.UpdatedConfiguration.ToListOfParameters();

            var declaredParameters = declarationSymbol.GetParameters();
642
            if (paramNodes.Count() != declaredParameters.Length)
643 644 645 646
            {
                return null;
            }

647 648 649 650 651
            if (declaredParameters.Length == 0)
            {
                return null;
            }

652
            var dictionary = new Dictionary<string, XmlElementSyntax>();
653
            var i = 0;
C
Charles Stoner 已提交
654
            foreach (var paramNode in paramNodes)
655 656 657 658 659 660 661 662 663 664 665 666 667
            {
                var nameAttribute = paramNode.StartTag.Attributes.FirstOrDefault(a => a.Name.ToString().Equals("name", StringComparison.OrdinalIgnoreCase));
                if (nameAttribute == null)
                {
                    return null;
                }

                var identifier = nameAttribute.DescendantNodes(descendIntoTrivia: true).OfType<IdentifierNameSyntax>().FirstOrDefault();
                if (identifier == null || identifier.ToString() != declaredParameters.ElementAt(i).Name)
                {
                    return null;
                }

C
Charles Stoner 已提交
668 669
                dictionary.Add(originalParameters[i].Name.ToString(), paramNode);
                i++;
670 671 672 673 674 675
            }

            // Everything lines up, so permute them.
            var permutedParams = new List<XmlElementSyntax>();
            foreach (var parameter in reorderedParameters)
            {
I
Ivan Basov 已提交
676 677 678 679 680 681 682 683 684 685 686 687
                if (dictionary.TryGetValue(parameter.Name, out var permutedParam))
                {
                    permutedParams.Add(permutedParam);
                }
                else
                {
                    permutedParams.Add(SyntaxFactory.XmlElement(
                        SyntaxFactory.XmlElementStartTag(
                            SyntaxFactory.XmlName("param"),
                            SyntaxFactory.List<XmlAttributeSyntax>(new[] { SyntaxFactory.XmlNameAttribute(parameter.Name) })),
                        SyntaxFactory.XmlElementEndTag(SyntaxFactory.XmlName("param"))));
                }
688 689 690 691 692
            }

            return permutedParams;
        }

I
Ivan Basov 已提交
693
        private List<SyntaxTrivia> GetPermutedTrivia(Document document, CSharpSyntaxNode node, List<XmlElementSyntax> permutedParamNodes)
694 695 696
        {
            var updatedLeadingTrivia = new List<SyntaxTrivia>();
            var index = 0;
I
Ivan Basov 已提交
697 698 699 700 701
            SyntaxTrivia lastWhiteSpaceTrivia = default;

            var lastDocumentationCommentTriviaSyntax = node.GetLeadingTrivia()
                .LastOrDefault(t => t.HasStructure && t.GetStructure() is DocumentationCommentTriviaSyntax);
            DocumentationCommentTriviaSyntax documentationCommeStructuredTrivia = lastDocumentationCommentTriviaSyntax.GetStructure() as DocumentationCommentTriviaSyntax;
702 703 704 705 706

            foreach (var trivia in node.GetLeadingTrivia())
            {
                if (!trivia.HasStructure)
                {
I
Ivan Basov 已提交
707 708 709 710 711
                    if (trivia.IsKind(SyntaxKind.WhitespaceTrivia))
                    {
                        lastWhiteSpaceTrivia = trivia;
                    }

712 713 714 715
                    updatedLeadingTrivia.Add(trivia);
                    continue;
                }

C
Cyrus Najmabadi 已提交
716
                if (!(trivia.GetStructure() is DocumentationCommentTriviaSyntax structuredTrivia))
717 718 719 720 721 722 723
                {
                    updatedLeadingTrivia.Add(trivia);
                    continue;
                }

                var updatedNodeList = new List<XmlNodeSyntax>();
                var structuredContent = structuredTrivia.Content.ToList();
C
Cyrus Najmabadi 已提交
724
                for (var i = 0; i < structuredContent.Count; i++)
725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751
                {
                    var content = structuredContent[i];
                    if (!content.IsKind(SyntaxKind.XmlElement))
                    {
                        updatedNodeList.Add(content);
                        continue;
                    }

                    var xmlElement = content as XmlElementSyntax;
                    if (xmlElement.StartTag.Name.ToString() != DocumentationCommentXmlNames.ParameterElementName)
                    {
                        updatedNodeList.Add(content);
                        continue;
                    }

                    // Found a param tag, so insert the next one from the reordered list
                    if (index < permutedParamNodes.Count)
                    {
                        updatedNodeList.Add(permutedParamNodes[index].WithLeadingTrivia(content.GetLeadingTrivia()).WithTrailingTrivia(content.GetTrailingTrivia()));
                        index++;
                    }
                    else
                    {
                        // Inspecting a param element that we are deleting but not replacing.
                    }
                }

I
Ivan Basov 已提交
752 753 754 755
                var newDocComments = SyntaxFactory.DocumentationCommentTrivia(
                    structuredTrivia.Kind(),
                    SyntaxFactory.List(updatedNodeList.AsEnumerable()),
                    structuredTrivia.EndOfComment);
756 757 758 759 760 761
                newDocComments = newDocComments.WithLeadingTrivia(structuredTrivia.GetLeadingTrivia()).WithTrailingTrivia(structuredTrivia.GetTrailingTrivia());
                var newTrivia = SyntaxFactory.Trivia(newDocComments);

                updatedLeadingTrivia.Add(newTrivia);
            }

I
Ivan Basov 已提交
762 763 764
            var extraNodeList = new List<XmlNodeSyntax>();
            while (index < permutedParamNodes.Count)
            {
I
Ivan Basov 已提交
765
                extraNodeList.Add(permutedParamNodes[index]);
I
Ivan Basov 已提交
766 767 768 769 770
                index++;
            }

            if (extraNodeList.Any())
            {
I
Ivan Basov 已提交
771 772 773 774 775 776 777 778 779 780 781
                var extraDocComments = SyntaxFactory.DocumentationCommentTrivia(
                    SyntaxKind.MultiLineDocumentationCommentTrivia,
                    SyntaxFactory.List(extraNodeList.AsEnumerable()),
                    SyntaxFactory.Token(SyntaxKind.EndOfDocumentationCommentToken));
                extraDocComments = extraDocComments
                    .WithLeadingTrivia(SyntaxFactory.DocumentationCommentExterior("/// "))
                    .WithTrailingTrivia(node.GetTrailingTrivia())
                    .WithTrailingTrivia(
                    SyntaxFactory.EndOfLine(document.Project.Solution.Workspace.Options.GetOption(FormattingOptions.NewLine, LanguageNames.CSharp)),
                    lastWhiteSpaceTrivia);

I
Ivan Basov 已提交
782 783 784 785 786
                var newTrivia = SyntaxFactory.Trivia(extraDocComments);

                updatedLeadingTrivia.Add(newTrivia);
            }

787 788 789
            return updatedLeadingTrivia;
        }

790
        public override async Task<ImmutableArray<SymbolAndProjectId>> DetermineCascadedSymbolsFromDelegateInvoke(
D
dotnet-bot 已提交
791 792
            SymbolAndProjectId<IMethodSymbol> symbolAndProjectId,
            Document document,
793
            CancellationToken cancellationToken)
794
        {
795
            var symbol = symbolAndProjectId.Symbol;
796 797 798
            var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
            var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);

799
            var nodes = root.DescendantNodes().ToImmutableArray();
800
            var convertedMethodGroups = nodes
801
                .WhereAsArray(
802
                    n =>
I
Ivan Basov 已提交
803 804 805
                    {
                        if (!n.IsKind(SyntaxKind.IdentifierName) ||
                            !semanticModel.GetMemberGroup(n, cancellationToken).Any())
806
                        {
I
Ivan Basov 已提交
807 808
                            return false;
                        }
809

I
Ivan Basov 已提交
810
                        ISymbol convertedType = semanticModel.GetTypeInfo(n, cancellationToken).ConvertedType;
811

I
Ivan Basov 已提交
812 813 814 815
                        if (convertedType != null)
                        {
                            convertedType = convertedType.OriginalDefinition;
                        }
816

I
Ivan Basov 已提交
817 818 819 820
                        if (convertedType != null)
                        {
                            convertedType = SymbolFinder.FindSourceDefinitionAsync(convertedType, document.Project.Solution, cancellationToken).WaitAndGetResult_CanCallOnBackground(cancellationToken) ?? convertedType;
                        }
821

I
Ivan Basov 已提交
822 823
                        return Equals(convertedType, symbol.ContainingType);
                    })
824
                .SelectAsArray(n => semanticModel.GetSymbolInfo(n, cancellationToken).Symbol);
825

826
            return convertedMethodGroups.SelectAsArray(symbolAndProjectId.WithSymbol);
827 828
        }

829
        protected override IEnumerable<AbstractFormattingRule> GetFormattingRules(Document document)
830
            => SpecializedCollections.SingletonEnumerable<AbstractFormattingRule>(new ChangeSignatureFormattingRule()).Concat(Formatter.GetDefaultFormattingRules(document));
831

I
Ivan Basov 已提交
832 833
        protected override SyntaxToken CreateSeparatorSyntaxToken()
            => SyntaxFactory.Token(SyntaxKind.CommaToken).WithTrailingTrivia(SyntaxFactory.ElasticSpace);
834
    }
S
Sam Harwell 已提交
835
}