CSharpChangeSignatureService.cs 39.5 KB
Newer Older
S
Sam Harwell 已提交
1
// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
2 3 4 5 6 7 8 9 10

using System;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Composition;
using System.Diagnostics;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
11
using Microsoft.CodeAnalysis;
12 13 14 15 16 17 18
using Microsoft.CodeAnalysis.ChangeSignature;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.FindSymbols;
using Microsoft.CodeAnalysis.Formatting;
using Microsoft.CodeAnalysis.Formatting.Rules;
using Microsoft.CodeAnalysis.Host.Mef;
using Microsoft.CodeAnalysis.Shared.Extensions;
I
Ivan Basov 已提交
19
using Microsoft.CodeAnalysis.Utilities;
20 21 22 23 24 25 26
using Roslyn.Utilities;

namespace Microsoft.CodeAnalysis.CSharp.ChangeSignature
{
    [ExportLanguageService(typeof(AbstractChangeSignatureService), LanguageNames.CSharp), Shared]
    internal sealed class CSharpChangeSignatureService : AbstractChangeSignatureService
    {
27 28 29 30 31 32
        private static readonly ImmutableArray<SyntaxKind> _declarationKinds = ImmutableArray.Create(
            SyntaxKind.MethodDeclaration,
            SyntaxKind.ConstructorDeclaration,
            SyntaxKind.IndexerDeclaration,
            SyntaxKind.DelegateDeclaration,
            SyntaxKind.SimpleLambdaExpression,
33 34
            SyntaxKind.ParenthesizedLambdaExpression,
            SyntaxKind.LocalFunctionStatement);
35 36 37

        private static readonly ImmutableArray<SyntaxKind> _declarationAndInvocableKinds =
            _declarationKinds.Concat(ImmutableArray.Create(
38 39 40 41 42 43
                SyntaxKind.InvocationExpression,
                SyntaxKind.ElementAccessExpression,
                SyntaxKind.ThisConstructorInitializer,
                SyntaxKind.BaseConstructorInitializer,
                SyntaxKind.ObjectCreationExpression,
                SyntaxKind.Attribute,
44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61
                SyntaxKind.NameMemberCref));

        private static readonly ImmutableArray<SyntaxKind> _updatableAncestorKinds = ImmutableArray.Create(
            SyntaxKind.ConstructorDeclaration,
            SyntaxKind.IndexerDeclaration,
            SyntaxKind.InvocationExpression,
            SyntaxKind.ElementAccessExpression,
            SyntaxKind.ThisConstructorInitializer,
            SyntaxKind.BaseConstructorInitializer,
            SyntaxKind.ObjectCreationExpression,
            SyntaxKind.Attribute,
            SyntaxKind.DelegateDeclaration,
            SyntaxKind.SimpleLambdaExpression,
            SyntaxKind.ParenthesizedLambdaExpression,
            SyntaxKind.NameMemberCref);

        private static readonly ImmutableArray<SyntaxKind> _updatableNodeKinds = ImmutableArray.Create(
            SyntaxKind.MethodDeclaration,
62
            SyntaxKind.LocalFunctionStatement,
63 64 65 66 67 68 69 70 71 72 73 74 75
            SyntaxKind.ConstructorDeclaration,
            SyntaxKind.IndexerDeclaration,
            SyntaxKind.InvocationExpression,
            SyntaxKind.ElementAccessExpression,
            SyntaxKind.ThisConstructorInitializer,
            SyntaxKind.BaseConstructorInitializer,
            SyntaxKind.ObjectCreationExpression,
            SyntaxKind.Attribute,
            SyntaxKind.DelegateDeclaration,
            SyntaxKind.NameMemberCref,
            SyntaxKind.AnonymousMethodExpression,
            SyntaxKind.ParenthesizedLambdaExpression,
            SyntaxKind.SimpleLambdaExpression);
76

77 78 79 80 81
        [ImportingConstructor]
        public CSharpChangeSignatureService()
        {
        }

82
        public override async Task<(ISymbol symbol, int selectedIndex, int insertPosition)> GetInvocationSymbolAsync(
83
            Document document, int position, bool restrictToDeclarations, CancellationToken cancellationToken)
84
        {
85
            var tree = await document.GetSyntaxTreeAsync(cancellationToken).ConfigureAwait(false);
86 87 88 89
            var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);

            var token = root.FindToken(position != tree.Length ? position : Math.Max(0, position - 1));

90
            // Allow the user to invoke Change-Sig if they've written:   Goo(a, b, c);$$ 
91 92 93 94 95 96
            if (token.Kind() == SyntaxKind.SemicolonToken && token.Parent is StatementSyntax)
            {
                token = token.GetPreviousToken();
                position = token.Span.End;
            }

97 98
            var matchingNode = GetMatchingNode(token.Parent, restrictToDeclarations);
            if (matchingNode == null)
99
            {
100
                return default;
101
            }
102

103 104
            // Don't show change-signature in the random whitespace/trivia for code.
            if (!matchingNode.Span.IntersectsWith(position))
105
            {
106
                return default;
107 108
            }

109 110 111 112
            // If we're actually on the declaration of some symbol, ensure that we're
            // in a good location for that symbol (i.e. not in the attributes/constraints).
            if (!InSymbolHeader(matchingNode, position))
            {
113
                return default;
114 115
            }

I
Ivan Basov 已提交
116 117 118 119 120 121 122 123
            int? insertPositionOpt = TryGetInsertPositionFromDeclaration(matchingNode);
            if (insertPositionOpt == null)
            {
                return default;
            }

            int insertPosition = insertPositionOpt.Value;

124 125
            var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);
            var symbol = semanticModel.GetDeclaredSymbol(matchingNode, cancellationToken);
126 127
            if (symbol != null)
            {
128
                var selectedIndex = TryGetSelectedIndexFromDeclaration(position, matchingNode);
129
                return (symbol, selectedIndex, insertPosition);
130 131 132 133 134 135 136 137
            }

            if (matchingNode.IsKind(SyntaxKind.ObjectCreationExpression))
            {
                var objectCreation = matchingNode as ObjectCreationExpressionSyntax;

                if (token.Parent.AncestorsAndSelf().Any(a => a == objectCreation.Type))
                {
138
                    var typeSymbol = semanticModel.GetSymbolInfo(objectCreation.Type, cancellationToken).Symbol;
139 140
                    if (typeSymbol != null && typeSymbol.IsKind(SymbolKind.NamedType) && (typeSymbol as ITypeSymbol).TypeKind == TypeKind.Delegate)
                    {
141
                        return (typeSymbol, 0, insertPosition);
142 143 144 145 146
                    }
                }
            }

            var symbolInfo = semanticModel.GetSymbolInfo(matchingNode, cancellationToken);
147
            return (symbolInfo.Symbol ?? symbolInfo.CandidateSymbols.FirstOrDefault(), 0, insertPosition);
148 149 150 151 152 153
        }

        private static int TryGetSelectedIndexFromDeclaration(int position, SyntaxNode matchingNode)
        {
            var parameters = matchingNode.ChildNodes().OfType<BaseParameterListSyntax>().SingleOrDefault();
            return parameters != null ? GetParameterIndex(parameters.Parameters, position) : 0;
154 155
        }

156 157
        // Find the position to insert the new parameter.
        // We will insert a new comma and a parameter.
I
Ivan Basov 已提交
158
        private static int? TryGetInsertPositionFromDeclaration(SyntaxNode matchingNode)
159 160
        {
            var parameters = matchingNode.ChildNodes().OfType<ParameterListSyntax>().SingleOrDefault();
161

162 163
            if (parameters == null)
            {
I
Ivan Basov 已提交
164
                return null;
165
            }
166 167 168 169

            if (parameters.Parameters.Count > 0 &&
                parameters.Parameters.Last().Modifiers.Any(SyntaxKind.ParamsKeyword))
            {
170 171 172 173 174 175 176 177 178 179 180 181
                if (parameters.Parameters.Count == 1)
                {
                    // (params a)
                    // (<new parameter> new comma ->, params a)
                    return parameters.OpenParenToken.SpanStart + 1;
                }
                else
                {
                    // (a, b, c, d put here ->, params e)
                    // (a, b, c, d,<- new comma <new parameter>, params e)
                    return parameters.Parameters.GetSeparators().Last().SpanStart;
                }
182 183 184 185 186 187 188 189
            }

            // ( put here->)
            // (,<- new comma for intellisense <new parameter>)
            //
            // (a, b, c, d put here->)
            // (a, b, c, d,<- new comma <new parameter>)
            return parameters.CloseParenToken.SpanStart;
190 191
        }

192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214
        private SyntaxNode GetMatchingNode(SyntaxNode node, bool restrictToDeclarations)
        {
            var matchKinds = restrictToDeclarations
                ? _declarationKinds
                : _declarationAndInvocableKinds;

            for (var current = node; current != null; current = current.Parent)
            {
                if (restrictToDeclarations &&
                    current.Kind() == SyntaxKind.Block || current.Kind() == SyntaxKind.ArrowExpressionClause)
                {
                    return null;
                }

                if (matchKinds.Contains(current.Kind()))
                {
                    return current;
                }
            }

            return null;
        }

215 216 217 218 219 220 221 222
        private bool InSymbolHeader(SyntaxNode matchingNode, int position)
        {
            // Caret has to be after the attributes if the symbol has any.
            var lastAttributes = matchingNode.ChildNodes().LastOrDefault(n => n is AttributeListSyntax);
            var start = lastAttributes?.GetLastToken().GetNextToken().SpanStart ??
                        matchingNode.SpanStart;

            if (position < start)
223
            {
224 225 226 227 228 229 230 231 232 233 234 235 236
                return false;
            }

            // If the symbol has a parameter list, then the caret shouldn't be past the end of it.
            var parameterList = matchingNode.ChildNodes().LastOrDefault(n => n is ParameterListSyntax);
            if (parameterList != null)
            {
                return position <= parameterList.FullSpan.End;
            }

            // Case we haven't handled yet.  Just assume we're in the header.
            return true;
        }
237 238 239

        public override SyntaxNode FindNodeToUpdate(Document document, SyntaxNode node)
        {
240
            if (_updatableNodeKinds.Contains(node.Kind()))
241 242 243 244 245
            {
                return node;
            }

            // TODO: file bug about this: var invocation = csnode.Ancestors().FirstOrDefault(a => a.Kind == SyntaxKind.InvocationExpression);
246
            var matchingNode = node.AncestorsAndSelf().FirstOrDefault(n => _updatableAncestorKinds.Contains(n.Kind()));
247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287
            if (matchingNode == null)
            {
                return null;
            }

            var nodeContainingOriginal = GetNodeContainingTargetNode(matchingNode);
            if (nodeContainingOriginal == null)
            {
                return null;
            }

            return node.AncestorsAndSelf().Any(n => n == nodeContainingOriginal) ? matchingNode : null;
        }

        private SyntaxNode GetNodeContainingTargetNode(SyntaxNode matchingNode)
        {
            switch (matchingNode.Kind())
            {
                case SyntaxKind.InvocationExpression:
                    return (matchingNode as InvocationExpressionSyntax).Expression;

                case SyntaxKind.ElementAccessExpression:
                    return (matchingNode as ElementAccessExpressionSyntax).ArgumentList;

                case SyntaxKind.ObjectCreationExpression:
                    return (matchingNode as ObjectCreationExpressionSyntax).Type;

                case SyntaxKind.ConstructorDeclaration:
                case SyntaxKind.IndexerDeclaration:
                case SyntaxKind.ThisConstructorInitializer:
                case SyntaxKind.BaseConstructorInitializer:
                case SyntaxKind.Attribute:
                case SyntaxKind.DelegateDeclaration:
                case SyntaxKind.NameMemberCref:
                    return matchingNode;

                default:
                    return null;
            }
        }

I
Ivan Basov 已提交
288
        public override async Task<SyntaxNode> ChangeSignatureAsync(
289 290 291 292 293 294 295 296 297 298 299 300 301 302 303
            Document document,
            ISymbol declarationSymbol,
            SyntaxNode potentiallyUpdatedNode,
            SyntaxNode originalNode,
            SignatureChange signaturePermutation,
            CancellationToken cancellationToken)
        {
            var updatedNode = potentiallyUpdatedNode as CSharpSyntaxNode;

            // Update <param> tags.
            if (updatedNode.IsKind(SyntaxKind.MethodDeclaration) ||
                updatedNode.IsKind(SyntaxKind.ConstructorDeclaration) ||
                updatedNode.IsKind(SyntaxKind.IndexerDeclaration) ||
                updatedNode.IsKind(SyntaxKind.DelegateDeclaration))
            {
I
Ivan Basov 已提交
304
                var updatedLeadingTrivia = UpdateParamTagsInLeadingTrivia(document, updatedNode, declarationSymbol, signaturePermutation);
305 306 307 308 309 310 311 312 313
                if (updatedLeadingTrivia != null)
                {
                    updatedNode = updatedNode.WithLeadingTrivia(updatedLeadingTrivia);
                }
            }

            // Update declarations parameter lists
            if (updatedNode.IsKind(SyntaxKind.MethodDeclaration))
            {
314
                var method = (MethodDeclarationSyntax)updatedNode;
I
Ivan Basov 已提交
315
                var updatedParameters = PermuteDeclaration(method.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
316 317 318
                return method.WithParameterList(method.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

319 320 321
            if (updatedNode.IsKind(SyntaxKind.LocalFunctionStatement))
            {
                var localFunction = (LocalFunctionStatementSyntax)updatedNode;
I
Ivan Basov 已提交
322
                var updatedParameters = PermuteDeclaration(localFunction.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
323 324 325
                return localFunction.WithParameterList(localFunction.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

326 327
            if (updatedNode.IsKind(SyntaxKind.ConstructorDeclaration))
            {
328
                var constructor = (ConstructorDeclarationSyntax)updatedNode;
I
Ivan Basov 已提交
329
                var updatedParameters = PermuteDeclaration(constructor.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
330 331 332 333 334
                return constructor.WithParameterList(constructor.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.IndexerDeclaration))
            {
335
                var indexer = (IndexerDeclarationSyntax)updatedNode;
I
Ivan Basov 已提交
336
                var updatedParameters = PermuteDeclaration(indexer.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
337 338 339 340 341
                return indexer.WithParameterList(indexer.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.DelegateDeclaration))
            {
342
                var delegateDeclaration = (DelegateDeclarationSyntax)updatedNode;
I
Ivan Basov 已提交
343
                var updatedParameters = PermuteDeclaration(delegateDeclaration.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
344 345 346 347 348
                return delegateDeclaration.WithParameterList(delegateDeclaration.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.AnonymousMethodExpression))
            {
349
                var anonymousMethod = (AnonymousMethodExpressionSyntax)updatedNode;
350 351 352 353 354 355 356

                // Delegates may omit parameters in C#
                if (anonymousMethod.ParameterList == null)
                {
                    return anonymousMethod;
                }

I
Ivan Basov 已提交
357
                var updatedParameters = PermuteDeclaration(anonymousMethod.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
358 359 360 361 362
                return anonymousMethod.WithParameterList(anonymousMethod.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.SimpleLambdaExpression))
            {
363
                var lambda = (SimpleLambdaExpressionSyntax)updatedNode;
364 365 366

                if (signaturePermutation.UpdatedConfiguration.ToListOfParameters().Any())
                {
I
Ivan Basov 已提交
367 368 369 370 371 372
                    var updatedParameters = PermuteDeclaration(SyntaxFactory.SeparatedList<ParameterSyntax>(new[] { lambda.Parameter }), signaturePermutation, CreateNewParameterSyntax);
                    return SyntaxFactory.ParenthesizedLambdaExpression(
                        lambda.AsyncKeyword,
                        SyntaxFactory.ParameterList(updatedParameters),
                        lambda.ArrowToken,
                        lambda.Body);
373 374 375 376 377 378 379 380
                }
                else
                {
                    // No parameters. Change to a parenthesized lambda expression
                    var emptyParameterList = SyntaxFactory.ParameterList()
                        .WithLeadingTrivia(lambda.Parameter.GetLeadingTrivia())
                        .WithTrailingTrivia(lambda.Parameter.GetTrailingTrivia());

381
                    return SyntaxFactory.ParenthesizedLambdaExpression(lambda.AsyncKeyword, emptyParameterList, lambda.ArrowToken, lambda.Body);
382 383 384 385 386
                }
            }

            if (updatedNode.IsKind(SyntaxKind.ParenthesizedLambdaExpression))
            {
387
                var lambda = (ParenthesizedLambdaExpressionSyntax)updatedNode;
I
Ivan Basov 已提交
388 389 390 391 392 393 394 395
                bool doNotSkipType = lambda.ParameterList.Parameters.Any() && lambda.ParameterList.Parameters.First().Type != null;
                Func<AddedParameter, ParameterSyntax> createNewParameterDelegate =
                    p => CreateNewParameterSyntax(p, !doNotSkipType);

                var updatedParameters = PermuteDeclaration(
                    lambda.ParameterList.Parameters,
                    signaturePermutation,
                    createNewParameterDelegate);
396 397 398 399 400 401
                return lambda.WithParameterList(lambda.ParameterList.WithParameters(updatedParameters));
            }

            // Update reference site argument lists
            if (updatedNode.IsKind(SyntaxKind.InvocationExpression))
            {
402
                var invocation = (InvocationExpressionSyntax)updatedNode;
I
Ivan Basov 已提交
403
                var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);
404

405
                var symbolInfo = semanticModel.GetSymbolInfo((InvocationExpressionSyntax)originalNode, cancellationToken);
406 407
                var isReducedExtensionMethod = false;

C
Cyrus Najmabadi 已提交
408
                if (symbolInfo.Symbol is IMethodSymbol methodSymbol && methodSymbol.MethodKind == MethodKind.ReducedExtension)
409 410 411 412
                {
                    isReducedExtensionMethod = true;
                }

413 414
                SignatureChange signaturePermutationWithoutAddedParameters = signaturePermutation.WithoutAddedParameters();

I
Ivan Basov 已提交
415
                var newArguments = PermuteArgumentList(declarationSymbol, invocation.ArgumentList.Arguments, signaturePermutationWithoutAddedParameters, isReducedExtensionMethod);
I
Ivan Basov 已提交
416
                newArguments = AddNewArgumentsToList(newArguments, signaturePermutation, isReducedExtensionMethod);
417 418 419 420 421
                return invocation.WithArgumentList(invocation.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.ObjectCreationExpression))
            {
422
                var objCreation = (ObjectCreationExpressionSyntax)updatedNode;
I
Ivan Basov 已提交
423
                var newArguments = PermuteArgumentList(declarationSymbol, objCreation.ArgumentList.Arguments, signaturePermutation);
424 425 426 427 428 429
                return objCreation.WithArgumentList(objCreation.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.ThisConstructorInitializer) ||
                updatedNode.IsKind(SyntaxKind.BaseConstructorInitializer))
            {
430
                var objCreation = (ConstructorInitializerSyntax)updatedNode;
I
Ivan Basov 已提交
431
                var newArguments = PermuteArgumentList(declarationSymbol, objCreation.ArgumentList.Arguments, signaturePermutation);
432 433 434 435 436
                return objCreation.WithArgumentList(objCreation.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.ElementAccessExpression))
            {
437
                var elementAccess = (ElementAccessExpressionSyntax)updatedNode;
I
Ivan Basov 已提交
438
                var newArguments = PermuteArgumentList(declarationSymbol, elementAccess.ArgumentList.Arguments, signaturePermutation);
439 440 441 442 443
                return elementAccess.WithArgumentList(elementAccess.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            if (updatedNode.IsKind(SyntaxKind.Attribute))
            {
444
                var attribute = (AttributeSyntax)updatedNode;
I
Ivan Basov 已提交
445
                var newArguments = PermuteAttributeArgumentList(declarationSymbol, attribute.ArgumentList.Arguments, signaturePermutation);
446 447 448 449 450 451
                return attribute.WithArgumentList(attribute.ArgumentList.WithArguments(newArguments).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
            }

            // Handle references in crefs
            if (updatedNode.IsKind(SyntaxKind.NameMemberCref))
            {
452
                var nameMemberCref = (NameMemberCrefSyntax)updatedNode;
453 454 455 456 457 458 459

                if (nameMemberCref.Parameters == null ||
                    !nameMemberCref.Parameters.Parameters.Any())
                {
                    return nameMemberCref;
                }

I
Ivan Basov 已提交
460
                var newParameters = PermuteDeclaration(nameMemberCref.Parameters.Parameters, signaturePermutation, CreateNewCrefParameterSyntax);
461 462 463 464 465 466 467 468 469

                var newCrefParameterList = nameMemberCref.Parameters.WithParameters(newParameters);
                return nameMemberCref.WithParameters(newCrefParameterList);
            }

            Debug.Assert(false, "Unknown reference location");
            return null;
        }

470 471
        private SeparatedSyntaxList<ArgumentSyntax> AddNewArgumentsToList(
            SeparatedSyntaxList<ArgumentSyntax> newArguments,
I
Ivan Basov 已提交
472 473
            SignatureChange signaturePermutation,
            bool isReducedExtensionMethod)
474 475
        {
            List<ArgumentSyntax> fullList = new List<ArgumentSyntax>();
476
            List<SyntaxToken> separators = new List<SyntaxToken>();
477 478 479 480 481 482 483 484 485

            var updatedParameters = signaturePermutation.UpdatedConfiguration.ToListOfParameters();

            int indexInExistingList = 0;

            bool seenNameEquals = false;

            for (int i = 0; i < updatedParameters.Count; i++)
            {
I
Ivan Basov 已提交
486 487 488
                // Skip this parameter in list of arguments for extension method calls but not for reduced ones.
                if (updatedParameters[i] != signaturePermutation.UpdatedConfiguration.ThisParameter
                    || !isReducedExtensionMethod)
489
                {
I
Ivan Basov 已提交
490
                    if (updatedParameters[i] is AddedParameter addedParameter)
491
                    {
I
Ivan Basov 已提交
492
                        if (addedParameter.CallSiteValue != null)
I
Ivan Basov 已提交
493 494 495 496
                        {
                            fullList.Add(SyntaxFactory.Argument(
                                seenNameEquals ? SyntaxFactory.NameColon(addedParameter.Name) : default,
                                refKindKeyword: default,
I
Ivan Basov 已提交
497
                                expression: SyntaxFactory.ParseExpression(addedParameter.CallSiteValue)));
I
Ivan Basov 已提交
498
                            separators.Add(SyntaxFactory.Token(SyntaxKind.CommaToken).WithTrailingTrivia(SyntaxFactory.ElasticSpace));
I
Ivan Basov 已提交
499
                        }
500
                    }
I
Ivan Basov 已提交
501
                    else
502
                    {
I
Ivan Basov 已提交
503
                        if (indexInExistingList < newArguments.Count)
I
Ivan Basov 已提交
504
                        {
I
Ivan Basov 已提交
505 506 507 508
                            if (newArguments[indexInExistingList].NameColon != default)
                            {
                                seenNameEquals = true;
                            }
509

I
Ivan Basov 已提交
510 511 512 513
                            if (indexInExistingList < newArguments.SeparatorCount)
                            {
                                separators.Add(newArguments.GetSeparator(indexInExistingList));
                            }
514

I
Ivan Basov 已提交
515 516
                            fullList.Add(newArguments[indexInExistingList++]);
                        }
I
Ivan Basov 已提交
517
                    }
518 519 520
                }
            }

521 522 523 524 525 526 527 528 529 530 531
            // Add the rest of existing parameters, e.g. from the params argument.
            while (indexInExistingList < newArguments.Count)
            {
                if (indexInExistingList < newArguments.SeparatorCount)
                {
                    separators.Add(newArguments.GetSeparator(indexInExistingList));
                }

                fullList.Add(newArguments[indexInExistingList++]);
            }

I
Ivan Basov 已提交
532 533 534 535 536
            if (fullList.Count == separators.Count && separators.Count != 0)
            {
                separators.Remove(separators.Last());
            }

537
            return SyntaxFactory.SeparatedList(fullList, separators);
538 539
        }

I
Ivan Basov 已提交
540 541
        private static ParameterSyntax CreateNewParameterSyntax(AddedParameter addedParameter)
            => CreateNewParameterSyntax(addedParameter, skipType: false);
I
Ivan Basov 已提交
542

I
Ivan Basov 已提交
543 544 545 546 547 548 549
        private static ParameterSyntax CreateNewParameterSyntax(AddedParameter addedParameter, bool skipType)
            => SyntaxFactory.Parameter(
                attributeLists: SyntaxFactory.List<AttributeListSyntax>(),
                modifiers: SyntaxFactory.TokenList(),
                type: skipType ? default : SyntaxFactory.ParseTypeName(addedParameter.TypeName).WithTrailingTrivia(SyntaxFactory.ElasticSpace),
                SyntaxFactory.Identifier(addedParameter.ParameterName),
                @default: default);
I
Ivan Basov 已提交
550

I
Ivan Basov 已提交
551 552
        private static CrefParameterSyntax CreateNewCrefParameterSyntax(AddedParameter addedParameter)
            => SyntaxFactory.CrefParameter(type: SyntaxFactory.ParseTypeName(addedParameter.TypeName)).WithLeadingTrivia(SyntaxFactory.ElasticSpace);
I
Ivan Basov 已提交
553 554

        private SeparatedSyntaxList<T> PermuteDeclaration<T>(
I
Ivan Basov 已提交
555
            SeparatedSyntaxList<T> list,
I
Ivan Basov 已提交
556 557
            SignatureChange updatedSignature,
            Func<AddedParameter, T> createNewParameterMethod) where T : SyntaxNode
558
        {
559
            var permuteDeclarationBase = base.PermuteDeclarationBase<T>(list, updatedSignature, createNewParameterMethod);
560
            return SyntaxFactory.SeparatedList(permuteDeclarationBase.parameters, permuteDeclarationBase.separators);
561 562
        }

563
        protected override T TransferLeadingWhitespaceTrivia<T>(T newArgument, SyntaxNode oldArgument)
564 565 566 567 568 569 570 571 572
        {
            var oldTrivia = oldArgument.GetLeadingTrivia();
            var oldOnlyHasWhitespaceTrivia = oldTrivia.All(t => t.IsKind(SyntaxKind.WhitespaceTrivia));

            var newTrivia = newArgument.GetLeadingTrivia();
            var newOnlyHasWhitespaceTrivia = newTrivia.All(t => t.IsKind(SyntaxKind.WhitespaceTrivia));

            if (oldOnlyHasWhitespaceTrivia && newOnlyHasWhitespaceTrivia)
            {
573
                newArgument = newArgument.WithLeadingTrivia(oldTrivia);
574 575 576 577 578
            }

            return newArgument;
        }

579
        private SeparatedSyntaxList<AttributeArgumentSyntax> PermuteAttributeArgumentList(
580 581 582 583
            ISymbol declarationSymbol,
            SeparatedSyntaxList<AttributeArgumentSyntax> arguments,
            SignatureChange updatedSignature)
        {
I
Ivan Basov 已提交
584 585
            var newArguments = PermuteArguments(declarationSymbol, arguments.Select(a => UnifiedArgumentSyntax.Create(a)).ToList(),
                updatedSignature,
A
Allison Chou 已提交
586
                callSiteValue => UnifiedArgumentSyntax.Create(SyntaxFactory.AttributeArgument(SyntaxFactory.ParseExpression(callSiteValue))));
587
            var numSeparatorsToSkip = arguments.Count - newArguments.Count;
588 589

            // copy whitespace trivia from original position
590 591
            var newArgumentsWithTrivia = TransferLeadingWhitespaceTrivia(
                newArguments.Select(a => (AttributeArgumentSyntax)(UnifiedArgumentSyntax)a), arguments);
592 593

            return SyntaxFactory.SeparatedList(newArgumentsWithTrivia, GetSeparators(arguments, numSeparatorsToSkip));
594 595
        }

596
        private SeparatedSyntaxList<ArgumentSyntax> PermuteArgumentList(
597 598 599 600 601
            ISymbol declarationSymbol,
            SeparatedSyntaxList<ArgumentSyntax> arguments,
            SignatureChange updatedSignature,
            bool isReducedExtensionMethod = false)
        {
I
Ivan Basov 已提交
602 603
            var newArguments = PermuteArguments(declarationSymbol, arguments.Select(a => UnifiedArgumentSyntax.Create(a)).ToList(),
                updatedSignature,
A
Allison Chou 已提交
604
                 callSiteValue => UnifiedArgumentSyntax.Create(SyntaxFactory.Argument(SyntaxFactory.ParseExpression(callSiteValue))),
I
Ivan Basov 已提交
605
                 isReducedExtensionMethod);
606

607 608 609
            // copy whitespace trivia from original position
            var newArgumentsWithTrivia = TransferLeadingWhitespaceTrivia(
                newArguments.Select(a => (ArgumentSyntax)(UnifiedArgumentSyntax)a), arguments);
610

611
            var numSeparatorsToSkip = arguments.Count - newArguments.Count;
612 613 614
            return SyntaxFactory.SeparatedList(newArgumentsWithTrivia, GetSeparators(arguments, numSeparatorsToSkip));
        }

615
        private List<T> TransferLeadingWhitespaceTrivia<T, U>(IEnumerable<T> newArguments, SeparatedSyntaxList<U> oldArguments)
616 617 618 619
            where T : SyntaxNode
            where U : SyntaxNode
        {
            var result = new List<T>();
620
            var index = 0;
621 622
            foreach (var newArgument in newArguments)
            {
I
Ivan Basov 已提交
623 624 625 626 627 628 629 630 631
                if (index < oldArguments.Count)
                {
                    result.Add(TransferLeadingWhitespaceTrivia(newArgument, oldArguments[index]));
                }
                else
                {
                    result.Add(newArgument);
                }

632 633 634 635
                index++;
            }

            return result;
636 637
        }

I
Ivan Basov 已提交
638
        private List<SyntaxTrivia> UpdateParamTagsInLeadingTrivia(Document document, CSharpSyntaxNode node, ISymbol declarationSymbol, SignatureChange updatedSignature)
639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655
        {
            if (!node.HasLeadingTrivia)
            {
                return null;
            }

            var paramNodes = node
                .DescendantNodes(descendIntoTrivia: true)
                .OfType<XmlElementSyntax>()
                .Where(e => e.StartTag.Name.ToString() == DocumentationCommentXmlNames.ParameterElementName);

            var permutedParamNodes = VerifyAndPermuteParamNodes(paramNodes, declarationSymbol, updatedSignature);
            if (permutedParamNodes == null)
            {
                return null;
            }

I
Ivan Basov 已提交
656
            return GetPermutedTrivia(document, node, permutedParamNodes);
657 658 659 660 661 662 663 664 665
        }

        private List<XmlElementSyntax> VerifyAndPermuteParamNodes(IEnumerable<XmlElementSyntax> paramNodes, ISymbol declarationSymbol, SignatureChange updatedSignature)
        {
            // Only reorder if count and order match originally.
            var originalParameters = updatedSignature.OriginalConfiguration.ToListOfParameters();
            var reorderedParameters = updatedSignature.UpdatedConfiguration.ToListOfParameters();

            var declaredParameters = declarationSymbol.GetParameters();
666
            if (paramNodes.Count() != declaredParameters.Length)
667 668 669 670
            {
                return null;
            }

671 672 673 674 675
            if (declaredParameters.Length == 0)
            {
                return null;
            }

676
            var dictionary = new Dictionary<string, XmlElementSyntax>();
677
            var i = 0;
C
Charles Stoner 已提交
678
            foreach (var paramNode in paramNodes)
679 680 681 682 683 684 685 686 687 688 689 690 691
            {
                var nameAttribute = paramNode.StartTag.Attributes.FirstOrDefault(a => a.Name.ToString().Equals("name", StringComparison.OrdinalIgnoreCase));
                if (nameAttribute == null)
                {
                    return null;
                }

                var identifier = nameAttribute.DescendantNodes(descendIntoTrivia: true).OfType<IdentifierNameSyntax>().FirstOrDefault();
                if (identifier == null || identifier.ToString() != declaredParameters.ElementAt(i).Name)
                {
                    return null;
                }

C
Charles Stoner 已提交
692 693
                dictionary.Add(originalParameters[i].Name.ToString(), paramNode);
                i++;
694 695 696 697 698 699
            }

            // Everything lines up, so permute them.
            var permutedParams = new List<XmlElementSyntax>();
            foreach (var parameter in reorderedParameters)
            {
I
Ivan Basov 已提交
700 701 702 703 704 705 706 707 708 709 710 711
                if (dictionary.TryGetValue(parameter.Name, out var permutedParam))
                {
                    permutedParams.Add(permutedParam);
                }
                else
                {
                    permutedParams.Add(SyntaxFactory.XmlElement(
                        SyntaxFactory.XmlElementStartTag(
                            SyntaxFactory.XmlName("param"),
                            SyntaxFactory.List<XmlAttributeSyntax>(new[] { SyntaxFactory.XmlNameAttribute(parameter.Name) })),
                        SyntaxFactory.XmlElementEndTag(SyntaxFactory.XmlName("param"))));
                }
712 713 714 715 716
            }

            return permutedParams;
        }

I
Ivan Basov 已提交
717
        private List<SyntaxTrivia> GetPermutedTrivia(Document document, CSharpSyntaxNode node, List<XmlElementSyntax> permutedParamNodes)
718 719 720
        {
            var updatedLeadingTrivia = new List<SyntaxTrivia>();
            var index = 0;
I
Ivan Basov 已提交
721 722 723 724 725
            SyntaxTrivia lastWhiteSpaceTrivia = default;

            var lastDocumentationCommentTriviaSyntax = node.GetLeadingTrivia()
                .LastOrDefault(t => t.HasStructure && t.GetStructure() is DocumentationCommentTriviaSyntax);
            DocumentationCommentTriviaSyntax documentationCommeStructuredTrivia = lastDocumentationCommentTriviaSyntax.GetStructure() as DocumentationCommentTriviaSyntax;
726 727 728 729 730

            foreach (var trivia in node.GetLeadingTrivia())
            {
                if (!trivia.HasStructure)
                {
I
Ivan Basov 已提交
731 732 733 734 735
                    if (trivia.IsKind(SyntaxKind.WhitespaceTrivia))
                    {
                        lastWhiteSpaceTrivia = trivia;
                    }

736 737 738 739
                    updatedLeadingTrivia.Add(trivia);
                    continue;
                }

C
Cyrus Najmabadi 已提交
740
                if (!(trivia.GetStructure() is DocumentationCommentTriviaSyntax structuredTrivia))
741 742 743 744 745 746 747
                {
                    updatedLeadingTrivia.Add(trivia);
                    continue;
                }

                var updatedNodeList = new List<XmlNodeSyntax>();
                var structuredContent = structuredTrivia.Content.ToList();
C
Cyrus Najmabadi 已提交
748
                for (var i = 0; i < structuredContent.Count; i++)
749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775
                {
                    var content = structuredContent[i];
                    if (!content.IsKind(SyntaxKind.XmlElement))
                    {
                        updatedNodeList.Add(content);
                        continue;
                    }

                    var xmlElement = content as XmlElementSyntax;
                    if (xmlElement.StartTag.Name.ToString() != DocumentationCommentXmlNames.ParameterElementName)
                    {
                        updatedNodeList.Add(content);
                        continue;
                    }

                    // Found a param tag, so insert the next one from the reordered list
                    if (index < permutedParamNodes.Count)
                    {
                        updatedNodeList.Add(permutedParamNodes[index].WithLeadingTrivia(content.GetLeadingTrivia()).WithTrailingTrivia(content.GetTrailingTrivia()));
                        index++;
                    }
                    else
                    {
                        // Inspecting a param element that we are deleting but not replacing.
                    }
                }

I
Ivan Basov 已提交
776 777 778 779
                var newDocComments = SyntaxFactory.DocumentationCommentTrivia(
                    structuredTrivia.Kind(),
                    SyntaxFactory.List(updatedNodeList.AsEnumerable()),
                    structuredTrivia.EndOfComment);
780 781 782 783 784 785
                newDocComments = newDocComments.WithLeadingTrivia(structuredTrivia.GetLeadingTrivia()).WithTrailingTrivia(structuredTrivia.GetTrailingTrivia());
                var newTrivia = SyntaxFactory.Trivia(newDocComments);

                updatedLeadingTrivia.Add(newTrivia);
            }

I
Ivan Basov 已提交
786 787 788
            var extraNodeList = new List<XmlNodeSyntax>();
            while (index < permutedParamNodes.Count)
            {
I
Ivan Basov 已提交
789
                extraNodeList.Add(permutedParamNodes[index]);
I
Ivan Basov 已提交
790 791 792 793 794
                index++;
            }

            if (extraNodeList.Any())
            {
I
Ivan Basov 已提交
795 796 797 798 799 800 801 802 803 804 805
                var extraDocComments = SyntaxFactory.DocumentationCommentTrivia(
                    SyntaxKind.MultiLineDocumentationCommentTrivia,
                    SyntaxFactory.List(extraNodeList.AsEnumerable()),
                    SyntaxFactory.Token(SyntaxKind.EndOfDocumentationCommentToken));
                extraDocComments = extraDocComments
                    .WithLeadingTrivia(SyntaxFactory.DocumentationCommentExterior("/// "))
                    .WithTrailingTrivia(node.GetTrailingTrivia())
                    .WithTrailingTrivia(
                    SyntaxFactory.EndOfLine(document.Project.Solution.Workspace.Options.GetOption(FormattingOptions.NewLine, LanguageNames.CSharp)),
                    lastWhiteSpaceTrivia);

I
Ivan Basov 已提交
806 807 808 809 810
                var newTrivia = SyntaxFactory.Trivia(extraDocComments);

                updatedLeadingTrivia.Add(newTrivia);
            }

811 812 813
            return updatedLeadingTrivia;
        }

814
        public override async Task<ImmutableArray<SymbolAndProjectId>> DetermineCascadedSymbolsFromDelegateInvoke(
D
dotnet-bot 已提交
815 816
            SymbolAndProjectId<IMethodSymbol> symbolAndProjectId,
            Document document,
817
            CancellationToken cancellationToken)
818
        {
819
            var symbol = symbolAndProjectId.Symbol;
820 821 822
            var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
            var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);

823
            var nodes = root.DescendantNodes().ToImmutableArray();
824
            var convertedMethodGroups = nodes
825
                .WhereAsArray(
826
                    n =>
I
Ivan Basov 已提交
827 828 829
                    {
                        if (!n.IsKind(SyntaxKind.IdentifierName) ||
                            !semanticModel.GetMemberGroup(n, cancellationToken).Any())
830
                        {
I
Ivan Basov 已提交
831 832
                            return false;
                        }
833

I
Ivan Basov 已提交
834
                        ISymbol convertedType = semanticModel.GetTypeInfo(n, cancellationToken).ConvertedType;
835

I
Ivan Basov 已提交
836 837 838 839
                        if (convertedType != null)
                        {
                            convertedType = convertedType.OriginalDefinition;
                        }
840

I
Ivan Basov 已提交
841 842 843 844
                        if (convertedType != null)
                        {
                            convertedType = SymbolFinder.FindSourceDefinitionAsync(convertedType, document.Project.Solution, cancellationToken).WaitAndGetResult_CanCallOnBackground(cancellationToken) ?? convertedType;
                        }
845

I
Ivan Basov 已提交
846 847
                        return Equals(convertedType, symbol.ContainingType);
                    })
848
                .SelectAsArray(n => semanticModel.GetSymbolInfo(n, cancellationToken).Symbol);
849

850
            return convertedMethodGroups.SelectAsArray(symbolAndProjectId.WithSymbol);
851 852
        }

853
        protected override IEnumerable<AbstractFormattingRule> GetFormattingRules(Document document)
854
            => SpecializedCollections.SingletonEnumerable<AbstractFormattingRule>(new ChangeSignatureFormattingRule()).Concat(Formatter.GetDefaultFormattingRules(document));
855

I
Ivan Basov 已提交
856 857
        protected override SyntaxToken CreateSeparatorSyntaxToken()
            => SyntaxFactory.Token(SyntaxKind.CommaToken).WithTrailingTrivia(SyntaxFactory.ElasticSpace);
858
    }
S
Sam Harwell 已提交
859
}