issues_controller.rb 7.6 KB
Newer Older
1 2
# frozen_string_literal: true

3
class Projects::IssuesController < Projects::ApplicationController
D
Douwe Maan 已提交
4
  include RendersNotes
5
  include ToggleSubscriptionAction
6
  include IssuableActions
7
  include ToggleAwardEmoji
8
  include IssuableCollections
9
  include IssuesCalendar
10
  include SpammableActions
11

12 13 14 15 16 17 18 19
  def self.issue_except_actions
    %i[index calendar new create bulk_update]
  end

  def self.set_issuables_index_only_actions
    %i[index calendar]
  end

20 21 22 23
  prepend_before_action(only: [:index]) { authenticate_sessionless_user!(:rss) }
  prepend_before_action(only: [:calendar]) { authenticate_sessionless_user!(:ics) }
  prepend_before_action :authenticate_new_issue!, only: [:new]
  prepend_before_action :store_uri, only: [:new, :show]
24

25
  before_action :whitelist_query_limiting, only: [:create, :create_merge_request, :move, :bulk_update]
26
  before_action :check_issues_available!
27 28 29
  before_action :issue, except: issue_except_actions

  before_action :set_issuables_index, only: set_issuables_index_only_actions
D
Dmitriy Zaporozhets 已提交
30 31

  # Allow write(create) issue
D
Dmitriy Zaporozhets 已提交
32
  before_action :authorize_create_issue!, only: [:new, :create]
D
Dmitriy Zaporozhets 已提交
33 34

  # Allow modify issue
35
  before_action :authorize_update_issuable!, only: [:edit, :update, :move]
D
Dmitriy Zaporozhets 已提交
36

37
  # Allow create a new branch and empty WIP merge request from current issue
38
  before_action :authorize_create_merge_request_from!, only: [:create_merge_request]
39

P
Phil Hughes 已提交
40 41
  before_action :set_suggested_issues_feature_flags, only: [:new]

D
Dmitriy Zaporozhets 已提交
42
  respond_to :html
G
gitlabhq 已提交
43 44

  def index
J
Jarka Kadlecova 已提交
45
    @issues = @issuables
46

G
gitlabhq 已提交
47
    respond_to do |format|
D
Dmitriy Zaporozhets 已提交
48
      format.html
49
      format.atom { render layout: 'xml.atom' }
D
Dmitriy Zaporozhets 已提交
50 51
      format.json do
        render json: {
52
          html: view_to_html_string("projects/issues/_issues"),
P
Phil Hughes 已提交
53
          labels: @labels.as_json(methods: :text_color)
D
Dmitriy Zaporozhets 已提交
54 55
        }
      end
G
gitlabhq 已提交
56 57 58
    end
  end

59
  def calendar
60
    render_issues_calendar(@issuables)
61 62
  end

G
gitlabhq 已提交
63
  def new
64
    params[:issue] ||= ActionController::Parameters.new(
65
      assignee_ids: ""
66
    )
67
    build_params = issue_params.merge(
B
Bob Van Landuyt 已提交
68
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
69
      discussion_to_resolve: params[:discussion_to_resolve]
70
    )
71
    service = Issues::BuildService.new(project, current_user, build_params)
72

73
    @issue = @noteable = service.execute
B
Bob Van Landuyt 已提交
74
    @merge_request_to_resolve_discussions_of = service.merge_request_to_resolve_discussions_of
75
    @discussion_to_resolve = service.discussions_to_resolve.first if params[:discussion_to_resolve]
76

G
gitlabhq 已提交
77 78 79
    respond_with(@issue)
  end

80 81 82 83
  def edit
    respond_with(@issue)
  end

G
gitlabhq 已提交
84
  def create
85
    create_params = issue_params.merge(spammable_params).merge(
B
Bob Van Landuyt 已提交
86
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
87 88 89
      discussion_to_resolve: params[:discussion_to_resolve]
    )

90 91 92
    service = Issues::CreateService.new(project, current_user, create_params)
    @issue = service.execute

93
    if service.discussions_to_resolve.count(&:resolved?) > 0
94
      flash[:notice] = if service.discussion_to_resolve_id
95 96 97 98
                         "Resolved 1 discussion."
                       else
                         "Resolved all discussions."
                       end
99
    end
G
gitlabhq 已提交
100

101
    respond_to do |format|
102
      format.html do
103
        recaptcha_check_with_fallback { render :new }
104
      end
105
      format.js do
106 107
        @link = @issue.attachment.url.to_js
      end
108
    end
G
gitlabhq 已提交
109 110
  end

111 112 113
  def move
    params.require(:move_to_project_id)

114 115
    if params[:move_to_project_id].to_i > 0
      new_project = Project.find(params[:move_to_project_id])
116 117
      return render_404 unless issue.can_move?(current_user, new_project)

118
      @issue = Issues::UpdateService.new(project, current_user, target_project: new_project).execute(issue)
119
    end
G
gitlabhq 已提交
120 121

    respond_to do |format|
122
      format.json do
123
        render_issue_json
124
      end
G
gitlabhq 已提交
125
    end
126 127

  rescue ActiveRecord::StaleObjectError
128
    render_conflict_response
G
gitlabhq 已提交
129 130
  end

131
  def referenced_merge_requests
132
    @merge_requests, @closed_by_merge_requests = ::Issues::ReferencedMergeRequestsService.new(project, current_user).execute(issue)
133 134 135 136 137 138 139 140 141 142 143

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_merge_requests')
        }
      end
    end
  end

  def related_branches
144
    @related_branches = Issues::RelatedBranchesService.new(project, current_user).execute(issue)
145 146 147 148 149 150 151 152 153 154

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_related_branches')
        }
      end
    end
  end

155 156 157
  def can_create_branch
    can_create = current_user &&
      can?(current_user, :push_code, @project) &&
158
      @issue.can_be_worked_on?
159 160 161

    respond_to do |format|
      format.json do
162
        render json: { can_create_branch: can_create, suggested_branch_name: @issue.suggested_branch_name }
163 164 165 166
      end
    end
  end

167
  def create_merge_request
168 169
    create_params = params.slice(:branch_name, :ref).merge(issue_iid: issue.iid)
    result = ::MergeRequests::CreateFromIssueService.new(project, current_user, create_params).execute
170 171 172 173 174 175 176 177

    if result[:status] == :success
      render json: MergeRequestCreateSerializer.new.represent(result[:merge_request])
    else
      render json: result[:messsage], status: :unprocessable_entity
    end
  end

N
Nihad Abbasov 已提交
178
  protected
G
gitlabhq 已提交
179

180
  # rubocop: disable CodeReuse/ActiveRecord
G
gitlabhq 已提交
181
  def issue
182
    return @issue if defined?(@issue)
183

184
    # The Sortable default scope causes performance issues when used with find_by
185
    @issuable = @noteable = @issue ||= @project.issues.includes(author: :status).where(iid: params[:id]).reorder(nil).take!
186
    @note = @project.notes.new(noteable: @issuable)
187 188 189 190

    return render_404 unless can?(current_user, :read_issue, @issue)

    @issue
G
gitlabhq 已提交
191
  end
192
  # rubocop: enable CodeReuse/ActiveRecord
193
  alias_method :subscribable_resource, :issue
194
  alias_method :issuable, :issue
195
  alias_method :awardable, :issue
196
  alias_method :spammable, :issue
D
Dmitriy Zaporozhets 已提交
197

198 199 200 201
  def spammable_path
    project_issue_path(@project, @issue)
  end

202
  def authorize_create_merge_request!
203
    render_404 unless can?(current_user, :push_code, @project) && @issue.can_be_worked_on?
204 205
  end

206 207 208 209 210 211 212 213
  def render_issue_json
    if @issue.valid?
      render json: serializer.represent(@issue)
    else
      render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
    end
  end

214
  def issue_params
215 216 217 218 219 220 221 222 223 224 225 226 227 228 229
    params.require(:issue).permit(*issue_params_attributes)
  end

  def issue_params_attributes
    %i[
      title
      assignee_id
      position
      description
      confidential
      milestone_id
      due_date
      state_event
      task_num
      lock_version
230
      discussion_locked
231
    ] + [{ label_ids: [], assignee_ids: [] }]
232
  end
233

234
  def authenticate_new_issue!
235 236 237 238
    return if current_user

    notice = "Please sign in to create the new issue."

239 240 241 242
    redirect_to new_user_session_path, notice: notice
  end

  def store_uri
243 244 245
    if request.get? && !request.xhr?
      store_location_for :user, request.fullpath
    end
246
  end
D
Douwe Maan 已提交
247 248 249 250

  def serializer
    IssueSerializer.new(current_user: current_user, project: issue.project)
  end
251 252 253 254 255

  def update_service
    update_params = issue_params.merge(spammable_params)
    Issues::UpdateService.new(project, current_user, update_params)
  end
J
Jarka Kadlecova 已提交
256

257 258
  def finder_type
    IssuesFinder
J
Jarka Kadlecova 已提交
259
  end
260 261 262 263 264 265 266 267 268

  def whitelist_query_limiting
    # Also see the following issues:
    #
    # 1. https://gitlab.com/gitlab-org/gitlab-ce/issues/42423
    # 2. https://gitlab.com/gitlab-org/gitlab-ce/issues/42424
    # 3. https://gitlab.com/gitlab-org/gitlab-ce/issues/42426
    Gitlab::QueryLimiting.whitelist('https://gitlab.com/gitlab-org/gitlab-ce/issues/42422')
  end
P
Phil Hughes 已提交
269 270

  def set_suggested_issues_feature_flags
271
    push_frontend_feature_flag(:graphql, default_enabled: true)
P
Phil Hughes 已提交
272
  end
G
gitlabhq 已提交
273
end