issues_controller.rb 6.7 KB
Newer Older
1
class Projects::IssuesController < Projects::ApplicationController
D
Douwe Maan 已提交
2
  include RendersNotes
3
  include ToggleSubscriptionAction
4
  include IssuableActions
5
  include ToggleAwardEmoji
6
  include IssuableCollections
7
  include SpammableActions
8

9 10
  prepend_before_action :authenticate_user!, only: [:new]

11
  before_action :whitelist_query_limiting, only: [:create, :create_merge_request, :move, :bulk_update]
12
  before_action :check_issues_available!
13
  before_action :issue, except: [:index, :new, :create, :bulk_update]
J
Jarka Kadlecova 已提交
14
  before_action :set_issuables_index, only: [:index]
D
Dmitriy Zaporozhets 已提交
15 16

  # Allow write(create) issue
D
Dmitriy Zaporozhets 已提交
17
  before_action :authorize_create_issue!, only: [:new, :create]
D
Dmitriy Zaporozhets 已提交
18 19

  # Allow modify issue
20
  before_action :authorize_update_issuable!, only: [:edit, :update, :move]
D
Dmitriy Zaporozhets 已提交
21

22
  # Allow create a new branch and empty WIP merge request from current issue
23
  before_action :authorize_create_merge_request_from!, only: [:create_merge_request]
24

D
Dmitriy Zaporozhets 已提交
25
  respond_to :html
G
gitlabhq 已提交
26 27

  def index
J
Jarka Kadlecova 已提交
28
    @issues = @issuables
29

G
gitlabhq 已提交
30
    respond_to do |format|
D
Dmitriy Zaporozhets 已提交
31
      format.html
32
      format.atom { render layout: 'xml.atom' }
D
Dmitriy Zaporozhets 已提交
33 34
      format.json do
        render json: {
35
          html: view_to_html_string("projects/issues/_issues"),
P
Phil Hughes 已提交
36
          labels: @labels.as_json(methods: :text_color)
D
Dmitriy Zaporozhets 已提交
37 38
        }
      end
G
gitlabhq 已提交
39 40 41 42
    end
  end

  def new
43
    params[:issue] ||= ActionController::Parameters.new(
44
      assignee_ids: ""
45
    )
46
    build_params = issue_params.merge(
B
Bob Van Landuyt 已提交
47
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
48
      discussion_to_resolve: params[:discussion_to_resolve]
49
    )
50
    service = Issues::BuildService.new(project, current_user, build_params)
51

52
    @issue = @noteable = service.execute
B
Bob Van Landuyt 已提交
53
    @merge_request_to_resolve_discussions_of = service.merge_request_to_resolve_discussions_of
54
    @discussion_to_resolve = service.discussions_to_resolve.first if params[:discussion_to_resolve]
55

G
gitlabhq 已提交
56 57 58
    respond_with(@issue)
  end

59 60 61 62
  def edit
    respond_with(@issue)
  end

G
gitlabhq 已提交
63
  def create
64
    create_params = issue_params.merge(spammable_params).merge(
B
Bob Van Landuyt 已提交
65
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
66 67 68
      discussion_to_resolve: params[:discussion_to_resolve]
    )

69 70 71
    service = Issues::CreateService.new(project, current_user, create_params)
    @issue = service.execute

72
    if service.discussions_to_resolve.count(&:resolved?) > 0
73
      flash[:notice] = if service.discussion_to_resolve_id
74 75 76 77
                         "Resolved 1 discussion."
                       else
                         "Resolved all discussions."
                       end
78
    end
G
gitlabhq 已提交
79

80
    respond_to do |format|
81
      format.html do
82
        recaptcha_check_with_fallback { render :new }
83
      end
84
      format.js do
85 86
        @link = @issue.attachment.url.to_js
      end
87
    end
G
gitlabhq 已提交
88 89
  end

90 91 92
  def move
    params.require(:move_to_project_id)

93 94
    if params[:move_to_project_id].to_i > 0
      new_project = Project.find(params[:move_to_project_id])
95 96
      return render_404 unless issue.can_move?(current_user, new_project)

97
      @issue = Issues::UpdateService.new(project, current_user, target_project: new_project).execute(issue)
98
    end
G
gitlabhq 已提交
99 100

    respond_to do |format|
101
      format.json do
102
        render_issue_json
103
      end
G
gitlabhq 已提交
104
    end
105 106

  rescue ActiveRecord::StaleObjectError
107
    render_conflict_response
G
gitlabhq 已提交
108 109
  end

110
  def referenced_merge_requests
111
    @merge_requests, @closed_by_merge_requests = ::Issues::FetchReferencedMergeRequestsService.new(project, current_user).execute(issue)
112 113 114 115 116 117 118 119 120 121 122

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_merge_requests')
        }
      end
    end
  end

  def related_branches
123
    @related_branches = @issue.related_branches(current_user)
124 125 126 127 128 129 130 131 132 133

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_related_branches')
        }
      end
    end
  end

134 135 136
  def can_create_branch
    can_create = current_user &&
      can?(current_user, :push_code, @project) &&
137
      @issue.can_be_worked_on?
138 139 140

    respond_to do |format|
      format.json do
141
        render json: { can_create_branch: can_create, suggested_branch_name: @issue.suggested_branch_name }
142 143 144 145
      end
    end
  end

146
  def create_merge_request
147 148
    create_params = params.slice(:branch_name, :ref).merge(issue_iid: issue.iid)
    result = ::MergeRequests::CreateFromIssueService.new(project, current_user, create_params).execute
149 150 151 152 153 154 155 156

    if result[:status] == :success
      render json: MergeRequestCreateSerializer.new.represent(result[:merge_request])
    else
      render json: result[:messsage], status: :unprocessable_entity
    end
  end

N
Nihad Abbasov 已提交
157
  protected
G
gitlabhq 已提交
158 159

  def issue
160
    return @issue if defined?(@issue)
161

162
    # The Sortable default scope causes performance issues when used with find_by
163 164
    @issuable = @noteable = @issue ||= @project.issues.where(iid: params[:id]).reorder(nil).take!
    @note = @project.notes.new(noteable: @issuable)
165 166 167 168

    return render_404 unless can?(current_user, :read_issue, @issue)

    @issue
G
gitlabhq 已提交
169
  end
170
  alias_method :subscribable_resource, :issue
171
  alias_method :issuable, :issue
172
  alias_method :awardable, :issue
173
  alias_method :spammable, :issue
D
Dmitriy Zaporozhets 已提交
174

175 176 177 178
  def spammable_path
    project_issue_path(@project, @issue)
  end

179
  def authorize_create_merge_request!
180
    render_404 unless can?(current_user, :push_code, @project) && @issue.can_be_worked_on?
181 182
  end

183 184 185 186 187 188 189 190
  def render_issue_json
    if @issue.valid?
      render json: serializer.represent(@issue)
    else
      render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
    end
  end

191
  def issue_params
192 193 194 195 196 197 198 199 200 201 202 203 204 205 206
    params.require(:issue).permit(*issue_params_attributes)
  end

  def issue_params_attributes
    %i[
      title
      assignee_id
      position
      description
      confidential
      milestone_id
      due_date
      state_event
      task_num
      lock_version
207
      discussion_locked
208
    ] + [{ label_ids: [], assignee_ids: [] }]
209
  end
210 211 212 213 214 215

  def authenticate_user!
    return if current_user

    notice = "Please sign in to create the new issue."

216 217 218 219
    if request.get? && !request.xhr?
      store_location_for :user, request.fullpath
    end

220 221
    redirect_to new_user_session_path, notice: notice
  end
D
Douwe Maan 已提交
222 223 224 225

  def serializer
    IssueSerializer.new(current_user: current_user, project: issue.project)
  end
226 227 228 229 230

  def update_service
    update_params = issue_params.merge(spammable_params)
    Issues::UpdateService.new(project, current_user, update_params)
  end
J
Jarka Kadlecova 已提交
231

232 233
  def finder_type
    IssuesFinder
J
Jarka Kadlecova 已提交
234
  end
235 236 237 238 239 240 241 242 243

  def whitelist_query_limiting
    # Also see the following issues:
    #
    # 1. https://gitlab.com/gitlab-org/gitlab-ce/issues/42423
    # 2. https://gitlab.com/gitlab-org/gitlab-ce/issues/42424
    # 3. https://gitlab.com/gitlab-org/gitlab-ce/issues/42426
    Gitlab::QueryLimiting.whitelist('https://gitlab.com/gitlab-org/gitlab-ce/issues/42422')
  end
G
gitlabhq 已提交
244
end