issues_controller.rb 8.1 KB
Newer Older
1
class Projects::IssuesController < Projects::ApplicationController
D
Douwe Maan 已提交
2
  include RendersNotes
3
  include ToggleSubscriptionAction
4
  include IssuableActions
5
  include ToggleAwardEmoji
6
  include IssuableCollections
7
  include SpammableActions
8

9 10
  prepend_before_action :authenticate_user!, only: [:new]

11
  before_action :check_issues_available!
12
  before_action :issue, except: [:index, :new, :create, :bulk_update]
13
  before_action :set_issues_index, only: [:index]
D
Dmitriy Zaporozhets 已提交
14 15

  # Allow write(create) issue
D
Dmitriy Zaporozhets 已提交
16
  before_action :authorize_create_issue!, only: [:new, :create]
D
Dmitriy Zaporozhets 已提交
17 18

  # Allow modify issue
J
Jarka Kadlecova 已提交
19
  before_action :authorize_update_issue!, only: [:update, :move]
D
Dmitriy Zaporozhets 已提交
20

21 22 23
  # Allow create a new branch and empty WIP merge request from current issue
  before_action :authorize_create_merge_request!, only: [:create_merge_request]

D
Dmitriy Zaporozhets 已提交
24
  respond_to :html
G
gitlabhq 已提交
25 26

  def index
27 28 29 30 31 32 33 34 35 36
    if params[:assignee_id].present?
      assignee = User.find_by_id(params[:assignee_id])
      @users.push(assignee) if assignee
    end

    if params[:author_id].present?
      author = User.find_by_id(params[:author_id])
      @users.push(author) if author
    end

G
gitlabhq 已提交
37
    respond_to do |format|
D
Dmitriy Zaporozhets 已提交
38
      format.html
39
      format.atom { render layout: 'xml.atom' }
D
Dmitriy Zaporozhets 已提交
40 41
      format.json do
        render json: {
42
          html: view_to_html_string("projects/issues/_issues"),
P
Phil Hughes 已提交
43
          labels: @labels.as_json(methods: :text_color)
D
Dmitriy Zaporozhets 已提交
44 45
        }
      end
G
gitlabhq 已提交
46 47 48 49
    end
  end

  def new
50
    params[:issue] ||= ActionController::Parameters.new(
51
      assignee_ids: ""
52
    )
53
    build_params = issue_params.merge(
B
Bob Van Landuyt 已提交
54
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
55
      discussion_to_resolve: params[:discussion_to_resolve]
56
    )
57
    service = Issues::BuildService.new(project, current_user, build_params)
58

59
    @issue = @noteable = service.execute
B
Bob Van Landuyt 已提交
60
    @merge_request_to_resolve_discussions_of = service.merge_request_to_resolve_discussions_of
61
    @discussion_to_resolve = service.discussions_to_resolve.first if params[:discussion_to_resolve]
62

G
gitlabhq 已提交
63 64 65 66
    respond_with(@issue)
  end

  def show
67
    @noteable = @issue
68
    @note     = @project.notes.new(noteable: @issue)
G
gitlabhq 已提交
69

70 71 72
    respond_to do |format|
      format.html
      format.json do
D
Douwe Maan 已提交
73
        render json: serializer.represent(@issue)
74 75
      end
    end
G
gitlabhq 已提交
76 77
  end

78
  def discussions
79 80 81 82 83
    notes = @issue.notes
      .inc_relations_for_view
      .includes(:noteable)
      .fresh

84 85
    notes = prepare_notes_for_rendering(notes)
    notes = notes.reject { |n| n.cross_reference_not_visible_for?(current_user) }
86

87
    discussions = Discussion.build_collection(notes, @issue)
88

89
    render json: DiscussionSerializer.new(project: @project, noteable: @issue, current_user: current_user).represent(discussions)
90 91
  end

G
gitlabhq 已提交
92
  def create
93
    create_params = issue_params.merge(spammable_params).merge(
B
Bob Van Landuyt 已提交
94
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
95 96 97
      discussion_to_resolve: params[:discussion_to_resolve]
    )

98 99 100
    service = Issues::CreateService.new(project, current_user, create_params)
    @issue = service.execute

101
    if service.discussions_to_resolve.count(&:resolved?) > 0
102
      flash[:notice] = if service.discussion_to_resolve_id
103 104 105 106
                         "Resolved 1 discussion."
                       else
                         "Resolved all discussions."
                       end
107
    end
G
gitlabhq 已提交
108

109
    respond_to do |format|
110
      format.html do
111
        recaptcha_check_with_fallback { render :new }
112
      end
113
      format.js do
114 115
        @link = @issue.attachment.url.to_js
      end
116
    end
G
gitlabhq 已提交
117 118 119
  end

  def update
120 121 122
    update_params = issue_params.merge(spammable_params)

    @issue = Issues::UpdateService.new(project, current_user, update_params).execute(issue)
G
gitlabhq 已提交
123

124 125 126 127 128 129 130 131 132 133 134 135 136
    respond_to do |format|
      format.json do
        render_issue_json
      end
    end

  rescue ActiveRecord::StaleObjectError
    render_conflict_response
  end

  def move
    params.require(:move_to_project_id)

137 138
    if params[:move_to_project_id].to_i > 0
      new_project = Project.find(params[:move_to_project_id])
139 140
      return render_404 unless issue.can_move?(current_user, new_project)

141
      @issue = Issues::UpdateService.new(project, current_user, target_project: new_project).execute(issue)
142
    end
G
gitlabhq 已提交
143 144

    respond_to do |format|
145
      format.json do
146
        render_issue_json
147
      end
G
gitlabhq 已提交
148
    end
149 150

  rescue ActiveRecord::StaleObjectError
151
    render_conflict_response
G
gitlabhq 已提交
152 153
  end

154 155 156 157 158 159 160 161 162 163 164 165 166 167
  def referenced_merge_requests
    @merge_requests = @issue.referenced_merge_requests(current_user)
    @closed_by_merge_requests = @issue.closed_by_merge_requests(current_user)

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_merge_requests')
        }
      end
    end
  end

  def related_branches
168
    @related_branches = @issue.related_branches(current_user)
169 170 171 172 173 174 175 176 177 178

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_related_branches')
        }
      end
    end
  end

179 180 181 182 183 184 185
  def can_create_branch
    can_create = current_user &&
      can?(current_user, :push_code, @project) &&
      @issue.can_be_worked_on?(current_user)

    respond_to do |format|
      format.json do
186
        render json: { can_create_branch: can_create, has_related_branch: @issue.has_related_branch? }
187 188 189 190
      end
    end
  end

191
  def realtime_changes
R
Regis Boudinot 已提交
192
    Gitlab::PollingInterval.set_header(response, interval: 3_000)
R
Regis 已提交
193

194
    response = {
195
      title: view_context.markdown_field(@issue, :title),
R
Regis 已提交
196
      title_text: @issue.title,
197 198
      description: view_context.markdown_field(@issue, :description),
      description_text: @issue.description,
199
      task_status: @issue.task_status
200
    }
201

202
    if @issue.edited?
203 204 205 206 207 208
      response[:updated_at] = @issue.updated_at
      response[:updated_by_name] = @issue.last_edited_by.name
      response[:updated_by_path] = user_path(@issue.last_edited_by)
    end

    render json: response
R
Regis Boudinot 已提交
209 210
  end

211
  def create_merge_request
212
    result = ::MergeRequests::CreateFromIssueService.new(project, current_user, issue_iid: issue.iid).execute
213 214 215 216 217 218 219 220

    if result[:status] == :success
      render json: MergeRequestCreateSerializer.new.represent(result[:merge_request])
    else
      render json: result[:messsage], status: :unprocessable_entity
    end
  end

N
Nihad Abbasov 已提交
221
  protected
G
gitlabhq 已提交
222 223

  def issue
224
    return @issue if defined?(@issue)
225
    # The Sortable default scope causes performance issues when used with find_by
226
    @noteable = @issue ||= @project.issues.where(iid: params[:id]).reorder(nil).take!
227 228 229 230

    return render_404 unless can?(current_user, :read_issue, @issue)

    @issue
G
gitlabhq 已提交
231
  end
232
  alias_method :subscribable_resource, :issue
233
  alias_method :issuable, :issue
234
  alias_method :awardable, :issue
235
  alias_method :spammable, :issue
D
Dmitriy Zaporozhets 已提交
236

237 238 239 240
  def spammable_path
    project_issue_path(@project, @issue)
  end

D
Dmitriy Zaporozhets 已提交
241
  def authorize_update_issue!
242
    render_404 unless can?(current_user, :update_issue, @issue)
D
Dmitriy Zaporozhets 已提交
243 244
  end

D
Dmitriy Zaporozhets 已提交
245
  def authorize_admin_issues!
246
    render_404 unless can?(current_user, :admin_issue, @project)
D
Dmitriy Zaporozhets 已提交
247
  end
248

249
  def authorize_create_merge_request!
250
    render_404 unless can?(current_user, :push_code, @project) && @issue.can_be_worked_on?(current_user)
251 252
  end

253
  def check_issues_available!
254
    return render_404 unless @project.feature_available?(:issues, current_user)
255
  end
256

257 258 259 260 261 262 263 264
  def render_issue_json
    if @issue.valid?
      render json: serializer.represent(@issue)
    else
      render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
    end
  end

265
  def issue_params
266 267 268 269 270 271 272 273 274 275 276 277 278 279 280
    params.require(:issue).permit(*issue_params_attributes)
  end

  def issue_params_attributes
    %i[
      title
      assignee_id
      position
      description
      confidential
      milestone_id
      due_date
      state_event
      task_num
      lock_version
281
      discussion_locked
282
    ] + [{ label_ids: [], assignee_ids: [] }]
283
  end
284 285 286 287 288 289

  def authenticate_user!
    return if current_user

    notice = "Please sign in to create the new issue."

290 291 292 293
    if request.get? && !request.xhr?
      store_location_for :user, request.fullpath
    end

294 295
    redirect_to new_user_session_path, notice: notice
  end
D
Douwe Maan 已提交
296 297 298 299

  def serializer
    IssueSerializer.new(current_user: current_user, project: issue.project)
  end
G
gitlabhq 已提交
300
end