issues_controller.rb 6.9 KB
Newer Older
1
class Projects::IssuesController < Projects::ApplicationController
D
Douwe Maan 已提交
2
  include RendersNotes
3
  include ToggleSubscriptionAction
4
  include IssuableActions
5
  include ToggleAwardEmoji
6
  include IssuableCollections
7
  include IssuesCalendar
8
  include SpammableActions
9

10 11
  prepend_before_action :authenticate_user!, only: [:new]

12
  before_action :whitelist_query_limiting, only: [:create, :create_merge_request, :move, :bulk_update]
13
  before_action :check_issues_available!
14 15
  before_action :issue, except: [:index, :calendar, :new, :create, :bulk_update]
  before_action :set_issuables_index, only: [:index, :calendar]
D
Dmitriy Zaporozhets 已提交
16 17

  # Allow write(create) issue
D
Dmitriy Zaporozhets 已提交
18
  before_action :authorize_create_issue!, only: [:new, :create]
D
Dmitriy Zaporozhets 已提交
19 20

  # Allow modify issue
21
  before_action :authorize_update_issuable!, only: [:edit, :update, :move]
D
Dmitriy Zaporozhets 已提交
22

23
  # Allow create a new branch and empty WIP merge request from current issue
24
  before_action :authorize_create_merge_request_from!, only: [:create_merge_request]
25

D
Dmitriy Zaporozhets 已提交
26
  respond_to :html
G
gitlabhq 已提交
27 28

  def index
J
Jarka Kadlecova 已提交
29
    @issues = @issuables
30

G
gitlabhq 已提交
31
    respond_to do |format|
D
Dmitriy Zaporozhets 已提交
32
      format.html
33
      format.atom { render layout: 'xml.atom' }
D
Dmitriy Zaporozhets 已提交
34 35
      format.json do
        render json: {
36
          html: view_to_html_string("projects/issues/_issues"),
P
Phil Hughes 已提交
37
          labels: @labels.as_json(methods: :text_color)
D
Dmitriy Zaporozhets 已提交
38 39
        }
      end
G
gitlabhq 已提交
40 41 42
    end
  end

43
  def calendar
44
    render_issues_calendar(@issuables)
45 46
  end

G
gitlabhq 已提交
47
  def new
48
    params[:issue] ||= ActionController::Parameters.new(
49
      assignee_ids: ""
50
    )
51
    build_params = issue_params.merge(
B
Bob Van Landuyt 已提交
52
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
53
      discussion_to_resolve: params[:discussion_to_resolve]
54
    )
55
    service = Issues::BuildService.new(project, current_user, build_params)
56

57
    @issue = @noteable = service.execute
B
Bob Van Landuyt 已提交
58
    @merge_request_to_resolve_discussions_of = service.merge_request_to_resolve_discussions_of
59
    @discussion_to_resolve = service.discussions_to_resolve.first if params[:discussion_to_resolve]
60

G
gitlabhq 已提交
61 62 63
    respond_with(@issue)
  end

64 65 66 67
  def edit
    respond_with(@issue)
  end

G
gitlabhq 已提交
68
  def create
69
    create_params = issue_params.merge(spammable_params).merge(
B
Bob Van Landuyt 已提交
70
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
71 72 73
      discussion_to_resolve: params[:discussion_to_resolve]
    )

74 75 76
    service = Issues::CreateService.new(project, current_user, create_params)
    @issue = service.execute

77
    if service.discussions_to_resolve.count(&:resolved?) > 0
78
      flash[:notice] = if service.discussion_to_resolve_id
79 80 81 82
                         "Resolved 1 discussion."
                       else
                         "Resolved all discussions."
                       end
83
    end
G
gitlabhq 已提交
84

85
    respond_to do |format|
86
      format.html do
87
        recaptcha_check_with_fallback { render :new }
88
      end
89
      format.js do
90 91
        @link = @issue.attachment.url.to_js
      end
92
    end
G
gitlabhq 已提交
93 94
  end

95 96 97
  def move
    params.require(:move_to_project_id)

98 99
    if params[:move_to_project_id].to_i > 0
      new_project = Project.find(params[:move_to_project_id])
100 101
      return render_404 unless issue.can_move?(current_user, new_project)

102
      @issue = Issues::UpdateService.new(project, current_user, target_project: new_project).execute(issue)
103
    end
G
gitlabhq 已提交
104 105

    respond_to do |format|
106
      format.json do
107
        render_issue_json
108
      end
G
gitlabhq 已提交
109
    end
110 111

  rescue ActiveRecord::StaleObjectError
112
    render_conflict_response
G
gitlabhq 已提交
113 114
  end

115
  def referenced_merge_requests
116
    @merge_requests, @closed_by_merge_requests = ::Issues::ReferencedMergeRequestsService.new(project, current_user).execute(issue)
117 118 119 120 121 122 123 124 125 126 127

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_merge_requests')
        }
      end
    end
  end

  def related_branches
128
    @related_branches = @issue.related_branches(current_user)
129 130 131 132 133 134 135 136 137 138

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_related_branches')
        }
      end
    end
  end

139 140 141
  def can_create_branch
    can_create = current_user &&
      can?(current_user, :push_code, @project) &&
142
      @issue.can_be_worked_on?
143 144 145

    respond_to do |format|
      format.json do
146
        render json: { can_create_branch: can_create, suggested_branch_name: @issue.suggested_branch_name }
147 148 149 150
      end
    end
  end

151
  def create_merge_request
152 153
    create_params = params.slice(:branch_name, :ref).merge(issue_iid: issue.iid)
    result = ::MergeRequests::CreateFromIssueService.new(project, current_user, create_params).execute
154 155 156 157 158 159 160 161

    if result[:status] == :success
      render json: MergeRequestCreateSerializer.new.represent(result[:merge_request])
    else
      render json: result[:messsage], status: :unprocessable_entity
    end
  end

N
Nihad Abbasov 已提交
162
  protected
G
gitlabhq 已提交
163 164

  def issue
165
    return @issue if defined?(@issue)
166

167
    # The Sortable default scope causes performance issues when used with find_by
168
    @issuable = @noteable = @issue ||= @project.issues.includes(author: :status).where(iid: params[:id]).reorder(nil).take!
169
    @note = @project.notes.new(noteable: @issuable)
170 171 172 173

    return render_404 unless can?(current_user, :read_issue, @issue)

    @issue
G
gitlabhq 已提交
174
  end
175
  alias_method :subscribable_resource, :issue
176
  alias_method :issuable, :issue
177
  alias_method :awardable, :issue
178
  alias_method :spammable, :issue
D
Dmitriy Zaporozhets 已提交
179

180 181 182 183
  def spammable_path
    project_issue_path(@project, @issue)
  end

184
  def authorize_create_merge_request!
185
    render_404 unless can?(current_user, :push_code, @project) && @issue.can_be_worked_on?
186 187
  end

188 189 190 191 192 193 194 195
  def render_issue_json
    if @issue.valid?
      render json: serializer.represent(@issue)
    else
      render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
    end
  end

196
  def issue_params
197 198 199 200 201 202 203 204 205 206 207 208 209 210 211
    params.require(:issue).permit(*issue_params_attributes)
  end

  def issue_params_attributes
    %i[
      title
      assignee_id
      position
      description
      confidential
      milestone_id
      due_date
      state_event
      task_num
      lock_version
212
      discussion_locked
213
    ] + [{ label_ids: [], assignee_ids: [] }]
214
  end
215 216 217 218 219 220

  def authenticate_user!
    return if current_user

    notice = "Please sign in to create the new issue."

221 222 223 224
    if request.get? && !request.xhr?
      store_location_for :user, request.fullpath
    end

225 226
    redirect_to new_user_session_path, notice: notice
  end
D
Douwe Maan 已提交
227 228 229 230

  def serializer
    IssueSerializer.new(current_user: current_user, project: issue.project)
  end
231 232 233 234 235

  def update_service
    update_params = issue_params.merge(spammable_params)
    Issues::UpdateService.new(project, current_user, update_params)
  end
J
Jarka Kadlecova 已提交
236

237 238
  def finder_type
    IssuesFinder
J
Jarka Kadlecova 已提交
239
  end
240 241 242 243 244 245 246 247 248

  def whitelist_query_limiting
    # Also see the following issues:
    #
    # 1. https://gitlab.com/gitlab-org/gitlab-ce/issues/42423
    # 2. https://gitlab.com/gitlab-org/gitlab-ce/issues/42424
    # 3. https://gitlab.com/gitlab-org/gitlab-ce/issues/42426
    Gitlab::QueryLimiting.whitelist('https://gitlab.com/gitlab-org/gitlab-ce/issues/42422')
  end
G
gitlabhq 已提交
249
end