issues_controller.rb 8.4 KB
Newer Older
1
class Projects::IssuesController < Projects::ApplicationController
D
Douwe Maan 已提交
2
  include RendersNotes
3
  include ToggleSubscriptionAction
4
  include IssuableActions
5
  include ToggleAwardEmoji
6
  include IssuableCollections
7
  include SpammableActions
8

9 10
  prepend_before_action :authenticate_user!, only: [:new]

11
  before_action :redirect_to_external_issue_tracker, only: [:index, :new]
12
  before_action :module_enabled
13
  before_action :issue, only: [:edit, :update, :show, :referenced_merge_requests,
14
                               :related_branches, :can_create_branch, :realtime_changes, :create_merge_request]
R
randx 已提交
15

D
Dmitriy Zaporozhets 已提交
16
  # Allow read any issue
17
  before_action :authorize_read_issue!, only: [:show, :realtime_changes]
D
Dmitriy Zaporozhets 已提交
18 19

  # Allow write(create) issue
D
Dmitriy Zaporozhets 已提交
20
  before_action :authorize_create_issue!, only: [:new, :create]
D
Dmitriy Zaporozhets 已提交
21 22

  # Allow modify issue
D
Dmitriy Zaporozhets 已提交
23
  before_action :authorize_update_issue!, only: [:edit, :update]
D
Dmitriy Zaporozhets 已提交
24

25 26 27
  # Allow create a new branch and empty WIP merge request from current issue
  before_action :authorize_create_merge_request!, only: [:create_merge_request]

D
Dmitriy Zaporozhets 已提交
28
  respond_to :html
G
gitlabhq 已提交
29 30

  def index
31 32 33
    @collection_type    = "Issue"
    @issues             = issues_collection
    @issues             = @issues.page(params[:page])
34
    @issuable_meta_data = issuable_meta_data(@issues, @collection_type)
35

36
    if @issues.out_of_range? && @issues.total_pages != 0
37
      return redirect_to url_for(params.merge(page: @issues.total_pages, only_path: true))
38
    end
39

40
    if params[:label_name].present?
41 42
      @labels = LabelsFinder.new(current_user, project_id: @project.id, title: params[:label_name]).execute
    end
G
gitlabhq 已提交
43

44 45 46 47 48 49 50 51 52 53 54 55
    @users = []

    if params[:assignee_id].present?
      assignee = User.find_by_id(params[:assignee_id])
      @users.push(assignee) if assignee
    end

    if params[:author_id].present?
      author = User.find_by_id(params[:author_id])
      @users.push(author) if author
    end

G
gitlabhq 已提交
56
    respond_to do |format|
D
Dmitriy Zaporozhets 已提交
57
      format.html
58
      format.atom { render layout: false }
D
Dmitriy Zaporozhets 已提交
59 60
      format.json do
        render json: {
61
          html: view_to_html_string("projects/issues/_issues"),
P
Phil Hughes 已提交
62
          labels: @labels.as_json(methods: :text_color)
D
Dmitriy Zaporozhets 已提交
63 64
        }
      end
G
gitlabhq 已提交
65 66 67 68
    end
  end

  def new
69
    params[:issue] ||= ActionController::Parameters.new(
70
      assignee_ids: ""
71
    )
72
    build_params = issue_params.merge(
B
Bob Van Landuyt 已提交
73
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
74
      discussion_to_resolve: params[:discussion_to_resolve]
75
    )
76
    service = Issues::BuildService.new(project, current_user, build_params)
77

78
    @issue = @noteable = service.execute
B
Bob Van Landuyt 已提交
79
    @merge_request_to_resolve_discussions_of = service.merge_request_to_resolve_discussions_of
80
    @discussion_to_resolve = service.discussions_to_resolve.first if params[:discussion_to_resolve]
81

G
gitlabhq 已提交
82 83 84 85 86 87 88 89
    respond_with(@issue)
  end

  def edit
    respond_with(@issue)
  end

  def show
90
    @noteable = @issue
91
    @note     = @project.notes.new(noteable: @issue)
G
gitlabhq 已提交
92

93 94
    @discussions = @issue.discussions
    @notes = prepare_notes_for_rendering(@discussions.flat_map(&:notes))
95

96 97 98
    respond_to do |format|
      format.html
      format.json do
99
        render json: IssueSerializer.new.represent(@issue)
100 101
      end
    end
G
gitlabhq 已提交
102 103 104
  end

  def create
105
    create_params = issue_params.merge(spammable_params).merge(
B
Bob Van Landuyt 已提交
106
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
107 108 109
      discussion_to_resolve: params[:discussion_to_resolve]
    )

110 111 112
    service = Issues::CreateService.new(project, current_user, create_params)
    @issue = service.execute

113
    if service.discussions_to_resolve.count(&:resolved?) > 0
114
      flash[:notice] = if service.discussion_to_resolve_id
115 116 117 118
                         "Resolved 1 discussion."
                       else
                         "Resolved all discussions."
                       end
119
    end
G
gitlabhq 已提交
120

121
    respond_to do |format|
122
      format.html do
123
        recaptcha_check_with_fallback { render :new }
124
      end
125
      format.js do
126 127
        @link = @issue.attachment.url.to_js
      end
128
    end
G
gitlabhq 已提交
129 130 131
  end

  def update
132 133 134
    update_params = issue_params.merge(spammable_params)

    @issue = Issues::UpdateService.new(project, current_user, update_params).execute(issue)
G
gitlabhq 已提交
135

136 137
    if params[:move_to_project_id].to_i > 0
      new_project = Project.find(params[:move_to_project_id])
138 139
      return render_404 unless issue.can_move?(current_user, new_project)

140
      move_service = Issues::MoveService.new(project, current_user)
141
      @issue = move_service.execute(@issue, new_project)
142
    end
G
gitlabhq 已提交
143 144

    respond_to do |format|
145
      format.html do
146
        recaptcha_check_with_fallback { render :edit }
147
      end
148

149
      format.json do
150 151 152
        if @issue.valid?
          render json: @issue.to_json(methods: [:task_status, :task_status_short],
                                      include: { milestone: {},
153
                                                 assignees: { only: [:id, :name, :username], methods: [:avatar_url] },
154 155 156 157
                                                 labels: { methods: :text_color } })
        else
          render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
        end
158
      end
G
gitlabhq 已提交
159
    end
160 161

  rescue ActiveRecord::StaleObjectError
162
    render_conflict_response
G
gitlabhq 已提交
163 164
  end

165 166 167 168 169 170 171 172 173 174 175 176 177 178
  def referenced_merge_requests
    @merge_requests = @issue.referenced_merge_requests(current_user)
    @closed_by_merge_requests = @issue.closed_by_merge_requests(current_user)

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_merge_requests')
        }
      end
    end
  end

  def related_branches
179
    @related_branches = @issue.related_branches(current_user)
180 181 182 183 184 185 186 187 188 189

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_related_branches')
        }
      end
    end
  end

190 191 192 193 194 195 196
  def can_create_branch
    can_create = current_user &&
      can?(current_user, :push_code, @project) &&
      @issue.can_be_worked_on?(current_user)

    respond_to do |format|
      format.json do
197
        render json: { can_create_branch: can_create, has_related_branch: @issue.has_related_branch? }
198 199 200 201
      end
    end
  end

202
  def realtime_changes
R
Regis Boudinot 已提交
203
    Gitlab::PollingInterval.set_header(response, interval: 3_000)
R
Regis 已提交
204

205 206
    render json: {
      title: view_context.markdown_field(@issue, :title),
R
Regis 已提交
207
      title_text: @issue.title,
208 209
      description: view_context.markdown_field(@issue, :description),
      description_text: @issue.description,
R
Regis 已提交
210
      task_status: @issue.task_status,
211
      updated_at: @issue.updated_at
212
    }
R
Regis Boudinot 已提交
213 214
  end

215 216 217 218 219 220 221 222 223 224
  def create_merge_request
    result = MergeRequests::CreateFromIssueService.new(project, current_user, issue_iid: issue.iid).execute

    if result[:status] == :success
      render json: MergeRequestCreateSerializer.new.represent(result[:merge_request])
    else
      render json: result[:messsage], status: :unprocessable_entity
    end
  end

N
Nihad Abbasov 已提交
225
  protected
G
gitlabhq 已提交
226 227

  def issue
228
    # The Sortable default scope causes performance issues when used with find_by
229
    @noteable = @issue ||= @project.issues.where(iid: params[:id]).reorder(nil).take!
G
gitlabhq 已提交
230
  end
231
  alias_method :subscribable_resource, :issue
232
  alias_method :issuable, :issue
233
  alias_method :awardable, :issue
234
  alias_method :spammable, :issue
D
Dmitriy Zaporozhets 已提交
235

236 237 238 239
  def authorize_read_issue!
    return render_404 unless can?(current_user, :read_issue, @issue)
  end

D
Dmitriy Zaporozhets 已提交
240
  def authorize_update_issue!
241
    return render_404 unless can?(current_user, :update_issue, @issue)
D
Dmitriy Zaporozhets 已提交
242 243
  end

D
Dmitriy Zaporozhets 已提交
244 245
  def authorize_admin_issues!
    return render_404 unless can?(current_user, :admin_issue, @project)
D
Dmitriy Zaporozhets 已提交
246
  end
247

248 249 250 251
  def authorize_create_merge_request!
    return render_404 unless can?(current_user, :push_code, @project) && @issue.can_be_worked_on?(current_user)
  end

252
  def module_enabled
F
Felipe Artur 已提交
253
    return render_404 unless @project.feature_available?(:issues, current_user) && @project.default_issues_tracker?
254
  end
255

256
  def redirect_to_external_issue_tracker
257
    external = @project.external_issue_tracker
258

259 260 261 262 263
    return unless external

    if action_name == 'new'
      redirect_to external.new_issue_path
    else
264
      redirect_to external.project_path
265
    end
266 267
  end

268
  def issue_params
269
    params.require(:issue).permit(
270
      :title, :assignee_id, :position, :description, :confidential,
271
      :milestone_id, :due_date, :state_event, :task_num, :lock_version, label_ids: [], assignee_ids: []
272 273
    )
  end
274 275 276 277 278 279 280 281 282

  def authenticate_user!
    return if current_user

    notice = "Please sign in to create the new issue."

    store_location_for :user, request.fullpath
    redirect_to new_user_session_path, notice: notice
  end
G
gitlabhq 已提交
283
end