project_spec.rb 59.7 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

D
Douwe Maan 已提交
3
describe Project, models: true do
4
  describe 'associations' do
5 6 7 8
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
    it { is_expected.to have_many(:users) }
U
ubudzisz 已提交
9
    it { is_expected.to have_many(:services) }
10 11 12 13 14
    it { is_expected.to have_many(:events).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:issues).dependent(:destroy) }
    it { is_expected.to have_many(:milestones).dependent(:destroy) }
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
15 16
    it { is_expected.to have_many(:users).through(:project_members) }
    it { is_expected.to have_many(:requesters).dependent(:destroy) }
17 18 19 20 21 22 23
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet').dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys_projects).dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys) }
    it { is_expected.to have_many(:hooks).dependent(:destroy) }
    it { is_expected.to have_many(:protected_branches).dependent(:destroy) }
    it { is_expected.to have_one(:forked_project_link).dependent(:destroy) }
24
    it { is_expected.to have_one(:slack_service).dependent(:destroy) }
25
    it { is_expected.to have_one(:mattermost_service).dependent(:destroy) }
26 27
    it { is_expected.to have_one(:pushover_service).dependent(:destroy) }
    it { is_expected.to have_one(:asana_service).dependent(:destroy) }
28
    it { is_expected.to have_many(:boards).dependent(:destroy) }
U
ubudzisz 已提交
29 30 31 32 33 34 35 36 37 38
    it { is_expected.to have_one(:campfire_service).dependent(:destroy) }
    it { is_expected.to have_one(:drone_ci_service).dependent(:destroy) }
    it { is_expected.to have_one(:emails_on_push_service).dependent(:destroy) }
    it { is_expected.to have_one(:builds_email_service).dependent(:destroy) }
    it { is_expected.to have_one(:emails_on_push_service).dependent(:destroy) }
    it { is_expected.to have_one(:irker_service).dependent(:destroy) }
    it { is_expected.to have_one(:pivotaltracker_service).dependent(:destroy) }
    it { is_expected.to have_one(:hipchat_service).dependent(:destroy) }
    it { is_expected.to have_one(:flowdock_service).dependent(:destroy) }
    it { is_expected.to have_one(:assembla_service).dependent(:destroy) }
K
Kamil Trzcinski 已提交
39
    it { is_expected.to have_one(:slack_slash_commands_service).dependent(:destroy) }
40
    it { is_expected.to have_one(:mattermost_slash_commands_service).dependent(:destroy) }
U
ubudzisz 已提交
41 42 43 44 45 46 47 48 49 50 51
    it { is_expected.to have_one(:gemnasium_service).dependent(:destroy) }
    it { is_expected.to have_one(:buildkite_service).dependent(:destroy) }
    it { is_expected.to have_one(:bamboo_service).dependent(:destroy) }
    it { is_expected.to have_one(:teamcity_service).dependent(:destroy) }
    it { is_expected.to have_one(:jira_service).dependent(:destroy) }
    it { is_expected.to have_one(:redmine_service).dependent(:destroy) }
    it { is_expected.to have_one(:custom_issue_tracker_service).dependent(:destroy) }
    it { is_expected.to have_one(:bugzilla_service).dependent(:destroy) }
    it { is_expected.to have_one(:gitlab_issue_tracker_service).dependent(:destroy) }
    it { is_expected.to have_one(:external_wiki_service).dependent(:destroy) }
    it { is_expected.to have_one(:project_feature).dependent(:destroy) }
M
Markus Koller 已提交
52
    it { is_expected.to have_one(:statistics).class_name('ProjectStatistics').dependent(:delete) }
U
ubudzisz 已提交
53 54 55
    it { is_expected.to have_one(:import_data).class_name('ProjectImportData').dependent(:destroy) }
    it { is_expected.to have_one(:last_event).class_name('Event') }
    it { is_expected.to have_one(:forked_from_project).through(:forked_project_link) }
K
Kamil Trzcinski 已提交
56
    it { is_expected.to have_many(:commit_statuses) }
57
    it { is_expected.to have_many(:pipelines) }
58 59 60 61 62
    it { is_expected.to have_many(:builds) }
    it { is_expected.to have_many(:runner_projects) }
    it { is_expected.to have_many(:runners) }
    it { is_expected.to have_many(:variables) }
    it { is_expected.to have_many(:triggers) }
K
Kamil Trzcinski 已提交
63
    it { is_expected.to have_many(:pages_domains) }
D
Douglas Barbosa Alexandre 已提交
64
    it { is_expected.to have_many(:labels).class_name('ProjectLabel').dependent(:destroy) }
U
ubudzisz 已提交
65
    it { is_expected.to have_many(:users_star_projects).dependent(:destroy) }
66 67
    it { is_expected.to have_many(:environments).dependent(:destroy) }
    it { is_expected.to have_many(:deployments).dependent(:destroy) }
68
    it { is_expected.to have_many(:todos).dependent(:destroy) }
U
ubudzisz 已提交
69 70 71 72 73
    it { is_expected.to have_many(:releases).dependent(:destroy) }
    it { is_expected.to have_many(:lfs_objects_projects).dependent(:destroy) }
    it { is_expected.to have_many(:project_group_links).dependent(:destroy) }
    it { is_expected.to have_many(:notification_settings).dependent(:destroy) }
    it { is_expected.to have_many(:forks).through(:forked_project_links) }
74

F
Felipe Artur 已提交
75 76
    context 'after initialized' do
      it "has a project_feature" do
77
        expect(Project.new.project_feature).to be_present
78 79 80
      end
    end

81
    describe '#members & #requesters' do
82
      let(:project) { create(:empty_project, :public, :access_requestable) }
83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107
      let(:requester) { create(:user) }
      let(:developer) { create(:user) }
      before do
        project.request_access(requester)
        project.team << [developer, :developer]
      end

      describe '#members' do
        it 'includes members and exclude requesters' do
          member_user_ids = project.members.pluck(:user_id)

          expect(member_user_ids).to include(developer.id)
          expect(member_user_ids).not_to include(requester.id)
        end
      end

      describe '#requesters' do
        it 'does not include requesters' do
          requester_user_ids = project.requesters.pluck(:user_id)

          expect(requester_user_ids).to include(requester.id)
          expect(requester_user_ids).not_to include(developer.id)
        end
      end
    end
108 109 110 111 112

    describe '#boards' do
      it 'raises an error when attempting to add more than one board to the project' do
        subject.boards.build

113
        expect { subject.boards.build }.to raise_error(Project::BoardLimitExceeded, 'Number of permitted boards exceeded')
114 115 116
        expect(subject.boards.size).to eq 1
      end
    end
G
gitlabhq 已提交
117 118
  end

119 120 121 122 123 124
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
125
    it { is_expected.to include_module(Gitlab::CurrentSettings) }
126 127
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
128 129
  end

130
  describe 'validation' do
131
    let!(:project) { create(:empty_project) }
132

133 134
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
135
    it { is_expected.to validate_length_of(:name).is_at_most(255) }
136

137 138
    it { is_expected.to validate_presence_of(:path) }
    it { is_expected.to validate_uniqueness_of(:path).scoped_to(:namespace_id) }
139 140 141 142
    it { is_expected.to validate_length_of(:path).is_at_most(255) }

    it { is_expected.to validate_length_of(:description).is_at_most(2000) }

143
    it { is_expected.to validate_presence_of(:creator) }
144

145
    it { is_expected.to validate_presence_of(:namespace) }
146

147
    it { is_expected.to validate_presence_of(:repository_storage) }
148

149
    it 'does not allow new projects beyond user limits' do
150
      project2 = build(:empty_project)
151 152
      allow(project2).to receive(:creator).and_return(double(can_create_project?: false, projects_limit: 0).as_null_object)
      expect(project2).not_to be_valid
P
Phil Hughes 已提交
153
      expect(project2.errors[:limit_reached].first).to match(/Personal project creation is not allowed/)
154
    end
155 156 157

    describe 'wiki path conflict' do
      context "when the new path has been used by the wiki of other Project" do
158
        it 'has an error on the name attribute' do
159
          new_project = build_stubbed(:empty_project, namespace_id: project.namespace_id, path: "#{project.path}.wiki")
160 161 162 163 164 165 166

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end

      context "when the new wiki path has been used by the path of other Project" do
167
        it 'has an error on the name attribute' do
168 169
          project_with_wiki_suffix = create(:empty_project, path: 'foo.wiki')
          new_project = build_stubbed(:empty_project, namespace_id: project_with_wiki_suffix.namespace_id, path: 'foo')
170 171 172 173 174 175

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end
    end
176 177

    context 'repository storages inclussion' do
178
      let(:project2) { build(:empty_project, repository_storage: 'missing') }
179 180 181 182 183 184

      before do
        storages = { 'custom' => 'tmp/tests/custom_repositories' }
        allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      end

185
      it "does not allow repository storages that don't match a label in the configuration" do
186 187 188 189
        expect(project2).not_to be_valid
        expect(project2.errors[:repository_storage].first).to match(/is not included in the list/)
      end
    end
190

191
    it 'does not allow an invalid URI as import_url' do
192
      project2 = build(:empty_project, import_url: 'invalid://')
J
James Lopez 已提交
193 194 195 196

      expect(project2).not_to be_valid
    end

197
    it 'does allow a valid URI as import_url' do
198
      project2 = build(:empty_project, import_url: 'ssh://test@gitlab.com/project.git')
J
James Lopez 已提交
199

200 201
      expect(project2).to be_valid
    end
202

203
    it 'allows an empty URI' do
204
      project2 = build(:empty_project, import_url: '')
205

206
      expect(project2).to be_valid
207 208 209
    end

    it 'does not produce import data on an empty URI' do
210
      project2 = build(:empty_project, import_url: '')
211 212 213 214 215

      expect(project2.import_data).to be_nil
    end

    it 'does not produce import data on an invalid URI' do
216
      project2 = build(:empty_project, import_url: 'test://')
217 218 219

      expect(project2.import_data).to be_nil
    end
220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239

    describe 'project pending deletion' do
      let!(:project_pending_deletion) do
        create(:empty_project,
               pending_delete: true)
      end
      let(:new_project) do
        build(:empty_project,
              name: project_pending_deletion.name,
              namespace: project_pending_deletion.namespace)
      end

      before do
        new_project.validate
      end

      it 'contains errors related to the project being deleted' do
        expect(new_project.errors.full_messages.first).to eq('The project is still being deleted. Please try again later.')
      end
    end
G
gitlabhq 已提交
240
  end
241

242 243 244 245 246 247 248 249 250
  describe 'default_scope' do
    it 'excludes projects pending deletion from the results' do
      project = create(:empty_project)
      create(:empty_project, pending_delete: true)

      expect(Project.all).to eq [project]
    end
  end

K
Kamil Trzcinski 已提交
251
  describe 'project token' do
252
    it 'sets an random token if none provided' do
K
Kamil Trzcinski 已提交
253 254
      project = FactoryGirl.create :empty_project, runners_token: ''
      expect(project.runners_token).not_to eq('')
K
Kamil Trzcinski 已提交
255 256
    end

U
ubudzisz 已提交
257
    it 'does not set an random token if one provided' do
K
Kamil Trzcinski 已提交
258 259
      project = FactoryGirl.create :empty_project, runners_token: 'my-token'
      expect(project.runners_token).to eq('my-token')
K
Kamil Trzcinski 已提交
260 261
    end
  end
G
gitlabhq 已提交
262

263
  describe 'Respond to' do
264 265 266 267 268
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
G
gitlabhq 已提交
269 270
  end

271 272 273 274 275 276 277
  describe 'delegation' do
    it { is_expected.to delegate_method(:add_guest).to(:team) }
    it { is_expected.to delegate_method(:add_reporter).to(:team) }
    it { is_expected.to delegate_method(:add_developer).to(:team) }
    it { is_expected.to delegate_method(:add_master).to(:team) }
  end

R
Rémy Coutable 已提交
278 279 280 281 282 283 284
  describe '#name_with_namespace' do
    let(:project) { build_stubbed(:empty_project) }

    it { expect(project.name_with_namespace).to eq "#{project.namespace.human_name} / #{project.name}" }
    it { expect(project.human_name).to eq project.name_with_namespace }
  end

285
  describe '#to_reference' do
286
    let(:owner)     { create(:user, name: 'Gitlab') }
287
    let(:namespace) { create(:namespace, path: 'sample-namespace', owner: owner) }
288 289
    let(:project)   { create(:empty_project, path: 'sample-project', namespace: namespace) }
    let(:group)     { create(:group, name: 'Group', path: 'sample-group', owner: owner) }
290

291
    context 'when nil argument' do
292 293 294 295 296
      it 'returns nil' do
        expect(project.to_reference).to be_nil
      end
    end

297
    context 'when full is true' do
298
      it 'returns complete path to the project' do
299 300 301
        expect(project.to_reference(full: true)).to          eq 'sample-namespace/sample-project'
        expect(project.to_reference(project, full: true)).to eq 'sample-namespace/sample-project'
        expect(project.to_reference(group, full: true)).to   eq 'sample-namespace/sample-project'
302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
      let(:another_namespace_project) { create(:empty_project, name: 'another-project') }

      it 'returns complete path to the project' do
        expect(project.to_reference(another_namespace_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when same namespace / cross-project argument' do
      let(:another_project) { create(:empty_project, namespace: namespace) }

322
      it 'returns path to the project' do
323 324 325
        expect(project.to_reference(another_project)).to eq 'sample-project'
      end
    end
326

327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346
    context 'when different namespace / cross-project argument' do
      let(:another_namespace) { create(:namespace, path: 'another-namespace', owner: owner) }
      let(:another_project)   { create(:empty_project, path: 'another-project', namespace: another_namespace) }

      it 'returns full path to the project' do
        expect(project.to_reference(another_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when argument is a namespace' do
      context 'with same project path' do
        it 'returns path to the project' do
          expect(project.to_reference(namespace)).to eq 'sample-project'
        end
      end

      context 'with different project path' do
        it 'returns full path to the project' do
          expect(project.to_reference(group)).to eq 'sample-namespace/sample-project'
        end
347 348
      end
    end
349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381
  end

  describe '#to_human_reference' do
    let(:owner) { create(:user, name: 'Gitlab') }
    let(:namespace) { create(:namespace, name: 'Sample namespace', owner: owner) }
    let(:project) { create(:empty_project, name: 'Sample project', namespace: namespace) }

    context 'when nil argument' do
      it 'returns nil' do
        expect(project.to_human_reference).to be_nil
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_human_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
      let(:another_namespace_project) { create(:empty_project, name: 'another-project') }

      it 'returns complete name with namespace of the project' do
        expect(project.to_human_reference(another_namespace_project)).to eq 'Gitlab / Sample project'
      end
    end

    context 'when same namespace / cross-project argument' do
      let(:another_project) { create(:empty_project, namespace: namespace) }

      it 'returns name of the project' do
        expect(project.to_human_reference(another_project)).to eq 'Sample project'
      end
382 383 384
    end
  end

385
  describe '#repository_storage_path' do
386
    let(:project) { create(:empty_project, repository_storage: 'custom') }
387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402

    before do
      FileUtils.mkdir('tmp/tests/custom_repositories')
      storages = { 'custom' => 'tmp/tests/custom_repositories' }
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

    after do
      FileUtils.rm_rf('tmp/tests/custom_repositories')
    end

    it 'returns the repository storage path' do
      expect(project.repository_storage_path).to eq('tmp/tests/custom_repositories')
    end
  end

403
  it 'returns valid url to repo' do
404
    project = Project.new(path: 'somewhere')
405
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
G
gitlabhq 已提交
406 407
  end

D
Douwe Maan 已提交
408 409 410 411 412 413
  describe "#web_url" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the full web URL for this repo' do
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.path}/somewhere")
    end
A
Ariejan de Vroom 已提交
414 415
  end

416
  describe "#new_issue_address" do
417 418 419
    let(:project) { create(:empty_project, path: "somewhere") }
    let(:user) { create(:user) }

420 421 422 423 424 425
    context 'incoming email enabled' do
      before do
        stub_incoming_email_setting(enabled: true, address: "p+%{key}@gl.ab")
      end

      it 'returns the address to create a new issue' do
426
        address = "p+#{project.path_with_namespace}+#{user.incoming_email_token}@gl.ab"
427 428 429 430 431 432 433 434 435

        expect(project.new_issue_address(user)).to eq(address)
      end
    end

    context 'incoming email disabled' do
      before do
        stub_incoming_email_setting(enabled: false)
      end
436

437 438 439
      it 'returns nil' do
        expect(project.new_issue_address(user)).to be_nil
      end
440 441 442
    end
  end

443
  describe 'last_activity methods' do
S
Stan Hu 已提交
444 445
    let(:timestamp) { 2.hours.ago }
    # last_activity_at gets set to created_at upon creation
446
    let(:project) { create(:empty_project, created_at: timestamp, updated_at: timestamp) }
G
gitlabhq 已提交
447

448
    describe 'last_activity' do
449
      it 'alias last_activity to last_event' do
450 451
        last_event = create(:event, project: project)

452
        expect(project.last_activity).to eq(last_event)
453
      end
G
gitlabhq 已提交
454 455
    end

456 457
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
458 459
        new_event = create(:event, project: project, created_at: Time.now)

S
Stan Hu 已提交
460
        project.reload
461
        expect(project.last_activity_at.to_i).to eq(new_event.created_at.to_i)
462
      end
463

464
      it 'returns the project\'s last update date if it has no events' do
465
        expect(project.last_activity_date).to eq(project.updated_at)
466
      end
467 468
    end
  end
469

470 471
  describe '#get_issue' do
    let(:project) { create(:empty_project) }
S
Stan Hu 已提交
472
    let!(:issue)  { create(:issue, project: project) }
473 474 475 476 477
    let(:user)    { create(:user) }

    before do
      project.team << [user, :developer]
    end
478 479 480

    context 'with default issues tracker' do
      it 'returns an issue' do
481
        expect(project.get_issue(issue.iid, user)).to eq issue
482 483
      end

S
Stan Hu 已提交
484 485 486 487
      it 'returns count of open issues' do
        expect(project.open_issues_count).to eq(1)
      end

488
      it 'returns nil when no issue found' do
489 490 491 492 493 494
        expect(project.get_issue(999, user)).to be_nil
      end

      it "returns nil when user doesn't have access" do
        user = create(:user)
        expect(project.get_issue(issue.iid, user)).to eq nil
495 496 497 498 499 500 501 502 503
      end
    end

    context 'with external issues tracker' do
      before do
        allow(project).to receive(:default_issues_tracker?).and_return(false)
      end

      it 'returns an ExternalIssue' do
504
        issue = project.get_issue('FOO-1234', user)
505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525
        expect(issue).to be_kind_of(ExternalIssue)
        expect(issue.iid).to eq 'FOO-1234'
        expect(issue.project).to eq project
      end
    end
  end

  describe '#issue_exists?' do
    let(:project) { create(:empty_project) }

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

L
Lin Jen-Shin 已提交
526
  describe '#to_param' do
527 528 529
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
530
        @project = create(:empty_project, name: 'gitlabhq', namespace: @group)
531 532
      end

V
Vinnie Okada 已提交
533
      it { expect(@project.to_param).to eq('gitlabhq') }
534
    end
535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552

    context 'with invalid path' do
      it 'returns previous path to keep project suitable for use in URLs when persisted' do
        project = create(:empty_project, path: 'gitlab')
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'gitlab'
      end

      it 'returns current path when new record' do
        project = build(:empty_project, path: 'gitlab')
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'foo&bar'
      end
    end
553
  end
D
Dmitriy Zaporozhets 已提交
554

L
Lin Jen-Shin 已提交
555
  describe '#repository' do
556
    let(:project) { create(:project, :repository) }
D
Dmitriy Zaporozhets 已提交
557

558
    it 'returns valid repo' do
559
      expect(project.repository).to be_kind_of(Repository)
D
Dmitriy Zaporozhets 已提交
560 561
    end
  end
562

L
Lin Jen-Shin 已提交
563
  describe '#default_issues_tracker?' do
564
    it "is true if used internal tracker" do
565 566
      project = build(:empty_project)

567
      expect(project.default_issues_tracker?).to be_truthy
568 569
    end

570
    it "is false if used other tracker" do
571 572 573 574
      # NOTE: The current nature of this factory requires persistence
      project = create(:redmine_project)

      expect(project.default_issues_tracker?).to be_falsey
575 576 577
    end
  end

L
Lin Jen-Shin 已提交
578
  describe '#external_issue_tracker' do
579
    let(:project) { create(:empty_project) }
580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612
    let(:ext_project) { create(:redmine_project) }

    context 'on existing projects with no value for has_external_issue_tracker' do
      before(:each) do
        project.update_column(:has_external_issue_tracker, nil)
        ext_project.update_column(:has_external_issue_tracker, nil)
      end

      it 'updates the has_external_issue_tracker boolean' do
        expect do
          project.external_issue_tracker
        end.to change { project.reload.has_external_issue_tracker }.to(false)

        expect do
          ext_project.external_issue_tracker
        end.to change { ext_project.reload.has_external_issue_tracker }.to(true)
      end
    end

    it 'returns nil and does not query services when there is no external issue tracker' do
      expect(project).not_to receive(:services)

      expect(project.external_issue_tracker).to eq(nil)
    end

    it 'retrieves external_issue_tracker querying services and cache it when there is external issue tracker' do
      ext_project.reload # Factory returns a project with changed attributes
      expect(ext_project).to receive(:services).once.and_call_original

      2.times { expect(ext_project.external_issue_tracker).to be_a_kind_of(RedmineService) }
    end
  end

L
Lin Jen-Shin 已提交
613
  describe '#cache_has_external_issue_tracker' do
614
    let(:project) { create(:empty_project, has_external_issue_tracker: nil) }
615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634

    it 'stores true if there is any external_issue_tracker' do
      services = double(:service, external_issue_trackers: [RedmineService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(true)
    end

    it 'stores false if there is no external_issue_tracker' do
      services = double(:service, external_issue_trackers: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(false)
    end
  end

635
  describe '#has_wiki?' do
636
    let(:no_wiki_project)       { create(:empty_project, :wiki_disabled, has_external_wiki: false) }
637 638
    let(:wiki_enabled_project)  { create(:empty_project) }
    let(:external_wiki_project) { create(:empty_project, has_external_wiki: true) }
639 640 641 642 643 644 645 646

    it 'returns true if project is wiki enabled or has external wiki' do
      expect(wiki_enabled_project).to have_wiki
      expect(external_wiki_project).to have_wiki
      expect(no_wiki_project).not_to have_wiki
    end
  end

647
  describe '#external_wiki' do
648
    let(:project) { create(:empty_project) }
649

650 651 652 653 654
    context 'with an active external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: true)
        project.external_wiki
      end
655

656 657 658
      it 'sets :has_external_wiki as true' do
        expect(project.has_external_wiki).to be(true)
      end
659

660 661
      it 'sets :has_external_wiki as false if an external wiki service is destroyed later' do
        expect(project.has_external_wiki).to be(true)
662

663 664 665 666
        project.services.external_wikis.first.destroy

        expect(project.has_external_wiki).to be(false)
      end
667 668
    end

669 670 671 672
    context 'with an inactive external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: false)
      end
673

674 675 676
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end
677 678
    end

679 680 681 682
    context 'with no external wiki' do
      before do
        project.external_wiki
      end
683

684 685 686 687 688 689 690 691 692 693 694
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end

      it 'sets :has_external_wiki as true if an external wiki service is created later' do
        expect(project.has_external_wiki).to be(false)

        create(:service, project: project, type: 'ExternalWikiService', active: true)

        expect(project.has_external_wiki).to be(true)
      end
695 696 697
    end
  end

L
Lin Jen-Shin 已提交
698
  describe '#open_branches' do
699
    let(:project) { create(:project, :repository) }
700 701 702 703 704

    before do
      project.protected_branches.create(name: 'master')
    end

705 706
    it { expect(project.open_branches.map(&:name)).to include('feature') }
    it { expect(project.open_branches.map(&:name)).not_to include('master') }
707

708
    it "includes branches matching a protected branch wildcard" do
709 710 711 712
      expect(project.open_branches.map(&:name)).to include('feature')

      create(:protected_branch, name: 'feat*', project: project)

713
      expect(Project.find(project.id).open_branches.map(&:name)).to include('feature')
714
    end
715
  end
C
Ciro Santilli 已提交
716

717 718
  describe '#star_count' do
    it 'counts stars from multiple users' do
C
Ciro Santilli 已提交
719 720
      user1 = create :user
      user2 = create :user
721
      project = create(:empty_project, :public)
C
Ciro Santilli 已提交
722 723

      expect(project.star_count).to eq(0)
724

C
Ciro Santilli 已提交
725
      user1.toggle_star(project)
726 727
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
728
      user2.toggle_star(project)
729 730 731
      project.reload
      expect(project.reload.star_count).to eq(2)

C
Ciro Santilli 已提交
732
      user1.toggle_star(project)
733 734 735
      project.reload
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
736
      user2.toggle_star(project)
737 738 739 740
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

741
    it 'counts stars on the right project' do
742
      user = create :user
743 744
      project1 = create(:empty_project, :public)
      project2 = create(:empty_project, :public)
745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
C
Ciro Santilli 已提交
772 773
    end
  end
774

L
Lin Jen-Shin 已提交
775
  describe '#avatar_type' do
776
    let(:project) { create(:empty_project) }
777

778
    it 'is true if avatar is image' do
779
      project.update_attribute(:avatar, 'uploads/avatar.png')
780
      expect(project.avatar_type).to be_truthy
781 782
    end

783
    it 'is false if avatar is html page' do
784
      project.update_attribute(:avatar, 'uploads/avatar.html')
785
      expect(project.avatar_type).to eq(['only images allowed'])
786 787
    end
  end
S
sue445 已提交
788

L
Lin Jen-Shin 已提交
789
  describe '#avatar_url' do
S
sue445 已提交
790 791
    subject { project.avatar_url }

792
    let(:project) { create(:empty_project) }
S
sue445 已提交
793 794 795 796 797 798 799 800 801 802 803

    context 'When avatar file is uploaded' do
      before do
        project.update_columns(avatar: 'uploads/avatar.png')
        allow(project.avatar).to receive(:present?) { true }
      end

      let(:avatar_path) do
        "/uploads/project/avatar/#{project.id}/uploads/avatar.png"
      end

804
      it { should eq "http://#{Gitlab.config.gitlab.host}#{avatar_path}" }
S
sue445 已提交
805 806 807 808 809 810 811 812 813 814 815
    end

    context 'When avatar file in git' do
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

      let(:avatar_path) do
        "/#{project.namespace.name}/#{project.path}/avatar"
      end

816
      it { should eq "http://#{Gitlab.config.gitlab.host}#{avatar_path}" }
S
sue445 已提交
817
    end
818 819 820 821 822 823

    context 'when git repo is empty' do
      let(:project) { create(:empty_project) }

      it { should eq nil }
    end
S
sue445 已提交
824
  end
825

826
  describe '#pipeline_for' do
827
    let(:project) { create(:project, :repository) }
828
    let!(:pipeline) { create_pipeline }
K
Kamil Trzcinski 已提交
829

830 831
    shared_examples 'giving the correct pipeline' do
      it { is_expected.to eq(pipeline) }
K
Kamil Trzcinski 已提交
832

833 834
      context 'return latest' do
        let!(:pipeline2) { create_pipeline }
K
Kamil Trzcinski 已提交
835

836
        it { is_expected.to eq(pipeline2) }
K
Kamil Trzcinski 已提交
837
      end
838 839 840 841 842 843 844 845 846 847 848 849 850
    end

    context 'with explicit sha' do
      subject { project.pipeline_for('master', pipeline.sha) }

      it_behaves_like 'giving the correct pipeline'
    end

    context 'with implicit sha' do
      subject { project.pipeline_for('master') }

      it_behaves_like 'giving the correct pipeline'
    end
K
Kamil Trzcinski 已提交
851

852 853 854 855 856
    def create_pipeline
      create(:ci_pipeline,
             project: project,
             ref: 'master',
             sha: project.commit('master').sha)
K
Kamil Trzcinski 已提交
857
    end
858
  end
859

L
Lin Jen-Shin 已提交
860
  describe '#builds_enabled' do
861
    let(:project) { create(:empty_project) }
862

863 864 865
    subject { project.builds_enabled }

    it { expect(project.builds_enabled?).to be_truthy }
866
  end
Y
Yorick Peterse 已提交
867

868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887
  describe '.with_shared_runners' do
    subject { Project.with_shared_runners }

    context 'when shared runners are enabled for project' do
      let!(:project) { create(:empty_project, shared_runners_enabled: true) }

      it "returns a project" do
        is_expected.to eq([project])
      end
    end

    context 'when shared runners are disabled for project' do
      let!(:project) { create(:empty_project, shared_runners_enabled: false) }

      it "returns an empty array" do
        is_expected.to be_empty
      end
    end
  end

888 889 890 891 892 893 894 895 896 897 898 899 900 901
  describe '.cached_count', caching: true do
    let(:group)     { create(:group, :public) }
    let!(:project1) { create(:empty_project, :public, group: group) }
    let!(:project2) { create(:empty_project, :public, group: group) }

    it 'returns total project count' do
      expect(Project).to receive(:count).once.and_call_original

      3.times do
        expect(Project.cached_count).to eq(2)
      end
    end
  end

Y
Yorick Peterse 已提交
902
  describe '.trending' do
F
Felipe Artur 已提交
903
    let(:group)    { create(:group, :public) }
Y
Yorick Peterse 已提交
904 905 906 907 908 909 910 911 912 913
    let(:project1) { create(:empty_project, :public, group: group) }
    let(:project2) { create(:empty_project, :public, group: group) }

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)

Y
Yorick Peterse 已提交
914
      TrendingProject.refresh!
Y
Yorick Peterse 已提交
915 916
    end

Y
Yorick Peterse 已提交
917
    subject { described_class.trending.to_a }
Y
Yorick Peterse 已提交
918

Y
Yorick Peterse 已提交
919 920
    it 'sorts projects by the amount of notes in descending order' do
      expect(subject).to eq([project1, project2])
Y
Yorick Peterse 已提交
921
    end
922 923 924 925 926 927 928 929

    it 'does not take system notes into account' do
      10.times do
        create(:note_on_commit, project: project2, system: true)
      end

      expect(described_class.trending.to_a).to eq([project1, project2])
    end
Y
Yorick Peterse 已提交
930
  end
Y
Yorick Peterse 已提交
931 932

  describe '.visible_to_user' do
933
    let!(:project) { create(:empty_project, :private) }
Y
Yorick Peterse 已提交
934 935 936 937 938 939
    let!(:user)    { create(:user) }

    subject { described_class.visible_to_user(user) }

    describe 'when a user has access to a project' do
      before do
940
        project.add_user(user, Gitlab::Access::MASTER)
Y
Yorick Peterse 已提交
941 942 943 944 945 946 947 948 949
      end

      it { is_expected.to eq([project]) }
    end

    describe 'when a user does not have access to any projects' do
      it { is_expected.to eq([]) }
    end
  end
K
Kamil Trzcinski 已提交
950

951 952 953 954
  context 'repository storage by default' do
    let(:project) { create(:empty_project) }

    before do
955 956 957 958
      storages = {
        'default' => 'tmp/tests/repositories',
        'picked'  => 'tmp/tests/repositories',
      }
959 960 961
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

962 963 964 965 966
    it 'picks storage from ApplicationSetting' do
      expect_any_instance_of(ApplicationSetting).to receive(:pick_repository_storage).and_return('picked')

      expect(project.repository_storage).to eq('picked')
    end
967 968
  end

K
Kamil Trzcinski 已提交
969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986
  context 'shared runners by default' do
    let(:project) { create(:empty_project) }

    subject { project.shared_runners_enabled }

    context 'are enabled' do
      before { stub_application_setting(shared_runners_enabled: true) }

      it { is_expected.to be_truthy }
    end

    context 'are disabled' do
      before { stub_application_setting(shared_runners_enabled: false) }

      it { is_expected.to be_falsey }
    end
  end

L
Lin Jen-Shin 已提交
987
  describe '#any_runners' do
K
Kamil Trzcinski 已提交
988
    let(:project) { create(:empty_project, shared_runners_enabled: shared_runners_enabled) }
989 990
    let(:specific_runner) { create(:ci_runner) }
    let(:shared_runner) { create(:ci_runner, :shared) }
K
Kamil Trzcinski 已提交
991 992 993

    context 'for shared runners disabled' do
      let(:shared_runners_enabled) { false }
994

995
      it 'has no runners available' do
K
Kamil Trzcinski 已提交
996 997
        expect(project.any_runners?).to be_falsey
      end
998

999
      it 'has a specific runner' do
1000
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
1001 1002
        expect(project.any_runners?).to be_truthy
      end
1003

1004
      it 'has a shared runner, but they are prohibited to use' do
K
Kamil Trzcinski 已提交
1005 1006 1007
        shared_runner
        expect(project.any_runners?).to be_falsey
      end
1008

K
Kamil Trzcinski 已提交
1009
      it 'checks the presence of specific runner' do
1010
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
1011 1012 1013
        expect(project.any_runners? { |runner| runner == specific_runner }).to be_truthy
      end
    end
1014

K
Kamil Trzcinski 已提交
1015 1016
    context 'for shared runners enabled' do
      let(:shared_runners_enabled) { true }
1017

1018
      it 'has a shared runner' do
K
Kamil Trzcinski 已提交
1019 1020 1021 1022 1023 1024 1025 1026 1027 1028
        shared_runner
        expect(project.any_runners?).to be_truthy
      end

      it 'checks the presence of shared runner' do
        shared_runner
        expect(project.any_runners? { |runner| runner == shared_runner }).to be_truthy
      end
    end
  end
1029

1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051
  describe '#shared_runners' do
    let!(:runner) { create(:ci_runner, :shared) }

    subject { project.shared_runners }

    context 'when shared runners are enabled for project' do
      let!(:project) { create(:empty_project, shared_runners_enabled: true) }

      it "returns a list of shared runners" do
        is_expected.to eq([runner])
      end
    end

    context 'when shared runners are disabled for project' do
      let!(:project) { create(:empty_project, shared_runners_enabled: false) }

      it "returns a empty list" do
        is_expected.to be_empty
      end
    end
  end

1052
  describe '#visibility_level_allowed?' do
1053
    let(:project) { create(:empty_project, :internal) }
1054 1055 1056 1057 1058 1059 1060 1061

    context 'when checking on non-forked project' do
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_truthy }
    end

    context 'when checking on forked project' do
1062 1063
      let(:project)        { create(:empty_project, :internal) }
      let(:forked_project) { create(:empty_project, forked_from_project: project) }
1064 1065 1066 1067 1068

      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
1069
  end
1070

1071 1072 1073 1074 1075 1076
  describe '#pages_deployed?' do
    let(:project) { create :empty_project }

    subject { project.pages_deployed? }

    context 'if public folder does exist' do
1077
      before { allow(Dir).to receive(:exist?).with(project.public_pages_path).and_return(true) }
1078 1079 1080 1081 1082 1083 1084 1085 1086

      it { is_expected.to be_truthy }
    end

    context "if public folder doesn't exist" do
      it { is_expected.to be_falsey }
    end
  end

1087
  describe '.search' do
1088
    let(:project) { create(:empty_project, description: 'kitten mittens') }
1089

1090 1091 1092
    it 'returns projects with a matching name' do
      expect(described_class.search(project.name)).to eq([project])
    end
1093

1094 1095 1096
    it 'returns projects with a partially matching name' do
      expect(described_class.search(project.name[0..2])).to eq([project])
    end
1097

1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136
    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search(project.name.upcase)).to eq([project])
    end

    it 'returns projects with a matching description' do
      expect(described_class.search(project.description)).to eq([project])
    end

    it 'returns projects with a partially matching description' do
      expect(described_class.search('kitten')).to eq([project])
    end

    it 'returns projects with a matching description regardless of the casing' do
      expect(described_class.search('KITTEN')).to eq([project])
    end

    it 'returns projects with a matching path' do
      expect(described_class.search(project.path)).to eq([project])
    end

    it 'returns projects with a partially matching path' do
      expect(described_class.search(project.path[0..2])).to eq([project])
    end

    it 'returns projects with a matching path regardless of the casing' do
      expect(described_class.search(project.path.upcase)).to eq([project])
    end

    it 'returns projects with a matching namespace name' do
      expect(described_class.search(project.namespace.name)).to eq([project])
    end

    it 'returns projects with a partially matching namespace name' do
      expect(described_class.search(project.namespace.name[0..2])).to eq([project])
    end

    it 'returns projects with a matching namespace name regardless of the casing' do
      expect(described_class.search(project.namespace.name.upcase)).to eq([project])
    end
1137 1138 1139 1140 1141

    it 'returns projects when eager loading namespaces' do
      relation = described_class.all.includes(:namespace)

      expect(relation.search(project.namespace.name)).to eq([project])
1142
    end
1143
  end
1144 1145

  describe '#rename_repo' do
1146
    let(:project) { create(:project, :repository) }
1147 1148 1149 1150 1151 1152 1153 1154
    let(:gitlab_shell) { Gitlab::Shell.new }

    before do
      # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
      # call. This makes testing a bit easier.
      allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)

      allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
K
Kamil Trzcinski 已提交
1155
    end
1156

K
Kamil Trzcinski 已提交
1157
    it 'renames a repository' do
1158 1159 1160 1161
      ns = project.namespace_dir

      expect(gitlab_shell).to receive(:mv_repository).
        ordered.
1162
        with(project.repository_storage_path, "#{ns}/foo", "#{ns}/#{project.path}").
1163 1164 1165 1166
        and_return(true)

      expect(gitlab_shell).to receive(:mv_repository).
        ordered.
1167
        with(project.repository_storage_path, "#{ns}/foo.wiki", "#{ns}/#{project.path}.wiki").
1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181
        and_return(true)

      expect_any_instance_of(SystemHooksService).
        to receive(:execute_hooks_for).
        with(project, :rename)

      expect_any_instance_of(Gitlab::UploadsTransfer).
        to receive(:rename_project).
        with('foo', project.path, ns)

      expect(project).to receive(:expire_caches_before_rename)

      project.rename_repo
    end
K
Kamil Trzcinski 已提交
1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192

    context 'container registry with tags' do
      before do
        stub_container_registry_config(enabled: true)
        stub_container_registry_tags('tag')
      end

      subject { project.rename_repo }

      it { expect{subject}.to raise_error(Exception) }
    end
1193 1194 1195
  end

  describe '#expire_caches_before_rename' do
1196
    let(:project) { create(:project, :repository) }
1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208
    let(:repo)    { double(:repo, exists?: true) }
    let(:wiki)    { double(:wiki, exists?: true) }

    it 'expires the caches of the repository and wiki' do
      allow(Repository).to receive(:new).
        with('foo', project).
        and_return(repo)

      allow(Repository).to receive(:new).
        with('foo.wiki', project).
        and_return(wiki)

1209 1210
      expect(repo).to receive(:before_delete)
      expect(wiki).to receive(:before_delete)
1211 1212 1213 1214

      project.expire_caches_before_rename('foo')
    end
  end
1215 1216

  describe '.search_by_title' do
1217
    let(:project) { create(:empty_project, name: 'kittens') }
1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230

    it 'returns projects with a matching name' do
      expect(described_class.search_by_title(project.name)).to eq([project])
    end

    it 'returns projects with a partially matching name' do
      expect(described_class.search_by_title('kitten')).to eq([project])
    end

    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search_by_title('KITTENS')).to eq([project])
    end
  end
1231 1232 1233 1234 1235

  context 'when checking projects from groups' do
    let(:private_group)    { create(:group, visibility_level: 0)  }
    let(:internal_group)   { create(:group, visibility_level: 10) }

1236 1237
    let(:private_project)  { create :empty_project, :private, group: private_group }
    let(:internal_project) { create :empty_project, :internal, group: internal_group }
1238 1239 1240 1241 1242 1243 1244 1245 1246

    context 'when group is private project can not be internal' do
      it { expect(private_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_falsey }
    end

    context 'when group is internal project can not be public' do
      it { expect(internal_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
  end
1247

1248
  describe '#create_repository' do
1249
    let(:project) { create(:project, :repository) }
1250 1251 1252 1253 1254 1255 1256 1257 1258
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    context 'using a regular repository' do
      it 'creates the repository' do
        expect(shell).to receive(:add_repository).
1259
          with(project.repository_storage_path, project.path_with_namespace).
1260 1261 1262 1263 1264 1265 1266 1267 1268
          and_return(true)

        expect(project.repository).to receive(:after_create)

        expect(project.create_repository).to eq(true)
      end

      it 'adds an error if the repository could not be created' do
        expect(shell).to receive(:add_repository).
1269
          with(project.repository_storage_path, project.path_with_namespace).
1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287
          and_return(false)

        expect(project.repository).not_to receive(:after_create)

        expect(project.create_repository).to eq(false)
        expect(project.errors).not_to be_empty
      end
    end

    context 'using a forked repository' do
      it 'does nothing' do
        expect(project).to receive(:forked?).and_return(true)
        expect(shell).not_to receive(:add_repository)

        project.create_repository
      end
    end
  end
1288 1289

  describe '#protected_branch?' do
1290
    context 'existing project' do
1291
      let(:project) { create(:project, :repository) }
1292 1293

      it 'returns true when the branch matches a protected branch via direct match' do
1294
        create(:protected_branch, project: project, name: "foo")
1295 1296 1297 1298 1299

        expect(project.protected_branch?('foo')).to eq(true)
      end

      it 'returns true when the branch matches a protected branch via wildcard match' do
1300
        create(:protected_branch, project: project, name: "production/*")
1301 1302 1303 1304 1305 1306 1307 1308 1309

        expect(project.protected_branch?('production/some-branch')).to eq(true)
      end

      it 'returns false when the branch does not match a protected branch via direct match' do
        expect(project.protected_branch?('foo')).to eq(false)
      end

      it 'returns false when the branch does not match a protected branch via wildcard match' do
1310
        create(:protected_branch, project: project, name: "production/*")
1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344

        expect(project.protected_branch?('staging/some-branch')).to eq(false)
      end
    end

    context "new project" do
      let(:project) { create(:empty_project) }

      it 'returns false when default_protected_branch is unprotected' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)

        expect(project.protected_branch?('master')).to be false
      end

      it 'returns false when default_protected_branch lets developers push' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)

        expect(project.protected_branch?('master')).to be false
      end

      it 'returns true when default_branch_protection does not let developers push but let developer merge branches' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)

        expect(project.protected_branch?('master')).to be true
      end

      it 'returns true when default_branch_protection is in full protection' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_FULL)

        expect(project.protected_branch?('master')).to be true
      end
    end
  end

1345
  describe '#user_can_push_to_empty_repo?' do
1346
    let(:project) { create(:empty_project) }
1347
    let(:user)    { create(:user) }
1348

1349 1350 1351
    it 'returns false when default_branch_protection is in full protection and user is developer' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_FULL)
1352

1353
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1354 1355
    end

1356 1357 1358
    it 'returns false when default_branch_protection only lets devs merge and user is dev' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)
1359

1360
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1361 1362
    end

1363 1364 1365
    it 'returns true when default_branch_protection lets devs push and user is developer' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)
1366

1367 1368
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
    end
1369

1370 1371 1372
    it 'returns true when default_branch_protection is unprotected and user is developer' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)
1373

1374
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1375
    end
1376

1377 1378
    it 'returns true when user is master' do
      project.team << [user, :master]
1379

1380
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1381 1382 1383
    end
  end

1384 1385 1386 1387 1388 1389 1390 1391 1392
  describe '#container_registry_path_with_namespace' do
    let(:project) { create(:empty_project, path: 'PROJECT') }

    subject { project.container_registry_path_with_namespace }

    it { is_expected.not_to eq(project.path_with_namespace) }
    it { is_expected.to eq(project.path_with_namespace.downcase) }
  end

K
Kamil Trzcinski 已提交
1393 1394 1395
  describe '#container_registry_repository' do
    let(:project) { create(:empty_project) }

K
Kamil Trzcinski 已提交
1396 1397
    before { stub_container_registry_config(enabled: true) }

K
Kamil Trzcinski 已提交
1398 1399
    subject { project.container_registry_repository }

1400
    it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1401 1402 1403 1404 1405 1406 1407
  end

  describe '#container_registry_repository_url' do
    let(:project) { create(:empty_project) }

    subject { project.container_registry_repository_url }

1408
    before { stub_container_registry_config(**registry_settings) }
K
Kamil Trzcinski 已提交
1409 1410 1411 1412 1413 1414 1415 1416 1417

    context 'for enabled registry' do
      let(:registry_settings) do
        {
          enabled: true,
          host_port: 'example.com',
        }
      end

1418
      it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437
    end

    context 'for disabled registry' do
      let(:registry_settings) do
        {
          enabled: false
        }
      end

      it { is_expected.to be_nil }
    end
  end

  describe '#has_container_registry_tags?' do
    let(:project) { create(:empty_project) }

    subject { project.has_container_registry_tags? }

    context 'for enabled registry' do
1438
      before { stub_container_registry_config(enabled: true) }
K
Kamil Trzcinski 已提交
1439 1440

      context 'with tags' do
K
Kamil Trzcinski 已提交
1441
        before { stub_container_registry_tags('test', 'test2') }
K
Kamil Trzcinski 已提交
1442 1443 1444 1445 1446

        it { is_expected.to be_truthy }
      end

      context 'when no tags' do
K
Kamil Trzcinski 已提交
1447
        before { stub_container_registry_tags }
K
Kamil Trzcinski 已提交
1448 1449 1450 1451 1452 1453

        it { is_expected.to be_falsey }
      end
    end

    context 'for disabled registry' do
1454
      before { stub_container_registry_config(enabled: false) }
K
Kamil Trzcinski 已提交
1455 1456 1457 1458

      it { is_expected.to be_falsey }
    end
  end
Y
Yorick Peterse 已提交
1459

1460
  describe '#latest_successful_builds_for' do
L
Lin Jen-Shin 已提交
1461
    def create_pipeline(status = 'success')
1462
      create(:ci_pipeline, project: project,
L
Lin Jen-Shin 已提交
1463
                           sha: project.commit.sha,
1464
                           ref: project.default_branch,
L
Lin Jen-Shin 已提交
1465
                           status: status)
1466 1467
    end

L
Lin Jen-Shin 已提交
1468 1469 1470
    def create_build(new_pipeline = pipeline, name = 'test')
      create(:ci_build, :success, :artifacts,
             pipeline: new_pipeline,
L
Lin Jen-Shin 已提交
1471
             status: new_pipeline.status,
L
Lin Jen-Shin 已提交
1472
             name: name)
1473 1474
    end

1475
    let(:project) { create(:project, :repository) }
L
Lin Jen-Shin 已提交
1476
    let(:pipeline) { create_pipeline }
L
Lin Jen-Shin 已提交
1477 1478

    context 'with many builds' do
1479
      it 'gives the latest builds from latest pipeline' do
1480 1481
        pipeline1 = create_pipeline
        pipeline2 = create_pipeline
1482
        build1_p2 = create_build(pipeline2, 'test')
1483 1484
        create_build(pipeline1, 'test')
        create_build(pipeline1, 'test2')
1485
        build2_p2 = create_build(pipeline2, 'test2')
L
Lin Jen-Shin 已提交
1486 1487 1488

        latest_builds = project.latest_successful_builds_for

1489
        expect(latest_builds).to contain_exactly(build2_p2, build1_p2)
L
Lin Jen-Shin 已提交
1490 1491
      end
    end
L
Lin Jen-Shin 已提交
1492

L
Lin Jen-Shin 已提交
1493
    context 'with succeeded pipeline' do
L
Lin Jen-Shin 已提交
1494
      let!(:build) { create_build }
1495

L
Lin Jen-Shin 已提交
1496
      context 'standalone pipeline' do
1497 1498 1499 1500 1501 1502 1503 1504
        it 'returns builds for ref for default_branch' do
          builds = project.latest_successful_builds_for

          expect(builds).to contain_exactly(build)
        end

        it 'returns empty relation if the build cannot be found' do
          builds = project.latest_successful_builds_for('TAIL')
1505

1506 1507 1508
          expect(builds).to be_kind_of(ActiveRecord::Relation)
          expect(builds).to be_empty
        end
1509 1510
      end

L
Lin Jen-Shin 已提交
1511
      context 'with some pending pipeline' do
1512
        before do
L
Lin Jen-Shin 已提交
1513
          create_build(create_pipeline('pending'))
1514 1515
        end

L
Lin Jen-Shin 已提交
1516 1517
        it 'gives the latest build from latest pipeline' do
          latest_build = project.latest_successful_builds_for
1518

L
Lin Jen-Shin 已提交
1519
          expect(latest_build).to contain_exactly(build)
1520
        end
1521 1522 1523 1524 1525 1526
      end
    end

    context 'with pending pipeline' do
      before do
        pipeline.update(status: 'pending')
L
Lin Jen-Shin 已提交
1527
        create_build(pipeline)
1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538
      end

      it 'returns empty relation' do
        builds = project.latest_successful_builds_for

        expect(builds).to be_kind_of(ActiveRecord::Relation)
        expect(builds).to be_empty
      end
    end
  end

1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554
  describe '#add_import_job' do
    context 'forked' do
      let(:forked_project_link) { create(:forked_project_link) }
      let(:forked_from_project) { forked_project_link.forked_from_project }
      let(:project) { forked_project_link.forked_to_project }

      it 'schedules a RepositoryForkWorker job' do
        expect(RepositoryForkWorker).to receive(:perform_async).
          with(project.id, forked_from_project.repository_storage_path,
              forked_from_project.path_with_namespace, project.namespace.path)

        project.add_import_job
      end
    end

    context 'not forked' do
1555
      let(:project) { create(:empty_project) }
1556 1557 1558 1559 1560 1561 1562 1563 1564

      it 'schedules a RepositoryImportWorker job' do
        expect(RepositoryImportWorker).to receive(:perform_async).with(project.id)

        project.add_import_job
      end
    end
  end

R
Rémy Coutable 已提交
1565
  describe '#gitlab_project_import?' do
1566
    subject(:project) { build(:empty_project, import_type: 'gitlab_project') }
R
Rémy Coutable 已提交
1567 1568 1569 1570 1571

    it { expect(project.gitlab_project_import?).to be true }
  end

  describe '#gitea_import?' do
1572
    subject(:project) { build(:empty_project, import_type: 'gitea') }
R
Rémy Coutable 已提交
1573 1574 1575 1576

    it { expect(project.gitea_import?).to be true }
  end

1577
  describe '#lfs_enabled?' do
1578
    let(:project) { create(:empty_project) }
1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638

    shared_examples 'project overrides group' do
      it 'returns true when enabled in project' do
        project.update_attribute(:lfs_enabled, true)

        expect(project.lfs_enabled?).to be_truthy
      end

      it 'returns false when disabled in project' do
        project.update_attribute(:lfs_enabled, false)

        expect(project.lfs_enabled?).to be_falsey
      end

      it 'returns the value from the namespace, when no value is set in project' do
        expect(project.lfs_enabled?).to eq(project.namespace.lfs_enabled?)
      end
    end

    context 'LFS disabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, false)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    context 'LFS enabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, true)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    describe 'LFS disabled globally' do
      shared_examples 'it always returns false' do
        it do
          expect(project.lfs_enabled?).to be_falsey
          expect(project.namespace.lfs_enabled?).to be_falsey
        end
      end

      context 'when no values are set' do
        it_behaves_like 'it always returns false'
      end

      context 'when all values are set to true' do
        before do
          project.namespace.update_attribute(:lfs_enabled, true)
          project.update_attribute(:lfs_enabled, true)
        end

        it_behaves_like 'it always returns false'
      end
    end
  end

1639
  describe '#change_head' do
1640
    let(:project) { create(:project, :repository) }
1641

1642
    it 'calls the before_change_head and after_change_head methods' do
1643
      expect(project.repository).to receive(:before_change_head)
1644 1645
      expect(project.repository).to receive(:after_change_head)

1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665
      project.change_head(project.default_branch)
    end

    it 'creates the new reference with rugged' do
      expect(project.repository.rugged.references).to receive(:create).with('HEAD',
                                                                            "refs/heads/#{project.default_branch}",
                                                                            force: true)
      project.change_head(project.default_branch)
    end

    it 'copies the gitattributes' do
      expect(project.repository).to receive(:copy_gitattributes).with(project.default_branch)
      project.change_head(project.default_branch)
    end

    it 'reloads the default branch' do
      expect(project).to receive(:reload_default_branch)
      project.change_head(project.default_branch)
    end
  end
Y
Yorick Peterse 已提交
1666 1667

  describe '#pushes_since_gc' do
1668
    let(:project) { create(:empty_project) }
Y
Yorick Peterse 已提交
1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689

    after do
      project.reset_pushes_since_gc
    end

    context 'without any pushes' do
      it 'returns 0' do
        expect(project.pushes_since_gc).to eq(0)
      end
    end

    context 'with a number of pushes' do
      it 'returns the number of pushes' do
        3.times { project.increment_pushes_since_gc }

        expect(project.pushes_since_gc).to eq(3)
      end
    end
  end

  describe '#increment_pushes_since_gc' do
1690
    let(:project) { create(:empty_project) }
Y
Yorick Peterse 已提交
1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703

    after do
      project.reset_pushes_since_gc
    end

    it 'increments the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      expect(project.pushes_since_gc).to eq(3)
    end
  end

  describe '#reset_pushes_since_gc' do
1704
    let(:project) { create(:empty_project) }
Y
Yorick Peterse 已提交
1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717

    after do
      project.reset_pushes_since_gc
    end

    it 'resets the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      project.reset_pushes_since_gc

      expect(project.pushes_since_gc).to eq(0)
    end
  end
1718

1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738
  describe '#deployment_variables' do
    context 'when project has no deployment service' do
      let(:project) { create(:empty_project) }

      it 'returns an empty array' do
        expect(project.deployment_variables).to eq []
      end
    end

    context 'when project has a deployment service' do
      let(:project) { create(:kubernetes_project) }

      it 'returns variables from this service' do
        expect(project.deployment_variables).to include(
          { key: 'KUBE_TOKEN', value: project.kubernetes_service.token, public: false }
        )
      end
    end
  end

M
Markus Koller 已提交
1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758
  describe '#update_project_statistics' do
    let(:project) { create(:empty_project) }

    it "is called after creation" do
      expect(project.statistics).to be_a ProjectStatistics
      expect(project.statistics).to be_persisted
    end

    it "copies the namespace_id" do
      expect(project.statistics.namespace_id).to eq project.namespace_id
    end

    it "updates the namespace_id when changed" do
      namespace = create(:namespace)
      project.update(namespace: namespace)

      expect(project.statistics.namespace_id).to eq namespace.id
    end
  end

1759 1760 1761 1762 1763 1764 1765 1766
  describe 'inside_path' do
    let!(:project1) { create(:empty_project) }
    let!(:project2) { create(:empty_project) }
    let!(:path) { project1.namespace.path }

    it { expect(Project.inside_path(path)).to eq([project1]) }
  end

D
Douwe Maan 已提交
1767 1768 1769 1770 1771 1772 1773 1774 1775 1776
  describe '#route_map_for' do
    let(:project) { create(:project) }
    let(:route_map) do
      <<-MAP.strip_heredoc
      - source: /source/(.*)/
        public: '\\1'
      MAP
    end

    before do
D
Douwe Maan 已提交
1777
      project.repository.commit_file(User.last, '.gitlab/route-map.yml', route_map, message: 'Add .gitlab/route-map.yml', branch_name: 'master', update: false)
D
Douwe Maan 已提交
1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      context 'when the route map is valid' do
        it 'returns a route map' do
          map = project.route_map_for(project.commit.sha)
          expect(map).to be_a_kind_of(Gitlab::RouteMap)
        end
      end

      context 'when the route map is invalid' do
        let(:route_map) { 'INVALID' }

        it 'returns nil' do
          expect(project.route_map_for(project.commit.sha)).to be_nil
        end
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(project.route_map_for(project.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#public_path_for_source_path' do
    let(:project) { create(:project) }
    let(:route_map) do
      Gitlab::RouteMap.new(<<-MAP.strip_heredoc)
        - source: /source/(.*)/
          public: '\\1'
      MAP
    end
    let(:sha) { project.commit.id }

    context 'when there is a route map' do
      before do
        allow(project).to receive(:route_map_for).with(sha).and_return(route_map)
      end

      context 'when the source path is mapped' do
        it 'returns the public path' do
          expect(project.public_path_for_source_path('source/file.html', sha)).to eq('file.html')
        end
      end

      context 'when the source path is not mapped' do
        it 'returns nil' do
          expect(project.public_path_for_source_path('file.html', sha)).to be_nil
        end
      end
    end

    context 'when there is no route map' do
      before do
        allow(project).to receive(:route_map_for).with(sha).and_return(nil)
      end

      it 'returns nil' do
        expect(project.public_path_for_source_path('source/file.html', sha)).to be_nil
      end
    end
  end

1843 1844 1845
  def enable_lfs
    allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
  end
K
Kamil Trzcinski 已提交
1846

1847
  describe '#pages_url' do
K
Kamil Trzcinski 已提交
1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872
    let(:group) { create :group, name: group_name }
    let(:project) { create :empty_project, namespace: group, name: project_name }
    let(:domain) { 'Example.com' }

    subject { project.pages_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return('http://example.com')
    end

    context 'group page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'group.example.com' }

      it { is_expected.to eq("http://group.example.com") }
    end

    context 'project page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'Project' }

      it { is_expected.to eq("http://group.example.com/project") }
    end
  end
G
gitlabhq 已提交
1873
end