repository_spec.rb 56.2 KB
Newer Older
1 2
require 'spec_helper'

D
Douwe Maan 已提交
3
describe Repository, models: true do
4
  include RepoHelpers
5
  TestBlob = Struct.new(:name)
6

7
  let(:project) { create(:project, :repository) }
8
  let(:repository) { project.repository }
9
  let(:user) { create(:user) }
10

11 12 13 14
  let(:commit_options) do
    author = repository.user_to_committer(user)
    { message: 'Test message', committer: author, author: author }
  end
15

R
Rubén Dávila 已提交
16
  let(:merge_commit) do
17
    merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
S
Sean McGivern 已提交
18 19 20 21 22 23

    merge_commit_id = repository.merge(user,
                                       merge_request.diff_head_sha,
                                       merge_request,
                                       commit_options)

24
    repository.commit(merge_commit_id)
25
  end
26

27 28
  let(:author_email) { 'user@example.org' }
  let(:author_name) { 'John Doe' }
29

30
  describe '#branch_names_contains' do
31 32
    subject { repository.branch_names_contains(sample_commit.id) }

33 34 35
    it { is_expected.to include('master') }
    it { is_expected.not_to include('feature') }
    it { is_expected.not_to include('fix') }
36
  end
37

38
  describe '#tag_names_contains' do
D
Dmitriy Zaporozhets 已提交
39
    subject { repository.tag_names_contains(sample_commit.id) }
40

D
Dmitriy Zaporozhets 已提交
41 42
    it { is_expected.to include('v1.1.0') }
    it { is_expected.not_to include('v1.0.0') }
43 44
  end

45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62
  describe 'tags_sorted_by' do
    context 'name' do
      subject { repository.tags_sorted_by('name').map(&:name) }

      it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
    end

    context 'updated' do
      let(:tag_a) { repository.find_tag('v1.0.0') }
      let(:tag_b) { repository.find_tag('v1.1.0') }

      context 'desc' do
        subject { repository.tags_sorted_by('updated_desc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now)
          double_last = double(committed_date: Time.now - 1.second)

63 64
          allow(tag_a).to receive(:dereferenced_target).and_return(double_first)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_last)
65
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
66 67 68 69 70 71 72 73 74 75 76 77
        end

        it { is_expected.to eq(['v1.0.0', 'v1.1.0']) }
      end

      context 'asc' do
        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

78 79
          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
80
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
81 82 83 84
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
      end
85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108

      context 'annotated tag pointing to a blob' do
        let(:annotated_tag_name) { 'annotated-tag' }

        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          options = { message: 'test tag message\n',
                      tagger: { name: 'John Smith', email: 'john@gmail.com' } }
          repository.rugged.tags.create(annotated_tag_name, 'a48e4fc218069f68ef2e769dd8dfea3991362175', options)

          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0', annotated_tag_name]) }

        after do
          repository.rugged.tags.delete(annotated_tag_name)
        end
      end
109 110 111
    end
  end

112 113 114
  describe '#ref_name_for_sha' do
    context 'ref found' do
      it 'returns the ref' do
115 116
        allow_any_instance_of(Gitlab::Popen).to receive(:popen).
          and_return(["b8d95eb4969eefacb0a58f6a28f6803f8070e7b9 commit\trefs/environments/production/77\n", 0])
117 118 119 120 121 122 123

        expect(repository.ref_name_for_sha('bla', '0' * 40)).to eq 'refs/environments/production/77'
      end
    end

    context 'ref not found' do
      it 'returns nil' do
124 125
        allow_any_instance_of(Gitlab::Popen).to receive(:popen).
          and_return(["", 0])
126 127 128 129 130 131

        expect(repository.ref_name_for_sha('bla', '0' * 40)).to eq nil
      end
    end
  end

132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151
  describe '#ref_exists?' do
    context 'when ref exists' do
      it 'returns true' do
        expect(repository.ref_exists?('refs/heads/master')).to be true
      end
    end

    context 'when ref does not exist' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/non-existent')).to be false
      end
    end

    context 'when ref format is incorrect' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/invalid:master')).to be false
      end
    end
  end

152
  describe '#last_commit_for_path' do
D
Dmitriy Zaporozhets 已提交
153
    subject { repository.last_commit_for_path(sample_commit.id, '.gitignore').id }
154

D
Dmitriy Zaporozhets 已提交
155
    it { is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8') }
156
  end
157

H
Hiroyuki Sato 已提交
158 159 160
  describe '#last_commit_id_for_path' do
    subject { repository.last_commit_id_for_path(sample_commit.id, '.gitignore') }

H
Hiroyuki Sato 已提交
161 162 163
    it "returns last commit id for a given path" do
      is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8')
    end
H
Hiroyuki Sato 已提交
164

H
Hiroyuki Sato 已提交
165
    it "caches last commit id for a given path" do
H
Hiroyuki Sato 已提交
166 167
      cache = repository.send(:cache)
      key = "last_commit_id_for_path:#{sample_commit.id}:#{Digest::SHA1.hexdigest('.gitignore')}"
168

H
Hiroyuki Sato 已提交
169
      expect(cache).to receive(:fetch).with(key).and_return('c1acaa5')
H
Hiroyuki Sato 已提交
170
      is_expected.to eq('c1acaa5')
H
Hiroyuki Sato 已提交
171 172 173
    end
  end

174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194
  describe '#commits' do
    it 'sets follow when path is a single path' do
      expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: true)).and_call_original.twice

      repository.commits('master', path: 'README.md')
      repository.commits('master', path: ['README.md'])
    end

    it 'does not set follow when path is multiple paths' do
      expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: false)).and_call_original

      repository.commits('master', path: ['README.md', 'CHANGELOG'])
    end

    it 'does not set follow when there are no paths' do
      expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: false)).and_call_original

      repository.commits('master')
    end
  end

195
  describe '#find_commits_by_message' do
196 197
    it 'returns commits with messages containing a given string' do
      commit_ids = repository.find_commits_by_message('submodule').map(&:id)
198

199 200 201 202 203 204 205 206 207 208 209
      expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
      expect(commit_ids).to include('6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9')
      expect(commit_ids).to include('cfe32cf61b73a0d5e9f13e774abde7ff789b1660')
      expect(commit_ids).not_to include('913c66a37b4a45b9769037c55c2d238bd0942d2e')
    end

    it 'is case insensitive' do
      commit_ids = repository.find_commits_by_message('SUBMODULE').map(&:id)

      expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
    end
210 211
  end

212
  describe '#blob_at' do
213 214 215 216 217 218
    context 'blank sha' do
      subject { repository.blob_at(Gitlab::Git::BLANK_SHA, '.gitignore') }

      it { is_expected.to be_nil }
    end
  end
219

220
  describe '#merged_to_root_ref?' do
221
    context 'merged branch without ff' do
222
      subject { repository.merged_to_root_ref?('branch-merged') }
F
Florent (HP) 已提交
223 224 225

      it { is_expected.to be_truthy }
    end
226

227 228
    # If the HEAD was ff then it will be false
    context 'merged with ff' do
F
Florent (HP) 已提交
229 230 231 232
      subject { repository.merged_to_root_ref?('improve/awesome') }

      it { is_expected.to be_truthy }
    end
233

234 235 236 237 238
    context 'not merged branch' do
      subject { repository.merged_to_root_ref?('not-merged-branch') }

      it { is_expected.to be_falsey }
    end
239 240 241 242 243 244

    context 'default branch' do
      subject { repository.merged_to_root_ref?('master') }

      it { is_expected.to be_falsey }
    end
245 246
  end

247
  describe '#can_be_merged?' do
248 249 250 251 252 253 254 255 256 257 258
    context 'mergeable branches' do
      subject { repository.can_be_merged?('0b4bc9a49b562e85de7cc9e834518ea6828729b9', 'master') }

      it { is_expected.to be_truthy }
    end

    context 'non-mergeable branches' do
      subject { repository.can_be_merged?('bb5206fee213d983da88c47f9cf4cc6caf9c66dc', 'feature') }

      it { is_expected.to be_falsey }
    end
F
Florent (HP) 已提交
259 260 261 262 263 264 265 266 267 268 269 270

    context 'non merged branch' do
      subject { repository.merged_to_root_ref?('fix') }

      it { is_expected.to be_falsey }
    end

    context 'non existent branch' do
      subject { repository.merged_to_root_ref?('non_existent_branch') }

      it { is_expected.to be_nil }
    end
271 272
  end

273 274 275
  describe '#commit' do
    context 'when ref exists' do
      it 'returns commit object' do
D
Douwe Maan 已提交
276 277
        expect(repository.commit('master'))
          .to be_an_instance_of Commit
278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301
      end
    end

    context 'when ref does not exist' do
      it 'returns nil' do
        expect(repository.commit('non-existent-ref')).to be_nil
      end
    end

    context 'when ref is not valid' do
      context 'when preceding tree element exists' do
        it 'returns nil' do
          expect(repository.commit('master:ref')).to be_nil
        end
      end

      context 'when preceding tree element does not exist' do
        it 'returns nil' do
          expect(repository.commit('non-existent:ref')).to be_nil
        end
      end
    end
  end

D
Douwe Maan 已提交
302
  describe "#create_dir" do
303 304
    it "commits a change that creates a new directory" do
      expect do
305
        repository.create_dir(user, 'newdir',
306
          message: 'Create newdir', branch_name: 'master')
307 308 309 310 311 312
      end.to change { repository.commits('master').count }.by(1)

      newdir = repository.tree('master', 'newdir')
      expect(newdir.path).to eq('newdir')
    end

313 314 315 316 317
    context "when committing to another project" do
      let(:forked_project) { create(:project) }

      it "creates a fork and commit to the forked project" do
        expect do
318
          repository.create_dir(user, 'newdir',
319
            message: 'Create newdir', branch_name: 'patch',
L
Lin Jen-Shin 已提交
320
            start_branch_name: 'master', start_project: forked_project)
321 322 323 324 325 326 327 328 329 330
        end.to change { repository.commits('master').count }.by(0)

        expect(repository.branch_exists?('patch')).to be_truthy
        expect(forked_project.repository.branch_exists?('patch')).to be_falsy

        newdir = repository.tree('patch', 'newdir')
        expect(newdir.path).to eq('newdir')
      end
    end

331 332 333
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
334
          repository.create_dir(user, 'newdir',
335 336 337
            message: 'Add newdir',
            branch_name: 'master',
            author_email: author_email, author_name: author_name)
338 339 340 341 342 343 344 345 346 347
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

348 349
  describe "#create_file" do
    it 'commits new file successfully' do
350
      expect do
351 352 353
        repository.create_file(user, 'NEWCHANGELOG', 'Changelog!',
                               message: 'Create changelog',
                               branch_name: 'master')
354 355
      end.to change { repository.commits('master').count }.by(1)

356
      blob = repository.blob_at('master', 'NEWCHANGELOG')
357

358
      expect(blob.data).to eq('Changelog!')
359
    end
360

361
    it 'respects the autocrlf setting' do
362
      repository.create_file(user, 'hello.txt', "Hello,\r\nWorld",
363
                             message: 'Add hello world',
364
                             branch_name: 'master')
365 366 367 368 369 370

      blob = repository.blob_at('master', 'hello.txt')

      expect(blob.data).to eq("Hello,\nWorld")
    end

371 372 373
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
374
          repository.create_file(user, 'NEWREADME', 'README!',
375 376 377 378
                                 message: 'Add README',
                                 branch_name: 'master',
                                 author_email: author_email,
                                 author_name: author_name)
379 380 381 382 383 384 385 386
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
387 388
  end

389
  describe "#update_file" do
390 391 392 393 394 395 396 397 398 399 400 401
    it 'updates file successfully' do
      expect do
        repository.update_file(user, 'CHANGELOG', 'Changelog!',
                               message: 'Update changelog',
                               branch_name: 'master')
      end.to change { repository.commits('master').count }.by(1)

      blob = repository.blob_at('master', 'CHANGELOG')

      expect(blob.data).to eq('Changelog!')
    end

T
tiagonbotelho 已提交
402
    it 'updates filename successfully' do
403 404
      expect do
        repository.update_file(user, 'NEWLICENSE', 'Copyright!',
405
                                     branch_name: 'master',
T
tiagonbotelho 已提交
406
                                     previous_path: 'LICENSE',
407 408
                                     message: 'Changes filename')
      end.to change { repository.commits('master').count }.by(1)
T
tiagonbotelho 已提交
409 410 411 412 413 414

      files = repository.ls_files('master')

      expect(files).not_to include('LICENSE')
      expect(files).to include('NEWLICENSE')
    end
415 416 417 418

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
419 420 421 422 423 424
          repository.update_file(user, 'README', 'Updated README!',
                                 branch_name: 'master',
                                 previous_path: 'README',
                                 message: 'Update README',
                                 author_email: author_email,
                                 author_name: author_name)
425 426 427 428 429 430 431 432 433 434
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

D
Douwe Maan 已提交
435
  describe "#delete_file" do
436 437
    it 'removes file successfully' do
      expect do
438
        repository.delete_file(user, 'README',
439
          message: 'Remove README', branch_name: 'master')
440 441 442 443 444 445 446 447
      end.to change { repository.commits('master').count }.by(1)

      expect(repository.blob_at('master', 'README')).to be_nil
    end

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
448
          repository.delete_file(user, 'README',
449 450
            message: 'Remove README', branch_name: 'master',
            author_email: author_email, author_name: author_name)
451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

  describe '#get_committer_and_author' do
    it 'returns the committer and author data' do
      options = repository.get_committer_and_author(user)
      expect(options[:committer][:email]).to eq(user.email)
      expect(options[:author][:email]).to eq(user.email)
    end

    context 'when the email/name are given' do
      it 'returns an object containing the email/name' do
        options = repository.get_committer_and_author(user, email: author_email, name: author_name)
        expect(options[:author][:email]).to eq(author_email)
        expect(options[:author][:name]).to eq(author_name)
      end
    end

    context 'when the email is given but the name is not' do
      it 'returns the committer as the author' do
        options = repository.get_committer_and_author(user, email: author_email)
        expect(options[:author][:email]).to eq(user.email)
        expect(options[:author][:name]).to eq(user.name)
      end
    end

    context 'when the name is given but the email is not' do
      it 'returns nil' do
        options = repository.get_committer_and_author(user, name: author_name)
        expect(options[:author][:email]).to eq(user.email)
        expect(options[:author][:name]).to eq(user.name)
      end
    end
T
tiagonbotelho 已提交
491 492
  end

V
Valery Sizov 已提交
493 494
  describe "search_files_by_content" do
    let(:results) { repository.search_files_by_content('feature', 'master') }
495 496 497 498
    subject { results }

    it { is_expected.to be_an Array }

499
    it 'regex-escapes the query string' do
V
Valery Sizov 已提交
500
      results = repository.search_files_by_content("test\\", 'master')
501 502 503 504

      expect(results.first).not_to start_with('fatal:')
    end

505
    it 'properly handles an unmatched parenthesis' do
V
Valery Sizov 已提交
506
      results = repository.search_files_by_content("test(", 'master')
507 508 509 510

      expect(results.first).not_to start_with('fatal:')
    end

V
Valery Sizov 已提交
511
    it 'properly handles when query is not present' do
V
Valery Sizov 已提交
512
      results = repository.search_files_by_content('', 'master')
V
Valery Sizov 已提交
513 514 515 516 517 518

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
      repository = create(:empty_project).repository
V
Valery Sizov 已提交
519
      results = repository.search_files_by_content('test', 'master')
V
Valery Sizov 已提交
520 521 522 523

      expect(results).to match_array([])
    end

524 525 526 527
    describe 'result' do
      subject { results.first }

      it { is_expected.to be_an String }
528
      it { expect(subject.lines[2]).to eq("master:CHANGELOG:190:  - Feature: Replace teams with group membership\n") }
529 530
    end
  end
Z
Zeger-Jan van de Weg 已提交
531

V
Valery Sizov 已提交
532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553
  describe "search_files_by_name" do
    let(:results) { repository.search_files_by_name('files', 'master') }

    it 'returns result' do
      expect(results.first).to eq('files/html/500.html')
    end

    it 'properly handles when query is not present' do
      results = repository.search_files_by_name('', 'master')

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
      repository = create(:empty_project).repository

      results = repository.search_files_by_name('test', 'master')

      expect(results).to match_array([])
    end
  end

554 555 556 557 558 559 560 561 562 563
  describe '#create_ref' do
    it 'redirects the call to fetch_ref' do
      ref, ref_path = '1', '2'

      expect(repository).to receive(:fetch_ref).with(repository.path_to_repo, ref, ref_path)

      repository.create_ref(ref, ref_path)
    end
  end

564
  describe "#changelog", caching: true do
565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595
    it 'accepts changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changelog')])

      expect(repository.changelog.name).to eq('changelog')
    end

    it 'accepts news instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('news')])

      expect(repository.changelog.name).to eq('news')
    end

    it 'accepts history instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('history')])

      expect(repository.changelog.name).to eq('history')
    end

    it 'accepts changes instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changes')])

      expect(repository.changelog.name).to eq('changes')
    end

    it 'is case-insensitive' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('CHANGELOG')])

      expect(repository.changelog.name).to eq('CHANGELOG')
    end
  end

596
  describe "#license_blob", caching: true do
597
    before do
598
      repository.delete_file(
599
        user, 'LICENSE', message: 'Remove LICENSE', branch_name: 'master')
600 601
    end

602
    it 'handles when HEAD points to non-existent ref' do
603
      repository.create_file(
604
        user, 'LICENSE', 'Copyright!',
605
        message: 'Add LICENSE', branch_name: 'master')
606

607 608
      allow(repository).to receive(:file_on_head).
        and_raise(Rugged::ReferenceError)
609 610 611 612

      expect(repository.license_blob).to be_nil
    end

613
    it 'looks in the root_ref only' do
614
      repository.delete_file(user, 'LICENSE',
615
        message: 'Remove LICENSE', branch_name: 'markdown')
616
      repository.create_file(user, 'LICENSE',
617
        Licensee::License.new('mit').content,
618
        message: 'Add LICENSE', branch_name: 'markdown')
619 620 621 622

      expect(repository.license_blob).to be_nil
    end

623
    it 'detects license file with no recognizable open-source license content' do
624 625
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')
626 627 628 629

      expect(repository.license_blob.name).to eq('LICENSE')
    end

630 631
    %w[LICENSE LICENCE LiCensE LICENSE.md LICENSE.foo COPYING COPYING.md].each do |filename|
      it "detects '#{filename}'" do
632
        repository.create_file(user, filename,
633
          Licensee::License.new('mit').content,
634
          message: "Add #{filename}", branch_name: 'master')
635

636 637
        expect(repository.license_blob.name).to eq(filename)
      end
638 639 640
    end
  end

641
  describe '#license_key', caching: true do
642
    before do
643
      repository.delete_file(user, 'LICENSE',
644
        message: 'Remove LICENSE', branch_name: 'master')
645
    end
Z
Zeger-Jan van de Weg 已提交
646

647
    it 'returns nil when no license is detected' do
648 649 650
      expect(repository.license_key).to be_nil
    end

651 652 653
    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

654 655 656 657
      expect(repository.license_key).to be_nil
    end

    it 'detects license file with no recognizable open-source license content' do
658 659
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')
660 661

      expect(repository.license_key).to be_nil
Z
Zeger-Jan van de Weg 已提交
662
    end
663

664
    it 'returns the license key' do
665
      repository.create_file(user, 'LICENSE',
666
        Licensee::License.new('mit').content,
667
        message: 'Add LICENSE', branch_name: 'master')
668

669
      expect(repository.license_key).to eq('mit')
670
    end
Z
Zeger-Jan van de Weg 已提交
671
  end
672

673
  describe "#gitlab_ci_yml", caching: true do
674 675 676 677 678 679 680 681 682 683 684 685 686
    it 'returns valid file' do
      files = [TestBlob.new('file'), TestBlob.new('.gitlab-ci.yml'), TestBlob.new('copying')]
      expect(repository.tree).to receive(:blobs).and_return(files)

      expect(repository.gitlab_ci_yml.name).to eq('.gitlab-ci.yml')
    end

    it 'returns nil if not exists' do
      expect(repository.tree).to receive(:blobs).and_return([])
      expect(repository.gitlab_ci_yml).to be_nil
    end

    it 'returns nil for empty repository' do
687
      allow(repository).to receive(:file_on_head).and_raise(Rugged::ReferenceError)
688 689 690 691
      expect(repository.gitlab_ci_yml).to be_nil
    end
  end

692
  describe '#add_branch' do
693
    context 'when pre hooks were successful' do
694
      it 'runs without errors' do
695
        hook = double(trigger: [true, nil])
696
        expect(Gitlab::Git::Hook).to receive(:new).exactly(3).times.and_return(hook)
697 698 699 700

        expect { repository.add_branch(user, 'new_feature', 'master') }.not_to raise_error
      end

701
      it 'creates the branch' do
702
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, nil])
703 704 705 706 707

        branch = repository.add_branch(user, 'new_feature', 'master')

        expect(branch.name).to eq('new_feature')
      end
708 709 710 711 712 713

      it 'calls the after_create_branch hook' do
        expect(repository).to receive(:after_create_branch)

        repository.add_branch(user, 'new_feature', 'master')
      end
714 715 716
    end

    context 'when pre hooks failed' do
717
      it 'gets an error' do
718
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
719 720 721 722 723 724

        expect do
          repository.add_branch(user, 'new_feature', 'master')
        end.to raise_error(GitHooksService::PreReceiveError)
      end

725
      it 'does not create the branch' do
726
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
727 728 729 730 731 732 733 734 735

        expect do
          repository.add_branch(user, 'new_feature', 'master')
        end.to raise_error(GitHooksService::PreReceiveError)
        expect(repository.find_branch('new_feature')).to be_nil
      end
    end
  end

736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753
  describe '#find_branch' do
    it 'loads a branch with a fresh repo' do
      expect(Gitlab::Git::Repository).to receive(:new).twice.and_call_original

      2.times do
        expect(repository.find_branch('feature')).not_to be_nil
      end
    end

    it 'loads a branch with a cached repo' do
      expect(Gitlab::Git::Repository).to receive(:new).once.and_call_original

      2.times do
        expect(repository.find_branch('feature', fresh_repo: false)).not_to be_nil
      end
    end
  end

754
  describe '#rm_branch' do
755 756 757
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
    let(:blank_sha) { '0000000000000000000000000000000000000000' }

758
    context 'when pre hooks were successful' do
759
      it 'runs without errors' do
760 761
        expect_any_instance_of(GitHooksService).to receive(:execute).
          with(user, project.repository.path_to_repo, old_rev, blank_sha, 'refs/heads/feature')
762 763 764 765

        expect { repository.rm_branch(user, 'feature') }.not_to raise_error
      end

766
      it 'deletes the branch' do
767
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, nil])
768 769 770 771 772 773 774 775

        expect { repository.rm_branch(user, 'feature') }.not_to raise_error

        expect(repository.find_branch('feature')).to be_nil
      end
    end

    context 'when pre hooks failed' do
776
      it 'gets an error' do
777
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
778 779

        expect do
780
          repository.rm_branch(user, 'feature')
781 782 783
        end.to raise_error(GitHooksService::PreReceiveError)
      end

784
      it 'does not delete the branch' do
785
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
786 787 788 789 790 791 792 793 794

        expect do
          repository.rm_branch(user, 'feature')
        end.to raise_error(GitHooksService::PreReceiveError)
        expect(repository.find_branch('feature')).not_to be_nil
      end
    end
  end

795
  describe '#update_branch_with_hooks' do
796
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
797
    let(:new_rev) { 'a74ae73c1ccde9b974a70e82b901588071dc142a' } # commit whose parent is old_rev
798

799
    context 'when pre hooks were successful' do
800
      before do
801 802
        service = GitHooksService.new
        expect(GitHooksService).to receive(:new).and_return(service)
803 804
        expect(service).to receive(:execute).
          with(
805 806 807
            user,
            repository.path_to_repo,
            old_rev,
808
            new_rev,
809 810
            'refs/heads/feature').
          and_yield(service).and_return(true)
811
      end
812

813
      it 'runs without errors' do
814
        expect do
815 816 817
          GitOperationService.new(user, repository).with_branch('feature') do
            new_rev
          end
818 819
        end.not_to raise_error
      end
820

821
      it 'ensures the autocrlf Git option is set to :input' do
822 823 824
        service = GitOperationService.new(user, repository)

        expect(service).to receive(:update_autocrlf_option)
825

826
        service.with_branch('feature') { new_rev }
827
      end
828 829 830

      context "when the branch wasn't empty" do
        it 'updates the head' do
831
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(old_rev)
832 833 834 835 836

          GitOperationService.new(user, repository).with_branch('feature') do
            new_rev
          end

837
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(new_rev)
838 839
        end
      end
840 841
    end

842
    context 'when the update adds more than one commit' do
843
      let(:old_rev) { '33f3729a45c02fc67d00adb1b8bca394b0e761d9' }
844

845
      it 'runs without errors' do
846 847 848 849 850 851
        # old_rev is an ancestor of new_rev
        expect(repository.rugged.merge_base(old_rev, new_rev)).to eq(old_rev)

        # old_rev is not a direct ancestor (parent) of new_rev
        expect(repository.rugged.lookup(new_rev).parent_ids).not_to include(old_rev)

852 853 854
        branch = 'feature-ff-target'
        repository.add_branch(user, branch, old_rev)

855 856 857 858 859
        expect do
          GitOperationService.new(user, repository).with_branch(branch) do
            new_rev
          end
        end.not_to raise_error
860 861 862 863
      end
    end

    context 'when the update would remove commits from the target branch' do
864 865
      let(:branch) { 'master' }
      let(:old_rev) { repository.find_branch(branch).dereferenced_target.sha }
866

867
      it 'raises an exception' do
868 869 870 871 872 873
        # The 'master' branch is NOT an ancestor of new_rev.
        expect(repository.rugged.merge_base(old_rev, new_rev)).not_to eq(old_rev)

        # Updating 'master' to new_rev would lose the commits on 'master' that
        # are not contained in new_rev. This should not be allowed.
        expect do
874 875 876
          GitOperationService.new(user, repository).with_branch(branch) do
            new_rev
          end
877
        end.to raise_error(Repository::CommitError)
878 879 880
      end
    end

881
    context 'when pre hooks failed' do
882
      it 'gets an error' do
883
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
884 885

        expect do
886 887 888
          GitOperationService.new(user, repository).with_branch('feature') do
            new_rev
          end
889 890 891
        end.to raise_error(GitHooksService::PreReceiveError)
      end
    end
892 893 894 895 896 897 898 899 900 901 902 903

    context 'when target branch is different from source branch' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

      it 'expires branch cache' do
        expect(repository).not_to receive(:expire_exists_cache)
        expect(repository).not_to receive(:expire_root_ref_cache)
        expect(repository).not_to receive(:expire_emptiness_caches)
        expect(repository).to     receive(:expire_branches_cache)

904 905
        GitOperationService.new(user, repository).
          with_branch('new-feature') do
906 907
            new_rev
          end
908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923
      end
    end

    context 'when repository is empty' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

      it 'expires creation and branch cache' do
        empty_repository = create(:empty_project, :empty_repo).repository

        expect(empty_repository).to receive(:expire_exists_cache)
        expect(empty_repository).to receive(:expire_root_ref_cache)
        expect(empty_repository).to receive(:expire_emptiness_caches)
        expect(empty_repository).to receive(:expire_branches_cache)

924
        empty_repository.create_file(user, 'CHANGELOG', 'Changelog!',
925
                                     message: 'Updates file content',
926
                                     branch_name: 'master')
927 928
      end
    end
929
  end
930

931 932 933 934 935 936
  describe '#exists?' do
    it 'returns true when a repository exists' do
      expect(repository.exists?).to eq(true)
    end

    it 'returns false when a repository does not exist' do
937
      allow(repository).to receive(:refs_directory_exists?).and_return(false)
938 939 940

      expect(repository.exists?).to eq(false)
    end
941 942 943 944 945 946

    it 'returns false when there is no namespace' do
      allow(repository).to receive(:path_with_namespace).and_return(nil)

      expect(repository.exists?).to eq(false)
    end
947 948
  end

949 950 951 952 953
  describe '#has_visible_content?' do
    subject { repository.has_visible_content? }

    describe 'when there are no branches' do
      before do
954
        allow(repository).to receive(:branch_count).and_return(0)
955 956 957 958 959 960
      end

      it { is_expected.to eq(false) }
    end

    describe 'when there are branches' do
961
      it 'returns true' do
962
        expect(repository).to receive(:branch_count).and_return(3)
963 964 965 966 967 968

        expect(subject).to eq(true)
      end
    end
  end

969 970 971 972 973 974 975
  describe '#update_autocrlf_option' do
    describe 'when autocrlf is not already set to :input' do
      before do
        repository.raw_repository.autocrlf = true
      end

      it 'sets autocrlf to :input' do
976
        GitOperationService.new(nil, repository).send(:update_autocrlf_option)
977 978 979 980 981 982 983 984 985 986 987

        expect(repository.raw_repository.autocrlf).to eq(:input)
      end
    end

    describe 'when autocrlf is already set to :input' do
      before do
        repository.raw_repository.autocrlf = :input
      end

      it 'does nothing' do
988 989
        expect(repository.raw_repository).not_to receive(:autocrlf=).
          with(:input)
990

991
        GitOperationService.new(nil, repository).send(:update_autocrlf_option)
992 993 994 995
      end
    end
  end

996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007
  describe '#empty?' do
    let(:empty_repository) { create(:project_empty_repo).repository }

    it 'returns true for an empty repository' do
      expect(empty_repository.empty?).to eq(true)
    end

    it 'returns false for a non-empty repository' do
      expect(repository.empty?).to eq(false)
    end

    it 'caches the output' do
1008 1009 1010
      expect(repository.raw_repository).to receive(:empty?).
        once.
        and_return(false)
1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022

      repository.empty?
      repository.empty?
    end
  end

  describe '#root_ref' do
    it 'returns a branch name' do
      expect(repository.root_ref).to be_an_instance_of(String)
    end

    it 'caches the output' do
1023 1024 1025
      expect(repository.raw_repository).to receive(:root_ref).
        once.
        and_return('master')
1026 1027 1028 1029 1030 1031 1032 1033 1034 1035

      repository.root_ref
      repository.root_ref
    end
  end

  describe '#expire_root_ref_cache' do
    it 'expires the root reference cache' do
      repository.root_ref

1036 1037 1038
      expect(repository.raw_repository).to receive(:root_ref).
        once.
        and_return('foo')
1039 1040 1041 1042 1043 1044 1045

      repository.expire_root_ref_cache

      expect(repository.root_ref).to eq('foo')
    end
  end

Y
Yorick Peterse 已提交
1046
  describe '#expire_branch_cache' do
1047 1048 1049 1050 1051
    # This method is private but we need it for testing purposes. Sadly there's
    # no other proper way of testing caching operations.
    let(:cache) { repository.send(:cache) }

    it 'expires the cache for all branches' do
1052
      expect(cache).to receive(:expire).
1053
        at_least(repository.branches.length * 2).
1054
        times
1055 1056 1057 1058 1059

      repository.expire_branch_cache
    end

    it 'expires the cache for all branches when the root branch is given' do
1060
      expect(cache).to receive(:expire).
1061
        at_least(repository.branches.length * 2).
1062
        times
1063 1064 1065 1066 1067

      repository.expire_branch_cache(repository.root_ref)
    end

    it 'expires the cache for a specific branch' do
1068
      expect(cache).to receive(:expire).twice
1069 1070 1071 1072

      repository.expire_branch_cache('foo')
    end
  end
1073

1074 1075 1076
  describe '#expire_emptiness_caches' do
    let(:cache) { repository.send(:cache) }

1077 1078 1079
    it 'expires the caches for an empty repository' do
      allow(repository).to receive(:empty?).and_return(true)

1080 1081 1082 1083
      expect(cache).to receive(:expire).with(:empty?)

      repository.expire_emptiness_caches
    end
1084 1085 1086 1087 1088 1089 1090 1091

    it 'does not expire the cache for a non-empty repository' do
      allow(repository).to receive(:empty?).and_return(false)

      expect(cache).not_to receive(:expire).with(:empty?)

      repository.expire_emptiness_caches
    end
1092 1093
  end

1094
  describe 'skip_merges option' do
1095
    subject { repository.commits(Gitlab::Git::BRANCH_REF_PREFIX + "'test'", limit: 100, skip_merges: true).map{ |k| k.id } }
1096 1097 1098

    it { is_expected.not_to include('e56497bb5f03a90a51293fc6d516788730953899') }
  end
1099 1100

  describe '#merge' do
1101
    it 'merges the code and return the commit id' do
R
Rubén Dávila 已提交
1102 1103
      expect(merge_commit).to be_present
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
1104
    end
1105 1106 1107

    it 'sets the `in_progress_merge_commit_sha` flag for the given merge request' do
      merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
S
Sean McGivern 已提交
1108 1109 1110 1111 1112

      merge_commit_id = repository.merge(user,
                                         merge_request.diff_head_sha,
                                         merge_request,
                                         commit_options)
1113 1114 1115

      expect(merge_request.in_progress_merge_commit_sha).to eq(merge_commit_id)
    end
1116 1117
  end

1118 1119 1120
  describe '#revert' do
    let(:new_image_commit) { repository.commit('33f3729a45c02fc67d00adb1b8bca394b0e761d9') }
    let(:update_image_commit) { repository.commit('2f63565e7aac07bcdadb654e253078b727143ec4') }
1121

1122
    context 'when there is a conflict' do
1123 1124
      it 'raises an error' do
        expect { repository.revert(user, new_image_commit, 'master') }.to raise_error(/Failed to/)
1125 1126 1127 1128
      end
    end

    context 'when commit was already reverted' do
1129
      it 'raises an error' do
1130 1131
        repository.revert(user, update_image_commit, 'master')

1132
        expect { repository.revert(user, update_image_commit, 'master') }.to raise_error(/Failed to/)
1133 1134 1135 1136
      end
    end

    context 'when commit can be reverted' do
1137
      it 'reverts the changes' do
1138 1139 1140 1141 1142
        expect(repository.revert(user, update_image_commit, 'master')).to be_truthy
      end
    end

    context 'reverting a merge commit' do
1143
      it 'reverts the changes' do
1144 1145 1146 1147 1148 1149
        merge_commit
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).to be_present

        repository.revert(user, merge_commit, 'master')
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).not_to be_present
      end
1150 1151
    end
  end
1152

P
P.S.V.R 已提交
1153 1154 1155 1156 1157 1158
  describe '#cherry_pick' do
    let(:conflict_commit) { repository.commit('c642fe9b8b9f28f9225d7ea953fe14e74748d53b') }
    let(:pickable_commit) { repository.commit('7d3b0f7cff5f37573aea97cebfd5692ea1689924') }
    let(:pickable_merge) { repository.commit('e56497bb5f03a90a51293fc6d516788730953899') }

    context 'when there is a conflict' do
1159 1160
      it 'raises an error' do
        expect { repository.cherry_pick(user, conflict_commit, 'master') }.to raise_error(/Failed to/)
P
P.S.V.R 已提交
1161 1162 1163 1164
      end
    end

    context 'when commit was already cherry-picked' do
1165
      it 'raises an error' do
P
P.S.V.R 已提交
1166 1167
        repository.cherry_pick(user, pickable_commit, 'master')

1168
        expect { repository.cherry_pick(user, pickable_commit, 'master') }.to raise_error(/Failed to/)
P
P.S.V.R 已提交
1169 1170 1171 1172
      end
    end

    context 'when commit can be cherry-picked' do
1173
      it 'cherry-picks the changes' do
P
P.S.V.R 已提交
1174 1175 1176 1177 1178
        expect(repository.cherry_pick(user, pickable_commit, 'master')).to be_truthy
      end
    end

    context 'cherry-picking a merge commit' do
1179
      it 'cherry-picks the changes' do
1180
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).to be_nil
P
P.S.V.R 已提交
1181

1182 1183
        repository.cherry_pick(user, pickable_merge, 'improve/awesome')
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).not_to be_nil
P
P.S.V.R 已提交
1184 1185 1186 1187
      end
    end
  end

1188 1189 1190 1191 1192 1193 1194
  describe '#before_delete' do
    describe 'when a repository does not exist' do
      before do
        allow(repository).to receive(:exists?).and_return(false)
      end

      it 'does not flush caches that depend on repository data' do
1195
        expect(repository).not_to receive(:expire_cache)
1196 1197 1198 1199

        repository.before_delete
      end

1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
1223 1224

      it 'flushes the exists cache' do
1225
        expect(repository).to receive(:expire_exists_cache).twice
1226 1227 1228

        repository.before_delete
      end
1229 1230 1231 1232 1233 1234 1235
    end

    describe 'when a repository exists' do
      before do
        allow(repository).to receive(:exists?).and_return(true)
      end

1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
    end
  end

  describe '#before_change_head' do
    it 'flushes the branch cache' do
      expect(repository).to receive(:expire_branch_cache)

      repository.before_change_head
    end

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.before_change_head
    end
  end

1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292
  describe '#after_change_head' do
    it 'flushes the readme cache' do
      expect(repository).to receive(:expire_method_caches).with([
        :readme,
        :changelog,
        :license,
        :contributing,
        :gitignore,
        :koding,
        :gitlab_ci,
        :avatar
      ])

      repository.after_change_head
    end
  end

Y
Yorick Peterse 已提交
1293
  describe '#before_push_tag' do
1294
    it 'flushes the cache' do
1295 1296 1297
      expect(repository).to receive(:expire_statistics_caches)
      expect(repository).to receive(:expire_emptiness_caches)
      expect(repository).to receive(:expire_tags_cache)
1298

Y
Yorick Peterse 已提交
1299
      repository.before_push_tag
1300 1301 1302 1303
    end
  end

  describe '#after_import' do
1304 1305
    it 'flushes and builds the cache' do
      expect(repository).to receive(:expire_content_cache)
1306 1307 1308

      repository.after_import
    end
1309 1310 1311
  end

  describe '#after_push_commit' do
1312
    it 'expires statistics caches' do
1313 1314
      expect(repository).to receive(:expire_statistics_caches).
        and_call_original
1315

1316 1317 1318
      expect(repository).to receive(:expire_branch_cache).
        with('master').
        and_call_original
1319

1320
      repository.after_push_commit('master')
1321 1322 1323 1324
    end
  end

  describe '#after_create_branch' do
1325
    it 'expires the branch caches' do
1326
      expect(repository).to receive(:expire_branches_cache)
1327 1328 1329 1330 1331 1332

      repository.after_create_branch
    end
  end

  describe '#after_remove_branch' do
1333
    it 'expires the branch caches' do
1334
      expect(repository).to receive(:expire_branches_cache)
1335 1336 1337 1338

      repository.after_remove_branch
    end
  end
1339

1340 1341 1342 1343 1344 1345
  describe '#after_create' do
    it 'flushes the exists cache' do
      expect(repository).to receive(:expire_exists_cache)

      repository.after_create
    end
1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.after_create
    end

    it 'flushes the emptiness caches' do
      expect(repository).to receive(:expire_emptiness_caches)

      repository.after_create
    end
1358 1359
  end

1360 1361 1362 1363 1364 1365 1366 1367 1368 1369
  describe "#copy_gitattributes" do
    it 'returns true with a valid ref' do
      expect(repository.copy_gitattributes('master')).to be_truthy
    end

    it 'returns false with an invalid ref' do
      expect(repository.copy_gitattributes('invalid')).to be_falsey
    end
  end

Y
Yorick Peterse 已提交
1370 1371
  describe '#before_remove_tag' do
    it 'flushes the tag cache' do
1372 1373
      expect(repository).to receive(:expire_tags_cache).and_call_original
      expect(repository).to receive(:expire_statistics_caches).and_call_original
Y
Yorick Peterse 已提交
1374 1375 1376 1377 1378 1379 1380

      repository.before_remove_tag
    end
  end

  describe '#branch_count' do
    it 'returns the number of branches' do
D
Douwe Maan 已提交
1381
      expect(repository.branch_count).to be_an(Integer)
Y
Yorick Peterse 已提交
1382 1383 1384 1385 1386
    end
  end

  describe '#tag_count' do
    it 'returns the number of tags' do
D
Douwe Maan 已提交
1387
      expect(repository.tag_count).to be_an(Integer)
Y
Yorick Peterse 已提交
1388 1389 1390
    end
  end

1391
  describe '#expire_branches_cache' do
Y
Yorick Peterse 已提交
1392
    it 'expires the cache' do
1393 1394 1395
      expect(repository).to receive(:expire_method_caches).
        with(%i(branch_names branch_count)).
        and_call_original
Y
Yorick Peterse 已提交
1396

1397
      repository.expire_branches_cache
Y
Yorick Peterse 已提交
1398 1399 1400
    end
  end

1401
  describe '#expire_tags_cache' do
Y
Yorick Peterse 已提交
1402
    it 'expires the cache' do
1403 1404 1405
      expect(repository).to receive(:expire_method_caches).
        with(%i(tag_names tag_count)).
        and_call_original
Y
Yorick Peterse 已提交
1406

1407
      repository.expire_tags_cache
Y
Yorick Peterse 已提交
1408 1409
    end
  end
1410

1411
  describe '#add_tag' do
1412 1413
    context 'with a valid target' do
      let(:user) { build_stubbed(:user) }
1414

1415
      it 'creates the tag using rugged' do
1416 1417
        expect(repository.rugged.tags).to receive(:create).
          with('8.5', repository.commit('master').id,
1418
            hash_including(message: 'foo',
1419 1420
                           tagger: hash_including(name: user.name, email: user.email))).
          and_call_original
1421

1422 1423 1424 1425 1426 1427 1428 1429
        repository.add_tag(user, '8.5', 'master', 'foo')
      end

      it 'returns a Gitlab::Git::Tag object' do
        tag = repository.add_tag(user, '8.5', 'master', 'foo')

        expect(tag).to be_a(Gitlab::Git::Tag)
      end
1430 1431 1432 1433 1434 1435 1436

      it 'passes commit SHA to pre-receive and update hooks,\
        and tag SHA to post-receive hook' do
        pre_receive_hook = Gitlab::Git::Hook.new('pre-receive', repository.path_to_repo)
        update_hook = Gitlab::Git::Hook.new('update', repository.path_to_repo)
        post_receive_hook = Gitlab::Git::Hook.new('post-receive', repository.path_to_repo)

1437 1438
        allow(Gitlab::Git::Hook).to receive(:new).
          and_return(pre_receive_hook, update_hook, post_receive_hook)
1439 1440 1441 1442 1443 1444 1445 1446 1447 1448

        allow(pre_receive_hook).to receive(:trigger).and_call_original
        allow(update_hook).to receive(:trigger).and_call_original
        allow(post_receive_hook).to receive(:trigger).and_call_original

        tag = repository.add_tag(user, '8.5', 'master', 'foo')

        commit_sha = repository.commit('master').id
        tag_sha = tag.target

1449 1450 1451 1452 1453 1454
        expect(pre_receive_hook).to have_received(:trigger).
          with(anything, anything, commit_sha, anything)
        expect(update_hook).to have_received(:trigger).
          with(anything, anything, commit_sha, anything)
        expect(post_receive_hook).to have_received(:trigger).
          with(anything, anything, tag_sha, anything)
1455
      end
1456 1457 1458 1459 1460 1461
    end

    context 'with an invalid target' do
      it 'returns false' do
        expect(repository.add_tag(user, '8.5', 'bar', 'foo')).to be false
      end
1462 1463 1464
    end
  end

1465 1466 1467 1468 1469 1470 1471 1472 1473 1474
  describe '#rm_branch' do
    let(:user) { create(:user) }

    it 'removes a branch' do
      expect(repository).to receive(:before_remove_branch)
      expect(repository).to receive(:after_remove_branch)

      repository.rm_branch(user, 'feature')
    end
  end
1475 1476 1477 1478 1479

  describe '#rm_tag' do
    it 'removes a tag' do
      expect(repository).to receive(:before_remove_tag)

L
Lin Jen-Shin 已提交
1480 1481 1482
      repository.rm_tag(create(:user), 'v1.1.0')

      expect(repository.find_tag('v1.1.0')).to be_nil
1483 1484
    end
  end
1485 1486

  describe '#avatar' do
1487
    it 'returns nil if repo does not exist' do
1488 1489
      expect(repository).to receive(:file_on_head).
        and_raise(Rugged::ReferenceError)
1490 1491 1492 1493

      expect(repository.avatar).to eq(nil)
    end

1494
    it 'returns the first avatar file found in the repository' do
1495 1496 1497
      expect(repository).to receive(:file_on_head).
        with(:avatar).
        and_return(double(:tree, path: 'logo.png'))
1498 1499 1500 1501 1502

      expect(repository.avatar).to eq('logo.png')
    end

    it 'caches the output' do
1503 1504 1505 1506
      expect(repository).to receive(:file_on_head).
        with(:avatar).
        once.
        and_return(double(:tree, path: 'logo.png'))
1507

1508
      2.times { expect(repository.avatar).to eq('logo.png') }
1509 1510
    end
  end
1511

1512 1513 1514 1515 1516 1517 1518 1519 1520 1521
  describe '#expire_exists_cache' do
    let(:cache) { repository.send(:cache) }

    it 'expires the cache' do
      expect(cache).to receive(:expire).with(:exists?)

      repository.expire_exists_cache
    end
  end

1522
  describe "#keep_around" do
1523 1524 1525 1526
    it "does not fail if we attempt to reference bad commit" do
      expect(repository.kept_around?('abc1234')).to be_falsey
    end

1527 1528 1529 1530 1531
    it "stores a reference to the specified commit sha so it isn't garbage collected" do
      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_truthy
    end
1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547

    it "attempting to call keep_around on truncated ref does not fail" do
      repository.keep_around(sample_commit.id)
      ref = repository.send(:keep_around_ref_name, sample_commit.id)
      path = File.join(repository.path, ref)
      # Corrupt the reference
      File.truncate(path, 0)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      File.delete(path)
    end
1548
  end
1549

1550
  describe '#update_ref' do
1551
    it 'can create a ref' do
1552
      GitOperationService.new(nil, repository).send(:update_ref, 'refs/heads/foobar', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
1553 1554 1555 1556 1557 1558

      expect(repository.find_branch('foobar')).not_to be_nil
    end

    it 'raises CommitError when the ref update fails' do
      expect do
1559
        GitOperationService.new(nil, repository).send(:update_ref, 'refs/heads/master', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
1560 1561 1562
      end.to raise_error(Repository::CommitError)
    end
  end
1563 1564 1565

  describe '#contribution_guide', caching: true do
    it 'returns and caches the output' do
1566 1567 1568 1569
      expect(repository).to receive(:file_on_head).
        with(:contributing).
        and_return(Gitlab::Git::Tree.new(path: 'CONTRIBUTING.md')).
        once
1570 1571

      2.times do
1572 1573
        expect(repository.contribution_guide).
          to be_an_instance_of(Gitlab::Git::Tree)
1574 1575 1576 1577
      end
    end
  end

1578
  describe '#gitignore', caching: true do
1579
    it 'returns and caches the output' do
1580 1581 1582 1583
      expect(repository).to receive(:file_on_head).
        with(:gitignore).
        and_return(Gitlab::Git::Tree.new(path: '.gitignore')).
        once
1584 1585

      2.times do
1586
        expect(repository.gitignore).to be_an_instance_of(Gitlab::Git::Tree)
1587 1588 1589 1590
      end
    end
  end

1591
  describe '#koding_yml', caching: true do
1592
    it 'returns and caches the output' do
1593 1594 1595 1596
      expect(repository).to receive(:file_on_head).
        with(:koding).
        and_return(Gitlab::Git::Tree.new(path: '.koding.yml')).
        once
1597 1598

      2.times do
1599
        expect(repository.koding_yml).to be_an_instance_of(Gitlab::Git::Tree)
1600 1601 1602 1603
      end
    end
  end

1604 1605 1606 1607
  describe '#readme', caching: true do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)
1608

1609 1610 1611
        expect(repository.readme).to be_nil
      end
    end
1612

1613 1614 1615
    context 'with an existing repository' do
      it 'returns the README' do
        expect(repository.readme).to be_an_instance_of(Gitlab::Git::Blob)
1616 1617 1618 1619
      end
    end
  end

1620 1621
  describe '#expire_statistics_caches' do
    it 'expires the caches' do
1622 1623
      expect(repository).to receive(:expire_method_caches).
        with(%i(size commit_count))
1624

1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639
      repository.expire_statistics_caches
    end
  end

  describe '#expire_method_caches' do
    it 'expires the caches of the given methods' do
      expect_any_instance_of(RepositoryCache).to receive(:expire).with(:readme)
      expect_any_instance_of(RepositoryCache).to receive(:expire).with(:gitignore)

      repository.expire_method_caches(%i(readme gitignore))
    end
  end

  describe '#expire_all_method_caches' do
    it 'expires the caches of all methods' do
1640 1641
      expect(repository).to receive(:expire_method_caches).
        with(Repository::CACHED_METHODS)
1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665

      repository.expire_all_method_caches
    end
  end

  describe '#file_on_head' do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with a repository that has no blobs' do
      it 'returns nil' do
        expect_any_instance_of(Tree).to receive(:blobs).and_return([])

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with an existing repository' do
      it 'returns a Gitlab::Git::Tree' do
1666 1667
        expect(repository.file_on_head(:readme)).
          to be_an_instance_of(Gitlab::Git::Tree)
1668 1669 1670 1671
      end
    end
  end

1672 1673 1674 1675 1676 1677
  describe '#head_tree' do
    context 'with an existing repository' do
      it 'returns a Tree' do
        expect(repository.head_tree).to be_an_instance_of(Tree)
      end
    end
1678

1679 1680 1681 1682 1683
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:head_commit).and_return(nil)

        expect(repository.head_tree).to be_nil
1684 1685 1686 1687
      end
    end
  end

1688 1689 1690 1691 1692
  describe '#tree' do
    context 'using a non-existing repository' do
      before do
        allow(repository).to receive(:head_commit).and_return(nil)
      end
1693

1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736
      it 'returns nil' do
        expect(repository.tree(:head)).to be_nil
      end

      it 'returns nil when using a path' do
        expect(repository.tree(:head, 'README.md')).to be_nil
      end
    end

    context 'using an existing repository' do
      it 'returns a Tree' do
        expect(repository.tree(:head)).to be_an_instance_of(Tree)
      end
    end
  end

  describe '#size' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:exists?).and_return(false)

        expect(repository.size).to eq(0.0)
      end
    end

    context 'with an existing repository' do
      it 'returns the repository size as a Float' do
        expect(repository.size).to be_an_instance_of(Float)
      end
    end
  end

  describe '#commit_count' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:root_ref).and_return(nil)

        expect(repository.commit_count).to eq(0)
      end
    end

    context 'with an existing repository' do
      it 'returns the commit count' do
D
Douwe Maan 已提交
1737
        expect(repository.commit_count).to be_an(Integer)
1738 1739 1740 1741
      end
    end
  end

1742
  describe '#commit_count_for_ref' do
1743 1744
    let(:project) { create :empty_project }

1745 1746
    context 'with a non-existing repository' do
      it 'returns 0' do
1747 1748 1749 1750 1751 1752 1753 1754
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
      end
    end

    context 'with empty repository' do
      it 'returns 0' do
        project.create_repository
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
1755 1756 1757 1758 1759 1760 1761 1762 1763 1764
      end
    end

    context 'when searching for the root ref' do
      it 'returns the same count as #commit_count' do
        expect(repository.commit_count_for_ref(repository.root_ref)).to eq(repository.commit_count)
      end
    end
  end

1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781
  describe '#cache_method_output', caching: true do
    context 'with a non-existing repository' do
      let(:value) do
        repository.cache_method_output(:cats, fallback: 10) do
          raise Rugged::ReferenceError
        end
      end

      it 'returns a fallback value' do
        expect(value).to eq(10)
      end

      it 'does not cache the data' do
        value

        expect(repository.instance_variable_defined?(:@cats)).to eq(false)
        expect(repository.send(:cache).exist?(:cats)).to eq(false)
1782 1783
      end
    end
1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804

    context 'with an existing repository' do
      it 'caches the output' do
        object = double

        expect(object).to receive(:number).once.and_return(10)

        2.times do
          val = repository.cache_method_output(:cats) { object.number }

          expect(val).to eq(10)
        end

        expect(repository.send(:cache).exist?(:cats)).to eq(true)
        expect(repository.instance_variable_get(:@cats)).to eq(10)
      end
    end
  end

  describe '#refresh_method_caches' do
    it 'refreshes the caches of the given types' do
1805
      expect(repository).to receive(:expire_method_caches).
1806
        with(%i(rendered_readme license_blob license_key))
1807

1808
      expect(repository).to receive(:rendered_readme)
1809 1810 1811 1812 1813
      expect(repository).to receive(:license_blob)
      expect(repository).to receive(:license_key)

      repository.refresh_method_caches(%i(readme license))
    end
1814
  end
D
Douwe Maan 已提交
1815 1816 1817

  describe '#gitlab_ci_yml_for' do
    before do
1818
      repository.create_file(User.last, '.gitlab-ci.yml', 'CONTENT', message: 'Add .gitlab-ci.yml', branch_name: 'master')
D
Douwe Maan 已提交
1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835
    end

    context 'when there is a .gitlab-ci.yml at the commit' do
      it 'returns the content' do
        expect(repository.gitlab_ci_yml_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab-ci.yml at the commit' do
      it 'returns nil' do
        expect(repository.gitlab_ci_yml_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#route_map_for' do
    before do
1836
      repository.create_file(User.last, '.gitlab/route-map.yml', 'CONTENT', message: 'Add .gitlab/route-map.yml', branch_name: 'master')
D
Douwe Maan 已提交
1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      it 'returns the content' do
        expect(repository.route_map_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(repository.route_map_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end
1851

1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864
  # TODO: Uncomment when feature is reenabled
  # describe '#is_ancestor?' do
  #   context 'Gitaly is_ancestor feature enabled' do
  #     it 'asks Gitaly server if it\'s an ancestor' do
  #       commit = repository.commit
  #       allow(Gitlab::GitalyClient).to receive(:feature_enabled?).with(:is_ancestor).and_return(true)
  #       expect(Gitlab::GitalyClient::Commit).to receive(:is_ancestor).
  #         with(repository.raw_repository, commit.id, commit.id).and_return(true)
  #
  #       expect(repository.is_ancestor?(commit.id, commit.id)).to be true
  #     end
  #   end
  # end
1865
end