relations_test.rb 51.2 KB
Newer Older
1
require "cases/helper"
2
require 'models/tag'
3
require 'models/tagging'
4 5
require 'models/post'
require 'models/topic'
6
require 'models/comment'
7 8 9
require 'models/author'
require 'models/entrant'
require 'models/developer'
10
require 'models/reply'
11
require 'models/company'
12
require 'models/bird'
13 14 15
require 'models/car'
require 'models/engine'
require 'models/tyre'
16
require 'models/minivan'
17

18

E
Emilio Tagua 已提交
19
class RelationTest < ActiveRecord::TestCase
20
  fixtures :authors, :topics, :entrants, :developers, :companies, :developers_projects, :accounts, :categories, :categorizations, :posts, :comments,
21 22 23 24 25 26 27
    :tags, :taggings, :cars, :minivans

  def test_do_not_double_quote_string_id
    van = Minivan.last
    assert van
    assert_equal van.id, Minivan.where(:minivan_id => van).to_a.first.minivan_id
  end
28

29 30 31 32 33 34
  def test_do_not_double_quote_string_id_with_array
    van = Minivan.last
    assert van
    assert_equal van, Minivan.where(:minivan_id => [van]).to_a.first
  end

A
Aaron Patterson 已提交
35
  def test_bind_values
36
    relation = Post.all
A
Aaron Patterson 已提交
37 38 39 40 41 42 43
    assert_equal [], relation.bind_values

    relation2 = relation.bind 'foo'
    assert_equal %w{ foo }, relation2.bind_values
    assert_equal [], relation.bind_values
  end

44
  def test_two_scopes_with_includes_should_not_drop_any_include
45 46 47 48 49
    # heat habtm cache
    car = Car.incl_engines.incl_tyres.first
    car.tyres.length
    car.engines.length

50
    car = Car.incl_engines.incl_tyres.first
51 52
    assert_no_queries { car.tyres.length }
    assert_no_queries { car.engines.length }
53
  end
54

55 56 57 58 59
  def test_dynamic_finder
    x = Post.where('author_id = ?', 1)
    assert x.klass.respond_to?(:find_by_id), '@klass should handle dynamic finders'
  end

60 61 62 63 64
  def test_multivalue_where
    posts = Post.where('author_id = ? AND id = ?', 1, 1)
    assert_equal 1, posts.to_a.size
  end

65
  def test_scoped
66
    topics = Topic.all
67
    assert_kind_of ActiveRecord::Relation, topics
68
    assert_equal 5, topics.size
69 70
  end

71
  def test_to_json
72 73
    assert_nothing_raised  { Bird.all.to_json }
    assert_nothing_raised  { Bird.all.to_a.to_json }
74 75 76
  end

  def test_to_yaml
77 78
    assert_nothing_raised  { Bird.all.to_yaml }
    assert_nothing_raised  { Bird.all.to_a.to_yaml }
79 80
  end

81
  def test_to_xml
82 83
    assert_nothing_raised  { Bird.all.to_xml }
    assert_nothing_raised  { Bird.all.to_a.to_xml }
84 85
  end

86
  def test_scoped_all
87
    topics = Topic.all.to_a
88
    assert_kind_of Array, topics
89
    assert_no_queries { assert_equal 5, topics.size }
90 91
  end

P
Pratik Naik 已提交
92
  def test_loaded_all
93
    topics = Topic.all
P
Pratik Naik 已提交
94 95

    assert_queries(1) do
96
      2.times { assert_equal 5, topics.to_a.size }
P
Pratik Naik 已提交
97 98 99 100 101 102
    end

    assert topics.loaded?
  end

  def test_scoped_first
103
    topics = Topic.all.order('id ASC')
P
Pratik Naik 已提交
104 105 106 107 108 109 110 111 112

    assert_queries(1) do
      2.times { assert_equal "The First Topic", topics.first.title }
    end

    assert ! topics.loaded?
  end

  def test_loaded_first
113
    topics = Topic.all.order('id ASC')
P
Pratik Naik 已提交
114 115

    assert_queries(1) do
116
      topics.to_a # force load
P
Pratik Naik 已提交
117 118 119 120 121 122
      2.times { assert_equal "The First Topic", topics.first.title }
    end

    assert topics.loaded?
  end

123
  def test_reload
124
    topics = Topic.all
125 126 127 128 129 130 131

    assert_queries(1) do
      2.times { topics.to_a }
    end

    assert topics.loaded?

132 133
    original_size = topics.to_a.size
    Topic.create! :title => 'fake'
134

135 136 137
    assert_queries(1) { topics.reload }
    assert_equal original_size + 1, topics.size
    assert topics.loaded?
138 139
  end

I
Ivan Kukobko 已提交
140
  def test_finding_with_subquery
141 142 143 144 145 146
    relation = Topic.where(:approved => true)
    assert_equal relation.to_a, Topic.select('*').from(relation).to_a
    assert_equal relation.to_a, Topic.select('subquery.*').from(relation).to_a
    assert_equal relation.to_a, Topic.select('a.*').from(relation, :a).to_a
  end

147 148 149 150 151 152 153
  def test_finding_with_subquery_with_binds
    relation = Post.first.comments
    assert_equal relation.to_a, Comment.select('*').from(relation).to_a
    assert_equal relation.to_a, Comment.select('subquery.*').from(relation).to_a
    assert_equal relation.to_a, Comment.select('a.*').from(relation, :a).to_a
  end

154 155 156 157 158
  def test_finding_with_subquery_without_select_does_not_change_the_select
    relation = Topic.where(approved: true)
    assert_raises(ActiveRecord::StatementInvalid) do
      Topic.from(relation).to_a
    end
C
Cody Cutrer 已提交
159 160
  end

161

162
  def test_finding_with_conditions
163 164
    assert_equal ["David"], Author.where(:name => 'David').map(&:name)
    assert_equal ['Mary'],  Author.where(["name = ?", 'Mary']).map(&:name)
165
    assert_equal ['Mary'],  Author.where("name = ?", 'Mary').map(&:name)
166 167 168
  end

  def test_finding_with_order
169
    topics = Topic.order('id')
170
    assert_equal 5, topics.to_a.size
171 172 173
    assert_equal topics(:first).title, topics.first.title
  end

174 175
  def test_finding_with_arel_order
    topics = Topic.order(Topic.arel_table[:id].asc)
176
    assert_equal 5, topics.to_a.size
177 178
    assert_equal topics(:first).title, topics.first.title
  end
179

180 181
  def test_finding_with_assoc_order
    topics = Topic.order(:id => :desc)
182 183
    assert_equal 5, topics.to_a.size
    assert_equal topics(:fifth).title, topics.first.title
184
  end
185

186 187
  def test_finding_with_reverted_assoc_order
    topics = Topic.order(:id => :asc).reverse_order
188 189
    assert_equal 5, topics.to_a.size
    assert_equal topics(:fifth).title, topics.first.title
190
  end
191

Y
Yves Senn 已提交
192 193 194 195
  def test_order_with_hash_and_symbol_generates_the_same_sql
    assert_equal Topic.order(:id).to_sql, Topic.order(:id => :asc).to_sql
  end

196 197 198 199 200 201 202 203 204 205 206 207
  def test_finding_with_desc_order_with_string
    topics = Topic.order(id: "desc")
    assert_equal 5, topics.to_a.size
    assert_equal [topics(:fifth), topics(:fourth), topics(:third), topics(:second), topics(:first)], topics.to_a
  end

  def test_finding_with_asc_order_with_string
    topics = Topic.order(id: 'asc')
    assert_equal 5, topics.to_a.size
    assert_equal [topics(:first), topics(:second), topics(:third), topics(:fourth), topics(:fifth)], topics.to_a
  end

208 209 210 211 212
  def test_support_upper_and_lower_case_directions
    assert_includes Topic.order(id: "ASC").to_sql, "ASC"
    assert_includes Topic.order(id: "asc").to_sql, "ASC"
    assert_includes Topic.order(id: :ASC).to_sql, "ASC"
    assert_includes Topic.order(id: :asc).to_sql, "ASC"
213

214 215 216 217
    assert_includes Topic.order(id: "DESC").to_sql, "DESC"
    assert_includes Topic.order(id: "desc").to_sql, "DESC"
    assert_includes Topic.order(id: :DESC).to_sql, "DESC"
    assert_includes Topic.order(id: :desc).to_sql,"DESC"
218 219
  end

220
  def test_raising_exception_on_invalid_hash_params
221 222
    e = assert_raise(ArgumentError) { Topic.order(:name, "id DESC", id: :asfsdf) }
    assert_equal 'Direction "asfsdf" is invalid. Valid directions are: [:asc, :desc, :ASC, :DESC, "asc", "desc", "ASC", "DESC"]', e.message
223
  end
224 225 226

  def test_finding_last_with_arel_order
    topics = Topic.order(Topic.arel_table[:id].asc)
227
    assert_equal topics(:fifth).title, topics.last.title
228 229
  end

230
  def test_finding_with_order_concatenated
231
    topics = Topic.order('author_name').order('title')
232
    assert_equal 5, topics.to_a.size
233 234 235
    assert_equal topics(:fourth).title, topics.first.title
  end

236 237 238 239 240 241 242 243 244 245 246 247
  def test_finding_with_order_by_aliased_attributes
    topics = Topic.order(:heading)
    assert_equal 5, topics.to_a.size
    assert_equal topics(:fifth).title, topics.first.title
  end

  def test_finding_with_assoc_order_by_aliased_attributes
    topics = Topic.order(heading: :desc)
    assert_equal 5, topics.to_a.size
    assert_equal topics(:third).title, topics.first.title
  end

S
Sebastian Martinez 已提交
248
  def test_finding_with_reorder
249
    topics = Topic.order('author_name').order('title').reorder('id').to_a
S
Sebastian Martinez 已提交
250
    topics_titles = topics.map{ |t| t.title }
251
    assert_equal ['The First Topic', 'The Second Topic of the day', 'The Third Topic of the day', 'The Fourth Topic of the day', 'The Fifth Topic of the day'], topics_titles
S
Sebastian Martinez 已提交
252
  end
253

254 255 256 257 258 259 260 261 262 263 264 265
  def test_finding_with_reorder_by_aliased_attributes
    topics = Topic.order('author_name').reorder(:heading)
    assert_equal 5, topics.to_a.size
    assert_equal topics(:fifth).title, topics.first.title
  end

  def test_finding_with_assoc_reorder_by_aliased_attributes
    topics = Topic.order('author_name').reorder(heading: :desc)
    assert_equal 5, topics.to_a.size
    assert_equal topics(:third).title, topics.first.title
  end

266
  def test_finding_with_order_and_take
267
    entrants = Entrant.order("id ASC").limit(2).to_a
268

P
Pratik Naik 已提交
269 270
    assert_equal 2, entrants.size
    assert_equal entrants(:first).name, entrants.first.name
271 272
  end

273
  def test_finding_with_cross_table_order_and_limit
274
    tags = Tag.includes(:taggings).
275 276
              order("tags.name asc", "taggings.taggable_id asc", "REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").
              limit(1).to_a
277 278 279
    assert_equal 1, tags.length
  end

280
  def test_finding_with_complex_order_and_limit
281
    tags = Tag.includes(:taggings).references(:taggings).order("REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").limit(1).to_a
282 283 284 285
    assert_equal 1, tags.length
  end

  def test_finding_with_complex_order
286
    tags = Tag.includes(:taggings).references(:taggings).order("REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").to_a
287
    assert_equal 3, tags.length
288 289
  end

290
  def test_finding_with_order_limit_and_offset
291
    entrants = Entrant.order("id ASC").limit(2).offset(1)
292

293
    assert_equal 2, entrants.to_a.size
P
Pratik Naik 已提交
294
    assert_equal entrants(:second).name, entrants.first.name
295

296
    entrants = Entrant.order("id ASC").limit(2).offset(2)
297
    assert_equal 1, entrants.to_a.size
P
Pratik Naik 已提交
298
    assert_equal entrants(:third).name, entrants.first.name
299 300 301
  end

  def test_finding_with_group
302
    developers = Developer.group("salary").select("salary").to_a
303 304 305 306
    assert_equal 4, developers.size
    assert_equal 4, developers.map(&:salary).uniq.size
  end

307
  def test_select_with_block
308
    even_ids = Developer.all.select {|d| d.id % 2 == 0 }.map(&:id)
309
    assert_equal [2, 4, 6, 8, 10], even_ids.sort
310 311
  end

312 313 314
  def test_none
    assert_no_queries do
      assert_equal [], Developer.none
315
      assert_equal [], Developer.all.none
316 317 318 319 320 321 322 323 324
    end
  end

  def test_none_chainable
    assert_no_queries do
      assert_equal [], Developer.none.where(:name => 'David')
    end
  end

A
Akira Matsuda 已提交
325 326 327 328 329 330
  def test_none_chainable_to_existing_scope_extension_method
    assert_no_queries do
      assert_equal 1, Topic.anonymous_extension.none.one
    end
  end

331 332
  def test_none_chained_to_methods_firing_queries_straight_to_db
    assert_no_queries do
333
      assert_equal [],    Developer.none.pluck(:id, :name)
334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352
      assert_equal 0,     Developer.none.delete_all
      assert_equal 0,     Developer.none.update_all(:name => 'David')
      assert_equal 0,     Developer.none.delete(1)
      assert_equal false, Developer.none.exists?(1)
    end
  end

  def test_null_relation_content_size_methods
    assert_no_queries do
      assert_equal 0,     Developer.none.size
      assert_equal 0,     Developer.none.count
      assert_equal true,  Developer.none.empty?
      assert_equal false, Developer.none.any?
      assert_equal false, Developer.none.many?
    end
  end

  def test_null_relation_calculations_methods
    assert_no_queries do
353
      assert_equal 0, Developer.none.count
354
      assert_equal 0, Developer.none.calculate(:count, nil, {})
355
      assert_equal nil, Developer.none.calculate(:average, 'salary')
356 357
    end
  end
358

359 360 361 362 363
  def test_null_relation_metadata_methods
    assert_equal "", Developer.none.to_sql
    assert_equal({}, Developer.none.where_values_hash)
  end

364 365 366 367
  def test_null_relation_where_values_hash
    assert_equal({ 'salary' => 100_000 }, Developer.none.where(salary: 100_000).where_values_hash)
  end

368 369 370 371
  def test_joins_with_nil_argument
    assert_nothing_raised { DependentFirm.joins(nil).first }
  end

372
  def test_finding_with_hash_conditions_on_joined_table
373
    firms = DependentFirm.joins(:account).where({:name => 'RailsCore', :accounts => { :credit_limit => 55..60 }}).to_a
374 375 376 377 378
    assert_equal 1, firms.size
    assert_equal companies(:rails_core), firms.first
  end

  def test_find_all_with_join
379
    developers_on_project_one = Developer.joins('LEFT JOIN developers_projects ON developers.id = developers_projects.developer_id').
380
      where('project_id=1').to_a
381 382 383 384 385 386 387 388

    assert_equal 3, developers_on_project_one.length
    developer_names = developers_on_project_one.map { |d| d.name }
    assert developer_names.include?('David')
    assert developer_names.include?('Jamis')
  end

  def test_find_on_hash_conditions
389
    assert_equal Topic.all.merge!(:where => {:approved => false}).to_a, Topic.where({ :approved => false }).to_a
390 391 392
  end

  def test_joins_with_string_array
393
    person_with_reader_and_post = Post.joins([
394 395 396 397 398 399
        "INNER JOIN categorizations ON categorizations.post_id = posts.id",
        "INNER JOIN categories ON categories.id = categorizations.category_id AND categories.type = 'SpecialCategory'"
      ]
    ).to_a
    assert_equal 1, person_with_reader_and_post.size
  end
400

401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416
  def test_no_arguments_to_query_methods_raise_errors
    assert_raises(ArgumentError) { Topic.references() }
    assert_raises(ArgumentError) { Topic.includes() }
    assert_raises(ArgumentError) { Topic.preload() }
    assert_raises(ArgumentError) { Topic.group() }
    assert_raises(ArgumentError) { Topic.reorder() }
  end

  def test_blank_like_arguments_to_query_methods_dont_raise_errors
    assert_nothing_raised { Topic.references([]) }
    assert_nothing_raised { Topic.includes([]) }
    assert_nothing_raised { Topic.preload([]) }
    assert_nothing_raised { Topic.group([]) }
    assert_nothing_raised { Topic.reorder([]) }
  end

417
  def test_scoped_responds_to_delegated_methods
418
    relation = Topic.all
419 420

    ["map", "uniq", "sort", "insert", "delete", "update"].each do |method|
421
      assert_respond_to relation, method, "Topic.all should respond to #{method.inspect}"
422 423 424
    end
  end

425
  def test_respond_to_delegates_to_relation
426
    relation = Topic.all
427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443
    fake_arel = Struct.new(:responds) {
      def respond_to? method, access = false
        responds << [method, access]
      end
    }.new []

    relation.extend(Module.new { attr_accessor :arel })
    relation.arel = fake_arel

    relation.respond_to?(:matching_attributes)
    assert_equal [:matching_attributes, false], fake_arel.responds.first

    fake_arel.responds = []
    relation.respond_to?(:matching_attributes, true)
    assert_equal [:matching_attributes, true], fake_arel.responds.first
  end

444
  def test_respond_to_dynamic_finders
445
    relation = Topic.all
446

447
    ["find_by_title", "find_by_title_and_author_name"].each do |method|
448
      assert_respond_to relation, method, "Topic.all should respond to #{method.inspect}"
449 450
    end
  end
451

452
  def test_respond_to_class_methods_and_scopes
453
    assert Topic.all.respond_to?(:by_lifo)
454 455
  end

456
  def test_find_with_readonly_option
457 458
    Developer.all.each { |d| assert !d.readonly? }
    Developer.all.readonly.each { |d| assert d.readonly? }
459
  end
460 461

  def test_eager_association_loading_of_stis_with_multiple_references
462
    authors = Author.eager_load(:posts => { :special_comments => { :post => [ :special_comments, :very_special_comment ] } }).
463
      order('comments.body, very_special_comments_posts.body').where('posts.id = 4').to_a
464

465 466 467 468 469 470 471
    assert_equal [authors(:david)], authors
    assert_no_queries do
      authors.first.posts.first.special_comments.first.post.special_comments
      authors.first.posts.first.special_comments.first.post.very_special_comment
    end
  end

472
  def test_find_with_preloaded_associations
473
    assert_queries(2) do
474
      posts = Post.preload(:comments).order('posts.id')
475
      assert posts.first.comments.first
476
    end
477

C
Carlos Antonio da Silva 已提交
478
    assert_queries(2) do
479
      posts = Post.preload(:comments).order('posts.id')
480
      assert posts.first.comments.first
481
    end
482

483
    assert_queries(2) do
484
      posts = Post.preload(:author).order('posts.id')
485
      assert posts.first.author
486
    end
487

C
Carlos Antonio da Silva 已提交
488
    assert_queries(2) do
489
      posts = Post.preload(:author).order('posts.id')
490 491 492
      assert posts.first.author
    end

C
Carlos Antonio da Silva 已提交
493
    assert_queries(3) do
494
      posts = Post.preload(:author, :comments).order('posts.id')
495
      assert posts.first.author
496 497 498 499
      assert posts.first.comments.first
    end
  end

500 501 502 503 504 505 506
  def test_preload_applies_to_all_chained_preloaded_scopes
    assert_queries(3) do
      post = Post.with_comments.with_tags.first
      assert post
    end
  end

507 508
  def test_find_with_included_associations
    assert_queries(2) do
509
      posts = Post.includes(:comments).order('posts.id')
510 511 512
      assert posts.first.comments.first
    end

C
Carlos Antonio da Silva 已提交
513
    assert_queries(2) do
514
      posts = Post.all.includes(:comments).order('posts.id')
515 516 517 518
      assert posts.first.comments.first
    end

    assert_queries(2) do
519
      posts = Post.includes(:author).order('posts.id')
520 521 522
      assert posts.first.author
    end

C
Carlos Antonio da Silva 已提交
523
    assert_queries(3) do
524
      posts = Post.includes(:author, :comments).order('posts.id')
525
      assert posts.first.author
526
      assert posts.first.comments.first
527 528
    end
  end
529

P
Pratik Naik 已提交
530
  def test_default_scope_with_conditions_string
531
    assert_equal Developer.where(name: 'David').map(&:id).sort, DeveloperCalledDavid.all.map(&:id).sort
532
    assert_nil DeveloperCalledDavid.create!.name
533 534 535
  end

  def test_default_scope_with_conditions_hash
536
    assert_equal Developer.where(name: 'Jamis').map(&:id).sort, DeveloperCalledJamis.all.map(&:id).sort
537 538 539
    assert_equal 'Jamis', DeveloperCalledJamis.create!.name
  end

540 541
  def test_default_scoping_finder_methods
    developers = DeveloperCalledDavid.order('id').map(&:id).sort
J
Jon Leighton 已提交
542
    assert_equal Developer.where(name: 'David').map(&:id).sort, developers
543 544
  end

545 546 547 548 549 550 551 552
  def test_includes_with_select
    query = Post.select('comments_count AS ranking').order('ranking').includes(:comments)
      .where(comments: { id: 1 })

    assert_equal ['comments_count AS ranking'], query.select_values
    assert_equal 1, query.to_a.size
  end

553 554
  def test_loading_with_one_association
    posts = Post.preload(:comments)
555 556 557 558
    post = posts.find { |p| p.id == 1 }
    assert_equal 2, post.comments.size
    assert post.comments.include?(comments(:greetings))

559
    post = Post.where("posts.title = 'Welcome to the weblog'").preload(:comments).first
560 561 562
    assert_equal 2, post.comments.size
    assert post.comments.include?(comments(:greetings))

563
    posts = Post.preload(:last_comment)
564 565 566 567
    post = posts.find { |p| p.id == 1 }
    assert_equal Post.find(1).last_comment, post.last_comment
  end

568 569 570 571 572 573 574 575
  def test_to_sql_on_eager_join
    expected = assert_sql {
      Post.eager_load(:last_comment).order('comments.id DESC').to_a
    }.first
    actual = Post.eager_load(:last_comment).order('comments.id DESC').to_sql
    assert_equal expected, actual
  end

576 577 578 579 580 581
  def test_to_sql_on_scoped_proxy
    auth = Author.first
    Post.where("1=1").written_by(auth)
    assert_not auth.posts.to_sql.include?("1=1")
  end

582
  def test_loading_with_one_association_with_non_preload
583
    posts = Post.eager_load(:last_comment).order('comments.id DESC')
584 585 586
    post = posts.find { |p| p.id == 1 }
    assert_equal Post.find(1).last_comment, post.last_comment
  end
587 588 589 590 591 592 593

  def test_dynamic_find_by_attributes
    david = authors(:david)
    author = Author.preload(:taggings).find_by_id(david.id)
    expected_taggings = taggings(:welcome_general, :thinking_general)

    assert_no_queries do
594
      assert_equal expected_taggings, author.taggings.distinct.sort_by { |t| t.id }
595 596 597
      assert_equal expected_taggings, author.taggings.uniq.sort_by { |t| t.id }
    end

598
    authors = Author.all
599 600 601 602 603
    assert_equal david, authors.find_by_id_and_name(david.id, david.name)
    assert_equal david, authors.find_by_id_and_name!(david.id, david.name)
  end

  def test_dynamic_find_by_attributes_bang
604
    author = Author.all.find_by_id!(authors(:david).id)
605 606
    assert_equal "David", author.name

607
    assert_raises(ActiveRecord::RecordNotFound) { Author.all.find_by_id_and_name!(20, 'invalid') }
608 609
  end

P
Pratik Naik 已提交
610
  def test_find_id
611
    authors = Author.all
P
Pratik Naik 已提交
612 613 614 615

    david = authors.find(authors(:david).id)
    assert_equal 'David', david.name

P
Pratik Naik 已提交
616
    assert_raises(ActiveRecord::RecordNotFound) { authors.where(:name => 'lifo').find('42') }
P
Pratik Naik 已提交
617
  end
618

P
Pratik Naik 已提交
619 620 621 622 623 624 625 626 627 628
  def test_find_ids
    authors = Author.order('id ASC')

    results = authors.find(authors(:david).id, authors(:mary).id)
    assert_kind_of Array, results
    assert_equal 2, results.size
    assert_equal 'David', results[0].name
    assert_equal 'Mary', results[1].name
    assert_equal results, authors.find([authors(:david).id, authors(:mary).id])

P
Pratik Naik 已提交
629 630
    assert_raises(ActiveRecord::RecordNotFound) { authors.where(:name => 'lifo').find(authors(:david).id, '42') }
    assert_raises(ActiveRecord::RecordNotFound) { authors.find(['42', 43]) }
P
Pratik Naik 已提交
631 632
  end

633
  def test_find_in_empty_array
634 635
    authors = Author.all.where(:id => [])
    assert authors.to_a.blank?
636 637
  end

638 639
  def test_where_with_ar_object
    author = Author.first
640
    authors = Author.all.where(:id => author)
641
    assert_equal 1, authors.to_a.length
642 643
  end

644 645
  def test_find_with_list_of_ar
    author = Author.first
646
    authors = Author.find([author.id])
647 648 649
    assert_equal author, authors.first
  end

650 651 652 653 654 655 656
  class Mary < Author; end

  def test_find_by_classname
    Author.create!(:name => Mary.name)
    assert_equal 1, Author.where(:name => Mary).size
  end

657 658 659 660 661 662
  def test_find_by_id_with_list_of_ar
    author = Author.first
    authors = Author.find_by_id([author])
    assert_equal author, authors
  end

663 664 665 666 667 668
  def test_find_all_using_where_twice_should_or_the_relation
    david = authors(:david)
    relation = Author.unscoped
    relation = relation.where(:name => david.name)
    relation = relation.where(:name => 'Santiago')
    relation = relation.where(:id => david.id)
669
    assert_equal [], relation.to_a
670 671
  end

A
Aaron Patterson 已提交
672 673 674 675 676 677 678 679
  def test_multi_where_ands_queries
    relation = Author.unscoped
    david = authors(:david)
    sql = relation.where(:name => david.name).where(:name => 'Santiago').to_sql
    assert_match('AND', sql)
  end

  def test_find_all_with_multiple_should_use_and
A
Aaron Patterson 已提交
680 681 682 683 684 685 686 687
    david = authors(:david)
    relation = [
      { :name => david.name },
      { :name => 'Santiago' },
      { :name => 'tenderlove' },
    ].inject(Author.unscoped) do |memo, param|
      memo.where(param)
    end
688
    assert_equal [], relation.to_a
A
Aaron Patterson 已提交
689
  end
A
Aaron Patterson 已提交
690

691 692 693 694 695 696
  def test_find_all_using_where_with_relation
    david = authors(:david)
    # switching the lines below would succeed in current rails
    # assert_queries(2) {
    assert_queries(1) {
      relation = Author.where(:id => Author.where(:id => david.id))
697
      assert_equal [david], relation.to_a
698
    }
699 700 701 702 703

    assert_queries(1) {
      relation = Author.where('id in (?)', Author.where(id: david).select(:id))
      assert_equal [david], relation.to_a
    }
704 705 706 707 708 709 710 711 712

    assert_queries(1) do
      relation = Author.where('id in (:author_ids)', author_ids: Author.where(id: david).select(:id))
      assert_equal [david], relation.to_a
    end
  end

  def test_find_all_using_where_with_relation_with_bound_values
    david = authors(:david)
713
    davids_posts = david.posts.order(:id).to_a
714 715 716

    assert_queries(1) do
      relation = Post.where(id: david.posts.select(:id))
717
      assert_equal davids_posts, relation.order(:id).to_a
718 719 720 721
    end

    assert_queries(1) do
      relation = Post.where('id in (?)', david.posts.select(:id))
722
      assert_equal davids_posts, relation.order(:id).to_a, 'should process Relation as bind variables'
723 724 725 726
    end

    assert_queries(1) do
      relation = Post.where('id in (:post_ids)', post_ids: david.posts.select(:id))
727
      assert_equal davids_posts, relation.order(:id).to_a, 'should process Relation as named bind variables'
728
    end
729 730
  end

731 732 733 734 735 736
  def test_find_all_using_where_with_relation_and_alternate_primary_key
    cool_first = minivans(:cool_first)
    # switching the lines below would succeed in current rails
    # assert_queries(2) {
    assert_queries(1) {
      relation = Minivan.where(:minivan_id => Minivan.where(:name => cool_first.name))
737
      assert_equal [cool_first], relation.to_a
738 739 740
    }
  end

741 742 743 744 745 746 747
  def test_find_all_using_where_with_relation_does_not_alter_select_values
    david = authors(:david)

    subquery = Author.where(:id => david.id)

    assert_queries(1) {
      relation = Author.where(:id => subquery)
748
      assert_equal [david], relation.to_a
749 750 751 752 753
    }

    assert_equal 0, subquery.select_values.size
  end

754 755 756 757
  def test_find_all_using_where_with_relation_with_joins
    david = authors(:david)
    assert_queries(1) {
      relation = Author.where(:id => Author.joins(:posts).where(:id => david.id))
758
      assert_equal [david], relation.to_a
759 760 761
    }
  end

A
Aaron Patterson 已提交
762

763 764 765 766
  def test_find_all_using_where_with_relation_with_select_to_build_subquery
    david = authors(:david)
    assert_queries(1) {
      relation = Author.where(:name => Author.where(:id => david.id).select(:name))
767
      assert_equal [david], relation.to_a
768
    }
A
Aaron Patterson 已提交
769 770
  end

P
Pratik Naik 已提交
771 772 773 774 775
  def test_exists
    davids = Author.where(:name => 'David')
    assert davids.exists?
    assert davids.exists?(authors(:david).id)
    assert ! davids.exists?(authors(:mary).id)
P
Pratik Naik 已提交
776 777
    assert ! davids.exists?("42")
    assert ! davids.exists?(42)
778
    assert ! davids.exists?(davids.new.id)
P
Pratik Naik 已提交
779 780 781 782 783

    fake  = Author.where(:name => 'fake author')
    assert ! fake.exists?
    assert ! fake.exists?(authors(:david).id)
  end
784 785

  def test_last
786
    authors = Author.all
787
    assert_equal authors(:bob), authors.last
788 789
  end

P
Pratik Naik 已提交
790 791 792 793 794 795 796 797 798 799 800 801 802
  def test_destroy_all
    davids = Author.where(:name => 'David')

    # Force load
    assert_equal [authors(:david)], davids.to_a
    assert davids.loaded?

    assert_difference('Author.count', -1) { davids.destroy_all }

    assert_equal [], davids.to_a
    assert davids.loaded?
  end

P
Pratik Naik 已提交
803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822
  def test_delete_all
    davids = Author.where(:name => 'David')

    assert_difference('Author.count', -1) { davids.delete_all }
    assert ! davids.loaded?
  end

  def test_delete_all_loaded
    davids = Author.where(:name => 'David')

    # Force load
    assert_equal [authors(:david)], davids.to_a
    assert davids.loaded?

    assert_difference('Author.count', -1) { davids.delete_all }

    assert_equal [], davids.to_a
    assert davids.loaded?
  end

823 824 825 826
  def test_delete_all_limit_error
    assert_raises(ActiveRecord::ActiveRecordError) { Author.limit(10).delete_all }
  end

827 828
  def test_select_with_aggregates
    posts = Post.select(:title, :body)
R
Rafael Mendonça França 已提交
829

830 831 832 833
    assert_equal 11, posts.count(:all)
    assert_equal 11, posts.size
    assert posts.any?
    assert posts.many?
R
Rafael Mendonça França 已提交
834
    assert_not posts.empty?
835
  end
R
Rafael Mendonça França 已提交
836

837 838 839 840 841 842 843 844
  def test_select_takes_a_variable_list_of_args
    david = developers(:david)

    developer = Developer.where(id: david.id).select(:name, :salary).first
    assert_equal david.name, developer.name
    assert_equal david.salary, developer.salary
  end

845 846 847 848 849 850 851
  def test_select_takes_an_aliased_attribute
    first = topics(:first)

    topic = Topic.where(id: first.id).select(:heading).first
    assert_equal first.heading, topic.heading
  end

852 853 854 855
  def test_select_argument_error
    assert_raises(ArgumentError) { Developer.select }
  end

P
Pratik Naik 已提交
856
  def test_count
857
    posts = Post.all
P
Pratik Naik 已提交
858

859 860 861
    assert_equal 11, posts.count
    assert_equal 11, posts.count(:all)
    assert_equal 11, posts.count(:id)
P
Pratik Naik 已提交
862 863

    assert_equal 1, posts.where('comments_count > 1').count
864
    assert_equal 9, posts.where(:comments_count => 0).count
P
Pratik Naik 已提交
865 866
  end

867 868 869 870 871 872 873 874 875 876 877
  def test_count_on_association_relation
    author = Author.last
    another_author = Author.first
    posts = Post.where(author_id: author.id)

    assert_equal author.posts.where(author_id: author.id).size, posts.count

    assert_equal 0, author.posts.where(author_id: another_author.id).size
    assert author.posts.where(author_id: another_author.id).empty?
  end

P
Pratik Naik 已提交
878
  def test_count_with_distinct
879
    posts = Post.all
P
Pratik Naik 已提交
880

881 882
    assert_equal 3, posts.distinct(true).count(:comments_count)
    assert_equal 11, posts.distinct(false).count(:comments_count)
P
Pratik Naik 已提交
883

884 885
    assert_equal 3, posts.distinct(true).select(:comments_count).count
    assert_equal 11, posts.distinct(false).select(:comments_count).count
P
Pratik Naik 已提交
886 887 888 889
  end

  def test_count_explicit_columns
    Post.update_all(:comments_count => nil)
890
    posts = Post.all
P
Pratik Naik 已提交
891

P
Pratik Naik 已提交
892
    assert_equal [0], posts.select('comments_count').where('id is not null').group('id').order('id').count.values.uniq
893
    assert_equal 0, posts.where('id is not null').select('comments_count').count
894

895
    assert_equal 11, posts.select('comments_count').count('id')
P
Pratik Naik 已提交
896 897 898 899
    assert_equal 0, posts.select('comments_count').count
    assert_equal 0, posts.count(:comments_count)
    assert_equal 0, posts.count('comments_count')
  end
900

901
  def test_multiple_selects
902
    post = Post.all.select('comments_count').select('title').order("id ASC").first
903 904 905 906
    assert_equal "Welcome to the weblog", post.title
    assert_equal 2, post.comments_count
  end

907
  def test_size
908
    posts = Post.all
909

910
    assert_queries(1) { assert_equal 11, posts.size }
911 912 913 914
    assert ! posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
915
    assert_no_queries { assert_equal 9, best_posts.size }
916 917
  end

918
  def test_size_with_limit
919
    posts = Post.limit(10)
920

921
    assert_queries(1) { assert_equal 10, posts.size }
922 923 924 925
    assert ! posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
926
    assert_no_queries { assert_equal 9, best_posts.size }
927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945
  end

  def test_size_with_zero_limit
    posts = Post.limit(0)

    assert_no_queries { assert_equal 0, posts.size }
    assert ! posts.loaded?

    posts.to_a # force load
    assert_no_queries { assert_equal 0, posts.size }
  end

  def test_empty_with_zero_limit
    posts = Post.limit(0)

    assert_no_queries { assert_equal true, posts.empty? }
    assert ! posts.loaded?
  end

946 947 948 949 950 951 952
  def test_count_complex_chained_relations
    posts = Post.select('comments_count').where('id is not null').group("author_id").where("comments_count > 0")

    expected = { 1 => 2 }
    assert_equal expected, posts.count
  end

953
  def test_empty
954
    posts = Post.all
955 956 957 958 959 960 961 962 963 964 965 966 967 968 969

    assert_queries(1) { assert_equal false, posts.empty? }
    assert ! posts.loaded?

    no_posts = posts.where(:title => "")
    assert_queries(1) { assert_equal true, no_posts.empty? }
    assert ! no_posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
    assert_no_queries { assert_equal false, best_posts.empty? }
  end

  def test_empty_complex_chained_relations
    posts = Post.select("comments_count").where("id is not null").group("author_id").where("comments_count > 0")
A
Andrew White 已提交
970

971 972 973 974 975 976 977 978
    assert_queries(1) { assert_equal false, posts.empty? }
    assert ! posts.loaded?

    no_posts = posts.where(:title => "")
    assert_queries(1) { assert_equal true, no_posts.empty? }
    assert ! no_posts.loaded?
  end

P
Pratik Naik 已提交
979
  def test_any
980
    posts = Post.all
P
Pratik Naik 已提交
981

982 983 984 985 986 987 988 989
    # This test was failing when run on its own (as opposed to running the entire suite).
    # The second line in the assert_queries block was causing visit_Arel_Attributes_Attribute
    # in Arel::Visitors::ToSql to trigger a SHOW TABLES query. Running that line here causes
    # the SHOW TABLES result to be cached so we don't have to do it again in the block.
    #
    # This is obviously a rubbish fix but it's the best I can come up with for now...
    posts.where(:id => nil).any?

P
Pratik Naik 已提交
990 991 992 993 994 995 996 997 998 999 1000 1001
    assert_queries(3) do
      assert posts.any? # Uses COUNT()
      assert ! posts.where(:id => nil).any?

      assert posts.any? {|p| p.id > 0 }
      assert ! posts.any? {|p| p.id <= 0 }
    end

    assert posts.loaded?
  end

  def test_many
1002
    posts = Post.all
1003

P
Pratik Naik 已提交
1004 1005 1006 1007 1008
    assert_queries(2) do
      assert posts.many? # Uses COUNT()
      assert posts.many? {|p| p.id > 0 }
      assert ! posts.many? {|p| p.id < 2 }
    end
1009

P
Pratik Naik 已提交
1010 1011 1012
    assert posts.loaded?
  end

1013
  def test_many_with_limits
1014
    posts = Post.all
1015 1016 1017 1018

    assert posts.many?
    assert ! posts.limit(1).many?
  end
P
Pratik Naik 已提交
1019 1020

  def test_build
1021
    posts = Post.all
P
Pratik Naik 已提交
1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034

    post = posts.new
    assert_kind_of Post, post
  end

  def test_scoped_build
    posts = Post.where(:title => 'You told a lie')

    post = posts.new
    assert_kind_of Post, post
    assert_equal 'You told a lie', post.title
  end

1035
  def test_create
1036
    birds = Bird.all
1037 1038 1039

    sparrow = birds.create
    assert_kind_of Bird, sparrow
1040
    assert !sparrow.persisted?
1041 1042

    hen = birds.where(:name => 'hen').create
1043
    assert hen.persisted?
1044 1045 1046 1047
    assert_equal 'hen', hen.name
  end

  def test_create_bang
1048
    birds = Bird.all
1049 1050 1051 1052 1053

    assert_raises(ActiveRecord::RecordInvalid) { birds.create! }

    hen = birds.where(:name => 'hen').create!
    assert_kind_of Bird, hen
1054
    assert hen.persisted?
1055 1056
    assert_equal 'hen', hen.name
  end
P
Pratik Naik 已提交
1057

1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132
  def test_first_or_create
    parrot = Bird.where(:color => 'green').first_or_create(:name => 'parrot')
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color

    same_parrot = Bird.where(:color => 'green').first_or_create(:name => 'parakeet')
    assert_kind_of Bird, same_parrot
    assert same_parrot.persisted?
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_with_no_parameters
    parrot = Bird.where(:color => 'green').first_or_create
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert_equal 'green', parrot.color
  end

  def test_first_or_create_with_block
    parrot = Bird.where(:color => 'green').first_or_create { |bird| bird.name = 'parrot' }
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name

    same_parrot = Bird.where(:color => 'green').first_or_create { |bird| bird.name = 'parakeet' }
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_with_array
    several_green_birds = Bird.where(:color => 'green').first_or_create([{:name => 'parrot'}, {:name => 'parakeet'}])
    assert_kind_of Array, several_green_birds
    several_green_birds.each { |bird| assert bird.persisted? }

    same_parrot = Bird.where(:color => 'green').first_or_create([{:name => 'hummingbird'}, {:name => 'macaw'}])
    assert_kind_of Bird, same_parrot
    assert_equal several_green_birds.first, same_parrot
  end

  def test_first_or_create_bang_with_valid_options
    parrot = Bird.where(:color => 'green').first_or_create!(:name => 'parrot')
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color

    same_parrot = Bird.where(:color => 'green').first_or_create!(:name => 'parakeet')
    assert_kind_of Bird, same_parrot
    assert same_parrot.persisted?
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_bang_with_invalid_options
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create!(:pirate_id => 1) }
  end

  def test_first_or_create_bang_with_no_parameters
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create! }
  end

  def test_first_or_create_bang_with_valid_block
    parrot = Bird.where(:color => 'green').first_or_create! { |bird| bird.name = 'parrot' }
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name

    same_parrot = Bird.where(:color => 'green').first_or_create! { |bird| bird.name = 'parakeet' }
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_bang_with_invalid_block
    assert_raise(ActiveRecord::RecordInvalid) do
1133
      Bird.where(:color => 'green').first_or_create! { |bird| bird.pirate_id = 1 }
1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150
    end
  end

  def test_first_or_create_with_valid_array
    several_green_birds = Bird.where(:color => 'green').first_or_create!([{:name => 'parrot'}, {:name => 'parakeet'}])
    assert_kind_of Array, several_green_birds
    several_green_birds.each { |bird| assert bird.persisted? }

    same_parrot = Bird.where(:color => 'green').first_or_create!([{:name => 'hummingbird'}, {:name => 'macaw'}])
    assert_kind_of Bird, same_parrot
    assert_equal several_green_birds.first, same_parrot
  end

  def test_first_or_create_with_invalid_array
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create!([ {:name => 'parrot'}, {:pirate_id => 1} ]) }
  end

1151 1152
  def test_first_or_initialize
    parrot = Bird.where(:color => 'green').first_or_initialize(:name => 'parrot')
1153 1154 1155 1156 1157 1158 1159 1160
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert parrot.valid?
    assert parrot.new_record?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color
  end

1161 1162
  def test_first_or_initialize_with_no_parameters
    parrot = Bird.where(:color => 'green').first_or_initialize
1163 1164 1165 1166 1167 1168 1169
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert !parrot.valid?
    assert parrot.new_record?
    assert_equal 'green', parrot.color
  end

1170 1171
  def test_first_or_initialize_with_block
    parrot = Bird.where(:color => 'green').first_or_initialize { |bird| bird.name = 'parrot' }
1172 1173 1174 1175 1176 1177 1178 1179
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert parrot.valid?
    assert parrot.new_record?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name
  end

1180 1181 1182 1183 1184 1185 1186 1187 1188
  def test_find_or_create_by
    assert_nil Bird.find_by(name: 'bob')

    bird = Bird.find_or_create_by(name: 'bob')
    assert bird.persisted?

    assert_equal bird, Bird.find_or_create_by(name: 'bob')
  end

1189 1190 1191 1192 1193 1194 1195 1196 1197 1198
  def test_find_or_create_by_with_create_with
    assert_nil Bird.find_by(name: 'bob')

    bird = Bird.create_with(color: 'green').find_or_create_by(name: 'bob')
    assert bird.persisted?
    assert_equal 'green', bird.color

    assert_equal bird, Bird.create_with(color: 'blue').find_or_create_by(name: 'bob')
  end

1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212
  def test_find_or_create_by!
    assert_raises(ActiveRecord::RecordInvalid) { Bird.find_or_create_by!(color: 'green') }
  end

  def test_find_or_initialize_by
    assert_nil Bird.find_by(name: 'bob')

    bird = Bird.find_or_initialize_by(name: 'bob')
    assert bird.new_record?
    bird.save!

    assert_equal bird, Bird.find_or_initialize_by(name: 'bob')
  end

1213 1214 1215 1216 1217 1218 1219 1220
  def test_explicit_create_scope
    hens = Bird.where(:name => 'hen')
    assert_equal 'hen', hens.new.name

    hens = hens.create_with(:name => 'cock')
    assert_equal 'cock', hens.new.name
  end

P
Pratik Naik 已提交
1221 1222
  def test_except
    relation = Post.where(:author_id => 1).order('id ASC').limit(1)
1223
    assert_equal [posts(:welcome)], relation.to_a
P
Pratik Naik 已提交
1224 1225

    author_posts = relation.except(:order, :limit)
1226
    assert_equal Post.where(:author_id => 1).to_a, author_posts.to_a
P
Pratik Naik 已提交
1227 1228

    all_posts = relation.except(:where, :order, :limit)
J
Jon Leighton 已提交
1229
    assert_equal Post.all, all_posts
P
Pratik Naik 已提交
1230 1231
  end

E
Emilio Tagua 已提交
1232 1233
  def test_only
    relation = Post.where(:author_id => 1).order('id ASC').limit(1)
1234
    assert_equal [posts(:welcome)], relation.to_a
E
Emilio Tagua 已提交
1235 1236

    author_posts = relation.only(:where)
1237
    assert_equal Post.where(:author_id => 1).to_a, author_posts.to_a
E
Emilio Tagua 已提交
1238 1239

    all_posts = relation.only(:limit)
1240
    assert_equal Post.limit(1).to_a.first, all_posts.first
E
Emilio Tagua 已提交
1241 1242
  end

P
Pratik Naik 已提交
1243
  def test_anonymous_extension
1244
    relation = Post.where(:author_id => 1).order('id ASC').extending do
P
Pratik Naik 已提交
1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258
      def author
        'lifo'
      end
    end

    assert_equal "lifo", relation.author
    assert_equal "lifo", relation.limit(1).author
  end

  def test_named_extension
    relation = Post.where(:author_id => 1).order('id ASC').extending(Post::NamedExtension)
    assert_equal "lifo", relation.author
    assert_equal "lifo", relation.limit(1).author
  end
1259 1260

  def test_order_by_relation_attribute
1261
    assert_equal Post.order(Post.arel_table[:title]).to_a, Post.order("title").to_a
1262
  end
1263

1264
  def test_default_scope_order_with_scope_order
1265 1266
    assert_equal 'zyke', CoolCar.order_using_new_style.limit(1).first.name
    assert_equal 'zyke', FastCar.order_using_new_style.limit(1).first.name
1267 1268 1269
  end

  def test_order_using_scoping
1270
    car1 = CoolCar.order('id DESC').scoping do
1271
      CoolCar.all.merge!(order: 'id asc').first
1272
    end
1273
    assert_equal 'zyke', car1.name
1274 1275

    car2 = FastCar.order('id DESC').scoping do
1276
      FastCar.all.merge!(order: 'id asc').first
1277
    end
1278
    assert_equal 'zyke', car2.name
1279 1280 1281 1282 1283
  end

  def test_unscoped_block_style
    assert_equal 'honda', CoolCar.unscoped { CoolCar.order_using_new_style.limit(1).first.name}
    assert_equal 'honda', FastCar.unscoped { FastCar.order_using_new_style.limit(1).first.name}
1284 1285
  end

1286 1287 1288
  def test_intersection_with_array
    relation = Author.where(:name => "David")
    rails_author = relation.first
1289

1290 1291 1292
    assert_equal [rails_author], [rails_author] & relation
    assert_equal [rails_author], relation & [rails_author]
  end
1293

1294
  def test_primary_key
1295
    assert_equal "id", Post.all.primary_key
1296
  end
1297

1298 1299 1300 1301 1302 1303
  def test_disable_implicit_join_references_is_deprecated
    assert_deprecated do
      ActiveRecord::Base.disable_implicit_join_references = true
    end
  end

1304
  def test_ordering_with_extra_spaces
1305
    assert_equal authors(:david), Author.order('id DESC , name DESC').last
1306
  end
1307

1308 1309 1310 1311
  def test_update_all_with_blank_argument
    assert_raises(ArgumentError) { Comment.update_all({}) }
  end

1312 1313 1314 1315 1316 1317 1318
  def test_update_all_with_joins
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id)
    count    = comments.count

    assert_equal count, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:greetings).post
  end
1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340

  def test_update_all_with_joins_and_limit
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).limit(1)
    assert_equal 1, comments.update_all(:post_id => posts(:thinking).id)
  end

  def test_update_all_with_joins_and_limit_and_order
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).order('comments.id').limit(1)
    assert_equal 1, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:greetings).post
    assert_equal posts(:welcome),  comments(:more_greetings).post
  end

  def test_update_all_with_joins_and_offset
    all_comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id)
    count        = all_comments.count
    comments     = all_comments.offset(1)

    assert_equal count - 1, comments.update_all(:post_id => posts(:thinking).id)
  end

  def test_update_all_with_joins_and_offset_and_order
1341
    all_comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).order('posts.id', 'comments.id')
1342 1343 1344 1345 1346 1347 1348
    count        = all_comments.count
    comments     = all_comments.offset(1)

    assert_equal count - 1, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:more_greetings).post
    assert_equal posts(:welcome),  comments(:greetings).post
  end
1349

1350
  def test_distinct
1351 1352 1353 1354 1355 1356 1357
    tag1 = Tag.create(:name => 'Foo')
    tag2 = Tag.create(:name => 'Foo')

    query = Tag.select(:name).where(:id => [tag1.id, tag2.id])

    assert_equal ['Foo', 'Foo'], query.map(&:name)
    assert_sql(/DISTINCT/) do
1358
      assert_equal ['Foo'], query.distinct.map(&:name)
1359 1360 1361
      assert_equal ['Foo'], query.uniq.map(&:name)
    end
    assert_sql(/DISTINCT/) do
1362
      assert_equal ['Foo'], query.distinct(true).map(&:name)
1363 1364
      assert_equal ['Foo'], query.uniq(true).map(&:name)
    end
1365
    assert_equal ['Foo', 'Foo'], query.distinct(true).distinct(false).map(&:name)
1366 1367
    assert_equal ['Foo', 'Foo'], query.uniq(true).uniq(false).map(&:name)
  end
1368

1369 1370 1371 1372 1373 1374 1375 1376
  def test_doesnt_add_having_values_if_options_are_blank
    scope = Post.having('')
    assert_equal [], scope.having_values

    scope = Post.having([])
    assert_equal [], scope.having_values
  end

1377 1378 1379 1380 1381 1382 1383 1384 1385 1386
  def test_references_triggers_eager_loading
    scope = Post.includes(:comments)
    assert !scope.eager_loading?
    assert scope.references(:comments).eager_loading?
  end

  def test_references_doesnt_trigger_eager_loading_if_reference_not_included
    scope = Post.references(:comments)
    assert !scope.eager_loading?
  end
1387

1388
  def test_automatically_added_where_references
1389
    scope = Post.where(:comments => { :body => "Bla" })
J
Jon Leighton 已提交
1390
    assert_equal ['comments'], scope.references_values
1391 1392

    scope = Post.where('comments.body' => 'Bla')
J
Jon Leighton 已提交
1393
    assert_equal ['comments'], scope.references_values
1394
  end
1395

1396 1397 1398 1399 1400 1401 1402 1403
  def test_automatically_added_where_not_references
    scope = Post.where.not(comments: { body: "Bla" })
    assert_equal ['comments'], scope.references_values

    scope = Post.where.not('comments.body' => 'Bla')
    assert_equal ['comments'], scope.references_values
  end

1404
  def test_automatically_added_having_references
1405
    scope = Post.having(:comments => { :body => "Bla" })
J
Jon Leighton 已提交
1406
    assert_equal ['comments'], scope.references_values
1407 1408

    scope = Post.having('comments.body' => 'Bla')
J
Jon Leighton 已提交
1409
    assert_equal ['comments'], scope.references_values
1410
  end
1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428

  def test_automatically_added_order_references
    scope = Post.order('comments.body')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('comments.body', 'yaks.body')
    assert_equal ['comments', 'yaks'], scope.references_values

    # Don't infer yaks, let's not go down that road again...
    scope = Post.order('comments.body, yaks.body')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('comments.body asc')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('foo(comments.body)')
    assert_equal [], scope.references_values
  end
1429

1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447
  def test_automatically_added_reorder_references
    scope = Post.reorder('comments.body')
    assert_equal %w(comments), scope.references_values

    scope = Post.reorder('comments.body', 'yaks.body')
    assert_equal %w(comments yaks), scope.references_values

    # Don't infer yaks, let's not go down that road again...
    scope = Post.reorder('comments.body, yaks.body')
    assert_equal %w(comments), scope.references_values

    scope = Post.reorder('comments.body asc')
    assert_equal %w(comments), scope.references_values

    scope = Post.reorder('foo(comments.body)')
    assert_equal [], scope.references_values
  end

1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459
  def test_order_with_reorder_nil_removes_the_order
    relation = Post.order(:title).reorder(nil)

    assert_nil relation.order_values.first
  end

  def test_reverse_order_with_reorder_nil_removes_the_order
    relation = Post.order(:title).reverse_order.reorder(nil)

    assert_nil relation.order_values.first
  end

1460
  def test_presence
1461
    topics = Topic.all
1462

1463
    # the first query is triggered because there are no topics yet.
1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477
    assert_queries(1) { assert topics.present? }

    # checking if there are topics is used before you actually display them,
    # thus it shouldn't invoke an extra count query.
    assert_no_queries { assert topics.present? }
    assert_no_queries { assert !topics.blank? }

    # shows count of topics and loops after loading the query should not trigger extra queries either.
    assert_no_queries { topics.size }
    assert_no_queries { topics.length }
    assert_no_queries { topics.each }

    # count always trigger the COUNT query.
    assert_queries(1) { topics.count }
1478 1479 1480

    assert topics.loaded?
  end
1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494

  test "find_by with hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by(author_id: 2)
  end

  test "find_by with non-hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by("author_id = 2")
  end

  test "find_by with multi-arg conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by('author_id = ?', 2)
  end

  test "find_by returns nil if the record is missing" do
1495
    assert_equal nil, Post.all.find_by("1 = 0")
1496 1497
  end

1498 1499 1500 1501
  test "find_by doesn't have implicit ordering" do
    assert_sql(/^((?!ORDER).)*$/) { Post.find_by(author_id: 2) }
  end

1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513
  test "find_by! with hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by!(author_id: 2)
  end

  test "find_by! with non-hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by!("author_id = 2")
  end

  test "find_by! with multi-arg conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by!('author_id = ?', 2)
  end

1514 1515 1516 1517
  test "find_by! doesn't have implicit ordering" do
    assert_sql(/^((?!ORDER).)*$/) { Post.find_by!(author_id: 2) }
  end

1518 1519
  test "find_by! raises RecordNotFound if the record is missing" do
    assert_raises(ActiveRecord::RecordNotFound) do
1520
      Post.all.find_by!("1 = 0")
1521 1522
    end
  end
1523 1524

  test "loaded relations cannot be mutated by multi value methods" do
1525
    relation = Post.all
1526 1527 1528 1529 1530 1531 1532 1533
    relation.to_a

    assert_raises(ActiveRecord::ImmutableRelation) do
      relation.where! 'foo'
    end
  end

  test "loaded relations cannot be mutated by single value methods" do
1534
    relation = Post.all
1535 1536 1537 1538 1539 1540 1541 1542
    relation.to_a

    assert_raises(ActiveRecord::ImmutableRelation) do
      relation.limit! 5
    end
  end

  test "loaded relations cannot be mutated by merge!" do
1543
    relation = Post.all
1544 1545 1546 1547 1548 1549
    relation.to_a

    assert_raises(ActiveRecord::ImmutableRelation) do
      relation.merge! where: 'foo'
    end
  end
1550

1551 1552 1553 1554 1555 1556 1557 1558 1559
  test "loaded relations cannot be mutated by extending!" do
    relation = Post.all
    relation.to_a

    assert_raises(ActiveRecord::ImmutableRelation) do
      relation.extending! Module.new
    end
  end

1560 1561 1562 1563
  test "relations show the records in #inspect" do
    relation = Post.limit(2)
    assert_equal "#<ActiveRecord::Relation [#{Post.limit(2).map(&:inspect).join(', ')}]>", relation.inspect
  end
1564

1565
  test "relations limit the records in #inspect at 10" do
1566 1567 1568
    relation = Post.limit(11)
    assert_equal "#<ActiveRecord::Relation [#{Post.limit(10).map(&:inspect).join(', ')}, ...]>", relation.inspect
  end
1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579

  test "already-loaded relations don't perform a new query in #inspect" do
    relation = Post.limit(2)
    relation.to_a

    expected = "#<ActiveRecord::Relation [#{Post.limit(2).map(&:inspect).join(', ')}]>"

    assert_no_queries do
      assert_equal expected, relation.inspect
    end
  end
1580 1581 1582 1583 1584 1585 1586 1587 1588 1589

  test 'using a custom table affects the wheres' do
    table_alias = Post.arel_table.alias('omg_posts')

    relation = ActiveRecord::Relation.new Post, table_alias
    relation.where!(:foo => "bar")

    node = relation.arel.constraints.first.grep(Arel::Attributes::Attribute).first
    assert_equal table_alias, node.relation
  end
J
Jon Leighton 已提交
1590 1591 1592 1593 1594 1595 1596 1597

  test '#load' do
    relation = Post.all
    assert_queries(1) do
      assert_equal relation, relation.load
    end
    assert_no_queries { relation.to_a }
  end
1598 1599

  test 'group with select and includes' do
1600 1601
    authors_count = Post.select('author_id, COUNT(author_id) AS num_posts').
      group('author_id').order('author_id').includes(:author).to_a
1602 1603 1604 1605 1606 1607 1608 1609 1610 1611

    assert_no_queries do
      result = authors_count.map do |post|
        [post.num_posts, post.author.try(:name)]
      end

      expected = [[1, nil], [5, "David"], [3, "Mary"], [2, "Bob"]]
      assert_equal expected, result
    end
  end
1612

1613 1614 1615 1616 1617 1618
  test "joins with select" do
    posts = Post.joins(:author).select("id", "authors.author_address_id").order("posts.id").limit(3)
    assert_equal [1, 2, 4], posts.map(&:id)
    assert_equal [1, 1, 1], posts.map(&:author_address_id)
  end

1619 1620 1621 1622 1623 1624
  test "delegations do not leak to other classes" do
    Topic.all.by_lifo
    assert Topic.all.class.method_defined?(:by_lifo)
    assert !Post.all.respond_to?(:by_lifo)
  end

1625 1626 1627 1628 1629 1630 1631 1632 1633
  def test_unscope_removes_binds
    left  = Post.where(id: Arel::Nodes::BindParam.new('?'))
    column = Post.columns_hash['id']
    left.bind_values += [[column, 20]]

    relation = left.unscope(where: :id)
    assert_equal [], relation.bind_values
  end

L
laurocaetano 已提交
1634 1635 1636 1637 1638
  def test_merging_removes_rhs_bind_parameters
    left  = Post.where(id: Arel::Nodes::BindParam.new('?'))
    column = Post.columns_hash['id']
    left.bind_values += [[column, 20]]
    right   = Post.where(id: 10)
1639

L
laurocaetano 已提交
1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670
    merged = left.merge(right)
    assert_equal [], merged.bind_values
  end

  def test_merging_keeps_lhs_bind_parameters
    column = Post.columns_hash['id']
    binds = [[column, 20]]

    right  = Post.where(id: Arel::Nodes::BindParam.new('?'))
    right.bind_values += binds
    left   = Post.where(id: 10)

    merged = left.merge(right)
    assert_equal binds, merged.bind_values
  end

  def test_merging_reorders_bind_params
    post         = Post.first
    id_column    = Post.columns_hash['id']
    title_column = Post.columns_hash['title']

    bv = Post.connection.substitute_at id_column, 0

    right  = Post.where(id: bv)
    right.bind_values += [[id_column, post.id]]

    left   = Post.where(title: bv)
    left.bind_values += [[title_column, post.title]]

    merged = left.merge(right)
    assert_equal post, merged.first
1671
  end
P
Pratik Naik 已提交
1672
end