relations_test.rb 37.9 KB
Newer Older
1
require "cases/helper"
2
require 'models/tag'
3
require 'models/tagging'
4 5
require 'models/post'
require 'models/topic'
6
require 'models/comment'
7
require 'models/author'
8
require 'models/comment'
9 10
require 'models/entrant'
require 'models/developer'
11
require 'models/reply'
12
require 'models/company'
13
require 'models/bird'
14 15 16
require 'models/car'
require 'models/engine'
require 'models/tyre'
17
require 'models/minivan'
18

19

E
Emilio Tagua 已提交
20
class RelationTest < ActiveRecord::TestCase
21
  fixtures :authors, :topics, :entrants, :developers, :companies, :developers_projects, :accounts, :categories, :categorizations, :posts, :comments,
22 23 24 25 26 27 28
    :tags, :taggings, :cars, :minivans

  def test_do_not_double_quote_string_id
    van = Minivan.last
    assert van
    assert_equal van.id, Minivan.where(:minivan_id => van).to_a.first.minivan_id
  end
29

30 31 32 33 34 35
  def test_do_not_double_quote_string_id_with_array
    van = Minivan.last
    assert van
    assert_equal van, Minivan.where(:minivan_id => [van]).to_a.first
  end

A
Aaron Patterson 已提交
36 37 38 39 40 41 42 43 44
  def test_bind_values
    relation = Post.scoped
    assert_equal [], relation.bind_values

    relation2 = relation.bind 'foo'
    assert_equal %w{ foo }, relation2.bind_values
    assert_equal [], relation.bind_values
  end

45
  def test_two_scopes_with_includes_should_not_drop_any_include
46
    car = Car.incl_engines.incl_tyres.first
47 48
    assert_no_queries { car.tyres.length }
    assert_no_queries { car.engines.length }
49
  end
50

51 52 53 54 55
  def test_dynamic_finder
    x = Post.where('author_id = ?', 1)
    assert x.klass.respond_to?(:find_by_id), '@klass should handle dynamic finders'
  end

56 57 58 59 60
  def test_multivalue_where
    posts = Post.where('author_id = ? AND id = ?', 1, 1)
    assert_equal 1, posts.to_a.size
  end

61 62 63 64 65 66
  def test_scoped
    topics = Topic.scoped
    assert_kind_of ActiveRecord::Relation, topics
    assert_equal 4, topics.size
  end

67 68 69 70 71 72 73 74 75 76
  def test_to_json
    assert_nothing_raised  { Bird.scoped.to_json }
    assert_nothing_raised  { Bird.scoped.all.to_json }
  end

  def test_to_yaml
    assert_nothing_raised  { Bird.scoped.to_yaml }
    assert_nothing_raised  { Bird.scoped.all.to_yaml }
  end

77 78 79 80 81
  def test_to_xml
    assert_nothing_raised  { Bird.scoped.to_xml }
    assert_nothing_raised  { Bird.scoped.all.to_xml }
  end

82 83 84 85 86 87
  def test_scoped_all
    topics = Topic.scoped.all
    assert_kind_of Array, topics
    assert_no_queries { assert_equal 4, topics.size }
  end

P
Pratik Naik 已提交
88 89 90 91 92 93 94 95 96 97 98
  def test_loaded_all
    topics = Topic.scoped

    assert_queries(1) do
      2.times { assert_equal 4, topics.all.size }
    end

    assert topics.loaded?
  end

  def test_scoped_first
P
Pratik Naik 已提交
99
    topics = Topic.scoped.order('id ASC')
P
Pratik Naik 已提交
100 101 102 103 104 105 106 107 108

    assert_queries(1) do
      2.times { assert_equal "The First Topic", topics.first.title }
    end

    assert ! topics.loaded?
  end

  def test_loaded_first
P
Pratik Naik 已提交
109
    topics = Topic.scoped.order('id ASC')
P
Pratik Naik 已提交
110 111 112 113 114 115 116 117 118

    assert_queries(1) do
      topics.all # force load
      2.times { assert_equal "The First Topic", topics.first.title }
    end

    assert topics.loaded?
  end

119 120 121 122 123 124 125 126 127
  def test_reload
    topics = Topic.scoped

    assert_queries(1) do
      2.times { topics.to_a }
    end

    assert topics.loaded?

128 129
    original_size = topics.to_a.size
    Topic.create! :title => 'fake'
130

131 132 133
    assert_queries(1) { topics.reload }
    assert_equal original_size + 1, topics.size
    assert topics.loaded?
134 135
  end

136
  def test_finding_with_conditions
137 138
    assert_equal ["David"], Author.where(:name => 'David').map(&:name)
    assert_equal ['Mary'],  Author.where(["name = ?", 'Mary']).map(&:name)
139
    assert_equal ['Mary'],  Author.where("name = ?", 'Mary').map(&:name)
140 141 142
  end

  def test_finding_with_order
143
    topics = Topic.order('id')
144
    assert_equal 4, topics.to_a.size
145 146 147
    assert_equal topics(:first).title, topics.first.title
  end

148 149 150 151 152 153 154 155 156 157 158 159

  def test_finding_with_arel_order
    topics = Topic.order(Topic.arel_table[:id].asc)
    assert_equal 4, topics.to_a.size
    assert_equal topics(:first).title, topics.first.title
  end

  def test_finding_last_with_arel_order
    topics = Topic.order(Topic.arel_table[:id].asc)
    assert_equal topics(:fourth).title, topics.last.title
  end

160 161 162 163 164 165
  def test_finding_with_order_concatenated
    topics = Topic.order('author_name').order('title')
    assert_equal 4, topics.to_a.size
    assert_equal topics(:fourth).title, topics.first.title
  end

S
Sebastian Martinez 已提交
166 167 168 169 170
  def test_finding_with_reorder
    topics = Topic.order('author_name').order('title').reorder('id').all
    topics_titles = topics.map{ |t| t.title }
    assert_equal ['The First Topic', 'The Second Topic of the day', 'The Third Topic of the day', 'The Fourth Topic of the day'], topics_titles
  end
171

172
  def test_finding_with_order_and_take
173
    entrants = Entrant.order("id ASC").limit(2).to_a
174

P
Pratik Naik 已提交
175 176
    assert_equal 2, entrants.size
    assert_equal entrants(:first).name, entrants.first.name
177 178
  end

179
  def test_finding_with_cross_table_order_and_limit
180
    tags = Tag.includes(:taggings).
181 182
              order("tags.name asc", "taggings.taggable_id asc", "REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").
              limit(1).to_a
183 184 185
    assert_equal 1, tags.length
  end

186
  def test_finding_with_complex_order_and_limit
187
    tags = Tag.includes(:taggings).references(:taggings).order("REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").limit(1).to_a
188 189 190 191
    assert_equal 1, tags.length
  end

  def test_finding_with_complex_order
192
    tags = Tag.includes(:taggings).references(:taggings).order("REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").to_a
193
    assert_equal 3, tags.length
194 195
  end

196
  def test_finding_with_order_limit_and_offset
197
    entrants = Entrant.order("id ASC").limit(2).offset(1)
198

199
    assert_equal 2, entrants.to_a.size
P
Pratik Naik 已提交
200
    assert_equal entrants(:second).name, entrants.first.name
201

202
    entrants = Entrant.order("id ASC").limit(2).offset(2)
203
    assert_equal 1, entrants.to_a.size
P
Pratik Naik 已提交
204
    assert_equal entrants(:third).name, entrants.first.name
205 206 207
  end

  def test_finding_with_group
208
    developers = Developer.group("salary").select("salary").to_a
209 210 211 212
    assert_equal 4, developers.size
    assert_equal 4, developers.map(&:salary).uniq.size
  end

213 214
  def test_select_with_block
    even_ids = Developer.scoped.select {|d| d.id % 2 == 0 }.map(&:id)
215
    assert_equal [2, 4, 6, 8, 10], even_ids.sort
216 217
  end

218 219 220 221 222 223 224 225 226 227 228 229 230
  def test_none
    assert_no_queries do
      assert_equal [], Developer.none
      assert_equal [], Developer.scoped.none
    end
  end

  def test_none_chainable
    assert_no_queries do
      assert_equal [], Developer.none.where(:name => 'David')
    end
  end

231 232 233 234
  def test_joins_with_nil_argument
    assert_nothing_raised { DependentFirm.joins(nil).first }
  end

235
  def test_finding_with_hash_conditions_on_joined_table
236
    firms = DependentFirm.joins(:account).where({:name => 'RailsCore', :accounts => { :credit_limit => 55..60 }}).to_a
237 238 239 240 241
    assert_equal 1, firms.size
    assert_equal companies(:rails_core), firms.first
  end

  def test_find_all_with_join
242
    developers_on_project_one = Developer.joins('LEFT JOIN developers_projects ON developers.id = developers_projects.developer_id').
243
      where('project_id=1').to_a
244 245 246 247 248 249 250 251

    assert_equal 3, developers_on_project_one.length
    developer_names = developers_on_project_one.map { |d| d.name }
    assert developer_names.include?('David')
    assert developer_names.include?('Jamis')
  end

  def test_find_on_hash_conditions
252
    assert_equal Topic.find(:all, :conditions => {:approved => false}), Topic.where({ :approved => false }).to_a
253 254 255
  end

  def test_joins_with_string_array
256
    person_with_reader_and_post = Post.joins([
257 258 259 260 261 262
        "INNER JOIN categorizations ON categorizations.post_id = posts.id",
        "INNER JOIN categories ON categories.id = categorizations.category_id AND categories.type = 'SpecialCategory'"
      ]
    ).to_a
    assert_equal 1, person_with_reader_and_post.size
  end
263

264 265
  def test_scoped_responds_to_delegated_methods
    relation = Topic.scoped
266 267

    ["map", "uniq", "sort", "insert", "delete", "update"].each do |method|
268
      assert_respond_to relation, method, "Topic.scoped should respond to #{method.inspect}"
269 270 271
    end
  end

272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290
  def test_respond_to_delegates_to_relation
    relation = Topic.scoped
    fake_arel = Struct.new(:responds) {
      def respond_to? method, access = false
        responds << [method, access]
      end
    }.new []

    relation.extend(Module.new { attr_accessor :arel })
    relation.arel = fake_arel

    relation.respond_to?(:matching_attributes)
    assert_equal [:matching_attributes, false], fake_arel.responds.first

    fake_arel.responds = []
    relation.respond_to?(:matching_attributes, true)
    assert_equal [:matching_attributes, true], fake_arel.responds.first
  end

291 292 293 294
  def test_respond_to_dynamic_finders
    relation = Topic.scoped

    ["find_by_title", "find_by_title_and_author_name", "find_or_create_by_title", "find_or_initialize_by_title_and_author_name"].each do |method|
295
      assert_respond_to relation, method, "Topic.scoped should respond to #{method.inspect}"
296 297
    end
  end
298

299
  def test_respond_to_class_methods_and_scopes
300 301 302 303
    assert DeveloperOrderedBySalary.scoped.respond_to?(:all_ordered_by_name)
    assert Topic.scoped.respond_to?(:by_lifo)
  end

304
  def test_find_with_readonly_option
305 306
    Developer.scoped.each { |d| assert !d.readonly? }
    Developer.scoped.readonly.each { |d| assert d.readonly? }
307
  end
308 309

  def test_eager_association_loading_of_stis_with_multiple_references
310
    authors = Author.eager_load(:posts => { :special_comments => { :post => [ :special_comments, :very_special_comment ] } }).
311
      order('comments.body, very_special_comments_posts.body').where('posts.id = 4').to_a
312

313 314 315 316 317 318 319
    assert_equal [authors(:david)], authors
    assert_no_queries do
      authors.first.posts.first.special_comments.first.post.special_comments
      authors.first.posts.first.special_comments.first.post.very_special_comment
    end
  end

320
  def test_find_with_preloaded_associations
321
    assert_queries(2) do
322
      posts = Post.preload(:comments).order('posts.id')
323
      assert posts.first.comments.first
324
    end
325

C
Carlos Antonio da Silva 已提交
326
    assert_queries(2) do
327
      posts = Post.preload(:comments).order('posts.id')
328
      assert posts.first.comments.first
329
    end
330

331
    assert_queries(2) do
332
      posts = Post.preload(:author).order('posts.id')
333
      assert posts.first.author
334
    end
335

C
Carlos Antonio da Silva 已提交
336
    assert_queries(2) do
337
      posts = Post.preload(:author).order('posts.id')
338 339 340
      assert posts.first.author
    end

C
Carlos Antonio da Silva 已提交
341
    assert_queries(3) do
342
      posts = Post.preload(:author, :comments).order('posts.id')
343
      assert posts.first.author
344 345 346 347 348 349
      assert posts.first.comments.first
    end
  end

  def test_find_with_included_associations
    assert_queries(2) do
350
      posts = Post.includes(:comments).order('posts.id')
351 352 353
      assert posts.first.comments.first
    end

C
Carlos Antonio da Silva 已提交
354
    assert_queries(2) do
355
      posts = Post.scoped.includes(:comments).order('posts.id')
356 357 358 359
      assert posts.first.comments.first
    end

    assert_queries(2) do
360
      posts = Post.includes(:author).order('posts.id')
361 362 363
      assert posts.first.author
    end

C
Carlos Antonio da Silva 已提交
364
    assert_queries(3) do
365
      posts = Post.includes(:author, :comments).order('posts.id')
366
      assert posts.first.author
367
      assert posts.first.comments.first
368 369
    end
  end
370

P
Pratik Naik 已提交
371
  def test_default_scope_with_conditions_string
372
    assert_equal Developer.find_all_by_name('David').map(&:id).sort, DeveloperCalledDavid.scoped.map(&:id).sort
373
    assert_nil DeveloperCalledDavid.create!.name
374 375 376
  end

  def test_default_scope_with_conditions_hash
377
    assert_equal Developer.find_all_by_name('Jamis').map(&:id).sort, DeveloperCalledJamis.scoped.map(&:id).sort
378 379 380
    assert_equal 'Jamis', DeveloperCalledJamis.create!.name
  end

381 382 383 384 385
  def test_default_scoping_finder_methods
    developers = DeveloperCalledDavid.order('id').map(&:id).sort
    assert_equal Developer.find_all_by_name('David').map(&:id).sort, developers
  end

386 387
  def test_loading_with_one_association
    posts = Post.preload(:comments)
388 389 390 391
    post = posts.find { |p| p.id == 1 }
    assert_equal 2, post.comments.size
    assert post.comments.include?(comments(:greetings))

392
    post = Post.where("posts.title = 'Welcome to the weblog'").preload(:comments).first
393 394 395
    assert_equal 2, post.comments.size
    assert post.comments.include?(comments(:greetings))

396
    posts = Post.preload(:last_comment)
397 398 399 400 401
    post = posts.find { |p| p.id == 1 }
    assert_equal Post.find(1).last_comment, post.last_comment
  end

  def test_loading_with_one_association_with_non_preload
402
    posts = Post.eager_load(:last_comment).order('comments.id DESC')
403 404 405
    post = posts.find { |p| p.id == 1 }
    assert_equal Post.find(1).last_comment, post.last_comment
  end
406

407 408 409 410 411 412 413 414 415
  def test_dynamic_find_by_attributes_should_yield_found_object
    david = authors(:david)
    yielded_value = nil
    Author.find_by_name(david.name) do |author|
      yielded_value = author
    end
    assert_equal david, yielded_value
  end

416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433
  def test_dynamic_find_by_attributes
    david = authors(:david)
    author = Author.preload(:taggings).find_by_id(david.id)
    expected_taggings = taggings(:welcome_general, :thinking_general)

    assert_no_queries do
      assert_equal expected_taggings, author.taggings.uniq.sort_by { |t| t.id }
    end

    authors = Author.scoped
    assert_equal david, authors.find_by_id_and_name(david.id, david.name)
    assert_equal david, authors.find_by_id_and_name!(david.id, david.name)
  end

  def test_dynamic_find_by_attributes_bang
    author = Author.scoped.find_by_id!(authors(:david).id)
    assert_equal "David", author.name

P
Pratik Naik 已提交
434
    assert_raises(ActiveRecord::RecordNotFound) { Author.scoped.find_by_id_and_name!(20, 'invalid') }
435 436 437 438 439 440 441 442 443
  end

  def test_dynamic_find_all_by_attributes
    authors = Author.scoped

    davids = authors.find_all_by_name('David')
    assert_kind_of Array, davids
    assert_equal [authors(:david)], davids
  end
444 445 446 447 448 449

  def test_dynamic_find_or_initialize_by_attributes
    authors = Author.scoped

    lifo = authors.find_or_initialize_by_name('Lifo')
    assert_equal "Lifo", lifo.name
450
    assert !lifo.persisted?
451 452 453 454 455 456 457 458 459

    assert_equal authors(:david), authors.find_or_initialize_by_name(:name => 'David')
  end

  def test_dynamic_find_or_create_by_attributes
    authors = Author.scoped

    lifo = authors.find_or_create_by_name('Lifo')
    assert_equal "Lifo", lifo.name
460
    assert lifo.persisted?
461 462 463 464

    assert_equal authors(:david), authors.find_or_create_by_name(:name => 'David')
  end

465 466 467 468 469 470 471 472 473 474 475 476
  def test_dynamic_find_or_create_by_attributes_bang
    authors = Author.scoped

    assert_raises(ActiveRecord::RecordInvalid) { authors.find_or_create_by_name!('') }

    lifo = authors.find_or_create_by_name!('Lifo')
    assert_equal "Lifo", lifo.name
    assert lifo.persisted?

    assert_equal authors(:david), authors.find_or_create_by_name!(:name => 'David')
  end

P
Pratik Naik 已提交
477 478 479 480 481 482
  def test_find_id
    authors = Author.scoped

    david = authors.find(authors(:david).id)
    assert_equal 'David', david.name

P
Pratik Naik 已提交
483
    assert_raises(ActiveRecord::RecordNotFound) { authors.where(:name => 'lifo').find('42') }
P
Pratik Naik 已提交
484
  end
485

P
Pratik Naik 已提交
486 487 488 489 490 491 492 493 494 495
  def test_find_ids
    authors = Author.order('id ASC')

    results = authors.find(authors(:david).id, authors(:mary).id)
    assert_kind_of Array, results
    assert_equal 2, results.size
    assert_equal 'David', results[0].name
    assert_equal 'Mary', results[1].name
    assert_equal results, authors.find([authors(:david).id, authors(:mary).id])

P
Pratik Naik 已提交
496 497
    assert_raises(ActiveRecord::RecordNotFound) { authors.where(:name => 'lifo').find(authors(:david).id, '42') }
    assert_raises(ActiveRecord::RecordNotFound) { authors.find(['42', 43]) }
P
Pratik Naik 已提交
498 499
  end

500 501
  def test_find_in_empty_array
    authors = Author.scoped.where(:id => [])
502
    assert_blank authors.all
503 504
  end

505 506 507 508 509 510
  def test_where_with_ar_object
    author = Author.first
    authors = Author.scoped.where(:id => author)
    assert_equal 1, authors.all.length
  end

511 512 513 514 515 516
  def test_find_with_list_of_ar
    author = Author.first
    authors = Author.find([author])
    assert_equal author, authors.first
  end

517 518 519 520 521 522 523
  class Mary < Author; end

  def test_find_by_classname
    Author.create!(:name => Mary.name)
    assert_equal 1, Author.where(:name => Mary).size
  end

524 525 526 527 528 529
  def test_find_by_id_with_list_of_ar
    author = Author.first
    authors = Author.find_by_id([author])
    assert_equal author, authors
  end

530 531 532 533 534 535
  def test_find_all_using_where_twice_should_or_the_relation
    david = authors(:david)
    relation = Author.unscoped
    relation = relation.where(:name => david.name)
    relation = relation.where(:name => 'Santiago')
    relation = relation.where(:id => david.id)
A
Aaron Patterson 已提交
536
    assert_equal [], relation.all
537 538
  end

A
Aaron Patterson 已提交
539 540 541 542 543 544 545 546
  def test_multi_where_ands_queries
    relation = Author.unscoped
    david = authors(:david)
    sql = relation.where(:name => david.name).where(:name => 'Santiago').to_sql
    assert_match('AND', sql)
  end

  def test_find_all_with_multiple_should_use_and
A
Aaron Patterson 已提交
547 548 549 550 551 552 553 554
    david = authors(:david)
    relation = [
      { :name => david.name },
      { :name => 'Santiago' },
      { :name => 'tenderlove' },
    ].inject(Author.unscoped) do |memo, param|
      memo.where(param)
    end
A
Aaron Patterson 已提交
555
    assert_equal [], relation.all
A
Aaron Patterson 已提交
556
  end
A
Aaron Patterson 已提交
557

558 559 560 561 562 563 564 565 566 567
  def test_find_all_using_where_with_relation
    david = authors(:david)
    # switching the lines below would succeed in current rails
    # assert_queries(2) {
    assert_queries(1) {
      relation = Author.where(:id => Author.where(:id => david.id))
      assert_equal [david], relation.all
    }
  end

568 569 570 571 572 573 574 575 576 577
  def test_find_all_using_where_with_relation_and_alternate_primary_key
    cool_first = minivans(:cool_first)
    # switching the lines below would succeed in current rails
    # assert_queries(2) {
    assert_queries(1) {
      relation = Minivan.where(:minivan_id => Minivan.where(:name => cool_first.name))
      assert_equal [cool_first], relation.all
    }
  end

578 579 580 581 582 583 584 585 586 587 588 589 590
  def test_find_all_using_where_with_relation_does_not_alter_select_values
    david = authors(:david)

    subquery = Author.where(:id => david.id)

    assert_queries(1) {
      relation = Author.where(:id => subquery)
      assert_equal [david], relation.all
    }

    assert_equal 0, subquery.select_values.size
  end

591 592 593 594 595 596 597 598
  def test_find_all_using_where_with_relation_with_joins
    david = authors(:david)
    assert_queries(1) {
      relation = Author.where(:id => Author.joins(:posts).where(:id => david.id))
      assert_equal [david], relation.all
    }
  end

A
Aaron Patterson 已提交
599

600 601 602 603 604 605
  def test_find_all_using_where_with_relation_with_select_to_build_subquery
    david = authors(:david)
    assert_queries(1) {
      relation = Author.where(:name => Author.where(:id => david.id).select(:name))
      assert_equal [david], relation.all
    }
A
Aaron Patterson 已提交
606 607
  end

P
Pratik Naik 已提交
608 609 610 611 612
  def test_exists
    davids = Author.where(:name => 'David')
    assert davids.exists?
    assert davids.exists?(authors(:david).id)
    assert ! davids.exists?(authors(:mary).id)
P
Pratik Naik 已提交
613 614
    assert ! davids.exists?("42")
    assert ! davids.exists?(42)
P
Pratik Naik 已提交
615 616 617 618 619

    fake  = Author.where(:name => 'fake author')
    assert ! fake.exists?
    assert ! fake.exists?(authors(:david).id)
  end
620 621 622

  def test_last
    authors = Author.scoped
623
    assert_equal authors(:bob), authors.last
624 625
  end

P
Pratik Naik 已提交
626 627 628 629 630 631 632 633 634 635 636 637 638
  def test_destroy_all
    davids = Author.where(:name => 'David')

    # Force load
    assert_equal [authors(:david)], davids.to_a
    assert davids.loaded?

    assert_difference('Author.count', -1) { davids.destroy_all }

    assert_equal [], davids.to_a
    assert davids.loaded?
  end

P
Pratik Naik 已提交
639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658
  def test_delete_all
    davids = Author.where(:name => 'David')

    assert_difference('Author.count', -1) { davids.delete_all }
    assert ! davids.loaded?
  end

  def test_delete_all_loaded
    davids = Author.where(:name => 'David')

    # Force load
    assert_equal [authors(:david)], davids.to_a
    assert davids.loaded?

    assert_difference('Author.count', -1) { davids.delete_all }

    assert_equal [], davids.to_a
    assert davids.loaded?
  end

659 660 661 662
  def test_select_argument_error
    assert_raises(ArgumentError) { Developer.select }
  end

663
  def test_relation_merging
664
    devs = Developer.where("salary >= 80000").merge(Developer.limit(2)).merge(Developer.order('id ASC').where("id < 3"))
665 666
    assert_equal [developers(:david), developers(:jamis)], devs.to_a

667
    dev_with_count = Developer.limit(1).merge(Developer.order('id DESC')).merge(Developer.select('developers.*'))
668
    assert_equal [developers(:poor_jamis)], dev_with_count.to_a
669 670 671 672
  end

  def test_relation_merging_with_eager_load
    relations = []
673 674
    relations << Post.order('comments.id DESC').merge(Post.eager_load(:last_comment)).merge(Post.scoped)
    relations << Post.eager_load(:last_comment).merge(Post.order('comments.id DESC')).merge(Post.scoped)
675

676 677 678 679 680 681
    relations.each do |posts|
      post = posts.find { |p| p.id == 1 }
      assert_equal Post.find(1).last_comment, post.last_comment
    end
  end

682
  def test_relation_merging_with_locks
683
    devs = Developer.lock.where("salary >= 80000").order("id DESC").merge(Developer.limit(2))
684
    assert_present devs.locked
685 686
  end

687
  def test_relation_merging_with_preload
C
Carlos Antonio da Silva 已提交
688 689
    [Post.scoped.merge(Post.preload(:author)), Post.preload(:author).merge(Post.scoped)].each do |posts|
      assert_queries(2) { assert posts.first.author }
M
Marcin Raczkowski 已提交
690
    end
691
  end
692

693
  def test_relation_merging_with_joins
694
    comments = Comment.joins(:post).where(:body => 'Thank you for the welcome').merge(Post.where(:body => 'Such a lovely day'))
695 696 697
    assert_equal 1, comments.count
  end

P
Pratik Naik 已提交
698 699 700
  def test_count
    posts = Post.scoped

701 702 703
    assert_equal 11, posts.count
    assert_equal 11, posts.count(:all)
    assert_equal 11, posts.count(:id)
P
Pratik Naik 已提交
704 705

    assert_equal 1, posts.where('comments_count > 1').count
706
    assert_equal 9, posts.where(:comments_count => 0).count
P
Pratik Naik 已提交
707 708 709 710 711 712
  end

  def test_count_with_distinct
    posts = Post.scoped

    assert_equal 3, posts.count(:comments_count, :distinct => true)
713
    assert_equal 11, posts.count(:comments_count, :distinct => false)
P
Pratik Naik 已提交
714 715

    assert_equal 3, posts.select(:comments_count).count(:distinct => true)
716
    assert_equal 11, posts.select(:comments_count).count(:distinct => false)
P
Pratik Naik 已提交
717 718 719 720 721 722
  end

  def test_count_explicit_columns
    Post.update_all(:comments_count => nil)
    posts = Post.scoped

P
Pratik Naik 已提交
723
    assert_equal [0], posts.select('comments_count').where('id is not null').group('id').order('id').count.values.uniq
724
    assert_equal 0, posts.where('id is not null').select('comments_count').count
725

726
    assert_equal 11, posts.select('comments_count').count('id')
P
Pratik Naik 已提交
727 728 729 730
    assert_equal 0, posts.select('comments_count').count
    assert_equal 0, posts.count(:comments_count)
    assert_equal 0, posts.count('comments_count')
  end
731

732 733 734 735 736 737
  def test_multiple_selects
    post = Post.scoped.select('comments_count').select('title').order("id ASC").first
    assert_equal "Welcome to the weblog", post.title
    assert_equal 2, post.comments_count
  end

738 739 740
  def test_size
    posts = Post.scoped

741
    assert_queries(1) { assert_equal 11, posts.size }
742 743 744 745
    assert ! posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
746
    assert_no_queries { assert_equal 9, best_posts.size }
747 748
  end

749
  def test_size_with_limit
750
    posts = Post.limit(10)
751

752
    assert_queries(1) { assert_equal 10, posts.size }
753 754 755 756
    assert ! posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
757
    assert_no_queries { assert_equal 9, best_posts.size }
758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776
  end

  def test_size_with_zero_limit
    posts = Post.limit(0)

    assert_no_queries { assert_equal 0, posts.size }
    assert ! posts.loaded?

    posts.to_a # force load
    assert_no_queries { assert_equal 0, posts.size }
  end

  def test_empty_with_zero_limit
    posts = Post.limit(0)

    assert_no_queries { assert_equal true, posts.empty? }
    assert ! posts.loaded?
  end

777 778 779 780 781 782 783
  def test_count_complex_chained_relations
    posts = Post.select('comments_count').where('id is not null').group("author_id").where("comments_count > 0")

    expected = { 1 => 2 }
    assert_equal expected, posts.count
  end

784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800
  def test_empty
    posts = Post.scoped

    assert_queries(1) { assert_equal false, posts.empty? }
    assert ! posts.loaded?

    no_posts = posts.where(:title => "")
    assert_queries(1) { assert_equal true, no_posts.empty? }
    assert ! no_posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
    assert_no_queries { assert_equal false, best_posts.empty? }
  end

  def test_empty_complex_chained_relations
    posts = Post.select("comments_count").where("id is not null").group("author_id").where("comments_count > 0")
A
Andrew White 已提交
801

802 803 804 805 806 807 808 809
    assert_queries(1) { assert_equal false, posts.empty? }
    assert ! posts.loaded?

    no_posts = posts.where(:title => "")
    assert_queries(1) { assert_equal true, no_posts.empty? }
    assert ! no_posts.loaded?
  end

P
Pratik Naik 已提交
810 811 812
  def test_any
    posts = Post.scoped

813 814 815 816 817 818 819 820
    # This test was failing when run on its own (as opposed to running the entire suite).
    # The second line in the assert_queries block was causing visit_Arel_Attributes_Attribute
    # in Arel::Visitors::ToSql to trigger a SHOW TABLES query. Running that line here causes
    # the SHOW TABLES result to be cached so we don't have to do it again in the block.
    #
    # This is obviously a rubbish fix but it's the best I can come up with for now...
    posts.where(:id => nil).any?

P
Pratik Naik 已提交
821 822 823 824 825 826 827 828 829 830 831 832 833
    assert_queries(3) do
      assert posts.any? # Uses COUNT()
      assert ! posts.where(:id => nil).any?

      assert posts.any? {|p| p.id > 0 }
      assert ! posts.any? {|p| p.id <= 0 }
    end

    assert posts.loaded?
  end

  def test_many
    posts = Post.scoped
834

P
Pratik Naik 已提交
835 836 837 838 839
    assert_queries(2) do
      assert posts.many? # Uses COUNT()
      assert posts.many? {|p| p.id > 0 }
      assert ! posts.many? {|p| p.id < 2 }
    end
840

P
Pratik Naik 已提交
841 842 843
    assert posts.loaded?
  end

844 845 846 847 848 849
  def test_many_with_limits
    posts = Post.scoped

    assert posts.many?
    assert ! posts.limit(1).many?
  end
P
Pratik Naik 已提交
850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865

  def test_build
    posts = Post.scoped

    post = posts.new
    assert_kind_of Post, post
  end

  def test_scoped_build
    posts = Post.where(:title => 'You told a lie')

    post = posts.new
    assert_kind_of Post, post
    assert_equal 'You told a lie', post.title
  end

866 867 868 869 870
  def test_create
    birds = Bird.scoped

    sparrow = birds.create
    assert_kind_of Bird, sparrow
871
    assert !sparrow.persisted?
872 873

    hen = birds.where(:name => 'hen').create
874
    assert hen.persisted?
875 876 877 878 879 880 881 882 883 884
    assert_equal 'hen', hen.name
  end

  def test_create_bang
    birds = Bird.scoped

    assert_raises(ActiveRecord::RecordInvalid) { birds.create! }

    hen = birds.where(:name => 'hen').create!
    assert_kind_of Bird, hen
885
    assert hen.persisted?
886 887
    assert_equal 'hen', hen.name
  end
P
Pratik Naik 已提交
888

889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963
  def test_first_or_create
    parrot = Bird.where(:color => 'green').first_or_create(:name => 'parrot')
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color

    same_parrot = Bird.where(:color => 'green').first_or_create(:name => 'parakeet')
    assert_kind_of Bird, same_parrot
    assert same_parrot.persisted?
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_with_no_parameters
    parrot = Bird.where(:color => 'green').first_or_create
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert_equal 'green', parrot.color
  end

  def test_first_or_create_with_block
    parrot = Bird.where(:color => 'green').first_or_create { |bird| bird.name = 'parrot' }
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name

    same_parrot = Bird.where(:color => 'green').first_or_create { |bird| bird.name = 'parakeet' }
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_with_array
    several_green_birds = Bird.where(:color => 'green').first_or_create([{:name => 'parrot'}, {:name => 'parakeet'}])
    assert_kind_of Array, several_green_birds
    several_green_birds.each { |bird| assert bird.persisted? }

    same_parrot = Bird.where(:color => 'green').first_or_create([{:name => 'hummingbird'}, {:name => 'macaw'}])
    assert_kind_of Bird, same_parrot
    assert_equal several_green_birds.first, same_parrot
  end

  def test_first_or_create_bang_with_valid_options
    parrot = Bird.where(:color => 'green').first_or_create!(:name => 'parrot')
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color

    same_parrot = Bird.where(:color => 'green').first_or_create!(:name => 'parakeet')
    assert_kind_of Bird, same_parrot
    assert same_parrot.persisted?
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_bang_with_invalid_options
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create!(:pirate_id => 1) }
  end

  def test_first_or_create_bang_with_no_parameters
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create! }
  end

  def test_first_or_create_bang_with_valid_block
    parrot = Bird.where(:color => 'green').first_or_create! { |bird| bird.name = 'parrot' }
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name

    same_parrot = Bird.where(:color => 'green').first_or_create! { |bird| bird.name = 'parakeet' }
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_bang_with_invalid_block
    assert_raise(ActiveRecord::RecordInvalid) do
964
      Bird.where(:color => 'green').first_or_create! { |bird| bird.pirate_id = 1 }
965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981
    end
  end

  def test_first_or_create_with_valid_array
    several_green_birds = Bird.where(:color => 'green').first_or_create!([{:name => 'parrot'}, {:name => 'parakeet'}])
    assert_kind_of Array, several_green_birds
    several_green_birds.each { |bird| assert bird.persisted? }

    same_parrot = Bird.where(:color => 'green').first_or_create!([{:name => 'hummingbird'}, {:name => 'macaw'}])
    assert_kind_of Bird, same_parrot
    assert_equal several_green_birds.first, same_parrot
  end

  def test_first_or_create_with_invalid_array
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create!([ {:name => 'parrot'}, {:pirate_id => 1} ]) }
  end

982 983
  def test_first_or_initialize
    parrot = Bird.where(:color => 'green').first_or_initialize(:name => 'parrot')
984 985 986 987 988 989 990 991
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert parrot.valid?
    assert parrot.new_record?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color
  end

992 993
  def test_first_or_initialize_with_no_parameters
    parrot = Bird.where(:color => 'green').first_or_initialize
994 995 996 997 998 999 1000
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert !parrot.valid?
    assert parrot.new_record?
    assert_equal 'green', parrot.color
  end

1001 1002
  def test_first_or_initialize_with_block
    parrot = Bird.where(:color => 'green').first_or_initialize { |bird| bird.name = 'parrot' }
1003 1004 1005 1006 1007 1008 1009 1010
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert parrot.valid?
    assert parrot.new_record?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name
  end

1011 1012 1013 1014 1015 1016 1017 1018
  def test_explicit_create_scope
    hens = Bird.where(:name => 'hen')
    assert_equal 'hen', hens.new.name

    hens = hens.create_with(:name => 'cock')
    assert_equal 'cock', hens.new.name
  end

P
Pratik Naik 已提交
1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029
  def test_except
    relation = Post.where(:author_id => 1).order('id ASC').limit(1)
    assert_equal [posts(:welcome)], relation.all

    author_posts = relation.except(:order, :limit)
    assert_equal Post.where(:author_id => 1).all, author_posts.all

    all_posts = relation.except(:where, :order, :limit)
    assert_equal Post.all, all_posts.all
  end

1030 1031 1032 1033
  def test_extensions_with_except
    assert_equal 2, Topic.named_extension.order(:author_name).except(:order).two
  end

E
Emilio Tagua 已提交
1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044
  def test_only
    relation = Post.where(:author_id => 1).order('id ASC').limit(1)
    assert_equal [posts(:welcome)], relation.all

    author_posts = relation.only(:where)
    assert_equal Post.where(:author_id => 1).all, author_posts.all

    all_posts = relation.only(:limit)
    assert_equal Post.limit(1).all.first, all_posts.first
  end

1045 1046 1047 1048
  def test_extensions_with_only
    assert_equal 2, Topic.named_extension.order(:author_name).only(:order).two
  end

P
Pratik Naik 已提交
1049
  def test_anonymous_extension
1050
    relation = Post.where(:author_id => 1).order('id ASC').extending do
P
Pratik Naik 已提交
1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064
      def author
        'lifo'
      end
    end

    assert_equal "lifo", relation.author
    assert_equal "lifo", relation.limit(1).author
  end

  def test_named_extension
    relation = Post.where(:author_id => 1).order('id ASC').extending(Post::NamedExtension)
    assert_equal "lifo", relation.author
    assert_equal "lifo", relation.limit(1).author
  end
1065 1066 1067 1068

  def test_order_by_relation_attribute
    assert_equal Post.order(Post.arel_table[:title]).all, Post.order("title").all
  end
1069

1070
  def test_order_with_find_with_order
1071 1072
    assert_equal 'zyke', CoolCar.order('name desc').find(:first, :order => 'id').name
    assert_equal 'zyke', FastCar.order('name desc').find(:first, :order => 'id').name
1073 1074
  end

1075
  def test_default_scope_order_with_scope_order
1076 1077 1078 1079
    assert_equal 'zyke', CoolCar.order_using_new_style.limit(1).first.name
    assert_equal 'zyke', CoolCar.order_using_old_style.limit(1).first.name
    assert_equal 'zyke', FastCar.order_using_new_style.limit(1).first.name
    assert_equal 'zyke', FastCar.order_using_old_style.limit(1).first.name
1080 1081 1082
  end

  def test_order_using_scoping
1083 1084
    car1 = CoolCar.order('id DESC').scoping do
      CoolCar.find(:first, :order => 'id asc')
1085
    end
1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099
    assert_equal 'zyke', car1.name

    car2 = FastCar.order('id DESC').scoping do
      FastCar.find(:first, :order => 'id asc')
    end
    assert_equal 'zyke', car2.name
  end

  def test_unscoped_block_style
    assert_equal 'honda', CoolCar.unscoped { CoolCar.order_using_new_style.limit(1).first.name}
    assert_equal 'honda', CoolCar.unscoped { CoolCar.order_using_old_style.limit(1).first.name}

    assert_equal 'honda', FastCar.unscoped { FastCar.order_using_new_style.limit(1).first.name}
    assert_equal 'honda', FastCar.unscoped { FastCar.order_using_old_style.limit(1).first.name}
1100 1101
  end

1102 1103 1104
  def test_intersection_with_array
    relation = Author.where(:name => "David")
    rails_author = relation.first
1105

1106 1107 1108
    assert_equal [rails_author], [rails_author] & relation
    assert_equal [rails_author], relation & [rails_author]
  end
1109 1110 1111 1112

  def test_removing_limit_with_options
    assert_not_equal 1, Post.limit(1).all(:limit => nil).count
  end
1113 1114 1115 1116

  def test_primary_key
    assert_equal "id", Post.scoped.primary_key
  end
1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129

  def test_eager_loading_with_conditions_on_joins
    scope = Post.includes(:comments)

    # This references the comments table, and so it should cause the comments to be eager
    # loaded via a JOIN, rather than by subsequent queries.
    scope = scope.joins(
      Post.arel_table.create_join(
        Post.arel_table,
        Post.arel_table.create_on(Comment.arel_table[:id].eq(3))
      )
    )

1130 1131 1132
    assert_deprecated do
      assert scope.eager_loading?
    end
1133
  end
1134 1135

  def test_ordering_with_extra_spaces
1136
    assert_equal authors(:david), Author.order('id DESC , name DESC').last
1137
  end
1138 1139 1140 1141 1142 1143 1144 1145

  def test_update_all_with_joins
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id)
    count    = comments.count

    assert_equal count, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:greetings).post
  end
1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167

  def test_update_all_with_joins_and_limit
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).limit(1)
    assert_equal 1, comments.update_all(:post_id => posts(:thinking).id)
  end

  def test_update_all_with_joins_and_limit_and_order
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).order('comments.id').limit(1)
    assert_equal 1, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:greetings).post
    assert_equal posts(:welcome),  comments(:more_greetings).post
  end

  def test_update_all_with_joins_and_offset
    all_comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id)
    count        = all_comments.count
    comments     = all_comments.offset(1)

    assert_equal count - 1, comments.update_all(:post_id => posts(:thinking).id)
  end

  def test_update_all_with_joins_and_offset_and_order
1168
    all_comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).order('posts.id', 'comments.id')
1169 1170 1171 1172 1173 1174 1175
    count        = all_comments.count
    comments     = all_comments.offset(1)

    assert_equal count - 1, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:more_greetings).post
    assert_equal posts(:welcome),  comments(:greetings).post
  end
1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191

  def test_uniq
    tag1 = Tag.create(:name => 'Foo')
    tag2 = Tag.create(:name => 'Foo')

    query = Tag.select(:name).where(:id => [tag1.id, tag2.id])

    assert_equal ['Foo', 'Foo'], query.map(&:name)
    assert_sql(/DISTINCT/) do
      assert_equal ['Foo'], query.uniq.map(&:name)
    end
    assert_sql(/DISTINCT/) do
      assert_equal ['Foo'], query.uniq(true).map(&:name)
    end
    assert_equal ['Foo', 'Foo'], query.uniq(true).uniq(false).map(&:name)
  end
1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202

  def test_references_triggers_eager_loading
    scope = Post.includes(:comments)
    assert !scope.eager_loading?
    assert scope.references(:comments).eager_loading?
  end

  def test_references_doesnt_trigger_eager_loading_if_reference_not_included
    scope = Post.references(:comments)
    assert !scope.eager_loading?
  end
1203

1204
  def test_automatically_added_where_references
1205
    scope = Post.where(:comments => { :body => "Bla" })
J
Jon Leighton 已提交
1206
    assert_equal ['comments'], scope.references_values
1207 1208

    scope = Post.where('comments.body' => 'Bla')
J
Jon Leighton 已提交
1209
    assert_equal ['comments'], scope.references_values
1210
  end
1211

1212
  def test_automatically_added_having_references
1213
    scope = Post.having(:comments => { :body => "Bla" })
J
Jon Leighton 已提交
1214
    assert_equal ['comments'], scope.references_values
1215 1216

    scope = Post.having('comments.body' => 'Bla')
J
Jon Leighton 已提交
1217
    assert_equal ['comments'], scope.references_values
1218
  end
1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236

  def test_automatically_added_order_references
    scope = Post.order('comments.body')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('comments.body', 'yaks.body')
    assert_equal ['comments', 'yaks'], scope.references_values

    # Don't infer yaks, let's not go down that road again...
    scope = Post.order('comments.body, yaks.body')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('comments.body asc')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('foo(comments.body)')
    assert_equal [], scope.references_values
  end
P
Pratik Naik 已提交
1237
end