relations_test.rb 48.9 KB
Newer Older
1
require "cases/helper"
2
require 'models/tag'
3
require 'models/tagging'
4 5
require 'models/post'
require 'models/topic'
6
require 'models/comment'
7 8 9
require 'models/author'
require 'models/entrant'
require 'models/developer'
10
require 'models/reply'
11
require 'models/company'
12
require 'models/bird'
13 14 15
require 'models/car'
require 'models/engine'
require 'models/tyre'
16
require 'models/minivan'
17

18

E
Emilio Tagua 已提交
19
class RelationTest < ActiveRecord::TestCase
20
  fixtures :authors, :topics, :entrants, :developers, :companies, :developers_projects, :accounts, :categories, :categorizations, :posts, :comments,
21 22 23 24 25 26 27
    :tags, :taggings, :cars, :minivans

  def test_do_not_double_quote_string_id
    van = Minivan.last
    assert van
    assert_equal van.id, Minivan.where(:minivan_id => van).to_a.first.minivan_id
  end
28

29 30 31 32 33 34
  def test_do_not_double_quote_string_id_with_array
    van = Minivan.last
    assert van
    assert_equal van, Minivan.where(:minivan_id => [van]).to_a.first
  end

A
Aaron Patterson 已提交
35
  def test_bind_values
36
    relation = Post.all
A
Aaron Patterson 已提交
37 38 39 40 41 42 43
    assert_equal [], relation.bind_values

    relation2 = relation.bind 'foo'
    assert_equal %w{ foo }, relation2.bind_values
    assert_equal [], relation.bind_values
  end

44
  def test_two_scopes_with_includes_should_not_drop_any_include
45
    car = Car.incl_engines.incl_tyres.first
46 47
    assert_no_queries { car.tyres.length }
    assert_no_queries { car.engines.length }
48
  end
49

50 51 52 53 54
  def test_dynamic_finder
    x = Post.where('author_id = ?', 1)
    assert x.klass.respond_to?(:find_by_id), '@klass should handle dynamic finders'
  end

55 56 57 58 59
  def test_multivalue_where
    posts = Post.where('author_id = ? AND id = ?', 1, 1)
    assert_equal 1, posts.to_a.size
  end

60
  def test_scoped
61
    topics = Topic.all
62 63 64 65
    assert_kind_of ActiveRecord::Relation, topics
    assert_equal 4, topics.size
  end

66
  def test_to_json
67 68
    assert_nothing_raised  { Bird.all.to_json }
    assert_nothing_raised  { Bird.all.to_a.to_json }
69 70 71
  end

  def test_to_yaml
72 73
    assert_nothing_raised  { Bird.all.to_yaml }
    assert_nothing_raised  { Bird.all.to_a.to_yaml }
74 75
  end

76
  def test_to_xml
77 78
    assert_nothing_raised  { Bird.all.to_xml }
    assert_nothing_raised  { Bird.all.to_a.to_xml }
79 80
  end

81
  def test_scoped_all
82
    topics = Topic.all.to_a
83 84 85 86
    assert_kind_of Array, topics
    assert_no_queries { assert_equal 4, topics.size }
  end

P
Pratik Naik 已提交
87
  def test_loaded_all
88
    topics = Topic.all
P
Pratik Naik 已提交
89 90

    assert_queries(1) do
91
      2.times { assert_equal 4, topics.to_a.size }
P
Pratik Naik 已提交
92 93 94 95 96 97
    end

    assert topics.loaded?
  end

  def test_scoped_first
98
    topics = Topic.all.order('id ASC')
P
Pratik Naik 已提交
99 100 101 102 103 104 105 106 107

    assert_queries(1) do
      2.times { assert_equal "The First Topic", topics.first.title }
    end

    assert ! topics.loaded?
  end

  def test_loaded_first
108
    topics = Topic.all.order('id ASC')
P
Pratik Naik 已提交
109 110

    assert_queries(1) do
111
      topics.to_a # force load
P
Pratik Naik 已提交
112 113 114 115 116 117
      2.times { assert_equal "The First Topic", topics.first.title }
    end

    assert topics.loaded?
  end

118
  def test_reload
119
    topics = Topic.all
120 121 122 123 124 125 126

    assert_queries(1) do
      2.times { topics.to_a }
    end

    assert topics.loaded?

127 128
    original_size = topics.to_a.size
    Topic.create! :title => 'fake'
129

130 131 132
    assert_queries(1) { topics.reload }
    assert_equal original_size + 1, topics.size
    assert topics.loaded?
133 134
  end

I
Ivan Kukobko 已提交
135
  def test_finding_with_subquery
136 137 138 139 140 141
    relation = Topic.where(:approved => true)
    assert_equal relation.to_a, Topic.select('*').from(relation).to_a
    assert_equal relation.to_a, Topic.select('subquery.*').from(relation).to_a
    assert_equal relation.to_a, Topic.select('a.*').from(relation, :a).to_a
  end

142 143 144 145 146 147 148
  def test_finding_with_subquery_with_binds
    relation = Post.first.comments
    assert_equal relation.to_a, Comment.select('*').from(relation).to_a
    assert_equal relation.to_a, Comment.select('subquery.*').from(relation).to_a
    assert_equal relation.to_a, Comment.select('a.*').from(relation, :a).to_a
  end

149
  def test_finding_with_conditions
150 151
    assert_equal ["David"], Author.where(:name => 'David').map(&:name)
    assert_equal ['Mary'],  Author.where(["name = ?", 'Mary']).map(&:name)
152
    assert_equal ['Mary'],  Author.where("name = ?", 'Mary').map(&:name)
153 154 155
  end

  def test_finding_with_order
156
    topics = Topic.order('id')
157
    assert_equal 4, topics.to_a.size
158 159 160
    assert_equal topics(:first).title, topics.first.title
  end

161 162 163 164 165 166

  def test_finding_with_arel_order
    topics = Topic.order(Topic.arel_table[:id].asc)
    assert_equal 4, topics.to_a.size
    assert_equal topics(:first).title, topics.first.title
  end
167

168 169 170 171 172
  def test_finding_with_assoc_order
    topics = Topic.order(:id => :desc)
    assert_equal 4, topics.to_a.size
    assert_equal topics(:fourth).title, topics.first.title
  end
173

174 175 176 177 178
  def test_finding_with_reverted_assoc_order
    topics = Topic.order(:id => :asc).reverse_order
    assert_equal 4, topics.to_a.size
    assert_equal topics(:fourth).title, topics.first.title
  end
179

Y
Yves Senn 已提交
180 181 182 183
  def test_order_with_hash_and_symbol_generates_the_same_sql
    assert_equal Topic.order(:id).to_sql, Topic.order(:id => :asc).to_sql
  end

184 185 186
  def test_raising_exception_on_invalid_hash_params
    assert_raise(ArgumentError) { Topic.order(:name, "id DESC", :id => :DeSc) }
  end
187 188 189 190 191 192

  def test_finding_last_with_arel_order
    topics = Topic.order(Topic.arel_table[:id].asc)
    assert_equal topics(:fourth).title, topics.last.title
  end

193
  def test_finding_with_order_concatenated
194
    topics = Topic.order('author_name').order('title')
195 196 197 198
    assert_equal 4, topics.to_a.size
    assert_equal topics(:fourth).title, topics.first.title
  end

S
Sebastian Martinez 已提交
199
  def test_finding_with_reorder
200
    topics = Topic.order('author_name').order('title').reorder('id').to_a
S
Sebastian Martinez 已提交
201 202 203
    topics_titles = topics.map{ |t| t.title }
    assert_equal ['The First Topic', 'The Second Topic of the day', 'The Third Topic of the day', 'The Fourth Topic of the day'], topics_titles
  end
204

205
  def test_finding_with_order_and_take
206
    entrants = Entrant.order("id ASC").limit(2).to_a
207

P
Pratik Naik 已提交
208 209
    assert_equal 2, entrants.size
    assert_equal entrants(:first).name, entrants.first.name
210 211
  end

212
  def test_finding_with_cross_table_order_and_limit
213
    tags = Tag.includes(:taggings).
214 215
              order("tags.name asc", "taggings.taggable_id asc", "REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").
              limit(1).to_a
216 217 218
    assert_equal 1, tags.length
  end

219
  def test_finding_with_complex_order_and_limit
220
    tags = Tag.includes(:taggings).references(:taggings).order("REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").limit(1).to_a
221 222 223 224
    assert_equal 1, tags.length
  end

  def test_finding_with_complex_order
225
    tags = Tag.includes(:taggings).references(:taggings).order("REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").to_a
226
    assert_equal 3, tags.length
227 228
  end

229
  def test_finding_with_order_limit_and_offset
230
    entrants = Entrant.order("id ASC").limit(2).offset(1)
231

232
    assert_equal 2, entrants.to_a.size
P
Pratik Naik 已提交
233
    assert_equal entrants(:second).name, entrants.first.name
234

235
    entrants = Entrant.order("id ASC").limit(2).offset(2)
236
    assert_equal 1, entrants.to_a.size
P
Pratik Naik 已提交
237
    assert_equal entrants(:third).name, entrants.first.name
238 239 240
  end

  def test_finding_with_group
241
    developers = Developer.group("salary").select("salary").to_a
242 243 244 245
    assert_equal 4, developers.size
    assert_equal 4, developers.map(&:salary).uniq.size
  end

246
  def test_select_with_block
247
    even_ids = Developer.all.select {|d| d.id % 2 == 0 }.map(&:id)
248
    assert_equal [2, 4, 6, 8, 10], even_ids.sort
249 250
  end

251 252 253
  def test_none
    assert_no_queries do
      assert_equal [], Developer.none
254
      assert_equal [], Developer.all.none
255 256 257 258 259 260 261 262 263
    end
  end

  def test_none_chainable
    assert_no_queries do
      assert_equal [], Developer.none.where(:name => 'David')
    end
  end

A
Akira Matsuda 已提交
264 265 266 267 268 269
  def test_none_chainable_to_existing_scope_extension_method
    assert_no_queries do
      assert_equal 1, Topic.anonymous_extension.none.one
    end
  end

270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291
  def test_none_chained_to_methods_firing_queries_straight_to_db
    assert_no_queries do
      assert_equal [],    Developer.none.pluck(:id) # => uses select_all
      assert_equal 0,     Developer.none.delete_all
      assert_equal 0,     Developer.none.update_all(:name => 'David')
      assert_equal 0,     Developer.none.delete(1)
      assert_equal false, Developer.none.exists?(1)
    end
  end

  def test_null_relation_content_size_methods
    assert_no_queries do
      assert_equal 0,     Developer.none.size
      assert_equal 0,     Developer.none.count
      assert_equal true,  Developer.none.empty?
      assert_equal false, Developer.none.any?
      assert_equal false, Developer.none.many?
    end
  end

  def test_null_relation_calculations_methods
    assert_no_queries do
292 293 294
      assert_equal 0, Developer.none.count
      assert_equal 0, Developer.none.calculate(:count, nil, {})
      assert_equal nil, Developer.none.calculate(:average, 'salary')
295 296
    end
  end
297

298 299 300 301 302
  def test_null_relation_metadata_methods
    assert_equal "", Developer.none.to_sql
    assert_equal({}, Developer.none.where_values_hash)
  end

303 304 305 306
  def test_joins_with_nil_argument
    assert_nothing_raised { DependentFirm.joins(nil).first }
  end

307
  def test_finding_with_hash_conditions_on_joined_table
308
    firms = DependentFirm.joins(:account).where({:name => 'RailsCore', :accounts => { :credit_limit => 55..60 }}).to_a
309 310 311 312 313
    assert_equal 1, firms.size
    assert_equal companies(:rails_core), firms.first
  end

  def test_find_all_with_join
314
    developers_on_project_one = Developer.joins('LEFT JOIN developers_projects ON developers.id = developers_projects.developer_id').
315
      where('project_id=1').to_a
316 317 318 319 320 321 322 323

    assert_equal 3, developers_on_project_one.length
    developer_names = developers_on_project_one.map { |d| d.name }
    assert developer_names.include?('David')
    assert developer_names.include?('Jamis')
  end

  def test_find_on_hash_conditions
324
    assert_equal Topic.all.merge!(:where => {:approved => false}).to_a, Topic.where({ :approved => false }).to_a
325 326 327
  end

  def test_joins_with_string_array
328
    person_with_reader_and_post = Post.joins([
329 330 331 332 333 334
        "INNER JOIN categorizations ON categorizations.post_id = posts.id",
        "INNER JOIN categories ON categories.id = categorizations.category_id AND categories.type = 'SpecialCategory'"
      ]
    ).to_a
    assert_equal 1, person_with_reader_and_post.size
  end
335

336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351
  def test_no_arguments_to_query_methods_raise_errors
    assert_raises(ArgumentError) { Topic.references() }
    assert_raises(ArgumentError) { Topic.includes() }
    assert_raises(ArgumentError) { Topic.preload() }
    assert_raises(ArgumentError) { Topic.group() }
    assert_raises(ArgumentError) { Topic.reorder() }
  end

  def test_blank_like_arguments_to_query_methods_dont_raise_errors
    assert_nothing_raised { Topic.references([]) }
    assert_nothing_raised { Topic.includes([]) }
    assert_nothing_raised { Topic.preload([]) }
    assert_nothing_raised { Topic.group([]) }
    assert_nothing_raised { Topic.reorder([]) }
  end

352
  def test_scoped_responds_to_delegated_methods
353
    relation = Topic.all
354 355

    ["map", "uniq", "sort", "insert", "delete", "update"].each do |method|
356
      assert_respond_to relation, method, "Topic.all should respond to #{method.inspect}"
357 358 359
    end
  end

360
  def test_respond_to_delegates_to_relation
361
    relation = Topic.all
362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
    fake_arel = Struct.new(:responds) {
      def respond_to? method, access = false
        responds << [method, access]
      end
    }.new []

    relation.extend(Module.new { attr_accessor :arel })
    relation.arel = fake_arel

    relation.respond_to?(:matching_attributes)
    assert_equal [:matching_attributes, false], fake_arel.responds.first

    fake_arel.responds = []
    relation.respond_to?(:matching_attributes, true)
    assert_equal [:matching_attributes, true], fake_arel.responds.first
  end

379
  def test_respond_to_dynamic_finders
380
    relation = Topic.all
381

382
    ["find_by_title", "find_by_title_and_author_name"].each do |method|
383
      assert_respond_to relation, method, "Topic.all should respond to #{method.inspect}"
384 385
    end
  end
386

387
  def test_respond_to_class_methods_and_scopes
388
    assert Topic.all.respond_to?(:by_lifo)
389 390
  end

391
  def test_find_with_readonly_option
392 393
    Developer.all.each { |d| assert !d.readonly? }
    Developer.all.readonly.each { |d| assert d.readonly? }
394
  end
395 396

  def test_eager_association_loading_of_stis_with_multiple_references
397
    authors = Author.eager_load(:posts => { :special_comments => { :post => [ :special_comments, :very_special_comment ] } }).
398
      order('comments.body, very_special_comments_posts.body').where('posts.id = 4').to_a
399

400 401 402 403 404 405 406
    assert_equal [authors(:david)], authors
    assert_no_queries do
      authors.first.posts.first.special_comments.first.post.special_comments
      authors.first.posts.first.special_comments.first.post.very_special_comment
    end
  end

407
  def test_find_with_preloaded_associations
408
    assert_queries(2) do
409
      posts = Post.preload(:comments).order('posts.id')
410
      assert posts.first.comments.first
411
    end
412

C
Carlos Antonio da Silva 已提交
413
    assert_queries(2) do
414
      posts = Post.preload(:comments).order('posts.id')
415
      assert posts.first.comments.first
416
    end
417

418
    assert_queries(2) do
419
      posts = Post.preload(:author).order('posts.id')
420
      assert posts.first.author
421
    end
422

C
Carlos Antonio da Silva 已提交
423
    assert_queries(2) do
424
      posts = Post.preload(:author).order('posts.id')
425 426 427
      assert posts.first.author
    end

C
Carlos Antonio da Silva 已提交
428
    assert_queries(3) do
429
      posts = Post.preload(:author, :comments).order('posts.id')
430
      assert posts.first.author
431 432 433 434
      assert posts.first.comments.first
    end
  end

435 436 437 438 439 440 441
  def test_preload_applies_to_all_chained_preloaded_scopes
    assert_queries(3) do
      post = Post.with_comments.with_tags.first
      assert post
    end
  end

442 443
  def test_find_with_included_associations
    assert_queries(2) do
444
      posts = Post.includes(:comments).order('posts.id')
445 446 447
      assert posts.first.comments.first
    end

C
Carlos Antonio da Silva 已提交
448
    assert_queries(2) do
449
      posts = Post.all.includes(:comments).order('posts.id')
450 451 452 453
      assert posts.first.comments.first
    end

    assert_queries(2) do
454
      posts = Post.includes(:author).order('posts.id')
455 456 457
      assert posts.first.author
    end

C
Carlos Antonio da Silva 已提交
458
    assert_queries(3) do
459
      posts = Post.includes(:author, :comments).order('posts.id')
460
      assert posts.first.author
461
      assert posts.first.comments.first
462 463
    end
  end
464

P
Pratik Naik 已提交
465
  def test_default_scope_with_conditions_string
466
    assert_equal Developer.where(name: 'David').map(&:id).sort, DeveloperCalledDavid.all.map(&:id).sort
467
    assert_nil DeveloperCalledDavid.create!.name
468 469 470
  end

  def test_default_scope_with_conditions_hash
471
    assert_equal Developer.where(name: 'Jamis').map(&:id).sort, DeveloperCalledJamis.all.map(&:id).sort
472 473 474
    assert_equal 'Jamis', DeveloperCalledJamis.create!.name
  end

475 476
  def test_default_scoping_finder_methods
    developers = DeveloperCalledDavid.order('id').map(&:id).sort
J
Jon Leighton 已提交
477
    assert_equal Developer.where(name: 'David').map(&:id).sort, developers
478 479
  end

480 481
  def test_loading_with_one_association
    posts = Post.preload(:comments)
482 483 484 485
    post = posts.find { |p| p.id == 1 }
    assert_equal 2, post.comments.size
    assert post.comments.include?(comments(:greetings))

486
    post = Post.where("posts.title = 'Welcome to the weblog'").preload(:comments).first
487 488 489
    assert_equal 2, post.comments.size
    assert post.comments.include?(comments(:greetings))

490
    posts = Post.preload(:last_comment)
491 492 493 494
    post = posts.find { |p| p.id == 1 }
    assert_equal Post.find(1).last_comment, post.last_comment
  end

495 496 497 498 499 500 501 502
  def test_to_sql_on_eager_join
    expected = assert_sql {
      Post.eager_load(:last_comment).order('comments.id DESC').to_a
    }.first
    actual = Post.eager_load(:last_comment).order('comments.id DESC').to_sql
    assert_equal expected, actual
  end

503
  def test_loading_with_one_association_with_non_preload
504
    posts = Post.eager_load(:last_comment).order('comments.id DESC')
505 506 507
    post = posts.find { |p| p.id == 1 }
    assert_equal Post.find(1).last_comment, post.last_comment
  end
508 509 510 511 512 513 514

  def test_dynamic_find_by_attributes
    david = authors(:david)
    author = Author.preload(:taggings).find_by_id(david.id)
    expected_taggings = taggings(:welcome_general, :thinking_general)

    assert_no_queries do
515
      assert_equal expected_taggings, author.taggings.distinct.sort_by { |t| t.id }
516 517 518
      assert_equal expected_taggings, author.taggings.uniq.sort_by { |t| t.id }
    end

519
    authors = Author.all
520 521 522 523 524
    assert_equal david, authors.find_by_id_and_name(david.id, david.name)
    assert_equal david, authors.find_by_id_and_name!(david.id, david.name)
  end

  def test_dynamic_find_by_attributes_bang
525
    author = Author.all.find_by_id!(authors(:david).id)
526 527
    assert_equal "David", author.name

528
    assert_raises(ActiveRecord::RecordNotFound) { Author.all.find_by_id_and_name!(20, 'invalid') }
529 530
  end

P
Pratik Naik 已提交
531
  def test_find_id
532
    authors = Author.all
P
Pratik Naik 已提交
533 534 535 536

    david = authors.find(authors(:david).id)
    assert_equal 'David', david.name

P
Pratik Naik 已提交
537
    assert_raises(ActiveRecord::RecordNotFound) { authors.where(:name => 'lifo').find('42') }
P
Pratik Naik 已提交
538
  end
539

P
Pratik Naik 已提交
540 541 542 543 544 545 546 547 548 549
  def test_find_ids
    authors = Author.order('id ASC')

    results = authors.find(authors(:david).id, authors(:mary).id)
    assert_kind_of Array, results
    assert_equal 2, results.size
    assert_equal 'David', results[0].name
    assert_equal 'Mary', results[1].name
    assert_equal results, authors.find([authors(:david).id, authors(:mary).id])

P
Pratik Naik 已提交
550 551
    assert_raises(ActiveRecord::RecordNotFound) { authors.where(:name => 'lifo').find(authors(:david).id, '42') }
    assert_raises(ActiveRecord::RecordNotFound) { authors.find(['42', 43]) }
P
Pratik Naik 已提交
552 553
  end

554
  def test_find_in_empty_array
555 556
    authors = Author.all.where(:id => [])
    assert authors.to_a.blank?
557 558
  end

559 560
  def test_where_with_ar_object
    author = Author.first
561
    authors = Author.all.where(:id => author)
562
    assert_equal 1, authors.to_a.length
563 564
  end

565 566 567 568 569 570
  def test_find_with_list_of_ar
    author = Author.first
    authors = Author.find([author])
    assert_equal author, authors.first
  end

571 572 573 574 575 576 577
  class Mary < Author; end

  def test_find_by_classname
    Author.create!(:name => Mary.name)
    assert_equal 1, Author.where(:name => Mary).size
  end

578 579 580 581 582 583
  def test_find_by_id_with_list_of_ar
    author = Author.first
    authors = Author.find_by_id([author])
    assert_equal author, authors
  end

584 585 586 587 588 589
  def test_find_all_using_where_twice_should_or_the_relation
    david = authors(:david)
    relation = Author.unscoped
    relation = relation.where(:name => david.name)
    relation = relation.where(:name => 'Santiago')
    relation = relation.where(:id => david.id)
590
    assert_equal [], relation.to_a
591 592
  end

A
Aaron Patterson 已提交
593 594 595 596 597 598 599 600
  def test_multi_where_ands_queries
    relation = Author.unscoped
    david = authors(:david)
    sql = relation.where(:name => david.name).where(:name => 'Santiago').to_sql
    assert_match('AND', sql)
  end

  def test_find_all_with_multiple_should_use_and
A
Aaron Patterson 已提交
601 602 603 604 605 606 607 608
    david = authors(:david)
    relation = [
      { :name => david.name },
      { :name => 'Santiago' },
      { :name => 'tenderlove' },
    ].inject(Author.unscoped) do |memo, param|
      memo.where(param)
    end
609
    assert_equal [], relation.to_a
A
Aaron Patterson 已提交
610
  end
A
Aaron Patterson 已提交
611

612 613 614 615 616 617
  def test_find_all_using_where_with_relation
    david = authors(:david)
    # switching the lines below would succeed in current rails
    # assert_queries(2) {
    assert_queries(1) {
      relation = Author.where(:id => Author.where(:id => david.id))
618
      assert_equal [david], relation.to_a
619 620 621
    }
  end

622 623 624 625 626 627
  def test_find_all_using_where_with_relation_and_alternate_primary_key
    cool_first = minivans(:cool_first)
    # switching the lines below would succeed in current rails
    # assert_queries(2) {
    assert_queries(1) {
      relation = Minivan.where(:minivan_id => Minivan.where(:name => cool_first.name))
628
      assert_equal [cool_first], relation.to_a
629 630 631
    }
  end

632 633 634 635 636 637 638
  def test_find_all_using_where_with_relation_does_not_alter_select_values
    david = authors(:david)

    subquery = Author.where(:id => david.id)

    assert_queries(1) {
      relation = Author.where(:id => subquery)
639
      assert_equal [david], relation.to_a
640 641 642 643 644
    }

    assert_equal 0, subquery.select_values.size
  end

645 646 647 648
  def test_find_all_using_where_with_relation_with_joins
    david = authors(:david)
    assert_queries(1) {
      relation = Author.where(:id => Author.joins(:posts).where(:id => david.id))
649
      assert_equal [david], relation.to_a
650 651 652
    }
  end

A
Aaron Patterson 已提交
653

654 655 656 657
  def test_find_all_using_where_with_relation_with_select_to_build_subquery
    david = authors(:david)
    assert_queries(1) {
      relation = Author.where(:name => Author.where(:id => david.id).select(:name))
658
      assert_equal [david], relation.to_a
659
    }
A
Aaron Patterson 已提交
660 661
  end

P
Pratik Naik 已提交
662 663 664 665 666
  def test_exists
    davids = Author.where(:name => 'David')
    assert davids.exists?
    assert davids.exists?(authors(:david).id)
    assert ! davids.exists?(authors(:mary).id)
P
Pratik Naik 已提交
667 668
    assert ! davids.exists?("42")
    assert ! davids.exists?(42)
669
    assert ! davids.exists?(davids.new)
P
Pratik Naik 已提交
670 671 672 673 674

    fake  = Author.where(:name => 'fake author')
    assert ! fake.exists?
    assert ! fake.exists?(authors(:david).id)
  end
675 676

  def test_last
677
    authors = Author.all
678
    assert_equal authors(:bob), authors.last
679 680
  end

P
Pratik Naik 已提交
681 682 683 684 685 686 687 688 689 690 691 692 693
  def test_destroy_all
    davids = Author.where(:name => 'David')

    # Force load
    assert_equal [authors(:david)], davids.to_a
    assert davids.loaded?

    assert_difference('Author.count', -1) { davids.destroy_all }

    assert_equal [], davids.to_a
    assert davids.loaded?
  end

P
Pratik Naik 已提交
694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713
  def test_delete_all
    davids = Author.where(:name => 'David')

    assert_difference('Author.count', -1) { davids.delete_all }
    assert ! davids.loaded?
  end

  def test_delete_all_loaded
    davids = Author.where(:name => 'David')

    # Force load
    assert_equal [authors(:david)], davids.to_a
    assert davids.loaded?

    assert_difference('Author.count', -1) { davids.delete_all }

    assert_equal [], davids.to_a
    assert davids.loaded?
  end

714 715 716 717
  def test_delete_all_limit_error
    assert_raises(ActiveRecord::ActiveRecordError) { Author.limit(10).delete_all }
  end

718 719 720 721 722 723 724 725
  def test_select_takes_a_variable_list_of_args
    david = developers(:david)

    developer = Developer.where(id: david.id).select(:name, :salary).first
    assert_equal david.name, developer.name
    assert_equal david.salary, developer.salary
  end

726 727 728 729
  def test_select_argument_error
    assert_raises(ArgumentError) { Developer.select }
  end

730
  def test_relation_merging
731
    devs = Developer.where("salary >= 80000").merge(Developer.limit(2)).merge(Developer.order('id ASC').where("id < 3"))
732 733
    assert_equal [developers(:david), developers(:jamis)], devs.to_a

734
    dev_with_count = Developer.limit(1).merge(Developer.order('id DESC')).merge(Developer.select('developers.*'))
735
    assert_equal [developers(:poor_jamis)], dev_with_count.to_a
736 737
  end

738 739 740 741 742 743 744
  def test_relation_to_sql
    sql = Post.connection.unprepared_statement do
      Post.first.comments.to_sql
    end
    assert_no_match(/\?/, sql)
  end

745 746 747 748 749 750 751
  def test_relation_merging_with_arel_equalities_keeps_last_equality
    devs = Developer.where(Developer.arel_table[:salary].eq(80000)).merge(
      Developer.where(Developer.arel_table[:salary].eq(9000))
    )
    assert_equal [developers(:poor_jamis)], devs.to_a
  end

752
  def test_relation_merging_with_arel_equalities_keeps_last_equality_with_non_attribute_left_hand
753
    salary_attr = Developer.arel_table[:salary]
754 755 756 757 758 759
    devs = Developer.where(
      Arel::Nodes::NamedFunction.new('abs', [salary_attr]).eq(80000)
    ).merge(
      Developer.where(
        Arel::Nodes::NamedFunction.new('abs', [salary_attr]).eq(9000)
      )
760 761 762 763
    )
    assert_equal [developers(:poor_jamis)], devs.to_a
  end

764 765
  def test_relation_merging_with_eager_load
    relations = []
766 767
    relations << Post.order('comments.id DESC').merge(Post.eager_load(:last_comment)).merge(Post.all)
    relations << Post.eager_load(:last_comment).merge(Post.order('comments.id DESC')).merge(Post.all)
768

769 770 771 772 773 774
    relations.each do |posts|
      post = posts.find { |p| p.id == 1 }
      assert_equal Post.find(1).last_comment, post.last_comment
    end
  end

775
  def test_relation_merging_with_locks
776
    devs = Developer.lock.where("salary >= 80000").order("id DESC").merge(Developer.limit(2))
777
    assert devs.locked.present?
778 779
  end

780
  def test_relation_merging_with_preload
781
    [Post.all.merge(Post.preload(:author)), Post.preload(:author).merge(Post.all)].each do |posts|
C
Carlos Antonio da Silva 已提交
782
      assert_queries(2) { assert posts.first.author }
M
Marcin Raczkowski 已提交
783
    end
784
  end
785

786
  def test_relation_merging_with_joins
787
    comments = Comment.joins(:post).where(:body => 'Thank you for the welcome').merge(Post.where(:body => 'Such a lovely day'))
788 789 790
    assert_equal 1, comments.count
  end

791 792 793 794 795 796 797 798
  def test_relation_merging_with_association
    assert_queries(2) do  # one for loading post, and another one merged query
      post = Post.where(:body => 'Such a lovely day').first
      comments = Comment.where(:body => 'Thank you for the welcome').merge(post.comments)
      assert_equal 1, comments.count
    end
  end

P
Pratik Naik 已提交
799
  def test_count
800
    posts = Post.all
P
Pratik Naik 已提交
801

802 803 804
    assert_equal 11, posts.count
    assert_equal 11, posts.count(:all)
    assert_equal 11, posts.count(:id)
P
Pratik Naik 已提交
805 806

    assert_equal 1, posts.where('comments_count > 1').count
807
    assert_equal 9, posts.where(:comments_count => 0).count
P
Pratik Naik 已提交
808 809 810
  end

  def test_count_with_distinct
811
    posts = Post.all
P
Pratik Naik 已提交
812

813 814
    assert_equal 3, posts.distinct(true).count(:comments_count)
    assert_equal 11, posts.distinct(false).count(:comments_count)
P
Pratik Naik 已提交
815

816 817
    assert_equal 3, posts.distinct(true).select(:comments_count).count
    assert_equal 11, posts.distinct(false).select(:comments_count).count
P
Pratik Naik 已提交
818 819 820 821
  end

  def test_count_explicit_columns
    Post.update_all(:comments_count => nil)
822
    posts = Post.all
P
Pratik Naik 已提交
823

P
Pratik Naik 已提交
824
    assert_equal [0], posts.select('comments_count').where('id is not null').group('id').order('id').count.values.uniq
825
    assert_equal 0, posts.where('id is not null').select('comments_count').count
826

827
    assert_equal 11, posts.select('comments_count').count('id')
P
Pratik Naik 已提交
828 829 830 831
    assert_equal 0, posts.select('comments_count').count
    assert_equal 0, posts.count(:comments_count)
    assert_equal 0, posts.count('comments_count')
  end
832

833
  def test_multiple_selects
834
    post = Post.all.select('comments_count').select('title').order("id ASC").first
835 836 837 838
    assert_equal "Welcome to the weblog", post.title
    assert_equal 2, post.comments_count
  end

839
  def test_size
840
    posts = Post.all
841

842
    assert_queries(1) { assert_equal 11, posts.size }
843 844 845 846
    assert ! posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
847
    assert_no_queries { assert_equal 9, best_posts.size }
848 849
  end

850
  def test_size_with_limit
851
    posts = Post.limit(10)
852

853
    assert_queries(1) { assert_equal 10, posts.size }
854 855 856 857
    assert ! posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
858
    assert_no_queries { assert_equal 9, best_posts.size }
859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877
  end

  def test_size_with_zero_limit
    posts = Post.limit(0)

    assert_no_queries { assert_equal 0, posts.size }
    assert ! posts.loaded?

    posts.to_a # force load
    assert_no_queries { assert_equal 0, posts.size }
  end

  def test_empty_with_zero_limit
    posts = Post.limit(0)

    assert_no_queries { assert_equal true, posts.empty? }
    assert ! posts.loaded?
  end

878 879 880 881 882 883 884
  def test_count_complex_chained_relations
    posts = Post.select('comments_count').where('id is not null').group("author_id").where("comments_count > 0")

    expected = { 1 => 2 }
    assert_equal expected, posts.count
  end

885
  def test_empty
886
    posts = Post.all
887 888 889 890 891 892 893 894 895 896 897 898 899 900 901

    assert_queries(1) { assert_equal false, posts.empty? }
    assert ! posts.loaded?

    no_posts = posts.where(:title => "")
    assert_queries(1) { assert_equal true, no_posts.empty? }
    assert ! no_posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
    assert_no_queries { assert_equal false, best_posts.empty? }
  end

  def test_empty_complex_chained_relations
    posts = Post.select("comments_count").where("id is not null").group("author_id").where("comments_count > 0")
A
Andrew White 已提交
902

903 904 905 906 907 908 909 910
    assert_queries(1) { assert_equal false, posts.empty? }
    assert ! posts.loaded?

    no_posts = posts.where(:title => "")
    assert_queries(1) { assert_equal true, no_posts.empty? }
    assert ! no_posts.loaded?
  end

P
Pratik Naik 已提交
911
  def test_any
912
    posts = Post.all
P
Pratik Naik 已提交
913

914 915 916 917 918 919 920 921
    # This test was failing when run on its own (as opposed to running the entire suite).
    # The second line in the assert_queries block was causing visit_Arel_Attributes_Attribute
    # in Arel::Visitors::ToSql to trigger a SHOW TABLES query. Running that line here causes
    # the SHOW TABLES result to be cached so we don't have to do it again in the block.
    #
    # This is obviously a rubbish fix but it's the best I can come up with for now...
    posts.where(:id => nil).any?

P
Pratik Naik 已提交
922 923 924 925 926 927 928 929 930 931 932 933
    assert_queries(3) do
      assert posts.any? # Uses COUNT()
      assert ! posts.where(:id => nil).any?

      assert posts.any? {|p| p.id > 0 }
      assert ! posts.any? {|p| p.id <= 0 }
    end

    assert posts.loaded?
  end

  def test_many
934
    posts = Post.all
935

P
Pratik Naik 已提交
936 937 938 939 940
    assert_queries(2) do
      assert posts.many? # Uses COUNT()
      assert posts.many? {|p| p.id > 0 }
      assert ! posts.many? {|p| p.id < 2 }
    end
941

P
Pratik Naik 已提交
942 943 944
    assert posts.loaded?
  end

945
  def test_many_with_limits
946
    posts = Post.all
947 948 949 950

    assert posts.many?
    assert ! posts.limit(1).many?
  end
P
Pratik Naik 已提交
951 952

  def test_build
953
    posts = Post.all
P
Pratik Naik 已提交
954 955 956 957 958 959 960 961 962 963 964 965 966

    post = posts.new
    assert_kind_of Post, post
  end

  def test_scoped_build
    posts = Post.where(:title => 'You told a lie')

    post = posts.new
    assert_kind_of Post, post
    assert_equal 'You told a lie', post.title
  end

967
  def test_create
968
    birds = Bird.all
969 970 971

    sparrow = birds.create
    assert_kind_of Bird, sparrow
972
    assert !sparrow.persisted?
973 974

    hen = birds.where(:name => 'hen').create
975
    assert hen.persisted?
976 977 978 979
    assert_equal 'hen', hen.name
  end

  def test_create_bang
980
    birds = Bird.all
981 982 983 984 985

    assert_raises(ActiveRecord::RecordInvalid) { birds.create! }

    hen = birds.where(:name => 'hen').create!
    assert_kind_of Bird, hen
986
    assert hen.persisted?
987 988
    assert_equal 'hen', hen.name
  end
P
Pratik Naik 已提交
989

990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064
  def test_first_or_create
    parrot = Bird.where(:color => 'green').first_or_create(:name => 'parrot')
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color

    same_parrot = Bird.where(:color => 'green').first_or_create(:name => 'parakeet')
    assert_kind_of Bird, same_parrot
    assert same_parrot.persisted?
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_with_no_parameters
    parrot = Bird.where(:color => 'green').first_or_create
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert_equal 'green', parrot.color
  end

  def test_first_or_create_with_block
    parrot = Bird.where(:color => 'green').first_or_create { |bird| bird.name = 'parrot' }
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name

    same_parrot = Bird.where(:color => 'green').first_or_create { |bird| bird.name = 'parakeet' }
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_with_array
    several_green_birds = Bird.where(:color => 'green').first_or_create([{:name => 'parrot'}, {:name => 'parakeet'}])
    assert_kind_of Array, several_green_birds
    several_green_birds.each { |bird| assert bird.persisted? }

    same_parrot = Bird.where(:color => 'green').first_or_create([{:name => 'hummingbird'}, {:name => 'macaw'}])
    assert_kind_of Bird, same_parrot
    assert_equal several_green_birds.first, same_parrot
  end

  def test_first_or_create_bang_with_valid_options
    parrot = Bird.where(:color => 'green').first_or_create!(:name => 'parrot')
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color

    same_parrot = Bird.where(:color => 'green').first_or_create!(:name => 'parakeet')
    assert_kind_of Bird, same_parrot
    assert same_parrot.persisted?
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_bang_with_invalid_options
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create!(:pirate_id => 1) }
  end

  def test_first_or_create_bang_with_no_parameters
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create! }
  end

  def test_first_or_create_bang_with_valid_block
    parrot = Bird.where(:color => 'green').first_or_create! { |bird| bird.name = 'parrot' }
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name

    same_parrot = Bird.where(:color => 'green').first_or_create! { |bird| bird.name = 'parakeet' }
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_bang_with_invalid_block
    assert_raise(ActiveRecord::RecordInvalid) do
1065
      Bird.where(:color => 'green').first_or_create! { |bird| bird.pirate_id = 1 }
1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082
    end
  end

  def test_first_or_create_with_valid_array
    several_green_birds = Bird.where(:color => 'green').first_or_create!([{:name => 'parrot'}, {:name => 'parakeet'}])
    assert_kind_of Array, several_green_birds
    several_green_birds.each { |bird| assert bird.persisted? }

    same_parrot = Bird.where(:color => 'green').first_or_create!([{:name => 'hummingbird'}, {:name => 'macaw'}])
    assert_kind_of Bird, same_parrot
    assert_equal several_green_birds.first, same_parrot
  end

  def test_first_or_create_with_invalid_array
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create!([ {:name => 'parrot'}, {:pirate_id => 1} ]) }
  end

1083 1084
  def test_first_or_initialize
    parrot = Bird.where(:color => 'green').first_or_initialize(:name => 'parrot')
1085 1086 1087 1088 1089 1090 1091 1092
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert parrot.valid?
    assert parrot.new_record?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color
  end

1093 1094
  def test_first_or_initialize_with_no_parameters
    parrot = Bird.where(:color => 'green').first_or_initialize
1095 1096 1097 1098 1099 1100 1101
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert !parrot.valid?
    assert parrot.new_record?
    assert_equal 'green', parrot.color
  end

1102 1103
  def test_first_or_initialize_with_block
    parrot = Bird.where(:color => 'green').first_or_initialize { |bird| bird.name = 'parrot' }
1104 1105 1106 1107 1108 1109 1110 1111
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert parrot.valid?
    assert parrot.new_record?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name
  end

1112 1113 1114 1115 1116 1117 1118 1119 1120
  def test_find_or_create_by
    assert_nil Bird.find_by(name: 'bob')

    bird = Bird.find_or_create_by(name: 'bob')
    assert bird.persisted?

    assert_equal bird, Bird.find_or_create_by(name: 'bob')
  end

1121 1122 1123 1124 1125 1126 1127 1128 1129 1130
  def test_find_or_create_by_with_create_with
    assert_nil Bird.find_by(name: 'bob')

    bird = Bird.create_with(color: 'green').find_or_create_by(name: 'bob')
    assert bird.persisted?
    assert_equal 'green', bird.color

    assert_equal bird, Bird.create_with(color: 'blue').find_or_create_by(name: 'bob')
  end

1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144
  def test_find_or_create_by!
    assert_raises(ActiveRecord::RecordInvalid) { Bird.find_or_create_by!(color: 'green') }
  end

  def test_find_or_initialize_by
    assert_nil Bird.find_by(name: 'bob')

    bird = Bird.find_or_initialize_by(name: 'bob')
    assert bird.new_record?
    bird.save!

    assert_equal bird, Bird.find_or_initialize_by(name: 'bob')
  end

1145 1146 1147 1148 1149 1150 1151 1152
  def test_explicit_create_scope
    hens = Bird.where(:name => 'hen')
    assert_equal 'hen', hens.new.name

    hens = hens.create_with(:name => 'cock')
    assert_equal 'cock', hens.new.name
  end

P
Pratik Naik 已提交
1153 1154
  def test_except
    relation = Post.where(:author_id => 1).order('id ASC').limit(1)
1155
    assert_equal [posts(:welcome)], relation.to_a
P
Pratik Naik 已提交
1156 1157

    author_posts = relation.except(:order, :limit)
1158
    assert_equal Post.where(:author_id => 1).to_a, author_posts.to_a
P
Pratik Naik 已提交
1159 1160

    all_posts = relation.except(:where, :order, :limit)
J
Jon Leighton 已提交
1161
    assert_equal Post.all, all_posts
P
Pratik Naik 已提交
1162 1163
  end

E
Emilio Tagua 已提交
1164 1165
  def test_only
    relation = Post.where(:author_id => 1).order('id ASC').limit(1)
1166
    assert_equal [posts(:welcome)], relation.to_a
E
Emilio Tagua 已提交
1167 1168

    author_posts = relation.only(:where)
1169
    assert_equal Post.where(:author_id => 1).to_a, author_posts.to_a
E
Emilio Tagua 已提交
1170 1171

    all_posts = relation.only(:limit)
1172
    assert_equal Post.limit(1).to_a.first, all_posts.first
E
Emilio Tagua 已提交
1173 1174
  end

P
Pratik Naik 已提交
1175
  def test_anonymous_extension
1176
    relation = Post.where(:author_id => 1).order('id ASC').extending do
P
Pratik Naik 已提交
1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190
      def author
        'lifo'
      end
    end

    assert_equal "lifo", relation.author
    assert_equal "lifo", relation.limit(1).author
  end

  def test_named_extension
    relation = Post.where(:author_id => 1).order('id ASC').extending(Post::NamedExtension)
    assert_equal "lifo", relation.author
    assert_equal "lifo", relation.limit(1).author
  end
1191 1192

  def test_order_by_relation_attribute
1193
    assert_equal Post.order(Post.arel_table[:title]).to_a, Post.order("title").to_a
1194
  end
1195

1196
  def test_default_scope_order_with_scope_order
1197 1198
    assert_equal 'zyke', CoolCar.order_using_new_style.limit(1).first.name
    assert_equal 'zyke', FastCar.order_using_new_style.limit(1).first.name
1199 1200 1201
  end

  def test_order_using_scoping
1202
    car1 = CoolCar.order('id DESC').scoping do
1203
      CoolCar.all.merge!(order: 'id asc').first
1204
    end
1205
    assert_equal 'zyke', car1.name
1206 1207

    car2 = FastCar.order('id DESC').scoping do
1208
      FastCar.all.merge!(order: 'id asc').first
1209
    end
1210
    assert_equal 'zyke', car2.name
1211 1212 1213 1214 1215
  end

  def test_unscoped_block_style
    assert_equal 'honda', CoolCar.unscoped { CoolCar.order_using_new_style.limit(1).first.name}
    assert_equal 'honda', FastCar.unscoped { FastCar.order_using_new_style.limit(1).first.name}
1216 1217
  end

1218 1219 1220
  def test_intersection_with_array
    relation = Author.where(:name => "David")
    rails_author = relation.first
1221

1222 1223 1224
    assert_equal [rails_author], [rails_author] & relation
    assert_equal [rails_author], relation & [rails_author]
  end
1225

1226
  def test_primary_key
1227
    assert_equal "id", Post.all.primary_key
1228
  end
1229

1230 1231 1232 1233 1234 1235
  def test_disable_implicit_join_references_is_deprecated
    assert_deprecated do
      ActiveRecord::Base.disable_implicit_join_references = true
    end
  end

1236
  def test_ordering_with_extra_spaces
1237
    assert_equal authors(:david), Author.order('id DESC , name DESC').last
1238
  end
1239

1240 1241 1242 1243
  def test_update_all_with_blank_argument
    assert_raises(ArgumentError) { Comment.update_all({}) }
  end

1244 1245 1246 1247 1248 1249 1250
  def test_update_all_with_joins
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id)
    count    = comments.count

    assert_equal count, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:greetings).post
  end
1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272

  def test_update_all_with_joins_and_limit
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).limit(1)
    assert_equal 1, comments.update_all(:post_id => posts(:thinking).id)
  end

  def test_update_all_with_joins_and_limit_and_order
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).order('comments.id').limit(1)
    assert_equal 1, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:greetings).post
    assert_equal posts(:welcome),  comments(:more_greetings).post
  end

  def test_update_all_with_joins_and_offset
    all_comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id)
    count        = all_comments.count
    comments     = all_comments.offset(1)

    assert_equal count - 1, comments.update_all(:post_id => posts(:thinking).id)
  end

  def test_update_all_with_joins_and_offset_and_order
1273
    all_comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).order('posts.id', 'comments.id')
1274 1275 1276 1277 1278 1279 1280
    count        = all_comments.count
    comments     = all_comments.offset(1)

    assert_equal count - 1, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:more_greetings).post
    assert_equal posts(:welcome),  comments(:greetings).post
  end
1281

1282
  def test_distinct
1283 1284 1285 1286 1287 1288 1289
    tag1 = Tag.create(:name => 'Foo')
    tag2 = Tag.create(:name => 'Foo')

    query = Tag.select(:name).where(:id => [tag1.id, tag2.id])

    assert_equal ['Foo', 'Foo'], query.map(&:name)
    assert_sql(/DISTINCT/) do
1290
      assert_equal ['Foo'], query.distinct.map(&:name)
1291 1292 1293
      assert_equal ['Foo'], query.uniq.map(&:name)
    end
    assert_sql(/DISTINCT/) do
1294
      assert_equal ['Foo'], query.distinct(true).map(&:name)
1295 1296
      assert_equal ['Foo'], query.uniq(true).map(&:name)
    end
1297
    assert_equal ['Foo', 'Foo'], query.distinct(true).distinct(false).map(&:name)
1298 1299
    assert_equal ['Foo', 'Foo'], query.uniq(true).uniq(false).map(&:name)
  end
1300

1301 1302 1303 1304 1305 1306 1307 1308
  def test_doesnt_add_having_values_if_options_are_blank
    scope = Post.having('')
    assert_equal [], scope.having_values

    scope = Post.having([])
    assert_equal [], scope.having_values
  end

1309 1310 1311 1312 1313 1314 1315 1316 1317 1318
  def test_references_triggers_eager_loading
    scope = Post.includes(:comments)
    assert !scope.eager_loading?
    assert scope.references(:comments).eager_loading?
  end

  def test_references_doesnt_trigger_eager_loading_if_reference_not_included
    scope = Post.references(:comments)
    assert !scope.eager_loading?
  end
1319

1320
  def test_automatically_added_where_references
1321
    scope = Post.where(:comments => { :body => "Bla" })
J
Jon Leighton 已提交
1322
    assert_equal ['comments'], scope.references_values
1323 1324

    scope = Post.where('comments.body' => 'Bla')
J
Jon Leighton 已提交
1325
    assert_equal ['comments'], scope.references_values
1326
  end
1327

1328
  def test_automatically_added_having_references
1329
    scope = Post.having(:comments => { :body => "Bla" })
J
Jon Leighton 已提交
1330
    assert_equal ['comments'], scope.references_values
1331 1332

    scope = Post.having('comments.body' => 'Bla')
J
Jon Leighton 已提交
1333
    assert_equal ['comments'], scope.references_values
1334
  end
1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352

  def test_automatically_added_order_references
    scope = Post.order('comments.body')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('comments.body', 'yaks.body')
    assert_equal ['comments', 'yaks'], scope.references_values

    # Don't infer yaks, let's not go down that road again...
    scope = Post.order('comments.body, yaks.body')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('comments.body asc')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('foo(comments.body)')
    assert_equal [], scope.references_values
  end
1353

1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371
  def test_automatically_added_reorder_references
    scope = Post.reorder('comments.body')
    assert_equal %w(comments), scope.references_values

    scope = Post.reorder('comments.body', 'yaks.body')
    assert_equal %w(comments yaks), scope.references_values

    # Don't infer yaks, let's not go down that road again...
    scope = Post.reorder('comments.body, yaks.body')
    assert_equal %w(comments), scope.references_values

    scope = Post.reorder('comments.body asc')
    assert_equal %w(comments), scope.references_values

    scope = Post.reorder('foo(comments.body)')
    assert_equal [], scope.references_values
  end

1372
  def test_presence
1373
    topics = Topic.all
1374

1375
    # the first query is triggered because there are no topics yet.
1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389
    assert_queries(1) { assert topics.present? }

    # checking if there are topics is used before you actually display them,
    # thus it shouldn't invoke an extra count query.
    assert_no_queries { assert topics.present? }
    assert_no_queries { assert !topics.blank? }

    # shows count of topics and loops after loading the query should not trigger extra queries either.
    assert_no_queries { topics.size }
    assert_no_queries { topics.length }
    assert_no_queries { topics.each }

    # count always trigger the COUNT query.
    assert_queries(1) { topics.count }
1390 1391 1392

    assert topics.loaded?
  end
1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406

  test "find_by with hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by(author_id: 2)
  end

  test "find_by with non-hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by("author_id = 2")
  end

  test "find_by with multi-arg conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by('author_id = ?', 2)
  end

  test "find_by returns nil if the record is missing" do
1407
    assert_equal nil, Post.all.find_by("1 = 0")
1408 1409
  end

1410 1411 1412 1413
  test "find_by doesn't have implicit ordering" do
    assert_sql(/^((?!ORDER).)*$/) { Post.find_by(author_id: 2) }
  end

1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425
  test "find_by! with hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by!(author_id: 2)
  end

  test "find_by! with non-hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by!("author_id = 2")
  end

  test "find_by! with multi-arg conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by!('author_id = ?', 2)
  end

1426 1427 1428 1429
  test "find_by! doesn't have implicit ordering" do
    assert_sql(/^((?!ORDER).)*$/) { Post.find_by!(author_id: 2) }
  end

1430 1431
  test "find_by! raises RecordNotFound if the record is missing" do
    assert_raises(ActiveRecord::RecordNotFound) do
1432
      Post.all.find_by!("1 = 0")
1433 1434
    end
  end
1435 1436

  test "loaded relations cannot be mutated by multi value methods" do
1437
    relation = Post.all
1438 1439 1440 1441 1442 1443 1444 1445
    relation.to_a

    assert_raises(ActiveRecord::ImmutableRelation) do
      relation.where! 'foo'
    end
  end

  test "loaded relations cannot be mutated by single value methods" do
1446
    relation = Post.all
1447 1448 1449 1450 1451 1452 1453 1454
    relation.to_a

    assert_raises(ActiveRecord::ImmutableRelation) do
      relation.limit! 5
    end
  end

  test "loaded relations cannot be mutated by merge!" do
1455
    relation = Post.all
1456 1457 1458 1459 1460 1461
    relation.to_a

    assert_raises(ActiveRecord::ImmutableRelation) do
      relation.merge! where: 'foo'
    end
  end
1462

1463 1464 1465 1466 1467 1468 1469 1470 1471
  test "loaded relations cannot be mutated by extending!" do
    relation = Post.all
    relation.to_a

    assert_raises(ActiveRecord::ImmutableRelation) do
      relation.extending! Module.new
    end
  end

1472 1473 1474 1475
  test "relations show the records in #inspect" do
    relation = Post.limit(2)
    assert_equal "#<ActiveRecord::Relation [#{Post.limit(2).map(&:inspect).join(', ')}]>", relation.inspect
  end
1476

1477
  test "relations limit the records in #inspect at 10" do
1478 1479 1480
    relation = Post.limit(11)
    assert_equal "#<ActiveRecord::Relation [#{Post.limit(10).map(&:inspect).join(', ')}, ...]>", relation.inspect
  end
1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491

  test "already-loaded relations don't perform a new query in #inspect" do
    relation = Post.limit(2)
    relation.to_a

    expected = "#<ActiveRecord::Relation [#{Post.limit(2).map(&:inspect).join(', ')}]>"

    assert_no_queries do
      assert_equal expected, relation.inspect
    end
  end
1492 1493 1494 1495 1496 1497 1498 1499 1500 1501

  test 'using a custom table affects the wheres' do
    table_alias = Post.arel_table.alias('omg_posts')

    relation = ActiveRecord::Relation.new Post, table_alias
    relation.where!(:foo => "bar")

    node = relation.arel.constraints.first.grep(Arel::Attributes::Attribute).first
    assert_equal table_alias, node.relation
  end
J
Jon Leighton 已提交
1502 1503 1504 1505 1506 1507 1508 1509

  test '#load' do
    relation = Post.all
    assert_queries(1) do
      assert_equal relation, relation.load
    end
    assert_no_queries { relation.to_a }
  end
1510 1511

  test 'group with select and includes' do
1512 1513
    authors_count = Post.select('author_id, COUNT(author_id) AS num_posts').
      group('author_id').order('author_id').includes(:author).to_a
1514 1515 1516 1517 1518 1519 1520 1521 1522 1523

    assert_no_queries do
      result = authors_count.map do |post|
        [post.num_posts, post.author.try(:name)]
      end

      expected = [[1, nil], [5, "David"], [3, "Mary"], [2, "Bob"]]
      assert_equal expected, result
    end
  end
1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552

  test "delegations do not leak to other classes" do
    Topic.all.by_lifo
    assert Topic.all.class.method_defined?(:by_lifo)
    assert !Post.all.respond_to?(:by_lifo)
  end

  class OMGTopic < ActiveRecord::Base
    self.table_name = 'topics'

    def self.__omg__
      "omgtopic"
    end
  end

  test "delegations do not clash across classes" do
    begin
      class ::Array
        def __omg__
          "array"
        end
      end

      assert_equal "array",    Topic.all.__omg__
      assert_equal "omgtopic", OMGTopic.all.__omg__
    ensure
      Array.send(:remove_method, :__omg__)
    end
  end
1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565

  test "merge collapses wheres from the LHS only" do
    left  = Post.where(title: "omg").where(comments_count: 1)
    right = Post.where(title: "wtf").where(title: "bbq")

    expected = [left.where_values[1]] + right.where_values
    merged   = left.merge(right)

    assert_equal expected, merged.where_values
    assert !merged.to_sql.include?("omg")
    assert merged.to_sql.include?("wtf")
    assert merged.to_sql.include?("bbq")
  end
1566 1567 1568 1569 1570 1571 1572 1573 1574 1575

  def test_merging_removes_rhs_bind_parameters
    left  = Post.where(id: Arel::Nodes::BindParam.new('?'))
    column = Post.columns_hash['id']
    left.bind_values += [[column, 20]]
    right   = Post.where(id: 10)

    merged = left.merge(right)
    assert_equal [], merged.bind_values
  end
1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587

  def test_merging_keeps_lhs_bind_parameters
    column = Post.columns_hash['id']
    binds = [[column, 20]]

    right  = Post.where(id: Arel::Nodes::BindParam.new('?'))
    right.bind_values += binds
    left   = Post.where(id: 10)

    merged = left.merge(right)
    assert_equal binds, merged.bind_values
  end
1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604

  def test_merging_reorders_bind_params
    post         = Post.first
    id_column    = Post.columns_hash['id']
    title_column = Post.columns_hash['title']

    bv = Post.connection.substitute_at id_column, 0

    right  = Post.where(id: bv)
    right.bind_values += [[id_column, post.id]]

    left   = Post.where(title: bv)
    left.bind_values += [[title_column, post.title]]

    merged = left.merge(right)
    assert_equal post, merged.first
  end
P
Pratik Naik 已提交
1605
end