relations_test.rb 46.4 KB
Newer Older
1
require "cases/helper"
2
require 'models/tag'
3
require 'models/tagging'
4 5
require 'models/post'
require 'models/topic'
6
require 'models/comment'
7 8 9
require 'models/author'
require 'models/entrant'
require 'models/developer'
10
require 'models/reply'
11
require 'models/company'
12
require 'models/bird'
13 14 15
require 'models/car'
require 'models/engine'
require 'models/tyre'
16
require 'models/minivan'
17

18

E
Emilio Tagua 已提交
19
class RelationTest < ActiveRecord::TestCase
20
  fixtures :authors, :topics, :entrants, :developers, :companies, :developers_projects, :accounts, :categories, :categorizations, :posts, :comments,
21 22 23 24 25 26 27
    :tags, :taggings, :cars, :minivans

  def test_do_not_double_quote_string_id
    van = Minivan.last
    assert van
    assert_equal van.id, Minivan.where(:minivan_id => van).to_a.first.minivan_id
  end
28

29 30 31 32 33 34
  def test_do_not_double_quote_string_id_with_array
    van = Minivan.last
    assert van
    assert_equal van, Minivan.where(:minivan_id => [van]).to_a.first
  end

A
Aaron Patterson 已提交
35
  def test_bind_values
36
    relation = Post.all
A
Aaron Patterson 已提交
37 38 39 40 41 42 43
    assert_equal [], relation.bind_values

    relation2 = relation.bind 'foo'
    assert_equal %w{ foo }, relation2.bind_values
    assert_equal [], relation.bind_values
  end

44
  def test_two_scopes_with_includes_should_not_drop_any_include
45 46 47 48 49
    # heat habtm cache
    car = Car.incl_engines.incl_tyres.first
    car.tyres.length
    car.engines.length

50
    car = Car.incl_engines.incl_tyres.first
51 52
    assert_no_queries { car.tyres.length }
    assert_no_queries { car.engines.length }
53
  end
54

55 56 57 58 59
  def test_dynamic_finder
    x = Post.where('author_id = ?', 1)
    assert x.klass.respond_to?(:find_by_id), '@klass should handle dynamic finders'
  end

60 61 62 63 64
  def test_multivalue_where
    posts = Post.where('author_id = ? AND id = ?', 1, 1)
    assert_equal 1, posts.to_a.size
  end

65
  def test_scoped
66
    topics = Topic.all
67 68 69 70
    assert_kind_of ActiveRecord::Relation, topics
    assert_equal 4, topics.size
  end

71
  def test_to_json
72 73
    assert_nothing_raised  { Bird.all.to_json }
    assert_nothing_raised  { Bird.all.to_a.to_json }
74 75 76
  end

  def test_to_yaml
77 78
    assert_nothing_raised  { Bird.all.to_yaml }
    assert_nothing_raised  { Bird.all.to_a.to_yaml }
79 80
  end

81
  def test_to_xml
82 83
    assert_nothing_raised  { Bird.all.to_xml }
    assert_nothing_raised  { Bird.all.to_a.to_xml }
84 85
  end

86
  def test_scoped_all
87
    topics = Topic.all.to_a
88 89 90 91
    assert_kind_of Array, topics
    assert_no_queries { assert_equal 4, topics.size }
  end

P
Pratik Naik 已提交
92
  def test_loaded_all
93
    topics = Topic.all
P
Pratik Naik 已提交
94 95

    assert_queries(1) do
96
      2.times { assert_equal 4, topics.to_a.size }
P
Pratik Naik 已提交
97 98 99 100 101 102
    end

    assert topics.loaded?
  end

  def test_scoped_first
103
    topics = Topic.all.order('id ASC')
P
Pratik Naik 已提交
104 105 106 107 108 109 110 111 112

    assert_queries(1) do
      2.times { assert_equal "The First Topic", topics.first.title }
    end

    assert ! topics.loaded?
  end

  def test_loaded_first
113
    topics = Topic.all.order('id ASC')
P
Pratik Naik 已提交
114 115

    assert_queries(1) do
116
      topics.to_a # force load
P
Pratik Naik 已提交
117 118 119 120 121 122
      2.times { assert_equal "The First Topic", topics.first.title }
    end

    assert topics.loaded?
  end

123
  def test_reload
124
    topics = Topic.all
125 126 127 128 129 130 131

    assert_queries(1) do
      2.times { topics.to_a }
    end

    assert topics.loaded?

132 133
    original_size = topics.to_a.size
    Topic.create! :title => 'fake'
134

135 136 137
    assert_queries(1) { topics.reload }
    assert_equal original_size + 1, topics.size
    assert topics.loaded?
138 139
  end

I
Ivan Kukobko 已提交
140
  def test_finding_with_subquery
141 142 143 144 145 146
    relation = Topic.where(:approved => true)
    assert_equal relation.to_a, Topic.select('*').from(relation).to_a
    assert_equal relation.to_a, Topic.select('subquery.*').from(relation).to_a
    assert_equal relation.to_a, Topic.select('a.*').from(relation, :a).to_a
  end

147 148 149 150 151 152 153
  def test_finding_with_subquery_with_binds
    relation = Post.first.comments
    assert_equal relation.to_a, Comment.select('*').from(relation).to_a
    assert_equal relation.to_a, Comment.select('subquery.*').from(relation).to_a
    assert_equal relation.to_a, Comment.select('a.*').from(relation, :a).to_a
  end

154
  def test_finding_with_conditions
155 156
    assert_equal ["David"], Author.where(:name => 'David').map(&:name)
    assert_equal ['Mary'],  Author.where(["name = ?", 'Mary']).map(&:name)
157
    assert_equal ['Mary'],  Author.where("name = ?", 'Mary').map(&:name)
158 159 160
  end

  def test_finding_with_order
161
    topics = Topic.order('id')
162
    assert_equal 4, topics.to_a.size
163 164 165
    assert_equal topics(:first).title, topics.first.title
  end

166 167 168 169 170 171

  def test_finding_with_arel_order
    topics = Topic.order(Topic.arel_table[:id].asc)
    assert_equal 4, topics.to_a.size
    assert_equal topics(:first).title, topics.first.title
  end
172

173 174 175 176 177
  def test_finding_with_assoc_order
    topics = Topic.order(:id => :desc)
    assert_equal 4, topics.to_a.size
    assert_equal topics(:fourth).title, topics.first.title
  end
178

179 180 181 182 183
  def test_finding_with_reverted_assoc_order
    topics = Topic.order(:id => :asc).reverse_order
    assert_equal 4, topics.to_a.size
    assert_equal topics(:fourth).title, topics.first.title
  end
184

Y
Yves Senn 已提交
185 186 187 188
  def test_order_with_hash_and_symbol_generates_the_same_sql
    assert_equal Topic.order(:id).to_sql, Topic.order(:id => :asc).to_sql
  end

189 190 191
  def test_raising_exception_on_invalid_hash_params
    assert_raise(ArgumentError) { Topic.order(:name, "id DESC", :id => :DeSc) }
  end
192 193 194 195 196 197

  def test_finding_last_with_arel_order
    topics = Topic.order(Topic.arel_table[:id].asc)
    assert_equal topics(:fourth).title, topics.last.title
  end

198
  def test_finding_with_order_concatenated
199
    topics = Topic.order('author_name').order('title')
200 201 202 203
    assert_equal 4, topics.to_a.size
    assert_equal topics(:fourth).title, topics.first.title
  end

S
Sebastian Martinez 已提交
204
  def test_finding_with_reorder
205
    topics = Topic.order('author_name').order('title').reorder('id').to_a
S
Sebastian Martinez 已提交
206 207 208
    topics_titles = topics.map{ |t| t.title }
    assert_equal ['The First Topic', 'The Second Topic of the day', 'The Third Topic of the day', 'The Fourth Topic of the day'], topics_titles
  end
209

210
  def test_finding_with_order_and_take
211
    entrants = Entrant.order("id ASC").limit(2).to_a
212

P
Pratik Naik 已提交
213 214
    assert_equal 2, entrants.size
    assert_equal entrants(:first).name, entrants.first.name
215 216
  end

217
  def test_finding_with_cross_table_order_and_limit
218
    tags = Tag.includes(:taggings).
219 220
              order("tags.name asc", "taggings.taggable_id asc", "REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").
              limit(1).to_a
221 222 223
    assert_equal 1, tags.length
  end

224
  def test_finding_with_complex_order_and_limit
225
    tags = Tag.includes(:taggings).references(:taggings).order("REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").limit(1).to_a
226 227 228 229
    assert_equal 1, tags.length
  end

  def test_finding_with_complex_order
230
    tags = Tag.includes(:taggings).references(:taggings).order("REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").to_a
231
    assert_equal 3, tags.length
232 233
  end

234
  def test_finding_with_order_limit_and_offset
235
    entrants = Entrant.order("id ASC").limit(2).offset(1)
236

237
    assert_equal 2, entrants.to_a.size
P
Pratik Naik 已提交
238
    assert_equal entrants(:second).name, entrants.first.name
239

240
    entrants = Entrant.order("id ASC").limit(2).offset(2)
241
    assert_equal 1, entrants.to_a.size
P
Pratik Naik 已提交
242
    assert_equal entrants(:third).name, entrants.first.name
243 244 245
  end

  def test_finding_with_group
246
    developers = Developer.group("salary").select("salary").to_a
247 248 249 250
    assert_equal 4, developers.size
    assert_equal 4, developers.map(&:salary).uniq.size
  end

251
  def test_select_with_block
252
    even_ids = Developer.all.select {|d| d.id % 2 == 0 }.map(&:id)
253
    assert_equal [2, 4, 6, 8, 10], even_ids.sort
254 255
  end

256 257 258
  def test_none
    assert_no_queries do
      assert_equal [], Developer.none
259
      assert_equal [], Developer.all.none
260 261 262 263 264 265 266 267 268
    end
  end

  def test_none_chainable
    assert_no_queries do
      assert_equal [], Developer.none.where(:name => 'David')
    end
  end

A
Akira Matsuda 已提交
269 270 271 272 273 274
  def test_none_chainable_to_existing_scope_extension_method
    assert_no_queries do
      assert_equal 1, Topic.anonymous_extension.none.one
    end
  end

275 276
  def test_none_chained_to_methods_firing_queries_straight_to_db
    assert_no_queries do
277
      assert_equal [],    Developer.none.pluck(:id, :name)
278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296
      assert_equal 0,     Developer.none.delete_all
      assert_equal 0,     Developer.none.update_all(:name => 'David')
      assert_equal 0,     Developer.none.delete(1)
      assert_equal false, Developer.none.exists?(1)
    end
  end

  def test_null_relation_content_size_methods
    assert_no_queries do
      assert_equal 0,     Developer.none.size
      assert_equal 0,     Developer.none.count
      assert_equal true,  Developer.none.empty?
      assert_equal false, Developer.none.any?
      assert_equal false, Developer.none.many?
    end
  end

  def test_null_relation_calculations_methods
    assert_no_queries do
297
      assert_equal 0, Developer.none.count
298
      assert_equal 0, Developer.none.calculate(:count, nil, {})
299
      assert_equal nil, Developer.none.calculate(:average, 'salary')
300 301
    end
  end
302

303 304 305 306 307
  def test_null_relation_metadata_methods
    assert_equal "", Developer.none.to_sql
    assert_equal({}, Developer.none.where_values_hash)
  end

308 309 310 311
  def test_null_relation_where_values_hash
    assert_equal({ 'salary' => 100_000 }, Developer.none.where(salary: 100_000).where_values_hash)
  end

312 313 314 315
  def test_joins_with_nil_argument
    assert_nothing_raised { DependentFirm.joins(nil).first }
  end

316
  def test_finding_with_hash_conditions_on_joined_table
317
    firms = DependentFirm.joins(:account).where({:name => 'RailsCore', :accounts => { :credit_limit => 55..60 }}).to_a
318 319 320 321 322
    assert_equal 1, firms.size
    assert_equal companies(:rails_core), firms.first
  end

  def test_find_all_with_join
323
    developers_on_project_one = Developer.joins('LEFT JOIN developers_projects ON developers.id = developers_projects.developer_id').
324
      where('project_id=1').to_a
325 326 327 328 329 330 331 332

    assert_equal 3, developers_on_project_one.length
    developer_names = developers_on_project_one.map { |d| d.name }
    assert developer_names.include?('David')
    assert developer_names.include?('Jamis')
  end

  def test_find_on_hash_conditions
333
    assert_equal Topic.all.merge!(:where => {:approved => false}).to_a, Topic.where({ :approved => false }).to_a
334 335 336
  end

  def test_joins_with_string_array
337
    person_with_reader_and_post = Post.joins([
338 339 340 341 342 343
        "INNER JOIN categorizations ON categorizations.post_id = posts.id",
        "INNER JOIN categories ON categories.id = categorizations.category_id AND categories.type = 'SpecialCategory'"
      ]
    ).to_a
    assert_equal 1, person_with_reader_and_post.size
  end
344

345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360
  def test_no_arguments_to_query_methods_raise_errors
    assert_raises(ArgumentError) { Topic.references() }
    assert_raises(ArgumentError) { Topic.includes() }
    assert_raises(ArgumentError) { Topic.preload() }
    assert_raises(ArgumentError) { Topic.group() }
    assert_raises(ArgumentError) { Topic.reorder() }
  end

  def test_blank_like_arguments_to_query_methods_dont_raise_errors
    assert_nothing_raised { Topic.references([]) }
    assert_nothing_raised { Topic.includes([]) }
    assert_nothing_raised { Topic.preload([]) }
    assert_nothing_raised { Topic.group([]) }
    assert_nothing_raised { Topic.reorder([]) }
  end

361
  def test_scoped_responds_to_delegated_methods
362
    relation = Topic.all
363 364

    ["map", "uniq", "sort", "insert", "delete", "update"].each do |method|
365
      assert_respond_to relation, method, "Topic.all should respond to #{method.inspect}"
366 367 368
    end
  end

369
  def test_respond_to_delegates_to_relation
370
    relation = Topic.all
371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387
    fake_arel = Struct.new(:responds) {
      def respond_to? method, access = false
        responds << [method, access]
      end
    }.new []

    relation.extend(Module.new { attr_accessor :arel })
    relation.arel = fake_arel

    relation.respond_to?(:matching_attributes)
    assert_equal [:matching_attributes, false], fake_arel.responds.first

    fake_arel.responds = []
    relation.respond_to?(:matching_attributes, true)
    assert_equal [:matching_attributes, true], fake_arel.responds.first
  end

388
  def test_respond_to_dynamic_finders
389
    relation = Topic.all
390

391
    ["find_by_title", "find_by_title_and_author_name"].each do |method|
392
      assert_respond_to relation, method, "Topic.all should respond to #{method.inspect}"
393 394
    end
  end
395

396
  def test_respond_to_class_methods_and_scopes
397
    assert Topic.all.respond_to?(:by_lifo)
398 399
  end

400
  def test_find_with_readonly_option
401 402
    Developer.all.each { |d| assert !d.readonly? }
    Developer.all.readonly.each { |d| assert d.readonly? }
403
  end
404 405

  def test_eager_association_loading_of_stis_with_multiple_references
406
    authors = Author.eager_load(:posts => { :special_comments => { :post => [ :special_comments, :very_special_comment ] } }).
407
      order('comments.body, very_special_comments_posts.body').where('posts.id = 4').to_a
408

409 410 411 412 413 414 415
    assert_equal [authors(:david)], authors
    assert_no_queries do
      authors.first.posts.first.special_comments.first.post.special_comments
      authors.first.posts.first.special_comments.first.post.very_special_comment
    end
  end

416
  def test_find_with_preloaded_associations
417
    assert_queries(2) do
418
      posts = Post.preload(:comments).order('posts.id')
419
      assert posts.first.comments.first
420
    end
421

C
Carlos Antonio da Silva 已提交
422
    assert_queries(2) do
423
      posts = Post.preload(:comments).order('posts.id')
424
      assert posts.first.comments.first
425
    end
426

427
    assert_queries(2) do
428
      posts = Post.preload(:author).order('posts.id')
429
      assert posts.first.author
430
    end
431

C
Carlos Antonio da Silva 已提交
432
    assert_queries(2) do
433
      posts = Post.preload(:author).order('posts.id')
434 435 436
      assert posts.first.author
    end

C
Carlos Antonio da Silva 已提交
437
    assert_queries(3) do
438
      posts = Post.preload(:author, :comments).order('posts.id')
439
      assert posts.first.author
440 441 442 443
      assert posts.first.comments.first
    end
  end

444 445 446 447 448 449 450
  def test_preload_applies_to_all_chained_preloaded_scopes
    assert_queries(3) do
      post = Post.with_comments.with_tags.first
      assert post
    end
  end

451 452
  def test_find_with_included_associations
    assert_queries(2) do
453
      posts = Post.includes(:comments).order('posts.id')
454 455 456
      assert posts.first.comments.first
    end

C
Carlos Antonio da Silva 已提交
457
    assert_queries(2) do
458
      posts = Post.all.includes(:comments).order('posts.id')
459 460 461 462
      assert posts.first.comments.first
    end

    assert_queries(2) do
463
      posts = Post.includes(:author).order('posts.id')
464 465 466
      assert posts.first.author
    end

C
Carlos Antonio da Silva 已提交
467
    assert_queries(3) do
468
      posts = Post.includes(:author, :comments).order('posts.id')
469
      assert posts.first.author
470
      assert posts.first.comments.first
471 472
    end
  end
473

P
Pratik Naik 已提交
474
  def test_default_scope_with_conditions_string
475
    assert_equal Developer.where(name: 'David').map(&:id).sort, DeveloperCalledDavid.all.map(&:id).sort
476
    assert_nil DeveloperCalledDavid.create!.name
477 478 479
  end

  def test_default_scope_with_conditions_hash
480
    assert_equal Developer.where(name: 'Jamis').map(&:id).sort, DeveloperCalledJamis.all.map(&:id).sort
481 482 483
    assert_equal 'Jamis', DeveloperCalledJamis.create!.name
  end

484 485
  def test_default_scoping_finder_methods
    developers = DeveloperCalledDavid.order('id').map(&:id).sort
J
Jon Leighton 已提交
486
    assert_equal Developer.where(name: 'David').map(&:id).sort, developers
487 488
  end

489 490 491 492 493 494 495 496
  def test_includes_with_select
    query = Post.select('comments_count AS ranking').order('ranking').includes(:comments)
      .where(comments: { id: 1 })

    assert_equal ['comments_count AS ranking'], query.select_values
    assert_equal 1, query.to_a.size
  end

497 498
  def test_loading_with_one_association
    posts = Post.preload(:comments)
499 500 501 502
    post = posts.find { |p| p.id == 1 }
    assert_equal 2, post.comments.size
    assert post.comments.include?(comments(:greetings))

503
    post = Post.where("posts.title = 'Welcome to the weblog'").preload(:comments).first
504 505 506
    assert_equal 2, post.comments.size
    assert post.comments.include?(comments(:greetings))

507
    posts = Post.preload(:last_comment)
508 509 510 511
    post = posts.find { |p| p.id == 1 }
    assert_equal Post.find(1).last_comment, post.last_comment
  end

512 513 514 515 516 517 518 519
  def test_to_sql_on_eager_join
    expected = assert_sql {
      Post.eager_load(:last_comment).order('comments.id DESC').to_a
    }.first
    actual = Post.eager_load(:last_comment).order('comments.id DESC').to_sql
    assert_equal expected, actual
  end

520
  def test_loading_with_one_association_with_non_preload
521
    posts = Post.eager_load(:last_comment).order('comments.id DESC')
522 523 524
    post = posts.find { |p| p.id == 1 }
    assert_equal Post.find(1).last_comment, post.last_comment
  end
525 526 527 528 529 530 531

  def test_dynamic_find_by_attributes
    david = authors(:david)
    author = Author.preload(:taggings).find_by_id(david.id)
    expected_taggings = taggings(:welcome_general, :thinking_general)

    assert_no_queries do
532
      assert_equal expected_taggings, author.taggings.distinct.sort_by { |t| t.id }
533 534 535
      assert_equal expected_taggings, author.taggings.uniq.sort_by { |t| t.id }
    end

536
    authors = Author.all
537 538 539 540 541
    assert_equal david, authors.find_by_id_and_name(david.id, david.name)
    assert_equal david, authors.find_by_id_and_name!(david.id, david.name)
  end

  def test_dynamic_find_by_attributes_bang
542
    author = Author.all.find_by_id!(authors(:david).id)
543 544
    assert_equal "David", author.name

545
    assert_raises(ActiveRecord::RecordNotFound) { Author.all.find_by_id_and_name!(20, 'invalid') }
546 547
  end

P
Pratik Naik 已提交
548
  def test_find_id
549
    authors = Author.all
P
Pratik Naik 已提交
550 551 552 553

    david = authors.find(authors(:david).id)
    assert_equal 'David', david.name

P
Pratik Naik 已提交
554
    assert_raises(ActiveRecord::RecordNotFound) { authors.where(:name => 'lifo').find('42') }
P
Pratik Naik 已提交
555
  end
556

P
Pratik Naik 已提交
557 558 559 560 561 562 563 564 565 566
  def test_find_ids
    authors = Author.order('id ASC')

    results = authors.find(authors(:david).id, authors(:mary).id)
    assert_kind_of Array, results
    assert_equal 2, results.size
    assert_equal 'David', results[0].name
    assert_equal 'Mary', results[1].name
    assert_equal results, authors.find([authors(:david).id, authors(:mary).id])

P
Pratik Naik 已提交
567 568
    assert_raises(ActiveRecord::RecordNotFound) { authors.where(:name => 'lifo').find(authors(:david).id, '42') }
    assert_raises(ActiveRecord::RecordNotFound) { authors.find(['42', 43]) }
P
Pratik Naik 已提交
569 570
  end

571
  def test_find_in_empty_array
572 573
    authors = Author.all.where(:id => [])
    assert authors.to_a.blank?
574 575
  end

576 577
  def test_where_with_ar_object
    author = Author.first
578
    authors = Author.all.where(:id => author)
579
    assert_equal 1, authors.to_a.length
580 581
  end

582 583 584 585 586 587
  def test_find_with_list_of_ar
    author = Author.first
    authors = Author.find([author])
    assert_equal author, authors.first
  end

588 589 590 591 592 593 594
  class Mary < Author; end

  def test_find_by_classname
    Author.create!(:name => Mary.name)
    assert_equal 1, Author.where(:name => Mary).size
  end

595 596 597 598 599 600
  def test_find_by_id_with_list_of_ar
    author = Author.first
    authors = Author.find_by_id([author])
    assert_equal author, authors
  end

601 602 603 604 605 606
  def test_find_all_using_where_twice_should_or_the_relation
    david = authors(:david)
    relation = Author.unscoped
    relation = relation.where(:name => david.name)
    relation = relation.where(:name => 'Santiago')
    relation = relation.where(:id => david.id)
607
    assert_equal [], relation.to_a
608 609
  end

A
Aaron Patterson 已提交
610 611 612 613 614 615 616 617
  def test_multi_where_ands_queries
    relation = Author.unscoped
    david = authors(:david)
    sql = relation.where(:name => david.name).where(:name => 'Santiago').to_sql
    assert_match('AND', sql)
  end

  def test_find_all_with_multiple_should_use_and
A
Aaron Patterson 已提交
618 619 620 621 622 623 624 625
    david = authors(:david)
    relation = [
      { :name => david.name },
      { :name => 'Santiago' },
      { :name => 'tenderlove' },
    ].inject(Author.unscoped) do |memo, param|
      memo.where(param)
    end
626
    assert_equal [], relation.to_a
A
Aaron Patterson 已提交
627
  end
A
Aaron Patterson 已提交
628

629 630 631 632 633 634
  def test_find_all_using_where_with_relation
    david = authors(:david)
    # switching the lines below would succeed in current rails
    # assert_queries(2) {
    assert_queries(1) {
      relation = Author.where(:id => Author.where(:id => david.id))
635
      assert_equal [david], relation.to_a
636
    }
637 638 639 640 641

    assert_queries(1) {
      relation = Author.where('id in (?)', Author.where(id: david).select(:id))
      assert_equal [david], relation.to_a
    }
642 643 644 645 646 647 648 649 650

    assert_queries(1) do
      relation = Author.where('id in (:author_ids)', author_ids: Author.where(id: david).select(:id))
      assert_equal [david], relation.to_a
    end
  end

  def test_find_all_using_where_with_relation_with_bound_values
    david = authors(:david)
651
    davids_posts = david.posts.order(:id).to_a
652 653 654

    assert_queries(1) do
      relation = Post.where(id: david.posts.select(:id))
655
      assert_equal davids_posts, relation.order(:id).to_a
656 657 658 659
    end

    assert_queries(1) do
      relation = Post.where('id in (?)', david.posts.select(:id))
660
      assert_equal davids_posts, relation.order(:id).to_a, 'should process Relation as bind variables'
661 662 663 664
    end

    assert_queries(1) do
      relation = Post.where('id in (:post_ids)', post_ids: david.posts.select(:id))
665
      assert_equal davids_posts, relation.order(:id).to_a, 'should process Relation as named bind variables'
666
    end
667 668
  end

669 670 671 672 673 674
  def test_find_all_using_where_with_relation_and_alternate_primary_key
    cool_first = minivans(:cool_first)
    # switching the lines below would succeed in current rails
    # assert_queries(2) {
    assert_queries(1) {
      relation = Minivan.where(:minivan_id => Minivan.where(:name => cool_first.name))
675
      assert_equal [cool_first], relation.to_a
676 677 678
    }
  end

679 680 681 682 683 684 685
  def test_find_all_using_where_with_relation_does_not_alter_select_values
    david = authors(:david)

    subquery = Author.where(:id => david.id)

    assert_queries(1) {
      relation = Author.where(:id => subquery)
686
      assert_equal [david], relation.to_a
687 688 689 690 691
    }

    assert_equal 0, subquery.select_values.size
  end

692 693 694 695
  def test_find_all_using_where_with_relation_with_joins
    david = authors(:david)
    assert_queries(1) {
      relation = Author.where(:id => Author.joins(:posts).where(:id => david.id))
696
      assert_equal [david], relation.to_a
697 698 699
    }
  end

A
Aaron Patterson 已提交
700

701 702 703 704
  def test_find_all_using_where_with_relation_with_select_to_build_subquery
    david = authors(:david)
    assert_queries(1) {
      relation = Author.where(:name => Author.where(:id => david.id).select(:name))
705
      assert_equal [david], relation.to_a
706
    }
A
Aaron Patterson 已提交
707 708
  end

P
Pratik Naik 已提交
709 710 711 712 713
  def test_exists
    davids = Author.where(:name => 'David')
    assert davids.exists?
    assert davids.exists?(authors(:david).id)
    assert ! davids.exists?(authors(:mary).id)
P
Pratik Naik 已提交
714 715
    assert ! davids.exists?("42")
    assert ! davids.exists?(42)
716
    assert ! davids.exists?(davids.new)
P
Pratik Naik 已提交
717 718 719 720 721

    fake  = Author.where(:name => 'fake author')
    assert ! fake.exists?
    assert ! fake.exists?(authors(:david).id)
  end
722 723

  def test_last
724
    authors = Author.all
725
    assert_equal authors(:bob), authors.last
726 727
  end

P
Pratik Naik 已提交
728 729 730 731 732 733 734 735 736 737 738 739 740
  def test_destroy_all
    davids = Author.where(:name => 'David')

    # Force load
    assert_equal [authors(:david)], davids.to_a
    assert davids.loaded?

    assert_difference('Author.count', -1) { davids.destroy_all }

    assert_equal [], davids.to_a
    assert davids.loaded?
  end

P
Pratik Naik 已提交
741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760
  def test_delete_all
    davids = Author.where(:name => 'David')

    assert_difference('Author.count', -1) { davids.delete_all }
    assert ! davids.loaded?
  end

  def test_delete_all_loaded
    davids = Author.where(:name => 'David')

    # Force load
    assert_equal [authors(:david)], davids.to_a
    assert davids.loaded?

    assert_difference('Author.count', -1) { davids.delete_all }

    assert_equal [], davids.to_a
    assert davids.loaded?
  end

761 762 763 764
  def test_delete_all_limit_error
    assert_raises(ActiveRecord::ActiveRecordError) { Author.limit(10).delete_all }
  end

765 766 767 768 769 770 771 772
  def test_select_takes_a_variable_list_of_args
    david = developers(:david)

    developer = Developer.where(id: david.id).select(:name, :salary).first
    assert_equal david.name, developer.name
    assert_equal david.salary, developer.salary
  end

773 774 775 776
  def test_select_argument_error
    assert_raises(ArgumentError) { Developer.select }
  end

P
Pratik Naik 已提交
777
  def test_count
778
    posts = Post.all
P
Pratik Naik 已提交
779

780 781 782
    assert_equal 11, posts.count
    assert_equal 11, posts.count(:all)
    assert_equal 11, posts.count(:id)
P
Pratik Naik 已提交
783 784

    assert_equal 1, posts.where('comments_count > 1').count
785
    assert_equal 9, posts.where(:comments_count => 0).count
P
Pratik Naik 已提交
786 787 788
  end

  def test_count_with_distinct
789
    posts = Post.all
P
Pratik Naik 已提交
790

791 792
    assert_equal 3, posts.distinct(true).count(:comments_count)
    assert_equal 11, posts.distinct(false).count(:comments_count)
P
Pratik Naik 已提交
793

794 795
    assert_equal 3, posts.distinct(true).select(:comments_count).count
    assert_equal 11, posts.distinct(false).select(:comments_count).count
P
Pratik Naik 已提交
796 797 798 799
  end

  def test_count_explicit_columns
    Post.update_all(:comments_count => nil)
800
    posts = Post.all
P
Pratik Naik 已提交
801

P
Pratik Naik 已提交
802
    assert_equal [0], posts.select('comments_count').where('id is not null').group('id').order('id').count.values.uniq
803
    assert_equal 0, posts.where('id is not null').select('comments_count').count
804

805
    assert_equal 11, posts.select('comments_count').count('id')
P
Pratik Naik 已提交
806 807 808 809
    assert_equal 0, posts.select('comments_count').count
    assert_equal 0, posts.count(:comments_count)
    assert_equal 0, posts.count('comments_count')
  end
810

811
  def test_multiple_selects
812
    post = Post.all.select('comments_count').select('title').order("id ASC").first
813 814 815 816
    assert_equal "Welcome to the weblog", post.title
    assert_equal 2, post.comments_count
  end

817
  def test_size
818
    posts = Post.all
819

820
    assert_queries(1) { assert_equal 11, posts.size }
821 822 823 824
    assert ! posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
825
    assert_no_queries { assert_equal 9, best_posts.size }
826 827
  end

828
  def test_size_with_limit
829
    posts = Post.limit(10)
830

831
    assert_queries(1) { assert_equal 10, posts.size }
832 833 834 835
    assert ! posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
836
    assert_no_queries { assert_equal 9, best_posts.size }
837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855
  end

  def test_size_with_zero_limit
    posts = Post.limit(0)

    assert_no_queries { assert_equal 0, posts.size }
    assert ! posts.loaded?

    posts.to_a # force load
    assert_no_queries { assert_equal 0, posts.size }
  end

  def test_empty_with_zero_limit
    posts = Post.limit(0)

    assert_no_queries { assert_equal true, posts.empty? }
    assert ! posts.loaded?
  end

856 857 858 859 860 861 862
  def test_count_complex_chained_relations
    posts = Post.select('comments_count').where('id is not null').group("author_id").where("comments_count > 0")

    expected = { 1 => 2 }
    assert_equal expected, posts.count
  end

863
  def test_empty
864
    posts = Post.all
865 866 867 868 869 870 871 872 873 874 875 876 877 878 879

    assert_queries(1) { assert_equal false, posts.empty? }
    assert ! posts.loaded?

    no_posts = posts.where(:title => "")
    assert_queries(1) { assert_equal true, no_posts.empty? }
    assert ! no_posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
    assert_no_queries { assert_equal false, best_posts.empty? }
  end

  def test_empty_complex_chained_relations
    posts = Post.select("comments_count").where("id is not null").group("author_id").where("comments_count > 0")
A
Andrew White 已提交
880

881 882 883 884 885 886 887 888
    assert_queries(1) { assert_equal false, posts.empty? }
    assert ! posts.loaded?

    no_posts = posts.where(:title => "")
    assert_queries(1) { assert_equal true, no_posts.empty? }
    assert ! no_posts.loaded?
  end

P
Pratik Naik 已提交
889
  def test_any
890
    posts = Post.all
P
Pratik Naik 已提交
891

892 893 894 895 896 897 898 899
    # This test was failing when run on its own (as opposed to running the entire suite).
    # The second line in the assert_queries block was causing visit_Arel_Attributes_Attribute
    # in Arel::Visitors::ToSql to trigger a SHOW TABLES query. Running that line here causes
    # the SHOW TABLES result to be cached so we don't have to do it again in the block.
    #
    # This is obviously a rubbish fix but it's the best I can come up with for now...
    posts.where(:id => nil).any?

P
Pratik Naik 已提交
900 901 902 903 904 905 906 907 908 909 910 911
    assert_queries(3) do
      assert posts.any? # Uses COUNT()
      assert ! posts.where(:id => nil).any?

      assert posts.any? {|p| p.id > 0 }
      assert ! posts.any? {|p| p.id <= 0 }
    end

    assert posts.loaded?
  end

  def test_many
912
    posts = Post.all
913

P
Pratik Naik 已提交
914 915 916 917 918
    assert_queries(2) do
      assert posts.many? # Uses COUNT()
      assert posts.many? {|p| p.id > 0 }
      assert ! posts.many? {|p| p.id < 2 }
    end
919

P
Pratik Naik 已提交
920 921 922
    assert posts.loaded?
  end

923
  def test_many_with_limits
924
    posts = Post.all
925 926 927 928

    assert posts.many?
    assert ! posts.limit(1).many?
  end
P
Pratik Naik 已提交
929 930

  def test_build
931
    posts = Post.all
P
Pratik Naik 已提交
932 933 934 935 936 937 938 939 940 941 942 943 944

    post = posts.new
    assert_kind_of Post, post
  end

  def test_scoped_build
    posts = Post.where(:title => 'You told a lie')

    post = posts.new
    assert_kind_of Post, post
    assert_equal 'You told a lie', post.title
  end

945
  def test_create
946
    birds = Bird.all
947 948 949

    sparrow = birds.create
    assert_kind_of Bird, sparrow
950
    assert !sparrow.persisted?
951 952

    hen = birds.where(:name => 'hen').create
953
    assert hen.persisted?
954 955 956 957
    assert_equal 'hen', hen.name
  end

  def test_create_bang
958
    birds = Bird.all
959 960 961 962 963

    assert_raises(ActiveRecord::RecordInvalid) { birds.create! }

    hen = birds.where(:name => 'hen').create!
    assert_kind_of Bird, hen
964
    assert hen.persisted?
965 966
    assert_equal 'hen', hen.name
  end
P
Pratik Naik 已提交
967

968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042
  def test_first_or_create
    parrot = Bird.where(:color => 'green').first_or_create(:name => 'parrot')
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color

    same_parrot = Bird.where(:color => 'green').first_or_create(:name => 'parakeet')
    assert_kind_of Bird, same_parrot
    assert same_parrot.persisted?
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_with_no_parameters
    parrot = Bird.where(:color => 'green').first_or_create
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert_equal 'green', parrot.color
  end

  def test_first_or_create_with_block
    parrot = Bird.where(:color => 'green').first_or_create { |bird| bird.name = 'parrot' }
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name

    same_parrot = Bird.where(:color => 'green').first_or_create { |bird| bird.name = 'parakeet' }
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_with_array
    several_green_birds = Bird.where(:color => 'green').first_or_create([{:name => 'parrot'}, {:name => 'parakeet'}])
    assert_kind_of Array, several_green_birds
    several_green_birds.each { |bird| assert bird.persisted? }

    same_parrot = Bird.where(:color => 'green').first_or_create([{:name => 'hummingbird'}, {:name => 'macaw'}])
    assert_kind_of Bird, same_parrot
    assert_equal several_green_birds.first, same_parrot
  end

  def test_first_or_create_bang_with_valid_options
    parrot = Bird.where(:color => 'green').first_or_create!(:name => 'parrot')
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color

    same_parrot = Bird.where(:color => 'green').first_or_create!(:name => 'parakeet')
    assert_kind_of Bird, same_parrot
    assert same_parrot.persisted?
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_bang_with_invalid_options
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create!(:pirate_id => 1) }
  end

  def test_first_or_create_bang_with_no_parameters
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create! }
  end

  def test_first_or_create_bang_with_valid_block
    parrot = Bird.where(:color => 'green').first_or_create! { |bird| bird.name = 'parrot' }
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name

    same_parrot = Bird.where(:color => 'green').first_or_create! { |bird| bird.name = 'parakeet' }
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_bang_with_invalid_block
    assert_raise(ActiveRecord::RecordInvalid) do
1043
      Bird.where(:color => 'green').first_or_create! { |bird| bird.pirate_id = 1 }
1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060
    end
  end

  def test_first_or_create_with_valid_array
    several_green_birds = Bird.where(:color => 'green').first_or_create!([{:name => 'parrot'}, {:name => 'parakeet'}])
    assert_kind_of Array, several_green_birds
    several_green_birds.each { |bird| assert bird.persisted? }

    same_parrot = Bird.where(:color => 'green').first_or_create!([{:name => 'hummingbird'}, {:name => 'macaw'}])
    assert_kind_of Bird, same_parrot
    assert_equal several_green_birds.first, same_parrot
  end

  def test_first_or_create_with_invalid_array
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create!([ {:name => 'parrot'}, {:pirate_id => 1} ]) }
  end

1061 1062
  def test_first_or_initialize
    parrot = Bird.where(:color => 'green').first_or_initialize(:name => 'parrot')
1063 1064 1065 1066 1067 1068 1069 1070
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert parrot.valid?
    assert parrot.new_record?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color
  end

1071 1072
  def test_first_or_initialize_with_no_parameters
    parrot = Bird.where(:color => 'green').first_or_initialize
1073 1074 1075 1076 1077 1078 1079
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert !parrot.valid?
    assert parrot.new_record?
    assert_equal 'green', parrot.color
  end

1080 1081
  def test_first_or_initialize_with_block
    parrot = Bird.where(:color => 'green').first_or_initialize { |bird| bird.name = 'parrot' }
1082 1083 1084 1085 1086 1087 1088 1089
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert parrot.valid?
    assert parrot.new_record?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name
  end

1090 1091 1092 1093 1094 1095 1096 1097 1098
  def test_find_or_create_by
    assert_nil Bird.find_by(name: 'bob')

    bird = Bird.find_or_create_by(name: 'bob')
    assert bird.persisted?

    assert_equal bird, Bird.find_or_create_by(name: 'bob')
  end

1099 1100 1101 1102 1103 1104 1105 1106 1107 1108
  def test_find_or_create_by_with_create_with
    assert_nil Bird.find_by(name: 'bob')

    bird = Bird.create_with(color: 'green').find_or_create_by(name: 'bob')
    assert bird.persisted?
    assert_equal 'green', bird.color

    assert_equal bird, Bird.create_with(color: 'blue').find_or_create_by(name: 'bob')
  end

1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122
  def test_find_or_create_by!
    assert_raises(ActiveRecord::RecordInvalid) { Bird.find_or_create_by!(color: 'green') }
  end

  def test_find_or_initialize_by
    assert_nil Bird.find_by(name: 'bob')

    bird = Bird.find_or_initialize_by(name: 'bob')
    assert bird.new_record?
    bird.save!

    assert_equal bird, Bird.find_or_initialize_by(name: 'bob')
  end

1123 1124 1125 1126 1127 1128 1129 1130
  def test_explicit_create_scope
    hens = Bird.where(:name => 'hen')
    assert_equal 'hen', hens.new.name

    hens = hens.create_with(:name => 'cock')
    assert_equal 'cock', hens.new.name
  end

P
Pratik Naik 已提交
1131 1132
  def test_except
    relation = Post.where(:author_id => 1).order('id ASC').limit(1)
1133
    assert_equal [posts(:welcome)], relation.to_a
P
Pratik Naik 已提交
1134 1135

    author_posts = relation.except(:order, :limit)
1136
    assert_equal Post.where(:author_id => 1).to_a, author_posts.to_a
P
Pratik Naik 已提交
1137 1138

    all_posts = relation.except(:where, :order, :limit)
J
Jon Leighton 已提交
1139
    assert_equal Post.all, all_posts
P
Pratik Naik 已提交
1140 1141
  end

E
Emilio Tagua 已提交
1142 1143
  def test_only
    relation = Post.where(:author_id => 1).order('id ASC').limit(1)
1144
    assert_equal [posts(:welcome)], relation.to_a
E
Emilio Tagua 已提交
1145 1146

    author_posts = relation.only(:where)
1147
    assert_equal Post.where(:author_id => 1).to_a, author_posts.to_a
E
Emilio Tagua 已提交
1148 1149

    all_posts = relation.only(:limit)
1150
    assert_equal Post.limit(1).to_a.first, all_posts.first
E
Emilio Tagua 已提交
1151 1152
  end

P
Pratik Naik 已提交
1153
  def test_anonymous_extension
1154
    relation = Post.where(:author_id => 1).order('id ASC').extending do
P
Pratik Naik 已提交
1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168
      def author
        'lifo'
      end
    end

    assert_equal "lifo", relation.author
    assert_equal "lifo", relation.limit(1).author
  end

  def test_named_extension
    relation = Post.where(:author_id => 1).order('id ASC').extending(Post::NamedExtension)
    assert_equal "lifo", relation.author
    assert_equal "lifo", relation.limit(1).author
  end
1169 1170

  def test_order_by_relation_attribute
1171
    assert_equal Post.order(Post.arel_table[:title]).to_a, Post.order("title").to_a
1172
  end
1173

1174
  def test_default_scope_order_with_scope_order
1175 1176
    assert_equal 'zyke', CoolCar.order_using_new_style.limit(1).first.name
    assert_equal 'zyke', FastCar.order_using_new_style.limit(1).first.name
1177 1178 1179
  end

  def test_order_using_scoping
1180
    car1 = CoolCar.order('id DESC').scoping do
1181
      CoolCar.all.merge!(order: 'id asc').first
1182
    end
1183
    assert_equal 'zyke', car1.name
1184 1185

    car2 = FastCar.order('id DESC').scoping do
1186
      FastCar.all.merge!(order: 'id asc').first
1187
    end
1188
    assert_equal 'zyke', car2.name
1189 1190 1191 1192 1193
  end

  def test_unscoped_block_style
    assert_equal 'honda', CoolCar.unscoped { CoolCar.order_using_new_style.limit(1).first.name}
    assert_equal 'honda', FastCar.unscoped { FastCar.order_using_new_style.limit(1).first.name}
1194 1195
  end

1196 1197 1198
  def test_intersection_with_array
    relation = Author.where(:name => "David")
    rails_author = relation.first
1199

1200 1201 1202
    assert_equal [rails_author], [rails_author] & relation
    assert_equal [rails_author], relation & [rails_author]
  end
1203

1204
  def test_primary_key
1205
    assert_equal "id", Post.all.primary_key
1206
  end
1207

1208 1209 1210 1211 1212 1213
  def test_disable_implicit_join_references_is_deprecated
    assert_deprecated do
      ActiveRecord::Base.disable_implicit_join_references = true
    end
  end

1214
  def test_ordering_with_extra_spaces
1215
    assert_equal authors(:david), Author.order('id DESC , name DESC').last
1216
  end
1217

1218 1219 1220 1221
  def test_update_all_with_blank_argument
    assert_raises(ArgumentError) { Comment.update_all({}) }
  end

1222 1223 1224 1225 1226 1227 1228
  def test_update_all_with_joins
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id)
    count    = comments.count

    assert_equal count, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:greetings).post
  end
1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250

  def test_update_all_with_joins_and_limit
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).limit(1)
    assert_equal 1, comments.update_all(:post_id => posts(:thinking).id)
  end

  def test_update_all_with_joins_and_limit_and_order
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).order('comments.id').limit(1)
    assert_equal 1, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:greetings).post
    assert_equal posts(:welcome),  comments(:more_greetings).post
  end

  def test_update_all_with_joins_and_offset
    all_comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id)
    count        = all_comments.count
    comments     = all_comments.offset(1)

    assert_equal count - 1, comments.update_all(:post_id => posts(:thinking).id)
  end

  def test_update_all_with_joins_and_offset_and_order
1251
    all_comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).order('posts.id', 'comments.id')
1252 1253 1254 1255 1256 1257 1258
    count        = all_comments.count
    comments     = all_comments.offset(1)

    assert_equal count - 1, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:more_greetings).post
    assert_equal posts(:welcome),  comments(:greetings).post
  end
1259

1260
  def test_distinct
1261 1262 1263 1264 1265 1266 1267
    tag1 = Tag.create(:name => 'Foo')
    tag2 = Tag.create(:name => 'Foo')

    query = Tag.select(:name).where(:id => [tag1.id, tag2.id])

    assert_equal ['Foo', 'Foo'], query.map(&:name)
    assert_sql(/DISTINCT/) do
1268
      assert_equal ['Foo'], query.distinct.map(&:name)
1269 1270 1271
      assert_equal ['Foo'], query.uniq.map(&:name)
    end
    assert_sql(/DISTINCT/) do
1272
      assert_equal ['Foo'], query.distinct(true).map(&:name)
1273 1274
      assert_equal ['Foo'], query.uniq(true).map(&:name)
    end
1275
    assert_equal ['Foo', 'Foo'], query.distinct(true).distinct(false).map(&:name)
1276 1277
    assert_equal ['Foo', 'Foo'], query.uniq(true).uniq(false).map(&:name)
  end
1278

1279 1280 1281 1282 1283 1284 1285 1286
  def test_doesnt_add_having_values_if_options_are_blank
    scope = Post.having('')
    assert_equal [], scope.having_values

    scope = Post.having([])
    assert_equal [], scope.having_values
  end

1287 1288 1289 1290 1291 1292 1293 1294 1295 1296
  def test_references_triggers_eager_loading
    scope = Post.includes(:comments)
    assert !scope.eager_loading?
    assert scope.references(:comments).eager_loading?
  end

  def test_references_doesnt_trigger_eager_loading_if_reference_not_included
    scope = Post.references(:comments)
    assert !scope.eager_loading?
  end
1297

1298
  def test_automatically_added_where_references
1299
    scope = Post.where(:comments => { :body => "Bla" })
J
Jon Leighton 已提交
1300
    assert_equal ['comments'], scope.references_values
1301 1302

    scope = Post.where('comments.body' => 'Bla')
J
Jon Leighton 已提交
1303
    assert_equal ['comments'], scope.references_values
1304
  end
1305

1306
  def test_automatically_added_having_references
1307
    scope = Post.having(:comments => { :body => "Bla" })
J
Jon Leighton 已提交
1308
    assert_equal ['comments'], scope.references_values
1309 1310

    scope = Post.having('comments.body' => 'Bla')
J
Jon Leighton 已提交
1311
    assert_equal ['comments'], scope.references_values
1312
  end
1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330

  def test_automatically_added_order_references
    scope = Post.order('comments.body')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('comments.body', 'yaks.body')
    assert_equal ['comments', 'yaks'], scope.references_values

    # Don't infer yaks, let's not go down that road again...
    scope = Post.order('comments.body, yaks.body')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('comments.body asc')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('foo(comments.body)')
    assert_equal [], scope.references_values
  end
1331

1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349
  def test_automatically_added_reorder_references
    scope = Post.reorder('comments.body')
    assert_equal %w(comments), scope.references_values

    scope = Post.reorder('comments.body', 'yaks.body')
    assert_equal %w(comments yaks), scope.references_values

    # Don't infer yaks, let's not go down that road again...
    scope = Post.reorder('comments.body, yaks.body')
    assert_equal %w(comments), scope.references_values

    scope = Post.reorder('comments.body asc')
    assert_equal %w(comments), scope.references_values

    scope = Post.reorder('foo(comments.body)')
    assert_equal [], scope.references_values
  end

1350
  def test_presence
1351
    topics = Topic.all
1352

1353
    # the first query is triggered because there are no topics yet.
1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367
    assert_queries(1) { assert topics.present? }

    # checking if there are topics is used before you actually display them,
    # thus it shouldn't invoke an extra count query.
    assert_no_queries { assert topics.present? }
    assert_no_queries { assert !topics.blank? }

    # shows count of topics and loops after loading the query should not trigger extra queries either.
    assert_no_queries { topics.size }
    assert_no_queries { topics.length }
    assert_no_queries { topics.each }

    # count always trigger the COUNT query.
    assert_queries(1) { topics.count }
1368 1369 1370

    assert topics.loaded?
  end
1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384

  test "find_by with hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by(author_id: 2)
  end

  test "find_by with non-hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by("author_id = 2")
  end

  test "find_by with multi-arg conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by('author_id = ?', 2)
  end

  test "find_by returns nil if the record is missing" do
1385
    assert_equal nil, Post.all.find_by("1 = 0")
1386 1387
  end

1388 1389 1390 1391
  test "find_by doesn't have implicit ordering" do
    assert_sql(/^((?!ORDER).)*$/) { Post.find_by(author_id: 2) }
  end

1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403
  test "find_by! with hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by!(author_id: 2)
  end

  test "find_by! with non-hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by!("author_id = 2")
  end

  test "find_by! with multi-arg conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by!('author_id = ?', 2)
  end

1404 1405 1406 1407
  test "find_by! doesn't have implicit ordering" do
    assert_sql(/^((?!ORDER).)*$/) { Post.find_by!(author_id: 2) }
  end

1408 1409
  test "find_by! raises RecordNotFound if the record is missing" do
    assert_raises(ActiveRecord::RecordNotFound) do
1410
      Post.all.find_by!("1 = 0")
1411 1412
    end
  end
1413 1414

  test "loaded relations cannot be mutated by multi value methods" do
1415
    relation = Post.all
1416 1417 1418 1419 1420 1421 1422 1423
    relation.to_a

    assert_raises(ActiveRecord::ImmutableRelation) do
      relation.where! 'foo'
    end
  end

  test "loaded relations cannot be mutated by single value methods" do
1424
    relation = Post.all
1425 1426 1427 1428 1429 1430 1431 1432
    relation.to_a

    assert_raises(ActiveRecord::ImmutableRelation) do
      relation.limit! 5
    end
  end

  test "loaded relations cannot be mutated by merge!" do
1433
    relation = Post.all
1434 1435 1436 1437 1438 1439
    relation.to_a

    assert_raises(ActiveRecord::ImmutableRelation) do
      relation.merge! where: 'foo'
    end
  end
1440

1441 1442 1443 1444 1445 1446 1447 1448 1449
  test "loaded relations cannot be mutated by extending!" do
    relation = Post.all
    relation.to_a

    assert_raises(ActiveRecord::ImmutableRelation) do
      relation.extending! Module.new
    end
  end

1450 1451 1452 1453
  test "relations show the records in #inspect" do
    relation = Post.limit(2)
    assert_equal "#<ActiveRecord::Relation [#{Post.limit(2).map(&:inspect).join(', ')}]>", relation.inspect
  end
1454

1455
  test "relations limit the records in #inspect at 10" do
1456 1457 1458
    relation = Post.limit(11)
    assert_equal "#<ActiveRecord::Relation [#{Post.limit(10).map(&:inspect).join(', ')}, ...]>", relation.inspect
  end
1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469

  test "already-loaded relations don't perform a new query in #inspect" do
    relation = Post.limit(2)
    relation.to_a

    expected = "#<ActiveRecord::Relation [#{Post.limit(2).map(&:inspect).join(', ')}]>"

    assert_no_queries do
      assert_equal expected, relation.inspect
    end
  end
1470 1471 1472 1473 1474 1475 1476 1477 1478 1479

  test 'using a custom table affects the wheres' do
    table_alias = Post.arel_table.alias('omg_posts')

    relation = ActiveRecord::Relation.new Post, table_alias
    relation.where!(:foo => "bar")

    node = relation.arel.constraints.first.grep(Arel::Attributes::Attribute).first
    assert_equal table_alias, node.relation
  end
J
Jon Leighton 已提交
1480 1481 1482 1483 1484 1485 1486 1487

  test '#load' do
    relation = Post.all
    assert_queries(1) do
      assert_equal relation, relation.load
    end
    assert_no_queries { relation.to_a }
  end
1488 1489

  test 'group with select and includes' do
1490 1491
    authors_count = Post.select('author_id, COUNT(author_id) AS num_posts').
      group('author_id').order('author_id').includes(:author).to_a
1492 1493 1494 1495 1496 1497 1498 1499 1500 1501

    assert_no_queries do
      result = authors_count.map do |post|
        [post.num_posts, post.author.try(:name)]
      end

      expected = [[1, nil], [5, "David"], [3, "Mary"], [2, "Bob"]]
      assert_equal expected, result
    end
  end
1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530

  test "delegations do not leak to other classes" do
    Topic.all.by_lifo
    assert Topic.all.class.method_defined?(:by_lifo)
    assert !Post.all.respond_to?(:by_lifo)
  end

  class OMGTopic < ActiveRecord::Base
    self.table_name = 'topics'

    def self.__omg__
      "omgtopic"
    end
  end

  test "delegations do not clash across classes" do
    begin
      class ::Array
        def __omg__
          "array"
        end
      end

      assert_equal "array",    Topic.all.__omg__
      assert_equal "omgtopic", OMGTopic.all.__omg__
    ensure
      Array.send(:remove_method, :__omg__)
    end
  end
P
Pratik Naik 已提交
1531
end