- 16 10月, 2015 5 次提交
-
-
由 John Ferlan 提交于
https://bugzilla.redhat.com/show_bug.cgi?id=1249981 When qemuDomainPinIOThread was added in commit id 'fb562614', a check for the IOThread capability was not needed since a check for iothreadpids covered the condition where the support for IOThreads was not present. The iothreadpids array was only created if qemuProcessDetectIOThreadPIDs was able to query the monitor for IOThreads. It would only do that if the QEMU_CAPS_OBJECT_IOTHREAD capability was set. However, when iothreadids were added in commit id '8d4614a5' and the check for iothreadpids was replaced by a search through the iothreadids[] array for the matching iothread_id that left open the possibility that an iothreadids[] array was defined, but the entries essentially pointed to elements with only the 'iothread_id' defined leaving the 'thread_id' value of 0 and eventually the cpumap entry of NULL. This was because, the original IOThreads commit id '72edaae7' only checked if IOThreads were defined and if the emulator had the IOThreads capability, then IOThread objects were added at startup. The "capability failure" check was only done when a disk was assigned to an IOThread in qemuCheckIOThreads. This was because the initial implementation had no way to dynamically add IOThreads, but it was possible to dynamically add a disk to the domain. So the decision was if the domain supported it, then add the IOThread objects. Then if a disk with an IOThread defined was added, it could check the capability and fail to add if not there. This just meant the 'iothreads' value was essentially ignored. Eventually commit id 'a27ed6e7' allowed for the dynamic addition and deletion of IOThread objects. So it was no longer necessary to generate IOThread objects to dynamically attach a disk to. However, the startup and disk check code was not modified to reflect this. This patch will move the capability failure check to when IOThread objects are being added to the command line. Thus a domain that has IOThreads defined will not be started if the emulator doesn't support the capability. This means when qemuCheckIOThreads is called to add a disk, it's no longer necessary to check the capability. Instead the code can use the IOThreadFind call to indicate that the IOThread doesn't exist. Finally because it could be possible to have a domain running with the iothreadids[] defined prior to this change if libvirtd is restarted each having mostly empty elements, qemuProcessDetectIOThreadPIDs will check if there are niothreadids when the QEMU_CAPS_OBJECT_IOTHREAD capability check fails and remove the elements and array if it exists. With these changes in place, it turns out the cputune-numatune test was failing because the right bit wasn't set in the test. So used the opportunity to fix that and create a test that would expect to fail with some sort of iothreads defined and used, but not having the correct capability.
-
由 John Ferlan 提交于
If there are no IOThreads defined, no sense making other checks
-
由 John Ferlan 提交于
Although theoretically both should be the same value, the niothreadids should be used in favor of iothreads when performing comparisons. This leaves the iothreads as a purely numeric value to be saved in the config file. The one exception to the rule is virDomainIOThreadIDDefArrayInit where the iothreadids are being generated from the iothreads count since iothreadids were added after initial iothreads support.
-
由 Peter Krempa 提交于
The condition checking whether --format was specified was incorrect. virsh crashed if the following format was used: virsh dump VM dump --format '' --memory-only Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1272301
-
由 Dominik Perpeet 提交于
Event implementations need to be registered before a connection to the Hypervisor is opened, otherwise event handling can be impaired (e.g. delayed messages). This fact is referenced in an e-mail [1], but should also be noted in the documentation of the registration functions. [1] https://www.redhat.com/archives/libvirt-users/2014-April/msg00011.html
-
- 15 10月, 2015 10 次提交
-
-
由 Wei Jiangang 提交于
Don't compare a bool variable against the literal, "true". Signed-off-by: NWei Jiangang <weijg.fnst@cn.fujitsu.com> Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
-
由 Wei Jiangang 提交于
seclets ==> selects qualfied ==> qualified Signed-off-by: NWei Jiangang <weijg.fnst@cn.fujitsu.com> Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
-
由 John Ferlan 提交于
Create a separate local API that will fill in the iothreadid array entries that were not defined by <iothread id='#'> entries in the XML. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Andrea Bolognani 提交于
There were some inconsistencies, eg. the number of digits used for the day. The month name was also spelled out instead of abbreviated in some instances.
-
由 Andrea Bolognani 提交于
There were some inconsistencies; now the section title is always one of Bug Fixes, Cleanups, Documentation, Features, Improvements, Portability, Security.
-
由 Andrea Bolognani 提交于
Make sure there is always an empty line between sections.
-
由 Andrea Bolognani 提交于
Some of the paragraphs were not properly indented: while this was not a problem in the HTML version, you could tell the difference in the plain text version.
-
由 Andrea Bolognani 提交于
Some <br/> tags were missing from the end of the corresponding line, some of there were in the middle of the line instead.
-
由 Andrea Bolognani 提交于
Mostly missing space between change description and author name or spurious space before section title. Reflow the introductory paragraph as well.
-
由 Andrea Bolognani 提交于
Sort all items into the standard categories: Features, Bug Fixes, Improvements, Cleanups, etc. The sorting is somewhat arbitrary in certain instances.
-
- 14 10月, 2015 16 次提交
-
-
由 Andrea Bolognani 提交于
The changes for releases earlier than 0.7.1 were mostly lumped together as opposed to being tidly organized with one change per line, like we have done from that point onwards. As a result, they look awful in the HTML version and don't work too well in the plain text version either. Luckily, except for the very first releases, the information is still very detailed, so it's enough to organize it properly.
-
由 Andrea Bolognani 提交于
The changes for releases earlier than 0.7.1 were mostly lumped together as opposed to being tidly organized with one change per line, like we have done from that point onwards. As a result, they look awful in the HTML version and don't work too well in the plain text version either. Luckily, except for the very first releases, the information is still very detailed, so it's enough to organize it properly.
-
由 Andrea Bolognani 提交于
The changes for releases earlier than 0.7.1 were mostly lumped together as opposed to being tidly organized with one change per line, like we have done from that point onwards. As a result, they look awful in the HTML version and don't work too well in the plain text version either. Luckily, except for the very first releases, the information is still very detailed, so it's enough to organize it properly.
-
由 Andrea Bolognani 提交于
-
由 Andrea Bolognani 提交于
Portability and Bug Fixes for release 0.7.3 were merged together; same for Features and Security for release 1.1.3. Split them off
-
由 Andrea Bolognani 提交于
-
由 Andrea Bolognani 提交于
The description for this release, unlike all other descriptions, was inside a <p> element; however, the XSLT stylesheet contains a template that drops all <p> elements from the output file, so it never made it to the generated NEWS file. Use a <li> element, same as all other releases, instead.
-
由 Wei Jiangang 提交于
It should redirect stdout to /dev/null first, then redirect stderr to whatever stdout currently points at. Signed-off-by: NWei Jiangang <weijg.fnst@cn.fujitsu.com>
-
由 John Ferlan 提交于
Rework the code in order to use the "ret = -1;" and goto cleanup; coding style. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
After a successful creation of a directory, if some other call results in returning a failure, let's remove the directory we created to prevent another round trip or confusion in the caller. In particular, this function can be called during a storage backend buildVol, so in order to ensure that caller doesn't need to distinguish between failed create or some other failure after create, just remove the directory we created. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
After a successful creation of a file, if some other call results in returning a failure, let's unlink the file we created to prevent another round trip or confusion in the caller. In particular, this function can be called during a storage backend buildVol, so in order to ensure that caller doesn't need to distinguish between failed create or some other failure after create, just remove the volume we created. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
https://bugzilla.redhat.com/show_bug.cgi?id=1233003 Track when the logical volume was successfully created in order to properly handle the call to virStorageBackendLogicalDeleteVol. It's possible that the failure to create was because someone created an LV in the pool outside of libvirt's knowledge. In this case, we don't want to delete that LV. A subsequent or future refresh of the pool will find the volume and cause an earlier failure Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
Commit id '1b5685da' refactored the code to move buildvoldef inside the buildVol conditional; however, the VIR_FREE of the memory was left only when 'buildret' failed, thus we're leaking memory. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
As of commit id '155ca616' a 'refreshVol' is called after a buildVol succeeds in storageVolCreateXML, thus a volStorageBackendSheepdogRefreshVolInfo call in virStorageBackendSheepdogBuildVol is no longer necessary. Additionally, the 'conn' parameter becomes unused. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 John Ferlan 提交于
As of commit id '155ca616' a 'refreshVol' is called after the buildVol succeeds in storageVolCreateXML, thus the volStorageBackendRBDRefreshVolInfo call in virStorageBackendRBDBuildVol is no longer necessary. Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Eric Blake 提交于
Without this, building on cygwin fails with: CC libvirt_admin_la-libvirt-admin.lo libvirt-admin.c:25:21: fatal error: rpc/rpc.h: No such file or directory #include <rpc/rpc.h> ^ Reported-by: NYaakov Selkowitz <yselkowi@redhat.com> Signed-off-by: NEric Blake <eblake@redhat.com>
-
- 13 10月, 2015 1 次提交
-
-
由 Daniel P. Berrange 提交于
This looks for existance of DMAR (Intel) and IVRS (AMD) files under /sys/firmware/acpi/tables/, as a sign that the platform has IOMMU present & enabled in the BIOS. If these are present and /sys/kernel/iommu_groups does not contain any entries this is taken as a sign that the kernel has not enabled the IOMMU currently. If no ACPI tables are found we can't distinguish between disabled in BIOS and not present in the hardware, so we have to give the user a generic hint. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
- 12 10月, 2015 8 次提交
-
-
由 Michal Privoznik 提交于
Our apibuild.py script does not cope with ATTRIBUTE_NONNULL: Parse Error: parsing function type, ')' expected Got token ('name', 'char') Last token: ('name', 'char') Token queue: [('op', '*'), ('name', 'dconnuri'), ('sep', ')')] Line 3297 end: Makefile:2441: recipe for target '../../docs/apibuild.py.stamp' failed Let's drop it. Moreover, up until e17ae3cc where it was introduced we did not really care about NULL-ity of dconnuri. And moreover the ATTRIBUTE_NONNULL merely checks for static calls over NULL, it won't catch the dynamic ones, where a NULL is passed by a variable at runtime. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 John Ferlan 提交于
https://bugzilla.redhat.com/show_bug.cgi?id=1256999 After creating a copy of the 'authdef' in a pool -> disk translation, unconditionally clear the 'authType' in the resulting disk auth def structure since that's used for a storage pool and not a disk. This ensures virStorageAuthDefFormat will properly format the <auth> XML for a <disk> (e.g. it won't have a <auth type='%s'.../>).
-
由 Daniel P. Berrange 提交于
Win32 does not have support for mntent.h header, so the method which uses this must be stubbed out. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
由 Daniel P. Berrange 提交于
Extend the virt-host-validate checks to see if the required cgroups are compiled into the kernel and that they are mounted on the system. The cgroups are all optional except for 3 that LXC mandates Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
由 Daniel P. Berrange 提交于
Currently we just check that various devices are accessible. This leads to inaccurate errors reported for /dev/kvm and /dev/vhost-net if they exist but an unprivileged user lacks access. Switch existing checks to look for file existance, and add a separate check for accessibility of /dev/kvm since some distros don't grant users access by default. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
由 Daniel P. Berrange 提交于
The LXC driver requires the uts, mnt, pid & ipc namespaces, while net & user namespaces are optional. Validate all these are present. Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
-
由 Nikolay Shirokovskiy 提交于
Check dconnuri is not null or we will catch nullpointer later. I hope this makes Coverity happy. Signed-off-by: NNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
-
由 Nikolay Shirokovskiy 提交于
virDomainMigrateUnmanagedParams is not a good candidate for this functionality as it is used by migrate family functions too and its have its own checks that are superset of extracted and we don't need to check twice. Actually name of the function is slightly misleading as there is also a check for consistensy of flags parameter alone. So it could be refactored further and reused by all migrate functions but for now let it be a matter of a different patchset. It is *not* a pure refactoring patch as it introduces offline check for older versions. Looks like it must be done that way and no one will be broken too. Signed-off-by: NNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
-