qemu_conf.c 43.0 KB
Newer Older
D
Daniel P. Berrange 已提交
1 2 3
/*
 * config.c: VM configuration management
 *
4
 * Copyright (C) 2006, 2007, 2008 Red Hat, Inc.
D
Daniel P. Berrange 已提交
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

24
#include <config.h>
25

D
Daniel P. Berrange 已提交
26 27 28 29 30
#include <dirent.h>
#include <string.h>
#include <limits.h>
#include <sys/types.h>
#include <sys/stat.h>
31
#include <stdlib.h>
D
Daniel P. Berrange 已提交
32 33 34
#include <unistd.h>
#include <errno.h>
#include <fcntl.h>
35
#include <sys/wait.h>
36
#include <arpa/inet.h>
37
#include <sys/utsname.h>
D
Daniel P. Berrange 已提交
38

39 40 41 42
#if HAVE_NUMACTL
#include <numa.h>
#endif

43
#include "virterror_internal.h"
44
#include "qemu_conf.h"
45
#include "uuid.h"
46
#include "buf.h"
D
Daniel P. Berrange 已提交
47
#include "conf.h"
48
#include "util.h"
49
#include "memory.h"
J
Jim Meyering 已提交
50
#include "verify.h"
51 52 53 54 55 56 57

VIR_ENUM_DECL(virDomainDiskQEMUBus)
VIR_ENUM_IMPL(virDomainDiskQEMUBus, VIR_DOMAIN_DISK_BUS_LAST,
              "ide",
              "floppy",
              "scsi",
              "virtio",
58 59
              "xen",
              "usb")
60

61

62 63
#define qemudLog(level, msg...) fprintf(stderr, msg)

D
Daniel P. Berrange 已提交
64 65 66 67 68 69
int qemudLoadDriverConfig(struct qemud_driver *driver,
                          const char *filename) {
    virConfPtr conf;
    virConfValuePtr p;

    /* Setup 2 critical defaults */
70 71 72 73 74
    if (!(driver->vncListen = strdup("127.0.0.1"))) {
        qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
                         "%s", _("failed to allocate vncListen"));
        return -1;
    }
D
Daniel P. Berrange 已提交
75 76
    if (!(driver->vncTLSx509certdir = strdup(SYSCONF_DIR "/pki/libvirt-vnc"))) {
        qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
77
                         "%s", _("failed to allocate vncTLSx509certdir"));
D
Daniel P. Berrange 已提交
78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108
        return -1;
    }

    /* Just check the file is readable before opening it, otherwise
     * libvirt emits an error.
     */
    if (access (filename, R_OK) == -1) return 0;

    conf = virConfReadFile (filename);
    if (!conf) return 0;


#define CHECK_TYPE(name,typ) if (p && p->type != (typ)) {               \
        qemudReportError(NULL, NULL, NULL, VIR_ERR_INTERNAL_ERROR,      \
                         "remoteReadConfigFile: %s: %s: expected type " #typ "\n", \
                         filename, (name));                             \
        virConfFree(conf);                                              \
        return -1;                                                      \
    }

    p = virConfGetValue (conf, "vnc_tls");
    CHECK_TYPE ("vnc_tls", VIR_CONF_LONG);
    if (p) driver->vncTLS = p->l;

    p = virConfGetValue (conf, "vnc_tls_x509_verify");
    CHECK_TYPE ("vnc_tls_x509_verify", VIR_CONF_LONG);
    if (p) driver->vncTLSx509verify = p->l;

    p = virConfGetValue (conf, "vnc_tls_x509_cert_dir");
    CHECK_TYPE ("vnc_tls_x509_cert_dir", VIR_CONF_STRING);
    if (p && p->str) {
109
        VIR_FREE(driver->vncTLSx509certdir);
D
Daniel P. Berrange 已提交
110 111
        if (!(driver->vncTLSx509certdir = strdup(p->str))) {
            qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
112
                             "%s", _("failed to allocate vncTLSx509certdir"));
D
Daniel P. Berrange 已提交
113 114 115 116 117 118 119 120
            virConfFree(conf);
            return -1;
        }
    }

    p = virConfGetValue (conf, "vnc_listen");
    CHECK_TYPE ("vnc_listen", VIR_CONF_STRING);
    if (p && p->str) {
J
Jim Meyering 已提交
121
        VIR_FREE(driver->vncListen);
122 123
        if (!(driver->vncListen = strdup(p->str))) {
            qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
J
Jim Meyering 已提交
124
                             "%s", _("failed to allocate vnc_listen"));
125 126 127
            virConfFree(conf);
            return -1;
        }
D
Daniel P. Berrange 已提交
128 129 130 131 132 133
    }

    virConfFree (conf);
    return 0;
}

D
Daniel P. Berrange 已提交
134 135
/* The list of possible machine types for various architectures,
   as supported by QEMU - taken from 'qemu -M ?' for each arch */
136 137
static const char *const arch_info_hvm_x86_machines[] = {
    "pc", "isapc"
D
Daniel P. Berrange 已提交
138
};
139 140
static const char *const arch_info_hvm_mips_machines[] = {
    "mips"
D
Daniel P. Berrange 已提交
141
};
142 143
static const char *const arch_info_hvm_sparc_machines[] = {
    "sun4m"
D
Daniel P. Berrange 已提交
144
};
145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166
static const char *const arch_info_hvm_ppc_machines[] = {
    "g3bw", "mac99", "prep"
};

static const char *const arch_info_xen_x86_machines[] = {
    "xenner"
};

struct qemu_feature_flags {
    const char *name;
    const int default_on;
    const int toggle;
};

struct qemu_arch_info {
    const char *arch;
    int wordsize;
    const char *const *machines;
    int nmachines;
    const char *binary;
    const struct qemu_feature_flags *flags;
    int nflags;
D
Daniel P. Berrange 已提交
167 168
};

169
/* Feature flags for the architecture info */
J
Jim Meyering 已提交
170
static const struct qemu_feature_flags const arch_info_i686_flags [] = {
171 172
    { "pae",  1, 0 },
    { "nonpae",  1, 0 },
173 174 175 176
    { "acpi", 1, 1 },
    { "apic", 1, 0 },
};

J
Jim Meyering 已提交
177
static const struct qemu_feature_flags const arch_info_x86_64_flags [] = {
178 179 180 181
    { "acpi", 1, 1 },
    { "apic", 1, 0 },
};

D
Daniel P. Berrange 已提交
182
/* The archicture tables for supported QEMU archs */
183 184 185 186 187 188 189 190 191 192 193 194 195
static const struct qemu_arch_info const arch_info_hvm[] = {
    {  "i686", 32, arch_info_hvm_x86_machines, 2,
       "/usr/bin/qemu", arch_info_i686_flags, 4 },
    {  "x86_64", 64, arch_info_hvm_x86_machines, 2,
       "/usr/bin/qemu-system-x86_64", arch_info_x86_64_flags, 2 },
    {  "mips", 32, arch_info_hvm_mips_machines, 1,
       "/usr/bin/qemu-system-mips", NULL, 0 },
    {  "mipsel", 32, arch_info_hvm_mips_machines, 1,
       "/usr/bin/qemu-system-mipsel", NULL, 0 },
    {  "sparc", 32, arch_info_hvm_sparc_machines, 1,
       "/usr/bin/qemu-system-sparc", NULL, 0 },
    {  "ppc", 32, arch_info_hvm_ppc_machines, 3,
       "/usr/bin/qemu-system-ppc", NULL, 0 },
D
Daniel P. Berrange 已提交
196 197
};

198 199 200 201 202 203
static const struct qemu_arch_info const arch_info_xen[] = {
    {  "i686", 32, arch_info_xen_x86_machines, 1,
       "/usr/bin/xenner", arch_info_i686_flags, 4 },
    {  "x86_64", 64, arch_info_xen_x86_machines, 1,
       "/usr/bin/xenner", arch_info_x86_64_flags, 2 },
};
D
Daniel P. Berrange 已提交
204

205 206 207 208 209 210
static int
qemudCapsInitGuest(virCapsPtr caps,
                   const char *hostmachine,
                   const struct qemu_arch_info *info,
                   int hvm) {
    virCapsGuestPtr guest;
211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233
    int i, haskvm, hasbase, samearch;
    const char *kvmbin = NULL;

    /* Check for existance of base emulator */
    hasbase = (access(info->binary, X_OK) == 0);

    samearch = STREQ(info->arch, hostmachine);
    if (samearch) {
        const char *const kvmbins[] = { "/usr/bin/qemu-kvm", /* Fedora */
                                        "/usr/bin/kvm" }; /* Upstream .spec */

        for (i = 0; i < ARRAY_CARDINALITY(kvmbins); ++i) {
            if ((haskvm = (access(kvmbins[i], X_OK) == 0))) {
                kvmbin = kvmbins[i];
                break;
            }
        }
    } else {
        haskvm = 0;
    }

    if (!hasbase && !haskvm)
        return 0;
D
Daniel P. Berrange 已提交
234

235 236 237 238 239 240 241 242 243
    if ((guest = virCapabilitiesAddGuest(caps,
                                         hvm ? "hvm" : "xen",
                                         info->arch,
                                         info->wordsize,
                                         info->binary,
                                         NULL,
                                         info->nmachines,
                                         info->machines)) == NULL)
        return -1;
D
Daniel P. Berrange 已提交
244

245
    if (hvm) {
246
        if (hasbase &&
247 248 249 250 251 252 253
            virCapabilitiesAddGuestDomain(guest,
                                          "qemu",
                                          NULL,
                                          NULL,
                                          0,
                                          NULL) == NULL)
            return -1;
D
Daniel P. Berrange 已提交
254

255
        /* If guest & host match, then we can accelerate */
256
        if (samearch) {
257 258 259 260 261 262 263 264 265 266
            if (access("/dev/kqemu", F_OK) == 0 &&
                virCapabilitiesAddGuestDomain(guest,
                                              "kqemu",
                                              NULL,
                                              NULL,
                                              0,
                                              NULL) == NULL)
                return -1;

            if (access("/dev/kvm", F_OK) == 0 &&
267
                haskvm &&
268 269
                virCapabilitiesAddGuestDomain(guest,
                                              "kvm",
270
                                              kvmbin,
271 272 273 274 275 276 277 278 279 280 281 282 283 284
                                              NULL,
                                              0,
                                              NULL) == NULL)
                return -1;
        }
    } else {
        if (virCapabilitiesAddGuestDomain(guest,
                                          "kvm",
                                          NULL,
                                          NULL,
                                          0,
                                          NULL) == NULL)
            return -1;
    }
D
Daniel P. Berrange 已提交
285

286 287 288 289 290 291 292
    if (info->nflags) {
        for (i = 0 ; i < info->nflags ; i++) {
            if (virCapabilitiesAddGuestFeature(guest,
                                               info->flags[i].name,
                                               info->flags[i].default_on,
                                               info->flags[i].toggle) == NULL)
                return -1;
D
Daniel P. Berrange 已提交
293 294 295
        }
    }

296
    return 0;
D
Daniel P. Berrange 已提交
297 298
}

299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357
#if HAVE_NUMACTL
#define MAX_CPUS 4096
#define MAX_CPUS_MASK_SIZE (sizeof(unsigned long))
#define MAX_CPUS_MASK_LEN (MAX_CPUS / MAX_CPUS_MASK_SIZE)
#define MAX_CPUS_MASK_BYTES (MAX_CPUS / 8)

#define MASK_CPU_ISSET(mask, cpu) \
    (((mask)[((cpu) / MAX_CPUS_MASK_SIZE)] >> ((cpu) % MAX_CPUS_MASK_SIZE)) & 1)

static int
qemudCapsInitNUMA(virCapsPtr caps)
{
    int n, i;
    unsigned long *mask = NULL;
    int ncpus;
    int *cpus = NULL;
    int ret = -1;

    if (numa_available() < 0)
        return 0;

    if (VIR_ALLOC_N(mask, MAX_CPUS_MASK_LEN) < 0)
        goto cleanup;

    for (n = 0 ; n <= numa_max_node() ; n++) {
        if (numa_node_to_cpus(n, mask, MAX_CPUS_MASK_BYTES) < 0)
            goto cleanup;

        for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++)
            if (MASK_CPU_ISSET(mask, i))
                ncpus++;

        if (VIR_ALLOC_N(cpus, ncpus) < 0)
            goto cleanup;

        for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++)
            if (MASK_CPU_ISSET(mask, i))
                cpus[ncpus++] = i;

        if (virCapabilitiesAddHostNUMACell(caps,
                                           n,
                                           ncpus,
                                           cpus) < 0)
            goto cleanup;

        VIR_FREE(cpus);
    }

    ret = 0;

cleanup:
    VIR_FREE(cpus);
    VIR_FREE(mask);
    return ret;
}
#else
static int qemudCapsInitNUMA(virCapsPtr caps ATTRIBUTE_UNUSED) { return 0; }
#endif

358 359 360 361
virCapsPtr qemudCapsInit(void) {
    struct utsname utsname;
    virCapsPtr caps;
    int i;
D
Daniel P. Berrange 已提交
362

363 364 365 366 367 368 369
    /* Really, this never fails - look at the man-page. */
    uname (&utsname);

    if ((caps = virCapabilitiesNew(utsname.machine,
                                   0, 0)) == NULL)
        goto no_memory;

370 371 372
    /* Using KVM's mac prefix for QEMU too */
    virCapabilitiesSetMacPrefix(caps, (unsigned char[]){ 0x52, 0x54, 0x00 });

373 374 375
    if (qemudCapsInitNUMA(caps) < 0)
        goto no_memory;

J
Jim Meyering 已提交
376
    for (i = 0 ; i < ARRAY_CARDINALITY(arch_info_hvm) ; i++)
377 378 379 380 381 382 383
        if (qemudCapsInitGuest(caps,
                               utsname.machine,
                               &arch_info_hvm[i], 1) < 0)
            goto no_memory;

    if (access("/usr/bin/xenner", X_OK) == 0 &&
        access("/dev/kvm", F_OK) == 0) {
J
Jim Meyering 已提交
384
        for (i = 0 ; i < ARRAY_CARDINALITY(arch_info_xen) ; i++)
385 386 387 388 389 390 391 392 393
            /* Allow Xen 32-on-32, 32-on-64 and 64-on-64 */
            if (STREQ(arch_info_xen[i].arch, utsname.machine) ||
                (STREQ(utsname.machine, "x86_64") &&
                 STREQ(arch_info_xen[i].arch, "i686"))) {
                if (qemudCapsInitGuest(caps,
                                       utsname.machine,
                                       &arch_info_xen[i], 0) < 0)
                    goto no_memory;
            }
D
Daniel P. Berrange 已提交
394 395
    }

396 397 398 399 400
    return caps;

 no_memory:
    virCapabilitiesFree(caps);
    return NULL;
D
Daniel P. Berrange 已提交
401 402
}

403

404 405 406 407 408
int qemudExtractVersionInfo(const char *qemu,
                            unsigned int *retversion,
                            unsigned int *retflags) {
    const char *const qemuarg[] = { qemu, "-help", NULL };
    const char *const qemuenv[] = { "LC_ALL=C", NULL };
409
    pid_t child;
410
    int newstdout = -1;
411
    int ret = -1, status;
412 413 414 415 416 417 418 419 420 421 422 423
    unsigned int major, minor, micro;
    unsigned int version;
    unsigned int flags = 0;

    if (retflags)
        *retflags = 0;
    if (retversion)
        *retversion = 0;

    if (virExec(NULL, qemuarg, qemuenv, NULL,
                &child, -1, &newstdout, NULL, VIR_EXEC_NONE) < 0)
        return -1;
424

425 426 427 428 429
    char *help = NULL;
    enum { MAX_HELP_OUTPUT_SIZE = 8192 };
    int len = virFileReadLimFD(newstdout, MAX_HELP_OUTPUT_SIZE, &help);
    if (len < 0)
        goto cleanup2;
430

431 432 433
    if (sscanf(help, "QEMU PC emulator version %u.%u.%u",
               &major, &minor, &micro) != 3) {
        goto cleanup2;
434 435
    }

436
    version = (major * 1000 * 1000) + (minor * 1000) + micro;
437

438 439 440 441 442 443
    if (strstr(help, "-no-kqemu"))
        flags |= QEMUD_CMD_FLAG_KQEMU;
    if (strstr(help, "-no-reboot"))
        flags |= QEMUD_CMD_FLAG_NO_REBOOT;
    if (strstr(help, "-name"))
        flags |= QEMUD_CMD_FLAG_NAME;
444 445 446 447
    if (strstr(help, "-uuid"))
        flags |= QEMUD_CMD_FLAG_UUID;
    if (strstr(help, "-domid"))
        flags |= QEMUD_CMD_FLAG_DOMID;
448 449 450 451 452 453
    if (strstr(help, "-drive"))
        flags |= QEMUD_CMD_FLAG_DRIVE;
    if (strstr(help, "boot=on"))
        flags |= QEMUD_CMD_FLAG_DRIVE_BOOT;
    if (version >= 9000)
        flags |= QEMUD_CMD_FLAG_VNC_COLON;
454

455 456 457 458
    if (retversion)
        *retversion = version;
    if (retflags)
        *retflags = flags;
459

460
    ret = 0;
461

462 463
    qemudDebug("Version %d %d %d  Cooked version: %d, with flags ? %d",
               major, minor, micro, version, flags);
464

465
cleanup2:
466
    VIR_FREE(help);
467 468
    if (close(newstdout) < 0)
        ret = -1;
469

470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486
rewait:
    if (waitpid(child, &status, 0) != child) {
        if (errno == EINTR)
            goto rewait;

        qemudLog(QEMUD_ERR,
                 _("Unexpected exit status from qemu %d pid %lu"),
                 WEXITSTATUS(status), (unsigned long)child);
        ret = -1;
    }
    /* Check & log unexpected exit status, but don't fail,
     * as there's really no need to throw an error if we did
     * actually read a valid version number above */
    if (WEXITSTATUS(status) != 0) {
        qemudLog(QEMUD_WARN,
                 _("Unexpected exit status '%d', qemu probably failed"),
                 WEXITSTATUS(status));
487
    }
488 489

    return ret;
490 491
}

492
int qemudExtractVersion(virConnectPtr conn,
493 494
                        struct qemud_driver *driver) {
    const char *binary;
495
    struct stat sb;
496

497
    if (driver->qemuVersion > 0)
498 499
        return 0;

500 501
    if ((binary = virCapabilitiesDefaultGuestEmulator(driver->caps,
                                                      "hvm",
502 503 504
                                                      "i686",
                                                      "qemu")) == NULL)
        return -1;
505

506 507 508 509 510
    if (stat(binary, &sb) < 0) {
        qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                         _("Cannot find QEMU binary %s: %s"), binary,
                         strerror(errno));
        return -1;
511 512
    }

513
    if (qemudExtractVersionInfo(binary, &driver->qemuVersion, NULL) < 0) {
514 515
        return -1;
    }
D
Daniel P. Berrange 已提交
516

517
    return 0;
D
Daniel P. Berrange 已提交
518 519 520
}


521
static char *
522 523
qemudNetworkIfaceConnect(virConnectPtr conn,
                         struct qemud_driver *driver,
524 525 526
                         int **tapfds,
                         int *ntapfds,
                         virDomainNetDefPtr net,
527
                         int vlan)
528
{
529
    char *brname;
530 531 532 533 534
    char tapfdstr[4+3+32+7];
    char *retval = NULL;
    int err;
    int tapfd = -1;

535
    if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
536 537 538
        virNetworkPtr network = virNetworkLookupByName(conn,
                                                      net->data.network.name);
        if (!network) {
539
            qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
540
                             _("Network '%s' not found"),
541
                             net->data.network.name);
542
            goto error;
543 544 545 546 547 548
        }
        brname = virNetworkGetBridgeName(network);

        virNetworkFree(network);

        if (brname == NULL) {
549
            qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
550
                             _("Network '%s' is not active"),
551
                             net->data.network.name);
552 553
            goto error;
        }
554 555
    } else if (net->type == VIR_DOMAIN_NET_TYPE_BRIDGE) {
        brname = net->data.bridge.brname;
556
    } else {
557
        qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
558
                         _("Network type %d is not supported"), net->type);
559 560 561
        goto error;
    }

562 563 564 565 566 567 568 569 570 571
    if (!net->ifname ||
        STRPREFIX(net->ifname, "vnet") ||
        strchr(net->ifname, '%')) {
        VIR_FREE(net->ifname);
        if (!(net->ifname = strdup("vnet%d"))) {
            qemudReportError(conn, NULL, NULL, VIR_ERR_NO_MEMORY, NULL);
            goto error;
        }
    }

572
    if (!driver->brctl && (err = brInit(&driver->brctl))) {
573
        qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
574 575
                         _("cannot initialize bridge support: %s"),
                         strerror(err));
576 577 578
        goto error;
    }

579
    if ((err = brAddTap(driver->brctl, brname,
580
                        &net->ifname, &tapfd))) {
581 582 583 584 585 586 587 588 589
        if (errno == ENOTSUP) {
            /* In this particular case, give a better diagnostic. */
            qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                             _("Failed to add tap interface to bridge. "
                               "%s is not a bridge device"), brname);
        } else {
            qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                             _("Failed to add tap interface '%s' "
                               "to bridge '%s' : %s"),
590
                             net->ifname, brname, strerror(err));
591
        }
592 593 594
        goto error;
    }

595 596
    snprintf(tapfdstr, sizeof(tapfdstr),
             "tap,fd=%d,script=,vlan=%d,ifname=%s",
597
             tapfd, vlan, net->ifname);
598 599 600 601

    if (!(retval = strdup(tapfdstr)))
        goto no_memory;

602
    if (VIR_REALLOC_N(*tapfds, (*ntapfds)+1) < 0)
603 604
        goto no_memory;

605
    (*tapfds)[(*ntapfds)++] = tapfd;
606 607 608 609

    return retval;

 no_memory:
610 611
    qemudReportError(conn, NULL, NULL, VIR_ERR_NO_MEMORY,
                     "%s", _("failed to allocate space for tapfds string"));
612
 error:
613
    VIR_FREE(retval);
614 615 616 617 618
    if (tapfd != -1)
        close(tapfd);
    return NULL;
}

619
static int qemudBuildCommandLineChrDevStr(virDomainChrDefPtr dev,
620 621 622
                                          char *buf,
                                          int buflen)
{
623 624
    switch (dev->type) {
    case VIR_DOMAIN_CHR_TYPE_NULL:
625 626 627 628
        strncpy(buf, "null", buflen);
        buf[buflen-1] = '\0';
        break;

629
    case VIR_DOMAIN_CHR_TYPE_VC:
630 631 632 633
        strncpy(buf, "vc", buflen);
        buf[buflen-1] = '\0';
        break;

634
    case VIR_DOMAIN_CHR_TYPE_PTY:
635 636 637 638
        strncpy(buf, "pty", buflen);
        buf[buflen-1] = '\0';
        break;

639
    case VIR_DOMAIN_CHR_TYPE_DEV:
640
        if (snprintf(buf, buflen, "%s",
641
                     dev->data.file.path) >= buflen)
642 643 644
            return -1;
        break;

645
    case VIR_DOMAIN_CHR_TYPE_FILE:
646
        if (snprintf(buf, buflen, "file:%s",
647
                     dev->data.file.path) >= buflen)
648 649 650
            return -1;
        break;

651
    case VIR_DOMAIN_CHR_TYPE_PIPE:
652
        if (snprintf(buf, buflen, "pipe:%s",
653
                     dev->data.file.path) >= buflen)
654 655 656
            return -1;
        break;

657
    case VIR_DOMAIN_CHR_TYPE_STDIO:
658 659 660 661
        strncpy(buf, "stdio", buflen);
        buf[buflen-1] = '\0';
        break;

662
    case VIR_DOMAIN_CHR_TYPE_UDP:
663
        if (snprintf(buf, buflen, "udp:%s:%s@%s:%s",
664 665 666 667
                     dev->data.udp.connectHost,
                     dev->data.udp.connectService,
                     dev->data.udp.bindHost,
                     dev->data.udp.bindService) >= buflen)
668 669 670
            return -1;
        break;

671
    case VIR_DOMAIN_CHR_TYPE_TCP:
672 673 674 675 676 677 678 679 680 681 682 683 684
        if (dev->data.tcp.protocol == VIR_DOMAIN_CHR_TCP_PROTOCOL_TELNET) {
            if (snprintf(buf, buflen, "telnet:%s:%s%s",
                         dev->data.tcp.host,
                         dev->data.tcp.service,
                         dev->data.tcp.listen ? ",server" : "") >= buflen)
                return -1;
        } else {
            if (snprintf(buf, buflen, "tcp:%s:%s%s",
                         dev->data.tcp.host,
                         dev->data.tcp.service,
                         dev->data.tcp.listen ? ",listen" : "") >= buflen)
                return -1;
        }
685 686
        break;

687
    case VIR_DOMAIN_CHR_TYPE_UNIX:
688
        if (snprintf(buf, buflen, "unix:%s%s",
689 690
                     dev->data.nix.path,
                     dev->data.nix.listen ? ",listen" : "") >= buflen)
691 692 693 694 695 696 697
            return -1;
        break;
    }

    return 0;
}

D
Daniel P. Berrange 已提交
698 699 700 701
/*
 * Constructs a argv suitable for launching qemu with config defined
 * for a given virtual machine.
 */
702 703
int qemudBuildCommandLine(virConnectPtr conn,
                          struct qemud_driver *driver,
704
                          virDomainObjPtr vm,
705
                          unsigned int qemuCmdFlags,
706
                          const char ***retargv,
707
                          const char ***retenv,
708 709 710
                          int **tapfds,
                          int *ntapfds,
                          const char *migrateFrom) {
711
    int i;
D
Daniel P. Berrange 已提交
712 713
    char memory[50];
    char vcpus[50];
714
    char boot[VIR_DOMAIN_BOOT_LAST];
715 716
    struct utsname ut;
    int disableKQEMU = 0;
717
    int qargc = 0, qarga = 0;
718
    const char **qargv = NULL;
719 720
    int qenvc = 0, qenva = 0;
    const char **qenv = NULL;
721
    const char *emulator;
722 723
    char uuid[VIR_UUID_STRING_BUFLEN];
    char domid[50];
D
Daniel P. Berrange 已提交
724

725 726
    uname(&ut);

D
Daniel P. Berrange 已提交
727
    /* Nasty hack make i?86 look like i686 to simplify next comparison */
728 729 730 731
    if (ut.machine[0] == 'i' &&
        ut.machine[2] == '8' &&
        ut.machine[3] == '6' &&
        !ut.machine[4])
D
Daniel P. Berrange 已提交
732
        ut.machine[1] = '6';
733

734 735
    virUUIDFormat(vm->def->uuid, uuid);

736 737 738 739 740
    /* Need to explicitly disable KQEMU if
     * 1. Arch matches host arch
     * 2. Guest is 'qemu'
     * 3. The qemu binary has the -no-kqemu flag
     */
741
    if ((qemuCmdFlags & QEMUD_CMD_FLAG_KQEMU) &&
742
        STREQ(ut.machine, vm->def->os.arch) &&
743
        vm->def->virtType == VIR_DOMAIN_VIRT_QEMU)
744 745
        disableKQEMU = 1;

746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766
#define ADD_ARG_SPACE                                                   \
    do { \
        if (qargc == qarga) {                                           \
            qarga += 10;                                                \
            if (VIR_REALLOC_N(qargv, qarga) < 0)                        \
                goto no_memory;                                         \
        }                                                               \
    } while (0)

#define ADD_ARG(thisarg)                                                \
    do {                                                                \
        ADD_ARG_SPACE;                                                  \
        qargv[qargc++] = thisarg;                                       \
    } while (0)

#define ADD_ARG_LIT(thisarg)                                            \
    do {                                                                \
        ADD_ARG_SPACE;                                                  \
        if ((qargv[qargc++] = strdup(thisarg)) == NULL)                 \
            goto no_memory;                                             \
    } while (0)
D
Daniel P. Berrange 已提交
767

768 769 770 771
#define ADD_USBDISK(thisarg)                                            \
    do {                                                                \
        ADD_ARG_LIT("-usbdevice");                                      \
        ADD_ARG_SPACE;                                                  \
772 773
        if ((asprintf((char **)&(qargv[qargc++]),                       \
                      "disk:%s", thisarg)) == -1) {                     \
774 775 776 777 778
            qargv[qargc-1] = NULL;                                      \
            goto no_memory;                                             \
        }                                                               \
    } while (0)

779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812
#define ADD_ENV_SPACE                                                   \
    do {                                                                \
        if (qenvc == qenva) {                                           \
            qenva += 10;                                                \
            if (VIR_REALLOC_N(qenv, qenva) < 0)                         \
                goto no_memory;                                         \
        }                                                               \
    } while (0)

#define ADD_ENV(thisarg)                                                \
    do {                                                                \
        ADD_ENV_SPACE;                                                  \
        qenv[qenvc++] = thisarg;                                        \
    } while (0)

#define ADD_ENV_LIT(thisarg)                                            \
    do {                                                                \
        ADD_ENV_SPACE;                                                  \
        if ((qenv[qenvc++] = strdup(thisarg)) == NULL)                  \
            goto no_memory;                                             \
    } while (0)

#define ADD_ENV_COPY(envname)                                           \
    do {                                                                \
        char *val = getenv(envname);                                    \
        char *envval;                                                   \
        ADD_ENV_SPACE;                                                  \
        if (val != NULL) {                                              \
            if (asprintf(&envval, "%s=%s", envname, val) < 0)           \
                goto no_memory;                                         \
            qenv[qenvc++] = envval;                                     \
        }                                                               \
    } while (0)

813
    snprintf(memory, sizeof(memory), "%lu", vm->def->memory/1024);
814
    snprintf(vcpus, sizeof(vcpus), "%lu", vm->def->vcpus);
815
    snprintf(domid, sizeof(domid), "%d", vm->def->id);
D
Daniel P. Berrange 已提交
816

817 818 819 820 821 822 823 824 825 826
    ADD_ENV_LIT("LC_ALL=C");

    ADD_ENV_COPY("LD_PRELOAD");
    ADD_ENV_COPY("LD_LIBRARY_PATH");
    ADD_ENV_COPY("PATH");
    ADD_ENV_COPY("HOME");
    ADD_ENV_COPY("USER");
    ADD_ENV_COPY("LOGNAME");
    ADD_ENV_COPY("TMPDIR");

827 828 829 830 831
    emulator = vm->def->emulator;
    if (!emulator)
        emulator = virDomainDefDefaultEmulator(conn, vm->def, driver->caps);
    if (!emulator)
        return -1;
832

833
    ADD_ARG_LIT(emulator);
834 835 836 837 838 839 840 841 842
    ADD_ARG_LIT("-S");
    ADD_ARG_LIT("-M");
    ADD_ARG_LIT(vm->def->os.machine);
    if (disableKQEMU)
        ADD_ARG_LIT("-no-kqemu");
    ADD_ARG_LIT("-m");
    ADD_ARG_LIT(memory);
    ADD_ARG_LIT("-smp");
    ADD_ARG_LIT(vcpus);
D
Daniel P. Berrange 已提交
843

844
    if (qemuCmdFlags & QEMUD_CMD_FLAG_NAME) {
845 846
        ADD_ARG_LIT("-name");
        ADD_ARG_LIT(vm->def->name);
847
    }
848 849 850 851 852 853 854 855 856
    if (qemuCmdFlags & QEMUD_CMD_FLAG_UUID) {
        ADD_ARG_LIT("-uuid");
        ADD_ARG_LIT(uuid);
    }
    if (qemuCmdFlags & QEMUD_CMD_FLAG_DOMID) {
        ADD_ARG_LIT("-domid");
        ADD_ARG_LIT(domid);
    }

857 858 859 860 861 862 863
    /*
     * NB, -nographic *MUST* come before any serial, or monitor
     * or parallel port flags due to QEMU craziness, where it
     * decides to change the serial port & monitor to be on stdout
     * if you ask for nographic. So we have to make sure we override
     * these defaults ourselves...
     */
864
    if (!vm->def->graphics)
865
        ADD_ARG_LIT("-nographic");
866

867 868
    ADD_ARG_LIT("-monitor");
    ADD_ARG_LIT("pty");
D
Daniel P. Berrange 已提交
869

870 871
    if (vm->def->localtime)
        ADD_ARG_LIT("-localtime");
872

873 874
    if ((qemuCmdFlags & QEMUD_CMD_FLAG_NO_REBOOT) &&
        vm->def->onReboot != VIR_DOMAIN_LIFECYCLE_RESTART)
875
        ADD_ARG_LIT("-no-reboot");
D
Daniel P. Berrange 已提交
876

877
    if (!(vm->def->features & (1 << VIR_DOMAIN_FEATURE_ACPI)))
878
        ADD_ARG_LIT("-no-acpi");
D
Daniel P. Berrange 已提交
879

880
    if (!vm->def->os.bootloader) {
D
Daniel P. Berrange 已提交
881 882
        for (i = 0 ; i < vm->def->os.nBootDevs ; i++) {
            switch (vm->def->os.bootDevs[i]) {
883
            case VIR_DOMAIN_BOOT_CDROM:
D
Daniel P. Berrange 已提交
884 885
                boot[i] = 'd';
                break;
886
            case VIR_DOMAIN_BOOT_FLOPPY:
D
Daniel P. Berrange 已提交
887 888
                boot[i] = 'a';
                break;
889
            case VIR_DOMAIN_BOOT_DISK:
D
Daniel P. Berrange 已提交
890 891
                boot[i] = 'c';
                break;
892
            case VIR_DOMAIN_BOOT_NET:
D
Daniel P. Berrange 已提交
893 894 895 896 897 898 899 900
                boot[i] = 'n';
                break;
            default:
                boot[i] = 'c';
                break;
            }
        }
        boot[vm->def->os.nBootDevs] = '\0';
901 902
        ADD_ARG_LIT("-boot");
        ADD_ARG_LIT(boot);
D
Daniel P. Berrange 已提交
903

904
        if (vm->def->os.kernel) {
905 906
            ADD_ARG_LIT("-kernel");
            ADD_ARG_LIT(vm->def->os.kernel);
D
Daniel P. Berrange 已提交
907
        }
908
        if (vm->def->os.initrd) {
909 910
            ADD_ARG_LIT("-initrd");
            ADD_ARG_LIT(vm->def->os.initrd);
D
Daniel P. Berrange 已提交
911
        }
912
        if (vm->def->os.cmdline) {
913 914
            ADD_ARG_LIT("-append");
            ADD_ARG_LIT(vm->def->os.cmdline);
D
Daniel P. Berrange 已提交
915 916
        }
    } else {
917 918
        ADD_ARG_LIT("-bootloader");
        ADD_ARG_LIT(vm->def->os.bootloader);
D
Daniel P. Berrange 已提交
919 920
    }

921
    /* If QEMU supports -drive param instead of old -hda, -hdb, -cdrom .. */
922
    if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE) {
923 924 925
        int bootCD = 0, bootFloppy = 0, bootDisk = 0;

        /* If QEMU supports boot=on for -drive param... */
926
        if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE_BOOT) {
927 928
            for (i = 0 ; i < vm->def->os.nBootDevs ; i++) {
                switch (vm->def->os.bootDevs[i]) {
929
                case VIR_DOMAIN_BOOT_CDROM:
930 931
                    bootCD = 1;
                    break;
932
                case VIR_DOMAIN_BOOT_FLOPPY:
933 934
                    bootFloppy = 1;
                    break;
935
                case VIR_DOMAIN_BOOT_DISK:
936 937 938
                    bootDisk = 1;
                    break;
                }
939
            }
940
        }
D
Daniel P. Berrange 已提交
941

942
        for (i = 0 ; i < vm->def->ndisks ; i++) {
943 944 945
            char opt[PATH_MAX];
            const char *media = NULL;
            int bootable = 0;
946
            virDomainDiskDefPtr disk = vm->def->disks[i];
947
            int idx = virDiskNameToIndex(disk->dst);
948
            const char *bus = virDomainDiskQEMUBusTypeToString(disk->bus);
D
Daniel P. Berrange 已提交
949

950 951 952 953 954 955 956 957 958 959 960
            if (disk->bus == VIR_DOMAIN_DISK_BUS_USB) {
                if (disk->device == VIR_DOMAIN_DISK_DEVICE_DISK) {
                    ADD_USBDISK(disk->src);
                } else {
                    qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                     _("unsupported usb disk type for '%s'"), disk->src);
                    goto error;
                }
                continue;
            }

961 962 963 964 965 966 967
            if (idx < 0) {
                qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                 _("unsupported disk type '%s'"), disk->dst);
                goto error;
            }

            switch (disk->device) {
968
            case VIR_DOMAIN_DISK_DEVICE_CDROM:
969 970
                bootable = bootCD;
                bootCD = 0;
971
                media = "media=cdrom,";
972
                break;
973
            case VIR_DOMAIN_DISK_DEVICE_FLOPPY:
974 975 976
                bootable = bootFloppy;
                bootFloppy = 0;
                break;
977
            case VIR_DOMAIN_DISK_DEVICE_DISK:
978 979 980 981 982
                bootable = bootDisk;
                bootDisk = 0;
                break;
            }

983
            snprintf(opt, PATH_MAX, "file=%s,if=%s,%sindex=%d%s%s",
984
                     disk->src ? disk->src : "", bus,
985 986
                     media ? media : "",
                     idx,
987 988
                     bootable &&
                     disk->device == VIR_DOMAIN_DISK_DEVICE_DISK
989 990 991
                     ? ",boot=on" : "",
                     disk->shared && ! disk->readonly
                     ? ",cache=off" : "");
992

993 994
            ADD_ARG_LIT("-drive");
            ADD_ARG_LIT(opt);
995 996
        }
    } else {
997
        for (i = 0 ; i < vm->def->ndisks ; i++) {
998 999
            char dev[NAME_MAX];
            char file[PATH_MAX];
1000
            virDomainDiskDefPtr disk = vm->def->disks[i];
1001

1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012
            if (disk->bus == VIR_DOMAIN_DISK_BUS_USB) {
                if (disk->device == VIR_DOMAIN_DISK_DEVICE_DISK) {
                    ADD_USBDISK(disk->src);
                } else {
                    qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                     _("unsupported usb disk type for '%s'"), disk->src);
                    goto error;
                }
                continue;
            }

1013
            if (STREQ(disk->dst, "hdc") &&
1014 1015
                disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM) {
                if (disk->src) {
1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032
                    snprintf(dev, NAME_MAX, "-%s", "cdrom");
                } else {
                    continue;
                }
            } else {
                if (STRPREFIX(disk->dst, "hd") ||
                    STRPREFIX(disk->dst, "fd")) {
                    snprintf(dev, NAME_MAX, "-%s", disk->dst);
                } else {
                    qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                     _("unsupported disk type '%s'"), disk->dst);
                    goto error;
                }
            }

            snprintf(file, PATH_MAX, "%s", disk->src);

1033 1034
            ADD_ARG_LIT(dev);
            ADD_ARG_LIT(file);
1035
        }
D
Daniel P. Berrange 已提交
1036 1037
    }

1038
    if (!vm->def->nnets) {
1039 1040
        ADD_ARG_LIT("-net");
        ADD_ARG_LIT("none");
D
Daniel P. Berrange 已提交
1041
    } else {
1042
        int vlan = 0;
1043
        for (i = 0 ; i < vm->def->nnets ; i++) {
1044
            char nic[100];
1045
            virDomainNetDefPtr net = vm->def->nets[i];
1046

1047 1048
            if (snprintf(nic, sizeof(nic),
                         "nic,macaddr=%02x:%02x:%02x:%02x:%02x:%02x,vlan=%d%s%s",
1049 1050 1051
                         net->mac[0], net->mac[1],
                         net->mac[2], net->mac[3],
                         net->mac[4], net->mac[5],
1052
                         vlan,
1053 1054
                         (net->model ? ",model=" : ""),
                         (net->model ? net->model : "")) >= sizeof(nic))
1055
                goto error;
D
Daniel P. Berrange 已提交
1056

1057 1058 1059
            ADD_ARG_LIT("-net");
            ADD_ARG_LIT(nic);
            ADD_ARG_LIT("-net");
1060

1061
            switch (net->type) {
1062 1063
            case VIR_DOMAIN_NET_TYPE_NETWORK:
            case VIR_DOMAIN_NET_TYPE_BRIDGE:
1064
                {
1065 1066 1067
                    char *tap = qemudNetworkIfaceConnect(conn, driver,
                                                         tapfds, ntapfds,
                                                         net, vlan);
1068 1069 1070 1071 1072
                    if (tap == NULL)
                        goto error;
                    ADD_ARG(tap);
                    break;
                }
1073

1074
            case VIR_DOMAIN_NET_TYPE_ETHERNET:
1075 1076 1077
                {
                    char arg[PATH_MAX];
                    if (snprintf(arg, PATH_MAX-1, "tap,ifname=%s,script=%s,vlan=%d",
1078 1079
                                 net->ifname,
                                 net->data.ethernet.script,
1080 1081 1082
                                 vlan) >= (PATH_MAX-1))
                        goto error;

1083
                    ADD_ARG_LIT(arg);
1084 1085 1086
                }
                break;

1087 1088 1089
            case VIR_DOMAIN_NET_TYPE_CLIENT:
            case VIR_DOMAIN_NET_TYPE_SERVER:
            case VIR_DOMAIN_NET_TYPE_MCAST:
1090 1091 1092 1093
                {
                    char arg[PATH_MAX];
                    const char *mode = NULL;
                    switch (net->type) {
1094
                    case VIR_DOMAIN_NET_TYPE_CLIENT:
1095 1096
                        mode = "connect";
                        break;
1097
                    case VIR_DOMAIN_NET_TYPE_SERVER:
1098 1099
                        mode = "listen";
                        break;
1100
                    case VIR_DOMAIN_NET_TYPE_MCAST:
1101 1102 1103 1104 1105
                        mode = "mcast";
                        break;
                    }
                    if (snprintf(arg, PATH_MAX-1, "socket,%s=%s:%d,vlan=%d",
                                 mode,
1106 1107
                                 net->data.socket.address,
                                 net->data.socket.port,
1108 1109 1110
                                 vlan) >= (PATH_MAX-1))
                        goto error;

1111
                    ADD_ARG_LIT(arg);
1112 1113 1114
                }
                break;

1115
            case VIR_DOMAIN_NET_TYPE_USER:
1116 1117 1118 1119 1120 1121
            default:
                {
                    char arg[PATH_MAX];
                    if (snprintf(arg, PATH_MAX-1, "user,vlan=%d", vlan) >= (PATH_MAX-1))
                        goto error;

1122
                    ADD_ARG_LIT(arg);
1123
                }
1124
            }
D
Daniel P. Berrange 已提交
1125

1126
            vlan++;
D
Daniel P. Berrange 已提交
1127 1128 1129
        }
    }

1130
    if (!vm->def->nserials) {
1131 1132
        ADD_ARG_LIT("-serial");
        ADD_ARG_LIT("none");
1133
    } else {
1134
        for (i = 0 ; i < vm->def->nserials ; i++) {
1135
            char buf[4096];
1136
            virDomainChrDefPtr serial = vm->def->serials[i];
1137 1138 1139 1140

            if (qemudBuildCommandLineChrDevStr(serial, buf, sizeof(buf)) < 0)
                goto error;

1141 1142
            ADD_ARG_LIT("-serial");
            ADD_ARG_LIT(buf);
1143 1144 1145
        }
    }

1146
    if (!vm->def->nparallels) {
1147 1148
        ADD_ARG_LIT("-parallel");
        ADD_ARG_LIT("none");
1149
    } else {
1150
        for (i = 0 ; i < vm->def->nparallels ; i++) {
1151
            char buf[4096];
1152
            virDomainChrDefPtr parallel = vm->def->parallels[i];
1153 1154 1155 1156

            if (qemudBuildCommandLineChrDevStr(parallel, buf, sizeof(buf)) < 0)
                goto error;

1157 1158
            ADD_ARG_LIT("-parallel");
            ADD_ARG_LIT(buf);
1159 1160 1161
        }
    }

1162
    ADD_ARG_LIT("-usb");
1163 1164 1165
    for (i = 0 ; i < vm->def->ninputs ; i++) {
        virDomainInputDefPtr input = vm->def->inputs[i];

1166
        if (input->bus == VIR_DOMAIN_INPUT_BUS_USB) {
1167
            ADD_ARG_LIT("-usbdevice");
1168
            ADD_ARG_LIT(input->type == VIR_DOMAIN_INPUT_TYPE_MOUSE ? "mouse" : "tablet");
1169 1170 1171
        }
    }

1172 1173
    if (vm->def->graphics &&
        vm->def->graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC) {
D
Daniel P. Berrange 已提交
1174
        char vncdisplay[PATH_MAX];
1175
        int ret;
D
Daniel P. Berrange 已提交
1176

1177
        if (qemuCmdFlags & QEMUD_CMD_FLAG_VNC_COLON) {
D
Daniel P. Berrange 已提交
1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190
            char options[PATH_MAX] = "";
            if (driver->vncTLS) {
                strcat(options, ",tls");
                if (driver->vncTLSx509verify) {
                    strcat(options, ",x509verify=");
                } else {
                    strcat(options, ",x509=");
                }
                strncat(options, driver->vncTLSx509certdir,
                        sizeof(options) - (strlen(driver->vncTLSx509certdir)-1));
                options[sizeof(options)-1] = '\0';
            }
            ret = snprintf(vncdisplay, sizeof(vncdisplay), "%s:%d%s",
D
Daniel P. Berrange 已提交
1191 1192 1193
                           (vm->def->graphics->data.vnc.listenAddr ?
                            vm->def->graphics->data.vnc.listenAddr :
                            (driver->vncListen ? driver->vncListen : "")),
1194
                           vm->def->graphics->data.vnc.port - 5900,
D
Daniel P. Berrange 已提交
1195 1196
                           options);
        } else {
1197
            ret = snprintf(vncdisplay, sizeof(vncdisplay), "%d",
1198
                           vm->def->graphics->data.vnc.port - 5900);
D
Daniel P. Berrange 已提交
1199
        }
1200
        if (ret < 0 || ret >= (int)sizeof(vncdisplay))
1201 1202
            goto error;

1203 1204
        ADD_ARG_LIT("-vnc");
        ADD_ARG_LIT(vncdisplay);
1205
        if (vm->def->graphics->data.vnc.keymap) {
1206
            ADD_ARG_LIT("-k");
1207
            ADD_ARG_LIT(vm->def->graphics->data.vnc.keymap);
1208
        }
1209 1210
    } else if (vm->def->graphics &&
               vm->def->graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL) {
1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228
        char *xauth = NULL;
        char *display = NULL;

        if (vm->def->graphics->data.sdl.xauth &&
            asprintf(&xauth, "XAUTHORITY=%s",
                     vm->def->graphics->data.sdl.xauth) < 0)
            goto no_memory;
        if (vm->def->graphics->data.sdl.display &&
            asprintf(&display, "DISPLAY=%s",
                     vm->def->graphics->data.sdl.display) < 0) {
            VIR_FREE(xauth);
            goto no_memory;
        }

        if (xauth)
            ADD_ENV(xauth);
        if (display)
            ADD_ENV(display);
D
Daniel P. Berrange 已提交
1229 1230
    }

D
Daniel Veillard 已提交
1231
    /* Add sound hardware */
1232
    if (vm->def->nsounds) {
D
Daniel Veillard 已提交
1233
        int size = 100;
1234 1235
        char *modstr;
        if (VIR_ALLOC_N(modstr, size+1) < 0)
D
Daniel Veillard 已提交
1236 1237
            goto no_memory;

1238 1239
        for (i = 0 ; i < vm->def->nsounds && size > 0 ; i++) {
            virDomainSoundDefPtr sound = vm->def->sounds[i];
1240
            const char *model = virDomainSoundModelTypeToString(sound->model);
D
Daniel Veillard 已提交
1241
            if (!model) {
1242
                VIR_FREE(modstr);
1243 1244 1245
                qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                 "%s", _("invalid sound model"));
                goto error;
D
Daniel Veillard 已提交
1246 1247 1248
            }
            strncat(modstr, model, size);
            size -= strlen(model);
1249
            if (i < (vm->def->nsounds - 1))
D
Daniel Veillard 已提交
1250 1251
               strncat(modstr, ",", size--);
        }
1252 1253
        ADD_ARG_LIT("-soundhw");
        ADD_ARG(modstr);
D
Daniel Veillard 已提交
1254 1255
    }

1256
    /* Add host passthrough hardware */
1257
    for (i = 0 ; i < vm->def->nhostdevs ; i++) {
1258 1259
        int ret;
        char* usbdev;
1260
        virDomainHostdevDefPtr hostdev = vm->def->hostdevs[i];
1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283

        if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
            hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) {
            if(hostdev->source.subsys.usb.vendor) {
                    ret = asprintf(&usbdev, "host:%.4x:%.4x",
                               hostdev->source.subsys.usb.vendor,
                               hostdev->source.subsys.usb.product);

            } else {
                    ret = asprintf(&usbdev, "host:%.3d.%.3d",
                               hostdev->source.subsys.usb.bus,
                               hostdev->source.subsys.usb.device);
            }
            if (ret < 0) {
                usbdev = NULL;
                goto error;
            }
            ADD_ARG_LIT("-usbdevice");
            ADD_ARG_LIT(usbdev);
            VIR_FREE(usbdev);
        }
    }

1284
    if (migrateFrom) {
1285
        ADD_ARG_LIT("-incoming");
1286
        ADD_ARG_LIT(migrateFrom);
1287 1288
    }

1289
    ADD_ARG(NULL);
1290
    ADD_ENV(NULL);
D
Daniel P. Berrange 已提交
1291

1292
    *retargv = qargv;
1293
    *retenv = qenv;
D
Daniel P. Berrange 已提交
1294 1295 1296
    return 0;

 no_memory:
1297 1298
    qemudReportError(conn, NULL, NULL, VIR_ERR_NO_MEMORY,
                     "%s", _("failed to allocate space for argv string"));
1299
 error:
1300 1301
    if (tapfds &&
        *tapfds) {
1302
        for (i = 0; i < *ntapfds; i++)
1303 1304 1305
            close((*tapfds)[i]);
        VIR_FREE(*tapfds);
        *ntapfds = 0;
1306
    }
1307 1308
    if (qargv) {
        for (i = 0 ; i < qargc ; i++)
1309 1310
            VIR_FREE((qargv)[i]);
        VIR_FREE(qargv);
D
Daniel P. Berrange 已提交
1311
    }
1312 1313 1314 1315 1316
    if (qenv) {
        for (i = 0 ; i < qenvc ; i++)
            VIR_FREE((qenv)[i]);
        VIR_FREE(qenv);
    }
D
Daniel P. Berrange 已提交
1317
    return -1;
1318 1319 1320 1321

#undef ADD_ARG
#undef ADD_ARG_LIT
#undef ADD_ARG_SPACE
1322 1323 1324 1325 1326
#undef ADD_USBDISK
#undef ADD_ENV
#undef ADD_ENV_COPY
#undef ADD_ENV_LIT
#undef ADD_ENV_SPACE
D
Daniel P. Berrange 已提交
1327
}