qemu_conf.c 42.3 KB
Newer Older
D
Daniel P. Berrange 已提交
1 2 3
/*
 * config.c: VM configuration management
 *
4
 * Copyright (C) 2006, 2007, 2008 Red Hat, Inc.
D
Daniel P. Berrange 已提交
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

24
#include <config.h>
25

D
Daniel P. Berrange 已提交
26 27 28 29 30
#include <dirent.h>
#include <string.h>
#include <limits.h>
#include <sys/types.h>
#include <sys/stat.h>
31
#include <stdlib.h>
D
Daniel P. Berrange 已提交
32 33 34
#include <unistd.h>
#include <errno.h>
#include <fcntl.h>
35
#include <sys/wait.h>
36
#include <arpa/inet.h>
37
#include <sys/utsname.h>
D
Daniel P. Berrange 已提交
38

39 40 41 42
#if HAVE_NUMACTL
#include <numa.h>
#endif

43
#include "qemu_conf.h"
44
#include "uuid.h"
45
#include "buf.h"
D
Daniel P. Berrange 已提交
46
#include "conf.h"
47
#include "util.h"
48
#include "memory.h"
J
Jim Meyering 已提交
49
#include "verify.h"
50 51 52 53 54 55 56

VIR_ENUM_DECL(virDomainDiskQEMUBus)
VIR_ENUM_IMPL(virDomainDiskQEMUBus, VIR_DOMAIN_DISK_BUS_LAST,
              "ide",
              "floppy",
              "scsi",
              "virtio",
57 58
              "xen",
              "usb")
59

60

61 62
#define qemudLog(level, msg...) fprintf(stderr, msg)

D
Daniel P. Berrange 已提交
63 64 65 66 67 68
int qemudLoadDriverConfig(struct qemud_driver *driver,
                          const char *filename) {
    virConfPtr conf;
    virConfValuePtr p;

    /* Setup 2 critical defaults */
69 70 71 72 73
    if (!(driver->vncListen = strdup("127.0.0.1"))) {
        qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
                         "%s", _("failed to allocate vncListen"));
        return -1;
    }
D
Daniel P. Berrange 已提交
74 75
    if (!(driver->vncTLSx509certdir = strdup(SYSCONF_DIR "/pki/libvirt-vnc"))) {
        qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
76
                         "%s", _("failed to allocate vncTLSx509certdir"));
D
Daniel P. Berrange 已提交
77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107
        return -1;
    }

    /* Just check the file is readable before opening it, otherwise
     * libvirt emits an error.
     */
    if (access (filename, R_OK) == -1) return 0;

    conf = virConfReadFile (filename);
    if (!conf) return 0;


#define CHECK_TYPE(name,typ) if (p && p->type != (typ)) {               \
        qemudReportError(NULL, NULL, NULL, VIR_ERR_INTERNAL_ERROR,      \
                         "remoteReadConfigFile: %s: %s: expected type " #typ "\n", \
                         filename, (name));                             \
        virConfFree(conf);                                              \
        return -1;                                                      \
    }

    p = virConfGetValue (conf, "vnc_tls");
    CHECK_TYPE ("vnc_tls", VIR_CONF_LONG);
    if (p) driver->vncTLS = p->l;

    p = virConfGetValue (conf, "vnc_tls_x509_verify");
    CHECK_TYPE ("vnc_tls_x509_verify", VIR_CONF_LONG);
    if (p) driver->vncTLSx509verify = p->l;

    p = virConfGetValue (conf, "vnc_tls_x509_cert_dir");
    CHECK_TYPE ("vnc_tls_x509_cert_dir", VIR_CONF_STRING);
    if (p && p->str) {
108
        VIR_FREE(driver->vncTLSx509certdir);
D
Daniel P. Berrange 已提交
109 110
        if (!(driver->vncTLSx509certdir = strdup(p->str))) {
            qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
111
                             "%s", _("failed to allocate vncTLSx509certdir"));
D
Daniel P. Berrange 已提交
112 113 114 115 116 117 118 119
            virConfFree(conf);
            return -1;
        }
    }

    p = virConfGetValue (conf, "vnc_listen");
    CHECK_TYPE ("vnc_listen", VIR_CONF_STRING);
    if (p && p->str) {
120 121 122 123 124 125
        if (!(driver->vncListen = strdup(p->str))) {
            qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
                             "%s", _("failed to allocate vncTLSx509certdir"));
            virConfFree(conf);
            return -1;
        }
D
Daniel P. Berrange 已提交
126 127 128 129 130 131
    }

    virConfFree (conf);
    return 0;
}

D
Daniel P. Berrange 已提交
132 133
/* The list of possible machine types for various architectures,
   as supported by QEMU - taken from 'qemu -M ?' for each arch */
134 135
static const char *const arch_info_hvm_x86_machines[] = {
    "pc", "isapc"
D
Daniel P. Berrange 已提交
136
};
137 138
static const char *const arch_info_hvm_mips_machines[] = {
    "mips"
D
Daniel P. Berrange 已提交
139
};
140 141
static const char *const arch_info_hvm_sparc_machines[] = {
    "sun4m"
D
Daniel P. Berrange 已提交
142
};
143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164
static const char *const arch_info_hvm_ppc_machines[] = {
    "g3bw", "mac99", "prep"
};

static const char *const arch_info_xen_x86_machines[] = {
    "xenner"
};

struct qemu_feature_flags {
    const char *name;
    const int default_on;
    const int toggle;
};

struct qemu_arch_info {
    const char *arch;
    int wordsize;
    const char *const *machines;
    int nmachines;
    const char *binary;
    const struct qemu_feature_flags *flags;
    int nflags;
D
Daniel P. Berrange 已提交
165 166
};

167
/* Feature flags for the architecture info */
J
Jim Meyering 已提交
168
static const struct qemu_feature_flags const arch_info_i686_flags [] = {
169 170
    { "pae",  1, 0 },
    { "nonpae",  1, 0 },
171 172 173 174
    { "acpi", 1, 1 },
    { "apic", 1, 0 },
};

J
Jim Meyering 已提交
175
static const struct qemu_feature_flags const arch_info_x86_64_flags [] = {
176 177 178 179
    { "acpi", 1, 1 },
    { "apic", 1, 0 },
};

D
Daniel P. Berrange 已提交
180
/* The archicture tables for supported QEMU archs */
181 182 183 184 185 186 187 188 189 190 191 192 193
static const struct qemu_arch_info const arch_info_hvm[] = {
    {  "i686", 32, arch_info_hvm_x86_machines, 2,
       "/usr/bin/qemu", arch_info_i686_flags, 4 },
    {  "x86_64", 64, arch_info_hvm_x86_machines, 2,
       "/usr/bin/qemu-system-x86_64", arch_info_x86_64_flags, 2 },
    {  "mips", 32, arch_info_hvm_mips_machines, 1,
       "/usr/bin/qemu-system-mips", NULL, 0 },
    {  "mipsel", 32, arch_info_hvm_mips_machines, 1,
       "/usr/bin/qemu-system-mipsel", NULL, 0 },
    {  "sparc", 32, arch_info_hvm_sparc_machines, 1,
       "/usr/bin/qemu-system-sparc", NULL, 0 },
    {  "ppc", 32, arch_info_hvm_ppc_machines, 3,
       "/usr/bin/qemu-system-ppc", NULL, 0 },
D
Daniel P. Berrange 已提交
194 195
};

196 197 198 199 200 201
static const struct qemu_arch_info const arch_info_xen[] = {
    {  "i686", 32, arch_info_xen_x86_machines, 1,
       "/usr/bin/xenner", arch_info_i686_flags, 4 },
    {  "x86_64", 64, arch_info_xen_x86_machines, 1,
       "/usr/bin/xenner", arch_info_x86_64_flags, 2 },
};
D
Daniel P. Berrange 已提交
202

203 204 205 206 207 208
static int
qemudCapsInitGuest(virCapsPtr caps,
                   const char *hostmachine,
                   const struct qemu_arch_info *info,
                   int hvm) {
    virCapsGuestPtr guest;
209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231
    int i, haskvm, hasbase, samearch;
    const char *kvmbin = NULL;

    /* Check for existance of base emulator */
    hasbase = (access(info->binary, X_OK) == 0);

    samearch = STREQ(info->arch, hostmachine);
    if (samearch) {
        const char *const kvmbins[] = { "/usr/bin/qemu-kvm", /* Fedora */
                                        "/usr/bin/kvm" }; /* Upstream .spec */

        for (i = 0; i < ARRAY_CARDINALITY(kvmbins); ++i) {
            if ((haskvm = (access(kvmbins[i], X_OK) == 0))) {
                kvmbin = kvmbins[i];
                break;
            }
        }
    } else {
        haskvm = 0;
    }

    if (!hasbase && !haskvm)
        return 0;
D
Daniel P. Berrange 已提交
232

233 234 235 236 237 238 239 240 241
    if ((guest = virCapabilitiesAddGuest(caps,
                                         hvm ? "hvm" : "xen",
                                         info->arch,
                                         info->wordsize,
                                         info->binary,
                                         NULL,
                                         info->nmachines,
                                         info->machines)) == NULL)
        return -1;
D
Daniel P. Berrange 已提交
242

243
    if (hvm) {
244
        if (hasbase &&
245 246 247 248 249 250 251
            virCapabilitiesAddGuestDomain(guest,
                                          "qemu",
                                          NULL,
                                          NULL,
                                          0,
                                          NULL) == NULL)
            return -1;
D
Daniel P. Berrange 已提交
252

253
        /* If guest & host match, then we can accelerate */
254
        if (samearch) {
255 256 257 258 259 260 261 262 263 264
            if (access("/dev/kqemu", F_OK) == 0 &&
                virCapabilitiesAddGuestDomain(guest,
                                              "kqemu",
                                              NULL,
                                              NULL,
                                              0,
                                              NULL) == NULL)
                return -1;

            if (access("/dev/kvm", F_OK) == 0 &&
265
                haskvm &&
266 267
                virCapabilitiesAddGuestDomain(guest,
                                              "kvm",
268
                                              kvmbin,
269 270 271 272 273 274 275 276 277 278 279 280 281 282
                                              NULL,
                                              0,
                                              NULL) == NULL)
                return -1;
        }
    } else {
        if (virCapabilitiesAddGuestDomain(guest,
                                          "kvm",
                                          NULL,
                                          NULL,
                                          0,
                                          NULL) == NULL)
            return -1;
    }
D
Daniel P. Berrange 已提交
283

284 285 286 287 288 289 290
    if (info->nflags) {
        for (i = 0 ; i < info->nflags ; i++) {
            if (virCapabilitiesAddGuestFeature(guest,
                                               info->flags[i].name,
                                               info->flags[i].default_on,
                                               info->flags[i].toggle) == NULL)
                return -1;
D
Daniel P. Berrange 已提交
291 292 293
        }
    }

294
    return 0;
D
Daniel P. Berrange 已提交
295 296
}

297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355
#if HAVE_NUMACTL
#define MAX_CPUS 4096
#define MAX_CPUS_MASK_SIZE (sizeof(unsigned long))
#define MAX_CPUS_MASK_LEN (MAX_CPUS / MAX_CPUS_MASK_SIZE)
#define MAX_CPUS_MASK_BYTES (MAX_CPUS / 8)

#define MASK_CPU_ISSET(mask, cpu) \
    (((mask)[((cpu) / MAX_CPUS_MASK_SIZE)] >> ((cpu) % MAX_CPUS_MASK_SIZE)) & 1)

static int
qemudCapsInitNUMA(virCapsPtr caps)
{
    int n, i;
    unsigned long *mask = NULL;
    int ncpus;
    int *cpus = NULL;
    int ret = -1;

    if (numa_available() < 0)
        return 0;

    if (VIR_ALLOC_N(mask, MAX_CPUS_MASK_LEN) < 0)
        goto cleanup;

    for (n = 0 ; n <= numa_max_node() ; n++) {
        if (numa_node_to_cpus(n, mask, MAX_CPUS_MASK_BYTES) < 0)
            goto cleanup;

        for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++)
            if (MASK_CPU_ISSET(mask, i))
                ncpus++;

        if (VIR_ALLOC_N(cpus, ncpus) < 0)
            goto cleanup;

        for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++)
            if (MASK_CPU_ISSET(mask, i))
                cpus[ncpus++] = i;

        if (virCapabilitiesAddHostNUMACell(caps,
                                           n,
                                           ncpus,
                                           cpus) < 0)
            goto cleanup;

        VIR_FREE(cpus);
    }

    ret = 0;

cleanup:
    VIR_FREE(cpus);
    VIR_FREE(mask);
    return ret;
}
#else
static int qemudCapsInitNUMA(virCapsPtr caps ATTRIBUTE_UNUSED) { return 0; }
#endif

356 357 358 359
virCapsPtr qemudCapsInit(void) {
    struct utsname utsname;
    virCapsPtr caps;
    int i;
D
Daniel P. Berrange 已提交
360

361 362 363 364 365 366 367
    /* Really, this never fails - look at the man-page. */
    uname (&utsname);

    if ((caps = virCapabilitiesNew(utsname.machine,
                                   0, 0)) == NULL)
        goto no_memory;

368 369 370
    /* Using KVM's mac prefix for QEMU too */
    virCapabilitiesSetMacPrefix(caps, (unsigned char[]){ 0x52, 0x54, 0x00 });

371 372 373
    if (qemudCapsInitNUMA(caps) < 0)
        goto no_memory;

J
Jim Meyering 已提交
374
    for (i = 0 ; i < ARRAY_CARDINALITY(arch_info_hvm) ; i++)
375 376 377 378 379 380 381
        if (qemudCapsInitGuest(caps,
                               utsname.machine,
                               &arch_info_hvm[i], 1) < 0)
            goto no_memory;

    if (access("/usr/bin/xenner", X_OK) == 0 &&
        access("/dev/kvm", F_OK) == 0) {
J
Jim Meyering 已提交
382
        for (i = 0 ; i < ARRAY_CARDINALITY(arch_info_xen) ; i++)
383 384 385 386 387 388 389 390 391
            /* Allow Xen 32-on-32, 32-on-64 and 64-on-64 */
            if (STREQ(arch_info_xen[i].arch, utsname.machine) ||
                (STREQ(utsname.machine, "x86_64") &&
                 STREQ(arch_info_xen[i].arch, "i686"))) {
                if (qemudCapsInitGuest(caps,
                                       utsname.machine,
                                       &arch_info_xen[i], 0) < 0)
                    goto no_memory;
            }
D
Daniel P. Berrange 已提交
392 393
    }

394 395 396 397 398
    return caps;

 no_memory:
    virCapabilitiesFree(caps);
    return NULL;
D
Daniel P. Berrange 已提交
399 400
}

401

402 403 404 405 406
int qemudExtractVersionInfo(const char *qemu,
                            unsigned int *retversion,
                            unsigned int *retflags) {
    const char *const qemuarg[] = { qemu, "-help", NULL };
    const char *const qemuenv[] = { "LC_ALL=C", NULL };
407
    pid_t child;
408
    int newstdout = -1;
409
    int ret = -1, status;
410 411 412 413 414 415 416 417 418 419 420 421
    unsigned int major, minor, micro;
    unsigned int version;
    unsigned int flags = 0;

    if (retflags)
        *retflags = 0;
    if (retversion)
        *retversion = 0;

    if (virExec(NULL, qemuarg, qemuenv, NULL,
                &child, -1, &newstdout, NULL, VIR_EXEC_NONE) < 0)
        return -1;
422

423 424 425 426 427
    char *help = NULL;
    enum { MAX_HELP_OUTPUT_SIZE = 8192 };
    int len = virFileReadLimFD(newstdout, MAX_HELP_OUTPUT_SIZE, &help);
    if (len < 0)
        goto cleanup2;
428

429 430 431
    if (sscanf(help, "QEMU PC emulator version %u.%u.%u",
               &major, &minor, &micro) != 3) {
        goto cleanup2;
432 433
    }

434
    version = (major * 1000 * 1000) + (minor * 1000) + micro;
435

436 437 438 439 440 441 442 443 444 445 446 447
    if (strstr(help, "-no-kqemu"))
        flags |= QEMUD_CMD_FLAG_KQEMU;
    if (strstr(help, "-no-reboot"))
        flags |= QEMUD_CMD_FLAG_NO_REBOOT;
    if (strstr(help, "-name"))
        flags |= QEMUD_CMD_FLAG_NAME;
    if (strstr(help, "-drive"))
        flags |= QEMUD_CMD_FLAG_DRIVE;
    if (strstr(help, "boot=on"))
        flags |= QEMUD_CMD_FLAG_DRIVE_BOOT;
    if (version >= 9000)
        flags |= QEMUD_CMD_FLAG_VNC_COLON;
448

449 450 451 452
    if (retversion)
        *retversion = version;
    if (retflags)
        *retflags = flags;
453

454
    ret = 0;
455

456 457
    qemudDebug("Version %d %d %d  Cooked version: %d, with flags ? %d",
               major, minor, micro, version, flags);
458

459
cleanup2:
460
    VIR_FREE(help);
461 462
    if (close(newstdout) < 0)
        ret = -1;
463

464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480
rewait:
    if (waitpid(child, &status, 0) != child) {
        if (errno == EINTR)
            goto rewait;

        qemudLog(QEMUD_ERR,
                 _("Unexpected exit status from qemu %d pid %lu"),
                 WEXITSTATUS(status), (unsigned long)child);
        ret = -1;
    }
    /* Check & log unexpected exit status, but don't fail,
     * as there's really no need to throw an error if we did
     * actually read a valid version number above */
    if (WEXITSTATUS(status) != 0) {
        qemudLog(QEMUD_WARN,
                 _("Unexpected exit status '%d', qemu probably failed"),
                 WEXITSTATUS(status));
481
    }
482 483

    return ret;
484 485
}

486
int qemudExtractVersion(virConnectPtr conn,
487 488
                        struct qemud_driver *driver) {
    const char *binary;
489
    struct stat sb;
490

491
    if (driver->qemuVersion > 0)
492 493
        return 0;

494 495
    if ((binary = virCapabilitiesDefaultGuestEmulator(driver->caps,
                                                      "hvm",
496 497 498
                                                      "i686",
                                                      "qemu")) == NULL)
        return -1;
499

500 501 502 503 504
    if (stat(binary, &sb) < 0) {
        qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                         _("Cannot find QEMU binary %s: %s"), binary,
                         strerror(errno));
        return -1;
505 506
    }

507
    if (qemudExtractVersionInfo(binary, &driver->qemuVersion, NULL) < 0) {
508 509
        return -1;
    }
D
Daniel P. Berrange 已提交
510

511
    return 0;
D
Daniel P. Berrange 已提交
512 513 514
}


515
static char *
516 517
qemudNetworkIfaceConnect(virConnectPtr conn,
                         struct qemud_driver *driver,
518 519 520
                         int **tapfds,
                         int *ntapfds,
                         virDomainNetDefPtr net,
521
                         int vlan)
522
{
523
    char *brname;
524 525 526 527 528
    char tapfdstr[4+3+32+7];
    char *retval = NULL;
    int err;
    int tapfd = -1;

529
    if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
530 531 532
        virNetworkPtr network = virNetworkLookupByName(conn,
                                                      net->data.network.name);
        if (!network) {
533
            qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
534
                             _("Network '%s' not found"),
535
                             net->data.network.name);
536
            goto error;
537 538 539 540 541 542
        }
        brname = virNetworkGetBridgeName(network);

        virNetworkFree(network);

        if (brname == NULL) {
543
            qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
544
                             _("Network '%s' is not active"),
545
                             net->data.network.name);
546 547
            goto error;
        }
548 549
    } else if (net->type == VIR_DOMAIN_NET_TYPE_BRIDGE) {
        brname = net->data.bridge.brname;
550
    } else {
551
        qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
552
                         _("Network type %d is not supported"), net->type);
553 554 555
        goto error;
    }

556 557 558 559 560 561 562 563 564 565
    if (!net->ifname ||
        STRPREFIX(net->ifname, "vnet") ||
        strchr(net->ifname, '%')) {
        VIR_FREE(net->ifname);
        if (!(net->ifname = strdup("vnet%d"))) {
            qemudReportError(conn, NULL, NULL, VIR_ERR_NO_MEMORY, NULL);
            goto error;
        }
    }

566
    if (!driver->brctl && (err = brInit(&driver->brctl))) {
567
        qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
568 569
                         _("cannot initialize bridge support: %s"),
                         strerror(err));
570 571 572
        goto error;
    }

573
    if ((err = brAddTap(driver->brctl, brname,
574
                        &net->ifname, &tapfd))) {
575 576 577 578 579 580 581 582 583
        if (errno == ENOTSUP) {
            /* In this particular case, give a better diagnostic. */
            qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                             _("Failed to add tap interface to bridge. "
                               "%s is not a bridge device"), brname);
        } else {
            qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                             _("Failed to add tap interface '%s' "
                               "to bridge '%s' : %s"),
584
                             net->ifname, brname, strerror(err));
585
        }
586 587 588
        goto error;
    }

589 590
    snprintf(tapfdstr, sizeof(tapfdstr),
             "tap,fd=%d,script=,vlan=%d,ifname=%s",
591
             tapfd, vlan, net->ifname);
592 593 594 595

    if (!(retval = strdup(tapfdstr)))
        goto no_memory;

596
    if (VIR_REALLOC_N(*tapfds, (*ntapfds)+1) < 0)
597 598
        goto no_memory;

599
    (*tapfds)[(*ntapfds)++] = tapfd;
600 601 602 603

    return retval;

 no_memory:
604 605
    qemudReportError(conn, NULL, NULL, VIR_ERR_NO_MEMORY,
                     "%s", _("failed to allocate space for tapfds string"));
606
 error:
607
    VIR_FREE(retval);
608 609 610 611 612
    if (tapfd != -1)
        close(tapfd);
    return NULL;
}

613
static int qemudBuildCommandLineChrDevStr(virDomainChrDefPtr dev,
614 615 616
                                          char *buf,
                                          int buflen)
{
617 618
    switch (dev->type) {
    case VIR_DOMAIN_CHR_TYPE_NULL:
619 620 621 622
        strncpy(buf, "null", buflen);
        buf[buflen-1] = '\0';
        break;

623
    case VIR_DOMAIN_CHR_TYPE_VC:
624 625 626 627
        strncpy(buf, "vc", buflen);
        buf[buflen-1] = '\0';
        break;

628
    case VIR_DOMAIN_CHR_TYPE_PTY:
629 630 631 632
        strncpy(buf, "pty", buflen);
        buf[buflen-1] = '\0';
        break;

633
    case VIR_DOMAIN_CHR_TYPE_DEV:
634
        if (snprintf(buf, buflen, "%s",
635
                     dev->data.file.path) >= buflen)
636 637 638
            return -1;
        break;

639
    case VIR_DOMAIN_CHR_TYPE_FILE:
640
        if (snprintf(buf, buflen, "file:%s",
641
                     dev->data.file.path) >= buflen)
642 643 644
            return -1;
        break;

645
    case VIR_DOMAIN_CHR_TYPE_PIPE:
646
        if (snprintf(buf, buflen, "pipe:%s",
647
                     dev->data.file.path) >= buflen)
648 649 650
            return -1;
        break;

651
    case VIR_DOMAIN_CHR_TYPE_STDIO:
652 653 654 655
        strncpy(buf, "stdio", buflen);
        buf[buflen-1] = '\0';
        break;

656
    case VIR_DOMAIN_CHR_TYPE_UDP:
657
        if (snprintf(buf, buflen, "udp:%s:%s@%s:%s",
658 659 660 661
                     dev->data.udp.connectHost,
                     dev->data.udp.connectService,
                     dev->data.udp.bindHost,
                     dev->data.udp.bindService) >= buflen)
662 663 664
            return -1;
        break;

665
    case VIR_DOMAIN_CHR_TYPE_TCP:
666 667 668 669 670 671 672 673 674 675 676 677 678
        if (dev->data.tcp.protocol == VIR_DOMAIN_CHR_TCP_PROTOCOL_TELNET) {
            if (snprintf(buf, buflen, "telnet:%s:%s%s",
                         dev->data.tcp.host,
                         dev->data.tcp.service,
                         dev->data.tcp.listen ? ",server" : "") >= buflen)
                return -1;
        } else {
            if (snprintf(buf, buflen, "tcp:%s:%s%s",
                         dev->data.tcp.host,
                         dev->data.tcp.service,
                         dev->data.tcp.listen ? ",listen" : "") >= buflen)
                return -1;
        }
679 680
        break;

681
    case VIR_DOMAIN_CHR_TYPE_UNIX:
682
        if (snprintf(buf, buflen, "unix:%s%s",
683 684
                     dev->data.nix.path,
                     dev->data.nix.listen ? ",listen" : "") >= buflen)
685 686 687 688 689 690 691
            return -1;
        break;
    }

    return 0;
}

D
Daniel P. Berrange 已提交
692 693 694 695
/*
 * Constructs a argv suitable for launching qemu with config defined
 * for a given virtual machine.
 */
696 697
int qemudBuildCommandLine(virConnectPtr conn,
                          struct qemud_driver *driver,
698
                          virDomainObjPtr vm,
699
                          unsigned int qemuCmdFlags,
700
                          const char ***retargv,
701
                          const char ***retenv,
702 703 704
                          int **tapfds,
                          int *ntapfds,
                          const char *migrateFrom) {
705
    int i;
D
Daniel P. Berrange 已提交
706 707
    char memory[50];
    char vcpus[50];
708
    char boot[VIR_DOMAIN_BOOT_LAST];
709 710
    struct utsname ut;
    int disableKQEMU = 0;
711
    int qargc = 0, qarga = 0;
712
    const char **qargv = NULL;
713 714
    int qenvc = 0, qenva = 0;
    const char **qenv = NULL;
715
    const char *emulator;
D
Daniel P. Berrange 已提交
716

717 718
    uname(&ut);

D
Daniel P. Berrange 已提交
719
    /* Nasty hack make i?86 look like i686 to simplify next comparison */
720 721 722 723
    if (ut.machine[0] == 'i' &&
        ut.machine[2] == '8' &&
        ut.machine[3] == '6' &&
        !ut.machine[4])
D
Daniel P. Berrange 已提交
724
        ut.machine[1] = '6';
725 726 727 728 729 730

    /* Need to explicitly disable KQEMU if
     * 1. Arch matches host arch
     * 2. Guest is 'qemu'
     * 3. The qemu binary has the -no-kqemu flag
     */
731
    if ((qemuCmdFlags & QEMUD_CMD_FLAG_KQEMU) &&
732
        STREQ(ut.machine, vm->def->os.arch) &&
733
        vm->def->virtType == VIR_DOMAIN_VIRT_QEMU)
734 735
        disableKQEMU = 1;

736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756
#define ADD_ARG_SPACE                                                   \
    do { \
        if (qargc == qarga) {                                           \
            qarga += 10;                                                \
            if (VIR_REALLOC_N(qargv, qarga) < 0)                        \
                goto no_memory;                                         \
        }                                                               \
    } while (0)

#define ADD_ARG(thisarg)                                                \
    do {                                                                \
        ADD_ARG_SPACE;                                                  \
        qargv[qargc++] = thisarg;                                       \
    } while (0)

#define ADD_ARG_LIT(thisarg)                                            \
    do {                                                                \
        ADD_ARG_SPACE;                                                  \
        if ((qargv[qargc++] = strdup(thisarg)) == NULL)                 \
            goto no_memory;                                             \
    } while (0)
D
Daniel P. Berrange 已提交
757

758 759 760 761
#define ADD_USBDISK(thisarg)                                            \
    do {                                                                \
        ADD_ARG_LIT("-usbdevice");                                      \
        ADD_ARG_SPACE;                                                  \
762 763
        if ((asprintf((char **)&(qargv[qargc++]),                       \
                      "disk:%s", thisarg)) == -1) {                     \
764 765 766 767 768
            qargv[qargc-1] = NULL;                                      \
            goto no_memory;                                             \
        }                                                               \
    } while (0)

769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802
#define ADD_ENV_SPACE                                                   \
    do {                                                                \
        if (qenvc == qenva) {                                           \
            qenva += 10;                                                \
            if (VIR_REALLOC_N(qenv, qenva) < 0)                         \
                goto no_memory;                                         \
        }                                                               \
    } while (0)

#define ADD_ENV(thisarg)                                                \
    do {                                                                \
        ADD_ENV_SPACE;                                                  \
        qenv[qenvc++] = thisarg;                                        \
    } while (0)

#define ADD_ENV_LIT(thisarg)                                            \
    do {                                                                \
        ADD_ENV_SPACE;                                                  \
        if ((qenv[qenvc++] = strdup(thisarg)) == NULL)                  \
            goto no_memory;                                             \
    } while (0)

#define ADD_ENV_COPY(envname)                                           \
    do {                                                                \
        char *val = getenv(envname);                                    \
        char *envval;                                                   \
        ADD_ENV_SPACE;                                                  \
        if (val != NULL) {                                              \
            if (asprintf(&envval, "%s=%s", envname, val) < 0)           \
                goto no_memory;                                         \
            qenv[qenvc++] = envval;                                     \
        }                                                               \
    } while (0)

803
    snprintf(memory, sizeof(memory), "%lu", vm->def->memory/1024);
804
    snprintf(vcpus, sizeof(vcpus), "%lu", vm->def->vcpus);
D
Daniel P. Berrange 已提交
805

806 807 808 809 810 811 812 813 814 815
    ADD_ENV_LIT("LC_ALL=C");

    ADD_ENV_COPY("LD_PRELOAD");
    ADD_ENV_COPY("LD_LIBRARY_PATH");
    ADD_ENV_COPY("PATH");
    ADD_ENV_COPY("HOME");
    ADD_ENV_COPY("USER");
    ADD_ENV_COPY("LOGNAME");
    ADD_ENV_COPY("TMPDIR");

816 817 818 819 820
    emulator = vm->def->emulator;
    if (!emulator)
        emulator = virDomainDefDefaultEmulator(conn, vm->def, driver->caps);
    if (!emulator)
        return -1;
821

822
    ADD_ARG_LIT(emulator);
823 824 825 826 827 828 829 830 831
    ADD_ARG_LIT("-S");
    ADD_ARG_LIT("-M");
    ADD_ARG_LIT(vm->def->os.machine);
    if (disableKQEMU)
        ADD_ARG_LIT("-no-kqemu");
    ADD_ARG_LIT("-m");
    ADD_ARG_LIT(memory);
    ADD_ARG_LIT("-smp");
    ADD_ARG_LIT(vcpus);
D
Daniel P. Berrange 已提交
832

833
    if (qemuCmdFlags & QEMUD_CMD_FLAG_NAME) {
834 835
        ADD_ARG_LIT("-name");
        ADD_ARG_LIT(vm->def->name);
836
    }
837 838 839 840 841 842 843
    /*
     * NB, -nographic *MUST* come before any serial, or monitor
     * or parallel port flags due to QEMU craziness, where it
     * decides to change the serial port & monitor to be on stdout
     * if you ask for nographic. So we have to make sure we override
     * these defaults ourselves...
     */
844
    if (!vm->def->graphics)
845
        ADD_ARG_LIT("-nographic");
846

847 848
    ADD_ARG_LIT("-monitor");
    ADD_ARG_LIT("pty");
D
Daniel P. Berrange 已提交
849

850 851
    if (vm->def->localtime)
        ADD_ARG_LIT("-localtime");
852

853 854
    if ((qemuCmdFlags & QEMUD_CMD_FLAG_NO_REBOOT) &&
        vm->def->onReboot != VIR_DOMAIN_LIFECYCLE_RESTART)
855
        ADD_ARG_LIT("-no-reboot");
D
Daniel P. Berrange 已提交
856

857
    if (!(vm->def->features & (1 << VIR_DOMAIN_FEATURE_ACPI)))
858
        ADD_ARG_LIT("-no-acpi");
D
Daniel P. Berrange 已提交
859

860
    if (!vm->def->os.bootloader) {
D
Daniel P. Berrange 已提交
861 862
        for (i = 0 ; i < vm->def->os.nBootDevs ; i++) {
            switch (vm->def->os.bootDevs[i]) {
863
            case VIR_DOMAIN_BOOT_CDROM:
D
Daniel P. Berrange 已提交
864 865
                boot[i] = 'd';
                break;
866
            case VIR_DOMAIN_BOOT_FLOPPY:
D
Daniel P. Berrange 已提交
867 868
                boot[i] = 'a';
                break;
869
            case VIR_DOMAIN_BOOT_DISK:
D
Daniel P. Berrange 已提交
870 871
                boot[i] = 'c';
                break;
872
            case VIR_DOMAIN_BOOT_NET:
D
Daniel P. Berrange 已提交
873 874 875 876 877 878 879 880
                boot[i] = 'n';
                break;
            default:
                boot[i] = 'c';
                break;
            }
        }
        boot[vm->def->os.nBootDevs] = '\0';
881 882
        ADD_ARG_LIT("-boot");
        ADD_ARG_LIT(boot);
D
Daniel P. Berrange 已提交
883

884
        if (vm->def->os.kernel) {
885 886
            ADD_ARG_LIT("-kernel");
            ADD_ARG_LIT(vm->def->os.kernel);
D
Daniel P. Berrange 已提交
887
        }
888
        if (vm->def->os.initrd) {
889 890
            ADD_ARG_LIT("-initrd");
            ADD_ARG_LIT(vm->def->os.initrd);
D
Daniel P. Berrange 已提交
891
        }
892
        if (vm->def->os.cmdline) {
893 894
            ADD_ARG_LIT("-append");
            ADD_ARG_LIT(vm->def->os.cmdline);
D
Daniel P. Berrange 已提交
895 896
        }
    } else {
897 898
        ADD_ARG_LIT("-bootloader");
        ADD_ARG_LIT(vm->def->os.bootloader);
D
Daniel P. Berrange 已提交
899 900
    }

901
    /* If QEMU supports -drive param instead of old -hda, -hdb, -cdrom .. */
902
    if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE) {
903 904 905
        int bootCD = 0, bootFloppy = 0, bootDisk = 0;

        /* If QEMU supports boot=on for -drive param... */
906
        if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE_BOOT) {
907 908
            for (i = 0 ; i < vm->def->os.nBootDevs ; i++) {
                switch (vm->def->os.bootDevs[i]) {
909
                case VIR_DOMAIN_BOOT_CDROM:
910 911
                    bootCD = 1;
                    break;
912
                case VIR_DOMAIN_BOOT_FLOPPY:
913 914
                    bootFloppy = 1;
                    break;
915
                case VIR_DOMAIN_BOOT_DISK:
916 917 918
                    bootDisk = 1;
                    break;
                }
919
            }
920
        }
D
Daniel P. Berrange 已提交
921

922
        for (i = 0 ; i < vm->def->ndisks ; i++) {
923 924 925
            char opt[PATH_MAX];
            const char *media = NULL;
            int bootable = 0;
926
            virDomainDiskDefPtr disk = vm->def->disks[i];
927
            int idx = virDiskNameToIndex(disk->dst);
928
            const char *bus = virDomainDiskQEMUBusTypeToString(disk->bus);
D
Daniel P. Berrange 已提交
929

930 931 932 933 934 935 936 937 938 939 940
            if (disk->bus == VIR_DOMAIN_DISK_BUS_USB) {
                if (disk->device == VIR_DOMAIN_DISK_DEVICE_DISK) {
                    ADD_USBDISK(disk->src);
                } else {
                    qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                     _("unsupported usb disk type for '%s'"), disk->src);
                    goto error;
                }
                continue;
            }

941 942 943 944 945 946 947
            if (idx < 0) {
                qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                 _("unsupported disk type '%s'"), disk->dst);
                goto error;
            }

            switch (disk->device) {
948
            case VIR_DOMAIN_DISK_DEVICE_CDROM:
949 950
                bootable = bootCD;
                bootCD = 0;
951
                media = "media=cdrom,";
952
                break;
953
            case VIR_DOMAIN_DISK_DEVICE_FLOPPY:
954 955 956
                bootable = bootFloppy;
                bootFloppy = 0;
                break;
957
            case VIR_DOMAIN_DISK_DEVICE_DISK:
958 959 960 961 962 963
                bootable = bootDisk;
                bootDisk = 0;
                break;
            }

            snprintf(opt, PATH_MAX, "file=%s,if=%s,%sindex=%d%s",
964
                     disk->src ? disk->src : "", bus,
965 966
                     media ? media : "",
                     idx,
967 968
                     bootable &&
                     disk->device == VIR_DOMAIN_DISK_DEVICE_DISK
969
                     ? ",boot=on" : "");
970

971 972
            ADD_ARG_LIT("-drive");
            ADD_ARG_LIT(opt);
973 974
        }
    } else {
975
        for (i = 0 ; i < vm->def->ndisks ; i++) {
976 977
            char dev[NAME_MAX];
            char file[PATH_MAX];
978
            virDomainDiskDefPtr disk = vm->def->disks[i];
979

980 981 982 983 984 985 986 987 988 989 990
            if (disk->bus == VIR_DOMAIN_DISK_BUS_USB) {
                if (disk->device == VIR_DOMAIN_DISK_DEVICE_DISK) {
                    ADD_USBDISK(disk->src);
                } else {
                    qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                     _("unsupported usb disk type for '%s'"), disk->src);
                    goto error;
                }
                continue;
            }

991
            if (STREQ(disk->dst, "hdc") &&
992 993
                disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM) {
                if (disk->src) {
994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010
                    snprintf(dev, NAME_MAX, "-%s", "cdrom");
                } else {
                    continue;
                }
            } else {
                if (STRPREFIX(disk->dst, "hd") ||
                    STRPREFIX(disk->dst, "fd")) {
                    snprintf(dev, NAME_MAX, "-%s", disk->dst);
                } else {
                    qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                     _("unsupported disk type '%s'"), disk->dst);
                    goto error;
                }
            }

            snprintf(file, PATH_MAX, "%s", disk->src);

1011 1012
            ADD_ARG_LIT(dev);
            ADD_ARG_LIT(file);
1013
        }
D
Daniel P. Berrange 已提交
1014 1015
    }

1016
    if (!vm->def->nnets) {
1017 1018
        ADD_ARG_LIT("-net");
        ADD_ARG_LIT("none");
D
Daniel P. Berrange 已提交
1019
    } else {
1020
        int vlan = 0;
1021
        for (i = 0 ; i < vm->def->nnets ; i++) {
1022
            char nic[100];
1023
            virDomainNetDefPtr net = vm->def->nets[i];
1024

1025 1026
            if (snprintf(nic, sizeof(nic),
                         "nic,macaddr=%02x:%02x:%02x:%02x:%02x:%02x,vlan=%d%s%s",
1027 1028 1029
                         net->mac[0], net->mac[1],
                         net->mac[2], net->mac[3],
                         net->mac[4], net->mac[5],
1030
                         vlan,
1031 1032
                         (net->model ? ",model=" : ""),
                         (net->model ? net->model : "")) >= sizeof(nic))
1033
                goto error;
D
Daniel P. Berrange 已提交
1034

1035 1036 1037
            ADD_ARG_LIT("-net");
            ADD_ARG_LIT(nic);
            ADD_ARG_LIT("-net");
1038

1039
            switch (net->type) {
1040 1041
            case VIR_DOMAIN_NET_TYPE_NETWORK:
            case VIR_DOMAIN_NET_TYPE_BRIDGE:
1042
                {
1043 1044 1045
                    char *tap = qemudNetworkIfaceConnect(conn, driver,
                                                         tapfds, ntapfds,
                                                         net, vlan);
1046 1047 1048 1049 1050
                    if (tap == NULL)
                        goto error;
                    ADD_ARG(tap);
                    break;
                }
1051

1052
            case VIR_DOMAIN_NET_TYPE_ETHERNET:
1053 1054 1055
                {
                    char arg[PATH_MAX];
                    if (snprintf(arg, PATH_MAX-1, "tap,ifname=%s,script=%s,vlan=%d",
1056 1057
                                 net->ifname,
                                 net->data.ethernet.script,
1058 1059 1060
                                 vlan) >= (PATH_MAX-1))
                        goto error;

1061
                    ADD_ARG_LIT(arg);
1062 1063 1064
                }
                break;

1065 1066 1067
            case VIR_DOMAIN_NET_TYPE_CLIENT:
            case VIR_DOMAIN_NET_TYPE_SERVER:
            case VIR_DOMAIN_NET_TYPE_MCAST:
1068 1069 1070 1071
                {
                    char arg[PATH_MAX];
                    const char *mode = NULL;
                    switch (net->type) {
1072
                    case VIR_DOMAIN_NET_TYPE_CLIENT:
1073 1074
                        mode = "connect";
                        break;
1075
                    case VIR_DOMAIN_NET_TYPE_SERVER:
1076 1077
                        mode = "listen";
                        break;
1078
                    case VIR_DOMAIN_NET_TYPE_MCAST:
1079 1080 1081 1082 1083
                        mode = "mcast";
                        break;
                    }
                    if (snprintf(arg, PATH_MAX-1, "socket,%s=%s:%d,vlan=%d",
                                 mode,
1084 1085
                                 net->data.socket.address,
                                 net->data.socket.port,
1086 1087 1088
                                 vlan) >= (PATH_MAX-1))
                        goto error;

1089
                    ADD_ARG_LIT(arg);
1090 1091 1092
                }
                break;

1093
            case VIR_DOMAIN_NET_TYPE_USER:
1094 1095 1096 1097 1098 1099
            default:
                {
                    char arg[PATH_MAX];
                    if (snprintf(arg, PATH_MAX-1, "user,vlan=%d", vlan) >= (PATH_MAX-1))
                        goto error;

1100
                    ADD_ARG_LIT(arg);
1101
                }
1102
            }
D
Daniel P. Berrange 已提交
1103

1104
            vlan++;
D
Daniel P. Berrange 已提交
1105 1106 1107
        }
    }

1108
    if (!vm->def->nserials) {
1109 1110
        ADD_ARG_LIT("-serial");
        ADD_ARG_LIT("none");
1111
    } else {
1112
        for (i = 0 ; i < vm->def->nserials ; i++) {
1113
            char buf[4096];
1114
            virDomainChrDefPtr serial = vm->def->serials[i];
1115 1116 1117 1118

            if (qemudBuildCommandLineChrDevStr(serial, buf, sizeof(buf)) < 0)
                goto error;

1119 1120
            ADD_ARG_LIT("-serial");
            ADD_ARG_LIT(buf);
1121 1122 1123
        }
    }

1124
    if (!vm->def->nparallels) {
1125 1126
        ADD_ARG_LIT("-parallel");
        ADD_ARG_LIT("none");
1127
    } else {
1128
        for (i = 0 ; i < vm->def->nparallels ; i++) {
1129
            char buf[4096];
1130
            virDomainChrDefPtr parallel = vm->def->parallels[i];
1131 1132 1133 1134

            if (qemudBuildCommandLineChrDevStr(parallel, buf, sizeof(buf)) < 0)
                goto error;

1135 1136
            ADD_ARG_LIT("-parallel");
            ADD_ARG_LIT(buf);
1137 1138 1139
        }
    }

1140
    ADD_ARG_LIT("-usb");
1141 1142 1143
    for (i = 0 ; i < vm->def->ninputs ; i++) {
        virDomainInputDefPtr input = vm->def->inputs[i];

1144
        if (input->bus == VIR_DOMAIN_INPUT_BUS_USB) {
1145
            ADD_ARG_LIT("-usbdevice");
1146
            ADD_ARG_LIT(input->type == VIR_DOMAIN_INPUT_TYPE_MOUSE ? "mouse" : "tablet");
1147 1148 1149
        }
    }

1150 1151
    if (vm->def->graphics &&
        vm->def->graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC) {
D
Daniel P. Berrange 已提交
1152
        char vncdisplay[PATH_MAX];
1153
        int ret;
D
Daniel P. Berrange 已提交
1154

1155
        if (qemuCmdFlags & QEMUD_CMD_FLAG_VNC_COLON) {
D
Daniel P. Berrange 已提交
1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168
            char options[PATH_MAX] = "";
            if (driver->vncTLS) {
                strcat(options, ",tls");
                if (driver->vncTLSx509verify) {
                    strcat(options, ",x509verify=");
                } else {
                    strcat(options, ",x509=");
                }
                strncat(options, driver->vncTLSx509certdir,
                        sizeof(options) - (strlen(driver->vncTLSx509certdir)-1));
                options[sizeof(options)-1] = '\0';
            }
            ret = snprintf(vncdisplay, sizeof(vncdisplay), "%s:%d%s",
D
Daniel P. Berrange 已提交
1169 1170 1171
                           (vm->def->graphics->data.vnc.listenAddr ?
                            vm->def->graphics->data.vnc.listenAddr :
                            (driver->vncListen ? driver->vncListen : "")),
1172
                           vm->def->graphics->data.vnc.port - 5900,
D
Daniel P. Berrange 已提交
1173 1174
                           options);
        } else {
1175
            ret = snprintf(vncdisplay, sizeof(vncdisplay), "%d",
1176
                           vm->def->graphics->data.vnc.port - 5900);
D
Daniel P. Berrange 已提交
1177
        }
1178
        if (ret < 0 || ret >= (int)sizeof(vncdisplay))
1179 1180
            goto error;

1181 1182
        ADD_ARG_LIT("-vnc");
        ADD_ARG_LIT(vncdisplay);
1183
        if (vm->def->graphics->data.vnc.keymap) {
1184
            ADD_ARG_LIT("-k");
1185
            ADD_ARG_LIT(vm->def->graphics->data.vnc.keymap);
1186
        }
1187 1188
    } else if (vm->def->graphics &&
               vm->def->graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL) {
1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206
        char *xauth = NULL;
        char *display = NULL;

        if (vm->def->graphics->data.sdl.xauth &&
            asprintf(&xauth, "XAUTHORITY=%s",
                     vm->def->graphics->data.sdl.xauth) < 0)
            goto no_memory;
        if (vm->def->graphics->data.sdl.display &&
            asprintf(&display, "DISPLAY=%s",
                     vm->def->graphics->data.sdl.display) < 0) {
            VIR_FREE(xauth);
            goto no_memory;
        }

        if (xauth)
            ADD_ENV(xauth);
        if (display)
            ADD_ENV(display);
D
Daniel P. Berrange 已提交
1207 1208
    }

D
Daniel Veillard 已提交
1209
    /* Add sound hardware */
1210
    if (vm->def->nsounds) {
D
Daniel Veillard 已提交
1211
        int size = 100;
1212 1213
        char *modstr;
        if (VIR_ALLOC_N(modstr, size+1) < 0)
D
Daniel Veillard 已提交
1214 1215
            goto no_memory;

1216 1217
        for (i = 0 ; i < vm->def->nsounds && size > 0 ; i++) {
            virDomainSoundDefPtr sound = vm->def->sounds[i];
1218
            const char *model = virDomainSoundModelTypeToString(sound->model);
D
Daniel Veillard 已提交
1219
            if (!model) {
1220
                VIR_FREE(modstr);
1221 1222 1223
                qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                 "%s", _("invalid sound model"));
                goto error;
D
Daniel Veillard 已提交
1224 1225 1226
            }
            strncat(modstr, model, size);
            size -= strlen(model);
1227
            if (i < (vm->def->nsounds - 1))
D
Daniel Veillard 已提交
1228 1229
               strncat(modstr, ",", size--);
        }
1230 1231
        ADD_ARG_LIT("-soundhw");
        ADD_ARG(modstr);
D
Daniel Veillard 已提交
1232 1233
    }

1234
    /* Add host passthrough hardware */
1235
    for (i = 0 ; i < vm->def->nhostdevs ; i++) {
1236 1237
        int ret;
        char* usbdev;
1238
        virDomainHostdevDefPtr hostdev = vm->def->hostdevs[i];
1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261

        if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
            hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) {
            if(hostdev->source.subsys.usb.vendor) {
                    ret = asprintf(&usbdev, "host:%.4x:%.4x",
                               hostdev->source.subsys.usb.vendor,
                               hostdev->source.subsys.usb.product);

            } else {
                    ret = asprintf(&usbdev, "host:%.3d.%.3d",
                               hostdev->source.subsys.usb.bus,
                               hostdev->source.subsys.usb.device);
            }
            if (ret < 0) {
                usbdev = NULL;
                goto error;
            }
            ADD_ARG_LIT("-usbdevice");
            ADD_ARG_LIT(usbdev);
            VIR_FREE(usbdev);
        }
    }

1262
    if (migrateFrom) {
1263
        ADD_ARG_LIT("-incoming");
1264
        ADD_ARG_LIT(migrateFrom);
1265 1266
    }

1267
    ADD_ARG(NULL);
1268
    ADD_ENV(NULL);
D
Daniel P. Berrange 已提交
1269

1270
    *retargv = qargv;
1271
    *retenv = qenv;
D
Daniel P. Berrange 已提交
1272 1273 1274
    return 0;

 no_memory:
1275 1276
    qemudReportError(conn, NULL, NULL, VIR_ERR_NO_MEMORY,
                     "%s", _("failed to allocate space for argv string"));
1277
 error:
1278 1279
    if (tapfds &&
        *tapfds) {
1280
        for (i = 0; i < *ntapfds; i++)
1281 1282 1283
            close((*tapfds)[i]);
        VIR_FREE(*tapfds);
        *ntapfds = 0;
1284
    }
1285 1286
    if (qargv) {
        for (i = 0 ; i < qargc ; i++)
1287 1288
            VIR_FREE((qargv)[i]);
        VIR_FREE(qargv);
D
Daniel P. Berrange 已提交
1289
    }
1290 1291 1292 1293 1294
    if (qenv) {
        for (i = 0 ; i < qenvc ; i++)
            VIR_FREE((qenv)[i]);
        VIR_FREE(qenv);
    }
D
Daniel P. Berrange 已提交
1295
    return -1;
1296 1297 1298 1299

#undef ADD_ARG
#undef ADD_ARG_LIT
#undef ADD_ARG_SPACE
1300 1301 1302 1303 1304
#undef ADD_USBDISK
#undef ADD_ENV
#undef ADD_ENV_COPY
#undef ADD_ENV_LIT
#undef ADD_ENV_SPACE
D
Daniel P. Berrange 已提交
1305
}