qemu_conf.c 39.6 KB
Newer Older
D
Daniel P. Berrange 已提交
1 2 3
/*
 * config.c: VM configuration management
 *
4
 * Copyright (C) 2006, 2007, 2008 Red Hat, Inc.
D
Daniel P. Berrange 已提交
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

24
#include <config.h>
25 26

#ifdef WITH_QEMU
27

D
Daniel P. Berrange 已提交
28 29 30 31 32 33 34 35
#include <dirent.h>
#include <string.h>
#include <limits.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <unistd.h>
#include <errno.h>
#include <fcntl.h>
36
#include <sys/wait.h>
37
#include <arpa/inet.h>
38
#include <sys/utsname.h>
D
Daniel P. Berrange 已提交
39

40 41 42 43
#if HAVE_NUMACTL
#include <numa.h>
#endif

44
#include "qemu_conf.h"
45
#include "uuid.h"
46
#include "buf.h"
D
Daniel P. Berrange 已提交
47
#include "conf.h"
48
#include "util.h"
49
#include "memory.h"
J
Jim Meyering 已提交
50
#include "verify.h"
51 52 53 54 55 56 57

VIR_ENUM_DECL(virDomainDiskQEMUBus)
VIR_ENUM_IMPL(virDomainDiskQEMUBus, VIR_DOMAIN_DISK_BUS_LAST,
              "ide",
              "floppy",
              "scsi",
              "virtio",
58 59
              "xen",
              "usb")
60

61

62 63
#define qemudLog(level, msg...) fprintf(stderr, msg)

64 65 66 67 68
void qemudReportError(virConnectPtr conn,
                      virDomainPtr dom,
                      virNetworkPtr net,
                      int code, const char *fmt, ...) {
    va_list args;
69
    char errorMessage[1024];
D
Daniel Veillard 已提交
70
    const char *virerr;
71 72 73

    if (fmt) {
        va_start(args, fmt);
74
        vsnprintf(errorMessage, sizeof(errorMessage)-1, fmt, args);
75 76 77 78
        va_end(args);
    } else {
        errorMessage[0] = '\0';
    }
D
Daniel Veillard 已提交
79

80
    virerr = __virErrorMsg(code, (errorMessage[0] ? errorMessage : NULL));
81
    __virRaiseError(conn, dom, net, VIR_FROM_QEMU, code, VIR_ERR_ERROR,
D
Daniel Veillard 已提交
82
                    virerr, errorMessage, NULL, -1, -1, virerr, errorMessage);
83 84
}

D
Daniel P. Berrange 已提交
85 86 87 88 89 90
int qemudLoadDriverConfig(struct qemud_driver *driver,
                          const char *filename) {
    virConfPtr conf;
    virConfValuePtr p;

    /* Setup 2 critical defaults */
91 92 93 94 95
    if (!(driver->vncListen = strdup("127.0.0.1"))) {
        qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
                         "%s", _("failed to allocate vncListen"));
        return -1;
    }
D
Daniel P. Berrange 已提交
96 97
    if (!(driver->vncTLSx509certdir = strdup(SYSCONF_DIR "/pki/libvirt-vnc"))) {
        qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
98
                         "%s", _("failed to allocate vncTLSx509certdir"));
D
Daniel P. Berrange 已提交
99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129
        return -1;
    }

    /* Just check the file is readable before opening it, otherwise
     * libvirt emits an error.
     */
    if (access (filename, R_OK) == -1) return 0;

    conf = virConfReadFile (filename);
    if (!conf) return 0;


#define CHECK_TYPE(name,typ) if (p && p->type != (typ)) {               \
        qemudReportError(NULL, NULL, NULL, VIR_ERR_INTERNAL_ERROR,      \
                         "remoteReadConfigFile: %s: %s: expected type " #typ "\n", \
                         filename, (name));                             \
        virConfFree(conf);                                              \
        return -1;                                                      \
    }

    p = virConfGetValue (conf, "vnc_tls");
    CHECK_TYPE ("vnc_tls", VIR_CONF_LONG);
    if (p) driver->vncTLS = p->l;

    p = virConfGetValue (conf, "vnc_tls_x509_verify");
    CHECK_TYPE ("vnc_tls_x509_verify", VIR_CONF_LONG);
    if (p) driver->vncTLSx509verify = p->l;

    p = virConfGetValue (conf, "vnc_tls_x509_cert_dir");
    CHECK_TYPE ("vnc_tls_x509_cert_dir", VIR_CONF_STRING);
    if (p && p->str) {
130
        VIR_FREE(driver->vncTLSx509certdir);
D
Daniel P. Berrange 已提交
131 132
        if (!(driver->vncTLSx509certdir = strdup(p->str))) {
            qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
133
                             "%s", _("failed to allocate vncTLSx509certdir"));
D
Daniel P. Berrange 已提交
134 135 136 137 138 139 140 141
            virConfFree(conf);
            return -1;
        }
    }

    p = virConfGetValue (conf, "vnc_listen");
    CHECK_TYPE ("vnc_listen", VIR_CONF_STRING);
    if (p && p->str) {
142 143 144 145 146 147
        if (!(driver->vncListen = strdup(p->str))) {
            qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
                             "%s", _("failed to allocate vncTLSx509certdir"));
            virConfFree(conf);
            return -1;
        }
D
Daniel P. Berrange 已提交
148 149 150 151 152 153
    }

    virConfFree (conf);
    return 0;
}

D
Daniel P. Berrange 已提交
154 155
/* The list of possible machine types for various architectures,
   as supported by QEMU - taken from 'qemu -M ?' for each arch */
156 157
static const char *const arch_info_hvm_x86_machines[] = {
    "pc", "isapc"
D
Daniel P. Berrange 已提交
158
};
159 160
static const char *const arch_info_hvm_mips_machines[] = {
    "mips"
D
Daniel P. Berrange 已提交
161
};
162 163
static const char *const arch_info_hvm_sparc_machines[] = {
    "sun4m"
D
Daniel P. Berrange 已提交
164
};
165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186
static const char *const arch_info_hvm_ppc_machines[] = {
    "g3bw", "mac99", "prep"
};

static const char *const arch_info_xen_x86_machines[] = {
    "xenner"
};

struct qemu_feature_flags {
    const char *name;
    const int default_on;
    const int toggle;
};

struct qemu_arch_info {
    const char *arch;
    int wordsize;
    const char *const *machines;
    int nmachines;
    const char *binary;
    const struct qemu_feature_flags *flags;
    int nflags;
D
Daniel P. Berrange 已提交
187 188
};

189
/* Feature flags for the architecture info */
J
Jim Meyering 已提交
190
static const struct qemu_feature_flags const arch_info_i686_flags [] = {
191 192
    { "pae",  1, 0 },
    { "nonpae",  1, 0 },
193 194 195 196
    { "acpi", 1, 1 },
    { "apic", 1, 0 },
};

J
Jim Meyering 已提交
197
static const struct qemu_feature_flags const arch_info_x86_64_flags [] = {
198 199 200 201
    { "acpi", 1, 1 },
    { "apic", 1, 0 },
};

D
Daniel P. Berrange 已提交
202
/* The archicture tables for supported QEMU archs */
203 204 205 206 207 208 209 210 211 212 213 214 215
static const struct qemu_arch_info const arch_info_hvm[] = {
    {  "i686", 32, arch_info_hvm_x86_machines, 2,
       "/usr/bin/qemu", arch_info_i686_flags, 4 },
    {  "x86_64", 64, arch_info_hvm_x86_machines, 2,
       "/usr/bin/qemu-system-x86_64", arch_info_x86_64_flags, 2 },
    {  "mips", 32, arch_info_hvm_mips_machines, 1,
       "/usr/bin/qemu-system-mips", NULL, 0 },
    {  "mipsel", 32, arch_info_hvm_mips_machines, 1,
       "/usr/bin/qemu-system-mipsel", NULL, 0 },
    {  "sparc", 32, arch_info_hvm_sparc_machines, 1,
       "/usr/bin/qemu-system-sparc", NULL, 0 },
    {  "ppc", 32, arch_info_hvm_ppc_machines, 3,
       "/usr/bin/qemu-system-ppc", NULL, 0 },
D
Daniel P. Berrange 已提交
216 217
};

218 219 220 221 222 223
static const struct qemu_arch_info const arch_info_xen[] = {
    {  "i686", 32, arch_info_xen_x86_machines, 1,
       "/usr/bin/xenner", arch_info_i686_flags, 4 },
    {  "x86_64", 64, arch_info_xen_x86_machines, 1,
       "/usr/bin/xenner", arch_info_x86_64_flags, 2 },
};
D
Daniel P. Berrange 已提交
224

225 226 227 228 229 230
static int
qemudCapsInitGuest(virCapsPtr caps,
                   const char *hostmachine,
                   const struct qemu_arch_info *info,
                   int hvm) {
    virCapsGuestPtr guest;
D
Daniel P. Berrange 已提交
231 232
    int i;

233 234 235 236 237 238 239 240 241
    if ((guest = virCapabilitiesAddGuest(caps,
                                         hvm ? "hvm" : "xen",
                                         info->arch,
                                         info->wordsize,
                                         info->binary,
                                         NULL,
                                         info->nmachines,
                                         info->machines)) == NULL)
        return -1;
D
Daniel P. Berrange 已提交
242

243 244 245 246 247 248 249 250 251 252
    if (hvm) {
        /* Check for existance of base emulator */
        if (access(info->binary, X_OK) == 0 &&
            virCapabilitiesAddGuestDomain(guest,
                                          "qemu",
                                          NULL,
                                          NULL,
                                          0,
                                          NULL) == NULL)
            return -1;
D
Daniel P. Berrange 已提交
253

254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282
        /* If guest & host match, then we can accelerate */
        if (STREQ(info->arch, hostmachine)) {
            if (access("/dev/kqemu", F_OK) == 0 &&
                virCapabilitiesAddGuestDomain(guest,
                                              "kqemu",
                                              NULL,
                                              NULL,
                                              0,
                                              NULL) == NULL)
                return -1;

            if (access("/dev/kvm", F_OK) == 0 &&
                virCapabilitiesAddGuestDomain(guest,
                                              "kvm",
                                              "/usr/bin/qemu-kvm",
                                              NULL,
                                              0,
                                              NULL) == NULL)
                return -1;
        }
    } else {
        if (virCapabilitiesAddGuestDomain(guest,
                                          "kvm",
                                          NULL,
                                          NULL,
                                          0,
                                          NULL) == NULL)
            return -1;
    }
D
Daniel P. Berrange 已提交
283

284 285 286 287 288 289 290
    if (info->nflags) {
        for (i = 0 ; i < info->nflags ; i++) {
            if (virCapabilitiesAddGuestFeature(guest,
                                               info->flags[i].name,
                                               info->flags[i].default_on,
                                               info->flags[i].toggle) == NULL)
                return -1;
D
Daniel P. Berrange 已提交
291 292 293
        }
    }

294
    return 0;
D
Daniel P. Berrange 已提交
295 296
}

297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355
#if HAVE_NUMACTL
#define MAX_CPUS 4096
#define MAX_CPUS_MASK_SIZE (sizeof(unsigned long))
#define MAX_CPUS_MASK_LEN (MAX_CPUS / MAX_CPUS_MASK_SIZE)
#define MAX_CPUS_MASK_BYTES (MAX_CPUS / 8)

#define MASK_CPU_ISSET(mask, cpu) \
    (((mask)[((cpu) / MAX_CPUS_MASK_SIZE)] >> ((cpu) % MAX_CPUS_MASK_SIZE)) & 1)

static int
qemudCapsInitNUMA(virCapsPtr caps)
{
    int n, i;
    unsigned long *mask = NULL;
    int ncpus;
    int *cpus = NULL;
    int ret = -1;

    if (numa_available() < 0)
        return 0;

    if (VIR_ALLOC_N(mask, MAX_CPUS_MASK_LEN) < 0)
        goto cleanup;

    for (n = 0 ; n <= numa_max_node() ; n++) {
        if (numa_node_to_cpus(n, mask, MAX_CPUS_MASK_BYTES) < 0)
            goto cleanup;

        for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++)
            if (MASK_CPU_ISSET(mask, i))
                ncpus++;

        if (VIR_ALLOC_N(cpus, ncpus) < 0)
            goto cleanup;

        for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++)
            if (MASK_CPU_ISSET(mask, i))
                cpus[ncpus++] = i;

        if (virCapabilitiesAddHostNUMACell(caps,
                                           n,
                                           ncpus,
                                           cpus) < 0)
            goto cleanup;

        VIR_FREE(cpus);
    }

    ret = 0;

cleanup:
    VIR_FREE(cpus);
    VIR_FREE(mask);
    return ret;
}
#else
static int qemudCapsInitNUMA(virCapsPtr caps ATTRIBUTE_UNUSED) { return 0; }
#endif

356 357 358 359
virCapsPtr qemudCapsInit(void) {
    struct utsname utsname;
    virCapsPtr caps;
    int i;
D
Daniel P. Berrange 已提交
360

361 362 363 364 365 366 367
    /* Really, this never fails - look at the man-page. */
    uname (&utsname);

    if ((caps = virCapabilitiesNew(utsname.machine,
                                   0, 0)) == NULL)
        goto no_memory;

368 369 370
    if (qemudCapsInitNUMA(caps) < 0)
        goto no_memory;

371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388
    for (i = 0 ; i < (sizeof(arch_info_hvm)/sizeof(arch_info_hvm[0])) ; i++)
        if (qemudCapsInitGuest(caps,
                               utsname.machine,
                               &arch_info_hvm[i], 1) < 0)
            goto no_memory;

    if (access("/usr/bin/xenner", X_OK) == 0 &&
        access("/dev/kvm", F_OK) == 0) {
        for (i = 0 ; i < (sizeof(arch_info_xen)/sizeof(arch_info_xen[0])) ; i++)
            /* Allow Xen 32-on-32, 32-on-64 and 64-on-64 */
            if (STREQ(arch_info_xen[i].arch, utsname.machine) ||
                (STREQ(utsname.machine, "x86_64") &&
                 STREQ(arch_info_xen[i].arch, "i686"))) {
                if (qemudCapsInitGuest(caps,
                                       utsname.machine,
                                       &arch_info_xen[i], 0) < 0)
                    goto no_memory;
            }
D
Daniel P. Berrange 已提交
389 390
    }

391 392 393 394 395
    return caps;

 no_memory:
    virCapabilitiesFree(caps);
    return NULL;
D
Daniel P. Berrange 已提交
396 397
}

398

399
int qemudExtractVersionInfo(const char *qemu, int *version, int *flags) {
400 401 402
    pid_t child;
    int newstdout[2];

403 404 405 406
    if (flags)
        *flags = 0;
    if (version)
        *version = 0;
407 408 409 410 411 412 413 414 415 416 417 418

    if (pipe(newstdout) < 0) {
        return -1;
    }

    if ((child = fork()) < 0) {
        close(newstdout[0]);
        close(newstdout[1]);
        return -1;
    }

    if (child == 0) { /* Kid */
419 420 421
        /* Just in case QEMU is translated someday we force to C locale.. */
        const char *const qemuenv[] = { "LANG=C", NULL };

422 423 424 425 426 427 428 429 430
        if (close(STDIN_FILENO) < 0)
            goto cleanup1;
        if (close(STDERR_FILENO) < 0)
            goto cleanup1;
        if (close(newstdout[0]) < 0)
            goto cleanup1;
        if (dup2(newstdout[1], STDOUT_FILENO) < 0)
            goto cleanup1;

431 432 433
        /* Passing -help, rather than relying on no-args which doesn't
           always work */
        execle(qemu, qemu, "-help", (char*)NULL, qemuenv);
434 435 436 437

    cleanup1:
        _exit(-1); /* Just in case */
    } else { /* Parent */
D
Daniel P. Berrange 已提交
438
        char help[8192]; /* Ought to be enough to hold QEMU help screen */
439
        int got = 0, ret = -1;
440
        int major, minor, micro;
441
        int ver;
442 443 444 445

        if (close(newstdout[1]) < 0)
            goto cleanup2;

D
Daniel P. Berrange 已提交
446 447 448 449 450 451 452 453 454 455
        while (got < (sizeof(help)-1)) {
            int len;
            if ((len = read(newstdout[0], help+got, sizeof(help)-got-1)) <= 0) {
                if (!len)
                    break;
                if (errno == EINTR)
                    continue;
                goto cleanup2;
            }
            got += len;
456 457 458 459 460 461 462
        }
        help[got] = '\0';

        if (sscanf(help, "QEMU PC emulator version %d.%d.%d", &major,&minor, &micro) != 3) {
            goto cleanup2;
        }

463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479
        ver = (major * 1000 * 1000) + (minor * 1000) + micro;
        if (version)
            *version = ver;
        if (flags) {
            if (strstr(help, "-no-kqemu"))
                *flags |= QEMUD_CMD_FLAG_KQEMU;
            if (strstr(help, "-no-reboot"))
                *flags |= QEMUD_CMD_FLAG_NO_REBOOT;
            if (strstr(help, "-name"))
                *flags |= QEMUD_CMD_FLAG_NAME;
            if (strstr(help, "-drive"))
                *flags |= QEMUD_CMD_FLAG_DRIVE;
            if (strstr(help, "boot=on"))
                *flags |= QEMUD_CMD_FLAG_DRIVE_BOOT;
            if (ver >= 9000)
                *flags |= QEMUD_CMD_FLAG_VNC_COLON;
        }
480 481 482 483 484 485 486 487 488 489 490 491 492 493
        ret = 0;

        qemudDebug("Version %d %d %d  Cooked version: %d, with flags ? %d",
                   major, minor, micro, *version, *flags);

    cleanup2:
        if (close(newstdout[0]) < 0)
            ret = -1;

    rewait:
        if (waitpid(child, &got, 0) != child) {
            if (errno == EINTR) {
                goto rewait;
            }
494 495 496
            qemudLog(QEMUD_ERR,
                     _("Unexpected exit status from qemu %d pid %lu"),
                     got, (unsigned long)child);
497 498 499 500 501
            ret = -1;
        }
        /* Check & log unexpected exit status, but don't fail,
         * as there's really no need to throw an error if we did
         * actually read a valid version number above */
502
        if (WEXITSTATUS(got) != 0) {
503 504 505
            qemudLog(QEMUD_WARN,
                     _("Unexpected exit status '%d', qemu probably failed"),
                     got);
506 507 508 509 510 511
        }

        return ret;
    }
}

512
int qemudExtractVersion(virConnectPtr conn,
513 514
                        struct qemud_driver *driver) {
    const char *binary;
515
    struct stat sb;
516
    int ignored;
517

518
    if (driver->qemuVersion > 0)
519 520
        return 0;

521 522
    if ((binary = virCapabilitiesDefaultGuestEmulator(driver->caps,
                                                      "hvm",
523 524 525
                                                      "i686",
                                                      "qemu")) == NULL)
        return -1;
526

527 528 529 530 531
    if (stat(binary, &sb) < 0) {
        qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                         _("Cannot find QEMU binary %s: %s"), binary,
                         strerror(errno));
        return -1;
532 533
    }

534 535 536
    if (qemudExtractVersionInfo(binary, &driver->qemuVersion, &ignored) < 0) {
        return -1;
    }
D
Daniel P. Berrange 已提交
537

538
    return 0;
D
Daniel P. Berrange 已提交
539 540 541
}


542
static char *
543 544
qemudNetworkIfaceConnect(virConnectPtr conn,
                         struct qemud_driver *driver,
545 546 547
                         int **tapfds,
                         int *ntapfds,
                         virDomainNetDefPtr net,
548
                         int vlan)
549
{
550
    virNetworkObjPtr network = NULL;
551
    char *brname;
552 553 554 555 556
    char tapfdstr[4+3+32+7];
    char *retval = NULL;
    int err;
    int tapfd = -1;

557 558
    if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
        if (!(network = virNetworkFindByName(driver->networks, net->data.network.name))) {
559
            qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
560
                             _("Network '%s' not found"),
561
                             net->data.network.name);
562
            goto error;
563
        } else if (network->def->bridge == NULL) {
564
            qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
565
                             _("Network '%s' not active"),
566
                             net->data.network.name);
567 568
            goto error;
        }
569
        brname = network->def->bridge;
570 571
    } else if (net->type == VIR_DOMAIN_NET_TYPE_BRIDGE) {
        brname = net->data.bridge.brname;
572
    } else {
573
        qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
574
                         _("Network type %d is not supported"), net->type);
575 576 577
        goto error;
    }

578 579 580 581 582 583 584 585 586 587
    if (!net->ifname ||
        STRPREFIX(net->ifname, "vnet") ||
        strchr(net->ifname, '%')) {
        VIR_FREE(net->ifname);
        if (!(net->ifname = strdup("vnet%d"))) {
            qemudReportError(conn, NULL, NULL, VIR_ERR_NO_MEMORY, NULL);
            goto error;
        }
    }

588
    if (!driver->brctl && (err = brInit(&driver->brctl))) {
589
        qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
590 591
                         _("cannot initialize bridge support: %s"),
                         strerror(err));
592 593 594
        goto error;
    }

595
    if ((err = brAddTap(driver->brctl, brname,
596
                        &net->ifname, &tapfd))) {
597 598 599 600 601 602 603 604 605
        if (errno == ENOTSUP) {
            /* In this particular case, give a better diagnostic. */
            qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                             _("Failed to add tap interface to bridge. "
                               "%s is not a bridge device"), brname);
        } else {
            qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                             _("Failed to add tap interface '%s' "
                               "to bridge '%s' : %s"),
606
                             net->ifname, brname, strerror(err));
607
        }
608 609 610
        goto error;
    }

611 612
    snprintf(tapfdstr, sizeof(tapfdstr),
             "tap,fd=%d,script=,vlan=%d,ifname=%s",
613
             tapfd, vlan, net->ifname);
614 615 616 617

    if (!(retval = strdup(tapfdstr)))
        goto no_memory;

618
    if (VIR_REALLOC_N(*tapfds, (*ntapfds)+1) < 0)
619 620
        goto no_memory;

621
    (*tapfds)[(*ntapfds)++] = tapfd;
622 623 624 625

    return retval;

 no_memory:
626 627
    qemudReportError(conn, NULL, NULL, VIR_ERR_NO_MEMORY,
                     "%s", _("failed to allocate space for tapfds string"));
628
 error:
629
    VIR_FREE(retval);
630 631 632 633 634
    if (tapfd != -1)
        close(tapfd);
    return NULL;
}

635
static int qemudBuildCommandLineChrDevStr(virDomainChrDefPtr dev,
636 637 638
                                          char *buf,
                                          int buflen)
{
639 640
    switch (dev->type) {
    case VIR_DOMAIN_CHR_TYPE_NULL:
641 642 643 644
        strncpy(buf, "null", buflen);
        buf[buflen-1] = '\0';
        break;

645
    case VIR_DOMAIN_CHR_TYPE_VC:
646 647 648 649
        strncpy(buf, "vc", buflen);
        buf[buflen-1] = '\0';
        break;

650
    case VIR_DOMAIN_CHR_TYPE_PTY:
651 652 653 654
        strncpy(buf, "pty", buflen);
        buf[buflen-1] = '\0';
        break;

655
    case VIR_DOMAIN_CHR_TYPE_DEV:
656
        if (snprintf(buf, buflen, "%s",
657
                     dev->data.file.path) >= buflen)
658 659 660
            return -1;
        break;

661
    case VIR_DOMAIN_CHR_TYPE_FILE:
662
        if (snprintf(buf, buflen, "file:%s",
663
                     dev->data.file.path) >= buflen)
664 665 666
            return -1;
        break;

667
    case VIR_DOMAIN_CHR_TYPE_PIPE:
668
        if (snprintf(buf, buflen, "pipe:%s",
669
                     dev->data.file.path) >= buflen)
670 671 672
            return -1;
        break;

673
    case VIR_DOMAIN_CHR_TYPE_STDIO:
674 675 676 677
        strncpy(buf, "stdio", buflen);
        buf[buflen-1] = '\0';
        break;

678
    case VIR_DOMAIN_CHR_TYPE_UDP:
679
        if (snprintf(buf, buflen, "udp:%s:%s@%s:%s",
680 681 682 683
                     dev->data.udp.connectHost,
                     dev->data.udp.connectService,
                     dev->data.udp.bindHost,
                     dev->data.udp.bindService) >= buflen)
684 685 686
            return -1;
        break;

687
    case VIR_DOMAIN_CHR_TYPE_TCP:
688
        if (snprintf(buf, buflen, "%s:%s:%s%s",
689 690 691 692
                     dev->data.tcp.protocol == VIR_DOMAIN_CHR_TCP_PROTOCOL_TELNET ? "telnet" : "tcp",
                     dev->data.tcp.host,
                     dev->data.tcp.service,
                     dev->data.tcp.listen ? ",listen" : "") >= buflen)
693 694 695
            return -1;
        break;

696
    case VIR_DOMAIN_CHR_TYPE_UNIX:
697
        if (snprintf(buf, buflen, "unix:%s%s",
698 699
                     dev->data.nix.path,
                     dev->data.nix.listen ? ",listen" : "") >= buflen)
700 701 702 703 704 705 706
            return -1;
        break;
    }

    return 0;
}

D
Daniel P. Berrange 已提交
707 708 709 710
/*
 * Constructs a argv suitable for launching qemu with config defined
 * for a given virtual machine.
 */
711 712
int qemudBuildCommandLine(virConnectPtr conn,
                          struct qemud_driver *driver,
713 714
                          virDomainObjPtr vm,
                          int qemuCmdFlags,
715
                          const char ***retargv,
716 717 718
                          int **tapfds,
                          int *ntapfds,
                          const char *migrateFrom) {
719
    int i;
D
Daniel P. Berrange 已提交
720 721
    char memory[50];
    char vcpus[50];
722 723 724 725 726
    char boot[VIR_DOMAIN_BOOT_LAST];
    virDomainDiskDefPtr disk = vm->def->disks;
    virDomainNetDefPtr net = vm->def->nets;
    virDomainInputDefPtr input = vm->def->inputs;
    virDomainSoundDefPtr sound = vm->def->sounds;
727
    virDomainHostdevDefPtr hostdev = vm->def->hostdevs;
728 729
    virDomainChrDefPtr serial = vm->def->serials;
    virDomainChrDefPtr parallel = vm->def->parallels;
730 731
    struct utsname ut;
    int disableKQEMU = 0;
732
    int qargc = 0, qarga = 0;
733
    const char **qargv = NULL;
D
Daniel P. Berrange 已提交
734

735 736
    uname(&ut);

D
Daniel P. Berrange 已提交
737
    /* Nasty hack make i?86 look like i686 to simplify next comparison */
738 739 740 741
    if (ut.machine[0] == 'i' &&
        ut.machine[2] == '8' &&
        ut.machine[3] == '6' &&
        !ut.machine[4])
D
Daniel P. Berrange 已提交
742
        ut.machine[1] = '6';
743 744 745 746 747 748

    /* Need to explicitly disable KQEMU if
     * 1. Arch matches host arch
     * 2. Guest is 'qemu'
     * 3. The qemu binary has the -no-kqemu flag
     */
749
    if ((qemuCmdFlags & QEMUD_CMD_FLAG_KQEMU) &&
750
        STREQ(ut.machine, vm->def->os.arch) &&
751
        vm->def->virtType == VIR_DOMAIN_VIRT_QEMU)
752 753
        disableKQEMU = 1;

754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774
#define ADD_ARG_SPACE                                                   \
    do { \
        if (qargc == qarga) {                                           \
            qarga += 10;                                                \
            if (VIR_REALLOC_N(qargv, qarga) < 0)                        \
                goto no_memory;                                         \
        }                                                               \
    } while (0)

#define ADD_ARG(thisarg)                                                \
    do {                                                                \
        ADD_ARG_SPACE;                                                  \
        qargv[qargc++] = thisarg;                                       \
    } while (0)

#define ADD_ARG_LIT(thisarg)                                            \
    do {                                                                \
        ADD_ARG_SPACE;                                                  \
        if ((qargv[qargc++] = strdup(thisarg)) == NULL)                 \
            goto no_memory;                                             \
    } while (0)
D
Daniel P. Berrange 已提交
775

776 777 778 779
#define ADD_USBDISK(thisarg)                                            \
    do {                                                                \
        ADD_ARG_LIT("-usbdevice");                                      \
        ADD_ARG_SPACE;                                                  \
780
        if ((asprintf((char **)&(qargv[qargc++]), "disk:%s", thisarg)) == -1) {    \
781 782 783 784 785
            qargv[qargc-1] = NULL;                                      \
            goto no_memory;                                             \
        }                                                               \
    } while (0)

786
    snprintf(memory, sizeof(memory), "%lu", vm->def->memory/1024);
787
    snprintf(vcpus, sizeof(vcpus), "%lu", vm->def->vcpus);
D
Daniel P. Berrange 已提交
788

789

790
    ADD_ARG_LIT(vm->def->emulator);
791 792 793 794 795 796 797 798 799
    ADD_ARG_LIT("-S");
    ADD_ARG_LIT("-M");
    ADD_ARG_LIT(vm->def->os.machine);
    if (disableKQEMU)
        ADD_ARG_LIT("-no-kqemu");
    ADD_ARG_LIT("-m");
    ADD_ARG_LIT(memory);
    ADD_ARG_LIT("-smp");
    ADD_ARG_LIT(vcpus);
D
Daniel P. Berrange 已提交
800

801
    if (qemuCmdFlags & QEMUD_CMD_FLAG_NAME) {
802 803
        ADD_ARG_LIT("-name");
        ADD_ARG_LIT(vm->def->name);
804
    }
805 806 807 808 809 810 811
    /*
     * NB, -nographic *MUST* come before any serial, or monitor
     * or parallel port flags due to QEMU craziness, where it
     * decides to change the serial port & monitor to be on stdout
     * if you ask for nographic. So we have to make sure we override
     * these defaults ourselves...
     */
812
    if (!vm->def->graphics)
813
        ADD_ARG_LIT("-nographic");
814

815 816
    ADD_ARG_LIT("-monitor");
    ADD_ARG_LIT("pty");
D
Daniel P. Berrange 已提交
817

818 819
    if (vm->def->localtime)
        ADD_ARG_LIT("-localtime");
820

821 822
    if ((qemuCmdFlags & QEMUD_CMD_FLAG_NO_REBOOT) &&
        vm->def->onReboot != VIR_DOMAIN_LIFECYCLE_RESTART)
823
        ADD_ARG_LIT("-no-reboot");
D
Daniel P. Berrange 已提交
824

825
    if (!(vm->def->features & (1 << VIR_DOMAIN_FEATURE_ACPI)))
826
        ADD_ARG_LIT("-no-acpi");
D
Daniel P. Berrange 已提交
827

828
    if (!vm->def->os.bootloader) {
D
Daniel P. Berrange 已提交
829 830
        for (i = 0 ; i < vm->def->os.nBootDevs ; i++) {
            switch (vm->def->os.bootDevs[i]) {
831
            case VIR_DOMAIN_BOOT_CDROM:
D
Daniel P. Berrange 已提交
832 833
                boot[i] = 'd';
                break;
834
            case VIR_DOMAIN_BOOT_FLOPPY:
D
Daniel P. Berrange 已提交
835 836
                boot[i] = 'a';
                break;
837
            case VIR_DOMAIN_BOOT_DISK:
D
Daniel P. Berrange 已提交
838 839
                boot[i] = 'c';
                break;
840
            case VIR_DOMAIN_BOOT_NET:
D
Daniel P. Berrange 已提交
841 842 843 844 845 846 847 848
                boot[i] = 'n';
                break;
            default:
                boot[i] = 'c';
                break;
            }
        }
        boot[vm->def->os.nBootDevs] = '\0';
849 850
        ADD_ARG_LIT("-boot");
        ADD_ARG_LIT(boot);
D
Daniel P. Berrange 已提交
851

852
        if (vm->def->os.kernel) {
853 854
            ADD_ARG_LIT("-kernel");
            ADD_ARG_LIT(vm->def->os.kernel);
D
Daniel P. Berrange 已提交
855
        }
856
        if (vm->def->os.initrd) {
857 858
            ADD_ARG_LIT("-initrd");
            ADD_ARG_LIT(vm->def->os.initrd);
D
Daniel P. Berrange 已提交
859
        }
860
        if (vm->def->os.cmdline) {
861 862
            ADD_ARG_LIT("-append");
            ADD_ARG_LIT(vm->def->os.cmdline);
D
Daniel P. Berrange 已提交
863 864
        }
    } else {
865 866
        ADD_ARG_LIT("-bootloader");
        ADD_ARG_LIT(vm->def->os.bootloader);
D
Daniel P. Berrange 已提交
867 868
    }

869
    /* If QEMU supports -drive param instead of old -hda, -hdb, -cdrom .. */
870
    if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE) {
871 872 873
        int bootCD = 0, bootFloppy = 0, bootDisk = 0;

        /* If QEMU supports boot=on for -drive param... */
874
        if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE_BOOT) {
875 876
            for (i = 0 ; i < vm->def->os.nBootDevs ; i++) {
                switch (vm->def->os.bootDevs[i]) {
877
                case VIR_DOMAIN_BOOT_CDROM:
878 879
                    bootCD = 1;
                    break;
880
                case VIR_DOMAIN_BOOT_FLOPPY:
881 882
                    bootFloppy = 1;
                    break;
883
                case VIR_DOMAIN_BOOT_DISK:
884 885 886
                    bootDisk = 1;
                    break;
                }
887
            }
888
        }
D
Daniel P. Berrange 已提交
889

890 891 892 893 894
        while (disk) {
            char opt[PATH_MAX];
            const char *media = NULL;
            int bootable = 0;
            int idx = virDiskNameToIndex(disk->dst);
895
            const char *bus = virDomainDiskQEMUBusTypeToString(disk->bus);
D
Daniel P. Berrange 已提交
896

897 898 899 900 901 902 903 904 905 906 907 908
            if (disk->bus == VIR_DOMAIN_DISK_BUS_USB) {
                if (disk->device == VIR_DOMAIN_DISK_DEVICE_DISK) {
                    ADD_USBDISK(disk->src);
                } else {
                    qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                     _("unsupported usb disk type for '%s'"), disk->src);
                    goto error;
                }
                disk = disk->next;
                continue;
            }

909 910 911 912 913 914 915
            if (idx < 0) {
                qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                 _("unsupported disk type '%s'"), disk->dst);
                goto error;
            }

            switch (disk->device) {
916
            case VIR_DOMAIN_DISK_DEVICE_CDROM:
917 918
                bootable = bootCD;
                bootCD = 0;
919
                media = "media=cdrom,";
920
                break;
921
            case VIR_DOMAIN_DISK_DEVICE_FLOPPY:
922 923 924
                bootable = bootFloppy;
                bootFloppy = 0;
                break;
925
            case VIR_DOMAIN_DISK_DEVICE_DISK:
926 927 928 929 930 931
                bootable = bootDisk;
                bootDisk = 0;
                break;
            }

            snprintf(opt, PATH_MAX, "file=%s,if=%s,%sindex=%d%s",
932
                     disk->src ? disk->src : "", bus,
933 934
                     media ? media : "",
                     idx,
935 936
                     bootable &&
                     disk->device == VIR_DOMAIN_DISK_DEVICE_DISK
937
                     ? ",boot=on" : "");
938

939 940
            ADD_ARG_LIT("-drive");
            ADD_ARG_LIT(opt);
941 942 943 944 945 946 947
            disk = disk->next;
        }
    } else {
        while (disk) {
            char dev[NAME_MAX];
            char file[PATH_MAX];

948 949 950 951 952 953 954 955 956 957 958 959
            if (disk->bus == VIR_DOMAIN_DISK_BUS_USB) {
                if (disk->device == VIR_DOMAIN_DISK_DEVICE_DISK) {
                    ADD_USBDISK(disk->src);
                } else {
                    qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                     _("unsupported usb disk type for '%s'"), disk->src);
                    goto error;
                }
                disk = disk->next;
                continue;
            }

960
            if (STREQ(disk->dst, "hdc") &&
961 962
                disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM) {
                if (disk->src) {
963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980
                    snprintf(dev, NAME_MAX, "-%s", "cdrom");
                } else {
                    disk = disk->next;
                    continue;
                }
            } else {
                if (STRPREFIX(disk->dst, "hd") ||
                    STRPREFIX(disk->dst, "fd")) {
                    snprintf(dev, NAME_MAX, "-%s", disk->dst);
                } else {
                    qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                     _("unsupported disk type '%s'"), disk->dst);
                    goto error;
                }
            }

            snprintf(file, PATH_MAX, "%s", disk->src);

981 982
            ADD_ARG_LIT(dev);
            ADD_ARG_LIT(file);
983 984 985

            disk = disk->next;
        }
D
Daniel P. Berrange 已提交
986 987 988
    }

    if (!net) {
989 990
        ADD_ARG_LIT("-net");
        ADD_ARG_LIT("none");
D
Daniel P. Berrange 已提交
991
    } else {
992
        int vlan = 0;
D
Daniel P. Berrange 已提交
993
        while (net) {
994
            char nic[100];
995

996 997
            if (snprintf(nic, sizeof(nic),
                         "nic,macaddr=%02x:%02x:%02x:%02x:%02x:%02x,vlan=%d%s%s",
998 999 1000
                         net->mac[0], net->mac[1],
                         net->mac[2], net->mac[3],
                         net->mac[4], net->mac[5],
1001
                         vlan,
1002 1003
                         (net->model ? ",model=" : ""),
                         (net->model ? net->model : "")) >= sizeof(nic))
1004
                goto error;
D
Daniel P. Berrange 已提交
1005

1006 1007 1008
            ADD_ARG_LIT("-net");
            ADD_ARG_LIT(nic);
            ADD_ARG_LIT("-net");
1009

1010
            switch (net->type) {
1011 1012
            case VIR_DOMAIN_NET_TYPE_NETWORK:
            case VIR_DOMAIN_NET_TYPE_BRIDGE:
1013
                {
1014 1015 1016
                    char *tap = qemudNetworkIfaceConnect(conn, driver,
                                                         tapfds, ntapfds,
                                                         net, vlan);
1017 1018 1019 1020 1021
                    if (tap == NULL)
                        goto error;
                    ADD_ARG(tap);
                    break;
                }
1022

1023
            case VIR_DOMAIN_NET_TYPE_ETHERNET:
1024 1025 1026
                {
                    char arg[PATH_MAX];
                    if (snprintf(arg, PATH_MAX-1, "tap,ifname=%s,script=%s,vlan=%d",
1027 1028
                                 net->ifname,
                                 net->data.ethernet.script,
1029 1030 1031
                                 vlan) >= (PATH_MAX-1))
                        goto error;

1032
                    ADD_ARG_LIT(arg);
1033 1034 1035
                }
                break;

1036 1037 1038
            case VIR_DOMAIN_NET_TYPE_CLIENT:
            case VIR_DOMAIN_NET_TYPE_SERVER:
            case VIR_DOMAIN_NET_TYPE_MCAST:
1039 1040 1041 1042
                {
                    char arg[PATH_MAX];
                    const char *mode = NULL;
                    switch (net->type) {
1043
                    case VIR_DOMAIN_NET_TYPE_CLIENT:
1044 1045
                        mode = "connect";
                        break;
1046
                    case VIR_DOMAIN_NET_TYPE_SERVER:
1047 1048
                        mode = "listen";
                        break;
1049
                    case VIR_DOMAIN_NET_TYPE_MCAST:
1050 1051 1052 1053 1054
                        mode = "mcast";
                        break;
                    }
                    if (snprintf(arg, PATH_MAX-1, "socket,%s=%s:%d,vlan=%d",
                                 mode,
1055 1056
                                 net->data.socket.address,
                                 net->data.socket.port,
1057 1058 1059
                                 vlan) >= (PATH_MAX-1))
                        goto error;

1060
                    ADD_ARG_LIT(arg);
1061 1062 1063
                }
                break;

1064
            case VIR_DOMAIN_NET_TYPE_USER:
1065 1066 1067 1068 1069 1070
            default:
                {
                    char arg[PATH_MAX];
                    if (snprintf(arg, PATH_MAX-1, "user,vlan=%d", vlan) >= (PATH_MAX-1))
                        goto error;

1071
                    ADD_ARG_LIT(arg);
1072
                }
1073
            }
D
Daniel P. Berrange 已提交
1074 1075

            net = net->next;
1076
            vlan++;
D
Daniel P. Berrange 已提交
1077 1078 1079
        }
    }

1080
    if (!serial) {
1081 1082
        ADD_ARG_LIT("-serial");
        ADD_ARG_LIT("none");
1083 1084 1085 1086 1087 1088 1089
    } else {
        while (serial) {
            char buf[4096];

            if (qemudBuildCommandLineChrDevStr(serial, buf, sizeof(buf)) < 0)
                goto error;

1090 1091
            ADD_ARG_LIT("-serial");
            ADD_ARG_LIT(buf);
1092 1093 1094 1095 1096 1097

            serial = serial->next;
        }
    }

    if (!parallel) {
1098 1099
        ADD_ARG_LIT("-parallel");
        ADD_ARG_LIT("none");
1100 1101 1102 1103 1104 1105 1106
    } else {
        while (parallel) {
            char buf[4096];

            if (qemudBuildCommandLineChrDevStr(parallel, buf, sizeof(buf)) < 0)
                goto error;

1107 1108
            ADD_ARG_LIT("-parallel");
            ADD_ARG_LIT(buf);
1109 1110 1111 1112 1113

            parallel = parallel->next;
        }
    }

1114
    ADD_ARG_LIT("-usb");
1115
    while (input) {
1116
        if (input->bus == VIR_DOMAIN_INPUT_BUS_USB) {
1117
            ADD_ARG_LIT("-usbdevice");
1118
            ADD_ARG_LIT(input->type == VIR_DOMAIN_INPUT_TYPE_MOUSE ? "mouse" : "tablet");
1119 1120 1121 1122 1123
        }

        input = input->next;
    }

1124 1125
    if (vm->def->graphics &&
        vm->def->graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC) {
D
Daniel P. Berrange 已提交
1126
        char vncdisplay[PATH_MAX];
1127
        int ret;
D
Daniel P. Berrange 已提交
1128

1129
        if (qemuCmdFlags & QEMUD_CMD_FLAG_VNC_COLON) {
D
Daniel P. Berrange 已提交
1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142
            char options[PATH_MAX] = "";
            if (driver->vncTLS) {
                strcat(options, ",tls");
                if (driver->vncTLSx509verify) {
                    strcat(options, ",x509verify=");
                } else {
                    strcat(options, ",x509=");
                }
                strncat(options, driver->vncTLSx509certdir,
                        sizeof(options) - (strlen(driver->vncTLSx509certdir)-1));
                options[sizeof(options)-1] = '\0';
            }
            ret = snprintf(vncdisplay, sizeof(vncdisplay), "%s:%d%s",
D
Daniel P. Berrange 已提交
1143 1144 1145
                           (vm->def->graphics->data.vnc.listenAddr ?
                            vm->def->graphics->data.vnc.listenAddr :
                            (driver->vncListen ? driver->vncListen : "")),
1146
                           vm->def->graphics->data.vnc.port - 5900,
D
Daniel P. Berrange 已提交
1147 1148
                           options);
        } else {
1149
            ret = snprintf(vncdisplay, sizeof(vncdisplay), "%d",
1150
                           vm->def->graphics->data.vnc.port - 5900);
D
Daniel P. Berrange 已提交
1151
        }
1152
        if (ret < 0 || ret >= (int)sizeof(vncdisplay))
1153 1154
            goto error;

1155 1156
        ADD_ARG_LIT("-vnc");
        ADD_ARG_LIT(vncdisplay);
1157
        if (vm->def->graphics->data.vnc.keymap) {
1158
            ADD_ARG_LIT("-k");
1159
            ADD_ARG_LIT(vm->def->graphics->data.vnc.keymap);
1160
        }
1161 1162
    } else if (vm->def->graphics &&
               vm->def->graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL) {
D
Daniel P. Berrange 已提交
1163 1164 1165
        /* SDL is the default. no args needed */
    }

D
Daniel Veillard 已提交
1166 1167 1168
    /* Add sound hardware */
    if (sound) {
        int size = 100;
1169 1170
        char *modstr;
        if (VIR_ALLOC_N(modstr, size+1) < 0)
D
Daniel Veillard 已提交
1171 1172 1173
            goto no_memory;

        while(sound && size > 0) {
1174
            const char *model = virDomainSoundModelTypeToString(sound->model);
D
Daniel Veillard 已提交
1175
            if (!model) {
1176
                VIR_FREE(modstr);
1177 1178 1179
                qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
                                 "%s", _("invalid sound model"));
                goto error;
D
Daniel Veillard 已提交
1180 1181 1182 1183 1184 1185 1186
            }
            strncat(modstr, model, size);
            size -= strlen(model);
            sound = sound->next;
            if (sound)
               strncat(modstr, ",", size--);
        }
1187 1188
        ADD_ARG_LIT("-soundhw");
        ADD_ARG(modstr);
D
Daniel Veillard 已提交
1189 1190
    }

1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218
    /* Add host passthrough hardware */
    while (hostdev) {
        int ret;
        char* usbdev;

        if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
            hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) {
            if(hostdev->source.subsys.usb.vendor) {
                    ret = asprintf(&usbdev, "host:%.4x:%.4x",
                               hostdev->source.subsys.usb.vendor,
                               hostdev->source.subsys.usb.product);

            } else {
                    ret = asprintf(&usbdev, "host:%.3d.%.3d",
                               hostdev->source.subsys.usb.bus,
                               hostdev->source.subsys.usb.device);
            }
            if (ret < 0) {
                usbdev = NULL;
                goto error;
            }
            ADD_ARG_LIT("-usbdevice");
            ADD_ARG_LIT(usbdev);
            VIR_FREE(usbdev);
        }
        hostdev = hostdev->next;
    }

1219
    if (migrateFrom) {
1220
        ADD_ARG_LIT("-incoming");
1221
        ADD_ARG_LIT(migrateFrom);
1222 1223
    }

1224
    ADD_ARG(NULL);
D
Daniel P. Berrange 已提交
1225

1226
    *retargv = qargv;
D
Daniel P. Berrange 已提交
1227 1228 1229
    return 0;

 no_memory:
1230 1231
    qemudReportError(conn, NULL, NULL, VIR_ERR_NO_MEMORY,
                     "%s", _("failed to allocate space for argv string"));
1232
 error:
1233 1234 1235 1236 1237 1238
    if (tapfds &&
        *tapfds) {
        for (i = 0; ntapfds; i++)
            close((*tapfds)[i]);
        VIR_FREE(*tapfds);
        *ntapfds = 0;
1239
    }
1240 1241
    if (qargv) {
        for (i = 0 ; i < qargc ; i++)
1242 1243
            VIR_FREE((qargv)[i]);
        VIR_FREE(qargv);
D
Daniel P. Berrange 已提交
1244 1245
    }
    return -1;
1246 1247 1248 1249

#undef ADD_ARG
#undef ADD_ARG_LIT
#undef ADD_ARG_SPACE
D
Daniel P. Berrange 已提交
1250 1251 1252
}


1253
#endif /* WITH_QEMU */