virstoragetest.c 43.1 KB
Newer Older
1
/*
2
 * Copyright (C) 2013-2014 Red Hat, Inc.
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library.  If not, see
 * <http://www.gnu.org/licenses/>.
 *
 * Author: Eric Blake <eblake@redhat.com>
 */

#include <config.h>

#include <stdlib.h>

#include "testutils.h"
#include "vircommand.h"
#include "virerror.h"
28
#include "virfile.h"
29 30
#include "virlog.h"
#include "virstoragefile.h"
31
#include "virstring.h"
32
#include "dirname.h"
33

34 35
#include "storage/storage_driver.h"

36 37
#define VIR_FROM_THIS VIR_FROM_NONE

38 39
VIR_LOG_INIT("tests.storagetest");

40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61
#define datadir abs_builddir "/virstoragedata"

/* This test creates the following files, all in datadir:

 * raw: 1024-byte raw file
 * qcow2: qcow2 file with 'raw' as backing
 * wrap: qcow2 file with 'qcow2' as backing
 * qed: qed file with 'raw' as backing
 * sub/link1: symlink to qcow2
 * sub/link2: symlink to wrap
 *
 * Relative names to these files are known at compile time, but absolute
 * and canonical names depend on where the test is run; for convenience,
 * we pre-populate the computation of these names for use during the test.
*/

static char *qemuimg;
static char *absraw;
static char *canonraw;
static char *absqcow2;
static char *canonqcow2;
static char *abswrap;
E
Eric Blake 已提交
62
static char *canonwrap;
63
static char *absqed;
E
Eric Blake 已提交
64
static char *canonqed;
E
Eric Blake 已提交
65
static char *absdir;
E
Eric Blake 已提交
66
static char *canondir;
67 68 69 70 71 72 73 74 75 76 77
static char *abslink2;

static void
testCleanupImages(void)
{
    VIR_FREE(qemuimg);
    VIR_FREE(absraw);
    VIR_FREE(canonraw);
    VIR_FREE(absqcow2);
    VIR_FREE(canonqcow2);
    VIR_FREE(abswrap);
E
Eric Blake 已提交
78
    VIR_FREE(canonwrap);
79
    VIR_FREE(absqed);
E
Eric Blake 已提交
80
    VIR_FREE(canonqed);
E
Eric Blake 已提交
81
    VIR_FREE(absdir);
E
Eric Blake 已提交
82
    VIR_FREE(canondir);
83 84 85 86 87 88 89 90
    VIR_FREE(abslink2);

    if (chdir(abs_builddir) < 0) {
        fprintf(stderr, "unable to return to correct directory, refusing to "
                "clean up %s\n", datadir);
        return;
    }

91
    virFileDeleteTree(datadir);
92 93
}

94 95 96 97 98 99 100

static virStorageSourcePtr
testStorageFileGetMetadata(const char *path,
                           int format,
                           uid_t uid, gid_t gid,
                           bool allow_probe)
{
101
    struct stat st;
102 103 104 105 106 107 108 109
    virStorageSourcePtr ret = NULL;

    if (VIR_ALLOC(ret) < 0)
        return NULL;

    ret->type = VIR_STORAGE_TYPE_FILE;
    ret->format = format;

110 111 112 113 114 115 116 117 118
    if (stat(path, &st) == 0) {
        if (S_ISDIR(st.st_mode)) {
            ret->type = VIR_STORAGE_TYPE_DIR;
            ret->format = VIR_STORAGE_FILE_DIR;
        } else if (S_ISBLK(st.st_mode)) {
            ret->type = VIR_STORAGE_TYPE_BLOCK;
        }
    }

119
    if (VIR_STRDUP(ret->path, path) < 0)
120 121
        goto error;

122
    if (virStorageFileGetMetadata(ret, uid, gid, allow_probe, false) < 0)
123 124 125 126 127 128 129 130 131
        goto error;

    return ret;

 error:
    virStorageSourceFree(ret);
    return NULL;
}

132 133 134 135 136
static int
testPrepImages(void)
{
    int ret = EXIT_FAILURE;
    virCommandPtr cmd = NULL;
137 138
    char *buf = NULL;
    bool compat = false;
139 140 141 142

    qemuimg = virFindFileInPath("kvm-img");
    if (!qemuimg)
        qemuimg = virFindFileInPath("qemu-img");
143 144
    if (!qemuimg)
        goto skip;
145

146 147 148
    /* Clean up from any earlier failed tests */
    virFileDeleteTree(datadir);

149 150 151 152 153 154 155 156 157 158 159 160
    /* See if qemu-img supports '-o compat=xxx'.  If so, we force the
     * use of both v2 and v3 files; if not, it is v2 only but the test
     * still works. */
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qcow2",
                               "-o?", "/dev/null", NULL);
    virCommandSetOutputBuffer(cmd, &buf);
    if (virCommandRun(cmd, NULL) < 0)
        goto skip;
    if (strstr(buf, "compat "))
        compat = true;
    VIR_FREE(buf);

161 162 163 164
    if (virAsprintf(&absraw, "%s/raw", datadir) < 0 ||
        virAsprintf(&absqcow2, "%s/qcow2", datadir) < 0 ||
        virAsprintf(&abswrap, "%s/wrap", datadir) < 0 ||
        virAsprintf(&absqed, "%s/qed", datadir) < 0 ||
E
Eric Blake 已提交
165
        virAsprintf(&absdir, "%s/dir", datadir) < 0 ||
166
        virAsprintf(&abslink2, "%s/sub/link2", datadir) < 0)
167 168 169 170 171 172
        goto cleanup;

    if (virFileMakePath(datadir "/sub") < 0) {
        fprintf(stderr, "unable to create directory %s\n", datadir "/sub");
        goto cleanup;
    }
E
Eric Blake 已提交
173 174 175 176
    if (virFileMakePath(datadir "/dir") < 0) {
        fprintf(stderr, "unable to create directory %s\n", datadir "/dir");
        goto cleanup;
    }
E
Eric Blake 已提交
177 178 179 180
    if (!(canondir = canonicalize_file_name(absdir))) {
        virReportOOMError();
        goto cleanup;
    }
181 182 183 184 185 186

    if (chdir(datadir) < 0) {
        fprintf(stderr, "unable to test relative backing chains\n");
        goto cleanup;
    }

187 188
    if (virAsprintf(&buf, "%1024d", 0) < 0 ||
        virFileWriteStr("raw", buf, 0600) < 0) {
189
        fprintf(stderr, "unable to create raw file\n");
190
        goto cleanup;
191
    }
192 193 194 195 196 197 198 199
    if (!(canonraw = canonicalize_file_name(absraw))) {
        virReportOOMError();
        goto cleanup;
    }

    /* Create a qcow2 wrapping relative raw; later on, we modify its
     * metadata to test other configurations */
    virCommandFree(cmd);
200 201 202 203
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qcow2", NULL);
    virCommandAddArgFormat(cmd, "-obacking_file=raw,backing_fmt=raw%s",
                           compat ? ",compat=0.10" : "");
    virCommandAddArg(cmd, "qcow2");
204
    if (virCommandRun(cmd, NULL) < 0)
205
        goto skip;
206 207
    /* Make sure our later uses of 'qemu-img rebase' will work */
    virCommandFree(cmd);
208
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
209
                               "-F", "raw", "-b", "raw", "qcow2", NULL);
210 211
    if (virCommandRun(cmd, NULL) < 0)
        goto skip;
212 213 214 215 216 217 218 219
    if (!(canonqcow2 = canonicalize_file_name(absqcow2))) {
        virReportOOMError();
        goto cleanup;
    }

    /* Create a second qcow2 wrapping the first, to be sure that we
     * can correctly avoid insecure probing.  */
    virCommandFree(cmd);
220
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qcow2", NULL);
221 222
    virCommandAddArgFormat(cmd, "-obacking_file=%s,backing_fmt=qcow2%s",
                           absqcow2, compat ? ",compat=1.1" : "");
223 224
    virCommandAddArg(cmd, "wrap");
    if (virCommandRun(cmd, NULL) < 0)
225
        goto skip;
E
Eric Blake 已提交
226 227 228 229
    if (!(canonwrap = canonicalize_file_name(abswrap))) {
        virReportOOMError();
        goto cleanup;
    }
230 231 232

    /* Create a qed file. */
    virCommandFree(cmd);
233
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qed", NULL);
234 235 236 237
    virCommandAddArgFormat(cmd, "-obacking_file=%s,backing_fmt=raw",
                           absraw);
    virCommandAddArg(cmd, "qed");
    if (virCommandRun(cmd, NULL) < 0)
238
        goto skip;
E
Eric Blake 已提交
239 240 241 242
    if (!(canonqed = canonicalize_file_name(absqed))) {
        virReportOOMError();
        goto cleanup;
    }
243

244
#ifdef HAVE_SYMLINK
245 246 247 248 249 250
    /* Create some symlinks in a sub-directory. */
    if (symlink("../qcow2", datadir "/sub/link1") < 0 ||
        symlink("../wrap", datadir "/sub/link2") < 0) {
        fprintf(stderr, "unable to create symlink");
        goto cleanup;
    }
251
#endif
252 253

    ret = 0;
254
 cleanup:
255
    VIR_FREE(buf);
256 257 258 259
    virCommandFree(cmd);
    if (ret)
        testCleanupImages();
    return ret;
260

261
 skip:
262 263 264
    fputs("qemu-img is too old; skipping this test\n", stderr);
    ret = EXIT_AM_SKIP;
    goto cleanup;
265 266
}

267 268 269 270 271
/* Many fields of virStorageFileMetadata have the same content whether
 * we access the file relatively or absolutely; but file names differ
 * depending on how the chain was opened.  For ease of testing, we
 * test both relative and absolute starts, and use a flag to say which
 * of the two variations to compare against.  */
272 273 274 275 276 277
typedef struct _testFileData testFileData;
struct _testFileData
{
    const char *expBackingStoreRaw;
    unsigned long long expCapacity;
    bool expEncrypted;
278
    const char *pathRel;
279
    const char *path;
E
Eric Blake 已提交
280 281
    int type;
    int format;
282 283 284 285 286 287 288 289 290 291 292 293
};

enum {
    EXP_PASS = 0,
    EXP_FAIL = 1,
    EXP_WARN = 2,
    ALLOW_PROBE = 4,
};

struct testChainData
{
    const char *start;
294
    virStorageFileFormat format;
295
    const testFileData *files[4];
296 297 298 299
    int nfiles;
    unsigned int flags;
};

300 301

static const char testStorageChainFormat[] =
302
    "chain member: %zu\n"
303
    "path:%s\n"
304 305 306 307 308 309 310
    "backingStoreRaw: %s\n"
    "capacity: %lld\n"
    "encryption: %d\n"
    "relPath:%s\n"
    "type:%d\n"
    "format:%d\n";

311 312 313 314 315
static int
testStorageChain(const void *args)
{
    const struct testChainData *data = args;
    int ret = -1;
316 317
    virStorageSourcePtr meta;
    virStorageSourcePtr elt;
318
    size_t i = 0;
E
Eric Blake 已提交
319
    char *broken = NULL;
320

321 322
    meta = testStorageFileGetMetadata(data->start, data->format, -1, -1,
                                      (data->flags & ALLOW_PROBE) != 0);
323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338
    if (!meta) {
        if (data->flags & EXP_FAIL) {
            virResetLastError();
            ret = 0;
        }
        goto cleanup;
    } else if (data->flags & EXP_FAIL) {
        fprintf(stderr, "call should have failed\n");
        goto cleanup;
    }
    if (data->flags & EXP_WARN) {
        if (!virGetLastError()) {
            fprintf(stderr, "call should have warned\n");
            goto cleanup;
        }
        virResetLastError();
E
Eric Blake 已提交
339 340 341 342 343 344 345 346 347 348 349 350 351
        if (virStorageFileChainGetBroken(meta, &broken) || !broken) {
            fprintf(stderr, "call should identify broken part of chain\n");
            goto cleanup;
        }
    } else {
        if (virGetLastError()) {
            fprintf(stderr, "call should not have warned\n");
            goto cleanup;
        }
        if (virStorageFileChainGetBroken(meta, &broken) || broken) {
            fprintf(stderr, "chain should not be identified as broken\n");
            goto cleanup;
        }
352 353 354 355 356 357 358 359 360 361 362 363 364
    }

    elt = meta;
    while (elt) {
        char *expect = NULL;
        char *actual = NULL;

        if (i == data->nfiles) {
            fprintf(stderr, "probed chain was too long\n");
            goto cleanup;
        }

        if (virAsprintf(&expect,
365
                        testStorageChainFormat, i,
366
                        NULLSTR(data->files[i]->path),
367 368
                        NULLSTR(data->files[i]->expBackingStoreRaw),
                        data->files[i]->expCapacity,
369
                        data->files[i]->expEncrypted,
370
                        NULLSTR(data->files[i]->pathRel),
E
Eric Blake 已提交
371 372
                        data->files[i]->type,
                        data->files[i]->format) < 0 ||
373
            virAsprintf(&actual,
374
                        testStorageChainFormat, i,
375
                        NULLSTR(elt->path),
376
                        NULLSTR(elt->backingStoreRaw),
377 378
                        elt->capacity,
                        !!elt->encryption,
379
                        NULLSTR(elt->relPath),
380 381
                        elt->type,
                        elt->format) < 0) {
382 383 384 385 386 387 388 389 390 391 392 393
            VIR_FREE(expect);
            VIR_FREE(actual);
            goto cleanup;
        }
        if (STRNEQ(expect, actual)) {
            virtTestDifference(stderr, expect, actual);
            VIR_FREE(expect);
            VIR_FREE(actual);
            goto cleanup;
        }
        VIR_FREE(expect);
        VIR_FREE(actual);
394
        elt = elt->backingStore;
395 396 397 398 399 400 401 402
        i++;
    }
    if (i != data->nfiles) {
        fprintf(stderr, "probed chain was too short\n");
        goto cleanup;
    }

    ret = 0;
403
 cleanup:
E
Eric Blake 已提交
404
    VIR_FREE(broken);
405
    virStorageSourceFree(meta);
406 407 408
    return ret;
}

E
Eric Blake 已提交
409 410
struct testLookupData
{
411
    virStorageSourcePtr chain;
412
    const char *target;
E
Eric Blake 已提交
413
    virStorageSourcePtr from;
E
Eric Blake 已提交
414
    const char *name;
415
    unsigned int expIndex;
E
Eric Blake 已提交
416
    const char *expResult;
417
    virStorageSourcePtr expMeta;
418
    virStorageSourcePtr expParent;
E
Eric Blake 已提交
419 420 421 422 423 424 425
};

static int
testStorageLookup(const void *args)
{
    const struct testLookupData *data = args;
    int ret = 0;
426
    virStorageSourcePtr result;
427
    virStorageSourcePtr actualParent;
428 429 430 431 432 433 434 435 436 437 438
    unsigned int idx;

    if (virStorageFileParseChainIndex(data->target, data->name, &idx) < 0 &&
        data->expIndex) {
        fprintf(stderr, "call should not have failed\n");
        ret = -1;
    }
    if (idx != data->expIndex) {
        fprintf(stderr, "index: expected %u, got %u\n", data->expIndex, idx);
        ret = -1;
    }
E
Eric Blake 已提交
439

440
     /* Test twice to ensure optional parameter doesn't cause NULL deref. */
E
Eric Blake 已提交
441
    result = virStorageFileChainLookup(data->chain, data->from,
442 443
                                       idx ? NULL : data->name,
                                       idx, NULL);
E
Eric Blake 已提交
444 445 446 447 448 449 450 451 452 453 454 455 456 457

    if (!data->expResult) {
        if (!virGetLastError()) {
            fprintf(stderr, "call should have failed\n");
            ret = -1;
        }
        virResetLastError();
    } else {
        if (virGetLastError()) {
            fprintf(stderr, "call should not have warned\n");
            ret = -1;
        }
    }

458 459 460 461 462 463 464
    if (!result) {
        if (data->expResult) {
            fprintf(stderr, "result 1: expected %s, got NULL\n",
                    data->expResult);
            ret = -1;
        }
    } else if (STRNEQ_NULLABLE(data->expResult, result->path)) {
E
Eric Blake 已提交
465
        fprintf(stderr, "result 1: expected %s, got %s\n",
466
                NULLSTR(data->expResult), NULLSTR(result->path));
E
Eric Blake 已提交
467 468 469
        ret = -1;
    }

E
Eric Blake 已提交
470
    result = virStorageFileChainLookup(data->chain, data->from,
471
                                       data->name, idx, &actualParent);
E
Eric Blake 已提交
472 473
    if (!data->expResult)
        virResetLastError();
474 475 476 477 478 479 480 481

    if (!result) {
        if (data->expResult) {
            fprintf(stderr, "result 2: expected %s, got NULL\n",
                    data->expResult);
            ret = -1;
        }
    } else if (STRNEQ_NULLABLE(data->expResult, result->path)) {
E
Eric Blake 已提交
482
        fprintf(stderr, "result 2: expected %s, got %s\n",
483
                NULLSTR(data->expResult), NULLSTR(result->path));
E
Eric Blake 已提交
484 485
        ret = -1;
    }
486
    if (data->expMeta != result) {
E
Eric Blake 已提交
487
        fprintf(stderr, "meta: expected %p, got %p\n",
488
                data->expMeta, result);
E
Eric Blake 已提交
489 490
        ret = -1;
    }
491
    if (data->expParent != actualParent) {
E
Eric Blake 已提交
492
        fprintf(stderr, "parent: expected %s, got %s\n",
493 494
                NULLSTR(data->expParent ? data->expParent->path : NULL),
                NULLSTR(actualParent ? actualParent->path : NULL));
E
Eric Blake 已提交
495 496 497 498 499 500
        ret = -1;
    }

    return ret;
}

501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517

struct testPathCanonicalizeData
{
    const char *path;
    const char *expect;
};

static const char *testPathCanonicalizeSymlinks[][2] =
{
    {"/path/blah", "/other/path/huzah"},
    {"/path/to/relative/symlink", "../../actual/file"},
    {"/cycle", "/cycle"},
    {"/cycle2/link", "./link"},
};

static int
testPathCanonicalizeReadlink(const char *path,
518
                             char **linkpath,
519 520 521 522
                             void *data ATTRIBUTE_UNUSED)
{
    size_t i;

523
    *linkpath = NULL;
524 525 526

    for (i = 0; i < ARRAY_CARDINALITY(testPathCanonicalizeSymlinks); i++) {
        if (STREQ(path, testPathCanonicalizeSymlinks[i][0])) {
527
            if (VIR_STRDUP(*linkpath, testPathCanonicalizeSymlinks[i][1]) < 0)
528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564
                return -1;

            return 0;
        }
    }

    return 1;
}


static int
testPathCanonicalize(const void *args)
{
    const struct testPathCanonicalizeData *data = args;
    char *canon = NULL;
    int ret = -1;

    canon = virStorageFileCanonicalizePath(data->path,
                                           testPathCanonicalizeReadlink,
                                           NULL);

    if (STRNEQ_NULLABLE(data->expect, canon)) {
        fprintf(stderr,
                "path canonicalization of '%s' failed: expected '%s' got '%s'\n",
                data->path, NULLSTR(data->expect), NULLSTR(canon));

        goto cleanup;
    }

    ret = 0;

 cleanup:
    VIR_FREE(canon);

    return ret;
}

565 566 567 568 569 570 571 572 573 574 575 576 577
static virStorageSource backingchain[12];

static void
testPathRelativePrepare(void)
{
    size_t i;

    for (i = 0; i < ARRAY_CARDINALITY(backingchain); i++) {
        if (i < ARRAY_CARDINALITY(backingchain) - 1)
            backingchain[i].backingStore = &backingchain[i + 1];
        else
            backingchain[i].backingStore = NULL;

578
        backingchain[i].relPath = NULL;
579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656
    }

    /* normal relative backing chain */
    backingchain[0].path = (char *) "/path/to/some/img";

    backingchain[1].path = (char *) "/path/to/some/asdf";
    backingchain[1].relPath = (char *) "asdf";

    backingchain[2].path = (char *) "/path/to/some/test";
    backingchain[2].relPath = (char *) "test";

    backingchain[3].path = (char *) "/path/to/some/blah";
    backingchain[3].relPath = (char *) "blah";

    /* ovirt's backing chain */
    backingchain[4].path = (char *) "/path/to/volume/image1";

    backingchain[5].path = (char *) "/path/to/volume/image2";
    backingchain[5].relPath = (char *) "../volume/image2";

    backingchain[6].path = (char *) "/path/to/volume/image3";
    backingchain[6].relPath = (char *) "../volume/image3";

    backingchain[7].path = (char *) "/path/to/volume/image4";
    backingchain[7].relPath = (char *) "../volume/image4";

    /* some arbitrarily crazy backing chains */
    backingchain[8].path = (char *) "/crazy/base/image";

    backingchain[9].path = (char *) "/crazy/base/directory/stuff/volumes/garbage/image2";
    backingchain[9].relPath = (char *) "directory/stuff/volumes/garbage/image2";

    backingchain[10].path = (char *) "/crazy/base/directory/image3";
    backingchain[10].relPath = (char *) "../../../image3";

    backingchain[11].path = (char *) "/crazy/base/blah/image4";
    backingchain[11].relPath = (char *) "../blah/image4";
}


struct testPathRelativeBacking
{
    virStorageSourcePtr top;
    virStorageSourcePtr base;

    const char *expect;
};

static int
testPathRelative(const void *args)
{
    const struct testPathRelativeBacking *data = args;
    char *actual = NULL;
    int ret = -1;

    if (virStorageFileGetRelativeBackingPath(data->top,
                                             data->base,
                                             &actual) < 0) {
        fprintf(stderr, "relative backing path resolution failed\n");
        goto cleanup;
    }

    if (STRNEQ_NULLABLE(data->expect, actual)) {
        fprintf(stderr, "relative path resolution from '%s' to '%s': "
                "expected '%s', got '%s'\n",
                data->top->path, data->base->path,
                NULLSTR(data->expect), NULLSTR(actual));
        goto cleanup;
    }

    ret = 0;

 cleanup:
    VIR_FREE(actual);

    return ret;
}

657

658 659 660 661 662
static int
mymain(void)
{
    int ret;
    virCommandPtr cmd = NULL;
663
    struct testChainData data;
E
Eric Blake 已提交
664
    struct testLookupData data2;
665
    struct testPathCanonicalizeData data3;
666
    struct testPathRelativeBacking data4;
667
    virStorageSourcePtr chain = NULL;
E
Eric Blake 已提交
668 669
    virStorageSourcePtr chain2; /* short for chain->backingStore */
    virStorageSourcePtr chain3; /* short for chain2->backingStore */
670 671 672 673 674 675

    /* Prep some files with qemu-img; if that is not found on PATH, or
     * if it lacks support for qcow2 and qed, skip this test.  */
    if ((ret = testPrepImages()) != 0)
        return ret;

676
#define TEST_ONE_CHAIN(id, start, format, flags, ...)                \
677
    do {                                                             \
678 679 680 681
        size_t i;                                                    \
        memset(&data, 0, sizeof(data));                              \
        data = (struct testChainData){                               \
            start, format, { __VA_ARGS__ }, 0, flags,                \
682
        };                                                           \
683 684 685
        for (i = 0; i < ARRAY_CARDINALITY(data.files); i++)          \
            if (data.files[i])                                       \
                data.nfiles++;                                       \
686
        if (virtTestRun("Storage backing chain " id,                 \
687 688 689 690
                        testStorageChain, &data) < 0)                \
            ret = -1;                                                \
    } while (0)

691 692 693
#define VIR_FLATTEN_2(...) __VA_ARGS__
#define VIR_FLATTEN_1(_1) VIR_FLATTEN_2 _1

694 695 696 697
#define TEST_CHAIN(id, path, format, chain1, flags1, chain2, flags2)           \
    do {                                                                       \
        TEST_ONE_CHAIN(#id "a", path, format, flags1, VIR_FLATTEN_1(chain1));  \
        TEST_ONE_CHAIN(#id "b", path, format, flags2, VIR_FLATTEN_1(chain2));  \
698 699 700 701 702
    } while (0)

    /* The actual tests, in several groups. */

    /* Missing file */
703
    TEST_ONE_CHAIN("0", "bogus", VIR_STORAGE_FILE_RAW, EXP_FAIL);
704 705

    /* Raw image, whether with right format or no specified format */
706
    testFileData raw = {
707
        .path = canonraw,
E
Eric Blake 已提交
708 709
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_RAW,
710
    };
711
    TEST_CHAIN(1, absraw, VIR_STORAGE_FILE_RAW,
712 713
               (&raw), EXP_PASS,
               (&raw), ALLOW_PROBE | EXP_PASS);
714
    TEST_CHAIN(2, absraw, VIR_STORAGE_FILE_AUTO,
715 716
               (&raw), EXP_PASS,
               (&raw), ALLOW_PROBE | EXP_PASS);
717 718

    /* Qcow2 file with relative raw backing, format provided */
719
    raw.pathRel = "raw";
720
    testFileData qcow2 = {
721 722
        .expBackingStoreRaw = "raw",
        .expCapacity = 1024,
723
        .path = canonqcow2,
E
Eric Blake 已提交
724 725
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
726 727
    };
    testFileData qcow2_as_raw = {
728
        .path = canonqcow2,
E
Eric Blake 已提交
729 730
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_RAW,
731
    };
732
    TEST_CHAIN(3, absqcow2, VIR_STORAGE_FILE_QCOW2,
733 734
               (&qcow2, &raw), EXP_PASS,
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
735
    TEST_CHAIN(4, absqcow2, VIR_STORAGE_FILE_AUTO,
736
               (&qcow2_as_raw), EXP_PASS,
737
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
738 739 740 741 742 743 744

    /* Rewrite qcow2 file to use absolute backing name */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", absraw, "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
745
    qcow2.expBackingStoreRaw = absraw;
746
    raw.pathRel = NULL;
747 748

    /* Qcow2 file with raw as absolute backing, backing format provided */
749
    TEST_CHAIN(5, absqcow2, VIR_STORAGE_FILE_QCOW2,
750 751
               (&qcow2, &raw), EXP_PASS,
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
752
    TEST_CHAIN(6, absqcow2, VIR_STORAGE_FILE_AUTO,
753
               (&qcow2_as_raw), EXP_PASS,
754
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
755 756

    /* Wrapped file access */
757 758 759
    testFileData wrap = {
        .expBackingStoreRaw = absqcow2,
        .expCapacity = 1024,
760
        .path = canonwrap,
E
Eric Blake 已提交
761 762
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
763
    };
764
    TEST_CHAIN(7, abswrap, VIR_STORAGE_FILE_QCOW2,
765 766
               (&wrap, &qcow2, &raw), EXP_PASS,
               (&wrap, &qcow2, &raw), ALLOW_PROBE | EXP_PASS);
767 768 769 770 771 772 773 774 775 776 777 778 779 780 781

    /* Rewrite qcow2 and wrap file to omit backing file type */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-b", absraw, "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-b", absqcow2, "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Qcow2 file with raw as absolute backing, backing format omitted */
782 783 784
    testFileData wrap_as_raw = {
        .expBackingStoreRaw = absqcow2,
        .expCapacity = 1024,
785
        .path = canonwrap,
E
Eric Blake 已提交
786 787
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
788
    };
789
    TEST_CHAIN(8, abswrap, VIR_STORAGE_FILE_QCOW2,
790
               (&wrap_as_raw, &qcow2_as_raw), EXP_PASS,
791
               (&wrap, &qcow2, &raw), ALLOW_PROBE | EXP_PASS);
792 793 794 795 796 797 798 799

    /* Rewrite qcow2 to a missing backing file, with backing type */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", datadir "/bogus",
                               "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
800
    qcow2.expBackingStoreRaw = datadir "/bogus";
801 802

    /* Qcow2 file with missing backing file but specified type */
803
    TEST_CHAIN(9, absqcow2, VIR_STORAGE_FILE_QCOW2,
804 805
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN);
806 807 808 809 810 811 812 813 814

    /* Rewrite qcow2 to a missing backing file, without backing type */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-b", datadir "/bogus", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Qcow2 file with missing backing file and no specified type */
815
    TEST_CHAIN(10, absqcow2, VIR_STORAGE_FILE_QCOW2,
816 817
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN);
818 819 820 821

    /* Rewrite qcow2 to use an nbd: protocol as backend */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
822
                               "-F", "raw", "-b", "nbd:example.org:6000:exportname=blah",
823 824 825
                               "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
826
    qcow2.expBackingStoreRaw = "nbd:example.org:6000:exportname=blah";
827 828

    /* Qcow2 file with backing protocol instead of file */
829
    testFileData nbd = {
830
        .path = "blah",
831 832 833
        .type = VIR_STORAGE_TYPE_NETWORK,
        .format = VIR_STORAGE_FILE_RAW,
    };
834
    TEST_CHAIN(11, absqcow2, VIR_STORAGE_FILE_QCOW2,
835 836
               (&qcow2, &nbd), EXP_PASS,
               (&qcow2, &nbd), ALLOW_PROBE | EXP_PASS);
837

838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856
    /* Rewrite qcow2 to use an nbd: protocol as backend */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", "nbd+tcp://example.org:6000/blah",
                               "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
    qcow2.expBackingStoreRaw = "nbd+tcp://example.org:6000/blah";

    /* Qcow2 file with backing protocol instead of file */
    testFileData nbd2 = {
        .path = "blah",
        .type = VIR_STORAGE_TYPE_NETWORK,
        .format = VIR_STORAGE_FILE_RAW,
    };
    TEST_CHAIN(12, absqcow2, VIR_STORAGE_FILE_QCOW2,
               (&qcow2, &nbd2), EXP_PASS,
               (&qcow2, &nbd2), ALLOW_PROBE | EXP_PASS);

857
    /* qed file */
858 859 860
    testFileData qed = {
        .expBackingStoreRaw = absraw,
        .expCapacity = 1024,
861
        .path = canonqed,
E
Eric Blake 已提交
862 863
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QED,
864 865
    };
    testFileData qed_as_raw = {
866
        .path = canonqed,
E
Eric Blake 已提交
867 868
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_RAW,
869
    };
870
    TEST_CHAIN(13, absqed, VIR_STORAGE_FILE_AUTO,
871
               (&qed_as_raw), EXP_PASS,
872
               (&qed, &raw), ALLOW_PROBE | EXP_PASS);
873

E
Eric Blake 已提交
874
    /* directory */
875
    testFileData dir = {
876
        .path = canondir,
E
Eric Blake 已提交
877 878
        .type = VIR_STORAGE_TYPE_DIR,
        .format = VIR_STORAGE_FILE_DIR,
879
    };
880
    TEST_CHAIN(14, absdir, VIR_STORAGE_FILE_AUTO,
E
Eric Blake 已提交
881 882
               (&dir), EXP_PASS,
               (&dir), ALLOW_PROBE | EXP_PASS);
883
    TEST_CHAIN(15, absdir, VIR_STORAGE_FILE_DIR,
E
Eric Blake 已提交
884 885 886
               (&dir), EXP_PASS,
               (&dir), ALLOW_PROBE | EXP_PASS);

887
#ifdef HAVE_SYMLINK
888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903
    /* Rewrite qcow2 and wrap file to use backing names relative to a
     * symlink from a different directory */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", "../raw", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "../sub/link1", "wrap",
                               NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Behavior of symlinks to qcow2 with relative backing files */
904
    testFileData link1 = {
905 906
        .expBackingStoreRaw = "../raw",
        .expCapacity = 1024,
907
        .pathRel = "../sub/link1",
908
        .path = datadir "/sub/../sub/link1",
E
Eric Blake 已提交
909 910
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
911
    };
912
    testFileData link2 = {
913 914
        .expBackingStoreRaw = "../sub/link1",
        .expCapacity = 1024,
915
        .path = abslink2,
E
Eric Blake 已提交
916 917
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
918
    };
919 920

    raw.path = datadir "/sub/../sub/../raw";
921
    raw.pathRel = "../raw";
922
    TEST_CHAIN(16, abslink2, VIR_STORAGE_FILE_QCOW2,
923 924
               (&link2, &link1, &raw), EXP_PASS,
               (&link2, &link1, &raw), ALLOW_PROBE | EXP_PASS);
925
#endif
E
Eric Blake 已提交
926 927 928 929 930 931 932

    /* Rewrite qcow2 to be a self-referential loop */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "qcow2", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
933
    qcow2.expBackingStoreRaw = "qcow2";
E
Eric Blake 已提交
934 935

    /* Behavior of an infinite loop chain */
936
    TEST_CHAIN(17, absqcow2, VIR_STORAGE_FILE_QCOW2,
937 938
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN);
E
Eric Blake 已提交
939 940 941 942 943 944 945 946 947 948 949 950 951

    /* Rewrite wrap and qcow2 to be mutually-referential loop */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "wrap", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", absqcow2, "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
952
    qcow2.expBackingStoreRaw = "wrap";
E
Eric Blake 已提交
953 954

    /* Behavior of an infinite loop chain */
955
    TEST_CHAIN(18, abswrap, VIR_STORAGE_FILE_QCOW2,
956 957
               (&wrap, &qcow2), EXP_WARN,
               (&wrap, &qcow2), ALLOW_PROBE | EXP_WARN);
E
Eric Blake 已提交
958

E
Eric Blake 已提交
959 960 961 962 963 964 965
    /* Rewrite wrap and qcow2 back to 3-deep chain, absolute backing */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", absraw, "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

966
    /* Test behavior of chain lookups, absolute backing from relative start */
967 968
    chain = testStorageFileGetMetadata("wrap", VIR_STORAGE_FILE_QCOW2,
                                       -1, -1, false);
E
Eric Blake 已提交
969 970 971 972
    if (!chain) {
        ret = -1;
        goto cleanup;
    }
E
Eric Blake 已提交
973 974
    chain2 = chain->backingStore;
    chain3 = chain2->backingStore;
E
Eric Blake 已提交
975

E
Eric Blake 已提交
976
#define TEST_LOOKUP_TARGET(id, target, from, name, index, result,       \
E
Eric Blake 已提交
977
                           meta, parent)                                \
E
Eric Blake 已提交
978 979 980 981 982 983 984
    do {                                                                \
        data2 = (struct testLookupData){                                \
            chain, target, from, name, index,                           \
            result, meta, parent, };                                    \
        if (virtTestRun("Chain lookup " #id,                            \
                        testStorageLookup, &data2) < 0)                 \
            ret = -1;                                                   \
E
Eric Blake 已提交
985
    } while (0)
E
Eric Blake 已提交
986 987 988 989
#define TEST_LOOKUP(id, from, name, result, meta, parent)               \
    TEST_LOOKUP_TARGET(id, NULL, from, name, 0, result, meta, parent)

    TEST_LOOKUP(0, NULL, "bogus", NULL, NULL, NULL);
E
Eric Blake 已提交
990
    TEST_LOOKUP(1, chain, "bogus", NULL, NULL, NULL);
E
Eric Blake 已提交
991
    TEST_LOOKUP(2, NULL, "wrap", chain->path, chain, NULL);
E
Eric Blake 已提交
992
    TEST_LOOKUP(3, chain, "wrap", NULL, NULL, NULL);
E
Eric Blake 已提交
993
    TEST_LOOKUP(4, chain2, "wrap", NULL, NULL, NULL);
E
Eric Blake 已提交
994
    TEST_LOOKUP(5, NULL, abswrap, chain->path, chain, NULL);
E
Eric Blake 已提交
995
    TEST_LOOKUP(6, chain, abswrap, NULL, NULL, NULL);
E
Eric Blake 已提交
996
    TEST_LOOKUP(7, chain2, abswrap, NULL, NULL, NULL);
997 998
    TEST_LOOKUP(8, NULL, "qcow2", chain2->path, chain2, chain);
    TEST_LOOKUP(9, chain, "qcow2", chain2->path, chain2, chain);
E
Eric Blake 已提交
999
    TEST_LOOKUP(10, chain2, "qcow2", NULL, NULL, NULL);
E
Eric Blake 已提交
1000
    TEST_LOOKUP(11, chain3, "qcow2", NULL, NULL, NULL);
1001 1002
    TEST_LOOKUP(12, NULL, absqcow2, chain2->path, chain2, chain);
    TEST_LOOKUP(13, chain, absqcow2, chain2->path, chain2, chain);
E
Eric Blake 已提交
1003
    TEST_LOOKUP(14, chain2, absqcow2, NULL, NULL, NULL);
E
Eric Blake 已提交
1004
    TEST_LOOKUP(15, chain3, absqcow2, NULL, NULL, NULL);
1005 1006 1007
    TEST_LOOKUP(16, NULL, "raw", chain3->path, chain3, chain2);
    TEST_LOOKUP(17, chain, "raw", chain3->path, chain3, chain2);
    TEST_LOOKUP(18, chain2, "raw", chain3->path, chain3, chain2);
E
Eric Blake 已提交
1008
    TEST_LOOKUP(19, chain3, "raw", NULL, NULL, NULL);
1009 1010 1011
    TEST_LOOKUP(20, NULL, absraw, chain3->path, chain3, chain2);
    TEST_LOOKUP(21, chain, absraw, chain3->path, chain3, chain2);
    TEST_LOOKUP(22, chain2, absraw, chain3->path, chain3, chain2);
E
Eric Blake 已提交
1012
    TEST_LOOKUP(23, chain3, absraw, NULL, NULL, NULL);
1013 1014 1015
    TEST_LOOKUP(24, NULL, NULL, chain3->path, chain3, chain2);
    TEST_LOOKUP(25, chain, NULL, chain3->path, chain3, chain2);
    TEST_LOOKUP(26, chain2, NULL, chain3->path, chain3, chain2);
E
Eric Blake 已提交
1016
    TEST_LOOKUP(27, chain3, NULL, NULL, NULL, NULL);
E
Eric Blake 已提交
1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030

    /* Rewrite wrap and qcow2 back to 3-deep chain, relative backing */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", "raw", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "qcow2", "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

1031
    /* Test behavior of chain lookups, relative backing from absolute start */
1032
    virStorageSourceFree(chain);
1033 1034
    chain = testStorageFileGetMetadata(abswrap, VIR_STORAGE_FILE_QCOW2,
                                       -1, -1, false);
E
Eric Blake 已提交
1035 1036 1037 1038
    if (!chain) {
        ret = -1;
        goto cleanup;
    }
E
Eric Blake 已提交
1039 1040
    chain2 = chain->backingStore;
    chain3 = chain2->backingStore;
E
Eric Blake 已提交
1041

E
Eric Blake 已提交
1042
    TEST_LOOKUP(28, NULL, "bogus", NULL, NULL, NULL);
E
Eric Blake 已提交
1043
    TEST_LOOKUP(29, chain, "bogus", NULL, NULL, NULL);
E
Eric Blake 已提交
1044
    TEST_LOOKUP(30, NULL, "wrap", chain->path, chain, NULL);
E
Eric Blake 已提交
1045
    TEST_LOOKUP(31, chain, "wrap", NULL, NULL, NULL);
E
Eric Blake 已提交
1046
    TEST_LOOKUP(32, chain2, "wrap", NULL, NULL, NULL);
E
Eric Blake 已提交
1047
    TEST_LOOKUP(33, NULL, abswrap, chain->path, chain, NULL);
E
Eric Blake 已提交
1048
    TEST_LOOKUP(34, chain, abswrap, NULL, NULL, NULL);
E
Eric Blake 已提交
1049
    TEST_LOOKUP(35, chain2, abswrap, NULL, NULL, NULL);
1050 1051
    TEST_LOOKUP(36, NULL, "qcow2", chain2->path, chain2, chain);
    TEST_LOOKUP(37, chain, "qcow2", chain2->path, chain2, chain);
E
Eric Blake 已提交
1052
    TEST_LOOKUP(38, chain2, "qcow2", NULL, NULL, NULL);
E
Eric Blake 已提交
1053
    TEST_LOOKUP(39, chain3, "qcow2", NULL, NULL, NULL);
1054 1055
    TEST_LOOKUP(40, NULL, absqcow2, chain2->path, chain2, chain);
    TEST_LOOKUP(41, chain, absqcow2, chain2->path, chain2, chain);
E
Eric Blake 已提交
1056
    TEST_LOOKUP(42, chain2, absqcow2, NULL, NULL, NULL);
E
Eric Blake 已提交
1057
    TEST_LOOKUP(43, chain3, absqcow2, NULL, NULL, NULL);
1058 1059 1060
    TEST_LOOKUP(44, NULL, "raw", chain3->path, chain3, chain2);
    TEST_LOOKUP(45, chain, "raw", chain3->path, chain3, chain2);
    TEST_LOOKUP(46, chain2, "raw", chain3->path, chain3, chain2);
E
Eric Blake 已提交
1061
    TEST_LOOKUP(47, chain3, "raw", NULL, NULL, NULL);
1062 1063 1064
    TEST_LOOKUP(48, NULL, absraw, chain3->path, chain3, chain2);
    TEST_LOOKUP(49, chain, absraw, chain3->path, chain3, chain2);
    TEST_LOOKUP(50, chain2, absraw, chain3->path, chain3, chain2);
E
Eric Blake 已提交
1065
    TEST_LOOKUP(51, chain3, absraw, NULL, NULL, NULL);
1066 1067 1068
    TEST_LOOKUP(52, NULL, NULL, chain3->path, chain3, chain2);
    TEST_LOOKUP(53, chain, NULL, chain3->path, chain3, chain2);
    TEST_LOOKUP(54, chain2, NULL, chain3->path, chain3, chain2);
E
Eric Blake 已提交
1069
    TEST_LOOKUP(55, chain3, NULL, NULL, NULL, NULL);
E
Eric Blake 已提交
1070 1071 1072 1073 1074 1075 1076 1077 1078

    /* Use link to wrap with cross-directory relative backing */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "../qcow2", "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Test behavior of chain lookups, relative backing */
1079
    virStorageSourceFree(chain);
1080 1081
    chain = testStorageFileGetMetadata("sub/link2", VIR_STORAGE_FILE_QCOW2,
                                       -1, -1, false);
E
Eric Blake 已提交
1082 1083 1084 1085
    if (!chain) {
        ret = -1;
        goto cleanup;
    }
E
Eric Blake 已提交
1086 1087
    chain2 = chain->backingStore;
    chain3 = chain2->backingStore;
E
Eric Blake 已提交
1088

E
Eric Blake 已提交
1089 1090 1091 1092
    TEST_LOOKUP(56, NULL, "bogus", NULL, NULL, NULL);
    TEST_LOOKUP(57, NULL, "sub/link2", chain->path, chain, NULL);
    TEST_LOOKUP(58, NULL, "wrap", chain->path, chain, NULL);
    TEST_LOOKUP(59, NULL, abswrap, chain->path, chain, NULL);
1093
    TEST_LOOKUP(60, NULL, "../qcow2", chain2->path, chain2, chain);
E
Eric Blake 已提交
1094
    TEST_LOOKUP(61, NULL, "qcow2", NULL, NULL, NULL);
1095 1096 1097 1098
    TEST_LOOKUP(62, NULL, absqcow2, chain2->path, chain2, chain);
    TEST_LOOKUP(63, NULL, "raw", chain3->path, chain3, chain2);
    TEST_LOOKUP(64, NULL, absraw, chain3->path, chain3, chain2);
    TEST_LOOKUP(65, NULL, NULL, chain3->path, chain3, chain2);
E
Eric Blake 已提交
1099 1100 1101 1102 1103

    TEST_LOOKUP_TARGET(66, "vda", NULL, "bogus[1]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(67, "vda", NULL, "vda[-1]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(68, "vda", NULL, "vda[1][1]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(69, "vda", NULL, "wrap", 0, chain->path, chain, NULL);
E
Eric Blake 已提交
1104
    TEST_LOOKUP_TARGET(70, "vda", chain, "wrap", 0, NULL, NULL, NULL);
E
Eric Blake 已提交
1105
    TEST_LOOKUP_TARGET(71, "vda", chain2, "wrap", 0, NULL, NULL, NULL);
E
Eric Blake 已提交
1106
    TEST_LOOKUP_TARGET(72, "vda", NULL, "vda[0]", 0, NULL, NULL, NULL);
1107 1108
    TEST_LOOKUP_TARGET(73, "vda", NULL, "vda[1]", 1, chain2->path, chain2, chain);
    TEST_LOOKUP_TARGET(74, "vda", chain, "vda[1]", 1, chain2->path, chain2, chain);
E
Eric Blake 已提交
1109
    TEST_LOOKUP_TARGET(75, "vda", chain2, "vda[1]", 1, NULL, NULL, NULL);
E
Eric Blake 已提交
1110
    TEST_LOOKUP_TARGET(76, "vda", chain3, "vda[1]", 1, NULL, NULL, NULL);
1111 1112 1113
    TEST_LOOKUP_TARGET(77, "vda", NULL, "vda[2]", 2, chain3->path, chain3, chain2);
    TEST_LOOKUP_TARGET(78, "vda", chain, "vda[2]", 2, chain3->path, chain3, chain2);
    TEST_LOOKUP_TARGET(79, "vda", chain2, "vda[2]", 2, chain3->path, chain3, chain2);
E
Eric Blake 已提交
1114
    TEST_LOOKUP_TARGET(80, "vda", chain3, "vda[2]", 2, NULL, NULL, NULL);
E
Eric Blake 已提交
1115
    TEST_LOOKUP_TARGET(81, "vda", NULL, "vda[3]", 3, NULL, NULL, NULL);
1116

1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159
#define TEST_PATH_CANONICALIZE(id, PATH, EXPECT)                            \
    do {                                                                    \
        data3.path = PATH;                                                  \
        data3.expect = EXPECT;                                              \
        if (virtTestRun("Path canonicalize " #id,                           \
                        testPathCanonicalize, &data3) < 0)                  \
            ret = -1;                                                       \
    } while (0)

    TEST_PATH_CANONICALIZE(1, "/", "/");
    TEST_PATH_CANONICALIZE(2, "/path", "/path");
    TEST_PATH_CANONICALIZE(3, "/path/to/blah", "/path/to/blah");
    TEST_PATH_CANONICALIZE(4, "/path/", "/path");
    TEST_PATH_CANONICALIZE(5, "///////", "/");
    TEST_PATH_CANONICALIZE(6, "//", "//");
    TEST_PATH_CANONICALIZE(7, "", "");
    TEST_PATH_CANONICALIZE(8, ".", ".");
    TEST_PATH_CANONICALIZE(9, "../", "..");
    TEST_PATH_CANONICALIZE(10, "../../", "../..");
    TEST_PATH_CANONICALIZE(11, "../../blah", "../../blah");
    TEST_PATH_CANONICALIZE(12, "/./././blah", "/blah");
    TEST_PATH_CANONICALIZE(13, ".././../././../blah", "../../../blah");
    TEST_PATH_CANONICALIZE(14, "/././", "/");
    TEST_PATH_CANONICALIZE(15, "./././", ".");
    TEST_PATH_CANONICALIZE(16, "blah/../foo", "foo");
    TEST_PATH_CANONICALIZE(17, "foo/bar/../blah", "foo/blah");
    TEST_PATH_CANONICALIZE(18, "foo/bar/.././blah", "foo/blah");
    TEST_PATH_CANONICALIZE(19, "/path/to/foo/bar/../../../../../../../../baz", "/baz");
    TEST_PATH_CANONICALIZE(20, "path/to/foo/bar/../../../../../../../../baz", "../../../../baz");
    TEST_PATH_CANONICALIZE(21, "path/to/foo/bar", "path/to/foo/bar");
    TEST_PATH_CANONICALIZE(22, "//foo//bar", "//foo/bar");
    TEST_PATH_CANONICALIZE(23, "/bar//foo", "/bar/foo");
    TEST_PATH_CANONICALIZE(24, "//../blah", "//blah");

    /* test paths with symlinks */
    TEST_PATH_CANONICALIZE(25, "/path/blah", "/other/path/huzah");
    TEST_PATH_CANONICALIZE(26, "/path/to/relative/symlink", "/path/actual/file");
    TEST_PATH_CANONICALIZE(27, "/path/to/relative/symlink/blah", "/path/actual/file/blah");
    TEST_PATH_CANONICALIZE(28, "/path/blah/yippee", "/other/path/huzah/yippee");
    TEST_PATH_CANONICALIZE(29, "/cycle", NULL);
    TEST_PATH_CANONICALIZE(30, "/cycle2/link", NULL);
    TEST_PATH_CANONICALIZE(31, "///", "/");

1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206
#define TEST_RELATIVE_BACKING(id, TOP, BASE, EXPECT)                        \
    do {                                                                    \
        data4.top = &TOP;                                                   \
        data4.base = &BASE;                                                 \
        data4.expect = EXPECT;                                              \
        if (virtTestRun("Path relative resolve " #id,                       \
                        testPathRelative, &data4) < 0)                      \
            ret = -1;                                                       \
    } while (0)

    testPathRelativePrepare();

    /* few negative tests first */

    /* a non-relative image is in the backing chain span */
    TEST_RELATIVE_BACKING(1, backingchain[0], backingchain[1], NULL);
    TEST_RELATIVE_BACKING(2, backingchain[0], backingchain[2], NULL);
    TEST_RELATIVE_BACKING(3, backingchain[0], backingchain[3], NULL);
    TEST_RELATIVE_BACKING(4, backingchain[1], backingchain[5], NULL);

    /* image is not in chain (specified backwards) */
    TEST_RELATIVE_BACKING(5, backingchain[2], backingchain[1], NULL);

    /* positive tests */
    TEST_RELATIVE_BACKING(6, backingchain[1], backingchain[1], "asdf");
    TEST_RELATIVE_BACKING(7, backingchain[1], backingchain[2], "test");
    TEST_RELATIVE_BACKING(8, backingchain[1], backingchain[3], "blah");
    TEST_RELATIVE_BACKING(9, backingchain[2], backingchain[2], "test");
    TEST_RELATIVE_BACKING(10, backingchain[2], backingchain[3], "blah");
    TEST_RELATIVE_BACKING(11, backingchain[3], backingchain[3], "blah");

    /* oVirt spelling */
    TEST_RELATIVE_BACKING(12, backingchain[5], backingchain[5], "../volume/image2");
    TEST_RELATIVE_BACKING(13, backingchain[5], backingchain[6], "../volume/../volume/image3");
    TEST_RELATIVE_BACKING(14, backingchain[5], backingchain[7], "../volume/../volume/../volume/image4");
    TEST_RELATIVE_BACKING(15, backingchain[6], backingchain[6], "../volume/image3");
    TEST_RELATIVE_BACKING(16, backingchain[6], backingchain[7], "../volume/../volume/image4");
    TEST_RELATIVE_BACKING(17, backingchain[7], backingchain[7], "../volume/image4");

    /* crazy spellings */
    TEST_RELATIVE_BACKING(17, backingchain[9], backingchain[9], "directory/stuff/volumes/garbage/image2");
    TEST_RELATIVE_BACKING(18, backingchain[9], backingchain[10], "directory/stuff/volumes/garbage/../../../image3");
    TEST_RELATIVE_BACKING(19, backingchain[9], backingchain[11], "directory/stuff/volumes/garbage/../../../../blah/image4");
    TEST_RELATIVE_BACKING(20, backingchain[10], backingchain[10], "../../../image3");
    TEST_RELATIVE_BACKING(21, backingchain[10], backingchain[11], "../../../../blah/image4");
    TEST_RELATIVE_BACKING(22, backingchain[11], backingchain[11], "../blah/image4");

E
Eric Blake 已提交
1207
 cleanup:
1208
    /* Final cleanup */
1209
    virStorageSourceFree(chain);
1210 1211 1212 1213 1214 1215 1216
    testCleanupImages();
    virCommandFree(cmd);

    return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
}

VIRT_TEST_MAIN(mymain)