virstoragetest.c 42.1 KB
Newer Older
1
/*
2
 * Copyright (C) 2013-2014 Red Hat, Inc.
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library.  If not, see
 * <http://www.gnu.org/licenses/>.
 *
 * Author: Eric Blake <eblake@redhat.com>
 */

#include <config.h>

#include <stdlib.h>

#include "testutils.h"
#include "vircommand.h"
#include "virerror.h"
28
#include "virfile.h"
29 30
#include "virlog.h"
#include "virstoragefile.h"
31
#include "virstring.h"
32
#include "dirname.h"
33

34 35
#include "storage/storage_driver.h"

36 37
#define VIR_FROM_THIS VIR_FROM_NONE

38 39
VIR_LOG_INIT("tests.storagetest");

40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61
#define datadir abs_builddir "/virstoragedata"

/* This test creates the following files, all in datadir:

 * raw: 1024-byte raw file
 * qcow2: qcow2 file with 'raw' as backing
 * wrap: qcow2 file with 'qcow2' as backing
 * qed: qed file with 'raw' as backing
 * sub/link1: symlink to qcow2
 * sub/link2: symlink to wrap
 *
 * Relative names to these files are known at compile time, but absolute
 * and canonical names depend on where the test is run; for convenience,
 * we pre-populate the computation of these names for use during the test.
*/

static char *qemuimg;
static char *absraw;
static char *canonraw;
static char *absqcow2;
static char *canonqcow2;
static char *abswrap;
E
Eric Blake 已提交
62
static char *canonwrap;
63
static char *absqed;
E
Eric Blake 已提交
64
static char *canonqed;
E
Eric Blake 已提交
65
static char *absdir;
E
Eric Blake 已提交
66
static char *canondir;
67 68 69 70 71 72 73 74 75 76 77
static char *abslink2;

static void
testCleanupImages(void)
{
    VIR_FREE(qemuimg);
    VIR_FREE(absraw);
    VIR_FREE(canonraw);
    VIR_FREE(absqcow2);
    VIR_FREE(canonqcow2);
    VIR_FREE(abswrap);
E
Eric Blake 已提交
78
    VIR_FREE(canonwrap);
79
    VIR_FREE(absqed);
E
Eric Blake 已提交
80
    VIR_FREE(canonqed);
E
Eric Blake 已提交
81
    VIR_FREE(absdir);
E
Eric Blake 已提交
82
    VIR_FREE(canondir);
83 84 85 86 87 88 89 90
    VIR_FREE(abslink2);

    if (chdir(abs_builddir) < 0) {
        fprintf(stderr, "unable to return to correct directory, refusing to "
                "clean up %s\n", datadir);
        return;
    }

91
    virFileDeleteTree(datadir);
92 93
}

94 95 96 97 98 99 100

static virStorageSourcePtr
testStorageFileGetMetadata(const char *path,
                           int format,
                           uid_t uid, gid_t gid,
                           bool allow_probe)
{
101
    struct stat st;
102 103 104 105 106 107 108 109
    virStorageSourcePtr ret = NULL;

    if (VIR_ALLOC(ret) < 0)
        return NULL;

    ret->type = VIR_STORAGE_TYPE_FILE;
    ret->format = format;

110 111 112 113 114 115 116 117 118
    if (stat(path, &st) == 0) {
        if (S_ISDIR(st.st_mode)) {
            ret->type = VIR_STORAGE_TYPE_DIR;
            ret->format = VIR_STORAGE_FILE_DIR;
        } else if (S_ISBLK(st.st_mode)) {
            ret->type = VIR_STORAGE_TYPE_BLOCK;
        }
    }

119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141
    if (VIR_STRDUP(ret->relPath, path) < 0)
        goto error;

    if (!(ret->relDir = mdir_name(path))) {
        virReportOOMError();
        goto error;
    }

    if (!(ret->path = canonicalize_file_name(path))) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "failed to resolve '%s'", path);
        goto error;
    }

    if (virStorageFileGetMetadata(ret, uid, gid, allow_probe) < 0)
        goto error;

    return ret;

 error:
    virStorageSourceFree(ret);
    return NULL;
}

142 143 144 145 146
static int
testPrepImages(void)
{
    int ret = EXIT_FAILURE;
    virCommandPtr cmd = NULL;
147 148
    char *buf = NULL;
    bool compat = false;
149 150 151 152

    qemuimg = virFindFileInPath("kvm-img");
    if (!qemuimg)
        qemuimg = virFindFileInPath("qemu-img");
153 154
    if (!qemuimg)
        goto skip;
155

156 157 158
    /* Clean up from any earlier failed tests */
    virFileDeleteTree(datadir);

159 160 161 162 163 164 165 166 167 168 169 170
    /* See if qemu-img supports '-o compat=xxx'.  If so, we force the
     * use of both v2 and v3 files; if not, it is v2 only but the test
     * still works. */
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qcow2",
                               "-o?", "/dev/null", NULL);
    virCommandSetOutputBuffer(cmd, &buf);
    if (virCommandRun(cmd, NULL) < 0)
        goto skip;
    if (strstr(buf, "compat "))
        compat = true;
    VIR_FREE(buf);

171 172 173 174
    if (virAsprintf(&absraw, "%s/raw", datadir) < 0 ||
        virAsprintf(&absqcow2, "%s/qcow2", datadir) < 0 ||
        virAsprintf(&abswrap, "%s/wrap", datadir) < 0 ||
        virAsprintf(&absqed, "%s/qed", datadir) < 0 ||
E
Eric Blake 已提交
175
        virAsprintf(&absdir, "%s/dir", datadir) < 0 ||
176
        virAsprintf(&abslink2, "%s/sub/link2", datadir) < 0)
177 178 179 180 181 182
        goto cleanup;

    if (virFileMakePath(datadir "/sub") < 0) {
        fprintf(stderr, "unable to create directory %s\n", datadir "/sub");
        goto cleanup;
    }
E
Eric Blake 已提交
183 184 185 186
    if (virFileMakePath(datadir "/dir") < 0) {
        fprintf(stderr, "unable to create directory %s\n", datadir "/dir");
        goto cleanup;
    }
E
Eric Blake 已提交
187 188 189 190
    if (!(canondir = canonicalize_file_name(absdir))) {
        virReportOOMError();
        goto cleanup;
    }
191 192 193 194 195 196

    if (chdir(datadir) < 0) {
        fprintf(stderr, "unable to test relative backing chains\n");
        goto cleanup;
    }

197 198
    if (virAsprintf(&buf, "%1024d", 0) < 0 ||
        virFileWriteStr("raw", buf, 0600) < 0) {
199
        fprintf(stderr, "unable to create raw file\n");
200
        goto cleanup;
201
    }
202 203 204 205 206 207 208 209
    if (!(canonraw = canonicalize_file_name(absraw))) {
        virReportOOMError();
        goto cleanup;
    }

    /* Create a qcow2 wrapping relative raw; later on, we modify its
     * metadata to test other configurations */
    virCommandFree(cmd);
210 211 212 213
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qcow2", NULL);
    virCommandAddArgFormat(cmd, "-obacking_file=raw,backing_fmt=raw%s",
                           compat ? ",compat=0.10" : "");
    virCommandAddArg(cmd, "qcow2");
214
    if (virCommandRun(cmd, NULL) < 0)
215
        goto skip;
216 217
    /* Make sure our later uses of 'qemu-img rebase' will work */
    virCommandFree(cmd);
218
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
219
                               "-F", "raw", "-b", "raw", "qcow2", NULL);
220 221
    if (virCommandRun(cmd, NULL) < 0)
        goto skip;
222 223 224 225 226 227 228 229
    if (!(canonqcow2 = canonicalize_file_name(absqcow2))) {
        virReportOOMError();
        goto cleanup;
    }

    /* Create a second qcow2 wrapping the first, to be sure that we
     * can correctly avoid insecure probing.  */
    virCommandFree(cmd);
230
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qcow2", NULL);
231 232
    virCommandAddArgFormat(cmd, "-obacking_file=%s,backing_fmt=qcow2%s",
                           absqcow2, compat ? ",compat=1.1" : "");
233 234
    virCommandAddArg(cmd, "wrap");
    if (virCommandRun(cmd, NULL) < 0)
235
        goto skip;
E
Eric Blake 已提交
236 237 238 239
    if (!(canonwrap = canonicalize_file_name(abswrap))) {
        virReportOOMError();
        goto cleanup;
    }
240 241 242

    /* Create a qed file. */
    virCommandFree(cmd);
243
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qed", NULL);
244 245 246 247
    virCommandAddArgFormat(cmd, "-obacking_file=%s,backing_fmt=raw",
                           absraw);
    virCommandAddArg(cmd, "qed");
    if (virCommandRun(cmd, NULL) < 0)
248
        goto skip;
E
Eric Blake 已提交
249 250 251 252
    if (!(canonqed = canonicalize_file_name(absqed))) {
        virReportOOMError();
        goto cleanup;
    }
253

254
#ifdef HAVE_SYMLINK
255 256 257 258 259 260
    /* Create some symlinks in a sub-directory. */
    if (symlink("../qcow2", datadir "/sub/link1") < 0 ||
        symlink("../wrap", datadir "/sub/link2") < 0) {
        fprintf(stderr, "unable to create symlink");
        goto cleanup;
    }
261
#endif
262 263

    ret = 0;
264
 cleanup:
265
    VIR_FREE(buf);
266 267 268 269
    virCommandFree(cmd);
    if (ret)
        testCleanupImages();
    return ret;
270

271
 skip:
272 273 274
    fputs("qemu-img is too old; skipping this test\n", stderr);
    ret = EXIT_AM_SKIP;
    goto cleanup;
275 276
}

277 278 279 280 281
/* Many fields of virStorageFileMetadata have the same content whether
 * we access the file relatively or absolutely; but file names differ
 * depending on how the chain was opened.  For ease of testing, we
 * test both relative and absolute starts, and use a flag to say which
 * of the two variations to compare against.  */
282 283 284 285 286 287 288
typedef struct _testFileData testFileData;
struct _testFileData
{
    const char *expBackingStore;
    const char *expBackingStoreRaw;
    unsigned long long expCapacity;
    bool expEncrypted;
289 290
    const char *pathRel;
    const char *pathAbs;
291
    const char *path;
E
Eric Blake 已提交
292 293 294 295
    const char *relDirRel;
    const char *relDirAbs;
    int type;
    int format;
296 297 298 299 300 301 302
};

enum {
    EXP_PASS = 0,
    EXP_FAIL = 1,
    EXP_WARN = 2,
    ALLOW_PROBE = 4,
303
    ABS_START = 8,
304 305 306 307 308
};

struct testChainData
{
    const char *start;
309
    virStorageFileFormat format;
310
    const testFileData *files[4];
311 312 313 314
    int nfiles;
    unsigned int flags;
};

315 316

static const char testStorageChainFormat[] =
317
    "chain member: %zu\n"
318 319 320 321 322 323 324 325 326 327
    "store: %s\n"
    "backingStoreRaw: %s\n"
    "capacity: %lld\n"
    "encryption: %d\n"
    "relPath:%s\n"
    "path:%s\n"
    "relDir:%s\n"
    "type:%d\n"
    "format:%d\n";

328 329 330 331 332
static int
testStorageChain(const void *args)
{
    const struct testChainData *data = args;
    int ret = -1;
333 334
    virStorageSourcePtr meta;
    virStorageSourcePtr elt;
335
    size_t i = 0;
E
Eric Blake 已提交
336
    char *broken = NULL;
337
    bool isAbs = !!(data->flags & ABS_START);
338

339 340
    meta = testStorageFileGetMetadata(data->start, data->format, -1, -1,
                                      (data->flags & ALLOW_PROBE) != 0);
341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356
    if (!meta) {
        if (data->flags & EXP_FAIL) {
            virResetLastError();
            ret = 0;
        }
        goto cleanup;
    } else if (data->flags & EXP_FAIL) {
        fprintf(stderr, "call should have failed\n");
        goto cleanup;
    }
    if (data->flags & EXP_WARN) {
        if (!virGetLastError()) {
            fprintf(stderr, "call should have warned\n");
            goto cleanup;
        }
        virResetLastError();
E
Eric Blake 已提交
357 358 359 360 361 362 363 364 365 366 367 368 369
        if (virStorageFileChainGetBroken(meta, &broken) || !broken) {
            fprintf(stderr, "call should identify broken part of chain\n");
            goto cleanup;
        }
    } else {
        if (virGetLastError()) {
            fprintf(stderr, "call should not have warned\n");
            goto cleanup;
        }
        if (virStorageFileChainGetBroken(meta, &broken) || broken) {
            fprintf(stderr, "chain should not be identified as broken\n");
            goto cleanup;
        }
370 371 372 373 374 375
    }

    elt = meta;
    while (elt) {
        char *expect = NULL;
        char *actual = NULL;
376
        const char *expPath;
E
Eric Blake 已提交
377
        const char *expRelDir;
378 379 380 381 382 383

        if (i == data->nfiles) {
            fprintf(stderr, "probed chain was too long\n");
            goto cleanup;
        }

384 385
        expPath = isAbs ? data->files[i]->pathAbs
            : data->files[i]->pathRel;
E
Eric Blake 已提交
386 387
        expRelDir = isAbs ? data->files[i]->relDirAbs
            : data->files[i]->relDirRel;
388
        if (virAsprintf(&expect,
389
                        testStorageChainFormat, i,
390 391 392
                        NULLSTR(data->files[i]->expBackingStore),
                        NULLSTR(data->files[i]->expBackingStoreRaw),
                        data->files[i]->expCapacity,
393
                        data->files[i]->expEncrypted,
E
Eric Blake 已提交
394
                        NULLSTR(expPath),
395
                        NULLSTR(data->files[i]->path),
E
Eric Blake 已提交
396 397 398
                        NULLSTR(expRelDir),
                        data->files[i]->type,
                        data->files[i]->format) < 0 ||
399
            virAsprintf(&actual,
400
                        testStorageChainFormat, i,
401
                        NULLSTR(elt->backingStore ? elt->backingStore->path : NULL),
402
                        NULLSTR(elt->backingStoreRaw),
403 404
                        elt->capacity,
                        !!elt->encryption,
405
                        NULLSTR(elt->relPath),
406
                        NULLSTR(elt->path),
E
Eric Blake 已提交
407
                        NULLSTR(elt->relDir),
408 409
                        elt->type,
                        elt->format) < 0) {
410 411 412 413 414 415 416 417 418 419 420 421
            VIR_FREE(expect);
            VIR_FREE(actual);
            goto cleanup;
        }
        if (STRNEQ(expect, actual)) {
            virtTestDifference(stderr, expect, actual);
            VIR_FREE(expect);
            VIR_FREE(actual);
            goto cleanup;
        }
        VIR_FREE(expect);
        VIR_FREE(actual);
422
        elt = elt->backingStore;
423 424 425 426 427 428 429 430
        i++;
    }
    if (i != data->nfiles) {
        fprintf(stderr, "probed chain was too short\n");
        goto cleanup;
    }

    ret = 0;
431
 cleanup:
E
Eric Blake 已提交
432
    VIR_FREE(broken);
433
    virStorageSourceFree(meta);
434 435 436
    return ret;
}

E
Eric Blake 已提交
437 438
struct testLookupData
{
439
    virStorageSourcePtr chain;
440
    const char *target;
E
Eric Blake 已提交
441
    virStorageSourcePtr from;
E
Eric Blake 已提交
442
    const char *name;
443
    unsigned int expIndex;
E
Eric Blake 已提交
444
    const char *expResult;
445
    virStorageSourcePtr expMeta;
E
Eric Blake 已提交
446 447 448 449 450 451 452 453
    const char *expParent;
};

static int
testStorageLookup(const void *args)
{
    const struct testLookupData *data = args;
    int ret = 0;
454
    virStorageSourcePtr result;
E
Eric Blake 已提交
455
    const char *actualParent;
456 457 458 459 460 461 462 463 464 465 466
    unsigned int idx;

    if (virStorageFileParseChainIndex(data->target, data->name, &idx) < 0 &&
        data->expIndex) {
        fprintf(stderr, "call should not have failed\n");
        ret = -1;
    }
    if (idx != data->expIndex) {
        fprintf(stderr, "index: expected %u, got %u\n", data->expIndex, idx);
        ret = -1;
    }
E
Eric Blake 已提交
467

468
     /* Test twice to ensure optional parameter doesn't cause NULL deref. */
E
Eric Blake 已提交
469
    result = virStorageFileChainLookup(data->chain, data->from,
470 471
                                       idx ? NULL : data->name,
                                       idx, NULL);
E
Eric Blake 已提交
472 473 474 475 476 477 478 479 480 481 482 483 484 485

    if (!data->expResult) {
        if (!virGetLastError()) {
            fprintf(stderr, "call should have failed\n");
            ret = -1;
        }
        virResetLastError();
    } else {
        if (virGetLastError()) {
            fprintf(stderr, "call should not have warned\n");
            ret = -1;
        }
    }

486 487 488 489 490 491 492
    if (!result) {
        if (data->expResult) {
            fprintf(stderr, "result 1: expected %s, got NULL\n",
                    data->expResult);
            ret = -1;
        }
    } else if (STRNEQ_NULLABLE(data->expResult, result->path)) {
E
Eric Blake 已提交
493
        fprintf(stderr, "result 1: expected %s, got %s\n",
494
                NULLSTR(data->expResult), NULLSTR(result->path));
E
Eric Blake 已提交
495 496 497
        ret = -1;
    }

E
Eric Blake 已提交
498
    result = virStorageFileChainLookup(data->chain, data->from,
499
                                       data->name, idx, &actualParent);
E
Eric Blake 已提交
500 501
    if (!data->expResult)
        virResetLastError();
502 503 504 505 506 507 508 509

    if (!result) {
        if (data->expResult) {
            fprintf(stderr, "result 2: expected %s, got NULL\n",
                    data->expResult);
            ret = -1;
        }
    } else if (STRNEQ_NULLABLE(data->expResult, result->path)) {
E
Eric Blake 已提交
510
        fprintf(stderr, "result 2: expected %s, got %s\n",
511
                NULLSTR(data->expResult), NULLSTR(result->path));
E
Eric Blake 已提交
512 513
        ret = -1;
    }
514
    if (data->expMeta != result) {
E
Eric Blake 已提交
515
        fprintf(stderr, "meta: expected %p, got %p\n",
516
                data->expMeta, result);
E
Eric Blake 已提交
517 518 519 520 521 522 523 524 525 526 527
        ret = -1;
    }
    if (STRNEQ_NULLABLE(data->expParent, actualParent)) {
        fprintf(stderr, "parent: expected %s, got %s\n",
                NULLSTR(data->expParent), NULLSTR(actualParent));
        ret = -1;
    }

    return ret;
}

528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544

struct testPathCanonicalizeData
{
    const char *path;
    const char *expect;
};

static const char *testPathCanonicalizeSymlinks[][2] =
{
    {"/path/blah", "/other/path/huzah"},
    {"/path/to/relative/symlink", "../../actual/file"},
    {"/cycle", "/cycle"},
    {"/cycle2/link", "./link"},
};

static int
testPathCanonicalizeReadlink(const char *path,
545
                             char **linkpath,
546 547 548 549
                             void *data ATTRIBUTE_UNUSED)
{
    size_t i;

550
    *linkpath = NULL;
551 552 553

    for (i = 0; i < ARRAY_CARDINALITY(testPathCanonicalizeSymlinks); i++) {
        if (STREQ(path, testPathCanonicalizeSymlinks[i][0])) {
554
            if (VIR_STRDUP(*linkpath, testPathCanonicalizeSymlinks[i][1]) < 0)
555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592
                return -1;

            return 0;
        }
    }

    return 1;
}


static int
testPathCanonicalize(const void *args)
{
    const struct testPathCanonicalizeData *data = args;
    char *canon = NULL;
    int ret = -1;

    canon = virStorageFileCanonicalizePath(data->path,
                                           testPathCanonicalizeReadlink,
                                           NULL);

    if (STRNEQ_NULLABLE(data->expect, canon)) {
        fprintf(stderr,
                "path canonicalization of '%s' failed: expected '%s' got '%s'\n",
                data->path, NULLSTR(data->expect), NULLSTR(canon));

        goto cleanup;
    }

    ret = 0;

 cleanup:
    VIR_FREE(canon);

    return ret;
}


593 594 595 596 597
static int
mymain(void)
{
    int ret;
    virCommandPtr cmd = NULL;
598
    struct testChainData data;
E
Eric Blake 已提交
599
    struct testLookupData data2;
600
    struct testPathCanonicalizeData data3;
601
    virStorageSourcePtr chain = NULL;
E
Eric Blake 已提交
602 603
    virStorageSourcePtr chain2; /* short for chain->backingStore */
    virStorageSourcePtr chain3; /* short for chain2->backingStore */
604 605 606 607 608 609

    /* Prep some files with qemu-img; if that is not found on PATH, or
     * if it lacks support for qcow2 and qed, skip this test.  */
    if ((ret = testPrepImages()) != 0)
        return ret;

610
#define TEST_ONE_CHAIN(id, start, format, flags, ...)                \
611
    do {                                                             \
612 613 614 615
        size_t i;                                                    \
        memset(&data, 0, sizeof(data));                              \
        data = (struct testChainData){                               \
            start, format, { __VA_ARGS__ }, 0, flags,                \
616
        };                                                           \
617 618 619
        for (i = 0; i < ARRAY_CARDINALITY(data.files); i++)          \
            if (data.files[i])                                       \
                data.nfiles++;                                       \
620
        if (virtTestRun("Storage backing chain " id,                 \
621 622 623 624
                        testStorageChain, &data) < 0)                \
            ret = -1;                                                \
    } while (0)

625 626 627
#define VIR_FLATTEN_2(...) __VA_ARGS__
#define VIR_FLATTEN_1(_1) VIR_FLATTEN_2 _1

628 629 630
#define TEST_CHAIN(id, relstart, absstart, format, chain1, flags1,   \
                   chain2, flags2, chain3, flags3, chain4, flags4)   \
    do {                                                             \
631 632 633 634
        TEST_ONE_CHAIN(#id "a", relstart, format, flags1,            \
                       VIR_FLATTEN_1(chain1));                       \
        TEST_ONE_CHAIN(#id "b", relstart, format, flags2,            \
                       VIR_FLATTEN_1(chain2));                       \
635
        TEST_ONE_CHAIN(#id "c", absstart, format, flags3 | ABS_START,\
636
                       VIR_FLATTEN_1(chain3));                       \
637
        TEST_ONE_CHAIN(#id "d", absstart, format, flags4 | ABS_START,\
638
                       VIR_FLATTEN_1(chain4));                       \
639 640 641 642 643
    } while (0)

    /* The actual tests, in several groups. */

    /* Missing file */
644
    TEST_ONE_CHAIN("0", "bogus", VIR_STORAGE_FILE_RAW, EXP_FAIL);
645 646

    /* Raw image, whether with right format or no specified format */
647
    testFileData raw = {
648 649
        .pathRel = "raw",
        .pathAbs = canonraw,
650
        .path = canonraw,
E
Eric Blake 已提交
651 652 653 654
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_RAW,
655
    };
656
    TEST_CHAIN(1, "raw", absraw, VIR_STORAGE_FILE_RAW,
657 658 659 660
               (&raw), EXP_PASS,
               (&raw), ALLOW_PROBE | EXP_PASS,
               (&raw), EXP_PASS,
               (&raw), ALLOW_PROBE | EXP_PASS);
661
    TEST_CHAIN(2, "raw", absraw, VIR_STORAGE_FILE_AUTO,
662 663 664 665
               (&raw), EXP_PASS,
               (&raw), ALLOW_PROBE | EXP_PASS,
               (&raw), EXP_PASS,
               (&raw), ALLOW_PROBE | EXP_PASS);
666 667

    /* Qcow2 file with relative raw backing, format provided */
668
    raw.pathAbs = "raw";
669
    testFileData qcow2 = {
670 671 672
        .expBackingStore = canonraw,
        .expBackingStoreRaw = "raw",
        .expCapacity = 1024,
673 674
        .pathRel = "qcow2",
        .pathAbs = canonqcow2,
675
        .path = canonqcow2,
E
Eric Blake 已提交
676 677 678 679
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
680 681 682 683
    };
    testFileData qcow2_as_raw = {
        .pathRel = "qcow2",
        .pathAbs = canonqcow2,
684
        .path = canonqcow2,
E
Eric Blake 已提交
685 686 687 688
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_RAW,
689
    };
690
    TEST_CHAIN(3, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2,
691 692 693 694
               (&qcow2, &raw), EXP_PASS,
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS,
               (&qcow2, &raw), EXP_PASS,
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
695
    TEST_CHAIN(4, "qcow2", absqcow2, VIR_STORAGE_FILE_AUTO,
696
               (&qcow2_as_raw), EXP_PASS,
697
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS,
698
               (&qcow2_as_raw), EXP_PASS,
699
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
700 701 702 703 704 705 706

    /* Rewrite qcow2 file to use absolute backing name */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", absraw, "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
707
    qcow2.expBackingStoreRaw = absraw;
708 709
    raw.pathRel = absraw;
    raw.pathAbs = absraw;
E
Eric Blake 已提交
710
    raw.relDirRel = datadir;
711 712 713

    /* Qcow2 file with raw as absolute backing, backing format provided */
    TEST_CHAIN(5, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2,
714 715 716 717
               (&qcow2, &raw), EXP_PASS,
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS,
               (&qcow2, &raw), EXP_PASS,
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
718
    TEST_CHAIN(6, "qcow2", absqcow2, VIR_STORAGE_FILE_AUTO,
719
               (&qcow2_as_raw), EXP_PASS,
720
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS,
721
               (&qcow2_as_raw), EXP_PASS,
722
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
723 724

    /* Wrapped file access */
725 726 727 728
    testFileData wrap = {
        .expBackingStore = canonqcow2,
        .expBackingStoreRaw = absqcow2,
        .expCapacity = 1024,
729 730
        .pathRel = "wrap",
        .pathAbs = abswrap,
731
        .path = canonwrap,
E
Eric Blake 已提交
732 733 734 735
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
736
    };
737
    qcow2.pathRel = absqcow2;
E
Eric Blake 已提交
738
    qcow2.relDirRel = datadir;
739
    TEST_CHAIN(7, "wrap", abswrap, VIR_STORAGE_FILE_QCOW2,
740 741 742 743
               (&wrap, &qcow2, &raw), EXP_PASS,
               (&wrap, &qcow2, &raw), ALLOW_PROBE | EXP_PASS,
               (&wrap, &qcow2, &raw), EXP_PASS,
               (&wrap, &qcow2, &raw), ALLOW_PROBE | EXP_PASS);
744 745 746 747 748 749 750 751 752 753 754 755 756

    /* Rewrite qcow2 and wrap file to omit backing file type */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-b", absraw, "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-b", absqcow2, "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
757
    qcow2_as_raw.pathRel = absqcow2;
E
Eric Blake 已提交
758
    qcow2_as_raw.relDirRel = datadir;
759 760

    /* Qcow2 file with raw as absolute backing, backing format omitted */
761 762 763 764
    testFileData wrap_as_raw = {
        .expBackingStore = canonqcow2,
        .expBackingStoreRaw = absqcow2,
        .expCapacity = 1024,
765 766
        .pathRel = "wrap",
        .pathAbs = abswrap,
767
        .path = canonwrap,
E
Eric Blake 已提交
768 769 770 771
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
772
    };
773
    TEST_CHAIN(8, "wrap", abswrap, VIR_STORAGE_FILE_QCOW2,
774
               (&wrap_as_raw, &qcow2_as_raw), EXP_PASS,
775
               (&wrap, &qcow2, &raw), ALLOW_PROBE | EXP_PASS,
776
               (&wrap_as_raw, &qcow2_as_raw), EXP_PASS,
777
               (&wrap, &qcow2, &raw), ALLOW_PROBE | EXP_PASS);
778 779 780 781 782 783 784 785

    /* Rewrite qcow2 to a missing backing file, with backing type */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", datadir "/bogus",
                               "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
786 787
    qcow2.expBackingStore = NULL;
    qcow2.expBackingStoreRaw = datadir "/bogus";
788
    qcow2.pathRel = "qcow2";
E
Eric Blake 已提交
789
    qcow2.relDirRel = ".";
790 791 792

    /* Qcow2 file with missing backing file but specified type */
    TEST_CHAIN(9, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2,
793 794 795 796
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN,
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN);
797 798 799 800 801 802 803 804 805 806

    /* Rewrite qcow2 to a missing backing file, without backing type */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-b", datadir "/bogus", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Qcow2 file with missing backing file and no specified type */
    TEST_CHAIN(10, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2,
807 808 809 810
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN,
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN);
811 812 813 814

    /* Rewrite qcow2 to use an nbd: protocol as backend */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
815
                               "-F", "raw", "-b", "nbd:example.org:6000:exportname=blah",
816 817 818
                               "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
819 820
    qcow2.expBackingStore = "blah";
    qcow2.expBackingStoreRaw = "nbd:example.org:6000:exportname=blah";
821 822

    /* Qcow2 file with backing protocol instead of file */
823
    testFileData nbd = {
824 825 826
        .pathRel = "nbd:example.org:6000:exportname=blah",
        .pathAbs = "nbd:example.org:6000:exportname=blah",
        .path = "blah",
827 828
        .type = VIR_STORAGE_TYPE_NETWORK,
        .format = VIR_STORAGE_FILE_RAW,
829 830
        .relDirRel = ".",
        .relDirAbs = ".",
831
    };
832
    TEST_CHAIN(11, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2,
833 834 835 836
               (&qcow2, &nbd), EXP_PASS,
               (&qcow2, &nbd), ALLOW_PROBE | EXP_PASS,
               (&qcow2, &nbd), EXP_PASS,
               (&qcow2, &nbd), ALLOW_PROBE | EXP_PASS);
837 838

    /* qed file */
839 840 841 842
    testFileData qed = {
        .expBackingStore = canonraw,
        .expBackingStoreRaw = absraw,
        .expCapacity = 1024,
843 844
        .pathRel = "qed",
        .pathAbs = absqed,
845
        .path = canonqed,
E
Eric Blake 已提交
846 847 848 849
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QED,
850 851 852 853
    };
    testFileData qed_as_raw = {
        .pathRel = "qed",
        .pathAbs = absqed,
854
        .path = canonqed,
E
Eric Blake 已提交
855 856 857 858
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_RAW,
859
    };
860
    TEST_CHAIN(12, "qed", absqed, VIR_STORAGE_FILE_AUTO,
861
               (&qed_as_raw), EXP_PASS,
862
               (&qed, &raw), ALLOW_PROBE | EXP_PASS,
863
               (&qed_as_raw), EXP_PASS,
864
               (&qed, &raw), ALLOW_PROBE | EXP_PASS);
865

E
Eric Blake 已提交
866
    /* directory */
867
    testFileData dir = {
868 869
        .pathRel = "dir",
        .pathAbs = absdir,
870 871 872
        .path = canondir,
        .relDirRel = ".",
        .relDirAbs = datadir,
E
Eric Blake 已提交
873 874
        .type = VIR_STORAGE_TYPE_DIR,
        .format = VIR_STORAGE_FILE_DIR,
875
    };
E
Eric Blake 已提交
876 877 878 879 880 881 882 883 884 885 886
    TEST_CHAIN(13, "dir", absdir, VIR_STORAGE_FILE_AUTO,
               (&dir), EXP_PASS,
               (&dir), ALLOW_PROBE | EXP_PASS,
               (&dir), EXP_PASS,
               (&dir), ALLOW_PROBE | EXP_PASS);
    TEST_CHAIN(14, "dir", absdir, VIR_STORAGE_FILE_DIR,
               (&dir), EXP_PASS,
               (&dir), ALLOW_PROBE | EXP_PASS,
               (&dir), EXP_PASS,
               (&dir), ALLOW_PROBE | EXP_PASS);

887
#ifdef HAVE_SYMLINK
888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903
    /* Rewrite qcow2 and wrap file to use backing names relative to a
     * symlink from a different directory */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", "../raw", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "../sub/link1", "wrap",
                               NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Behavior of symlinks to qcow2 with relative backing files */
904
    testFileData link1 = {
905 906 907
        .expBackingStore = canonraw,
        .expBackingStoreRaw = "../raw",
        .expCapacity = 1024,
908 909
        .pathRel = "../sub/link1",
        .pathAbs = "../sub/link1",
910
        .path = canonqcow2,
E
Eric Blake 已提交
911 912 913 914
        .relDirRel = "sub/../sub",
        .relDirAbs = datadir "/sub/../sub",
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
915
    };
916
    testFileData link2 = {
917 918 919
        .expBackingStore = canonqcow2,
        .expBackingStoreRaw = "../sub/link1",
        .expCapacity = 1024,
920 921
        .pathRel = "sub/link2",
        .pathAbs = abslink2,
922
        .path = canonwrap,
E
Eric Blake 已提交
923 924 925 926
        .relDirRel = "sub",
        .relDirAbs = datadir "/sub",
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
927
    };
928 929
    raw.pathRel = "../raw";
    raw.pathAbs = "../raw";
E
Eric Blake 已提交
930 931
    raw.relDirRel = "sub/../sub/..";
    raw.relDirAbs = datadir "/sub/../sub/..";
E
Eric Blake 已提交
932
    TEST_CHAIN(15, "sub/link2", abslink2, VIR_STORAGE_FILE_QCOW2,
933 934 935 936
               (&link2, &link1, &raw), EXP_PASS,
               (&link2, &link1, &raw), ALLOW_PROBE | EXP_PASS,
               (&link2, &link1, &raw), EXP_PASS,
               (&link2, &link1, &raw), ALLOW_PROBE | EXP_PASS);
937
#endif
E
Eric Blake 已提交
938 939 940 941 942 943 944

    /* Rewrite qcow2 to be a self-referential loop */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "qcow2", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
945 946
    qcow2.expBackingStore = NULL;
    qcow2.expBackingStoreRaw = "qcow2";
E
Eric Blake 已提交
947 948 949

    /* Behavior of an infinite loop chain */
    TEST_CHAIN(16, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2,
950 951 952 953
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN,
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN);
E
Eric Blake 已提交
954 955 956 957 958 959 960 961 962 963 964 965 966

    /* Rewrite wrap and qcow2 to be mutually-referential loop */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "wrap", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", absqcow2, "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
967
    qcow2.expBackingStoreRaw = "wrap";
968
    qcow2.pathRel = absqcow2;
E
Eric Blake 已提交
969
    qcow2.relDirRel =  datadir;
E
Eric Blake 已提交
970 971 972

    /* Behavior of an infinite loop chain */
    TEST_CHAIN(17, "wrap", abswrap, VIR_STORAGE_FILE_QCOW2,
973 974 975 976
               (&wrap, &qcow2), EXP_WARN,
               (&wrap, &qcow2), ALLOW_PROBE | EXP_WARN,
               (&wrap, &qcow2), EXP_WARN,
               (&wrap, &qcow2), ALLOW_PROBE | EXP_WARN);
E
Eric Blake 已提交
977

E
Eric Blake 已提交
978 979 980 981 982 983 984
    /* Rewrite wrap and qcow2 back to 3-deep chain, absolute backing */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", absraw, "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

985
    /* Test behavior of chain lookups, absolute backing from relative start */
986 987
    chain = testStorageFileGetMetadata("wrap", VIR_STORAGE_FILE_QCOW2,
                                       -1, -1, false);
E
Eric Blake 已提交
988 989 990 991
    if (!chain) {
        ret = -1;
        goto cleanup;
    }
E
Eric Blake 已提交
992 993
    chain2 = chain->backingStore;
    chain3 = chain2->backingStore;
E
Eric Blake 已提交
994

E
Eric Blake 已提交
995
#define TEST_LOOKUP_TARGET(id, target, from, name, index, result,       \
E
Eric Blake 已提交
996
                           meta, parent)                                \
E
Eric Blake 已提交
997 998 999 1000 1001 1002 1003
    do {                                                                \
        data2 = (struct testLookupData){                                \
            chain, target, from, name, index,                           \
            result, meta, parent, };                                    \
        if (virtTestRun("Chain lookup " #id,                            \
                        testStorageLookup, &data2) < 0)                 \
            ret = -1;                                                   \
E
Eric Blake 已提交
1004
    } while (0)
E
Eric Blake 已提交
1005 1006 1007 1008
#define TEST_LOOKUP(id, from, name, result, meta, parent)               \
    TEST_LOOKUP_TARGET(id, NULL, from, name, 0, result, meta, parent)

    TEST_LOOKUP(0, NULL, "bogus", NULL, NULL, NULL);
E
Eric Blake 已提交
1009
    TEST_LOOKUP(1, chain, "bogus", NULL, NULL, NULL);
E
Eric Blake 已提交
1010
    TEST_LOOKUP(2, NULL, "wrap", chain->path, chain, NULL);
E
Eric Blake 已提交
1011
    TEST_LOOKUP(3, chain, "wrap", NULL, NULL, NULL);
E
Eric Blake 已提交
1012
    TEST_LOOKUP(4, chain2, "wrap", NULL, NULL, NULL);
E
Eric Blake 已提交
1013
    TEST_LOOKUP(5, NULL, abswrap, chain->path, chain, NULL);
E
Eric Blake 已提交
1014
    TEST_LOOKUP(6, chain, abswrap, NULL, NULL, NULL);
E
Eric Blake 已提交
1015
    TEST_LOOKUP(7, chain2, abswrap, NULL, NULL, NULL);
E
Eric Blake 已提交
1016
    TEST_LOOKUP(8, NULL, "qcow2", chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1017
    TEST_LOOKUP(9, chain, "qcow2", chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1018
    TEST_LOOKUP(10, chain2, "qcow2", NULL, NULL, NULL);
E
Eric Blake 已提交
1019
    TEST_LOOKUP(11, chain3, "qcow2", NULL, NULL, NULL);
E
Eric Blake 已提交
1020
    TEST_LOOKUP(12, NULL, absqcow2, chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1021
    TEST_LOOKUP(13, chain, absqcow2, chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1022
    TEST_LOOKUP(14, chain2, absqcow2, NULL, NULL, NULL);
E
Eric Blake 已提交
1023
    TEST_LOOKUP(15, chain3, absqcow2, NULL, NULL, NULL);
E
Eric Blake 已提交
1024
    TEST_LOOKUP(16, NULL, "raw", chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1025 1026
    TEST_LOOKUP(17, chain, "raw", chain3->path, chain3, chain2->path);
    TEST_LOOKUP(18, chain2, "raw", chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1027
    TEST_LOOKUP(19, chain3, "raw", NULL, NULL, NULL);
E
Eric Blake 已提交
1028
    TEST_LOOKUP(20, NULL, absraw, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1029 1030
    TEST_LOOKUP(21, chain, absraw, chain3->path, chain3, chain2->path);
    TEST_LOOKUP(22, chain2, absraw, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1031
    TEST_LOOKUP(23, chain3, absraw, NULL, NULL, NULL);
E
Eric Blake 已提交
1032
    TEST_LOOKUP(24, NULL, NULL, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1033 1034
    TEST_LOOKUP(25, chain, NULL, chain3->path, chain3, chain2->path);
    TEST_LOOKUP(26, chain2, NULL, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1035
    TEST_LOOKUP(27, chain3, NULL, NULL, NULL, NULL);
E
Eric Blake 已提交
1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049

    /* Rewrite wrap and qcow2 back to 3-deep chain, relative backing */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", "raw", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "qcow2", "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

1050
    /* Test behavior of chain lookups, relative backing from absolute start */
1051
    virStorageSourceFree(chain);
1052 1053
    chain = testStorageFileGetMetadata(abswrap, VIR_STORAGE_FILE_QCOW2,
                                       -1, -1, false);
E
Eric Blake 已提交
1054 1055 1056 1057
    if (!chain) {
        ret = -1;
        goto cleanup;
    }
E
Eric Blake 已提交
1058 1059
    chain2 = chain->backingStore;
    chain3 = chain2->backingStore;
E
Eric Blake 已提交
1060

E
Eric Blake 已提交
1061
    TEST_LOOKUP(28, NULL, "bogus", NULL, NULL, NULL);
E
Eric Blake 已提交
1062
    TEST_LOOKUP(29, chain, "bogus", NULL, NULL, NULL);
E
Eric Blake 已提交
1063
    TEST_LOOKUP(30, NULL, "wrap", chain->path, chain, NULL);
E
Eric Blake 已提交
1064
    TEST_LOOKUP(31, chain, "wrap", NULL, NULL, NULL);
E
Eric Blake 已提交
1065
    TEST_LOOKUP(32, chain2, "wrap", NULL, NULL, NULL);
E
Eric Blake 已提交
1066
    TEST_LOOKUP(33, NULL, abswrap, chain->path, chain, NULL);
E
Eric Blake 已提交
1067
    TEST_LOOKUP(34, chain, abswrap, NULL, NULL, NULL);
E
Eric Blake 已提交
1068
    TEST_LOOKUP(35, chain2, abswrap, NULL, NULL, NULL);
E
Eric Blake 已提交
1069
    TEST_LOOKUP(36, NULL, "qcow2", chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1070
    TEST_LOOKUP(37, chain, "qcow2", chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1071
    TEST_LOOKUP(38, chain2, "qcow2", NULL, NULL, NULL);
E
Eric Blake 已提交
1072
    TEST_LOOKUP(39, chain3, "qcow2", NULL, NULL, NULL);
E
Eric Blake 已提交
1073
    TEST_LOOKUP(40, NULL, absqcow2, chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1074
    TEST_LOOKUP(41, chain, absqcow2, chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1075
    TEST_LOOKUP(42, chain2, absqcow2, NULL, NULL, NULL);
E
Eric Blake 已提交
1076
    TEST_LOOKUP(43, chain3, absqcow2, NULL, NULL, NULL);
E
Eric Blake 已提交
1077
    TEST_LOOKUP(44, NULL, "raw", chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1078 1079
    TEST_LOOKUP(45, chain, "raw", chain3->path, chain3, chain2->path);
    TEST_LOOKUP(46, chain2, "raw", chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1080
    TEST_LOOKUP(47, chain3, "raw", NULL, NULL, NULL);
E
Eric Blake 已提交
1081
    TEST_LOOKUP(48, NULL, absraw, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1082 1083
    TEST_LOOKUP(49, chain, absraw, chain3->path, chain3, chain2->path);
    TEST_LOOKUP(50, chain2, absraw, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1084
    TEST_LOOKUP(51, chain3, absraw, NULL, NULL, NULL);
E
Eric Blake 已提交
1085
    TEST_LOOKUP(52, NULL, NULL, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1086 1087
    TEST_LOOKUP(53, chain, NULL, chain3->path, chain3, chain2->path);
    TEST_LOOKUP(54, chain2, NULL, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1088
    TEST_LOOKUP(55, chain3, NULL, NULL, NULL, NULL);
E
Eric Blake 已提交
1089 1090 1091 1092 1093 1094 1095 1096 1097

    /* Use link to wrap with cross-directory relative backing */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "../qcow2", "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Test behavior of chain lookups, relative backing */
1098
    virStorageSourceFree(chain);
1099 1100
    chain = testStorageFileGetMetadata("sub/link2", VIR_STORAGE_FILE_QCOW2,
                                       -1, -1, false);
E
Eric Blake 已提交
1101 1102 1103 1104
    if (!chain) {
        ret = -1;
        goto cleanup;
    }
E
Eric Blake 已提交
1105 1106
    chain2 = chain->backingStore;
    chain3 = chain2->backingStore;
E
Eric Blake 已提交
1107

E
Eric Blake 已提交
1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122
    TEST_LOOKUP(56, NULL, "bogus", NULL, NULL, NULL);
    TEST_LOOKUP(57, NULL, "sub/link2", chain->path, chain, NULL);
    TEST_LOOKUP(58, NULL, "wrap", chain->path, chain, NULL);
    TEST_LOOKUP(59, NULL, abswrap, chain->path, chain, NULL);
    TEST_LOOKUP(60, NULL, "../qcow2", chain2->path, chain2, chain->path);
    TEST_LOOKUP(61, NULL, "qcow2", NULL, NULL, NULL);
    TEST_LOOKUP(62, NULL, absqcow2, chain2->path, chain2, chain->path);
    TEST_LOOKUP(63, NULL, "raw", chain3->path, chain3, chain2->path);
    TEST_LOOKUP(64, NULL, absraw, chain3->path, chain3, chain2->path);
    TEST_LOOKUP(65, NULL, NULL, chain3->path, chain3, chain2->path);

    TEST_LOOKUP_TARGET(66, "vda", NULL, "bogus[1]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(67, "vda", NULL, "vda[-1]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(68, "vda", NULL, "vda[1][1]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(69, "vda", NULL, "wrap", 0, chain->path, chain, NULL);
E
Eric Blake 已提交
1123
    TEST_LOOKUP_TARGET(70, "vda", chain, "wrap", 0, NULL, NULL, NULL);
E
Eric Blake 已提交
1124
    TEST_LOOKUP_TARGET(71, "vda", chain2, "wrap", 0, NULL, NULL, NULL);
E
Eric Blake 已提交
1125 1126
    TEST_LOOKUP_TARGET(72, "vda", NULL, "vda[0]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(73, "vda", NULL, "vda[1]", 1, chain2->path, chain2,
1127
                       chain->path);
E
Eric Blake 已提交
1128 1129
    TEST_LOOKUP_TARGET(74, "vda", chain, "vda[1]", 1, chain2->path, chain2,
                       chain->path);
E
Eric Blake 已提交
1130
    TEST_LOOKUP_TARGET(75, "vda", chain2, "vda[1]", 1, NULL, NULL, NULL);
E
Eric Blake 已提交
1131
    TEST_LOOKUP_TARGET(76, "vda", chain3, "vda[1]", 1, NULL, NULL, NULL);
E
Eric Blake 已提交
1132
    TEST_LOOKUP_TARGET(77, "vda", NULL, "vda[2]", 2, chain3->path, chain3,
E
Eric Blake 已提交
1133
                       chain2->path);
E
Eric Blake 已提交
1134 1135 1136 1137
    TEST_LOOKUP_TARGET(78, "vda", chain, "vda[2]", 2, chain3->path, chain3,
                       chain2->path);
    TEST_LOOKUP_TARGET(79, "vda", chain2, "vda[2]", 2, chain3->path, chain3,
                       chain2->path);
E
Eric Blake 已提交
1138
    TEST_LOOKUP_TARGET(80, "vda", chain3, "vda[2]", 2, NULL, NULL, NULL);
E
Eric Blake 已提交
1139
    TEST_LOOKUP_TARGET(81, "vda", NULL, "vda[3]", 3, NULL, NULL, NULL);
1140

1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183
#define TEST_PATH_CANONICALIZE(id, PATH, EXPECT)                            \
    do {                                                                    \
        data3.path = PATH;                                                  \
        data3.expect = EXPECT;                                              \
        if (virtTestRun("Path canonicalize " #id,                           \
                        testPathCanonicalize, &data3) < 0)                  \
            ret = -1;                                                       \
    } while (0)

    TEST_PATH_CANONICALIZE(1, "/", "/");
    TEST_PATH_CANONICALIZE(2, "/path", "/path");
    TEST_PATH_CANONICALIZE(3, "/path/to/blah", "/path/to/blah");
    TEST_PATH_CANONICALIZE(4, "/path/", "/path");
    TEST_PATH_CANONICALIZE(5, "///////", "/");
    TEST_PATH_CANONICALIZE(6, "//", "//");
    TEST_PATH_CANONICALIZE(7, "", "");
    TEST_PATH_CANONICALIZE(8, ".", ".");
    TEST_PATH_CANONICALIZE(9, "../", "..");
    TEST_PATH_CANONICALIZE(10, "../../", "../..");
    TEST_PATH_CANONICALIZE(11, "../../blah", "../../blah");
    TEST_PATH_CANONICALIZE(12, "/./././blah", "/blah");
    TEST_PATH_CANONICALIZE(13, ".././../././../blah", "../../../blah");
    TEST_PATH_CANONICALIZE(14, "/././", "/");
    TEST_PATH_CANONICALIZE(15, "./././", ".");
    TEST_PATH_CANONICALIZE(16, "blah/../foo", "foo");
    TEST_PATH_CANONICALIZE(17, "foo/bar/../blah", "foo/blah");
    TEST_PATH_CANONICALIZE(18, "foo/bar/.././blah", "foo/blah");
    TEST_PATH_CANONICALIZE(19, "/path/to/foo/bar/../../../../../../../../baz", "/baz");
    TEST_PATH_CANONICALIZE(20, "path/to/foo/bar/../../../../../../../../baz", "../../../../baz");
    TEST_PATH_CANONICALIZE(21, "path/to/foo/bar", "path/to/foo/bar");
    TEST_PATH_CANONICALIZE(22, "//foo//bar", "//foo/bar");
    TEST_PATH_CANONICALIZE(23, "/bar//foo", "/bar/foo");
    TEST_PATH_CANONICALIZE(24, "//../blah", "//blah");

    /* test paths with symlinks */
    TEST_PATH_CANONICALIZE(25, "/path/blah", "/other/path/huzah");
    TEST_PATH_CANONICALIZE(26, "/path/to/relative/symlink", "/path/actual/file");
    TEST_PATH_CANONICALIZE(27, "/path/to/relative/symlink/blah", "/path/actual/file/blah");
    TEST_PATH_CANONICALIZE(28, "/path/blah/yippee", "/other/path/huzah/yippee");
    TEST_PATH_CANONICALIZE(29, "/cycle", NULL);
    TEST_PATH_CANONICALIZE(30, "/cycle2/link", NULL);
    TEST_PATH_CANONICALIZE(31, "///", "/");

E
Eric Blake 已提交
1184
 cleanup:
1185
    /* Final cleanup */
1186
    virStorageSourceFree(chain);
1187 1188 1189 1190 1191 1192 1193
    testCleanupImages();
    virCommandFree(cmd);

    return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
}

VIRT_TEST_MAIN(mymain)