virstoragetest.c 35.1 KB
Newer Older
1
/*
2
 * Copyright (C) 2013-2014 Red Hat, Inc.
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library.  If not, see
 * <http://www.gnu.org/licenses/>.
 *
 * Author: Eric Blake <eblake@redhat.com>
 */

#include <config.h>

#include <stdlib.h>

#include "testutils.h"
#include "vircommand.h"
#include "virerror.h"
28
#include "virfile.h"
29 30
#include "virlog.h"
#include "virstoragefile.h"
31
#include "virstring.h"
32
#include "dirname.h"
33 34 35

#define VIR_FROM_THIS VIR_FROM_NONE

36 37
VIR_LOG_INIT("tests.storagetest");

38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59
#define datadir abs_builddir "/virstoragedata"

/* This test creates the following files, all in datadir:

 * raw: 1024-byte raw file
 * qcow2: qcow2 file with 'raw' as backing
 * wrap: qcow2 file with 'qcow2' as backing
 * qed: qed file with 'raw' as backing
 * sub/link1: symlink to qcow2
 * sub/link2: symlink to wrap
 *
 * Relative names to these files are known at compile time, but absolute
 * and canonical names depend on where the test is run; for convenience,
 * we pre-populate the computation of these names for use during the test.
*/

static char *qemuimg;
static char *absraw;
static char *canonraw;
static char *absqcow2;
static char *canonqcow2;
static char *abswrap;
E
Eric Blake 已提交
60
static char *canonwrap;
61
static char *absqed;
E
Eric Blake 已提交
62
static char *canonqed;
E
Eric Blake 已提交
63
static char *absdir;
E
Eric Blake 已提交
64
static char *canondir;
65 66 67 68 69 70 71 72 73 74 75
static char *abslink2;

static void
testCleanupImages(void)
{
    VIR_FREE(qemuimg);
    VIR_FREE(absraw);
    VIR_FREE(canonraw);
    VIR_FREE(absqcow2);
    VIR_FREE(canonqcow2);
    VIR_FREE(abswrap);
E
Eric Blake 已提交
76
    VIR_FREE(canonwrap);
77
    VIR_FREE(absqed);
E
Eric Blake 已提交
78
    VIR_FREE(canonqed);
E
Eric Blake 已提交
79
    VIR_FREE(absdir);
E
Eric Blake 已提交
80
    VIR_FREE(canondir);
81 82 83 84 85 86 87 88
    VIR_FREE(abslink2);

    if (chdir(abs_builddir) < 0) {
        fprintf(stderr, "unable to return to correct directory, refusing to "
                "clean up %s\n", datadir);
        return;
    }

89
    virFileDeleteTree(datadir);
90 91
}

92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129

static virStorageSourcePtr
testStorageFileGetMetadata(const char *path,
                           int format,
                           uid_t uid, gid_t gid,
                           bool allow_probe)
{
    virStorageSourcePtr ret = NULL;

    if (VIR_ALLOC(ret) < 0)
        return NULL;

    ret->type = VIR_STORAGE_TYPE_FILE;
    ret->format = format;

    if (VIR_STRDUP(ret->relPath, path) < 0)
        goto error;

    if (!(ret->relDir = mdir_name(path))) {
        virReportOOMError();
        goto error;
    }

    if (!(ret->path = canonicalize_file_name(path))) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "failed to resolve '%s'", path);
        goto error;
    }

    if (virStorageFileGetMetadata(ret, uid, gid, allow_probe) < 0)
        goto error;

    return ret;

 error:
    virStorageSourceFree(ret);
    return NULL;
}

130 131 132 133 134
static int
testPrepImages(void)
{
    int ret = EXIT_FAILURE;
    virCommandPtr cmd = NULL;
135 136
    char *buf = NULL;
    bool compat = false;
137 138 139 140

    qemuimg = virFindFileInPath("kvm-img");
    if (!qemuimg)
        qemuimg = virFindFileInPath("qemu-img");
141 142
    if (!qemuimg)
        goto skip;
143

144 145 146
    /* Clean up from any earlier failed tests */
    virFileDeleteTree(datadir);

147 148 149 150 151 152 153 154 155 156 157 158
    /* See if qemu-img supports '-o compat=xxx'.  If so, we force the
     * use of both v2 and v3 files; if not, it is v2 only but the test
     * still works. */
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qcow2",
                               "-o?", "/dev/null", NULL);
    virCommandSetOutputBuffer(cmd, &buf);
    if (virCommandRun(cmd, NULL) < 0)
        goto skip;
    if (strstr(buf, "compat "))
        compat = true;
    VIR_FREE(buf);

159 160 161 162
    if (virAsprintf(&absraw, "%s/raw", datadir) < 0 ||
        virAsprintf(&absqcow2, "%s/qcow2", datadir) < 0 ||
        virAsprintf(&abswrap, "%s/wrap", datadir) < 0 ||
        virAsprintf(&absqed, "%s/qed", datadir) < 0 ||
E
Eric Blake 已提交
163
        virAsprintf(&absdir, "%s/dir", datadir) < 0 ||
164
        virAsprintf(&abslink2, "%s/sub/link2", datadir) < 0)
165 166 167 168 169 170
        goto cleanup;

    if (virFileMakePath(datadir "/sub") < 0) {
        fprintf(stderr, "unable to create directory %s\n", datadir "/sub");
        goto cleanup;
    }
E
Eric Blake 已提交
171 172 173 174
    if (virFileMakePath(datadir "/dir") < 0) {
        fprintf(stderr, "unable to create directory %s\n", datadir "/dir");
        goto cleanup;
    }
E
Eric Blake 已提交
175 176 177 178
    if (!(canondir = canonicalize_file_name(absdir))) {
        virReportOOMError();
        goto cleanup;
    }
179 180 181 182 183 184

    if (chdir(datadir) < 0) {
        fprintf(stderr, "unable to test relative backing chains\n");
        goto cleanup;
    }

185 186
    if (virAsprintf(&buf, "%1024d", 0) < 0 ||
        virFileWriteStr("raw", buf, 0600) < 0) {
187
        fprintf(stderr, "unable to create raw file\n");
188
        goto cleanup;
189
    }
190 191 192 193 194 195 196 197
    if (!(canonraw = canonicalize_file_name(absraw))) {
        virReportOOMError();
        goto cleanup;
    }

    /* Create a qcow2 wrapping relative raw; later on, we modify its
     * metadata to test other configurations */
    virCommandFree(cmd);
198 199 200 201
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qcow2", NULL);
    virCommandAddArgFormat(cmd, "-obacking_file=raw,backing_fmt=raw%s",
                           compat ? ",compat=0.10" : "");
    virCommandAddArg(cmd, "qcow2");
202
    if (virCommandRun(cmd, NULL) < 0)
203
        goto skip;
204 205
    /* Make sure our later uses of 'qemu-img rebase' will work */
    virCommandFree(cmd);
206
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
207
                               "-F", "raw", "-b", "raw", "qcow2", NULL);
208 209
    if (virCommandRun(cmd, NULL) < 0)
        goto skip;
210 211 212 213 214 215 216 217
    if (!(canonqcow2 = canonicalize_file_name(absqcow2))) {
        virReportOOMError();
        goto cleanup;
    }

    /* Create a second qcow2 wrapping the first, to be sure that we
     * can correctly avoid insecure probing.  */
    virCommandFree(cmd);
218
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qcow2", NULL);
219 220
    virCommandAddArgFormat(cmd, "-obacking_file=%s,backing_fmt=qcow2%s",
                           absqcow2, compat ? ",compat=1.1" : "");
221 222
    virCommandAddArg(cmd, "wrap");
    if (virCommandRun(cmd, NULL) < 0)
223
        goto skip;
E
Eric Blake 已提交
224 225 226 227
    if (!(canonwrap = canonicalize_file_name(abswrap))) {
        virReportOOMError();
        goto cleanup;
    }
228 229 230

    /* Create a qed file. */
    virCommandFree(cmd);
231
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qed", NULL);
232 233 234 235
    virCommandAddArgFormat(cmd, "-obacking_file=%s,backing_fmt=raw",
                           absraw);
    virCommandAddArg(cmd, "qed");
    if (virCommandRun(cmd, NULL) < 0)
236
        goto skip;
E
Eric Blake 已提交
237 238 239 240
    if (!(canonqed = canonicalize_file_name(absqed))) {
        virReportOOMError();
        goto cleanup;
    }
241

242
#ifdef HAVE_SYMLINK
243 244 245 246 247 248
    /* Create some symlinks in a sub-directory. */
    if (symlink("../qcow2", datadir "/sub/link1") < 0 ||
        symlink("../wrap", datadir "/sub/link2") < 0) {
        fprintf(stderr, "unable to create symlink");
        goto cleanup;
    }
249
#endif
250 251

    ret = 0;
252
 cleanup:
253
    VIR_FREE(buf);
254 255 256 257
    virCommandFree(cmd);
    if (ret)
        testCleanupImages();
    return ret;
258

259
 skip:
260 261 262
    fputs("qemu-img is too old; skipping this test\n", stderr);
    ret = EXIT_AM_SKIP;
    goto cleanup;
263 264
}

265 266 267 268 269
/* Many fields of virStorageFileMetadata have the same content whether
 * we access the file relatively or absolutely; but file names differ
 * depending on how the chain was opened.  For ease of testing, we
 * test both relative and absolute starts, and use a flag to say which
 * of the two variations to compare against.  */
270 271 272 273 274 275 276
typedef struct _testFileData testFileData;
struct _testFileData
{
    const char *expBackingStore;
    const char *expBackingStoreRaw;
    unsigned long long expCapacity;
    bool expEncrypted;
277 278
    const char *pathRel;
    const char *pathAbs;
279
    const char *path;
E
Eric Blake 已提交
280 281 282 283
    const char *relDirRel;
    const char *relDirAbs;
    int type;
    int format;
284 285 286 287 288 289 290
};

enum {
    EXP_PASS = 0,
    EXP_FAIL = 1,
    EXP_WARN = 2,
    ALLOW_PROBE = 4,
291
    ABS_START = 8,
292 293 294 295 296
};

struct testChainData
{
    const char *start;
297
    virStorageFileFormat format;
298
    const testFileData *files[4];
299 300 301 302 303 304 305 306 307
    int nfiles;
    unsigned int flags;
};

static int
testStorageChain(const void *args)
{
    const struct testChainData *data = args;
    int ret = -1;
308 309
    virStorageSourcePtr meta;
    virStorageSourcePtr elt;
310
    size_t i = 0;
E
Eric Blake 已提交
311
    char *broken = NULL;
312
    bool isAbs = !!(data->flags & ABS_START);
313

314 315
    meta = testStorageFileGetMetadata(data->start, data->format, -1, -1,
                                      (data->flags & ALLOW_PROBE) != 0);
316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331
    if (!meta) {
        if (data->flags & EXP_FAIL) {
            virResetLastError();
            ret = 0;
        }
        goto cleanup;
    } else if (data->flags & EXP_FAIL) {
        fprintf(stderr, "call should have failed\n");
        goto cleanup;
    }
    if (data->flags & EXP_WARN) {
        if (!virGetLastError()) {
            fprintf(stderr, "call should have warned\n");
            goto cleanup;
        }
        virResetLastError();
E
Eric Blake 已提交
332 333 334 335 336 337 338 339 340 341 342 343 344
        if (virStorageFileChainGetBroken(meta, &broken) || !broken) {
            fprintf(stderr, "call should identify broken part of chain\n");
            goto cleanup;
        }
    } else {
        if (virGetLastError()) {
            fprintf(stderr, "call should not have warned\n");
            goto cleanup;
        }
        if (virStorageFileChainGetBroken(meta, &broken) || broken) {
            fprintf(stderr, "chain should not be identified as broken\n");
            goto cleanup;
        }
345 346 347 348 349 350
    }

    elt = meta;
    while (elt) {
        char *expect = NULL;
        char *actual = NULL;
351
        const char *expPath;
E
Eric Blake 已提交
352
        const char *expRelDir;
353 354 355 356 357 358

        if (i == data->nfiles) {
            fprintf(stderr, "probed chain was too long\n");
            goto cleanup;
        }

359 360
        expPath = isAbs ? data->files[i]->pathAbs
            : data->files[i]->pathRel;
E
Eric Blake 已提交
361 362
        expRelDir = isAbs ? data->files[i]->relDirAbs
            : data->files[i]->relDirRel;
363
        if (virAsprintf(&expect,
364
                        "store:%s\nraw:%s\nother:%lld %d\n"
365
                        "relPath:%s\npath:%s\nrelDir:%s\ntype:%d %d\n",
366 367 368
                        NULLSTR(data->files[i]->expBackingStore),
                        NULLSTR(data->files[i]->expBackingStoreRaw),
                        data->files[i]->expCapacity,
369
                        data->files[i]->expEncrypted,
E
Eric Blake 已提交
370
                        NULLSTR(expPath),
371
                        NULLSTR(data->files[i]->path),
E
Eric Blake 已提交
372 373 374
                        NULLSTR(expRelDir),
                        data->files[i]->type,
                        data->files[i]->format) < 0 ||
375
            virAsprintf(&actual,
376
                        "store:%s\nraw:%s\nother:%lld %d\n"
377
                        "relPath:%s\npath:%s\nrelDir:%s\ntype:%d %d\n",
378
                        NULLSTR(elt->backingStore ? elt->backingStore->path : NULL),
379
                        NULLSTR(elt->backingStoreRaw),
380
                        elt->capacity, !!elt->encryption,
381
                        NULLSTR(elt->relPath),
382
                        NULLSTR(elt->path),
E
Eric Blake 已提交
383 384
                        NULLSTR(elt->relDir),
                        elt->type, elt->format) < 0) {
385 386 387 388 389
            VIR_FREE(expect);
            VIR_FREE(actual);
            goto cleanup;
        }
        if (STRNEQ(expect, actual)) {
390
            fprintf(stderr, "chain member %zu", i);
391 392 393 394 395 396 397
            virtTestDifference(stderr, expect, actual);
            VIR_FREE(expect);
            VIR_FREE(actual);
            goto cleanup;
        }
        VIR_FREE(expect);
        VIR_FREE(actual);
398
        elt = elt->backingStore;
399 400 401 402 403 404 405 406
        i++;
    }
    if (i != data->nfiles) {
        fprintf(stderr, "probed chain was too short\n");
        goto cleanup;
    }

    ret = 0;
407
 cleanup:
E
Eric Blake 已提交
408
    VIR_FREE(broken);
409
    virStorageSourceFree(meta);
410 411 412
    return ret;
}

E
Eric Blake 已提交
413 414
struct testLookupData
{
415
    virStorageSourcePtr chain;
416
    const char *target;
E
Eric Blake 已提交
417
    const char *name;
418
    unsigned int expIndex;
E
Eric Blake 已提交
419
    const char *expResult;
420
    virStorageSourcePtr expMeta;
E
Eric Blake 已提交
421 422 423 424 425 426 427 428
    const char *expParent;
};

static int
testStorageLookup(const void *args)
{
    const struct testLookupData *data = args;
    int ret = 0;
429
    virStorageSourcePtr result;
E
Eric Blake 已提交
430
    const char *actualParent;
431 432 433 434 435 436 437 438 439 440 441
    unsigned int idx;

    if (virStorageFileParseChainIndex(data->target, data->name, &idx) < 0 &&
        data->expIndex) {
        fprintf(stderr, "call should not have failed\n");
        ret = -1;
    }
    if (idx != data->expIndex) {
        fprintf(stderr, "index: expected %u, got %u\n", data->expIndex, idx);
        ret = -1;
    }
E
Eric Blake 已提交
442

443
     /* Test twice to ensure optional parameter doesn't cause NULL deref. */
444 445 446
    result = virStorageFileChainLookup(data->chain, NULL,
                                       idx ? NULL : data->name,
                                       idx, NULL);
E
Eric Blake 已提交
447 448 449 450 451 452 453 454 455 456 457 458 459 460

    if (!data->expResult) {
        if (!virGetLastError()) {
            fprintf(stderr, "call should have failed\n");
            ret = -1;
        }
        virResetLastError();
    } else {
        if (virGetLastError()) {
            fprintf(stderr, "call should not have warned\n");
            ret = -1;
        }
    }

461 462 463 464 465 466 467
    if (!result) {
        if (data->expResult) {
            fprintf(stderr, "result 1: expected %s, got NULL\n",
                    data->expResult);
            ret = -1;
        }
    } else if (STRNEQ_NULLABLE(data->expResult, result->path)) {
E
Eric Blake 已提交
468
        fprintf(stderr, "result 1: expected %s, got %s\n",
469
                NULLSTR(data->expResult), NULLSTR(result->path));
E
Eric Blake 已提交
470 471 472
        ret = -1;
    }

473 474
    result = virStorageFileChainLookup(data->chain, data->chain,
                                       data->name, idx, &actualParent);
E
Eric Blake 已提交
475 476
    if (!data->expResult)
        virResetLastError();
477 478 479 480 481 482 483 484

    if (!result) {
        if (data->expResult) {
            fprintf(stderr, "result 2: expected %s, got NULL\n",
                    data->expResult);
            ret = -1;
        }
    } else if (STRNEQ_NULLABLE(data->expResult, result->path)) {
E
Eric Blake 已提交
485
        fprintf(stderr, "result 2: expected %s, got %s\n",
486
                NULLSTR(data->expResult), NULLSTR(result->path));
E
Eric Blake 已提交
487 488
        ret = -1;
    }
489
    if (data->expMeta != result) {
E
Eric Blake 已提交
490
        fprintf(stderr, "meta: expected %p, got %p\n",
491
                data->expMeta, result);
E
Eric Blake 已提交
492 493 494 495 496 497 498 499 500 501 502
        ret = -1;
    }
    if (STRNEQ_NULLABLE(data->expParent, actualParent)) {
        fprintf(stderr, "parent: expected %s, got %s\n",
                NULLSTR(data->expParent), NULLSTR(actualParent));
        ret = -1;
    }

    return ret;
}

503 504 505 506 507
static int
mymain(void)
{
    int ret;
    virCommandPtr cmd = NULL;
508
    struct testChainData data;
509
    virStorageSourcePtr chain = NULL;
510 511 512 513 514 515

    /* Prep some files with qemu-img; if that is not found on PATH, or
     * if it lacks support for qcow2 and qed, skip this test.  */
    if ((ret = testPrepImages()) != 0)
        return ret;

516
#define TEST_ONE_CHAIN(id, start, format, flags, ...)                \
517
    do {                                                             \
518 519 520 521
        size_t i;                                                    \
        memset(&data, 0, sizeof(data));                              \
        data = (struct testChainData){                               \
            start, format, { __VA_ARGS__ }, 0, flags,                \
522
        };                                                           \
523 524 525
        for (i = 0; i < ARRAY_CARDINALITY(data.files); i++)          \
            if (data.files[i])                                       \
                data.nfiles++;                                       \
526
        if (virtTestRun("Storage backing chain " id,                 \
527 528 529 530
                        testStorageChain, &data) < 0)                \
            ret = -1;                                                \
    } while (0)

531 532 533
#define VIR_FLATTEN_2(...) __VA_ARGS__
#define VIR_FLATTEN_1(_1) VIR_FLATTEN_2 _1

534 535 536
#define TEST_CHAIN(id, relstart, absstart, format, chain1, flags1,   \
                   chain2, flags2, chain3, flags3, chain4, flags4)   \
    do {                                                             \
537 538 539 540
        TEST_ONE_CHAIN(#id "a", relstart, format, flags1,            \
                       VIR_FLATTEN_1(chain1));                       \
        TEST_ONE_CHAIN(#id "b", relstart, format, flags2,            \
                       VIR_FLATTEN_1(chain2));                       \
541
        TEST_ONE_CHAIN(#id "c", absstart, format, flags3 | ABS_START,\
542
                       VIR_FLATTEN_1(chain3));                       \
543
        TEST_ONE_CHAIN(#id "d", absstart, format, flags4 | ABS_START,\
544
                       VIR_FLATTEN_1(chain4));                       \
545 546 547 548 549
    } while (0)

    /* The actual tests, in several groups. */

    /* Missing file */
550
    TEST_ONE_CHAIN("0", "bogus", VIR_STORAGE_FILE_RAW, EXP_FAIL);
551 552

    /* Raw image, whether with right format or no specified format */
553
    testFileData raw = {
554 555
        .pathRel = "raw",
        .pathAbs = canonraw,
556
        .path = canonraw,
E
Eric Blake 已提交
557 558 559 560
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_RAW,
561
    };
562
    TEST_CHAIN(1, "raw", absraw, VIR_STORAGE_FILE_RAW,
563 564 565 566
               (&raw), EXP_PASS,
               (&raw), ALLOW_PROBE | EXP_PASS,
               (&raw), EXP_PASS,
               (&raw), ALLOW_PROBE | EXP_PASS);
567
    TEST_CHAIN(2, "raw", absraw, VIR_STORAGE_FILE_AUTO,
568 569 570 571
               (&raw), EXP_PASS,
               (&raw), ALLOW_PROBE | EXP_PASS,
               (&raw), EXP_PASS,
               (&raw), ALLOW_PROBE | EXP_PASS);
572 573

    /* Qcow2 file with relative raw backing, format provided */
574
    raw.pathAbs = "raw";
575
    testFileData qcow2 = {
576 577 578
        .expBackingStore = canonraw,
        .expBackingStoreRaw = "raw",
        .expCapacity = 1024,
579 580
        .pathRel = "qcow2",
        .pathAbs = canonqcow2,
581
        .path = canonqcow2,
E
Eric Blake 已提交
582 583 584 585
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
586 587 588 589
    };
    testFileData qcow2_as_raw = {
        .pathRel = "qcow2",
        .pathAbs = canonqcow2,
590
        .path = canonqcow2,
E
Eric Blake 已提交
591 592 593 594
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_RAW,
595
    };
596
    TEST_CHAIN(3, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2,
597 598 599 600
               (&qcow2, &raw), EXP_PASS,
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS,
               (&qcow2, &raw), EXP_PASS,
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
601
    TEST_CHAIN(4, "qcow2", absqcow2, VIR_STORAGE_FILE_AUTO,
602
               (&qcow2_as_raw), EXP_PASS,
603
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS,
604
               (&qcow2_as_raw), EXP_PASS,
605
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
606 607 608 609 610 611 612

    /* Rewrite qcow2 file to use absolute backing name */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", absraw, "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
613
    qcow2.expBackingStoreRaw = absraw;
614 615
    raw.pathRel = absraw;
    raw.pathAbs = absraw;
E
Eric Blake 已提交
616
    raw.relDirRel = datadir;
617 618 619

    /* Qcow2 file with raw as absolute backing, backing format provided */
    TEST_CHAIN(5, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2,
620 621 622 623
               (&qcow2, &raw), EXP_PASS,
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS,
               (&qcow2, &raw), EXP_PASS,
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
624
    TEST_CHAIN(6, "qcow2", absqcow2, VIR_STORAGE_FILE_AUTO,
625
               (&qcow2_as_raw), EXP_PASS,
626
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS,
627
               (&qcow2_as_raw), EXP_PASS,
628
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
629 630

    /* Wrapped file access */
631 632 633 634
    testFileData wrap = {
        .expBackingStore = canonqcow2,
        .expBackingStoreRaw = absqcow2,
        .expCapacity = 1024,
635 636
        .pathRel = "wrap",
        .pathAbs = abswrap,
637
        .path = canonwrap,
E
Eric Blake 已提交
638 639 640 641
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
642
    };
643
    qcow2.pathRel = absqcow2;
E
Eric Blake 已提交
644
    qcow2.relDirRel = datadir;
645
    TEST_CHAIN(7, "wrap", abswrap, VIR_STORAGE_FILE_QCOW2,
646 647 648 649
               (&wrap, &qcow2, &raw), EXP_PASS,
               (&wrap, &qcow2, &raw), ALLOW_PROBE | EXP_PASS,
               (&wrap, &qcow2, &raw), EXP_PASS,
               (&wrap, &qcow2, &raw), ALLOW_PROBE | EXP_PASS);
650 651 652 653 654 655 656 657 658 659 660 661 662

    /* Rewrite qcow2 and wrap file to omit backing file type */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-b", absraw, "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-b", absqcow2, "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
663
    qcow2_as_raw.pathRel = absqcow2;
E
Eric Blake 已提交
664
    qcow2_as_raw.relDirRel = datadir;
665 666

    /* Qcow2 file with raw as absolute backing, backing format omitted */
667 668 669 670
    testFileData wrap_as_raw = {
        .expBackingStore = canonqcow2,
        .expBackingStoreRaw = absqcow2,
        .expCapacity = 1024,
671 672
        .pathRel = "wrap",
        .pathAbs = abswrap,
673
        .path = canonwrap,
E
Eric Blake 已提交
674 675 676 677
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
678
    };
679
    TEST_CHAIN(8, "wrap", abswrap, VIR_STORAGE_FILE_QCOW2,
680
               (&wrap_as_raw, &qcow2_as_raw), EXP_PASS,
681
               (&wrap, &qcow2, &raw), ALLOW_PROBE | EXP_PASS,
682
               (&wrap_as_raw, &qcow2_as_raw), EXP_PASS,
683
               (&wrap, &qcow2, &raw), ALLOW_PROBE | EXP_PASS);
684 685 686 687 688 689 690 691

    /* Rewrite qcow2 to a missing backing file, with backing type */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", datadir "/bogus",
                               "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
692 693
    qcow2.expBackingStore = NULL;
    qcow2.expBackingStoreRaw = datadir "/bogus";
694
    qcow2.pathRel = "qcow2";
E
Eric Blake 已提交
695
    qcow2.relDirRel = ".";
696 697 698

    /* Qcow2 file with missing backing file but specified type */
    TEST_CHAIN(9, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2,
699 700 701 702
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN,
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN);
703 704 705 706 707 708 709 710 711 712

    /* Rewrite qcow2 to a missing backing file, without backing type */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-b", datadir "/bogus", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Qcow2 file with missing backing file and no specified type */
    TEST_CHAIN(10, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2,
713 714 715 716
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN,
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN);
717 718 719 720 721 722 723 724

    /* Rewrite qcow2 to use an nbd: protocol as backend */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", "nbd:example.org:6000",
                               "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
725
    qcow2.expBackingStore = "nbd:example.org:6000";
726
    qcow2.expBackingStoreRaw = "nbd:example.org:6000";
727 728

    /* Qcow2 file with backing protocol instead of file */
729 730 731
    testFileData nbd = {
        .pathRel = "nbd:example.org:6000",
        .pathAbs = "nbd:example.org:6000",
732
        .path = "nbd:example.org:6000",
733 734 735
        .type = VIR_STORAGE_TYPE_NETWORK,
        .format = VIR_STORAGE_FILE_RAW,
    };
736
    TEST_CHAIN(11, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2,
737 738 739 740
               (&qcow2, &nbd), EXP_PASS,
               (&qcow2, &nbd), ALLOW_PROBE | EXP_PASS,
               (&qcow2, &nbd), EXP_PASS,
               (&qcow2, &nbd), ALLOW_PROBE | EXP_PASS);
741 742

    /* qed file */
743 744 745 746
    testFileData qed = {
        .expBackingStore = canonraw,
        .expBackingStoreRaw = absraw,
        .expCapacity = 1024,
747 748
        .pathRel = "qed",
        .pathAbs = absqed,
749
        .path = canonqed,
E
Eric Blake 已提交
750 751 752 753
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QED,
754 755 756 757
    };
    testFileData qed_as_raw = {
        .pathRel = "qed",
        .pathAbs = absqed,
758
        .path = canonqed,
E
Eric Blake 已提交
759 760 761 762
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_RAW,
763
    };
764
    TEST_CHAIN(12, "qed", absqed, VIR_STORAGE_FILE_AUTO,
765
               (&qed_as_raw), EXP_PASS,
766
               (&qed, &raw), ALLOW_PROBE | EXP_PASS,
767
               (&qed_as_raw), EXP_PASS,
768
               (&qed, &raw), ALLOW_PROBE | EXP_PASS);
769

E
Eric Blake 已提交
770
    /* directory */
771
    testFileData dir = {
772 773
        .pathRel = "dir",
        .pathAbs = absdir,
774 775 776
        .path = canondir,
        .relDirRel = ".",
        .relDirAbs = datadir,
E
Eric Blake 已提交
777 778
        .type = VIR_STORAGE_TYPE_DIR,
        .format = VIR_STORAGE_FILE_DIR,
779
    };
E
Eric Blake 已提交
780 781 782 783 784 785 786 787 788 789 790
    TEST_CHAIN(13, "dir", absdir, VIR_STORAGE_FILE_AUTO,
               (&dir), EXP_PASS,
               (&dir), ALLOW_PROBE | EXP_PASS,
               (&dir), EXP_PASS,
               (&dir), ALLOW_PROBE | EXP_PASS);
    TEST_CHAIN(14, "dir", absdir, VIR_STORAGE_FILE_DIR,
               (&dir), EXP_PASS,
               (&dir), ALLOW_PROBE | EXP_PASS,
               (&dir), EXP_PASS,
               (&dir), ALLOW_PROBE | EXP_PASS);

791
#ifdef HAVE_SYMLINK
792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807
    /* Rewrite qcow2 and wrap file to use backing names relative to a
     * symlink from a different directory */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", "../raw", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "../sub/link1", "wrap",
                               NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Behavior of symlinks to qcow2 with relative backing files */
808
    testFileData link1 = {
809 810 811
        .expBackingStore = canonraw,
        .expBackingStoreRaw = "../raw",
        .expCapacity = 1024,
812 813
        .pathRel = "../sub/link1",
        .pathAbs = "../sub/link1",
814
        .path = canonqcow2,
E
Eric Blake 已提交
815 816 817 818
        .relDirRel = "sub/../sub",
        .relDirAbs = datadir "/sub/../sub",
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
819
    };
820
    testFileData link2 = {
821 822 823
        .expBackingStore = canonqcow2,
        .expBackingStoreRaw = "../sub/link1",
        .expCapacity = 1024,
824 825
        .pathRel = "sub/link2",
        .pathAbs = abslink2,
826
        .path = canonwrap,
E
Eric Blake 已提交
827 828 829 830
        .relDirRel = "sub",
        .relDirAbs = datadir "/sub",
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
831
    };
832 833
    raw.pathRel = "../raw";
    raw.pathAbs = "../raw";
E
Eric Blake 已提交
834 835
    raw.relDirRel = "sub/../sub/..";
    raw.relDirAbs = datadir "/sub/../sub/..";
E
Eric Blake 已提交
836
    TEST_CHAIN(15, "sub/link2", abslink2, VIR_STORAGE_FILE_QCOW2,
837 838 839 840
               (&link2, &link1, &raw), EXP_PASS,
               (&link2, &link1, &raw), ALLOW_PROBE | EXP_PASS,
               (&link2, &link1, &raw), EXP_PASS,
               (&link2, &link1, &raw), ALLOW_PROBE | EXP_PASS);
841
#endif
E
Eric Blake 已提交
842 843 844 845 846 847 848

    /* Rewrite qcow2 to be a self-referential loop */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "qcow2", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
849 850
    qcow2.expBackingStore = NULL;
    qcow2.expBackingStoreRaw = "qcow2";
E
Eric Blake 已提交
851 852 853

    /* Behavior of an infinite loop chain */
    TEST_CHAIN(16, "qcow2", absqcow2, VIR_STORAGE_FILE_QCOW2,
854 855 856 857
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN,
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN);
E
Eric Blake 已提交
858 859 860 861 862 863 864 865 866 867 868 869 870

    /* Rewrite wrap and qcow2 to be mutually-referential loop */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "wrap", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", absqcow2, "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
871
    qcow2.expBackingStoreRaw = "wrap";
872
    qcow2.pathRel = absqcow2;
E
Eric Blake 已提交
873
    qcow2.relDirRel =  datadir;
E
Eric Blake 已提交
874 875 876

    /* Behavior of an infinite loop chain */
    TEST_CHAIN(17, "wrap", abswrap, VIR_STORAGE_FILE_QCOW2,
877 878 879 880
               (&wrap, &qcow2), EXP_WARN,
               (&wrap, &qcow2), ALLOW_PROBE | EXP_WARN,
               (&wrap, &qcow2), EXP_WARN,
               (&wrap, &qcow2), ALLOW_PROBE | EXP_WARN);
E
Eric Blake 已提交
881

E
Eric Blake 已提交
882 883 884 885 886 887 888
    /* Rewrite wrap and qcow2 back to 3-deep chain, absolute backing */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", absraw, "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

889
    /* Test behavior of chain lookups, absolute backing from relative start */
890 891
    chain = testStorageFileGetMetadata("wrap", VIR_STORAGE_FILE_QCOW2,
                                       -1, -1, false);
E
Eric Blake 已提交
892 893 894 895 896
    if (!chain) {
        ret = -1;
        goto cleanup;
    }

897 898 899 900 901 902 903
#define TEST_LOOKUP_TARGET(id, target, name, index, result, meta, parent)   \
    do {                                                                    \
        struct testLookupData data2 = { chain, target, name, index,         \
                                        result, meta, parent, };            \
        if (virtTestRun("Chain lookup " #id,                                \
                        testStorageLookup, &data2) < 0)                     \
            ret = -1;                                                       \
E
Eric Blake 已提交
904
    } while (0)
905 906
#define TEST_LOOKUP(id, name, result, meta, parent)                         \
    TEST_LOOKUP_TARGET(id, NULL, name, 0, result, meta, parent)
E
Eric Blake 已提交
907 908

    TEST_LOOKUP(0, "bogus", NULL, NULL, NULL);
909 910
    TEST_LOOKUP(1, "wrap", chain->path, chain, NULL);
    TEST_LOOKUP(2, abswrap, chain->path, chain, NULL);
911
    TEST_LOOKUP(3, "qcow2", chain->backingStore->path, chain->backingStore,
912
                chain->path);
913
    TEST_LOOKUP(4, absqcow2, chain->backingStore->path, chain->backingStore,
914
                chain->path);
915 916 917 918 919 920
    TEST_LOOKUP(5, "raw", chain->backingStore->backingStore->path,
                chain->backingStore->backingStore, chain->backingStore->path);
    TEST_LOOKUP(6, absraw, chain->backingStore->backingStore->path,
                chain->backingStore->backingStore, chain->backingStore->path);
    TEST_LOOKUP(7, NULL, chain->backingStore->backingStore->path,
                chain->backingStore->backingStore, chain->backingStore->path);
E
Eric Blake 已提交
921 922 923 924 925 926 927 928 929 930 931 932 933 934

    /* Rewrite wrap and qcow2 back to 3-deep chain, relative backing */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", "raw", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "qcow2", "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

935
    /* Test behavior of chain lookups, relative backing from absolute start */
936
    virStorageSourceFree(chain);
937 938
    chain = testStorageFileGetMetadata(abswrap, VIR_STORAGE_FILE_QCOW2,
                                       -1, -1, false);
E
Eric Blake 已提交
939 940 941 942 943 944
    if (!chain) {
        ret = -1;
        goto cleanup;
    }

    TEST_LOOKUP(8, "bogus", NULL, NULL, NULL);
945 946
    TEST_LOOKUP(9, "wrap", chain->path, chain, NULL);
    TEST_LOOKUP(10, abswrap, chain->path, chain, NULL);
947
    TEST_LOOKUP(11, "qcow2", chain->backingStore->path, chain->backingStore,
948
                chain->path);
949
    TEST_LOOKUP(12, absqcow2, chain->backingStore->path, chain->backingStore,
950
                chain->path);
951 952 953 954 955 956
    TEST_LOOKUP(13, "raw", chain->backingStore->backingStore->path,
                chain->backingStore->backingStore, chain->backingStore->path);
    TEST_LOOKUP(14, absraw, chain->backingStore->backingStore->path,
                chain->backingStore->backingStore, chain->backingStore->path);
    TEST_LOOKUP(15, NULL, chain->backingStore->backingStore->path,
                chain->backingStore->backingStore, chain->backingStore->path);
E
Eric Blake 已提交
957 958 959 960 961 962 963 964 965

    /* Use link to wrap with cross-directory relative backing */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "../qcow2", "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Test behavior of chain lookups, relative backing */
966
    virStorageSourceFree(chain);
967 968
    chain = testStorageFileGetMetadata("sub/link2", VIR_STORAGE_FILE_QCOW2,
                                       -1, -1, false);
E
Eric Blake 已提交
969 970 971 972 973 974
    if (!chain) {
        ret = -1;
        goto cleanup;
    }

    TEST_LOOKUP(16, "bogus", NULL, NULL, NULL);
975 976 977
    TEST_LOOKUP(17, "sub/link2", chain->path, chain, NULL);
    TEST_LOOKUP(18, "wrap", chain->path, chain, NULL);
    TEST_LOOKUP(19, abswrap, chain->path, chain, NULL);
978
    TEST_LOOKUP(20, "../qcow2", chain->backingStore->path, chain->backingStore,
979
                chain->path);
E
Eric Blake 已提交
980
    TEST_LOOKUP(21, "qcow2", NULL, NULL, NULL);
981
    TEST_LOOKUP(22, absqcow2, chain->backingStore->path, chain->backingStore,
982
                chain->path);
983 984 985 986 987 988
    TEST_LOOKUP(23, "raw", chain->backingStore->backingStore->path,
                chain->backingStore->backingStore, chain->backingStore->path);
    TEST_LOOKUP(24, absraw, chain->backingStore->backingStore->path,
                chain->backingStore->backingStore, chain->backingStore->path);
    TEST_LOOKUP(25, NULL, chain->backingStore->backingStore->path,
                chain->backingStore->backingStore, chain->backingStore->path);
E
Eric Blake 已提交
989

990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004
    TEST_LOOKUP_TARGET(26, "vda", "bogus[1]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(27, "vda", "vda[-1]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(28, "vda", "vda[1][1]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(29, "vda", "wrap", 0, chain->path, chain, NULL);
    TEST_LOOKUP_TARGET(30, "vda", "vda[0]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(31, "vda", "vda[1]", 1,
                       chain->backingStore->path,
                       chain->backingStore,
                       chain->path);
    TEST_LOOKUP_TARGET(32, "vda", "vda[2]", 2,
                       chain->backingStore->backingStore->path,
                       chain->backingStore->backingStore,
                       chain->backingStore->path);
    TEST_LOOKUP_TARGET(33, "vda", "vda[3]", 3, NULL, NULL, NULL);

E
Eric Blake 已提交
1005
 cleanup:
1006
    /* Final cleanup */
1007
    virStorageSourceFree(chain);
1008 1009 1010 1011 1012 1013 1014
    testCleanupImages();
    virCommandFree(cmd);

    return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
}

VIRT_TEST_MAIN(mymain)