virstoragetest.c 44.0 KB
Newer Older
1
/*
2
 * Copyright (C) 2013-2014 Red Hat, Inc.
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library.  If not, see
 * <http://www.gnu.org/licenses/>.
 *
 * Author: Eric Blake <eblake@redhat.com>
 */

#include <config.h>

#include <stdlib.h>

#include "testutils.h"
#include "vircommand.h"
#include "virerror.h"
28
#include "virfile.h"
29 30
#include "virlog.h"
#include "virstoragefile.h"
31
#include "virstring.h"
32
#include "dirname.h"
33

34 35
#include "storage/storage_driver.h"

36 37
#define VIR_FROM_THIS VIR_FROM_NONE

38 39
VIR_LOG_INIT("tests.storagetest");

40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61
#define datadir abs_builddir "/virstoragedata"

/* This test creates the following files, all in datadir:

 * raw: 1024-byte raw file
 * qcow2: qcow2 file with 'raw' as backing
 * wrap: qcow2 file with 'qcow2' as backing
 * qed: qed file with 'raw' as backing
 * sub/link1: symlink to qcow2
 * sub/link2: symlink to wrap
 *
 * Relative names to these files are known at compile time, but absolute
 * and canonical names depend on where the test is run; for convenience,
 * we pre-populate the computation of these names for use during the test.
*/

static char *qemuimg;
static char *absraw;
static char *canonraw;
static char *absqcow2;
static char *canonqcow2;
static char *abswrap;
E
Eric Blake 已提交
62
static char *canonwrap;
63
static char *absqed;
E
Eric Blake 已提交
64
static char *canonqed;
E
Eric Blake 已提交
65
static char *absdir;
E
Eric Blake 已提交
66
static char *canondir;
67 68 69 70 71 72 73 74 75 76 77
static char *abslink2;

static void
testCleanupImages(void)
{
    VIR_FREE(qemuimg);
    VIR_FREE(absraw);
    VIR_FREE(canonraw);
    VIR_FREE(absqcow2);
    VIR_FREE(canonqcow2);
    VIR_FREE(abswrap);
E
Eric Blake 已提交
78
    VIR_FREE(canonwrap);
79
    VIR_FREE(absqed);
E
Eric Blake 已提交
80
    VIR_FREE(canonqed);
E
Eric Blake 已提交
81
    VIR_FREE(absdir);
E
Eric Blake 已提交
82
    VIR_FREE(canondir);
83 84 85 86 87 88 89 90
    VIR_FREE(abslink2);

    if (chdir(abs_builddir) < 0) {
        fprintf(stderr, "unable to return to correct directory, refusing to "
                "clean up %s\n", datadir);
        return;
    }

91
    virFileDeleteTree(datadir);
92 93
}

94 95 96 97 98 99 100

static virStorageSourcePtr
testStorageFileGetMetadata(const char *path,
                           int format,
                           uid_t uid, gid_t gid,
                           bool allow_probe)
{
101
    struct stat st;
102 103 104 105 106 107 108 109
    virStorageSourcePtr ret = NULL;

    if (VIR_ALLOC(ret) < 0)
        return NULL;

    ret->type = VIR_STORAGE_TYPE_FILE;
    ret->format = format;

110 111 112 113 114 115 116 117 118
    if (stat(path, &st) == 0) {
        if (S_ISDIR(st.st_mode)) {
            ret->type = VIR_STORAGE_TYPE_DIR;
            ret->format = VIR_STORAGE_FILE_DIR;
        } else if (S_ISBLK(st.st_mode)) {
            ret->type = VIR_STORAGE_TYPE_BLOCK;
        }
    }

119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138
    if (!(ret->relDir = mdir_name(path))) {
        virReportOOMError();
        goto error;
    }

    if (!(ret->path = canonicalize_file_name(path))) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "failed to resolve '%s'", path);
        goto error;
    }

    if (virStorageFileGetMetadata(ret, uid, gid, allow_probe) < 0)
        goto error;

    return ret;

 error:
    virStorageSourceFree(ret);
    return NULL;
}

139 140 141 142 143
static int
testPrepImages(void)
{
    int ret = EXIT_FAILURE;
    virCommandPtr cmd = NULL;
144 145
    char *buf = NULL;
    bool compat = false;
146 147 148 149

    qemuimg = virFindFileInPath("kvm-img");
    if (!qemuimg)
        qemuimg = virFindFileInPath("qemu-img");
150 151
    if (!qemuimg)
        goto skip;
152

153 154 155
    /* Clean up from any earlier failed tests */
    virFileDeleteTree(datadir);

156 157 158 159 160 161 162 163 164 165 166 167
    /* See if qemu-img supports '-o compat=xxx'.  If so, we force the
     * use of both v2 and v3 files; if not, it is v2 only but the test
     * still works. */
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qcow2",
                               "-o?", "/dev/null", NULL);
    virCommandSetOutputBuffer(cmd, &buf);
    if (virCommandRun(cmd, NULL) < 0)
        goto skip;
    if (strstr(buf, "compat "))
        compat = true;
    VIR_FREE(buf);

168 169 170 171
    if (virAsprintf(&absraw, "%s/raw", datadir) < 0 ||
        virAsprintf(&absqcow2, "%s/qcow2", datadir) < 0 ||
        virAsprintf(&abswrap, "%s/wrap", datadir) < 0 ||
        virAsprintf(&absqed, "%s/qed", datadir) < 0 ||
E
Eric Blake 已提交
172
        virAsprintf(&absdir, "%s/dir", datadir) < 0 ||
173
        virAsprintf(&abslink2, "%s/sub/link2", datadir) < 0)
174 175 176 177 178 179
        goto cleanup;

    if (virFileMakePath(datadir "/sub") < 0) {
        fprintf(stderr, "unable to create directory %s\n", datadir "/sub");
        goto cleanup;
    }
E
Eric Blake 已提交
180 181 182 183
    if (virFileMakePath(datadir "/dir") < 0) {
        fprintf(stderr, "unable to create directory %s\n", datadir "/dir");
        goto cleanup;
    }
E
Eric Blake 已提交
184 185 186 187
    if (!(canondir = canonicalize_file_name(absdir))) {
        virReportOOMError();
        goto cleanup;
    }
188 189 190 191 192 193

    if (chdir(datadir) < 0) {
        fprintf(stderr, "unable to test relative backing chains\n");
        goto cleanup;
    }

194 195
    if (virAsprintf(&buf, "%1024d", 0) < 0 ||
        virFileWriteStr("raw", buf, 0600) < 0) {
196
        fprintf(stderr, "unable to create raw file\n");
197
        goto cleanup;
198
    }
199 200 201 202 203 204 205 206
    if (!(canonraw = canonicalize_file_name(absraw))) {
        virReportOOMError();
        goto cleanup;
    }

    /* Create a qcow2 wrapping relative raw; later on, we modify its
     * metadata to test other configurations */
    virCommandFree(cmd);
207 208 209 210
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qcow2", NULL);
    virCommandAddArgFormat(cmd, "-obacking_file=raw,backing_fmt=raw%s",
                           compat ? ",compat=0.10" : "");
    virCommandAddArg(cmd, "qcow2");
211
    if (virCommandRun(cmd, NULL) < 0)
212
        goto skip;
213 214
    /* Make sure our later uses of 'qemu-img rebase' will work */
    virCommandFree(cmd);
215
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
216
                               "-F", "raw", "-b", "raw", "qcow2", NULL);
217 218
    if (virCommandRun(cmd, NULL) < 0)
        goto skip;
219 220 221 222 223 224 225 226
    if (!(canonqcow2 = canonicalize_file_name(absqcow2))) {
        virReportOOMError();
        goto cleanup;
    }

    /* Create a second qcow2 wrapping the first, to be sure that we
     * can correctly avoid insecure probing.  */
    virCommandFree(cmd);
227
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qcow2", NULL);
228 229
    virCommandAddArgFormat(cmd, "-obacking_file=%s,backing_fmt=qcow2%s",
                           absqcow2, compat ? ",compat=1.1" : "");
230 231
    virCommandAddArg(cmd, "wrap");
    if (virCommandRun(cmd, NULL) < 0)
232
        goto skip;
E
Eric Blake 已提交
233 234 235 236
    if (!(canonwrap = canonicalize_file_name(abswrap))) {
        virReportOOMError();
        goto cleanup;
    }
237 238 239

    /* Create a qed file. */
    virCommandFree(cmd);
240
    cmd = virCommandNewArgList(qemuimg, "create", "-f", "qed", NULL);
241 242 243 244
    virCommandAddArgFormat(cmd, "-obacking_file=%s,backing_fmt=raw",
                           absraw);
    virCommandAddArg(cmd, "qed");
    if (virCommandRun(cmd, NULL) < 0)
245
        goto skip;
E
Eric Blake 已提交
246 247 248 249
    if (!(canonqed = canonicalize_file_name(absqed))) {
        virReportOOMError();
        goto cleanup;
    }
250

251
#ifdef HAVE_SYMLINK
252 253 254 255 256 257
    /* Create some symlinks in a sub-directory. */
    if (symlink("../qcow2", datadir "/sub/link1") < 0 ||
        symlink("../wrap", datadir "/sub/link2") < 0) {
        fprintf(stderr, "unable to create symlink");
        goto cleanup;
    }
258
#endif
259 260

    ret = 0;
261
 cleanup:
262
    VIR_FREE(buf);
263 264 265 266
    virCommandFree(cmd);
    if (ret)
        testCleanupImages();
    return ret;
267

268
 skip:
269 270 271
    fputs("qemu-img is too old; skipping this test\n", stderr);
    ret = EXIT_AM_SKIP;
    goto cleanup;
272 273
}

274 275 276 277 278
/* Many fields of virStorageFileMetadata have the same content whether
 * we access the file relatively or absolutely; but file names differ
 * depending on how the chain was opened.  For ease of testing, we
 * test both relative and absolute starts, and use a flag to say which
 * of the two variations to compare against.  */
279 280 281 282 283 284
typedef struct _testFileData testFileData;
struct _testFileData
{
    const char *expBackingStoreRaw;
    unsigned long long expCapacity;
    bool expEncrypted;
285
    const char *pathRel;
286
    const char *path;
E
Eric Blake 已提交
287 288 289 290
    const char *relDirRel;
    const char *relDirAbs;
    int type;
    int format;
291 292 293 294 295 296 297
};

enum {
    EXP_PASS = 0,
    EXP_FAIL = 1,
    EXP_WARN = 2,
    ALLOW_PROBE = 4,
298
    ABS_START = 8,
299 300 301 302 303
};

struct testChainData
{
    const char *start;
304
    virStorageFileFormat format;
305
    const testFileData *files[4];
306 307 308 309
    int nfiles;
    unsigned int flags;
};

310 311

static const char testStorageChainFormat[] =
312
    "chain member: %zu\n"
313
    "path:%s\n"
314 315 316 317 318 319 320 321
    "backingStoreRaw: %s\n"
    "capacity: %lld\n"
    "encryption: %d\n"
    "relPath:%s\n"
    "relDir:%s\n"
    "type:%d\n"
    "format:%d\n";

322 323 324 325 326
static int
testStorageChain(const void *args)
{
    const struct testChainData *data = args;
    int ret = -1;
327 328
    virStorageSourcePtr meta;
    virStorageSourcePtr elt;
329
    size_t i = 0;
E
Eric Blake 已提交
330
    char *broken = NULL;
331
    bool isAbs = !!(data->flags & ABS_START);
332

333 334
    meta = testStorageFileGetMetadata(data->start, data->format, -1, -1,
                                      (data->flags & ALLOW_PROBE) != 0);
335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350
    if (!meta) {
        if (data->flags & EXP_FAIL) {
            virResetLastError();
            ret = 0;
        }
        goto cleanup;
    } else if (data->flags & EXP_FAIL) {
        fprintf(stderr, "call should have failed\n");
        goto cleanup;
    }
    if (data->flags & EXP_WARN) {
        if (!virGetLastError()) {
            fprintf(stderr, "call should have warned\n");
            goto cleanup;
        }
        virResetLastError();
E
Eric Blake 已提交
351 352 353 354 355 356 357 358 359 360 361 362 363
        if (virStorageFileChainGetBroken(meta, &broken) || !broken) {
            fprintf(stderr, "call should identify broken part of chain\n");
            goto cleanup;
        }
    } else {
        if (virGetLastError()) {
            fprintf(stderr, "call should not have warned\n");
            goto cleanup;
        }
        if (virStorageFileChainGetBroken(meta, &broken) || broken) {
            fprintf(stderr, "chain should not be identified as broken\n");
            goto cleanup;
        }
364 365 366 367 368 369
    }

    elt = meta;
    while (elt) {
        char *expect = NULL;
        char *actual = NULL;
E
Eric Blake 已提交
370
        const char *expRelDir;
371 372 373 374 375 376

        if (i == data->nfiles) {
            fprintf(stderr, "probed chain was too long\n");
            goto cleanup;
        }

E
Eric Blake 已提交
377 378
        expRelDir = isAbs ? data->files[i]->relDirAbs
            : data->files[i]->relDirRel;
379
        if (virAsprintf(&expect,
380
                        testStorageChainFormat, i,
381
                        NULLSTR(data->files[i]->path),
382 383
                        NULLSTR(data->files[i]->expBackingStoreRaw),
                        data->files[i]->expCapacity,
384
                        data->files[i]->expEncrypted,
385
                        NULLSTR(data->files[i]->pathRel),
E
Eric Blake 已提交
386 387 388
                        NULLSTR(expRelDir),
                        data->files[i]->type,
                        data->files[i]->format) < 0 ||
389
            virAsprintf(&actual,
390
                        testStorageChainFormat, i,
391
                        NULLSTR(elt->path),
392
                        NULLSTR(elt->backingStoreRaw),
393 394
                        elt->capacity,
                        !!elt->encryption,
395
                        NULLSTR(elt->relPath),
E
Eric Blake 已提交
396
                        NULLSTR(elt->relDir),
397 398
                        elt->type,
                        elt->format) < 0) {
399 400 401 402 403 404 405 406 407 408 409 410
            VIR_FREE(expect);
            VIR_FREE(actual);
            goto cleanup;
        }
        if (STRNEQ(expect, actual)) {
            virtTestDifference(stderr, expect, actual);
            VIR_FREE(expect);
            VIR_FREE(actual);
            goto cleanup;
        }
        VIR_FREE(expect);
        VIR_FREE(actual);
411
        elt = elt->backingStore;
412 413 414 415 416 417 418 419
        i++;
    }
    if (i != data->nfiles) {
        fprintf(stderr, "probed chain was too short\n");
        goto cleanup;
    }

    ret = 0;
420
 cleanup:
E
Eric Blake 已提交
421
    VIR_FREE(broken);
422
    virStorageSourceFree(meta);
423 424 425
    return ret;
}

E
Eric Blake 已提交
426 427
struct testLookupData
{
428
    virStorageSourcePtr chain;
429
    const char *target;
E
Eric Blake 已提交
430
    virStorageSourcePtr from;
E
Eric Blake 已提交
431
    const char *name;
432
    unsigned int expIndex;
E
Eric Blake 已提交
433
    const char *expResult;
434
    virStorageSourcePtr expMeta;
E
Eric Blake 已提交
435 436 437 438 439 440 441 442
    const char *expParent;
};

static int
testStorageLookup(const void *args)
{
    const struct testLookupData *data = args;
    int ret = 0;
443
    virStorageSourcePtr result;
E
Eric Blake 已提交
444
    const char *actualParent;
445 446 447 448 449 450 451 452 453 454 455
    unsigned int idx;

    if (virStorageFileParseChainIndex(data->target, data->name, &idx) < 0 &&
        data->expIndex) {
        fprintf(stderr, "call should not have failed\n");
        ret = -1;
    }
    if (idx != data->expIndex) {
        fprintf(stderr, "index: expected %u, got %u\n", data->expIndex, idx);
        ret = -1;
    }
E
Eric Blake 已提交
456

457
     /* Test twice to ensure optional parameter doesn't cause NULL deref. */
E
Eric Blake 已提交
458
    result = virStorageFileChainLookup(data->chain, data->from,
459 460
                                       idx ? NULL : data->name,
                                       idx, NULL);
E
Eric Blake 已提交
461 462 463 464 465 466 467 468 469 470 471 472 473 474

    if (!data->expResult) {
        if (!virGetLastError()) {
            fprintf(stderr, "call should have failed\n");
            ret = -1;
        }
        virResetLastError();
    } else {
        if (virGetLastError()) {
            fprintf(stderr, "call should not have warned\n");
            ret = -1;
        }
    }

475 476 477 478 479 480 481
    if (!result) {
        if (data->expResult) {
            fprintf(stderr, "result 1: expected %s, got NULL\n",
                    data->expResult);
            ret = -1;
        }
    } else if (STRNEQ_NULLABLE(data->expResult, result->path)) {
E
Eric Blake 已提交
482
        fprintf(stderr, "result 1: expected %s, got %s\n",
483
                NULLSTR(data->expResult), NULLSTR(result->path));
E
Eric Blake 已提交
484 485 486
        ret = -1;
    }

E
Eric Blake 已提交
487
    result = virStorageFileChainLookup(data->chain, data->from,
488
                                       data->name, idx, &actualParent);
E
Eric Blake 已提交
489 490
    if (!data->expResult)
        virResetLastError();
491 492 493 494 495 496 497 498

    if (!result) {
        if (data->expResult) {
            fprintf(stderr, "result 2: expected %s, got NULL\n",
                    data->expResult);
            ret = -1;
        }
    } else if (STRNEQ_NULLABLE(data->expResult, result->path)) {
E
Eric Blake 已提交
499
        fprintf(stderr, "result 2: expected %s, got %s\n",
500
                NULLSTR(data->expResult), NULLSTR(result->path));
E
Eric Blake 已提交
501 502
        ret = -1;
    }
503
    if (data->expMeta != result) {
E
Eric Blake 已提交
504
        fprintf(stderr, "meta: expected %p, got %p\n",
505
                data->expMeta, result);
E
Eric Blake 已提交
506 507 508 509 510 511 512 513 514 515 516
        ret = -1;
    }
    if (STRNEQ_NULLABLE(data->expParent, actualParent)) {
        fprintf(stderr, "parent: expected %s, got %s\n",
                NULLSTR(data->expParent), NULLSTR(actualParent));
        ret = -1;
    }

    return ret;
}

517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533

struct testPathCanonicalizeData
{
    const char *path;
    const char *expect;
};

static const char *testPathCanonicalizeSymlinks[][2] =
{
    {"/path/blah", "/other/path/huzah"},
    {"/path/to/relative/symlink", "../../actual/file"},
    {"/cycle", "/cycle"},
    {"/cycle2/link", "./link"},
};

static int
testPathCanonicalizeReadlink(const char *path,
534
                             char **linkpath,
535 536 537 538
                             void *data ATTRIBUTE_UNUSED)
{
    size_t i;

539
    *linkpath = NULL;
540 541 542

    for (i = 0; i < ARRAY_CARDINALITY(testPathCanonicalizeSymlinks); i++) {
        if (STREQ(path, testPathCanonicalizeSymlinks[i][0])) {
543
            if (VIR_STRDUP(*linkpath, testPathCanonicalizeSymlinks[i][1]) < 0)
544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580
                return -1;

            return 0;
        }
    }

    return 1;
}


static int
testPathCanonicalize(const void *args)
{
    const struct testPathCanonicalizeData *data = args;
    char *canon = NULL;
    int ret = -1;

    canon = virStorageFileCanonicalizePath(data->path,
                                           testPathCanonicalizeReadlink,
                                           NULL);

    if (STRNEQ_NULLABLE(data->expect, canon)) {
        fprintf(stderr,
                "path canonicalization of '%s' failed: expected '%s' got '%s'\n",
                data->path, NULLSTR(data->expect), NULLSTR(canon));

        goto cleanup;
    }

    ret = 0;

 cleanup:
    VIR_FREE(canon);

    return ret;
}

581 582 583 584 585 586 587 588 589 590 591 592 593
static virStorageSource backingchain[12];

static void
testPathRelativePrepare(void)
{
    size_t i;

    for (i = 0; i < ARRAY_CARDINALITY(backingchain); i++) {
        if (i < ARRAY_CARDINALITY(backingchain) - 1)
            backingchain[i].backingStore = &backingchain[i + 1];
        else
            backingchain[i].backingStore = NULL;

594
        backingchain[i].relPath = NULL;
595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672
    }

    /* normal relative backing chain */
    backingchain[0].path = (char *) "/path/to/some/img";

    backingchain[1].path = (char *) "/path/to/some/asdf";
    backingchain[1].relPath = (char *) "asdf";

    backingchain[2].path = (char *) "/path/to/some/test";
    backingchain[2].relPath = (char *) "test";

    backingchain[3].path = (char *) "/path/to/some/blah";
    backingchain[3].relPath = (char *) "blah";

    /* ovirt's backing chain */
    backingchain[4].path = (char *) "/path/to/volume/image1";

    backingchain[5].path = (char *) "/path/to/volume/image2";
    backingchain[5].relPath = (char *) "../volume/image2";

    backingchain[6].path = (char *) "/path/to/volume/image3";
    backingchain[6].relPath = (char *) "../volume/image3";

    backingchain[7].path = (char *) "/path/to/volume/image4";
    backingchain[7].relPath = (char *) "../volume/image4";

    /* some arbitrarily crazy backing chains */
    backingchain[8].path = (char *) "/crazy/base/image";

    backingchain[9].path = (char *) "/crazy/base/directory/stuff/volumes/garbage/image2";
    backingchain[9].relPath = (char *) "directory/stuff/volumes/garbage/image2";

    backingchain[10].path = (char *) "/crazy/base/directory/image3";
    backingchain[10].relPath = (char *) "../../../image3";

    backingchain[11].path = (char *) "/crazy/base/blah/image4";
    backingchain[11].relPath = (char *) "../blah/image4";
}


struct testPathRelativeBacking
{
    virStorageSourcePtr top;
    virStorageSourcePtr base;

    const char *expect;
};

static int
testPathRelative(const void *args)
{
    const struct testPathRelativeBacking *data = args;
    char *actual = NULL;
    int ret = -1;

    if (virStorageFileGetRelativeBackingPath(data->top,
                                             data->base,
                                             &actual) < 0) {
        fprintf(stderr, "relative backing path resolution failed\n");
        goto cleanup;
    }

    if (STRNEQ_NULLABLE(data->expect, actual)) {
        fprintf(stderr, "relative path resolution from '%s' to '%s': "
                "expected '%s', got '%s'\n",
                data->top->path, data->base->path,
                NULLSTR(data->expect), NULLSTR(actual));
        goto cleanup;
    }

    ret = 0;

 cleanup:
    VIR_FREE(actual);

    return ret;
}

673

674 675 676 677 678
static int
mymain(void)
{
    int ret;
    virCommandPtr cmd = NULL;
679
    struct testChainData data;
E
Eric Blake 已提交
680
    struct testLookupData data2;
681
    struct testPathCanonicalizeData data3;
682
    struct testPathRelativeBacking data4;
683
    virStorageSourcePtr chain = NULL;
E
Eric Blake 已提交
684 685
    virStorageSourcePtr chain2; /* short for chain->backingStore */
    virStorageSourcePtr chain3; /* short for chain2->backingStore */
686 687 688 689 690 691

    /* Prep some files with qemu-img; if that is not found on PATH, or
     * if it lacks support for qcow2 and qed, skip this test.  */
    if ((ret = testPrepImages()) != 0)
        return ret;

692
#define TEST_ONE_CHAIN(id, start, format, flags, ...)                \
693
    do {                                                             \
694 695 696 697
        size_t i;                                                    \
        memset(&data, 0, sizeof(data));                              \
        data = (struct testChainData){                               \
            start, format, { __VA_ARGS__ }, 0, flags,                \
698
        };                                                           \
699 700 701
        for (i = 0; i < ARRAY_CARDINALITY(data.files); i++)          \
            if (data.files[i])                                       \
                data.nfiles++;                                       \
702
        if (virtTestRun("Storage backing chain " id,                 \
703 704 705 706
                        testStorageChain, &data) < 0)                \
            ret = -1;                                                \
    } while (0)

707 708 709
#define VIR_FLATTEN_2(...) __VA_ARGS__
#define VIR_FLATTEN_1(_1) VIR_FLATTEN_2 _1

710
#define TEST_CHAIN(id, path, format, chain1, flags1, chain2, flags2) \
711
    do {                                                             \
712
        TEST_ONE_CHAIN(#id "a", path, format, flags1 | ABS_START,    \
713
                       VIR_FLATTEN_1(chain1));                       \
714
        TEST_ONE_CHAIN(#id "b", path, format, flags2 | ABS_START,    \
715
                       VIR_FLATTEN_1(chain2));                       \
716 717 718 719 720
    } while (0)

    /* The actual tests, in several groups. */

    /* Missing file */
721
    TEST_ONE_CHAIN("0", "bogus", VIR_STORAGE_FILE_RAW, EXP_FAIL);
722 723

    /* Raw image, whether with right format or no specified format */
724
    testFileData raw = {
725
        .path = canonraw,
E
Eric Blake 已提交
726 727 728 729
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_RAW,
730
    };
731
    TEST_CHAIN(1, absraw, VIR_STORAGE_FILE_RAW,
732 733
               (&raw), EXP_PASS,
               (&raw), ALLOW_PROBE | EXP_PASS);
734
    TEST_CHAIN(2, absraw, VIR_STORAGE_FILE_AUTO,
735 736
               (&raw), EXP_PASS,
               (&raw), ALLOW_PROBE | EXP_PASS);
737 738

    /* Qcow2 file with relative raw backing, format provided */
739
    raw.pathRel = "raw";
740
    testFileData qcow2 = {
741 742
        .expBackingStoreRaw = "raw",
        .expCapacity = 1024,
743
        .path = canonqcow2,
E
Eric Blake 已提交
744 745 746 747
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
748 749
    };
    testFileData qcow2_as_raw = {
750
        .path = canonqcow2,
E
Eric Blake 已提交
751 752 753 754
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_RAW,
755
    };
756
    TEST_CHAIN(3, absqcow2, VIR_STORAGE_FILE_QCOW2,
757 758
               (&qcow2, &raw), EXP_PASS,
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
759
    TEST_CHAIN(4, absqcow2, VIR_STORAGE_FILE_AUTO,
760
               (&qcow2_as_raw), EXP_PASS,
761
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
762 763 764 765 766 767 768

    /* Rewrite qcow2 file to use absolute backing name */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", absraw, "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
769
    qcow2.expBackingStoreRaw = absraw;
770
    raw.pathRel = NULL;
E
Eric Blake 已提交
771
    raw.relDirRel = datadir;
772 773

    /* Qcow2 file with raw as absolute backing, backing format provided */
774
    TEST_CHAIN(5, absqcow2, VIR_STORAGE_FILE_QCOW2,
775 776
               (&qcow2, &raw), EXP_PASS,
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
777
    TEST_CHAIN(6, absqcow2, VIR_STORAGE_FILE_AUTO,
778
               (&qcow2_as_raw), EXP_PASS,
779
               (&qcow2, &raw), ALLOW_PROBE | EXP_PASS);
780 781

    /* Wrapped file access */
782 783 784
    testFileData wrap = {
        .expBackingStoreRaw = absqcow2,
        .expCapacity = 1024,
785
        .path = canonwrap,
E
Eric Blake 已提交
786 787 788 789
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
790
    };
E
Eric Blake 已提交
791
    qcow2.relDirRel = datadir;
792
    TEST_CHAIN(7, abswrap, VIR_STORAGE_FILE_QCOW2,
793 794
               (&wrap, &qcow2, &raw), EXP_PASS,
               (&wrap, &qcow2, &raw), ALLOW_PROBE | EXP_PASS);
795 796 797 798 799 800 801 802 803 804 805 806 807

    /* Rewrite qcow2 and wrap file to omit backing file type */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-b", absraw, "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-b", absqcow2, "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
E
Eric Blake 已提交
808
    qcow2_as_raw.relDirRel = datadir;
809 810

    /* Qcow2 file with raw as absolute backing, backing format omitted */
811 812 813
    testFileData wrap_as_raw = {
        .expBackingStoreRaw = absqcow2,
        .expCapacity = 1024,
814
        .path = canonwrap,
E
Eric Blake 已提交
815 816 817 818
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
819
    };
820
    TEST_CHAIN(8, abswrap, VIR_STORAGE_FILE_QCOW2,
821
               (&wrap_as_raw, &qcow2_as_raw), EXP_PASS,
822
               (&wrap, &qcow2, &raw), ALLOW_PROBE | EXP_PASS);
823 824 825 826 827 828 829 830

    /* Rewrite qcow2 to a missing backing file, with backing type */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", datadir "/bogus",
                               "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
831
    qcow2.expBackingStoreRaw = datadir "/bogus";
E
Eric Blake 已提交
832
    qcow2.relDirRel = ".";
833 834

    /* Qcow2 file with missing backing file but specified type */
835
    TEST_CHAIN(9, absqcow2, VIR_STORAGE_FILE_QCOW2,
836 837
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN);
838 839 840 841 842 843 844 845 846

    /* Rewrite qcow2 to a missing backing file, without backing type */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-b", datadir "/bogus", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Qcow2 file with missing backing file and no specified type */
847
    TEST_CHAIN(10, absqcow2, VIR_STORAGE_FILE_QCOW2,
848 849
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN);
850 851 852 853

    /* Rewrite qcow2 to use an nbd: protocol as backend */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
854
                               "-F", "raw", "-b", "nbd:example.org:6000:exportname=blah",
855 856 857
                               "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
858
    qcow2.expBackingStoreRaw = "nbd:example.org:6000:exportname=blah";
859 860

    /* Qcow2 file with backing protocol instead of file */
861
    testFileData nbd = {
862
        .path = "blah",
863 864
        .type = VIR_STORAGE_TYPE_NETWORK,
        .format = VIR_STORAGE_FILE_RAW,
865 866
        .relDirRel = ".",
        .relDirAbs = ".",
867
    };
868
    TEST_CHAIN(11, absqcow2, VIR_STORAGE_FILE_QCOW2,
869 870
               (&qcow2, &nbd), EXP_PASS,
               (&qcow2, &nbd), ALLOW_PROBE | EXP_PASS);
871 872

    /* qed file */
873 874 875
    testFileData qed = {
        .expBackingStoreRaw = absraw,
        .expCapacity = 1024,
876
        .path = canonqed,
E
Eric Blake 已提交
877 878 879 880
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QED,
881 882
    };
    testFileData qed_as_raw = {
883
        .path = canonqed,
E
Eric Blake 已提交
884 885 886 887
        .relDirRel = ".",
        .relDirAbs = datadir,
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_RAW,
888
    };
889
    TEST_CHAIN(12, absqed, VIR_STORAGE_FILE_AUTO,
890
               (&qed_as_raw), EXP_PASS,
891
               (&qed, &raw), ALLOW_PROBE | EXP_PASS);
892

E
Eric Blake 已提交
893
    /* directory */
894
    testFileData dir = {
895 896 897
        .path = canondir,
        .relDirRel = ".",
        .relDirAbs = datadir,
E
Eric Blake 已提交
898 899
        .type = VIR_STORAGE_TYPE_DIR,
        .format = VIR_STORAGE_FILE_DIR,
900
    };
901
    TEST_CHAIN(13, absdir, VIR_STORAGE_FILE_AUTO,
E
Eric Blake 已提交
902 903
               (&dir), EXP_PASS,
               (&dir), ALLOW_PROBE | EXP_PASS);
904
    TEST_CHAIN(14, absdir, VIR_STORAGE_FILE_DIR,
E
Eric Blake 已提交
905 906 907
               (&dir), EXP_PASS,
               (&dir), ALLOW_PROBE | EXP_PASS);

908
#ifdef HAVE_SYMLINK
909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924
    /* Rewrite qcow2 and wrap file to use backing names relative to a
     * symlink from a different directory */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", "../raw", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "../sub/link1", "wrap",
                               NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Behavior of symlinks to qcow2 with relative backing files */
925
    testFileData link1 = {
926 927
        .expBackingStoreRaw = "../raw",
        .expCapacity = 1024,
928
        .pathRel = "../sub/link1",
929
        .path = canonqcow2,
E
Eric Blake 已提交
930 931 932 933
        .relDirRel = "sub/../sub",
        .relDirAbs = datadir "/sub/../sub",
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
934
    };
935
    testFileData link2 = {
936 937
        .expBackingStoreRaw = "../sub/link1",
        .expCapacity = 1024,
938
        .path = canonwrap,
E
Eric Blake 已提交
939 940 941 942
        .relDirRel = "sub",
        .relDirAbs = datadir "/sub",
        .type = VIR_STORAGE_TYPE_FILE,
        .format = VIR_STORAGE_FILE_QCOW2,
943
    };
944
    raw.pathRel = "../raw";
E
Eric Blake 已提交
945 946
    raw.relDirRel = "sub/../sub/..";
    raw.relDirAbs = datadir "/sub/../sub/..";
947
    TEST_CHAIN(15, abslink2, VIR_STORAGE_FILE_QCOW2,
948 949
               (&link2, &link1, &raw), EXP_PASS,
               (&link2, &link1, &raw), ALLOW_PROBE | EXP_PASS);
950
#endif
E
Eric Blake 已提交
951 952 953 954 955 956 957

    /* Rewrite qcow2 to be a self-referential loop */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "qcow2", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
958
    qcow2.expBackingStoreRaw = "qcow2";
E
Eric Blake 已提交
959 960

    /* Behavior of an infinite loop chain */
961
    TEST_CHAIN(16, absqcow2, VIR_STORAGE_FILE_QCOW2,
962 963
               (&qcow2), EXP_WARN,
               (&qcow2), ALLOW_PROBE | EXP_WARN);
E
Eric Blake 已提交
964 965 966 967 968 969 970 971 972 973 974 975 976

    /* Rewrite wrap and qcow2 to be mutually-referential loop */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "wrap", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", absqcow2, "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;
977
    qcow2.expBackingStoreRaw = "wrap";
E
Eric Blake 已提交
978
    qcow2.relDirRel =  datadir;
E
Eric Blake 已提交
979 980

    /* Behavior of an infinite loop chain */
981
    TEST_CHAIN(17, abswrap, VIR_STORAGE_FILE_QCOW2,
982 983
               (&wrap, &qcow2), EXP_WARN,
               (&wrap, &qcow2), ALLOW_PROBE | EXP_WARN);
E
Eric Blake 已提交
984

E
Eric Blake 已提交
985 986 987 988 989 990 991
    /* Rewrite wrap and qcow2 back to 3-deep chain, absolute backing */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", absraw, "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

992
    /* Test behavior of chain lookups, absolute backing from relative start */
993 994
    chain = testStorageFileGetMetadata("wrap", VIR_STORAGE_FILE_QCOW2,
                                       -1, -1, false);
E
Eric Blake 已提交
995 996 997 998
    if (!chain) {
        ret = -1;
        goto cleanup;
    }
E
Eric Blake 已提交
999 1000
    chain2 = chain->backingStore;
    chain3 = chain2->backingStore;
E
Eric Blake 已提交
1001

E
Eric Blake 已提交
1002
#define TEST_LOOKUP_TARGET(id, target, from, name, index, result,       \
E
Eric Blake 已提交
1003
                           meta, parent)                                \
E
Eric Blake 已提交
1004 1005 1006 1007 1008 1009 1010
    do {                                                                \
        data2 = (struct testLookupData){                                \
            chain, target, from, name, index,                           \
            result, meta, parent, };                                    \
        if (virtTestRun("Chain lookup " #id,                            \
                        testStorageLookup, &data2) < 0)                 \
            ret = -1;                                                   \
E
Eric Blake 已提交
1011
    } while (0)
E
Eric Blake 已提交
1012 1013 1014 1015
#define TEST_LOOKUP(id, from, name, result, meta, parent)               \
    TEST_LOOKUP_TARGET(id, NULL, from, name, 0, result, meta, parent)

    TEST_LOOKUP(0, NULL, "bogus", NULL, NULL, NULL);
E
Eric Blake 已提交
1016
    TEST_LOOKUP(1, chain, "bogus", NULL, NULL, NULL);
E
Eric Blake 已提交
1017
    TEST_LOOKUP(2, NULL, "wrap", chain->path, chain, NULL);
E
Eric Blake 已提交
1018
    TEST_LOOKUP(3, chain, "wrap", NULL, NULL, NULL);
E
Eric Blake 已提交
1019
    TEST_LOOKUP(4, chain2, "wrap", NULL, NULL, NULL);
E
Eric Blake 已提交
1020
    TEST_LOOKUP(5, NULL, abswrap, chain->path, chain, NULL);
E
Eric Blake 已提交
1021
    TEST_LOOKUP(6, chain, abswrap, NULL, NULL, NULL);
E
Eric Blake 已提交
1022
    TEST_LOOKUP(7, chain2, abswrap, NULL, NULL, NULL);
E
Eric Blake 已提交
1023
    TEST_LOOKUP(8, NULL, "qcow2", chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1024
    TEST_LOOKUP(9, chain, "qcow2", chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1025
    TEST_LOOKUP(10, chain2, "qcow2", NULL, NULL, NULL);
E
Eric Blake 已提交
1026
    TEST_LOOKUP(11, chain3, "qcow2", NULL, NULL, NULL);
E
Eric Blake 已提交
1027
    TEST_LOOKUP(12, NULL, absqcow2, chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1028
    TEST_LOOKUP(13, chain, absqcow2, chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1029
    TEST_LOOKUP(14, chain2, absqcow2, NULL, NULL, NULL);
E
Eric Blake 已提交
1030
    TEST_LOOKUP(15, chain3, absqcow2, NULL, NULL, NULL);
E
Eric Blake 已提交
1031
    TEST_LOOKUP(16, NULL, "raw", chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1032 1033
    TEST_LOOKUP(17, chain, "raw", chain3->path, chain3, chain2->path);
    TEST_LOOKUP(18, chain2, "raw", chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1034
    TEST_LOOKUP(19, chain3, "raw", NULL, NULL, NULL);
E
Eric Blake 已提交
1035
    TEST_LOOKUP(20, NULL, absraw, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1036 1037
    TEST_LOOKUP(21, chain, absraw, chain3->path, chain3, chain2->path);
    TEST_LOOKUP(22, chain2, absraw, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1038
    TEST_LOOKUP(23, chain3, absraw, NULL, NULL, NULL);
E
Eric Blake 已提交
1039
    TEST_LOOKUP(24, NULL, NULL, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1040 1041
    TEST_LOOKUP(25, chain, NULL, chain3->path, chain3, chain2->path);
    TEST_LOOKUP(26, chain2, NULL, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1042
    TEST_LOOKUP(27, chain3, NULL, NULL, NULL, NULL);
E
Eric Blake 已提交
1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056

    /* Rewrite wrap and qcow2 back to 3-deep chain, relative backing */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "raw", "-b", "raw", "qcow2", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "qcow2", "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

1057
    /* Test behavior of chain lookups, relative backing from absolute start */
1058
    virStorageSourceFree(chain);
1059 1060
    chain = testStorageFileGetMetadata(abswrap, VIR_STORAGE_FILE_QCOW2,
                                       -1, -1, false);
E
Eric Blake 已提交
1061 1062 1063 1064
    if (!chain) {
        ret = -1;
        goto cleanup;
    }
E
Eric Blake 已提交
1065 1066
    chain2 = chain->backingStore;
    chain3 = chain2->backingStore;
E
Eric Blake 已提交
1067

E
Eric Blake 已提交
1068
    TEST_LOOKUP(28, NULL, "bogus", NULL, NULL, NULL);
E
Eric Blake 已提交
1069
    TEST_LOOKUP(29, chain, "bogus", NULL, NULL, NULL);
E
Eric Blake 已提交
1070
    TEST_LOOKUP(30, NULL, "wrap", chain->path, chain, NULL);
E
Eric Blake 已提交
1071
    TEST_LOOKUP(31, chain, "wrap", NULL, NULL, NULL);
E
Eric Blake 已提交
1072
    TEST_LOOKUP(32, chain2, "wrap", NULL, NULL, NULL);
E
Eric Blake 已提交
1073
    TEST_LOOKUP(33, NULL, abswrap, chain->path, chain, NULL);
E
Eric Blake 已提交
1074
    TEST_LOOKUP(34, chain, abswrap, NULL, NULL, NULL);
E
Eric Blake 已提交
1075
    TEST_LOOKUP(35, chain2, abswrap, NULL, NULL, NULL);
E
Eric Blake 已提交
1076
    TEST_LOOKUP(36, NULL, "qcow2", chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1077
    TEST_LOOKUP(37, chain, "qcow2", chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1078
    TEST_LOOKUP(38, chain2, "qcow2", NULL, NULL, NULL);
E
Eric Blake 已提交
1079
    TEST_LOOKUP(39, chain3, "qcow2", NULL, NULL, NULL);
E
Eric Blake 已提交
1080
    TEST_LOOKUP(40, NULL, absqcow2, chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1081
    TEST_LOOKUP(41, chain, absqcow2, chain2->path, chain2, chain->path);
E
Eric Blake 已提交
1082
    TEST_LOOKUP(42, chain2, absqcow2, NULL, NULL, NULL);
E
Eric Blake 已提交
1083
    TEST_LOOKUP(43, chain3, absqcow2, NULL, NULL, NULL);
E
Eric Blake 已提交
1084
    TEST_LOOKUP(44, NULL, "raw", chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1085 1086
    TEST_LOOKUP(45, chain, "raw", chain3->path, chain3, chain2->path);
    TEST_LOOKUP(46, chain2, "raw", chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1087
    TEST_LOOKUP(47, chain3, "raw", NULL, NULL, NULL);
E
Eric Blake 已提交
1088
    TEST_LOOKUP(48, NULL, absraw, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1089 1090
    TEST_LOOKUP(49, chain, absraw, chain3->path, chain3, chain2->path);
    TEST_LOOKUP(50, chain2, absraw, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1091
    TEST_LOOKUP(51, chain3, absraw, NULL, NULL, NULL);
E
Eric Blake 已提交
1092
    TEST_LOOKUP(52, NULL, NULL, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1093 1094
    TEST_LOOKUP(53, chain, NULL, chain3->path, chain3, chain2->path);
    TEST_LOOKUP(54, chain2, NULL, chain3->path, chain3, chain2->path);
E
Eric Blake 已提交
1095
    TEST_LOOKUP(55, chain3, NULL, NULL, NULL, NULL);
E
Eric Blake 已提交
1096 1097 1098 1099 1100 1101 1102 1103 1104

    /* Use link to wrap with cross-directory relative backing */
    virCommandFree(cmd);
    cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
                               "-F", "qcow2", "-b", "../qcow2", "wrap", NULL);
    if (virCommandRun(cmd, NULL) < 0)
        ret = -1;

    /* Test behavior of chain lookups, relative backing */
1105
    virStorageSourceFree(chain);
1106 1107
    chain = testStorageFileGetMetadata("sub/link2", VIR_STORAGE_FILE_QCOW2,
                                       -1, -1, false);
E
Eric Blake 已提交
1108 1109 1110 1111
    if (!chain) {
        ret = -1;
        goto cleanup;
    }
E
Eric Blake 已提交
1112 1113
    chain2 = chain->backingStore;
    chain3 = chain2->backingStore;
E
Eric Blake 已提交
1114

E
Eric Blake 已提交
1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129
    TEST_LOOKUP(56, NULL, "bogus", NULL, NULL, NULL);
    TEST_LOOKUP(57, NULL, "sub/link2", chain->path, chain, NULL);
    TEST_LOOKUP(58, NULL, "wrap", chain->path, chain, NULL);
    TEST_LOOKUP(59, NULL, abswrap, chain->path, chain, NULL);
    TEST_LOOKUP(60, NULL, "../qcow2", chain2->path, chain2, chain->path);
    TEST_LOOKUP(61, NULL, "qcow2", NULL, NULL, NULL);
    TEST_LOOKUP(62, NULL, absqcow2, chain2->path, chain2, chain->path);
    TEST_LOOKUP(63, NULL, "raw", chain3->path, chain3, chain2->path);
    TEST_LOOKUP(64, NULL, absraw, chain3->path, chain3, chain2->path);
    TEST_LOOKUP(65, NULL, NULL, chain3->path, chain3, chain2->path);

    TEST_LOOKUP_TARGET(66, "vda", NULL, "bogus[1]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(67, "vda", NULL, "vda[-1]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(68, "vda", NULL, "vda[1][1]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(69, "vda", NULL, "wrap", 0, chain->path, chain, NULL);
E
Eric Blake 已提交
1130
    TEST_LOOKUP_TARGET(70, "vda", chain, "wrap", 0, NULL, NULL, NULL);
E
Eric Blake 已提交
1131
    TEST_LOOKUP_TARGET(71, "vda", chain2, "wrap", 0, NULL, NULL, NULL);
E
Eric Blake 已提交
1132 1133
    TEST_LOOKUP_TARGET(72, "vda", NULL, "vda[0]", 0, NULL, NULL, NULL);
    TEST_LOOKUP_TARGET(73, "vda", NULL, "vda[1]", 1, chain2->path, chain2,
1134
                       chain->path);
E
Eric Blake 已提交
1135 1136
    TEST_LOOKUP_TARGET(74, "vda", chain, "vda[1]", 1, chain2->path, chain2,
                       chain->path);
E
Eric Blake 已提交
1137
    TEST_LOOKUP_TARGET(75, "vda", chain2, "vda[1]", 1, NULL, NULL, NULL);
E
Eric Blake 已提交
1138
    TEST_LOOKUP_TARGET(76, "vda", chain3, "vda[1]", 1, NULL, NULL, NULL);
E
Eric Blake 已提交
1139
    TEST_LOOKUP_TARGET(77, "vda", NULL, "vda[2]", 2, chain3->path, chain3,
E
Eric Blake 已提交
1140
                       chain2->path);
E
Eric Blake 已提交
1141 1142 1143 1144
    TEST_LOOKUP_TARGET(78, "vda", chain, "vda[2]", 2, chain3->path, chain3,
                       chain2->path);
    TEST_LOOKUP_TARGET(79, "vda", chain2, "vda[2]", 2, chain3->path, chain3,
                       chain2->path);
E
Eric Blake 已提交
1145
    TEST_LOOKUP_TARGET(80, "vda", chain3, "vda[2]", 2, NULL, NULL, NULL);
E
Eric Blake 已提交
1146
    TEST_LOOKUP_TARGET(81, "vda", NULL, "vda[3]", 3, NULL, NULL, NULL);
1147

1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190
#define TEST_PATH_CANONICALIZE(id, PATH, EXPECT)                            \
    do {                                                                    \
        data3.path = PATH;                                                  \
        data3.expect = EXPECT;                                              \
        if (virtTestRun("Path canonicalize " #id,                           \
                        testPathCanonicalize, &data3) < 0)                  \
            ret = -1;                                                       \
    } while (0)

    TEST_PATH_CANONICALIZE(1, "/", "/");
    TEST_PATH_CANONICALIZE(2, "/path", "/path");
    TEST_PATH_CANONICALIZE(3, "/path/to/blah", "/path/to/blah");
    TEST_PATH_CANONICALIZE(4, "/path/", "/path");
    TEST_PATH_CANONICALIZE(5, "///////", "/");
    TEST_PATH_CANONICALIZE(6, "//", "//");
    TEST_PATH_CANONICALIZE(7, "", "");
    TEST_PATH_CANONICALIZE(8, ".", ".");
    TEST_PATH_CANONICALIZE(9, "../", "..");
    TEST_PATH_CANONICALIZE(10, "../../", "../..");
    TEST_PATH_CANONICALIZE(11, "../../blah", "../../blah");
    TEST_PATH_CANONICALIZE(12, "/./././blah", "/blah");
    TEST_PATH_CANONICALIZE(13, ".././../././../blah", "../../../blah");
    TEST_PATH_CANONICALIZE(14, "/././", "/");
    TEST_PATH_CANONICALIZE(15, "./././", ".");
    TEST_PATH_CANONICALIZE(16, "blah/../foo", "foo");
    TEST_PATH_CANONICALIZE(17, "foo/bar/../blah", "foo/blah");
    TEST_PATH_CANONICALIZE(18, "foo/bar/.././blah", "foo/blah");
    TEST_PATH_CANONICALIZE(19, "/path/to/foo/bar/../../../../../../../../baz", "/baz");
    TEST_PATH_CANONICALIZE(20, "path/to/foo/bar/../../../../../../../../baz", "../../../../baz");
    TEST_PATH_CANONICALIZE(21, "path/to/foo/bar", "path/to/foo/bar");
    TEST_PATH_CANONICALIZE(22, "//foo//bar", "//foo/bar");
    TEST_PATH_CANONICALIZE(23, "/bar//foo", "/bar/foo");
    TEST_PATH_CANONICALIZE(24, "//../blah", "//blah");

    /* test paths with symlinks */
    TEST_PATH_CANONICALIZE(25, "/path/blah", "/other/path/huzah");
    TEST_PATH_CANONICALIZE(26, "/path/to/relative/symlink", "/path/actual/file");
    TEST_PATH_CANONICALIZE(27, "/path/to/relative/symlink/blah", "/path/actual/file/blah");
    TEST_PATH_CANONICALIZE(28, "/path/blah/yippee", "/other/path/huzah/yippee");
    TEST_PATH_CANONICALIZE(29, "/cycle", NULL);
    TEST_PATH_CANONICALIZE(30, "/cycle2/link", NULL);
    TEST_PATH_CANONICALIZE(31, "///", "/");

1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237
#define TEST_RELATIVE_BACKING(id, TOP, BASE, EXPECT)                        \
    do {                                                                    \
        data4.top = &TOP;                                                   \
        data4.base = &BASE;                                                 \
        data4.expect = EXPECT;                                              \
        if (virtTestRun("Path relative resolve " #id,                       \
                        testPathRelative, &data4) < 0)                      \
            ret = -1;                                                       \
    } while (0)

    testPathRelativePrepare();

    /* few negative tests first */

    /* a non-relative image is in the backing chain span */
    TEST_RELATIVE_BACKING(1, backingchain[0], backingchain[1], NULL);
    TEST_RELATIVE_BACKING(2, backingchain[0], backingchain[2], NULL);
    TEST_RELATIVE_BACKING(3, backingchain[0], backingchain[3], NULL);
    TEST_RELATIVE_BACKING(4, backingchain[1], backingchain[5], NULL);

    /* image is not in chain (specified backwards) */
    TEST_RELATIVE_BACKING(5, backingchain[2], backingchain[1], NULL);

    /* positive tests */
    TEST_RELATIVE_BACKING(6, backingchain[1], backingchain[1], "asdf");
    TEST_RELATIVE_BACKING(7, backingchain[1], backingchain[2], "test");
    TEST_RELATIVE_BACKING(8, backingchain[1], backingchain[3], "blah");
    TEST_RELATIVE_BACKING(9, backingchain[2], backingchain[2], "test");
    TEST_RELATIVE_BACKING(10, backingchain[2], backingchain[3], "blah");
    TEST_RELATIVE_BACKING(11, backingchain[3], backingchain[3], "blah");

    /* oVirt spelling */
    TEST_RELATIVE_BACKING(12, backingchain[5], backingchain[5], "../volume/image2");
    TEST_RELATIVE_BACKING(13, backingchain[5], backingchain[6], "../volume/../volume/image3");
    TEST_RELATIVE_BACKING(14, backingchain[5], backingchain[7], "../volume/../volume/../volume/image4");
    TEST_RELATIVE_BACKING(15, backingchain[6], backingchain[6], "../volume/image3");
    TEST_RELATIVE_BACKING(16, backingchain[6], backingchain[7], "../volume/../volume/image4");
    TEST_RELATIVE_BACKING(17, backingchain[7], backingchain[7], "../volume/image4");

    /* crazy spellings */
    TEST_RELATIVE_BACKING(17, backingchain[9], backingchain[9], "directory/stuff/volumes/garbage/image2");
    TEST_RELATIVE_BACKING(18, backingchain[9], backingchain[10], "directory/stuff/volumes/garbage/../../../image3");
    TEST_RELATIVE_BACKING(19, backingchain[9], backingchain[11], "directory/stuff/volumes/garbage/../../../../blah/image4");
    TEST_RELATIVE_BACKING(20, backingchain[10], backingchain[10], "../../../image3");
    TEST_RELATIVE_BACKING(21, backingchain[10], backingchain[11], "../../../../blah/image4");
    TEST_RELATIVE_BACKING(22, backingchain[11], backingchain[11], "../blah/image4");

E
Eric Blake 已提交
1238
 cleanup:
1239
    /* Final cleanup */
1240
    virStorageSourceFree(chain);
1241 1242 1243 1244 1245 1246 1247
    testCleanupImages();
    virCommandFree(cmd);

    return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
}

VIRT_TEST_MAIN(mymain)