virt-aa-helper.c 47.8 KB
Newer Older
J
Jamie Strandboge 已提交
1 2
/*
 * virt-aa-helper: wrapper program used by AppArmor security driver.
3
 *
4
 * Copyright (C) 2010-2014 Red Hat, Inc.
5
 * Copyright (C) 2009-2011 Canonical Ltd.
J
Jamie Strandboge 已提交
6
 *
O
Osier Yang 已提交
7 8 9 10 11 12 13 14 15 16 17
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
J
Jamie Strandboge 已提交
20 21 22 23 24 25 26 27 28 29 30 31
 */

#include <config.h>

#include <stdarg.h>
#include <unistd.h>
#include <sys/types.h>
#include <fcntl.h>
#include <getopt.h>
#include <sys/utsname.h>

#include "internal.h"
32
#include "virbuffer.h"
33
#include "viralloc.h"
34
#include "vircommand.h"
35
#include "virlog.h"
36
#include "dirname.h"
37
#include "driver.h"
J
Jamie Strandboge 已提交
38 39 40 41

#include "security_driver.h"
#include "security_apparmor.h"
#include "domain_conf.h"
42
#include "virxml.h"
43
#include "viruuid.h"
44
#include "virusb.h"
45
#include "virpci.h"
E
Eric Blake 已提交
46
#include "virfile.h"
47
#include "configmake.h"
48
#include "virrandom.h"
49
#include "virstring.h"
50
#include "virgettext.h"
51
#include "virhostdev.h"
J
Jamie Strandboge 已提交
52

53 54
#define VIR_FROM_THIS VIR_FROM_SECURITY

J
Jamie Strandboge 已提交
55 56 57 58 59 60 61 62 63 64 65 66
static char *progname;

typedef struct {
    char uuid[PROFILE_NAME_SIZE];       /* UUID of vm */
    bool dryrun;                /* dry run */
    char cmd;                   /* 'c'   create
                                 * 'a'   add (load)
                                 * 'r'   replace
                                 * 'R'   remove */
    char *files;                /* list of files */
    virDomainDefPtr def;        /* VM definition */
    virCapsPtr caps;            /* VM capabilities */
67
    virDomainXMLOptionPtr xmlopt; /* XML parser data */
68
    char *virtType;                  /* type of hypervisor (eg qemu, xen, lxc) */
69
    char *os;                   /* type of os (eg hvm, xen, exe) */
70
    virArch arch;               /* machine architecture */
71 72
    char *newfile;              /* newly added file */
    bool append;                /* append to .files instead of rewrite */
J
Jamie Strandboge 已提交
73 74 75 76 77 78 79 80 81
} vahControl;

static int
vahDeinit(vahControl * ctl)
{
    if (ctl == NULL)
        return -1;

    VIR_FREE(ctl->def);
82
    virObjectUnref(ctl->caps);
83
    virObjectUnref(ctl->xmlopt);
84
    VIR_FREE(ctl->files);
85
    VIR_FREE(ctl->virtType);
86
    VIR_FREE(ctl->os);
87
    VIR_FREE(ctl->newfile);
J
Jamie Strandboge 已提交
88 89 90 91 92 93 94 95 96 97

    return 0;
}

/*
 * Print usage
 */
static void
vah_usage(void)
{
98 99 100 101
    printf(_("\n%s [options] [< def.xml]\n\n"
            "  Options:\n"
            "    -a | --add                     load profile\n"
            "    -c | --create                  create profile from template\n"
102
            "    -d | --dryrun                  dry run\n"
103 104 105 106 107 108 109 110 111 112 113
            "    -D | --delete                  unload and delete profile\n"
            "    -f | --add-file <file>         add file to profile\n"
            "    -F | --append-file <file>      append file to profile\n"
            "    -r | --replace                 reload profile\n"
            "    -R | --remove                  unload profile\n"
            "    -h | --help                    this help\n"
            "    -u | --uuid <uuid>             uuid (profile name)\n"
            "\n"), progname);

    puts(_("This command is intended to be used by libvirtd "
           "and not used directly.\n"));
J
Jamie Strandboge 已提交
114 115 116 117 118 119
    return;
}

static void
vah_error(vahControl * ctl, int doexit, const char *str)
{
120
    fprintf(stderr, _("%s: error: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
121 122 123 124 125 126 127 128 129 130 131

    if (doexit) {
        if (ctl != NULL)
            vahDeinit(ctl);
        exit(EXIT_FAILURE);
    }
}

static void
vah_warning(const char *str)
{
132
    fprintf(stderr, _("%s: warning: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
133 134 135 136 137
}

static void
vah_info(const char *str)
{
138
    fprintf(stderr, _("%s:\n%s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
139 140 141 142 143 144 145 146
}

/*
 * run an apparmor_parser command
 */
static int
parserCommand(const char *profile_name, const char cmd)
{
147
    int result = -1;
J
Jamie Strandboge 已提交
148
    char flag[3];
149
    char *profile;
150 151
    int status;
    int ret;
J
Jamie Strandboge 已提交
152 153

    if (strchr("arR", cmd) == NULL) {
154
        vah_error(NULL, 0, _("invalid flag"));
J
Jamie Strandboge 已提交
155 156 157 158 159
        return -1;
    }

    snprintf(flag, 3, "-%c", cmd);

160 161
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", profile_name) < 0) {
162
        vah_error(NULL, 0, _("profile name exceeds maximum length"));
J
Jamie Strandboge 已提交
163 164 165 166
        return -1;
    }

    if (!virFileExists(profile)) {
167
        vah_error(NULL, 0, _("profile does not exist"));
168
        goto cleanup;
J
Jamie Strandboge 已提交
169 170 171 172
    } else {
        const char * const argv[] = {
            "/sbin/apparmor_parser", flag, profile, NULL
        };
J
Ján Tomko 已提交
173
        g_autoptr(virCommand) command = virCommandNewArgs(argv);
174

175
        virCommandRawStatus(command);
176
        if ((ret = virCommandRun(command, &status)) != 0 ||
177 178
            (WIFEXITED(status) && WEXITSTATUS(status) != 0)) {
            if (ret != 0) {
179
                vah_error(NULL, 0, _("failed to run apparmor_parser"));
180
                goto cleanup;
181 182 183
            } else if (cmd == 'R' && WIFEXITED(status) &&
                       WEXITSTATUS(status) == 234) {
                vah_warning(_("unable to unload already unloaded profile"));
184
            } else {
185
                vah_error(NULL, 0, _("apparmor_parser exited with error"));
186
                goto cleanup;
187
            }
J
Jamie Strandboge 已提交
188 189 190
        }
    }

191 192
    result = 0;

193
 cleanup:
194 195 196
    VIR_FREE(profile);

    return result;
J
Jamie Strandboge 已提交
197 198 199 200 201 202
}

/*
 * Update the dynamic files
 */
static int
203 204
update_include_file(const char *include_file, const char *included_files,
                    bool append)
J
Jamie Strandboge 已提交
205 206
{
    int rc = -1;
207
    int plen, flen = 0;
J
Jamie Strandboge 已提交
208 209
    int fd;
    char *pcontent = NULL;
210
    char *existing = NULL;
J
Jamie Strandboge 已提交
211 212 213
    const char *warning =
         "# DO NOT EDIT THIS FILE DIRECTLY. IT IS MANAGED BY LIBVIRT.\n";

214 215 216 217 218 219 220
    if (virFileExists(include_file)) {
        flen = virFileReadAll(include_file, MAX_FILE_LEN, &existing);
        if (flen < 0)
            return rc;
    }

    if (append && virFileExists(include_file)) {
221
        if (virAsprintfQuiet(&pcontent, "%s%s", existing, included_files) == -1) {
222
            vah_error(NULL, 0, _("could not allocate memory for profile"));
223
            goto cleanup;
224 225
        }
    } else {
226
        if (virAsprintfQuiet(&pcontent, "%s%s", warning, included_files) == -1) {
227
            vah_error(NULL, 0, _("could not allocate memory for profile"));
228
            goto cleanup;
229
        }
J
Jamie Strandboge 已提交
230 231 232 233
    }

    plen = strlen(pcontent);
    if (plen > MAX_FILE_LEN) {
234
        vah_error(NULL, 0, _("invalid length for new profile"));
235
        goto cleanup;
J
Jamie Strandboge 已提交
236 237 238
    }

    /* only update the disk profile if it is different */
239 240
    if (flen > 0 && flen == plen && STREQLEN(existing, pcontent, plen)) {
        rc = 0;
241
        goto cleanup;
J
Jamie Strandboge 已提交
242 243 244 245
    }

    /* write the file */
    if ((fd = open(include_file, O_CREAT | O_TRUNC | O_WRONLY, 0644)) == -1) {
246
        vah_error(NULL, 0, _("failed to create include file"));
247
        goto cleanup;
J
Jamie Strandboge 已提交
248 249 250
    }

    if (safewrite(fd, pcontent, plen) < 0) { /* don't write the '\0' */
251
        VIR_FORCE_CLOSE(fd);
252
        vah_error(NULL, 0, _("failed to write to profile"));
253
        goto cleanup;
J
Jamie Strandboge 已提交
254 255
    }

256
    if (VIR_CLOSE(fd) != 0) {
257
        vah_error(NULL, 0, _("failed to close or write to profile"));
258
        goto cleanup;
J
Jamie Strandboge 已提交
259 260 261
    }
    rc = 0;

262
 cleanup:
J
Jamie Strandboge 已提交
263
    VIR_FREE(pcontent);
264
    VIR_FREE(existing);
J
Jamie Strandboge 已提交
265 266 267 268 269 270 271 272 273

    return rc;
}

/*
 * Create a profile based on a template
 */
static int
create_profile(const char *profile, const char *profile_name,
274
               const char *profile_files, int virtType)
J
Jamie Strandboge 已提交
275
{
276
    char *template;
J
Jamie Strandboge 已提交
277 278 279 280
    char *tcontent = NULL;
    char *pcontent = NULL;
    char *replace_name = NULL;
    char *replace_files = NULL;
281
    char *tmp = NULL;
J
Jamie Strandboge 已提交
282 283 284 285 286
    const char *template_name = "\nprofile LIBVIRT_TEMPLATE";
    const char *template_end = "\n}";
    int tlen, plen;
    int fd;
    int rc = -1;
287
    const char *driver_name = NULL;
J
Jamie Strandboge 已提交
288 289

    if (virFileExists(profile)) {
290
        vah_error(NULL, 0, _("profile exists"));
J
Jamie Strandboge 已提交
291 292 293
        goto end;
    }

294 295 296 297 298 299 300 301 302
    switch (virtType) {
    case VIR_DOMAIN_VIRT_QEMU:
    case VIR_DOMAIN_VIRT_KQEMU:
    case VIR_DOMAIN_VIRT_KVM:
        driver_name = "qemu";
        break;
    default:
        driver_name = virDomainVirtTypeToString(virtType);
    }
C
Cédric Bosdonnat 已提交
303 304

    if (virAsprintfQuiet(&template, "%s/TEMPLATE.%s", APPARMOR_DIR "/libvirt",
305
                         driver_name) < 0) {
306
        vah_error(NULL, 0, _("template name exceeds maximum length"));
J
Jamie Strandboge 已提交
307 308 309 310
        goto end;
    }

    if (!virFileExists(template)) {
311
        vah_error(NULL, 0, _("template does not exist"));
J
Jamie Strandboge 已提交
312 313 314 315
        goto end;
    }

    if ((tlen = virFileReadAll(template, MAX_FILE_LEN, &tcontent)) < 0) {
316
        vah_error(NULL, 0, _("failed to read AppArmor template"));
J
Jamie Strandboge 已提交
317 318 319 320
        goto end;
    }

    if (strstr(tcontent, template_name) == NULL) {
321
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
322 323 324 325
        goto clean_tcontent;
    }

    if (strstr(tcontent, template_end) == NULL) {
326
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
327 328 329 330
        goto clean_tcontent;
    }

    /* '\nprofile <profile_name>\0' */
331
    if (virAsprintfQuiet(&replace_name, "\nprofile %s", profile_name) == -1) {
332
        vah_error(NULL, 0, _("could not allocate memory for profile name"));
J
Jamie Strandboge 已提交
333 334 335 336
        goto clean_tcontent;
    }

    /* '\n<profile_files>\n}\0' */
337 338
    if ((virtType != VIR_DOMAIN_VIRT_LXC) &&
            virAsprintfQuiet(&replace_files, "\n%s\n}", profile_files) == -1) {
339
        vah_error(NULL, 0, _("could not allocate memory for profile files"));
J
Jamie Strandboge 已提交
340 341 342 343
        VIR_FREE(replace_name);
        goto clean_tcontent;
    }

C
Cédric Bosdonnat 已提交
344
    plen = tlen + strlen(replace_name) - strlen(template_name) + 1;
345 346 347 348

    if (virtType != VIR_DOMAIN_VIRT_LXC)
        plen += strlen(replace_files) - strlen(template_end);

J
Jamie Strandboge 已提交
349
    if (plen > MAX_FILE_LEN || plen < tlen) {
350
        vah_error(NULL, 0, _("invalid length for new profile"));
J
Jamie Strandboge 已提交
351 352 353
        goto clean_replace;
    }

354
    if (!(pcontent = virStringReplace(tcontent, template_name, replace_name)))
J
Jamie Strandboge 已提交
355 356
        goto clean_all;

357 358 359 360
    if (virtType != VIR_DOMAIN_VIRT_LXC) {
        if (!(tmp = virStringReplace(pcontent, template_end, replace_files)))
            goto clean_all;
        VIR_FREE(pcontent);
361
        pcontent = g_steal_pointer(&tmp);
362
    }
J
Jamie Strandboge 已提交
363 364 365

    /* write the file */
    if ((fd = open(profile, O_CREAT | O_EXCL | O_WRONLY, 0644)) == -1) {
366
        vah_error(NULL, 0, _("failed to create profile"));
J
Jamie Strandboge 已提交
367 368 369 370
        goto clean_all;
    }

    if (safewrite(fd, pcontent, plen - 1) < 0) { /* don't write the '\0' */
371
        VIR_FORCE_CLOSE(fd);
372
        vah_error(NULL, 0, _("failed to write to profile"));
J
Jamie Strandboge 已提交
373 374 375
        goto clean_all;
    }

376
    if (VIR_CLOSE(fd) != 0) {
377
        vah_error(NULL, 0, _("failed to close or write to profile"));
J
Jamie Strandboge 已提交
378 379 380 381
        goto clean_all;
    }
    rc = 0;

382
 clean_all:
J
Jamie Strandboge 已提交
383
    VIR_FREE(pcontent);
384
 clean_replace:
J
Jamie Strandboge 已提交
385 386
    VIR_FREE(replace_name);
    VIR_FREE(replace_files);
387
 clean_tcontent:
J
Jamie Strandboge 已提交
388
    VIR_FREE(tcontent);
389
 end:
390
    VIR_FREE(template);
J
Jamie Strandboge 已提交
391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442
    return rc;
}

/*
 * Load an existing profile
 */
static int
parserLoad(const char *profile_name)
{
    return parserCommand(profile_name, 'a');
}

/*
 * Remove an existing profile
 */
static int
parserRemove(const char *profile_name)
{
    return parserCommand(profile_name, 'R');
}

/*
 * Replace an existing profile
 */
static int
parserReplace(const char *profile_name)
{
    return parserCommand(profile_name, 'r');
}

static int
valid_uuid(const char *uuid)
{
    unsigned char rawuuid[VIR_UUID_BUFLEN];

    if (strlen(uuid) != PROFILE_NAME_SIZE - 1)
        return -1;

    if (!STRPREFIX(uuid, AA_PREFIX))
        return -1;

    if (virUUIDParse(uuid + strlen(AA_PREFIX), rawuuid) < 0)
        return -1;

    return 0;
}

static int
valid_name(const char *name)
{
    /* just try to filter out any dangerous characters in the name that can be
     * used to subvert the profile */
443
    const char *bad = "/[]{}?^,\"*";
J
Jamie Strandboge 已提交
444

445
    if (strlen(name) == 0)
J
Jamie Strandboge 已提交
446 447 448 449 450 451 452 453 454 455 456 457
        return -1;

    if (strcspn(name, bad) != strlen(name))
        return -1;

    return 0;
}

/* see if one of the strings in arr starts with str */
static int
array_starts_with(const char *str, const char * const *arr, const long size)
{
458
    size_t i;
J
Jamie Strandboge 已提交
459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506
    for (i = 0; i < size; i++) {
        if (strlen(str) < strlen(arr[i]))
            continue;

        if (STRPREFIX(str, arr[i]))
            return 0;
    }
    return 1;
}

/*
 * Don't allow access to special files or restricted paths such as /bin, /sbin,
 * /usr/bin, /usr/sbin and /etc. This is in an effort to prevent read/write
 * access to system files which could be used to elevate privileges. This is a
 * safety measure in case libvirtd is under a restrictive profile and is
 * subverted and trying to escape confinement.
 *
 * Note that we cannot exclude block devices because they are valid devices.
 * The TEMPLATE file can be adjusted to explicitly disallow these if needed.
 *
 * RETURN: -1 on error, 0 if ok, 1 if blocked
 */
static int
valid_path(const char *path, const bool readonly)
{
    const char * const restricted[] = {
        "/bin/",
        "/etc/",
        "/lib",
        "/lost+found/",
        "/proc/",
        "/sbin/",
        "/selinux/",
        "/sys/",
        "/usr/bin/",
        "/usr/lib",
        "/usr/sbin/",
        "/usr/share/",
        "/usr/local/bin/",
        "/usr/local/etc/",
        "/usr/local/lib",
        "/usr/local/sbin/"
    };
    /* these paths are ok for readonly, but not read/write */
    const char * const restricted_rw[] = {
        "/boot/",
        "/vmlinuz",
        "/initrd",
507
        "/initrd.img",
508
        "/usr/share/edk2/",
509
        "/usr/share/OVMF/",              /* for OVMF images */
510 511
        "/usr/share/ovmf/",              /* for OVMF images */
        "/usr/share/AAVMF/",             /* for AAVMF images */
512 513
        "/usr/share/qemu-efi/",          /* for AAVMF images */
        "/usr/share/qemu-efi-aarch64/"   /* for AAVMF images */
J
Jamie Strandboge 已提交
514
    };
515 516
    /* override the above with these */
    const char * const override[] = {
517 518 519
        "/sys/devices/pci",                /* for hostdev pci devices */
        "/sys/kernel/config/target/vhost", /* for hostdev vhost_scsi devices */
        "/etc/libvirt-sandbox/services/"   /* for virt-sandbox service config */
520
    };
J
Jamie Strandboge 已提交
521

522 523 524
    const int nropaths = G_N_ELEMENTS(restricted);
    const int nrwpaths = G_N_ELEMENTS(restricted_rw);
    const int nopaths = G_N_ELEMENTS(override);
525

526
    if (path == NULL) {
527
        vah_error(NULL, 0, _("bad pathname"));
J
Jamie Strandboge 已提交
528 529 530 531 532 533 534 535 536
        return -1;
    }

    /* Don't allow double quotes, since we use them to quote the filename
     * and this will confuse the apparmor parser.
     */
    if (strchr(path, '"') != NULL)
        return 1;

J
Jamie Strandboge 已提交
537 538 539 540
    /* Require an absolute path */
    if (STRNEQLEN(path, "/", 1))
        return 1;

541
    if (!virFileExists(path))
542
        vah_warning(_("path does not exist, skipping file type checks"));
J
Jamie Strandboge 已提交
543

544
    /* overrides are always allowed */
545
    if (array_starts_with(path, override, nopaths) == 0)
546
        return 0;
J
Jamie Strandboge 已提交
547

548 549
    /* allow read only paths upfront */
    if (readonly) {
550
        if (array_starts_with(path, restricted_rw, nrwpaths) == 0)
551
            return 0;
J
Jamie Strandboge 已提交
552 553
    }

554
    /* disallow RW access to all paths in restricted and restriced_rw */
555 556
    if ((array_starts_with(path, restricted, nropaths) == 0 ||
         array_starts_with(path, restricted_rw, nrwpaths) == 0))
557 558
        return 1;

J
Jamie Strandboge 已提交
559 560 561
    return 0;
}

562 563 564 565 566 567 568
static int
verify_xpath_context(xmlXPathContextPtr ctxt)
{
    int rc = -1;
    char *tmp = NULL;

    if (!ctxt) {
569
        vah_warning(_("Invalid context"));
570 571 572 573 574
        goto error;
    }

    /* check if have <name> */
    if (!(tmp = virXPathString("string(./name[1])", ctxt))) {
575
        vah_warning(_("Could not find <name>"));
576 577 578 579 580 581
        goto error;
    }
    VIR_FREE(tmp);

    /* check if have <uuid> */
    if (!(tmp = virXPathString("string(./uuid[1])", ctxt))) {
582
        vah_warning(_("Could not find <uuid>"));
583 584 585 586 587 588
        goto error;
    }
    VIR_FREE(tmp);

    rc = 0;

589
 error:
590 591 592
    return rc;
}

593 594
/*
 * Parse the xml we received to fill in the following:
595
 * ctl->virtType
596
 * ctl->os
597 598 599 600 601 602 603 604 605 606
 * ctl->arch
 *
 * These are suitable for setting up a virCapsPtr
 */
static int
caps_mockup(vahControl * ctl, const char *xmlStr)
{
    int rc = -1;
    xmlDocPtr xml = NULL;
    xmlXPathContextPtr ctxt = NULL;
607
    char *arch;
608

609
    if (!(xml = virXMLParseStringCtxt(xmlStr, _("(domain_definition)"),
610
                                      &ctxt))) {
611 612 613
        goto cleanup;
    }

614
    if (!virXMLNodeNameEqual(ctxt->node, "domain")) {
615
        vah_error(NULL, 0, _("unexpected root element, expecting <domain>"));
616 617 618
        goto cleanup;
    }

619 620 621 622
    /* Quick sanity check for some required elements */
    if (verify_xpath_context(ctxt) != 0)
        goto cleanup;

623 624 625 626 627
    ctl->virtType = virXPathString("string(./@type)", ctxt);
    if (!ctl->virtType) {
        vah_error(ctl, 0, _("domain type is not defined"));
        goto cleanup;
    }
628 629
    ctl->os = virXPathString("string(./os/type[1])", ctxt);
    if (!ctl->os) {
630
        vah_error(ctl, 0, _("os.type is not defined"));
631 632
        goto cleanup;
    }
633 634 635 636 637 638
    arch = virXPathString("string(./os/type[1]/@arch)", ctxt);
    if (!arch) {
        ctl->arch = virArchFromHost();
    } else {
        ctl->arch = virArchFromString(arch);
        VIR_FREE(arch);
639 640 641 642
    }

    rc = 0;

643
 cleanup:
644
    xmlFreeDoc(xml);
645 646 647 648 649
    xmlXPathFreeContext(ctxt);

    return rc;
}

650 651 652
virDomainDefParserConfig virAAHelperDomainDefParserConfig = {
    .features = VIR_DOMAIN_DEF_FEATURE_MEMORY_HOTPLUG |
                VIR_DOMAIN_DEF_FEATURE_OFFLINE_VCPUPIN |
653 654
                VIR_DOMAIN_DEF_FEATURE_INDIVIDUAL_VCPUS |
                VIR_DOMAIN_DEF_FEATURE_NET_MODEL_STRING,
655
};
656

J
Jamie Strandboge 已提交
657 658 659
static int
get_definition(vahControl * ctl, const char *xmlStr)
{
660
    int rc = -1, ostype, virtType;
J
Jamie Strandboge 已提交
661 662 663 664 665 666
    virCapsGuestPtr guest;  /* this is freed when caps is freed */

    /*
     * mock up some capabilities. We don't currently use these explicitly,
     * but need them for virDomainDefParseString().
     */
667 668
    if (caps_mockup(ctl, xmlStr) != 0)
        goto exit;
J
Jamie Strandboge 已提交
669

670
    if ((ctl->caps = virCapabilitiesNew(ctl->arch, true, true)) == NULL) {
671
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
672 673 674
        goto exit;
    }

675 676
    if (!(ctl->xmlopt = virDomainXMLOptionNew(&virAAHelperDomainDefParserConfig,
                                              NULL, NULL, NULL, NULL))) {
677 678 679 680
        vah_error(ctl, 0, _("Failed to create XML config object"));
        goto exit;
    }

681
    if ((ostype = virDomainOSTypeFromString(ctl->os)) < 0) {
682 683 684 685
        vah_error(ctl, 0, _("unknown OS type"));
        goto exit;
    }

J
Jamie Strandboge 已提交
686
    if ((guest = virCapabilitiesAddGuest(ctl->caps,
687
                                         ostype,
688
                                         ctl->arch,
J
Jamie Strandboge 已提交
689 690 691 692
                                         NULL,
                                         NULL,
                                         0,
                                         NULL)) == NULL) {
693
        vah_error(ctl, 0, _("could not allocate memory"));
694 695 696 697 698 699 700 701 702 703 704 705 706 707 708
        goto exit;
    }

    if ((virtType = virDomainVirtTypeFromString(ctl->virtType)) < 0) {
        vah_error(ctl, 0, _("unknown virtualization type"));
        goto exit;
    }

    if (virCapabilitiesAddGuestDomain(guest,
                                      virtType,
                                      NULL,
                                      NULL,
                                      0,
                                      NULL) == NULL) {
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
709 710 711
        goto exit;
    }

712
    ctl->def = virDomainDefParseString(xmlStr,
713
                                       ctl->caps, ctl->xmlopt, NULL,
714
                                       VIR_DOMAIN_DEF_PARSE_SKIP_SECLABEL |
715
                                       VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE);
716

J
Jamie Strandboge 已提交
717
    if (ctl->def == NULL) {
718
        vah_error(ctl, 0, _("could not parse XML"));
J
Jamie Strandboge 已提交
719 720 721 722
        goto exit;
    }

    if (!ctl->def->name) {
723
        vah_error(ctl, 0, _("could not find name in XML"));
J
Jamie Strandboge 已提交
724 725 726 727
        goto exit;
    }

    if (valid_name(ctl->def->name) != 0) {
728
        vah_error(ctl, 0, _("bad name"));
J
Jamie Strandboge 已提交
729 730 731 732 733
        goto exit;
    }

    rc = 0;

734
 exit:
J
Jamie Strandboge 已提交
735 736 737
    return rc;
}

738 739 740 741
/**
  * The permissions allowed are apparmor valid permissions and 'R'. 'R' stands for
  * read with no explicit deny rule.
  */
J
Jamie Strandboge 已提交
742
static int
F
Felix Geyer 已提交
743
vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool recursive)
J
Jamie Strandboge 已提交
744 745 746 747
{
    char *tmp = NULL;
    int rc = -1;
    bool readonly = true;
748 749
    bool explicit_deny_rule = true;
    char *sub = NULL;
750
    char *perms_new = NULL;
751 752 753
    char *pathdir = NULL;
    char *pathtmp = NULL;
    char *pathreal = NULL;
J
Jamie Strandboge 已提交
754 755 756 757

    if (path == NULL)
        return rc;

J
Jamie Strandboge 已提交
758 759 760 761 762 763
    /* Skip files without an absolute path. Not having one confuses the
     * apparmor parser and this also ensures things like tcp consoles don't
     * get added to the profile.
     */
    if (STRNEQLEN(path, "/", 1)) {
        vah_warning(path);
764
        vah_warning(_("skipped non-absolute path"));
J
Jamie Strandboge 已提交
765 766 767
        return 0;
    }

768 769 770 771 772 773 774
    /* files might be created by qemu later on and not exist right now.
     * But realpath needs a valid path to work on, therefore:
     * 1. walk the path to find longest valid path
     * 2. get the realpath of that valid path
     * 3. re-combine the realpath with the remaining suffix
     * Note: A totally non existent path is used as-is
     */
775
     pathdir = g_strdup(path);
776 777 778 779
     while (!virFileExists(pathdir)) {
         if ((pathtmp = mdir_name(pathdir)) == NULL)
             goto cleanup;
         VIR_FREE(pathdir);
780
         pathdir = g_steal_pointer(&pathtmp);
781 782 783 784
     }

    if (strlen(pathdir) == 1) {
        /* nothing of the path does exist yet */
785
        tmp = g_strdup(path);
786
    } else {
787
        pathtmp = g_strdup(path + strlen(pathdir));
788 789 790 791
        if ((pathreal = realpath(pathdir, NULL)) == NULL) {
            vah_error(NULL, 0, pathdir);
            vah_error(NULL, 0, _("could not find realpath"));
            goto cleanup;
J
Jamie Strandboge 已提交
792
        }
793 794
        if (virAsprintfQuiet(&tmp, "%s%s", pathreal, pathtmp) < 0)
            goto cleanup;
795
    }
J
Jamie Strandboge 已提交
796

797
    perms_new = g_strdup(perms);
798 799

    if (strchr(perms_new, 'w') != NULL) {
J
Jamie Strandboge 已提交
800
        readonly = false;
801 802 803
        explicit_deny_rule = false;
    }

804
    if ((sub = strchr(perms_new, 'R')) != NULL) {
805 806 807 808
        /* Don't write the invalid R permission, replace it with 'r' */
        sub[0] = 'r';
        explicit_deny_rule = false;
    }
J
Jamie Strandboge 已提交
809 810 811 812 813

    rc = valid_path(tmp, readonly);
    if (rc != 0) {
        if (rc > 0) {
            vah_error(NULL, 0, path);
814
            vah_error(NULL, 0, _("skipped restricted file"));
J
Jamie Strandboge 已提交
815
        }
816
        goto cleanup;
J
Jamie Strandboge 已提交
817 818
    }

819 820 821
    if (tmp[strlen(tmp) - 1] == '/')
        tmp[strlen(tmp) - 1] = '\0';

822 823
    virBufferAsprintf(buf, "  \"%s%s\" %s,\n", tmp, recursive ? "/**" : "",
                      perms_new);
824
    if (explicit_deny_rule) {
825
        virBufferAddLit(buf, "  # don't audit writes to readonly files\n");
F
Felix Geyer 已提交
826 827 828 829 830
        virBufferAsprintf(buf, "  deny \"%s%s\" w,\n", tmp, recursive ? "/**" : "");
    }
    if (recursive) {
        /* allow reading (but not creating) the dir */
        virBufferAsprintf(buf, "  \"%s/\" r,\n", tmp);
831
    }
J
Jamie Strandboge 已提交
832

833
 cleanup:
834 835 836
    VIR_FREE(pathdir);
    VIR_FREE(pathtmp);
    VIR_FREE(pathreal);
837
    VIR_FREE(perms_new);
838
    VIR_FREE(tmp);
J
Jamie Strandboge 已提交
839 840 841 842

    return rc;
}

F
Felix Geyer 已提交
843 844 845 846 847 848
static int
vah_add_file(virBufferPtr buf, const char *path, const char *perms)
{
    return vah_add_path(buf, path, perms, false);
}

849 850 851 852 853 854 855 856 857 858 859 860
static int
vah_add_file_chardev(virBufferPtr buf,
                     const char *path,
                     const char *perms,
                     const int type)
{
    char *pipe_in;
    char *pipe_out;
    int rc = -1;

    if (type == VIR_DOMAIN_CHR_TYPE_PIPE) {
        /* add the pipe input */
861
        if (virAsprintfQuiet(&pipe_in, "%s.in", path) == -1) {
862
            vah_error(NULL, 0, _("could not allocate memory"));
863
            goto cleanup;
864 865 866 867 868 869
        }

        if (vah_add_file(buf, pipe_in, perms) != 0)
            goto clean_pipe_in;

        /* add the pipe output */
870
        if (virAsprintfQuiet(&pipe_out, "%s.out", path) == -1) {
871 872 873 874 875 876 877 878 879 880 881 882 883 884 885
            vah_error(NULL, 0, _("could not allocate memory"));
            goto clean_pipe_in;
        }

        if (vah_add_file(buf, pipe_out, perms) != 0)
            goto clean_pipe_out;

        rc = 0;
      clean_pipe_out:
        VIR_FREE(pipe_out);
      clean_pipe_in:
        VIR_FREE(pipe_in);
    } else {
        /* add the file */
        if (vah_add_file(buf, path, perms) != 0)
886
            goto cleanup;
887 888 889
        rc = 0;
    }

890
 cleanup:
891 892 893
    return rc;
}

J
Jamie Strandboge 已提交
894
static int
J
Ján Tomko 已提交
895
file_iterate_hostdev_cb(virUSBDevicePtr dev G_GNUC_UNUSED,
896 897 898 899 900 901 902
                        const char *file, void *opaque)
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

static int
J
Ján Tomko 已提交
903
file_iterate_pci_cb(virPCIDevicePtr dev G_GNUC_UNUSED,
904
                    const char *file, void *opaque)
J
Jamie Strandboge 已提交
905 906 907 908 909
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

910
static int
911
add_file_path(virStorageSourcePtr src,
912
              size_t depth,
913
              virBufferPtr buf)
914 915 916
{
    int ret;

917 918 919 920
    /* execute the callback only for local storage */
    if (!src->path || !virStorageSourceIsLocalStorage(src))
        return 0;

921
    if (depth == 0) {
922 923
        if (src->readonly)
            ret = vah_add_file(buf, src->path, "rk");
924
        else
925
            ret = vah_add_file(buf, src->path, "rwk");
926
    } else {
927
        ret = vah_add_file(buf, src->path, "rk");
928 929
    }

930 931 932
    if (ret != 0)
        ret = -1;

933 934 935
    return ret;
}

936 937

static int
938
storage_source_add_files(virStorageSourcePtr src,
939 940
                         virBufferPtr buf,
                         size_t depth)
941 942 943
{
    virStorageSourcePtr tmp;

944
    for (tmp = src; virStorageSourceIsBacking(tmp); tmp = tmp->backingStore) {
945 946
        if (add_file_path(tmp, depth, buf) < 0)
            return -1;
947 948 949 950 951 952 953

        depth++;
    }

    return 0;
}

J
Jamie Strandboge 已提交
954 955 956 957 958
static int
get_files(vahControl * ctl)
{
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
959
    size_t i;
J
Jamie Strandboge 已提交
960 961
    char *uuid;
    char uuidstr[VIR_UUID_STRING_BUFLEN];
962
    bool needsVfio = false, needsvhost = false, needsgl = false;
J
Jamie Strandboge 已提交
963 964 965

    /* verify uuid is same as what we were given on the command line */
    virUUIDFormat(ctl->def->uuid, uuidstr);
966
    if (virAsprintfQuiet(&uuid, "%s%s", AA_PREFIX, uuidstr) == -1) {
967
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
968 969 970 971
        return rc;
    }

    if (STRNEQ(uuid, ctl->uuid)) {
972
        vah_error(ctl, 0, _("given uuid does not match XML uuid"));
973
        goto cleanup;
J
Jamie Strandboge 已提交
974 975
    }

976 977
    /* load the storage driver so that backing store can be accessed */
#ifdef WITH_STORAGE
978
    virDriverLoadModule("storage", "storageRegister", false);
979
#endif
980

981
    for (i = 0; i < ctl->def->ndisks; i++) {
982 983
        virDomainDiskDefPtr disk = ctl->def->disks[i];

984
        if (!virDomainDiskGetSource(disk))
E
Eric Blake 已提交
985
            continue;
986 987 988
        /* XXX - if we knew the qemu user:group here we could send it in
         *        so that the open could be re-tried as that user:group.
         */
989
        if (!virStorageSourceHasBacking(disk->src))
990
            virStorageFileGetMetadata(disk->src, -1, -1, false);
991

992
         /* XXX should handle open errors more careful than just ignoring them.
993
         */
994
        if (storage_source_add_files(disk->src, &buf, 0) < 0)
995
            goto cleanup;
996
    }
J
Jamie Strandboge 已提交
997 998

    for (i = 0; i < ctl->def->nserials; i++)
999
        if (ctl->def->serials[i] &&
1000 1001 1002 1003 1004 1005 1006
            (ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->serials[i]->source->data.file.path &&
            ctl->def->serials[i]->source->data.file.path[0] != '\0')
1007
            if (vah_add_file_chardev(&buf,
1008
                                     ctl->def->serials[i]->source->data.file.path,
1009
                                     "rw",
1010
                                     ctl->def->serials[i]->source->type) != 0)
1011
                goto cleanup;
J
Jamie Strandboge 已提交
1012

1013 1014
    for (i = 0; i < ctl->def->nconsoles; i++)
        if (ctl->def->consoles[i] &&
1015 1016 1017 1018 1019 1020 1021
            (ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->consoles[i]->source->data.file.path &&
            ctl->def->consoles[i]->source->data.file.path[0] != '\0')
1022
            if (vah_add_file(&buf,
1023
                             ctl->def->consoles[i]->source->data.file.path, "rw") != 0)
1024
                goto cleanup;
J
Jamie Strandboge 已提交
1025

1026
    for (i = 0; i < ctl->def->nparallels; i++)
1027
        if (ctl->def->parallels[i] &&
1028 1029 1030 1031 1032 1033 1034
            (ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->parallels[i]->source->data.file.path &&
            ctl->def->parallels[i]->source->data.file.path[0] != '\0')
1035
            if (vah_add_file_chardev(&buf,
1036
                                     ctl->def->parallels[i]->source->data.file.path,
1037
                                     "rw",
1038
                                     ctl->def->parallels[i]->source->type) != 0)
1039
                goto cleanup;
1040

1041
    for (i = 0; i < ctl->def->nchannels; i++)
1042
        if (ctl->def->channels[i] &&
1043 1044 1045 1046 1047 1048 1049
            (ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->channels[i]->source->data.file.path &&
            ctl->def->channels[i]->source->data.file.path[0] != '\0')
1050
            if (vah_add_file_chardev(&buf,
1051
                                     ctl->def->channels[i]->source->data.file.path,
1052
                                     "rw",
1053
                                     ctl->def->channels[i]->source->type) != 0)
1054
                goto cleanup;
1055

1056
    if (ctl->def->os.kernel)
J
Jamie Strandboge 已提交
1057
        if (vah_add_file(&buf, ctl->def->os.kernel, "r") != 0)
1058
            goto cleanup;
J
Jamie Strandboge 已提交
1059

1060
    if (ctl->def->os.initrd)
J
Jamie Strandboge 已提交
1061
        if (vah_add_file(&buf, ctl->def->os.initrd, "r") != 0)
1062
            goto cleanup;
O
Olivia Yin 已提交
1063 1064 1065

    if (ctl->def->os.dtb)
        if (vah_add_file(&buf, ctl->def->os.dtb, "r") != 0)
1066
            goto cleanup;
J
Jamie Strandboge 已提交
1067

J
Ján Tomko 已提交
1068 1069 1070 1071
    if (ctl->def->os.slic_table)
        if (vah_add_file(&buf, ctl->def->os.slic_table, "r") != 0)
            goto cleanup;

1072
    if (ctl->def->os.loader && ctl->def->os.loader->path)
1073
        if (vah_add_file(&buf, ctl->def->os.loader->path, "rk") != 0)
1074
            goto cleanup;
1075

1076
    if (ctl->def->os.loader && ctl->def->os.loader->nvram)
1077
        if (vah_add_file(&buf, ctl->def->os.loader->nvram, "rwk") != 0)
1078 1079
            goto cleanup;

1080
    for (i = 0; i < ctl->def->ngraphics; i++) {
1081 1082
        virDomainGraphicsDefPtr graphics = ctl->def->graphics[i];
        size_t n;
1083 1084 1085 1086
        const char *rendernode = virDomainGraphicsGetRenderNode(graphics);

        if (rendernode) {
            vah_add_file(&buf, rendernode, "rw");
1087
            needsgl = true;
1088 1089 1090
        } else {
            if (virDomainGraphicsNeedsAutoRenderNode(graphics)) {
                char *defaultRenderNode = virHostGetDRMRenderNode();
1091
                needsgl = true;
1092 1093 1094 1095 1096 1097 1098

                if (defaultRenderNode) {
                    vah_add_file(&buf, defaultRenderNode, "rw");
                    VIR_FREE(defaultRenderNode);
                }
            }
        }
1099 1100 1101 1102 1103 1104 1105 1106 1107

        for (n = 0; n < graphics->nListens; n++) {
            virDomainGraphicsListenDef listenObj = graphics->listens[n];

            if (listenObj.type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET &&
                listenObj.socket &&
                vah_add_file(&buf, listenObj.socket, "rw"))
                goto cleanup;
        }
1108 1109
    }

1110 1111 1112 1113
    if (ctl->def->ngraphics == 1 &&
        ctl->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL)
        if (vah_add_file(&buf, ctl->def->graphics[0]->data.sdl.xauth,
                         "r") != 0)
1114
            goto cleanup;
J
Jamie Strandboge 已提交
1115 1116 1117 1118

    for (i = 0; i < ctl->def->nhostdevs; i++)
        if (ctl->def->hostdevs[i]) {
            virDomainHostdevDefPtr dev = ctl->def->hostdevs[i];
1119
            virDomainHostdevSubsysUSBPtr usbsrc = &dev->source.subsys.u.usb;
J
Jamie Strandboge 已提交
1120 1121
            switch (dev->source.subsys.type) {
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: {
1122
                virUSBDevicePtr usb =
1123
                    virUSBDeviceNew(usbsrc->bus, usbsrc->device, NULL);
1124 1125 1126 1127

                if (usb == NULL)
                    continue;

1128 1129 1130
                if (virHostdevFindUSBDevice(dev, true, &usb) < 0)
                    continue;

1131 1132
                rc = virUSBDeviceFileIterate(usb, file_iterate_hostdev_cb, &buf);
                virUSBDeviceFree(usb);
1133
                if (rc != 0)
1134
                    goto cleanup;
J
Jamie Strandboge 已提交
1135 1136
                break;
            }
1137

1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: {
                virDomainHostdevSubsysMediatedDevPtr mdevsrc = &dev->source.subsys.u.mdev;
                switch ((virMediatedDeviceModelType) mdevsrc->model) {
                    case VIR_MDEV_MODEL_TYPE_VFIO_PCI:
                    case VIR_MDEV_MODEL_TYPE_VFIO_AP:
                    case VIR_MDEV_MODEL_TYPE_VFIO_CCW:
                        needsVfio = true;
                        break;
                    case VIR_MDEV_MODEL_TYPE_LAST:
                    default:
                        virReportEnumRangeError(virMediatedDeviceModelType,
                                                mdevsrc->model);
                        break;
                }
                break;
            }

J
Jamie Strandboge 已提交
1155
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: {
1156
                virPCIDevicePtr pci = virPCIDeviceNew(
1157 1158 1159 1160
                           dev->source.subsys.u.pci.addr.domain,
                           dev->source.subsys.u.pci.addr.bus,
                           dev->source.subsys.u.pci.addr.slot,
                           dev->source.subsys.u.pci.addr.function);
J
Jamie Strandboge 已提交
1161

1162
                virDomainHostdevSubsysPCIBackendType backend = dev->source.subsys.u.pci.backend;
1163 1164 1165 1166 1167
                if (backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO ||
                        backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT) {
                    needsVfio = true;
                }

J
Jamie Strandboge 已提交
1168 1169 1170
                if (pci == NULL)
                    continue;

1171 1172
                rc = virPCIDeviceFileIterate(pci, file_iterate_pci_cb, &buf);
                virPCIDeviceFree(pci);
J
Jamie Strandboge 已提交
1173 1174 1175

                break;
            }
1176

J
Jamie Strandboge 已提交
1177 1178 1179 1180 1181 1182
            default:
                rc = 0;
                break;
            } /* switch */
        }

F
Felix Geyer 已提交
1183 1184 1185 1186 1187
    for (i = 0; i < ctl->def->nfss; i++) {
        if (ctl->def->fss[i] &&
                ctl->def->fss[i]->type == VIR_DOMAIN_FS_TYPE_MOUNT &&
                (ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_PATH ||
                 ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT) &&
1188
                ctl->def->fss[i]->src) {
F
Felix Geyer 已提交
1189 1190
            virDomainFSDefPtr fs = ctl->def->fss[i];

1191 1192 1193
            /* We don't need to add deny rw rules for readonly mounts,
             * this can only lead to troubles when mounting / readonly.
             */
1194
            if (vah_add_path(&buf, fs->src->path, fs->readonly ? "R" : "rw", true) != 0)
F
Felix Geyer 已提交
1195 1196 1197 1198
                goto cleanup;
        }
    }

1199 1200 1201 1202 1203 1204 1205 1206
    for (i = 0; i < ctl->def->ninputs; i++) {
        if (ctl->def->inputs[i] &&
                ctl->def->inputs[i]->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) {
            if (vah_add_file(&buf, ctl->def->inputs[i]->source.evdev, "rw") != 0)
                goto cleanup;
        }
    }

1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218
    for (i = 0; i < ctl->def->nnets; i++) {
        if (ctl->def->nets[i] &&
                ctl->def->nets[i]->type == VIR_DOMAIN_NET_TYPE_VHOSTUSER &&
                ctl->def->nets[i]->data.vhostuser) {
            virDomainChrSourceDefPtr vhu = ctl->def->nets[i]->data.vhostuser;

            if (vah_add_file_chardev(&buf, vhu->data.nix.path, "rw",
                       vhu->type) != 0)
                goto cleanup;
        }
    }

1219 1220 1221 1222 1223 1224 1225 1226
    for (i = 0; i < ctl->def->nmems; i++) {
        if (ctl->def->mems[i] &&
                ctl->def->mems[i]->model == VIR_DOMAIN_MEMORY_MODEL_NVDIMM) {
            if (vah_add_file(&buf, ctl->def->mems[i]->nvdimmPath, "rw") != 0)
                goto cleanup;
        }
    }

1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248
    if (ctl->def->tpm) {
        char *shortName = NULL;
        const char *tpmpath = NULL;

        switch (ctl->def->tpm->type) {
        case VIR_DOMAIN_TPM_TYPE_EMULATOR:
            shortName = virDomainDefGetShortName(ctl->def);

            switch (ctl->def->tpm->version) {
            case VIR_DOMAIN_TPM_VERSION_1_2:
                tpmpath = "tpm1.2";
                break;
            case VIR_DOMAIN_TPM_VERSION_2_0:
                tpmpath = "tpm2";
                break;
            case VIR_DOMAIN_TPM_VERSION_DEFAULT:
            case VIR_DOMAIN_TPM_VERSION_LAST:
                break;
            }

            /* Unix socket for QEMU and swtpm to use */
            virBufferAsprintf(&buf,
1249 1250
                "  \"%s/libvirt/qemu/swtpm/%s-swtpm.sock\" rw,\n",
                RUNSTATEDIR, shortName);
1251 1252 1253 1254
            /* Paths for swtpm to use: give it access to its state
             * directory, log, and PID files.
             */
            virBufferAsprintf(&buf,
1255
                "  \"%s/lib/libvirt/swtpm/%s/%s/**\" rwk,\n",
1256 1257
                LOCALSTATEDIR, uuidstr, tpmpath);
            virBufferAsprintf(&buf,
1258
                "  \"%s/log/swtpm/libvirt/qemu/%s-swtpm.log\" w,\n",
1259 1260
                LOCALSTATEDIR, ctl->def->name);
            virBufferAsprintf(&buf,
1261 1262
                "  \"%s/libvirt/qemu/swtpm/%s-swtpm.pid\" rw,\n",
                RUNSTATEDIR, shortName);
1263 1264 1265 1266 1267 1268 1269 1270 1271

            VIR_FREE(shortName);
            break;
        case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
        case VIR_DOMAIN_TPM_TYPE_LAST:
            break;
        }
    }

1272 1273 1274
    if (ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
        for (i = 0; i < ctl->def->nnets; i++) {
            virDomainNetDefPtr net = ctl->def->nets[i];
1275
            if (net && virDomainNetGetModelString(net)) {
1276 1277
                if (net->driver.virtio.name == VIR_DOMAIN_NET_BACKEND_TYPE_QEMU)
                    continue;
1278
                if (!virDomainNetIsVirtioModel(net))
1279 1280 1281 1282 1283 1284
                    continue;
            }
            needsvhost = true;
        }
    }
    if (needsvhost)
1285
        virBufferAddLit(&buf, "  \"/dev/vhost-net\" rw,\n");
1286

1287
    if (needsVfio) {
1288 1289
        virBufferAddLit(&buf, "  \"/dev/vfio/vfio\" rw,\n");
        virBufferAddLit(&buf, "  \"/dev/vfio/[0-9]*\" rw,\n");
1290
    }
1291 1292 1293 1294 1295 1296 1297 1298 1299 1300
    if (needsgl) {
        /* if using gl all sorts of further dri related paths will be needed */
        virBufferAddLit(&buf, "  # DRI/Mesa/(e)GL config and driver paths\n");
        virBufferAddLit(&buf, "  \"/usr/lib{,32,64}/dri/*.so*\" mr,\n");
        virBufferAddLit(&buf, "  \"/usr/lib/@{multiarch}/dri/*.so*\" mr,\n");
        virBufferAddLit(&buf, "  \"/usr/lib/fglrx/dri/*.so*\" mr,\n");
        virBufferAddLit(&buf, "  \"/etc/drirc\" r,\n");
        virBufferAddLit(&buf, "  \"/usr/share/drirc.d/{,*.conf}\" r,\n");
        virBufferAddLit(&buf, "  \"/etc/glvnd/egl_vendor.d/{,*}\" r,\n");
        virBufferAddLit(&buf, "  \"/usr/share/glvnd/egl_vendor.d/{,*}\" r,\n");
1301 1302 1303 1304 1305
        virBufferAddLit(&buf, "  \"/usr/share/egl/egl_external_platform.d/\" r,\n");
        virBufferAddLit(&buf, "  \"/usr/share/egl/egl_external_platform.d/*\" r,\n");
        virBufferAddLit(&buf, "  \"/proc/modules\" r,\n");
        virBufferAddLit(&buf, "  \"/proc/driver/nvidia/params\" r,\n");
        virBufferAddLit(&buf, "  \"/dev/nvidiactl\" rw,\n");
1306 1307
        virBufferAddLit(&buf, "  # Probe DRI device attributes\n");
        virBufferAddLit(&buf, "  \"/dev/dri/\" r,\n");
1308
        virBufferAddLit(&buf, "  \"/sys/devices/**/{uevent,vendor,device,subsystem_vendor,subsystem_device}\" r,\n");
1309 1310 1311
        virBufferAddLit(&buf, "  # dri libs will trigger that, but t is not requited and DAC would deny it anyway\n");
        virBufferAddLit(&buf, "  deny \"/var/lib/libvirt/.cache/\" w,\n");
    }
1312

1313
    if (ctl->newfile)
1314
        if (vah_add_file(&buf, ctl->newfile, "rwk") != 0)
1315
            goto cleanup;
J
Jamie Strandboge 已提交
1316 1317 1318 1319

    rc = 0;
    ctl->files = virBufferContentAndReset(&buf);

1320
 cleanup:
J
Jamie Strandboge 已提交
1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334
    VIR_FREE(uuid);
    return rc;
}

static int
vahParseArgv(vahControl * ctl, int argc, char **argv)
{
    int arg, idx = 0;
    struct option opt[] = {
        {"add", 0, 0, 'a'},
        {"create", 0, 0, 'c'},
        {"dryrun", 0, 0, 'd'},
        {"delete", 0, 0, 'D'},
        {"add-file", 0, 0, 'f'},
1335
        {"append-file", 0, 0, 'F'},
J
Jamie Strandboge 已提交
1336 1337 1338 1339 1340 1341 1342
        {"help", 0, 0, 'h'},
        {"replace", 0, 0, 'r'},
        {"remove", 0, 0, 'R'},
        {"uuid", 1, 0, 'u'},
        {0, 0, 0, 0}
    };

1343
    while ((arg = getopt_long(argc, argv, "acdDhrRH:b:u:p:f:F:", opt,
J
Jamie Strandboge 已提交
1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358
            &idx)) != -1) {
        switch (arg) {
            case 'a':
                ctl->cmd = 'a';
                break;
            case 'c':
                ctl->cmd = 'c';
                break;
            case 'd':
                ctl->dryrun = true;
                break;
            case 'D':
                ctl->cmd = 'D';
                break;
            case 'f':
1359
            case 'F':
1360
                ctl->newfile = g_strdup(optarg);
1361
                ctl->append = arg == 'F';
J
Jamie Strandboge 已提交
1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374
                break;
            case 'h':
                vah_usage();
                exit(EXIT_SUCCESS);
                break;
            case 'r':
                ctl->cmd = 'r';
                break;
            case 'R':
                ctl->cmd = 'R';
                break;
            case 'u':
                if (strlen(optarg) > PROFILE_NAME_SIZE - 1)
1375
                    vah_error(ctl, 1, _("invalid UUID"));
1376
                if (virStrcpy((char *)ctl->uuid, optarg,
1377
                    PROFILE_NAME_SIZE) < 0)
1378
                    vah_error(ctl, 1, _("error copying UUID"));
J
Jamie Strandboge 已提交
1379 1380
                break;
            default:
1381
                vah_error(ctl, 1, _("unsupported option"));
J
Jamie Strandboge 已提交
1382 1383 1384 1385
                break;
        }
    }
    if (strchr("acDrR", ctl->cmd) == NULL)
1386
        vah_error(ctl, 1, _("bad command"));
J
Jamie Strandboge 已提交
1387 1388

    if (valid_uuid(ctl->uuid) != 0)
1389
        vah_error(ctl, 1, _("invalid UUID"));
J
Jamie Strandboge 已提交
1390 1391 1392 1393 1394 1395 1396 1397 1398

    if (!ctl->cmd) {
        vah_usage();
        exit(EXIT_FAILURE);
    }

    if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *xmlStr = NULL;
        if (virFileReadLimFD(STDIN_FILENO, MAX_FILE_LEN, &xmlStr) < 0)
1399
            vah_error(ctl, 1, _("could not read xml file"));
J
Jamie Strandboge 已提交
1400 1401 1402

        if (get_definition(ctl, xmlStr) != 0 || ctl->def == NULL) {
            VIR_FREE(xmlStr);
1403
            vah_error(ctl, 1, _("could not get VM definition"));
J
Jamie Strandboge 已提交
1404 1405 1406 1407
        }
        VIR_FREE(xmlStr);

        if (get_files(ctl) != 0)
1408
            vah_error(ctl, 1, _("invalid VM definition"));
J
Jamie Strandboge 已提交
1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426
    }
    return 0;
}


/*
 * virt-aa-helper -c -u UUID < file.xml
 * virt-aa-helper -r -u UUID [-f <file>] < file.xml
 * virt-aa-helper -a -u UUID
 * virt-aa-helper -R -u UUID
 * virt-aa-helper -D -u UUID
 */
int
main(int argc, char **argv)
{
    vahControl _ctl, *ctl = &_ctl;
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
1427 1428
    char *profile = NULL;
    char *include_file = NULL;
J
Jamie Strandboge 已提交
1429

1430
    if (virGettextInitialize() < 0 ||
1431 1432 1433 1434 1435
        virErrorInitialize() < 0) {
        fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
        exit(EXIT_FAILURE);
    }

1436
    virFileActivateDirOverrideForProg(argv[0]);
1437

1438 1439 1440
    /* Initialize the log system */
    virLogSetFromEnv();

J
Jamie Strandboge 已提交
1441 1442
    /* clear the environment */
    environ = NULL;
1443
    if (setenv("PATH", "/sbin:/usr/sbin", 1) != 0)
1444 1445
        vah_error(ctl, 1, _("could not set PATH"));

1446
    /* ensure the traditional IFS setting */
1447
    if (setenv("IFS", " \t\n", 1) != 0)
1448
        vah_error(ctl, 1, _("could not set IFS"));
J
Jamie Strandboge 已提交
1449 1450 1451 1452 1453 1454 1455 1456 1457

    if (!(progname = strrchr(argv[0], '/')))
        progname = argv[0];
    else
        progname++;

    memset(ctl, 0, sizeof(vahControl));

    if (vahParseArgv(ctl, argc, argv) != 0)
1458
        vah_error(ctl, 1, _("could not parse arguments"));
J
Jamie Strandboge 已提交
1459

1460 1461
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1462
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1463

1464 1465
    if (virAsprintfQuiet(&include_file, "%s/%s.files",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1466
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1467

1468
    if (ctl->cmd == 'a') {
J
Jamie Strandboge 已提交
1469
        rc = parserLoad(ctl->uuid);
1470
    } else if (ctl->cmd == 'R' || ctl->cmd == 'D') {
J
Jamie Strandboge 已提交
1471 1472 1473 1474 1475 1476 1477 1478
        rc = parserRemove(ctl->uuid);
        if (ctl->cmd == 'D') {
            unlink(include_file);
            unlink(profile);
        }
    } else if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *included_files = NULL;

1479
        if (ctl->cmd == 'c' && virFileExists(profile))
1480
            vah_error(ctl, 1, _("profile exists"));
J
Jamie Strandboge 已提交
1481

1482
        if (ctl->append && ctl->newfile) {
1483
            if (vah_add_file(&buf, ctl->newfile, "rwk") != 0)
1484
                goto cleanup;
1485
        } else {
1486 1487 1488
            if (ctl->def->virtType == VIR_DOMAIN_VIRT_QEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KQEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
1489 1490
                virBufferAsprintf(&buf, "  \"%s/log/libvirt/**/%s.log\" w,\n",
                                  LOCALSTATEDIR, ctl->def->name);
1491
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%s/monitor.sock\" rw,\n",
1492
                                  LOCALSTATEDIR, ctl->def->name);
1493 1494
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%d-%.*s/*\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->id, 20, ctl->def->name);
1495 1496 1497 1498
                virBufferAsprintf(&buf, "  \"%s/libvirt/**/%s.pid\" rwk,\n",
                                  RUNSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"%s/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  RUNSTATEDIR, ctl->def->name);
1499
            }
1500
            if (ctl->files)
1501
                virBufferAdd(&buf, ctl->files, -1);
1502
        }
J
Jamie Strandboge 已提交
1503 1504 1505 1506 1507 1508 1509 1510

        included_files = virBufferContentAndReset(&buf);

        /* (re)create the include file using included_files */
        if (ctl->dryrun) {
            vah_info(include_file);
            vah_info(included_files);
            rc = 0;
1511 1512 1513
        } else if (ctl->def->virtType == VIR_DOMAIN_VIRT_LXC) {
            rc = 0;
        } else if ((rc = update_include_file(include_file,
1514
                                             included_files,
1515
                                             ctl->append)) != 0) {
1516
            goto cleanup;
1517
        }
J
Jamie Strandboge 已提交
1518 1519 1520 1521 1522


        /* create the profile from TEMPLATE */
        if (ctl->cmd == 'c') {
            char *tmp = NULL;
1523 1524
            if (virAsprintfQuiet(&tmp, "  #include <libvirt/%s.files>\n",
                                 ctl->uuid) == -1) {
1525
                vah_error(ctl, 0, _("could not allocate memory"));
1526
                goto cleanup;
J
Jamie Strandboge 已提交
1527 1528 1529 1530 1531 1532 1533
            }

            if (ctl->dryrun) {
                vah_info(profile);
                vah_info(ctl->uuid);
                vah_info(tmp);
                rc = 0;
1534 1535
            } else if ((rc = create_profile(profile, ctl->uuid, tmp,
                                            ctl->def->virtType)) != 0) {
1536
                vah_error(ctl, 0, _("could not create profile"));
J
Jamie Strandboge 已提交
1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554
                unlink(include_file);
            }
            VIR_FREE(tmp);
        }

        if (rc == 0 && !ctl->dryrun) {
            if (ctl->cmd == 'c')
                rc = parserLoad(ctl->uuid);
            else
                rc = parserReplace(ctl->uuid);

            /* cleanup */
            if (rc != 0) {
                unlink(include_file);
                if (ctl->cmd == 'c')
                    unlink(profile);
            }
        }
1555
      cleanup:
J
Jamie Strandboge 已提交
1556 1557 1558 1559
        VIR_FREE(included_files);
    }

    vahDeinit(ctl);
1560 1561 1562 1563

    VIR_FREE(profile);
    VIR_FREE(include_file);

J
Jamie Strandboge 已提交
1564 1565
    exit(rc == 0 ? EXIT_SUCCESS : EXIT_FAILURE);
}