virt-aa-helper.c 47.9 KB
Newer Older
J
Jamie Strandboge 已提交
1 2
/*
 * virt-aa-helper: wrapper program used by AppArmor security driver.
3
 *
4
 * Copyright (C) 2010-2014 Red Hat, Inc.
5
 * Copyright (C) 2009-2011 Canonical Ltd.
J
Jamie Strandboge 已提交
6
 *
O
Osier Yang 已提交
7 8 9 10 11 12 13 14 15 16 17
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
J
Jamie Strandboge 已提交
20 21 22 23 24 25 26 27 28 29 30 31
 */

#include <config.h>

#include <stdarg.h>
#include <unistd.h>
#include <sys/types.h>
#include <fcntl.h>
#include <getopt.h>
#include <sys/utsname.h>

#include "internal.h"
32
#include "virbuffer.h"
33
#include "viralloc.h"
34
#include "vircommand.h"
35
#include "virlog.h"
36
#include "dirname.h"
37
#include "driver.h"
J
Jamie Strandboge 已提交
38 39 40 41

#include "security_driver.h"
#include "security_apparmor.h"
#include "domain_conf.h"
42
#include "virxml.h"
43
#include "viruuid.h"
44
#include "virusb.h"
45
#include "virpci.h"
E
Eric Blake 已提交
46
#include "virfile.h"
47
#include "configmake.h"
48
#include "virrandom.h"
49
#include "virstring.h"
50
#include "virgettext.h"
51
#include "virhostdev.h"
J
Jamie Strandboge 已提交
52

53 54
#define VIR_FROM_THIS VIR_FROM_SECURITY

J
Jamie Strandboge 已提交
55 56 57 58 59 60 61 62 63 64 65 66
static char *progname;

typedef struct {
    char uuid[PROFILE_NAME_SIZE];       /* UUID of vm */
    bool dryrun;                /* dry run */
    char cmd;                   /* 'c'   create
                                 * 'a'   add (load)
                                 * 'r'   replace
                                 * 'R'   remove */
    char *files;                /* list of files */
    virDomainDefPtr def;        /* VM definition */
    virCapsPtr caps;            /* VM capabilities */
67
    virDomainXMLOptionPtr xmlopt; /* XML parser data */
68
    char *virtType;                  /* type of hypervisor (eg qemu, xen, lxc) */
69
    char *os;                   /* type of os (eg hvm, xen, exe) */
70
    virArch arch;               /* machine architecture */
71 72
    char *newfile;              /* newly added file */
    bool append;                /* append to .files instead of rewrite */
J
Jamie Strandboge 已提交
73 74 75 76 77 78 79 80 81
} vahControl;

static int
vahDeinit(vahControl * ctl)
{
    if (ctl == NULL)
        return -1;

    VIR_FREE(ctl->def);
82
    virObjectUnref(ctl->caps);
83
    virObjectUnref(ctl->xmlopt);
84
    VIR_FREE(ctl->files);
85
    VIR_FREE(ctl->virtType);
86
    VIR_FREE(ctl->os);
87
    VIR_FREE(ctl->newfile);
J
Jamie Strandboge 已提交
88 89 90 91 92 93 94 95 96 97

    return 0;
}

/*
 * Print usage
 */
static void
vah_usage(void)
{
98 99 100 101
    printf(_("\n%s [options] [< def.xml]\n\n"
            "  Options:\n"
            "    -a | --add                     load profile\n"
            "    -c | --create                  create profile from template\n"
102
            "    -d | --dryrun                  dry run\n"
103 104 105 106 107 108 109 110 111 112 113
            "    -D | --delete                  unload and delete profile\n"
            "    -f | --add-file <file>         add file to profile\n"
            "    -F | --append-file <file>      append file to profile\n"
            "    -r | --replace                 reload profile\n"
            "    -R | --remove                  unload profile\n"
            "    -h | --help                    this help\n"
            "    -u | --uuid <uuid>             uuid (profile name)\n"
            "\n"), progname);

    puts(_("This command is intended to be used by libvirtd "
           "and not used directly.\n"));
J
Jamie Strandboge 已提交
114 115 116 117 118 119
    return;
}

static void
vah_error(vahControl * ctl, int doexit, const char *str)
{
120
    fprintf(stderr, _("%s: error: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
121 122 123 124 125 126 127 128 129 130 131

    if (doexit) {
        if (ctl != NULL)
            vahDeinit(ctl);
        exit(EXIT_FAILURE);
    }
}

static void
vah_warning(const char *str)
{
132
    fprintf(stderr, _("%s: warning: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
133 134 135 136 137
}

static void
vah_info(const char *str)
{
138
    fprintf(stderr, _("%s:\n%s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
139 140 141 142 143 144 145 146
}

/*
 * run an apparmor_parser command
 */
static int
parserCommand(const char *profile_name, const char cmd)
{
147
    int result = -1;
J
Jamie Strandboge 已提交
148
    char flag[3];
149
    char *profile;
150 151
    int status;
    int ret;
J
Jamie Strandboge 已提交
152 153

    if (strchr("arR", cmd) == NULL) {
154
        vah_error(NULL, 0, _("invalid flag"));
J
Jamie Strandboge 已提交
155 156 157 158 159
        return -1;
    }

    snprintf(flag, 3, "-%c", cmd);

160 161
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", profile_name) < 0) {
162
        vah_error(NULL, 0, _("profile name exceeds maximum length"));
J
Jamie Strandboge 已提交
163 164 165 166
        return -1;
    }

    if (!virFileExists(profile)) {
167
        vah_error(NULL, 0, _("profile does not exist"));
168
        goto cleanup;
J
Jamie Strandboge 已提交
169 170 171 172
    } else {
        const char * const argv[] = {
            "/sbin/apparmor_parser", flag, profile, NULL
        };
173 174 175
        if ((ret = virRun(argv, &status)) != 0 ||
            (WIFEXITED(status) && WEXITSTATUS(status) != 0)) {
            if (ret != 0) {
176
                vah_error(NULL, 0, _("failed to run apparmor_parser"));
177
                goto cleanup;
178 179 180
            } else if (cmd == 'R' && WIFEXITED(status) &&
                       WEXITSTATUS(status) == 234) {
                vah_warning(_("unable to unload already unloaded profile"));
181
            } else {
182
                vah_error(NULL, 0, _("apparmor_parser exited with error"));
183
                goto cleanup;
184
            }
J
Jamie Strandboge 已提交
185 186 187
        }
    }

188 189
    result = 0;

190
 cleanup:
191 192 193
    VIR_FREE(profile);

    return result;
J
Jamie Strandboge 已提交
194 195 196 197 198 199
}

/*
 * Update the dynamic files
 */
static int
200 201
update_include_file(const char *include_file, const char *included_files,
                    bool append)
J
Jamie Strandboge 已提交
202 203
{
    int rc = -1;
204
    int plen, flen = 0;
J
Jamie Strandboge 已提交
205 206
    int fd;
    char *pcontent = NULL;
207
    char *existing = NULL;
J
Jamie Strandboge 已提交
208 209 210
    const char *warning =
         "# DO NOT EDIT THIS FILE DIRECTLY. IT IS MANAGED BY LIBVIRT.\n";

211 212 213 214 215 216 217
    if (virFileExists(include_file)) {
        flen = virFileReadAll(include_file, MAX_FILE_LEN, &existing);
        if (flen < 0)
            return rc;
    }

    if (append && virFileExists(include_file)) {
218
        if (virAsprintfQuiet(&pcontent, "%s%s", existing, included_files) == -1) {
219
            vah_error(NULL, 0, _("could not allocate memory for profile"));
220
            goto cleanup;
221 222
        }
    } else {
223
        if (virAsprintfQuiet(&pcontent, "%s%s", warning, included_files) == -1) {
224
            vah_error(NULL, 0, _("could not allocate memory for profile"));
225
            goto cleanup;
226
        }
J
Jamie Strandboge 已提交
227 228 229 230
    }

    plen = strlen(pcontent);
    if (plen > MAX_FILE_LEN) {
231
        vah_error(NULL, 0, _("invalid length for new profile"));
232
        goto cleanup;
J
Jamie Strandboge 已提交
233 234 235
    }

    /* only update the disk profile if it is different */
236 237
    if (flen > 0 && flen == plen && STREQLEN(existing, pcontent, plen)) {
        rc = 0;
238
        goto cleanup;
J
Jamie Strandboge 已提交
239 240 241 242
    }

    /* write the file */
    if ((fd = open(include_file, O_CREAT | O_TRUNC | O_WRONLY, 0644)) == -1) {
243
        vah_error(NULL, 0, _("failed to create include file"));
244
        goto cleanup;
J
Jamie Strandboge 已提交
245 246 247
    }

    if (safewrite(fd, pcontent, plen) < 0) { /* don't write the '\0' */
248
        VIR_FORCE_CLOSE(fd);
249
        vah_error(NULL, 0, _("failed to write to profile"));
250
        goto cleanup;
J
Jamie Strandboge 已提交
251 252
    }

253
    if (VIR_CLOSE(fd) != 0) {
254
        vah_error(NULL, 0, _("failed to close or write to profile"));
255
        goto cleanup;
J
Jamie Strandboge 已提交
256 257 258
    }
    rc = 0;

259
 cleanup:
J
Jamie Strandboge 已提交
260
    VIR_FREE(pcontent);
261
    VIR_FREE(existing);
J
Jamie Strandboge 已提交
262 263 264 265 266 267 268 269 270

    return rc;
}

/*
 * Create a profile based on a template
 */
static int
create_profile(const char *profile, const char *profile_name,
271
               const char *profile_files, int virtType)
J
Jamie Strandboge 已提交
272
{
273
    char *template;
J
Jamie Strandboge 已提交
274 275 276 277
    char *tcontent = NULL;
    char *pcontent = NULL;
    char *replace_name = NULL;
    char *replace_files = NULL;
278
    char *tmp = NULL;
J
Jamie Strandboge 已提交
279 280 281 282 283
    const char *template_name = "\nprofile LIBVIRT_TEMPLATE";
    const char *template_end = "\n}";
    int tlen, plen;
    int fd;
    int rc = -1;
284
    const char *driver_name = NULL;
J
Jamie Strandboge 已提交
285 286

    if (virFileExists(profile)) {
287
        vah_error(NULL, 0, _("profile exists"));
J
Jamie Strandboge 已提交
288 289 290
        goto end;
    }

291 292 293 294 295 296 297 298 299
    switch (virtType) {
    case VIR_DOMAIN_VIRT_QEMU:
    case VIR_DOMAIN_VIRT_KQEMU:
    case VIR_DOMAIN_VIRT_KVM:
        driver_name = "qemu";
        break;
    default:
        driver_name = virDomainVirtTypeToString(virtType);
    }
C
Cédric Bosdonnat 已提交
300 301

    if (virAsprintfQuiet(&template, "%s/TEMPLATE.%s", APPARMOR_DIR "/libvirt",
302
                         driver_name) < 0) {
303
        vah_error(NULL, 0, _("template name exceeds maximum length"));
J
Jamie Strandboge 已提交
304 305 306 307
        goto end;
    }

    if (!virFileExists(template)) {
308
        vah_error(NULL, 0, _("template does not exist"));
J
Jamie Strandboge 已提交
309 310 311 312
        goto end;
    }

    if ((tlen = virFileReadAll(template, MAX_FILE_LEN, &tcontent)) < 0) {
313
        vah_error(NULL, 0, _("failed to read AppArmor template"));
J
Jamie Strandboge 已提交
314 315 316 317
        goto end;
    }

    if (strstr(tcontent, template_name) == NULL) {
318
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
319 320 321 322
        goto clean_tcontent;
    }

    if (strstr(tcontent, template_end) == NULL) {
323
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
324 325 326 327
        goto clean_tcontent;
    }

    /* '\nprofile <profile_name>\0' */
328
    if (virAsprintfQuiet(&replace_name, "\nprofile %s", profile_name) == -1) {
329
        vah_error(NULL, 0, _("could not allocate memory for profile name"));
J
Jamie Strandboge 已提交
330 331 332 333
        goto clean_tcontent;
    }

    /* '\n<profile_files>\n}\0' */
334 335
    if ((virtType != VIR_DOMAIN_VIRT_LXC) &&
            virAsprintfQuiet(&replace_files, "\n%s\n}", profile_files) == -1) {
336
        vah_error(NULL, 0, _("could not allocate memory for profile files"));
J
Jamie Strandboge 已提交
337 338 339 340
        VIR_FREE(replace_name);
        goto clean_tcontent;
    }

C
Cédric Bosdonnat 已提交
341
    plen = tlen + strlen(replace_name) - strlen(template_name) + 1;
342 343 344 345

    if (virtType != VIR_DOMAIN_VIRT_LXC)
        plen += strlen(replace_files) - strlen(template_end);

J
Jamie Strandboge 已提交
346
    if (plen > MAX_FILE_LEN || plen < tlen) {
347
        vah_error(NULL, 0, _("invalid length for new profile"));
J
Jamie Strandboge 已提交
348 349 350
        goto clean_replace;
    }

351
    if (!(pcontent = virStringReplace(tcontent, template_name, replace_name)))
J
Jamie Strandboge 已提交
352 353
        goto clean_all;

354 355 356 357
    if (virtType != VIR_DOMAIN_VIRT_LXC) {
        if (!(tmp = virStringReplace(pcontent, template_end, replace_files)))
            goto clean_all;
        VIR_FREE(pcontent);
358
        VIR_STEAL_PTR(pcontent, tmp);
359
    }
J
Jamie Strandboge 已提交
360 361 362

    /* write the file */
    if ((fd = open(profile, O_CREAT | O_EXCL | O_WRONLY, 0644)) == -1) {
363
        vah_error(NULL, 0, _("failed to create profile"));
J
Jamie Strandboge 已提交
364 365 366 367
        goto clean_all;
    }

    if (safewrite(fd, pcontent, plen - 1) < 0) { /* don't write the '\0' */
368
        VIR_FORCE_CLOSE(fd);
369
        vah_error(NULL, 0, _("failed to write to profile"));
J
Jamie Strandboge 已提交
370 371 372
        goto clean_all;
    }

373
    if (VIR_CLOSE(fd) != 0) {
374
        vah_error(NULL, 0, _("failed to close or write to profile"));
J
Jamie Strandboge 已提交
375 376 377 378
        goto clean_all;
    }
    rc = 0;

379
 clean_all:
J
Jamie Strandboge 已提交
380
    VIR_FREE(pcontent);
381
 clean_replace:
J
Jamie Strandboge 已提交
382 383
    VIR_FREE(replace_name);
    VIR_FREE(replace_files);
384
 clean_tcontent:
J
Jamie Strandboge 已提交
385
    VIR_FREE(tcontent);
386
 end:
387
    VIR_FREE(template);
J
Jamie Strandboge 已提交
388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439
    return rc;
}

/*
 * Load an existing profile
 */
static int
parserLoad(const char *profile_name)
{
    return parserCommand(profile_name, 'a');
}

/*
 * Remove an existing profile
 */
static int
parserRemove(const char *profile_name)
{
    return parserCommand(profile_name, 'R');
}

/*
 * Replace an existing profile
 */
static int
parserReplace(const char *profile_name)
{
    return parserCommand(profile_name, 'r');
}

static int
valid_uuid(const char *uuid)
{
    unsigned char rawuuid[VIR_UUID_BUFLEN];

    if (strlen(uuid) != PROFILE_NAME_SIZE - 1)
        return -1;

    if (!STRPREFIX(uuid, AA_PREFIX))
        return -1;

    if (virUUIDParse(uuid + strlen(AA_PREFIX), rawuuid) < 0)
        return -1;

    return 0;
}

static int
valid_name(const char *name)
{
    /* just try to filter out any dangerous characters in the name that can be
     * used to subvert the profile */
440
    const char *bad = "/[]{}?^,\"*";
J
Jamie Strandboge 已提交
441

442
    if (strlen(name) == 0)
J
Jamie Strandboge 已提交
443 444 445 446 447 448 449 450 451 452 453 454
        return -1;

    if (strcspn(name, bad) != strlen(name))
        return -1;

    return 0;
}

/* see if one of the strings in arr starts with str */
static int
array_starts_with(const char *str, const char * const *arr, const long size)
{
455
    size_t i;
J
Jamie Strandboge 已提交
456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503
    for (i = 0; i < size; i++) {
        if (strlen(str) < strlen(arr[i]))
            continue;

        if (STRPREFIX(str, arr[i]))
            return 0;
    }
    return 1;
}

/*
 * Don't allow access to special files or restricted paths such as /bin, /sbin,
 * /usr/bin, /usr/sbin and /etc. This is in an effort to prevent read/write
 * access to system files which could be used to elevate privileges. This is a
 * safety measure in case libvirtd is under a restrictive profile and is
 * subverted and trying to escape confinement.
 *
 * Note that we cannot exclude block devices because they are valid devices.
 * The TEMPLATE file can be adjusted to explicitly disallow these if needed.
 *
 * RETURN: -1 on error, 0 if ok, 1 if blocked
 */
static int
valid_path(const char *path, const bool readonly)
{
    const char * const restricted[] = {
        "/bin/",
        "/etc/",
        "/lib",
        "/lost+found/",
        "/proc/",
        "/sbin/",
        "/selinux/",
        "/sys/",
        "/usr/bin/",
        "/usr/lib",
        "/usr/sbin/",
        "/usr/share/",
        "/usr/local/bin/",
        "/usr/local/etc/",
        "/usr/local/lib",
        "/usr/local/sbin/"
    };
    /* these paths are ok for readonly, but not read/write */
    const char * const restricted_rw[] = {
        "/boot/",
        "/vmlinuz",
        "/initrd",
504
        "/initrd.img",
505
        "/usr/share/OVMF/",              /* for OVMF images */
506 507
        "/usr/share/ovmf/",              /* for OVMF images */
        "/usr/share/AAVMF/",             /* for AAVMF images */
508 509
        "/usr/share/qemu-efi/",          /* for AAVMF images */
        "/usr/share/qemu-efi-aarch64/"   /* for AAVMF images */
J
Jamie Strandboge 已提交
510
    };
511 512
    /* override the above with these */
    const char * const override[] = {
J
John Ferlan 已提交
513
        "/sys/devices/pci",              /* for hostdev pci devices */
514
        "/etc/libvirt-sandbox/services/" /* for virt-sandbox service config */
515
    };
J
Jamie Strandboge 已提交
516

517 518 519 520
    const int nropaths = ARRAY_CARDINALITY(restricted);
    const int nrwpaths = ARRAY_CARDINALITY(restricted_rw);
    const int nopaths = ARRAY_CARDINALITY(override);

521
    if (path == NULL) {
522
        vah_error(NULL, 0, _("bad pathname"));
J
Jamie Strandboge 已提交
523 524 525 526 527 528 529 530 531
        return -1;
    }

    /* Don't allow double quotes, since we use them to quote the filename
     * and this will confuse the apparmor parser.
     */
    if (strchr(path, '"') != NULL)
        return 1;

J
Jamie Strandboge 已提交
532 533 534 535
    /* Require an absolute path */
    if (STRNEQLEN(path, "/", 1))
        return 1;

536
    if (!virFileExists(path))
537
        vah_warning(_("path does not exist, skipping file type checks"));
J
Jamie Strandboge 已提交
538

539
    /* overrides are always allowed */
540
    if (array_starts_with(path, override, nopaths) == 0)
541
        return 0;
J
Jamie Strandboge 已提交
542

543 544
    /* allow read only paths upfront */
    if (readonly) {
545
        if (array_starts_with(path, restricted_rw, nrwpaths) == 0)
546
            return 0;
J
Jamie Strandboge 已提交
547 548
    }

549
    /* disallow RW access to all paths in restricted and restriced_rw */
550 551
    if ((array_starts_with(path, restricted, nropaths) == 0 ||
         array_starts_with(path, restricted_rw, nrwpaths) == 0))
552 553
        return 1;

J
Jamie Strandboge 已提交
554 555 556
    return 0;
}

557 558 559 560 561 562 563
static int
verify_xpath_context(xmlXPathContextPtr ctxt)
{
    int rc = -1;
    char *tmp = NULL;

    if (!ctxt) {
564
        vah_warning(_("Invalid context"));
565 566 567 568 569
        goto error;
    }

    /* check if have <name> */
    if (!(tmp = virXPathString("string(./name[1])", ctxt))) {
570
        vah_warning(_("Could not find <name>"));
571 572 573 574 575 576
        goto error;
    }
    VIR_FREE(tmp);

    /* check if have <uuid> */
    if (!(tmp = virXPathString("string(./uuid[1])", ctxt))) {
577
        vah_warning(_("Could not find <uuid>"));
578 579 580 581 582 583
        goto error;
    }
    VIR_FREE(tmp);

    rc = 0;

584
 error:
585 586 587
    return rc;
}

588 589
/*
 * Parse the xml we received to fill in the following:
590
 * ctl->virtType
591
 * ctl->os
592 593 594 595 596 597 598 599 600 601
 * ctl->arch
 *
 * These are suitable for setting up a virCapsPtr
 */
static int
caps_mockup(vahControl * ctl, const char *xmlStr)
{
    int rc = -1;
    xmlDocPtr xml = NULL;
    xmlXPathContextPtr ctxt = NULL;
602
    char *arch;
603

604
    if (!(xml = virXMLParseStringCtxt(xmlStr, _("(domain_definition)"),
605
                                      &ctxt))) {
606 607 608
        goto cleanup;
    }

609
    if (!virXMLNodeNameEqual(ctxt->node, "domain")) {
610
        vah_error(NULL, 0, _("unexpected root element, expecting <domain>"));
611 612 613
        goto cleanup;
    }

614 615 616 617
    /* Quick sanity check for some required elements */
    if (verify_xpath_context(ctxt) != 0)
        goto cleanup;

618 619 620 621 622
    ctl->virtType = virXPathString("string(./@type)", ctxt);
    if (!ctl->virtType) {
        vah_error(ctl, 0, _("domain type is not defined"));
        goto cleanup;
    }
623 624
    ctl->os = virXPathString("string(./os/type[1])", ctxt);
    if (!ctl->os) {
625
        vah_error(ctl, 0, _("os.type is not defined"));
626 627
        goto cleanup;
    }
628 629 630 631 632 633
    arch = virXPathString("string(./os/type[1]/@arch)", ctxt);
    if (!arch) {
        ctl->arch = virArchFromHost();
    } else {
        ctl->arch = virArchFromString(arch);
        VIR_FREE(arch);
634 635 636 637
    }

    rc = 0;

638
 cleanup:
639
    xmlFreeDoc(xml);
640 641 642 643 644
    xmlXPathFreeContext(ctxt);

    return rc;
}

645 646 647 648 649
virDomainDefParserConfig virAAHelperDomainDefParserConfig = {
    .features = VIR_DOMAIN_DEF_FEATURE_MEMORY_HOTPLUG |
                VIR_DOMAIN_DEF_FEATURE_OFFLINE_VCPUPIN |
                VIR_DOMAIN_DEF_FEATURE_INDIVIDUAL_VCPUS,
};
650

J
Jamie Strandboge 已提交
651 652 653
static int
get_definition(vahControl * ctl, const char *xmlStr)
{
654
    int rc = -1, ostype, virtType;
J
Jamie Strandboge 已提交
655 656 657 658 659 660
    virCapsGuestPtr guest;  /* this is freed when caps is freed */

    /*
     * mock up some capabilities. We don't currently use these explicitly,
     * but need them for virDomainDefParseString().
     */
661 662
    if (caps_mockup(ctl, xmlStr) != 0)
        goto exit;
J
Jamie Strandboge 已提交
663

664
    if ((ctl->caps = virCapabilitiesNew(ctl->arch, true, true)) == NULL) {
665
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
666 667 668
        goto exit;
    }

669 670
    if (!(ctl->xmlopt = virDomainXMLOptionNew(&virAAHelperDomainDefParserConfig,
                                              NULL, NULL, NULL, NULL))) {
671 672 673 674
        vah_error(ctl, 0, _("Failed to create XML config object"));
        goto exit;
    }

675
    if ((ostype = virDomainOSTypeFromString(ctl->os)) < 0) {
676 677 678 679
        vah_error(ctl, 0, _("unknown OS type"));
        goto exit;
    }

J
Jamie Strandboge 已提交
680
    if ((guest = virCapabilitiesAddGuest(ctl->caps,
681
                                         ostype,
682
                                         ctl->arch,
J
Jamie Strandboge 已提交
683 684 685 686
                                         NULL,
                                         NULL,
                                         0,
                                         NULL)) == NULL) {
687
        vah_error(ctl, 0, _("could not allocate memory"));
688 689 690 691 692 693 694 695 696 697 698 699 700 701 702
        goto exit;
    }

    if ((virtType = virDomainVirtTypeFromString(ctl->virtType)) < 0) {
        vah_error(ctl, 0, _("unknown virtualization type"));
        goto exit;
    }

    if (virCapabilitiesAddGuestDomain(guest,
                                      virtType,
                                      NULL,
                                      NULL,
                                      0,
                                      NULL) == NULL) {
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
703 704 705
        goto exit;
    }

706
    ctl->def = virDomainDefParseString(xmlStr,
707
                                       ctl->caps, ctl->xmlopt, NULL,
708
                                       VIR_DOMAIN_DEF_PARSE_SKIP_SECLABEL |
709
                                       VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE);
710

J
Jamie Strandboge 已提交
711
    if (ctl->def == NULL) {
712
        vah_error(ctl, 0, _("could not parse XML"));
J
Jamie Strandboge 已提交
713 714 715 716
        goto exit;
    }

    if (!ctl->def->name) {
717
        vah_error(ctl, 0, _("could not find name in XML"));
J
Jamie Strandboge 已提交
718 719 720 721
        goto exit;
    }

    if (valid_name(ctl->def->name) != 0) {
722
        vah_error(ctl, 0, _("bad name"));
J
Jamie Strandboge 已提交
723 724 725 726 727
        goto exit;
    }

    rc = 0;

728
 exit:
J
Jamie Strandboge 已提交
729 730 731
    return rc;
}

732 733 734 735
/**
  * The permissions allowed are apparmor valid permissions and 'R'. 'R' stands for
  * read with no explicit deny rule.
  */
J
Jamie Strandboge 已提交
736
static int
F
Felix Geyer 已提交
737
vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool recursive)
J
Jamie Strandboge 已提交
738 739 740 741
{
    char *tmp = NULL;
    int rc = -1;
    bool readonly = true;
742 743
    bool explicit_deny_rule = true;
    char *sub = NULL;
744
    char *perms_new = NULL;
745 746 747
    char *pathdir = NULL;
    char *pathtmp = NULL;
    char *pathreal = NULL;
J
Jamie Strandboge 已提交
748 749 750 751

    if (path == NULL)
        return rc;

J
Jamie Strandboge 已提交
752 753 754 755 756 757
    /* Skip files without an absolute path. Not having one confuses the
     * apparmor parser and this also ensures things like tcp consoles don't
     * get added to the profile.
     */
    if (STRNEQLEN(path, "/", 1)) {
        vah_warning(path);
758
        vah_warning(_("skipped non-absolute path"));
J
Jamie Strandboge 已提交
759 760 761
        return 0;
    }

762 763 764 765 766 767 768
    /* files might be created by qemu later on and not exist right now.
     * But realpath needs a valid path to work on, therefore:
     * 1. walk the path to find longest valid path
     * 2. get the realpath of that valid path
     * 3. re-combine the realpath with the remaining suffix
     * Note: A totally non existent path is used as-is
     */
769
     if (VIR_STRDUP_QUIET(pathdir, path) < 0)
770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788
         goto cleanup;
     while (!virFileExists(pathdir)) {
         if ((pathtmp = mdir_name(pathdir)) == NULL)
             goto cleanup;
         VIR_FREE(pathdir);
         VIR_STEAL_PTR(pathdir, pathtmp);
     }

    if (strlen(pathdir) == 1) {
        /* nothing of the path does exist yet */
        if (VIR_STRDUP_QUIET(tmp, path) < 0)
            goto cleanup;
    } else {
        if (VIR_STRDUP_QUIET(pathtmp, path+strlen(pathdir)) < 0)
            goto cleanup;
        if ((pathreal = realpath(pathdir, NULL)) == NULL) {
            vah_error(NULL, 0, pathdir);
            vah_error(NULL, 0, _("could not find realpath"));
            goto cleanup;
J
Jamie Strandboge 已提交
789
        }
790 791
        if (virAsprintfQuiet(&tmp, "%s%s", pathreal, pathtmp) < 0)
            goto cleanup;
792
    }
J
Jamie Strandboge 已提交
793

794
    if (VIR_STRDUP_QUIET(perms_new, perms) < 0)
795
        goto cleanup;
796 797

    if (strchr(perms_new, 'w') != NULL) {
J
Jamie Strandboge 已提交
798
        readonly = false;
799 800 801
        explicit_deny_rule = false;
    }

802
    if ((sub = strchr(perms_new, 'R')) != NULL) {
803 804 805 806
        /* Don't write the invalid R permission, replace it with 'r' */
        sub[0] = 'r';
        explicit_deny_rule = false;
    }
J
Jamie Strandboge 已提交
807 808 809 810 811

    rc = valid_path(tmp, readonly);
    if (rc != 0) {
        if (rc > 0) {
            vah_error(NULL, 0, path);
812
            vah_error(NULL, 0, _("skipped restricted file"));
J
Jamie Strandboge 已提交
813
        }
814
        goto cleanup;
J
Jamie Strandboge 已提交
815 816
    }

817 818 819
    if (tmp[strlen(tmp) - 1] == '/')
        tmp[strlen(tmp) - 1] = '\0';

820 821
    virBufferAsprintf(buf, "  \"%s%s\" %s,\n", tmp, recursive ? "/**" : "",
                      perms_new);
822
    if (explicit_deny_rule) {
823
        virBufferAddLit(buf, "  # don't audit writes to readonly files\n");
F
Felix Geyer 已提交
824 825 826 827 828
        virBufferAsprintf(buf, "  deny \"%s%s\" w,\n", tmp, recursive ? "/**" : "");
    }
    if (recursive) {
        /* allow reading (but not creating) the dir */
        virBufferAsprintf(buf, "  \"%s/\" r,\n", tmp);
829
    }
J
Jamie Strandboge 已提交
830

831
 cleanup:
832 833 834
    VIR_FREE(pathdir);
    VIR_FREE(pathtmp);
    VIR_FREE(pathreal);
835
    VIR_FREE(perms_new);
836
    VIR_FREE(tmp);
J
Jamie Strandboge 已提交
837 838 839 840

    return rc;
}

F
Felix Geyer 已提交
841 842 843 844 845 846
static int
vah_add_file(virBufferPtr buf, const char *path, const char *perms)
{
    return vah_add_path(buf, path, perms, false);
}

847 848 849 850 851 852 853 854 855 856 857 858
static int
vah_add_file_chardev(virBufferPtr buf,
                     const char *path,
                     const char *perms,
                     const int type)
{
    char *pipe_in;
    char *pipe_out;
    int rc = -1;

    if (type == VIR_DOMAIN_CHR_TYPE_PIPE) {
        /* add the pipe input */
859
        if (virAsprintfQuiet(&pipe_in, "%s.in", path) == -1) {
860
            vah_error(NULL, 0, _("could not allocate memory"));
861
            goto cleanup;
862 863 864 865 866 867
        }

        if (vah_add_file(buf, pipe_in, perms) != 0)
            goto clean_pipe_in;

        /* add the pipe output */
868
        if (virAsprintfQuiet(&pipe_out, "%s.out", path) == -1) {
869 870 871 872 873 874 875 876 877 878 879 880 881 882 883
            vah_error(NULL, 0, _("could not allocate memory"));
            goto clean_pipe_in;
        }

        if (vah_add_file(buf, pipe_out, perms) != 0)
            goto clean_pipe_out;

        rc = 0;
      clean_pipe_out:
        VIR_FREE(pipe_out);
      clean_pipe_in:
        VIR_FREE(pipe_in);
    } else {
        /* add the file */
        if (vah_add_file(buf, path, perms) != 0)
884
            goto cleanup;
885 886 887
        rc = 0;
    }

888
 cleanup:
889 890 891
    return rc;
}

J
Jamie Strandboge 已提交
892
static int
893
file_iterate_hostdev_cb(virUSBDevicePtr dev ATTRIBUTE_UNUSED,
894 895 896 897 898 899 900
                        const char *file, void *opaque)
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

static int
901 902
file_iterate_pci_cb(virPCIDevicePtr dev ATTRIBUTE_UNUSED,
                    const char *file, void *opaque)
J
Jamie Strandboge 已提交
903 904 905 906 907
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

908 909 910 911 912 913 914 915 916 917
static int
add_file_path(virDomainDiskDefPtr disk,
              const char *path,
              size_t depth,
              void *opaque)
{
    virBufferPtr buf = opaque;
    int ret;

    if (depth == 0) {
918
        if (disk->src->readonly)
919
            ret = vah_add_file(buf, path, "rk");
920
        else
921
            ret = vah_add_file(buf, path, "rwk");
922
    } else {
923
        ret = vah_add_file(buf, path, "rk");
924 925
    }

926 927 928
    if (ret != 0)
        ret = -1;

929 930 931
    return ret;
}

J
Jamie Strandboge 已提交
932 933 934 935 936
static int
get_files(vahControl * ctl)
{
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
937
    size_t i;
J
Jamie Strandboge 已提交
938 939
    char *uuid;
    char uuidstr[VIR_UUID_STRING_BUFLEN];
940
    bool needsVfio = false, needsvhost = false, needsgl = false;
J
Jamie Strandboge 已提交
941 942 943

    /* verify uuid is same as what we were given on the command line */
    virUUIDFormat(ctl->def->uuid, uuidstr);
944
    if (virAsprintfQuiet(&uuid, "%s%s", AA_PREFIX, uuidstr) == -1) {
945
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
946 947 948 949
        return rc;
    }

    if (STRNEQ(uuid, ctl->uuid)) {
950
        vah_error(ctl, 0, _("given uuid does not match XML uuid"));
951
        goto cleanup;
J
Jamie Strandboge 已提交
952 953
    }

954 955
    /* load the storage driver so that backing store can be accessed */
#ifdef WITH_STORAGE
956
    virDriverLoadModule("storage", "storageRegister", false);
957
#endif
958

959
    for (i = 0; i < ctl->def->ndisks; i++) {
960 961
        virDomainDiskDefPtr disk = ctl->def->disks[i];

962
        if (!virDomainDiskGetSource(disk))
E
Eric Blake 已提交
963
            continue;
964 965 966
        /* XXX - if we knew the qemu user:group here we could send it in
         *        so that the open could be re-tried as that user:group.
         */
967
        if (!virStorageSourceHasBacking(disk->src))
968
            virStorageFileGetMetadata(disk->src, -1, -1, false);
969

970 971 972
        /* XXX passing ignoreOpenFailure = true to get back to the behavior
         * from before using virDomainDiskDefForeachPath. actually we should
         * be passing ignoreOpenFailure = false and handle open errors more
973 974
         * careful than just ignoring them.
         */
975
        if (virDomainDiskDefForeachPath(disk, true, add_file_path, &buf) < 0)
976
            goto cleanup;
977
    }
J
Jamie Strandboge 已提交
978 979

    for (i = 0; i < ctl->def->nserials; i++)
980
        if (ctl->def->serials[i] &&
981 982 983 984 985 986 987
            (ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->serials[i]->source->data.file.path &&
            ctl->def->serials[i]->source->data.file.path[0] != '\0')
988
            if (vah_add_file_chardev(&buf,
989
                                     ctl->def->serials[i]->source->data.file.path,
990
                                     "rw",
991
                                     ctl->def->serials[i]->source->type) != 0)
992
                goto cleanup;
J
Jamie Strandboge 已提交
993

994 995
    for (i = 0; i < ctl->def->nconsoles; i++)
        if (ctl->def->consoles[i] &&
996 997 998 999 1000 1001 1002
            (ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->consoles[i]->source->data.file.path &&
            ctl->def->consoles[i]->source->data.file.path[0] != '\0')
1003
            if (vah_add_file(&buf,
1004
                             ctl->def->consoles[i]->source->data.file.path, "rw") != 0)
1005
                goto cleanup;
J
Jamie Strandboge 已提交
1006

1007
    for (i = 0; i < ctl->def->nparallels; i++)
1008
        if (ctl->def->parallels[i] &&
1009 1010 1011 1012 1013 1014 1015
            (ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->parallels[i]->source->data.file.path &&
            ctl->def->parallels[i]->source->data.file.path[0] != '\0')
1016
            if (vah_add_file_chardev(&buf,
1017
                                     ctl->def->parallels[i]->source->data.file.path,
1018
                                     "rw",
1019
                                     ctl->def->parallels[i]->source->type) != 0)
1020
                goto cleanup;
1021

1022
    for (i = 0; i < ctl->def->nchannels; i++)
1023
        if (ctl->def->channels[i] &&
1024 1025 1026 1027 1028 1029 1030
            (ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->channels[i]->source->data.file.path &&
            ctl->def->channels[i]->source->data.file.path[0] != '\0')
1031
            if (vah_add_file_chardev(&buf,
1032
                                     ctl->def->channels[i]->source->data.file.path,
1033
                                     "rw",
1034
                                     ctl->def->channels[i]->source->type) != 0)
1035
                goto cleanup;
1036

1037
    if (ctl->def->os.kernel)
J
Jamie Strandboge 已提交
1038
        if (vah_add_file(&buf, ctl->def->os.kernel, "r") != 0)
1039
            goto cleanup;
J
Jamie Strandboge 已提交
1040

1041
    if (ctl->def->os.initrd)
J
Jamie Strandboge 已提交
1042
        if (vah_add_file(&buf, ctl->def->os.initrd, "r") != 0)
1043
            goto cleanup;
O
Olivia Yin 已提交
1044 1045 1046

    if (ctl->def->os.dtb)
        if (vah_add_file(&buf, ctl->def->os.dtb, "r") != 0)
1047
            goto cleanup;
J
Jamie Strandboge 已提交
1048

J
Ján Tomko 已提交
1049 1050 1051 1052
    if (ctl->def->os.slic_table)
        if (vah_add_file(&buf, ctl->def->os.slic_table, "r") != 0)
            goto cleanup;

1053
    if (ctl->def->os.loader && ctl->def->os.loader->path)
1054
        if (vah_add_file(&buf, ctl->def->os.loader->path, "rk") != 0)
1055
            goto cleanup;
1056

1057
    if (ctl->def->os.loader && ctl->def->os.loader->nvram)
1058
        if (vah_add_file(&buf, ctl->def->os.loader->nvram, "rwk") != 0)
1059 1060
            goto cleanup;

1061
    for (i = 0; i < ctl->def->ngraphics; i++) {
1062 1063
        virDomainGraphicsDefPtr graphics = ctl->def->graphics[i];
        size_t n;
1064 1065 1066 1067
        const char *rendernode = virDomainGraphicsGetRenderNode(graphics);

        if (rendernode) {
            vah_add_file(&buf, rendernode, "rw");
1068
            needsgl = true;
1069 1070 1071
        } else {
            if (virDomainGraphicsNeedsAutoRenderNode(graphics)) {
                char *defaultRenderNode = virHostGetDRMRenderNode();
1072
                needsgl = true;
1073 1074 1075 1076 1077 1078 1079

                if (defaultRenderNode) {
                    vah_add_file(&buf, defaultRenderNode, "rw");
                    VIR_FREE(defaultRenderNode);
                }
            }
        }
1080 1081 1082 1083 1084 1085 1086 1087 1088

        for (n = 0; n < graphics->nListens; n++) {
            virDomainGraphicsListenDef listenObj = graphics->listens[n];

            if (listenObj.type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET &&
                listenObj.socket &&
                vah_add_file(&buf, listenObj.socket, "rw"))
                goto cleanup;
        }
1089 1090
    }

1091 1092 1093 1094
    if (ctl->def->ngraphics == 1 &&
        ctl->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL)
        if (vah_add_file(&buf, ctl->def->graphics[0]->data.sdl.xauth,
                         "r") != 0)
1095
            goto cleanup;
J
Jamie Strandboge 已提交
1096 1097 1098 1099

    for (i = 0; i < ctl->def->nhostdevs; i++)
        if (ctl->def->hostdevs[i]) {
            virDomainHostdevDefPtr dev = ctl->def->hostdevs[i];
1100
            virDomainHostdevSubsysUSBPtr usbsrc = &dev->source.subsys.u.usb;
J
Jamie Strandboge 已提交
1101 1102
            switch (dev->source.subsys.type) {
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: {
1103
                virUSBDevicePtr usb =
1104
                    virUSBDeviceNew(usbsrc->bus, usbsrc->device, NULL);
1105 1106 1107 1108

                if (usb == NULL)
                    continue;

1109 1110 1111
                if (virHostdevFindUSBDevice(dev, true, &usb) < 0)
                    continue;

1112 1113
                rc = virUSBDeviceFileIterate(usb, file_iterate_hostdev_cb, &buf);
                virUSBDeviceFree(usb);
1114
                if (rc != 0)
1115
                    goto cleanup;
J
Jamie Strandboge 已提交
1116 1117
                break;
            }
1118

1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: {
                virDomainHostdevSubsysMediatedDevPtr mdevsrc = &dev->source.subsys.u.mdev;
                switch ((virMediatedDeviceModelType) mdevsrc->model) {
                    case VIR_MDEV_MODEL_TYPE_VFIO_PCI:
                    case VIR_MDEV_MODEL_TYPE_VFIO_AP:
                    case VIR_MDEV_MODEL_TYPE_VFIO_CCW:
                        needsVfio = true;
                        break;
                    case VIR_MDEV_MODEL_TYPE_LAST:
                    default:
                        virReportEnumRangeError(virMediatedDeviceModelType,
                                                mdevsrc->model);
                        break;
                }
                break;
            }

J
Jamie Strandboge 已提交
1136
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: {
1137
                virPCIDevicePtr pci = virPCIDeviceNew(
1138 1139 1140 1141
                           dev->source.subsys.u.pci.addr.domain,
                           dev->source.subsys.u.pci.addr.bus,
                           dev->source.subsys.u.pci.addr.slot,
                           dev->source.subsys.u.pci.addr.function);
J
Jamie Strandboge 已提交
1142

1143
                virDomainHostdevSubsysPCIBackendType backend = dev->source.subsys.u.pci.backend;
1144 1145 1146 1147 1148
                if (backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO ||
                        backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT) {
                    needsVfio = true;
                }

J
Jamie Strandboge 已提交
1149 1150 1151
                if (pci == NULL)
                    continue;

1152 1153
                rc = virPCIDeviceFileIterate(pci, file_iterate_pci_cb, &buf);
                virPCIDeviceFree(pci);
J
Jamie Strandboge 已提交
1154 1155 1156

                break;
            }
1157

J
Jamie Strandboge 已提交
1158 1159 1160 1161 1162 1163
            default:
                rc = 0;
                break;
            } /* switch */
        }

F
Felix Geyer 已提交
1164 1165 1166 1167 1168
    for (i = 0; i < ctl->def->nfss; i++) {
        if (ctl->def->fss[i] &&
                ctl->def->fss[i]->type == VIR_DOMAIN_FS_TYPE_MOUNT &&
                (ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_PATH ||
                 ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT) &&
1169
                ctl->def->fss[i]->src) {
F
Felix Geyer 已提交
1170 1171
            virDomainFSDefPtr fs = ctl->def->fss[i];

1172 1173 1174
            /* We don't need to add deny rw rules for readonly mounts,
             * this can only lead to troubles when mounting / readonly.
             */
1175
            if (vah_add_path(&buf, fs->src->path, fs->readonly ? "R" : "rw", true) != 0)
F
Felix Geyer 已提交
1176 1177 1178 1179
                goto cleanup;
        }
    }

1180 1181 1182 1183 1184 1185 1186 1187
    for (i = 0; i < ctl->def->ninputs; i++) {
        if (ctl->def->inputs[i] &&
                ctl->def->inputs[i]->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) {
            if (vah_add_file(&buf, ctl->def->inputs[i]->source.evdev, "rw") != 0)
                goto cleanup;
        }
    }

1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199
    for (i = 0; i < ctl->def->nnets; i++) {
        if (ctl->def->nets[i] &&
                ctl->def->nets[i]->type == VIR_DOMAIN_NET_TYPE_VHOSTUSER &&
                ctl->def->nets[i]->data.vhostuser) {
            virDomainChrSourceDefPtr vhu = ctl->def->nets[i]->data.vhostuser;

            if (vah_add_file_chardev(&buf, vhu->data.nix.path, "rw",
                       vhu->type) != 0)
                goto cleanup;
        }
    }

1200 1201 1202 1203 1204 1205 1206 1207
    for (i = 0; i < ctl->def->nmems; i++) {
        if (ctl->def->mems[i] &&
                ctl->def->mems[i]->model == VIR_DOMAIN_MEMORY_MODEL_NVDIMM) {
            if (vah_add_file(&buf, ctl->def->mems[i]->nvdimmPath, "rw") != 0)
                goto cleanup;
        }
    }

1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252
    if (ctl->def->tpm) {
        char *shortName = NULL;
        const char *tpmpath = NULL;

        switch (ctl->def->tpm->type) {
        case VIR_DOMAIN_TPM_TYPE_EMULATOR:
            shortName = virDomainDefGetShortName(ctl->def);

            switch (ctl->def->tpm->version) {
            case VIR_DOMAIN_TPM_VERSION_1_2:
                tpmpath = "tpm1.2";
                break;
            case VIR_DOMAIN_TPM_VERSION_2_0:
                tpmpath = "tpm2";
                break;
            case VIR_DOMAIN_TPM_VERSION_DEFAULT:
            case VIR_DOMAIN_TPM_VERSION_LAST:
                break;
            }

            /* Unix socket for QEMU and swtpm to use */
            virBufferAsprintf(&buf,
                "  \"/run/libvirt/qemu/swtpm/%s-swtpm.sock\" rw,\n",
                shortName);
            /* Paths for swtpm to use: give it access to its state
             * directory, log, and PID files.
             */
            virBufferAsprintf(&buf,
                "  \"%s/lib/libvirt/swtpm/%s/%s/**\" rw,\n",
                LOCALSTATEDIR, uuidstr, tpmpath);
            virBufferAsprintf(&buf,
                "  \"%s/log/swtpm/libvirt/qemu/%s-swtpm.log\" a,\n",
                LOCALSTATEDIR, ctl->def->name);
            virBufferAsprintf(&buf,
                "  \"/run/libvirt/qemu/swtpm/%s-swtpm.pid\" rw,\n",
                shortName);

            VIR_FREE(shortName);
            break;
        case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
        case VIR_DOMAIN_TPM_TYPE_LAST:
            break;
        }
    }

1253 1254 1255 1256 1257 1258
    if (ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
        for (i = 0; i < ctl->def->nnets; i++) {
            virDomainNetDefPtr net = ctl->def->nets[i];
            if (net && net->model) {
                if (net->driver.virtio.name == VIR_DOMAIN_NET_BACKEND_TYPE_QEMU)
                    continue;
1259
                if (!virDomainNetIsVirtioModel(net))
1260 1261 1262 1263 1264 1265
                    continue;
            }
            needsvhost = true;
        }
    }
    if (needsvhost)
1266
        virBufferAddLit(&buf, "  \"/dev/vhost-net\" rw,\n");
1267

1268
    if (needsVfio) {
1269 1270
        virBufferAddLit(&buf, "  \"/dev/vfio/vfio\" rw,\n");
        virBufferAddLit(&buf, "  \"/dev/vfio/[0-9]*\" rw,\n");
1271
    }
1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288
    if (needsgl) {
        /* if using gl all sorts of further dri related paths will be needed */
        virBufferAddLit(&buf, "  # DRI/Mesa/(e)GL config and driver paths\n");
        virBufferAddLit(&buf, "  \"/usr/lib{,32,64}/dri/*.so*\" mr,\n");
        virBufferAddLit(&buf, "  \"/usr/lib/@{multiarch}/dri/*.so*\" mr,\n");
        virBufferAddLit(&buf, "  \"/usr/lib/fglrx/dri/*.so*\" mr,\n");
        virBufferAddLit(&buf, "  \"/etc/drirc\" r,\n");
        virBufferAddLit(&buf, "  \"/usr/share/drirc.d/{,*.conf}\" r,\n");
        virBufferAddLit(&buf, "  \"/etc/glvnd/egl_vendor.d/{,*}\" r,\n");
        virBufferAddLit(&buf, "  \"/usr/share/glvnd/egl_vendor.d/{,*}\" r,\n");
        virBufferAddLit(&buf, "  # Probe DRI device attributes\n");
        virBufferAddLit(&buf, "  \"/dev/dri/\" r,\n");
        virBufferAddLit(&buf, "  \"/sys/devices/*/*/{uevent,vendor,device,subsystem_vendor,subsystem_device}\" r,\n");
        virBufferAddLit(&buf, "  \"/sys/devices/*/*/drm/*/{uevent,vendor,device,subsystem_vendor,subsystem_device}\" r,\n");
        virBufferAddLit(&buf, "  # dri libs will trigger that, but t is not requited and DAC would deny it anyway\n");
        virBufferAddLit(&buf, "  deny \"/var/lib/libvirt/.cache/\" w,\n");
    }
1289

1290
    if (ctl->newfile)
1291
        if (vah_add_file(&buf, ctl->newfile, "rwk") != 0)
1292
            goto cleanup;
J
Jamie Strandboge 已提交
1293 1294

    if (virBufferError(&buf)) {
1295
        virBufferFreeAndReset(&buf);
1296
        vah_error(NULL, 0, _("failed to allocate file buffer"));
1297
        goto cleanup;
J
Jamie Strandboge 已提交
1298 1299 1300 1301 1302
    }

    rc = 0;
    ctl->files = virBufferContentAndReset(&buf);

1303
 cleanup:
J
Jamie Strandboge 已提交
1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317
    VIR_FREE(uuid);
    return rc;
}

static int
vahParseArgv(vahControl * ctl, int argc, char **argv)
{
    int arg, idx = 0;
    struct option opt[] = {
        {"add", 0, 0, 'a'},
        {"create", 0, 0, 'c'},
        {"dryrun", 0, 0, 'd'},
        {"delete", 0, 0, 'D'},
        {"add-file", 0, 0, 'f'},
1318
        {"append-file", 0, 0, 'F'},
J
Jamie Strandboge 已提交
1319 1320 1321 1322 1323 1324 1325
        {"help", 0, 0, 'h'},
        {"replace", 0, 0, 'r'},
        {"remove", 0, 0, 'R'},
        {"uuid", 1, 0, 'u'},
        {0, 0, 0, 0}
    };

1326
    while ((arg = getopt_long(argc, argv, "acdDhrRH:b:u:p:f:F:", opt,
J
Jamie Strandboge 已提交
1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341
            &idx)) != -1) {
        switch (arg) {
            case 'a':
                ctl->cmd = 'a';
                break;
            case 'c':
                ctl->cmd = 'c';
                break;
            case 'd':
                ctl->dryrun = true;
                break;
            case 'D':
                ctl->cmd = 'D';
                break;
            case 'f':
1342
            case 'F':
1343
                if (VIR_STRDUP_QUIET(ctl->newfile, optarg) < 0)
1344
                    vah_error(ctl, 1, _("could not allocate memory for disk"));
1345
                ctl->append = arg == 'F';
J
Jamie Strandboge 已提交
1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358
                break;
            case 'h':
                vah_usage();
                exit(EXIT_SUCCESS);
                break;
            case 'r':
                ctl->cmd = 'r';
                break;
            case 'R':
                ctl->cmd = 'R';
                break;
            case 'u':
                if (strlen(optarg) > PROFILE_NAME_SIZE - 1)
1359
                    vah_error(ctl, 1, _("invalid UUID"));
1360
                if (virStrcpy((char *)ctl->uuid, optarg,
1361
                    PROFILE_NAME_SIZE) < 0)
1362
                    vah_error(ctl, 1, _("error copying UUID"));
J
Jamie Strandboge 已提交
1363 1364
                break;
            default:
1365
                vah_error(ctl, 1, _("unsupported option"));
J
Jamie Strandboge 已提交
1366 1367 1368 1369
                break;
        }
    }
    if (strchr("acDrR", ctl->cmd) == NULL)
1370
        vah_error(ctl, 1, _("bad command"));
J
Jamie Strandboge 已提交
1371 1372

    if (valid_uuid(ctl->uuid) != 0)
1373
        vah_error(ctl, 1, _("invalid UUID"));
J
Jamie Strandboge 已提交
1374 1375 1376 1377 1378 1379 1380 1381 1382

    if (!ctl->cmd) {
        vah_usage();
        exit(EXIT_FAILURE);
    }

    if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *xmlStr = NULL;
        if (virFileReadLimFD(STDIN_FILENO, MAX_FILE_LEN, &xmlStr) < 0)
1383
            vah_error(ctl, 1, _("could not read xml file"));
J
Jamie Strandboge 已提交
1384 1385 1386

        if (get_definition(ctl, xmlStr) != 0 || ctl->def == NULL) {
            VIR_FREE(xmlStr);
1387
            vah_error(ctl, 1, _("could not get VM definition"));
J
Jamie Strandboge 已提交
1388 1389 1390 1391
        }
        VIR_FREE(xmlStr);

        if (get_files(ctl) != 0)
1392
            vah_error(ctl, 1, _("invalid VM definition"));
J
Jamie Strandboge 已提交
1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410
    }
    return 0;
}


/*
 * virt-aa-helper -c -u UUID < file.xml
 * virt-aa-helper -r -u UUID [-f <file>] < file.xml
 * virt-aa-helper -a -u UUID
 * virt-aa-helper -R -u UUID
 * virt-aa-helper -D -u UUID
 */
int
main(int argc, char **argv)
{
    vahControl _ctl, *ctl = &_ctl;
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
1411 1412
    char *profile = NULL;
    char *include_file = NULL;
J
Jamie Strandboge 已提交
1413

1414 1415
    if (virGettextInitialize() < 0 ||
        virThreadInitialize() < 0 ||
1416 1417 1418 1419 1420
        virErrorInitialize() < 0) {
        fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
        exit(EXIT_FAILURE);
    }

1421 1422
    virFileActivateDirOverride(argv[0]);

1423 1424 1425
    /* Initialize the log system */
    virLogSetFromEnv();

J
Jamie Strandboge 已提交
1426 1427
    /* clear the environment */
    environ = NULL;
1428
    if (setenv("PATH", "/sbin:/usr/sbin", 1) != 0)
1429 1430
        vah_error(ctl, 1, _("could not set PATH"));

1431
    /* ensure the traditional IFS setting */
1432
    if (setenv("IFS", " \t\n", 1) != 0)
1433
        vah_error(ctl, 1, _("could not set IFS"));
J
Jamie Strandboge 已提交
1434 1435 1436 1437 1438 1439 1440 1441 1442

    if (!(progname = strrchr(argv[0], '/')))
        progname = argv[0];
    else
        progname++;

    memset(ctl, 0, sizeof(vahControl));

    if (vahParseArgv(ctl, argc, argv) != 0)
1443
        vah_error(ctl, 1, _("could not parse arguments"));
J
Jamie Strandboge 已提交
1444

1445 1446
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1447
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1448

1449 1450
    if (virAsprintfQuiet(&include_file, "%s/%s.files",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1451
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1452

1453
    if (ctl->cmd == 'a') {
J
Jamie Strandboge 已提交
1454
        rc = parserLoad(ctl->uuid);
1455
    } else if (ctl->cmd == 'R' || ctl->cmd == 'D') {
J
Jamie Strandboge 已提交
1456 1457 1458 1459 1460 1461 1462 1463
        rc = parserRemove(ctl->uuid);
        if (ctl->cmd == 'D') {
            unlink(include_file);
            unlink(profile);
        }
    } else if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *included_files = NULL;

1464
        if (ctl->cmd == 'c' && virFileExists(profile))
1465
            vah_error(ctl, 1, _("profile exists"));
J
Jamie Strandboge 已提交
1466

1467
        if (ctl->append && ctl->newfile) {
1468
            if (vah_add_file(&buf, ctl->newfile, "rwk") != 0)
1469
                goto cleanup;
1470
        } else {
1471 1472 1473
            if (ctl->def->virtType == VIR_DOMAIN_VIRT_QEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KQEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
1474 1475
                virBufferAsprintf(&buf, "  \"%s/log/libvirt/**/%s.log\" w,\n",
                                  LOCALSTATEDIR, ctl->def->name);
1476
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%s/monitor.sock\" rw,\n",
1477
                                  LOCALSTATEDIR, ctl->def->name);
1478 1479
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%d-%.*s/*\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->id, 20, ctl->def->name);
1480 1481 1482 1483 1484 1485 1486 1487 1488
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/%s.pid\" rwk,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/%s.pid\" rwk,\n",
                                  ctl->def->name);
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  ctl->def->name);
            }
1489
            if (ctl->files)
1490
                virBufferAdd(&buf, ctl->files, -1);
1491
        }
J
Jamie Strandboge 已提交
1492

1493 1494
        if (virBufferError(&buf)) {
            virBufferFreeAndReset(&buf);
1495
            vah_error(ctl, 1, _("failed to allocate buffer"));
1496
        }
J
Jamie Strandboge 已提交
1497 1498 1499 1500 1501 1502 1503 1504

        included_files = virBufferContentAndReset(&buf);

        /* (re)create the include file using included_files */
        if (ctl->dryrun) {
            vah_info(include_file);
            vah_info(included_files);
            rc = 0;
1505 1506 1507
        } else if (ctl->def->virtType == VIR_DOMAIN_VIRT_LXC) {
            rc = 0;
        } else if ((rc = update_include_file(include_file,
1508
                                             included_files,
1509
                                             ctl->append)) != 0) {
1510
            goto cleanup;
1511
        }
J
Jamie Strandboge 已提交
1512 1513 1514 1515 1516


        /* create the profile from TEMPLATE */
        if (ctl->cmd == 'c') {
            char *tmp = NULL;
1517 1518
            if (virAsprintfQuiet(&tmp, "  #include <libvirt/%s.files>\n",
                                 ctl->uuid) == -1) {
1519
                vah_error(ctl, 0, _("could not allocate memory"));
1520
                goto cleanup;
J
Jamie Strandboge 已提交
1521 1522 1523 1524 1525 1526 1527
            }

            if (ctl->dryrun) {
                vah_info(profile);
                vah_info(ctl->uuid);
                vah_info(tmp);
                rc = 0;
1528 1529
            } else if ((rc = create_profile(profile, ctl->uuid, tmp,
                                            ctl->def->virtType)) != 0) {
1530
                vah_error(ctl, 0, _("could not create profile"));
J
Jamie Strandboge 已提交
1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548
                unlink(include_file);
            }
            VIR_FREE(tmp);
        }

        if (rc == 0 && !ctl->dryrun) {
            if (ctl->cmd == 'c')
                rc = parserLoad(ctl->uuid);
            else
                rc = parserReplace(ctl->uuid);

            /* cleanup */
            if (rc != 0) {
                unlink(include_file);
                if (ctl->cmd == 'c')
                    unlink(profile);
            }
        }
1549
      cleanup:
J
Jamie Strandboge 已提交
1550 1551 1552 1553
        VIR_FREE(included_files);
    }

    vahDeinit(ctl);
1554 1555 1556 1557

    VIR_FREE(profile);
    VIR_FREE(include_file);

J
Jamie Strandboge 已提交
1558 1559
    exit(rc == 0 ? EXIT_SUCCESS : EXIT_FAILURE);
}