virt-aa-helper.c 46.2 KB
Newer Older
J
Jamie Strandboge 已提交
1 2
/*
 * virt-aa-helper: wrapper program used by AppArmor security driver.
3
 *
4
 * Copyright (C) 2010-2014 Red Hat, Inc.
5
 * Copyright (C) 2009-2011 Canonical Ltd.
J
Jamie Strandboge 已提交
6
 *
O
Osier Yang 已提交
7 8 9 10 11 12 13 14 15 16 17
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
J
Jamie Strandboge 已提交
20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35
 *
 * Author:
 *   Jamie Strandboge <jamie@canonical.com>
 *
 */

#include <config.h>

#include <stdarg.h>
#include <unistd.h>
#include <sys/types.h>
#include <fcntl.h>
#include <getopt.h>
#include <sys/utsname.h>

#include "internal.h"
36
#include "virbuffer.h"
37
#include "viralloc.h"
38
#include "vircommand.h"
39
#include "virlog.h"
40
#include "dirname.h"
41
#include "driver.h"
J
Jamie Strandboge 已提交
42 43 44 45

#include "security_driver.h"
#include "security_apparmor.h"
#include "domain_conf.h"
46
#include "virxml.h"
47
#include "viruuid.h"
48
#include "virusb.h"
49
#include "virpci.h"
E
Eric Blake 已提交
50
#include "virfile.h"
51
#include "configmake.h"
52
#include "virrandom.h"
53
#include "virstring.h"
54
#include "virgettext.h"
55
#include "virhostdev.h"
J
Jamie Strandboge 已提交
56

57 58
#define VIR_FROM_THIS VIR_FROM_SECURITY

J
Jamie Strandboge 已提交
59 60 61 62 63 64 65 66 67 68 69 70
static char *progname;

typedef struct {
    char uuid[PROFILE_NAME_SIZE];       /* UUID of vm */
    bool dryrun;                /* dry run */
    char cmd;                   /* 'c'   create
                                 * 'a'   add (load)
                                 * 'r'   replace
                                 * 'R'   remove */
    char *files;                /* list of files */
    virDomainDefPtr def;        /* VM definition */
    virCapsPtr caps;            /* VM capabilities */
71
    virDomainXMLOptionPtr xmlopt; /* XML parser data */
72
    char *virtType;                  /* type of hypervisor (eg qemu, xen, lxc) */
73
    char *os;                   /* type of os (eg hvm, xen, exe) */
74
    virArch arch;               /* machine architecture */
75 76
    char *newfile;              /* newly added file */
    bool append;                /* append to .files instead of rewrite */
J
Jamie Strandboge 已提交
77 78 79 80 81 82 83 84 85
} vahControl;

static int
vahDeinit(vahControl * ctl)
{
    if (ctl == NULL)
        return -1;

    VIR_FREE(ctl->def);
86
    virObjectUnref(ctl->caps);
87
    virObjectUnref(ctl->xmlopt);
88
    VIR_FREE(ctl->files);
89
    VIR_FREE(ctl->virtType);
90
    VIR_FREE(ctl->os);
91
    VIR_FREE(ctl->newfile);
J
Jamie Strandboge 已提交
92 93 94 95 96 97 98 99 100 101

    return 0;
}

/*
 * Print usage
 */
static void
vah_usage(void)
{
102 103 104 105
    printf(_("\n%s [options] [< def.xml]\n\n"
            "  Options:\n"
            "    -a | --add                     load profile\n"
            "    -c | --create                  create profile from template\n"
106
            "    -d | --dryrun                  dry run\n"
107 108 109 110 111 112 113 114 115 116 117
            "    -D | --delete                  unload and delete profile\n"
            "    -f | --add-file <file>         add file to profile\n"
            "    -F | --append-file <file>      append file to profile\n"
            "    -r | --replace                 reload profile\n"
            "    -R | --remove                  unload profile\n"
            "    -h | --help                    this help\n"
            "    -u | --uuid <uuid>             uuid (profile name)\n"
            "\n"), progname);

    puts(_("This command is intended to be used by libvirtd "
           "and not used directly.\n"));
J
Jamie Strandboge 已提交
118 119 120 121 122 123
    return;
}

static void
vah_error(vahControl * ctl, int doexit, const char *str)
{
124
    fprintf(stderr, _("%s: error: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
125 126 127 128 129 130 131 132 133 134 135

    if (doexit) {
        if (ctl != NULL)
            vahDeinit(ctl);
        exit(EXIT_FAILURE);
    }
}

static void
vah_warning(const char *str)
{
136
    fprintf(stderr, _("%s: warning: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
137 138 139 140 141
}

static void
vah_info(const char *str)
{
142
    fprintf(stderr, _("%s:\n%s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
143 144 145 146 147 148 149 150
}

/*
 * run an apparmor_parser command
 */
static int
parserCommand(const char *profile_name, const char cmd)
{
151
    int result = -1;
J
Jamie Strandboge 已提交
152
    char flag[3];
153
    char *profile;
154 155
    int status;
    int ret;
J
Jamie Strandboge 已提交
156 157

    if (strchr("arR", cmd) == NULL) {
158
        vah_error(NULL, 0, _("invalid flag"));
J
Jamie Strandboge 已提交
159 160 161 162 163
        return -1;
    }

    snprintf(flag, 3, "-%c", cmd);

164 165
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", profile_name) < 0) {
166
        vah_error(NULL, 0, _("profile name exceeds maximum length"));
J
Jamie Strandboge 已提交
167 168 169 170
        return -1;
    }

    if (!virFileExists(profile)) {
171
        vah_error(NULL, 0, _("profile does not exist"));
172
        goto cleanup;
J
Jamie Strandboge 已提交
173 174 175 176
    } else {
        const char * const argv[] = {
            "/sbin/apparmor_parser", flag, profile, NULL
        };
177 178 179
        if ((ret = virRun(argv, &status)) != 0 ||
            (WIFEXITED(status) && WEXITSTATUS(status) != 0)) {
            if (ret != 0) {
180
                vah_error(NULL, 0, _("failed to run apparmor_parser"));
181
                goto cleanup;
182 183 184
            } else if (cmd == 'R' && WIFEXITED(status) &&
                       WEXITSTATUS(status) == 234) {
                vah_warning(_("unable to unload already unloaded profile"));
185
            } else {
186
                vah_error(NULL, 0, _("apparmor_parser exited with error"));
187
                goto cleanup;
188
            }
J
Jamie Strandboge 已提交
189 190 191
        }
    }

192 193
    result = 0;

194
 cleanup:
195 196 197
    VIR_FREE(profile);

    return result;
J
Jamie Strandboge 已提交
198 199 200 201 202 203
}

/*
 * Update the dynamic files
 */
static int
204 205
update_include_file(const char *include_file, const char *included_files,
                    bool append)
J
Jamie Strandboge 已提交
206 207
{
    int rc = -1;
208
    int plen, flen = 0;
J
Jamie Strandboge 已提交
209 210
    int fd;
    char *pcontent = NULL;
211
    char *existing = NULL;
J
Jamie Strandboge 已提交
212 213 214
    const char *warning =
         "# DO NOT EDIT THIS FILE DIRECTLY. IT IS MANAGED BY LIBVIRT.\n";

215 216 217 218 219 220 221
    if (virFileExists(include_file)) {
        flen = virFileReadAll(include_file, MAX_FILE_LEN, &existing);
        if (flen < 0)
            return rc;
    }

    if (append && virFileExists(include_file)) {
222
        if (virAsprintfQuiet(&pcontent, "%s%s", existing, included_files) == -1) {
223
            vah_error(NULL, 0, _("could not allocate memory for profile"));
224
            goto cleanup;
225 226
        }
    } else {
227
        if (virAsprintfQuiet(&pcontent, "%s%s", warning, included_files) == -1) {
228
            vah_error(NULL, 0, _("could not allocate memory for profile"));
229
            goto cleanup;
230
        }
J
Jamie Strandboge 已提交
231 232 233 234
    }

    plen = strlen(pcontent);
    if (plen > MAX_FILE_LEN) {
235
        vah_error(NULL, 0, _("invalid length for new profile"));
236
        goto cleanup;
J
Jamie Strandboge 已提交
237 238 239
    }

    /* only update the disk profile if it is different */
240 241
    if (flen > 0 && flen == plen && STREQLEN(existing, pcontent, plen)) {
        rc = 0;
242
        goto cleanup;
J
Jamie Strandboge 已提交
243 244 245 246
    }

    /* write the file */
    if ((fd = open(include_file, O_CREAT | O_TRUNC | O_WRONLY, 0644)) == -1) {
247
        vah_error(NULL, 0, _("failed to create include file"));
248
        goto cleanup;
J
Jamie Strandboge 已提交
249 250 251
    }

    if (safewrite(fd, pcontent, plen) < 0) { /* don't write the '\0' */
252
        VIR_FORCE_CLOSE(fd);
253
        vah_error(NULL, 0, _("failed to write to profile"));
254
        goto cleanup;
J
Jamie Strandboge 已提交
255 256
    }

257
    if (VIR_CLOSE(fd) != 0) {
258
        vah_error(NULL, 0, _("failed to close or write to profile"));
259
        goto cleanup;
J
Jamie Strandboge 已提交
260 261 262
    }
    rc = 0;

263
 cleanup:
J
Jamie Strandboge 已提交
264
    VIR_FREE(pcontent);
265
    VIR_FREE(existing);
J
Jamie Strandboge 已提交
266 267 268 269 270 271 272 273 274

    return rc;
}

/*
 * Create a profile based on a template
 */
static int
create_profile(const char *profile, const char *profile_name,
275
               const char *profile_files, int virtType)
J
Jamie Strandboge 已提交
276
{
277
    char *template;
J
Jamie Strandboge 已提交
278 279 280 281
    char *tcontent = NULL;
    char *pcontent = NULL;
    char *replace_name = NULL;
    char *replace_files = NULL;
282
    char *tmp = NULL;
J
Jamie Strandboge 已提交
283 284 285 286 287
    const char *template_name = "\nprofile LIBVIRT_TEMPLATE";
    const char *template_end = "\n}";
    int tlen, plen;
    int fd;
    int rc = -1;
288
    const char *driver_name = NULL;
J
Jamie Strandboge 已提交
289 290

    if (virFileExists(profile)) {
291
        vah_error(NULL, 0, _("profile exists"));
J
Jamie Strandboge 已提交
292 293 294
        goto end;
    }

295 296 297 298 299 300 301 302 303
    switch (virtType) {
    case VIR_DOMAIN_VIRT_QEMU:
    case VIR_DOMAIN_VIRT_KQEMU:
    case VIR_DOMAIN_VIRT_KVM:
        driver_name = "qemu";
        break;
    default:
        driver_name = virDomainVirtTypeToString(virtType);
    }
C
Cédric Bosdonnat 已提交
304 305

    if (virAsprintfQuiet(&template, "%s/TEMPLATE.%s", APPARMOR_DIR "/libvirt",
306
                         driver_name) < 0) {
307
        vah_error(NULL, 0, _("template name exceeds maximum length"));
J
Jamie Strandboge 已提交
308 309 310 311
        goto end;
    }

    if (!virFileExists(template)) {
312
        vah_error(NULL, 0, _("template does not exist"));
J
Jamie Strandboge 已提交
313 314 315 316
        goto end;
    }

    if ((tlen = virFileReadAll(template, MAX_FILE_LEN, &tcontent)) < 0) {
317
        vah_error(NULL, 0, _("failed to read AppArmor template"));
J
Jamie Strandboge 已提交
318 319 320 321
        goto end;
    }

    if (strstr(tcontent, template_name) == NULL) {
322
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
323 324 325 326
        goto clean_tcontent;
    }

    if (strstr(tcontent, template_end) == NULL) {
327
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
328 329 330 331
        goto clean_tcontent;
    }

    /* '\nprofile <profile_name>\0' */
332
    if (virAsprintfQuiet(&replace_name, "\nprofile %s", profile_name) == -1) {
333
        vah_error(NULL, 0, _("could not allocate memory for profile name"));
J
Jamie Strandboge 已提交
334 335 336 337
        goto clean_tcontent;
    }

    /* '\n<profile_files>\n}\0' */
338 339
    if ((virtType != VIR_DOMAIN_VIRT_LXC) &&
            virAsprintfQuiet(&replace_files, "\n%s\n}", profile_files) == -1) {
340
        vah_error(NULL, 0, _("could not allocate memory for profile files"));
J
Jamie Strandboge 已提交
341 342 343 344
        VIR_FREE(replace_name);
        goto clean_tcontent;
    }

C
Cédric Bosdonnat 已提交
345
    plen = tlen + strlen(replace_name) - strlen(template_name) + 1;
346 347 348 349

    if (virtType != VIR_DOMAIN_VIRT_LXC)
        plen += strlen(replace_files) - strlen(template_end);

J
Jamie Strandboge 已提交
350
    if (plen > MAX_FILE_LEN || plen < tlen) {
351
        vah_error(NULL, 0, _("invalid length for new profile"));
J
Jamie Strandboge 已提交
352 353 354
        goto clean_replace;
    }

355
    if (!(pcontent = virStringReplace(tcontent, template_name, replace_name)))
J
Jamie Strandboge 已提交
356 357
        goto clean_all;

358 359 360 361 362 363 364
    if (virtType != VIR_DOMAIN_VIRT_LXC) {
        if (!(tmp = virStringReplace(pcontent, template_end, replace_files)))
            goto clean_all;
        VIR_FREE(pcontent);
        pcontent = tmp;
        tmp = NULL;
    }
J
Jamie Strandboge 已提交
365 366 367

    /* write the file */
    if ((fd = open(profile, O_CREAT | O_EXCL | O_WRONLY, 0644)) == -1) {
368
        vah_error(NULL, 0, _("failed to create profile"));
J
Jamie Strandboge 已提交
369 370 371 372
        goto clean_all;
    }

    if (safewrite(fd, pcontent, plen - 1) < 0) { /* don't write the '\0' */
373
        VIR_FORCE_CLOSE(fd);
374
        vah_error(NULL, 0, _("failed to write to profile"));
J
Jamie Strandboge 已提交
375 376 377
        goto clean_all;
    }

378
    if (VIR_CLOSE(fd) != 0) {
379
        vah_error(NULL, 0, _("failed to close or write to profile"));
J
Jamie Strandboge 已提交
380 381 382 383
        goto clean_all;
    }
    rc = 0;

384
 clean_all:
J
Jamie Strandboge 已提交
385
    VIR_FREE(pcontent);
386
 clean_replace:
J
Jamie Strandboge 已提交
387 388
    VIR_FREE(replace_name);
    VIR_FREE(replace_files);
389
 clean_tcontent:
J
Jamie Strandboge 已提交
390
    VIR_FREE(tcontent);
391
 end:
392
    VIR_FREE(template);
J
Jamie Strandboge 已提交
393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444
    return rc;
}

/*
 * Load an existing profile
 */
static int
parserLoad(const char *profile_name)
{
    return parserCommand(profile_name, 'a');
}

/*
 * Remove an existing profile
 */
static int
parserRemove(const char *profile_name)
{
    return parserCommand(profile_name, 'R');
}

/*
 * Replace an existing profile
 */
static int
parserReplace(const char *profile_name)
{
    return parserCommand(profile_name, 'r');
}

static int
valid_uuid(const char *uuid)
{
    unsigned char rawuuid[VIR_UUID_BUFLEN];

    if (strlen(uuid) != PROFILE_NAME_SIZE - 1)
        return -1;

    if (!STRPREFIX(uuid, AA_PREFIX))
        return -1;

    if (virUUIDParse(uuid + strlen(AA_PREFIX), rawuuid) < 0)
        return -1;

    return 0;
}

static int
valid_name(const char *name)
{
    /* just try to filter out any dangerous characters in the name that can be
     * used to subvert the profile */
445
    const char *bad = "/[]{}?^,\"*";
J
Jamie Strandboge 已提交
446

447
    if (strlen(name) == 0)
J
Jamie Strandboge 已提交
448 449 450 451 452 453 454 455 456 457 458 459
        return -1;

    if (strcspn(name, bad) != strlen(name))
        return -1;

    return 0;
}

/* see if one of the strings in arr starts with str */
static int
array_starts_with(const char *str, const char * const *arr, const long size)
{
460
    size_t i;
J
Jamie Strandboge 已提交
461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508
    for (i = 0; i < size; i++) {
        if (strlen(str) < strlen(arr[i]))
            continue;

        if (STRPREFIX(str, arr[i]))
            return 0;
    }
    return 1;
}

/*
 * Don't allow access to special files or restricted paths such as /bin, /sbin,
 * /usr/bin, /usr/sbin and /etc. This is in an effort to prevent read/write
 * access to system files which could be used to elevate privileges. This is a
 * safety measure in case libvirtd is under a restrictive profile and is
 * subverted and trying to escape confinement.
 *
 * Note that we cannot exclude block devices because they are valid devices.
 * The TEMPLATE file can be adjusted to explicitly disallow these if needed.
 *
 * RETURN: -1 on error, 0 if ok, 1 if blocked
 */
static int
valid_path(const char *path, const bool readonly)
{
    const char * const restricted[] = {
        "/bin/",
        "/etc/",
        "/lib",
        "/lost+found/",
        "/proc/",
        "/sbin/",
        "/selinux/",
        "/sys/",
        "/usr/bin/",
        "/usr/lib",
        "/usr/sbin/",
        "/usr/share/",
        "/usr/local/bin/",
        "/usr/local/etc/",
        "/usr/local/lib",
        "/usr/local/sbin/"
    };
    /* these paths are ok for readonly, but not read/write */
    const char * const restricted_rw[] = {
        "/boot/",
        "/vmlinuz",
        "/initrd",
509
        "/initrd.img",
510
        "/usr/share/OVMF/",              /* for OVMF images */
511 512
        "/usr/share/ovmf/",              /* for OVMF images */
        "/usr/share/AAVMF/",             /* for AAVMF images */
513 514
        "/usr/share/qemu-efi/",          /* for AAVMF images */
        "/usr/share/qemu-efi-aarch64/"   /* for AAVMF images */
J
Jamie Strandboge 已提交
515
    };
516 517
    /* override the above with these */
    const char * const override[] = {
J
John Ferlan 已提交
518
        "/sys/devices/pci",              /* for hostdev pci devices */
519
        "/etc/libvirt-sandbox/services/" /* for virt-sandbox service config */
520
    };
J
Jamie Strandboge 已提交
521

522 523 524 525
    const int nropaths = ARRAY_CARDINALITY(restricted);
    const int nrwpaths = ARRAY_CARDINALITY(restricted_rw);
    const int nopaths = ARRAY_CARDINALITY(override);

526
    if (path == NULL) {
527
        vah_error(NULL, 0, _("bad pathname"));
J
Jamie Strandboge 已提交
528 529 530 531 532 533 534 535 536
        return -1;
    }

    /* Don't allow double quotes, since we use them to quote the filename
     * and this will confuse the apparmor parser.
     */
    if (strchr(path, '"') != NULL)
        return 1;

J
Jamie Strandboge 已提交
537 538 539 540
    /* Require an absolute path */
    if (STRNEQLEN(path, "/", 1))
        return 1;

541
    if (!virFileExists(path))
542
        vah_warning(_("path does not exist, skipping file type checks"));
J
Jamie Strandboge 已提交
543

544
    /* overrides are always allowed */
545
    if (array_starts_with(path, override, nopaths) == 0)
546
        return 0;
J
Jamie Strandboge 已提交
547

548 549
    /* allow read only paths upfront */
    if (readonly) {
550
        if (array_starts_with(path, restricted_rw, nrwpaths) == 0)
551
            return 0;
J
Jamie Strandboge 已提交
552 553
    }

554
    /* disallow RW acess to all paths in restricted and restriced_rw */
555 556
    if ((array_starts_with(path, restricted, nropaths) == 0 ||
         array_starts_with(path, restricted_rw, nrwpaths) == 0))
557 558
        return 1;

J
Jamie Strandboge 已提交
559 560 561
    return 0;
}

562 563 564 565 566 567 568
static int
verify_xpath_context(xmlXPathContextPtr ctxt)
{
    int rc = -1;
    char *tmp = NULL;

    if (!ctxt) {
569
        vah_warning(_("Invalid context"));
570 571 572 573 574
        goto error;
    }

    /* check if have <name> */
    if (!(tmp = virXPathString("string(./name[1])", ctxt))) {
575
        vah_warning(_("Could not find <name>"));
576 577 578 579 580 581
        goto error;
    }
    VIR_FREE(tmp);

    /* check if have <uuid> */
    if (!(tmp = virXPathString("string(./uuid[1])", ctxt))) {
582
        vah_warning(_("Could not find <uuid>"));
583 584 585 586 587 588
        goto error;
    }
    VIR_FREE(tmp);

    rc = 0;

589
 error:
590 591 592
    return rc;
}

593 594
/*
 * Parse the xml we received to fill in the following:
595
 * ctl->virtType
596
 * ctl->os
597 598 599 600 601 602 603 604 605 606
 * ctl->arch
 *
 * These are suitable for setting up a virCapsPtr
 */
static int
caps_mockup(vahControl * ctl, const char *xmlStr)
{
    int rc = -1;
    xmlDocPtr xml = NULL;
    xmlXPathContextPtr ctxt = NULL;
607
    char *arch;
608

609
    if (!(xml = virXMLParseStringCtxt(xmlStr, _("(domain_definition)"),
610
                                      &ctxt))) {
611 612 613
        goto cleanup;
    }

614
    if (!virXMLNodeNameEqual(ctxt->node, "domain")) {
615
        vah_error(NULL, 0, _("unexpected root element, expecting <domain>"));
616 617 618
        goto cleanup;
    }

619 620 621 622
    /* Quick sanity check for some required elements */
    if (verify_xpath_context(ctxt) != 0)
        goto cleanup;

623 624 625 626 627
    ctl->virtType = virXPathString("string(./@type)", ctxt);
    if (!ctl->virtType) {
        vah_error(ctl, 0, _("domain type is not defined"));
        goto cleanup;
    }
628 629
    ctl->os = virXPathString("string(./os/type[1])", ctxt);
    if (!ctl->os) {
630
        vah_error(ctl, 0, _("os.type is not defined"));
631 632
        goto cleanup;
    }
633 634 635 636 637 638
    arch = virXPathString("string(./os/type[1]/@arch)", ctxt);
    if (!arch) {
        ctl->arch = virArchFromHost();
    } else {
        ctl->arch = virArchFromString(arch);
        VIR_FREE(arch);
639 640 641 642
    }

    rc = 0;

643
 cleanup:
644
    xmlFreeDoc(xml);
645 646 647 648 649
    xmlXPathFreeContext(ctxt);

    return rc;
}

650 651 652 653 654
virDomainDefParserConfig virAAHelperDomainDefParserConfig = {
    .features = VIR_DOMAIN_DEF_FEATURE_MEMORY_HOTPLUG |
                VIR_DOMAIN_DEF_FEATURE_OFFLINE_VCPUPIN |
                VIR_DOMAIN_DEF_FEATURE_INDIVIDUAL_VCPUS,
};
655

J
Jamie Strandboge 已提交
656 657 658
static int
get_definition(vahControl * ctl, const char *xmlStr)
{
659
    int rc = -1, ostype, virtType;
J
Jamie Strandboge 已提交
660 661 662 663 664 665
    virCapsGuestPtr guest;  /* this is freed when caps is freed */

    /*
     * mock up some capabilities. We don't currently use these explicitly,
     * but need them for virDomainDefParseString().
     */
666 667
    if (caps_mockup(ctl, xmlStr) != 0)
        goto exit;
J
Jamie Strandboge 已提交
668

669
    if ((ctl->caps = virCapabilitiesNew(ctl->arch, true, true)) == NULL) {
670
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
671 672 673
        goto exit;
    }

674 675
    if (!(ctl->xmlopt = virDomainXMLOptionNew(&virAAHelperDomainDefParserConfig,
                                              NULL, NULL, NULL, NULL))) {
676 677 678 679
        vah_error(ctl, 0, _("Failed to create XML config object"));
        goto exit;
    }

680
    if ((ostype = virDomainOSTypeFromString(ctl->os)) < 0) {
681 682 683 684
        vah_error(ctl, 0, _("unknown OS type"));
        goto exit;
    }

J
Jamie Strandboge 已提交
685
    if ((guest = virCapabilitiesAddGuest(ctl->caps,
686
                                         ostype,
687
                                         ctl->arch,
J
Jamie Strandboge 已提交
688 689 690 691
                                         NULL,
                                         NULL,
                                         0,
                                         NULL)) == NULL) {
692
        vah_error(ctl, 0, _("could not allocate memory"));
693 694 695 696 697 698 699 700 701 702 703 704 705 706 707
        goto exit;
    }

    if ((virtType = virDomainVirtTypeFromString(ctl->virtType)) < 0) {
        vah_error(ctl, 0, _("unknown virtualization type"));
        goto exit;
    }

    if (virCapabilitiesAddGuestDomain(guest,
                                      virtType,
                                      NULL,
                                      NULL,
                                      0,
                                      NULL) == NULL) {
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
708 709 710
        goto exit;
    }

711
    ctl->def = virDomainDefParseString(xmlStr,
712
                                       ctl->caps, ctl->xmlopt, NULL,
713
                                       VIR_DOMAIN_DEF_PARSE_SKIP_SECLABEL |
714
                                       VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE);
715

J
Jamie Strandboge 已提交
716
    if (ctl->def == NULL) {
717
        vah_error(ctl, 0, _("could not parse XML"));
J
Jamie Strandboge 已提交
718 719 720 721
        goto exit;
    }

    if (!ctl->def->name) {
722
        vah_error(ctl, 0, _("could not find name in XML"));
J
Jamie Strandboge 已提交
723 724 725 726
        goto exit;
    }

    if (valid_name(ctl->def->name) != 0) {
727
        vah_error(ctl, 0, _("bad name"));
J
Jamie Strandboge 已提交
728 729 730 731 732
        goto exit;
    }

    rc = 0;

733
 exit:
J
Jamie Strandboge 已提交
734 735 736
    return rc;
}

737 738 739 740
/**
  * The permissions allowed are apparmor valid permissions and 'R'. 'R' stands for
  * read with no explicit deny rule.
  */
J
Jamie Strandboge 已提交
741
static int
F
Felix Geyer 已提交
742
vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool recursive)
J
Jamie Strandboge 已提交
743 744 745 746
{
    char *tmp = NULL;
    int rc = -1;
    bool readonly = true;
747 748
    bool explicit_deny_rule = true;
    char *sub = NULL;
749
    char *perms_new = NULL;
750 751 752
    char *pathdir = NULL;
    char *pathtmp = NULL;
    char *pathreal = NULL;
J
Jamie Strandboge 已提交
753 754 755 756

    if (path == NULL)
        return rc;

J
Jamie Strandboge 已提交
757 758 759 760 761 762
    /* Skip files without an absolute path. Not having one confuses the
     * apparmor parser and this also ensures things like tcp consoles don't
     * get added to the profile.
     */
    if (STRNEQLEN(path, "/", 1)) {
        vah_warning(path);
763
        vah_warning(_("skipped non-absolute path"));
J
Jamie Strandboge 已提交
764 765 766
        return 0;
    }

767 768 769 770 771 772 773
    /* files might be created by qemu later on and not exist right now.
     * But realpath needs a valid path to work on, therefore:
     * 1. walk the path to find longest valid path
     * 2. get the realpath of that valid path
     * 3. re-combine the realpath with the remaining suffix
     * Note: A totally non existent path is used as-is
     */
774
     if (VIR_STRDUP_QUIET(pathdir, path) < 0)
775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793
         goto cleanup;
     while (!virFileExists(pathdir)) {
         if ((pathtmp = mdir_name(pathdir)) == NULL)
             goto cleanup;
         VIR_FREE(pathdir);
         VIR_STEAL_PTR(pathdir, pathtmp);
     }

    if (strlen(pathdir) == 1) {
        /* nothing of the path does exist yet */
        if (VIR_STRDUP_QUIET(tmp, path) < 0)
            goto cleanup;
    } else {
        if (VIR_STRDUP_QUIET(pathtmp, path+strlen(pathdir)) < 0)
            goto cleanup;
        if ((pathreal = realpath(pathdir, NULL)) == NULL) {
            vah_error(NULL, 0, pathdir);
            vah_error(NULL, 0, _("could not find realpath"));
            goto cleanup;
J
Jamie Strandboge 已提交
794
        }
795 796
        if (virAsprintfQuiet(&tmp, "%s%s", pathreal, pathtmp) < 0)
            goto cleanup;
797
    }
J
Jamie Strandboge 已提交
798

799
    if (VIR_STRDUP_QUIET(perms_new, perms) < 0)
800
        goto cleanup;
801 802

    if (strchr(perms_new, 'w') != NULL) {
J
Jamie Strandboge 已提交
803
        readonly = false;
804 805 806
        explicit_deny_rule = false;
    }

807
    if ((sub = strchr(perms_new, 'R')) != NULL) {
808 809 810 811
        /* Don't write the invalid R permission, replace it with 'r' */
        sub[0] = 'r';
        explicit_deny_rule = false;
    }
J
Jamie Strandboge 已提交
812 813 814 815 816

    rc = valid_path(tmp, readonly);
    if (rc != 0) {
        if (rc > 0) {
            vah_error(NULL, 0, path);
817
            vah_error(NULL, 0, _("skipped restricted file"));
J
Jamie Strandboge 已提交
818
        }
819
        goto cleanup;
J
Jamie Strandboge 已提交
820 821
    }

822 823 824
    if (tmp[strlen(tmp) - 1] == '/')
        tmp[strlen(tmp) - 1] = '\0';

825 826
    virBufferAsprintf(buf, "  \"%s%s\" %s,\n", tmp, recursive ? "/**" : "",
                      perms_new);
827
    if (explicit_deny_rule) {
828
        virBufferAddLit(buf, "  # don't audit writes to readonly files\n");
F
Felix Geyer 已提交
829 830 831 832 833
        virBufferAsprintf(buf, "  deny \"%s%s\" w,\n", tmp, recursive ? "/**" : "");
    }
    if (recursive) {
        /* allow reading (but not creating) the dir */
        virBufferAsprintf(buf, "  \"%s/\" r,\n", tmp);
834
    }
J
Jamie Strandboge 已提交
835

836
 cleanup:
837 838 839
    VIR_FREE(pathdir);
    VIR_FREE(pathtmp);
    VIR_FREE(pathreal);
840
    VIR_FREE(perms_new);
841
    VIR_FREE(tmp);
J
Jamie Strandboge 已提交
842 843 844 845

    return rc;
}

F
Felix Geyer 已提交
846 847 848 849 850 851
static int
vah_add_file(virBufferPtr buf, const char *path, const char *perms)
{
    return vah_add_path(buf, path, perms, false);
}

852 853 854 855 856 857 858 859 860 861 862 863
static int
vah_add_file_chardev(virBufferPtr buf,
                     const char *path,
                     const char *perms,
                     const int type)
{
    char *pipe_in;
    char *pipe_out;
    int rc = -1;

    if (type == VIR_DOMAIN_CHR_TYPE_PIPE) {
        /* add the pipe input */
864
        if (virAsprintfQuiet(&pipe_in, "%s.in", path) == -1) {
865
            vah_error(NULL, 0, _("could not allocate memory"));
866
            goto cleanup;
867 868 869 870 871 872
        }

        if (vah_add_file(buf, pipe_in, perms) != 0)
            goto clean_pipe_in;

        /* add the pipe output */
873
        if (virAsprintfQuiet(&pipe_out, "%s.out", path) == -1) {
874 875 876 877 878 879 880 881 882 883 884 885 886 887 888
            vah_error(NULL, 0, _("could not allocate memory"));
            goto clean_pipe_in;
        }

        if (vah_add_file(buf, pipe_out, perms) != 0)
            goto clean_pipe_out;

        rc = 0;
      clean_pipe_out:
        VIR_FREE(pipe_out);
      clean_pipe_in:
        VIR_FREE(pipe_in);
    } else {
        /* add the file */
        if (vah_add_file(buf, path, perms) != 0)
889
            goto cleanup;
890 891 892
        rc = 0;
    }

893
 cleanup:
894 895 896
    return rc;
}

J
Jamie Strandboge 已提交
897
static int
898
file_iterate_hostdev_cb(virUSBDevicePtr dev ATTRIBUTE_UNUSED,
899 900 901 902 903 904 905
                        const char *file, void *opaque)
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

static int
906 907
file_iterate_pci_cb(virPCIDevicePtr dev ATTRIBUTE_UNUSED,
                    const char *file, void *opaque)
J
Jamie Strandboge 已提交
908 909 910 911 912
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

913 914 915 916 917 918 919 920 921 922
static int
add_file_path(virDomainDiskDefPtr disk,
              const char *path,
              size_t depth,
              void *opaque)
{
    virBufferPtr buf = opaque;
    int ret;

    if (depth == 0) {
923
        if (disk->src->readonly)
924
            ret = vah_add_file(buf, path, "rk");
925
        else
926
            ret = vah_add_file(buf, path, "rwk");
927
    } else {
928
        ret = vah_add_file(buf, path, "rk");
929 930
    }

931 932 933
    if (ret != 0)
        ret = -1;

934 935 936
    return ret;
}

J
Jamie Strandboge 已提交
937 938 939 940 941
static int
get_files(vahControl * ctl)
{
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
942
    size_t i;
J
Jamie Strandboge 已提交
943 944
    char *uuid;
    char uuidstr[VIR_UUID_STRING_BUFLEN];
945
    bool needsVfio = false, needsvhost = false;
J
Jamie Strandboge 已提交
946 947 948

    /* verify uuid is same as what we were given on the command line */
    virUUIDFormat(ctl->def->uuid, uuidstr);
949
    if (virAsprintfQuiet(&uuid, "%s%s", AA_PREFIX, uuidstr) == -1) {
950
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
951 952 953 954
        return rc;
    }

    if (STRNEQ(uuid, ctl->uuid)) {
955
        vah_error(ctl, 0, _("given uuid does not match XML uuid"));
956
        goto cleanup;
J
Jamie Strandboge 已提交
957 958
    }

959 960
    /* load the storage driver so that backing store can be accessed */
#ifdef WITH_STORAGE
961
    virDriverLoadModule("storage", "storageRegister", false);
962
#endif
963

964
    for (i = 0; i < ctl->def->ndisks; i++) {
965 966
        virDomainDiskDefPtr disk = ctl->def->disks[i];

967
        if (!virDomainDiskGetSource(disk))
E
Eric Blake 已提交
968
            continue;
969 970 971
        /* XXX - if we knew the qemu user:group here we could send it in
         *        so that the open could be re-tried as that user:group.
         */
972
        if (!virStorageSourceHasBacking(disk->src))
973
            virStorageFileGetMetadata(disk->src, -1, -1, false);
974

975 976 977
        /* XXX passing ignoreOpenFailure = true to get back to the behavior
         * from before using virDomainDiskDefForeachPath. actually we should
         * be passing ignoreOpenFailure = false and handle open errors more
978 979
         * careful than just ignoring them.
         */
980
        if (virDomainDiskDefForeachPath(disk, true, add_file_path, &buf) < 0)
981
            goto cleanup;
982
    }
J
Jamie Strandboge 已提交
983 984

    for (i = 0; i < ctl->def->nserials; i++)
985
        if (ctl->def->serials[i] &&
986 987 988 989 990 991 992
            (ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->serials[i]->source->data.file.path &&
            ctl->def->serials[i]->source->data.file.path[0] != '\0')
993
            if (vah_add_file_chardev(&buf,
994
                                     ctl->def->serials[i]->source->data.file.path,
995
                                     "rw",
996
                                     ctl->def->serials[i]->source->type) != 0)
997
                goto cleanup;
J
Jamie Strandboge 已提交
998

999 1000
    for (i = 0; i < ctl->def->nconsoles; i++)
        if (ctl->def->consoles[i] &&
1001 1002 1003 1004 1005 1006 1007
            (ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->consoles[i]->source->data.file.path &&
            ctl->def->consoles[i]->source->data.file.path[0] != '\0')
1008
            if (vah_add_file(&buf,
1009
                             ctl->def->consoles[i]->source->data.file.path, "rw") != 0)
1010
                goto cleanup;
J
Jamie Strandboge 已提交
1011

1012
    for (i = 0; i < ctl->def->nparallels; i++)
1013
        if (ctl->def->parallels[i] &&
1014 1015 1016 1017 1018 1019 1020
            (ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->parallels[i]->source->data.file.path &&
            ctl->def->parallels[i]->source->data.file.path[0] != '\0')
1021
            if (vah_add_file_chardev(&buf,
1022
                                     ctl->def->parallels[i]->source->data.file.path,
1023
                                     "rw",
1024
                                     ctl->def->parallels[i]->source->type) != 0)
1025
                goto cleanup;
1026

1027
    for (i = 0; i < ctl->def->nchannels; i++)
1028
        if (ctl->def->channels[i] &&
1029 1030 1031 1032 1033 1034 1035
            (ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->channels[i]->source->data.file.path &&
            ctl->def->channels[i]->source->data.file.path[0] != '\0')
1036
            if (vah_add_file_chardev(&buf,
1037
                                     ctl->def->channels[i]->source->data.file.path,
1038
                                     "rw",
1039
                                     ctl->def->channels[i]->source->type) != 0)
1040
                goto cleanup;
1041

1042
    if (ctl->def->os.kernel)
J
Jamie Strandboge 已提交
1043
        if (vah_add_file(&buf, ctl->def->os.kernel, "r") != 0)
1044
            goto cleanup;
J
Jamie Strandboge 已提交
1045

1046
    if (ctl->def->os.initrd)
J
Jamie Strandboge 已提交
1047
        if (vah_add_file(&buf, ctl->def->os.initrd, "r") != 0)
1048
            goto cleanup;
O
Olivia Yin 已提交
1049 1050 1051

    if (ctl->def->os.dtb)
        if (vah_add_file(&buf, ctl->def->os.dtb, "r") != 0)
1052
            goto cleanup;
J
Jamie Strandboge 已提交
1053

J
Ján Tomko 已提交
1054 1055 1056 1057
    if (ctl->def->os.slic_table)
        if (vah_add_file(&buf, ctl->def->os.slic_table, "r") != 0)
            goto cleanup;

1058
    if (ctl->def->os.loader && ctl->def->os.loader->path)
1059
        if (vah_add_file(&buf, ctl->def->os.loader->path, "rk") != 0)
1060
            goto cleanup;
1061

1062
    if (ctl->def->os.loader && ctl->def->os.loader->nvram)
1063
        if (vah_add_file(&buf, ctl->def->os.loader->nvram, "rwk") != 0)
1064 1065
            goto cleanup;

1066
    for (i = 0; i < ctl->def->ngraphics; i++) {
1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077
        virDomainGraphicsDefPtr graphics = ctl->def->graphics[i];
        size_t n;

        for (n = 0; n < graphics->nListens; n++) {
            virDomainGraphicsListenDef listenObj = graphics->listens[n];

            if (listenObj.type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET &&
                listenObj.socket &&
                vah_add_file(&buf, listenObj.socket, "rw"))
                goto cleanup;
        }
1078 1079
    }

1080 1081 1082 1083
    if (ctl->def->ngraphics == 1 &&
        ctl->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL)
        if (vah_add_file(&buf, ctl->def->graphics[0]->data.sdl.xauth,
                         "r") != 0)
1084
            goto cleanup;
J
Jamie Strandboge 已提交
1085 1086 1087 1088

    for (i = 0; i < ctl->def->nhostdevs; i++)
        if (ctl->def->hostdevs[i]) {
            virDomainHostdevDefPtr dev = ctl->def->hostdevs[i];
1089
            virDomainHostdevSubsysUSBPtr usbsrc = &dev->source.subsys.u.usb;
J
Jamie Strandboge 已提交
1090 1091
            switch (dev->source.subsys.type) {
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: {
1092
                virUSBDevicePtr usb =
1093
                    virUSBDeviceNew(usbsrc->bus, usbsrc->device, NULL);
1094 1095 1096 1097

                if (usb == NULL)
                    continue;

1098 1099 1100
                if (virHostdevFindUSBDevice(dev, true, &usb) < 0)
                    continue;

1101 1102
                rc = virUSBDeviceFileIterate(usb, file_iterate_hostdev_cb, &buf);
                virUSBDeviceFree(usb);
1103
                if (rc != 0)
1104
                    goto cleanup;
J
Jamie Strandboge 已提交
1105 1106
                break;
            }
1107

1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: {
                virDomainHostdevSubsysMediatedDevPtr mdevsrc = &dev->source.subsys.u.mdev;
                switch ((virMediatedDeviceModelType) mdevsrc->model) {
                    case VIR_MDEV_MODEL_TYPE_VFIO_PCI:
                    case VIR_MDEV_MODEL_TYPE_VFIO_AP:
                    case VIR_MDEV_MODEL_TYPE_VFIO_CCW:
                        needsVfio = true;
                        break;
                    case VIR_MDEV_MODEL_TYPE_LAST:
                    default:
                        virReportEnumRangeError(virMediatedDeviceModelType,
                                                mdevsrc->model);
                        break;
                }
                break;
            }

J
Jamie Strandboge 已提交
1125
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: {
1126
                virPCIDevicePtr pci = virPCIDeviceNew(
1127 1128 1129 1130
                           dev->source.subsys.u.pci.addr.domain,
                           dev->source.subsys.u.pci.addr.bus,
                           dev->source.subsys.u.pci.addr.slot,
                           dev->source.subsys.u.pci.addr.function);
J
Jamie Strandboge 已提交
1131

1132
                virDomainHostdevSubsysPCIBackendType backend = dev->source.subsys.u.pci.backend;
1133 1134 1135 1136 1137
                if (backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO ||
                        backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT) {
                    needsVfio = true;
                }

J
Jamie Strandboge 已提交
1138 1139 1140
                if (pci == NULL)
                    continue;

1141 1142
                rc = virPCIDeviceFileIterate(pci, file_iterate_pci_cb, &buf);
                virPCIDeviceFree(pci);
J
Jamie Strandboge 已提交
1143 1144 1145

                break;
            }
1146

J
Jamie Strandboge 已提交
1147 1148 1149 1150 1151 1152
            default:
                rc = 0;
                break;
            } /* switch */
        }

F
Felix Geyer 已提交
1153 1154 1155 1156 1157
    for (i = 0; i < ctl->def->nfss; i++) {
        if (ctl->def->fss[i] &&
                ctl->def->fss[i]->type == VIR_DOMAIN_FS_TYPE_MOUNT &&
                (ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_PATH ||
                 ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT) &&
1158
                ctl->def->fss[i]->src) {
F
Felix Geyer 已提交
1159 1160
            virDomainFSDefPtr fs = ctl->def->fss[i];

1161 1162 1163
            /* We don't need to add deny rw rules for readonly mounts,
             * this can only lead to troubles when mounting / readonly.
             */
1164
            if (vah_add_path(&buf, fs->src->path, fs->readonly ? "R" : "rw", true) != 0)
F
Felix Geyer 已提交
1165 1166 1167 1168
                goto cleanup;
        }
    }

1169 1170 1171 1172 1173 1174 1175 1176
    for (i = 0; i < ctl->def->ninputs; i++) {
        if (ctl->def->inputs[i] &&
                ctl->def->inputs[i]->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) {
            if (vah_add_file(&buf, ctl->def->inputs[i]->source.evdev, "rw") != 0)
                goto cleanup;
        }
    }

1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188
    for (i = 0; i < ctl->def->nnets; i++) {
        if (ctl->def->nets[i] &&
                ctl->def->nets[i]->type == VIR_DOMAIN_NET_TYPE_VHOSTUSER &&
                ctl->def->nets[i]->data.vhostuser) {
            virDomainChrSourceDefPtr vhu = ctl->def->nets[i]->data.vhostuser;

            if (vah_add_file_chardev(&buf, vhu->data.nix.path, "rw",
                       vhu->type) != 0)
                goto cleanup;
        }
    }

1189 1190 1191 1192 1193 1194 1195 1196
    for (i = 0; i < ctl->def->nmems; i++) {
        if (ctl->def->mems[i] &&
                ctl->def->mems[i]->model == VIR_DOMAIN_MEMORY_MODEL_NVDIMM) {
            if (vah_add_file(&buf, ctl->def->mems[i]->nvdimmPath, "rw") != 0)
                goto cleanup;
        }
    }

1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241
    if (ctl->def->tpm) {
        char *shortName = NULL;
        const char *tpmpath = NULL;

        switch (ctl->def->tpm->type) {
        case VIR_DOMAIN_TPM_TYPE_EMULATOR:
            shortName = virDomainDefGetShortName(ctl->def);

            switch (ctl->def->tpm->version) {
            case VIR_DOMAIN_TPM_VERSION_1_2:
                tpmpath = "tpm1.2";
                break;
            case VIR_DOMAIN_TPM_VERSION_2_0:
                tpmpath = "tpm2";
                break;
            case VIR_DOMAIN_TPM_VERSION_DEFAULT:
            case VIR_DOMAIN_TPM_VERSION_LAST:
                break;
            }

            /* Unix socket for QEMU and swtpm to use */
            virBufferAsprintf(&buf,
                "  \"/run/libvirt/qemu/swtpm/%s-swtpm.sock\" rw,\n",
                shortName);
            /* Paths for swtpm to use: give it access to its state
             * directory, log, and PID files.
             */
            virBufferAsprintf(&buf,
                "  \"%s/lib/libvirt/swtpm/%s/%s/**\" rw,\n",
                LOCALSTATEDIR, uuidstr, tpmpath);
            virBufferAsprintf(&buf,
                "  \"%s/log/swtpm/libvirt/qemu/%s-swtpm.log\" a,\n",
                LOCALSTATEDIR, ctl->def->name);
            virBufferAsprintf(&buf,
                "  \"/run/libvirt/qemu/swtpm/%s-swtpm.pid\" rw,\n",
                shortName);

            VIR_FREE(shortName);
            break;
        case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
        case VIR_DOMAIN_TPM_TYPE_LAST:
            break;
        }
    }

1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254
    if (ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
        for (i = 0; i < ctl->def->nnets; i++) {
            virDomainNetDefPtr net = ctl->def->nets[i];
            if (net && net->model) {
                if (net->driver.virtio.name == VIR_DOMAIN_NET_BACKEND_TYPE_QEMU)
                    continue;
                if (STRNEQ(net->model, "virtio"))
                    continue;
            }
            needsvhost = true;
        }
    }
    if (needsvhost)
1255
        virBufferAddLit(&buf, "  \"/dev/vhost-net\" rw,\n");
1256

1257
    if (needsVfio) {
1258 1259
        virBufferAddLit(&buf, "  \"/dev/vfio/vfio\" rw,\n");
        virBufferAddLit(&buf, "  \"/dev/vfio/[0-9]*\" rw,\n");
1260 1261
    }

1262
    if (ctl->newfile)
1263
        if (vah_add_file(&buf, ctl->newfile, "rwk") != 0)
1264
            goto cleanup;
J
Jamie Strandboge 已提交
1265 1266

    if (virBufferError(&buf)) {
1267
        virBufferFreeAndReset(&buf);
1268
        vah_error(NULL, 0, _("failed to allocate file buffer"));
1269
        goto cleanup;
J
Jamie Strandboge 已提交
1270 1271 1272 1273 1274
    }

    rc = 0;
    ctl->files = virBufferContentAndReset(&buf);

1275
 cleanup:
J
Jamie Strandboge 已提交
1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289
    VIR_FREE(uuid);
    return rc;
}

static int
vahParseArgv(vahControl * ctl, int argc, char **argv)
{
    int arg, idx = 0;
    struct option opt[] = {
        {"add", 0, 0, 'a'},
        {"create", 0, 0, 'c'},
        {"dryrun", 0, 0, 'd'},
        {"delete", 0, 0, 'D'},
        {"add-file", 0, 0, 'f'},
1290
        {"append-file", 0, 0, 'F'},
J
Jamie Strandboge 已提交
1291 1292 1293 1294 1295 1296 1297
        {"help", 0, 0, 'h'},
        {"replace", 0, 0, 'r'},
        {"remove", 0, 0, 'R'},
        {"uuid", 1, 0, 'u'},
        {0, 0, 0, 0}
    };

1298
    while ((arg = getopt_long(argc, argv, "acdDhrRH:b:u:p:f:F:", opt,
J
Jamie Strandboge 已提交
1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313
            &idx)) != -1) {
        switch (arg) {
            case 'a':
                ctl->cmd = 'a';
                break;
            case 'c':
                ctl->cmd = 'c';
                break;
            case 'd':
                ctl->dryrun = true;
                break;
            case 'D':
                ctl->cmd = 'D';
                break;
            case 'f':
1314
            case 'F':
1315
                if (VIR_STRDUP_QUIET(ctl->newfile, optarg) < 0)
1316
                    vah_error(ctl, 1, _("could not allocate memory for disk"));
1317
                ctl->append = arg == 'F';
J
Jamie Strandboge 已提交
1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330
                break;
            case 'h':
                vah_usage();
                exit(EXIT_SUCCESS);
                break;
            case 'r':
                ctl->cmd = 'r';
                break;
            case 'R':
                ctl->cmd = 'R';
                break;
            case 'u':
                if (strlen(optarg) > PROFILE_NAME_SIZE - 1)
1331
                    vah_error(ctl, 1, _("invalid UUID"));
1332
                if (virStrcpy((char *)ctl->uuid, optarg,
1333
                    PROFILE_NAME_SIZE) < 0)
1334
                    vah_error(ctl, 1, _("error copying UUID"));
J
Jamie Strandboge 已提交
1335 1336
                break;
            default:
1337
                vah_error(ctl, 1, _("unsupported option"));
J
Jamie Strandboge 已提交
1338 1339 1340 1341
                break;
        }
    }
    if (strchr("acDrR", ctl->cmd) == NULL)
1342
        vah_error(ctl, 1, _("bad command"));
J
Jamie Strandboge 已提交
1343 1344

    if (valid_uuid(ctl->uuid) != 0)
1345
        vah_error(ctl, 1, _("invalid UUID"));
J
Jamie Strandboge 已提交
1346 1347 1348 1349 1350 1351 1352 1353 1354

    if (!ctl->cmd) {
        vah_usage();
        exit(EXIT_FAILURE);
    }

    if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *xmlStr = NULL;
        if (virFileReadLimFD(STDIN_FILENO, MAX_FILE_LEN, &xmlStr) < 0)
1355
            vah_error(ctl, 1, _("could not read xml file"));
J
Jamie Strandboge 已提交
1356 1357 1358

        if (get_definition(ctl, xmlStr) != 0 || ctl->def == NULL) {
            VIR_FREE(xmlStr);
1359
            vah_error(ctl, 1, _("could not get VM definition"));
J
Jamie Strandboge 已提交
1360 1361 1362 1363
        }
        VIR_FREE(xmlStr);

        if (get_files(ctl) != 0)
1364
            vah_error(ctl, 1, _("invalid VM definition"));
J
Jamie Strandboge 已提交
1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382
    }
    return 0;
}


/*
 * virt-aa-helper -c -u UUID < file.xml
 * virt-aa-helper -r -u UUID [-f <file>] < file.xml
 * virt-aa-helper -a -u UUID
 * virt-aa-helper -R -u UUID
 * virt-aa-helper -D -u UUID
 */
int
main(int argc, char **argv)
{
    vahControl _ctl, *ctl = &_ctl;
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
1383 1384
    char *profile = NULL;
    char *include_file = NULL;
J
Jamie Strandboge 已提交
1385

1386 1387
    if (virGettextInitialize() < 0 ||
        virThreadInitialize() < 0 ||
1388 1389 1390 1391 1392
        virErrorInitialize() < 0) {
        fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
        exit(EXIT_FAILURE);
    }

1393 1394
    virFileActivateDirOverride(argv[0]);

1395 1396 1397
    /* Initialize the log system */
    virLogSetFromEnv();

J
Jamie Strandboge 已提交
1398 1399
    /* clear the environment */
    environ = NULL;
1400
    if (setenv("PATH", "/sbin:/usr/sbin", 1) != 0)
1401 1402
        vah_error(ctl, 1, _("could not set PATH"));

1403
    /* ensure the traditional IFS setting */
1404
    if (setenv("IFS", " \t\n", 1) != 0)
1405
        vah_error(ctl, 1, _("could not set IFS"));
J
Jamie Strandboge 已提交
1406 1407 1408 1409 1410 1411 1412 1413 1414

    if (!(progname = strrchr(argv[0], '/')))
        progname = argv[0];
    else
        progname++;

    memset(ctl, 0, sizeof(vahControl));

    if (vahParseArgv(ctl, argc, argv) != 0)
1415
        vah_error(ctl, 1, _("could not parse arguments"));
J
Jamie Strandboge 已提交
1416

1417 1418
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1419
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1420

1421 1422
    if (virAsprintfQuiet(&include_file, "%s/%s.files",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1423
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1424

1425
    if (ctl->cmd == 'a') {
J
Jamie Strandboge 已提交
1426
        rc = parserLoad(ctl->uuid);
1427
    } else if (ctl->cmd == 'R' || ctl->cmd == 'D') {
J
Jamie Strandboge 已提交
1428 1429 1430 1431 1432 1433 1434 1435
        rc = parserRemove(ctl->uuid);
        if (ctl->cmd == 'D') {
            unlink(include_file);
            unlink(profile);
        }
    } else if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *included_files = NULL;

1436
        if (ctl->cmd == 'c' && virFileExists(profile))
1437
            vah_error(ctl, 1, _("profile exists"));
J
Jamie Strandboge 已提交
1438

1439
        if (ctl->append && ctl->newfile) {
1440
            if (vah_add_file(&buf, ctl->newfile, "rwk") != 0)
1441
                goto cleanup;
1442
        } else {
1443 1444 1445
            if (ctl->def->virtType == VIR_DOMAIN_VIRT_QEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KQEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
1446 1447
                virBufferAsprintf(&buf, "  \"%s/log/libvirt/**/%s.log\" w,\n",
                                  LOCALSTATEDIR, ctl->def->name);
1448
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%s/monitor.sock\" rw,\n",
1449
                                  LOCALSTATEDIR, ctl->def->name);
1450 1451
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%d-%.*s/*\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->id, 20, ctl->def->name);
1452 1453 1454 1455 1456 1457 1458 1459 1460
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/%s.pid\" rwk,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/%s.pid\" rwk,\n",
                                  ctl->def->name);
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  ctl->def->name);
            }
1461
            if (ctl->files)
1462
                virBufferAdd(&buf, ctl->files, -1);
1463
        }
J
Jamie Strandboge 已提交
1464

1465 1466
        if (virBufferError(&buf)) {
            virBufferFreeAndReset(&buf);
1467
            vah_error(ctl, 1, _("failed to allocate buffer"));
1468
        }
J
Jamie Strandboge 已提交
1469 1470 1471 1472 1473 1474 1475 1476

        included_files = virBufferContentAndReset(&buf);

        /* (re)create the include file using included_files */
        if (ctl->dryrun) {
            vah_info(include_file);
            vah_info(included_files);
            rc = 0;
1477 1478 1479
        } else if (ctl->def->virtType == VIR_DOMAIN_VIRT_LXC) {
            rc = 0;
        } else if ((rc = update_include_file(include_file,
1480
                                             included_files,
1481
                                             ctl->append)) != 0) {
1482
            goto cleanup;
1483
        }
J
Jamie Strandboge 已提交
1484 1485 1486 1487 1488


        /* create the profile from TEMPLATE */
        if (ctl->cmd == 'c') {
            char *tmp = NULL;
1489 1490
            if (virAsprintfQuiet(&tmp, "  #include <libvirt/%s.files>\n",
                                 ctl->uuid) == -1) {
1491
                vah_error(ctl, 0, _("could not allocate memory"));
1492
                goto cleanup;
J
Jamie Strandboge 已提交
1493 1494 1495 1496 1497 1498 1499
            }

            if (ctl->dryrun) {
                vah_info(profile);
                vah_info(ctl->uuid);
                vah_info(tmp);
                rc = 0;
1500 1501
            } else if ((rc = create_profile(profile, ctl->uuid, tmp,
                                            ctl->def->virtType)) != 0) {
1502
                vah_error(ctl, 0, _("could not create profile"));
J
Jamie Strandboge 已提交
1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520
                unlink(include_file);
            }
            VIR_FREE(tmp);
        }

        if (rc == 0 && !ctl->dryrun) {
            if (ctl->cmd == 'c')
                rc = parserLoad(ctl->uuid);
            else
                rc = parserReplace(ctl->uuid);

            /* cleanup */
            if (rc != 0) {
                unlink(include_file);
                if (ctl->cmd == 'c')
                    unlink(profile);
            }
        }
1521
      cleanup:
J
Jamie Strandboge 已提交
1522 1523 1524 1525
        VIR_FREE(included_files);
    }

    vahDeinit(ctl);
1526 1527 1528 1529

    VIR_FREE(profile);
    VIR_FREE(include_file);

J
Jamie Strandboge 已提交
1530 1531
    exit(rc == 0 ? EXIT_SUCCESS : EXIT_FAILURE);
}