virt-aa-helper.c 46.1 KB
Newer Older
J
Jamie Strandboge 已提交
1 2
/*
 * virt-aa-helper: wrapper program used by AppArmor security driver.
3
 *
4
 * Copyright (C) 2010-2014 Red Hat, Inc.
5
 * Copyright (C) 2009-2011 Canonical Ltd.
J
Jamie Strandboge 已提交
6
 *
O
Osier Yang 已提交
7 8 9 10 11 12 13 14 15 16 17
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
J
Jamie Strandboge 已提交
20 21 22 23 24 25 26 27 28 29 30 31
 */

#include <config.h>

#include <stdarg.h>
#include <unistd.h>
#include <sys/types.h>
#include <fcntl.h>
#include <getopt.h>
#include <sys/utsname.h>

#include "internal.h"
32
#include "virbuffer.h"
33
#include "viralloc.h"
34
#include "vircommand.h"
35
#include "virlog.h"
36
#include "dirname.h"
37
#include "driver.h"
J
Jamie Strandboge 已提交
38 39 40 41

#include "security_driver.h"
#include "security_apparmor.h"
#include "domain_conf.h"
42
#include "virxml.h"
43
#include "viruuid.h"
44
#include "virusb.h"
45
#include "virpci.h"
E
Eric Blake 已提交
46
#include "virfile.h"
47
#include "configmake.h"
48
#include "virrandom.h"
49
#include "virstring.h"
50
#include "virgettext.h"
51
#include "virhostdev.h"
J
Jamie Strandboge 已提交
52

53 54
#define VIR_FROM_THIS VIR_FROM_SECURITY

J
Jamie Strandboge 已提交
55 56 57 58 59 60 61 62 63 64 65 66
static char *progname;

typedef struct {
    char uuid[PROFILE_NAME_SIZE];       /* UUID of vm */
    bool dryrun;                /* dry run */
    char cmd;                   /* 'c'   create
                                 * 'a'   add (load)
                                 * 'r'   replace
                                 * 'R'   remove */
    char *files;                /* list of files */
    virDomainDefPtr def;        /* VM definition */
    virCapsPtr caps;            /* VM capabilities */
67
    virDomainXMLOptionPtr xmlopt; /* XML parser data */
68
    char *virtType;                  /* type of hypervisor (eg qemu, xen, lxc) */
69
    char *os;                   /* type of os (eg hvm, xen, exe) */
70
    virArch arch;               /* machine architecture */
71 72
    char *newfile;              /* newly added file */
    bool append;                /* append to .files instead of rewrite */
J
Jamie Strandboge 已提交
73 74 75 76 77 78 79 80 81
} vahControl;

static int
vahDeinit(vahControl * ctl)
{
    if (ctl == NULL)
        return -1;

    VIR_FREE(ctl->def);
82
    virObjectUnref(ctl->caps);
83
    virObjectUnref(ctl->xmlopt);
84
    VIR_FREE(ctl->files);
85
    VIR_FREE(ctl->virtType);
86
    VIR_FREE(ctl->os);
87
    VIR_FREE(ctl->newfile);
J
Jamie Strandboge 已提交
88 89 90 91 92 93 94 95 96 97

    return 0;
}

/*
 * Print usage
 */
static void
vah_usage(void)
{
98 99 100 101
    printf(_("\n%s [options] [< def.xml]\n\n"
            "  Options:\n"
            "    -a | --add                     load profile\n"
            "    -c | --create                  create profile from template\n"
102
            "    -d | --dryrun                  dry run\n"
103 104 105 106 107 108 109 110 111 112 113
            "    -D | --delete                  unload and delete profile\n"
            "    -f | --add-file <file>         add file to profile\n"
            "    -F | --append-file <file>      append file to profile\n"
            "    -r | --replace                 reload profile\n"
            "    -R | --remove                  unload profile\n"
            "    -h | --help                    this help\n"
            "    -u | --uuid <uuid>             uuid (profile name)\n"
            "\n"), progname);

    puts(_("This command is intended to be used by libvirtd "
           "and not used directly.\n"));
J
Jamie Strandboge 已提交
114 115 116 117 118 119
    return;
}

static void
vah_error(vahControl * ctl, int doexit, const char *str)
{
120
    fprintf(stderr, _("%s: error: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
121 122 123 124 125 126 127 128 129 130 131

    if (doexit) {
        if (ctl != NULL)
            vahDeinit(ctl);
        exit(EXIT_FAILURE);
    }
}

static void
vah_warning(const char *str)
{
132
    fprintf(stderr, _("%s: warning: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
133 134 135 136 137
}

static void
vah_info(const char *str)
{
138
    fprintf(stderr, _("%s:\n%s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
139 140 141 142 143 144 145 146
}

/*
 * run an apparmor_parser command
 */
static int
parserCommand(const char *profile_name, const char cmd)
{
147
    int result = -1;
J
Jamie Strandboge 已提交
148
    char flag[3];
149
    char *profile;
150 151
    int status;
    int ret;
J
Jamie Strandboge 已提交
152 153

    if (strchr("arR", cmd) == NULL) {
154
        vah_error(NULL, 0, _("invalid flag"));
J
Jamie Strandboge 已提交
155 156 157 158 159
        return -1;
    }

    snprintf(flag, 3, "-%c", cmd);

160 161
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", profile_name) < 0) {
162
        vah_error(NULL, 0, _("profile name exceeds maximum length"));
J
Jamie Strandboge 已提交
163 164 165 166
        return -1;
    }

    if (!virFileExists(profile)) {
167
        vah_error(NULL, 0, _("profile does not exist"));
168
        goto cleanup;
J
Jamie Strandboge 已提交
169 170 171 172
    } else {
        const char * const argv[] = {
            "/sbin/apparmor_parser", flag, profile, NULL
        };
173 174 175
        if ((ret = virRun(argv, &status)) != 0 ||
            (WIFEXITED(status) && WEXITSTATUS(status) != 0)) {
            if (ret != 0) {
176
                vah_error(NULL, 0, _("failed to run apparmor_parser"));
177
                goto cleanup;
178 179 180
            } else if (cmd == 'R' && WIFEXITED(status) &&
                       WEXITSTATUS(status) == 234) {
                vah_warning(_("unable to unload already unloaded profile"));
181
            } else {
182
                vah_error(NULL, 0, _("apparmor_parser exited with error"));
183
                goto cleanup;
184
            }
J
Jamie Strandboge 已提交
185 186 187
        }
    }

188 189
    result = 0;

190
 cleanup:
191 192 193
    VIR_FREE(profile);

    return result;
J
Jamie Strandboge 已提交
194 195 196 197 198 199
}

/*
 * Update the dynamic files
 */
static int
200 201
update_include_file(const char *include_file, const char *included_files,
                    bool append)
J
Jamie Strandboge 已提交
202 203
{
    int rc = -1;
204
    int plen, flen = 0;
J
Jamie Strandboge 已提交
205 206
    int fd;
    char *pcontent = NULL;
207
    char *existing = NULL;
J
Jamie Strandboge 已提交
208 209 210
    const char *warning =
         "# DO NOT EDIT THIS FILE DIRECTLY. IT IS MANAGED BY LIBVIRT.\n";

211 212 213 214 215 216 217
    if (virFileExists(include_file)) {
        flen = virFileReadAll(include_file, MAX_FILE_LEN, &existing);
        if (flen < 0)
            return rc;
    }

    if (append && virFileExists(include_file)) {
218
        if (virAsprintfQuiet(&pcontent, "%s%s", existing, included_files) == -1) {
219
            vah_error(NULL, 0, _("could not allocate memory for profile"));
220
            goto cleanup;
221 222
        }
    } else {
223
        if (virAsprintfQuiet(&pcontent, "%s%s", warning, included_files) == -1) {
224
            vah_error(NULL, 0, _("could not allocate memory for profile"));
225
            goto cleanup;
226
        }
J
Jamie Strandboge 已提交
227 228 229 230
    }

    plen = strlen(pcontent);
    if (plen > MAX_FILE_LEN) {
231
        vah_error(NULL, 0, _("invalid length for new profile"));
232
        goto cleanup;
J
Jamie Strandboge 已提交
233 234 235
    }

    /* only update the disk profile if it is different */
236 237
    if (flen > 0 && flen == plen && STREQLEN(existing, pcontent, plen)) {
        rc = 0;
238
        goto cleanup;
J
Jamie Strandboge 已提交
239 240 241 242
    }

    /* write the file */
    if ((fd = open(include_file, O_CREAT | O_TRUNC | O_WRONLY, 0644)) == -1) {
243
        vah_error(NULL, 0, _("failed to create include file"));
244
        goto cleanup;
J
Jamie Strandboge 已提交
245 246 247
    }

    if (safewrite(fd, pcontent, plen) < 0) { /* don't write the '\0' */
248
        VIR_FORCE_CLOSE(fd);
249
        vah_error(NULL, 0, _("failed to write to profile"));
250
        goto cleanup;
J
Jamie Strandboge 已提交
251 252
    }

253
    if (VIR_CLOSE(fd) != 0) {
254
        vah_error(NULL, 0, _("failed to close or write to profile"));
255
        goto cleanup;
J
Jamie Strandboge 已提交
256 257 258
    }
    rc = 0;

259
 cleanup:
J
Jamie Strandboge 已提交
260
    VIR_FREE(pcontent);
261
    VIR_FREE(existing);
J
Jamie Strandboge 已提交
262 263 264 265 266 267 268 269 270

    return rc;
}

/*
 * Create a profile based on a template
 */
static int
create_profile(const char *profile, const char *profile_name,
271
               const char *profile_files, int virtType)
J
Jamie Strandboge 已提交
272
{
273
    char *template;
J
Jamie Strandboge 已提交
274 275 276 277
    char *tcontent = NULL;
    char *pcontent = NULL;
    char *replace_name = NULL;
    char *replace_files = NULL;
278
    char *tmp = NULL;
J
Jamie Strandboge 已提交
279 280 281 282 283
    const char *template_name = "\nprofile LIBVIRT_TEMPLATE";
    const char *template_end = "\n}";
    int tlen, plen;
    int fd;
    int rc = -1;
284
    const char *driver_name = NULL;
J
Jamie Strandboge 已提交
285 286

    if (virFileExists(profile)) {
287
        vah_error(NULL, 0, _("profile exists"));
J
Jamie Strandboge 已提交
288 289 290
        goto end;
    }

291 292 293 294 295 296 297 298 299
    switch (virtType) {
    case VIR_DOMAIN_VIRT_QEMU:
    case VIR_DOMAIN_VIRT_KQEMU:
    case VIR_DOMAIN_VIRT_KVM:
        driver_name = "qemu";
        break;
    default:
        driver_name = virDomainVirtTypeToString(virtType);
    }
C
Cédric Bosdonnat 已提交
300 301

    if (virAsprintfQuiet(&template, "%s/TEMPLATE.%s", APPARMOR_DIR "/libvirt",
302
                         driver_name) < 0) {
303
        vah_error(NULL, 0, _("template name exceeds maximum length"));
J
Jamie Strandboge 已提交
304 305 306 307
        goto end;
    }

    if (!virFileExists(template)) {
308
        vah_error(NULL, 0, _("template does not exist"));
J
Jamie Strandboge 已提交
309 310 311 312
        goto end;
    }

    if ((tlen = virFileReadAll(template, MAX_FILE_LEN, &tcontent)) < 0) {
313
        vah_error(NULL, 0, _("failed to read AppArmor template"));
J
Jamie Strandboge 已提交
314 315 316 317
        goto end;
    }

    if (strstr(tcontent, template_name) == NULL) {
318
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
319 320 321 322
        goto clean_tcontent;
    }

    if (strstr(tcontent, template_end) == NULL) {
323
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
324 325 326 327
        goto clean_tcontent;
    }

    /* '\nprofile <profile_name>\0' */
328
    if (virAsprintfQuiet(&replace_name, "\nprofile %s", profile_name) == -1) {
329
        vah_error(NULL, 0, _("could not allocate memory for profile name"));
J
Jamie Strandboge 已提交
330 331 332 333
        goto clean_tcontent;
    }

    /* '\n<profile_files>\n}\0' */
334 335
    if ((virtType != VIR_DOMAIN_VIRT_LXC) &&
            virAsprintfQuiet(&replace_files, "\n%s\n}", profile_files) == -1) {
336
        vah_error(NULL, 0, _("could not allocate memory for profile files"));
J
Jamie Strandboge 已提交
337 338 339 340
        VIR_FREE(replace_name);
        goto clean_tcontent;
    }

C
Cédric Bosdonnat 已提交
341
    plen = tlen + strlen(replace_name) - strlen(template_name) + 1;
342 343 344 345

    if (virtType != VIR_DOMAIN_VIRT_LXC)
        plen += strlen(replace_files) - strlen(template_end);

J
Jamie Strandboge 已提交
346
    if (plen > MAX_FILE_LEN || plen < tlen) {
347
        vah_error(NULL, 0, _("invalid length for new profile"));
J
Jamie Strandboge 已提交
348 349 350
        goto clean_replace;
    }

351
    if (!(pcontent = virStringReplace(tcontent, template_name, replace_name)))
J
Jamie Strandboge 已提交
352 353
        goto clean_all;

354 355 356 357 358 359 360
    if (virtType != VIR_DOMAIN_VIRT_LXC) {
        if (!(tmp = virStringReplace(pcontent, template_end, replace_files)))
            goto clean_all;
        VIR_FREE(pcontent);
        pcontent = tmp;
        tmp = NULL;
    }
J
Jamie Strandboge 已提交
361 362 363

    /* write the file */
    if ((fd = open(profile, O_CREAT | O_EXCL | O_WRONLY, 0644)) == -1) {
364
        vah_error(NULL, 0, _("failed to create profile"));
J
Jamie Strandboge 已提交
365 366 367 368
        goto clean_all;
    }

    if (safewrite(fd, pcontent, plen - 1) < 0) { /* don't write the '\0' */
369
        VIR_FORCE_CLOSE(fd);
370
        vah_error(NULL, 0, _("failed to write to profile"));
J
Jamie Strandboge 已提交
371 372 373
        goto clean_all;
    }

374
    if (VIR_CLOSE(fd) != 0) {
375
        vah_error(NULL, 0, _("failed to close or write to profile"));
J
Jamie Strandboge 已提交
376 377 378 379
        goto clean_all;
    }
    rc = 0;

380
 clean_all:
J
Jamie Strandboge 已提交
381
    VIR_FREE(pcontent);
382
 clean_replace:
J
Jamie Strandboge 已提交
383 384
    VIR_FREE(replace_name);
    VIR_FREE(replace_files);
385
 clean_tcontent:
J
Jamie Strandboge 已提交
386
    VIR_FREE(tcontent);
387
 end:
388
    VIR_FREE(template);
J
Jamie Strandboge 已提交
389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440
    return rc;
}

/*
 * Load an existing profile
 */
static int
parserLoad(const char *profile_name)
{
    return parserCommand(profile_name, 'a');
}

/*
 * Remove an existing profile
 */
static int
parserRemove(const char *profile_name)
{
    return parserCommand(profile_name, 'R');
}

/*
 * Replace an existing profile
 */
static int
parserReplace(const char *profile_name)
{
    return parserCommand(profile_name, 'r');
}

static int
valid_uuid(const char *uuid)
{
    unsigned char rawuuid[VIR_UUID_BUFLEN];

    if (strlen(uuid) != PROFILE_NAME_SIZE - 1)
        return -1;

    if (!STRPREFIX(uuid, AA_PREFIX))
        return -1;

    if (virUUIDParse(uuid + strlen(AA_PREFIX), rawuuid) < 0)
        return -1;

    return 0;
}

static int
valid_name(const char *name)
{
    /* just try to filter out any dangerous characters in the name that can be
     * used to subvert the profile */
441
    const char *bad = "/[]{}?^,\"*";
J
Jamie Strandboge 已提交
442

443
    if (strlen(name) == 0)
J
Jamie Strandboge 已提交
444 445 446 447 448 449 450 451 452 453 454 455
        return -1;

    if (strcspn(name, bad) != strlen(name))
        return -1;

    return 0;
}

/* see if one of the strings in arr starts with str */
static int
array_starts_with(const char *str, const char * const *arr, const long size)
{
456
    size_t i;
J
Jamie Strandboge 已提交
457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504
    for (i = 0; i < size; i++) {
        if (strlen(str) < strlen(arr[i]))
            continue;

        if (STRPREFIX(str, arr[i]))
            return 0;
    }
    return 1;
}

/*
 * Don't allow access to special files or restricted paths such as /bin, /sbin,
 * /usr/bin, /usr/sbin and /etc. This is in an effort to prevent read/write
 * access to system files which could be used to elevate privileges. This is a
 * safety measure in case libvirtd is under a restrictive profile and is
 * subverted and trying to escape confinement.
 *
 * Note that we cannot exclude block devices because they are valid devices.
 * The TEMPLATE file can be adjusted to explicitly disallow these if needed.
 *
 * RETURN: -1 on error, 0 if ok, 1 if blocked
 */
static int
valid_path(const char *path, const bool readonly)
{
    const char * const restricted[] = {
        "/bin/",
        "/etc/",
        "/lib",
        "/lost+found/",
        "/proc/",
        "/sbin/",
        "/selinux/",
        "/sys/",
        "/usr/bin/",
        "/usr/lib",
        "/usr/sbin/",
        "/usr/share/",
        "/usr/local/bin/",
        "/usr/local/etc/",
        "/usr/local/lib",
        "/usr/local/sbin/"
    };
    /* these paths are ok for readonly, but not read/write */
    const char * const restricted_rw[] = {
        "/boot/",
        "/vmlinuz",
        "/initrd",
505
        "/initrd.img",
506
        "/usr/share/OVMF/",              /* for OVMF images */
507 508
        "/usr/share/ovmf/",              /* for OVMF images */
        "/usr/share/AAVMF/",             /* for AAVMF images */
509 510
        "/usr/share/qemu-efi/",          /* for AAVMF images */
        "/usr/share/qemu-efi-aarch64/"   /* for AAVMF images */
J
Jamie Strandboge 已提交
511
    };
512 513
    /* override the above with these */
    const char * const override[] = {
J
John Ferlan 已提交
514
        "/sys/devices/pci",              /* for hostdev pci devices */
515
        "/etc/libvirt-sandbox/services/" /* for virt-sandbox service config */
516
    };
J
Jamie Strandboge 已提交
517

518 519 520 521
    const int nropaths = ARRAY_CARDINALITY(restricted);
    const int nrwpaths = ARRAY_CARDINALITY(restricted_rw);
    const int nopaths = ARRAY_CARDINALITY(override);

522
    if (path == NULL) {
523
        vah_error(NULL, 0, _("bad pathname"));
J
Jamie Strandboge 已提交
524 525 526 527 528 529 530 531 532
        return -1;
    }

    /* Don't allow double quotes, since we use them to quote the filename
     * and this will confuse the apparmor parser.
     */
    if (strchr(path, '"') != NULL)
        return 1;

J
Jamie Strandboge 已提交
533 534 535 536
    /* Require an absolute path */
    if (STRNEQLEN(path, "/", 1))
        return 1;

537
    if (!virFileExists(path))
538
        vah_warning(_("path does not exist, skipping file type checks"));
J
Jamie Strandboge 已提交
539

540
    /* overrides are always allowed */
541
    if (array_starts_with(path, override, nopaths) == 0)
542
        return 0;
J
Jamie Strandboge 已提交
543

544 545
    /* allow read only paths upfront */
    if (readonly) {
546
        if (array_starts_with(path, restricted_rw, nrwpaths) == 0)
547
            return 0;
J
Jamie Strandboge 已提交
548 549
    }

550
    /* disallow RW access to all paths in restricted and restriced_rw */
551 552
    if ((array_starts_with(path, restricted, nropaths) == 0 ||
         array_starts_with(path, restricted_rw, nrwpaths) == 0))
553 554
        return 1;

J
Jamie Strandboge 已提交
555 556 557
    return 0;
}

558 559 560 561 562 563 564
static int
verify_xpath_context(xmlXPathContextPtr ctxt)
{
    int rc = -1;
    char *tmp = NULL;

    if (!ctxt) {
565
        vah_warning(_("Invalid context"));
566 567 568 569 570
        goto error;
    }

    /* check if have <name> */
    if (!(tmp = virXPathString("string(./name[1])", ctxt))) {
571
        vah_warning(_("Could not find <name>"));
572 573 574 575 576 577
        goto error;
    }
    VIR_FREE(tmp);

    /* check if have <uuid> */
    if (!(tmp = virXPathString("string(./uuid[1])", ctxt))) {
578
        vah_warning(_("Could not find <uuid>"));
579 580 581 582 583 584
        goto error;
    }
    VIR_FREE(tmp);

    rc = 0;

585
 error:
586 587 588
    return rc;
}

589 590
/*
 * Parse the xml we received to fill in the following:
591
 * ctl->virtType
592
 * ctl->os
593 594 595 596 597 598 599 600 601 602
 * ctl->arch
 *
 * These are suitable for setting up a virCapsPtr
 */
static int
caps_mockup(vahControl * ctl, const char *xmlStr)
{
    int rc = -1;
    xmlDocPtr xml = NULL;
    xmlXPathContextPtr ctxt = NULL;
603
    char *arch;
604

605
    if (!(xml = virXMLParseStringCtxt(xmlStr, _("(domain_definition)"),
606
                                      &ctxt))) {
607 608 609
        goto cleanup;
    }

610
    if (!virXMLNodeNameEqual(ctxt->node, "domain")) {
611
        vah_error(NULL, 0, _("unexpected root element, expecting <domain>"));
612 613 614
        goto cleanup;
    }

615 616 617 618
    /* Quick sanity check for some required elements */
    if (verify_xpath_context(ctxt) != 0)
        goto cleanup;

619 620 621 622 623
    ctl->virtType = virXPathString("string(./@type)", ctxt);
    if (!ctl->virtType) {
        vah_error(ctl, 0, _("domain type is not defined"));
        goto cleanup;
    }
624 625
    ctl->os = virXPathString("string(./os/type[1])", ctxt);
    if (!ctl->os) {
626
        vah_error(ctl, 0, _("os.type is not defined"));
627 628
        goto cleanup;
    }
629 630 631 632 633 634
    arch = virXPathString("string(./os/type[1]/@arch)", ctxt);
    if (!arch) {
        ctl->arch = virArchFromHost();
    } else {
        ctl->arch = virArchFromString(arch);
        VIR_FREE(arch);
635 636 637 638
    }

    rc = 0;

639
 cleanup:
640
    xmlFreeDoc(xml);
641 642 643 644 645
    xmlXPathFreeContext(ctxt);

    return rc;
}

646 647 648 649 650
virDomainDefParserConfig virAAHelperDomainDefParserConfig = {
    .features = VIR_DOMAIN_DEF_FEATURE_MEMORY_HOTPLUG |
                VIR_DOMAIN_DEF_FEATURE_OFFLINE_VCPUPIN |
                VIR_DOMAIN_DEF_FEATURE_INDIVIDUAL_VCPUS,
};
651

J
Jamie Strandboge 已提交
652 653 654
static int
get_definition(vahControl * ctl, const char *xmlStr)
{
655
    int rc = -1, ostype, virtType;
J
Jamie Strandboge 已提交
656 657 658 659 660 661
    virCapsGuestPtr guest;  /* this is freed when caps is freed */

    /*
     * mock up some capabilities. We don't currently use these explicitly,
     * but need them for virDomainDefParseString().
     */
662 663
    if (caps_mockup(ctl, xmlStr) != 0)
        goto exit;
J
Jamie Strandboge 已提交
664

665
    if ((ctl->caps = virCapabilitiesNew(ctl->arch, true, true)) == NULL) {
666
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
667 668 669
        goto exit;
    }

670 671
    if (!(ctl->xmlopt = virDomainXMLOptionNew(&virAAHelperDomainDefParserConfig,
                                              NULL, NULL, NULL, NULL))) {
672 673 674 675
        vah_error(ctl, 0, _("Failed to create XML config object"));
        goto exit;
    }

676
    if ((ostype = virDomainOSTypeFromString(ctl->os)) < 0) {
677 678 679 680
        vah_error(ctl, 0, _("unknown OS type"));
        goto exit;
    }

J
Jamie Strandboge 已提交
681
    if ((guest = virCapabilitiesAddGuest(ctl->caps,
682
                                         ostype,
683
                                         ctl->arch,
J
Jamie Strandboge 已提交
684 685 686 687
                                         NULL,
                                         NULL,
                                         0,
                                         NULL)) == NULL) {
688
        vah_error(ctl, 0, _("could not allocate memory"));
689 690 691 692 693 694 695 696 697 698 699 700 701 702 703
        goto exit;
    }

    if ((virtType = virDomainVirtTypeFromString(ctl->virtType)) < 0) {
        vah_error(ctl, 0, _("unknown virtualization type"));
        goto exit;
    }

    if (virCapabilitiesAddGuestDomain(guest,
                                      virtType,
                                      NULL,
                                      NULL,
                                      0,
                                      NULL) == NULL) {
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
704 705 706
        goto exit;
    }

707
    ctl->def = virDomainDefParseString(xmlStr,
708
                                       ctl->caps, ctl->xmlopt, NULL,
709
                                       VIR_DOMAIN_DEF_PARSE_SKIP_SECLABEL |
710
                                       VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE);
711

J
Jamie Strandboge 已提交
712
    if (ctl->def == NULL) {
713
        vah_error(ctl, 0, _("could not parse XML"));
J
Jamie Strandboge 已提交
714 715 716 717
        goto exit;
    }

    if (!ctl->def->name) {
718
        vah_error(ctl, 0, _("could not find name in XML"));
J
Jamie Strandboge 已提交
719 720 721 722
        goto exit;
    }

    if (valid_name(ctl->def->name) != 0) {
723
        vah_error(ctl, 0, _("bad name"));
J
Jamie Strandboge 已提交
724 725 726 727 728
        goto exit;
    }

    rc = 0;

729
 exit:
J
Jamie Strandboge 已提交
730 731 732
    return rc;
}

733 734 735 736
/**
  * The permissions allowed are apparmor valid permissions and 'R'. 'R' stands for
  * read with no explicit deny rule.
  */
J
Jamie Strandboge 已提交
737
static int
F
Felix Geyer 已提交
738
vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool recursive)
J
Jamie Strandboge 已提交
739 740 741 742
{
    char *tmp = NULL;
    int rc = -1;
    bool readonly = true;
743 744
    bool explicit_deny_rule = true;
    char *sub = NULL;
745
    char *perms_new = NULL;
746 747 748
    char *pathdir = NULL;
    char *pathtmp = NULL;
    char *pathreal = NULL;
J
Jamie Strandboge 已提交
749 750 751 752

    if (path == NULL)
        return rc;

J
Jamie Strandboge 已提交
753 754 755 756 757 758
    /* Skip files without an absolute path. Not having one confuses the
     * apparmor parser and this also ensures things like tcp consoles don't
     * get added to the profile.
     */
    if (STRNEQLEN(path, "/", 1)) {
        vah_warning(path);
759
        vah_warning(_("skipped non-absolute path"));
J
Jamie Strandboge 已提交
760 761 762
        return 0;
    }

763 764 765 766 767 768 769
    /* files might be created by qemu later on and not exist right now.
     * But realpath needs a valid path to work on, therefore:
     * 1. walk the path to find longest valid path
     * 2. get the realpath of that valid path
     * 3. re-combine the realpath with the remaining suffix
     * Note: A totally non existent path is used as-is
     */
770
     if (VIR_STRDUP_QUIET(pathdir, path) < 0)
771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789
         goto cleanup;
     while (!virFileExists(pathdir)) {
         if ((pathtmp = mdir_name(pathdir)) == NULL)
             goto cleanup;
         VIR_FREE(pathdir);
         VIR_STEAL_PTR(pathdir, pathtmp);
     }

    if (strlen(pathdir) == 1) {
        /* nothing of the path does exist yet */
        if (VIR_STRDUP_QUIET(tmp, path) < 0)
            goto cleanup;
    } else {
        if (VIR_STRDUP_QUIET(pathtmp, path+strlen(pathdir)) < 0)
            goto cleanup;
        if ((pathreal = realpath(pathdir, NULL)) == NULL) {
            vah_error(NULL, 0, pathdir);
            vah_error(NULL, 0, _("could not find realpath"));
            goto cleanup;
J
Jamie Strandboge 已提交
790
        }
791 792
        if (virAsprintfQuiet(&tmp, "%s%s", pathreal, pathtmp) < 0)
            goto cleanup;
793
    }
J
Jamie Strandboge 已提交
794

795
    if (VIR_STRDUP_QUIET(perms_new, perms) < 0)
796
        goto cleanup;
797 798

    if (strchr(perms_new, 'w') != NULL) {
J
Jamie Strandboge 已提交
799
        readonly = false;
800 801 802
        explicit_deny_rule = false;
    }

803
    if ((sub = strchr(perms_new, 'R')) != NULL) {
804 805 806 807
        /* Don't write the invalid R permission, replace it with 'r' */
        sub[0] = 'r';
        explicit_deny_rule = false;
    }
J
Jamie Strandboge 已提交
808 809 810 811 812

    rc = valid_path(tmp, readonly);
    if (rc != 0) {
        if (rc > 0) {
            vah_error(NULL, 0, path);
813
            vah_error(NULL, 0, _("skipped restricted file"));
J
Jamie Strandboge 已提交
814
        }
815
        goto cleanup;
J
Jamie Strandboge 已提交
816 817
    }

818 819 820
    if (tmp[strlen(tmp) - 1] == '/')
        tmp[strlen(tmp) - 1] = '\0';

821 822
    virBufferAsprintf(buf, "  \"%s%s\" %s,\n", tmp, recursive ? "/**" : "",
                      perms_new);
823
    if (explicit_deny_rule) {
824
        virBufferAddLit(buf, "  # don't audit writes to readonly files\n");
F
Felix Geyer 已提交
825 826 827 828 829
        virBufferAsprintf(buf, "  deny \"%s%s\" w,\n", tmp, recursive ? "/**" : "");
    }
    if (recursive) {
        /* allow reading (but not creating) the dir */
        virBufferAsprintf(buf, "  \"%s/\" r,\n", tmp);
830
    }
J
Jamie Strandboge 已提交
831

832
 cleanup:
833 834 835
    VIR_FREE(pathdir);
    VIR_FREE(pathtmp);
    VIR_FREE(pathreal);
836
    VIR_FREE(perms_new);
837
    VIR_FREE(tmp);
J
Jamie Strandboge 已提交
838 839 840 841

    return rc;
}

F
Felix Geyer 已提交
842 843 844 845 846 847
static int
vah_add_file(virBufferPtr buf, const char *path, const char *perms)
{
    return vah_add_path(buf, path, perms, false);
}

848 849 850 851 852 853 854 855 856 857 858 859
static int
vah_add_file_chardev(virBufferPtr buf,
                     const char *path,
                     const char *perms,
                     const int type)
{
    char *pipe_in;
    char *pipe_out;
    int rc = -1;

    if (type == VIR_DOMAIN_CHR_TYPE_PIPE) {
        /* add the pipe input */
860
        if (virAsprintfQuiet(&pipe_in, "%s.in", path) == -1) {
861
            vah_error(NULL, 0, _("could not allocate memory"));
862
            goto cleanup;
863 864 865 866 867 868
        }

        if (vah_add_file(buf, pipe_in, perms) != 0)
            goto clean_pipe_in;

        /* add the pipe output */
869
        if (virAsprintfQuiet(&pipe_out, "%s.out", path) == -1) {
870 871 872 873 874 875 876 877 878 879 880 881 882 883 884
            vah_error(NULL, 0, _("could not allocate memory"));
            goto clean_pipe_in;
        }

        if (vah_add_file(buf, pipe_out, perms) != 0)
            goto clean_pipe_out;

        rc = 0;
      clean_pipe_out:
        VIR_FREE(pipe_out);
      clean_pipe_in:
        VIR_FREE(pipe_in);
    } else {
        /* add the file */
        if (vah_add_file(buf, path, perms) != 0)
885
            goto cleanup;
886 887 888
        rc = 0;
    }

889
 cleanup:
890 891 892
    return rc;
}

J
Jamie Strandboge 已提交
893
static int
894
file_iterate_hostdev_cb(virUSBDevicePtr dev ATTRIBUTE_UNUSED,
895 896 897 898 899 900 901
                        const char *file, void *opaque)
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

static int
902 903
file_iterate_pci_cb(virPCIDevicePtr dev ATTRIBUTE_UNUSED,
                    const char *file, void *opaque)
J
Jamie Strandboge 已提交
904 905 906 907 908
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

909 910 911 912 913 914 915 916 917 918
static int
add_file_path(virDomainDiskDefPtr disk,
              const char *path,
              size_t depth,
              void *opaque)
{
    virBufferPtr buf = opaque;
    int ret;

    if (depth == 0) {
919
        if (disk->src->readonly)
920
            ret = vah_add_file(buf, path, "rk");
921
        else
922
            ret = vah_add_file(buf, path, "rwk");
923
    } else {
924
        ret = vah_add_file(buf, path, "rk");
925 926
    }

927 928 929
    if (ret != 0)
        ret = -1;

930 931 932
    return ret;
}

J
Jamie Strandboge 已提交
933 934 935 936 937
static int
get_files(vahControl * ctl)
{
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
938
    size_t i;
J
Jamie Strandboge 已提交
939 940
    char *uuid;
    char uuidstr[VIR_UUID_STRING_BUFLEN];
941
    bool needsVfio = false, needsvhost = false;
J
Jamie Strandboge 已提交
942 943 944

    /* verify uuid is same as what we were given on the command line */
    virUUIDFormat(ctl->def->uuid, uuidstr);
945
    if (virAsprintfQuiet(&uuid, "%s%s", AA_PREFIX, uuidstr) == -1) {
946
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
947 948 949 950
        return rc;
    }

    if (STRNEQ(uuid, ctl->uuid)) {
951
        vah_error(ctl, 0, _("given uuid does not match XML uuid"));
952
        goto cleanup;
J
Jamie Strandboge 已提交
953 954
    }

955 956
    /* load the storage driver so that backing store can be accessed */
#ifdef WITH_STORAGE
957
    virDriverLoadModule("storage", "storageRegister", false);
958
#endif
959

960
    for (i = 0; i < ctl->def->ndisks; i++) {
961 962
        virDomainDiskDefPtr disk = ctl->def->disks[i];

963
        if (!virDomainDiskGetSource(disk))
E
Eric Blake 已提交
964
            continue;
965 966 967
        /* XXX - if we knew the qemu user:group here we could send it in
         *        so that the open could be re-tried as that user:group.
         */
968
        if (!virStorageSourceHasBacking(disk->src))
969
            virStorageFileGetMetadata(disk->src, -1, -1, false);
970

971 972 973
        /* XXX passing ignoreOpenFailure = true to get back to the behavior
         * from before using virDomainDiskDefForeachPath. actually we should
         * be passing ignoreOpenFailure = false and handle open errors more
974 975
         * careful than just ignoring them.
         */
976
        if (virDomainDiskDefForeachPath(disk, true, add_file_path, &buf) < 0)
977
            goto cleanup;
978
    }
J
Jamie Strandboge 已提交
979 980

    for (i = 0; i < ctl->def->nserials; i++)
981
        if (ctl->def->serials[i] &&
982 983 984 985 986 987 988
            (ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->serials[i]->source->data.file.path &&
            ctl->def->serials[i]->source->data.file.path[0] != '\0')
989
            if (vah_add_file_chardev(&buf,
990
                                     ctl->def->serials[i]->source->data.file.path,
991
                                     "rw",
992
                                     ctl->def->serials[i]->source->type) != 0)
993
                goto cleanup;
J
Jamie Strandboge 已提交
994

995 996
    for (i = 0; i < ctl->def->nconsoles; i++)
        if (ctl->def->consoles[i] &&
997 998 999 1000 1001 1002 1003
            (ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->consoles[i]->source->data.file.path &&
            ctl->def->consoles[i]->source->data.file.path[0] != '\0')
1004
            if (vah_add_file(&buf,
1005
                             ctl->def->consoles[i]->source->data.file.path, "rw") != 0)
1006
                goto cleanup;
J
Jamie Strandboge 已提交
1007

1008
    for (i = 0; i < ctl->def->nparallels; i++)
1009
        if (ctl->def->parallels[i] &&
1010 1011 1012 1013 1014 1015 1016
            (ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->parallels[i]->source->data.file.path &&
            ctl->def->parallels[i]->source->data.file.path[0] != '\0')
1017
            if (vah_add_file_chardev(&buf,
1018
                                     ctl->def->parallels[i]->source->data.file.path,
1019
                                     "rw",
1020
                                     ctl->def->parallels[i]->source->type) != 0)
1021
                goto cleanup;
1022

1023
    for (i = 0; i < ctl->def->nchannels; i++)
1024
        if (ctl->def->channels[i] &&
1025 1026 1027 1028 1029 1030 1031
            (ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->channels[i]->source->data.file.path &&
            ctl->def->channels[i]->source->data.file.path[0] != '\0')
1032
            if (vah_add_file_chardev(&buf,
1033
                                     ctl->def->channels[i]->source->data.file.path,
1034
                                     "rw",
1035
                                     ctl->def->channels[i]->source->type) != 0)
1036
                goto cleanup;
1037

1038
    if (ctl->def->os.kernel)
J
Jamie Strandboge 已提交
1039
        if (vah_add_file(&buf, ctl->def->os.kernel, "r") != 0)
1040
            goto cleanup;
J
Jamie Strandboge 已提交
1041

1042
    if (ctl->def->os.initrd)
J
Jamie Strandboge 已提交
1043
        if (vah_add_file(&buf, ctl->def->os.initrd, "r") != 0)
1044
            goto cleanup;
O
Olivia Yin 已提交
1045 1046 1047

    if (ctl->def->os.dtb)
        if (vah_add_file(&buf, ctl->def->os.dtb, "r") != 0)
1048
            goto cleanup;
J
Jamie Strandboge 已提交
1049

J
Ján Tomko 已提交
1050 1051 1052 1053
    if (ctl->def->os.slic_table)
        if (vah_add_file(&buf, ctl->def->os.slic_table, "r") != 0)
            goto cleanup;

1054
    if (ctl->def->os.loader && ctl->def->os.loader->path)
1055
        if (vah_add_file(&buf, ctl->def->os.loader->path, "rk") != 0)
1056
            goto cleanup;
1057

1058
    if (ctl->def->os.loader && ctl->def->os.loader->nvram)
1059
        if (vah_add_file(&buf, ctl->def->os.loader->nvram, "rwk") != 0)
1060 1061
            goto cleanup;

1062
    for (i = 0; i < ctl->def->ngraphics; i++) {
1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073
        virDomainGraphicsDefPtr graphics = ctl->def->graphics[i];
        size_t n;

        for (n = 0; n < graphics->nListens; n++) {
            virDomainGraphicsListenDef listenObj = graphics->listens[n];

            if (listenObj.type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET &&
                listenObj.socket &&
                vah_add_file(&buf, listenObj.socket, "rw"))
                goto cleanup;
        }
1074 1075
    }

1076 1077 1078 1079
    if (ctl->def->ngraphics == 1 &&
        ctl->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL)
        if (vah_add_file(&buf, ctl->def->graphics[0]->data.sdl.xauth,
                         "r") != 0)
1080
            goto cleanup;
J
Jamie Strandboge 已提交
1081 1082 1083 1084

    for (i = 0; i < ctl->def->nhostdevs; i++)
        if (ctl->def->hostdevs[i]) {
            virDomainHostdevDefPtr dev = ctl->def->hostdevs[i];
1085
            virDomainHostdevSubsysUSBPtr usbsrc = &dev->source.subsys.u.usb;
J
Jamie Strandboge 已提交
1086 1087
            switch (dev->source.subsys.type) {
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: {
1088
                virUSBDevicePtr usb =
1089
                    virUSBDeviceNew(usbsrc->bus, usbsrc->device, NULL);
1090 1091 1092 1093

                if (usb == NULL)
                    continue;

1094 1095 1096
                if (virHostdevFindUSBDevice(dev, true, &usb) < 0)
                    continue;

1097 1098
                rc = virUSBDeviceFileIterate(usb, file_iterate_hostdev_cb, &buf);
                virUSBDeviceFree(usb);
1099
                if (rc != 0)
1100
                    goto cleanup;
J
Jamie Strandboge 已提交
1101 1102
                break;
            }
1103

1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: {
                virDomainHostdevSubsysMediatedDevPtr mdevsrc = &dev->source.subsys.u.mdev;
                switch ((virMediatedDeviceModelType) mdevsrc->model) {
                    case VIR_MDEV_MODEL_TYPE_VFIO_PCI:
                    case VIR_MDEV_MODEL_TYPE_VFIO_AP:
                    case VIR_MDEV_MODEL_TYPE_VFIO_CCW:
                        needsVfio = true;
                        break;
                    case VIR_MDEV_MODEL_TYPE_LAST:
                    default:
                        virReportEnumRangeError(virMediatedDeviceModelType,
                                                mdevsrc->model);
                        break;
                }
                break;
            }

J
Jamie Strandboge 已提交
1121
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: {
1122
                virPCIDevicePtr pci = virPCIDeviceNew(
1123 1124 1125 1126
                           dev->source.subsys.u.pci.addr.domain,
                           dev->source.subsys.u.pci.addr.bus,
                           dev->source.subsys.u.pci.addr.slot,
                           dev->source.subsys.u.pci.addr.function);
J
Jamie Strandboge 已提交
1127

1128
                virDomainHostdevSubsysPCIBackendType backend = dev->source.subsys.u.pci.backend;
1129 1130 1131 1132 1133
                if (backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO ||
                        backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT) {
                    needsVfio = true;
                }

J
Jamie Strandboge 已提交
1134 1135 1136
                if (pci == NULL)
                    continue;

1137 1138
                rc = virPCIDeviceFileIterate(pci, file_iterate_pci_cb, &buf);
                virPCIDeviceFree(pci);
J
Jamie Strandboge 已提交
1139 1140 1141

                break;
            }
1142

J
Jamie Strandboge 已提交
1143 1144 1145 1146 1147 1148
            default:
                rc = 0;
                break;
            } /* switch */
        }

F
Felix Geyer 已提交
1149 1150 1151 1152 1153
    for (i = 0; i < ctl->def->nfss; i++) {
        if (ctl->def->fss[i] &&
                ctl->def->fss[i]->type == VIR_DOMAIN_FS_TYPE_MOUNT &&
                (ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_PATH ||
                 ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT) &&
1154
                ctl->def->fss[i]->src) {
F
Felix Geyer 已提交
1155 1156
            virDomainFSDefPtr fs = ctl->def->fss[i];

1157 1158 1159
            /* We don't need to add deny rw rules for readonly mounts,
             * this can only lead to troubles when mounting / readonly.
             */
1160
            if (vah_add_path(&buf, fs->src->path, fs->readonly ? "R" : "rw", true) != 0)
F
Felix Geyer 已提交
1161 1162 1163 1164
                goto cleanup;
        }
    }

1165 1166 1167 1168 1169 1170 1171 1172
    for (i = 0; i < ctl->def->ninputs; i++) {
        if (ctl->def->inputs[i] &&
                ctl->def->inputs[i]->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) {
            if (vah_add_file(&buf, ctl->def->inputs[i]->source.evdev, "rw") != 0)
                goto cleanup;
        }
    }

1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184
    for (i = 0; i < ctl->def->nnets; i++) {
        if (ctl->def->nets[i] &&
                ctl->def->nets[i]->type == VIR_DOMAIN_NET_TYPE_VHOSTUSER &&
                ctl->def->nets[i]->data.vhostuser) {
            virDomainChrSourceDefPtr vhu = ctl->def->nets[i]->data.vhostuser;

            if (vah_add_file_chardev(&buf, vhu->data.nix.path, "rw",
                       vhu->type) != 0)
                goto cleanup;
        }
    }

1185 1186 1187 1188 1189 1190 1191 1192
    for (i = 0; i < ctl->def->nmems; i++) {
        if (ctl->def->mems[i] &&
                ctl->def->mems[i]->model == VIR_DOMAIN_MEMORY_MODEL_NVDIMM) {
            if (vah_add_file(&buf, ctl->def->mems[i]->nvdimmPath, "rw") != 0)
                goto cleanup;
        }
    }

1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237
    if (ctl->def->tpm) {
        char *shortName = NULL;
        const char *tpmpath = NULL;

        switch (ctl->def->tpm->type) {
        case VIR_DOMAIN_TPM_TYPE_EMULATOR:
            shortName = virDomainDefGetShortName(ctl->def);

            switch (ctl->def->tpm->version) {
            case VIR_DOMAIN_TPM_VERSION_1_2:
                tpmpath = "tpm1.2";
                break;
            case VIR_DOMAIN_TPM_VERSION_2_0:
                tpmpath = "tpm2";
                break;
            case VIR_DOMAIN_TPM_VERSION_DEFAULT:
            case VIR_DOMAIN_TPM_VERSION_LAST:
                break;
            }

            /* Unix socket for QEMU and swtpm to use */
            virBufferAsprintf(&buf,
                "  \"/run/libvirt/qemu/swtpm/%s-swtpm.sock\" rw,\n",
                shortName);
            /* Paths for swtpm to use: give it access to its state
             * directory, log, and PID files.
             */
            virBufferAsprintf(&buf,
                "  \"%s/lib/libvirt/swtpm/%s/%s/**\" rw,\n",
                LOCALSTATEDIR, uuidstr, tpmpath);
            virBufferAsprintf(&buf,
                "  \"%s/log/swtpm/libvirt/qemu/%s-swtpm.log\" a,\n",
                LOCALSTATEDIR, ctl->def->name);
            virBufferAsprintf(&buf,
                "  \"/run/libvirt/qemu/swtpm/%s-swtpm.pid\" rw,\n",
                shortName);

            VIR_FREE(shortName);
            break;
        case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
        case VIR_DOMAIN_TPM_TYPE_LAST:
            break;
        }
    }

1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250
    if (ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
        for (i = 0; i < ctl->def->nnets; i++) {
            virDomainNetDefPtr net = ctl->def->nets[i];
            if (net && net->model) {
                if (net->driver.virtio.name == VIR_DOMAIN_NET_BACKEND_TYPE_QEMU)
                    continue;
                if (STRNEQ(net->model, "virtio"))
                    continue;
            }
            needsvhost = true;
        }
    }
    if (needsvhost)
1251
        virBufferAddLit(&buf, "  \"/dev/vhost-net\" rw,\n");
1252

1253
    if (needsVfio) {
1254 1255
        virBufferAddLit(&buf, "  \"/dev/vfio/vfio\" rw,\n");
        virBufferAddLit(&buf, "  \"/dev/vfio/[0-9]*\" rw,\n");
1256 1257
    }

1258
    if (ctl->newfile)
1259
        if (vah_add_file(&buf, ctl->newfile, "rwk") != 0)
1260
            goto cleanup;
J
Jamie Strandboge 已提交
1261 1262

    if (virBufferError(&buf)) {
1263
        virBufferFreeAndReset(&buf);
1264
        vah_error(NULL, 0, _("failed to allocate file buffer"));
1265
        goto cleanup;
J
Jamie Strandboge 已提交
1266 1267 1268 1269 1270
    }

    rc = 0;
    ctl->files = virBufferContentAndReset(&buf);

1271
 cleanup:
J
Jamie Strandboge 已提交
1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285
    VIR_FREE(uuid);
    return rc;
}

static int
vahParseArgv(vahControl * ctl, int argc, char **argv)
{
    int arg, idx = 0;
    struct option opt[] = {
        {"add", 0, 0, 'a'},
        {"create", 0, 0, 'c'},
        {"dryrun", 0, 0, 'd'},
        {"delete", 0, 0, 'D'},
        {"add-file", 0, 0, 'f'},
1286
        {"append-file", 0, 0, 'F'},
J
Jamie Strandboge 已提交
1287 1288 1289 1290 1291 1292 1293
        {"help", 0, 0, 'h'},
        {"replace", 0, 0, 'r'},
        {"remove", 0, 0, 'R'},
        {"uuid", 1, 0, 'u'},
        {0, 0, 0, 0}
    };

1294
    while ((arg = getopt_long(argc, argv, "acdDhrRH:b:u:p:f:F:", opt,
J
Jamie Strandboge 已提交
1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309
            &idx)) != -1) {
        switch (arg) {
            case 'a':
                ctl->cmd = 'a';
                break;
            case 'c':
                ctl->cmd = 'c';
                break;
            case 'd':
                ctl->dryrun = true;
                break;
            case 'D':
                ctl->cmd = 'D';
                break;
            case 'f':
1310
            case 'F':
1311
                if (VIR_STRDUP_QUIET(ctl->newfile, optarg) < 0)
1312
                    vah_error(ctl, 1, _("could not allocate memory for disk"));
1313
                ctl->append = arg == 'F';
J
Jamie Strandboge 已提交
1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326
                break;
            case 'h':
                vah_usage();
                exit(EXIT_SUCCESS);
                break;
            case 'r':
                ctl->cmd = 'r';
                break;
            case 'R':
                ctl->cmd = 'R';
                break;
            case 'u':
                if (strlen(optarg) > PROFILE_NAME_SIZE - 1)
1327
                    vah_error(ctl, 1, _("invalid UUID"));
1328
                if (virStrcpy((char *)ctl->uuid, optarg,
1329
                    PROFILE_NAME_SIZE) < 0)
1330
                    vah_error(ctl, 1, _("error copying UUID"));
J
Jamie Strandboge 已提交
1331 1332
                break;
            default:
1333
                vah_error(ctl, 1, _("unsupported option"));
J
Jamie Strandboge 已提交
1334 1335 1336 1337
                break;
        }
    }
    if (strchr("acDrR", ctl->cmd) == NULL)
1338
        vah_error(ctl, 1, _("bad command"));
J
Jamie Strandboge 已提交
1339 1340

    if (valid_uuid(ctl->uuid) != 0)
1341
        vah_error(ctl, 1, _("invalid UUID"));
J
Jamie Strandboge 已提交
1342 1343 1344 1345 1346 1347 1348 1349 1350

    if (!ctl->cmd) {
        vah_usage();
        exit(EXIT_FAILURE);
    }

    if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *xmlStr = NULL;
        if (virFileReadLimFD(STDIN_FILENO, MAX_FILE_LEN, &xmlStr) < 0)
1351
            vah_error(ctl, 1, _("could not read xml file"));
J
Jamie Strandboge 已提交
1352 1353 1354

        if (get_definition(ctl, xmlStr) != 0 || ctl->def == NULL) {
            VIR_FREE(xmlStr);
1355
            vah_error(ctl, 1, _("could not get VM definition"));
J
Jamie Strandboge 已提交
1356 1357 1358 1359
        }
        VIR_FREE(xmlStr);

        if (get_files(ctl) != 0)
1360
            vah_error(ctl, 1, _("invalid VM definition"));
J
Jamie Strandboge 已提交
1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378
    }
    return 0;
}


/*
 * virt-aa-helper -c -u UUID < file.xml
 * virt-aa-helper -r -u UUID [-f <file>] < file.xml
 * virt-aa-helper -a -u UUID
 * virt-aa-helper -R -u UUID
 * virt-aa-helper -D -u UUID
 */
int
main(int argc, char **argv)
{
    vahControl _ctl, *ctl = &_ctl;
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
1379 1380
    char *profile = NULL;
    char *include_file = NULL;
J
Jamie Strandboge 已提交
1381

1382 1383
    if (virGettextInitialize() < 0 ||
        virThreadInitialize() < 0 ||
1384 1385 1386 1387 1388
        virErrorInitialize() < 0) {
        fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
        exit(EXIT_FAILURE);
    }

1389 1390
    virFileActivateDirOverride(argv[0]);

1391 1392 1393
    /* Initialize the log system */
    virLogSetFromEnv();

J
Jamie Strandboge 已提交
1394 1395
    /* clear the environment */
    environ = NULL;
1396
    if (setenv("PATH", "/sbin:/usr/sbin", 1) != 0)
1397 1398
        vah_error(ctl, 1, _("could not set PATH"));

1399
    /* ensure the traditional IFS setting */
1400
    if (setenv("IFS", " \t\n", 1) != 0)
1401
        vah_error(ctl, 1, _("could not set IFS"));
J
Jamie Strandboge 已提交
1402 1403 1404 1405 1406 1407 1408 1409 1410

    if (!(progname = strrchr(argv[0], '/')))
        progname = argv[0];
    else
        progname++;

    memset(ctl, 0, sizeof(vahControl));

    if (vahParseArgv(ctl, argc, argv) != 0)
1411
        vah_error(ctl, 1, _("could not parse arguments"));
J
Jamie Strandboge 已提交
1412

1413 1414
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1415
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1416

1417 1418
    if (virAsprintfQuiet(&include_file, "%s/%s.files",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1419
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1420

1421
    if (ctl->cmd == 'a') {
J
Jamie Strandboge 已提交
1422
        rc = parserLoad(ctl->uuid);
1423
    } else if (ctl->cmd == 'R' || ctl->cmd == 'D') {
J
Jamie Strandboge 已提交
1424 1425 1426 1427 1428 1429 1430 1431
        rc = parserRemove(ctl->uuid);
        if (ctl->cmd == 'D') {
            unlink(include_file);
            unlink(profile);
        }
    } else if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *included_files = NULL;

1432
        if (ctl->cmd == 'c' && virFileExists(profile))
1433
            vah_error(ctl, 1, _("profile exists"));
J
Jamie Strandboge 已提交
1434

1435
        if (ctl->append && ctl->newfile) {
1436
            if (vah_add_file(&buf, ctl->newfile, "rwk") != 0)
1437
                goto cleanup;
1438
        } else {
1439 1440 1441
            if (ctl->def->virtType == VIR_DOMAIN_VIRT_QEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KQEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
1442 1443
                virBufferAsprintf(&buf, "  \"%s/log/libvirt/**/%s.log\" w,\n",
                                  LOCALSTATEDIR, ctl->def->name);
1444
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%s/monitor.sock\" rw,\n",
1445
                                  LOCALSTATEDIR, ctl->def->name);
1446 1447
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%d-%.*s/*\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->id, 20, ctl->def->name);
1448 1449 1450 1451 1452 1453 1454 1455 1456
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/%s.pid\" rwk,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/%s.pid\" rwk,\n",
                                  ctl->def->name);
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  ctl->def->name);
            }
1457
            if (ctl->files)
1458
                virBufferAdd(&buf, ctl->files, -1);
1459
        }
J
Jamie Strandboge 已提交
1460

1461 1462
        if (virBufferError(&buf)) {
            virBufferFreeAndReset(&buf);
1463
            vah_error(ctl, 1, _("failed to allocate buffer"));
1464
        }
J
Jamie Strandboge 已提交
1465 1466 1467 1468 1469 1470 1471 1472

        included_files = virBufferContentAndReset(&buf);

        /* (re)create the include file using included_files */
        if (ctl->dryrun) {
            vah_info(include_file);
            vah_info(included_files);
            rc = 0;
1473 1474 1475
        } else if (ctl->def->virtType == VIR_DOMAIN_VIRT_LXC) {
            rc = 0;
        } else if ((rc = update_include_file(include_file,
1476
                                             included_files,
1477
                                             ctl->append)) != 0) {
1478
            goto cleanup;
1479
        }
J
Jamie Strandboge 已提交
1480 1481 1482 1483 1484


        /* create the profile from TEMPLATE */
        if (ctl->cmd == 'c') {
            char *tmp = NULL;
1485 1486
            if (virAsprintfQuiet(&tmp, "  #include <libvirt/%s.files>\n",
                                 ctl->uuid) == -1) {
1487
                vah_error(ctl, 0, _("could not allocate memory"));
1488
                goto cleanup;
J
Jamie Strandboge 已提交
1489 1490 1491 1492 1493 1494 1495
            }

            if (ctl->dryrun) {
                vah_info(profile);
                vah_info(ctl->uuid);
                vah_info(tmp);
                rc = 0;
1496 1497
            } else if ((rc = create_profile(profile, ctl->uuid, tmp,
                                            ctl->def->virtType)) != 0) {
1498
                vah_error(ctl, 0, _("could not create profile"));
J
Jamie Strandboge 已提交
1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516
                unlink(include_file);
            }
            VIR_FREE(tmp);
        }

        if (rc == 0 && !ctl->dryrun) {
            if (ctl->cmd == 'c')
                rc = parserLoad(ctl->uuid);
            else
                rc = parserReplace(ctl->uuid);

            /* cleanup */
            if (rc != 0) {
                unlink(include_file);
                if (ctl->cmd == 'c')
                    unlink(profile);
            }
        }
1517
      cleanup:
J
Jamie Strandboge 已提交
1518 1519 1520 1521
        VIR_FREE(included_files);
    }

    vahDeinit(ctl);
1522 1523 1524 1525

    VIR_FREE(profile);
    VIR_FREE(include_file);

J
Jamie Strandboge 已提交
1526 1527
    exit(rc == 0 ? EXIT_SUCCESS : EXIT_FAILURE);
}