check.c 67.8 KB
Newer Older
1
// SPDX-License-Identifier: GPL-2.0-or-later
2 3 4 5 6 7 8
/*
 * Copyright (C) 2015-2017 Josh Poimboeuf <jpoimboe@redhat.com>
 */

#include <string.h>
#include <stdlib.h>

9
#include "builtin.h"
10 11
#include "cfi.h"
#include "arch.h"
12 13 14
#include "check.h"
#include "special.h"
#include "warn.h"
P
Peter Zijlstra 已提交
15
#include "arch_elf.h"
16 17 18 19

#include <linux/hashtable.h>
#include <linux/kernel.h>

20 21
#define FAKE_JUMP_OFFSET -1

22 23
#define C_JUMP_TABLE_SECTION ".rodata..c_jump_table"

24 25 26
struct alternative {
	struct list_head list;
	struct instruction *insn;
P
Peter Zijlstra 已提交
27
	bool skip_orig;
28 29 30
};

const char *objname;
31
struct cfi_init_state initial_func_cfi;
32

33 34
struct instruction *find_insn(struct objtool_file *file,
			      struct section *sec, unsigned long offset)
35 36 37
{
	struct instruction *insn;

38
	hash_for_each_possible(file->insn_hash, insn, hash, sec_offset_hash(sec, offset)) {
39 40
		if (insn->sec == sec && insn->offset == offset)
			return insn;
41
	}
42 43 44 45 46 47 48 49 50

	return NULL;
}

static struct instruction *next_insn_same_sec(struct objtool_file *file,
					      struct instruction *insn)
{
	struct instruction *next = list_next_entry(insn, list);

51
	if (!next || &next->list == &file->insn_list || next->sec != insn->sec)
52 53 54 55 56
		return NULL;

	return next;
}

57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76
static struct instruction *next_insn_same_func(struct objtool_file *file,
					       struct instruction *insn)
{
	struct instruction *next = list_next_entry(insn, list);
	struct symbol *func = insn->func;

	if (!func)
		return NULL;

	if (&next->list != &file->insn_list && next->func == func)
		return next;

	/* Check if we're already in the subfunction: */
	if (func == func->cfunc)
		return NULL;

	/* Move to the subfunction: */
	return find_insn(file, func->cfunc->sec, func->cfunc->offset);
}

77 78 79 80 81 82 83 84 85 86 87
static struct instruction *prev_insn_same_sym(struct objtool_file *file,
					       struct instruction *insn)
{
	struct instruction *prev = list_prev_entry(insn, list);

	if (&prev->list != &file->insn_list && prev->func == insn->func)
		return prev;

	return NULL;
}

88
#define func_for_each_insn(file, func, insn)				\
89 90 91 92
	for (insn = find_insn(file, func->sec, func->offset);		\
	     insn;							\
	     insn = next_insn_same_func(file, insn))

93 94
#define sym_for_each_insn(file, sym, insn)				\
	for (insn = find_insn(file, sym->sec, sym->offset);		\
95
	     insn && &insn->list != &file->insn_list &&			\
96 97
		insn->sec == sym->sec &&				\
		insn->offset < sym->offset + sym->len;			\
98 99
	     insn = list_next_entry(insn, list))

100
#define sym_for_each_insn_continue_reverse(file, sym, insn)		\
101 102
	for (insn = list_prev_entry(insn, list);			\
	     &insn->list != &file->insn_list &&				\
103
		insn->sec == sym->sec && insn->offset >= sym->offset;	\
104 105 106 107 108
	     insn = list_prev_entry(insn, list))

#define sec_for_each_insn_from(file, insn)				\
	for (; insn; insn = next_insn_same_sec(file, insn))

109 110 111
#define sec_for_each_insn_continue(file, insn)				\
	for (insn = next_insn_same_sec(file, insn); insn;		\
	     insn = next_insn_same_sec(file, insn))
112

113 114 115 116 117 118
static bool is_static_jump(struct instruction *insn)
{
	return insn->type == INSN_JUMP_CONDITIONAL ||
	       insn->type == INSN_JUMP_UNCONDITIONAL;
}

119 120 121 122 123 124
static bool is_sibling_call(struct instruction *insn)
{
	/* An indirect jump is either a sibling call or a jump to a table. */
	if (insn->type == INSN_JUMP_DYNAMIC)
		return list_empty(&insn->alts);

125
	if (!is_static_jump(insn))
126 127 128 129 130 131
		return false;

	/* add_jump_destinations() sets insn->call_dest for sibling calls. */
	return !!insn->call_dest;
}

132 133 134 135 136 137 138 139 140
/*
 * This checks to see if the given function is a "noreturn" function.
 *
 * For global functions which are outside the scope of this object file, we
 * have to keep a manual list of them.
 *
 * For local functions, we have to detect them manually by simply looking for
 * the lack of a return instruction.
 */
141 142
static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
				int recursion)
143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161
{
	int i;
	struct instruction *insn;
	bool empty = true;

	/*
	 * Unfortunately these have to be hard coded because the noreturn
	 * attribute isn't provided in ELF data.
	 */
	static const char * const global_noreturns[] = {
		"__stack_chk_fail",
		"panic",
		"do_exit",
		"do_task_dead",
		"__module_put_and_exit",
		"complete_and_exit",
		"__reiserfs_panic",
		"lbug_with_loc",
		"fortify_panic",
162
		"usercopy_abort",
163
		"machine_real_restart",
164
		"rewind_stack_do_exit",
165
		"kunit_try_catch_throw",
166 167
	};

168 169 170
	if (!func)
		return false;

171
	if (func->bind == STB_WEAK)
172
		return false;
173 174 175 176

	if (func->bind == STB_GLOBAL)
		for (i = 0; i < ARRAY_SIZE(global_noreturns); i++)
			if (!strcmp(func->name, global_noreturns[i]))
177
				return true;
178

179
	if (!func->len)
180
		return false;
181

182 183
	insn = find_insn(file, func->sec, func->offset);
	if (!insn->func)
184
		return false;
185

186
	func_for_each_insn(file, func, insn) {
187 188 189
		empty = false;

		if (insn->type == INSN_RETURN)
190
			return false;
191 192 193
	}

	if (empty)
194
		return false;
195 196 197 198 199 200

	/*
	 * A function can have a sibling call instead of a return.  In that
	 * case, the function's dead-end status depends on whether the target
	 * of the sibling call returns.
	 */
201
	func_for_each_insn(file, func, insn) {
202
		if (is_sibling_call(insn)) {
203 204 205 206
			struct instruction *dest = insn->jump_dest;

			if (!dest)
				/* sibling call to another file */
207
				return false;
208

209 210 211 212 213 214 215 216
			/* local sibling call */
			if (recursion == 5) {
				/*
				 * Infinite recursion: two functions have
				 * sibling calls to each other.  This is a very
				 * rare case.  It means they aren't dead ends.
				 */
				return false;
217 218
			}

219 220
			return __dead_end_function(file, dest->func, recursion+1);
		}
221 222
	}

223
	return true;
224 225
}

226
static bool dead_end_function(struct objtool_file *file, struct symbol *func)
227 228 229 230
{
	return __dead_end_function(file, func, 0);
}

231
static void init_cfi_state(struct cfi_state *cfi)
232 233 234
{
	int i;

235
	for (i = 0; i < CFI_NUM_REGS; i++) {
236 237
		cfi->regs[i].base = CFI_UNDEFINED;
		cfi->vals[i].base = CFI_UNDEFINED;
238
	}
239 240 241 242 243
	cfi->cfa.base = CFI_UNDEFINED;
	cfi->drap_reg = CFI_UNDEFINED;
	cfi->drap_offset = -1;
}

244
static void init_insn_state(struct insn_state *state, struct section *sec)
245 246 247
{
	memset(state, 0, sizeof(*state));
	init_cfi_state(&state->cfi);
248 249 250 251 252 253 254 255

	/*
	 * We need the full vmlinux for noinstr validation, otherwise we can
	 * not correctly determine insn->call_dest->sec (external symbols do
	 * not have a section).
	 */
	if (vmlinux && sec)
		state->noinstr = sec->noinstr;
256 257
}

258 259 260 261 262 263 264 265 266 267
/*
 * Call the arch-specific instruction decoder for all the instructions and add
 * them to the global instruction list.
 */
static int decode_instructions(struct objtool_file *file)
{
	struct section *sec;
	struct symbol *func;
	unsigned long offset;
	struct instruction *insn;
P
Peter Zijlstra 已提交
268
	unsigned long nr_insns = 0;
269 270
	int ret;

271
	for_each_sec(file, sec) {
272 273 274 275

		if (!(sec->sh.sh_flags & SHF_EXECINSTR))
			continue;

276 277 278 279 280
		if (strcmp(sec->name, ".altinstr_replacement") &&
		    strcmp(sec->name, ".altinstr_aux") &&
		    strncmp(sec->name, ".discard.", 9))
			sec->text = true;

281 282
		if (!strcmp(sec->name, ".noinstr.text") ||
		    !strcmp(sec->name, ".entry.text"))
283 284
			sec->noinstr = true;

285 286
		for (offset = 0; offset < sec->len; offset += insn->len) {
			insn = malloc(sizeof(*insn));
287 288 289 290
			if (!insn) {
				WARN("malloc failed");
				return -1;
			}
291 292
			memset(insn, 0, sizeof(*insn));
			INIT_LIST_HEAD(&insn->alts);
293
			INIT_LIST_HEAD(&insn->stack_ops);
294
			init_cfi_state(&insn->cfi);
295

296 297 298 299 300 301
			insn->sec = sec;
			insn->offset = offset;

			ret = arch_decode_instruction(file->elf, sec, offset,
						      sec->len - offset,
						      &insn->len, &insn->type,
302
						      &insn->immediate,
303
						      &insn->stack_ops);
304
			if (ret)
305
				goto err;
306

307
			hash_add(file->insn_hash, &insn->hash, sec_offset_hash(sec, insn->offset));
308
			list_add_tail(&insn->list, &file->insn_list);
P
Peter Zijlstra 已提交
309
			nr_insns++;
310 311 312
		}

		list_for_each_entry(func, &sec->symbol_list, list) {
313
			if (func->type != STT_FUNC || func->alias != func)
314 315 316 317 318 319 320 321
				continue;

			if (!find_insn(file, sec, func->offset)) {
				WARN("%s(): can't find starting instruction",
				     func->name);
				return -1;
			}

322
			sym_for_each_insn(file, func, insn)
323
				insn->func = func;
324 325 326
		}
	}

P
Peter Zijlstra 已提交
327 328 329
	if (stats)
		printf("nr_insns: %lu\n", nr_insns);

330
	return 0;
331 332 333 334

err:
	free(insn);
	return ret;
335 336
}

337 338 339 340 341 342 343 344 345 346 347 348 349
static struct instruction *find_last_insn(struct objtool_file *file,
					  struct section *sec)
{
	struct instruction *insn = NULL;
	unsigned int offset;
	unsigned int end = (sec->len > 10) ? sec->len - 10 : 0;

	for (offset = sec->len - 1; offset >= end && !insn; offset--)
		insn = find_insn(file, sec, offset);

	return insn;
}

350
/*
351
 * Mark "ud2" instructions and manually annotated dead ends.
352 353 354 355
 */
static int add_dead_ends(struct objtool_file *file)
{
	struct section *sec;
M
Matt Helsley 已提交
356
	struct reloc *reloc;
357 358
	struct instruction *insn;

359 360 361 362 363 364 365 366 367 368 369
	/*
	 * By default, "ud2" is a dead end unless otherwise annotated, because
	 * GCC 7 inserts it for certain divide-by-zero cases.
	 */
	for_each_insn(file, insn)
		if (insn->type == INSN_BUG)
			insn->dead_end = true;

	/*
	 * Check for manually annotated dead ends.
	 */
370 371
	sec = find_section_by_name(file->elf, ".rela.discard.unreachable");
	if (!sec)
372
		goto reachable;
373

M
Matt Helsley 已提交
374 375
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		if (reloc->sym->type != STT_SECTION) {
376 377 378
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}
M
Matt Helsley 已提交
379
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
380 381
		if (insn)
			insn = list_prev_entry(insn, list);
M
Matt Helsley 已提交
382 383
		else if (reloc->addend == reloc->sym->sec->len) {
			insn = find_last_insn(file, reloc->sym->sec);
384
			if (!insn) {
385
				WARN("can't find unreachable insn at %s+0x%x",
M
Matt Helsley 已提交
386
				     reloc->sym->sec->name, reloc->addend);
387 388 389 390
				return -1;
			}
		} else {
			WARN("can't find unreachable insn at %s+0x%x",
M
Matt Helsley 已提交
391
			     reloc->sym->sec->name, reloc->addend);
392 393 394 395 396 397
			return -1;
		}

		insn->dead_end = true;
	}

398 399 400 401 402 403 404 405 406 407 408
reachable:
	/*
	 * These manually annotated reachable checks are needed for GCC 4.4,
	 * where the Linux unreachable() macro isn't supported.  In that case
	 * GCC doesn't know the "ud2" is fatal, so it generates code as if it's
	 * not a dead end.
	 */
	sec = find_section_by_name(file->elf, ".rela.discard.reachable");
	if (!sec)
		return 0;

M
Matt Helsley 已提交
409 410
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		if (reloc->sym->type != STT_SECTION) {
411 412 413
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}
M
Matt Helsley 已提交
414
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
415 416
		if (insn)
			insn = list_prev_entry(insn, list);
M
Matt Helsley 已提交
417 418
		else if (reloc->addend == reloc->sym->sec->len) {
			insn = find_last_insn(file, reloc->sym->sec);
419
			if (!insn) {
420
				WARN("can't find reachable insn at %s+0x%x",
M
Matt Helsley 已提交
421
				     reloc->sym->sec->name, reloc->addend);
422 423 424 425
				return -1;
			}
		} else {
			WARN("can't find reachable insn at %s+0x%x",
M
Matt Helsley 已提交
426
			     reloc->sym->sec->name, reloc->addend);
427 428 429 430 431 432
			return -1;
		}

		insn->dead_end = false;
	}

433 434 435 436 437 438 439 440 441 442 443
	return 0;
}

/*
 * Warnings shouldn't be reported for ignored functions.
 */
static void add_ignores(struct objtool_file *file)
{
	struct instruction *insn;
	struct section *sec;
	struct symbol *func;
M
Matt Helsley 已提交
444
	struct reloc *reloc;
445

P
Peter Zijlstra 已提交
446 447 448
	sec = find_section_by_name(file->elf, ".rela.discard.func_stack_frame_non_standard");
	if (!sec)
		return;
449

M
Matt Helsley 已提交
450 451
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		switch (reloc->sym->type) {
P
Peter Zijlstra 已提交
452
		case STT_FUNC:
M
Matt Helsley 已提交
453
			func = reloc->sym;
P
Peter Zijlstra 已提交
454 455 456
			break;

		case STT_SECTION:
M
Matt Helsley 已提交
457
			func = find_func_by_offset(reloc->sym->sec, reloc->addend);
458
			if (!func)
459
				continue;
P
Peter Zijlstra 已提交
460
			break;
461

P
Peter Zijlstra 已提交
462
		default:
M
Matt Helsley 已提交
463
			WARN("unexpected relocation symbol type in %s: %d", sec->name, reloc->sym->type);
P
Peter Zijlstra 已提交
464
			continue;
465
		}
P
Peter Zijlstra 已提交
466

467
		func_for_each_insn(file, func, insn)
P
Peter Zijlstra 已提交
468
			insn->ignore = true;
469 470 471
	}
}

P
Peter Zijlstra 已提交
472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508
/*
 * This is a whitelist of functions that is allowed to be called with AC set.
 * The list is meant to be minimal and only contains compiler instrumentation
 * ABI and a few functions used to implement *_{to,from}_user() functions.
 *
 * These functions must not directly change AC, but may PUSHF/POPF.
 */
static const char *uaccess_safe_builtin[] = {
	/* KASAN */
	"kasan_report",
	"check_memory_region",
	/* KASAN out-of-line */
	"__asan_loadN_noabort",
	"__asan_load1_noabort",
	"__asan_load2_noabort",
	"__asan_load4_noabort",
	"__asan_load8_noabort",
	"__asan_load16_noabort",
	"__asan_storeN_noabort",
	"__asan_store1_noabort",
	"__asan_store2_noabort",
	"__asan_store4_noabort",
	"__asan_store8_noabort",
	"__asan_store16_noabort",
	/* KASAN in-line */
	"__asan_report_load_n_noabort",
	"__asan_report_load1_noabort",
	"__asan_report_load2_noabort",
	"__asan_report_load4_noabort",
	"__asan_report_load8_noabort",
	"__asan_report_load16_noabort",
	"__asan_report_store_n_noabort",
	"__asan_report_store1_noabort",
	"__asan_report_store2_noabort",
	"__asan_report_store4_noabort",
	"__asan_report_store8_noabort",
	"__asan_report_store16_noabort",
509
	/* KCSAN */
510
	"__kcsan_check_access",
511 512
	"kcsan_found_watchpoint",
	"kcsan_setup_watchpoint",
513
	"kcsan_check_scoped_accesses",
514 515
	"kcsan_disable_current",
	"kcsan_enable_current_nowarn",
516 517 518 519 520 521 522 523 524 525 526 527 528 529 530
	/* KCSAN/TSAN */
	"__tsan_func_entry",
	"__tsan_func_exit",
	"__tsan_read_range",
	"__tsan_write_range",
	"__tsan_read1",
	"__tsan_read2",
	"__tsan_read4",
	"__tsan_read8",
	"__tsan_read16",
	"__tsan_write1",
	"__tsan_write2",
	"__tsan_write4",
	"__tsan_write8",
	"__tsan_write16",
P
Peter Zijlstra 已提交
531 532
	/* KCOV */
	"write_comp_data",
533
	"check_kcov_mode",
P
Peter Zijlstra 已提交
534 535 536 537 538 539 540 541 542
	"__sanitizer_cov_trace_pc",
	"__sanitizer_cov_trace_const_cmp1",
	"__sanitizer_cov_trace_const_cmp2",
	"__sanitizer_cov_trace_const_cmp4",
	"__sanitizer_cov_trace_const_cmp8",
	"__sanitizer_cov_trace_cmp1",
	"__sanitizer_cov_trace_cmp2",
	"__sanitizer_cov_trace_cmp4",
	"__sanitizer_cov_trace_cmp8",
543
	"__sanitizer_cov_trace_switch",
P
Peter Zijlstra 已提交
544 545 546 547
	/* UBSAN */
	"ubsan_type_mismatch_common",
	"__ubsan_handle_type_mismatch",
	"__ubsan_handle_type_mismatch_v1",
548
	"__ubsan_handle_shift_out_of_bounds",
P
Peter Zijlstra 已提交
549 550 551
	/* misc */
	"csum_partial_copy_generic",
	"__memcpy_mcsafe",
552
	"mcsafe_handle_tail",
P
Peter Zijlstra 已提交
553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569
	"ftrace_likely_update", /* CONFIG_TRACE_BRANCH_PROFILING */
	NULL
};

static void add_uaccess_safe(struct objtool_file *file)
{
	struct symbol *func;
	const char **name;

	if (!uaccess)
		return;

	for (name = uaccess_safe_builtin; *name; name++) {
		func = find_symbol_by_name(file->elf, *name);
		if (!func)
			continue;

570
		func->uaccess_safe = true;
571 572 573
	}
}

574 575 576 577 578 579
/*
 * FIXME: For now, just ignore any alternatives which add retpolines.  This is
 * a temporary hack, as it doesn't allow ORC to unwind from inside a retpoline.
 * But it at least allows objtool to understand the control flow *around* the
 * retpoline.
 */
580
static int add_ignore_alternatives(struct objtool_file *file)
581 582
{
	struct section *sec;
M
Matt Helsley 已提交
583
	struct reloc *reloc;
584 585
	struct instruction *insn;

586
	sec = find_section_by_name(file->elf, ".rela.discard.ignore_alts");
587 588 589
	if (!sec)
		return 0;

M
Matt Helsley 已提交
590 591
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		if (reloc->sym->type != STT_SECTION) {
592 593 594 595
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}

M
Matt Helsley 已提交
596
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
597
		if (!insn) {
598
			WARN("bad .discard.ignore_alts entry");
599 600 601 602 603 604 605 606 607
			return -1;
		}

		insn->ignore_alts = true;
	}

	return 0;
}

608 609 610 611 612 613
/*
 * Find the destination instructions for all jumps.
 */
static int add_jump_destinations(struct objtool_file *file)
{
	struct instruction *insn;
M
Matt Helsley 已提交
614
	struct reloc *reloc;
615 616 617 618
	struct section *dest_sec;
	unsigned long dest_off;

	for_each_insn(file, insn) {
619
		if (!is_static_jump(insn))
620 621
			continue;

622
		if (insn->ignore || insn->offset == FAKE_JUMP_OFFSET)
623 624
			continue;

M
Matt Helsley 已提交
625
		reloc = find_reloc_by_dest_range(file->elf, insn->sec,
626
					       insn->offset, insn->len);
M
Matt Helsley 已提交
627
		if (!reloc) {
628
			dest_sec = insn->sec;
629
			dest_off = arch_jump_destination(insn);
M
Matt Helsley 已提交
630 631 632 633 634 635 636 637
		} else if (reloc->sym->type == STT_SECTION) {
			dest_sec = reloc->sym->sec;
			dest_off = arch_dest_reloc_offset(reloc->addend);
		} else if (reloc->sym->sec->idx) {
			dest_sec = reloc->sym->sec;
			dest_off = reloc->sym->sym.st_value +
				   arch_dest_reloc_offset(reloc->addend);
		} else if (strstr(reloc->sym->name, "_indirect_thunk_")) {
638 639 640 641
			/*
			 * Retpoline jumps are really dynamic jumps in
			 * disguise, so convert them accordingly.
			 */
642 643 644 645 646
			if (insn->type == INSN_JUMP_UNCONDITIONAL)
				insn->type = INSN_JUMP_DYNAMIC;
			else
				insn->type = INSN_JUMP_DYNAMIC_CONDITIONAL;

647
			insn->retpoline_safe = true;
648
			continue;
649
		} else {
650
			/* external sibling call */
M
Matt Helsley 已提交
651
			insn->call_dest = reloc->sym;
652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670
			continue;
		}

		insn->jump_dest = find_insn(file, dest_sec, dest_off);
		if (!insn->jump_dest) {

			/*
			 * This is a special case where an alt instruction
			 * jumps past the end of the section.  These are
			 * handled later in handle_group_alt().
			 */
			if (!strcmp(insn->sec->name, ".altinstr_replacement"))
				continue;

			WARN_FUNC("can't find jump dest instruction at %s+0x%lx",
				  insn->sec, insn->offset, dest_sec->name,
				  dest_off);
			return -1;
		}
671 672

		/*
673
		 * Cross-function jump.
674 675
		 */
		if (insn->func && insn->jump_dest->func &&
676 677 678 679 680 681 682 683 684 685 686 687 688 689 690
		    insn->func != insn->jump_dest->func) {

			/*
			 * For GCC 8+, create parent/child links for any cold
			 * subfunctions.  This is _mostly_ redundant with a
			 * similar initialization in read_symbols().
			 *
			 * If a function has aliases, we want the *first* such
			 * function in the symbol table to be the subfunction's
			 * parent.  In that case we overwrite the
			 * initialization done in read_symbols().
			 *
			 * However this code can't completely replace the
			 * read_symbols() code because this doesn't detect the
			 * case where the parent function's only reference to a
691
			 * subfunction is through a jump table.
692 693 694 695 696 697 698 699 700
			 */
			if (!strstr(insn->func->name, ".cold.") &&
			    strstr(insn->jump_dest->func->name, ".cold.")) {
				insn->func->cfunc = insn->jump_dest->func;
				insn->jump_dest->func->pfunc = insn->func;

			} else if (insn->jump_dest->func->pfunc != insn->func->pfunc &&
				   insn->jump_dest->offset == insn->jump_dest->func->offset) {

701
				/* internal sibling call */
702 703
				insn->call_dest = insn->jump_dest->func;
			}
704
		}
705 706 707 708 709
	}

	return 0;
}

710 711 712 713 714 715 716 717 718 719
static void remove_insn_ops(struct instruction *insn)
{
	struct stack_op *op, *tmp;

	list_for_each_entry_safe(op, tmp, &insn->stack_ops, list) {
		list_del(&op->list);
		free(op);
	}
}

720 721 722 723 724 725 726
/*
 * Find the destination instructions for all calls.
 */
static int add_call_destinations(struct objtool_file *file)
{
	struct instruction *insn;
	unsigned long dest_off;
M
Matt Helsley 已提交
727
	struct reloc *reloc;
728 729 730 731 732

	for_each_insn(file, insn) {
		if (insn->type != INSN_CALL)
			continue;

M
Matt Helsley 已提交
733
		reloc = find_reloc_by_dest_range(file->elf, insn->sec,
734
					       insn->offset, insn->len);
M
Matt Helsley 已提交
735
		if (!reloc) {
736
			dest_off = arch_jump_destination(insn);
737 738 739
			insn->call_dest = find_func_by_offset(insn->sec, dest_off);
			if (!insn->call_dest)
				insn->call_dest = find_symbol_by_offset(insn->sec, dest_off);
740

741 742 743 744
			if (insn->ignore)
				continue;

			if (!insn->call_dest) {
745
				WARN_FUNC("unannotated intra-function call", insn->sec, insn->offset);
746 747
				return -1;
			}
748

749 750 751 752 753 754
			if (insn->func && insn->call_dest->type != STT_FUNC) {
				WARN_FUNC("unsupported call to non-function",
					  insn->sec, insn->offset);
				return -1;
			}

M
Matt Helsley 已提交
755 756 757
		} else if (reloc->sym->type == STT_SECTION) {
			dest_off = arch_dest_reloc_offset(reloc->addend);
			insn->call_dest = find_func_by_offset(reloc->sym->sec,
758
							      dest_off);
759
			if (!insn->call_dest) {
760
				WARN_FUNC("can't find call dest symbol at %s+0x%lx",
761
					  insn->sec, insn->offset,
M
Matt Helsley 已提交
762
					  reloc->sym->sec->name,
763
					  dest_off);
764 765 766
				return -1;
			}
		} else
M
Matt Helsley 已提交
767
			insn->call_dest = reloc->sym;
768

P
Peter Zijlstra 已提交
769 770 771 772 773 774 775
		/*
		 * Many compilers cannot disable KCOV with a function attribute
		 * so they need a little help, NOP out any KCOV calls from noinstr
		 * text.
		 */
		if (insn->sec->noinstr &&
		    !strncmp(insn->call_dest->name, "__sanitizer_cov_", 16)) {
776 777 778
			if (reloc) {
				reloc->type = R_NONE;
				elf_write_reloc(file->elf, reloc);
P
Peter Zijlstra 已提交
779 780 781 782 783 784 785 786
			}

			elf_write_insn(file->elf, insn->sec,
				       insn->offset, insn->len,
				       arch_nop_insn(insn->len));
			insn->type = INSN_NOP;
		}

787 788 789 790 791 792 793 794
		/*
		 * Whatever stack impact regular CALLs have, should be undone
		 * by the RETURN of the called function.
		 *
		 * Annotated intra-function calls retain the stack_ops but
		 * are converted to JUMP, see read_intra_function_calls().
		 */
		remove_insn_ops(insn);
795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821
	}

	return 0;
}

/*
 * The .alternatives section requires some extra special care, over and above
 * what other special sections require:
 *
 * 1. Because alternatives are patched in-place, we need to insert a fake jump
 *    instruction at the end so that validate_branch() skips all the original
 *    replaced instructions when validating the new instruction path.
 *
 * 2. An added wrinkle is that the new instruction length might be zero.  In
 *    that case the old instructions are replaced with noops.  We simulate that
 *    by creating a fake jump as the only new instruction.
 *
 * 3. In some cases, the alternative section includes an instruction which
 *    conditionally jumps to the _end_ of the entry.  We have to modify these
 *    jumps' destinations to point back to .text rather than the end of the
 *    entry in .altinstr_replacement.
 */
static int handle_group_alt(struct objtool_file *file,
			    struct special_alt *special_alt,
			    struct instruction *orig_insn,
			    struct instruction **new_insn)
{
822
	static unsigned int alt_group_next_index = 1;
823
	struct instruction *last_orig_insn, *last_new_insn, *insn, *fake_jump = NULL;
824
	unsigned int alt_group = alt_group_next_index++;
825 826 827 828 829 830 831 832
	unsigned long dest_off;

	last_orig_insn = NULL;
	insn = orig_insn;
	sec_for_each_insn_from(file, insn) {
		if (insn->offset >= special_alt->orig_off + special_alt->orig_len)
			break;

833
		insn->alt_group = alt_group;
834 835 836
		last_orig_insn = insn;
	}

837 838 839 840 841 842 843 844
	if (next_insn_same_sec(file, last_orig_insn)) {
		fake_jump = malloc(sizeof(*fake_jump));
		if (!fake_jump) {
			WARN("malloc failed");
			return -1;
		}
		memset(fake_jump, 0, sizeof(*fake_jump));
		INIT_LIST_HEAD(&fake_jump->alts);
845
		INIT_LIST_HEAD(&fake_jump->stack_ops);
846
		init_cfi_state(&fake_jump->cfi);
847 848

		fake_jump->sec = special_alt->new_sec;
849
		fake_jump->offset = FAKE_JUMP_OFFSET;
850 851
		fake_jump->type = INSN_JUMP_UNCONDITIONAL;
		fake_jump->jump_dest = list_next_entry(last_orig_insn, list);
852
		fake_jump->func = orig_insn->func;
853 854 855
	}

	if (!special_alt->new_len) {
856 857 858 859 860 861
		if (!fake_jump) {
			WARN("%s: empty alternative at end of section",
			     special_alt->orig_sec->name);
			return -1;
		}

862 863 864 865 866
		*new_insn = fake_jump;
		return 0;
	}

	last_new_insn = NULL;
867
	alt_group = alt_group_next_index++;
868 869 870 871 872 873 874
	insn = *new_insn;
	sec_for_each_insn_from(file, insn) {
		if (insn->offset >= special_alt->new_off + special_alt->new_len)
			break;

		last_new_insn = insn;

875
		insn->ignore = orig_insn->ignore_alts;
876
		insn->func = orig_insn->func;
877
		insn->alt_group = alt_group;
878

879 880 881 882 883 884 885 886 887 888 889 890 891 892
		/*
		 * Since alternative replacement code is copy/pasted by the
		 * kernel after applying relocations, generally such code can't
		 * have relative-address relocation references to outside the
		 * .altinstr_replacement section, unless the arch's
		 * alternatives code can adjust the relative offsets
		 * accordingly.
		 *
		 * The x86 alternatives code adjusts the offsets only when it
		 * encounters a branch instruction at the very beginning of the
		 * replacement group.
		 */
		if ((insn->offset != special_alt->new_off ||
		    (insn->type != INSN_CALL && !is_static_jump(insn))) &&
M
Matt Helsley 已提交
893
		    find_reloc_by_dest_range(file->elf, insn->sec, insn->offset, insn->len)) {
894 895 896 897 898 899

			WARN_FUNC("unsupported relocation in alternatives section",
				  insn->sec, insn->offset);
			return -1;
		}

900
		if (!is_static_jump(insn))
901 902 903 904 905
			continue;

		if (!insn->immediate)
			continue;

906
		dest_off = arch_jump_destination(insn);
907 908 909 910 911 912
		if (dest_off == special_alt->new_off + special_alt->new_len) {
			if (!fake_jump) {
				WARN("%s: alternative jump to end of section",
				     special_alt->orig_sec->name);
				return -1;
			}
913
			insn->jump_dest = fake_jump;
914
		}
915 916 917 918 919 920 921 922 923 924 925 926 927 928

		if (!insn->jump_dest) {
			WARN_FUNC("can't find alternative jump destination",
				  insn->sec, insn->offset);
			return -1;
		}
	}

	if (!last_new_insn) {
		WARN_FUNC("can't find last new alternative instruction",
			  special_alt->new_sec, special_alt->new_off);
		return -1;
	}

929 930
	if (fake_jump)
		list_add(&fake_jump->list, &last_new_insn->list);
931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000

	return 0;
}

/*
 * A jump table entry can either convert a nop to a jump or a jump to a nop.
 * If the original instruction is a jump, make the alt entry an effective nop
 * by just skipping the original instruction.
 */
static int handle_jump_alt(struct objtool_file *file,
			   struct special_alt *special_alt,
			   struct instruction *orig_insn,
			   struct instruction **new_insn)
{
	if (orig_insn->type == INSN_NOP)
		return 0;

	if (orig_insn->type != INSN_JUMP_UNCONDITIONAL) {
		WARN_FUNC("unsupported instruction at jump label",
			  orig_insn->sec, orig_insn->offset);
		return -1;
	}

	*new_insn = list_next_entry(orig_insn, list);
	return 0;
}

/*
 * Read all the special sections which have alternate instructions which can be
 * patched in or redirected to at runtime.  Each instruction having alternate
 * instruction(s) has them added to its insn->alts list, which will be
 * traversed in validate_branch().
 */
static int add_special_section_alts(struct objtool_file *file)
{
	struct list_head special_alts;
	struct instruction *orig_insn, *new_insn;
	struct special_alt *special_alt, *tmp;
	struct alternative *alt;
	int ret;

	ret = special_get_alts(file->elf, &special_alts);
	if (ret)
		return ret;

	list_for_each_entry_safe(special_alt, tmp, &special_alts, list) {

		orig_insn = find_insn(file, special_alt->orig_sec,
				      special_alt->orig_off);
		if (!orig_insn) {
			WARN_FUNC("special: can't find orig instruction",
				  special_alt->orig_sec, special_alt->orig_off);
			ret = -1;
			goto out;
		}

		new_insn = NULL;
		if (!special_alt->group || special_alt->new_len) {
			new_insn = find_insn(file, special_alt->new_sec,
					     special_alt->new_off);
			if (!new_insn) {
				WARN_FUNC("special: can't find new instruction",
					  special_alt->new_sec,
					  special_alt->new_off);
				ret = -1;
				goto out;
			}
		}

		if (special_alt->group) {
1001 1002 1003 1004 1005 1006
			if (!special_alt->orig_len) {
				WARN_FUNC("empty alternative entry",
					  orig_insn->sec, orig_insn->offset);
				continue;
			}

1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017
			ret = handle_group_alt(file, special_alt, orig_insn,
					       &new_insn);
			if (ret)
				goto out;
		} else if (special_alt->jump_or_nop) {
			ret = handle_jump_alt(file, special_alt, orig_insn,
					      &new_insn);
			if (ret)
				goto out;
		}

1018 1019 1020 1021 1022 1023 1024
		alt = malloc(sizeof(*alt));
		if (!alt) {
			WARN("malloc failed");
			ret = -1;
			goto out;
		}

1025
		alt->insn = new_insn;
P
Peter Zijlstra 已提交
1026
		alt->skip_orig = special_alt->skip_orig;
P
Peter Zijlstra 已提交
1027
		orig_insn->ignore_alts |= special_alt->skip_alt;
1028 1029 1030 1031 1032 1033 1034 1035 1036 1037
		list_add_tail(&alt->list, &orig_insn->alts);

		list_del(&special_alt->list);
		free(special_alt);
	}

out:
	return ret;
}

1038
static int add_jump_table(struct objtool_file *file, struct instruction *insn,
M
Matt Helsley 已提交
1039
			    struct reloc *table)
1040
{
M
Matt Helsley 已提交
1041
	struct reloc *reloc = table;
1042
	struct instruction *dest_insn;
1043
	struct alternative *alt;
1044 1045
	struct symbol *pfunc = insn->func->pfunc;
	unsigned int prev_offset = 0;
1046

1047
	/*
M
Matt Helsley 已提交
1048
	 * Each @reloc is a switch table relocation which points to the target
1049 1050
	 * instruction.
	 */
M
Matt Helsley 已提交
1051
	list_for_each_entry_from(reloc, &table->sec->reloc_list, list) {
1052 1053

		/* Check for the end of the table: */
M
Matt Helsley 已提交
1054
		if (reloc != table && reloc->jump_table_start)
1055 1056
			break;

1057
		/* Make sure the table entries are consecutive: */
M
Matt Helsley 已提交
1058
		if (prev_offset && reloc->offset != prev_offset + 8)
1059 1060 1061
			break;

		/* Detect function pointers from contiguous objects: */
M
Matt Helsley 已提交
1062 1063
		if (reloc->sym->sec == pfunc->sec &&
		    reloc->addend == pfunc->offset)
1064 1065
			break;

M
Matt Helsley 已提交
1066
		dest_insn = find_insn(file, reloc->sym->sec, reloc->addend);
1067
		if (!dest_insn)
1068 1069
			break;

1070
		/* Make sure the destination is in the same function: */
1071
		if (!dest_insn->func || dest_insn->func->pfunc != pfunc)
1072
			break;
1073 1074 1075 1076 1077 1078 1079

		alt = malloc(sizeof(*alt));
		if (!alt) {
			WARN("malloc failed");
			return -1;
		}

1080
		alt->insn = dest_insn;
1081
		list_add_tail(&alt->list, &insn->alts);
M
Matt Helsley 已提交
1082
		prev_offset = reloc->offset;
1083 1084 1085 1086 1087 1088
	}

	if (!prev_offset) {
		WARN_FUNC("can't find switch jump table",
			  insn->sec, insn->offset);
		return -1;
1089 1090 1091 1092 1093 1094
	}

	return 0;
}

/*
1095
 * find_jump_table() - Given a dynamic jump, find the switch jump table in
1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127
 * .rodata associated with it.
 *
 * There are 3 basic patterns:
 *
 * 1. jmpq *[rodata addr](,%reg,8)
 *
 *    This is the most common case by far.  It jumps to an address in a simple
 *    jump table which is stored in .rodata.
 *
 * 2. jmpq *[rodata addr](%rip)
 *
 *    This is caused by a rare GCC quirk, currently only seen in three driver
 *    functions in the kernel, only with certain obscure non-distro configs.
 *
 *    As part of an optimization, GCC makes a copy of an existing switch jump
 *    table, modifies it, and then hard-codes the jump (albeit with an indirect
 *    jump) to use a single entry in the table.  The rest of the jump table and
 *    some of its jump targets remain as dead code.
 *
 *    In such a case we can just crudely ignore all unreachable instruction
 *    warnings for the entire object file.  Ideally we would just ignore them
 *    for the function, but that would require redesigning the code quite a
 *    bit.  And honestly that's just not worth doing: unreachable instruction
 *    warnings are of questionable value anyway, and this is such a rare issue.
 *
 * 3. mov [rodata addr],%reg1
 *    ... some instructions ...
 *    jmpq *(%reg1,%reg2,8)
 *
 *    This is a fairly uncommon pattern which is new for GCC 6.  As of this
 *    writing, there are 11 occurrences of it in the allmodconfig kernel.
 *
1128 1129 1130 1131
 *    As of GCC 7 there are quite a few more of these and the 'in between' code
 *    is significant. Esp. with KASAN enabled some of the code between the mov
 *    and jmpq uses .rodata itself, which can confuse things.
 *
1132 1133
 *    TODO: Once we have DWARF CFI and smarter instruction decoding logic,
 *    ensure the same register is used in the mov and jump instructions.
1134 1135
 *
 *    NOTE: RETPOLINE made it harder still to decode dynamic jumps.
1136
 */
M
Matt Helsley 已提交
1137
static struct reloc *find_jump_table(struct objtool_file *file,
1138 1139 1140
				      struct symbol *func,
				      struct instruction *insn)
{
M
Matt Helsley 已提交
1141
	struct reloc *text_reloc, *table_reloc;
1142
	struct instruction *dest_insn, *orig_insn = insn;
1143
	struct section *table_sec;
1144
	unsigned long table_offset;
1145

1146 1147 1148 1149 1150
	/*
	 * Backward search using the @first_jump_src links, these help avoid
	 * much of the 'in between' code. Which avoids us getting confused by
	 * it.
	 */
1151
	for (;
1152 1153
	     insn && insn->func && insn->func->pfunc == func;
	     insn = insn->first_jump_src ?: prev_insn_same_sym(file, insn)) {
1154

1155
		if (insn != orig_insn && insn->type == INSN_JUMP_DYNAMIC)
1156 1157 1158 1159 1160 1161 1162 1163 1164 1165
			break;

		/* allow small jumps within the range */
		if (insn->type == INSN_JUMP_UNCONDITIONAL &&
		    insn->jump_dest &&
		    (insn->jump_dest->offset <= insn->offset ||
		     insn->jump_dest->offset > orig_insn->offset))
		    break;

		/* look for a relocation which references .rodata */
M
Matt Helsley 已提交
1166
		text_reloc = find_reloc_by_dest_range(file->elf, insn->sec,
1167
						    insn->offset, insn->len);
M
Matt Helsley 已提交
1168 1169
		if (!text_reloc || text_reloc->sym->type != STT_SECTION ||
		    !text_reloc->sym->sec->rodata)
1170 1171
			continue;

M
Matt Helsley 已提交
1172 1173
		table_offset = text_reloc->addend;
		table_sec = text_reloc->sym->sec;
1174

M
Matt Helsley 已提交
1175
		if (text_reloc->type == R_X86_64_PC32)
1176 1177
			table_offset += 4;

1178 1179
		/*
		 * Make sure the .rodata address isn't associated with a
1180 1181 1182 1183 1184 1185
		 * symbol.  GCC jump tables are anonymous data.
		 *
		 * Also support C jump tables which are in the same format as
		 * switch jump tables.  For objtool to recognize them, they
		 * need to be placed in the C_JUMP_TABLE_SECTION section.  They
		 * have symbols associated with them.
1186
		 */
1187 1188
		if (find_symbol_containing(table_sec, table_offset) &&
		    strcmp(table_sec->name, C_JUMP_TABLE_SECTION))
1189 1190
			continue;

1191
		/*
M
Matt Helsley 已提交
1192
		 * Each table entry has a reloc associated with it.  The reloc
1193 1194 1195
		 * should reference text in the same function as the original
		 * instruction.
		 */
M
Matt Helsley 已提交
1196 1197
		table_reloc = find_reloc_by_dest(file->elf, table_sec, table_offset);
		if (!table_reloc)
1198
			continue;
M
Matt Helsley 已提交
1199
		dest_insn = find_insn(file, table_reloc->sym->sec, table_reloc->addend);
1200 1201
		if (!dest_insn || !dest_insn->func || dest_insn->func->pfunc != func)
			continue;
1202

1203 1204 1205 1206 1207
		/*
		 * Use of RIP-relative switch jumps is quite rare, and
		 * indicates a rare GCC quirk/bug which can leave dead code
		 * behind.
		 */
M
Matt Helsley 已提交
1208
		if (text_reloc->type == R_X86_64_PC32)
1209 1210
			file->ignore_unreachables = true;

M
Matt Helsley 已提交
1211
		return table_reloc;
1212 1213 1214 1215 1216
	}

	return NULL;
}

1217 1218 1219 1220 1221 1222
/*
 * First pass: Mark the head of each jump table so that in the next pass,
 * we know when a given jump table ends and the next one starts.
 */
static void mark_func_jump_tables(struct objtool_file *file,
				    struct symbol *func)
1223
{
1224
	struct instruction *insn, *last = NULL;
M
Matt Helsley 已提交
1225
	struct reloc *reloc;
1226

1227
	func_for_each_insn(file, func, insn) {
1228 1229 1230 1231 1232
		if (!last)
			last = insn;

		/*
		 * Store back-pointers for unconditional forward jumps such
1233
		 * that find_jump_table() can back-track using those and
1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244
		 * avoid some potentially confusing code.
		 */
		if (insn->type == INSN_JUMP_UNCONDITIONAL && insn->jump_dest &&
		    insn->offset > last->offset &&
		    insn->jump_dest->offset > insn->offset &&
		    !insn->jump_dest->first_jump_src) {

			insn->jump_dest->first_jump_src = insn;
			last = insn->jump_dest;
		}

1245 1246 1247
		if (insn->type != INSN_JUMP_DYNAMIC)
			continue;

M
Matt Helsley 已提交
1248 1249 1250 1251
		reloc = find_jump_table(file, func, insn);
		if (reloc) {
			reloc->jump_table_start = true;
			insn->jump_table = reloc;
1252 1253
		}
	}
1254 1255 1256 1257 1258 1259 1260 1261
}

static int add_func_jump_tables(struct objtool_file *file,
				  struct symbol *func)
{
	struct instruction *insn;
	int ret;

1262
	func_for_each_insn(file, func, insn) {
1263 1264
		if (!insn->jump_table)
			continue;
1265

1266
		ret = add_jump_table(file, insn, insn->jump_table);
1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278
		if (ret)
			return ret;
	}

	return 0;
}

/*
 * For some switch statements, gcc generates a jump table in the .rodata
 * section which contains a list of addresses within the function to jump to.
 * This finds these jump tables and adds them to the insn->alts lists.
 */
1279
static int add_jump_table_alts(struct objtool_file *file)
1280 1281 1282 1283 1284
{
	struct section *sec;
	struct symbol *func;
	int ret;

1285
	if (!file->rodata)
1286 1287
		return 0;

1288
	for_each_sec(file, sec) {
1289 1290 1291 1292
		list_for_each_entry(func, &sec->symbol_list, list) {
			if (func->type != STT_FUNC)
				continue;

1293
			mark_func_jump_tables(file, func);
1294
			ret = add_func_jump_tables(file, func);
1295 1296 1297 1298 1299 1300 1301 1302
			if (ret)
				return ret;
		}
	}

	return 0;
}

1303 1304
static int read_unwind_hints(struct objtool_file *file)
{
M
Matt Helsley 已提交
1305 1306
	struct section *sec, *relocsec;
	struct reloc *reloc;
1307 1308 1309 1310 1311 1312 1313 1314 1315
	struct unwind_hint *hint;
	struct instruction *insn;
	struct cfi_reg *cfa;
	int i;

	sec = find_section_by_name(file->elf, ".discard.unwind_hints");
	if (!sec)
		return 0;

M
Matt Helsley 已提交
1316 1317
	relocsec = sec->reloc;
	if (!relocsec) {
1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331
		WARN("missing .rela.discard.unwind_hints section");
		return -1;
	}

	if (sec->len % sizeof(struct unwind_hint)) {
		WARN("struct unwind_hint size mismatch");
		return -1;
	}

	file->hints = true;

	for (i = 0; i < sec->len / sizeof(struct unwind_hint); i++) {
		hint = (struct unwind_hint *)sec->data->d_buf + i;

M
Matt Helsley 已提交
1332 1333 1334
		reloc = find_reloc_by_dest(file->elf, sec, i * sizeof(*hint));
		if (!reloc) {
			WARN("can't find reloc for unwind_hints[%d]", i);
1335 1336 1337
			return -1;
		}

M
Matt Helsley 已提交
1338
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
1339 1340 1341 1342 1343
		if (!insn) {
			WARN("can't find insn for unwind_hints[%d]", i);
			return -1;
		}

1344
		cfa = &insn->cfi.cfa;
1345

1346
		if (hint->type == UNWIND_HINT_TYPE_RET_OFFSET) {
1347
			insn->ret_offset = hint->sp_offset;
1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384
			continue;
		}

		insn->hint = true;

		switch (hint->sp_reg) {
		case ORC_REG_UNDEFINED:
			cfa->base = CFI_UNDEFINED;
			break;
		case ORC_REG_SP:
			cfa->base = CFI_SP;
			break;
		case ORC_REG_BP:
			cfa->base = CFI_BP;
			break;
		case ORC_REG_SP_INDIRECT:
			cfa->base = CFI_SP_INDIRECT;
			break;
		case ORC_REG_R10:
			cfa->base = CFI_R10;
			break;
		case ORC_REG_R13:
			cfa->base = CFI_R13;
			break;
		case ORC_REG_DI:
			cfa->base = CFI_DI;
			break;
		case ORC_REG_DX:
			cfa->base = CFI_DX;
			break;
		default:
			WARN_FUNC("unsupported unwind_hint sp base reg %d",
				  insn->sec, insn->offset, hint->sp_reg);
			return -1;
		}

		cfa->offset = hint->sp_offset;
1385 1386
		insn->cfi.type = hint->type;
		insn->cfi.end = hint->end;
1387 1388 1389 1390 1391
	}

	return 0;
}

1392 1393
static int read_retpoline_hints(struct objtool_file *file)
{
J
Josh Poimboeuf 已提交
1394
	struct section *sec;
1395
	struct instruction *insn;
M
Matt Helsley 已提交
1396
	struct reloc *reloc;
1397

J
Josh Poimboeuf 已提交
1398
	sec = find_section_by_name(file->elf, ".rela.discard.retpoline_safe");
1399 1400 1401
	if (!sec)
		return 0;

M
Matt Helsley 已提交
1402 1403
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		if (reloc->sym->type != STT_SECTION) {
J
Josh Poimboeuf 已提交
1404
			WARN("unexpected relocation symbol type in %s", sec->name);
1405 1406 1407
			return -1;
		}

M
Matt Helsley 已提交
1408
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
1409
		if (!insn) {
J
Josh Poimboeuf 已提交
1410
			WARN("bad .discard.retpoline_safe entry");
1411 1412 1413 1414 1415
			return -1;
		}

		if (insn->type != INSN_JUMP_DYNAMIC &&
		    insn->type != INSN_CALL_DYNAMIC) {
J
Josh Poimboeuf 已提交
1416
			WARN_FUNC("retpoline_safe hint not an indirect jump/call",
1417 1418 1419 1420 1421 1422 1423 1424 1425 1426
				  insn->sec, insn->offset);
			return -1;
		}

		insn->retpoline_safe = true;
	}

	return 0;
}

1427 1428 1429 1430
static int read_instr_hints(struct objtool_file *file)
{
	struct section *sec;
	struct instruction *insn;
M
Matt Helsley 已提交
1431
	struct reloc *reloc;
1432 1433 1434 1435 1436

	sec = find_section_by_name(file->elf, ".rela.discard.instr_end");
	if (!sec)
		return 0;

M
Matt Helsley 已提交
1437 1438
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		if (reloc->sym->type != STT_SECTION) {
1439 1440 1441 1442
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}

M
Matt Helsley 已提交
1443
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455
		if (!insn) {
			WARN("bad .discard.instr_end entry");
			return -1;
		}

		insn->instr--;
	}

	sec = find_section_by_name(file->elf, ".rela.discard.instr_begin");
	if (!sec)
		return 0;

M
Matt Helsley 已提交
1456 1457
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		if (reloc->sym->type != STT_SECTION) {
1458 1459 1460 1461
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}

M
Matt Helsley 已提交
1462
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473
		if (!insn) {
			WARN("bad .discard.instr_begin entry");
			return -1;
		}

		insn->instr++;
	}

	return 0;
}

1474 1475 1476 1477
static int read_intra_function_calls(struct objtool_file *file)
{
	struct instruction *insn;
	struct section *sec;
M
Matt Helsley 已提交
1478
	struct reloc *reloc;
1479 1480 1481 1482 1483

	sec = find_section_by_name(file->elf, ".rela.discard.intra_function_calls");
	if (!sec)
		return 0;

M
Matt Helsley 已提交
1484
	list_for_each_entry(reloc, &sec->reloc_list, list) {
1485 1486
		unsigned long dest_off;

M
Matt Helsley 已提交
1487
		if (reloc->sym->type != STT_SECTION) {
1488 1489 1490 1491 1492
			WARN("unexpected relocation symbol type in %s",
			     sec->name);
			return -1;
		}

M
Matt Helsley 已提交
1493
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524
		if (!insn) {
			WARN("bad .discard.intra_function_call entry");
			return -1;
		}

		if (insn->type != INSN_CALL) {
			WARN_FUNC("intra_function_call not a direct call",
				  insn->sec, insn->offset);
			return -1;
		}

		/*
		 * Treat intra-function CALLs as JMPs, but with a stack_op.
		 * See add_call_destinations(), which strips stack_ops from
		 * normal CALLs.
		 */
		insn->type = INSN_JUMP_UNCONDITIONAL;

		dest_off = insn->offset + insn->len + insn->immediate;
		insn->jump_dest = find_insn(file, insn->sec, dest_off);
		if (!insn->jump_dest) {
			WARN_FUNC("can't find call dest at %s+0x%lx",
				  insn->sec, insn->offset,
				  insn->sec->name, dest_off);
			return -1;
		}
	}

	return 0;
}

1525 1526 1527 1528 1529 1530
static void mark_rodata(struct objtool_file *file)
{
	struct section *sec;
	bool found = false;

	/*
1531 1532 1533 1534 1535 1536 1537 1538
	 * Search for the following rodata sections, each of which can
	 * potentially contain jump tables:
	 *
	 * - .rodata: can contain GCC switch tables
	 * - .rodata.<func>: same, if -fdata-sections is being used
	 * - .rodata..c_jump_table: contains C annotated jump tables
	 *
	 * .rodata.str1.* sections are ignored; they don't contain jump tables.
1539 1540
	 */
	for_each_sec(file, sec) {
1541 1542
		if (!strncmp(sec->name, ".rodata", 7) &&
		    !strstr(sec->name, ".str1.")) {
1543 1544 1545 1546 1547 1548 1549 1550
			sec->rodata = true;
			found = true;
		}
	}

	file->rodata = found;
}

1551 1552 1553 1554
static int decode_sections(struct objtool_file *file)
{
	int ret;

1555 1556
	mark_rodata(file);

1557 1558 1559 1560 1561 1562 1563 1564 1565
	ret = decode_instructions(file);
	if (ret)
		return ret;

	ret = add_dead_ends(file);
	if (ret)
		return ret;

	add_ignores(file);
P
Peter Zijlstra 已提交
1566
	add_uaccess_safe(file);
1567

1568
	ret = add_ignore_alternatives(file);
1569 1570 1571
	if (ret)
		return ret;

1572 1573 1574 1575
	ret = add_jump_destinations(file);
	if (ret)
		return ret;

1576
	ret = add_special_section_alts(file);
1577 1578 1579
	if (ret)
		return ret;

1580 1581 1582 1583
	ret = read_intra_function_calls(file);
	if (ret)
		return ret;

1584
	ret = add_call_destinations(file);
1585 1586 1587
	if (ret)
		return ret;

1588
	ret = add_jump_table_alts(file);
1589 1590 1591
	if (ret)
		return ret;

1592 1593 1594 1595
	ret = read_unwind_hints(file);
	if (ret)
		return ret;

1596 1597 1598 1599
	ret = read_retpoline_hints(file);
	if (ret)
		return ret;

1600 1601 1602 1603
	ret = read_instr_hints(file);
	if (ret)
		return ret;

1604 1605 1606 1607 1608
	return 0;
}

static bool is_fentry_call(struct instruction *insn)
{
1609
	if (insn->type == INSN_CALL && insn->call_dest &&
1610 1611 1612 1613 1614 1615 1616
	    insn->call_dest->type == STT_NOTYPE &&
	    !strcmp(insn->call_dest->name, "__fentry__"))
		return true;

	return false;
}

1617
static bool has_modified_stack_frame(struct instruction *insn, struct insn_state *state)
1618
{
1619
	u8 ret_offset = insn->ret_offset;
1620
	struct cfi_state *cfi = &state->cfi;
1621 1622
	int i;

1623
	if (cfi->cfa.base != initial_func_cfi.cfa.base || cfi->drap)
1624 1625
		return true;

1626
	if (cfi->cfa.offset != initial_func_cfi.cfa.offset + ret_offset)
1627 1628
		return true;

1629
	if (cfi->stack_size != initial_func_cfi.cfa.offset + ret_offset)
1630 1631
		return true;

1632 1633 1634 1635 1636 1637 1638 1639
	/*
	 * If there is a ret offset hint then don't check registers
	 * because a callee-saved register might have been pushed on
	 * the stack.
	 */
	if (ret_offset)
		return false;

1640
	for (i = 0; i < CFI_NUM_REGS; i++) {
1641 1642
		if (cfi->regs[i].base != initial_func_cfi.regs[i].base ||
		    cfi->regs[i].offset != initial_func_cfi.regs[i].offset)
1643
			return true;
1644
	}
1645 1646 1647 1648 1649 1650

	return false;
}

static bool has_valid_stack_frame(struct insn_state *state)
{
1651 1652 1653 1654
	struct cfi_state *cfi = &state->cfi;

	if (cfi->cfa.base == CFI_BP && cfi->regs[CFI_BP].base == CFI_CFA &&
	    cfi->regs[CFI_BP].offset == -16)
1655 1656
		return true;

1657
	if (cfi->drap && cfi->regs[CFI_BP].base == CFI_BP)
1658 1659 1660
		return true;

	return false;
1661 1662
}

1663 1664
static int update_cfi_state_regs(struct instruction *insn,
				  struct cfi_state *cfi,
1665
				  struct stack_op *op)
1666
{
1667
	struct cfi_reg *cfa = &cfi->cfa;
1668

1669
	if (cfa->base != CFI_SP && cfa->base != CFI_SP_INDIRECT)
1670 1671 1672
		return 0;

	/* push */
P
Peter Zijlstra 已提交
1673
	if (op->dest.type == OP_DEST_PUSH || op->dest.type == OP_DEST_PUSHF)
1674 1675 1676
		cfa->offset += 8;

	/* pop */
P
Peter Zijlstra 已提交
1677
	if (op->src.type == OP_SRC_POP || op->src.type == OP_SRC_POPF)
1678 1679 1680 1681 1682 1683 1684 1685 1686 1687
		cfa->offset -= 8;

	/* add immediate to sp */
	if (op->dest.type == OP_DEST_REG && op->src.type == OP_SRC_ADD &&
	    op->dest.reg == CFI_SP && op->src.reg == CFI_SP)
		cfa->offset -= op->src.offset;

	return 0;
}

1688
static void save_reg(struct cfi_state *cfi, unsigned char reg, int base, int offset)
1689
{
1690
	if (arch_callee_saved_reg(reg) &&
1691 1692 1693
	    cfi->regs[reg].base == CFI_UNDEFINED) {
		cfi->regs[reg].base = base;
		cfi->regs[reg].offset = offset;
1694
	}
1695 1696
}

1697
static void restore_reg(struct cfi_state *cfi, unsigned char reg)
1698
{
1699 1700
	cfi->regs[reg].base = initial_func_cfi.regs[reg].base;
	cfi->regs[reg].offset = initial_func_cfi.regs[reg].offset;
1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755
}

/*
 * A note about DRAP stack alignment:
 *
 * GCC has the concept of a DRAP register, which is used to help keep track of
 * the stack pointer when aligning the stack.  r10 or r13 is used as the DRAP
 * register.  The typical DRAP pattern is:
 *
 *   4c 8d 54 24 08		lea    0x8(%rsp),%r10
 *   48 83 e4 c0		and    $0xffffffffffffffc0,%rsp
 *   41 ff 72 f8		pushq  -0x8(%r10)
 *   55				push   %rbp
 *   48 89 e5			mov    %rsp,%rbp
 *				(more pushes)
 *   41 52			push   %r10
 *				...
 *   41 5a			pop    %r10
 *				(more pops)
 *   5d				pop    %rbp
 *   49 8d 62 f8		lea    -0x8(%r10),%rsp
 *   c3				retq
 *
 * There are some variations in the epilogues, like:
 *
 *   5b				pop    %rbx
 *   41 5a			pop    %r10
 *   41 5c			pop    %r12
 *   41 5d			pop    %r13
 *   41 5e			pop    %r14
 *   c9				leaveq
 *   49 8d 62 f8		lea    -0x8(%r10),%rsp
 *   c3				retq
 *
 * and:
 *
 *   4c 8b 55 e8		mov    -0x18(%rbp),%r10
 *   48 8b 5d e0		mov    -0x20(%rbp),%rbx
 *   4c 8b 65 f0		mov    -0x10(%rbp),%r12
 *   4c 8b 6d f8		mov    -0x8(%rbp),%r13
 *   c9				leaveq
 *   49 8d 62 f8		lea    -0x8(%r10),%rsp
 *   c3				retq
 *
 * Sometimes r13 is used as the DRAP register, in which case it's saved and
 * restored beforehand:
 *
 *   41 55			push   %r13
 *   4c 8d 6c 24 10		lea    0x10(%rsp),%r13
 *   48 83 e4 f0		and    $0xfffffffffffffff0,%rsp
 *				...
 *   49 8d 65 f0		lea    -0x10(%r13),%rsp
 *   41 5d			pop    %r13
 *   c3				retq
 */
1756
static int update_cfi_state(struct instruction *insn, struct cfi_state *cfi,
1757
			     struct stack_op *op)
1758
{
1759 1760
	struct cfi_reg *cfa = &cfi->cfa;
	struct cfi_reg *regs = cfi->regs;
1761 1762 1763 1764 1765 1766 1767 1768 1769 1770

	/* stack operations don't make sense with an undefined CFA */
	if (cfa->base == CFI_UNDEFINED) {
		if (insn->func) {
			WARN_FUNC("undefined stack state", insn->sec, insn->offset);
			return -1;
		}
		return 0;
	}

1771 1772
	if (cfi->type == ORC_TYPE_REGS || cfi->type == ORC_TYPE_REGS_IRET)
		return update_cfi_state_regs(insn, cfi, op);
1773

1774 1775 1776 1777 1778 1779
	switch (op->dest.type) {

	case OP_DEST_REG:
		switch (op->src.type) {

		case OP_SRC_REG:
1780 1781 1782 1783 1784 1785 1786
			if (op->src.reg == CFI_SP && op->dest.reg == CFI_BP &&
			    cfa->base == CFI_SP &&
			    regs[CFI_BP].base == CFI_CFA &&
			    regs[CFI_BP].offset == -cfa->offset) {

				/* mov %rsp, %rbp */
				cfa->base = op->dest.reg;
1787
				cfi->bp_scratch = false;
1788
			}
1789

1790
			else if (op->src.reg == CFI_SP &&
1791
				 op->dest.reg == CFI_BP && cfi->drap) {
1792

1793 1794
				/* drap: mov %rsp, %rbp */
				regs[CFI_BP].base = CFI_BP;
1795 1796
				regs[CFI_BP].offset = -cfi->stack_size;
				cfi->bp_scratch = false;
1797
			}
1798

1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810
			else if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {

				/*
				 * mov %rsp, %reg
				 *
				 * This is needed for the rare case where GCC
				 * does:
				 *
				 *   mov    %rsp, %rax
				 *   ...
				 *   mov    %rax, %rsp
				 */
1811 1812
				cfi->vals[op->dest.reg].base = CFI_CFA;
				cfi->vals[op->dest.reg].offset = -cfi->stack_size;
1813 1814
			}

J
Josh Poimboeuf 已提交
1815 1816 1817 1818 1819 1820 1821 1822
			else if (op->src.reg == CFI_BP && op->dest.reg == CFI_SP &&
				 cfa->base == CFI_BP) {

				/*
				 * mov %rbp, %rsp
				 *
				 * Restore the original stack pointer (Clang).
				 */
1823
				cfi->stack_size = -cfi->regs[CFI_BP].offset;
J
Josh Poimboeuf 已提交
1824 1825
			}

1826 1827 1828 1829
			else if (op->dest.reg == cfa->base) {

				/* mov %reg, %rsp */
				if (cfa->base == CFI_SP &&
1830
				    cfi->vals[op->src.reg].base == CFI_CFA) {
1831 1832 1833 1834 1835 1836 1837 1838 1839

					/*
					 * This is needed for the rare case
					 * where GCC does something dumb like:
					 *
					 *   lea    0x8(%rsp), %rcx
					 *   ...
					 *   mov    %rcx, %rsp
					 */
1840 1841
					cfa->offset = -cfi->vals[op->src.reg].offset;
					cfi->stack_size = cfa->offset;
1842 1843 1844 1845 1846

				} else {
					cfa->base = CFI_UNDEFINED;
					cfa->offset = 0;
				}
1847 1848 1849 1850 1851 1852 1853 1854
			}

			break;

		case OP_SRC_ADD:
			if (op->dest.reg == CFI_SP && op->src.reg == CFI_SP) {

				/* add imm, %rsp */
1855
				cfi->stack_size -= op->src.offset;
1856 1857 1858 1859 1860 1861 1862 1863
				if (cfa->base == CFI_SP)
					cfa->offset -= op->src.offset;
				break;
			}

			if (op->dest.reg == CFI_SP && op->src.reg == CFI_BP) {

				/* lea disp(%rbp), %rsp */
1864
				cfi->stack_size = -(op->src.offset + regs[CFI_BP].offset);
1865 1866 1867
				break;
			}

1868
			if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {
1869 1870

				/* drap: lea disp(%rsp), %drap */
1871
				cfi->drap_reg = op->dest.reg;
1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882

				/*
				 * lea disp(%rsp), %reg
				 *
				 * This is needed for the rare case where GCC
				 * does something dumb like:
				 *
				 *   lea    0x8(%rsp), %rcx
				 *   ...
				 *   mov    %rcx, %rsp
				 */
1883 1884 1885
				cfi->vals[op->dest.reg].base = CFI_CFA;
				cfi->vals[op->dest.reg].offset = \
					-cfi->stack_size + op->src.offset;
1886

1887 1888 1889
				break;
			}

1890 1891
			if (cfi->drap && op->dest.reg == CFI_SP &&
			    op->src.reg == cfi->drap_reg) {
1892 1893 1894

				 /* drap: lea disp(%drap), %rsp */
				cfa->base = CFI_SP;
1895 1896 1897
				cfa->offset = cfi->stack_size = -op->src.offset;
				cfi->drap_reg = CFI_UNDEFINED;
				cfi->drap = false;
1898 1899 1900
				break;
			}

1901
			if (op->dest.reg == cfi->cfa.base) {
1902 1903 1904 1905 1906 1907 1908 1909 1910
				WARN_FUNC("unsupported stack register modification",
					  insn->sec, insn->offset);
				return -1;
			}

			break;

		case OP_SRC_AND:
			if (op->dest.reg != CFI_SP ||
1911 1912
			    (cfi->drap_reg != CFI_UNDEFINED && cfa->base != CFI_SP) ||
			    (cfi->drap_reg == CFI_UNDEFINED && cfa->base != CFI_BP)) {
1913 1914 1915 1916 1917
				WARN_FUNC("unsupported stack pointer realignment",
					  insn->sec, insn->offset);
				return -1;
			}

1918
			if (cfi->drap_reg != CFI_UNDEFINED) {
1919
				/* drap: and imm, %rsp */
1920 1921 1922
				cfa->base = cfi->drap_reg;
				cfa->offset = cfi->stack_size = 0;
				cfi->drap = true;
1923 1924 1925 1926 1927 1928 1929 1930 1931 1932
			}

			/*
			 * Older versions of GCC (4.8ish) realign the stack
			 * without DRAP, with a frame pointer.
			 */

			break;

		case OP_SRC_POP:
P
Peter Zijlstra 已提交
1933
		case OP_SRC_POPF:
1934
			if (!cfi->drap && op->dest.reg == cfa->base) {
1935 1936 1937 1938 1939

				/* pop %rbp */
				cfa->base = CFI_SP;
			}

1940 1941 1942
			if (cfi->drap && cfa->base == CFI_BP_INDIRECT &&
			    op->dest.reg == cfi->drap_reg &&
			    cfi->drap_offset == -cfi->stack_size) {
1943

1944
				/* drap: pop %drap */
1945
				cfa->base = cfi->drap_reg;
1946
				cfa->offset = 0;
1947
				cfi->drap_offset = -1;
1948

1949
			} else if (regs[op->dest.reg].offset == -cfi->stack_size) {
1950

1951
				/* pop %reg */
1952
				restore_reg(cfi, op->dest.reg);
1953 1954
			}

1955
			cfi->stack_size -= 8;
1956 1957 1958 1959 1960 1961
			if (cfa->base == CFI_SP)
				cfa->offset -= 8;

			break;

		case OP_SRC_REG_INDIRECT:
1962 1963
			if (cfi->drap && op->src.reg == CFI_BP &&
			    op->src.offset == cfi->drap_offset) {
1964 1965

				/* drap: mov disp(%rbp), %drap */
1966
				cfa->base = cfi->drap_reg;
1967
				cfa->offset = 0;
1968
				cfi->drap_offset = -1;
1969 1970
			}

1971
			if (cfi->drap && op->src.reg == CFI_BP &&
1972 1973 1974
			    op->src.offset == regs[op->dest.reg].offset) {

				/* drap: mov disp(%rbp), %reg */
1975
				restore_reg(cfi, op->dest.reg);
1976 1977 1978 1979 1980 1981

			} else if (op->src.reg == cfa->base &&
			    op->src.offset == regs[op->dest.reg].offset + cfa->offset) {

				/* mov disp(%rbp), %reg */
				/* mov disp(%rsp), %reg */
1982
				restore_reg(cfi, op->dest.reg);
1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995
			}

			break;

		default:
			WARN_FUNC("unknown stack-related instruction",
				  insn->sec, insn->offset);
			return -1;
		}

		break;

	case OP_DEST_PUSH:
P
Peter Zijlstra 已提交
1996
	case OP_DEST_PUSHF:
1997
		cfi->stack_size += 8;
1998 1999 2000 2001 2002 2003
		if (cfa->base == CFI_SP)
			cfa->offset += 8;

		if (op->src.type != OP_SRC_REG)
			break;

2004 2005
		if (cfi->drap) {
			if (op->src.reg == cfa->base && op->src.reg == cfi->drap_reg) {
2006 2007 2008

				/* drap: push %drap */
				cfa->base = CFI_BP_INDIRECT;
2009
				cfa->offset = -cfi->stack_size;
2010

2011
				/* save drap so we know when to restore it */
2012
				cfi->drap_offset = -cfi->stack_size;
2013

2014
			} else if (op->src.reg == CFI_BP && cfa->base == cfi->drap_reg) {
2015 2016

				/* drap: push %rbp */
2017
				cfi->stack_size = 0;
2018 2019 2020 2021

			} else if (regs[op->src.reg].base == CFI_UNDEFINED) {

				/* drap: push %reg */
2022
				save_reg(cfi, op->src.reg, CFI_BP, -cfi->stack_size);
2023 2024 2025 2026 2027
			}

		} else {

			/* push %reg */
2028
			save_reg(cfi, op->src.reg, CFI_CFA, -cfi->stack_size);
2029 2030 2031
		}

		/* detect when asm code uses rbp as a scratch register */
2032
		if (!no_fp && insn->func && op->src.reg == CFI_BP &&
2033
		    cfa->base != CFI_BP)
2034
			cfi->bp_scratch = true;
2035 2036 2037 2038
		break;

	case OP_DEST_REG_INDIRECT:

2039 2040
		if (cfi->drap) {
			if (op->src.reg == cfa->base && op->src.reg == cfi->drap_reg) {
2041 2042 2043 2044 2045

				/* drap: mov %drap, disp(%rbp) */
				cfa->base = CFI_BP_INDIRECT;
				cfa->offset = op->dest.offset;

2046
				/* save drap offset so we know when to restore it */
2047
				cfi->drap_offset = op->dest.offset;
2048 2049 2050 2051 2052
			}

			else if (regs[op->src.reg].base == CFI_UNDEFINED) {

				/* drap: mov reg, disp(%rbp) */
2053
				save_reg(cfi, op->src.reg, CFI_BP, op->dest.offset);
2054 2055 2056 2057 2058 2059
			}

		} else if (op->dest.reg == cfa->base) {

			/* mov reg, disp(%rbp) */
			/* mov reg, disp(%rsp) */
2060 2061
			save_reg(cfi, op->src.reg, CFI_CFA,
				 op->dest.offset - cfi->cfa.offset);
2062 2063 2064 2065 2066
		}

		break;

	case OP_DEST_LEAVE:
2067 2068
		if ((!cfi->drap && cfa->base != CFI_BP) ||
		    (cfi->drap && cfa->base != cfi->drap_reg)) {
2069 2070 2071 2072 2073 2074 2075
			WARN_FUNC("leave instruction with modified stack frame",
				  insn->sec, insn->offset);
			return -1;
		}

		/* leave (mov %rbp, %rsp; pop %rbp) */

2076 2077
		cfi->stack_size = -cfi->regs[CFI_BP].offset - 8;
		restore_reg(cfi, CFI_BP);
2078

2079
		if (!cfi->drap) {
2080 2081 2082 2083 2084 2085 2086
			cfa->base = CFI_SP;
			cfa->offset -= 8;
		}

		break;

	case OP_DEST_MEM:
P
Peter Zijlstra 已提交
2087
		if (op->src.type != OP_SRC_POP && op->src.type != OP_SRC_POPF) {
2088 2089 2090 2091 2092 2093
			WARN_FUNC("unknown stack-related memory operation",
				  insn->sec, insn->offset);
			return -1;
		}

		/* pop mem */
2094
		cfi->stack_size -= 8;
2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108
		if (cfa->base == CFI_SP)
			cfa->offset -= 8;

		break;

	default:
		WARN_FUNC("unknown stack-related instruction",
			  insn->sec, insn->offset);
		return -1;
	}

	return 0;
}

2109 2110 2111 2112 2113
static int handle_insn_ops(struct instruction *insn, struct insn_state *state)
{
	struct stack_op *op;

	list_for_each_entry(op, &insn->stack_ops, list) {
2114
		struct cfi_state old_cfi = state->cfi;
2115 2116
		int res;

2117
		res = update_cfi_state(insn, &state->cfi, op);
2118 2119 2120
		if (res)
			return res;

2121 2122 2123 2124 2125
		if (insn->alt_group && memcmp(&state->cfi, &old_cfi, sizeof(struct cfi_state))) {
			WARN_FUNC("alternative modifies stack", insn->sec, insn->offset);
			return -1;
		}

2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150
		if (op->dest.type == OP_DEST_PUSHF) {
			if (!state->uaccess_stack) {
				state->uaccess_stack = 1;
			} else if (state->uaccess_stack >> 31) {
				WARN_FUNC("PUSHF stack exhausted",
					  insn->sec, insn->offset);
				return 1;
			}
			state->uaccess_stack <<= 1;
			state->uaccess_stack  |= state->uaccess;
		}

		if (op->src.type == OP_SRC_POPF) {
			if (state->uaccess_stack) {
				state->uaccess = state->uaccess_stack & 1;
				state->uaccess_stack >>= 1;
				if (state->uaccess_stack == 1)
					state->uaccess_stack = 0;
			}
		}
	}

	return 0;
}

2151
static bool insn_cfi_match(struct instruction *insn, struct cfi_state *cfi2)
2152
{
2153
	struct cfi_state *cfi1 = &insn->cfi;
2154 2155
	int i;

2156 2157
	if (memcmp(&cfi1->cfa, &cfi2->cfa, sizeof(cfi1->cfa))) {

2158 2159
		WARN_FUNC("stack state mismatch: cfa1=%d%+d cfa2=%d%+d",
			  insn->sec, insn->offset,
2160 2161
			  cfi1->cfa.base, cfi1->cfa.offset,
			  cfi2->cfa.base, cfi2->cfa.offset);
2162

2163
	} else if (memcmp(&cfi1->regs, &cfi2->regs, sizeof(cfi1->regs))) {
2164
		for (i = 0; i < CFI_NUM_REGS; i++) {
2165
			if (!memcmp(&cfi1->regs[i], &cfi2->regs[i],
2166 2167 2168 2169 2170
				    sizeof(struct cfi_reg)))
				continue;

			WARN_FUNC("stack state mismatch: reg1[%d]=%d%+d reg2[%d]=%d%+d",
				  insn->sec, insn->offset,
2171 2172
				  i, cfi1->regs[i].base, cfi1->regs[i].offset,
				  i, cfi2->regs[i].base, cfi2->regs[i].offset);
2173 2174 2175
			break;
		}

2176 2177
	} else if (cfi1->type != cfi2->type) {

2178
		WARN_FUNC("stack state mismatch: type1=%d type2=%d",
2179 2180 2181 2182 2183
			  insn->sec, insn->offset, cfi1->type, cfi2->type);

	} else if (cfi1->drap != cfi2->drap ||
		   (cfi1->drap && cfi1->drap_reg != cfi2->drap_reg) ||
		   (cfi1->drap && cfi1->drap_offset != cfi2->drap_offset)) {
2184

2185
		WARN_FUNC("stack state mismatch: drap1=%d(%d,%d) drap2=%d(%d,%d)",
2186
			  insn->sec, insn->offset,
2187 2188
			  cfi1->drap, cfi1->drap_reg, cfi1->drap_offset,
			  cfi2->drap, cfi2->drap_reg, cfi2->drap_offset);
2189 2190 2191 2192 2193

	} else
		return true;

	return false;
2194 2195
}

P
Peter Zijlstra 已提交
2196 2197 2198
static inline bool func_uaccess_safe(struct symbol *func)
{
	if (func)
2199
		return func->uaccess_safe;
P
Peter Zijlstra 已提交
2200 2201 2202 2203

	return false;
}

2204
static inline const char *call_dest_name(struct instruction *insn)
P
Peter Zijlstra 已提交
2205 2206 2207 2208 2209 2210 2211
{
	if (insn->call_dest)
		return insn->call_dest->name;

	return "{dynamic}";
}

2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237
static inline bool noinstr_call_dest(struct symbol *func)
{
	/*
	 * We can't deal with indirect function calls at present;
	 * assume they're instrumented.
	 */
	if (!func)
		return false;

	/*
	 * If the symbol is from a noinstr section; we good.
	 */
	if (func->sec->noinstr)
		return true;

	/*
	 * The __ubsan_handle_*() calls are like WARN(), they only happen when
	 * something 'BAD' happened. At the risk of taking the machine down,
	 * let them proceed to get the message out.
	 */
	if (!strncmp(func->name, "__ubsan_handle_", 15))
		return true;

	return false;
}

P
Peter Zijlstra 已提交
2238 2239
static int validate_call(struct instruction *insn, struct insn_state *state)
{
2240
	if (state->noinstr && state->instr <= 0 &&
2241
	    !noinstr_call_dest(insn->call_dest)) {
2242 2243 2244 2245 2246
		WARN_FUNC("call to %s() leaves .noinstr.text section",
				insn->sec, insn->offset, call_dest_name(insn));
		return 1;
	}

P
Peter Zijlstra 已提交
2247 2248
	if (state->uaccess && !func_uaccess_safe(insn->call_dest)) {
		WARN_FUNC("call to %s() with UACCESS enabled",
2249
				insn->sec, insn->offset, call_dest_name(insn));
P
Peter Zijlstra 已提交
2250 2251 2252
		return 1;
	}

2253 2254
	if (state->df) {
		WARN_FUNC("call to %s() with DF set",
2255
				insn->sec, insn->offset, call_dest_name(insn));
2256 2257 2258
		return 1;
	}

P
Peter Zijlstra 已提交
2259 2260 2261
	return 0;
}

2262 2263
static int validate_sibling_call(struct instruction *insn, struct insn_state *state)
{
2264
	if (has_modified_stack_frame(insn, state)) {
2265 2266 2267 2268 2269
		WARN_FUNC("sibling call from callable instruction with modified stack frame",
				insn->sec, insn->offset);
		return 1;
	}

P
Peter Zijlstra 已提交
2270
	return validate_call(insn, state);
2271 2272
}

2273 2274
static int validate_return(struct symbol *func, struct instruction *insn, struct insn_state *state)
{
2275 2276 2277 2278 2279 2280
	if (state->noinstr && state->instr > 0) {
		WARN_FUNC("return with instrumentation enabled",
			  insn->sec, insn->offset);
		return 1;
	}

2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298
	if (state->uaccess && !func_uaccess_safe(func)) {
		WARN_FUNC("return with UACCESS enabled",
			  insn->sec, insn->offset);
		return 1;
	}

	if (!state->uaccess && func_uaccess_safe(func)) {
		WARN_FUNC("return with UACCESS disabled from a UACCESS-safe function",
			  insn->sec, insn->offset);
		return 1;
	}

	if (state->df) {
		WARN_FUNC("return with DF set",
			  insn->sec, insn->offset);
		return 1;
	}

2299
	if (func && has_modified_stack_frame(insn, state)) {
2300 2301 2302 2303 2304
		WARN_FUNC("return with modified stack frame",
			  insn->sec, insn->offset);
		return 1;
	}

2305
	if (state->cfi.bp_scratch) {
2306 2307
		WARN_FUNC("BP used as a scratch register",
			  insn->sec, insn->offset);
2308 2309 2310 2311 2312 2313
		return 1;
	}

	return 0;
}

2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337
/*
 * Alternatives should not contain any ORC entries, this in turn means they
 * should not contain any CFI ops, which implies all instructions should have
 * the same same CFI state.
 *
 * It is possible to constuct alternatives that have unreachable holes that go
 * unreported (because they're NOPs), such holes would result in CFI_UNDEFINED
 * states which then results in ORC entries, which we just said we didn't want.
 *
 * Avoid them by copying the CFI entry of the first instruction into the whole
 * alternative.
 */
static void fill_alternative_cfi(struct objtool_file *file, struct instruction *insn)
{
	struct instruction *first_insn = insn;
	int alt_group = insn->alt_group;

	sec_for_each_insn_continue(file, insn) {
		if (insn->alt_group != alt_group)
			break;
		insn->cfi = first_insn->cfi;
	}
}

2338 2339 2340 2341 2342 2343
/*
 * Follow the branch starting at the given instruction, and recursively follow
 * any other branches (jumps).  Meanwhile, track the frame pointer state at
 * each instruction and validate all the rules described in
 * tools/objtool/Documentation/stack-validation.txt.
 */
2344
static int validate_branch(struct objtool_file *file, struct symbol *func,
P
Peter Zijlstra 已提交
2345
			   struct instruction *insn, struct insn_state state)
2346 2347
{
	struct alternative *alt;
P
Peter Zijlstra 已提交
2348
	struct instruction *next_insn;
2349
	struct section *sec;
2350
	u8 visited;
2351 2352 2353 2354 2355
	int ret;

	sec = insn->sec;

	while (1) {
2356 2357
		next_insn = next_insn_same_sec(file, insn);

2358
		if (file->c_file && func && insn->func && func != insn->func->pfunc) {
2359 2360 2361
			WARN("%s() falls through to next function %s()",
			     func->name, insn->func->name);
			return 1;
2362 2363
		}

2364 2365 2366
		if (func && insn->ignore) {
			WARN_FUNC("BUG: why am I validating an ignored function?",
				  sec, insn->offset);
2367
			return 1;
2368 2369
		}

2370
		visited = 1 << state.uaccess;
2371
		if (insn->visited) {
2372
			if (!insn->hint && !insn_cfi_match(insn, &state.cfi))
2373 2374
				return 1;

2375
			if (insn->visited & visited)
P
Peter Zijlstra 已提交
2376
				return 0;
2377 2378
		}

2379 2380 2381
		if (state.noinstr)
			state.instr += insn->instr;

2382
		if (insn->hint)
2383
			state.cfi = insn->cfi;
2384
		else
2385
			insn->cfi = state.cfi;
2386

2387
		insn->visited |= visited;
2388

2389
		if (!insn->ignore_alts && !list_empty(&insn->alts)) {
P
Peter Zijlstra 已提交
2390 2391
			bool skip_orig = false;

2392
			list_for_each_entry(alt, &insn->alts, list) {
P
Peter Zijlstra 已提交
2393 2394 2395
				if (alt->skip_orig)
					skip_orig = true;

2396
				ret = validate_branch(file, func, alt->insn, state);
2397 2398 2399 2400 2401
				if (ret) {
					if (backtrace)
						BT_FUNC("(alt)", insn);
					return ret;
				}
2402
			}
P
Peter Zijlstra 已提交
2403

2404 2405 2406
			if (insn->alt_group)
				fill_alternative_cfi(file, insn);

P
Peter Zijlstra 已提交
2407 2408
			if (skip_orig)
				return 0;
2409 2410
		}

2411 2412 2413
		if (handle_insn_ops(insn, &state))
			return 1;

2414 2415 2416
		switch (insn->type) {

		case INSN_RETURN:
2417
			return validate_return(func, insn, &state);
2418 2419

		case INSN_CALL:
P
Peter Zijlstra 已提交
2420 2421 2422 2423
		case INSN_CALL_DYNAMIC:
			ret = validate_call(insn, &state);
			if (ret)
				return ret;
2424

2425 2426
			if (!no_fp && func && !is_fentry_call(insn) &&
			    !has_valid_stack_frame(&state)) {
2427 2428 2429 2430
				WARN_FUNC("call without frame pointer save/setup",
					  sec, insn->offset);
				return 1;
			}
2431 2432 2433 2434

			if (dead_end_function(file, insn->call_dest))
				return 0;

2435 2436 2437 2438
			break;

		case INSN_JUMP_CONDITIONAL:
		case INSN_JUMP_UNCONDITIONAL:
2439
			if (func && is_sibling_call(insn)) {
2440
				ret = validate_sibling_call(insn, &state);
2441
				if (ret)
2442
					return ret;
2443

2444
			} else if (insn->jump_dest) {
2445 2446
				ret = validate_branch(file, func,
						      insn->jump_dest, state);
2447 2448 2449 2450 2451
				if (ret) {
					if (backtrace)
						BT_FUNC("(branch)", insn);
					return ret;
				}
2452
			}
2453 2454 2455 2456 2457 2458 2459

			if (insn->type == INSN_JUMP_UNCONDITIONAL)
				return 0;

			break;

		case INSN_JUMP_DYNAMIC:
2460
		case INSN_JUMP_DYNAMIC_CONDITIONAL:
2461
			if (func && is_sibling_call(insn)) {
2462 2463 2464
				ret = validate_sibling_call(insn, &state);
				if (ret)
					return ret;
2465 2466
			}

2467 2468 2469 2470
			if (insn->type == INSN_JUMP_DYNAMIC)
				return 0;

			break;
2471

2472 2473 2474 2475 2476 2477 2478 2479
		case INSN_CONTEXT_SWITCH:
			if (func && (!next_insn || !next_insn->hint)) {
				WARN_FUNC("unsupported instruction in callable function",
					  sec, insn->offset);
				return 1;
			}
			return 0;

P
Peter Zijlstra 已提交
2480 2481 2482 2483 2484 2485 2486 2487 2488 2489
		case INSN_STAC:
			if (state.uaccess) {
				WARN_FUNC("recursive UACCESS enable", sec, insn->offset);
				return 1;
			}

			state.uaccess = true;
			break;

		case INSN_CLAC:
2490
			if (!state.uaccess && func) {
P
Peter Zijlstra 已提交
2491 2492 2493 2494 2495 2496 2497 2498 2499 2500
				WARN_FUNC("redundant UACCESS disable", sec, insn->offset);
				return 1;
			}

			if (func_uaccess_safe(func) && !state.uaccess_stack) {
				WARN_FUNC("UACCESS-safe disables UACCESS", sec, insn->offset);
				return 1;
			}

			state.uaccess = false;
2501 2502
			break;

2503 2504 2505 2506 2507 2508 2509 2510
		case INSN_STD:
			if (state.df)
				WARN_FUNC("recursive STD", sec, insn->offset);

			state.df = true;
			break;

		case INSN_CLD:
2511
			if (!state.df && func)
2512 2513 2514
				WARN_FUNC("redundant CLD", sec, insn->offset);

			state.df = false;
2515 2516
			break;

2517 2518 2519 2520 2521 2522 2523
		default:
			break;
		}

		if (insn->dead_end)
			return 0;

2524
		if (!next_insn) {
2525
			if (state.cfi.cfa.base == CFI_UNDEFINED)
2526
				return 0;
2527 2528 2529
			WARN("%s: unexpected end of section", sec->name);
			return 1;
		}
2530 2531

		insn = next_insn;
2532 2533 2534 2535 2536
	}

	return 0;
}

2537
static int validate_unwind_hints(struct objtool_file *file, struct section *sec)
2538 2539 2540
{
	struct instruction *insn;
	struct insn_state state;
2541
	int ret, warnings = 0;
2542 2543 2544 2545

	if (!file->hints)
		return 0;

2546
	init_insn_state(&state, sec);
2547

2548 2549 2550 2551 2552 2553 2554 2555 2556
	if (sec) {
		insn = find_insn(file, sec, 0);
		if (!insn)
			return 0;
	} else {
		insn = list_first_entry(&file->insn_list, typeof(*insn), list);
	}

	while (&insn->list != &file->insn_list && (!sec || insn->sec == sec)) {
2557
		if (insn->hint && !insn->visited) {
2558
			ret = validate_branch(file, insn->func, insn, state);
2559 2560
			if (ret && backtrace)
				BT_FUNC("<=== (hint)", insn);
2561 2562
			warnings += ret;
		}
2563 2564

		insn = list_next_entry(insn, list);
2565 2566 2567 2568 2569
	}

	return warnings;
}

2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582
static int validate_retpoline(struct objtool_file *file)
{
	struct instruction *insn;
	int warnings = 0;

	for_each_insn(file, insn) {
		if (insn->type != INSN_JUMP_DYNAMIC &&
		    insn->type != INSN_CALL_DYNAMIC)
			continue;

		if (insn->retpoline_safe)
			continue;

2583 2584 2585 2586 2587 2588 2589 2590 2591
		/*
		 * .init.text code is ran before userspace and thus doesn't
		 * strictly need retpolines, except for modules which are
		 * loaded late, they very much do need retpoline in their
		 * .init.text
		 */
		if (!strcmp(insn->sec->name, ".init.text") && !module)
			continue;

2592 2593 2594 2595 2596 2597 2598 2599 2600 2601
		WARN_FUNC("indirect %s found in RETPOLINE build",
			  insn->sec, insn->offset,
			  insn->type == INSN_JUMP_DYNAMIC ? "jump" : "call");

		warnings++;
	}

	return warnings;
}

2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614
static bool is_kasan_insn(struct instruction *insn)
{
	return (insn->type == INSN_CALL &&
		!strcmp(insn->call_dest->name, "__asan_handle_no_return"));
}

static bool is_ubsan_insn(struct instruction *insn)
{
	return (insn->type == INSN_CALL &&
		!strcmp(insn->call_dest->name,
			"__ubsan_handle_builtin_unreachable"));
}

2615
static bool ignore_unreachable_insn(struct instruction *insn)
2616 2617 2618
{
	int i;

2619 2620 2621 2622 2623 2624
	if (insn->ignore || insn->type == INSN_NOP)
		return true;

	/*
	 * Ignore any unused exceptions.  This can happen when a whitelisted
	 * function has an exception table entry.
2625 2626 2627
	 *
	 * Also ignore alternative replacement instructions.  This can happen
	 * when a whitelisted function uses one of the ALTERNATIVE macros.
2628
	 */
2629 2630 2631
	if (!strcmp(insn->sec->name, ".fixup") ||
	    !strcmp(insn->sec->name, ".altinstr_replacement") ||
	    !strcmp(insn->sec->name, ".altinstr_aux"))
2632 2633
		return true;

2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648
	if (!insn->func)
		return false;

	/*
	 * CONFIG_UBSAN_TRAP inserts a UD2 when it sees
	 * __builtin_unreachable().  The BUG() macro has an unreachable() after
	 * the UD2, which causes GCC's undefined trap logic to emit another UD2
	 * (or occasionally a JMP to UD2).
	 */
	if (list_prev_entry(insn, list)->dead_end &&
	    (insn->type == INSN_BUG ||
	     (insn->type == INSN_JUMP_UNCONDITIONAL &&
	      insn->jump_dest && insn->jump_dest->type == INSN_BUG)))
		return true;

2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659
	/*
	 * Check if this (or a subsequent) instruction is related to
	 * CONFIG_UBSAN or CONFIG_KASAN.
	 *
	 * End the search at 5 instructions to avoid going into the weeds.
	 */
	for (i = 0; i < 5; i++) {

		if (is_kasan_insn(insn) || is_ubsan_insn(insn))
			return true;

2660 2661 2662 2663 2664 2665 2666 2667
		if (insn->type == INSN_JUMP_UNCONDITIONAL) {
			if (insn->jump_dest &&
			    insn->jump_dest->func == insn->func) {
				insn = insn->jump_dest;
				continue;
			}

			break;
2668 2669
		}

2670
		if (insn->offset + insn->len >= insn->func->offset + insn->func->len)
2671
			break;
2672

2673 2674 2675 2676 2677 2678
		insn = list_next_entry(insn, list);
	}

	return false;
}

2679 2680
static int validate_symbol(struct objtool_file *file, struct section *sec,
			   struct symbol *sym, struct insn_state *state)
2681 2682
{
	struct instruction *insn;
2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706
	int ret;

	if (!sym->len) {
		WARN("%s() is missing an ELF size annotation", sym->name);
		return 1;
	}

	if (sym->pfunc != sym || sym->alias != sym)
		return 0;

	insn = find_insn(file, sec, sym->offset);
	if (!insn || insn->ignore || insn->visited)
		return 0;

	state->uaccess = sym->uaccess_safe;

	ret = validate_branch(file, insn->func, insn, *state);
	if (ret && backtrace)
		BT_FUNC("<=== (sym)", insn);
	return ret;
}

static int validate_section(struct objtool_file *file, struct section *sec)
{
2707
	struct insn_state state;
2708 2709
	struct symbol *func;
	int warnings = 0;
2710

2711 2712 2713
	list_for_each_entry(func, &sec->symbol_list, list) {
		if (func->type != STT_FUNC)
			continue;
2714

2715
		init_insn_state(&state, sec);
2716 2717
		state.cfi.cfa = initial_func_cfi.cfa;
		memcpy(&state.cfi.regs, &initial_func_cfi.regs,
2718
		       CFI_NUM_REGS * sizeof(struct cfi_reg));
2719
		state.cfi.stack_size = initial_func_cfi.cfa.offset;
2720

2721
		warnings += validate_symbol(file, sec, func, &state);
2722 2723 2724 2725 2726
	}

	return warnings;
}

2727 2728 2729
static int validate_vmlinux_functions(struct objtool_file *file)
{
	struct section *sec;
2730
	int warnings = 0;
2731 2732

	sec = find_section_by_name(file->elf, ".noinstr.text");
2733 2734 2735 2736
	if (sec) {
		warnings += validate_section(file, sec);
		warnings += validate_unwind_hints(file, sec);
	}
2737

2738 2739 2740 2741 2742
	sec = find_section_by_name(file->elf, ".entry.text");
	if (sec) {
		warnings += validate_section(file, sec);
		warnings += validate_unwind_hints(file, sec);
	}
2743 2744

	return warnings;
2745 2746
}

2747 2748 2749 2750 2751
static int validate_functions(struct objtool_file *file)
{
	struct section *sec;
	int warnings = 0;

2752 2753 2754 2755
	for_each_sec(file, sec) {
		if (!(sec->sh.sh_flags & SHF_EXECINSTR))
			continue;

2756
		warnings += validate_section(file, sec);
2757
	}
2758 2759 2760 2761

	return warnings;
}

2762
static int validate_reachable_instructions(struct objtool_file *file)
2763 2764
{
	struct instruction *insn;
2765 2766 2767

	if (file->ignore_unreachables)
		return 0;
2768 2769

	for_each_insn(file, insn) {
2770 2771 2772 2773 2774
		if (insn->visited || ignore_unreachable_insn(insn))
			continue;

		WARN_FUNC("unreachable instruction", insn->sec, insn->offset);
		return 1;
2775 2776
	}

2777
	return 0;
2778 2779
}

2780 2781
static struct objtool_file file;

2782
int check(const char *_objname, bool orc)
2783 2784 2785 2786 2787
{
	int ret, warnings = 0;

	objname = _objname;

2788
	file.elf = elf_open_read(objname, O_RDWR);
2789
	if (!file.elf)
2790 2791 2792 2793
		return 1;

	INIT_LIST_HEAD(&file.insn_list);
	hash_init(file.insn_hash);
2794
	file.c_file = !vmlinux && find_section_by_name(file.elf, ".comment");
2795
	file.ignore_unreachables = no_unreachable;
2796
	file.hints = false;
2797

2798 2799
	arch_initial_func_cfi_state(&initial_func_cfi);

2800 2801 2802 2803 2804
	ret = decode_sections(&file);
	if (ret < 0)
		goto out;
	warnings += ret;

2805
	if (list_empty(&file.insn_list))
2806 2807
		goto out;

2808 2809 2810 2811 2812 2813 2814 2815 2816
	if (vmlinux && !validate_dup) {
		ret = validate_vmlinux_functions(&file);
		if (ret < 0)
			goto out;

		warnings += ret;
		goto out;
	}

2817 2818 2819 2820 2821 2822 2823
	if (retpoline) {
		ret = validate_retpoline(&file);
		if (ret < 0)
			return ret;
		warnings += ret;
	}

2824
	ret = validate_functions(&file);
2825 2826 2827 2828
	if (ret < 0)
		goto out;
	warnings += ret;

2829
	ret = validate_unwind_hints(&file, NULL);
2830 2831 2832 2833
	if (ret < 0)
		goto out;
	warnings += ret;

2834 2835 2836 2837 2838 2839 2840
	if (!warnings) {
		ret = validate_reachable_instructions(&file);
		if (ret < 0)
			goto out;
		warnings += ret;
	}

2841 2842 2843 2844 2845 2846 2847 2848
	if (orc) {
		ret = create_orc(&file);
		if (ret < 0)
			goto out;

		ret = create_orc_sections(&file);
		if (ret < 0)
			goto out;
2849
	}
2850

2851
	if (file.elf->changed) {
2852 2853 2854 2855 2856
		ret = elf_write(file.elf);
		if (ret < 0)
			goto out;
	}

2857
out:
2858 2859 2860 2861 2862 2863 2864 2865 2866
	if (ret < 0) {
		/*
		 *  Fatal error.  The binary is corrupt or otherwise broken in
		 *  some way, or objtool itself is broken.  Fail the kernel
		 *  build.
		 */
		return ret;
	}

2867 2868
	return 0;
}