check.c 66.7 KB
Newer Older
1
// SPDX-License-Identifier: GPL-2.0-or-later
2 3 4 5 6 7 8
/*
 * Copyright (C) 2015-2017 Josh Poimboeuf <jpoimboe@redhat.com>
 */

#include <string.h>
#include <stdlib.h>

9
#include "builtin.h"
10 11
#include "cfi.h"
#include "arch.h"
12 13 14 15 16 17 18
#include "check.h"
#include "special.h"
#include "warn.h"

#include <linux/hashtable.h>
#include <linux/kernel.h>

19 20
#define FAKE_JUMP_OFFSET -1

21 22
#define C_JUMP_TABLE_SECTION ".rodata..c_jump_table"

23 24 25
struct alternative {
	struct list_head list;
	struct instruction *insn;
P
Peter Zijlstra 已提交
26
	bool skip_orig;
27 28 29
};

const char *objname;
30
struct cfi_init_state initial_func_cfi;
31

32 33
struct instruction *find_insn(struct objtool_file *file,
			      struct section *sec, unsigned long offset)
34 35 36
{
	struct instruction *insn;

37
	hash_for_each_possible(file->insn_hash, insn, hash, sec_offset_hash(sec, offset)) {
38 39
		if (insn->sec == sec && insn->offset == offset)
			return insn;
40
	}
41 42 43 44 45 46 47 48 49

	return NULL;
}

static struct instruction *next_insn_same_sec(struct objtool_file *file,
					      struct instruction *insn)
{
	struct instruction *next = list_next_entry(insn, list);

50
	if (!next || &next->list == &file->insn_list || next->sec != insn->sec)
51 52 53 54 55
		return NULL;

	return next;
}

56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75
static struct instruction *next_insn_same_func(struct objtool_file *file,
					       struct instruction *insn)
{
	struct instruction *next = list_next_entry(insn, list);
	struct symbol *func = insn->func;

	if (!func)
		return NULL;

	if (&next->list != &file->insn_list && next->func == func)
		return next;

	/* Check if we're already in the subfunction: */
	if (func == func->cfunc)
		return NULL;

	/* Move to the subfunction: */
	return find_insn(file, func->cfunc->sec, func->cfunc->offset);
}

76 77 78 79 80 81 82 83 84 85 86
static struct instruction *prev_insn_same_sym(struct objtool_file *file,
					       struct instruction *insn)
{
	struct instruction *prev = list_prev_entry(insn, list);

	if (&prev->list != &file->insn_list && prev->func == insn->func)
		return prev;

	return NULL;
}

87
#define func_for_each_insn(file, func, insn)				\
88 89 90 91
	for (insn = find_insn(file, func->sec, func->offset);		\
	     insn;							\
	     insn = next_insn_same_func(file, insn))

92 93
#define sym_for_each_insn(file, sym, insn)				\
	for (insn = find_insn(file, sym->sec, sym->offset);		\
94
	     insn && &insn->list != &file->insn_list &&			\
95 96
		insn->sec == sym->sec &&				\
		insn->offset < sym->offset + sym->len;			\
97 98
	     insn = list_next_entry(insn, list))

99
#define sym_for_each_insn_continue_reverse(file, sym, insn)		\
100 101
	for (insn = list_prev_entry(insn, list);			\
	     &insn->list != &file->insn_list &&				\
102
		insn->sec == sym->sec && insn->offset >= sym->offset;	\
103 104 105 106 107
	     insn = list_prev_entry(insn, list))

#define sec_for_each_insn_from(file, insn)				\
	for (; insn; insn = next_insn_same_sec(file, insn))

108 109 110
#define sec_for_each_insn_continue(file, insn)				\
	for (insn = next_insn_same_sec(file, insn); insn;		\
	     insn = next_insn_same_sec(file, insn))
111

112 113 114 115 116 117
static bool is_static_jump(struct instruction *insn)
{
	return insn->type == INSN_JUMP_CONDITIONAL ||
	       insn->type == INSN_JUMP_UNCONDITIONAL;
}

118 119 120 121 122 123
static bool is_sibling_call(struct instruction *insn)
{
	/* An indirect jump is either a sibling call or a jump to a table. */
	if (insn->type == INSN_JUMP_DYNAMIC)
		return list_empty(&insn->alts);

124
	if (!is_static_jump(insn))
125 126 127 128 129 130
		return false;

	/* add_jump_destinations() sets insn->call_dest for sibling calls. */
	return !!insn->call_dest;
}

131 132 133 134 135 136 137 138 139
/*
 * This checks to see if the given function is a "noreturn" function.
 *
 * For global functions which are outside the scope of this object file, we
 * have to keep a manual list of them.
 *
 * For local functions, we have to detect them manually by simply looking for
 * the lack of a return instruction.
 */
140 141
static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
				int recursion)
142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160
{
	int i;
	struct instruction *insn;
	bool empty = true;

	/*
	 * Unfortunately these have to be hard coded because the noreturn
	 * attribute isn't provided in ELF data.
	 */
	static const char * const global_noreturns[] = {
		"__stack_chk_fail",
		"panic",
		"do_exit",
		"do_task_dead",
		"__module_put_and_exit",
		"complete_and_exit",
		"__reiserfs_panic",
		"lbug_with_loc",
		"fortify_panic",
161
		"usercopy_abort",
162
		"machine_real_restart",
163
		"rewind_stack_do_exit",
164
		"kunit_try_catch_throw",
165 166
	};

167 168 169
	if (!func)
		return false;

170
	if (func->bind == STB_WEAK)
171
		return false;
172 173 174 175

	if (func->bind == STB_GLOBAL)
		for (i = 0; i < ARRAY_SIZE(global_noreturns); i++)
			if (!strcmp(func->name, global_noreturns[i]))
176
				return true;
177

178
	if (!func->len)
179
		return false;
180

181 182
	insn = find_insn(file, func->sec, func->offset);
	if (!insn->func)
183
		return false;
184

185
	func_for_each_insn(file, func, insn) {
186 187 188
		empty = false;

		if (insn->type == INSN_RETURN)
189
			return false;
190 191 192
	}

	if (empty)
193
		return false;
194 195 196 197 198 199

	/*
	 * A function can have a sibling call instead of a return.  In that
	 * case, the function's dead-end status depends on whether the target
	 * of the sibling call returns.
	 */
200
	func_for_each_insn(file, func, insn) {
201
		if (is_sibling_call(insn)) {
202 203 204 205
			struct instruction *dest = insn->jump_dest;

			if (!dest)
				/* sibling call to another file */
206
				return false;
207

208 209 210 211 212 213 214 215
			/* local sibling call */
			if (recursion == 5) {
				/*
				 * Infinite recursion: two functions have
				 * sibling calls to each other.  This is a very
				 * rare case.  It means they aren't dead ends.
				 */
				return false;
216 217
			}

218 219
			return __dead_end_function(file, dest->func, recursion+1);
		}
220 221
	}

222
	return true;
223 224
}

225
static bool dead_end_function(struct objtool_file *file, struct symbol *func)
226 227 228 229
{
	return __dead_end_function(file, func, 0);
}

230
static void init_cfi_state(struct cfi_state *cfi)
231 232 233
{
	int i;

234
	for (i = 0; i < CFI_NUM_REGS; i++) {
235 236
		cfi->regs[i].base = CFI_UNDEFINED;
		cfi->vals[i].base = CFI_UNDEFINED;
237
	}
238 239 240 241 242
	cfi->cfa.base = CFI_UNDEFINED;
	cfi->drap_reg = CFI_UNDEFINED;
	cfi->drap_offset = -1;
}

243
static void init_insn_state(struct insn_state *state, struct section *sec)
244 245 246
{
	memset(state, 0, sizeof(*state));
	init_cfi_state(&state->cfi);
247 248 249 250 251 252 253 254

	/*
	 * We need the full vmlinux for noinstr validation, otherwise we can
	 * not correctly determine insn->call_dest->sec (external symbols do
	 * not have a section).
	 */
	if (vmlinux && sec)
		state->noinstr = sec->noinstr;
255 256
}

257 258 259 260 261 262 263 264 265 266
/*
 * Call the arch-specific instruction decoder for all the instructions and add
 * them to the global instruction list.
 */
static int decode_instructions(struct objtool_file *file)
{
	struct section *sec;
	struct symbol *func;
	unsigned long offset;
	struct instruction *insn;
P
Peter Zijlstra 已提交
267
	unsigned long nr_insns = 0;
268 269
	int ret;

270
	for_each_sec(file, sec) {
271 272 273 274

		if (!(sec->sh.sh_flags & SHF_EXECINSTR))
			continue;

275 276 277 278 279
		if (strcmp(sec->name, ".altinstr_replacement") &&
		    strcmp(sec->name, ".altinstr_aux") &&
		    strncmp(sec->name, ".discard.", 9))
			sec->text = true;

280 281
		if (!strcmp(sec->name, ".noinstr.text") ||
		    !strcmp(sec->name, ".entry.text"))
282 283
			sec->noinstr = true;

284 285
		for (offset = 0; offset < sec->len; offset += insn->len) {
			insn = malloc(sizeof(*insn));
286 287 288 289
			if (!insn) {
				WARN("malloc failed");
				return -1;
			}
290 291
			memset(insn, 0, sizeof(*insn));
			INIT_LIST_HEAD(&insn->alts);
292
			INIT_LIST_HEAD(&insn->stack_ops);
293
			init_cfi_state(&insn->cfi);
294

295 296 297 298 299 300
			insn->sec = sec;
			insn->offset = offset;

			ret = arch_decode_instruction(file->elf, sec, offset,
						      sec->len - offset,
						      &insn->len, &insn->type,
301
						      &insn->immediate,
302
						      &insn->stack_ops);
303
			if (ret)
304
				goto err;
305

306
			hash_add(file->insn_hash, &insn->hash, sec_offset_hash(sec, insn->offset));
307
			list_add_tail(&insn->list, &file->insn_list);
P
Peter Zijlstra 已提交
308
			nr_insns++;
309 310 311
		}

		list_for_each_entry(func, &sec->symbol_list, list) {
312
			if (func->type != STT_FUNC || func->alias != func)
313 314 315 316 317 318 319 320
				continue;

			if (!find_insn(file, sec, func->offset)) {
				WARN("%s(): can't find starting instruction",
				     func->name);
				return -1;
			}

321
			sym_for_each_insn(file, func, insn)
322
				insn->func = func;
323 324 325
		}
	}

P
Peter Zijlstra 已提交
326 327 328
	if (stats)
		printf("nr_insns: %lu\n", nr_insns);

329
	return 0;
330 331 332 333

err:
	free(insn);
	return ret;
334 335
}

336 337 338 339 340 341 342 343 344 345 346 347 348
static struct instruction *find_last_insn(struct objtool_file *file,
					  struct section *sec)
{
	struct instruction *insn = NULL;
	unsigned int offset;
	unsigned int end = (sec->len > 10) ? sec->len - 10 : 0;

	for (offset = sec->len - 1; offset >= end && !insn; offset--)
		insn = find_insn(file, sec, offset);

	return insn;
}

349
/*
350
 * Mark "ud2" instructions and manually annotated dead ends.
351 352 353 354
 */
static int add_dead_ends(struct objtool_file *file)
{
	struct section *sec;
M
Matt Helsley 已提交
355
	struct reloc *reloc;
356 357
	struct instruction *insn;

358 359 360 361 362 363 364 365 366 367 368
	/*
	 * By default, "ud2" is a dead end unless otherwise annotated, because
	 * GCC 7 inserts it for certain divide-by-zero cases.
	 */
	for_each_insn(file, insn)
		if (insn->type == INSN_BUG)
			insn->dead_end = true;

	/*
	 * Check for manually annotated dead ends.
	 */
369 370
	sec = find_section_by_name(file->elf, ".rela.discard.unreachable");
	if (!sec)
371
		goto reachable;
372

M
Matt Helsley 已提交
373 374
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		if (reloc->sym->type != STT_SECTION) {
375 376 377
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}
M
Matt Helsley 已提交
378
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
379 380
		if (insn)
			insn = list_prev_entry(insn, list);
M
Matt Helsley 已提交
381 382
		else if (reloc->addend == reloc->sym->sec->len) {
			insn = find_last_insn(file, reloc->sym->sec);
383
			if (!insn) {
384
				WARN("can't find unreachable insn at %s+0x%x",
M
Matt Helsley 已提交
385
				     reloc->sym->sec->name, reloc->addend);
386 387 388 389
				return -1;
			}
		} else {
			WARN("can't find unreachable insn at %s+0x%x",
M
Matt Helsley 已提交
390
			     reloc->sym->sec->name, reloc->addend);
391 392 393 394 395 396
			return -1;
		}

		insn->dead_end = true;
	}

397 398 399 400 401 402 403 404 405 406 407
reachable:
	/*
	 * These manually annotated reachable checks are needed for GCC 4.4,
	 * where the Linux unreachable() macro isn't supported.  In that case
	 * GCC doesn't know the "ud2" is fatal, so it generates code as if it's
	 * not a dead end.
	 */
	sec = find_section_by_name(file->elf, ".rela.discard.reachable");
	if (!sec)
		return 0;

M
Matt Helsley 已提交
408 409
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		if (reloc->sym->type != STT_SECTION) {
410 411 412
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}
M
Matt Helsley 已提交
413
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
414 415
		if (insn)
			insn = list_prev_entry(insn, list);
M
Matt Helsley 已提交
416 417
		else if (reloc->addend == reloc->sym->sec->len) {
			insn = find_last_insn(file, reloc->sym->sec);
418
			if (!insn) {
419
				WARN("can't find reachable insn at %s+0x%x",
M
Matt Helsley 已提交
420
				     reloc->sym->sec->name, reloc->addend);
421 422 423 424
				return -1;
			}
		} else {
			WARN("can't find reachable insn at %s+0x%x",
M
Matt Helsley 已提交
425
			     reloc->sym->sec->name, reloc->addend);
426 427 428 429 430 431
			return -1;
		}

		insn->dead_end = false;
	}

432 433 434 435 436 437 438 439 440 441 442
	return 0;
}

/*
 * Warnings shouldn't be reported for ignored functions.
 */
static void add_ignores(struct objtool_file *file)
{
	struct instruction *insn;
	struct section *sec;
	struct symbol *func;
M
Matt Helsley 已提交
443
	struct reloc *reloc;
444

P
Peter Zijlstra 已提交
445 446 447
	sec = find_section_by_name(file->elf, ".rela.discard.func_stack_frame_non_standard");
	if (!sec)
		return;
448

M
Matt Helsley 已提交
449 450
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		switch (reloc->sym->type) {
P
Peter Zijlstra 已提交
451
		case STT_FUNC:
M
Matt Helsley 已提交
452
			func = reloc->sym;
P
Peter Zijlstra 已提交
453 454 455
			break;

		case STT_SECTION:
M
Matt Helsley 已提交
456
			func = find_func_by_offset(reloc->sym->sec, reloc->addend);
457
			if (!func)
458
				continue;
P
Peter Zijlstra 已提交
459
			break;
460

P
Peter Zijlstra 已提交
461
		default:
M
Matt Helsley 已提交
462
			WARN("unexpected relocation symbol type in %s: %d", sec->name, reloc->sym->type);
P
Peter Zijlstra 已提交
463
			continue;
464
		}
P
Peter Zijlstra 已提交
465

466
		func_for_each_insn(file, func, insn)
P
Peter Zijlstra 已提交
467
			insn->ignore = true;
468 469 470
	}
}

P
Peter Zijlstra 已提交
471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507
/*
 * This is a whitelist of functions that is allowed to be called with AC set.
 * The list is meant to be minimal and only contains compiler instrumentation
 * ABI and a few functions used to implement *_{to,from}_user() functions.
 *
 * These functions must not directly change AC, but may PUSHF/POPF.
 */
static const char *uaccess_safe_builtin[] = {
	/* KASAN */
	"kasan_report",
	"check_memory_region",
	/* KASAN out-of-line */
	"__asan_loadN_noabort",
	"__asan_load1_noabort",
	"__asan_load2_noabort",
	"__asan_load4_noabort",
	"__asan_load8_noabort",
	"__asan_load16_noabort",
	"__asan_storeN_noabort",
	"__asan_store1_noabort",
	"__asan_store2_noabort",
	"__asan_store4_noabort",
	"__asan_store8_noabort",
	"__asan_store16_noabort",
	/* KASAN in-line */
	"__asan_report_load_n_noabort",
	"__asan_report_load1_noabort",
	"__asan_report_load2_noabort",
	"__asan_report_load4_noabort",
	"__asan_report_load8_noabort",
	"__asan_report_load16_noabort",
	"__asan_report_store_n_noabort",
	"__asan_report_store1_noabort",
	"__asan_report_store2_noabort",
	"__asan_report_store4_noabort",
	"__asan_report_store8_noabort",
	"__asan_report_store16_noabort",
508
	/* KCSAN */
509
	"__kcsan_check_access",
510 511
	"kcsan_found_watchpoint",
	"kcsan_setup_watchpoint",
512
	"kcsan_check_scoped_accesses",
513 514
	"kcsan_disable_current",
	"kcsan_enable_current_nowarn",
515 516 517 518 519 520 521 522 523 524 525 526 527 528 529
	/* KCSAN/TSAN */
	"__tsan_func_entry",
	"__tsan_func_exit",
	"__tsan_read_range",
	"__tsan_write_range",
	"__tsan_read1",
	"__tsan_read2",
	"__tsan_read4",
	"__tsan_read8",
	"__tsan_read16",
	"__tsan_write1",
	"__tsan_write2",
	"__tsan_write4",
	"__tsan_write8",
	"__tsan_write16",
P
Peter Zijlstra 已提交
530 531
	/* KCOV */
	"write_comp_data",
532
	"check_kcov_mode",
P
Peter Zijlstra 已提交
533 534 535 536 537 538 539 540 541
	"__sanitizer_cov_trace_pc",
	"__sanitizer_cov_trace_const_cmp1",
	"__sanitizer_cov_trace_const_cmp2",
	"__sanitizer_cov_trace_const_cmp4",
	"__sanitizer_cov_trace_const_cmp8",
	"__sanitizer_cov_trace_cmp1",
	"__sanitizer_cov_trace_cmp2",
	"__sanitizer_cov_trace_cmp4",
	"__sanitizer_cov_trace_cmp8",
542
	"__sanitizer_cov_trace_switch",
P
Peter Zijlstra 已提交
543 544 545 546
	/* UBSAN */
	"ubsan_type_mismatch_common",
	"__ubsan_handle_type_mismatch",
	"__ubsan_handle_type_mismatch_v1",
547
	"__ubsan_handle_shift_out_of_bounds",
P
Peter Zijlstra 已提交
548 549 550
	/* misc */
	"csum_partial_copy_generic",
	"__memcpy_mcsafe",
551
	"mcsafe_handle_tail",
P
Peter Zijlstra 已提交
552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568
	"ftrace_likely_update", /* CONFIG_TRACE_BRANCH_PROFILING */
	NULL
};

static void add_uaccess_safe(struct objtool_file *file)
{
	struct symbol *func;
	const char **name;

	if (!uaccess)
		return;

	for (name = uaccess_safe_builtin; *name; name++) {
		func = find_symbol_by_name(file->elf, *name);
		if (!func)
			continue;

569
		func->uaccess_safe = true;
570 571 572
	}
}

573 574 575 576 577 578
/*
 * FIXME: For now, just ignore any alternatives which add retpolines.  This is
 * a temporary hack, as it doesn't allow ORC to unwind from inside a retpoline.
 * But it at least allows objtool to understand the control flow *around* the
 * retpoline.
 */
579
static int add_ignore_alternatives(struct objtool_file *file)
580 581
{
	struct section *sec;
M
Matt Helsley 已提交
582
	struct reloc *reloc;
583 584
	struct instruction *insn;

585
	sec = find_section_by_name(file->elf, ".rela.discard.ignore_alts");
586 587 588
	if (!sec)
		return 0;

M
Matt Helsley 已提交
589 590
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		if (reloc->sym->type != STT_SECTION) {
591 592 593 594
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}

M
Matt Helsley 已提交
595
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
596
		if (!insn) {
597
			WARN("bad .discard.ignore_alts entry");
598 599 600 601 602 603 604 605 606
			return -1;
		}

		insn->ignore_alts = true;
	}

	return 0;
}

607 608 609 610 611 612
/*
 * Find the destination instructions for all jumps.
 */
static int add_jump_destinations(struct objtool_file *file)
{
	struct instruction *insn;
M
Matt Helsley 已提交
613
	struct reloc *reloc;
614 615 616 617
	struct section *dest_sec;
	unsigned long dest_off;

	for_each_insn(file, insn) {
618
		if (!is_static_jump(insn))
619 620
			continue;

621
		if (insn->ignore || insn->offset == FAKE_JUMP_OFFSET)
622 623
			continue;

M
Matt Helsley 已提交
624
		reloc = find_reloc_by_dest_range(file->elf, insn->sec,
625
					       insn->offset, insn->len);
M
Matt Helsley 已提交
626
		if (!reloc) {
627
			dest_sec = insn->sec;
628
			dest_off = arch_jump_destination(insn);
M
Matt Helsley 已提交
629 630 631 632 633 634 635 636
		} else if (reloc->sym->type == STT_SECTION) {
			dest_sec = reloc->sym->sec;
			dest_off = arch_dest_reloc_offset(reloc->addend);
		} else if (reloc->sym->sec->idx) {
			dest_sec = reloc->sym->sec;
			dest_off = reloc->sym->sym.st_value +
				   arch_dest_reloc_offset(reloc->addend);
		} else if (strstr(reloc->sym->name, "_indirect_thunk_")) {
637 638 639 640
			/*
			 * Retpoline jumps are really dynamic jumps in
			 * disguise, so convert them accordingly.
			 */
641 642 643 644 645
			if (insn->type == INSN_JUMP_UNCONDITIONAL)
				insn->type = INSN_JUMP_DYNAMIC;
			else
				insn->type = INSN_JUMP_DYNAMIC_CONDITIONAL;

646
			insn->retpoline_safe = true;
647
			continue;
648
		} else {
649
			/* external sibling call */
M
Matt Helsley 已提交
650
			insn->call_dest = reloc->sym;
651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669
			continue;
		}

		insn->jump_dest = find_insn(file, dest_sec, dest_off);
		if (!insn->jump_dest) {

			/*
			 * This is a special case where an alt instruction
			 * jumps past the end of the section.  These are
			 * handled later in handle_group_alt().
			 */
			if (!strcmp(insn->sec->name, ".altinstr_replacement"))
				continue;

			WARN_FUNC("can't find jump dest instruction at %s+0x%lx",
				  insn->sec, insn->offset, dest_sec->name,
				  dest_off);
			return -1;
		}
670 671

		/*
672
		 * Cross-function jump.
673 674
		 */
		if (insn->func && insn->jump_dest->func &&
675 676 677 678 679 680 681 682 683 684 685 686 687 688 689
		    insn->func != insn->jump_dest->func) {

			/*
			 * For GCC 8+, create parent/child links for any cold
			 * subfunctions.  This is _mostly_ redundant with a
			 * similar initialization in read_symbols().
			 *
			 * If a function has aliases, we want the *first* such
			 * function in the symbol table to be the subfunction's
			 * parent.  In that case we overwrite the
			 * initialization done in read_symbols().
			 *
			 * However this code can't completely replace the
			 * read_symbols() code because this doesn't detect the
			 * case where the parent function's only reference to a
690
			 * subfunction is through a jump table.
691 692 693 694 695 696 697 698 699
			 */
			if (!strstr(insn->func->name, ".cold.") &&
			    strstr(insn->jump_dest->func->name, ".cold.")) {
				insn->func->cfunc = insn->jump_dest->func;
				insn->jump_dest->func->pfunc = insn->func;

			} else if (insn->jump_dest->func->pfunc != insn->func->pfunc &&
				   insn->jump_dest->offset == insn->jump_dest->func->offset) {

700
				/* internal sibling call */
701 702
				insn->call_dest = insn->jump_dest->func;
			}
703
		}
704 705 706 707 708
	}

	return 0;
}

709 710 711 712 713 714 715 716 717 718
static void remove_insn_ops(struct instruction *insn)
{
	struct stack_op *op, *tmp;

	list_for_each_entry_safe(op, tmp, &insn->stack_ops, list) {
		list_del(&op->list);
		free(op);
	}
}

719 720 721 722 723 724 725
/*
 * Find the destination instructions for all calls.
 */
static int add_call_destinations(struct objtool_file *file)
{
	struct instruction *insn;
	unsigned long dest_off;
M
Matt Helsley 已提交
726
	struct reloc *reloc;
727 728 729 730 731

	for_each_insn(file, insn) {
		if (insn->type != INSN_CALL)
			continue;

M
Matt Helsley 已提交
732
		reloc = find_reloc_by_dest_range(file->elf, insn->sec,
733
					       insn->offset, insn->len);
M
Matt Helsley 已提交
734
		if (!reloc) {
735
			dest_off = arch_jump_destination(insn);
736 737 738
			insn->call_dest = find_func_by_offset(insn->sec, dest_off);
			if (!insn->call_dest)
				insn->call_dest = find_symbol_by_offset(insn->sec, dest_off);
739

740 741 742 743
			if (insn->ignore)
				continue;

			if (!insn->call_dest) {
744
				WARN_FUNC("unannotated intra-function call", insn->sec, insn->offset);
745 746
				return -1;
			}
747

748 749 750 751 752 753
			if (insn->func && insn->call_dest->type != STT_FUNC) {
				WARN_FUNC("unsupported call to non-function",
					  insn->sec, insn->offset);
				return -1;
			}

M
Matt Helsley 已提交
754 755 756
		} else if (reloc->sym->type == STT_SECTION) {
			dest_off = arch_dest_reloc_offset(reloc->addend);
			insn->call_dest = find_func_by_offset(reloc->sym->sec,
757
							      dest_off);
758
			if (!insn->call_dest) {
759
				WARN_FUNC("can't find call dest symbol at %s+0x%lx",
760
					  insn->sec, insn->offset,
M
Matt Helsley 已提交
761
					  reloc->sym->sec->name,
762
					  dest_off);
763 764 765
				return -1;
			}
		} else
M
Matt Helsley 已提交
766
			insn->call_dest = reloc->sym;
767 768 769 770 771 772 773 774 775

		/*
		 * Whatever stack impact regular CALLs have, should be undone
		 * by the RETURN of the called function.
		 *
		 * Annotated intra-function calls retain the stack_ops but
		 * are converted to JUMP, see read_intra_function_calls().
		 */
		remove_insn_ops(insn);
776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802
	}

	return 0;
}

/*
 * The .alternatives section requires some extra special care, over and above
 * what other special sections require:
 *
 * 1. Because alternatives are patched in-place, we need to insert a fake jump
 *    instruction at the end so that validate_branch() skips all the original
 *    replaced instructions when validating the new instruction path.
 *
 * 2. An added wrinkle is that the new instruction length might be zero.  In
 *    that case the old instructions are replaced with noops.  We simulate that
 *    by creating a fake jump as the only new instruction.
 *
 * 3. In some cases, the alternative section includes an instruction which
 *    conditionally jumps to the _end_ of the entry.  We have to modify these
 *    jumps' destinations to point back to .text rather than the end of the
 *    entry in .altinstr_replacement.
 */
static int handle_group_alt(struct objtool_file *file,
			    struct special_alt *special_alt,
			    struct instruction *orig_insn,
			    struct instruction **new_insn)
{
803
	static unsigned int alt_group_next_index = 1;
804
	struct instruction *last_orig_insn, *last_new_insn, *insn, *fake_jump = NULL;
805
	unsigned int alt_group = alt_group_next_index++;
806 807 808 809 810 811 812 813
	unsigned long dest_off;

	last_orig_insn = NULL;
	insn = orig_insn;
	sec_for_each_insn_from(file, insn) {
		if (insn->offset >= special_alt->orig_off + special_alt->orig_len)
			break;

814
		insn->alt_group = alt_group;
815 816 817
		last_orig_insn = insn;
	}

818 819 820 821 822 823 824 825
	if (next_insn_same_sec(file, last_orig_insn)) {
		fake_jump = malloc(sizeof(*fake_jump));
		if (!fake_jump) {
			WARN("malloc failed");
			return -1;
		}
		memset(fake_jump, 0, sizeof(*fake_jump));
		INIT_LIST_HEAD(&fake_jump->alts);
826
		INIT_LIST_HEAD(&fake_jump->stack_ops);
827
		init_cfi_state(&fake_jump->cfi);
828 829

		fake_jump->sec = special_alt->new_sec;
830
		fake_jump->offset = FAKE_JUMP_OFFSET;
831 832
		fake_jump->type = INSN_JUMP_UNCONDITIONAL;
		fake_jump->jump_dest = list_next_entry(last_orig_insn, list);
833
		fake_jump->func = orig_insn->func;
834 835 836
	}

	if (!special_alt->new_len) {
837 838 839 840 841 842
		if (!fake_jump) {
			WARN("%s: empty alternative at end of section",
			     special_alt->orig_sec->name);
			return -1;
		}

843 844 845 846 847
		*new_insn = fake_jump;
		return 0;
	}

	last_new_insn = NULL;
848
	alt_group = alt_group_next_index++;
849 850 851 852 853 854 855
	insn = *new_insn;
	sec_for_each_insn_from(file, insn) {
		if (insn->offset >= special_alt->new_off + special_alt->new_len)
			break;

		last_new_insn = insn;

856
		insn->ignore = orig_insn->ignore_alts;
857
		insn->func = orig_insn->func;
858
		insn->alt_group = alt_group;
859

860 861 862 863 864 865 866 867 868 869 870 871 872 873
		/*
		 * Since alternative replacement code is copy/pasted by the
		 * kernel after applying relocations, generally such code can't
		 * have relative-address relocation references to outside the
		 * .altinstr_replacement section, unless the arch's
		 * alternatives code can adjust the relative offsets
		 * accordingly.
		 *
		 * The x86 alternatives code adjusts the offsets only when it
		 * encounters a branch instruction at the very beginning of the
		 * replacement group.
		 */
		if ((insn->offset != special_alt->new_off ||
		    (insn->type != INSN_CALL && !is_static_jump(insn))) &&
M
Matt Helsley 已提交
874
		    find_reloc_by_dest_range(file->elf, insn->sec, insn->offset, insn->len)) {
875 876 877 878 879 880

			WARN_FUNC("unsupported relocation in alternatives section",
				  insn->sec, insn->offset);
			return -1;
		}

881
		if (!is_static_jump(insn))
882 883 884 885 886
			continue;

		if (!insn->immediate)
			continue;

887
		dest_off = arch_jump_destination(insn);
888 889 890 891 892 893
		if (dest_off == special_alt->new_off + special_alt->new_len) {
			if (!fake_jump) {
				WARN("%s: alternative jump to end of section",
				     special_alt->orig_sec->name);
				return -1;
			}
894
			insn->jump_dest = fake_jump;
895
		}
896 897 898 899 900 901 902 903 904 905 906 907 908 909

		if (!insn->jump_dest) {
			WARN_FUNC("can't find alternative jump destination",
				  insn->sec, insn->offset);
			return -1;
		}
	}

	if (!last_new_insn) {
		WARN_FUNC("can't find last new alternative instruction",
			  special_alt->new_sec, special_alt->new_off);
		return -1;
	}

910 911
	if (fake_jump)
		list_add(&fake_jump->list, &last_new_insn->list);
912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981

	return 0;
}

/*
 * A jump table entry can either convert a nop to a jump or a jump to a nop.
 * If the original instruction is a jump, make the alt entry an effective nop
 * by just skipping the original instruction.
 */
static int handle_jump_alt(struct objtool_file *file,
			   struct special_alt *special_alt,
			   struct instruction *orig_insn,
			   struct instruction **new_insn)
{
	if (orig_insn->type == INSN_NOP)
		return 0;

	if (orig_insn->type != INSN_JUMP_UNCONDITIONAL) {
		WARN_FUNC("unsupported instruction at jump label",
			  orig_insn->sec, orig_insn->offset);
		return -1;
	}

	*new_insn = list_next_entry(orig_insn, list);
	return 0;
}

/*
 * Read all the special sections which have alternate instructions which can be
 * patched in or redirected to at runtime.  Each instruction having alternate
 * instruction(s) has them added to its insn->alts list, which will be
 * traversed in validate_branch().
 */
static int add_special_section_alts(struct objtool_file *file)
{
	struct list_head special_alts;
	struct instruction *orig_insn, *new_insn;
	struct special_alt *special_alt, *tmp;
	struct alternative *alt;
	int ret;

	ret = special_get_alts(file->elf, &special_alts);
	if (ret)
		return ret;

	list_for_each_entry_safe(special_alt, tmp, &special_alts, list) {

		orig_insn = find_insn(file, special_alt->orig_sec,
				      special_alt->orig_off);
		if (!orig_insn) {
			WARN_FUNC("special: can't find orig instruction",
				  special_alt->orig_sec, special_alt->orig_off);
			ret = -1;
			goto out;
		}

		new_insn = NULL;
		if (!special_alt->group || special_alt->new_len) {
			new_insn = find_insn(file, special_alt->new_sec,
					     special_alt->new_off);
			if (!new_insn) {
				WARN_FUNC("special: can't find new instruction",
					  special_alt->new_sec,
					  special_alt->new_off);
				ret = -1;
				goto out;
			}
		}

		if (special_alt->group) {
982 983 984 985 986 987
			if (!special_alt->orig_len) {
				WARN_FUNC("empty alternative entry",
					  orig_insn->sec, orig_insn->offset);
				continue;
			}

988 989 990 991 992 993 994 995 996 997 998
			ret = handle_group_alt(file, special_alt, orig_insn,
					       &new_insn);
			if (ret)
				goto out;
		} else if (special_alt->jump_or_nop) {
			ret = handle_jump_alt(file, special_alt, orig_insn,
					      &new_insn);
			if (ret)
				goto out;
		}

999 1000 1001 1002 1003 1004 1005
		alt = malloc(sizeof(*alt));
		if (!alt) {
			WARN("malloc failed");
			ret = -1;
			goto out;
		}

1006
		alt->insn = new_insn;
P
Peter Zijlstra 已提交
1007
		alt->skip_orig = special_alt->skip_orig;
P
Peter Zijlstra 已提交
1008
		orig_insn->ignore_alts |= special_alt->skip_alt;
1009 1010 1011 1012 1013 1014 1015 1016 1017 1018
		list_add_tail(&alt->list, &orig_insn->alts);

		list_del(&special_alt->list);
		free(special_alt);
	}

out:
	return ret;
}

1019
static int add_jump_table(struct objtool_file *file, struct instruction *insn,
M
Matt Helsley 已提交
1020
			    struct reloc *table)
1021
{
M
Matt Helsley 已提交
1022
	struct reloc *reloc = table;
1023
	struct instruction *dest_insn;
1024
	struct alternative *alt;
1025 1026
	struct symbol *pfunc = insn->func->pfunc;
	unsigned int prev_offset = 0;
1027

1028
	/*
M
Matt Helsley 已提交
1029
	 * Each @reloc is a switch table relocation which points to the target
1030 1031
	 * instruction.
	 */
M
Matt Helsley 已提交
1032
	list_for_each_entry_from(reloc, &table->sec->reloc_list, list) {
1033 1034

		/* Check for the end of the table: */
M
Matt Helsley 已提交
1035
		if (reloc != table && reloc->jump_table_start)
1036 1037
			break;

1038
		/* Make sure the table entries are consecutive: */
M
Matt Helsley 已提交
1039
		if (prev_offset && reloc->offset != prev_offset + 8)
1040 1041 1042
			break;

		/* Detect function pointers from contiguous objects: */
M
Matt Helsley 已提交
1043 1044
		if (reloc->sym->sec == pfunc->sec &&
		    reloc->addend == pfunc->offset)
1045 1046
			break;

M
Matt Helsley 已提交
1047
		dest_insn = find_insn(file, reloc->sym->sec, reloc->addend);
1048
		if (!dest_insn)
1049 1050
			break;

1051
		/* Make sure the destination is in the same function: */
1052
		if (!dest_insn->func || dest_insn->func->pfunc != pfunc)
1053
			break;
1054 1055 1056 1057 1058 1059 1060

		alt = malloc(sizeof(*alt));
		if (!alt) {
			WARN("malloc failed");
			return -1;
		}

1061
		alt->insn = dest_insn;
1062
		list_add_tail(&alt->list, &insn->alts);
M
Matt Helsley 已提交
1063
		prev_offset = reloc->offset;
1064 1065 1066 1067 1068 1069
	}

	if (!prev_offset) {
		WARN_FUNC("can't find switch jump table",
			  insn->sec, insn->offset);
		return -1;
1070 1071 1072 1073 1074 1075
	}

	return 0;
}

/*
1076
 * find_jump_table() - Given a dynamic jump, find the switch jump table in
1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108
 * .rodata associated with it.
 *
 * There are 3 basic patterns:
 *
 * 1. jmpq *[rodata addr](,%reg,8)
 *
 *    This is the most common case by far.  It jumps to an address in a simple
 *    jump table which is stored in .rodata.
 *
 * 2. jmpq *[rodata addr](%rip)
 *
 *    This is caused by a rare GCC quirk, currently only seen in three driver
 *    functions in the kernel, only with certain obscure non-distro configs.
 *
 *    As part of an optimization, GCC makes a copy of an existing switch jump
 *    table, modifies it, and then hard-codes the jump (albeit with an indirect
 *    jump) to use a single entry in the table.  The rest of the jump table and
 *    some of its jump targets remain as dead code.
 *
 *    In such a case we can just crudely ignore all unreachable instruction
 *    warnings for the entire object file.  Ideally we would just ignore them
 *    for the function, but that would require redesigning the code quite a
 *    bit.  And honestly that's just not worth doing: unreachable instruction
 *    warnings are of questionable value anyway, and this is such a rare issue.
 *
 * 3. mov [rodata addr],%reg1
 *    ... some instructions ...
 *    jmpq *(%reg1,%reg2,8)
 *
 *    This is a fairly uncommon pattern which is new for GCC 6.  As of this
 *    writing, there are 11 occurrences of it in the allmodconfig kernel.
 *
1109 1110 1111 1112
 *    As of GCC 7 there are quite a few more of these and the 'in between' code
 *    is significant. Esp. with KASAN enabled some of the code between the mov
 *    and jmpq uses .rodata itself, which can confuse things.
 *
1113 1114
 *    TODO: Once we have DWARF CFI and smarter instruction decoding logic,
 *    ensure the same register is used in the mov and jump instructions.
1115 1116
 *
 *    NOTE: RETPOLINE made it harder still to decode dynamic jumps.
1117
 */
M
Matt Helsley 已提交
1118
static struct reloc *find_jump_table(struct objtool_file *file,
1119 1120 1121
				      struct symbol *func,
				      struct instruction *insn)
{
M
Matt Helsley 已提交
1122
	struct reloc *text_reloc, *table_reloc;
1123
	struct instruction *dest_insn, *orig_insn = insn;
1124
	struct section *table_sec;
1125
	unsigned long table_offset;
1126

1127 1128 1129 1130 1131
	/*
	 * Backward search using the @first_jump_src links, these help avoid
	 * much of the 'in between' code. Which avoids us getting confused by
	 * it.
	 */
1132
	for (;
1133 1134
	     insn && insn->func && insn->func->pfunc == func;
	     insn = insn->first_jump_src ?: prev_insn_same_sym(file, insn)) {
1135

1136
		if (insn != orig_insn && insn->type == INSN_JUMP_DYNAMIC)
1137 1138 1139 1140 1141 1142 1143 1144 1145 1146
			break;

		/* allow small jumps within the range */
		if (insn->type == INSN_JUMP_UNCONDITIONAL &&
		    insn->jump_dest &&
		    (insn->jump_dest->offset <= insn->offset ||
		     insn->jump_dest->offset > orig_insn->offset))
		    break;

		/* look for a relocation which references .rodata */
M
Matt Helsley 已提交
1147
		text_reloc = find_reloc_by_dest_range(file->elf, insn->sec,
1148
						    insn->offset, insn->len);
M
Matt Helsley 已提交
1149 1150
		if (!text_reloc || text_reloc->sym->type != STT_SECTION ||
		    !text_reloc->sym->sec->rodata)
1151 1152
			continue;

M
Matt Helsley 已提交
1153 1154
		table_offset = text_reloc->addend;
		table_sec = text_reloc->sym->sec;
1155

M
Matt Helsley 已提交
1156
		if (text_reloc->type == R_X86_64_PC32)
1157 1158
			table_offset += 4;

1159 1160
		/*
		 * Make sure the .rodata address isn't associated with a
1161 1162 1163 1164 1165 1166
		 * symbol.  GCC jump tables are anonymous data.
		 *
		 * Also support C jump tables which are in the same format as
		 * switch jump tables.  For objtool to recognize them, they
		 * need to be placed in the C_JUMP_TABLE_SECTION section.  They
		 * have symbols associated with them.
1167
		 */
1168 1169
		if (find_symbol_containing(table_sec, table_offset) &&
		    strcmp(table_sec->name, C_JUMP_TABLE_SECTION))
1170 1171
			continue;

1172
		/*
M
Matt Helsley 已提交
1173
		 * Each table entry has a reloc associated with it.  The reloc
1174 1175 1176
		 * should reference text in the same function as the original
		 * instruction.
		 */
M
Matt Helsley 已提交
1177 1178
		table_reloc = find_reloc_by_dest(file->elf, table_sec, table_offset);
		if (!table_reloc)
1179
			continue;
M
Matt Helsley 已提交
1180
		dest_insn = find_insn(file, table_reloc->sym->sec, table_reloc->addend);
1181 1182
		if (!dest_insn || !dest_insn->func || dest_insn->func->pfunc != func)
			continue;
1183

1184 1185 1186 1187 1188
		/*
		 * Use of RIP-relative switch jumps is quite rare, and
		 * indicates a rare GCC quirk/bug which can leave dead code
		 * behind.
		 */
M
Matt Helsley 已提交
1189
		if (text_reloc->type == R_X86_64_PC32)
1190 1191
			file->ignore_unreachables = true;

M
Matt Helsley 已提交
1192
		return table_reloc;
1193 1194 1195 1196 1197
	}

	return NULL;
}

1198 1199 1200 1201 1202 1203
/*
 * First pass: Mark the head of each jump table so that in the next pass,
 * we know when a given jump table ends and the next one starts.
 */
static void mark_func_jump_tables(struct objtool_file *file,
				    struct symbol *func)
1204
{
1205
	struct instruction *insn, *last = NULL;
M
Matt Helsley 已提交
1206
	struct reloc *reloc;
1207

1208
	func_for_each_insn(file, func, insn) {
1209 1210 1211 1212 1213
		if (!last)
			last = insn;

		/*
		 * Store back-pointers for unconditional forward jumps such
1214
		 * that find_jump_table() can back-track using those and
1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225
		 * avoid some potentially confusing code.
		 */
		if (insn->type == INSN_JUMP_UNCONDITIONAL && insn->jump_dest &&
		    insn->offset > last->offset &&
		    insn->jump_dest->offset > insn->offset &&
		    !insn->jump_dest->first_jump_src) {

			insn->jump_dest->first_jump_src = insn;
			last = insn->jump_dest;
		}

1226 1227 1228
		if (insn->type != INSN_JUMP_DYNAMIC)
			continue;

M
Matt Helsley 已提交
1229 1230 1231 1232
		reloc = find_jump_table(file, func, insn);
		if (reloc) {
			reloc->jump_table_start = true;
			insn->jump_table = reloc;
1233 1234
		}
	}
1235 1236 1237 1238 1239 1240 1241 1242
}

static int add_func_jump_tables(struct objtool_file *file,
				  struct symbol *func)
{
	struct instruction *insn;
	int ret;

1243
	func_for_each_insn(file, func, insn) {
1244 1245
		if (!insn->jump_table)
			continue;
1246

1247
		ret = add_jump_table(file, insn, insn->jump_table);
1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259
		if (ret)
			return ret;
	}

	return 0;
}

/*
 * For some switch statements, gcc generates a jump table in the .rodata
 * section which contains a list of addresses within the function to jump to.
 * This finds these jump tables and adds them to the insn->alts lists.
 */
1260
static int add_jump_table_alts(struct objtool_file *file)
1261 1262 1263 1264 1265
{
	struct section *sec;
	struct symbol *func;
	int ret;

1266
	if (!file->rodata)
1267 1268
		return 0;

1269
	for_each_sec(file, sec) {
1270 1271 1272 1273
		list_for_each_entry(func, &sec->symbol_list, list) {
			if (func->type != STT_FUNC)
				continue;

1274
			mark_func_jump_tables(file, func);
1275
			ret = add_func_jump_tables(file, func);
1276 1277 1278 1279 1280 1281 1282 1283
			if (ret)
				return ret;
		}
	}

	return 0;
}

1284 1285
static int read_unwind_hints(struct objtool_file *file)
{
M
Matt Helsley 已提交
1286 1287
	struct section *sec, *relocsec;
	struct reloc *reloc;
1288 1289 1290 1291 1292 1293 1294 1295 1296
	struct unwind_hint *hint;
	struct instruction *insn;
	struct cfi_reg *cfa;
	int i;

	sec = find_section_by_name(file->elf, ".discard.unwind_hints");
	if (!sec)
		return 0;

M
Matt Helsley 已提交
1297 1298
	relocsec = sec->reloc;
	if (!relocsec) {
1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312
		WARN("missing .rela.discard.unwind_hints section");
		return -1;
	}

	if (sec->len % sizeof(struct unwind_hint)) {
		WARN("struct unwind_hint size mismatch");
		return -1;
	}

	file->hints = true;

	for (i = 0; i < sec->len / sizeof(struct unwind_hint); i++) {
		hint = (struct unwind_hint *)sec->data->d_buf + i;

M
Matt Helsley 已提交
1313 1314 1315
		reloc = find_reloc_by_dest(file->elf, sec, i * sizeof(*hint));
		if (!reloc) {
			WARN("can't find reloc for unwind_hints[%d]", i);
1316 1317 1318
			return -1;
		}

M
Matt Helsley 已提交
1319
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
1320 1321 1322 1323 1324
		if (!insn) {
			WARN("can't find insn for unwind_hints[%d]", i);
			return -1;
		}

1325
		cfa = &insn->cfi.cfa;
1326

1327
		if (hint->type == UNWIND_HINT_TYPE_RET_OFFSET) {
1328
			insn->ret_offset = hint->sp_offset;
1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365
			continue;
		}

		insn->hint = true;

		switch (hint->sp_reg) {
		case ORC_REG_UNDEFINED:
			cfa->base = CFI_UNDEFINED;
			break;
		case ORC_REG_SP:
			cfa->base = CFI_SP;
			break;
		case ORC_REG_BP:
			cfa->base = CFI_BP;
			break;
		case ORC_REG_SP_INDIRECT:
			cfa->base = CFI_SP_INDIRECT;
			break;
		case ORC_REG_R10:
			cfa->base = CFI_R10;
			break;
		case ORC_REG_R13:
			cfa->base = CFI_R13;
			break;
		case ORC_REG_DI:
			cfa->base = CFI_DI;
			break;
		case ORC_REG_DX:
			cfa->base = CFI_DX;
			break;
		default:
			WARN_FUNC("unsupported unwind_hint sp base reg %d",
				  insn->sec, insn->offset, hint->sp_reg);
			return -1;
		}

		cfa->offset = hint->sp_offset;
1366 1367
		insn->cfi.type = hint->type;
		insn->cfi.end = hint->end;
1368 1369 1370 1371 1372
	}

	return 0;
}

1373 1374
static int read_retpoline_hints(struct objtool_file *file)
{
J
Josh Poimboeuf 已提交
1375
	struct section *sec;
1376
	struct instruction *insn;
M
Matt Helsley 已提交
1377
	struct reloc *reloc;
1378

J
Josh Poimboeuf 已提交
1379
	sec = find_section_by_name(file->elf, ".rela.discard.retpoline_safe");
1380 1381 1382
	if (!sec)
		return 0;

M
Matt Helsley 已提交
1383 1384
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		if (reloc->sym->type != STT_SECTION) {
J
Josh Poimboeuf 已提交
1385
			WARN("unexpected relocation symbol type in %s", sec->name);
1386 1387 1388
			return -1;
		}

M
Matt Helsley 已提交
1389
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
1390
		if (!insn) {
J
Josh Poimboeuf 已提交
1391
			WARN("bad .discard.retpoline_safe entry");
1392 1393 1394 1395 1396
			return -1;
		}

		if (insn->type != INSN_JUMP_DYNAMIC &&
		    insn->type != INSN_CALL_DYNAMIC) {
J
Josh Poimboeuf 已提交
1397
			WARN_FUNC("retpoline_safe hint not an indirect jump/call",
1398 1399 1400 1401 1402 1403 1404 1405 1406 1407
				  insn->sec, insn->offset);
			return -1;
		}

		insn->retpoline_safe = true;
	}

	return 0;
}

1408 1409 1410 1411
static int read_instr_hints(struct objtool_file *file)
{
	struct section *sec;
	struct instruction *insn;
M
Matt Helsley 已提交
1412
	struct reloc *reloc;
1413 1414 1415 1416 1417

	sec = find_section_by_name(file->elf, ".rela.discard.instr_end");
	if (!sec)
		return 0;

M
Matt Helsley 已提交
1418 1419
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		if (reloc->sym->type != STT_SECTION) {
1420 1421 1422 1423
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}

M
Matt Helsley 已提交
1424
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436
		if (!insn) {
			WARN("bad .discard.instr_end entry");
			return -1;
		}

		insn->instr--;
	}

	sec = find_section_by_name(file->elf, ".rela.discard.instr_begin");
	if (!sec)
		return 0;

M
Matt Helsley 已提交
1437 1438
	list_for_each_entry(reloc, &sec->reloc_list, list) {
		if (reloc->sym->type != STT_SECTION) {
1439 1440 1441 1442
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}

M
Matt Helsley 已提交
1443
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454
		if (!insn) {
			WARN("bad .discard.instr_begin entry");
			return -1;
		}

		insn->instr++;
	}

	return 0;
}

1455 1456 1457 1458
static int read_intra_function_calls(struct objtool_file *file)
{
	struct instruction *insn;
	struct section *sec;
M
Matt Helsley 已提交
1459
	struct reloc *reloc;
1460 1461 1462 1463 1464

	sec = find_section_by_name(file->elf, ".rela.discard.intra_function_calls");
	if (!sec)
		return 0;

M
Matt Helsley 已提交
1465
	list_for_each_entry(reloc, &sec->reloc_list, list) {
1466 1467
		unsigned long dest_off;

M
Matt Helsley 已提交
1468
		if (reloc->sym->type != STT_SECTION) {
1469 1470 1471 1472 1473
			WARN("unexpected relocation symbol type in %s",
			     sec->name);
			return -1;
		}

M
Matt Helsley 已提交
1474
		insn = find_insn(file, reloc->sym->sec, reloc->addend);
1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505
		if (!insn) {
			WARN("bad .discard.intra_function_call entry");
			return -1;
		}

		if (insn->type != INSN_CALL) {
			WARN_FUNC("intra_function_call not a direct call",
				  insn->sec, insn->offset);
			return -1;
		}

		/*
		 * Treat intra-function CALLs as JMPs, but with a stack_op.
		 * See add_call_destinations(), which strips stack_ops from
		 * normal CALLs.
		 */
		insn->type = INSN_JUMP_UNCONDITIONAL;

		dest_off = insn->offset + insn->len + insn->immediate;
		insn->jump_dest = find_insn(file, insn->sec, dest_off);
		if (!insn->jump_dest) {
			WARN_FUNC("can't find call dest at %s+0x%lx",
				  insn->sec, insn->offset,
				  insn->sec->name, dest_off);
			return -1;
		}
	}

	return 0;
}

1506 1507 1508 1509 1510 1511
static void mark_rodata(struct objtool_file *file)
{
	struct section *sec;
	bool found = false;

	/*
1512 1513 1514 1515 1516 1517 1518 1519
	 * Search for the following rodata sections, each of which can
	 * potentially contain jump tables:
	 *
	 * - .rodata: can contain GCC switch tables
	 * - .rodata.<func>: same, if -fdata-sections is being used
	 * - .rodata..c_jump_table: contains C annotated jump tables
	 *
	 * .rodata.str1.* sections are ignored; they don't contain jump tables.
1520 1521
	 */
	for_each_sec(file, sec) {
1522 1523
		if (!strncmp(sec->name, ".rodata", 7) &&
		    !strstr(sec->name, ".str1.")) {
1524 1525 1526 1527 1528 1529 1530 1531
			sec->rodata = true;
			found = true;
		}
	}

	file->rodata = found;
}

1532 1533 1534 1535
static int decode_sections(struct objtool_file *file)
{
	int ret;

1536 1537
	mark_rodata(file);

1538 1539 1540 1541 1542 1543 1544 1545 1546
	ret = decode_instructions(file);
	if (ret)
		return ret;

	ret = add_dead_ends(file);
	if (ret)
		return ret;

	add_ignores(file);
P
Peter Zijlstra 已提交
1547
	add_uaccess_safe(file);
1548

1549
	ret = add_ignore_alternatives(file);
1550 1551 1552
	if (ret)
		return ret;

1553 1554 1555 1556
	ret = add_jump_destinations(file);
	if (ret)
		return ret;

1557
	ret = add_special_section_alts(file);
1558 1559 1560
	if (ret)
		return ret;

1561 1562 1563 1564
	ret = read_intra_function_calls(file);
	if (ret)
		return ret;

1565
	ret = add_call_destinations(file);
1566 1567 1568
	if (ret)
		return ret;

1569
	ret = add_jump_table_alts(file);
1570 1571 1572
	if (ret)
		return ret;

1573 1574 1575 1576
	ret = read_unwind_hints(file);
	if (ret)
		return ret;

1577 1578 1579 1580
	ret = read_retpoline_hints(file);
	if (ret)
		return ret;

1581 1582 1583 1584
	ret = read_instr_hints(file);
	if (ret)
		return ret;

1585 1586 1587 1588 1589
	return 0;
}

static bool is_fentry_call(struct instruction *insn)
{
1590
	if (insn->type == INSN_CALL && insn->call_dest &&
1591 1592 1593 1594 1595 1596 1597
	    insn->call_dest->type == STT_NOTYPE &&
	    !strcmp(insn->call_dest->name, "__fentry__"))
		return true;

	return false;
}

1598
static bool has_modified_stack_frame(struct instruction *insn, struct insn_state *state)
1599
{
1600
	u8 ret_offset = insn->ret_offset;
1601
	struct cfi_state *cfi = &state->cfi;
1602 1603
	int i;

1604
	if (cfi->cfa.base != initial_func_cfi.cfa.base || cfi->drap)
1605 1606
		return true;

1607
	if (cfi->cfa.offset != initial_func_cfi.cfa.offset + ret_offset)
1608 1609
		return true;

1610
	if (cfi->stack_size != initial_func_cfi.cfa.offset + ret_offset)
1611 1612
		return true;

1613 1614 1615 1616 1617 1618 1619 1620
	/*
	 * If there is a ret offset hint then don't check registers
	 * because a callee-saved register might have been pushed on
	 * the stack.
	 */
	if (ret_offset)
		return false;

1621
	for (i = 0; i < CFI_NUM_REGS; i++) {
1622 1623
		if (cfi->regs[i].base != initial_func_cfi.regs[i].base ||
		    cfi->regs[i].offset != initial_func_cfi.regs[i].offset)
1624
			return true;
1625
	}
1626 1627 1628 1629 1630 1631

	return false;
}

static bool has_valid_stack_frame(struct insn_state *state)
{
1632 1633 1634 1635
	struct cfi_state *cfi = &state->cfi;

	if (cfi->cfa.base == CFI_BP && cfi->regs[CFI_BP].base == CFI_CFA &&
	    cfi->regs[CFI_BP].offset == -16)
1636 1637
		return true;

1638
	if (cfi->drap && cfi->regs[CFI_BP].base == CFI_BP)
1639 1640 1641
		return true;

	return false;
1642 1643
}

1644 1645
static int update_cfi_state_regs(struct instruction *insn,
				  struct cfi_state *cfi,
1646
				  struct stack_op *op)
1647
{
1648
	struct cfi_reg *cfa = &cfi->cfa;
1649

1650
	if (cfa->base != CFI_SP && cfa->base != CFI_SP_INDIRECT)
1651 1652 1653
		return 0;

	/* push */
P
Peter Zijlstra 已提交
1654
	if (op->dest.type == OP_DEST_PUSH || op->dest.type == OP_DEST_PUSHF)
1655 1656 1657
		cfa->offset += 8;

	/* pop */
P
Peter Zijlstra 已提交
1658
	if (op->src.type == OP_SRC_POP || op->src.type == OP_SRC_POPF)
1659 1660 1661 1662 1663 1664 1665 1666 1667 1668
		cfa->offset -= 8;

	/* add immediate to sp */
	if (op->dest.type == OP_DEST_REG && op->src.type == OP_SRC_ADD &&
	    op->dest.reg == CFI_SP && op->src.reg == CFI_SP)
		cfa->offset -= op->src.offset;

	return 0;
}

1669
static void save_reg(struct cfi_state *cfi, unsigned char reg, int base, int offset)
1670
{
1671
	if (arch_callee_saved_reg(reg) &&
1672 1673 1674
	    cfi->regs[reg].base == CFI_UNDEFINED) {
		cfi->regs[reg].base = base;
		cfi->regs[reg].offset = offset;
1675
	}
1676 1677
}

1678
static void restore_reg(struct cfi_state *cfi, unsigned char reg)
1679
{
1680 1681
	cfi->regs[reg].base = initial_func_cfi.regs[reg].base;
	cfi->regs[reg].offset = initial_func_cfi.regs[reg].offset;
1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736
}

/*
 * A note about DRAP stack alignment:
 *
 * GCC has the concept of a DRAP register, which is used to help keep track of
 * the stack pointer when aligning the stack.  r10 or r13 is used as the DRAP
 * register.  The typical DRAP pattern is:
 *
 *   4c 8d 54 24 08		lea    0x8(%rsp),%r10
 *   48 83 e4 c0		and    $0xffffffffffffffc0,%rsp
 *   41 ff 72 f8		pushq  -0x8(%r10)
 *   55				push   %rbp
 *   48 89 e5			mov    %rsp,%rbp
 *				(more pushes)
 *   41 52			push   %r10
 *				...
 *   41 5a			pop    %r10
 *				(more pops)
 *   5d				pop    %rbp
 *   49 8d 62 f8		lea    -0x8(%r10),%rsp
 *   c3				retq
 *
 * There are some variations in the epilogues, like:
 *
 *   5b				pop    %rbx
 *   41 5a			pop    %r10
 *   41 5c			pop    %r12
 *   41 5d			pop    %r13
 *   41 5e			pop    %r14
 *   c9				leaveq
 *   49 8d 62 f8		lea    -0x8(%r10),%rsp
 *   c3				retq
 *
 * and:
 *
 *   4c 8b 55 e8		mov    -0x18(%rbp),%r10
 *   48 8b 5d e0		mov    -0x20(%rbp),%rbx
 *   4c 8b 65 f0		mov    -0x10(%rbp),%r12
 *   4c 8b 6d f8		mov    -0x8(%rbp),%r13
 *   c9				leaveq
 *   49 8d 62 f8		lea    -0x8(%r10),%rsp
 *   c3				retq
 *
 * Sometimes r13 is used as the DRAP register, in which case it's saved and
 * restored beforehand:
 *
 *   41 55			push   %r13
 *   4c 8d 6c 24 10		lea    0x10(%rsp),%r13
 *   48 83 e4 f0		and    $0xfffffffffffffff0,%rsp
 *				...
 *   49 8d 65 f0		lea    -0x10(%r13),%rsp
 *   41 5d			pop    %r13
 *   c3				retq
 */
1737
static int update_cfi_state(struct instruction *insn, struct cfi_state *cfi,
1738
			     struct stack_op *op)
1739
{
1740 1741
	struct cfi_reg *cfa = &cfi->cfa;
	struct cfi_reg *regs = cfi->regs;
1742 1743 1744 1745 1746 1747 1748 1749 1750 1751

	/* stack operations don't make sense with an undefined CFA */
	if (cfa->base == CFI_UNDEFINED) {
		if (insn->func) {
			WARN_FUNC("undefined stack state", insn->sec, insn->offset);
			return -1;
		}
		return 0;
	}

1752 1753
	if (cfi->type == ORC_TYPE_REGS || cfi->type == ORC_TYPE_REGS_IRET)
		return update_cfi_state_regs(insn, cfi, op);
1754

1755 1756 1757 1758 1759 1760
	switch (op->dest.type) {

	case OP_DEST_REG:
		switch (op->src.type) {

		case OP_SRC_REG:
1761 1762 1763 1764 1765 1766 1767
			if (op->src.reg == CFI_SP && op->dest.reg == CFI_BP &&
			    cfa->base == CFI_SP &&
			    regs[CFI_BP].base == CFI_CFA &&
			    regs[CFI_BP].offset == -cfa->offset) {

				/* mov %rsp, %rbp */
				cfa->base = op->dest.reg;
1768
				cfi->bp_scratch = false;
1769
			}
1770

1771
			else if (op->src.reg == CFI_SP &&
1772
				 op->dest.reg == CFI_BP && cfi->drap) {
1773

1774 1775
				/* drap: mov %rsp, %rbp */
				regs[CFI_BP].base = CFI_BP;
1776 1777
				regs[CFI_BP].offset = -cfi->stack_size;
				cfi->bp_scratch = false;
1778
			}
1779

1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791
			else if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {

				/*
				 * mov %rsp, %reg
				 *
				 * This is needed for the rare case where GCC
				 * does:
				 *
				 *   mov    %rsp, %rax
				 *   ...
				 *   mov    %rax, %rsp
				 */
1792 1793
				cfi->vals[op->dest.reg].base = CFI_CFA;
				cfi->vals[op->dest.reg].offset = -cfi->stack_size;
1794 1795
			}

J
Josh Poimboeuf 已提交
1796 1797 1798 1799 1800 1801 1802 1803
			else if (op->src.reg == CFI_BP && op->dest.reg == CFI_SP &&
				 cfa->base == CFI_BP) {

				/*
				 * mov %rbp, %rsp
				 *
				 * Restore the original stack pointer (Clang).
				 */
1804
				cfi->stack_size = -cfi->regs[CFI_BP].offset;
J
Josh Poimboeuf 已提交
1805 1806
			}

1807 1808 1809 1810
			else if (op->dest.reg == cfa->base) {

				/* mov %reg, %rsp */
				if (cfa->base == CFI_SP &&
1811
				    cfi->vals[op->src.reg].base == CFI_CFA) {
1812 1813 1814 1815 1816 1817 1818 1819 1820

					/*
					 * This is needed for the rare case
					 * where GCC does something dumb like:
					 *
					 *   lea    0x8(%rsp), %rcx
					 *   ...
					 *   mov    %rcx, %rsp
					 */
1821 1822
					cfa->offset = -cfi->vals[op->src.reg].offset;
					cfi->stack_size = cfa->offset;
1823 1824 1825 1826 1827

				} else {
					cfa->base = CFI_UNDEFINED;
					cfa->offset = 0;
				}
1828 1829 1830 1831 1832 1833 1834 1835
			}

			break;

		case OP_SRC_ADD:
			if (op->dest.reg == CFI_SP && op->src.reg == CFI_SP) {

				/* add imm, %rsp */
1836
				cfi->stack_size -= op->src.offset;
1837 1838 1839 1840 1841 1842 1843 1844
				if (cfa->base == CFI_SP)
					cfa->offset -= op->src.offset;
				break;
			}

			if (op->dest.reg == CFI_SP && op->src.reg == CFI_BP) {

				/* lea disp(%rbp), %rsp */
1845
				cfi->stack_size = -(op->src.offset + regs[CFI_BP].offset);
1846 1847 1848
				break;
			}

1849
			if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {
1850 1851

				/* drap: lea disp(%rsp), %drap */
1852
				cfi->drap_reg = op->dest.reg;
1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863

				/*
				 * lea disp(%rsp), %reg
				 *
				 * This is needed for the rare case where GCC
				 * does something dumb like:
				 *
				 *   lea    0x8(%rsp), %rcx
				 *   ...
				 *   mov    %rcx, %rsp
				 */
1864 1865 1866
				cfi->vals[op->dest.reg].base = CFI_CFA;
				cfi->vals[op->dest.reg].offset = \
					-cfi->stack_size + op->src.offset;
1867

1868 1869 1870
				break;
			}

1871 1872
			if (cfi->drap && op->dest.reg == CFI_SP &&
			    op->src.reg == cfi->drap_reg) {
1873 1874 1875

				 /* drap: lea disp(%drap), %rsp */
				cfa->base = CFI_SP;
1876 1877 1878
				cfa->offset = cfi->stack_size = -op->src.offset;
				cfi->drap_reg = CFI_UNDEFINED;
				cfi->drap = false;
1879 1880 1881
				break;
			}

1882
			if (op->dest.reg == cfi->cfa.base) {
1883 1884 1885 1886 1887 1888 1889 1890 1891
				WARN_FUNC("unsupported stack register modification",
					  insn->sec, insn->offset);
				return -1;
			}

			break;

		case OP_SRC_AND:
			if (op->dest.reg != CFI_SP ||
1892 1893
			    (cfi->drap_reg != CFI_UNDEFINED && cfa->base != CFI_SP) ||
			    (cfi->drap_reg == CFI_UNDEFINED && cfa->base != CFI_BP)) {
1894 1895 1896 1897 1898
				WARN_FUNC("unsupported stack pointer realignment",
					  insn->sec, insn->offset);
				return -1;
			}

1899
			if (cfi->drap_reg != CFI_UNDEFINED) {
1900
				/* drap: and imm, %rsp */
1901 1902 1903
				cfa->base = cfi->drap_reg;
				cfa->offset = cfi->stack_size = 0;
				cfi->drap = true;
1904 1905 1906 1907 1908 1909 1910 1911 1912 1913
			}

			/*
			 * Older versions of GCC (4.8ish) realign the stack
			 * without DRAP, with a frame pointer.
			 */

			break;

		case OP_SRC_POP:
P
Peter Zijlstra 已提交
1914
		case OP_SRC_POPF:
1915
			if (!cfi->drap && op->dest.reg == cfa->base) {
1916 1917 1918 1919 1920

				/* pop %rbp */
				cfa->base = CFI_SP;
			}

1921 1922 1923
			if (cfi->drap && cfa->base == CFI_BP_INDIRECT &&
			    op->dest.reg == cfi->drap_reg &&
			    cfi->drap_offset == -cfi->stack_size) {
1924

1925
				/* drap: pop %drap */
1926
				cfa->base = cfi->drap_reg;
1927
				cfa->offset = 0;
1928
				cfi->drap_offset = -1;
1929

1930
			} else if (regs[op->dest.reg].offset == -cfi->stack_size) {
1931

1932
				/* pop %reg */
1933
				restore_reg(cfi, op->dest.reg);
1934 1935
			}

1936
			cfi->stack_size -= 8;
1937 1938 1939 1940 1941 1942
			if (cfa->base == CFI_SP)
				cfa->offset -= 8;

			break;

		case OP_SRC_REG_INDIRECT:
1943 1944
			if (cfi->drap && op->src.reg == CFI_BP &&
			    op->src.offset == cfi->drap_offset) {
1945 1946

				/* drap: mov disp(%rbp), %drap */
1947
				cfa->base = cfi->drap_reg;
1948
				cfa->offset = 0;
1949
				cfi->drap_offset = -1;
1950 1951
			}

1952
			if (cfi->drap && op->src.reg == CFI_BP &&
1953 1954 1955
			    op->src.offset == regs[op->dest.reg].offset) {

				/* drap: mov disp(%rbp), %reg */
1956
				restore_reg(cfi, op->dest.reg);
1957 1958 1959 1960 1961 1962

			} else if (op->src.reg == cfa->base &&
			    op->src.offset == regs[op->dest.reg].offset + cfa->offset) {

				/* mov disp(%rbp), %reg */
				/* mov disp(%rsp), %reg */
1963
				restore_reg(cfi, op->dest.reg);
1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976
			}

			break;

		default:
			WARN_FUNC("unknown stack-related instruction",
				  insn->sec, insn->offset);
			return -1;
		}

		break;

	case OP_DEST_PUSH:
P
Peter Zijlstra 已提交
1977
	case OP_DEST_PUSHF:
1978
		cfi->stack_size += 8;
1979 1980 1981 1982 1983 1984
		if (cfa->base == CFI_SP)
			cfa->offset += 8;

		if (op->src.type != OP_SRC_REG)
			break;

1985 1986
		if (cfi->drap) {
			if (op->src.reg == cfa->base && op->src.reg == cfi->drap_reg) {
1987 1988 1989

				/* drap: push %drap */
				cfa->base = CFI_BP_INDIRECT;
1990
				cfa->offset = -cfi->stack_size;
1991

1992
				/* save drap so we know when to restore it */
1993
				cfi->drap_offset = -cfi->stack_size;
1994

1995
			} else if (op->src.reg == CFI_BP && cfa->base == cfi->drap_reg) {
1996 1997

				/* drap: push %rbp */
1998
				cfi->stack_size = 0;
1999 2000 2001 2002

			} else if (regs[op->src.reg].base == CFI_UNDEFINED) {

				/* drap: push %reg */
2003
				save_reg(cfi, op->src.reg, CFI_BP, -cfi->stack_size);
2004 2005 2006 2007 2008
			}

		} else {

			/* push %reg */
2009
			save_reg(cfi, op->src.reg, CFI_CFA, -cfi->stack_size);
2010 2011 2012
		}

		/* detect when asm code uses rbp as a scratch register */
2013
		if (!no_fp && insn->func && op->src.reg == CFI_BP &&
2014
		    cfa->base != CFI_BP)
2015
			cfi->bp_scratch = true;
2016 2017 2018 2019
		break;

	case OP_DEST_REG_INDIRECT:

2020 2021
		if (cfi->drap) {
			if (op->src.reg == cfa->base && op->src.reg == cfi->drap_reg) {
2022 2023 2024 2025 2026

				/* drap: mov %drap, disp(%rbp) */
				cfa->base = CFI_BP_INDIRECT;
				cfa->offset = op->dest.offset;

2027
				/* save drap offset so we know when to restore it */
2028
				cfi->drap_offset = op->dest.offset;
2029 2030 2031 2032 2033
			}

			else if (regs[op->src.reg].base == CFI_UNDEFINED) {

				/* drap: mov reg, disp(%rbp) */
2034
				save_reg(cfi, op->src.reg, CFI_BP, op->dest.offset);
2035 2036 2037 2038 2039 2040
			}

		} else if (op->dest.reg == cfa->base) {

			/* mov reg, disp(%rbp) */
			/* mov reg, disp(%rsp) */
2041 2042
			save_reg(cfi, op->src.reg, CFI_CFA,
				 op->dest.offset - cfi->cfa.offset);
2043 2044 2045 2046 2047
		}

		break;

	case OP_DEST_LEAVE:
2048 2049
		if ((!cfi->drap && cfa->base != CFI_BP) ||
		    (cfi->drap && cfa->base != cfi->drap_reg)) {
2050 2051 2052 2053 2054 2055 2056
			WARN_FUNC("leave instruction with modified stack frame",
				  insn->sec, insn->offset);
			return -1;
		}

		/* leave (mov %rbp, %rsp; pop %rbp) */

2057 2058
		cfi->stack_size = -cfi->regs[CFI_BP].offset - 8;
		restore_reg(cfi, CFI_BP);
2059

2060
		if (!cfi->drap) {
2061 2062 2063 2064 2065 2066 2067
			cfa->base = CFI_SP;
			cfa->offset -= 8;
		}

		break;

	case OP_DEST_MEM:
P
Peter Zijlstra 已提交
2068
		if (op->src.type != OP_SRC_POP && op->src.type != OP_SRC_POPF) {
2069 2070 2071 2072 2073 2074
			WARN_FUNC("unknown stack-related memory operation",
				  insn->sec, insn->offset);
			return -1;
		}

		/* pop mem */
2075
		cfi->stack_size -= 8;
2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089
		if (cfa->base == CFI_SP)
			cfa->offset -= 8;

		break;

	default:
		WARN_FUNC("unknown stack-related instruction",
			  insn->sec, insn->offset);
		return -1;
	}

	return 0;
}

2090 2091 2092 2093 2094
static int handle_insn_ops(struct instruction *insn, struct insn_state *state)
{
	struct stack_op *op;

	list_for_each_entry(op, &insn->stack_ops, list) {
2095
		struct cfi_state old_cfi = state->cfi;
2096 2097
		int res;

2098
		res = update_cfi_state(insn, &state->cfi, op);
2099 2100 2101
		if (res)
			return res;

2102 2103 2104 2105 2106
		if (insn->alt_group && memcmp(&state->cfi, &old_cfi, sizeof(struct cfi_state))) {
			WARN_FUNC("alternative modifies stack", insn->sec, insn->offset);
			return -1;
		}

2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131
		if (op->dest.type == OP_DEST_PUSHF) {
			if (!state->uaccess_stack) {
				state->uaccess_stack = 1;
			} else if (state->uaccess_stack >> 31) {
				WARN_FUNC("PUSHF stack exhausted",
					  insn->sec, insn->offset);
				return 1;
			}
			state->uaccess_stack <<= 1;
			state->uaccess_stack  |= state->uaccess;
		}

		if (op->src.type == OP_SRC_POPF) {
			if (state->uaccess_stack) {
				state->uaccess = state->uaccess_stack & 1;
				state->uaccess_stack >>= 1;
				if (state->uaccess_stack == 1)
					state->uaccess_stack = 0;
			}
		}
	}

	return 0;
}

2132
static bool insn_cfi_match(struct instruction *insn, struct cfi_state *cfi2)
2133
{
2134
	struct cfi_state *cfi1 = &insn->cfi;
2135 2136
	int i;

2137 2138
	if (memcmp(&cfi1->cfa, &cfi2->cfa, sizeof(cfi1->cfa))) {

2139 2140
		WARN_FUNC("stack state mismatch: cfa1=%d%+d cfa2=%d%+d",
			  insn->sec, insn->offset,
2141 2142
			  cfi1->cfa.base, cfi1->cfa.offset,
			  cfi2->cfa.base, cfi2->cfa.offset);
2143

2144
	} else if (memcmp(&cfi1->regs, &cfi2->regs, sizeof(cfi1->regs))) {
2145
		for (i = 0; i < CFI_NUM_REGS; i++) {
2146
			if (!memcmp(&cfi1->regs[i], &cfi2->regs[i],
2147 2148 2149 2150 2151
				    sizeof(struct cfi_reg)))
				continue;

			WARN_FUNC("stack state mismatch: reg1[%d]=%d%+d reg2[%d]=%d%+d",
				  insn->sec, insn->offset,
2152 2153
				  i, cfi1->regs[i].base, cfi1->regs[i].offset,
				  i, cfi2->regs[i].base, cfi2->regs[i].offset);
2154 2155 2156
			break;
		}

2157 2158
	} else if (cfi1->type != cfi2->type) {

2159
		WARN_FUNC("stack state mismatch: type1=%d type2=%d",
2160 2161 2162 2163 2164
			  insn->sec, insn->offset, cfi1->type, cfi2->type);

	} else if (cfi1->drap != cfi2->drap ||
		   (cfi1->drap && cfi1->drap_reg != cfi2->drap_reg) ||
		   (cfi1->drap && cfi1->drap_offset != cfi2->drap_offset)) {
2165

2166
		WARN_FUNC("stack state mismatch: drap1=%d(%d,%d) drap2=%d(%d,%d)",
2167
			  insn->sec, insn->offset,
2168 2169
			  cfi1->drap, cfi1->drap_reg, cfi1->drap_offset,
			  cfi2->drap, cfi2->drap_reg, cfi2->drap_offset);
2170 2171 2172 2173 2174

	} else
		return true;

	return false;
2175 2176
}

P
Peter Zijlstra 已提交
2177 2178 2179
static inline bool func_uaccess_safe(struct symbol *func)
{
	if (func)
2180
		return func->uaccess_safe;
P
Peter Zijlstra 已提交
2181 2182 2183 2184

	return false;
}

2185
static inline const char *call_dest_name(struct instruction *insn)
P
Peter Zijlstra 已提交
2186 2187 2188 2189 2190 2191 2192 2193 2194
{
	if (insn->call_dest)
		return insn->call_dest->name;

	return "{dynamic}";
}

static int validate_call(struct instruction *insn, struct insn_state *state)
{
2195
	if (state->noinstr && state->instr <= 0 &&
2196
	    (!insn->call_dest || !insn->call_dest->sec->noinstr)) {
2197 2198 2199 2200 2201
		WARN_FUNC("call to %s() leaves .noinstr.text section",
				insn->sec, insn->offset, call_dest_name(insn));
		return 1;
	}

P
Peter Zijlstra 已提交
2202 2203
	if (state->uaccess && !func_uaccess_safe(insn->call_dest)) {
		WARN_FUNC("call to %s() with UACCESS enabled",
2204
				insn->sec, insn->offset, call_dest_name(insn));
P
Peter Zijlstra 已提交
2205 2206 2207
		return 1;
	}

2208 2209
	if (state->df) {
		WARN_FUNC("call to %s() with DF set",
2210
				insn->sec, insn->offset, call_dest_name(insn));
2211 2212 2213
		return 1;
	}

P
Peter Zijlstra 已提交
2214 2215 2216
	return 0;
}

2217 2218
static int validate_sibling_call(struct instruction *insn, struct insn_state *state)
{
2219
	if (has_modified_stack_frame(insn, state)) {
2220 2221 2222 2223 2224
		WARN_FUNC("sibling call from callable instruction with modified stack frame",
				insn->sec, insn->offset);
		return 1;
	}

P
Peter Zijlstra 已提交
2225
	return validate_call(insn, state);
2226 2227
}

2228 2229
static int validate_return(struct symbol *func, struct instruction *insn, struct insn_state *state)
{
2230 2231 2232 2233 2234 2235
	if (state->noinstr && state->instr > 0) {
		WARN_FUNC("return with instrumentation enabled",
			  insn->sec, insn->offset);
		return 1;
	}

2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253
	if (state->uaccess && !func_uaccess_safe(func)) {
		WARN_FUNC("return with UACCESS enabled",
			  insn->sec, insn->offset);
		return 1;
	}

	if (!state->uaccess && func_uaccess_safe(func)) {
		WARN_FUNC("return with UACCESS disabled from a UACCESS-safe function",
			  insn->sec, insn->offset);
		return 1;
	}

	if (state->df) {
		WARN_FUNC("return with DF set",
			  insn->sec, insn->offset);
		return 1;
	}

2254
	if (func && has_modified_stack_frame(insn, state)) {
2255 2256 2257 2258 2259
		WARN_FUNC("return with modified stack frame",
			  insn->sec, insn->offset);
		return 1;
	}

2260
	if (state->cfi.bp_scratch) {
2261 2262
		WARN_FUNC("BP used as a scratch register",
			  insn->sec, insn->offset);
2263 2264 2265 2266 2267 2268
		return 1;
	}

	return 0;
}

2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292
/*
 * Alternatives should not contain any ORC entries, this in turn means they
 * should not contain any CFI ops, which implies all instructions should have
 * the same same CFI state.
 *
 * It is possible to constuct alternatives that have unreachable holes that go
 * unreported (because they're NOPs), such holes would result in CFI_UNDEFINED
 * states which then results in ORC entries, which we just said we didn't want.
 *
 * Avoid them by copying the CFI entry of the first instruction into the whole
 * alternative.
 */
static void fill_alternative_cfi(struct objtool_file *file, struct instruction *insn)
{
	struct instruction *first_insn = insn;
	int alt_group = insn->alt_group;

	sec_for_each_insn_continue(file, insn) {
		if (insn->alt_group != alt_group)
			break;
		insn->cfi = first_insn->cfi;
	}
}

2293 2294 2295 2296 2297 2298
/*
 * Follow the branch starting at the given instruction, and recursively follow
 * any other branches (jumps).  Meanwhile, track the frame pointer state at
 * each instruction and validate all the rules described in
 * tools/objtool/Documentation/stack-validation.txt.
 */
2299
static int validate_branch(struct objtool_file *file, struct symbol *func,
P
Peter Zijlstra 已提交
2300
			   struct instruction *insn, struct insn_state state)
2301 2302
{
	struct alternative *alt;
P
Peter Zijlstra 已提交
2303
	struct instruction *next_insn;
2304
	struct section *sec;
2305
	u8 visited;
2306 2307 2308 2309 2310
	int ret;

	sec = insn->sec;

	while (1) {
2311 2312
		next_insn = next_insn_same_sec(file, insn);

2313
		if (file->c_file && func && insn->func && func != insn->func->pfunc) {
2314 2315 2316
			WARN("%s() falls through to next function %s()",
			     func->name, insn->func->name);
			return 1;
2317 2318
		}

2319 2320 2321
		if (func && insn->ignore) {
			WARN_FUNC("BUG: why am I validating an ignored function?",
				  sec, insn->offset);
2322
			return 1;
2323 2324
		}

2325
		visited = 1 << state.uaccess;
2326
		if (insn->visited) {
2327
			if (!insn->hint && !insn_cfi_match(insn, &state.cfi))
2328 2329
				return 1;

2330
			if (insn->visited & visited)
P
Peter Zijlstra 已提交
2331
				return 0;
2332 2333
		}

2334 2335 2336
		if (state.noinstr)
			state.instr += insn->instr;

2337
		if (insn->hint)
2338
			state.cfi = insn->cfi;
2339
		else
2340
			insn->cfi = state.cfi;
2341

2342
		insn->visited |= visited;
2343

2344
		if (!insn->ignore_alts && !list_empty(&insn->alts)) {
P
Peter Zijlstra 已提交
2345 2346
			bool skip_orig = false;

2347
			list_for_each_entry(alt, &insn->alts, list) {
P
Peter Zijlstra 已提交
2348 2349 2350
				if (alt->skip_orig)
					skip_orig = true;

2351
				ret = validate_branch(file, func, alt->insn, state);
2352 2353 2354 2355 2356
				if (ret) {
					if (backtrace)
						BT_FUNC("(alt)", insn);
					return ret;
				}
2357
			}
P
Peter Zijlstra 已提交
2358

2359 2360 2361
			if (insn->alt_group)
				fill_alternative_cfi(file, insn);

P
Peter Zijlstra 已提交
2362 2363
			if (skip_orig)
				return 0;
2364 2365
		}

2366 2367 2368
		if (handle_insn_ops(insn, &state))
			return 1;

2369 2370 2371
		switch (insn->type) {

		case INSN_RETURN:
2372
			return validate_return(func, insn, &state);
2373 2374

		case INSN_CALL:
P
Peter Zijlstra 已提交
2375 2376 2377 2378
		case INSN_CALL_DYNAMIC:
			ret = validate_call(insn, &state);
			if (ret)
				return ret;
2379

2380 2381
			if (!no_fp && func && !is_fentry_call(insn) &&
			    !has_valid_stack_frame(&state)) {
2382 2383 2384 2385
				WARN_FUNC("call without frame pointer save/setup",
					  sec, insn->offset);
				return 1;
			}
2386 2387 2388 2389

			if (dead_end_function(file, insn->call_dest))
				return 0;

2390 2391 2392 2393
			break;

		case INSN_JUMP_CONDITIONAL:
		case INSN_JUMP_UNCONDITIONAL:
2394
			if (func && is_sibling_call(insn)) {
2395
				ret = validate_sibling_call(insn, &state);
2396
				if (ret)
2397
					return ret;
2398

2399
			} else if (insn->jump_dest) {
2400 2401
				ret = validate_branch(file, func,
						      insn->jump_dest, state);
2402 2403 2404 2405 2406
				if (ret) {
					if (backtrace)
						BT_FUNC("(branch)", insn);
					return ret;
				}
2407
			}
2408 2409 2410 2411 2412 2413 2414

			if (insn->type == INSN_JUMP_UNCONDITIONAL)
				return 0;

			break;

		case INSN_JUMP_DYNAMIC:
2415
		case INSN_JUMP_DYNAMIC_CONDITIONAL:
2416
			if (func && is_sibling_call(insn)) {
2417 2418 2419
				ret = validate_sibling_call(insn, &state);
				if (ret)
					return ret;
2420 2421
			}

2422 2423 2424 2425
			if (insn->type == INSN_JUMP_DYNAMIC)
				return 0;

			break;
2426

2427 2428 2429 2430 2431 2432 2433 2434
		case INSN_CONTEXT_SWITCH:
			if (func && (!next_insn || !next_insn->hint)) {
				WARN_FUNC("unsupported instruction in callable function",
					  sec, insn->offset);
				return 1;
			}
			return 0;

P
Peter Zijlstra 已提交
2435 2436 2437 2438 2439 2440 2441 2442 2443 2444
		case INSN_STAC:
			if (state.uaccess) {
				WARN_FUNC("recursive UACCESS enable", sec, insn->offset);
				return 1;
			}

			state.uaccess = true;
			break;

		case INSN_CLAC:
2445
			if (!state.uaccess && func) {
P
Peter Zijlstra 已提交
2446 2447 2448 2449 2450 2451 2452 2453 2454 2455
				WARN_FUNC("redundant UACCESS disable", sec, insn->offset);
				return 1;
			}

			if (func_uaccess_safe(func) && !state.uaccess_stack) {
				WARN_FUNC("UACCESS-safe disables UACCESS", sec, insn->offset);
				return 1;
			}

			state.uaccess = false;
2456 2457
			break;

2458 2459 2460 2461 2462 2463 2464 2465
		case INSN_STD:
			if (state.df)
				WARN_FUNC("recursive STD", sec, insn->offset);

			state.df = true;
			break;

		case INSN_CLD:
2466
			if (!state.df && func)
2467 2468 2469
				WARN_FUNC("redundant CLD", sec, insn->offset);

			state.df = false;
2470 2471
			break;

2472 2473 2474 2475 2476 2477 2478
		default:
			break;
		}

		if (insn->dead_end)
			return 0;

2479
		if (!next_insn) {
2480
			if (state.cfi.cfa.base == CFI_UNDEFINED)
2481
				return 0;
2482 2483 2484
			WARN("%s: unexpected end of section", sec->name);
			return 1;
		}
2485 2486

		insn = next_insn;
2487 2488 2489 2490 2491
	}

	return 0;
}

2492
static int validate_unwind_hints(struct objtool_file *file, struct section *sec)
2493 2494 2495
{
	struct instruction *insn;
	struct insn_state state;
2496
	int ret, warnings = 0;
2497 2498 2499 2500

	if (!file->hints)
		return 0;

2501
	init_insn_state(&state, sec);
2502

2503 2504 2505 2506 2507 2508 2509 2510 2511
	if (sec) {
		insn = find_insn(file, sec, 0);
		if (!insn)
			return 0;
	} else {
		insn = list_first_entry(&file->insn_list, typeof(*insn), list);
	}

	while (&insn->list != &file->insn_list && (!sec || insn->sec == sec)) {
2512
		if (insn->hint && !insn->visited) {
2513
			ret = validate_branch(file, insn->func, insn, state);
2514 2515
			if (ret && backtrace)
				BT_FUNC("<=== (hint)", insn);
2516 2517
			warnings += ret;
		}
2518 2519

		insn = list_next_entry(insn, list);
2520 2521 2522 2523 2524
	}

	return warnings;
}

2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537
static int validate_retpoline(struct objtool_file *file)
{
	struct instruction *insn;
	int warnings = 0;

	for_each_insn(file, insn) {
		if (insn->type != INSN_JUMP_DYNAMIC &&
		    insn->type != INSN_CALL_DYNAMIC)
			continue;

		if (insn->retpoline_safe)
			continue;

2538 2539 2540 2541 2542 2543 2544 2545 2546
		/*
		 * .init.text code is ran before userspace and thus doesn't
		 * strictly need retpolines, except for modules which are
		 * loaded late, they very much do need retpoline in their
		 * .init.text
		 */
		if (!strcmp(insn->sec->name, ".init.text") && !module)
			continue;

2547 2548 2549 2550 2551 2552 2553 2554 2555 2556
		WARN_FUNC("indirect %s found in RETPOLINE build",
			  insn->sec, insn->offset,
			  insn->type == INSN_JUMP_DYNAMIC ? "jump" : "call");

		warnings++;
	}

	return warnings;
}

2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569
static bool is_kasan_insn(struct instruction *insn)
{
	return (insn->type == INSN_CALL &&
		!strcmp(insn->call_dest->name, "__asan_handle_no_return"));
}

static bool is_ubsan_insn(struct instruction *insn)
{
	return (insn->type == INSN_CALL &&
		!strcmp(insn->call_dest->name,
			"__ubsan_handle_builtin_unreachable"));
}

2570
static bool ignore_unreachable_insn(struct instruction *insn)
2571 2572 2573
{
	int i;

2574 2575 2576 2577 2578 2579
	if (insn->ignore || insn->type == INSN_NOP)
		return true;

	/*
	 * Ignore any unused exceptions.  This can happen when a whitelisted
	 * function has an exception table entry.
2580 2581 2582
	 *
	 * Also ignore alternative replacement instructions.  This can happen
	 * when a whitelisted function uses one of the ALTERNATIVE macros.
2583
	 */
2584 2585 2586
	if (!strcmp(insn->sec->name, ".fixup") ||
	    !strcmp(insn->sec->name, ".altinstr_replacement") ||
	    !strcmp(insn->sec->name, ".altinstr_aux"))
2587 2588
		return true;

2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603
	if (!insn->func)
		return false;

	/*
	 * CONFIG_UBSAN_TRAP inserts a UD2 when it sees
	 * __builtin_unreachable().  The BUG() macro has an unreachable() after
	 * the UD2, which causes GCC's undefined trap logic to emit another UD2
	 * (or occasionally a JMP to UD2).
	 */
	if (list_prev_entry(insn, list)->dead_end &&
	    (insn->type == INSN_BUG ||
	     (insn->type == INSN_JUMP_UNCONDITIONAL &&
	      insn->jump_dest && insn->jump_dest->type == INSN_BUG)))
		return true;

2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614
	/*
	 * Check if this (or a subsequent) instruction is related to
	 * CONFIG_UBSAN or CONFIG_KASAN.
	 *
	 * End the search at 5 instructions to avoid going into the weeds.
	 */
	for (i = 0; i < 5; i++) {

		if (is_kasan_insn(insn) || is_ubsan_insn(insn))
			return true;

2615 2616 2617 2618 2619 2620 2621 2622
		if (insn->type == INSN_JUMP_UNCONDITIONAL) {
			if (insn->jump_dest &&
			    insn->jump_dest->func == insn->func) {
				insn = insn->jump_dest;
				continue;
			}

			break;
2623 2624
		}

2625
		if (insn->offset + insn->len >= insn->func->offset + insn->func->len)
2626
			break;
2627

2628 2629 2630 2631 2632 2633
		insn = list_next_entry(insn, list);
	}

	return false;
}

2634 2635
static int validate_symbol(struct objtool_file *file, struct section *sec,
			   struct symbol *sym, struct insn_state *state)
2636 2637
{
	struct instruction *insn;
2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661
	int ret;

	if (!sym->len) {
		WARN("%s() is missing an ELF size annotation", sym->name);
		return 1;
	}

	if (sym->pfunc != sym || sym->alias != sym)
		return 0;

	insn = find_insn(file, sec, sym->offset);
	if (!insn || insn->ignore || insn->visited)
		return 0;

	state->uaccess = sym->uaccess_safe;

	ret = validate_branch(file, insn->func, insn, *state);
	if (ret && backtrace)
		BT_FUNC("<=== (sym)", insn);
	return ret;
}

static int validate_section(struct objtool_file *file, struct section *sec)
{
2662
	struct insn_state state;
2663 2664
	struct symbol *func;
	int warnings = 0;
2665

2666 2667 2668
	list_for_each_entry(func, &sec->symbol_list, list) {
		if (func->type != STT_FUNC)
			continue;
2669

2670
		init_insn_state(&state, sec);
2671 2672
		state.cfi.cfa = initial_func_cfi.cfa;
		memcpy(&state.cfi.regs, &initial_func_cfi.regs,
2673
		       CFI_NUM_REGS * sizeof(struct cfi_reg));
2674
		state.cfi.stack_size = initial_func_cfi.cfa.offset;
2675

2676
		warnings += validate_symbol(file, sec, func, &state);
2677 2678 2679 2680 2681
	}

	return warnings;
}

2682 2683 2684
static int validate_vmlinux_functions(struct objtool_file *file)
{
	struct section *sec;
2685
	int warnings = 0;
2686 2687

	sec = find_section_by_name(file->elf, ".noinstr.text");
2688 2689 2690 2691
	if (sec) {
		warnings += validate_section(file, sec);
		warnings += validate_unwind_hints(file, sec);
	}
2692

2693 2694 2695 2696 2697
	sec = find_section_by_name(file->elf, ".entry.text");
	if (sec) {
		warnings += validate_section(file, sec);
		warnings += validate_unwind_hints(file, sec);
	}
2698 2699

	return warnings;
2700 2701
}

2702 2703 2704 2705 2706
static int validate_functions(struct objtool_file *file)
{
	struct section *sec;
	int warnings = 0;

2707 2708 2709 2710
	for_each_sec(file, sec) {
		if (!(sec->sh.sh_flags & SHF_EXECINSTR))
			continue;

2711
		warnings += validate_section(file, sec);
2712
	}
2713 2714 2715 2716

	return warnings;
}

2717
static int validate_reachable_instructions(struct objtool_file *file)
2718 2719
{
	struct instruction *insn;
2720 2721 2722

	if (file->ignore_unreachables)
		return 0;
2723 2724

	for_each_insn(file, insn) {
2725 2726 2727 2728 2729
		if (insn->visited || ignore_unreachable_insn(insn))
			continue;

		WARN_FUNC("unreachable instruction", insn->sec, insn->offset);
		return 1;
2730 2731
	}

2732
	return 0;
2733 2734
}

2735 2736
static struct objtool_file file;

2737
int check(const char *_objname, bool orc)
2738 2739 2740 2741 2742
{
	int ret, warnings = 0;

	objname = _objname;

2743
	file.elf = elf_open_read(objname, orc ? O_RDWR : O_RDONLY);
2744
	if (!file.elf)
2745 2746 2747 2748 2749
		return 1;

	INIT_LIST_HEAD(&file.insn_list);
	hash_init(file.insn_hash);
	file.c_file = find_section_by_name(file.elf, ".comment");
2750
	file.ignore_unreachables = no_unreachable;
2751
	file.hints = false;
2752

2753 2754
	arch_initial_func_cfi_state(&initial_func_cfi);

2755 2756 2757 2758 2759
	ret = decode_sections(&file);
	if (ret < 0)
		goto out;
	warnings += ret;

2760
	if (list_empty(&file.insn_list))
2761 2762
		goto out;

2763 2764 2765 2766 2767 2768 2769 2770 2771
	if (vmlinux && !validate_dup) {
		ret = validate_vmlinux_functions(&file);
		if (ret < 0)
			goto out;

		warnings += ret;
		goto out;
	}

2772 2773 2774 2775 2776 2777 2778
	if (retpoline) {
		ret = validate_retpoline(&file);
		if (ret < 0)
			return ret;
		warnings += ret;
	}

2779
	ret = validate_functions(&file);
2780 2781 2782 2783
	if (ret < 0)
		goto out;
	warnings += ret;

2784
	ret = validate_unwind_hints(&file, NULL);
2785 2786 2787 2788
	if (ret < 0)
		goto out;
	warnings += ret;

2789 2790 2791 2792 2793 2794 2795
	if (!warnings) {
		ret = validate_reachable_instructions(&file);
		if (ret < 0)
			goto out;
		warnings += ret;
	}

2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809
	if (orc) {
		ret = create_orc(&file);
		if (ret < 0)
			goto out;

		ret = create_orc_sections(&file);
		if (ret < 0)
			goto out;

		ret = elf_write(file.elf);
		if (ret < 0)
			goto out;
	}

2810
out:
2811 2812 2813 2814 2815 2816 2817 2818 2819
	if (ret < 0) {
		/*
		 *  Fatal error.  The binary is corrupt or otherwise broken in
		 *  some way, or objtool itself is broken.  Fail the kernel
		 *  build.
		 */
		return ret;
	}

2820 2821
	return 0;
}