check.c 60.5 KB
Newer Older
1
// SPDX-License-Identifier: GPL-2.0-or-later
2 3 4 5 6 7 8
/*
 * Copyright (C) 2015-2017 Josh Poimboeuf <jpoimboe@redhat.com>
 */

#include <string.h>
#include <stdlib.h>

9
#include "builtin.h"
10 11 12 13 14 15 16 17 18
#include "check.h"
#include "elf.h"
#include "special.h"
#include "arch.h"
#include "warn.h"

#include <linux/hashtable.h>
#include <linux/kernel.h>

19 20
#define FAKE_JUMP_OFFSET -1

21 22
#define C_JUMP_TABLE_SECTION ".rodata..c_jump_table"

23 24 25
struct alternative {
	struct list_head list;
	struct instruction *insn;
P
Peter Zijlstra 已提交
26
	bool skip_orig;
27 28 29
};

const char *objname;
30
struct cfi_state initial_func_cfi;
31

32 33
struct instruction *find_insn(struct objtool_file *file,
			      struct section *sec, unsigned long offset)
34 35 36 37 38 39 40 41 42 43 44 45 46 47 48
{
	struct instruction *insn;

	hash_for_each_possible(file->insn_hash, insn, hash, offset)
		if (insn->sec == sec && insn->offset == offset)
			return insn;

	return NULL;
}

static struct instruction *next_insn_same_sec(struct objtool_file *file,
					      struct instruction *insn)
{
	struct instruction *next = list_next_entry(insn, list);

49
	if (!next || &next->list == &file->insn_list || next->sec != insn->sec)
50 51 52 53 54
		return NULL;

	return next;
}

55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74
static struct instruction *next_insn_same_func(struct objtool_file *file,
					       struct instruction *insn)
{
	struct instruction *next = list_next_entry(insn, list);
	struct symbol *func = insn->func;

	if (!func)
		return NULL;

	if (&next->list != &file->insn_list && next->func == func)
		return next;

	/* Check if we're already in the subfunction: */
	if (func == func->cfunc)
		return NULL;

	/* Move to the subfunction: */
	return find_insn(file, func->cfunc->sec, func->cfunc->offset);
}

75
#define func_for_each_insn(file, func, insn)				\
76 77 78 79
	for (insn = find_insn(file, func->sec, func->offset);		\
	     insn;							\
	     insn = next_insn_same_func(file, insn))

80 81
#define sym_for_each_insn(file, sym, insn)				\
	for (insn = find_insn(file, sym->sec, sym->offset);		\
82
	     insn && &insn->list != &file->insn_list &&			\
83 84
		insn->sec == sym->sec &&				\
		insn->offset < sym->offset + sym->len;			\
85 86
	     insn = list_next_entry(insn, list))

87
#define sym_for_each_insn_continue_reverse(file, sym, insn)		\
88 89
	for (insn = list_prev_entry(insn, list);			\
	     &insn->list != &file->insn_list &&				\
90
		insn->sec == sym->sec && insn->offset >= sym->offset;	\
91 92 93 94 95
	     insn = list_prev_entry(insn, list))

#define sec_for_each_insn_from(file, insn)				\
	for (; insn; insn = next_insn_same_sec(file, insn))

96 97 98
#define sec_for_each_insn_continue(file, insn)				\
	for (insn = next_insn_same_sec(file, insn); insn;		\
	     insn = next_insn_same_sec(file, insn))
99

100 101 102 103 104 105
static bool is_static_jump(struct instruction *insn)
{
	return insn->type == INSN_JUMP_CONDITIONAL ||
	       insn->type == INSN_JUMP_UNCONDITIONAL;
}

106 107 108 109 110 111
static bool is_sibling_call(struct instruction *insn)
{
	/* An indirect jump is either a sibling call or a jump to a table. */
	if (insn->type == INSN_JUMP_DYNAMIC)
		return list_empty(&insn->alts);

112
	if (!is_static_jump(insn))
113 114 115 116 117 118
		return false;

	/* add_jump_destinations() sets insn->call_dest for sibling calls. */
	return !!insn->call_dest;
}

119 120 121 122 123 124 125 126 127
/*
 * This checks to see if the given function is a "noreturn" function.
 *
 * For global functions which are outside the scope of this object file, we
 * have to keep a manual list of them.
 *
 * For local functions, we have to detect them manually by simply looking for
 * the lack of a return instruction.
 */
128 129
static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
				int recursion)
130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148
{
	int i;
	struct instruction *insn;
	bool empty = true;

	/*
	 * Unfortunately these have to be hard coded because the noreturn
	 * attribute isn't provided in ELF data.
	 */
	static const char * const global_noreturns[] = {
		"__stack_chk_fail",
		"panic",
		"do_exit",
		"do_task_dead",
		"__module_put_and_exit",
		"complete_and_exit",
		"__reiserfs_panic",
		"lbug_with_loc",
		"fortify_panic",
149
		"usercopy_abort",
150
		"machine_real_restart",
151
		"rewind_stack_do_exit",
152
		"kunit_try_catch_throw",
153 154
	};

155 156 157
	if (!func)
		return false;

158
	if (func->bind == STB_WEAK)
159
		return false;
160 161 162 163

	if (func->bind == STB_GLOBAL)
		for (i = 0; i < ARRAY_SIZE(global_noreturns); i++)
			if (!strcmp(func->name, global_noreturns[i]))
164
				return true;
165

166
	if (!func->len)
167
		return false;
168

169 170
	insn = find_insn(file, func->sec, func->offset);
	if (!insn->func)
171
		return false;
172

173
	func_for_each_insn(file, func, insn) {
174 175 176
		empty = false;

		if (insn->type == INSN_RETURN)
177
			return false;
178 179 180
	}

	if (empty)
181
		return false;
182 183 184 185 186 187

	/*
	 * A function can have a sibling call instead of a return.  In that
	 * case, the function's dead-end status depends on whether the target
	 * of the sibling call returns.
	 */
188
	func_for_each_insn(file, func, insn) {
189
		if (is_sibling_call(insn)) {
190 191 192 193
			struct instruction *dest = insn->jump_dest;

			if (!dest)
				/* sibling call to another file */
194
				return false;
195

196 197 198 199 200 201 202 203
			/* local sibling call */
			if (recursion == 5) {
				/*
				 * Infinite recursion: two functions have
				 * sibling calls to each other.  This is a very
				 * rare case.  It means they aren't dead ends.
				 */
				return false;
204 205
			}

206 207
			return __dead_end_function(file, dest->func, recursion+1);
		}
208 209
	}

210
	return true;
211 212
}

213
static bool dead_end_function(struct objtool_file *file, struct symbol *func)
214 215 216 217
{
	return __dead_end_function(file, func, 0);
}

218 219 220 221 222 223
static void clear_insn_state(struct insn_state *state)
{
	int i;

	memset(state, 0, sizeof(*state));
	state->cfa.base = CFI_UNDEFINED;
224
	for (i = 0; i < CFI_NUM_REGS; i++) {
225
		state->regs[i].base = CFI_UNDEFINED;
226 227
		state->vals[i].base = CFI_UNDEFINED;
	}
228
	state->drap_reg = CFI_UNDEFINED;
229
	state->drap_offset = -1;
230 231
}

232 233 234 235 236 237 238 239 240 241
/*
 * Call the arch-specific instruction decoder for all the instructions and add
 * them to the global instruction list.
 */
static int decode_instructions(struct objtool_file *file)
{
	struct section *sec;
	struct symbol *func;
	unsigned long offset;
	struct instruction *insn;
P
Peter Zijlstra 已提交
242
	unsigned long nr_insns = 0;
243 244
	int ret;

245
	for_each_sec(file, sec) {
246 247 248 249

		if (!(sec->sh.sh_flags & SHF_EXECINSTR))
			continue;

250 251 252 253 254
		if (strcmp(sec->name, ".altinstr_replacement") &&
		    strcmp(sec->name, ".altinstr_aux") &&
		    strncmp(sec->name, ".discard.", 9))
			sec->text = true;

255 256
		for (offset = 0; offset < sec->len; offset += insn->len) {
			insn = malloc(sizeof(*insn));
257 258 259 260
			if (!insn) {
				WARN("malloc failed");
				return -1;
			}
261 262
			memset(insn, 0, sizeof(*insn));
			INIT_LIST_HEAD(&insn->alts);
263 264
			clear_insn_state(&insn->state);

265 266 267 268 269 270
			insn->sec = sec;
			insn->offset = offset;

			ret = arch_decode_instruction(file->elf, sec, offset,
						      sec->len - offset,
						      &insn->len, &insn->type,
271 272
						      &insn->immediate,
						      &insn->stack_op);
273
			if (ret)
274
				goto err;
275 276 277

			hash_add(file->insn_hash, &insn->hash, insn->offset);
			list_add_tail(&insn->list, &file->insn_list);
P
Peter Zijlstra 已提交
278
			nr_insns++;
279 280 281
		}

		list_for_each_entry(func, &sec->symbol_list, list) {
282
			if (func->type != STT_FUNC || func->alias != func)
283 284 285 286 287 288 289 290
				continue;

			if (!find_insn(file, sec, func->offset)) {
				WARN("%s(): can't find starting instruction",
				     func->name);
				return -1;
			}

291
			sym_for_each_insn(file, func, insn)
292
				insn->func = func;
293 294 295
		}
	}

P
Peter Zijlstra 已提交
296 297 298
	if (stats)
		printf("nr_insns: %lu\n", nr_insns);

299
	return 0;
300 301 302 303

err:
	free(insn);
	return ret;
304 305 306
}

/*
307
 * Mark "ud2" instructions and manually annotated dead ends.
308 309 310 311 312 313 314 315
 */
static int add_dead_ends(struct objtool_file *file)
{
	struct section *sec;
	struct rela *rela;
	struct instruction *insn;
	bool found;

316 317 318 319 320 321 322 323 324 325 326
	/*
	 * By default, "ud2" is a dead end unless otherwise annotated, because
	 * GCC 7 inserts it for certain divide-by-zero cases.
	 */
	for_each_insn(file, insn)
		if (insn->type == INSN_BUG)
			insn->dead_end = true;

	/*
	 * Check for manually annotated dead ends.
	 */
327 328
	sec = find_section_by_name(file->elf, ".rela.discard.unreachable");
	if (!sec)
329
		goto reachable;
330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361

	list_for_each_entry(rela, &sec->rela_list, list) {
		if (rela->sym->type != STT_SECTION) {
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}
		insn = find_insn(file, rela->sym->sec, rela->addend);
		if (insn)
			insn = list_prev_entry(insn, list);
		else if (rela->addend == rela->sym->sec->len) {
			found = false;
			list_for_each_entry_reverse(insn, &file->insn_list, list) {
				if (insn->sec == rela->sym->sec) {
					found = true;
					break;
				}
			}

			if (!found) {
				WARN("can't find unreachable insn at %s+0x%x",
				     rela->sym->sec->name, rela->addend);
				return -1;
			}
		} else {
			WARN("can't find unreachable insn at %s+0x%x",
			     rela->sym->sec->name, rela->addend);
			return -1;
		}

		insn->dead_end = true;
	}

362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403
reachable:
	/*
	 * These manually annotated reachable checks are needed for GCC 4.4,
	 * where the Linux unreachable() macro isn't supported.  In that case
	 * GCC doesn't know the "ud2" is fatal, so it generates code as if it's
	 * not a dead end.
	 */
	sec = find_section_by_name(file->elf, ".rela.discard.reachable");
	if (!sec)
		return 0;

	list_for_each_entry(rela, &sec->rela_list, list) {
		if (rela->sym->type != STT_SECTION) {
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}
		insn = find_insn(file, rela->sym->sec, rela->addend);
		if (insn)
			insn = list_prev_entry(insn, list);
		else if (rela->addend == rela->sym->sec->len) {
			found = false;
			list_for_each_entry_reverse(insn, &file->insn_list, list) {
				if (insn->sec == rela->sym->sec) {
					found = true;
					break;
				}
			}

			if (!found) {
				WARN("can't find reachable insn at %s+0x%x",
				     rela->sym->sec->name, rela->addend);
				return -1;
			}
		} else {
			WARN("can't find reachable insn at %s+0x%x",
			     rela->sym->sec->name, rela->addend);
			return -1;
		}

		insn->dead_end = false;
	}

404 405 406 407 408 409 410 411 412 413 414
	return 0;
}

/*
 * Warnings shouldn't be reported for ignored functions.
 */
static void add_ignores(struct objtool_file *file)
{
	struct instruction *insn;
	struct section *sec;
	struct symbol *func;
P
Peter Zijlstra 已提交
415
	struct rela *rela;
416

P
Peter Zijlstra 已提交
417 418 419
	sec = find_section_by_name(file->elf, ".rela.discard.func_stack_frame_non_standard");
	if (!sec)
		return;
420

P
Peter Zijlstra 已提交
421 422 423 424 425 426 427
	list_for_each_entry(rela, &sec->rela_list, list) {
		switch (rela->sym->type) {
		case STT_FUNC:
			func = rela->sym;
			break;

		case STT_SECTION:
428 429
			func = find_func_by_offset(rela->sym->sec, rela->addend);
			if (!func)
430
				continue;
P
Peter Zijlstra 已提交
431
			break;
432

P
Peter Zijlstra 已提交
433 434 435
		default:
			WARN("unexpected relocation symbol type in %s: %d", sec->name, rela->sym->type);
			continue;
436
		}
P
Peter Zijlstra 已提交
437

438
		func_for_each_insn(file, func, insn)
P
Peter Zijlstra 已提交
439
			insn->ignore = true;
440 441 442
	}
}

P
Peter Zijlstra 已提交
443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490
/*
 * This is a whitelist of functions that is allowed to be called with AC set.
 * The list is meant to be minimal and only contains compiler instrumentation
 * ABI and a few functions used to implement *_{to,from}_user() functions.
 *
 * These functions must not directly change AC, but may PUSHF/POPF.
 */
static const char *uaccess_safe_builtin[] = {
	/* KASAN */
	"kasan_report",
	"check_memory_region",
	/* KASAN out-of-line */
	"__asan_loadN_noabort",
	"__asan_load1_noabort",
	"__asan_load2_noabort",
	"__asan_load4_noabort",
	"__asan_load8_noabort",
	"__asan_load16_noabort",
	"__asan_storeN_noabort",
	"__asan_store1_noabort",
	"__asan_store2_noabort",
	"__asan_store4_noabort",
	"__asan_store8_noabort",
	"__asan_store16_noabort",
	/* KASAN in-line */
	"__asan_report_load_n_noabort",
	"__asan_report_load1_noabort",
	"__asan_report_load2_noabort",
	"__asan_report_load4_noabort",
	"__asan_report_load8_noabort",
	"__asan_report_load16_noabort",
	"__asan_report_store_n_noabort",
	"__asan_report_store1_noabort",
	"__asan_report_store2_noabort",
	"__asan_report_store4_noabort",
	"__asan_report_store8_noabort",
	"__asan_report_store16_noabort",
	/* KCOV */
	"write_comp_data",
	"__sanitizer_cov_trace_pc",
	"__sanitizer_cov_trace_const_cmp1",
	"__sanitizer_cov_trace_const_cmp2",
	"__sanitizer_cov_trace_const_cmp4",
	"__sanitizer_cov_trace_const_cmp8",
	"__sanitizer_cov_trace_cmp1",
	"__sanitizer_cov_trace_cmp2",
	"__sanitizer_cov_trace_cmp4",
	"__sanitizer_cov_trace_cmp8",
491
	"__sanitizer_cov_trace_switch",
P
Peter Zijlstra 已提交
492 493 494 495
	/* UBSAN */
	"ubsan_type_mismatch_common",
	"__ubsan_handle_type_mismatch",
	"__ubsan_handle_type_mismatch_v1",
496
	"__ubsan_handle_shift_out_of_bounds",
P
Peter Zijlstra 已提交
497 498 499
	/* misc */
	"csum_partial_copy_generic",
	"__memcpy_mcsafe",
500
	"mcsafe_handle_tail",
P
Peter Zijlstra 已提交
501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517
	"ftrace_likely_update", /* CONFIG_TRACE_BRANCH_PROFILING */
	NULL
};

static void add_uaccess_safe(struct objtool_file *file)
{
	struct symbol *func;
	const char **name;

	if (!uaccess)
		return;

	for (name = uaccess_safe_builtin; *name; name++) {
		func = find_symbol_by_name(file->elf, *name);
		if (!func)
			continue;

518
		func->uaccess_safe = true;
519 520 521
	}
}

522 523 524 525 526 527
/*
 * FIXME: For now, just ignore any alternatives which add retpolines.  This is
 * a temporary hack, as it doesn't allow ORC to unwind from inside a retpoline.
 * But it at least allows objtool to understand the control flow *around* the
 * retpoline.
 */
528
static int add_ignore_alternatives(struct objtool_file *file)
529 530 531 532 533
{
	struct section *sec;
	struct rela *rela;
	struct instruction *insn;

534
	sec = find_section_by_name(file->elf, ".rela.discard.ignore_alts");
535 536 537 538 539 540 541 542 543 544 545
	if (!sec)
		return 0;

	list_for_each_entry(rela, &sec->rela_list, list) {
		if (rela->sym->type != STT_SECTION) {
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}

		insn = find_insn(file, rela->sym->sec, rela->addend);
		if (!insn) {
546
			WARN("bad .discard.ignore_alts entry");
547 548 549 550 551 552 553 554 555
			return -1;
		}

		insn->ignore_alts = true;
	}

	return 0;
}

556 557 558 559 560 561 562 563 564 565 566
/*
 * Find the destination instructions for all jumps.
 */
static int add_jump_destinations(struct objtool_file *file)
{
	struct instruction *insn;
	struct rela *rela;
	struct section *dest_sec;
	unsigned long dest_off;

	for_each_insn(file, insn) {
567
		if (!is_static_jump(insn))
568 569
			continue;

570
		if (insn->ignore || insn->offset == FAKE_JUMP_OFFSET)
571 572
			continue;

573 574
		rela = find_rela_by_dest_range(file->elf, insn->sec,
					       insn->offset, insn->len);
575 576 577 578 579 580 581 582 583
		if (!rela) {
			dest_sec = insn->sec;
			dest_off = insn->offset + insn->len + insn->immediate;
		} else if (rela->sym->type == STT_SECTION) {
			dest_sec = rela->sym->sec;
			dest_off = rela->addend + 4;
		} else if (rela->sym->sec->idx) {
			dest_sec = rela->sym->sec;
			dest_off = rela->sym->sym.st_value + rela->addend + 4;
584 585 586 587 588
		} else if (strstr(rela->sym->name, "_indirect_thunk_")) {
			/*
			 * Retpoline jumps are really dynamic jumps in
			 * disguise, so convert them accordingly.
			 */
589 590 591 592 593
			if (insn->type == INSN_JUMP_UNCONDITIONAL)
				insn->type = INSN_JUMP_DYNAMIC;
			else
				insn->type = INSN_JUMP_DYNAMIC_CONDITIONAL;

594
			insn->retpoline_safe = true;
595
			continue;
596
		} else {
597
			/* external sibling call */
598
			insn->call_dest = rela->sym;
599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617
			continue;
		}

		insn->jump_dest = find_insn(file, dest_sec, dest_off);
		if (!insn->jump_dest) {

			/*
			 * This is a special case where an alt instruction
			 * jumps past the end of the section.  These are
			 * handled later in handle_group_alt().
			 */
			if (!strcmp(insn->sec->name, ".altinstr_replacement"))
				continue;

			WARN_FUNC("can't find jump dest instruction at %s+0x%lx",
				  insn->sec, insn->offset, dest_sec->name,
				  dest_off);
			return -1;
		}
618 619

		/*
620
		 * Cross-function jump.
621 622
		 */
		if (insn->func && insn->jump_dest->func &&
623 624 625 626 627 628 629 630 631 632 633 634 635 636 637
		    insn->func != insn->jump_dest->func) {

			/*
			 * For GCC 8+, create parent/child links for any cold
			 * subfunctions.  This is _mostly_ redundant with a
			 * similar initialization in read_symbols().
			 *
			 * If a function has aliases, we want the *first* such
			 * function in the symbol table to be the subfunction's
			 * parent.  In that case we overwrite the
			 * initialization done in read_symbols().
			 *
			 * However this code can't completely replace the
			 * read_symbols() code because this doesn't detect the
			 * case where the parent function's only reference to a
638
			 * subfunction is through a jump table.
639 640 641 642 643 644 645 646 647
			 */
			if (!strstr(insn->func->name, ".cold.") &&
			    strstr(insn->jump_dest->func->name, ".cold.")) {
				insn->func->cfunc = insn->jump_dest->func;
				insn->jump_dest->func->pfunc = insn->func;

			} else if (insn->jump_dest->func->pfunc != insn->func->pfunc &&
				   insn->jump_dest->offset == insn->jump_dest->func->offset) {

648
				/* internal sibling call */
649 650
				insn->call_dest = insn->jump_dest->func;
			}
651
		}
652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669
	}

	return 0;
}

/*
 * Find the destination instructions for all calls.
 */
static int add_call_destinations(struct objtool_file *file)
{
	struct instruction *insn;
	unsigned long dest_off;
	struct rela *rela;

	for_each_insn(file, insn) {
		if (insn->type != INSN_CALL)
			continue;

670 671
		rela = find_rela_by_dest_range(file->elf, insn->sec,
					       insn->offset, insn->len);
672 673
		if (!rela) {
			dest_off = insn->offset + insn->len + insn->immediate;
674 675 676
			insn->call_dest = find_func_by_offset(insn->sec, dest_off);
			if (!insn->call_dest)
				insn->call_dest = find_symbol_by_offset(insn->sec, dest_off);
677

678 679 680 681
			if (insn->ignore)
				continue;

			if (!insn->call_dest) {
682 683
				WARN_FUNC("unsupported intra-function call",
					  insn->sec, insn->offset);
684 685
				if (retpoline)
					WARN("If this is a retpoline, please patch it in with alternatives and annotate it with ANNOTATE_NOSPEC_ALTERNATIVE.");
686 687
				return -1;
			}
688

689 690 691 692 693 694
			if (insn->func && insn->call_dest->type != STT_FUNC) {
				WARN_FUNC("unsupported call to non-function",
					  insn->sec, insn->offset);
				return -1;
			}

695
		} else if (rela->sym->type == STT_SECTION) {
696 697 698
			insn->call_dest = find_func_by_offset(rela->sym->sec,
							      rela->addend+4);
			if (!insn->call_dest) {
699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733
				WARN_FUNC("can't find call dest symbol at %s+0x%x",
					  insn->sec, insn->offset,
					  rela->sym->sec->name,
					  rela->addend + 4);
				return -1;
			}
		} else
			insn->call_dest = rela->sym;
	}

	return 0;
}

/*
 * The .alternatives section requires some extra special care, over and above
 * what other special sections require:
 *
 * 1. Because alternatives are patched in-place, we need to insert a fake jump
 *    instruction at the end so that validate_branch() skips all the original
 *    replaced instructions when validating the new instruction path.
 *
 * 2. An added wrinkle is that the new instruction length might be zero.  In
 *    that case the old instructions are replaced with noops.  We simulate that
 *    by creating a fake jump as the only new instruction.
 *
 * 3. In some cases, the alternative section includes an instruction which
 *    conditionally jumps to the _end_ of the entry.  We have to modify these
 *    jumps' destinations to point back to .text rather than the end of the
 *    entry in .altinstr_replacement.
 */
static int handle_group_alt(struct objtool_file *file,
			    struct special_alt *special_alt,
			    struct instruction *orig_insn,
			    struct instruction **new_insn)
{
734
	struct instruction *last_orig_insn, *last_new_insn, *insn, *fake_jump = NULL;
735 736 737 738 739 740 741 742 743 744 745 746
	unsigned long dest_off;

	last_orig_insn = NULL;
	insn = orig_insn;
	sec_for_each_insn_from(file, insn) {
		if (insn->offset >= special_alt->orig_off + special_alt->orig_len)
			break;

		insn->alt_group = true;
		last_orig_insn = insn;
	}

747 748 749 750 751 752 753 754 755 756 757
	if (next_insn_same_sec(file, last_orig_insn)) {
		fake_jump = malloc(sizeof(*fake_jump));
		if (!fake_jump) {
			WARN("malloc failed");
			return -1;
		}
		memset(fake_jump, 0, sizeof(*fake_jump));
		INIT_LIST_HEAD(&fake_jump->alts);
		clear_insn_state(&fake_jump->state);

		fake_jump->sec = special_alt->new_sec;
758
		fake_jump->offset = FAKE_JUMP_OFFSET;
759 760
		fake_jump->type = INSN_JUMP_UNCONDITIONAL;
		fake_jump->jump_dest = list_next_entry(last_orig_insn, list);
761
		fake_jump->func = orig_insn->func;
762 763 764
	}

	if (!special_alt->new_len) {
765 766 767 768 769 770
		if (!fake_jump) {
			WARN("%s: empty alternative at end of section",
			     special_alt->orig_sec->name);
			return -1;
		}

771 772 773 774 775 776 777 778 779 780 781 782
		*new_insn = fake_jump;
		return 0;
	}

	last_new_insn = NULL;
	insn = *new_insn;
	sec_for_each_insn_from(file, insn) {
		if (insn->offset >= special_alt->new_off + special_alt->new_len)
			break;

		last_new_insn = insn;

783
		insn->ignore = orig_insn->ignore_alts;
784
		insn->func = orig_insn->func;
785

786 787 788 789 790 791 792 793 794 795 796 797 798 799
		/*
		 * Since alternative replacement code is copy/pasted by the
		 * kernel after applying relocations, generally such code can't
		 * have relative-address relocation references to outside the
		 * .altinstr_replacement section, unless the arch's
		 * alternatives code can adjust the relative offsets
		 * accordingly.
		 *
		 * The x86 alternatives code adjusts the offsets only when it
		 * encounters a branch instruction at the very beginning of the
		 * replacement group.
		 */
		if ((insn->offset != special_alt->new_off ||
		    (insn->type != INSN_CALL && !is_static_jump(insn))) &&
800
		    find_rela_by_dest_range(file->elf, insn->sec, insn->offset, insn->len)) {
801 802 803 804 805 806

			WARN_FUNC("unsupported relocation in alternatives section",
				  insn->sec, insn->offset);
			return -1;
		}

807
		if (!is_static_jump(insn))
808 809 810 811 812 813
			continue;

		if (!insn->immediate)
			continue;

		dest_off = insn->offset + insn->len + insn->immediate;
814 815 816 817 818 819
		if (dest_off == special_alt->new_off + special_alt->new_len) {
			if (!fake_jump) {
				WARN("%s: alternative jump to end of section",
				     special_alt->orig_sec->name);
				return -1;
			}
820
			insn->jump_dest = fake_jump;
821
		}
822 823 824 825 826 827 828 829 830 831 832 833 834 835

		if (!insn->jump_dest) {
			WARN_FUNC("can't find alternative jump destination",
				  insn->sec, insn->offset);
			return -1;
		}
	}

	if (!last_new_insn) {
		WARN_FUNC("can't find last new alternative instruction",
			  special_alt->new_sec, special_alt->new_off);
		return -1;
	}

836 837
	if (fake_jump)
		list_add(&fake_jump->list, &last_new_insn->list);
838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918

	return 0;
}

/*
 * A jump table entry can either convert a nop to a jump or a jump to a nop.
 * If the original instruction is a jump, make the alt entry an effective nop
 * by just skipping the original instruction.
 */
static int handle_jump_alt(struct objtool_file *file,
			   struct special_alt *special_alt,
			   struct instruction *orig_insn,
			   struct instruction **new_insn)
{
	if (orig_insn->type == INSN_NOP)
		return 0;

	if (orig_insn->type != INSN_JUMP_UNCONDITIONAL) {
		WARN_FUNC("unsupported instruction at jump label",
			  orig_insn->sec, orig_insn->offset);
		return -1;
	}

	*new_insn = list_next_entry(orig_insn, list);
	return 0;
}

/*
 * Read all the special sections which have alternate instructions which can be
 * patched in or redirected to at runtime.  Each instruction having alternate
 * instruction(s) has them added to its insn->alts list, which will be
 * traversed in validate_branch().
 */
static int add_special_section_alts(struct objtool_file *file)
{
	struct list_head special_alts;
	struct instruction *orig_insn, *new_insn;
	struct special_alt *special_alt, *tmp;
	struct alternative *alt;
	int ret;

	ret = special_get_alts(file->elf, &special_alts);
	if (ret)
		return ret;

	list_for_each_entry_safe(special_alt, tmp, &special_alts, list) {

		orig_insn = find_insn(file, special_alt->orig_sec,
				      special_alt->orig_off);
		if (!orig_insn) {
			WARN_FUNC("special: can't find orig instruction",
				  special_alt->orig_sec, special_alt->orig_off);
			ret = -1;
			goto out;
		}

		new_insn = NULL;
		if (!special_alt->group || special_alt->new_len) {
			new_insn = find_insn(file, special_alt->new_sec,
					     special_alt->new_off);
			if (!new_insn) {
				WARN_FUNC("special: can't find new instruction",
					  special_alt->new_sec,
					  special_alt->new_off);
				ret = -1;
				goto out;
			}
		}

		if (special_alt->group) {
			ret = handle_group_alt(file, special_alt, orig_insn,
					       &new_insn);
			if (ret)
				goto out;
		} else if (special_alt->jump_or_nop) {
			ret = handle_jump_alt(file, special_alt, orig_insn,
					      &new_insn);
			if (ret)
				goto out;
		}

919 920 921 922 923 924 925
		alt = malloc(sizeof(*alt));
		if (!alt) {
			WARN("malloc failed");
			ret = -1;
			goto out;
		}

926
		alt->insn = new_insn;
P
Peter Zijlstra 已提交
927
		alt->skip_orig = special_alt->skip_orig;
P
Peter Zijlstra 已提交
928
		orig_insn->ignore_alts |= special_alt->skip_alt;
929 930 931 932 933 934 935 936 937 938
		list_add_tail(&alt->list, &orig_insn->alts);

		list_del(&special_alt->list);
		free(special_alt);
	}

out:
	return ret;
}

939
static int add_jump_table(struct objtool_file *file, struct instruction *insn,
940
			    struct rela *table)
941 942
{
	struct rela *rela = table;
943
	struct instruction *dest_insn;
944
	struct alternative *alt;
945 946
	struct symbol *pfunc = insn->func->pfunc;
	unsigned int prev_offset = 0;
947

948 949 950 951 952
	/*
	 * Each @rela is a switch table relocation which points to the target
	 * instruction.
	 */
	list_for_each_entry_from(rela, &table->sec->rela_list, list) {
953 954 955

		/* Check for the end of the table: */
		if (rela != table && rela->jump_table_start)
956 957
			break;

958
		/* Make sure the table entries are consecutive: */
959 960 961 962 963 964 965 966
		if (prev_offset && rela->offset != prev_offset + 8)
			break;

		/* Detect function pointers from contiguous objects: */
		if (rela->sym->sec == pfunc->sec &&
		    rela->addend == pfunc->offset)
			break;

967 968
		dest_insn = find_insn(file, rela->sym->sec, rela->addend);
		if (!dest_insn)
969 970
			break;

971
		/* Make sure the destination is in the same function: */
972
		if (!dest_insn->func || dest_insn->func->pfunc != pfunc)
973
			break;
974 975 976 977 978 979 980

		alt = malloc(sizeof(*alt));
		if (!alt) {
			WARN("malloc failed");
			return -1;
		}

981
		alt->insn = dest_insn;
982
		list_add_tail(&alt->list, &insn->alts);
983 984 985 986 987 988 989
		prev_offset = rela->offset;
	}

	if (!prev_offset) {
		WARN_FUNC("can't find switch jump table",
			  insn->sec, insn->offset);
		return -1;
990 991 992 993 994 995
	}

	return 0;
}

/*
996
 * find_jump_table() - Given a dynamic jump, find the switch jump table in
997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028
 * .rodata associated with it.
 *
 * There are 3 basic patterns:
 *
 * 1. jmpq *[rodata addr](,%reg,8)
 *
 *    This is the most common case by far.  It jumps to an address in a simple
 *    jump table which is stored in .rodata.
 *
 * 2. jmpq *[rodata addr](%rip)
 *
 *    This is caused by a rare GCC quirk, currently only seen in three driver
 *    functions in the kernel, only with certain obscure non-distro configs.
 *
 *    As part of an optimization, GCC makes a copy of an existing switch jump
 *    table, modifies it, and then hard-codes the jump (albeit with an indirect
 *    jump) to use a single entry in the table.  The rest of the jump table and
 *    some of its jump targets remain as dead code.
 *
 *    In such a case we can just crudely ignore all unreachable instruction
 *    warnings for the entire object file.  Ideally we would just ignore them
 *    for the function, but that would require redesigning the code quite a
 *    bit.  And honestly that's just not worth doing: unreachable instruction
 *    warnings are of questionable value anyway, and this is such a rare issue.
 *
 * 3. mov [rodata addr],%reg1
 *    ... some instructions ...
 *    jmpq *(%reg1,%reg2,8)
 *
 *    This is a fairly uncommon pattern which is new for GCC 6.  As of this
 *    writing, there are 11 occurrences of it in the allmodconfig kernel.
 *
1029 1030 1031 1032
 *    As of GCC 7 there are quite a few more of these and the 'in between' code
 *    is significant. Esp. with KASAN enabled some of the code between the mov
 *    and jmpq uses .rodata itself, which can confuse things.
 *
1033 1034
 *    TODO: Once we have DWARF CFI and smarter instruction decoding logic,
 *    ensure the same register is used in the mov and jump instructions.
1035 1036
 *
 *    NOTE: RETPOLINE made it harder still to decode dynamic jumps.
1037
 */
1038
static struct rela *find_jump_table(struct objtool_file *file,
1039 1040 1041
				      struct symbol *func,
				      struct instruction *insn)
{
1042
	struct rela *text_rela, *table_rela;
1043
	struct instruction *dest_insn, *orig_insn = insn;
1044
	struct section *table_sec;
1045
	unsigned long table_offset;
1046

1047 1048 1049 1050 1051
	/*
	 * Backward search using the @first_jump_src links, these help avoid
	 * much of the 'in between' code. Which avoids us getting confused by
	 * it.
	 */
1052
	for (;
1053
	     &insn->list != &file->insn_list && insn->func && insn->func->pfunc == func;
1054 1055
	     insn = insn->first_jump_src ?: list_prev_entry(insn, list)) {

1056
		if (insn != orig_insn && insn->type == INSN_JUMP_DYNAMIC)
1057 1058 1059 1060 1061 1062 1063 1064 1065 1066
			break;

		/* allow small jumps within the range */
		if (insn->type == INSN_JUMP_UNCONDITIONAL &&
		    insn->jump_dest &&
		    (insn->jump_dest->offset <= insn->offset ||
		     insn->jump_dest->offset > orig_insn->offset))
		    break;

		/* look for a relocation which references .rodata */
1067 1068
		text_rela = find_rela_by_dest_range(file->elf, insn->sec,
						    insn->offset, insn->len);
1069 1070
		if (!text_rela || text_rela->sym->type != STT_SECTION ||
		    !text_rela->sym->sec->rodata)
1071 1072
			continue;

1073
		table_offset = text_rela->addend;
1074
		table_sec = text_rela->sym->sec;
1075

1076 1077 1078
		if (text_rela->type == R_X86_64_PC32)
			table_offset += 4;

1079 1080
		/*
		 * Make sure the .rodata address isn't associated with a
1081 1082 1083 1084 1085 1086
		 * symbol.  GCC jump tables are anonymous data.
		 *
		 * Also support C jump tables which are in the same format as
		 * switch jump tables.  For objtool to recognize them, they
		 * need to be placed in the C_JUMP_TABLE_SECTION section.  They
		 * have symbols associated with them.
1087
		 */
1088 1089
		if (find_symbol_containing(table_sec, table_offset) &&
		    strcmp(table_sec->name, C_JUMP_TABLE_SECTION))
1090 1091
			continue;

1092 1093 1094 1095 1096
		/*
		 * Each table entry has a rela associated with it.  The rela
		 * should reference text in the same function as the original
		 * instruction.
		 */
1097
		table_rela = find_rela_by_dest(file->elf, table_sec, table_offset);
1098 1099
		if (!table_rela)
			continue;
1100 1101 1102
		dest_insn = find_insn(file, table_rela->sym->sec, table_rela->addend);
		if (!dest_insn || !dest_insn->func || dest_insn->func->pfunc != func)
			continue;
1103

1104 1105 1106 1107 1108 1109 1110 1111 1112
		/*
		 * Use of RIP-relative switch jumps is quite rare, and
		 * indicates a rare GCC quirk/bug which can leave dead code
		 * behind.
		 */
		if (text_rela->type == R_X86_64_PC32)
			file->ignore_unreachables = true;

		return table_rela;
1113 1114 1115 1116 1117
	}

	return NULL;
}

1118 1119 1120 1121 1122 1123
/*
 * First pass: Mark the head of each jump table so that in the next pass,
 * we know when a given jump table ends and the next one starts.
 */
static void mark_func_jump_tables(struct objtool_file *file,
				    struct symbol *func)
1124
{
1125 1126
	struct instruction *insn, *last = NULL;
	struct rela *rela;
1127

1128
	func_for_each_insn(file, func, insn) {
1129 1130 1131 1132 1133
		if (!last)
			last = insn;

		/*
		 * Store back-pointers for unconditional forward jumps such
1134
		 * that find_jump_table() can back-track using those and
1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145
		 * avoid some potentially confusing code.
		 */
		if (insn->type == INSN_JUMP_UNCONDITIONAL && insn->jump_dest &&
		    insn->offset > last->offset &&
		    insn->jump_dest->offset > insn->offset &&
		    !insn->jump_dest->first_jump_src) {

			insn->jump_dest->first_jump_src = insn;
			last = insn->jump_dest;
		}

1146 1147 1148
		if (insn->type != INSN_JUMP_DYNAMIC)
			continue;

1149
		rela = find_jump_table(file, func, insn);
1150 1151 1152
		if (rela) {
			rela->jump_table_start = true;
			insn->jump_table = rela;
1153 1154
		}
	}
1155 1156 1157 1158 1159 1160 1161 1162
}

static int add_func_jump_tables(struct objtool_file *file,
				  struct symbol *func)
{
	struct instruction *insn;
	int ret;

1163
	func_for_each_insn(file, func, insn) {
1164 1165
		if (!insn->jump_table)
			continue;
1166

1167
		ret = add_jump_table(file, insn, insn->jump_table);
1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179
		if (ret)
			return ret;
	}

	return 0;
}

/*
 * For some switch statements, gcc generates a jump table in the .rodata
 * section which contains a list of addresses within the function to jump to.
 * This finds these jump tables and adds them to the insn->alts lists.
 */
1180
static int add_jump_table_alts(struct objtool_file *file)
1181 1182 1183 1184 1185
{
	struct section *sec;
	struct symbol *func;
	int ret;

1186
	if (!file->rodata)
1187 1188
		return 0;

1189
	for_each_sec(file, sec) {
1190 1191 1192 1193
		list_for_each_entry(func, &sec->symbol_list, list) {
			if (func->type != STT_FUNC)
				continue;

1194
			mark_func_jump_tables(file, func);
1195
			ret = add_func_jump_tables(file, func);
1196 1197 1198 1199 1200 1201 1202 1203
			if (ret)
				return ret;
		}
	}

	return 0;
}

1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232
static int read_unwind_hints(struct objtool_file *file)
{
	struct section *sec, *relasec;
	struct rela *rela;
	struct unwind_hint *hint;
	struct instruction *insn;
	struct cfi_reg *cfa;
	int i;

	sec = find_section_by_name(file->elf, ".discard.unwind_hints");
	if (!sec)
		return 0;

	relasec = sec->rela;
	if (!relasec) {
		WARN("missing .rela.discard.unwind_hints section");
		return -1;
	}

	if (sec->len % sizeof(struct unwind_hint)) {
		WARN("struct unwind_hint size mismatch");
		return -1;
	}

	file->hints = true;

	for (i = 0; i < sec->len / sizeof(struct unwind_hint); i++) {
		hint = (struct unwind_hint *)sec->data->d_buf + i;

1233
		rela = find_rela_by_dest(file->elf, sec, i * sizeof(*hint));
1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291
		if (!rela) {
			WARN("can't find rela for unwind_hints[%d]", i);
			return -1;
		}

		insn = find_insn(file, rela->sym->sec, rela->addend);
		if (!insn) {
			WARN("can't find insn for unwind_hints[%d]", i);
			return -1;
		}

		cfa = &insn->state.cfa;

		if (hint->type == UNWIND_HINT_TYPE_SAVE) {
			insn->save = true;
			continue;

		} else if (hint->type == UNWIND_HINT_TYPE_RESTORE) {
			insn->restore = true;
			insn->hint = true;
			continue;
		}

		insn->hint = true;

		switch (hint->sp_reg) {
		case ORC_REG_UNDEFINED:
			cfa->base = CFI_UNDEFINED;
			break;
		case ORC_REG_SP:
			cfa->base = CFI_SP;
			break;
		case ORC_REG_BP:
			cfa->base = CFI_BP;
			break;
		case ORC_REG_SP_INDIRECT:
			cfa->base = CFI_SP_INDIRECT;
			break;
		case ORC_REG_R10:
			cfa->base = CFI_R10;
			break;
		case ORC_REG_R13:
			cfa->base = CFI_R13;
			break;
		case ORC_REG_DI:
			cfa->base = CFI_DI;
			break;
		case ORC_REG_DX:
			cfa->base = CFI_DX;
			break;
		default:
			WARN_FUNC("unsupported unwind_hint sp base reg %d",
				  insn->sec, insn->offset, hint->sp_reg);
			return -1;
		}

		cfa->offset = hint->sp_offset;
		insn->state.type = hint->type;
1292
		insn->state.end = hint->end;
1293 1294 1295 1296 1297
	}

	return 0;
}

1298 1299
static int read_retpoline_hints(struct objtool_file *file)
{
J
Josh Poimboeuf 已提交
1300
	struct section *sec;
1301 1302 1303
	struct instruction *insn;
	struct rela *rela;

J
Josh Poimboeuf 已提交
1304
	sec = find_section_by_name(file->elf, ".rela.discard.retpoline_safe");
1305 1306 1307
	if (!sec)
		return 0;

J
Josh Poimboeuf 已提交
1308 1309 1310
	list_for_each_entry(rela, &sec->rela_list, list) {
		if (rela->sym->type != STT_SECTION) {
			WARN("unexpected relocation symbol type in %s", sec->name);
1311 1312 1313 1314 1315
			return -1;
		}

		insn = find_insn(file, rela->sym->sec, rela->addend);
		if (!insn) {
J
Josh Poimboeuf 已提交
1316
			WARN("bad .discard.retpoline_safe entry");
1317 1318 1319 1320 1321
			return -1;
		}

		if (insn->type != INSN_JUMP_DYNAMIC &&
		    insn->type != INSN_CALL_DYNAMIC) {
J
Josh Poimboeuf 已提交
1322
			WARN_FUNC("retpoline_safe hint not an indirect jump/call",
1323 1324 1325 1326 1327 1328 1329 1330 1331 1332
				  insn->sec, insn->offset);
			return -1;
		}

		insn->retpoline_safe = true;
	}

	return 0;
}

1333 1334 1335 1336 1337 1338
static void mark_rodata(struct objtool_file *file)
{
	struct section *sec;
	bool found = false;

	/*
1339 1340 1341 1342 1343 1344 1345 1346
	 * Search for the following rodata sections, each of which can
	 * potentially contain jump tables:
	 *
	 * - .rodata: can contain GCC switch tables
	 * - .rodata.<func>: same, if -fdata-sections is being used
	 * - .rodata..c_jump_table: contains C annotated jump tables
	 *
	 * .rodata.str1.* sections are ignored; they don't contain jump tables.
1347 1348
	 */
	for_each_sec(file, sec) {
1349 1350
		if ((!strncmp(sec->name, ".rodata", 7) && !strstr(sec->name, ".str1.")) ||
		    !strcmp(sec->name, C_JUMP_TABLE_SECTION)) {
1351 1352 1353 1354 1355 1356 1357 1358
			sec->rodata = true;
			found = true;
		}
	}

	file->rodata = found;
}

1359 1360 1361 1362
static int decode_sections(struct objtool_file *file)
{
	int ret;

1363 1364
	mark_rodata(file);

1365 1366 1367 1368 1369 1370 1371 1372 1373
	ret = decode_instructions(file);
	if (ret)
		return ret;

	ret = add_dead_ends(file);
	if (ret)
		return ret;

	add_ignores(file);
P
Peter Zijlstra 已提交
1374
	add_uaccess_safe(file);
1375

1376
	ret = add_ignore_alternatives(file);
1377 1378 1379
	if (ret)
		return ret;

1380 1381 1382 1383
	ret = add_jump_destinations(file);
	if (ret)
		return ret;

1384
	ret = add_special_section_alts(file);
1385 1386 1387
	if (ret)
		return ret;

1388
	ret = add_call_destinations(file);
1389 1390 1391
	if (ret)
		return ret;

1392
	ret = add_jump_table_alts(file);
1393 1394 1395
	if (ret)
		return ret;

1396 1397 1398 1399
	ret = read_unwind_hints(file);
	if (ret)
		return ret;

1400 1401 1402 1403
	ret = read_retpoline_hints(file);
	if (ret)
		return ret;

1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416
	return 0;
}

static bool is_fentry_call(struct instruction *insn)
{
	if (insn->type == INSN_CALL &&
	    insn->call_dest->type == STT_NOTYPE &&
	    !strcmp(insn->call_dest->name, "__fentry__"))
		return true;

	return false;
}

1417
static bool has_modified_stack_frame(struct insn_state *state)
1418
{
1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444
	int i;

	if (state->cfa.base != initial_func_cfi.cfa.base ||
	    state->cfa.offset != initial_func_cfi.cfa.offset ||
	    state->stack_size != initial_func_cfi.cfa.offset ||
	    state->drap)
		return true;

	for (i = 0; i < CFI_NUM_REGS; i++)
		if (state->regs[i].base != initial_func_cfi.regs[i].base ||
		    state->regs[i].offset != initial_func_cfi.regs[i].offset)
			return true;

	return false;
}

static bool has_valid_stack_frame(struct insn_state *state)
{
	if (state->cfa.base == CFI_BP && state->regs[CFI_BP].base == CFI_CFA &&
	    state->regs[CFI_BP].offset == -16)
		return true;

	if (state->drap && state->regs[CFI_BP].base == CFI_BP)
		return true;

	return false;
1445 1446
}

1447 1448 1449 1450 1451 1452 1453 1454 1455
static int update_insn_state_regs(struct instruction *insn, struct insn_state *state)
{
	struct cfi_reg *cfa = &state->cfa;
	struct stack_op *op = &insn->stack_op;

	if (cfa->base != CFI_SP)
		return 0;

	/* push */
P
Peter Zijlstra 已提交
1456
	if (op->dest.type == OP_DEST_PUSH || op->dest.type == OP_DEST_PUSHF)
1457 1458 1459
		cfa->offset += 8;

	/* pop */
P
Peter Zijlstra 已提交
1460
	if (op->src.type == OP_SRC_POP || op->src.type == OP_SRC_POPF)
1461 1462 1463 1464 1465 1466 1467 1468 1469 1470
		cfa->offset -= 8;

	/* add immediate to sp */
	if (op->dest.type == OP_DEST_REG && op->src.type == OP_SRC_ADD &&
	    op->dest.reg == CFI_SP && op->src.reg == CFI_SP)
		cfa->offset -= op->src.offset;

	return 0;
}

1471 1472
static void save_reg(struct insn_state *state, unsigned char reg, int base,
		     int offset)
1473
{
1474
	if (arch_callee_saved_reg(reg) &&
1475 1476 1477 1478
	    state->regs[reg].base == CFI_UNDEFINED) {
		state->regs[reg].base = base;
		state->regs[reg].offset = offset;
	}
1479 1480
}

1481
static void restore_reg(struct insn_state *state, unsigned char reg)
1482
{
1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554
	state->regs[reg].base = CFI_UNDEFINED;
	state->regs[reg].offset = 0;
}

/*
 * A note about DRAP stack alignment:
 *
 * GCC has the concept of a DRAP register, which is used to help keep track of
 * the stack pointer when aligning the stack.  r10 or r13 is used as the DRAP
 * register.  The typical DRAP pattern is:
 *
 *   4c 8d 54 24 08		lea    0x8(%rsp),%r10
 *   48 83 e4 c0		and    $0xffffffffffffffc0,%rsp
 *   41 ff 72 f8		pushq  -0x8(%r10)
 *   55				push   %rbp
 *   48 89 e5			mov    %rsp,%rbp
 *				(more pushes)
 *   41 52			push   %r10
 *				...
 *   41 5a			pop    %r10
 *				(more pops)
 *   5d				pop    %rbp
 *   49 8d 62 f8		lea    -0x8(%r10),%rsp
 *   c3				retq
 *
 * There are some variations in the epilogues, like:
 *
 *   5b				pop    %rbx
 *   41 5a			pop    %r10
 *   41 5c			pop    %r12
 *   41 5d			pop    %r13
 *   41 5e			pop    %r14
 *   c9				leaveq
 *   49 8d 62 f8		lea    -0x8(%r10),%rsp
 *   c3				retq
 *
 * and:
 *
 *   4c 8b 55 e8		mov    -0x18(%rbp),%r10
 *   48 8b 5d e0		mov    -0x20(%rbp),%rbx
 *   4c 8b 65 f0		mov    -0x10(%rbp),%r12
 *   4c 8b 6d f8		mov    -0x8(%rbp),%r13
 *   c9				leaveq
 *   49 8d 62 f8		lea    -0x8(%r10),%rsp
 *   c3				retq
 *
 * Sometimes r13 is used as the DRAP register, in which case it's saved and
 * restored beforehand:
 *
 *   41 55			push   %r13
 *   4c 8d 6c 24 10		lea    0x10(%rsp),%r13
 *   48 83 e4 f0		and    $0xfffffffffffffff0,%rsp
 *				...
 *   49 8d 65 f0		lea    -0x10(%r13),%rsp
 *   41 5d			pop    %r13
 *   c3				retq
 */
static int update_insn_state(struct instruction *insn, struct insn_state *state)
{
	struct stack_op *op = &insn->stack_op;
	struct cfi_reg *cfa = &state->cfa;
	struct cfi_reg *regs = state->regs;

	/* stack operations don't make sense with an undefined CFA */
	if (cfa->base == CFI_UNDEFINED) {
		if (insn->func) {
			WARN_FUNC("undefined stack state", insn->sec, insn->offset);
			return -1;
		}
		return 0;
	}

1555 1556 1557
	if (state->type == ORC_TYPE_REGS || state->type == ORC_TYPE_REGS_IRET)
		return update_insn_state_regs(insn, state);

1558 1559 1560 1561 1562 1563
	switch (op->dest.type) {

	case OP_DEST_REG:
		switch (op->src.type) {

		case OP_SRC_REG:
1564 1565 1566 1567 1568 1569 1570 1571 1572
			if (op->src.reg == CFI_SP && op->dest.reg == CFI_BP &&
			    cfa->base == CFI_SP &&
			    regs[CFI_BP].base == CFI_CFA &&
			    regs[CFI_BP].offset == -cfa->offset) {

				/* mov %rsp, %rbp */
				cfa->base = op->dest.reg;
				state->bp_scratch = false;
			}
1573

1574 1575
			else if (op->src.reg == CFI_SP &&
				 op->dest.reg == CFI_BP && state->drap) {
1576

1577 1578 1579 1580 1581
				/* drap: mov %rsp, %rbp */
				regs[CFI_BP].base = CFI_BP;
				regs[CFI_BP].offset = -state->stack_size;
				state->bp_scratch = false;
			}
1582

1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596
			else if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {

				/*
				 * mov %rsp, %reg
				 *
				 * This is needed for the rare case where GCC
				 * does:
				 *
				 *   mov    %rsp, %rax
				 *   ...
				 *   mov    %rax, %rsp
				 */
				state->vals[op->dest.reg].base = CFI_CFA;
				state->vals[op->dest.reg].offset = -state->stack_size;
1597 1598
			}

J
Josh Poimboeuf 已提交
1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609
			else if (op->src.reg == CFI_BP && op->dest.reg == CFI_SP &&
				 cfa->base == CFI_BP) {

				/*
				 * mov %rbp, %rsp
				 *
				 * Restore the original stack pointer (Clang).
				 */
				state->stack_size = -state->regs[CFI_BP].offset;
			}

1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630
			else if (op->dest.reg == cfa->base) {

				/* mov %reg, %rsp */
				if (cfa->base == CFI_SP &&
				    state->vals[op->src.reg].base == CFI_CFA) {

					/*
					 * This is needed for the rare case
					 * where GCC does something dumb like:
					 *
					 *   lea    0x8(%rsp), %rcx
					 *   ...
					 *   mov    %rcx, %rsp
					 */
					cfa->offset = -state->vals[op->src.reg].offset;
					state->stack_size = cfa->offset;

				} else {
					cfa->base = CFI_UNDEFINED;
					cfa->offset = 0;
				}
1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651
			}

			break;

		case OP_SRC_ADD:
			if (op->dest.reg == CFI_SP && op->src.reg == CFI_SP) {

				/* add imm, %rsp */
				state->stack_size -= op->src.offset;
				if (cfa->base == CFI_SP)
					cfa->offset -= op->src.offset;
				break;
			}

			if (op->dest.reg == CFI_SP && op->src.reg == CFI_BP) {

				/* lea disp(%rbp), %rsp */
				state->stack_size = -(op->src.offset + regs[CFI_BP].offset);
				break;
			}

1652
			if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {
1653 1654 1655

				/* drap: lea disp(%rsp), %drap */
				state->drap_reg = op->dest.reg;
1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670

				/*
				 * lea disp(%rsp), %reg
				 *
				 * This is needed for the rare case where GCC
				 * does something dumb like:
				 *
				 *   lea    0x8(%rsp), %rcx
				 *   ...
				 *   mov    %rcx, %rsp
				 */
				state->vals[op->dest.reg].base = CFI_CFA;
				state->vals[op->dest.reg].offset = \
					-state->stack_size + op->src.offset;

1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716
				break;
			}

			if (state->drap && op->dest.reg == CFI_SP &&
			    op->src.reg == state->drap_reg) {

				 /* drap: lea disp(%drap), %rsp */
				cfa->base = CFI_SP;
				cfa->offset = state->stack_size = -op->src.offset;
				state->drap_reg = CFI_UNDEFINED;
				state->drap = false;
				break;
			}

			if (op->dest.reg == state->cfa.base) {
				WARN_FUNC("unsupported stack register modification",
					  insn->sec, insn->offset);
				return -1;
			}

			break;

		case OP_SRC_AND:
			if (op->dest.reg != CFI_SP ||
			    (state->drap_reg != CFI_UNDEFINED && cfa->base != CFI_SP) ||
			    (state->drap_reg == CFI_UNDEFINED && cfa->base != CFI_BP)) {
				WARN_FUNC("unsupported stack pointer realignment",
					  insn->sec, insn->offset);
				return -1;
			}

			if (state->drap_reg != CFI_UNDEFINED) {
				/* drap: and imm, %rsp */
				cfa->base = state->drap_reg;
				cfa->offset = state->stack_size = 0;
				state->drap = true;
			}

			/*
			 * Older versions of GCC (4.8ish) realign the stack
			 * without DRAP, with a frame pointer.
			 */

			break;

		case OP_SRC_POP:
P
Peter Zijlstra 已提交
1717
		case OP_SRC_POPF:
1718 1719 1720 1721 1722 1723 1724
			if (!state->drap && op->dest.type == OP_DEST_REG &&
			    op->dest.reg == cfa->base) {

				/* pop %rbp */
				cfa->base = CFI_SP;
			}

1725 1726 1727 1728
			if (state->drap && cfa->base == CFI_BP_INDIRECT &&
			    op->dest.type == OP_DEST_REG &&
			    op->dest.reg == state->drap_reg &&
			    state->drap_offset == -state->stack_size) {
1729

1730 1731 1732 1733
				/* drap: pop %drap */
				cfa->base = state->drap_reg;
				cfa->offset = 0;
				state->drap_offset = -1;
1734

1735
			} else if (regs[op->dest.reg].offset == -state->stack_size) {
1736

1737
				/* pop %reg */
1738 1739 1740 1741 1742 1743 1744 1745 1746 1747
				restore_reg(state, op->dest.reg);
			}

			state->stack_size -= 8;
			if (cfa->base == CFI_SP)
				cfa->offset -= 8;

			break;

		case OP_SRC_REG_INDIRECT:
1748 1749 1750 1751 1752 1753 1754 1755 1756
			if (state->drap && op->src.reg == CFI_BP &&
			    op->src.offset == state->drap_offset) {

				/* drap: mov disp(%rbp), %drap */
				cfa->base = state->drap_reg;
				cfa->offset = 0;
				state->drap_offset = -1;
			}

1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781
			if (state->drap && op->src.reg == CFI_BP &&
			    op->src.offset == regs[op->dest.reg].offset) {

				/* drap: mov disp(%rbp), %reg */
				restore_reg(state, op->dest.reg);

			} else if (op->src.reg == cfa->base &&
			    op->src.offset == regs[op->dest.reg].offset + cfa->offset) {

				/* mov disp(%rbp), %reg */
				/* mov disp(%rsp), %reg */
				restore_reg(state, op->dest.reg);
			}

			break;

		default:
			WARN_FUNC("unknown stack-related instruction",
				  insn->sec, insn->offset);
			return -1;
		}

		break;

	case OP_DEST_PUSH:
P
Peter Zijlstra 已提交
1782
	case OP_DEST_PUSHF:
1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796
		state->stack_size += 8;
		if (cfa->base == CFI_SP)
			cfa->offset += 8;

		if (op->src.type != OP_SRC_REG)
			break;

		if (state->drap) {
			if (op->src.reg == cfa->base && op->src.reg == state->drap_reg) {

				/* drap: push %drap */
				cfa->base = CFI_BP_INDIRECT;
				cfa->offset = -state->stack_size;

1797 1798
				/* save drap so we know when to restore it */
				state->drap_offset = -state->stack_size;
1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817

			} else if (op->src.reg == CFI_BP && cfa->base == state->drap_reg) {

				/* drap: push %rbp */
				state->stack_size = 0;

			} else if (regs[op->src.reg].base == CFI_UNDEFINED) {

				/* drap: push %reg */
				save_reg(state, op->src.reg, CFI_BP, -state->stack_size);
			}

		} else {

			/* push %reg */
			save_reg(state, op->src.reg, CFI_CFA, -state->stack_size);
		}

		/* detect when asm code uses rbp as a scratch register */
1818
		if (!no_fp && insn->func && op->src.reg == CFI_BP &&
1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831
		    cfa->base != CFI_BP)
			state->bp_scratch = true;
		break;

	case OP_DEST_REG_INDIRECT:

		if (state->drap) {
			if (op->src.reg == cfa->base && op->src.reg == state->drap_reg) {

				/* drap: mov %drap, disp(%rbp) */
				cfa->base = CFI_BP_INDIRECT;
				cfa->offset = op->dest.offset;

1832 1833
				/* save drap offset so we know when to restore it */
				state->drap_offset = op->dest.offset;
1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872
			}

			else if (regs[op->src.reg].base == CFI_UNDEFINED) {

				/* drap: mov reg, disp(%rbp) */
				save_reg(state, op->src.reg, CFI_BP, op->dest.offset);
			}

		} else if (op->dest.reg == cfa->base) {

			/* mov reg, disp(%rbp) */
			/* mov reg, disp(%rsp) */
			save_reg(state, op->src.reg, CFI_CFA,
				 op->dest.offset - state->cfa.offset);
		}

		break;

	case OP_DEST_LEAVE:
		if ((!state->drap && cfa->base != CFI_BP) ||
		    (state->drap && cfa->base != state->drap_reg)) {
			WARN_FUNC("leave instruction with modified stack frame",
				  insn->sec, insn->offset);
			return -1;
		}

		/* leave (mov %rbp, %rsp; pop %rbp) */

		state->stack_size = -state->regs[CFI_BP].offset - 8;
		restore_reg(state, CFI_BP);

		if (!state->drap) {
			cfa->base = CFI_SP;
			cfa->offset -= 8;
		}

		break;

	case OP_DEST_MEM:
P
Peter Zijlstra 已提交
1873
		if (op->src.type != OP_SRC_POP && op->src.type != OP_SRC_POPF) {
1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918
			WARN_FUNC("unknown stack-related memory operation",
				  insn->sec, insn->offset);
			return -1;
		}

		/* pop mem */
		state->stack_size -= 8;
		if (cfa->base == CFI_SP)
			cfa->offset -= 8;

		break;

	default:
		WARN_FUNC("unknown stack-related instruction",
			  insn->sec, insn->offset);
		return -1;
	}

	return 0;
}

static bool insn_state_match(struct instruction *insn, struct insn_state *state)
{
	struct insn_state *state1 = &insn->state, *state2 = state;
	int i;

	if (memcmp(&state1->cfa, &state2->cfa, sizeof(state1->cfa))) {
		WARN_FUNC("stack state mismatch: cfa1=%d%+d cfa2=%d%+d",
			  insn->sec, insn->offset,
			  state1->cfa.base, state1->cfa.offset,
			  state2->cfa.base, state2->cfa.offset);

	} else if (memcmp(&state1->regs, &state2->regs, sizeof(state1->regs))) {
		for (i = 0; i < CFI_NUM_REGS; i++) {
			if (!memcmp(&state1->regs[i], &state2->regs[i],
				    sizeof(struct cfi_reg)))
				continue;

			WARN_FUNC("stack state mismatch: reg1[%d]=%d%+d reg2[%d]=%d%+d",
				  insn->sec, insn->offset,
				  i, state1->regs[i].base, state1->regs[i].offset,
				  i, state2->regs[i].base, state2->regs[i].offset);
			break;
		}

1919 1920 1921 1922
	} else if (state1->type != state2->type) {
		WARN_FUNC("stack state mismatch: type1=%d type2=%d",
			  insn->sec, insn->offset, state1->type, state2->type);

1923
	} else if (state1->drap != state2->drap ||
1924 1925 1926
		 (state1->drap && state1->drap_reg != state2->drap_reg) ||
		 (state1->drap && state1->drap_offset != state2->drap_offset)) {
		WARN_FUNC("stack state mismatch: drap1=%d(%d,%d) drap2=%d(%d,%d)",
1927
			  insn->sec, insn->offset,
1928 1929
			  state1->drap, state1->drap_reg, state1->drap_offset,
			  state2->drap, state2->drap_reg, state2->drap_offset);
1930 1931 1932 1933 1934

	} else
		return true;

	return false;
1935 1936
}

P
Peter Zijlstra 已提交
1937 1938 1939
static inline bool func_uaccess_safe(struct symbol *func)
{
	if (func)
1940
		return func->uaccess_safe;
P
Peter Zijlstra 已提交
1941 1942 1943 1944

	return false;
}

1945
static inline const char *call_dest_name(struct instruction *insn)
P
Peter Zijlstra 已提交
1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956
{
	if (insn->call_dest)
		return insn->call_dest->name;

	return "{dynamic}";
}

static int validate_call(struct instruction *insn, struct insn_state *state)
{
	if (state->uaccess && !func_uaccess_safe(insn->call_dest)) {
		WARN_FUNC("call to %s() with UACCESS enabled",
1957
				insn->sec, insn->offset, call_dest_name(insn));
P
Peter Zijlstra 已提交
1958 1959 1960
		return 1;
	}

1961 1962
	if (state->df) {
		WARN_FUNC("call to %s() with DF set",
1963
				insn->sec, insn->offset, call_dest_name(insn));
1964 1965 1966
		return 1;
	}

P
Peter Zijlstra 已提交
1967 1968 1969
	return 0;
}

1970 1971 1972 1973 1974 1975 1976 1977
static int validate_sibling_call(struct instruction *insn, struct insn_state *state)
{
	if (has_modified_stack_frame(state)) {
		WARN_FUNC("sibling call from callable instruction with modified stack frame",
				insn->sec, insn->offset);
		return 1;
	}

P
Peter Zijlstra 已提交
1978
	return validate_call(insn, state);
1979 1980
}

1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007
static int validate_return(struct symbol *func, struct instruction *insn, struct insn_state *state)
{
	if (state->uaccess && !func_uaccess_safe(func)) {
		WARN_FUNC("return with UACCESS enabled",
			  insn->sec, insn->offset);
		return 1;
	}

	if (!state->uaccess && func_uaccess_safe(func)) {
		WARN_FUNC("return with UACCESS disabled from a UACCESS-safe function",
			  insn->sec, insn->offset);
		return 1;
	}

	if (state->df) {
		WARN_FUNC("return with DF set",
			  insn->sec, insn->offset);
		return 1;
	}

	if (func && has_modified_stack_frame(state)) {
		WARN_FUNC("return with modified stack frame",
			  insn->sec, insn->offset);
		return 1;
	}

	if (state->bp_scratch) {
2008 2009
		WARN_FUNC("BP used as a scratch register",
			  insn->sec, insn->offset);
2010 2011 2012 2013 2014 2015
		return 1;
	}

	return 0;
}

2016 2017 2018 2019 2020 2021
/*
 * Follow the branch starting at the given instruction, and recursively follow
 * any other branches (jumps).  Meanwhile, track the frame pointer state at
 * each instruction and validate all the rules described in
 * tools/objtool/Documentation/stack-validation.txt.
 */
2022 2023
static int validate_branch(struct objtool_file *file, struct symbol *func,
			   struct instruction *first, struct insn_state state)
2024 2025
{
	struct alternative *alt;
2026
	struct instruction *insn, *next_insn;
2027
	struct section *sec;
2028
	u8 visited;
2029 2030 2031 2032 2033 2034 2035 2036
	int ret;

	insn = first;
	sec = insn->sec;

	if (insn->alt_group && list_empty(&insn->alts)) {
		WARN_FUNC("don't know how to handle branch to middle of alternative instruction group",
			  sec, insn->offset);
2037
		return 1;
2038 2039 2040
	}

	while (1) {
2041 2042
		next_insn = next_insn_same_sec(file, insn);

2043
		if (file->c_file && func && insn->func && func != insn->func->pfunc) {
2044 2045 2046
			WARN("%s() falls through to next function %s()",
			     func->name, insn->func->name);
			return 1;
2047 2048
		}

2049 2050 2051
		if (func && insn->ignore) {
			WARN_FUNC("BUG: why am I validating an ignored function?",
				  sec, insn->offset);
2052
			return 1;
2053 2054
		}

2055
		visited = 1 << state.uaccess;
2056
		if (insn->visited) {
2057
			if (!insn->hint && !insn_state_match(insn, &state))
2058 2059
				return 1;

2060
			if (insn->visited & visited)
P
Peter Zijlstra 已提交
2061
				return 0;
2062 2063
		}

2064 2065 2066 2067 2068 2069
		if (insn->hint) {
			if (insn->restore) {
				struct instruction *save_insn, *i;

				i = insn;
				save_insn = NULL;
2070
				sym_for_each_insn_continue_reverse(file, func, i) {
2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105
					if (i->save) {
						save_insn = i;
						break;
					}
				}

				if (!save_insn) {
					WARN_FUNC("no corresponding CFI save for CFI restore",
						  sec, insn->offset);
					return 1;
				}

				if (!save_insn->visited) {
					/*
					 * Oops, no state to copy yet.
					 * Hopefully we can reach this
					 * instruction from another branch
					 * after the save insn has been
					 * visited.
					 */
					if (insn == first)
						return 0;

					WARN_FUNC("objtool isn't smart enough to handle this CFI save/restore combo",
						  sec, insn->offset);
					return 1;
				}

				insn->state = save_insn->state;
			}

			state = insn->state;

		} else
			insn->state = state;
2106

2107
		insn->visited |= visited;
2108

2109
		if (!insn->ignore_alts) {
P
Peter Zijlstra 已提交
2110 2111
			bool skip_orig = false;

2112
			list_for_each_entry(alt, &insn->alts, list) {
P
Peter Zijlstra 已提交
2113 2114 2115
				if (alt->skip_orig)
					skip_orig = true;

2116
				ret = validate_branch(file, func, alt->insn, state);
2117 2118 2119 2120 2121
				if (ret) {
					if (backtrace)
						BT_FUNC("(alt)", insn);
					return ret;
				}
2122
			}
P
Peter Zijlstra 已提交
2123 2124 2125

			if (skip_orig)
				return 0;
2126 2127 2128 2129 2130
		}

		switch (insn->type) {

		case INSN_RETURN:
2131
			return validate_return(func, insn, &state);
2132 2133

		case INSN_CALL:
P
Peter Zijlstra 已提交
2134 2135 2136 2137
		case INSN_CALL_DYNAMIC:
			ret = validate_call(insn, &state);
			if (ret)
				return ret;
2138

2139 2140
			if (!no_fp && func && !is_fentry_call(insn) &&
			    !has_valid_stack_frame(&state)) {
2141 2142 2143 2144
				WARN_FUNC("call without frame pointer save/setup",
					  sec, insn->offset);
				return 1;
			}
2145 2146 2147 2148

			if (dead_end_function(file, insn->call_dest))
				return 0;

2149 2150 2151 2152
			break;

		case INSN_JUMP_CONDITIONAL:
		case INSN_JUMP_UNCONDITIONAL:
2153
			if (func && is_sibling_call(insn)) {
2154
				ret = validate_sibling_call(insn, &state);
2155
				if (ret)
2156
					return ret;
2157

2158
			} else if (insn->jump_dest) {
2159 2160
				ret = validate_branch(file, func,
						      insn->jump_dest, state);
2161 2162 2163 2164 2165
				if (ret) {
					if (backtrace)
						BT_FUNC("(branch)", insn);
					return ret;
				}
2166
			}
2167 2168 2169 2170 2171 2172 2173

			if (insn->type == INSN_JUMP_UNCONDITIONAL)
				return 0;

			break;

		case INSN_JUMP_DYNAMIC:
2174
		case INSN_JUMP_DYNAMIC_CONDITIONAL:
2175
			if (func && is_sibling_call(insn)) {
2176 2177 2178
				ret = validate_sibling_call(insn, &state);
				if (ret)
					return ret;
2179 2180
			}

2181 2182 2183 2184
			if (insn->type == INSN_JUMP_DYNAMIC)
				return 0;

			break;
2185

2186 2187 2188 2189 2190 2191 2192 2193
		case INSN_CONTEXT_SWITCH:
			if (func && (!next_insn || !next_insn->hint)) {
				WARN_FUNC("unsupported instruction in callable function",
					  sec, insn->offset);
				return 1;
			}
			return 0;

2194 2195
		case INSN_STACK:
			if (update_insn_state(insn, &state))
2196
				return 1;
2197

P
Peter Zijlstra 已提交
2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229
			if (insn->stack_op.dest.type == OP_DEST_PUSHF) {
				if (!state.uaccess_stack) {
					state.uaccess_stack = 1;
				} else if (state.uaccess_stack >> 31) {
					WARN_FUNC("PUSHF stack exhausted", sec, insn->offset);
					return 1;
				}
				state.uaccess_stack <<= 1;
				state.uaccess_stack  |= state.uaccess;
			}

			if (insn->stack_op.src.type == OP_SRC_POPF) {
				if (state.uaccess_stack) {
					state.uaccess = state.uaccess_stack & 1;
					state.uaccess_stack >>= 1;
					if (state.uaccess_stack == 1)
						state.uaccess_stack = 0;
				}
			}

			break;

		case INSN_STAC:
			if (state.uaccess) {
				WARN_FUNC("recursive UACCESS enable", sec, insn->offset);
				return 1;
			}

			state.uaccess = true;
			break;

		case INSN_CLAC:
2230
			if (!state.uaccess && func) {
P
Peter Zijlstra 已提交
2231 2232 2233 2234 2235 2236 2237 2238 2239 2240
				WARN_FUNC("redundant UACCESS disable", sec, insn->offset);
				return 1;
			}

			if (func_uaccess_safe(func) && !state.uaccess_stack) {
				WARN_FUNC("UACCESS-safe disables UACCESS", sec, insn->offset);
				return 1;
			}

			state.uaccess = false;
2241 2242
			break;

2243 2244 2245 2246 2247 2248 2249 2250
		case INSN_STD:
			if (state.df)
				WARN_FUNC("recursive STD", sec, insn->offset);

			state.df = true;
			break;

		case INSN_CLD:
2251
			if (!state.df && func)
2252 2253 2254
				WARN_FUNC("redundant CLD", sec, insn->offset);

			state.df = false;
2255 2256
			break;

2257 2258 2259 2260 2261 2262 2263
		default:
			break;
		}

		if (insn->dead_end)
			return 0;

2264 2265 2266
		if (!next_insn) {
			if (state.cfa.base == CFI_UNDEFINED)
				return 0;
2267 2268 2269
			WARN("%s: unexpected end of section", sec->name);
			return 1;
		}
2270 2271

		insn = next_insn;
2272 2273 2274 2275 2276
	}

	return 0;
}

2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289
static int validate_unwind_hints(struct objtool_file *file)
{
	struct instruction *insn;
	int ret, warnings = 0;
	struct insn_state state;

	if (!file->hints)
		return 0;

	clear_insn_state(&state);

	for_each_insn(file, insn) {
		if (insn->hint && !insn->visited) {
2290
			ret = validate_branch(file, insn->func, insn, state);
2291 2292
			if (ret && backtrace)
				BT_FUNC("<=== (hint)", insn);
2293 2294 2295 2296 2297 2298 2299
			warnings += ret;
		}
	}

	return warnings;
}

2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312
static int validate_retpoline(struct objtool_file *file)
{
	struct instruction *insn;
	int warnings = 0;

	for_each_insn(file, insn) {
		if (insn->type != INSN_JUMP_DYNAMIC &&
		    insn->type != INSN_CALL_DYNAMIC)
			continue;

		if (insn->retpoline_safe)
			continue;

2313 2314 2315 2316 2317 2318 2319 2320 2321
		/*
		 * .init.text code is ran before userspace and thus doesn't
		 * strictly need retpolines, except for modules which are
		 * loaded late, they very much do need retpoline in their
		 * .init.text
		 */
		if (!strcmp(insn->sec->name, ".init.text") && !module)
			continue;

2322 2323 2324 2325 2326 2327 2328 2329 2330 2331
		WARN_FUNC("indirect %s found in RETPOLINE build",
			  insn->sec, insn->offset,
			  insn->type == INSN_JUMP_DYNAMIC ? "jump" : "call");

		warnings++;
	}

	return warnings;
}

2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344
static bool is_kasan_insn(struct instruction *insn)
{
	return (insn->type == INSN_CALL &&
		!strcmp(insn->call_dest->name, "__asan_handle_no_return"));
}

static bool is_ubsan_insn(struct instruction *insn)
{
	return (insn->type == INSN_CALL &&
		!strcmp(insn->call_dest->name,
			"__ubsan_handle_builtin_unreachable"));
}

2345
static bool ignore_unreachable_insn(struct instruction *insn)
2346 2347 2348
{
	int i;

2349 2350 2351 2352 2353 2354
	if (insn->ignore || insn->type == INSN_NOP)
		return true;

	/*
	 * Ignore any unused exceptions.  This can happen when a whitelisted
	 * function has an exception table entry.
2355 2356 2357
	 *
	 * Also ignore alternative replacement instructions.  This can happen
	 * when a whitelisted function uses one of the ALTERNATIVE macros.
2358
	 */
2359 2360 2361
	if (!strcmp(insn->sec->name, ".fixup") ||
	    !strcmp(insn->sec->name, ".altinstr_replacement") ||
	    !strcmp(insn->sec->name, ".altinstr_aux"))
2362 2363
		return true;

2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378
	if (!insn->func)
		return false;

	/*
	 * CONFIG_UBSAN_TRAP inserts a UD2 when it sees
	 * __builtin_unreachable().  The BUG() macro has an unreachable() after
	 * the UD2, which causes GCC's undefined trap logic to emit another UD2
	 * (or occasionally a JMP to UD2).
	 */
	if (list_prev_entry(insn, list)->dead_end &&
	    (insn->type == INSN_BUG ||
	     (insn->type == INSN_JUMP_UNCONDITIONAL &&
	      insn->jump_dest && insn->jump_dest->type == INSN_BUG)))
		return true;

2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389
	/*
	 * Check if this (or a subsequent) instruction is related to
	 * CONFIG_UBSAN or CONFIG_KASAN.
	 *
	 * End the search at 5 instructions to avoid going into the weeds.
	 */
	for (i = 0; i < 5; i++) {

		if (is_kasan_insn(insn) || is_ubsan_insn(insn))
			return true;

2390 2391 2392 2393 2394 2395 2396 2397
		if (insn->type == INSN_JUMP_UNCONDITIONAL) {
			if (insn->jump_dest &&
			    insn->jump_dest->func == insn->func) {
				insn = insn->jump_dest;
				continue;
			}

			break;
2398 2399
		}

2400
		if (insn->offset + insn->len >= insn->func->offset + insn->func->len)
2401
			break;
2402

2403 2404 2405 2406 2407 2408
		insn = list_next_entry(insn, list);
	}

	return false;
}

2409
static int validate_section(struct objtool_file *file, struct section *sec)
2410 2411 2412
{
	struct symbol *func;
	struct instruction *insn;
2413
	struct insn_state state;
2414 2415
	int ret, warnings = 0;

2416 2417 2418 2419 2420 2421 2422
	clear_insn_state(&state);

	state.cfa = initial_func_cfi.cfa;
	memcpy(&state.regs, &initial_func_cfi.regs,
	       CFI_NUM_REGS * sizeof(struct cfi_reg));
	state.stack_size = initial_func_cfi.cfa.offset;

2423 2424 2425
	list_for_each_entry(func, &sec->symbol_list, list) {
		if (func->type != STT_FUNC)
			continue;
2426

2427 2428 2429 2430 2431
		if (!func->len) {
			WARN("%s() is missing an ELF size annotation",
			     func->name);
			warnings++;
		}
2432

2433 2434
		if (func->pfunc != func || func->alias != func)
			continue;
2435

2436 2437 2438
		insn = find_insn(file, sec, func->offset);
		if (!insn || insn->ignore || insn->visited)
			continue;
2439

2440
		state.uaccess = func->uaccess_safe;
P
Peter Zijlstra 已提交
2441

2442 2443 2444 2445
		ret = validate_branch(file, func, insn, state);
		if (ret && backtrace)
			BT_FUNC("<=== (func)", insn);
		warnings += ret;
2446 2447 2448 2449 2450
	}

	return warnings;
}

2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461
static int validate_functions(struct objtool_file *file)
{
	struct section *sec;
	int warnings = 0;

	for_each_sec(file, sec)
		warnings += validate_section(file, sec);

	return warnings;
}

2462
static int validate_reachable_instructions(struct objtool_file *file)
2463 2464
{
	struct instruction *insn;
2465 2466 2467

	if (file->ignore_unreachables)
		return 0;
2468 2469

	for_each_insn(file, insn) {
2470 2471 2472 2473 2474
		if (insn->visited || ignore_unreachable_insn(insn))
			continue;

		WARN_FUNC("unreachable instruction", insn->sec, insn->offset);
		return 1;
2475 2476
	}

2477
	return 0;
2478 2479
}

2480 2481
static struct objtool_file file;

2482
int check(const char *_objname, bool orc)
2483 2484 2485 2486 2487
{
	int ret, warnings = 0;

	objname = _objname;

2488
	file.elf = elf_read(objname, orc ? O_RDWR : O_RDONLY);
2489
	if (!file.elf)
2490 2491 2492 2493 2494
		return 1;

	INIT_LIST_HEAD(&file.insn_list);
	hash_init(file.insn_hash);
	file.c_file = find_section_by_name(file.elf, ".comment");
2495
	file.ignore_unreachables = no_unreachable;
2496
	file.hints = false;
2497

2498 2499
	arch_initial_func_cfi_state(&initial_func_cfi);

2500 2501 2502 2503 2504
	ret = decode_sections(&file);
	if (ret < 0)
		goto out;
	warnings += ret;

2505
	if (list_empty(&file.insn_list))
2506 2507
		goto out;

2508 2509 2510 2511 2512 2513 2514
	if (retpoline) {
		ret = validate_retpoline(&file);
		if (ret < 0)
			return ret;
		warnings += ret;
	}

2515
	ret = validate_functions(&file);
2516 2517 2518 2519
	if (ret < 0)
		goto out;
	warnings += ret;

2520 2521 2522 2523 2524
	ret = validate_unwind_hints(&file);
	if (ret < 0)
		goto out;
	warnings += ret;

2525 2526 2527 2528 2529 2530 2531
	if (!warnings) {
		ret = validate_reachable_instructions(&file);
		if (ret < 0)
			goto out;
		warnings += ret;
	}

2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545
	if (orc) {
		ret = create_orc(&file);
		if (ret < 0)
			goto out;

		ret = create_orc_sections(&file);
		if (ret < 0)
			goto out;

		ret = elf_write(file.elf);
		if (ret < 0)
			goto out;
	}

2546
out:
2547 2548 2549 2550 2551 2552 2553 2554 2555
	if (ret < 0) {
		/*
		 *  Fatal error.  The binary is corrupt or otherwise broken in
		 *  some way, or objtool itself is broken.  Fail the kernel
		 *  build.
		 */
		return ret;
	}

2556 2557
	return 0;
}