check.c 60.3 KB
Newer Older
1
// SPDX-License-Identifier: GPL-2.0-or-later
2 3 4 5 6 7 8
/*
 * Copyright (C) 2015-2017 Josh Poimboeuf <jpoimboe@redhat.com>
 */

#include <string.h>
#include <stdlib.h>

9
#include "builtin.h"
10 11 12 13 14 15 16 17 18
#include "check.h"
#include "elf.h"
#include "special.h"
#include "arch.h"
#include "warn.h"

#include <linux/hashtable.h>
#include <linux/kernel.h>

19 20
#define FAKE_JUMP_OFFSET -1

21 22
#define C_JUMP_TABLE_SECTION ".rodata..c_jump_table"

23 24 25
struct alternative {
	struct list_head list;
	struct instruction *insn;
P
Peter Zijlstra 已提交
26
	bool skip_orig;
27 28 29
};

const char *objname;
30
struct cfi_init_state initial_func_cfi;
31

32 33
struct instruction *find_insn(struct objtool_file *file,
			      struct section *sec, unsigned long offset)
34 35 36 37 38 39 40 41 42 43 44 45 46 47 48
{
	struct instruction *insn;

	hash_for_each_possible(file->insn_hash, insn, hash, offset)
		if (insn->sec == sec && insn->offset == offset)
			return insn;

	return NULL;
}

static struct instruction *next_insn_same_sec(struct objtool_file *file,
					      struct instruction *insn)
{
	struct instruction *next = list_next_entry(insn, list);

49
	if (!next || &next->list == &file->insn_list || next->sec != insn->sec)
50 51 52 53 54
		return NULL;

	return next;
}

55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74
static struct instruction *next_insn_same_func(struct objtool_file *file,
					       struct instruction *insn)
{
	struct instruction *next = list_next_entry(insn, list);
	struct symbol *func = insn->func;

	if (!func)
		return NULL;

	if (&next->list != &file->insn_list && next->func == func)
		return next;

	/* Check if we're already in the subfunction: */
	if (func == func->cfunc)
		return NULL;

	/* Move to the subfunction: */
	return find_insn(file, func->cfunc->sec, func->cfunc->offset);
}

75
#define func_for_each_insn(file, func, insn)				\
76 77 78 79
	for (insn = find_insn(file, func->sec, func->offset);		\
	     insn;							\
	     insn = next_insn_same_func(file, insn))

80 81
#define sym_for_each_insn(file, sym, insn)				\
	for (insn = find_insn(file, sym->sec, sym->offset);		\
82
	     insn && &insn->list != &file->insn_list &&			\
83 84
		insn->sec == sym->sec &&				\
		insn->offset < sym->offset + sym->len;			\
85 86
	     insn = list_next_entry(insn, list))

87
#define sym_for_each_insn_continue_reverse(file, sym, insn)		\
88 89
	for (insn = list_prev_entry(insn, list);			\
	     &insn->list != &file->insn_list &&				\
90
		insn->sec == sym->sec && insn->offset >= sym->offset;	\
91 92 93 94 95
	     insn = list_prev_entry(insn, list))

#define sec_for_each_insn_from(file, insn)				\
	for (; insn; insn = next_insn_same_sec(file, insn))

96 97 98
#define sec_for_each_insn_continue(file, insn)				\
	for (insn = next_insn_same_sec(file, insn); insn;		\
	     insn = next_insn_same_sec(file, insn))
99

100 101 102 103 104 105
static bool is_static_jump(struct instruction *insn)
{
	return insn->type == INSN_JUMP_CONDITIONAL ||
	       insn->type == INSN_JUMP_UNCONDITIONAL;
}

106 107 108 109 110 111
static bool is_sibling_call(struct instruction *insn)
{
	/* An indirect jump is either a sibling call or a jump to a table. */
	if (insn->type == INSN_JUMP_DYNAMIC)
		return list_empty(&insn->alts);

112
	if (!is_static_jump(insn))
113 114 115 116 117 118
		return false;

	/* add_jump_destinations() sets insn->call_dest for sibling calls. */
	return !!insn->call_dest;
}

119 120 121 122 123 124 125 126 127
/*
 * This checks to see if the given function is a "noreturn" function.
 *
 * For global functions which are outside the scope of this object file, we
 * have to keep a manual list of them.
 *
 * For local functions, we have to detect them manually by simply looking for
 * the lack of a return instruction.
 */
128 129
static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
				int recursion)
130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148
{
	int i;
	struct instruction *insn;
	bool empty = true;

	/*
	 * Unfortunately these have to be hard coded because the noreturn
	 * attribute isn't provided in ELF data.
	 */
	static const char * const global_noreturns[] = {
		"__stack_chk_fail",
		"panic",
		"do_exit",
		"do_task_dead",
		"__module_put_and_exit",
		"complete_and_exit",
		"__reiserfs_panic",
		"lbug_with_loc",
		"fortify_panic",
149
		"usercopy_abort",
150
		"machine_real_restart",
151
		"rewind_stack_do_exit",
152
		"kunit_try_catch_throw",
153 154
	};

155 156 157
	if (!func)
		return false;

158
	if (func->bind == STB_WEAK)
159
		return false;
160 161 162 163

	if (func->bind == STB_GLOBAL)
		for (i = 0; i < ARRAY_SIZE(global_noreturns); i++)
			if (!strcmp(func->name, global_noreturns[i]))
164
				return true;
165

166
	if (!func->len)
167
		return false;
168

169 170
	insn = find_insn(file, func->sec, func->offset);
	if (!insn->func)
171
		return false;
172

173
	func_for_each_insn(file, func, insn) {
174 175 176
		empty = false;

		if (insn->type == INSN_RETURN)
177
			return false;
178 179 180
	}

	if (empty)
181
		return false;
182 183 184 185 186 187

	/*
	 * A function can have a sibling call instead of a return.  In that
	 * case, the function's dead-end status depends on whether the target
	 * of the sibling call returns.
	 */
188
	func_for_each_insn(file, func, insn) {
189
		if (is_sibling_call(insn)) {
190 191 192 193
			struct instruction *dest = insn->jump_dest;

			if (!dest)
				/* sibling call to another file */
194
				return false;
195

196 197 198 199 200 201 202 203
			/* local sibling call */
			if (recursion == 5) {
				/*
				 * Infinite recursion: two functions have
				 * sibling calls to each other.  This is a very
				 * rare case.  It means they aren't dead ends.
				 */
				return false;
204 205
			}

206 207
			return __dead_end_function(file, dest->func, recursion+1);
		}
208 209
	}

210
	return true;
211 212
}

213
static bool dead_end_function(struct objtool_file *file, struct symbol *func)
214 215 216 217
{
	return __dead_end_function(file, func, 0);
}

218
static void init_cfi_state(struct cfi_state *cfi)
219 220 221
{
	int i;

222
	for (i = 0; i < CFI_NUM_REGS; i++) {
223 224
		cfi->regs[i].base = CFI_UNDEFINED;
		cfi->vals[i].base = CFI_UNDEFINED;
225
	}
226 227 228 229 230 231 232 233 234
	cfi->cfa.base = CFI_UNDEFINED;
	cfi->drap_reg = CFI_UNDEFINED;
	cfi->drap_offset = -1;
}

static void clear_insn_state(struct insn_state *state)
{
	memset(state, 0, sizeof(*state));
	init_cfi_state(&state->cfi);
235 236
}

237 238 239 240 241 242 243 244 245 246
/*
 * Call the arch-specific instruction decoder for all the instructions and add
 * them to the global instruction list.
 */
static int decode_instructions(struct objtool_file *file)
{
	struct section *sec;
	struct symbol *func;
	unsigned long offset;
	struct instruction *insn;
P
Peter Zijlstra 已提交
247
	unsigned long nr_insns = 0;
248 249
	int ret;

250
	for_each_sec(file, sec) {
251 252 253 254

		if (!(sec->sh.sh_flags & SHF_EXECINSTR))
			continue;

255 256 257 258 259
		if (strcmp(sec->name, ".altinstr_replacement") &&
		    strcmp(sec->name, ".altinstr_aux") &&
		    strncmp(sec->name, ".discard.", 9))
			sec->text = true;

260 261
		for (offset = 0; offset < sec->len; offset += insn->len) {
			insn = malloc(sizeof(*insn));
262 263 264 265
			if (!insn) {
				WARN("malloc failed");
				return -1;
			}
266 267
			memset(insn, 0, sizeof(*insn));
			INIT_LIST_HEAD(&insn->alts);
268
			INIT_LIST_HEAD(&insn->stack_ops);
269
			init_cfi_state(&insn->cfi);
270

271 272 273 274 275 276
			insn->sec = sec;
			insn->offset = offset;

			ret = arch_decode_instruction(file->elf, sec, offset,
						      sec->len - offset,
						      &insn->len, &insn->type,
277
						      &insn->immediate,
278
						      &insn->stack_ops);
279
			if (ret)
280
				goto err;
281 282 283

			hash_add(file->insn_hash, &insn->hash, insn->offset);
			list_add_tail(&insn->list, &file->insn_list);
P
Peter Zijlstra 已提交
284
			nr_insns++;
285 286 287
		}

		list_for_each_entry(func, &sec->symbol_list, list) {
288
			if (func->type != STT_FUNC || func->alias != func)
289 290 291 292 293 294 295 296
				continue;

			if (!find_insn(file, sec, func->offset)) {
				WARN("%s(): can't find starting instruction",
				     func->name);
				return -1;
			}

297
			sym_for_each_insn(file, func, insn)
298
				insn->func = func;
299 300 301
		}
	}

P
Peter Zijlstra 已提交
302 303 304
	if (stats)
		printf("nr_insns: %lu\n", nr_insns);

305
	return 0;
306 307 308 309

err:
	free(insn);
	return ret;
310 311 312
}

/*
313
 * Mark "ud2" instructions and manually annotated dead ends.
314 315 316 317 318 319 320 321
 */
static int add_dead_ends(struct objtool_file *file)
{
	struct section *sec;
	struct rela *rela;
	struct instruction *insn;
	bool found;

322 323 324 325 326 327 328 329 330 331 332
	/*
	 * By default, "ud2" is a dead end unless otherwise annotated, because
	 * GCC 7 inserts it for certain divide-by-zero cases.
	 */
	for_each_insn(file, insn)
		if (insn->type == INSN_BUG)
			insn->dead_end = true;

	/*
	 * Check for manually annotated dead ends.
	 */
333 334
	sec = find_section_by_name(file->elf, ".rela.discard.unreachable");
	if (!sec)
335
		goto reachable;
336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367

	list_for_each_entry(rela, &sec->rela_list, list) {
		if (rela->sym->type != STT_SECTION) {
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}
		insn = find_insn(file, rela->sym->sec, rela->addend);
		if (insn)
			insn = list_prev_entry(insn, list);
		else if (rela->addend == rela->sym->sec->len) {
			found = false;
			list_for_each_entry_reverse(insn, &file->insn_list, list) {
				if (insn->sec == rela->sym->sec) {
					found = true;
					break;
				}
			}

			if (!found) {
				WARN("can't find unreachable insn at %s+0x%x",
				     rela->sym->sec->name, rela->addend);
				return -1;
			}
		} else {
			WARN("can't find unreachable insn at %s+0x%x",
			     rela->sym->sec->name, rela->addend);
			return -1;
		}

		insn->dead_end = true;
	}

368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409
reachable:
	/*
	 * These manually annotated reachable checks are needed for GCC 4.4,
	 * where the Linux unreachable() macro isn't supported.  In that case
	 * GCC doesn't know the "ud2" is fatal, so it generates code as if it's
	 * not a dead end.
	 */
	sec = find_section_by_name(file->elf, ".rela.discard.reachable");
	if (!sec)
		return 0;

	list_for_each_entry(rela, &sec->rela_list, list) {
		if (rela->sym->type != STT_SECTION) {
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}
		insn = find_insn(file, rela->sym->sec, rela->addend);
		if (insn)
			insn = list_prev_entry(insn, list);
		else if (rela->addend == rela->sym->sec->len) {
			found = false;
			list_for_each_entry_reverse(insn, &file->insn_list, list) {
				if (insn->sec == rela->sym->sec) {
					found = true;
					break;
				}
			}

			if (!found) {
				WARN("can't find reachable insn at %s+0x%x",
				     rela->sym->sec->name, rela->addend);
				return -1;
			}
		} else {
			WARN("can't find reachable insn at %s+0x%x",
			     rela->sym->sec->name, rela->addend);
			return -1;
		}

		insn->dead_end = false;
	}

410 411 412 413 414 415 416 417 418 419 420
	return 0;
}

/*
 * Warnings shouldn't be reported for ignored functions.
 */
static void add_ignores(struct objtool_file *file)
{
	struct instruction *insn;
	struct section *sec;
	struct symbol *func;
P
Peter Zijlstra 已提交
421
	struct rela *rela;
422

P
Peter Zijlstra 已提交
423 424 425
	sec = find_section_by_name(file->elf, ".rela.discard.func_stack_frame_non_standard");
	if (!sec)
		return;
426

P
Peter Zijlstra 已提交
427 428 429 430 431 432 433
	list_for_each_entry(rela, &sec->rela_list, list) {
		switch (rela->sym->type) {
		case STT_FUNC:
			func = rela->sym;
			break;

		case STT_SECTION:
434 435
			func = find_func_by_offset(rela->sym->sec, rela->addend);
			if (!func)
436
				continue;
P
Peter Zijlstra 已提交
437
			break;
438

P
Peter Zijlstra 已提交
439 440 441
		default:
			WARN("unexpected relocation symbol type in %s: %d", sec->name, rela->sym->type);
			continue;
442
		}
P
Peter Zijlstra 已提交
443

444
		func_for_each_insn(file, func, insn)
P
Peter Zijlstra 已提交
445
			insn->ignore = true;
446 447 448
	}
}

P
Peter Zijlstra 已提交
449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496
/*
 * This is a whitelist of functions that is allowed to be called with AC set.
 * The list is meant to be minimal and only contains compiler instrumentation
 * ABI and a few functions used to implement *_{to,from}_user() functions.
 *
 * These functions must not directly change AC, but may PUSHF/POPF.
 */
static const char *uaccess_safe_builtin[] = {
	/* KASAN */
	"kasan_report",
	"check_memory_region",
	/* KASAN out-of-line */
	"__asan_loadN_noabort",
	"__asan_load1_noabort",
	"__asan_load2_noabort",
	"__asan_load4_noabort",
	"__asan_load8_noabort",
	"__asan_load16_noabort",
	"__asan_storeN_noabort",
	"__asan_store1_noabort",
	"__asan_store2_noabort",
	"__asan_store4_noabort",
	"__asan_store8_noabort",
	"__asan_store16_noabort",
	/* KASAN in-line */
	"__asan_report_load_n_noabort",
	"__asan_report_load1_noabort",
	"__asan_report_load2_noabort",
	"__asan_report_load4_noabort",
	"__asan_report_load8_noabort",
	"__asan_report_load16_noabort",
	"__asan_report_store_n_noabort",
	"__asan_report_store1_noabort",
	"__asan_report_store2_noabort",
	"__asan_report_store4_noabort",
	"__asan_report_store8_noabort",
	"__asan_report_store16_noabort",
	/* KCOV */
	"write_comp_data",
	"__sanitizer_cov_trace_pc",
	"__sanitizer_cov_trace_const_cmp1",
	"__sanitizer_cov_trace_const_cmp2",
	"__sanitizer_cov_trace_const_cmp4",
	"__sanitizer_cov_trace_const_cmp8",
	"__sanitizer_cov_trace_cmp1",
	"__sanitizer_cov_trace_cmp2",
	"__sanitizer_cov_trace_cmp4",
	"__sanitizer_cov_trace_cmp8",
497
	"__sanitizer_cov_trace_switch",
P
Peter Zijlstra 已提交
498 499 500 501
	/* UBSAN */
	"ubsan_type_mismatch_common",
	"__ubsan_handle_type_mismatch",
	"__ubsan_handle_type_mismatch_v1",
502
	"__ubsan_handle_shift_out_of_bounds",
P
Peter Zijlstra 已提交
503 504 505
	/* misc */
	"csum_partial_copy_generic",
	"__memcpy_mcsafe",
506
	"mcsafe_handle_tail",
P
Peter Zijlstra 已提交
507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523
	"ftrace_likely_update", /* CONFIG_TRACE_BRANCH_PROFILING */
	NULL
};

static void add_uaccess_safe(struct objtool_file *file)
{
	struct symbol *func;
	const char **name;

	if (!uaccess)
		return;

	for (name = uaccess_safe_builtin; *name; name++) {
		func = find_symbol_by_name(file->elf, *name);
		if (!func)
			continue;

524
		func->uaccess_safe = true;
525 526 527
	}
}

528 529 530 531 532 533
/*
 * FIXME: For now, just ignore any alternatives which add retpolines.  This is
 * a temporary hack, as it doesn't allow ORC to unwind from inside a retpoline.
 * But it at least allows objtool to understand the control flow *around* the
 * retpoline.
 */
534
static int add_ignore_alternatives(struct objtool_file *file)
535 536 537 538 539
{
	struct section *sec;
	struct rela *rela;
	struct instruction *insn;

540
	sec = find_section_by_name(file->elf, ".rela.discard.ignore_alts");
541 542 543 544 545 546 547 548 549 550 551
	if (!sec)
		return 0;

	list_for_each_entry(rela, &sec->rela_list, list) {
		if (rela->sym->type != STT_SECTION) {
			WARN("unexpected relocation symbol type in %s", sec->name);
			return -1;
		}

		insn = find_insn(file, rela->sym->sec, rela->addend);
		if (!insn) {
552
			WARN("bad .discard.ignore_alts entry");
553 554 555 556 557 558 559 560 561
			return -1;
		}

		insn->ignore_alts = true;
	}

	return 0;
}

562 563 564 565 566 567 568 569 570 571 572
/*
 * Find the destination instructions for all jumps.
 */
static int add_jump_destinations(struct objtool_file *file)
{
	struct instruction *insn;
	struct rela *rela;
	struct section *dest_sec;
	unsigned long dest_off;

	for_each_insn(file, insn) {
573
		if (!is_static_jump(insn))
574 575
			continue;

576
		if (insn->ignore || insn->offset == FAKE_JUMP_OFFSET)
577 578
			continue;

579 580
		rela = find_rela_by_dest_range(file->elf, insn->sec,
					       insn->offset, insn->len);
581 582
		if (!rela) {
			dest_sec = insn->sec;
583
			dest_off = arch_jump_destination(insn);
584 585
		} else if (rela->sym->type == STT_SECTION) {
			dest_sec = rela->sym->sec;
586
			dest_off = arch_dest_rela_offset(rela->addend);
587 588
		} else if (rela->sym->sec->idx) {
			dest_sec = rela->sym->sec;
589 590
			dest_off = rela->sym->sym.st_value +
				   arch_dest_rela_offset(rela->addend);
591 592 593 594 595
		} else if (strstr(rela->sym->name, "_indirect_thunk_")) {
			/*
			 * Retpoline jumps are really dynamic jumps in
			 * disguise, so convert them accordingly.
			 */
596 597 598 599 600
			if (insn->type == INSN_JUMP_UNCONDITIONAL)
				insn->type = INSN_JUMP_DYNAMIC;
			else
				insn->type = INSN_JUMP_DYNAMIC_CONDITIONAL;

601
			insn->retpoline_safe = true;
602
			continue;
603
		} else {
604
			/* external sibling call */
605
			insn->call_dest = rela->sym;
606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624
			continue;
		}

		insn->jump_dest = find_insn(file, dest_sec, dest_off);
		if (!insn->jump_dest) {

			/*
			 * This is a special case where an alt instruction
			 * jumps past the end of the section.  These are
			 * handled later in handle_group_alt().
			 */
			if (!strcmp(insn->sec->name, ".altinstr_replacement"))
				continue;

			WARN_FUNC("can't find jump dest instruction at %s+0x%lx",
				  insn->sec, insn->offset, dest_sec->name,
				  dest_off);
			return -1;
		}
625 626

		/*
627
		 * Cross-function jump.
628 629
		 */
		if (insn->func && insn->jump_dest->func &&
630 631 632 633 634 635 636 637 638 639 640 641 642 643 644
		    insn->func != insn->jump_dest->func) {

			/*
			 * For GCC 8+, create parent/child links for any cold
			 * subfunctions.  This is _mostly_ redundant with a
			 * similar initialization in read_symbols().
			 *
			 * If a function has aliases, we want the *first* such
			 * function in the symbol table to be the subfunction's
			 * parent.  In that case we overwrite the
			 * initialization done in read_symbols().
			 *
			 * However this code can't completely replace the
			 * read_symbols() code because this doesn't detect the
			 * case where the parent function's only reference to a
645
			 * subfunction is through a jump table.
646 647 648 649 650 651 652 653 654
			 */
			if (!strstr(insn->func->name, ".cold.") &&
			    strstr(insn->jump_dest->func->name, ".cold.")) {
				insn->func->cfunc = insn->jump_dest->func;
				insn->jump_dest->func->pfunc = insn->func;

			} else if (insn->jump_dest->func->pfunc != insn->func->pfunc &&
				   insn->jump_dest->offset == insn->jump_dest->func->offset) {

655
				/* internal sibling call */
656 657
				insn->call_dest = insn->jump_dest->func;
			}
658
		}
659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676
	}

	return 0;
}

/*
 * Find the destination instructions for all calls.
 */
static int add_call_destinations(struct objtool_file *file)
{
	struct instruction *insn;
	unsigned long dest_off;
	struct rela *rela;

	for_each_insn(file, insn) {
		if (insn->type != INSN_CALL)
			continue;

677 678
		rela = find_rela_by_dest_range(file->elf, insn->sec,
					       insn->offset, insn->len);
679
		if (!rela) {
680
			dest_off = arch_jump_destination(insn);
681 682 683
			insn->call_dest = find_func_by_offset(insn->sec, dest_off);
			if (!insn->call_dest)
				insn->call_dest = find_symbol_by_offset(insn->sec, dest_off);
684

685 686 687 688
			if (insn->ignore)
				continue;

			if (!insn->call_dest) {
689 690
				WARN_FUNC("unsupported intra-function call",
					  insn->sec, insn->offset);
691 692
				if (retpoline)
					WARN("If this is a retpoline, please patch it in with alternatives and annotate it with ANNOTATE_NOSPEC_ALTERNATIVE.");
693 694
				return -1;
			}
695

696 697 698 699 700 701
			if (insn->func && insn->call_dest->type != STT_FUNC) {
				WARN_FUNC("unsupported call to non-function",
					  insn->sec, insn->offset);
				return -1;
			}

702
		} else if (rela->sym->type == STT_SECTION) {
703
			dest_off = arch_dest_rela_offset(rela->addend);
704
			insn->call_dest = find_func_by_offset(rela->sym->sec,
705
							      dest_off);
706
			if (!insn->call_dest) {
707
				WARN_FUNC("can't find call dest symbol at %s+0x%lx",
708 709
					  insn->sec, insn->offset,
					  rela->sym->sec->name,
710
					  dest_off);
711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741
				return -1;
			}
		} else
			insn->call_dest = rela->sym;
	}

	return 0;
}

/*
 * The .alternatives section requires some extra special care, over and above
 * what other special sections require:
 *
 * 1. Because alternatives are patched in-place, we need to insert a fake jump
 *    instruction at the end so that validate_branch() skips all the original
 *    replaced instructions when validating the new instruction path.
 *
 * 2. An added wrinkle is that the new instruction length might be zero.  In
 *    that case the old instructions are replaced with noops.  We simulate that
 *    by creating a fake jump as the only new instruction.
 *
 * 3. In some cases, the alternative section includes an instruction which
 *    conditionally jumps to the _end_ of the entry.  We have to modify these
 *    jumps' destinations to point back to .text rather than the end of the
 *    entry in .altinstr_replacement.
 */
static int handle_group_alt(struct objtool_file *file,
			    struct special_alt *special_alt,
			    struct instruction *orig_insn,
			    struct instruction **new_insn)
{
742
	struct instruction *last_orig_insn, *last_new_insn, *insn, *fake_jump = NULL;
743 744 745 746 747 748 749 750 751 752 753 754
	unsigned long dest_off;

	last_orig_insn = NULL;
	insn = orig_insn;
	sec_for_each_insn_from(file, insn) {
		if (insn->offset >= special_alt->orig_off + special_alt->orig_len)
			break;

		insn->alt_group = true;
		last_orig_insn = insn;
	}

755 756 757 758 759 760 761 762
	if (next_insn_same_sec(file, last_orig_insn)) {
		fake_jump = malloc(sizeof(*fake_jump));
		if (!fake_jump) {
			WARN("malloc failed");
			return -1;
		}
		memset(fake_jump, 0, sizeof(*fake_jump));
		INIT_LIST_HEAD(&fake_jump->alts);
763
		INIT_LIST_HEAD(&fake_jump->stack_ops);
764
		init_cfi_state(&fake_jump->cfi);
765 766

		fake_jump->sec = special_alt->new_sec;
767
		fake_jump->offset = FAKE_JUMP_OFFSET;
768 769
		fake_jump->type = INSN_JUMP_UNCONDITIONAL;
		fake_jump->jump_dest = list_next_entry(last_orig_insn, list);
770
		fake_jump->func = orig_insn->func;
771 772 773
	}

	if (!special_alt->new_len) {
774 775 776 777 778 779
		if (!fake_jump) {
			WARN("%s: empty alternative at end of section",
			     special_alt->orig_sec->name);
			return -1;
		}

780 781 782 783 784 785 786 787 788 789 790 791
		*new_insn = fake_jump;
		return 0;
	}

	last_new_insn = NULL;
	insn = *new_insn;
	sec_for_each_insn_from(file, insn) {
		if (insn->offset >= special_alt->new_off + special_alt->new_len)
			break;

		last_new_insn = insn;

792
		insn->ignore = orig_insn->ignore_alts;
793
		insn->func = orig_insn->func;
794

795 796 797 798 799 800 801 802 803 804 805 806 807 808
		/*
		 * Since alternative replacement code is copy/pasted by the
		 * kernel after applying relocations, generally such code can't
		 * have relative-address relocation references to outside the
		 * .altinstr_replacement section, unless the arch's
		 * alternatives code can adjust the relative offsets
		 * accordingly.
		 *
		 * The x86 alternatives code adjusts the offsets only when it
		 * encounters a branch instruction at the very beginning of the
		 * replacement group.
		 */
		if ((insn->offset != special_alt->new_off ||
		    (insn->type != INSN_CALL && !is_static_jump(insn))) &&
809
		    find_rela_by_dest_range(file->elf, insn->sec, insn->offset, insn->len)) {
810 811 812 813 814 815

			WARN_FUNC("unsupported relocation in alternatives section",
				  insn->sec, insn->offset);
			return -1;
		}

816
		if (!is_static_jump(insn))
817 818 819 820 821
			continue;

		if (!insn->immediate)
			continue;

822
		dest_off = arch_jump_destination(insn);
823 824 825 826 827 828
		if (dest_off == special_alt->new_off + special_alt->new_len) {
			if (!fake_jump) {
				WARN("%s: alternative jump to end of section",
				     special_alt->orig_sec->name);
				return -1;
			}
829
			insn->jump_dest = fake_jump;
830
		}
831 832 833 834 835 836 837 838 839 840 841 842 843 844

		if (!insn->jump_dest) {
			WARN_FUNC("can't find alternative jump destination",
				  insn->sec, insn->offset);
			return -1;
		}
	}

	if (!last_new_insn) {
		WARN_FUNC("can't find last new alternative instruction",
			  special_alt->new_sec, special_alt->new_off);
		return -1;
	}

845 846
	if (fake_jump)
		list_add(&fake_jump->list, &last_new_insn->list);
847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916

	return 0;
}

/*
 * A jump table entry can either convert a nop to a jump or a jump to a nop.
 * If the original instruction is a jump, make the alt entry an effective nop
 * by just skipping the original instruction.
 */
static int handle_jump_alt(struct objtool_file *file,
			   struct special_alt *special_alt,
			   struct instruction *orig_insn,
			   struct instruction **new_insn)
{
	if (orig_insn->type == INSN_NOP)
		return 0;

	if (orig_insn->type != INSN_JUMP_UNCONDITIONAL) {
		WARN_FUNC("unsupported instruction at jump label",
			  orig_insn->sec, orig_insn->offset);
		return -1;
	}

	*new_insn = list_next_entry(orig_insn, list);
	return 0;
}

/*
 * Read all the special sections which have alternate instructions which can be
 * patched in or redirected to at runtime.  Each instruction having alternate
 * instruction(s) has them added to its insn->alts list, which will be
 * traversed in validate_branch().
 */
static int add_special_section_alts(struct objtool_file *file)
{
	struct list_head special_alts;
	struct instruction *orig_insn, *new_insn;
	struct special_alt *special_alt, *tmp;
	struct alternative *alt;
	int ret;

	ret = special_get_alts(file->elf, &special_alts);
	if (ret)
		return ret;

	list_for_each_entry_safe(special_alt, tmp, &special_alts, list) {

		orig_insn = find_insn(file, special_alt->orig_sec,
				      special_alt->orig_off);
		if (!orig_insn) {
			WARN_FUNC("special: can't find orig instruction",
				  special_alt->orig_sec, special_alt->orig_off);
			ret = -1;
			goto out;
		}

		new_insn = NULL;
		if (!special_alt->group || special_alt->new_len) {
			new_insn = find_insn(file, special_alt->new_sec,
					     special_alt->new_off);
			if (!new_insn) {
				WARN_FUNC("special: can't find new instruction",
					  special_alt->new_sec,
					  special_alt->new_off);
				ret = -1;
				goto out;
			}
		}

		if (special_alt->group) {
917 918 919 920 921 922
			if (!special_alt->orig_len) {
				WARN_FUNC("empty alternative entry",
					  orig_insn->sec, orig_insn->offset);
				continue;
			}

923 924 925 926 927 928 929 930 931 932 933
			ret = handle_group_alt(file, special_alt, orig_insn,
					       &new_insn);
			if (ret)
				goto out;
		} else if (special_alt->jump_or_nop) {
			ret = handle_jump_alt(file, special_alt, orig_insn,
					      &new_insn);
			if (ret)
				goto out;
		}

934 935 936 937 938 939 940
		alt = malloc(sizeof(*alt));
		if (!alt) {
			WARN("malloc failed");
			ret = -1;
			goto out;
		}

941
		alt->insn = new_insn;
P
Peter Zijlstra 已提交
942
		alt->skip_orig = special_alt->skip_orig;
P
Peter Zijlstra 已提交
943
		orig_insn->ignore_alts |= special_alt->skip_alt;
944 945 946 947 948 949 950 951 952 953
		list_add_tail(&alt->list, &orig_insn->alts);

		list_del(&special_alt->list);
		free(special_alt);
	}

out:
	return ret;
}

954
static int add_jump_table(struct objtool_file *file, struct instruction *insn,
955
			    struct rela *table)
956 957
{
	struct rela *rela = table;
958
	struct instruction *dest_insn;
959
	struct alternative *alt;
960 961
	struct symbol *pfunc = insn->func->pfunc;
	unsigned int prev_offset = 0;
962

963 964 965 966 967
	/*
	 * Each @rela is a switch table relocation which points to the target
	 * instruction.
	 */
	list_for_each_entry_from(rela, &table->sec->rela_list, list) {
968 969 970

		/* Check for the end of the table: */
		if (rela != table && rela->jump_table_start)
971 972
			break;

973
		/* Make sure the table entries are consecutive: */
974 975 976 977 978 979 980 981
		if (prev_offset && rela->offset != prev_offset + 8)
			break;

		/* Detect function pointers from contiguous objects: */
		if (rela->sym->sec == pfunc->sec &&
		    rela->addend == pfunc->offset)
			break;

982 983
		dest_insn = find_insn(file, rela->sym->sec, rela->addend);
		if (!dest_insn)
984 985
			break;

986
		/* Make sure the destination is in the same function: */
987
		if (!dest_insn->func || dest_insn->func->pfunc != pfunc)
988
			break;
989 990 991 992 993 994 995

		alt = malloc(sizeof(*alt));
		if (!alt) {
			WARN("malloc failed");
			return -1;
		}

996
		alt->insn = dest_insn;
997
		list_add_tail(&alt->list, &insn->alts);
998 999 1000 1001 1002 1003 1004
		prev_offset = rela->offset;
	}

	if (!prev_offset) {
		WARN_FUNC("can't find switch jump table",
			  insn->sec, insn->offset);
		return -1;
1005 1006 1007 1008 1009 1010
	}

	return 0;
}

/*
1011
 * find_jump_table() - Given a dynamic jump, find the switch jump table in
1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043
 * .rodata associated with it.
 *
 * There are 3 basic patterns:
 *
 * 1. jmpq *[rodata addr](,%reg,8)
 *
 *    This is the most common case by far.  It jumps to an address in a simple
 *    jump table which is stored in .rodata.
 *
 * 2. jmpq *[rodata addr](%rip)
 *
 *    This is caused by a rare GCC quirk, currently only seen in three driver
 *    functions in the kernel, only with certain obscure non-distro configs.
 *
 *    As part of an optimization, GCC makes a copy of an existing switch jump
 *    table, modifies it, and then hard-codes the jump (albeit with an indirect
 *    jump) to use a single entry in the table.  The rest of the jump table and
 *    some of its jump targets remain as dead code.
 *
 *    In such a case we can just crudely ignore all unreachable instruction
 *    warnings for the entire object file.  Ideally we would just ignore them
 *    for the function, but that would require redesigning the code quite a
 *    bit.  And honestly that's just not worth doing: unreachable instruction
 *    warnings are of questionable value anyway, and this is such a rare issue.
 *
 * 3. mov [rodata addr],%reg1
 *    ... some instructions ...
 *    jmpq *(%reg1,%reg2,8)
 *
 *    This is a fairly uncommon pattern which is new for GCC 6.  As of this
 *    writing, there are 11 occurrences of it in the allmodconfig kernel.
 *
1044 1045 1046 1047
 *    As of GCC 7 there are quite a few more of these and the 'in between' code
 *    is significant. Esp. with KASAN enabled some of the code between the mov
 *    and jmpq uses .rodata itself, which can confuse things.
 *
1048 1049
 *    TODO: Once we have DWARF CFI and smarter instruction decoding logic,
 *    ensure the same register is used in the mov and jump instructions.
1050 1051
 *
 *    NOTE: RETPOLINE made it harder still to decode dynamic jumps.
1052
 */
1053
static struct rela *find_jump_table(struct objtool_file *file,
1054 1055 1056
				      struct symbol *func,
				      struct instruction *insn)
{
1057
	struct rela *text_rela, *table_rela;
1058
	struct instruction *dest_insn, *orig_insn = insn;
1059
	struct section *table_sec;
1060
	unsigned long table_offset;
1061

1062 1063 1064 1065 1066
	/*
	 * Backward search using the @first_jump_src links, these help avoid
	 * much of the 'in between' code. Which avoids us getting confused by
	 * it.
	 */
1067
	for (;
1068
	     &insn->list != &file->insn_list && insn->func && insn->func->pfunc == func;
1069 1070
	     insn = insn->first_jump_src ?: list_prev_entry(insn, list)) {

1071
		if (insn != orig_insn && insn->type == INSN_JUMP_DYNAMIC)
1072 1073 1074 1075 1076 1077 1078 1079 1080 1081
			break;

		/* allow small jumps within the range */
		if (insn->type == INSN_JUMP_UNCONDITIONAL &&
		    insn->jump_dest &&
		    (insn->jump_dest->offset <= insn->offset ||
		     insn->jump_dest->offset > orig_insn->offset))
		    break;

		/* look for a relocation which references .rodata */
1082 1083
		text_rela = find_rela_by_dest_range(file->elf, insn->sec,
						    insn->offset, insn->len);
1084 1085
		if (!text_rela || text_rela->sym->type != STT_SECTION ||
		    !text_rela->sym->sec->rodata)
1086 1087
			continue;

1088
		table_offset = text_rela->addend;
1089
		table_sec = text_rela->sym->sec;
1090

1091 1092 1093
		if (text_rela->type == R_X86_64_PC32)
			table_offset += 4;

1094 1095
		/*
		 * Make sure the .rodata address isn't associated with a
1096 1097 1098 1099 1100 1101
		 * symbol.  GCC jump tables are anonymous data.
		 *
		 * Also support C jump tables which are in the same format as
		 * switch jump tables.  For objtool to recognize them, they
		 * need to be placed in the C_JUMP_TABLE_SECTION section.  They
		 * have symbols associated with them.
1102
		 */
1103 1104
		if (find_symbol_containing(table_sec, table_offset) &&
		    strcmp(table_sec->name, C_JUMP_TABLE_SECTION))
1105 1106
			continue;

1107 1108 1109 1110 1111
		/*
		 * Each table entry has a rela associated with it.  The rela
		 * should reference text in the same function as the original
		 * instruction.
		 */
1112
		table_rela = find_rela_by_dest(file->elf, table_sec, table_offset);
1113 1114
		if (!table_rela)
			continue;
1115 1116 1117
		dest_insn = find_insn(file, table_rela->sym->sec, table_rela->addend);
		if (!dest_insn || !dest_insn->func || dest_insn->func->pfunc != func)
			continue;
1118

1119 1120 1121 1122 1123 1124 1125 1126 1127
		/*
		 * Use of RIP-relative switch jumps is quite rare, and
		 * indicates a rare GCC quirk/bug which can leave dead code
		 * behind.
		 */
		if (text_rela->type == R_X86_64_PC32)
			file->ignore_unreachables = true;

		return table_rela;
1128 1129 1130 1131 1132
	}

	return NULL;
}

1133 1134 1135 1136 1137 1138
/*
 * First pass: Mark the head of each jump table so that in the next pass,
 * we know when a given jump table ends and the next one starts.
 */
static void mark_func_jump_tables(struct objtool_file *file,
				    struct symbol *func)
1139
{
1140 1141
	struct instruction *insn, *last = NULL;
	struct rela *rela;
1142

1143
	func_for_each_insn(file, func, insn) {
1144 1145 1146 1147 1148
		if (!last)
			last = insn;

		/*
		 * Store back-pointers for unconditional forward jumps such
1149
		 * that find_jump_table() can back-track using those and
1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160
		 * avoid some potentially confusing code.
		 */
		if (insn->type == INSN_JUMP_UNCONDITIONAL && insn->jump_dest &&
		    insn->offset > last->offset &&
		    insn->jump_dest->offset > insn->offset &&
		    !insn->jump_dest->first_jump_src) {

			insn->jump_dest->first_jump_src = insn;
			last = insn->jump_dest;
		}

1161 1162 1163
		if (insn->type != INSN_JUMP_DYNAMIC)
			continue;

1164
		rela = find_jump_table(file, func, insn);
1165 1166 1167
		if (rela) {
			rela->jump_table_start = true;
			insn->jump_table = rela;
1168 1169
		}
	}
1170 1171 1172 1173 1174 1175 1176 1177
}

static int add_func_jump_tables(struct objtool_file *file,
				  struct symbol *func)
{
	struct instruction *insn;
	int ret;

1178
	func_for_each_insn(file, func, insn) {
1179 1180
		if (!insn->jump_table)
			continue;
1181

1182
		ret = add_jump_table(file, insn, insn->jump_table);
1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194
		if (ret)
			return ret;
	}

	return 0;
}

/*
 * For some switch statements, gcc generates a jump table in the .rodata
 * section which contains a list of addresses within the function to jump to.
 * This finds these jump tables and adds them to the insn->alts lists.
 */
1195
static int add_jump_table_alts(struct objtool_file *file)
1196 1197 1198 1199 1200
{
	struct section *sec;
	struct symbol *func;
	int ret;

1201
	if (!file->rodata)
1202 1203
		return 0;

1204
	for_each_sec(file, sec) {
1205 1206 1207 1208
		list_for_each_entry(func, &sec->symbol_list, list) {
			if (func->type != STT_FUNC)
				continue;

1209
			mark_func_jump_tables(file, func);
1210
			ret = add_func_jump_tables(file, func);
1211 1212 1213 1214 1215 1216 1217 1218
			if (ret)
				return ret;
		}
	}

	return 0;
}

1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247
static int read_unwind_hints(struct objtool_file *file)
{
	struct section *sec, *relasec;
	struct rela *rela;
	struct unwind_hint *hint;
	struct instruction *insn;
	struct cfi_reg *cfa;
	int i;

	sec = find_section_by_name(file->elf, ".discard.unwind_hints");
	if (!sec)
		return 0;

	relasec = sec->rela;
	if (!relasec) {
		WARN("missing .rela.discard.unwind_hints section");
		return -1;
	}

	if (sec->len % sizeof(struct unwind_hint)) {
		WARN("struct unwind_hint size mismatch");
		return -1;
	}

	file->hints = true;

	for (i = 0; i < sec->len / sizeof(struct unwind_hint); i++) {
		hint = (struct unwind_hint *)sec->data->d_buf + i;

1248
		rela = find_rela_by_dest(file->elf, sec, i * sizeof(*hint));
1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259
		if (!rela) {
			WARN("can't find rela for unwind_hints[%d]", i);
			return -1;
		}

		insn = find_insn(file, rela->sym->sec, rela->addend);
		if (!insn) {
			WARN("can't find insn for unwind_hints[%d]", i);
			return -1;
		}

1260
		cfa = &insn->cfi.cfa;
1261

1262
		if (hint->type == UNWIND_HINT_TYPE_RET_OFFSET) {
1263
			insn->ret_offset = hint->sp_offset;
1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300
			continue;
		}

		insn->hint = true;

		switch (hint->sp_reg) {
		case ORC_REG_UNDEFINED:
			cfa->base = CFI_UNDEFINED;
			break;
		case ORC_REG_SP:
			cfa->base = CFI_SP;
			break;
		case ORC_REG_BP:
			cfa->base = CFI_BP;
			break;
		case ORC_REG_SP_INDIRECT:
			cfa->base = CFI_SP_INDIRECT;
			break;
		case ORC_REG_R10:
			cfa->base = CFI_R10;
			break;
		case ORC_REG_R13:
			cfa->base = CFI_R13;
			break;
		case ORC_REG_DI:
			cfa->base = CFI_DI;
			break;
		case ORC_REG_DX:
			cfa->base = CFI_DX;
			break;
		default:
			WARN_FUNC("unsupported unwind_hint sp base reg %d",
				  insn->sec, insn->offset, hint->sp_reg);
			return -1;
		}

		cfa->offset = hint->sp_offset;
1301 1302
		insn->cfi.type = hint->type;
		insn->cfi.end = hint->end;
1303 1304 1305 1306 1307
	}

	return 0;
}

1308 1309
static int read_retpoline_hints(struct objtool_file *file)
{
J
Josh Poimboeuf 已提交
1310
	struct section *sec;
1311 1312 1313
	struct instruction *insn;
	struct rela *rela;

J
Josh Poimboeuf 已提交
1314
	sec = find_section_by_name(file->elf, ".rela.discard.retpoline_safe");
1315 1316 1317
	if (!sec)
		return 0;

J
Josh Poimboeuf 已提交
1318 1319 1320
	list_for_each_entry(rela, &sec->rela_list, list) {
		if (rela->sym->type != STT_SECTION) {
			WARN("unexpected relocation symbol type in %s", sec->name);
1321 1322 1323 1324 1325
			return -1;
		}

		insn = find_insn(file, rela->sym->sec, rela->addend);
		if (!insn) {
J
Josh Poimboeuf 已提交
1326
			WARN("bad .discard.retpoline_safe entry");
1327 1328 1329 1330 1331
			return -1;
		}

		if (insn->type != INSN_JUMP_DYNAMIC &&
		    insn->type != INSN_CALL_DYNAMIC) {
J
Josh Poimboeuf 已提交
1332
			WARN_FUNC("retpoline_safe hint not an indirect jump/call",
1333 1334 1335 1336 1337 1338 1339 1340 1341 1342
				  insn->sec, insn->offset);
			return -1;
		}

		insn->retpoline_safe = true;
	}

	return 0;
}

1343 1344 1345 1346 1347 1348
static void mark_rodata(struct objtool_file *file)
{
	struct section *sec;
	bool found = false;

	/*
1349 1350 1351 1352 1353 1354 1355 1356
	 * Search for the following rodata sections, each of which can
	 * potentially contain jump tables:
	 *
	 * - .rodata: can contain GCC switch tables
	 * - .rodata.<func>: same, if -fdata-sections is being used
	 * - .rodata..c_jump_table: contains C annotated jump tables
	 *
	 * .rodata.str1.* sections are ignored; they don't contain jump tables.
1357 1358
	 */
	for_each_sec(file, sec) {
1359 1360
		if (!strncmp(sec->name, ".rodata", 7) &&
		    !strstr(sec->name, ".str1.")) {
1361 1362 1363 1364 1365 1366 1367 1368
			sec->rodata = true;
			found = true;
		}
	}

	file->rodata = found;
}

1369 1370 1371 1372
static int decode_sections(struct objtool_file *file)
{
	int ret;

1373 1374
	mark_rodata(file);

1375 1376 1377 1378 1379 1380 1381 1382 1383
	ret = decode_instructions(file);
	if (ret)
		return ret;

	ret = add_dead_ends(file);
	if (ret)
		return ret;

	add_ignores(file);
P
Peter Zijlstra 已提交
1384
	add_uaccess_safe(file);
1385

1386
	ret = add_ignore_alternatives(file);
1387 1388 1389
	if (ret)
		return ret;

1390 1391 1392 1393
	ret = add_jump_destinations(file);
	if (ret)
		return ret;

1394
	ret = add_special_section_alts(file);
1395 1396 1397
	if (ret)
		return ret;

1398
	ret = add_call_destinations(file);
1399 1400 1401
	if (ret)
		return ret;

1402
	ret = add_jump_table_alts(file);
1403 1404 1405
	if (ret)
		return ret;

1406 1407 1408 1409
	ret = read_unwind_hints(file);
	if (ret)
		return ret;

1410 1411 1412 1413
	ret = read_retpoline_hints(file);
	if (ret)
		return ret;

1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426
	return 0;
}

static bool is_fentry_call(struct instruction *insn)
{
	if (insn->type == INSN_CALL &&
	    insn->call_dest->type == STT_NOTYPE &&
	    !strcmp(insn->call_dest->name, "__fentry__"))
		return true;

	return false;
}

1427
static bool has_modified_stack_frame(struct instruction *insn, struct insn_state *state)
1428
{
1429
	u8 ret_offset = insn->ret_offset;
1430
	struct cfi_state *cfi = &state->cfi;
1431 1432
	int i;

1433
	if (cfi->cfa.base != initial_func_cfi.cfa.base || cfi->drap)
1434 1435
		return true;

1436
	if (cfi->cfa.offset != initial_func_cfi.cfa.offset + ret_offset)
1437 1438
		return true;

1439
	if (cfi->stack_size != initial_func_cfi.cfa.offset + ret_offset)
1440 1441 1442
		return true;

	for (i = 0; i < CFI_NUM_REGS; i++) {
1443 1444
		if (cfi->regs[i].base != initial_func_cfi.regs[i].base ||
		    cfi->regs[i].offset != initial_func_cfi.regs[i].offset)
1445
			return true;
1446
	}
1447 1448 1449 1450 1451 1452

	return false;
}

static bool has_valid_stack_frame(struct insn_state *state)
{
1453 1454 1455 1456
	struct cfi_state *cfi = &state->cfi;

	if (cfi->cfa.base == CFI_BP && cfi->regs[CFI_BP].base == CFI_CFA &&
	    cfi->regs[CFI_BP].offset == -16)
1457 1458
		return true;

1459
	if (cfi->drap && cfi->regs[CFI_BP].base == CFI_BP)
1460 1461 1462
		return true;

	return false;
1463 1464
}

1465 1466
static int update_cfi_state_regs(struct instruction *insn,
				  struct cfi_state *cfi,
1467
				  struct stack_op *op)
1468
{
1469
	struct cfi_reg *cfa = &cfi->cfa;
1470 1471 1472 1473 1474

	if (cfa->base != CFI_SP)
		return 0;

	/* push */
P
Peter Zijlstra 已提交
1475
	if (op->dest.type == OP_DEST_PUSH || op->dest.type == OP_DEST_PUSHF)
1476 1477 1478
		cfa->offset += 8;

	/* pop */
P
Peter Zijlstra 已提交
1479
	if (op->src.type == OP_SRC_POP || op->src.type == OP_SRC_POPF)
1480 1481 1482 1483 1484 1485 1486 1487 1488 1489
		cfa->offset -= 8;

	/* add immediate to sp */
	if (op->dest.type == OP_DEST_REG && op->src.type == OP_SRC_ADD &&
	    op->dest.reg == CFI_SP && op->src.reg == CFI_SP)
		cfa->offset -= op->src.offset;

	return 0;
}

1490
static void save_reg(struct cfi_state *cfi, unsigned char reg, int base, int offset)
1491
{
1492
	if (arch_callee_saved_reg(reg) &&
1493 1494 1495
	    cfi->regs[reg].base == CFI_UNDEFINED) {
		cfi->regs[reg].base = base;
		cfi->regs[reg].offset = offset;
1496
	}
1497 1498
}

1499
static void restore_reg(struct cfi_state *cfi, unsigned char reg)
1500
{
1501 1502
	cfi->regs[reg].base = initial_func_cfi.regs[reg].base;
	cfi->regs[reg].offset = initial_func_cfi.regs[reg].offset;
1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557
}

/*
 * A note about DRAP stack alignment:
 *
 * GCC has the concept of a DRAP register, which is used to help keep track of
 * the stack pointer when aligning the stack.  r10 or r13 is used as the DRAP
 * register.  The typical DRAP pattern is:
 *
 *   4c 8d 54 24 08		lea    0x8(%rsp),%r10
 *   48 83 e4 c0		and    $0xffffffffffffffc0,%rsp
 *   41 ff 72 f8		pushq  -0x8(%r10)
 *   55				push   %rbp
 *   48 89 e5			mov    %rsp,%rbp
 *				(more pushes)
 *   41 52			push   %r10
 *				...
 *   41 5a			pop    %r10
 *				(more pops)
 *   5d				pop    %rbp
 *   49 8d 62 f8		lea    -0x8(%r10),%rsp
 *   c3				retq
 *
 * There are some variations in the epilogues, like:
 *
 *   5b				pop    %rbx
 *   41 5a			pop    %r10
 *   41 5c			pop    %r12
 *   41 5d			pop    %r13
 *   41 5e			pop    %r14
 *   c9				leaveq
 *   49 8d 62 f8		lea    -0x8(%r10),%rsp
 *   c3				retq
 *
 * and:
 *
 *   4c 8b 55 e8		mov    -0x18(%rbp),%r10
 *   48 8b 5d e0		mov    -0x20(%rbp),%rbx
 *   4c 8b 65 f0		mov    -0x10(%rbp),%r12
 *   4c 8b 6d f8		mov    -0x8(%rbp),%r13
 *   c9				leaveq
 *   49 8d 62 f8		lea    -0x8(%r10),%rsp
 *   c3				retq
 *
 * Sometimes r13 is used as the DRAP register, in which case it's saved and
 * restored beforehand:
 *
 *   41 55			push   %r13
 *   4c 8d 6c 24 10		lea    0x10(%rsp),%r13
 *   48 83 e4 f0		and    $0xfffffffffffffff0,%rsp
 *				...
 *   49 8d 65 f0		lea    -0x10(%r13),%rsp
 *   41 5d			pop    %r13
 *   c3				retq
 */
1558
static int update_cfi_state(struct instruction *insn, struct cfi_state *cfi,
1559
			     struct stack_op *op)
1560
{
1561 1562
	struct cfi_reg *cfa = &cfi->cfa;
	struct cfi_reg *regs = cfi->regs;
1563 1564 1565 1566 1567 1568 1569 1570 1571 1572

	/* stack operations don't make sense with an undefined CFA */
	if (cfa->base == CFI_UNDEFINED) {
		if (insn->func) {
			WARN_FUNC("undefined stack state", insn->sec, insn->offset);
			return -1;
		}
		return 0;
	}

1573 1574
	if (cfi->type == ORC_TYPE_REGS || cfi->type == ORC_TYPE_REGS_IRET)
		return update_cfi_state_regs(insn, cfi, op);
1575

1576 1577 1578 1579 1580 1581
	switch (op->dest.type) {

	case OP_DEST_REG:
		switch (op->src.type) {

		case OP_SRC_REG:
1582 1583 1584 1585 1586 1587 1588
			if (op->src.reg == CFI_SP && op->dest.reg == CFI_BP &&
			    cfa->base == CFI_SP &&
			    regs[CFI_BP].base == CFI_CFA &&
			    regs[CFI_BP].offset == -cfa->offset) {

				/* mov %rsp, %rbp */
				cfa->base = op->dest.reg;
1589
				cfi->bp_scratch = false;
1590
			}
1591

1592
			else if (op->src.reg == CFI_SP &&
1593
				 op->dest.reg == CFI_BP && cfi->drap) {
1594

1595 1596
				/* drap: mov %rsp, %rbp */
				regs[CFI_BP].base = CFI_BP;
1597 1598
				regs[CFI_BP].offset = -cfi->stack_size;
				cfi->bp_scratch = false;
1599
			}
1600

1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612
			else if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {

				/*
				 * mov %rsp, %reg
				 *
				 * This is needed for the rare case where GCC
				 * does:
				 *
				 *   mov    %rsp, %rax
				 *   ...
				 *   mov    %rax, %rsp
				 */
1613 1614
				cfi->vals[op->dest.reg].base = CFI_CFA;
				cfi->vals[op->dest.reg].offset = -cfi->stack_size;
1615 1616
			}

J
Josh Poimboeuf 已提交
1617 1618 1619 1620 1621 1622 1623 1624
			else if (op->src.reg == CFI_BP && op->dest.reg == CFI_SP &&
				 cfa->base == CFI_BP) {

				/*
				 * mov %rbp, %rsp
				 *
				 * Restore the original stack pointer (Clang).
				 */
1625
				cfi->stack_size = -cfi->regs[CFI_BP].offset;
J
Josh Poimboeuf 已提交
1626 1627
			}

1628 1629 1630 1631
			else if (op->dest.reg == cfa->base) {

				/* mov %reg, %rsp */
				if (cfa->base == CFI_SP &&
1632
				    cfi->vals[op->src.reg].base == CFI_CFA) {
1633 1634 1635 1636 1637 1638 1639 1640 1641

					/*
					 * This is needed for the rare case
					 * where GCC does something dumb like:
					 *
					 *   lea    0x8(%rsp), %rcx
					 *   ...
					 *   mov    %rcx, %rsp
					 */
1642 1643
					cfa->offset = -cfi->vals[op->src.reg].offset;
					cfi->stack_size = cfa->offset;
1644 1645 1646 1647 1648

				} else {
					cfa->base = CFI_UNDEFINED;
					cfa->offset = 0;
				}
1649 1650 1651 1652 1653 1654 1655 1656
			}

			break;

		case OP_SRC_ADD:
			if (op->dest.reg == CFI_SP && op->src.reg == CFI_SP) {

				/* add imm, %rsp */
1657
				cfi->stack_size -= op->src.offset;
1658 1659 1660 1661 1662 1663 1664 1665
				if (cfa->base == CFI_SP)
					cfa->offset -= op->src.offset;
				break;
			}

			if (op->dest.reg == CFI_SP && op->src.reg == CFI_BP) {

				/* lea disp(%rbp), %rsp */
1666
				cfi->stack_size = -(op->src.offset + regs[CFI_BP].offset);
1667 1668 1669
				break;
			}

1670
			if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {
1671 1672

				/* drap: lea disp(%rsp), %drap */
1673
				cfi->drap_reg = op->dest.reg;
1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684

				/*
				 * lea disp(%rsp), %reg
				 *
				 * This is needed for the rare case where GCC
				 * does something dumb like:
				 *
				 *   lea    0x8(%rsp), %rcx
				 *   ...
				 *   mov    %rcx, %rsp
				 */
1685 1686 1687
				cfi->vals[op->dest.reg].base = CFI_CFA;
				cfi->vals[op->dest.reg].offset = \
					-cfi->stack_size + op->src.offset;
1688

1689 1690 1691
				break;
			}

1692 1693
			if (cfi->drap && op->dest.reg == CFI_SP &&
			    op->src.reg == cfi->drap_reg) {
1694 1695 1696

				 /* drap: lea disp(%drap), %rsp */
				cfa->base = CFI_SP;
1697 1698 1699
				cfa->offset = cfi->stack_size = -op->src.offset;
				cfi->drap_reg = CFI_UNDEFINED;
				cfi->drap = false;
1700 1701 1702
				break;
			}

1703
			if (op->dest.reg == cfi->cfa.base) {
1704 1705 1706 1707 1708 1709 1710 1711 1712
				WARN_FUNC("unsupported stack register modification",
					  insn->sec, insn->offset);
				return -1;
			}

			break;

		case OP_SRC_AND:
			if (op->dest.reg != CFI_SP ||
1713 1714
			    (cfi->drap_reg != CFI_UNDEFINED && cfa->base != CFI_SP) ||
			    (cfi->drap_reg == CFI_UNDEFINED && cfa->base != CFI_BP)) {
1715 1716 1717 1718 1719
				WARN_FUNC("unsupported stack pointer realignment",
					  insn->sec, insn->offset);
				return -1;
			}

1720
			if (cfi->drap_reg != CFI_UNDEFINED) {
1721
				/* drap: and imm, %rsp */
1722 1723 1724
				cfa->base = cfi->drap_reg;
				cfa->offset = cfi->stack_size = 0;
				cfi->drap = true;
1725 1726 1727 1728 1729 1730 1731 1732 1733 1734
			}

			/*
			 * Older versions of GCC (4.8ish) realign the stack
			 * without DRAP, with a frame pointer.
			 */

			break;

		case OP_SRC_POP:
P
Peter Zijlstra 已提交
1735
		case OP_SRC_POPF:
1736
			if (!cfi->drap && op->dest.reg == cfa->base) {
1737 1738 1739 1740 1741

				/* pop %rbp */
				cfa->base = CFI_SP;
			}

1742 1743 1744
			if (cfi->drap && cfa->base == CFI_BP_INDIRECT &&
			    op->dest.reg == cfi->drap_reg &&
			    cfi->drap_offset == -cfi->stack_size) {
1745

1746
				/* drap: pop %drap */
1747
				cfa->base = cfi->drap_reg;
1748
				cfa->offset = 0;
1749
				cfi->drap_offset = -1;
1750

1751
			} else if (regs[op->dest.reg].offset == -cfi->stack_size) {
1752

1753
				/* pop %reg */
1754
				restore_reg(cfi, op->dest.reg);
1755 1756
			}

1757
			cfi->stack_size -= 8;
1758 1759 1760 1761 1762 1763
			if (cfa->base == CFI_SP)
				cfa->offset -= 8;

			break;

		case OP_SRC_REG_INDIRECT:
1764 1765
			if (cfi->drap && op->src.reg == CFI_BP &&
			    op->src.offset == cfi->drap_offset) {
1766 1767

				/* drap: mov disp(%rbp), %drap */
1768
				cfa->base = cfi->drap_reg;
1769
				cfa->offset = 0;
1770
				cfi->drap_offset = -1;
1771 1772
			}

1773
			if (cfi->drap && op->src.reg == CFI_BP &&
1774 1775 1776
			    op->src.offset == regs[op->dest.reg].offset) {

				/* drap: mov disp(%rbp), %reg */
1777
				restore_reg(cfi, op->dest.reg);
1778 1779 1780 1781 1782 1783

			} else if (op->src.reg == cfa->base &&
			    op->src.offset == regs[op->dest.reg].offset + cfa->offset) {

				/* mov disp(%rbp), %reg */
				/* mov disp(%rsp), %reg */
1784
				restore_reg(cfi, op->dest.reg);
1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797
			}

			break;

		default:
			WARN_FUNC("unknown stack-related instruction",
				  insn->sec, insn->offset);
			return -1;
		}

		break;

	case OP_DEST_PUSH:
P
Peter Zijlstra 已提交
1798
	case OP_DEST_PUSHF:
1799
		cfi->stack_size += 8;
1800 1801 1802 1803 1804 1805
		if (cfa->base == CFI_SP)
			cfa->offset += 8;

		if (op->src.type != OP_SRC_REG)
			break;

1806 1807
		if (cfi->drap) {
			if (op->src.reg == cfa->base && op->src.reg == cfi->drap_reg) {
1808 1809 1810

				/* drap: push %drap */
				cfa->base = CFI_BP_INDIRECT;
1811
				cfa->offset = -cfi->stack_size;
1812

1813
				/* save drap so we know when to restore it */
1814
				cfi->drap_offset = -cfi->stack_size;
1815

1816
			} else if (op->src.reg == CFI_BP && cfa->base == cfi->drap_reg) {
1817 1818

				/* drap: push %rbp */
1819
				cfi->stack_size = 0;
1820 1821 1822 1823

			} else if (regs[op->src.reg].base == CFI_UNDEFINED) {

				/* drap: push %reg */
1824
				save_reg(cfi, op->src.reg, CFI_BP, -cfi->stack_size);
1825 1826 1827 1828 1829
			}

		} else {

			/* push %reg */
1830
			save_reg(cfi, op->src.reg, CFI_CFA, -cfi->stack_size);
1831 1832 1833
		}

		/* detect when asm code uses rbp as a scratch register */
1834
		if (!no_fp && insn->func && op->src.reg == CFI_BP &&
1835
		    cfa->base != CFI_BP)
1836
			cfi->bp_scratch = true;
1837 1838 1839 1840
		break;

	case OP_DEST_REG_INDIRECT:

1841 1842
		if (cfi->drap) {
			if (op->src.reg == cfa->base && op->src.reg == cfi->drap_reg) {
1843 1844 1845 1846 1847

				/* drap: mov %drap, disp(%rbp) */
				cfa->base = CFI_BP_INDIRECT;
				cfa->offset = op->dest.offset;

1848
				/* save drap offset so we know when to restore it */
1849
				cfi->drap_offset = op->dest.offset;
1850 1851 1852 1853 1854
			}

			else if (regs[op->src.reg].base == CFI_UNDEFINED) {

				/* drap: mov reg, disp(%rbp) */
1855
				save_reg(cfi, op->src.reg, CFI_BP, op->dest.offset);
1856 1857 1858 1859 1860 1861
			}

		} else if (op->dest.reg == cfa->base) {

			/* mov reg, disp(%rbp) */
			/* mov reg, disp(%rsp) */
1862 1863
			save_reg(cfi, op->src.reg, CFI_CFA,
				 op->dest.offset - cfi->cfa.offset);
1864 1865 1866 1867 1868
		}

		break;

	case OP_DEST_LEAVE:
1869 1870
		if ((!cfi->drap && cfa->base != CFI_BP) ||
		    (cfi->drap && cfa->base != cfi->drap_reg)) {
1871 1872 1873 1874 1875 1876 1877
			WARN_FUNC("leave instruction with modified stack frame",
				  insn->sec, insn->offset);
			return -1;
		}

		/* leave (mov %rbp, %rsp; pop %rbp) */

1878 1879
		cfi->stack_size = -cfi->regs[CFI_BP].offset - 8;
		restore_reg(cfi, CFI_BP);
1880

1881
		if (!cfi->drap) {
1882 1883 1884 1885 1886 1887 1888
			cfa->base = CFI_SP;
			cfa->offset -= 8;
		}

		break;

	case OP_DEST_MEM:
P
Peter Zijlstra 已提交
1889
		if (op->src.type != OP_SRC_POP && op->src.type != OP_SRC_POPF) {
1890 1891 1892 1893 1894 1895
			WARN_FUNC("unknown stack-related memory operation",
				  insn->sec, insn->offset);
			return -1;
		}

		/* pop mem */
1896
		cfi->stack_size -= 8;
1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910
		if (cfa->base == CFI_SP)
			cfa->offset -= 8;

		break;

	default:
		WARN_FUNC("unknown stack-related instruction",
			  insn->sec, insn->offset);
		return -1;
	}

	return 0;
}

1911 1912 1913 1914 1915 1916 1917
static int handle_insn_ops(struct instruction *insn, struct insn_state *state)
{
	struct stack_op *op;

	list_for_each_entry(op, &insn->stack_ops, list) {
		int res;

1918
		res = update_cfi_state(insn, &state->cfi, op);
1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946
		if (res)
			return res;

		if (op->dest.type == OP_DEST_PUSHF) {
			if (!state->uaccess_stack) {
				state->uaccess_stack = 1;
			} else if (state->uaccess_stack >> 31) {
				WARN_FUNC("PUSHF stack exhausted",
					  insn->sec, insn->offset);
				return 1;
			}
			state->uaccess_stack <<= 1;
			state->uaccess_stack  |= state->uaccess;
		}

		if (op->src.type == OP_SRC_POPF) {
			if (state->uaccess_stack) {
				state->uaccess = state->uaccess_stack & 1;
				state->uaccess_stack >>= 1;
				if (state->uaccess_stack == 1)
					state->uaccess_stack = 0;
			}
		}
	}

	return 0;
}

1947
static bool insn_cfi_match(struct instruction *insn, struct cfi_state *cfi2)
1948
{
1949
	struct cfi_state *cfi1 = &insn->cfi;
1950 1951
	int i;

1952 1953
	if (memcmp(&cfi1->cfa, &cfi2->cfa, sizeof(cfi1->cfa))) {

1954 1955
		WARN_FUNC("stack state mismatch: cfa1=%d%+d cfa2=%d%+d",
			  insn->sec, insn->offset,
1956 1957
			  cfi1->cfa.base, cfi1->cfa.offset,
			  cfi2->cfa.base, cfi2->cfa.offset);
1958

1959
	} else if (memcmp(&cfi1->regs, &cfi2->regs, sizeof(cfi1->regs))) {
1960
		for (i = 0; i < CFI_NUM_REGS; i++) {
1961
			if (!memcmp(&cfi1->regs[i], &cfi2->regs[i],
1962 1963 1964 1965 1966
				    sizeof(struct cfi_reg)))
				continue;

			WARN_FUNC("stack state mismatch: reg1[%d]=%d%+d reg2[%d]=%d%+d",
				  insn->sec, insn->offset,
1967 1968
				  i, cfi1->regs[i].base, cfi1->regs[i].offset,
				  i, cfi2->regs[i].base, cfi2->regs[i].offset);
1969 1970 1971
			break;
		}

1972 1973
	} else if (cfi1->type != cfi2->type) {

1974
		WARN_FUNC("stack state mismatch: type1=%d type2=%d",
1975 1976 1977 1978 1979
			  insn->sec, insn->offset, cfi1->type, cfi2->type);

	} else if (cfi1->drap != cfi2->drap ||
		   (cfi1->drap && cfi1->drap_reg != cfi2->drap_reg) ||
		   (cfi1->drap && cfi1->drap_offset != cfi2->drap_offset)) {
1980

1981
		WARN_FUNC("stack state mismatch: drap1=%d(%d,%d) drap2=%d(%d,%d)",
1982
			  insn->sec, insn->offset,
1983 1984
			  cfi1->drap, cfi1->drap_reg, cfi1->drap_offset,
			  cfi2->drap, cfi2->drap_reg, cfi2->drap_offset);
1985 1986 1987 1988 1989

	} else
		return true;

	return false;
1990 1991
}

P
Peter Zijlstra 已提交
1992 1993 1994
static inline bool func_uaccess_safe(struct symbol *func)
{
	if (func)
1995
		return func->uaccess_safe;
P
Peter Zijlstra 已提交
1996 1997 1998 1999

	return false;
}

2000
static inline const char *call_dest_name(struct instruction *insn)
P
Peter Zijlstra 已提交
2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011
{
	if (insn->call_dest)
		return insn->call_dest->name;

	return "{dynamic}";
}

static int validate_call(struct instruction *insn, struct insn_state *state)
{
	if (state->uaccess && !func_uaccess_safe(insn->call_dest)) {
		WARN_FUNC("call to %s() with UACCESS enabled",
2012
				insn->sec, insn->offset, call_dest_name(insn));
P
Peter Zijlstra 已提交
2013 2014 2015
		return 1;
	}

2016 2017
	if (state->df) {
		WARN_FUNC("call to %s() with DF set",
2018
				insn->sec, insn->offset, call_dest_name(insn));
2019 2020 2021
		return 1;
	}

P
Peter Zijlstra 已提交
2022 2023 2024
	return 0;
}

2025 2026
static int validate_sibling_call(struct instruction *insn, struct insn_state *state)
{
2027
	if (has_modified_stack_frame(insn, state)) {
2028 2029 2030 2031 2032
		WARN_FUNC("sibling call from callable instruction with modified stack frame",
				insn->sec, insn->offset);
		return 1;
	}

P
Peter Zijlstra 已提交
2033
	return validate_call(insn, state);
2034 2035
}

2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055
static int validate_return(struct symbol *func, struct instruction *insn, struct insn_state *state)
{
	if (state->uaccess && !func_uaccess_safe(func)) {
		WARN_FUNC("return with UACCESS enabled",
			  insn->sec, insn->offset);
		return 1;
	}

	if (!state->uaccess && func_uaccess_safe(func)) {
		WARN_FUNC("return with UACCESS disabled from a UACCESS-safe function",
			  insn->sec, insn->offset);
		return 1;
	}

	if (state->df) {
		WARN_FUNC("return with DF set",
			  insn->sec, insn->offset);
		return 1;
	}

2056
	if (func && has_modified_stack_frame(insn, state)) {
2057 2058 2059 2060 2061
		WARN_FUNC("return with modified stack frame",
			  insn->sec, insn->offset);
		return 1;
	}

2062
	if (state->cfi.bp_scratch) {
2063 2064
		WARN_FUNC("BP used as a scratch register",
			  insn->sec, insn->offset);
2065 2066 2067 2068 2069 2070
		return 1;
	}

	return 0;
}

2071 2072 2073 2074 2075 2076
/*
 * Follow the branch starting at the given instruction, and recursively follow
 * any other branches (jumps).  Meanwhile, track the frame pointer state at
 * each instruction and validate all the rules described in
 * tools/objtool/Documentation/stack-validation.txt.
 */
2077
static int validate_branch(struct objtool_file *file, struct symbol *func,
P
Peter Zijlstra 已提交
2078
			   struct instruction *insn, struct insn_state state)
2079 2080
{
	struct alternative *alt;
P
Peter Zijlstra 已提交
2081
	struct instruction *next_insn;
2082
	struct section *sec;
2083
	u8 visited;
2084 2085 2086 2087 2088 2089 2090
	int ret;

	sec = insn->sec;

	if (insn->alt_group && list_empty(&insn->alts)) {
		WARN_FUNC("don't know how to handle branch to middle of alternative instruction group",
			  sec, insn->offset);
2091
		return 1;
2092 2093 2094
	}

	while (1) {
2095 2096
		next_insn = next_insn_same_sec(file, insn);

2097
		if (file->c_file && func && insn->func && func != insn->func->pfunc) {
2098 2099 2100
			WARN("%s() falls through to next function %s()",
			     func->name, insn->func->name);
			return 1;
2101 2102
		}

2103 2104 2105
		if (func && insn->ignore) {
			WARN_FUNC("BUG: why am I validating an ignored function?",
				  sec, insn->offset);
2106
			return 1;
2107 2108
		}

2109
		visited = 1 << state.uaccess;
2110
		if (insn->visited) {
2111
			if (!insn->hint && !insn_cfi_match(insn, &state.cfi))
2112 2113
				return 1;

2114
			if (insn->visited & visited)
P
Peter Zijlstra 已提交
2115
				return 0;
2116 2117
		}

2118
		if (insn->hint)
2119
			state.cfi = insn->cfi;
2120
		else
2121
			insn->cfi = state.cfi;
2122

2123
		insn->visited |= visited;
2124

2125
		if (!insn->ignore_alts) {
P
Peter Zijlstra 已提交
2126 2127
			bool skip_orig = false;

2128
			list_for_each_entry(alt, &insn->alts, list) {
P
Peter Zijlstra 已提交
2129 2130 2131
				if (alt->skip_orig)
					skip_orig = true;

2132
				ret = validate_branch(file, func, alt->insn, state);
2133 2134 2135 2136 2137
				if (ret) {
					if (backtrace)
						BT_FUNC("(alt)", insn);
					return ret;
				}
2138
			}
P
Peter Zijlstra 已提交
2139 2140 2141

			if (skip_orig)
				return 0;
2142 2143 2144 2145 2146
		}

		switch (insn->type) {

		case INSN_RETURN:
2147
			return validate_return(func, insn, &state);
2148 2149

		case INSN_CALL:
P
Peter Zijlstra 已提交
2150 2151 2152 2153
		case INSN_CALL_DYNAMIC:
			ret = validate_call(insn, &state);
			if (ret)
				return ret;
2154

2155 2156
			if (!no_fp && func && !is_fentry_call(insn) &&
			    !has_valid_stack_frame(&state)) {
2157 2158 2159 2160
				WARN_FUNC("call without frame pointer save/setup",
					  sec, insn->offset);
				return 1;
			}
2161 2162 2163 2164

			if (dead_end_function(file, insn->call_dest))
				return 0;

2165 2166 2167 2168
			break;

		case INSN_JUMP_CONDITIONAL:
		case INSN_JUMP_UNCONDITIONAL:
2169
			if (func && is_sibling_call(insn)) {
2170
				ret = validate_sibling_call(insn, &state);
2171
				if (ret)
2172
					return ret;
2173

2174
			} else if (insn->jump_dest) {
2175 2176
				ret = validate_branch(file, func,
						      insn->jump_dest, state);
2177 2178 2179 2180 2181
				if (ret) {
					if (backtrace)
						BT_FUNC("(branch)", insn);
					return ret;
				}
2182
			}
2183 2184 2185 2186 2187 2188 2189

			if (insn->type == INSN_JUMP_UNCONDITIONAL)
				return 0;

			break;

		case INSN_JUMP_DYNAMIC:
2190
		case INSN_JUMP_DYNAMIC_CONDITIONAL:
2191
			if (func && is_sibling_call(insn)) {
2192 2193 2194
				ret = validate_sibling_call(insn, &state);
				if (ret)
					return ret;
2195 2196
			}

2197 2198 2199 2200
			if (insn->type == INSN_JUMP_DYNAMIC)
				return 0;

			break;
2201

P
Peter Zijlstra 已提交
2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215
		case INSN_EXCEPTION_RETURN:
			if (handle_insn_ops(insn, &state))
				return 1;

			/*
			 * This handles x86's sync_core() case, where we use an
			 * IRET to self. All 'normal' IRET instructions are in
			 * STT_NOTYPE entry symbols.
			 */
			if (func)
				break;

			return 0;

2216 2217 2218 2219 2220 2221 2222 2223
		case INSN_CONTEXT_SWITCH:
			if (func && (!next_insn || !next_insn->hint)) {
				WARN_FUNC("unsupported instruction in callable function",
					  sec, insn->offset);
				return 1;
			}
			return 0;

2224
		case INSN_STACK:
2225
			if (handle_insn_ops(insn, &state))
2226
				return 1;
P
Peter Zijlstra 已提交
2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238
			break;

		case INSN_STAC:
			if (state.uaccess) {
				WARN_FUNC("recursive UACCESS enable", sec, insn->offset);
				return 1;
			}

			state.uaccess = true;
			break;

		case INSN_CLAC:
2239
			if (!state.uaccess && func) {
P
Peter Zijlstra 已提交
2240 2241 2242 2243 2244 2245 2246 2247 2248 2249
				WARN_FUNC("redundant UACCESS disable", sec, insn->offset);
				return 1;
			}

			if (func_uaccess_safe(func) && !state.uaccess_stack) {
				WARN_FUNC("UACCESS-safe disables UACCESS", sec, insn->offset);
				return 1;
			}

			state.uaccess = false;
2250 2251
			break;

2252 2253 2254 2255 2256 2257 2258 2259
		case INSN_STD:
			if (state.df)
				WARN_FUNC("recursive STD", sec, insn->offset);

			state.df = true;
			break;

		case INSN_CLD:
2260
			if (!state.df && func)
2261 2262 2263
				WARN_FUNC("redundant CLD", sec, insn->offset);

			state.df = false;
2264 2265
			break;

2266 2267 2268 2269 2270 2271 2272
		default:
			break;
		}

		if (insn->dead_end)
			return 0;

2273
		if (!next_insn) {
2274
			if (state.cfi.cfa.base == CFI_UNDEFINED)
2275
				return 0;
2276 2277 2278
			WARN("%s: unexpected end of section", sec->name);
			return 1;
		}
2279 2280

		insn = next_insn;
2281 2282 2283 2284 2285
	}

	return 0;
}

2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298
static int validate_unwind_hints(struct objtool_file *file)
{
	struct instruction *insn;
	int ret, warnings = 0;
	struct insn_state state;

	if (!file->hints)
		return 0;

	clear_insn_state(&state);

	for_each_insn(file, insn) {
		if (insn->hint && !insn->visited) {
2299
			ret = validate_branch(file, insn->func, insn, state);
2300 2301
			if (ret && backtrace)
				BT_FUNC("<=== (hint)", insn);
2302 2303 2304 2305 2306 2307 2308
			warnings += ret;
		}
	}

	return warnings;
}

2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321
static int validate_retpoline(struct objtool_file *file)
{
	struct instruction *insn;
	int warnings = 0;

	for_each_insn(file, insn) {
		if (insn->type != INSN_JUMP_DYNAMIC &&
		    insn->type != INSN_CALL_DYNAMIC)
			continue;

		if (insn->retpoline_safe)
			continue;

2322 2323 2324 2325 2326 2327 2328 2329 2330
		/*
		 * .init.text code is ran before userspace and thus doesn't
		 * strictly need retpolines, except for modules which are
		 * loaded late, they very much do need retpoline in their
		 * .init.text
		 */
		if (!strcmp(insn->sec->name, ".init.text") && !module)
			continue;

2331 2332 2333 2334 2335 2336 2337 2338 2339 2340
		WARN_FUNC("indirect %s found in RETPOLINE build",
			  insn->sec, insn->offset,
			  insn->type == INSN_JUMP_DYNAMIC ? "jump" : "call");

		warnings++;
	}

	return warnings;
}

2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353
static bool is_kasan_insn(struct instruction *insn)
{
	return (insn->type == INSN_CALL &&
		!strcmp(insn->call_dest->name, "__asan_handle_no_return"));
}

static bool is_ubsan_insn(struct instruction *insn)
{
	return (insn->type == INSN_CALL &&
		!strcmp(insn->call_dest->name,
			"__ubsan_handle_builtin_unreachable"));
}

2354
static bool ignore_unreachable_insn(struct instruction *insn)
2355 2356 2357
{
	int i;

2358 2359 2360 2361 2362 2363
	if (insn->ignore || insn->type == INSN_NOP)
		return true;

	/*
	 * Ignore any unused exceptions.  This can happen when a whitelisted
	 * function has an exception table entry.
2364 2365 2366
	 *
	 * Also ignore alternative replacement instructions.  This can happen
	 * when a whitelisted function uses one of the ALTERNATIVE macros.
2367
	 */
2368 2369 2370
	if (!strcmp(insn->sec->name, ".fixup") ||
	    !strcmp(insn->sec->name, ".altinstr_replacement") ||
	    !strcmp(insn->sec->name, ".altinstr_aux"))
2371 2372
		return true;

2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387
	if (!insn->func)
		return false;

	/*
	 * CONFIG_UBSAN_TRAP inserts a UD2 when it sees
	 * __builtin_unreachable().  The BUG() macro has an unreachable() after
	 * the UD2, which causes GCC's undefined trap logic to emit another UD2
	 * (or occasionally a JMP to UD2).
	 */
	if (list_prev_entry(insn, list)->dead_end &&
	    (insn->type == INSN_BUG ||
	     (insn->type == INSN_JUMP_UNCONDITIONAL &&
	      insn->jump_dest && insn->jump_dest->type == INSN_BUG)))
		return true;

2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398
	/*
	 * Check if this (or a subsequent) instruction is related to
	 * CONFIG_UBSAN or CONFIG_KASAN.
	 *
	 * End the search at 5 instructions to avoid going into the weeds.
	 */
	for (i = 0; i < 5; i++) {

		if (is_kasan_insn(insn) || is_ubsan_insn(insn))
			return true;

2399 2400 2401 2402 2403 2404 2405 2406
		if (insn->type == INSN_JUMP_UNCONDITIONAL) {
			if (insn->jump_dest &&
			    insn->jump_dest->func == insn->func) {
				insn = insn->jump_dest;
				continue;
			}

			break;
2407 2408
		}

2409
		if (insn->offset + insn->len >= insn->func->offset + insn->func->len)
2410
			break;
2411

2412 2413 2414 2415 2416 2417
		insn = list_next_entry(insn, list);
	}

	return false;
}

2418
static int validate_section(struct objtool_file *file, struct section *sec)
2419 2420 2421
{
	struct symbol *func;
	struct instruction *insn;
2422
	struct insn_state state;
2423 2424
	int ret, warnings = 0;

2425 2426 2427
	list_for_each_entry(func, &sec->symbol_list, list) {
		if (func->type != STT_FUNC)
			continue;
2428

2429 2430 2431 2432 2433
		if (!func->len) {
			WARN("%s() is missing an ELF size annotation",
			     func->name);
			warnings++;
		}
2434

2435 2436
		if (func->pfunc != func || func->alias != func)
			continue;
2437

2438 2439 2440
		insn = find_insn(file, sec, func->offset);
		if (!insn || insn->ignore || insn->visited)
			continue;
2441

2442
		clear_insn_state(&state);
2443 2444
		state.cfi.cfa = initial_func_cfi.cfa;
		memcpy(&state.cfi.regs, &initial_func_cfi.regs,
2445
		       CFI_NUM_REGS * sizeof(struct cfi_reg));
2446
		state.cfi.stack_size = initial_func_cfi.cfa.offset;
2447

2448
		state.uaccess = func->uaccess_safe;
P
Peter Zijlstra 已提交
2449

2450 2451 2452 2453
		ret = validate_branch(file, func, insn, state);
		if (ret && backtrace)
			BT_FUNC("<=== (func)", insn);
		warnings += ret;
2454 2455 2456 2457 2458
	}

	return warnings;
}

2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469
static int validate_functions(struct objtool_file *file)
{
	struct section *sec;
	int warnings = 0;

	for_each_sec(file, sec)
		warnings += validate_section(file, sec);

	return warnings;
}

2470
static int validate_reachable_instructions(struct objtool_file *file)
2471 2472
{
	struct instruction *insn;
2473 2474 2475

	if (file->ignore_unreachables)
		return 0;
2476 2477

	for_each_insn(file, insn) {
2478 2479 2480 2481 2482
		if (insn->visited || ignore_unreachable_insn(insn))
			continue;

		WARN_FUNC("unreachable instruction", insn->sec, insn->offset);
		return 1;
2483 2484
	}

2485
	return 0;
2486 2487
}

2488 2489
static struct objtool_file file;

2490
int check(const char *_objname, bool orc)
2491 2492 2493 2494 2495
{
	int ret, warnings = 0;

	objname = _objname;

2496
	file.elf = elf_read(objname, orc ? O_RDWR : O_RDONLY);
2497
	if (!file.elf)
2498 2499 2500 2501 2502
		return 1;

	INIT_LIST_HEAD(&file.insn_list);
	hash_init(file.insn_hash);
	file.c_file = find_section_by_name(file.elf, ".comment");
2503
	file.ignore_unreachables = no_unreachable;
2504
	file.hints = false;
2505

2506 2507
	arch_initial_func_cfi_state(&initial_func_cfi);

2508 2509 2510 2511 2512
	ret = decode_sections(&file);
	if (ret < 0)
		goto out;
	warnings += ret;

2513
	if (list_empty(&file.insn_list))
2514 2515
		goto out;

2516 2517 2518 2519 2520 2521 2522
	if (retpoline) {
		ret = validate_retpoline(&file);
		if (ret < 0)
			return ret;
		warnings += ret;
	}

2523
	ret = validate_functions(&file);
2524 2525 2526 2527
	if (ret < 0)
		goto out;
	warnings += ret;

2528 2529 2530 2531 2532
	ret = validate_unwind_hints(&file);
	if (ret < 0)
		goto out;
	warnings += ret;

2533 2534 2535 2536 2537 2538 2539
	if (!warnings) {
		ret = validate_reachable_instructions(&file);
		if (ret < 0)
			goto out;
		warnings += ret;
	}

2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553
	if (orc) {
		ret = create_orc(&file);
		if (ret < 0)
			goto out;

		ret = create_orc_sections(&file);
		if (ret < 0)
			goto out;

		ret = elf_write(file.elf);
		if (ret < 0)
			goto out;
	}

2554
out:
2555 2556 2557 2558 2559 2560 2561 2562 2563
	if (ret < 0) {
		/*
		 *  Fatal error.  The binary is corrupt or otherwise broken in
		 *  some way, or objtool itself is broken.  Fail the kernel
		 *  build.
		 */
		return ret;
	}

2564 2565
	return 0;
}