omap_crtc.c 17.2 KB
Newer Older
1
/*
R
Rob Clark 已提交
2
 * drivers/gpu/drm/omapdrm/omap_crtc.c
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19
 *
 * Copyright (C) 2011 Texas Instruments
 * Author: Rob Clark <rob@ti.com>
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 as published by
 * the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 * more details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program.  If not, see <http://www.gnu.org/licenses/>.
 */

20 21
#include <linux/completion.h>

22 23
#include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h>
24 25
#include <drm/drm_crtc.h>
#include <drm/drm_crtc_helper.h>
26
#include <drm/drm_mode.h>
27
#include <drm/drm_plane_helper.h>
28 29

#include "omap_drv.h"
30 31 32 33 34

#define to_omap_crtc(x) container_of(x, struct omap_crtc, base)

struct omap_crtc {
	struct drm_crtc base;
35

36
	const char *name;
37
	enum omap_channel channel;
38
	struct drm_encoder *current_encoder;
39 40 41 42 43 44 45

	/*
	 * Temporary: eventually this will go away, but it is needed
	 * for now to keep the output's happy.  (They only need
	 * mgr->id.)  Eventually this will be replaced w/ something
	 * more common-panel-framework-y
	 */
46
	struct omap_overlay_manager *mgr;
47 48 49 50

	struct omap_video_timings timings;
	bool enabled;

51
	struct omap_drm_irq vblank_irq;
52 53
	struct omap_drm_irq error_irq;

54 55
	/* pending event */
	struct drm_pending_vblank_event *event;
56
	wait_queue_head_t flip_wait;
57

58 59
	struct completion completion;

60
	bool ignore_digit_sync_lost;
61 62
};

63 64 65 66
/* -----------------------------------------------------------------------------
 * Helper Functions
 */

67 68 69 70 71 72 73
uint32_t pipe2vbl(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);

	return dispc_mgr_get_vsync_irq(omap_crtc->channel);
}

74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89
const struct omap_video_timings *omap_crtc_timings(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	return &omap_crtc->timings;
}

enum omap_channel omap_crtc_channel(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	return omap_crtc->channel;
}

/* -----------------------------------------------------------------------------
 * DSS Manager Functions
 */

90 91 92 93 94 95 96 97 98
/*
 * Manager-ops, callbacks from output when they need to configure
 * the upstream part of the video pipe.
 *
 * Most of these we can ignore until we add support for command-mode
 * panels.. for video-mode the crtc-helpers already do an adequate
 * job of sequencing the setup of the video pipe in the proper order
 */

99 100 101
/* ovl-mgr-id -> crtc */
static struct omap_crtc *omap_crtcs[8];

102
/* we can probably ignore these until we support command-mode panels: */
103
static int omap_crtc_dss_connect(struct omap_overlay_manager *mgr,
104
		struct omap_dss_device *dst)
105 106 107 108 109 110 111 112 113 114 115 116 117
{
	if (mgr->output)
		return -EINVAL;

	if ((mgr->supported_outputs & dst->id) == 0)
		return -EINVAL;

	dst->manager = mgr;
	mgr->output = dst;

	return 0;
}

118
static void omap_crtc_dss_disconnect(struct omap_overlay_manager *mgr,
119
		struct omap_dss_device *dst)
120 121 122 123 124
{
	mgr->output->manager = NULL;
	mgr->output = NULL;
}

125
static void omap_crtc_dss_start_update(struct omap_overlay_manager *mgr)
126 127 128
{
}

129
/* Called only from omap_crtc_setup and suspend/resume handlers. */
130 131 132 133 134 135 136 137 138 139 140 141
static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable)
{
	struct drm_device *dev = crtc->dev;
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	enum omap_channel channel = omap_crtc->channel;
	struct omap_irq_wait *wait;
	u32 framedone_irq, vsync_irq;
	int ret;

	if (dispc_mgr_is_enabled(channel) == enable)
		return;

142 143 144 145 146 147 148
	if (omap_crtc->channel == OMAP_DSS_CHANNEL_DIGIT) {
		/*
		 * Digit output produces some sync lost interrupts during the
		 * first frame when enabling, so we need to ignore those.
		 */
		omap_crtc->ignore_digit_sync_lost = true;
	}
149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178

	framedone_irq = dispc_mgr_get_framedone_irq(channel);
	vsync_irq = dispc_mgr_get_vsync_irq(channel);

	if (enable) {
		wait = omap_irq_wait_init(dev, vsync_irq, 1);
	} else {
		/*
		 * When we disable the digit output, we need to wait for
		 * FRAMEDONE to know that DISPC has finished with the output.
		 *
		 * OMAP2/3 does not have FRAMEDONE irq for digit output, and in
		 * that case we need to use vsync interrupt, and wait for both
		 * even and odd frames.
		 */

		if (framedone_irq)
			wait = omap_irq_wait_init(dev, framedone_irq, 1);
		else
			wait = omap_irq_wait_init(dev, vsync_irq, 2);
	}

	dispc_mgr_enable(channel, enable);

	ret = omap_irq_wait(dev, wait, msecs_to_jiffies(100));
	if (ret) {
		dev_err(dev->dev, "%s: timeout waiting for %s\n",
				omap_crtc->name, enable ? "enable" : "disable");
	}

179 180 181 182 183
	if (omap_crtc->channel == OMAP_DSS_CHANNEL_DIGIT) {
		omap_crtc->ignore_digit_sync_lost = false;
		/* make sure the irq handler sees the value above */
		mb();
	}
184 185
}

186

187
static int omap_crtc_dss_enable(struct omap_overlay_manager *mgr)
188
{
189
	struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];
190
	struct omap_overlay_manager_info info;
191

192 193 194 195 196 197 198
	memset(&info, 0, sizeof(info));
	info.default_color = 0x00000000;
	info.trans_key = 0x00000000;
	info.trans_key_type = OMAP_DSS_COLOR_KEY_GFX_DST;
	info.trans_enabled = false;

	dispc_mgr_setup(omap_crtc->channel, &info);
199 200
	dispc_mgr_set_timings(omap_crtc->channel,
			&omap_crtc->timings);
201
	omap_crtc_set_enabled(&omap_crtc->base, true);
202

203 204 205
	return 0;
}

206
static void omap_crtc_dss_disable(struct omap_overlay_manager *mgr)
207
{
208 209
	struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];

210
	omap_crtc_set_enabled(&omap_crtc->base, false);
211 212
}

213
static void omap_crtc_dss_set_timings(struct omap_overlay_manager *mgr,
214 215
		const struct omap_video_timings *timings)
{
216
	struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];
217 218 219 220
	DBG("%s", omap_crtc->name);
	omap_crtc->timings = *timings;
}

221
static void omap_crtc_dss_set_lcd_config(struct omap_overlay_manager *mgr,
222 223
		const struct dss_lcd_mgr_config *config)
{
224
	struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];
225 226 227 228
	DBG("%s", omap_crtc->name);
	dispc_mgr_set_lcd_config(omap_crtc->channel, config);
}

229
static int omap_crtc_dss_register_framedone(
230 231 232 233 234 235
		struct omap_overlay_manager *mgr,
		void (*handler)(void *), void *data)
{
	return 0;
}

236
static void omap_crtc_dss_unregister_framedone(
237 238 239 240 241 242
		struct omap_overlay_manager *mgr,
		void (*handler)(void *), void *data)
{
}

static const struct dss_mgr_ops mgr_ops = {
243 244 245 246 247 248 249 250 251
	.connect = omap_crtc_dss_connect,
	.disconnect = omap_crtc_dss_disconnect,
	.start_update = omap_crtc_dss_start_update,
	.enable = omap_crtc_dss_enable,
	.disable = omap_crtc_dss_disable,
	.set_timings = omap_crtc_dss_set_timings,
	.set_lcd_config = omap_crtc_dss_set_lcd_config,
	.register_framedone_handler = omap_crtc_dss_register_framedone,
	.unregister_framedone_handler = omap_crtc_dss_unregister_framedone,
252 253
};

254
/* -----------------------------------------------------------------------------
255
 * Setup, Flush and Page Flip
256 257
 */

258 259 260
void omap_crtc_cancel_page_flip(struct drm_crtc *crtc, struct drm_file *file)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
261
	struct drm_pending_vblank_event *event;
262 263 264
	struct drm_device *dev = crtc->dev;
	unsigned long flags;

265 266 267 268
	/* Destroy the pending vertical blanking event associated with the
	 * pending page flip, if any, and disable vertical blanking interrupts.
	 */

269 270
	spin_lock_irqsave(&dev->event_lock, flags);

271 272 273 274 275 276
	event = omap_crtc->event;
	omap_crtc->event = NULL;

	if (event && event->base.file_priv == file) {
		event->base.destroy(&event->base);
		drm_crtc_vblank_put(crtc);
277 278 279 280 281
	}

	spin_unlock_irqrestore(&dev->event_lock, flags);
}

282
static void omap_crtc_complete_page_flip(struct drm_crtc *crtc)
283 284
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
285
	struct drm_pending_vblank_event *event;
286
	struct drm_device *dev = crtc->dev;
287
	unsigned long flags;
288

289
	spin_lock_irqsave(&dev->event_lock, flags);
290

291 292
	event = omap_crtc->event;
	omap_crtc->event = NULL;
293

294 295
	if (event) {
		drm_crtc_send_vblank_event(crtc, event);
296
		wake_up(&omap_crtc->flip_wait);
297 298 299 300
		drm_crtc_vblank_put(crtc);
	}

	spin_unlock_irqrestore(&dev->event_lock, flags);
301 302 303 304 305 306 307 308 309 310
}

static bool omap_crtc_page_flip_pending(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	struct drm_device *dev = crtc->dev;
	unsigned long flags;
	bool pending;

	spin_lock_irqsave(&dev->event_lock, flags);
311
	pending = omap_crtc->event != NULL;
312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327
	spin_unlock_irqrestore(&dev->event_lock, flags);

	return pending;
}

static void omap_crtc_wait_page_flip(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);

	if (wait_event_timeout(omap_crtc->flip_wait,
			       !omap_crtc_page_flip_pending(crtc),
			       msecs_to_jiffies(50)))
		return;

	dev_warn(crtc->dev->dev, "page flip timeout!\n");

328
	omap_crtc_complete_page_flip(crtc);
329 330
}

331 332 333 334
static void omap_crtc_error_irq(struct omap_drm_irq *irq, uint32_t irqstatus)
{
	struct omap_crtc *omap_crtc =
			container_of(irq, struct omap_crtc, error_irq);
335 336 337 338 339 340 341

	if (omap_crtc->ignore_digit_sync_lost) {
		irqstatus &= ~DISPC_IRQ_SYNC_LOST_DIGIT;
		if (!irqstatus)
			return;
	}

342
	DRM_ERROR_RATELIMITED("%s: errors: %08x\n", omap_crtc->name, irqstatus);
343 344
}

345
static void omap_crtc_vblank_irq(struct omap_drm_irq *irq, uint32_t irqstatus)
346 347
{
	struct omap_crtc *omap_crtc =
348 349
			container_of(irq, struct omap_crtc, vblank_irq);
	struct drm_device *dev = omap_crtc->base.dev;
350

351 352 353 354 355 356 357
	if (dispc_mgr_go_busy(omap_crtc->channel))
		return;

	DBG("%s: apply done", omap_crtc->name);
	__omap_irq_unregister(dev, &omap_crtc->vblank_irq);

	/* wakeup userspace */
358
	omap_crtc_complete_page_flip(&omap_crtc->base);
359 360

	complete(&omap_crtc->completion);
361 362
}

363
int omap_crtc_flush(struct drm_crtc *crtc)
364
{
365
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
366

367
	DBG("%s: GO", omap_crtc->name);
368

369 370
	WARN_ON(!drm_modeset_is_locked(&crtc->mutex));
	WARN_ON(omap_crtc->vblank_irq.registered);
371

372
	dispc_runtime_get();
373

374 375 376
	if (dispc_mgr_is_enabled(omap_crtc->channel)) {
		dispc_mgr_go(omap_crtc->channel);
		omap_irq_register(crtc->dev, &omap_crtc->vblank_irq);
377

378 379 380 381
		WARN_ON(!wait_for_completion_timeout(&omap_crtc->completion,
						     msecs_to_jiffies(100)));
		reinit_completion(&omap_crtc->completion);
	}
382

383
	dispc_runtime_put();
384 385 386 387

	return 0;
}

388
static void omap_crtc_setup(struct drm_crtc *crtc)
389
{
390
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
391 392 393 394 395 396
	struct omap_drm_private *priv = crtc->dev->dev_private;
	struct drm_encoder *encoder = NULL;
	unsigned int i;

	DBG("%s: enabled=%d", omap_crtc->name, omap_crtc->enabled);

397 398
	dispc_runtime_get();

399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422
	for (i = 0; i < priv->num_encoders; i++) {
		if (priv->encoders[i]->crtc == crtc) {
			encoder = priv->encoders[i];
			break;
		}
	}

	if (omap_crtc->current_encoder && encoder != omap_crtc->current_encoder)
		omap_encoder_set_enabled(omap_crtc->current_encoder, false);

	omap_crtc->current_encoder = encoder;

	if (!omap_crtc->enabled) {
		if (encoder)
			omap_encoder_set_enabled(encoder, false);
	} else {
		if (encoder) {
			omap_encoder_set_enabled(encoder, false);
			omap_encoder_update(encoder, omap_crtc->mgr,
					&omap_crtc->timings);
			omap_encoder_set_enabled(encoder, true);
		}
	}

423
	dispc_runtime_put();
424 425 426 427
}

/* -----------------------------------------------------------------------------
 * CRTC Functions
428 429
 */

430 431 432
static void omap_crtc_destroy(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
433 434 435

	DBG("%s", omap_crtc->name);

436
	WARN_ON(omap_crtc->vblank_irq.registered);
437 438
	omap_irq_unregister(crtc->dev, &omap_crtc->error_irq);

439
	drm_crtc_cleanup(crtc);
440

441 442 443
	kfree(omap_crtc);
}

444 445 446 447 448 449 450 451
static bool omap_crtc_mode_fixup(struct drm_crtc *crtc,
		const struct drm_display_mode *mode,
		struct drm_display_mode *adjusted_mode)
{
	return true;
}

static void omap_crtc_enable(struct drm_crtc *crtc)
452
{
453
	struct omap_drm_private *priv = crtc->dev->dev_private;
454
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
455
	unsigned int i;
456

457
	DBG("%s", omap_crtc->name);
458

459
	if (omap_crtc->enabled)
460
		return;
461

462
	/* Enable all planes associated with the CRTC. */
463 464 465 466
	for (i = 0; i < priv->num_planes; i++) {
		struct drm_plane *plane = priv->planes[i];

		if (plane->crtc == crtc)
467
			WARN_ON(omap_plane_set_enable(plane, true));
468
	}
469

470
	omap_crtc->enabled = true;
471 472 473

	omap_crtc_setup(crtc);
	omap_crtc_flush(crtc);
474

475 476 477
	dispc_runtime_get();
	drm_crtc_vblank_on(crtc);
	dispc_runtime_put();
478 479
}

480
static void omap_crtc_disable(struct drm_crtc *crtc)
481
{
482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507
	struct omap_drm_private *priv = crtc->dev->dev_private;
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	unsigned int i;

	DBG("%s", omap_crtc->name);

	if (!omap_crtc->enabled)
		return;

	omap_crtc_wait_page_flip(crtc);
	dispc_runtime_get();
	drm_crtc_vblank_off(crtc);
	dispc_runtime_put();

	/* Disable all planes associated with the CRTC. */
	for (i = 0; i < priv->num_planes; i++) {
		struct drm_plane *plane = priv->planes[i];

		if (plane->crtc == crtc)
			WARN_ON(omap_plane_set_enable(plane, false));
	}

	omap_crtc->enabled = false;

	omap_crtc_setup(crtc);
	omap_crtc_flush(crtc);
508 509
}

510
static void omap_crtc_mode_set_nofb(struct drm_crtc *crtc)
511 512
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
513
	struct drm_display_mode *mode = &crtc->state->adjusted_mode;
514 515

	DBG("%s: set mode: %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
516 517 518 519 520
	    omap_crtc->name, mode->base.id, mode->name,
	    mode->vrefresh, mode->clock,
	    mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal,
	    mode->vdisplay, mode->vsync_start, mode->vsync_end, mode->vtotal,
	    mode->type, mode->flags);
521 522

	copy_timings_drm_to_omap(&omap_crtc->timings, mode);
523 524
}

525 526
static void omap_crtc_atomic_begin(struct drm_crtc *crtc)
{
527
	struct drm_pending_vblank_event *event = crtc->state->event;
528
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
529
	struct drm_device *dev = crtc->dev;
530
	unsigned long flags;
531

532
	dispc_runtime_get();
533

534 535 536
	if (event) {
		WARN_ON(omap_crtc->event);
		WARN_ON(drm_crtc_vblank_get(crtc) != 0);
537

538 539
		spin_lock_irqsave(&dev->event_lock, flags);
		omap_crtc->event = event;
540
		spin_unlock_irqrestore(&dev->event_lock, flags);
541
	}
542
}
543

544 545 546
static void omap_crtc_atomic_flush(struct drm_crtc *crtc)
{
	omap_crtc_flush(crtc);
547

548
	dispc_runtime_put();
549 550 551

	crtc->invert_dimensions = !!(crtc->primary->state->rotation &
				    (BIT(DRM_ROTATE_90) | BIT(DRM_ROTATE_270)));
552 553
}

554 555 556 557
static int omap_crtc_atomic_set_property(struct drm_crtc *crtc,
					 struct drm_crtc_state *state,
					 struct drm_property *property,
					 uint64_t val)
558
{
559 560 561 562 563 564 565 566 567 568 569 570 571 572
	struct drm_plane_state *plane_state;
	struct drm_plane *plane = crtc->primary;

	/*
	 * Delegate property set to the primary plane. Get the plane state and
	 * set the property directly.
	 */

	plane_state = drm_atomic_get_plane_state(state->state, plane);
	if (!plane_state)
		return -EINVAL;

	return drm_atomic_plane_set_property(plane, plane_state, property, val);
}
573

574 575 576 577 578 579 580 581 582 583 584 585 586
static int omap_crtc_atomic_get_property(struct drm_crtc *crtc,
					 const struct drm_crtc_state *state,
					 struct drm_property *property,
					 uint64_t *val)
{
	/*
	 * Delegate property get to the primary plane. The
	 * drm_atomic_plane_get_property() function isn't exported, but can be
	 * called through drm_object_property_get_value() as that will call
	 * drm_atomic_get_property() for atomic drivers.
	 */
	return drm_object_property_get_value(&crtc->primary->base, property,
					     val);
587 588
}

589
static const struct drm_crtc_funcs omap_crtc_funcs = {
590
	.reset = drm_atomic_helper_crtc_reset,
591
	.set_config = drm_atomic_helper_set_config,
592
	.destroy = omap_crtc_destroy,
593
	.page_flip = drm_atomic_helper_page_flip,
594
	.set_property = drm_atomic_helper_crtc_set_property,
595 596
	.atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
	.atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
597 598
	.atomic_set_property = omap_crtc_atomic_set_property,
	.atomic_get_property = omap_crtc_atomic_get_property,
599 600 601 602
};

static const struct drm_crtc_helper_funcs omap_crtc_helper_funcs = {
	.mode_fixup = omap_crtc_mode_fixup,
603
	.mode_set_nofb = omap_crtc_mode_set_nofb,
604 605
	.disable = omap_crtc_disable,
	.enable = omap_crtc_enable,
606 607
	.atomic_begin = omap_crtc_atomic_begin,
	.atomic_flush = omap_crtc_atomic_flush,
608 609
};

610 611 612
/* -----------------------------------------------------------------------------
 * Init and Cleanup
 */
613

614
static const char *channel_names[] = {
615 616 617 618
	[OMAP_DSS_CHANNEL_LCD] = "lcd",
	[OMAP_DSS_CHANNEL_DIGIT] = "tv",
	[OMAP_DSS_CHANNEL_LCD2] = "lcd2",
	[OMAP_DSS_CHANNEL_LCD3] = "lcd3",
619 620
};

621 622 623 624 625
void omap_crtc_pre_init(void)
{
	dss_install_mgr_ops(&mgr_ops);
}

626 627 628 629 630
void omap_crtc_pre_uninit(void)
{
	dss_uninstall_mgr_ops();
}

631 632
/* initialize crtc */
struct drm_crtc *omap_crtc_init(struct drm_device *dev,
633
		struct drm_plane *plane, enum omap_channel channel, int id)
634 635
{
	struct drm_crtc *crtc = NULL;
636
	struct omap_crtc *omap_crtc;
637
	int ret;
638 639

	DBG("%s", channel_names[channel]);
640

641
	omap_crtc = kzalloc(sizeof(*omap_crtc), GFP_KERNEL);
642
	if (!omap_crtc)
643
		return NULL;
644 645

	crtc = &omap_crtc->base;
646

647
	init_waitqueue_head(&omap_crtc->flip_wait);
648
	init_completion(&omap_crtc->completion);
649

650 651 652
	omap_crtc->channel = channel;
	omap_crtc->name = channel_names[channel];

653 654
	omap_crtc->vblank_irq.irqmask = pipe2vbl(crtc);
	omap_crtc->vblank_irq.irq = omap_crtc_vblank_irq;
655 656 657 658 659 660 661

	omap_crtc->error_irq.irqmask =
			dispc_mgr_get_sync_lost_irq(channel);
	omap_crtc->error_irq.irq = omap_crtc_error_irq;
	omap_irq_register(dev, &omap_crtc->error_irq);

	/* temporary: */
662
	omap_crtc->mgr = omap_dss_get_overlay_manager(channel);
663

664 665 666 667 668 669 670
	ret = drm_crtc_init_with_planes(dev, crtc, plane, NULL,
					&omap_crtc_funcs);
	if (ret < 0) {
		kfree(omap_crtc);
		return NULL;
	}

671 672
	drm_crtc_helper_add(crtc, &omap_crtc_helper_funcs);

673
	omap_plane_install_properties(crtc->primary, &crtc->base);
674

675 676
	omap_crtcs[channel] = omap_crtc;

677 678
	return crtc;
}